--- Log opened Fri Jun 05 00:00:41 2020
00:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:00 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #13389: Utils and libraries: Fix #13371 - move umask operation earlier in AppInit() (master...13371) https://github.com/bitcoin/bitcoin/pull/13389
00:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:16 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds]
00:17 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 272 seconds]
00:18 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
00:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:19 < bitcoin-git> [bitcoin] jonasschnelli pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/4ede05d421e7...7f9800caf90d
00:19 < bitcoin-git> bitcoin/master f30960a João Barbosa: gui: Add closeAllWallets to WalletController
00:19 < bitcoin-git> bitcoin/master c4b5748 João Barbosa: gui: Add Close All Wallets action
00:19 < bitcoin-git> bitcoin/master 7f9800c Jonas Schnelli: Merge #15202: gui: Add Close All Wallets action
00:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:20 < bitcoin-git> [bitcoin] jonasschnelli merged pull request #15202: gui: Add Close All Wallets action (master...2019-01-closeallwallets) https://github.com/bitcoin/bitcoin/pull/15202
00:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:26 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7f9800caf90d...f4f222045693
00:26 < bitcoin-git> bitcoin/master f46b678 Vasil Dimov: qt: lock cs_main, m_cached_tip_mutex in that order
00:26 < bitcoin-git> bitcoin/master f4f2220 Jonas Schnelli: Merge #19132: qt: lock cs_main, m_cached_tip_mutex in that order
00:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:26 < bitcoin-git> [bitcoin] jonasschnelli merged pull request #19132: qt: lock cs_main, m_cached_tip_mutex in that order (master...lock_order_m_cached_tip_mutex) https://github.com/bitcoin/bitcoin/pull/19132
00:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:55 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection]
00:55 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev
01:08 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
01:13 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
01:15 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 246 seconds]
01:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:18 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f4f222045693...b55b5b6c3d93
01:18 < bitcoin-git> bitcoin/master fa7e002 MarcoFalke: ci: tsan with wallet
01:18 < bitcoin-git> bitcoin/master b55b5b6 fanquake: Merge #19164: ci: tsan with wallet
01:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:18 < bitcoin-git> [bitcoin] fanquake merged pull request #19164: ci: tsan with wallet (master...2006-ciTsanWallet) https://github.com/bitcoin/bitcoin/pull/19164
01:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:20 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
01:26 -!- kljasdfvv [~flack@p200300d46f11fb005963d7eae17176c4.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!]
01:28 -!- kljasdfvv [~flack@p200300d46f11fb0050d8dff47640a9a8.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
01:35 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
01:35 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
01:56 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 272 seconds]
02:00 -!- porygon2 [~porygon2@195.206.169.238] has quit []
02:11 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection]
02:21 -!- Eric-K [~Eric-K@84.39.116.180] has joined #bitcoin-core-dev
02:21 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev
02:27 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection]
02:27 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev
02:53 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 265 seconds]
02:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:54 < bitcoin-git> [bitcoin] vasild opened pull request #19173: build: turn on --enable-c++17 by --enable-fuzz (master...enable_c++17_by_fuzz) https://github.com/bitcoin/bitcoin/pull/19173
02:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:00 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev
03:03 -!- Amara54King [~Amara54Ki@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev
03:09 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 246 seconds]
03:10 -!- Amara54King [~Amara54Ki@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 246 seconds]
03:13 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has joined #bitcoin-core-dev
03:20 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev
03:25 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev
03:39 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
03:42 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection]
03:48 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev
04:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:17 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b55b5b6c3d93...aa35ea55021d
04:17 < bitcoin-git> bitcoin/master 0012471 Vasil Dimov: build: turn on --enable-c++17 by --enable-fuzz
04:17 < bitcoin-git> bitcoin/master aa35ea5 MarcoFalke: Merge #19173: build: turn on --enable-c++17 by --enable-fuzz
04:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:17 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19173: build: turn on --enable-c++17 by --enable-fuzz (master...enable_c++17_by_fuzz) https://github.com/bitcoin/bitcoin/pull/19173
04:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:21 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Quit: jonatack]
04:26 -!- baldur [~baldur@pool-173-56-240-14.nycmny.fios.verizon.net] has quit [Ping timeout: 265 seconds]
04:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:30 < bitcoin-git> [bitcoin] theStack opened pull request #19174: refactor: replace CConnman/BanMan pointers by references in net_processing.cpp (master...20200602-refactor-use-cconnman-references-within-net_processing) https://github.com/bitcoin/bitcoin/pull/19174
04:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:36 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 260 seconds]
04:38 -!- baldur [~baldur@pool-173-56-240-14.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
04:39 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev
04:45 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has joined #bitcoin-core-dev
04:58 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
05:00 -!- Eric-K [~Eric-K@84.39.116.180] has quit []
05:20 -!- porvak [~porvak@178.162.204.238] has joined #bitcoin-core-dev
05:24 -!- Genoveva89Bauch [~Genoveva8@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev
05:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:30 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/aa35ea55021d...0fc6ea216c00
05:30 < bitcoin-git> bitcoin/master e783197 Russell Yanofsky: refactor: replace RegisterWalletRPCCommands with GetWalletRPCCommands
05:30 < bitcoin-git> bitcoin/master 4a7253a Russell Yanofsky: Remove g_rpc_chain global
05:30 < bitcoin-git> bitcoin/master 0fc6ea2 MarcoFalke: Merge #19096: Remove g_rpc_chain global
05:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:31 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19096: Remove g_rpc_chain global (master...pr/wc) https://github.com/bitcoin/bitcoin/pull/19096
05:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:32 < bitcoin-git> [bitcoin] laanwj opened pull request #19176: refactor: Error message bilingual_str consistency  (master...2020_06_bilingual_str) https://github.com/bitcoin/bitcoin/pull/19176
05:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:34 -!- Genoveva89Bauch [~Genoveva8@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 272 seconds]
05:54 < wumpus> it was a pretty nifty idea to make _() return a struct with both the original message and the translated one, good use of type safety
05:57 -!- Highway61 [~Thunderbi@209.95.56.134] has joined #bitcoin-core-dev
06:04 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
06:14 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
06:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:20 < bitcoin-git> [bitcoin] troygiorshev opened pull request #19177: p2p: Fix and clean p2p_invalid_messages functional tests (master...p2p-refactor-fix-tests) https://github.com/bitcoin/bitcoin/pull/19177
06:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:59 -!- Highway62 [~Thunderbi@ip72-204-155-64.no.no.cox.net] has joined #bitcoin-core-dev
06:59 -!- Highway61 [~Thunderbi@209.95.56.134] has quit [Ping timeout: 246 seconds]
06:59 -!- Highway62 is now known as Highway61
07:16 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 272 seconds]
07:16 -!- ovovo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
07:28 < vasild> I prepared a code coverage report for a PR, highlighting the lines that were modifeid by the PR: https://people.freebsd.org/~vd/pr19031_coverage_of_modified_code/src/netaddress.cpp.gcov.html#153 (or rather, the lines that are not touched by the change are dimmed).
07:28 < gribble> https://github.com/bitcoin/bitcoin/issues/153 | rfc1123Time locale fix. by gavinandresen · Pull Request #153 · bitcoin/bitcoin · GitHub
07:28 < vasild> This answers the question "how much of the code modified by a given PR is covered by tests?"
07:29 < vasild> MarcoFalke: jonatack: ^ a few days ago we discussed this. Yes, it has the deficiency that if the PR caused the coverage to drop in some file that is not modified by the PR, that will not be shown.
07:31 < vasild> Anyway this is still useful - as long as there are bright red lines (not covered and modified by the change) this means writing more tests is warranted.
07:33 < vasild> Or at least some extra attention during review because some of the modified code is not tested.
07:46 -!- davterra [~dulyNoded@104.140.18.131] has joined #bitcoin-core-dev
07:49 -!- LarryRuane [62f5cc94@c-98-245-204-148.hsd1.co.comcast.net] has quit [Remote host closed the connection]
08:00 -!- porvak [~porvak@178.162.204.238] has quit []
08:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:03 < bitcoin-git> [bitcoin] jnewbery opened pull request #19178: Make mininode_lock non-reentrant (master...2020-05-mininode-lock-reentrancy) https://github.com/bitcoin/bitcoin/pull/19178
08:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:09 < jonatack> vasild: nice, how did you generate it
08:11 -!- cltrbreak_MAD2 [~ctrlbreak@159.2.182.106] has quit [Remote host closed the connection]
08:11 -!- cltrbreak_MAD2 [~ctrlbreak@159.2.182.106] has joined #bitcoin-core-dev
08:13 < vasild> jonatack: I used some python library to parse the generated HTML report and apply "opacity: 0.2;" to some lines
08:15 < vasild> I will clean up a bit the scripts and put them on github
08:16 -!- cltrbreak_MAD2 is now known as ctrlbreak
08:17 -!- barrydingles [~barryd@119.175.75.34.bc.googleusercontent.com] has quit [Remote host closed the connection]
08:21 -!- Limnoria1 [~Limnoria@84.39.116.180] has joined #bitcoin-core-dev
08:30 -!- ctrlbreak [~ctrlbreak@159.2.182.106] has quit [Read error: Connection reset by peer]
08:31 -!- ctrlbreak [~ctrlbreak@159.2.182.106] has joined #bitcoin-core-dev
08:44 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Remote host closed the connection]
08:50 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
09:05 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev
09:09 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
09:09 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
09:15 -!- ovovo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 272 seconds]
09:20 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
09:20 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
09:21 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 246 seconds]
09:22 -!- kljasdfvv [~flack@p200300d46f11fb0050d8dff47640a9a8.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!]
09:23 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
09:23 -!- vasild_ is now known as vasild
09:24 -!- Highway62 [~Thunderbi@104.223.94.122] has joined #bitcoin-core-dev
09:25 -!- Highway61 [~Thunderbi@ip72-204-155-64.no.no.cox.net] has quit [Ping timeout: 256 seconds]
09:25 -!- Highway62 is now known as Highway61
09:33 -!- ctrlbreak [~ctrlbreak@159.2.182.106] has quit [Remote host closed the connection]
09:33 -!- ctrlbreak [~ctrlbreak@159.2.182.106] has joined #bitcoin-core-dev
09:38 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
09:39 -!- Kiminuo [~mix@141.98.103.92] has joined #bitcoin-core-dev
09:50 -!- Deinogalerix21 [~Deinogale@185.125.207.151] has joined #bitcoin-core-dev
09:56 -!- Deinogalerix21 [~Deinogale@185.125.207.151] has quit [Quit: WeeChat 2.8]
10:00 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has quit [Quit: Leaving]
10:14 < luke-jr> fanquake: #19152 might be a backport canddiate
10:14 < gribble> https://github.com/bitcoin/bitcoin/issues/19152 | build: improve build OS configure output by skmcontrib · Pull Request #19152 · bitcoin/bitcoin · GitHub
10:17 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Remote host closed the connection]
10:18 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev
10:18 < MarcoFalke> vasild: Nice. The "not hit, modified" is probably the most important to look out in review
10:18 < MarcoFalke> Happy to throw the script on DrahtBot once it is open source
10:23 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
10:23 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Ping timeout: 272 seconds]
10:25 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds]
10:27 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev
10:29 < MarcoFalke> wumpus: sipa: Would it be possible to enable cirrus ci for testing purposed on the bitcoin/bitcoin repo?
10:30 < MarcoFalke> I am using them on my personal repos for more than a year and it works a lot nicer than travis
10:31 < MarcoFalke> I sent an email to travis and they said that s390x and arm are "unsupported", so I think we should move on instead of throwing money at them to only reply to us that our use case is unsupported
10:32 < sipa> MarcoFalke: happy to enable it; what does cirrus offer?
10:32 < MarcoFalke> https://cirrus-ci.org/features/
10:32 -!- LarryRuane [62f5cc94@c-98-245-204-148.hsd1.co.comcast.net] has joined #bitcoin-core-dev
10:32 < MarcoFalke> 10 parallel builds for free
10:33 < MarcoFalke> Up to 8 cores, 8GB of RAM
10:33 < MarcoFalke> To get the same on travis with 2 CPU and 4 GB, we pay them thousands of dollars per year
10:34 < sipa> heh
10:34 < sipa> MarcoFalke: approved
10:34 < sipa> github has pretty selective permissions apparently; this just needs read access to commits etc, and write access to the check status
10:35 -!- jarthur [~jarthur@2605:6000:1019:4971:59f9:8f72:d240:fa7d] has joined #bitcoin-core-dev
10:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:35 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #19078: test: Add salvage test for wallet tool (master...2005-testWalletToolSalvage) https://github.com/bitcoin/bitcoin/pull/19078
10:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:35 < bitcoin-git> [bitcoin] MarcoFalke reopened pull request #19078: test: Add salvage test for wallet tool (master...2005-testWalletToolSalvage) https://github.com/bitcoin/bitcoin/pull/19078
10:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:38 < phantomcircuit> sipa, historically the github permissions were super vague "read" "write" glad to see that's improving
10:39 < sipa> specifically:
10:39 < sipa> * Read access to code 
10:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:39 < bitcoin-git> [bitcoin] DrahtBot closed pull request #19078: test: Add salvage test for wallet tool (master...2005-testWalletToolSalvage) https://github.com/bitcoin/bitcoin/pull/19078
10:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:39 < sipa> * Read access to files located at .cirrus.yml
10:39 < sipa> * Read access to members, metadata, and pull requests 
10:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:39 < bitcoin-git> [bitcoin] DrahtBot reopened pull request #19078: test: Add salvage test for wallet tool (master...2005-testWalletToolSalvage) https://github.com/bitcoin/bitcoin/pull/19078
10:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:39 < sipa> * Read and write access to checks, commit statuses, and content references
10:40 < sipa> * Write access to attach content to the following external domain: cirrus-ci.com
10:40 < phantomcircuit> yeah that's much better than it used to be, presumably for exactly this reason
10:40 < sipa> i'm impressed it's so fine-grained
10:42 < MarcoFalke> sipa: thx!
10:46 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Quit: leaving]
10:47 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Quit: Leaving...]
10:48 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev
10:49 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev
11:00 -!- Limnoria1 [~Limnoria@84.39.116.180] has quit []
11:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:07 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #19179: [WIP RFC DONOTMERGE] ci: Run ci configs on cirrus (master...2006-ciCirrus) https://github.com/bitcoin/bitcoin/pull/19179
11:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:20 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Quit: leaving]
11:21 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev
11:22 -!- patryk1 [~patryk@185.204.1.185] has joined #bitcoin-core-dev
11:24 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Client Quit]
11:25 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev
11:35 -!- LarryRuane [62f5cc94@c-98-245-204-148.hsd1.co.comcast.net] has quit [Remote host closed the connection]
11:41 -!- ctrlbreak [~ctrlbreak@159.2.182.106] has quit [Remote host closed the connection]
11:41 -!- ctrlbreak [~ctrlbreak@159.2.182.106] has joined #bitcoin-core-dev
11:58 < fanquake> luke-jr: can do
12:00 < achow101> wallet meeting?
12:01 < provoostenator> I'm around, briefly
12:02 < achow101> meshcollider doesn't seem to be here
12:02 < achow101> #startmeeting
12:02 < lightningbot> Meeting started Fri Jun  5 19:02:25 2020 UTC.  The chair is achow101. Information about MeetBot at http://wiki.debian.org/MeetBot.
12:02 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
12:02 < achow101> any topics?
12:03 < provoostenator> HWW?
12:03 < achow101> one thing I would like to discuss is whether we should change our signer policy for PSBTs
12:03 < jonatack> hi
12:03 < provoostenator> I haven't done much other than rebase, but happy to answer questions
12:03 < provoostenator> Oh yeah, that's a good one.
12:04 < luke-jr> achow101: presumably with a synced node, we can access the full input tx?
12:04 < achow101> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james amiti fjahr jeremyrubin lightlike 
12:04 < achow101> emilengler jonatack hebasto jb55 elichai2
12:04 < fjahr> hi
12:04 < sipa> having thought about it more, i'm not sure it's worth requiring full input txn
12:05 < achow101> #topic HWW (provoostenator)
12:05 < achow101> any updates on that?
12:05 < achow101> FYI meshcollider broke is IRC and can't send messages
12:05 < provoostenator> The first PR for that is #15382 
12:05 < gribble> https://github.com/bitcoin/bitcoin/issues/15382 | util: add runCommandParseJSON by Sjors · Pull Request #15382 · bitcoin/bitcoin · GitHub
12:05 < sipa> given that the same attack model (software wallet malicious, able to make the vixtim sign twice with hww) already enables the attacker to e.g. be paid twice
12:06 < provoostenator> And the meat is in #16546
12:06 < gribble> https://github.com/bitcoin/bitcoin/issues/16546 | External signer support - Wallet Box edition by Sjors · Pull Request #16546 · bitcoin/bitcoin · GitHub
12:06 < achow101> so just review those?
12:07 < provoostenator> achow101: yup
12:07 < provoostenator> At least as a start.
12:07 < achow101> cool
12:07 < achow101> anything you wanted to discuss right now?
12:08 < provoostenator> There's also some dependencies
12:08 < provoostenator> But I think those two PR's can be reviewed mostly without worrying about these other dependencies. Just go for them if you're bored.
12:08 < provoostenator> Nothing specific to discuss.
12:09 < phantomcircuit> hi
12:09 -!- meshcoll- [meshcollid@gateway/shell/ircnow/x-jmtxdaapnvwvysok] has quit [Quit: ZNC 1.7.4 - https://znc.in]
12:09 < achow101> alright
12:10 < achow101> #topic Changing PSBT signer policy (achow101)
12:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:10 < bitcoin-git> [bitcoin] hebasto opened pull request #19180: refactor: Replace RecursiveMutex with Mutex in Shutdown() (master...200605-shutdown) https://github.com/bitcoin/bitcoin/pull/19180
12:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:10 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-jaqsmospkdyaosri] has joined #bitcoin-core-dev
12:10 < achow101> So there was the whole announcement from trezor 2 days ago about the thing in segwit where a signer could be tricked into sending money into fees
12:11 < achow101> and they're requiring full prevtxs (i.e. non_witness_utxo) for segwit inputs
12:11 < achow101> do we want to do the same policy to protect against that attack?
12:11 < meshcollider> ping
12:11 < provoostenator> A less drastic measure could be for the device to remember the last couple of inputs it signed?
12:11 < achow101> meshcollider: pong
12:11 < achow101> it seems that sipa doesn't think so
12:12 < sipa> provoostenator: i'd say that's far more drastic, but it's also the only real solution
12:12 < meshcollider> Yay it's working finally
12:12 < meshcollider> Sorry about that
12:12 < achow101> provoostenator: I think that would require more storage than they have
12:12 < luke-jr> sipa: why is just including the inputs not a solution?
12:13 < sipa> luke-jr: that doesn't prevent double paying
12:13 < provoostenator> Not having giant PSBT files was a nice improvement...
12:13 < sipa> luke-jr: it prevents this specific attack
12:13 < sipa> but it doesn't prevent the victim fr being told "your signature is invalid, try again" and then just paying the attacker twice
12:14 < luke-jr> well, that's social engineering
12:14 < achow101> sipa: but that would be new inputs, so remembering previous inputs wouldn't matter
12:14 < luke-jr> achow101: remembering the address could
12:14 < luke-jr> ie, strictly forbid address reuse
12:14 < luke-jr> but social engineers can probably work around that too
12:15 < provoostenator> So the attack mentioned, it doesn't matter who you were paying to? Or does the attacker have to be the recipient?
12:15 < sipa> luke-jr: right, it is - but my point is that if "attacker can convince the victim to sign twice" is part of the threat model, then this attack isn't the only problem
12:15 < luke-jr> hmm, true
12:15 < sipa> and this specific attack can be worked around, but others can't be with stateless HWW
12:15 < achow101> provoostenator: it doesn't matter. the amount lost was going to fees
12:16 < provoostenator> Right, so I don't think a spend-twice bug is fully comparable
12:16 < luke-jr> the recipient does need to be the same address, though, right?
12:16 < gwillen> that depends on whether the victim is looking at the address
12:16 < sipa> for the currently-discussed attack, yes
12:16 < gwillen> we're already positing they're signing twice even though they're only sending one transaction, so it's already got a social engineering component
12:16 < provoostenator> If the victim doesn't look at the address, they're toast regardless.
12:17 < gwillen> but, this is true, "oops please retry" is a much smaller social-engineering ask
12:17 < sipa> gwillen: than what?
12:17 < provoostenator> Once your computer has the kind of the malware that can do that, it can do so many things...
12:17 < luke-jr> deterministic input sorting could fix this too I think?
12:17 < sipa> luke-jr: i don't think so
12:18 < provoostenator> It can fool your browser, fool the UI of your wallet where you "check"  the address, mess with clipboard, alter the chain on disk.
12:18 < luke-jr> provoostenator: but otoh, malware on your comnputer is what hw wallets claim to protect against
12:18 < provoostenator> luke-jr: they do, but only to a limited extend
12:18 < provoostenator> They can't trivially run off with your private keys
12:18 < achow101> this attack already has a strong social engineering component in convincing the user to sign twice
12:18 < provoostenator> But if you just let someone take over your computer long enough..
12:20 < provoostenator> Would it help to store block height as a nonce?
12:20 < gwillen> achow101: people are used to things like that, though, so I think most people unaware of the attack would fall for it, even if they're otherwise careful
12:20 < provoostenator> nLockTime I mean
12:20 < gwillen> (for example, you would have to do that if USB flaked out, probably)
12:21 < gwillen> the coldcard has a big advantage if you're having to carry the transaction across by hand each time vs just spitting it over USB
12:21 < gwillen> this attack really does not work in that setting
12:22 < sipa> i think the only feasible solution is education really
12:22 < sipa> of course fixing this specific bug is a good thing of it comes at no cost
12:22 < sipa> but i'm unconvinced breaking "only need utxo to sign" is worth it
12:23 < achow101> sipa: education as in educating users they should inspect their transactions before sending?
12:23 < sipa> that they should be wary if they're told to retry signimg
12:23 < provoostenator> For the RPC it's cheap to add an opt-in feature to fill in the UTXO for SegWit, for GUI I would find it cluttery.
12:23 < sipa> oh we should add the full input tx where possible, i think
12:23 < sipa> for bitcoin core this is easy to do
12:24 < achow101> to be compatible with latest firmwares that fix this, we still need to add the full input tx
12:24 < sipa> but i'm not sure about requiring full input tx when signing
12:24 < luke-jr> add it, but don't require it to sign
12:24 < achow101> this does break compatibility with previous versions of Core and HWI
12:24 < luke-jr> is I think what sipa's saying
12:24 < achow101> right
12:24 < sipa> indeed
12:24 < achow101> ack
12:25 < sipa> unless we can get trezor to reverse their stance
12:25 < sipa> which seems unlikely
12:25 < luke-jr> it may be more likely than you assume
12:25 < achow101> i believe trezor, ledger, bitbox, and coldcard have/will have the same requirement to provide the full previous tx
12:26 < luke-jr> it's *possible* (but not certain) that the motive is to get another security fix released without drawing attention to it
12:26 < sipa> if that happens we have no choicw to follow suit
12:26 < achow101> although I think ledger does something where they allow single input segwit without full prevtx
12:26 < sipa> +but
12:26 < gwillen> achow101: I was under the impression that hww other than trezor were making this a user option at most
12:27 < achow101> gwillen: i've been working through a bunch of trezor issues over the past couple of days, so I havnen't had the change to test out ledger's changes
12:27 < achow101> coldcard hasn't published a new firmware yet but I'm told they probably will
12:27 < jonatack> luke-jr: not entirely implausible given how it was handled
12:28 < achow101> luke-jr: then they did a real poor job of it by giving users a good reason to not upgrade.
12:29 < luke-jr> achow101: are users getting that impression?
12:29 < jonatack> makes 2 recent trezor upgrades now that were better to avoid 
12:29 < achow101> luke-jr: yes. electrum, wasabi, and btcpay server no longer work with the new firmware. so users who want to keep using those software with their trezors are incentivized to not upgrade
12:30 < provoostenator> What happens when you do add the full input tx, and give it to an non-upgrade hardware wallet?
12:30 < achow101> provoostenator: usually they're fine with it. but HWI makes some assumptions about that so it makes the wrong signature
12:31 < provoostenator> Updating HWI is probably the easiest part.
12:31 < sipa> i have to run for a bit, will be back in 10-15 or so
12:31 < achow101> provoostenator: you would think so....
12:31 < provoostenator> Even if we added support for this, it'd be a while before a release / backport.
12:32 < achow101> right
12:32 < luke-jr> provoostenator: that's up to us
12:32 < provoostenator> True
12:33 < achow101> any other topics?
12:35 < achow101> seems not
12:35 < achow101> #endmeeting
12:36 < lightningbot> Meeting ended Fri Jun  5 19:36:00 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
12:36 < lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-06-05-19.02.html
12:36 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-06-05-19.02.txt
12:36 < lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-06-05-19.02.log.html
12:36 < meshcollider> Thanks achow101 
12:41 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has joined #bitcoin-core-dev
12:45 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev
13:05 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Remote host closed the connection]
13:15 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev
13:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:22 < bitcoin-git> [bitcoin] fjahr opened pull request #19181: Add ASM optimizations for MuHash3072 (master...csi-4-muhash-asm) https://github.com/bitcoin/bitcoin/pull/19181
13:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:27 < ja> fjahr: are the comments for the two versions of mulnadd3 supposed to be dufferent?
13:29 < ja> fjahr: why not bind 1103717 as a macro?
13:32 -!- ctrlbreak [~ctrlbreak@159.2.182.106] has quit [Remote host closed the connection]
13:32 -!- ctrlbreak [~ctrlbreak@159.2.182.106] has joined #bitcoin-core-dev
13:37 < fjahr> ja: thanks, I will need to look into it tomorrow. Would you mind commenting in the PR? Would be great to have these conversations there so they don't get lostt :)
13:39 < sipa> fjahr: the asm comment is wrong
13:40 < sipa> c2 is assumed to be 0 at entry
13:40 < sipa> not c0
13:40 < fjahr> ok, will fix that
13:41 < sipa> you can see that c0 is used as input and output
13:41 < sipa> but c2 is only ever assigned to
13:46 < fjahr> sipa: any comment on making 1103717 a macro? :)
13:50 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Quit: ZNC 1.7.5 - https://znc.in]
13:51 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!]
13:51 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev
13:54 < sipa> fjahr: yeah that would make sense
13:55 < ja> do you want comments on only the ASM PR? or both?
13:58 < fjahr> ja: I can make the changes and document it as well, no worries. Just in general it would be great of have in github so it's documented :)
13:58 < fjahr> ja: thanks for reviewing!
14:00 -!- patryk1 [~patryk@185.204.1.185] has quit []
14:02 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 246 seconds]
14:03 < promag> luke-jr: re https://github.com/bitcoin/bitcoin/pull/19117#issuecomment-639611634
14:04 < promag> > Knots for example has many RPCs before they're available in Core
14:04 < promag> so?
14:05 < promag> you mean that the client should be unaware if the server is core or knots?
14:05 < luke-jr> promag: I mean it shouldn't artificially fail because of "too old version" if the server actually supports the RPCs it needs
14:06 < luke-jr> Knots is just one example
14:07 < luke-jr> I could very well see someone using stable/older bitcoind backporting specific features they need
14:07 < promag> for any specific version (core@x.x.x for instance) you know what is supported
14:07 < luke-jr> promag: not usually
14:07 < promag> no?
14:07 < luke-jr> promag: the client author would need to study each RPC server version/variant, and can never account for private backports
14:08 < promag> but how does feature discovery help there?
14:09 < promag> only difference is requesting that info from the server VS having that info on client side based on server version
14:09 < luke-jr> promag: if you backport foobar method, help() and potentially getrpcwhitelist() will tell you foobar is supported
14:10 < promag> the client should know that if he updates server from 1.1.2 to 1.1.3 then foobar is available
14:10 < luke-jr> no, it shouldn't
14:10 < luke-jr> and someone might have 1.1.2 with foobar
14:11 < promag> luke-jr: how?
14:11 < luke-jr> backporting it
14:11 < promag> custom build?
14:11 < luke-jr> yes
14:11 < promag> oh!!!!
14:12 < promag> well in that case HE knows what's available, it's his own version X)
14:12 < luke-jr> he shouldn't need to modify whatever client he's using
14:12 < luke-jr> client software should just work if the feature is available
14:13 < promag> ok, but you think that info should provided along with the rpc whitelist ?
14:14 < sipa> i don't understand what prompted this discussion
14:14 < sipa> Kixunil was completely confused about what the PR was about
14:14 < luke-jr> promag: MarcoFalke's argument is that help() works already
14:15 < luke-jr> sipa: Kixunil?
14:15 < promag> sipa: right
14:15 < luke-jr> promag: using getrpcwhitelist would avoid whitelist-triggered errors
14:15 < sipa> luke-jr: you're responding to promag, who was responding to Kixunil on the PR
14:15 < luke-jr> promag: ie, using help() means clients need to check *both* help AND rpcwhitelist
14:15 < promag> luke-jr: let me find one issue with a problem with that approach
14:16 < luke-jr> sipa: Kixunil's idea makes sense to me
14:16 < luke-jr> perhaps the method name should be changed :P
14:17 < sipa> ok, but it seems unrelated to this PR
14:17 < sipa> versioning RPCs seems like a very generic topic
14:17 < promag> luke-jr: see OP https://github.com/bitcoin/bitcoin/issues/11589
14:17 < luke-jr> sipa: someone asked why "methods" shold be extensible
14:17 < promag> re feature detection
14:18 < luke-jr> promag: hmm
14:18 < promag> but re getrpcwhitelist... I think we could extend to getrpccredentials that could return whitelist, blacklist, fooo...
14:18 < luke-jr> I wonder if listfeatures (tentative new RPC name) should omit wallet-required RPCs when no wallet is specificed
14:21 -!- pntbr [~pntbr@217.138.204.90] has joined #bitcoin-core-dev
14:22 -!- dfmb_ [~dfmb_@unaffiliated/dfmb/x-4009105] has quit [Quit: Leaving]
14:23 < promag> only API that I remember where I had to discover features was opengl + extensions
14:23 < promag> also js stuff on the different browsers
14:23 < promag> pita
14:24 < promag> it's much easier to target a server version and stick to it.. then update client if server is updated
14:36 -!- Kiminuo [~mix@141.98.103.92] has quit [Ping timeout: 256 seconds]
14:40 < luke-jr> promag: just assuming the features are available and documenting a minimum supported server makes sense; but checking the version in software does not.
14:44 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev
14:44 -!- filchef [~filchef@212.104.97.177] has quit [Client Quit]
14:47 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
14:58 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
15:00 < phantomcircuit> right so the linker is complaining about using static member functions in blockfilter.h in wallet/wallet.cpp
15:01 < phantomcircuit> is there some magic i need to do to make that work?
15:14 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
15:15 -!- takinbo [~takinbo@unaffiliated/takinbo] has quit [Ping timeout: 272 seconds]
15:16 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
15:17 -!- takinbo [~takinbo@merkle.akinbo.org] has joined #bitcoin-core-dev
15:17 -!- takinbo [~takinbo@merkle.akinbo.org] has quit [Changing host]
15:17 -!- takinbo [~takinbo@unaffiliated/takinbo] has joined #bitcoin-core-dev
15:17 < luke-jr> phantomcircuit: GCC 10?
15:20 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 246 seconds]
15:24 -!- marcoagner [~user@bl13-226-166.dsl.telepac.pt] has quit [Ping timeout: 256 seconds]
15:26 < phantomcircuit> luke-jr, 8.3
15:27 < luke-jr> oh, because it's the wallet module
15:28 < luke-jr> wallet doesn't necessarily have block filters
15:28 < luke-jr> gotta go through the interfaces/ stuff IIRC
15:28 -!- Highway61 [~Thunderbi@104.223.94.122] has quit [Ping timeout: 260 seconds]
15:29 -!- takinbo [~takinbo@unaffiliated/takinbo] has quit [Quit: No Ping reply in 180 seconds.]
15:30 -!- takinbo [~takinbo@static.88-198-91-246.clients.your-server.de] has joined #bitcoin-core-dev
15:30 -!- takinbo [~takinbo@static.88-198-91-246.clients.your-server.de] has quit [Changing host]
15:30 -!- takinbo [~takinbo@unaffiliated/takinbo] has joined #bitcoin-core-dev
15:33 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
15:39 -!- jarthur [~jarthur@2605:6000:1019:4971:59f9:8f72:d240:fa7d] has quit []
15:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:49 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #19183: [WIP DONOTMERGE] Replace boost with C++17 (master...2005-StdVariantScriptedDiff) https://github.com/bitcoin/bitcoin/pull/19183
15:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:52 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 246 seconds]
16:30 -!- Highway61 [~Thunderbi@104.223.94.122] has joined #bitcoin-core-dev
16:33 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
16:38 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Remote host closed the connection]
16:58 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Quit: This computer has gone to sleep]
16:58 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev
17:00 -!- pntbr [~pntbr@217.138.204.90] has quit []
17:18 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Ping timeout: 260 seconds]
17:18 -!- ctrlbreak [~ctrlbreak@159.2.182.106] has quit [Remote host closed the connection]
17:19 -!- ctrlbreak [~ctrlbreak@159.2.182.106] has joined #bitcoin-core-dev
17:21 -!- peeja [~peeja@84.39.116.180] has joined #bitcoin-core-dev
17:26 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
17:29 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds]
17:31 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev
17:41 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Quit: This computer has gone to sleep]
17:49 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 246 seconds]
17:50 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
17:55 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev
17:58 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Client Quit]
17:58 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev
18:07 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit []
18:38 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Quit: This computer has gone to sleep]
18:46 -!- jarthur [~jarthur@2605:6000:1019:4971:5045:3ca9:a311:cbb4] has joined #bitcoin-core-dev
19:14 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev
19:19 -!- jarthur [~jarthur@2605:6000:1019:4971:5045:3ca9:a311:cbb4] has quit [Ping timeout: 246 seconds]
19:23 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Ping timeout: 260 seconds]
19:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:27 < bitcoin-git> [bitcoin] sipa opened pull request #19184: Overhaul transaction request logic (master...202004_txrequest_rand) https://github.com/bitcoin/bitcoin/pull/19184
19:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
19:31 -!- jarthur [~jarthur@2605:6000:1019:4971:813b:305d:a97a:b0aa] has joined #bitcoin-core-dev
20:00 -!- peeja [~peeja@84.39.116.180] has quit []
20:05 -!- pi [~pi@cpe-66-65-53-52.nyc.res.rr.com] has joined #bitcoin-core-dev
20:10 -!- pi [~pi@cpe-66-65-53-52.nyc.res.rr.com] has quit [Quit: WeeChat 2.3]
20:21 -!- sendak [~sendak@195.206.183.79] has joined #bitcoin-core-dev
20:33 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
20:35 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
20:36 -!- shesek [~shesek@185.3.145.28] has joined #bitcoin-core-dev
20:36 -!- shesek [~shesek@185.3.145.28] has quit [Changing host]
20:36 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
20:36 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 240 seconds]
20:47 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev
20:52 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Ping timeout: 246 seconds]
21:20 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
21:23 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev
21:23 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
21:23 -!- vasild_ is now known as vasild
21:27 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection]
21:28 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Ping timeout: 272 seconds]
21:34 -!- Highway61 [~Thunderbi@104.223.94.122] has quit [Ping timeout: 246 seconds]
21:35 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev
22:00 -!- Highway61 [~Thunderbi@104.223.94.122] has joined #bitcoin-core-dev
23:00 -!- sendak [~sendak@195.206.183.79] has quit []
23:20 -!- tryphe_ is now known as tryphe
23:21 -!- langseth1 [~langseth@185.189.114.11] has joined #bitcoin-core-dev
23:24 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev
23:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:25 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/0fc6ea216c00...17cfa52d3806
23:25 < bitcoin-git> bitcoin/master 7dda912 Hennadii Stepanov: test: Do not swallow flake8 exit code
23:25 < bitcoin-git> bitcoin/master 5d77549 Hennadii Stepanov: doc: Add mypy to test dependencies
23:25 < bitcoin-git> bitcoin/master 17cfa52 fanquake: Merge #19172: test: Do not swallow flake8 exit code
23:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:25 < bitcoin-git> [bitcoin] fanquake merged pull request #19172: test: Do not swallow flake8 exit code (master...200605-mypy) https://github.com/bitcoin/bitcoin/pull/19172
23:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:28 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Ping timeout: 246 seconds]
23:31 -!- Kiminuo [~mix@141.98.103.92] has joined #bitcoin-core-dev
23:49 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev
--- Log closed Sat Jun 06 00:00:42 2020