--- Log opened Mon Jun 08 00:00:44 2020
00:13 -!- MasterdonX [~masterdon@103.39.132.190] has joined #bitcoin-core-dev
00:13 -!- masterdonx2 [~masterdon@209.216.92.221] has quit [Ping timeout: 260 seconds]
00:45 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex]
00:52 -!- S3RK [~s3rk@47.246.66.112] has quit [Remote host closed the connection]
00:52 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev
01:05 -!- Highway61 [~Thunderbi@104.223.94.122] has quit [Ping timeout: 260 seconds]
01:07 -!- jonatack_ [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Quit: jonatack_]
01:13 -!- pretyflaco [~k3m@77.243.183.203] has quit [Ping timeout: 256 seconds]
01:16 -!- kljasdfvv [~flack@p200300d46f11fb00b9257c41477f9fe0.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
01:23 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev
01:23 < TheHoliestRoger> sipa can i pm you?
01:27 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
01:42 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex]
01:57 -!- jorijn [~jorijn@84-105-195-195.cable.dynamic.v4.ziggo.nl] has quit [Quit: ZNC 1.8.0 - https://znc.in]
01:57 -!- jorijn [~jorijn@84-105-195-195.cable.dynamic.v4.ziggo.nl] has joined #bitcoin-core-dev
02:00 -!- matp [~matp@37.120.217.243] has quit []
02:01 -!- rafalcpp [~racalcppp@ip-178-214.ists.pl] has joined #bitcoin-core-dev
02:08 -!- riordant [~riordant@1.53.75.82] has joined #bitcoin-core-dev
02:08 -!- BGL [~twenty@75-149-171-58-Washington.hfc.comcastbusiness.net] has quit [Ping timeout: 240 seconds]
02:21 -!- hggdh1 [~hggdh@195.206.169.238] has joined #bitcoin-core-dev
02:27 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
02:27 < promag> Can I request a gitian build for #18790?
02:27 < gribble> https://github.com/bitcoin/bitcoin/issues/18790 | gui: Improve thread naming by hebasto · Pull Request #18790 · bitcoin/bitcoin · GitHub
02:31 -!- S3RK [~s3rk@47.246.66.112] has quit [Remote host closed the connection]
02:47 < fanquake> promag: done
02:48 < promag> ty!
02:54 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
02:54 -!- Deinogalerix21 [~Deinogale@185.125.207.151] has joined #bitcoin-core-dev
02:55 -!- Deinogalerix21 [~Deinogale@185.125.207.151] has quit [Client Quit]
03:03 -!- Anabel19Hilpert [~Anabel19H@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev
03:07 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev
03:07 -!- Anabel19Hilpert [~Anabel19H@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 240 seconds]
03:12 -!- S3RK [~s3rk@47.246.66.112] has quit [Ping timeout: 256 seconds]
03:21 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has quit [Ping timeout: 264 seconds]
03:21 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev
03:25 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev
03:28 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Client Quit]
03:33 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev
03:39 -!- BGL [~twenty@75-149-171-58-Washington.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
03:48 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
03:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:57 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/807b9f811479...399a0d9dc7a1
03:57 < bitcoin-git> bitcoin/master 1a9ef1d Hennadii Stepanov: refactor: Replace RecursiveMutex with Mutex in Shutdown()
03:57 < bitcoin-git> bitcoin/master 399a0d9 MarcoFalke: Merge #19180: refactor: Replace RecursiveMutex with Mutex in Shutdown()
03:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:57 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19180: refactor: Replace RecursiveMutex with Mutex in Shutdown() (master...200605-shutdown) https://github.com/bitcoin/bitcoin/pull/19180
03:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:03 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/399a0d9dc7a1...8496dbeba687
04:03 < bitcoin-git> bitcoin/master 78c8f4f Hennadii Stepanov: refactor: Replace RecursiveMutex with Mutex in netbase.cpp
04:03 < bitcoin-git> bitcoin/master 8496dbe MarcoFalke: Merge #19190: refactor: Replace RecursiveMutex with Mutex in netbase.cpp
04:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:03 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19190: refactor: Replace RecursiveMutex with Mutex in netbase.cpp (master...200606-netbase) https://github.com/bitcoin/bitcoin/pull/19190
04:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:06 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/8496dbeba687...374fd6fc8b4c
04:06 < bitcoin-git> bitcoin/master c2410ce Hennadii Stepanov: refactor: Replace RecursiveMutex with Mutex in timedata.cpp
04:06 < bitcoin-git> bitcoin/master cc5c0d2 Hennadii Stepanov: refactor: Fix formatting of timedata.cpp
04:06 < bitcoin-git> bitcoin/master 374fd6f MarcoFalke: Merge #19189: refactor: Replace RecursiveMutex with Mutex in timedata.cpp
04:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:07 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19189: refactor: Replace RecursiveMutex with Mutex in timedata.cpp (master...200605-timedata) https://github.com/bitcoin/bitcoin/pull/19189
04:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:13 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
04:13 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds]
04:13 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 260 seconds]
04:19 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Remote host closed the connection]
04:19 -!- S3RK [~s3rk@47.246.66.112] has quit [Remote host closed the connection]
04:19 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev
04:22 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Quit: This computer has gone to sleep]
04:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
04:24 -!- S3RK [~s3rk@47.246.66.112] has quit [Ping timeout: 260 seconds]
04:24 -!- Deinogalerix21 [~Deinogale@185.125.207.151] has joined #bitcoin-core-dev
04:24 -!- Deinogalerix21 [~Deinogale@185.125.207.151] has quit [Client Quit]
04:25 -!- Deinogalerix21 [~Deinogale@185.125.207.151] has joined #bitcoin-core-dev
04:27 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev
04:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:29 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/374fd6fc8b4c...41fb69404c03
04:29 < bitcoin-git> bitcoin/master fa2c2b5 MarcoFalke: doc: Extract net permissions doc
04:29 < bitcoin-git> bitcoin/master 41fb694 MarcoFalke: Merge #19192: doc: Extract net permissions doc
04:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:29 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19192: doc: Extract net permissions doc (master...2006-docNetPerm) https://github.com/bitcoin/bitcoin/pull/19192
04:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:30 -!- Deinogalerix21 [~Deinogale@185.125.207.151] has quit [Quit: WeeChat 2.8]
04:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:36 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/41fb69404c03...9573d2b55b45
04:36 < bitcoin-git> bitcoin/master cb38b06 MIZUTA Takeshi: util: Don't reference errno when pthread fails.
04:36 < bitcoin-git> bitcoin/master 9573d2b fanquake: Merge #19194: util: Don't reference errno when pthread fails.
04:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:37 -!- S3RK [~s3rk@47.246.66.112] has quit [Ping timeout: 258 seconds]
04:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:37 < bitcoin-git> [bitcoin] fanquake merged pull request #19194: util: Don't reference errno when pthread fails. (master...prototype) https://github.com/bitcoin/bitcoin/pull/19194
04:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:42 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
04:45 -!- instagibbs [~instagibb@pool-71-178-191-230.washdc.fios.verizon.net] has quit [Ping timeout: 256 seconds]
04:46 -!- instagibbs [~instagibb@pool-71-178-191-230.washdc.fios.verizon.net] has joined #bitcoin-core-dev
04:50 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
04:55 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev
05:00 -!- hggdh1 [~hggdh@195.206.169.238] has quit []
05:06 -!- shesek [~shesek@5.102.222.33] has joined #bitcoin-core-dev
05:06 -!- shesek [~shesek@5.102.222.33] has quit [Changing host]
05:06 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
05:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:12 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #19206: test: Remove leftover comment in mining_basic (master...2006-testComment) https://github.com/bitcoin/bitcoin/pull/19206
05:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:19 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev
05:20 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Client Quit]
05:20 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev
05:22 -!- Jaykul1 [~Jaykul@84.39.116.180] has joined #bitcoin-core-dev
05:27 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 272 seconds]
05:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:30 < bitcoin-git> [bitcoin] jonatack opened pull request #19207: doc: -whitelist/-whitebind documentation improvements (master...whitelist-whitebind-doc-improvements) https://github.com/bitcoin/bitcoin/pull/19207
05:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:35 -!- riordant [~riordant@1.53.75.82] has quit []
05:35 -!- dr-orlovsky [~Dr_Orlovs@31.14.40.19] has quit [Ping timeout: 265 seconds]
05:53 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev
05:58 -!- S3RK [~s3rk@47.246.66.112] has quit [Ping timeout: 260 seconds]
06:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:00 < bitcoin-git> [bitcoin] ycshao opened pull request #19208: test: move `sync_blocks` and `sync_mempool` functions to `test_framework.py` (master...issue-18930) https://github.com/bitcoin/bitcoin/pull/19208
06:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:01 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 260 seconds]
06:02 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has quit [Ping timeout: 246 seconds]
06:02 -!- Kiminuo [~mix@141.98.103.108] has joined #bitcoin-core-dev
06:09 -!- pretyflaco [~k3m@185.213.155.177] has joined #bitcoin-core-dev
06:10 -!- shesek [~shesek@5.102.222.33] has joined #bitcoin-core-dev
06:10 -!- shesek [~shesek@5.102.222.33] has quit [Changing host]
06:10 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
06:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:15 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/9573d2b55b45...b3ec1fe8114a
06:15 < bitcoin-git> bitcoin/master a9bd1f9 Danny Lee: test: warn if nodes not connected before disconnect_nodes
06:15 < bitcoin-git> bitcoin/master e6e7abd Danny Lee: test: remove redundant two-way disconnect_nodes calls
06:15 -!- pretyflaco [~k3m@185.213.155.177] has quit [Ping timeout: 260 seconds]
06:15 < bitcoin-git> bitcoin/master 34e641a Danny Lee: test: Remove unnecessary disconnect_nodes call in rpc_psbt.py
06:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:15 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18890: test: disconnect_nodes should warn if nodes were already disconnected (master...disconnect-nodes) https://github.com/bitcoin/bitcoin/pull/18890
06:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:28 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
06:31 -!- Highway61 [~Thunderbi@161.129.71.26] has joined #bitcoin-core-dev
06:33 -!- roconnor [~roconnor@host-45-78-199-248.dyn.295.ca] has joined #bitcoin-core-dev
06:35 -!- Kiminuo [~mix@141.98.103.108] has quit [Ping timeout: 260 seconds]
06:35 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
06:38 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 265 seconds]
06:46 -!- dr-orlovsky [~Dr_Orlovs@31.14.40.19] has joined #bitcoin-core-dev
06:46 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Ping timeout: 260 seconds]
06:48 -!- Highway61 [~Thunderbi@161.129.71.26] has quit [Quit: Highway61]
06:48 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
06:49 -!- Highway61 [~Thunderbi@161.129.71.26] has joined #bitcoin-core-dev
06:51 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev
06:51 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds]
06:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:56 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b3ec1fe8114a...3e58734e55ee
06:56 < bitcoin-git> bitcoin/master a9d28af Hennadii Stepanov: qt: Display warnings as rich text
06:56 < bitcoin-git> bitcoin/master 3e58734 MarcoFalke: Merge #18898: gui: Display warnings as rich text
06:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:57 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18898: gui: Display warnings as rich text (master...200506-no-html) https://github.com/bitcoin/bitcoin/pull/18898
06:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:58 < bitcoin-git> [bitcoin] hebasto opened pull request #19210: qt: Get rid of cursor in out-of-focus labels (master...200608-cursor) https://github.com/bitcoin/bitcoin/pull/19210
06:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:03 < bitcoin-git> [bitcoin] hebasto closed pull request #14810: qt: Enable tabbing through labels (master...20181124-tab-through-labels) https://github.com/bitcoin/bitcoin/pull/14810
07:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:05 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev
07:18 -!- Highway62 [~Thunderbi@ip72-204-155-64.no.no.cox.net] has joined #bitcoin-core-dev
07:18 -!- Highway61 [~Thunderbi@161.129.71.26] has quit [Ping timeout: 246 seconds]
07:18 -!- Highway62 is now known as Highway61
07:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:20 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/3e58734e55ee...297466b49ff3
07:20 < bitcoin-git> bitcoin/master 3e44210 Rod Vagg: Expose txinwitness for coinbase in JSON form
07:20 < bitcoin-git> bitcoin/master 34645c4 Rod Vagg: Test txinwitness is accessible on coinbase vin
07:20 < bitcoin-git> bitcoin/master 297466b MarcoFalke: Merge #18826: Expose txinwitness for coinbase in JSON form from RPC
07:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:21 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18826: Expose txinwitness for coinbase in JSON form from RPC (master...rvagg/txinwitness-for-coinbase) https://github.com/bitcoin/bitcoin/pull/18826
07:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:22 -!- rafalcpp [~racalcppp@ip-178-214.ists.pl] has quit [Excess Flood]
07:24 -!- Highway62 [~Thunderbi@104.223.94.10] has joined #bitcoin-core-dev
07:24 -!- rafalcpp [~racalcppp@ip-178-214.ists.pl] has joined #bitcoin-core-dev
07:26 -!- Highway61 [~Thunderbi@ip72-204-155-64.no.no.cox.net] has quit [Ping timeout: 246 seconds]
07:26 -!- Highway62 is now known as Highway61
07:35 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev
07:37 -!- davterra [~dulyNoded@185.212.170.229] has quit [Remote host closed the connection]
07:37 -!- davterra [~dulyNoded@185.212.170.229] has joined #bitcoin-core-dev
07:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:38 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/297466b49ff3...a79bca2f1fb2
07:38 < bitcoin-git> bitcoin/master b00266f Sebastian Falbesoner: refactor: replace pointers by references within tx_verify.{h,cpp}
07:38 < bitcoin-git> bitcoin/master a79bca2 MarcoFalke: Merge #19069: refactor: replace pointers by references within tx_verify.{h...
07:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:39 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19069: refactor: replace pointers by references within tx_verify.{h,cpp} (master...20200526-refactor-replace-pointers-by-refs-in-tx_verify) https://github.com/bitcoin/bitcoin/pull/19069
07:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:43 -!- adiabat [~adiabat@63.209.32.102] has joined #bitcoin-core-dev
07:56 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Remote host closed the connection]
07:57 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev
08:00 -!- Jaykul1 [~Jaykul@84.39.116.180] has quit []
08:01 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Ping timeout: 246 seconds]
08:09 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev
08:09 -!- pretyflaco [~k3m@185.213.155.168] has joined #bitcoin-core-dev
08:10 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev
08:14 -!- S3RK [~s3rk@47.246.66.112] has quit [Ping timeout: 265 seconds]
08:18 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Quit: This computer has gone to sleep]
08:20 -!- suriro [~suriro@185.189.114.11] has joined #bitcoin-core-dev
08:31 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev
08:40 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
08:56 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
09:12 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
09:14 < vasild> MarcoFalke: jonatack: the scripts to "filter" a code coverage report: https://github.com/vasild/filter_coverage
09:14 -!- Kiminuo [~mix@109.183.7.106] has joined #bitcoin-core-dev
09:16 < vasild> I also generate an additional report with just the modified and not covered lines: https://people.freebsd.org/~vd/pr19031_coverage_of_modified_code/modified_and_not_covered.html to ease finding them (some source files may begin with 1000s of lines not touched by a change and scrolling to find "bright" lines is not covenient)
09:16 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds]
09:19 -!- Kiminuo [~mix@109.183.7.106] has quit [Ping timeout: 264 seconds]
09:20 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
09:23 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
09:23 -!- vasild_ is now known as vasild
09:32 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
09:33 < jonatack> thanks vasild, will ping you if questions
09:34 < vasild> ok :)
09:37 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 246 seconds]
09:39 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Ping timeout: 264 seconds]
09:39 -!- jarthur [~jarthur@2605:6000:1019:4971:c809:8c6:3463:41a] has joined #bitcoin-core-dev
09:40 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev
09:57 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
10:02 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
10:05 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 264 seconds]
10:10 -!- lnostdal [~lnostdal@cable-84-43-233-231.mnet.bg] has joined #bitcoin-core-dev
10:12 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection]
10:12 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
10:17 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Ping timeout: 256 seconds]
10:28 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
10:32 < luke-jr> MarcoFalke: #12677 is on my todo list
10:32 < gribble> https://github.com/bitcoin/bitcoin/issues/12677 | RPC: Add ancestor{count,size,fees} to listunspent output by luke-jr · Pull Request #12677 · bitcoin/bitcoin · GitHub
10:44 -!- rafalcpp [~racalcppp@ip-178-214.ists.pl] has quit [Ping timeout: 260 seconds]
10:46 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
10:48 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
10:52 -!- lnostdal [~lnostdal@cable-84-43-233-231.mnet.bg] has quit [Ping timeout: 265 seconds]
10:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:54 < bitcoin-git> [bitcoin] hebasto opened pull request #19213: refactor: Replace RecursiveMutex with Mutex in Get{Data,Blocks}Dir() (master...200608-path-mx) https://github.com/bitcoin/bitcoin/pull/19213
10:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:00 -!- suriro [~suriro@185.189.114.11] has quit []
11:03 -!- lnostdal [~lnostdal@cable-84-43-233-231.mnet.bg] has joined #bitcoin-core-dev
11:03 -!- lnostdal [~lnostdal@cable-84-43-233-231.mnet.bg] has quit [Remote host closed the connection]
11:07 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection]
11:08 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
11:12 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Ping timeout: 240 seconds]
11:18 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 258 seconds]
11:19 < harding> wumpus: FYI, I've heard from someone that they can't verify the releases because they have "weak-digest sha1" in their gpg.conf (based on a recommendation they heard from petertodd) and the release signing key is self-signed using sha1.  I explained the situation to them, but long-term I think that's a reasonable option for people to be setting and so maybe it's time to update the release key to use a stronger digest.
11:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:25 < bitcoin-git> [bitcoin] sipa opened pull request #19214: Auto-detect SHA256 implementation in benchmarks (master...202006_hw_sha_bench) https://github.com/bitcoin/bitcoin/pull/19214
11:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:28 -!- Randolf [~randolf@d207-216-81-185.bchsia.telus.net] has quit [Remote host closed the connection]
11:34 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
11:41 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
11:44 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 246 seconds]
11:45 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev
11:49 -!- rafalcpp [~racalcppp@ip-178-214.ists.pl] has joined #bitcoin-core-dev
11:49 -!- S3RK [~s3rk@47.246.66.112] has quit [Ping timeout: 272 seconds]
11:55 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 260 seconds]
11:55 -!- IAm_thor3 [~IAm_thor3@77.243.177.38] has joined #bitcoin-core-dev
12:09 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
12:13 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
12:15 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!]
12:28 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection]
12:28 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
12:28 < wumpus> harding: sure, do you perhaps know how to do this?
12:29 < harding> wumpus: I tried doing it several years ago, but I couldn't figure out how and ended up just creating a new key.  :-(
12:29 < wumpus> hmm generating a new release keys seems much worse 
12:33 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Ping timeout: 258 seconds]
12:36 < harding> wumpus: yeah, agreed.  You can still sign the new release keys with the old release keys to create a clear trust path, but it's probably worth waiting to see if anyone reading this knows a way to just upgrade the existing key.
12:37 < wumpus> looks like it should just be "gpg --cert-digest-algo sha512 --expert --edit-key", then "sign", going to try...
12:42 < harding> wumpus: if that works and if you figured it out from just reading the manual page or doing a quick web search, I'm going to have hang my head in shame because I know I spent more than an hour researching this a couple years ago.
12:42 -!- pinheadm_ [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
12:43 < phantomcircuit> sipa, no idea why the auto detect is actually slower
12:43 < phantomcircuit> definitely running a gcc old enough that the asm should beat the naive implementation significantly
12:43 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 246 seconds]
12:45 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Ping timeout: 246 seconds]
12:46 < sipa> phantomcircuit: if you run bitcoind, what gets reported in debug.log?
12:46 < sipa> (it tells you which implementation is selected)
12:47 < sipa> in one of the first output lines
12:47 < sipa> 2020-03-15T20:46:14.743702Z Using the 'sse4(1way),sse41(4way),avx2(8way)' SHA256 implementation
12:47 < phantomcircuit>  Using the 'sse4(1way),sse41(4way),avx2(8way)' SHA256 implementation
12:48 < sipa> any particular configure flags or CXXFLAGS?
12:48 -!- rafalcpp [~racalcppp@ip-178-214.ists.pl] has quit [Ping timeout: 264 seconds]
12:48 < phantomcircuit> --with-incompatible-bdb --without-gui
12:49 < sipa> very surprising
12:49 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
12:49 < sipa> and the sse4 code is actually assembly, not intrinsics
12:49 < sipa> so a compiler can't be fucking that up
12:50 < phantomcircuit> hmm i wonder if im having build issues one sec
12:51 < phantomcircuit> it is actually `using sse4(1way),sse41(4way),avx2(8way)` in the benchmark too
12:52 < sipa> only the 1-way code matters for the benchmarks you're listing
12:52 < sipa> how does the merkle root benchmark compare?
12:52 < wumpus> harding: well I did that and pushed my re-signed key to the keyservers, hope it worked (no idea how to test)
12:53 < sipa> -filter=MerkleRoot
12:53 < phantomcircuit> it's slower too
12:53 < phantomcircuit> bench_master.txt:MerkleRoot, 5, 800, 4.61105, 0.00114375, 0.00117359, 0.00114912
12:53 < phantomcircuit> bench_sipa.txt:MerkleRoot, 5, 800, 4.71484, 0.00116899, 0.00119543, 0.00117554
12:53 < wumpus> harding: (well I can verify bitcoin core SHA256SUMS.asc using "weak-digest sha1", but haven't ever seen it fail)
12:53 < sipa> wth
12:54 < sipa> phantomcircuit: that's ridiculous
12:54 < sipa> it should be 5x faster
12:54 < harding> wumpus: It's failed for me with weak-digest sha1, so I'll try testing now.
12:54 < phantomcircuit> sipa, it's a laptop cpu possibly the sse4/avx2 instructions are just comically broken?
12:56 < sipa> phantomcircuit: but your numbers are fast
12:56 < sipa> unreasonably fast for the naive implementation
12:57 < sipa> MerkleRoot, 5, 800, 42.6441, 0.0106318, 0.0107271, 0.0106534
12:57 < sipa> ^ that's on my laptop with naive SHA256
12:57 < harding> wumpus: did you upload to keyserver.ubuntu.com?  I still get a failure after running --refresh-keys from there.
12:57 < wumpus> "gpg --fingerprint --check-sigs 0x90C8019E36C2E964" does show two self-signatures
12:57 < wumpus> of course it doesn't show the algorithm used
12:58 < phantomcircuit> i mean i just did `git clean -fdx && git checkout master && ./autogen.sh && ./configure --with-incompatible-bdb --without-gui && make -j4 && ./src/bench/bench_bitcoin --filter='(SHA256|Merkle).*'` and got the same result for master
12:58 < phantomcircuit> which i see as b1b173994406158e5faa3c83b113da9d971ac104
12:59 < harding> wumpus: ah, now it works for me and my friend also says it works.  Thanks!
13:00 < harding> (I had to request the specific key with --refresh-keys)
13:00 < phantomcircuit> i'll clear ccache as well lets try this agian...
13:00 < wumpus> "You can validate signatures are using non-SHA1 by using gpg --list-packets < SIGFILE, and checking that digest algo (aka hash algorithm) is not "2" (SHA1). For SHA512, you'd want "10" (see RFC4880 section 9.4 for details): "  of course list-packets, of course
13:00 < sipa> haha
13:01 < harding> haha
13:01 < wumpus> harding: great! thanks for checking
13:01 < sipa> the gpg binary format is not too hard
13:01 < sipa> it's probably easier to learn to read a hexdump than to learn gpg's command line options
13:01 < wumpus> :-)
13:02 < sipa> i have edited gpg files using hd, head & tail
13:02 < sipa> phantomcircuit: i'm baffled
13:03 < phantomcircuit> it's gonna end up being some insane ccache issue except my original master benchmark is before i had even checked out the pr
13:03 < phantomcircuit> so uh
13:03  * phantomcircuit shrugs
13:04 < sipa> ok, i'm going to run this:
13:04 < sipa> $ ./autogen.sh && ./configure --with-incompatible-bdb --without-gui && make -j9 -C src bench/bench_bitcoin && ./src/bench/bench_bitcoin --filter='(SHA256|Merkle).*'
13:04 < sipa> with a git clean -dfx before it
13:05 -!- shesek [~shesek@185.3.145.28] has joined #bitcoin-core-dev
13:05 -!- shesek [~shesek@185.3.145.28] has quit [Changing host]
13:05 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
13:05 < sipa> this is on a i7-7820HQ fwiw
13:08 < phantomcircuit> running the exact same command against master now
13:09 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 260 seconds]
13:09 < phantomcircuit> sipa, i think your cpu should generally be faster
13:11 < wumpus> sipa: wow! I've never editited gpg files that low-level, did apparently mess around with gpgsplit at some point to turn an attached signature into a detached signature https://github.com/bitcoin-core/gitian.sigs/blob/master/scripts/extract-sig.py
13:11 < sipa> phantomcircuit: except your *naive* numbers are faster than my sse4 numbers!
13:12 < phantomcircuit> sipa, yeah im confused to
13:12 < sipa> and for the 1-way sse4 code, i'd believe it that an implementation may be sufficiently broken that it offers no gain
13:12 < sipa> but for the 8-way AVX2  ode to be effectively 8x slower than naive seems a severe stretch
13:13 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
13:13 < sipa> wumpus: i had to make the same edit to many different files, but it was the same byte range for all
13:16 < phantomcircuit> sipa, and now the numbers make sense, master is MerkleRoot, 5, 800, 26.4366, 0.00647519, 0.00678599, 0.00659338
13:17 < phantomcircuit> 19214 is MerkleRoot, 5, 800, 4.56617, 0.00113032, 0.00114694, 0.00114392
13:17 < phantomcircuit> so ??????
13:17 < phantomcircuit> i swear i didn't mix them up either
13:18 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
13:18 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Read error: Connection reset by peer]
13:18 < phantomcircuit> i mean that's still kind of unreasonably fast for the naive implementation but at least they're in the right ratio?
13:18 < sipa> that looks more reasonable
13:18 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
13:22 < sipa> phantomcircuit: well whatever glitch happened on your CPU, if you figure it out you may want to inform intel that naive SHA256 code can beat a AVX2 parallel one :)
13:22 < phantomcircuit> the weird thing is that i did the master benchmark before i checked out the pr
13:23 < phantomcircuit> i checked my shell history to confirm that too
13:27 -!- davterra [~dulyNoded@185.212.170.229] has quit [Ping timeout: 260 seconds]
13:27 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
13:32 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
13:48 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Remote host closed the connection]
13:49 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev
13:51 < phantomcircuit> sipa, oh do any of the other benchmarks maybe end up calling something that would call the auto detect?
13:53 < sipa> phantomcircuit: i don't think so
13:56 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev
14:00 -!- IAm_thor3 [~IAm_thor3@77.243.177.38] has quit []
14:01 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection]
14:01 -!- S3RK [~s3rk@47.246.66.112] has quit [Ping timeout: 265 seconds]
14:12 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
14:27 -!- pretyflaco1 [~k3m@82.102.16.91] has joined #bitcoin-core-dev
14:27 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
14:27 -!- pretyflaco [~k3m@185.213.155.168] has quit [Ping timeout: 260 seconds]
14:32 < phantomcircuit> i'd like to basically start over on ScanForWalletTransactions and split it into a call to a chain interface method that returns a list of candidate blocks and logic to (optionally, but by default) rescan if anything in the keypool changed
14:33 < phantomcircuit> as it stands the scanning logic can miss transactions if you use keypool keys out of order
14:33 < phantomcircuit> (i doubt that's ever actually happened to anybody though)
14:35 < sipa> phantomcircuit: how does that interact with work to make rescanning of all wallets happen simultaneously?
14:36 < phantomcircuit> is there a pr or an issue describing the strategy for that? (i don't see any reason it would be incompatible)
14:38 < sipa> no idea; just vaguely heard in mentioned
14:42 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:43 -!- rafalcpp [~racalcppp@ip-178-214.ists.pl] has joined #bitcoin-core-dev
14:44 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection]
14:45 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
14:49 < luke-jr> wumpus: did you manage to re-self-sign without SHA1?
14:50 < luke-jr> wumpus: I did it a few years ago - maybe I can look up how I did it
14:55 -!- Oejet [~Oejet@84.39.116.180] has joined #bitcoin-core-dev
15:01 -!- pretyflaco1 [~k3m@82.102.16.91] has quit [Ping timeout: 265 seconds]
15:02 -!- pretyflaco [~k3m@82.102.16.91] has joined #bitcoin-core-dev
15:07 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
15:08 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
15:09 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
15:10 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
15:15 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 260 seconds]
15:18 -!- davterra [~dulyNoded@s17612523583.blix.com] has joined #bitcoin-core-dev
15:20 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection]
15:25 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
15:28 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection]
15:29 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev
15:30 -!- _flow_ [~none@salem.informatik.uni-erlangen.de] has quit [Ping timeout: 244 seconds]
15:34 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection]
15:34 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev
15:35 -!- filchef [~filchef@212.104.97.177] has quit [Client Quit]
15:38 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
15:38 -!- _flow_ [~none@salem.informatik.uni-erlangen.de] has joined #bitcoin-core-dev
15:39 -!- dongcarl [~dongcarl@unaffiliated/dongcarl] has joined #bitcoin-core-dev
15:39 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has quit [Read error: Connection reset by peer]
15:39 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection]
15:40 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has joined #bitcoin-core-dev
15:41 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
15:41 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection]
15:41 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
15:44 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection]
15:44 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
15:47 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
15:48 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection]
15:52 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Remote host closed the connection]
15:54 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Remote host closed the connection]
15:55 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev
16:02 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev
16:04 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
16:07 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Read error: No route to host]
16:07 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
16:11 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
16:14 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection]
16:15 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 264 seconds]
16:16 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev
16:21 -!- S3RK [~s3rk@47.246.66.112] has quit [Ping timeout: 260 seconds]
16:25 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has quit [Quit: May the Shwartz be with you]
16:30 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev
16:34 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Ping timeout: 246 seconds]
16:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
16:34 < bitcoin-git> [bitcoin] achow101 opened pull request #19215: psbt: Include and allow both non_witness_utxo and witness_utxo for segwit inputs (master...psbt-segwit-fixes) https://github.com/bitcoin/bitcoin/pull/19215
16:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
16:48 -!- pretyflaco [~k3m@82.102.16.91] has quit [Ping timeout: 256 seconds]
17:00 -!- Oejet [~Oejet@84.39.116.180] has quit []
17:01 -!- Daniel [c9ed8849@201.237.136.73] has joined #bitcoin-core-dev
17:01 -!- Daniel is now known as Guest91026
17:06 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
17:06 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
17:09 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
17:12 -!- Guest91026 [c9ed8849@201.237.136.73] has quit [Remote host closed the connection]
17:19 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev
17:21 < phantomcircuit> sipa, actually this should make is really easy to do parallel scans
17:22 -!- n3glv1 [~n3glv@37.120.203.188] has joined #bitcoin-core-dev
17:25 -!- S3RK [~s3rk@47.246.66.112] has quit [Ping timeout: 256 seconds]
17:30 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds]
17:30 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
17:39 -!- roconnor [~roconnor@host-45-78-199-248.dyn.295.ca] has quit [Remote host closed the connection]
17:42 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev
17:42 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
17:43 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
17:45 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
18:03 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit []
18:46 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has quit [Read error: Connection reset by peer]
18:47 < aj> sipa: oops, was about to say "i'm not seeing any more premature requests either", but then realised when i picked up your updated patch i didn't reinstate the premature logging...
18:50 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev
18:50 -!- harrigan- [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Read error: Connection reset by peer]
18:53 < aj> hmm, and i didn't merge your patch very well anyway apparently, drat
18:53 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Ping timeout: 256 seconds]
18:56 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Quit: This computer has gone to sleep]
19:00 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev
19:07 -!- rafalcpp [~racalcppp@ip-178-214.ists.pl] has quit [Ping timeout: 264 seconds]
19:13 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev
19:31 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Ping timeout: 260 seconds]
19:32 -!- jarthur [~jarthur@2605:6000:1019:4971:c809:8c6:3463:41a] has quit [Ping timeout: 256 seconds]
19:33 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev
19:34 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has quit [Quit: This computer has gone to sleep]
19:50 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev
20:00 -!- n3glv1 [~n3glv@37.120.203.188] has quit []
20:03 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds]
20:18 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
20:19 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
20:20 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 264 seconds]
20:21 -!- Beetstra1 [~Beetstra@185.189.114.11] has joined #bitcoin-core-dev
20:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:56 < bitcoin-git> [bitcoin] pstratem opened pull request #19216: wallet: Remove first parameter to ScanForWalletTransactions start_hash (master...2020-06-07-wallet-scanforwallettransactions) https://github.com/bitcoin/bitcoin/pull/19216
20:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:58 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Remote host closed the connection]
20:59 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev
21:20 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
21:23 < phantomcircuit> anybody know why the cirrus ci failed on #19216 ?
21:23 < gribble> https://github.com/bitcoin/bitcoin/issues/19216 | wallet: Remove first parameter to ScanForWalletTransactions start_hash by pstratem · Pull Request #19216 · bitcoin/bitcoin · GitHub
21:23 < phantomcircuit> https://github.com/bitcoin/bitcoin/pull/19216/checks?check_run_id=752472448
21:23 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
21:23 -!- vasild_ is now known as vasild
21:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
21:53 < bitcoin-git> [bitcoin] hebasto closed pull request #18927: Pass bilingual_str argument to AbortNode() (master...200510-abort) https://github.com/bitcoin/bitcoin/pull/18927
21:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
21:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
21:54 < bitcoin-git> [bitcoin] hebasto reopened pull request #18927: Pass bilingual_str argument to AbortNode() (master...200510-abort) https://github.com/bitcoin/bitcoin/pull/18927
21:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
22:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
22:10 < bitcoin-git> [bitcoin] glowang opened pull request #19217: disambiguate block-relay-only variable names from blocksonly variables (master...2020/06/08/rename-max-block-relay-connection-name) https://github.com/bitcoin/bitcoin/pull/19217
22:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
22:14 -!- IGHOR [~quassel@176.121.4.135] has joined #bitcoin-core-dev
22:20 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Remote host closed the connection]
22:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
22:41 < bitcoin-git> [bitcoin] sipa opened pull request #19219: Replace automatic bans with discouragement filter (master...202006_discourage) https://github.com/bitcoin/bitcoin/pull/19219
22:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
22:51 < phantomcircuit> `importwallet` doesn't update transactions that are found in the scan initiated when the wallet is loaded if they already exist, which i think could mean they get attributed to the wrong block?
22:52 < sipa> how so?
22:53 < sipa> you mean if there was a reorg in between?
22:53 < phantomcircuit> sipa, i think so yes
22:54 < phantomcircuit> if the reorg happened before you imported the wallet
22:54 < phantomcircuit> it's the only thing that calls scan with fUpdate=false
22:56 < sipa> but the wallet will observe the reorg when your node activates it?
22:57 < sipa> or you mean if this happens while the wallet is not loaded?
23:00 -!- Beetstra1 [~Beetstra@185.189.114.11] has quit []
23:00 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has joined #bitcoin-core-dev
23:02 < phantomcircuit> sipa, if the reorg happens when you dont have the wallet activated
23:02 < phantomcircuit> sipa, it's kind of a catch 22
23:03 < phantomcircuit> it shouldn't be possible for the fUpdate flag to mean anything
23:03 < phantomcircuit> and yet it's there?
23:05 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
23:10 -!- proofofkeags [~proofofke@71-218-146-180.hlrn.qwest.net] has quit [Ping timeout: 256 seconds]
23:17 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex]
23:19 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
23:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:21 < bitcoin-git> [bitcoin] hebasto closed pull request #18927: Pass bilingual_str argument to AbortNode() (master...200510-abort) https://github.com/bitcoin/bitcoin/pull/18927
23:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:22 < bitcoin-git> [bitcoin] hebasto reopened pull request #18927: Pass bilingual_str argument to AbortNode() (master...200510-abort) https://github.com/bitcoin/bitcoin/pull/18927
23:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:22 -!- GothAlice1 [~GothAlice@84.39.116.180] has joined #bitcoin-core-dev
23:24 -!- S3RK [~s3rk@47.246.66.112] has quit [Remote host closed the connection]
23:24 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Remote host closed the connection]
23:25 -!- S3RK [~s3rk@47.246.66.112] has joined #bitcoin-core-dev
23:28 -!- Kiminuo [~mix@141.98.103.196] has joined #bitcoin-core-dev
23:29 -!- S3RK [~s3rk@47.246.66.112] has quit [Ping timeout: 258 seconds]
23:38 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Ping timeout: 240 seconds]
23:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:42 < bitcoin-git> [bitcoin] hebasto opened pull request #19220: refactor: Replace RecursiveMutex with Mutex in warnings.cpp (master...200609-warn-mx) https://github.com/bitcoin/bitcoin/pull/19220
23:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:53 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
--- Log closed Tue Jun 09 00:00:45 2020