--- Log opened Fri Jun 19 00:00:54 2020
00:29 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
00:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:42 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/057bd3189f12...0101110f9b64
00:42 < bitcoin-git> bitcoin/master f52d403 John Newbery: [net] split PushInventory()
00:42 < bitcoin-git> bitcoin/master 0101110 fanquake: Merge #19322: [net] split PushInventory()
00:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:42 < bitcoin-git> [bitcoin] fanquake merged pull request #19322: [net] split PushInventory() (master...2020-06-split-push-inventory) https://github.com/bitcoin/bitcoin/pull/19322
00:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:45 -!- jonatack_ [~jon@37.166.220.215] has quit [Ping timeout: 240 seconds]
00:48 -!- jonatack_ [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev
00:48 < luke-jr> so after spending several hours trying to get a Rust compiler, I'm once again concluding it is still not realistically usable yet (cc dongcarl)
00:49 -!- jonatack_ [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Client Quit]
00:49 < luke-jr> (got pretty far, but rustc is segfaulting building the std lib, and I have no clue where to go from there)
00:49 < luke-jr> (but that's only for 1.29.0 which is ancient and requires LLVM that has been dropped from Gentoo etc)
01:00 -!- Pavlenex [~Thunderbi@185.189.114.187] has joined #bitcoin-core-dev
01:05 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
01:08 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Ping timeout: 246 seconds]
01:09 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev
01:10 -!- arkos [3df73504@61.247.53.4] has joined #bitcoin-core-dev
01:28 -!- afk11` [~afk11@gateway/tor-sasl/afk11] has quit [Ping timeout: 240 seconds]
01:29 -!- afk11` [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev
01:30 -!- Pavlenex [~Thunderbi@185.189.114.187] has quit [Quit: Pavlenex]
01:39 < provoostenator> Github is broken
01:41 -!- Relis [~Relis@cpc96290-lewi18-2-0-cust910.2-4.cable.virginm.net] has joined #bitcoin-core-dev
01:41 < hebasto> https://www.githubstatus.com/ is green. lol
01:42 < provoostenator> So is half of the pretty 500 error page...
01:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:43 < bitcoin-git> [bitcoin] Saibato opened pull request #19327: qt: Allow horizontal slider in debugwindow peers tab to autosize display (master...fix-disp-flags-qt) https://github.com/bitcoin/bitcoin/pull/19327
01:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:44 < hebasto> provoostenator: for me too ((
01:46 -!- jonatack [~jon@192.113.14.109.rev.sfr.net] has joined #bitcoin-core-dev
01:46 < hebasto> they saw an error now -- "Some services are degraded"
02:00 -!- WiQert [~WiQert@89.47.234.28] has quit []
02:07 -!- jonatack [~jon@192.113.14.109.rev.sfr.net] has quit [Ping timeout: 256 seconds]
02:13 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 258 seconds]
02:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:18 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/0101110f9b64...c940c1ad8547
02:18 < bitcoin-git> bitcoin/master fac12eb MarcoFalke: net: Avoid redundant and confusing FAILED log
02:18 < bitcoin-git> bitcoin/master fa1904e MarcoFalke: net: Remove dead logging code
02:18 < bitcoin-git> bitcoin/master c940c1a fanquake: Merge #19293: net: Avoid redundant and confusing FAILED log
02:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:18 < bitcoin-git> [bitcoin] fanquake merged pull request #19293: net: Avoid redundant and confusing FAILED log (master...2006-netNoRet) https://github.com/bitcoin/bitcoin/pull/19293
02:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:19 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
02:19 -!- arkos [3df73504@61.247.53.4] has quit [Quit: Ping timeout (120 seconds)]
02:20 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 256 seconds]
02:21 -!- jonhcw [~jonhcw@84.39.116.180] has joined #bitcoin-core-dev
02:28 -!- S3RK [~s3rk@47.246.66.115] has quit [Remote host closed the connection]
02:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:34 < bitcoin-git> [bitcoin] fanquake closed pull request #19327: qt: Allow horizontal slider in debugwindow peers tab to autosize display (master...fix-disp-flags-qt) https://github.com/bitcoin/bitcoin/pull/19327
02:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:34 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
02:37 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
02:41 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 260 seconds]
02:57 -!- Pavlenex [~Thunderbi@185.189.114.187] has joined #bitcoin-core-dev
03:03 -!- Wilhelm68Zboncak [~Wilhelm68@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev
03:04 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
03:07 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
03:10 -!- Wilhelm68Zboncak [~Wilhelm68@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 240 seconds]
03:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:11 < bitcoin-git> [bitcoin] fanquake closed pull request #19318: build: disable -stack-clash-protection on Windows (master...disable_stack_clash_windows) https://github.com/bitcoin/bitcoin/pull/19318
03:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:12 -!- Pavlenex [~Thunderbi@185.189.114.187] has quit [Quit: Pavlenex]
03:37 < shesek> was `size` completely removed from `getmempoolentry`? the v0.20.0 docs still include it with a "will be completely removed in v0.20" note. https://bitcoincore.org/en/doc/0.20.0/rpc/blockchain/getmempoolentry/
03:37 -!- S3RK [~s3rk@47.246.66.115] has quit []
03:37 -!- Pavlenex [~Thunderbi@185.189.114.187] has joined #bitcoin-core-dev
03:39 < harding> shesek: are you asking whether the docs are correct or because you need the feature?
03:40 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
03:41 < harding> If you need the feature, you can use the `vsize` field, which is identical to the `size` field except in name.
03:41 -!- Pavlenex [~Thunderbi@185.189.114.187] has quit [Client Quit]
03:41 < luke-jr> not if he wants the real size
03:44 < harding> luke-jr: #15637 simply renamed the field; it didn't change from legacy size to vsize.
03:44 < gribble> https://github.com/bitcoin/bitcoin/issues/15637 | rpc: Rename size to vsize in mempool related calls by fanquake · Pull Request #15637 · bitcoin/bitcoin · GitHub
03:45 < shesek> harding, whether the docs are correct, I don't need it
03:45 < luke-jr> harding: yes, because size was broken at that point
03:47 < harding> shesek: I just tested with -deprecatedrpc=size and I can get the `size` field in getmempoolentry, so the docs are wrong about the feature being removed in 0.20.
03:49 < harding> Looks like it's remove in master though.
03:50 -!- wharm [181e66c1@24.30.102.193] has quit [Remote host closed the connection]
03:51 < harding> Yeah, removed in #18493
03:51 < gribble> https://github.com/bitcoin/bitcoin/issues/18493 | rpc: Remove deprecated "size" from mempool txs by vasild · Pull Request #18493 · bitcoin/bitcoin · GitHub
03:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:56 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c940c1ad8547...62948caf4446
03:56 < bitcoin-git> bitcoin/master 51e9393 Sebastian Falbesoner: refactor: s/command/msg_type/ in CNetMsgMaker and CSerializedNetMsg
03:56 < bitcoin-git> bitcoin/master 62948ca MarcoFalke: Merge #18937: refactor: s/command/msg_type/ in CNetMsgMaker and CSerialize...
03:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:57 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18937: refactor: s/command/msg_type/ in CNetMsgMaker and CSerializedNetMsg (master...20200520-refactor-replace-command-by-msgtype-part-3) https://github.com/bitcoin/bitcoin/pull/18937
03:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:00 -!- Highway61 [~Thunderbi@104.129.24.218] has joined #bitcoin-core-dev
04:09 -!- S3RK [~s3rk@47.246.66.115] has quit [Remote host closed the connection]
04:10 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
04:13 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
04:14 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 258 seconds]
04:50 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
04:52 -!- roconnor [~roconnor@host-45-58-196-55.dyn.295.ca] has joined #bitcoin-core-dev
04:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:55 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/62948caf4446...5f72ddb7ee4c
04:55 < bitcoin-git> bitcoin/master 3351c91 João Barbosa: refactor: Make CScriptVisitor stateless
04:55 < bitcoin-git> bitcoin/master 5f72ddb MarcoFalke: Merge #18863: refactor: Make CScriptVisitor stateless
04:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:55 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18863: refactor: Make CScriptVisitor stateless (master...2020-04-cscript-visitor) https://github.com/bitcoin/bitcoin/pull/18863
04:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:00 -!- jonhcw [~jonhcw@84.39.116.180] has quit []
05:00 < vasild> How to make sure this does not get forgotten to be added to the 0.21 release notes: https://github.com/bitcoin/bitcoin/pull/18493#issuecomment-607219682?
05:04 -!- lightlike [~lightlike@p200300c7ef198a00f56e62e3441b1b72.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
05:07 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev
05:11 -!- IGHOR_ [~quassel@176.121.4.135] has quit [Ping timeout: 265 seconds]
05:15 < fanquake> vasild: I've added a label
05:17 < vasild> fanquake: thanks!
05:22 -!- rule32 [~rule32@185.189.114.11] has joined #bitcoin-core-dev
05:51 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
06:05 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
06:14 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 256 seconds]
06:38 -!- dr-orlovsky [~dr-orlovs@xdsl-188-154-186-21.adslplus.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
06:39 -!- spinza_ [~spin@102.132.245.16] has quit [Ping timeout: 260 seconds]
06:41 < instagibbs> gwillen, I don't think that issue is a blocker, I think your suggested fix is plausible at least :)
06:43 -!- indigoChi021 [43bfba94@67.191.186.148] has joined #bitcoin-core-dev
06:45 -!- lightlike [~lightlike@p200300c7ef198a00f56e62e3441b1b72.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
06:50 -!- dr-orlovsky [~dr-orlovs@xdsl-188-154-186-21.adslplus.ch] has joined #bitcoin-core-dev
07:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:01 < bitcoin-git> [bitcoin] fjahr opened pull request #19328: Add gettxoutsetinfo hash_type option (master...csi-5-hash_type-none) https://github.com/bitcoin/bitcoin/pull/19328
07:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:05 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev
07:09 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
07:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:29 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5f72ddb7ee4c...febe5823b4ae
07:29 < bitcoin-git> bitcoin/master fa93527 MarcoFalke: cirrus: Clear dummy task
07:29 < bitcoin-git> bitcoin/master fa2eb3d MarcoFalke: ci: Run asan ci config on cirrus
07:29 < bitcoin-git> bitcoin/master febe582 MarcoFalke: Merge #19321: ci: Run asan ci config on cirrus
07:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:29 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19321: ci: Run asan ci config on cirrus (master...2006-ciCirrusAsan) https://github.com/bitcoin/bitcoin/pull/19321
07:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:00 -!- rule32 [~rule32@185.189.114.11] has quit []
08:00 -!- davterra [~davterra@206.217.205.53] has joined #bitcoin-core-dev
08:09 -!- davterra [~davterra@206.217.205.53] has quit [Remote host closed the connection]
08:20 -!- Seyaryuki [~Seyaryuki@185.204.1.185] has joined #bitcoin-core-dev
08:32 -!- Netsplit *.net <-> *.split quits: cryptapus, troygiorshev, EagleTM, belcher, awesome-doge, braydonf, Highway61, AaronvanW, davec, indigoChi021,  (+12 more, use /NETSPLIT to show all of them)
08:32 < provoostenator> Does Cirrus CI have a (live) log anywhere? I see a yellow "ci" section with a black box below it that's empty.
08:32 -!- Netsplit over, joins: belcher, ghost43, AaronvanW, troygiorshev, Dean_Guss, davec, wallet42, jb55, TheFuzzStone[m], sipa (+12 more)
08:32 < provoostenator> E.g. https://cirrus-ci.com/task/4685111432052736
08:35 < provoostenator> Oh wait, it magically apears after 11 minutes
08:35 < provoostenator> Sadly no auto-scroll :-)
08:35 -!- TheFuzzStone[m] [thefuzzsto@gateway/shell/matrix.org/x-kflubwqzsusgesez] has quit [Ping timeout: 244 seconds]
08:35 -!- awesome-doge [lplplpmatr@gateway/shell/matrix.org/x-kbesevotcdugwmua] has quit [Ping timeout: 244 seconds]
08:36 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-hmlapeyzopliczrv] has quit [Ping timeout: 256 seconds]
08:37 -!- nostrodamy [~nostrodam@thunix.net] has quit [Read error: Connection reset by peer]
08:38 -!- mrostecki[m] [mrosteckim@gateway/shell/matrix.org/x-sylfployggzaxqiv] has quit [Ping timeout: 244 seconds]
08:39 -!- leinlawun[m] [leinlawunm@gateway/shell/matrix.org/x-ocuqwjlclssyzsfu] has quit [Ping timeout: 244 seconds]
08:40 < provoostenator> MarcoFalke: I think you still need to activate cirrus CI for the GUI repo?
08:40 -!- majes [~smuxi@2602:306:bc5d:6b40:79b2:bf40:c883:a191] has joined #bitcoin-core-dev
08:43 -!- Pavlenex [~Thunderbi@185.189.114.187] has joined #bitcoin-core-dev
08:43 -!- nostrooo [~nostrooo@thunix.net] has joined #bitcoin-core-dev
08:45 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
08:46 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
08:47 -!- Highway61 [~Thunderbi@104.129.24.218] has quit [Quit: Highway61]
08:47 -!- Highway61 [~Thunderbi@104.129.24.218] has joined #bitcoin-core-dev
08:49 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 246 seconds]
08:52 -!- majes [~smuxi@2602:306:bc5d:6b40:79b2:bf40:c883:a191] has quit [Read error: Connection timed out]
08:53 -!- nostrooo [~nostrooo@thunix.net] has quit [Read error: Connection timed out]
08:54 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer]
08:54 -!- majes [~smuxi@2602:306:bc5d:6b40:79b2:bf40:c883:a191] has joined #bitcoin-core-dev
08:56 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
08:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:59 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #17458: Refactor OutputGroup effective value calculations and filtering to occur within the struct (master...cleanup-outputgroups) https://github.com/bitcoin/bitcoin/pull/17458
08:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:59 < bitcoin-git> [bitcoin] MarcoFalke reopened pull request #17458: Refactor OutputGroup effective value calculations and filtering to occur within the struct (master...cleanup-outputgroups) https://github.com/bitcoin/bitcoin/pull/17458
08:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:01 -!- majes is now known as Majes
09:09 -!- jarthur [~jarthur@2605:6000:1019:48d9:41fc:92a7:7901:8f65] has joined #bitcoin-core-dev
09:16 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
09:16 -!- kljasdfvv [~flack@p200300d46f11fb00b015a96b339e2443.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!]
09:17 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds]
09:20 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
09:23 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
09:23 -!- vasild_ is now known as vasild
09:41 -!- indigoChi021 [43bfba94@67.191.186.148] has quit [Remote host closed the connection]
09:53 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds]
09:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:54 < bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/febe5823b4ae...6dc1b45087c9
09:54 < bitcoin-git> bitcoin/master fa6ddb2 MarcoFalke: travis: Always run multiprocess build
09:54 < bitcoin-git> bitcoin/master fa88077 MarcoFalke: ci: Have one config run in xenial to test against python3.5
09:54 < bitcoin-git> bitcoin/master fad6720 MarcoFalke: doc: move doc to ci readme
09:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:54 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19267: ci: Upgrade most ci configs to focal (master...2006-ciFocal) https://github.com/bitcoin/bitcoin/pull/19267
09:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:02 -!- dr-orlovsky [~dr-orlovs@xdsl-188-154-186-21.adslplus.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
10:07 -!- TheFuzzStone[m] [thefuzzsto@gateway/shell/matrix.org/x-sifbugmgpepwojha] has joined #bitcoin-core-dev
10:10 -!- justanotheruser [~justanoth@wsip-70-167-146-53.om.om.cox.net] has joined #bitcoin-core-dev
10:13 -!- SergeySherkunov[ [leinlawunm@gateway/shell/matrix.org/x-vywfytvrihpbkinr] has joined #bitcoin-core-dev
10:13 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-whvsbyofpcqgupuh] has joined #bitcoin-core-dev
10:13 -!- mrostecki[m] [mrosteckim@gateway/shell/matrix.org/x-fxljgrsuvwnqncvo] has joined #bitcoin-core-dev
10:13 -!- awesome-doge [lplplpmatr@gateway/shell/matrix.org/x-xcwepqjxylatyekk] has joined #bitcoin-core-dev
10:23 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds]
10:33 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds]
10:37 -!- justanotheruser is now known as Guest88307
10:38 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev
10:39 -!- dr-orlovsky [~dr-orlovs@xdsl-188-154-186-21.adslplus.ch] has joined #bitcoin-core-dev
10:43 -!- Guest88307 [~justanoth@wsip-70-167-146-53.om.om.cox.net] has quit [Quit: WeeChat 2.7.1]
10:43 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
11:00 -!- Seyaryuki [~Seyaryuki@185.204.1.185] has quit []
11:00 -!- dr-orlovsky [~dr-orlovs@xdsl-188-154-186-21.adslplus.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
11:03 -!- dr-orlovsky [~dr-orlovs@xdsl-188-154-186-21.adslplus.ch] has joined #bitcoin-core-dev
11:08 -!- Pavlenex [~Thunderbi@185.189.114.187] has quit [Quit: Pavlenex]
11:14 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
11:21 -!- khorben1 [~khorben@84.39.116.180] has joined #bitcoin-core-dev
11:28 -!- afk11` [~afk11@gateway/tor-sasl/afk11] has quit [Remote host closed the connection]
11:28 -!- afk11` [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev
11:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:39 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6dc1b45087c9...f3d776b59380
11:39 < bitcoin-git> bitcoin/master b83cc0f Hennadii Stepanov: Fix link error with --enable-debug
11:39 < bitcoin-git> bitcoin/master f3d776b MarcoFalke: Merge #19309: refactor: Fix link error with --enable-debug
11:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:39 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19309: refactor: Fix link error with --enable-debug (master...200617-fix) https://github.com/bitcoin/bitcoin/pull/19309
11:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:43 -!- jrayhawk_ is now known as jrayhawk
11:54 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
11:57 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Ping timeout: 240 seconds]
11:57 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 265 seconds]
12:00 < provoostenator> Wallet meeting?
12:00 < meshcollider> #startmeeting
12:00 < lightningbot> Meeting started Fri Jun 19 19:00:09 2020 UTC.  The chair is meshcollider. Information about MeetBot at http://wiki.debian.org/MeetBot.
12:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
12:00 < achow101> wallet meeting?
12:00 < achow101> hi
12:00 < provoostenator> hi
12:00 < meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball ariard digi_james amiti fjahr 
12:00 < meshcollider> jeremyrubin emilengler jonatack hebasto jb55
12:00 < meshcollider> Glad you can see my messages this week
12:00 < meshcollider> Topics?
12:00 < achow101> luke-jr: had one
12:01 < provoostenator> Plug for for my hardware wallet write-up: https://gist.github.com/Sjors/29d06728c685e6182828c1ce9b74483d
12:02 < provoostenator> Nothing new to report though.
12:02 < achow101> [06-17 03:15:04 pm] <luke-jr> #proposedwalletmeetingtopic revert #6550 (conceptually) - merkle branches stored in the wallet would be useful for pruned nodes [w/ watch-only wallets]
12:02 < gribble> https://github.com/bitcoin/bitcoin/issues/6550 | Do not store Merkle branches in the wallet. by sipa · Pull Request #6550 · bitcoin/bitcoin · GitHub
12:03 < meshcollider> Is luke-jr here though
12:03 < meshcollider> provoostenator: nice write-up
12:04 < provoostenator> To many double negatives, so the proposal is to store Merkle branches in the wallet?
12:04 < sipa> yes
12:04 < sipa> at least optionally
12:04 < jonatack> hi
12:04 < achow101> also we should probably remove the descriptor wallets project from the repo now that it's done. maybe we should add one for hwardware wallets and one for sqlite wallets?
12:05 < sipa> but probably better to have this discussion with luke-jr present
12:05 < provoostenator> Is that to make it easier to do transaction lookups without a txindex?
12:05 < provoostenator> But yes, we can defer discussion until he's around.
12:05 < meshcollider> achow101: sounds sensible, I'm not sure I can add/remove projects so maybe sipa can do that for us :)
12:07 < meshcollider> So tl;dr for the hardware wallet write-up for now is: go and review #11413 ?
12:07 < gribble> https://github.com/bitcoin/bitcoin/issues/11413 | [wallet] [rpc] sendtoaddress/sendmany: Add explicit feerate option by kallewoof · Pull Request #11413 · bitcoin/bitcoin · GitHub
12:07 < provoostenator> Hardware wallet project would be welcome. My writeup contains a few PR's that can be added, recursion should find the rest, or pingme.
12:07 < provoostenator> meshcollider: there's roughly two things one can review, based on interest
12:07 < provoostenator> 1) bunch of send RPC related PR's
12:08 < provoostenator> 2) runCommandParseJSON (which adds boost::process)
12:08 < meshcollider> But you're right, 11413 has been stuck in limbo for a long time, we should get it in
12:09 < jonatack> +1 will review 11413
12:09 < provoostenator> Yes, because that introduces sat/b which I'll need in any other RPC call related to sending coins
12:10 < provoostenator> (or waste more of kallewoof's time if he needs to rebase)
12:10 < provoostenator> But I'd love to get #15382 in as well, hopefully the opt-in behavior now is acceptable.
12:10 < gribble> https://github.com/bitcoin/bitcoin/issues/15382 | util: add runCommandParseJSON by Sjors · Pull Request #15382 · bitcoin/bitcoin · GitHub
12:11 < provoostenator> configure.ac is rather painful to work on
12:11 < achow101> #18027 is getting close too. I'm reviewing it right now
12:11 < gribble> https://github.com/bitcoin/bitcoin/issues/18027 | "PSBT Operations" dialog by gwillen · Pull Request #18027 · bitcoin/bitcoin · GitHub
12:11 < provoostenator> That one is great too
12:12 < provoostenator> The UI is tangential to my hardware wallet PR's though, beacuse you won't need to touch PSBT manually.
12:12 < provoostenator> Though I can see how in multisig you might receive a PSBT via "email", load it and then sign on a device. So eventually it'll have a role.
12:13 < achow101> topic suggestion: how much bdb code do people want to review?
12:13 < meshcollider> #topic BDB code review (achow101)
12:13 < provoostenator> But my initial implementation assumes single sig, with only modest thought put into multisig (I closed a PR for that, too much of a stack)
12:13 < provoostenator> Is there a choice in how much?
12:14 < achow101> I've split out chunks of #18971 into a bunch of seperate PRs that are pretty easy to review
12:14 < gribble> https://github.com/bitcoin/bitcoin/issues/18971 | wallet: Refactor the classes in wallet/db.{cpp/h} by achow101 · Pull Request #18971 · bitcoin/bitcoin · GitHub
12:14 < achow101> the rest of it is introducing the WalletDatabase abstract class and some BDB changes
12:14 < achow101> but I've realized I can introduce the WalletDatabase class without those BDB changes
12:14 < provoostenator> Maybe use a checkbox - [ ]  instead of (merged) for easier visual inspection
12:15 < achow101> so do people want to have the abstract class and then the BDB changes separately?
12:15 < provoostenator> Yes please
12:15 < provoostenator> BDB is scary enough as move-only :-)
12:15 < meshcollider> I'd say so yep
12:15 < achow101> I fear the if I do that, those changes won't get merged, but at the same time, those changes will probably hold up the classsepparation
12:16 < provoostenator> I'd like to get Sqlite3 in relatlively long before 0.21 branch off
12:16 < achow101> alright then
12:16 < provoostenator> That seems more important than improving DBD
12:16 < achow101> I guess bdb is going to remain a mess
12:16 < achow101> at least it'll be a self contained mess
12:17 < meshcollider> We can make it a priority to get it reviewed and merged
12:17 < meshcollider> It'll be fine
12:18 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
12:18 -!- molz_ [~mol@unaffiliated/molly] has quit [Remote host closed the connection]
12:18 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
12:19 < meshcollider> Alright since Luke still isn't here then we'll keep this short and sweet :)
12:19 < meshcollider> #endmeeting
12:19 < lightningbot> Meeting ended Fri Jun 19 19:19:06 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
12:19 < lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-06-19-19.00.html
12:19 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-06-19-19.00.txt
12:19 < lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-06-19-19.00.log.html
12:19 < achow101> prediction: luke will show up in 40 minutes
12:19 < jonatack> Agree with separating the PRs achow101 
12:19 < meshcollider> Lol
12:19 < achow101> provoostenator: I've changed it to checkboxes
12:20 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 264 seconds]
12:20 < meshcollider> Something achieved directly from the meeting already ;)
12:20 < jonatack> meshcollider: two PRs that each have 2 ACKs, that don't touch anything dangerous: #19133
12:20 < gribble> https://github.com/bitcoin/bitcoin/issues/19133 | rpc, cli, test: add bitcoin-cli -generate command by jonatack · Pull Request #19133 · bitcoin/bitcoin · GitHub
12:21 < jonatack> and #19200
12:21 < gribble> https://github.com/bitcoin/bitcoin/issues/19200 | rpc: remove deprecated getaddressinfo fields by jonatack · Pull Request #19200 · bitcoin/bitcoin · GitHub
12:21 -!- dongcarl8 [~dongcarl@unaffiliated/dongcarl] has joined #bitcoin-core-dev
12:21 -!- dongcarl8 [~dongcarl@unaffiliated/dongcarl] has quit [Client Quit]
12:21 -!- dongcarl [~dongcarl@unaffiliated/dongcarl] has quit [Ping timeout: 246 seconds]
12:21 < meshcollider> jonatack: thanks!
12:21 -!- dongcarl5 [~dongcarl@unaffiliated/dongcarl] has joined #bitcoin-core-dev
12:22 -!- dongcarl5 [~dongcarl@unaffiliated/dongcarl] has quit [Client Quit]
12:22 -!- dongcarl [~dongcarl@unaffiliated/dongcarl] has joined #bitcoin-core-dev
12:22 < jonatack> will review 11413, 15382, and 18027 this weekend -- cheers
12:23 < provoostenator> My wallet PR's that should be almost merge-ready: #18202 and #16377
12:23 < gribble> https://github.com/bitcoin/bitcoin/issues/18202 | refactor: consolidate sendmany and sendtoaddress code by Sjors · Pull Request #18202 · bitcoin/bitcoin · GitHub
12:23 < gribble> https://github.com/bitcoin/bitcoin/issues/16377 | [rpc] dont automatically append inputs in walletcreatefundedpsbt by Sjors · Pull Request #16377 · bitcoin/bitcoin · GitHub
12:23 < jonatack> provoostenator: ok adding
12:23 < provoostenator> One that has a bit more discussion - see comment from promag - is now so old I don't remember my own reasoning: #18244
12:23 < gribble> https://github.com/bitcoin/bitcoin/issues/18244 | rpc: fundrawtransaction and walletcreatefundedpsbt respect locks even with manual coin selection by Sjors · Pull Request #18244 · bitcoin/bitcoin · GitHub
12:23 < achow101> who has the ability to modify the project boards?
12:24 < provoostenator> I can't say I find that last PR super important by the way.
12:24 < meshcollider> achow101: I'll check if I can
12:24 < provoostenator> Now that the GUI works again for watch-only coin selection :L-)
12:25 < meshcollider> Oh, looks like I can
12:28 < meshcollider> achow101, provoostenator : https://github.com/bitcoin/bitcoin/projects/15
12:32 < kanzure> #proposedwalletmeetingtopic wallet meeting topics will be aggregated here http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
12:32 -!- tryphe_ is now known as tryphe
12:34 < meshcollider> kanzure: cheers
12:36 < luke-jr> sorry I missed the meeting :x
12:37 < achow101> people might still be here
12:37 < provoostenator> meshcollider: thanks. Can you add #16377  and #18244 ?
12:37 < gribble> https://github.com/bitcoin/bitcoin/issues/16377 | [rpc] dont automatically append inputs in walletcreatefundedpsbt by Sjors · Pull Request #16377 · bitcoin/bitcoin · GitHub
12:37 < gribble> https://github.com/bitcoin/bitcoin/issues/18244 | rpc: fundrawtransaction and walletcreatefundedpsbt respect locks even with manual coin selection by Sjors · Pull Request #18244 · bitcoin/bitcoin · GitHub
12:38 < provoostenator> I guess you can't refer to other repos in a project, but otherwise bitcoin-core/gui# 4 would be nice in the "design" column
12:38 < meshcollider> Done
12:39 -!- dr-orlovsky [~dr-orlovs@xdsl-188-154-186-21.adslplus.ch] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
12:40 < meshcollider> provoostenator: I've added it as a note
12:40 < meshcollider> You can add to projects in the same organisation but not bitcoin-core to bitcoin
12:41 < achow101> #18027 seems RTM, has 3 acks
12:41 < gribble> https://github.com/bitcoin/bitcoin/issues/18027 | "PSBT Operations" dialog by gwillen · Pull Request #18027 · bitcoin/bitcoin · GitHub
12:46 < achow101> do we want to talk about luke-jr's topic?
12:46 < provoostenator> Now works for me...
12:47 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
12:49 < meshcollider> Sure, just ping anyone else relevant
12:49 < achow101> luke-jr: sipa ?
12:49 < luke-jr> .
12:51 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 240 seconds]
12:51 < achow101> meh, just go for it.
12:52 < meshcollider> Or you can wait for next week's (normal) meeting if you prefer
12:54 < meshcollider> achow101: https://github.com/bitcoin/bitcoin/projects/16
12:54 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 260 seconds]
12:55 < sipa> sli don't have much to discuss about it, apart from stating that it may be useful to have this functiinality optionally enabled
12:55 < achow101> meshcollider: add #18916 to design
12:55 < gribble> https://github.com/bitcoin/bitcoin/issues/18916 | Sqlite wallet storage · Issue #18916 · bitcoin/bitcoin · GitHub
12:56 < meshcollider> Done
13:07 < gwillen> achow101: whoops thanks for plugging my PR even though I missed the meeting :D
13:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:15 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/f3d776b59380...d4f9ae00252b
13:15 < bitcoin-git> bitcoin/master 3a03a11 Andrew Chow: Skip hdKeypath of 'm'
13:15 < bitcoin-git> bitcoin/master 951bca6 Andrew Chow: tests: feature_backwards_compatibility.py test 0.16 up/downgrade
13:15 < bitcoin-git> bitcoin/master d4f9ae0 MarcoFalke: Merge #19054: wallet: Skip hdKeypath of 'm' when determining inactive hd s...
13:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:16 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19054: wallet: Skip hdKeypath of 'm' when determining inactive hd seeds (master...inactive-seed-skip-m) https://github.com/bitcoin/bitcoin/pull/19054
13:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:22 < cfields> sipa: re #13062, the implicit Span conversions seem like a bit of a regression from MakeSpan() imo :\
13:22 < gribble> https://github.com/bitcoin/bitcoin/issues/13062 | Make script interpreter independent from storage type CScript by sipa · Pull Request #13062 · bitcoin/bitcoin · GitHub
13:22 < sipa> cfields: how so?
13:22 < sipa> MakeSpan is still there
13:24 < sipa> cfields: i think what you're concerned about is the automatic construction of spans, not the conversion
13:24 < cfields> sipa: yes, that.
13:25 < sipa> cfields: i was hesitant myself, but ended up just matching the std::span behavior
13:26 < cfields> for ex, in VerifyWitnessProgram, ExecuteWitnessScript gets called with different types of scripts depending on which branch it falls into. Just makes it hard to assume what the param ends up as.
13:28 < sipa> the way i see is that an automatically-created span acts as a "common denominator" for all containers that can be passed to it
13:28 < sipa> so by having a Span<const T> are argument to a function, you automatically enable passing any constant contiguous container to it
13:29 < sipa> i wonder if we need being able to do so from temporaries, though
13:29 < cfields> There are only a handful, and they sure look like magic :p
13:30 < cfields> but point taken about matching std::span.
13:36 < sipa> i think it makes sense to write a big comment about pitfalls with spans
13:37 < sipa> they're kind of the same ones that exist for references in the first place, but for references that's masked due to automatic lifetime extension
13:37 < sipa> as in:
13:37 < sipa> std::string Foo();
13:37 < sipa> std::string& x = Foo();
13:38 < sipa> works and is well-defined, as the temporary returned by Foo gets its lifetime automatically extended to that of x
13:38 < sipa> but if there is a function call in between, that magic disappears
13:40 < cfields> +1 to some pitfalls docs.
13:53 < sipa> the only actual danger i can imagine is when you're constructing a span from a temporary, and then assigning that span to a variable
13:54 < sipa> (and that temporary isn't a span itself)
14:00 -!- khorben1 [~khorben@84.39.116.180] has quit []
14:22 -!- fredy1 [~fredy@217.138.204.90] has joined #bitcoin-core-dev
14:24 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 260 seconds]
14:26 -!- troygiorshev [~troygiors@172-97-135-59.cpe.distributel.net] has joined #bitcoin-core-dev
14:28 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
14:32 -!- troygiorshev [~troygiors@172-97-135-59.cpe.distributel.net] has quit [Ping timeout: 246 seconds]
14:43 < jnewbery> cfields: you're very welcome to come to review club next week and tell us about the pitfalls of spans: https://bitcoincore.reviews/18468.html :)
14:45 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:59 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev
15:09 -!- troygiorshev [~troygiors@172-97-135-59.cpe.distributel.net] has joined #bitcoin-core-dev
15:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:15 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #19331: build: Do not include server symbols in wallet (master...2006-WalletNoServerSym) https://github.com/bitcoin/bitcoin/pull/19331
15:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:16 -!- isis is now known as isis_
15:20 < cfields> jnewbery: haha, I don't know what those pitfalls are, that's why I was running things by sipa :)
15:24 < sipa> cfields: you seem pretty good at noticing them (the vector resize, and the span-from-temporary one...)
15:27 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!]
15:28 -!- marcoagner [~user@81.193.76.62] has quit [Ping timeout: 265 seconds]
15:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:46 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #19332: test: Fix intermittent test failure in feature_backwards_compatibility (master...2006-testIntBack) https://github.com/bitcoin/bitcoin/pull/19332
15:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:46 -!- troygiorshev [~troygiors@172-97-135-59.cpe.distributel.net] has quit [Ping timeout: 256 seconds]
15:57 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds]
15:59 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 240 seconds]
16:10 < bsm117532> #proposedwalletmeetingtopic descriptor specification for watch-only wallets, and repeated payments without address use via BIP32 paths
16:11 < bsm117532> Maybe that doesn't work outside a meeting...
16:13 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
16:26 < gwillen> bsm117532: it does, the bot won't respond but the log gets scraped for them later, before the meeting
16:27 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
16:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
16:32 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #19333: refactor: Fix clang compile failure (master...2006-FixClangBuild) https://github.com/bitcoin/bitcoin/pull/19333
16:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
16:37 < fanquake> We are doing real well with the “fails to compile” changes recently
16:38 < fanquake> I feel like this is about the 3rd one this week
16:39 -!- IGHOR [~quassel@176.121.4.135] has joined #bitcoin-core-dev
16:43 -!- Highway61 [~Thunderbi@104.129.24.218] has quit [Ping timeout: 265 seconds]
16:49 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
16:52 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]
16:53 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 240 seconds]
16:55 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds]
17:00 -!- fredy1 [~fredy@217.138.204.90] has quit []
17:02 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
17:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 258 seconds]
17:19 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
17:20 -!- Suigintou [~Suigintou@84.39.116.180] has joined #bitcoin-core-dev
17:22 -!- davterra [~dulyNoded@89.45.90.30] has joined #bitcoin-core-dev
17:28 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 264 seconds]
17:33 -!- davterra [~dulyNoded@89.45.90.30] has quit [Read error: Connection reset by peer]
17:35 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
17:37 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
17:46 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 240 seconds]
17:51 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev
17:52 -!- davterra [~dulyNoded@89.45.90.100] has joined #bitcoin-core-dev
17:56 -!- Majes [~smuxi@2602:306:bc5d:6b40:79b2:bf40:c883:a191] has quit [Remote host closed the connection]
17:57 -!- davterra [~dulyNoded@89.45.90.100] has quit [Ping timeout: 240 seconds]
18:09 -!- davterra [~dulyNoded@89.45.90.17] has joined #bitcoin-core-dev
18:12 < luke-jr> fanquake: for as rigousous as our review process is, it sometimes seems to not provide much benefit :/
18:16 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Ping timeout: 256 seconds]
18:18 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
18:48 -!- jarthur [~jarthur@2605:6000:1019:48d9:41fc:92a7:7901:8f65] has quit []
18:48 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
18:57 -!- jarthur [~jarthur@2605:6000:1019:48d9:bcbb:34cb:e1df:d4fc] has joined #bitcoin-core-dev
19:03 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
19:15 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
19:16 -!- shesek [~shesek@5.22.128.126] has joined #bitcoin-core-dev
19:16 -!- shesek [~shesek@5.22.128.126] has quit [Changing host]
19:16 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
19:19 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 260 seconds]
19:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:21 < bitcoin-git> [bitcoin] achow101 opened pull request #19334: wallet: Introduce WalletDatabase abstract class (master...bdb-add-walletdb) https://github.com/bitcoin/bitcoin/pull/19334
19:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
19:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:29 < bitcoin-git> [bitcoin] achow101 opened pull request #19335: wallet: Cleanup and separate BerkeleyDatabase and BerkeleyBatch (master...bdb-cleanup-refactors) https://github.com/bitcoin/bitcoin/pull/19335
19:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
19:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:33 < bitcoin-git> [bitcoin] achow101 closed pull request #18971: wallet: Refactor the classes in wallet/db.{cpp/h} (master...refactor-storage) https://github.com/bitcoin/bitcoin/pull/18971
19:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
19:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 265 seconds]
19:47 -!- drbrule [sid395654@gateway/web/irccloud.com/x-fbecegmlpyoelsbm] has quit [Ping timeout: 246 seconds]
19:48 -!- GoldmanSats [uid428607@gateway/web/irccloud.com/x-kzypyuqsmufhfvjm] has quit [Read error: Connection reset by peer]
19:48 -!- peltre [sid268329@gateway/web/irccloud.com/x-xvebpypmgnwocfhc] has quit [Read error: Connection reset by peer]
19:48 -!- someone235 [uid419897@gateway/web/irccloud.com/x-uknpanohwsyvtgxv] has quit [Read error: Connection reset by peer]
19:49 -!- nejon [sid38993@gateway/web/irccloud.com/x-vpvxfasmmeopstyv] has quit [Ping timeout: 272 seconds]
19:49 -!- corollari [sid405633@gateway/web/irccloud.com/x-duaqbsaqbdllzypu] has quit [Ping timeout: 272 seconds]
19:49 -!- gertjaap_ [sid322815@gateway/web/irccloud.com/x-wywnhkyqqtdbyjqa] has quit [Ping timeout: 260 seconds]
19:50 -!- peltre [sid268329@gateway/web/irccloud.com/x-dcmplpgjqeahtpkq] has joined #bitcoin-core-dev
19:50 -!- someone235 [uid419897@gateway/web/irccloud.com/x-duxyuivyjgqokmoy] has joined #bitcoin-core-dev
19:51 -!- peltre [sid268329@gateway/web/irccloud.com/x-dcmplpgjqeahtpkq] has quit [Max SendQ exceeded]
19:52 -!- gertjaap_ [sid322815@gateway/web/irccloud.com/x-tpcodommqmzoliys] has joined #bitcoin-core-dev
19:52 -!- corollari [sid405633@gateway/web/irccloud.com/x-sqgypuvorhrbjxrs] has joined #bitcoin-core-dev
19:52 -!- peltre [sid268329@gateway/web/irccloud.com/x-ojmpynrbhevblhdx] has joined #bitcoin-core-dev
19:53 -!- GoldmanSats [uid428607@gateway/web/irccloud.com/x-hlkgdmaobnqhvuco] has joined #bitcoin-core-dev
19:53 -!- drbrule [sid395654@gateway/web/irccloud.com/x-idvkndlcscznsthd] has joined #bitcoin-core-dev
19:53 -!- peltre [sid268329@gateway/web/irccloud.com/x-ojmpynrbhevblhdx] has quit [Max SendQ exceeded]
19:56 -!- peltre [sid268329@gateway/web/irccloud.com/x-rccfqjwznycckvvz] has joined #bitcoin-core-dev
19:58 -!- nejon [sid38993@gateway/web/irccloud.com/x-qtljahryougxjevp] has joined #bitcoin-core-dev
19:58 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev
20:00 -!- Suigintou [~Suigintou@84.39.116.180] has quit []
20:09 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
20:12 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 258 seconds]
20:12 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
20:17 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 260 seconds]
20:21 -!- LaserShark [~LaserShar@84.39.116.180] has joined #bitcoin-core-dev
20:36 -!- jarthur [~jarthur@2605:6000:1019:48d9:bcbb:34cb:e1df:d4fc] has quit []
21:12 -!- davterra [~dulyNoded@89.45.90.17] has quit [Ping timeout: 258 seconds]
21:20 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
21:24 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
21:24 -!- vasild_ is now known as vasild
21:34 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
21:50 -!- isis_ is now known as isis
22:07 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds]
22:14 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev
23:00 -!- LaserShark [~LaserShar@84.39.116.180] has quit []
23:04 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!]
23:21 -!- sauce [~sauce@194.35.233.43] has joined #bitcoin-core-dev
--- Log closed Sat Jun 20 00:00:55 2020