--- Log opened Fri Jul 24 00:00:28 2020 00:01 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Client Quit] 00:04 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 00:06 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Client Quit] 00:11 -!- S3RK [~s3rk@47.246.66.116] has joined #bitcoin-core-dev 00:14 < luke-jr> this error makes no sense and I can't reproduce it :/ https://travis-ci.org/github/bitcoin/bitcoin/jobs/711362669#L3131 00:15 -!- S3RK [~s3rk@47.246.66.116] has quit [Ping timeout: 240 seconds] 00:18 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 00:22 -!- jeremyrubin [~jr@2601:645:c200:f539:c03f:40d9:1aa8:e444] has quit [Ping timeout: 260 seconds] 00:24 -!- marcoagner [~user@bl11-17-219.dsl.telepac.pt] has joined #bitcoin-core-dev 00:24 -!- jonatack [~jon@194.187.251.155] has joined #bitcoin-core-dev 00:30 -!- S3RK [~s3rk@47.246.66.116] has joined #bitcoin-core-dev 00:35 < vasild> src/wallet/walletdb.h:44:using WalletDatabase = BerkeleyDatabase; 00:36 < vasild> luke-jr: maybe it picked some "strange" berkeley db version that does not have "env" and "GetFileId" members? 00:36 < vasild> -I/home/travis/build/bitcoin/bitcoin/db4/include 00:37 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Ping timeout: 244 seconds] 00:40 -!- jeremyrubin [~jr@2601:645:c200:f539:c03f:40d9:1aa8:e444] has joined #bitcoin-core-dev 00:49 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 00:55 < luke-jr> vasild: that's not a bdb class 00:57 < vasild> hm, right, it is defined in src/wallet/bdb.h:101:class BerkeleyDatabase 01:00 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 01:10 < vasild> luke-jr: I can't reproduce it locally either, but it failed to compile for me for another reason: https://bpa.st/PUHA 01:10 -!- arowser [~arowser1@67.230.166.11] has quit [Ping timeout: 240 seconds] 01:12 -!- IGHOR [~quassel@176.121.4.135] has quit [Ping timeout: 264 seconds] 01:15 < luke-jr> yeah, I was wondering why I wasn't getting that one.. 01:15 < vasild> clang 11 here 01:16 < luke-jr> hmm, does GCC lack it entirely? :/ 01:17 < vasild> g++10 -Wthread-safety-analysis 01:17 < vasild> g++10: error: unrecognized command-line option '-Wthread-safety-analysis' 01:18 < luke-jr> apparently it was removed at some point :/ 01:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:21 < bitcoin-git> [bitcoin] hebasto closed pull request #19567: p2p, refactor: Do not over-reserve vAddr capacity (master...200722-addr) https://github.com/bitcoin/bitcoin/pull/19567 01:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:22 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 01:24 -!- IGHOR [~quassel@176.121.4.135] has joined #bitcoin-core-dev 01:29 -!- IGHOR [~quassel@176.121.4.135] has quit [Ping timeout: 240 seconds] 01:33 -!- IGHOR [~quassel@176.121.4.135] has joined #bitcoin-core-dev 01:40 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 256 seconds] 01:40 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev 01:42 -!- justMaD [~justMaD@84.39.116.180] has quit [Remote host closed the connection] 01:43 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev 01:50 -!- S3RK [~s3rk@47.246.66.116] has quit [Remote host closed the connection] 02:04 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 264 seconds] 02:07 -!- S3RK [~s3rk@47.246.66.116] has joined #bitcoin-core-dev 02:11 -!- S3RK [~s3rk@47.246.66.116] has quit [Ping timeout: 240 seconds] 02:15 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Ping timeout: 256 seconds] 02:16 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev 02:19 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex] 02:23 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Ping timeout: 256 seconds] 02:24 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 02:30 -!- dongcarl [~dongcarl@unaffiliated/dongcarl] has quit [Read error: Connection reset by peer] 02:32 -!- csharpsteen [~csharpste@84.39.117.57] has joined #bitcoin-core-dev 02:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:34 -!- MasterdonX [~masterdon@198.204.231.150] has joined #bitcoin-core-dev 02:35 -!- masterdonx2 [~masterdon@213.183.57.61] has quit [Ping timeout: 260 seconds] 02:40 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Read error: Connection reset by peer] 02:40 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 02:41 -!- jonatack [~jon@194.187.251.155] has quit [Ping timeout: 244 seconds] 02:53 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 03:03 -!- Ignacio32Lockman [~Ignacio32@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev 03:05 -!- arowser [~arowser1@67.230.166.11] has quit [Ping timeout: 246 seconds] 03:14 -!- S3RK [~s3rk@47.246.66.116] has joined #bitcoin-core-dev 03:17 -!- Ignacio32Lockman [~Ignacio32@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 256 seconds] 03:18 -!- S3RK [~s3rk@47.246.66.116] has quit [Ping timeout: 244 seconds] 03:27 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev 03:31 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev 03:34 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Ping timeout: 244 seconds] 03:41 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev 03:48 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 03:50 -!- S3RK [~s3rk@47.246.66.116] has joined #bitcoin-core-dev 03:50 -!- S3RK [~s3rk@47.246.66.116] has quit [Remote host closed the connection] 03:50 -!- S3RK [~s3rk@47.246.66.116] has joined #bitcoin-core-dev 03:51 < achow101> luke-jr: you need to rebase 03:52 < achow101> An actual WalletDatabase virtual class was added. It doesn't have an env member 03:53 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Read error: Connection reset by peer] 03:53 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 03:55 < achow101> Do you really need the bdb unique file id? Sqlite doesn't have a similar id so it's not guaranteed that file IDs will exist for all WalletDatabase classes 03:58 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Remote host closed the connection] 04:00 < wumpus> yanmaani: it should be preferred to use named parameters with RPC where possible as they prevent some kinds of bugs, positional arguments are mainly still accepted for historical compatiblity (no, they're not going away any time soon if it's up to me) 04:03 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev 04:05 < achow101> Personally I still prefer positional because I can never spell the named args correctly the first time 04:09 < wumpus> right for use in a program is different than using it manually 04:11 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 04:15 < jonatack> +1. for manual use, I mostly use positional. 04:15 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 04:18 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Ping timeout: 265 seconds] 04:18 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 04:20 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev 04:22 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 04:22 -!- S3RK [~s3rk@47.246.66.116] has quit [Remote host closed the connection] 04:23 -!- S3RK [~s3rk@47.246.66.116] has joined #bitcoin-core-dev 04:25 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Quit: jonatack] 04:27 -!- S3RK [~s3rk@47.246.66.116] has quit [Remote host closed the connection] 04:27 -!- S3RK [~s3rk@47.246.66.116] has joined #bitcoin-core-dev 04:29 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev 04:30 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev 04:35 -!- mutatrum [~quassel@2001:984:6da9:1:28b0:884:e2b9:741c] has quit [Ping timeout: 244 seconds] 04:36 -!- S3RK [~s3rk@47.246.66.116] has quit [Ping timeout: 258 seconds] 04:46 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 04:47 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Ping timeout: 240 seconds] 04:50 -!- reallll is now known as belcher_ 04:58 < wumpus> in principle bitcoin-cli could add in the names before sending it to the server and emulate the same interface 04:59 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 05:00 -!- csharpsteen [~csharpste@84.39.117.57] has quit [] 05:09 -!- vincenzopalazzo [~vincent@host-95-246-119-127.retail.telecomitalia.it] has quit [Quit: Leaving] 05:11 < jonatack> heh, just realised i've made 4 failed CLI PRs in a row, and 16439 by aj has been open for exactly a year now with only one ACK (from me)... CLI PRs seem unsexy :D 05:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:18 < bitcoin-git> [bitcoin] troygiorshev opened pull request #19580: Remove message_count (master...2020-07-remove-message_count) https://github.com/bitcoin/bitcoin/pull/19580 05:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:19 -!- arowser [~arowser1@67.230.166.11] has quit [Ping timeout: 256 seconds] 05:20 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 05:20 -!- bayashi [~bayashi@77.243.177.38] has joined #bitcoin-core-dev 05:29 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Ping timeout: 265 seconds] 05:34 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 05:35 -!- Tralfaz [~Davterra@37.120.208.253] has joined #bitcoin-core-dev 05:36 -!- Davterra [~Davterra@37.120.208.253] has quit [Read error: Connection reset by peer] 05:52 -!- arowser [~arowser1@67.230.166.11] has quit [Ping timeout: 264 seconds] 05:53 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev 05:58 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev 06:03 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Remote host closed the connection] 06:03 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 06:07 -!- arowser [~arowser1@67.230.166.11] has quit [Remote host closed the connection] 06:07 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 06:08 -!- arowser [~arowser1@67.230.166.11] has quit [Remote host closed the connection] 06:08 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 06:09 -!- arowser [~arowser1@67.230.166.11] has quit [Remote host closed the connection] 06:09 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 06:10 -!- arowser [~arowser1@67.230.166.11] has quit [Remote host closed the connection] 06:10 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 06:10 < instagibbs> jonatack, clearly the -cli is perfect then 06:17 -!- arowser [~arowser1@67.230.166.11] has quit [Ping timeout: 256 seconds] 06:29 -!- pingwindyktator [~pingwindy@pingwindyktator.me] has quit [Quit: The Lounge - https://thelounge.chat] 06:29 -!- pingwindyktator [~pingwindy@pingwindyktator.me] has joined #bitcoin-core-dev 06:30 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev 06:31 -!- grubles [~user@gateway/tor-sasl/grubles] has quit [Ping timeout: 240 seconds] 06:32 < elichai2> harding: Thanks! russell's tool was exactly what I was looking for :) 06:34 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 240 seconds] 06:38 -!- grubles [~user@gateway/tor-sasl/grubles] has joined #bitcoin-core-dev 06:40 -!- owowo [~ovovo@31.7.59.226] has joined #bitcoin-core-dev 06:40 -!- owowo [~ovovo@31.7.59.226] has quit [Changing host] 06:40 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 06:45 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 06:46 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Ping timeout: 258 seconds] 06:46 -!- Tralfaz is now known as Davterra 06:54 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev 06:57 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Ping timeout: 244 seconds] 07:09 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Read error: Connection reset by peer] 07:09 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 07:09 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev 07:22 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has joined #bitcoin-core-dev 07:28 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 07:31 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Ping timeout: 256 seconds] 07:31 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 07:32 < jonatack> instagibbs: yup seems so 07:37 -!- cubancorona [~cubancoro@pool-72-77-31-161.pitbpa.ftas.verizon.net] has quit [Quit: Leaving] 07:40 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Quit: ZNC 1.7.5 - https://znc.in] 07:43 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 07:45 -!- Tralfaz [~Davterra@193.32.127.227] has joined #bitcoin-core-dev 07:46 -!- Davterra [~Davterra@37.120.208.253] has quit [Disconnected by services] 07:46 -!- Tralfaz is now known as Davterra 07:49 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev 07:49 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 256 seconds] 07:53 < jnewbery> wumpus: I think #19472 is RFM. It has 4 ACKs 07:53 < gribble> https://github.com/bitcoin/bitcoin/issues/19472 | [net processing] Reduce cs_main scope in MaybeDiscourageAndDisconnect() by jnewbery · Pull Request #19472 · bitcoin/bitcoin · GitHub 08:00 -!- bayashi [~bayashi@77.243.177.38] has quit [] 08:02 < wumpus> jnewbery: thanks 08:03 -!- Pavlenex [~Thunderbi@178.220.159.79] has joined #bitcoin-core-dev 08:04 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 08:06 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Read error: Connection reset by peer] 08:06 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 08:14 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has quit [Remote host closed the connection] 08:15 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has joined #bitcoin-core-dev 08:15 < yanmaani> possible to subscribe to bitcoin-dev list without using the browser? captcha doesn't work on tor 08:18 -!- arowser [~arowser1@67.230.166.11] has quit [Ping timeout: 260 seconds] 08:19 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has quit [Ping timeout: 240 seconds] 08:19 -!- kljasdfvv [~flack@p200300d46f11fb003452f513203d2a59.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!] 08:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:21 < bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/007e15dcd7f8...40a04814d130 08:21 < bitcoin-git> bitcoin/master 1a1c23f John Newbery: [net processing] Change cs_main TRY_LOCK to LOCK in SendMessages() 08:21 < bitcoin-git> bitcoin/master a1d5a42 John Newbery: [net processing] Fix bad indentation in SendMessages() 08:21 < bitcoin-git> bitcoin/master a49781e John Newbery: [net processing] Only call MaybeDiscourageAndDisconnect from SendMessages 08:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:21 < bitcoin-git> [bitcoin] laanwj merged pull request #19472: [net processing] Reduce cs_main scope in MaybeDiscourageAndDisconnect() (master...2020-07-tidyup-maybediscourage) https://github.com/bitcoin/bitcoin/pull/19472 08:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:21 -!- hollowleviathan1 [~hollowlev@178.239.168.171] has joined #bitcoin-core-dev 08:22 -!- hollowleviathan1 is now known as Guest1131 08:30 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 08:34 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 08:36 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 08:37 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev 08:38 -!- arowser [~arowser1@67.230.166.11] has quit [Remote host closed the connection] 08:38 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev 08:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:45 < bitcoin-git> [bitcoin] jnewbery opened pull request #19583: Clean up Misbehaving() (master...2020-07-tidy-misbehavior) https://github.com/bitcoin/bitcoin/pull/19583 08:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:50 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection] 08:51 -!- michagogo [uid14316@wikia/Michagogo] has joined #bitcoin-core-dev 08:58 -!- smurfjack [~smurfjack@180.162.105.124] has quit [Quit: Leaving] 09:00 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 09:02 -!- vincenzopalazzo [~vincent@host-87-20-89-251.retail.telecomitalia.it] has joined #bitcoin-core-dev 09:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:05 < bitcoin-git> [bitcoin] ecurrencyhodler opened pull request #19584: doc: Update obsolete links to online reference #19582 (master...patch-1) https://github.com/bitcoin/bitcoin/pull/19584 09:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:17 -!- someone235 [uid419897@gateway/web/irccloud.com/x-bnpmmmyspwsvxyah] has joined #bitcoin-core-dev 09:18 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 09:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:20 < bitcoin-git> [bitcoin] stylesuxx opened pull request #19585: rpc: RPCResult Type of MempoolEntryDescription should be OBJ. (master...19579) https://github.com/bitcoin/bitcoin/pull/19585 09:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:23 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection] 09:24 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev 09:24 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection] 09:24 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev 09:26 < luke-jr> achow101: what else uniquely identifies a wallet? if sqlite doesn't have one, I suggest adding one explicitly from the start.. 09:42 -!- vincenzopalazzo [~vincent@host-87-20-89-251.retail.telecomitalia.it] has quit [Remote host closed the connection] 09:43 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Ping timeout: 256 seconds] 09:44 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev 09:45 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Remote host closed the connection] 09:45 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev 10:08 < cfields_> jnewbery: I just happened to see it here, haven't looked into it fully... 10:09 < cfields_> "Change cs_main TRY_LOCK to LOCK" IIRC the TRY_LOCK was _very_ important for making sure that peers are visited fairly. 10:11 < cfields_> I believe that change may significantly change how peers are processed. 10:11 < sipa> vasild: what do you need varint for? afaik it's not used in any public interface 10:12 < cfields_> I'll add it to my review queue. 10:12 < luke-jr> achow101: thanks for the explanation of rebase needed; I was quite confused, lol 10:13 -!- dongcarl [~dongcarl@unaffiliated/dongcarl] has joined #bitcoin-core-dev 10:13 -!- Pavlenex [~Thunderbi@178.220.159.79] has quit [Ping timeout: 256 seconds] 10:21 -!- dongcarl [~dongcarl@unaffiliated/dongcarl] has quit [Quit: The Lounge - https://thelounge.chat] 10:22 -!- dongcarl [~dongcarl@unaffiliated/dongcarl] has joined #bitcoin-core-dev 10:26 < jonatack> cfields_: TIL, interesting! 10:26 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev 10:27 < cfields_> jonatack: I'm struggling trying to remember the details. 10:28 < sipa> cfields_: i believe that a long time ago, during ProcessMessages cs_recv was held, and during SendMessages cs_send was held 10:28 < sipa> and the network thread would try to grab what wasn't locked, so sends could be done in parallel with ProcessMessages, and receives could be done in parallel with SendMessages, for the same peer 10:29 < sipa> i believe that's no longer the case, and SendMessages/ProcessMessages just grab send/recv locks whenever needed 10:29 < sipa> in particular, ProcessMessages doesn't lock cs_recv while validating a block... 10:29 < cfields_> sipa: maybe, but there's something about taking cs_main and stalling the processing pipeline. 10:30 < sipa> nothing in net locks cs_main 10:31 -!- Pavlenex [~Thunderbi@178.220.159.79] has joined #bitcoin-core-dev 10:31 < cfields_> sipa: right, but now SendMessages is guaranteed to wait for cs_main for every peer, every run through the loop. 10:32 < cfields_> before that would've caused it to hop around peers due to randomly failing to grab the lock. 10:32 < cfields_> Now they'll be guaranteed processed in-order. 10:32 < sipa> right 10:32 < sipa> exactly which PR are you talking about, btw? 10:32 < cfields_> Which iirc was explicitly not desired at one point, though I can't remember why :( 10:33 < cfields_> #19472 10:33 < gribble> https://github.com/bitcoin/bitcoin/issues/19472 | [net processing] Reduce cs_main scope in MaybeDiscourageAndDisconnect() by jnewbery · Pull Request #19472 · bitcoin/bitcoin · GitHub 10:35 < sipa> cfields_: ah i see 10:35 < sipa> cfields_: i'm not sure this really matters, as nearly every message being processed for incoming messages also grabs cs_main 10:36 < cfields_> sipa: sure, for post-handshake peers :) 10:37 < cfields_> you're right though. I'm struggling to remember how this could've been significant. 10:38 -!- Giszmo1 [~leo@pc-34-189-46-190.cm.vtr.net] has quit [Ping timeout: 264 seconds] 10:46 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Ping timeout: 240 seconds] 10:49 -!- Pavlenex [~Thunderbi@178.220.159.79] has quit [Quit: Pavlenex] 10:54 -!- Giszmo [~leo@201.219.236.126] has joined #bitcoin-core-dev 10:57 < cfields_> sipa: that's what it is... ProcessMessages and SendMessages are called together, as "we have a message to process" is what we use as a proxy for "maybe we should send some stuff too". Now the SendMessages are all guaranteed to run to the end, so we'll be spending more time in there now than before. I have no idea what the hit/miss ratio looked like before, so I'm not sure if that's significant. 10:58 < cfields_> *TRY_LOCK hit/miss 11:00 -!- Guest1131 [~hollowlev@178.239.168.171] has quit [] 11:03 -!- Pavlenex [~Thunderbi@178.220.159.79] has joined #bitcoin-core-dev 11:08 -!- Pavlenex [~Thunderbi@178.220.159.79] has quit [Quit: Pavlenex] 11:08 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 11:09 -!- michagogo [uid14316@wikia/Michagogo] has quit [Quit: Connection closed for inactivity] 11:11 < achow101> luke-jr: the full file path to the wallet should be sufficient 11:11 -!- Giszmo [~leo@201.219.236.126] has quit [Ping timeout: 240 seconds] 11:11 < achow101> As a unique identifier 11:13 < sdaftuar> cfields_: does that mean that if a user is doing a bunch of RPC calls that are grabbing cs_main, we might let our receive buffers fill up more? 11:13 < sdaftuar> that seems like a plausible reason why the old behavior might have been desirable i guess 11:14 < cfields_> sdaftuar: not on the socket side, but on the processing side, yes. 11:15 < cfields_> sdaftuar: but like sipa said, something would be bound to take cs_main eventually anyway. 11:16 < luke-jr> achow101: not if the user moves it 11:17 < sipa> luke-jr: i think it makes sense to be able to give a warning to detect a (fork of) a wallet file being loaded multiple times, but it's not really as necessary as it was with bdb (which would give annoying errors if you had the same db opened twice in the same env) 11:17 < cfields_> sdaftuar: the more I think about it, the more I think it was probably just a way of throttling SendMessages to be called less often than every run through the message handler loop. 11:17 < sipa> luke-jr: we could do the check at a more semantic level... like do you have multiple wallets watching the same addresses 11:18 < cfields_> s/to be called/to fully execute/ 11:18 < achow101> luke-jr: you're persisting the IDs? 11:19 < sipa> cfields_, sdaftuar: in that scenario i think the difference is spinning through SendMessages and blocking on the first ProcessMessages that needs cs_main, vs blocking immediately in SendMessages 11:20 < sipa> i don't think that's a big difference 11:21 < luke-jr> sipa: this isn't for detecting forks.. 11:21 -!- ds [~ds@77.243.177.38] has joined #bitcoin-core-dev 11:22 < sipa> luke-jr: i mean forks in the history of the wallet file; not blockchain forks 11:22 < luke-jr> achow101: yes, that's the whole point 11:22 -!- ds is now known as Guest78261 11:22 < luke-jr> sipa: right 11:22 < luke-jr> sipa: what I'm doing in that PR, is preventing pruning if we know we have a wallet that needs the blocks for syncing 11:22 < cfields_> sipa: I agree with that. I drop the cs_main objection. I am still concerned about the time spent in that function, though. Will follow-up with jnewbery for some before/after benchmarks. 11:23 < sipa> cfields_: i think post-move-to-more-net_processing-and-it-having-its-own-lock(s), there are more opportunities to do conditional processing anyway 11:23 < luke-jr> sipa: once the wallet is synced, we want pruning to continue, so it uses the fileid to track the prune lock 11:23 < achow101> luke-jr: I guess you could add an id record.. 11:23 < sdaftuar> sipa: i think the differene is that in SendMessages, if you were waiting a long time before you get invoked, then you might be sending stale data to your peers 11:24 < luke-jr> achow101: bdb already has this, it's just sqlite where we'd need to add it 11:24 < luke-jr> which is fine since sqlite has no existing wallets yet 11:24 < luke-jr> (and if we migrate bdb to sqlite someday, we can migrate fileid) 11:24 < sipa> luke-jr: i'm not really a fan of mixing a dblayer identifier with an application level identifier 11:25 < sipa> if you import a descriptors from one wallet file into another, shouldn't that also be treated as a duplicate? 11:25 < luke-jr> dunno 11:25 < luke-jr> syncing the new one won't sync the old one if you still have it around 11:25 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection] 11:26 < sdaftuar> actually, scratch what i said, i misremembered how those ProcessMessages/SendMessages calls work 11:26 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 11:26 < cfields_> sdaftuar: right, the actual sends are happening async :) 11:27 < luke-jr> sipa: it's not the keys in the wallet that matter for this per se, but the state of the sync of the wallet 11:27 < luke-jr> which isn't really correlated with the descriptor 11:28 < sipa> luke-jr: i see 11:31 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection] 11:31 -!- jarthur [~jarthur@2605:6000:1019:48d9:8946:f571:eb85:d5a] has joined #bitcoin-core-dev 11:31 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev 11:34 -!- grubles [~user@gateway/tor-sasl/grubles] has quit [Ping timeout: 240 seconds] 11:34 < achow101> luke-jr: I suppose it's fine to use the bdb I'd. But I would prefer if you didn't use WalletDatabaseFileId. A uint160 should work, the id is 20 bytes 11:34 -!- grubles [~user@gateway/tor-sasl/grubles] has joined #bitcoin-core-dev 11:36 -!- Giszmo [~leo@pc-34-189-46-190.cm.vtr.net] has joined #bitcoin-core-dev 11:36 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Ping timeout: 244 seconds] 11:38 -!- jarthur [~jarthur@2605:6000:1019:48d9:8946:f571:eb85:d5a] has quit [Ping timeout: 244 seconds] 11:46 -!- reardencode [~reardenco@shrugged.reardencode.com] has quit [Ping timeout: 256 seconds] 11:46 < luke-jr> achow101: well, I'm turning it into a std::string in CWallet - maybe I should do that at the WalletDatabase level? 11:47 < achow101> That would be preferable 12:01 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Ping timeout: 246 seconds] 12:01 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 12:02 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev 12:03 -!- jarthur [~jarthur@2605:6000:1019:48d9:7d6c:8299:b34:254c] has joined #bitcoin-core-dev 12:10 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 12:11 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 12:35 -!- roconnor_ [~roconnor@host-45-78-193-20.dyn.295.ca] has joined #bitcoin-core-dev 12:36 -!- roconnor [~roconnor@host-45-78-193-20.dyn.295.ca] has quit [Disconnected by services] 12:36 -!- roconnor_ is now known as roconnor 12:38 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 13:06 < jnewbery> cfields_: Just catching up on this now. Thanks for looking at the PR. 13:06 < jnewbery> My understanding was that the TRY_LOCK was added to fix a potential deadlock between cs_main and cs_vSend, introduced in #1117 13:06 < gribble> https://github.com/bitcoin/bitcoin/issues/1117 | Fix potential deadlock by sipa · Pull Request #1117 · bitcoin/bitcoin · GitHub 13:07 < jnewbery> I expect that the hit ratio for that TRY_LOCK is almost 1 (ie we get the lock almost always), because other threads don't hold cs_main very much 13:08 < jnewbery> unless you're really hammering the RPC with something that takes cs_main, but even then it'd be difficult 13:10 -!- cryptapus_ is now known as cryptapus 13:16 -!- Andrew [b9bda1a2@185.189.161.162] has joined #bitcoin-core-dev 13:18 -!- Andrew [b9bda1a2@185.189.161.162] has quit [Remote host closed the connection] 13:19 -!- frogger [b9bda1a2@185.189.161.162] has joined #bitcoin-core-dev 13:23 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 13:27 -!- arowser [~arowser1@67.230.166.11] has quit [Ping timeout: 240 seconds] 13:28 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev 13:39 -!- frogger [b9bda1a2@185.189.161.162] has quit [Remote host closed the connection] 13:41 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection] 13:41 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev 13:45 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Ping timeout: 240 seconds] 13:47 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 13:55 -!- S3RK [~s3rk@116.118.68.191] has joined #bitcoin-core-dev 13:58 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 14:00 -!- Guest78261 [~ds@77.243.177.38] has quit [] 14:00 -!- filchef [~filchef@212.104.97.177] has quit [Quit: KVIrc 5.0.0 Aria http://www.kvirc.net/] 14:01 -!- S3RK [~s3rk@116.118.68.191] has quit [Ping timeout: 244 seconds] 14:08 -!- S3RK [~s3rk@116.118.68.191] has joined #bitcoin-core-dev 14:12 -!- S3RK [~s3rk@116.118.68.191] has quit [Ping timeout: 246 seconds] 14:12 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev 14:21 -!- Antimatter [~Antimatte@84.39.116.180] has joined #bitcoin-core-dev 14:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:21 < bitcoin-git> [bitcoin] sanjaykdragon opened pull request #19586: REFACTOR: moved from percent format to proper format for consistency (master...master) https://github.com/bitcoin/bitcoin/pull/19586 14:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:21 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Ping timeout: 240 seconds] 14:24 -!- S3RK [~s3rk@116.118.68.191] has joined #bitcoin-core-dev 14:29 -!- S3RK [~s3rk@116.118.68.191] has quit [Ping timeout: 260 seconds] 14:31 -!- S3RK [~s3rk@116.118.68.191] has joined #bitcoin-core-dev 14:32 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Ping timeout: 246 seconds] 14:34 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:35 -!- S3RK [~s3rk@116.118.68.191] has quit [Ping timeout: 260 seconds] 14:36 -!- Giszmo [~leo@pc-34-189-46-190.cm.vtr.net] has quit [Ping timeout: 265 seconds] 14:38 -!- sipsorcery [~sipsorcer@2a02:8084:6981:78f0:2e0:67ff:fe09:9b12] has quit [Ping timeout: 272 seconds] 14:39 -!- sipsorcery [~sipsorcer@37.228.243.107] has joined #bitcoin-core-dev 14:39 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev 14:40 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 14:40 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection] 14:41 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 14:46 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Ping timeout: 244 seconds] 14:48 < yanmaani> What's the purpose of the options objects in RPCs, such as bumpfee? 14:48 < yanmaani> couldn't you just leave them as normal root-level named params? 14:49 < luke-jr> yanmaani: if you want an ugly interface.. 14:49 < yanmaani> luke-jr: how do you mean? Aren't named params optional? 14:49 < sipa> yanmaani: ootions objects existed before we supported named params 14:49 < luke-jr> yanmaani: foo(1, null, null, null, null, null, null, null, null, null, 2) is super ugly 14:50 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 14:50 < sipa> and it makes the positional interface pretty annoying 14:50 < sipa> as luke-jr points out 14:50 < luke-jr> yanmaani: after #17356 I have a commit that allows mixing options in with the usual named params 14:50 < gribble> https://github.com/bitcoin/bitcoin/issues/17356 | RPC: Internal named params by luke-jr · Pull Request #17356 · bitcoin/bitcoin · GitHub 14:50 < yanmaani> Oh wait, so named args are sort of positional at the same time? 14:50 < yanmaani> Couldn't you just have all the named args at the end? Or would you still need nulls 14:51 < luke-jr> yanmaani: root-level are positional 14:51 < sipa> yanmaani: internally everything is positional 14:51 < promag> yanmaani: 14:51 < yanmaani> Are named args positional? 14:51 < luke-jr> yanmaani: you'd need nulls to get to the option you want 14:51 < promag> ops 14:51 < sipa> yanmaani: they're mapped to positional arguments internally 14:51 < yanmaani> luke-jr: Can't I write option=value? 14:51 < luke-jr> positional arguments only make sense for things you would normally specify for every/common use case 14:51 < luke-jr> yanmaani: only if you're using named params 14:52 < sipa> yanmaani: the external interface supports both named or positional, as json-rpc specifies 14:52 -!- Giszmo [~leo@201.219.234.97] has joined #bitcoin-core-dev 14:52 < sipa> internally every named argument is just mapped to an internal positional on3 14:52 < yanmaani> Ohh. So you don't want them because of that reason? 14:52 < sipa> yanmaani: i don't think this matters 14:52 < luke-jr> yanmaani: the only reason for args to be root-level, is for them to be used positionally 14:52 < yanmaani> If someone is using something where they can only use positional args, then you don't want them to write null, null, null, ... 14:53 < sipa> even if things were implemented differently internally, we still want to support a usable.positional interface 14:53 < promag> yanmaani: if you read rpc method implementations then you see that params are read with index, like param[2].. 14:54 < yanmaani> luke-jr: Well it's a bit cleaner to write rpccall true 1 foo=bar asd=asd than rpccall true 1 '{"foo": "bar", "asd": "asd"}' 14:54 < luke-jr> sipa: implementing it differently would enable naming options without an options={…} though 14:54 < sipa> luke-jr: right 14:54 < luke-jr> yanmaani: JSON-RPC doesn't allow that 14:54 < promag> yanmaani: you mean on the console? 14:54 < yanmaani> So the names are just cosmetic? 14:54 < yanmaani> promag: yeah 14:54 < luke-jr> yanmaani: JSON-RPC only allows ALL positional or ALL named 14:54 < luke-jr> options is how we can get both 14:54 < yanmaani> oh. 14:54 < yanmaani> nice 14:55 < yanmaani> And if you're using all named, then you still need a fallback all-named API? 14:55 < sipa> you mean all-positionalm 14:55 < sipa> ? 14:56 < promag> rpccall true 1 foo=bar asd=asd <----- you are mixing here 14:56 < sipa> tbh, i never use the named interface 14:57 < promag> sipa: I though you use brain-ipc-foo 14:57 < yanmaani> sipa: yes 14:57 < yanmaani> a fallback all-pos 14:57 < sipa> right, we need some way of supporting an all-pos interface 14:58 < sipa> i wouldn't call it fallback - it's just one of the two supported interfacez 14:58 < yanmaani> Oh. Nice. 14:58 < sipa> promag: lol 14:59 < promag> what was the motivation for named params btw? 14:59 < sipa> json-rpc specifies them 14:59 < luke-jr> XD 14:59 < sipa> and in some contexts, i think they're useful 14:59 -!- samry [18075af6@c-24-7-90-246.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 14:59 < promag> it's not mandatory is it? 14:59 < sipa> though i hacen't seen much need personally 15:00 < promag> for methods with optional params then yeah, named is cool 15:00 < sipa> promag: it is not clear from the spec, to me 15:00 < sipa> whether thet're required to be supported on the server side or not 15:01 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection] 15:01 < promag> commit -m "drop rpc, add graphql" 15:03 < promag> jk, long live json-rpc, its awesome 15:04 < sipa> i think we need x86-rpc; the client sends a bit of x86 assembly to the server, which executes it 15:04 < sipa> it's extremely flexible! 15:05 < promag> ack 15:08 -!- Highway62 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev 15:09 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Ping timeout: 260 seconds] 15:09 -!- Highway62 is now known as Highway61 15:11 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Remote host closed the connection] 15:12 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection] 15:13 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 15:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 15:17 -!- grubles [~user@gateway/tor-sasl/grubles] has quit [Quit: leaving] 15:18 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 15:21 -!- sipsorcery [~sipsorcer@37.228.243.107] has quit [Ping timeout: 258 seconds] 15:21 -!- sipsorcery [~sipsorcer@37.228.243.107] has joined #bitcoin-core-dev 15:25 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev 15:26 -!- isis_ is now known as isis 15:27 -!- Giszmo [~leo@201.219.234.97] has quit [Ping timeout: 256 seconds] 15:37 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 15:37 -!- gzhao408 [~textual@c-73-252-251-3.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 15:42 -!- Giszmo [~leo@pc-34-189-46-190.cm.vtr.net] has joined #bitcoin-core-dev 15:44 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 15:45 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds] 15:48 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 246 seconds] 15:59 -!- Giszmo [~leo@pc-34-189-46-190.cm.vtr.net] has quit [Ping timeout: 240 seconds] 16:01 -!- arowser [~arowser1@67.230.166.11] has quit [Remote host closed the connection] 16:04 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev 16:05 -!- Giszmo [~leo@pc-34-189-46-190.cm.vtr.net] has joined #bitcoin-core-dev 16:12 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev 16:16 -!- jarthur_ [~jarthur@2605:6000:1019:48d9:4470:f4b9:100a:d26a] has joined #bitcoin-core-dev 16:20 -!- jarthur [~jarthur@2605:6000:1019:48d9:7d6c:8299:b34:254c] has quit [Ping timeout: 244 seconds] 16:25 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 16:25 -!- sipsorcery [~sipsorcer@37.228.243.107] has quit [Ping timeout: 240 seconds] 16:36 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection] 16:37 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev 16:41 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Ping timeout: 260 seconds] 16:43 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev 16:44 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Remote host closed the connection] 16:45 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has joined #bitcoin-core-dev 16:46 -!- jarthur_ [~jarthur@2605:6000:1019:48d9:4470:f4b9:100a:d26a] has quit [Remote host closed the connection] 16:47 < instagibbs> named params are super helpful when you have an rpc call with 9+ args :) 16:47 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 16:49 -!- proofofkeags [~proofofke@c-65-50-169-164.hs.gigamonster.net] has quit [Ping timeout: 240 seconds] 16:54 -!- jarthur [~jarthur@2605:6000:1019:48d9:4470:f4b9:100a:d26a] has joined #bitcoin-core-dev 16:55 -!- marcoagner [~user@bl11-17-219.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 16:58 -!- jarthur [~jarthur@2605:6000:1019:48d9:4470:f4b9:100a:d26a] has quit [Remote host closed the connection] 16:58 -!- sipsorcery [~sipsorcer@37.228.243.107] has joined #bitcoin-core-dev 17:00 -!- Antimatter [~Antimatte@84.39.116.180] has quit [] 17:01 -!- jarthur [~jarthur@2605:6000:1019:48d9:899:88ce:94dd:84d6] has joined #bitcoin-core-dev 17:03 -!- seanicided [~sseanicid@clwdon2201w-lp140-02-142-112-161-69.dsl.bell.ca] has quit [Remote host closed the connection] 17:05 -!- jarthur [~jarthur@2605:6000:1019:48d9:899:88ce:94dd:84d6] has quit [Ping timeout: 260 seconds] 17:06 < achow101> Sometimes (read: usually) I think it was a mistake to add wallet type options as bools to createwallet 17:06 < achow101> Should've made that an "options" arg 17:07 < luke-jr> yes 17:07 < luke-jr> not too late to fix tho? 17:08 < achow101> We could add one at the end but that wouldn't necessarily make things better since we still need to keep the existing ones 17:08 < luke-jr> could replace the existing ones, and just interpret bools compatibly for a few releases 17:09 < achow101> I suppose so 17:09 < achow101> Forgot that was a thing we did 17:19 -!- samry [18075af6@c-24-7-90-246.hsd1.ca.comcast.net] has quit [Remote host closed the connection] 17:21 -!- RhodiumToad1 [~RhodiumTo@84.39.116.180] has joined #bitcoin-core-dev 17:29 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 17:33 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 17:34 -!- sipsorcery [~sipsorcer@37.228.243.107] has quit [Ping timeout: 240 seconds] 17:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 17:52 -!- Davterra [~Davterra@193.32.127.227] has quit [Read error: Connection reset by peer] 17:53 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 17:53 -!- Davterra [~Davterra@193.32.127.227] has joined #bitcoin-core-dev 17:58 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Ping timeout: 244 seconds] 17:58 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 18:01 -!- arowser [~arowser1@67.230.166.11] has quit [Remote host closed the connection] 18:01 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 18:06 -!- arowser [~arowser1@67.230.166.11] has quit [Remote host closed the connection] 18:08 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 18:11 -!- Davterra [~Davterra@193.32.127.227] has quit [Read error: Connection reset by peer] 18:12 -!- Davterra [~Davterra@193.32.127.227] has joined #bitcoin-core-dev 18:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 244 seconds] 18:17 -!- roconnor [~roconnor@host-45-78-193-20.dyn.295.ca] has quit [Ping timeout: 246 seconds] 18:17 -!- gzhao408 [~textual@c-73-252-251-3.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 18:18 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 18:33 -!- niska [~niska@static.38.6.217.95.clients.your-server.de] has quit [Quit: Leaving] 18:33 -!- IGHOR [~quassel@176.121.4.135] has quit [Quit: No Ping reply in 180 seconds.] 18:34 -!- IGHOR [~quassel@176.121.4.135] has joined #bitcoin-core-dev 18:36 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection] 18:36 -!- niska [~niska@static.38.6.217.95.clients.your-server.de] has joined #bitcoin-core-dev 18:37 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev 18:47 -!- roconnor [~roconnor@host-184-164-1-116.dyn.295.ca] has joined #bitcoin-core-dev 18:55 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 19:08 -!- Netsplit *.net <-> *.split quits: niska, da2ce7_, NicolasDorier, someone235, dongcarl, justanotheruser, Zenton 19:08 -!- Netsplit *.net <-> *.split quits: petezz4_, DougieBot5000, luke-jr, CodeShark___, Mercury_Vapor, esotericnonsense, dkrm, nullptr|, fanquake, qubenix, (+202 more, use /NETSPLIT to show all of them) 19:14 -!- Netsplit over, joins: RubenSomsen, nothingmuch, _0x0ff, provoostenator, marcinja, dkrm, petezz4_, Lexyon___, lesderid, kinlo 19:14 -!- someone235 [uid419897@gateway/web/irccloud.com/x-jsctuxyumfxvlhqb] has joined #bitcoin-core-dev 19:14 -!- Netsplit over, joins: fjahr, felixweis, harding, stevenroose, aj, amiti, takinbo, waxwing, jeremyrubin, jonatack (+125 more) 19:14 -!- esotericnonsense [~esotericn@static.116.206.47.78.clients.your-server.de] has joined #bitcoin-core-dev 19:14 -!- Netsplit over, joins: justanotheruser, NicolasDorier, da2ce7_ 19:14 -!- drbrule [sid395654@gateway/web/irccloud.com/x-kanoriwwwwrnvtek] has joined #bitcoin-core-dev 19:14 -!- Netsplit over, joins: so, kanzure, bsm117532, CubicEarth, sanket1729, willcl_ark, gwillen, Victorsueca, instagibbs, nickler (+46 more) 19:15 -!- someone235 [uid419897@gateway/web/irccloud.com/x-jsctuxyumfxvlhqb] has quit [Changing host] 19:15 -!- someone235 [uid419897@unaffiliated/someone235] has joined #bitcoin-core-dev 19:15 -!- Netsplit over, joins: Bullit 19:15 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 19:15 -!- Netsplit *.net <-> *.split quits: petezz4_, arik__, arowser, Processus42, Bullit, justinmoon, spinza, Highway61, jamesob, DougieBot5000, (+121 more, use /NETSPLIT to show all of them) 19:15 -!- Netsplit *.net <-> *.split quits: warren 19:15 -!- Netsplit *.net <-> *.split quits: comboy, rockhouse 19:15 -!- Netsplit *.net <-> *.split quits: jimpo, ariard 19:16 -!- Netsplit *.net <-> *.split quits: fanquake, qubenix, dgenr8, cornfeedhobo, shigeya, yanmaani, bsm117532, Zenton, morcos, ghost43, (+63 more, use /NETSPLIT to show all of them) 19:19 -!- Netsplit over, joins: kanzure, Anduck, Cory, Eliel, thrasher, adam3us, ensign, kakobrekla, frogar 19:19 -!- valwal_ [sid334773@gateway/web/irccloud.com/x-skdjatjtpmrtqhqb] has joined #bitcoin-core-dev 19:19 -!- SergeySherkunov[ [leinlawunm@gateway/shell/matrix.org/x-svxabrnnehavfsfe] has joined #bitcoin-core-dev 19:19 -!- Netsplit over, joins: Victorsueca, CubicEarth, instagibbs, rabidus, qubenix, Zenton, tynes, jrayhawk, CodeShark___, mdunnio (+7 more) 19:19 -!- someone235 [uid419897@gateway/web/irccloud.com/x-ddezuxjzkvsewcxq] has joined #bitcoin-core-dev 19:19 -!- Netsplit over, joins: roconnor, Davterra, jonatack, Jackielove4u, jeremyrubin, cato_, GoldmanSats, dgenr8, pinheadmz, adiabat (+130 more) 19:19 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 244 seconds] 19:19 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Remote host closed the connection] 19:20 -!- Netsplit over, joins: gwillen, willcl_ark, sanket1729, Lightsword, wullon5, bsm117532, chjj, raj_, dlb76, cryptapus (+13 more) 19:20 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev 19:20 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 19:20 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has joined #bitcoin-core-dev 19:20 -!- amiti [sid373138@gateway/web/irccloud.com/session] has joined #bitcoin-core-dev 19:20 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has quit [Remote host closed the connection] 19:20 -!- amiti [sid373138@gateway/web/irccloud.com/session] has quit [Changing host] 19:20 -!- amiti [sid373138@gateway/web/irccloud.com/x-ydvnpfgtsutkxdez] has joined #bitcoin-core-dev 19:20 -!- vfP56jSe [sid321684@gateway/web/irccloud.com/x-pwrkfklrxpbpmsjo] has joined #bitcoin-core-dev 19:20 -!- Netsplit over, joins: stackingcore21 19:20 -!- drbrule [sid395654@gateway/web/irccloud.com/x-yqpepggnfuxnzbmd] has joined #bitcoin-core-dev 19:21 -!- Netsplit over, joins: achow101, cdecker, mdrollette, jonasschnelli, mr_burdell, btc_thc 19:21 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has joined #bitcoin-core-dev 19:21 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 19:21 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 19:22 -!- jakesyl [sid56879@gateway/web/irccloud.com/x-vhpvzrcxhrnukhbu] has joined #bitcoin-core-dev 19:22 -!- berndj [~berndj@ns1.linksynergy.co.za] has joined #bitcoin-core-dev 19:22 -!- elichai2 [sid212594@gateway/web/irccloud.com/x-tsdkusvosotobleb] has joined #bitcoin-core-dev 19:22 -!- RubenSomsen [sid301948@gateway/web/irccloud.com/x-gasdhhiyorhasrtn] has joined #bitcoin-core-dev 19:24 -!- jnewbery [~john@164.90.178.190] has joined #bitcoin-core-dev 19:24 -!- peltre [sid268329@gateway/web/irccloud.com/x-mcgnksoyzsyeokqf] has joined #bitcoin-core-dev 19:24 -!- Henry151 [~bishop@ns3007530.ip-151-80-44.eu] has joined #bitcoin-core-dev 19:24 -!- ahmed_ [sid14086@gateway/web/irccloud.com/x-felvqsaxhbpclvkf] has joined #bitcoin-core-dev 19:34 -!- infernix [nix@unaffiliated/infernix] has joined #bitcoin-core-dev 19:38 -!- awesome-doge [lplplpmatr@gateway/shell/matrix.org/x-somhdjwicrgxovyi] has joined #bitcoin-core-dev 19:38 -!- TheFuzzStone[m] [thefuzzsto@gateway/shell/matrix.org/x-gopsgvoatplwrlyy] has joined #bitcoin-core-dev 19:38 -!- infamously[m] [infamously@gateway/shell/matrix.org/x-powuqxjtzzcfdufr] has joined #bitcoin-core-dev 19:39 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Ping timeout: 260 seconds] 19:40 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev 19:43 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Ping timeout: 240 seconds] 19:51 -!- arowser [~arowser1@67.230.166.11] has quit [Ping timeout: 240 seconds] 19:52 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has joined #bitcoin-core-dev 19:58 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 19:59 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has quit [Remote host closed the connection] 20:00 -!- RhodiumToad1 [~RhodiumTo@84.39.116.180] has quit [] 20:00 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has joined #bitcoin-core-dev 20:04 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has quit [Ping timeout: 240 seconds] 20:21 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 20:22 -!- Y_Ichiro [~Y_Ichiro@185.189.114.11] has joined #bitcoin-core-dev 20:27 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has joined #bitcoin-core-dev 20:34 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 20:34 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 20:41 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev 20:46 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 20:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 258 seconds] 20:57 -!- arowser [~arowser1@67.230.166.11] has quit [Ping timeout: 240 seconds] 20:58 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has quit [Remote host closed the connection] 20:58 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has joined #bitcoin-core-dev 21:03 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has quit [Ping timeout: 264 seconds] 21:09 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev 21:15 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 21:22 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 244 seconds] 21:59 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 240 seconds] 22:04 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev 22:28 -!- S3RK [~s3rk@116.118.71.29] has joined #bitcoin-core-dev 22:29 -!- S3RK [~s3rk@116.118.71.29] has quit [Client Quit] 22:48 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 23:00 -!- Y_Ichiro [~Y_Ichiro@185.189.114.11] has quit [] 23:00 -!- awesome-doge [lplplpmatr@gateway/shell/matrix.org/x-somhdjwicrgxovyi] has quit [Quit: Idle for 30+ days] 23:01 -!- SergeySherkunov[ [leinlawunm@gateway/shell/matrix.org/x-svxabrnnehavfsfe] has quit [Quit: Idle for 30+ days] 23:17 -!- go11111111111 [go1111111@gateway/vpn/privateinternetaccess/go1111111] has joined #bitcoin-core-dev 23:20 -!- go121212 [~go1111111@104.156.98.86] has quit [Ping timeout: 260 seconds] 23:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 23:22 -!- clintbellanger [~clintbell@178.162.212.214] has joined #bitcoin-core-dev 23:37 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Ping timeout: 240 seconds] 23:41 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Ping timeout: 256 seconds] 23:42 -!- arowser [~arowser1@67.230.166.11] has joined #bitcoin-core-dev 23:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:45 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #18991: Cache responses to GETADDR to prevent topology leaks (master...2020-05-addr-response-caching) https://github.com/bitcoin/bitcoin/pull/18991 23:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:45 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 246 seconds] 23:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:45 < bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18991: Cache responses to GETADDR to prevent topology leaks (master...2020-05-addr-response-caching) https://github.com/bitcoin/bitcoin/pull/18991 23:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:46 -!- vincenzopalazzo [~vincent@host-87-20-89-251.retail.telecomitalia.it] has joined #bitcoin-core-dev 23:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:47 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #19471: util: Make default arg values more specific (master...200708-hint) https://github.com/bitcoin/bitcoin/pull/19471 23:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:47 < bitcoin-git> [bitcoin] MarcoFalke reopened pull request #19471: util: Make default arg values more specific (master...200708-hint) https://github.com/bitcoin/bitcoin/pull/19471 23:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] --- Log closed Sat Jul 25 00:00:29 2020