--- Log opened Mon Aug 03 00:00:39 2020 00:15 -!- marcoagner [~user@2001:8a0:6a45:1900:2fd7:e0f0:d356:dd70] has joined #bitcoin-core-dev 00:19 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has quit [Quit: Find me in #TheHolyRoger or https://theholyroger.com] 00:21 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has joined #bitcoin-core-dev 00:36 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 244 seconds] 00:43 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 00:48 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Quit: jonatack] 00:48 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 265 seconds] 00:56 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 00:57 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 01:00 -!- arowser_ [~arowser1@192.69.88.248] has quit [Ping timeout: 246 seconds] 01:00 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 01:02 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 256 seconds] 01:21 -!- victorSN [~victorSN@unaffiliated/victorsn] has quit [Remote host closed the connection] 01:21 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has quit [Remote host closed the connection] 01:24 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has joined #bitcoin-core-dev 01:24 -!- victorSN [~victorSN@unaffiliated/victorsn] has joined #bitcoin-core-dev 01:28 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:31 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has joined #bitcoin-core-dev 01:35 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has quit [Ping timeout: 256 seconds] 01:38 -!- arowser_ [~arowser1@192.69.88.248] has quit [Ping timeout: 240 seconds] 01:38 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 01:40 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 01:40 -!- arowser_ [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev 01:41 -!- arowser_ [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection] 01:41 -!- arowser_ [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev 01:53 -!- arowser_ [~arowser1@192.69.88.248.16clouds.com] has quit [Ping timeout: 256 seconds] 01:56 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 02:00 -!- Snuupy1 [~Snuupy@217.146.82.202] has quit [] 02:01 -!- wullon5 [~wullon@241.243.86.88.rdns.comcable.net] has quit [Ping timeout: 256 seconds] 02:04 -!- SergeySherkunov[ [leinlawunm@gateway/shell/matrix.org/x-cfparybdxnpwjhus] has quit [Quit: Idle for 30+ days] 02:05 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has joined #bitcoin-core-dev 02:06 -!- Pavlenex [~Thunderbi@185.244.212.67] has joined #bitcoin-core-dev 02:12 -!- BGL [~twenty@75-149-171-58-Washington.hfc.comcastbusiness.net] has quit [Ping timeout: 256 seconds] 02:13 -!- infamously[m] [infamously@gateway/shell/matrix.org/x-zeyqpapkfqwalqfa] has left #bitcoin-core-dev [] 02:16 -!- jonas_ [~Jonas@200116b8244130006476a8cac024ff90.dip.versatel-1u1.de] has joined #bitcoin-core-dev 02:17 -!- Pavlenex [~Thunderbi@185.244.212.67] has quit [Quit: Pavlenex] 02:20 -!- Gunni1 [~Gunni@84.39.117.57] has joined #bitcoin-core-dev 02:21 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 02:24 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds] 02:25 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds] 02:31 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has quit [Remote host closed the connection] 02:31 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has joined #bitcoin-core-dev 02:33 -!- arowser_ [~arowser1@192.69.88.248] has quit [Ping timeout: 240 seconds] 02:36 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 02:36 -!- jonatack [~jon@134.19.179.235] has joined #bitcoin-core-dev 02:37 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 02:37 -!- jonatack [~jon@134.19.179.235] has quit [Read error: Connection reset by peer] 02:38 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has joined #bitcoin-core-dev 02:39 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 02:43 -!- jonatack [~jon@37.173.224.129] has joined #bitcoin-core-dev 02:44 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has quit [Remote host closed the connection] 02:45 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has joined #bitcoin-core-dev 02:49 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has quit [Ping timeout: 246 seconds] 02:53 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 02:53 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 02:56 -!- jonas_ [~Jonas@200116b8244130006476a8cac024ff90.dip.versatel-1u1.de] has quit [Quit: Leaving] 03:03 -!- Annie78Runte [~Annie78Ru@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev 03:05 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has joined #bitcoin-core-dev 03:08 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 03:11 -!- promag_ [~promag@31.22.163.178] has joined #bitcoin-core-dev 03:13 -!- arowser_ [~arowser1@192.69.88.248] has quit [Ping timeout: 264 seconds] 03:15 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 03:15 -!- BGL [~twenty@75-149-171-58-Washington.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 03:16 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Read error: Connection reset by peer] 03:16 -!- promag_ [~promag@31.22.163.178] has quit [Ping timeout: 246 seconds] 03:16 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has joined #bitcoin-core-dev 03:16 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 03:18 -!- wullon5 [~wullon@241.243.86.88.rdns.comcable.net] has joined #bitcoin-core-dev 03:22 < jnewbery> wumpus MarcoFalke fanquake: I think #18991 may be ready for merge. It's had a ton of review and has three ACKs on the most recent branch (and a bunch more ACKs/concept ACKs on previous branches) 03:22 < gribble> https://github.com/bitcoin/bitcoin/issues/18991 | Cache responses to GETADDR to prevent topology leaks by naumenkogs · Pull Request #18991 · bitcoin/bitcoin · GitHub 03:24 -!- Annie78Runte [~Annie78Ru@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 246 seconds] 03:27 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex] 03:28 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev 03:36 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Remote host closed the connection] 03:41 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has quit [Remote host closed the connection] 03:42 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 03:42 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 03:43 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 03:43 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 03:52 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev 03:55 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Read error: Connection reset by peer] 03:55 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev 03:55 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 03:58 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 03:58 -!- vasild_ is now known as vasild 04:02 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has joined #bitcoin-core-dev 04:06 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6c13:d9fa:5686:d5f0] has joined #bitcoin-core-dev 04:06 -!- jonatack [~jon@37.173.224.129] has quit [Read error: Connection reset by peer] 04:07 -!- promag [~promag@bl23-82-251.dsl.telepac.pt] has quit [Ping timeout: 260 seconds] 04:39 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6c13:d9fa:5686:d5f0] has quit [Remote host closed the connection] 04:40 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6c13:d9fa:5686:d5f0] has joined #bitcoin-core-dev 04:43 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has quit [Quit: Leaving] 04:44 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6c13:d9fa:5686:d5f0] has quit [Ping timeout: 260 seconds] 04:47 -!- IGHOR [~quassel@176.121.4.135] has quit [Ping timeout: 240 seconds] 04:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:47 < bitcoin-git> [bitcoin] S3RK opened pull request #19651: wallet: allow import same descriptor twice (master...importdescriptors_twice) https://github.com/bitcoin/bitcoin/pull/19651 04:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:48 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Ping timeout: 264 seconds] 04:49 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has joined #bitcoin-core-dev 04:49 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev 04:51 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 04:54 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Ping timeout: 246 seconds] 04:56 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev 05:00 -!- Gunni1 [~Gunni@84.39.117.57] has quit [] 05:02 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has joined #bitcoin-core-dev 05:02 < wumpus> jnewbery: thanks will take a look 05:08 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has quit [Remote host closed the connection] 05:08 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has joined #bitcoin-core-dev 05:12 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has quit [Read error: Connection reset by peer] 05:20 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds] 05:21 -!- langseth1 [~langseth@84.39.117.57] has joined #bitcoin-core-dev 05:21 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 05:24 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 05:31 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has joined #bitcoin-core-dev 05:44 -!- shesek [~shesek@164.90.217.137] has joined #bitcoin-core-dev 05:44 -!- shesek [~shesek@164.90.217.137] has quit [Changing host] 05:44 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 05:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:50 < bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/a78742830aa3...14ceddd29085 05:50 < bitcoin-git> bitcoin/master ded742b Gleb Naumenko: Move filtering banned addrs inside GetAddresses() 05:50 < bitcoin-git> bitcoin/master 7cc0e81 Gleb Naumenko: Remove useless 2500 limit on AddrMan queries 05:50 < bitcoin-git> bitcoin/master acd6135 Gleb Naumenko: Cache responses to addr requests 05:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:50 < bitcoin-git> [bitcoin] laanwj merged pull request #18991: Cache responses to GETADDR to prevent topology leaks (master...2020-05-addr-response-caching) https://github.com/bitcoin/bitcoin/pull/18991 05:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:57 -!- arowser_ [~arowser1@192.69.88.248] has quit [Ping timeout: 246 seconds] 05:57 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 06:03 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex] 06:06 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 06:06 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 06:08 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 06:08 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 06:09 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 06:09 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 06:10 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 06:10 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 06:11 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 06:11 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 06:13 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 06:13 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 06:23 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 06:24 -!- LuisAranguren [quassel@88s6l9d9m1hyljqp9fbs.ip6.superloop.com] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.] 06:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:26 < bitcoin-git> [bitcoin] hebasto opened pull request #19652: Add thread safety annotations to Mempool{Info}ToJSON() (master...200803-mmx-2) https://github.com/bitcoin/bitcoin/pull/19652 06:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:45 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 06:45 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has quit [Remote host closed the connection] 06:51 -!- Davterra [~Davterra@89.45.90.131] has quit [Quit: Leaving] 06:52 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 06:52 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 06:53 -!- Davterra [~Davterra@89.45.90.131] has joined #bitcoin-core-dev 06:53 < hebasto> jeremyrubin: did you see recent #18710 update and its benchmarks by martinus? 06:53 < gribble> https://github.com/bitcoin/bitcoin/issues/18710 | Add local thread pool to CCheckQueue by hebasto · Pull Request #18710 · bitcoin/bitcoin · GitHub 06:54 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 06:54 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 07:11 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection] 07:12 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 07:13 < aj> hebasto: why do you think adding GUARDED_BY is a design change? it's just those members existed before bitcoin source had thread safety annotations, as far as i know? 07:13 -!- Tralfaz [~Davterra@89.45.90.192] has joined #bitcoin-core-dev 07:14 < hebasto> aj: it changes class invariants 07:14 < aj> hebasto: no it doesn't? (or: i don't see how?) 07:14 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 07:14 < aj> hebasto: (i'd say that it *documents* class invariants, just like the rest of your pr) 07:15 -!- Davterra [~Davterra@89.45.90.131] has quit [Ping timeout: 256 seconds] 07:16 < hebasto> aj: ok, if new GUARDED_BY will not cause to introduce new need to acquire a lock somewhere 07:16 < aj> hebasto: seemed to work fine for me, fwiw 07:17 < aj> hebasto: (if it did demand a lock was acquired somewhere, i'd expect that to be a bug worth fixing anyway) 07:17 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has joined #bitcoin-core-dev 07:18 < hebasto> btw, `AssertLock{Not}Held` were my tools to transit `CTxMemPool::cs` to `RecursiveMutex` in #19306 07:18 < gribble> https://github.com/bitcoin/bitcoin/issues/19306 | refactor: Replace RecursiveMutex with Mutex in CTxMemPool by hebasto · Pull Request #19306 · bitcoin/bitcoin · GitHub 07:18 < aj> hebasto: yep 07:18 < hebasto> oops s/RecursiveMutex/Mutex/ 07:19 < aj> s/to/from/ would've been shorter 07:19 * hebasto :) 07:21 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has quit [Ping timeout: 264 seconds] 07:21 < hebasto> aj: sudden run-time error that were not caught by compile-time thread safety analysis could be (almost) eliminated with full annotation coverage 07:24 -!- Tralfaz [~Davterra@89.45.90.192] has quit [Remote host closed the connection] 07:25 < aj> hebasto: it crossed my mind that maybe DEBUG_LOCKORDER should check for accidental recursive locking attempts with Mutex (or even RecursiveMutex if it just logged a warning on first occurence or so?) 07:26 < aj> hebasto: hmm, "EX_LOCKS_REQ(!cs)" complaints are only warnings, not errors? 07:27 < hebasto> we could always pass -Werror, no? 07:28 < aj> hebasto: i thought we were? 07:29 < aj> no, apparently not? did i do configure wrong? 07:29 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 07:29 -!- Davterra [~Davterra@89.45.90.192] has joined #bitcoin-core-dev 07:29 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex] 07:29 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 07:30 < aj> ah, missed --enable-werror i guess? 07:30 < hebasto> by default `--enable-werror=no` 07:31 < aj> yeah, there's already '-Werror=thread-safety' by default 07:32 < aj> or not? 07:33 < hebasto> you should add `--enable-werror` 07:33 -!- rafalcpp [~racalcppp@ip-178-214.ists.pl] has joined #bitcoin-core-dev 07:34 < aj> yeah, have done so. weird i haven't felt forced to before 07:37 -!- Luke [~Luke@bitnomial/staff/luke] has joined #bitcoin-core-dev 07:39 < aj> hebasto: hmm, apart from a missing EXCLUSIVE_LOCKS_REQUIRED(!cs_wallet) in BlockUntilSyncedToCurrentChain(), it seems possible to annotate AssertLockNotHeldInternal with EXCLUSIVE_LOCKS_REQUIRED(!*cs) (have to templatize it to avoid "dereferencing" a void* too of course) 07:40 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 07:41 < hebasto> aj: did you see #19337 ? 07:41 -!- arowser_ [~arowser1@192.69.88.248] has quit [Read error: Connection reset by peer] 07:41 < gribble> https://github.com/bitcoin/bitcoin/issues/19337 | sync: detect double lock from the same thread by vasild · Pull Request #19337 · bitcoin/bitcoin · GitHub 07:41 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 07:47 < aj> hebasto: yay! 07:49 -!- Davterra [~Davterra@89.45.90.192] has quit [Remote host closed the connection] 07:51 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has joined #bitcoin-core-dev 08:00 -!- langseth1 [~langseth@84.39.117.57] has quit [] 08:00 -!- rafalcpp [~racalcppp@ip-178-214.ists.pl] has quit [Ping timeout: 264 seconds] 08:17 -!- Deinogalerix21 [~Deinogale@185.125.207.151] has joined #bitcoin-core-dev 08:18 -!- Deinogalerix21 [~Deinogale@185.125.207.151] has quit [Client Quit] 08:19 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Read error: Connection reset by peer] 08:19 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 08:20 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 08:22 -!- directhex1 [~directhex@217.146.82.202] has joined #bitcoin-core-dev 08:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:28 < bitcoin-git> [bitcoin] laanwj pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/14ceddd29085...34eb2362581d 08:28 < bitcoin-git> bitcoin/master 131a2f0 Pieter Wuille: scripted-diff: rename base_blob::data to m_data 08:28 < bitcoin-git> bitcoin/master 5678250 Pieter Wuille: Make uint256 Span-convertible by adding ::data() 08:28 < bitcoin-git> bitcoin/master e63dcc3 Pieter Wuille: Add MakeUCharSpan, to help constructing Span<[const] unsigned char> 08:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:28 < bitcoin-git> [bitcoin] laanwj merged pull request #19326: Simplify hash.h interface using Spans (master...202006_spanhashes) https://github.com/bitcoin/bitcoin/pull/19326 08:28 -!- rafalcpp [~racalcppp@ip-178-214.ists.pl] has joined #bitcoin-core-dev 08:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:39 < hebasto> aj: to feel safe a "clone" of `AssertLockHeld()` needed but without `ASSERT_EXCLUSIVE_LOCK()` 08:39 < hebasto> how it could be named? 08:39 < aj> hebasto: RequireLockHeld or ExpectLockHeld maybe? *shrug* 08:41 < hebasto> `RequireLockHeld` looks good! 08:47 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex] 08:57 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Ping timeout: 264 seconds] 08:59 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 09:03 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev 09:04 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 246 seconds] 09:08 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 09:08 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 09:19 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev 09:21 -!- Luke [~Luke@bitnomial/staff/luke] has quit [Quit: sleep] 09:22 < warren> jonasschnelli: hey. Curious whatever happened to BIP150 and 151. Did that end up getting rolled into a replacement BIP? 09:23 < sipa> warren: BIP324 will replace BIP151 09:24 < warren> thanks 09:25 < warren> is any authentication scheme currently favored in conjunction with this? 09:26 < sipa> we have some theoretic work, a successor to countersign, but nothing published 09:26 -!- jarthur [~jarthur@2605:6000:1019:48d9:5061:a54a:8d30:ccb1] has joined #bitcoin-core-dev 09:26 -!- jarthur [~jarthur@2605:6000:1019:48d9:5061:a54a:8d30:ccb1] has quit [Remote host closed the connection] 09:28 -!- jarthur_ [~jarthur@cpe-66-68-134-212.austin.res.rr.com] has quit [Read error: Connection reset by peer] 09:30 -!- Davterra [~Davterra@89.45.90.192] has joined #bitcoin-core-dev 09:46 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has quit [Remote host closed the connection] 09:49 -!- alko89 [~alko89@unaffiliated/alko89] has quit [Ping timeout: 240 seconds] 09:52 -!- Pavlenex [~Thunderbi@194.187.251.11] has joined #bitcoin-core-dev 10:01 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 10:01 -!- arowser_ [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev 10:06 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 10:11 -!- Davterra [~Davterra@89.45.90.192] has quit [Ping timeout: 256 seconds] 10:22 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Ping timeout: 265 seconds] 10:23 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Remote host closed the connection] 10:24 < jeremyrubin> Does the linter need to be kicked? 10:24 < jeremyrubin> https://travis-ci.org/github/bitcoin/bitcoin/jobs/714556846 10:25 < fjahr> jeremyrubin: seems so, I saw this yesterday: https://github.com/bitcoin/bitcoin/pull/19439#issuecomment-667732466 10:25 < fjahr> But it doesn't fail locally for me 10:27 -!- hanhua [63687d99@99-104-125-153.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 10:27 < fjahr> seems to be an error specific to the CI environment, but maybe someone else can reproduce it? 10:32 < jeremyrubin> that seemed to be the issue thanks 10:32 -!- proofofkeags [~proofofke@2601:280:c280:e500:2dda:95db:aa11:9e17] has joined #bitcoin-core-dev 10:38 -!- arowser_ [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection] 10:38 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 10:45 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 10:48 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 264 seconds] 11:00 -!- directhex1 [~directhex@217.146.82.202] has quit [] 11:04 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 240 seconds] 11:13 -!- alko89 [~alko89@unaffiliated/alko89] has joined #bitcoin-core-dev 11:16 -!- pinheadmz [~pinheadmz@mobile-107-107-57-216.mycingular.net] has joined #bitcoin-core-dev 11:17 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 11:21 -!- stranger64 [~stranger6@217.146.82.202] has joined #bitcoin-core-dev 11:25 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev 11:34 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 11:40 -!- Davterra [~Davterra@static-198-54-128-101.cust.tzulo.com] has joined #bitcoin-core-dev 11:41 -!- mdrollette [~matt@cpe-70-123-125-237.tx.res.rr.com] has quit [Quit: bye] 11:44 -!- mdrollette [~mdrollett@cpe-70-123-125-237.tx.res.rr.com] has joined #bitcoin-core-dev 11:59 -!- Pavlenex [~Thunderbi@194.187.251.11] has quit [Quit: Pavlenex] 12:12 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has quit [Ping timeout: 256 seconds] 12:13 -!- troygiorshev [~troygiors@CPEdcef09a0ed55-CM0c473d74be00.cpe.net.cable.rogers.com] has joined #bitcoin-core-dev 12:16 -!- alko89 [~alko89@unaffiliated/alko89] has quit [Quit: ZNC 1.7.5 - https://znc.in] 12:18 -!- hanhua [63687d99@99-104-125-153.lightspeed.sntcca.sbcglobal.net] has quit [Remote host closed the connection] 12:18 -!- alko89 [~alko89@unaffiliated/alko89] has joined #bitcoin-core-dev 12:22 -!- Davterra [~Davterra@static-198-54-128-101.cust.tzulo.com] has quit [Remote host closed the connection] 12:23 -!- Pavlenex [~Thunderbi@194.187.251.11] has joined #bitcoin-core-dev 12:24 -!- Davterra [~Davterra@2601:603:4f00:63d0::1] has joined #bitcoin-core-dev 12:24 -!- Davterra [~Davterra@2601:603:4f00:63d0::1] has quit [Remote host closed the connection] 12:32 -!- mutatrum [~quassel@84.241.198.28] has joined #bitcoin-core-dev 12:33 -!- Pavlenex [~Thunderbi@194.187.251.11] has quit [Quit: Pavlenex] 12:38 -!- ovovo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 12:40 -!- Pavlenex [~Thunderbi@194.187.251.11] has joined #bitcoin-core-dev 12:40 -!- Pavlenex [~Thunderbi@194.187.251.11] has quit [Client Quit] 12:42 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 260 seconds] 12:43 -!- pinheadmz [~pinheadmz@mobile-107-107-57-216.mycingular.net] has quit [Quit: pinheadmz] 12:47 -!- pinheadmz [~pinheadmz@mobile-107-107-58-157.mycingular.net] has joined #bitcoin-core-dev 12:48 -!- pinheadmz [~pinheadmz@mobile-107-107-58-157.mycingular.net] has quit [Client Quit] 13:03 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds] 13:15 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev 13:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:19 < bitcoin-git> [bitcoin] achow101 opened pull request #19653: wallet: Replace -zapwallettxes with zapwallettxes RPC (master...zapwallettxes-rpc) https://github.com/bitcoin/bitcoin/pull/19653 13:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:26 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 13:34 < luke-jr> achow101: please introduce and remove in separate PRs.. 13:35 < achow101> luke-jr: it's moving one functionality to another place 13:35 < achow101> we did the same thing for upgradewallet 13:36 < luke-jr> pretty sure I said the same for that too 13:50 -!- mutatrum [~quassel@84.241.198.28] has quit [Ping timeout: 240 seconds] 13:52 -!- isis is now known as isis_ 13:57 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:00 -!- stranger64 [~stranger6@217.146.82.202] has quit [] 14:05 -!- cfields [~cfields@unaffiliated/cfields] has joined #bitcoin-core-dev 14:06 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev 14:07 -!- filchef [~filchef@212.104.97.177] has quit [Client Quit] 14:14 -!- Joy [b254c82b@178-84-200-43.dynamic.upc.nl] has joined #bitcoin-core-dev 14:20 -!- erwin_bullet [~erwin_bul@178.162.209.171] has joined #bitcoin-core-dev 14:55 -!- dviola [~diego@unaffiliated/dviola] has quit [Ping timeout: 246 seconds] 14:56 -!- Joy [b254c82b@178-84-200-43.dynamic.upc.nl] has quit [Ping timeout: 245 seconds] 15:02 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 15:03 -!- proofofkeags [~proofofke@2601:280:c280:e500:2dda:95db:aa11:9e17] has quit [Remote host closed the connection] 15:11 -!- proofofkeags [~proofofke@2601:280:c280:e500:2dda:95db:aa11:9e17] has joined #bitcoin-core-dev 15:25 -!- Pavlenex [~Thunderbi@194.187.251.11] has joined #bitcoin-core-dev 15:27 -!- Pavlenex [~Thunderbi@194.187.251.11] has quit [Client Quit] 15:31 -!- proofofkeags [~proofofke@2601:280:c280:e500:2dda:95db:aa11:9e17] has quit [Remote host closed the connection] 15:50 -!- proofofkeags [~proofofke@2601:280:c280:e500:c9e7:9321:1031:749d] has joined #bitcoin-core-dev 15:55 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 15:55 -!- proofofkeags [~proofofke@2601:280:c280:e500:c9e7:9321:1031:749d] has quit [Ping timeout: 260 seconds] 15:55 -!- marcoagner [~user@2001:8a0:6a45:1900:2fd7:e0f0:d356:dd70] has quit [Ping timeout: 260 seconds] 15:58 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 15:58 -!- vasild_ is now known as vasild 16:11 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 256 seconds] 16:27 -!- proofofkeags [~proofofke@2601:280:c280:e500:c9e7:9321:1031:749d] has joined #bitcoin-core-dev 16:28 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 16:31 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 16:33 -!- proofofkeags [~proofofke@2601:280:c280:e500:c9e7:9321:1031:749d] has quit [Ping timeout: 260 seconds] 16:42 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection] 16:43 -!- mdrollette [~mdrollett@cpe-70-123-125-237.tx.res.rr.com] has quit [Quit: bye] 16:43 -!- mdrollette [~mdrollett@cpe-70-123-125-237.tx.res.rr.com] has joined #bitcoin-core-dev 16:51 -!- dviola [~diego@189.7.69.189] has joined #bitcoin-core-dev 17:00 -!- erwin_bullet [~erwin_bul@178.162.209.171] has quit [] 17:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:01 < bitcoin-git> [bitcoin] fjahr opened pull request #19654: lint: Improve commit message linter in Travis (master...commit-lint) https://github.com/bitcoin/bitcoin/pull/19654 17:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:05 -!- gzhao408 [~textual@c-73-252-251-3.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 17:09 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 17:12 -!- fearbeag [~sseanicid@142.114.183.92] has joined #bitcoin-core-dev 17:14 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 17:15 -!- dviola [~diego@189.7.69.189] has left #bitcoin-core-dev [] 17:16 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 17:19 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 264 seconds] 17:22 -!- kers [~kers@185.103.96.135] has joined #bitcoin-core-dev 17:27 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has joined #bitcoin-core-dev 17:44 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 17:48 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds] 17:51 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 18:02 -!- arowser_ [~arowser1@192.69.88.248] has quit [Ping timeout: 264 seconds] 18:02 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 18:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:15 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/34eb2362581d...bb2a9f9c8c55 18:15 < bitcoin-git> bitcoin/master f916847 Justin Moon: rpc: Document getwalletinfo's unlocked_until field as optional 18:15 < bitcoin-git> bitcoin/master bb2a9f9 fanquake: Merge #19634: rpc: Document getwalletinfo's unlocked_until field as option... 18:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:15 < bitcoin-git> [bitcoin] fanquake merged pull request #19634: rpc: Document getwalletinfo's unlocked_until field as optional (master...getwalletinfo) https://github.com/bitcoin/bitcoin/pull/19634 18:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:19 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 18:22 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 18:32 -!- arowser_ [~arowser1@192.69.88.248] has quit [Ping timeout: 246 seconds] 18:34 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 18:42 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 18:42 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 18:45 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 18:45 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 18:48 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 18:48 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 18:51 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection] 18:52 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds] 18:53 -!- fearbeag [~sseanicid@142.114.183.92] has quit [Quit: Leaving] 18:57 -!- sipsorcery [~sipsorcer@2a02:8084:6981:78f0::1b71] has quit [Ping timeout: 272 seconds] 18:59 -!- sipsorcery [~sipsorcer@37.228.243.107] has joined #bitcoin-core-dev 19:04 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection] 19:04 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 19:05 -!- frogar [~frogar_@172.105.92.83] has quit [Remote host closed the connection] 19:07 -!- gzhao408 [~textual@c-73-252-251-3.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 19:12 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 19:12 -!- arowser_ [~arowser1@192.69.88.248] has quit [Ping timeout: 240 seconds] 19:19 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev 19:20 -!- adiabat [~adiabat@63.209.32.102] has quit [Remote host closed the connection] 19:22 -!- adiabat [~adiabat@63.209.32.102] has joined #bitcoin-core-dev 19:28 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 19:30 -!- frogar [~frogar_@172.105.92.83] has joined #bitcoin-core-dev 19:32 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 246 seconds] 19:58 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has quit [Remote host closed the connection] 19:58 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has joined #bitcoin-core-dev 20:00 -!- kers [~kers@185.103.96.135] has quit [] 20:03 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has quit [Ping timeout: 240 seconds] 20:04 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 20:08 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 240 seconds] 20:22 -!- ranman1 [~ranman@77.243.177.38] has joined #bitcoin-core-dev 21:02 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has joined #bitcoin-core-dev 21:13 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has quit [Remote host closed the connection] 21:24 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 21:44 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has joined #bitcoin-core-dev 21:57 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 264 seconds] 22:13 -!- IGHOR [~quassel@176.121.4.135] has joined #bitcoin-core-dev 22:28 -!- ranman1 [~ranman@77.243.177.38] has quit [Remote host closed the connection] 22:36 -!- achadwick [~achadwick@37.120.203.188] has joined #bitcoin-core-dev 22:42 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds] 22:43 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 22:44 -!- proofofkeags [~proofofke@174-29-8-246.hlrn.qwest.net] has quit [Remote host closed the connection] 22:47 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 22:47 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 22:48 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 22:51 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 240 seconds] 22:52 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 22:56 -!- mdrollette [~mdrollett@cpe-70-123-125-237.tx.res.rr.com] has quit [Ping timeout: 240 seconds] 22:57 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 256 seconds] 23:00 -!- achadwick [~achadwick@37.120.203.188] has quit [] 23:22 -!- penthium2 [~penthium2@178.239.168.171] has joined #bitcoin-core-dev 23:28 -!- mdrollette [~mdrollett@cpe-70-123-125-237.tx.res.rr.com] has joined #bitcoin-core-dev 23:31 -!- shesek [~shesek@164.90.217.137] has joined #bitcoin-core-dev 23:31 -!- shesek [~shesek@164.90.217.137] has quit [Changing host] 23:31 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 23:55 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 23:57 -!- coinGuyBri [~coinguybr@c-174-56-133-139.hsd1.sc.comcast.net] has joined #bitcoin-core-dev --- Log closed Tue Aug 04 00:00:40 2020