--- Log opened Wed Aug 12 00:00:48 2020
00:05 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
00:05 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
00:09 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 265 seconds]
00:09 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev
00:12 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
00:18 -!- arowser_ [~arowser1@192.69.88.248] has quit [Ping timeout: 240 seconds]
00:19 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 256 seconds]
00:21 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev
00:30 -!- arowser_ [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev
00:43 -!- arowser_ [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection]
00:43 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
00:46 -!- vincenzopalazzo [~vincent@host-95-246-119-127.retail.telecomitalia.it] has quit [Remote host closed the connection]
00:50 -!- jonatack [~jon@192.113.14.109.rev.sfr.net] has joined #bitcoin-core-dev
00:56 -!- sipsorcery [~sipsorcer@37.228.243.134] has joined #bitcoin-core-dev
01:08 -!- midnight [~midnight@unaffiliated/midnightmagic] has quit [Ping timeout: 244 seconds]
01:11 -!- midnight [~midnight@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
01:12 -!- vincenzopalazzo [~vincent@host-95-246-119-127.retail.telecomitalia.it] has joined #bitcoin-core-dev
01:15 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 256 seconds]
01:16 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev
01:28 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection]
01:28 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
01:29 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection]
01:29 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
01:35 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev
01:45 -!- b10c [~b10c@2001:16b8:2e50:e600:885a:5088:eb3:4c5d] has joined #bitcoin-core-dev
01:51 < jonatack> review beg for #19455 (which arguably should have been in the last release with -generate to make multiple bitcoin command line tutorials work again for users), as requested by ajonas and MarcoFalke. It's a quick review with complete test coverage. 
01:51 < gribble> https://github.com/bitcoin/bitcoin/issues/19455 | rpc generate: print useful help and error message by jonatack · Pull Request #19455 · bitcoin/bitcoin · GitHub
01:54 -!- promag [~promag@83.223.233.213] has joined #bitcoin-core-dev
01:59 -!- promag [~promag@83.223.233.213] has quit [Ping timeout: 246 seconds]
02:00 -!- torax [~torax@185.204.1.185] has quit []
02:05 -!- TheFuzzStone[m] [thefuzzsto@gateway/shell/matrix.org/x-wyppdpqstfcbhvwd] has quit [Quit: killed]
02:05 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-toywuawfkiqcrduy] has quit [Quit: killed]
02:06 -!- thunderbiscuit[m [thunderbis@gateway/shell/matrix.org/x-mfukdwtxjsdagjte] has quit [Quit: killed]
02:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
02:08 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
02:12 -!- SergeySherkunov[ [leinlawunm@gateway/shell/matrix.org/x-ohhrsgytahhtithz] has joined #bitcoin-core-dev
02:18 -!- b10c_ [~b10c@2001:16b8:2e50:e600:885a:5088:eb3:4c5d] has joined #bitcoin-core-dev
02:22 -!- zakk [~zakk@84.39.116.180] has joined #bitcoin-core-dev
02:22 -!- zakk is now known as Guest84477
02:25 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex]
02:28 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 240 seconds]
02:29 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev
02:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
02:34 -!- thunderbiscuit[m [thunderbis@gateway/shell/matrix.org/x-nesqmfqydbpwpgwg] has joined #bitcoin-core-dev
02:34 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-xpkyziydjunbcssq] has joined #bitcoin-core-dev
02:34 -!- TheFuzzStone[m] [thefuzzsto@gateway/shell/matrix.org/x-vgpurkxvwygyqguw] has joined #bitcoin-core-dev
02:49 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection]
02:49 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
02:49 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
02:51 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 246 seconds]
02:51 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev
02:53 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Ping timeout: 265 seconds]
02:53 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
02:58 -!- jeremyrubin [~jr@2601:645:c200:f539:f85e:a648:fc27:2225] has quit [Ping timeout: 260 seconds]
02:59 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
03:03 -!- Vinnie23Vandervo [~Vinnie23V@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev
03:11 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
03:12 -!- sipsorcery [~sipsorcer@37.228.243.134] has quit [Ping timeout: 240 seconds]
03:13 -!- SergeySherkunov[ [leinlawunm@gateway/shell/matrix.org/x-ohhrsgytahhtithz] has quit [Quit: Idle for 30+ days]
03:14 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Client Quit]
03:17 -!- sipsorcery [~sipsorcer@37.228.243.134] has joined #bitcoin-core-dev
03:19 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev
03:37 < jonatack> elichai2: "<elichai2> I don't work on anything p2p related right now, but I do plan to review a bunch of stuff, so if there'll be a high priority for review out of this it would be great" --> high prority suggestion: #19628
03:37 < gribble> https://github.com/bitcoin/bitcoin/issues/19628 | net: change CNetAddr::ip to have flexible size by vasild · Pull Request #19628 · bitcoin/bitcoin · GitHub
03:37 < jonatack> as part of #19031
03:37 < gribble> https://github.com/bitcoin/bitcoin/issues/19031 | Implement ADDRv2 support (part of BIP155) by vasild · Pull Request #19031 · bitcoin/bitcoin · GitHub
03:37 < vasild> +1
03:38 < elichai2> jonatack: Thanks!
03:40 < jonatack> elichai2: 10/10 you'll like it, lots of low-level memcpy/memcmp mixed with some Span to overhaul the critical netaddress infra ;)
03:40 -!- Vinnie23Vandervo [~Vinnie23V@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 244 seconds]
03:40 < elichai2> :D
03:42 < vasild> well, in my defence, I tried to split the patch, but everything seems to be linked together...
03:43 < jonatack> that is true
03:45 < vasild> it would be possible to remove GetByte() as a first patch, but that would be lots of mechanical changes, all retouched/redone in the second patch
03:49 < jonatack> while shilling PRs, i find having the cli -netinfo peer connections dashboard (e.g. <human-readable getpeerinfo>) reassuring as a sanity check for testing running nodes with the addrv2 changes
03:50 < vasild> e.g. GetByte(3) (this gets the first byte!) would become ip[sizeof(IPV4_IN_IPV6_PREFIX) + 0] (in about 100 places) and then all those will be changed to m_addr[0] in a second patch - I think that would be wasting reviewer's time
03:51 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev
03:53 < jonatack> vasild: i think you'll have several acks soon so would not rework it now
03:54 < vasild> let it rain acks! :)
03:54 < ryanofsky> fanquake, can you give specific examples of where review recap comments have been misleading? I think they are essential for long-lived prs because we have no explicit standards for merging
03:54 < vasild> (but not before I address your suggestions)
03:55 < ryanofsky> so without review recap comments, there's basically no transparency about why a pr has or hasn't been merged
03:55 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
03:56 < ryanofsky> if a comment is misleading, you can call out the comment, not discourage comments in general
03:58 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
03:58 -!- vasild_ is now known as vasild
04:11 -!- jonatack [~jon@192.113.14.109.rev.sfr.net] has quit [Ping timeout: 260 seconds]
04:19 < fanquake> ryanofsky: Sure, I'll try dig up some examples. I wasn't trying to discourage commenting. My point is that Concept ACKs left at the opening of a PR, are not necessarily relevant if they are being "recapped" 2 months later, after the implementation has changed, or a different approach is being taken. Similarly, if someone ACK'd something 3 rebases and a few code changes ago, I'm not really looking at  that as 
04:19 < fanquake> a "tested ACK".
04:19 < fanquake> Do you think people are changing how they are reviewing based on these comments, or just wether or not they are going to review something in the first place?
04:21 -!- sipsorcery [~sipsorcer@37.228.243.134] has quit [Remote host closed the connection]
04:21 < fanquake> I'd also like to avoid the idea that just because a PR has *had* a large number of ACKs throughout it's lifetime, it just ready to merge. Obviously this is all dependent on the change itself, and a bit hard to generalize. However as I mentioned above, ACKs are certainly not equal when it comes to more important parts of the code.  
04:22 -!- sipsorcery [~sipsorcer@37.228.243.134] has joined #bitcoin-core-dev
04:23 < fanquake> Hopefully this is something we'll only have to worry about less as more (frequent) contributors are onboarded etc etc
04:26 < ryanofsky> Sure I agree with all that, I just think it's mostly obvious. I plan to keep making review recap comments and want to encourage other people to make them
04:27 < ryanofsky> So if there are specific comments that are misleading, which includes outdated acks, or mischaracterized acks, let's just respond to and fix those comments
04:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:38 < bitcoin-git> [bitcoin] jnewbery opened pull request #19704: Net processing: move ProcessMessage() to PeerLogicValidation (master...2020-07-process-message-plv) https://github.com/bitcoin/bitcoin/pull/19704
04:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:48 -!- spikee [~spike@81.4.120.158] has joined #bitcoin-core-dev
04:49 -!- spikee [~spike@81.4.120.158] has quit [Client Quit]
04:49 -!- spikee [~spike@81.4.120.158] has joined #bitcoin-core-dev
04:49 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
04:50 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Client Quit]
04:51 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:39db:1da7:760:f108] has joined #bitcoin-core-dev
04:56 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Remote host closed the connection]
04:57 -!- Guest84477 [~zakk@84.39.116.180] has quit [Remote host closed the connection]
05:00 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev
05:03 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:39db:1da7:760:f108] has quit [Remote host closed the connection]
05:04 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:39db:1da7:760:f108] has joined #bitcoin-core-dev
05:07 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Remote host closed the connection]
05:08 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:39db:1da7:760:f108] has quit [Ping timeout: 244 seconds]
05:18 -!- lliehu [~lliehu@184.75.221.3] has joined #bitcoin-core-dev
05:19 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev
05:21 -!- spikee [~spike@81.4.120.158] has quit [Quit: WeeChat 3.0-dev]
05:22 < wumpus> yes, definitely call out comments that you think are misleading or ask for more information if you think someone is not clear enough in their review, I definitely agree "number of ACKs" is not the only measure, judging whether something is ready for merge is not *that* trivial
05:23 -!- wullon58 [~wullon@241.243.86.88.rdns.comcable.net] has joined #bitcoin-core-dev
05:23 -!- wullon5 [~wullon@241.243.86.88.rdns.comcable.net] has quit [Ping timeout: 256 seconds]
05:24 < wumpus> in general I pay attention to: number of ACKs, who has ACKed, are there tests that cover the functionality, are there any unaddressed comments, if it's a bugfix did the original reporter test it, is there anyone with principal problems with the concept or its implementation, etc etc…
05:26 < wumpus> it definitely also matters where the code change is, is it in one of the risky parts or only user facing, need different kinds of review
05:26 < wumpus> this is why we need actual maintainers and not a merge-bot :-)
05:27 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has joined #bitcoin-core-dev
05:29 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 246 seconds]
05:29 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev
05:36 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 260 seconds]
05:41 < jnewbery> is there a make target that I can run before pushing that will maximize my chances of passing travis? I used to do `make check && ./test/functional/test_runner.py`, but that often doesn't catch stuff now because of linters and fuzzers.
05:41 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
05:42 < fanquake> You could append && ./test/lint/lint-all.sh (I think) for the linters
05:43 < fanquake> If you want to sanity check the fuzzers you'll have to recompile
05:46 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:39db:1da7:760:f108] has joined #bitcoin-core-dev
05:53 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:39db:1da7:760:f108] has quit [Remote host closed the connection]
05:53 < troygiorshev> We were trying to get away from that, right?  in #19388?
05:53 < gribble> https://github.com/bitcoin/bitcoin/issues/19388 | Build fuzz tests by default · Issue #19388 · bitcoin/bitcoin · GitHub
05:58 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
05:58 -!- TheHoliestRoger_ is now known as TheHoliestRoger
06:00 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Client Quit]
06:00 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
06:04 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
06:05 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 264 seconds]
06:06 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection]
06:06 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
06:07 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection]
06:07 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
06:07 < wumpus> troygiorshev: yes and no: the fuzz tests that would be always built are shims and not actually useful for fuzzing, it's just to make sure there's 100% compiler coverage
06:08 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection]
06:08 -!- arowser_ [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev
06:09 -!- arowser_ [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection]
06:09 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 260 seconds]
06:09 -!- arowser_ [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev
06:10 -!- arowser_ [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection]
06:10 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
06:12 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection]
06:12 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
06:13 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection]
06:13 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
06:13 < troygiorshev> wumpus: you're right, thx
06:19 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection]
06:19 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev
06:19 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
06:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:23 < bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/ce3bdd0ed1bb...bd00d3b1f203
06:23 < bitcoin-git> bitcoin/master f26502e John Newbery: [addrman] Specify max addresses and pct when calling GetAddresses()
06:23 < bitcoin-git> bitcoin/master ae8051b John Newbery: [test] Test that getnodeaddresses() can return all known addresses
06:23 < bitcoin-git> bitcoin/master 37a480e John Newbery: [net] Add addpeeraddress RPC method
06:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:23 < bitcoin-git> [bitcoin] laanwj merged pull request #19658: [rpc] Allow RPC to fetch all addrman records and add records to addrman (master...2020-07-addrman-get) https://github.com/bitcoin/bitcoin/pull/19658
06:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:24 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:8c3e:7a3b:e18f:4a80] has joined #bitcoin-core-dev
06:26 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:8c3e:7a3b:e18f:4a80] has quit [Remote host closed the connection]
06:32 -!- lliehu [~lliehu@184.75.221.3] has quit [Remote host closed the connection]
06:43 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
06:46 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds]
06:46 -!- Guyver2_ is now known as Guyver2
06:46 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
06:47 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
06:49 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 256 seconds]
06:50 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds]
06:51 -!- Mikaku1 [~Mikaku@185.244.214.217] has joined #bitcoin-core-dev
06:55 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
06:59 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection]
06:59 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
07:11 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
07:15 -!- b10c__ [~b10c@2001:16b8:2e50:e600:885a:5088:eb3:4c5d] has joined #bitcoin-core-dev
07:15 -!- b10c__ [~b10c@2001:16b8:2e50:e600:885a:5088:eb3:4c5d] has quit [Client Quit]
07:17 -!- b10c_ [~b10c@2001:16b8:2e50:e600:885a:5088:eb3:4c5d] has quit [Quit: Leaving]
07:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:20 < bitcoin-git> [bitcoin] vasild opened pull request #19705: Shrink CAddress from 48 to 40 bytes on x64 (master...shrink_caddress) https://github.com/bitcoin/bitcoin/pull/19705
07:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:23 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex]
07:24 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
07:28 -!- b10c [~b10c@2001:16b8:2e50:e600:885a:5088:eb3:4c5d] has quit [Quit: Leaving]
07:31 -!- jonatack [~jon@37.164.92.255] has joined #bitcoin-core-dev
07:32 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection]
07:32 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
07:36 -!- jonatack [~jon@37.164.92.255] has quit [Ping timeout: 256 seconds]
07:40 -!- jonatack [~jon@213.152.161.211] has joined #bitcoin-core-dev
07:41 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 256 seconds]
07:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:44 < bitcoin-git> [bitcoin] theStack opened pull request #19706: refactor: make EncodeBase58{Check} consume Spans (master...20200810-util-make-base58encode-consume-spans) https://github.com/bitcoin/bitcoin/pull/19706
07:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:45 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection]
07:45 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
07:45 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
07:46 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection]
07:46 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
08:00 -!- Mikaku1 [~Mikaku@185.244.214.217] has quit []
08:11 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 272 seconds]
08:15 -!- jonatack [~jon@213.152.161.211] has quit [Ping timeout: 256 seconds]
08:15 -!- PaulTroo_ [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev
08:17 -!- Davterra [~Davterra@89.46.114.243] has quit [Ping timeout: 256 seconds]
08:18 -!- PaulTro__ [~paultroon@193.32.127.234] has quit [Ping timeout: 240 seconds]
08:20 -!- Davterra [~Davterra@89.45.90.22] has joined #bitcoin-core-dev
08:26 < jamesob> fwiw going to take some time this weekend to get the next assumeutxo PR filed, which will be the (unused) process for snapshot activation. main bottleneck is that I've gotta write some decent unittests, which will take a few hours.
08:29 -!- jeremyrubin [~jr@2601:645:c200:f539:f85e:a648:fc27:2225] has joined #bitcoin-core-dev
08:29 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 240 seconds]
08:30 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
08:30 -!- Davterra [~Davterra@89.45.90.22] has quit [Quit: Leaving]
08:32 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has quit [Read error: Connection reset by peer]
08:37 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has quit [Quit: Leaving]
08:38 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev
08:40 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has joined #bitcoin-core-dev
08:40 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has quit [Remote host closed the connection]
08:41 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has joined #bitcoin-core-dev
08:41 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev
08:48 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 260 seconds]
08:50 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev
08:50 -!- sipsorcery [~sipsorcer@37.228.243.134] has quit [Ping timeout: 264 seconds]
08:53 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev
08:55 -!- amcrae1 [~amcrae@185.244.214.217] has joined #bitcoin-core-dev
09:01 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex]
09:01 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has quit [Quit: Lost terminal]
09:06 -!- sipsorcery [~sipsorcer@37.228.243.134] has joined #bitcoin-core-dev
09:12 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has joined #bitcoin-core-dev
09:12 -!- baldur [~baldur@pool-173-56-240-14.nycmny.fios.verizon.net] has quit [Ping timeout: 256 seconds]
09:18 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
09:25 -!- baldur [~baldur@pool-173-56-240-14.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
09:31 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection]
09:31 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
09:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:31 < bitcoin-git> [bitcoin] achow101 closed pull request #19653: wallet: Replace -zapwallettxes with zapwallettxes RPC (master...zapwallettxes-rpc) https://github.com/bitcoin/bitcoin/pull/19653
09:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:32 < willcl_ark>  troygiorshev: I did make a bit of progress on #19388 but could not get the linking working correctly at the end. If you have any ideas on this, my branch is here: https://github.com/willcl-ark/bitcoin/tree/default_fuzz_tests
09:32 < gribble> https://github.com/bitcoin/bitcoin/issues/19388 | Build fuzz tests by default · Issue #19388 · bitcoin/bitcoin · GitHub
09:33 < troygiorshev> willcl_ark: thanks for the link.  build stuff is definitely something I'm weak on, but if I spend a day figuring it out I'll give that a look!
09:35 -!- Guyver2__ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
09:37 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 264 seconds]
09:49 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev
09:49 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex]
09:52 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 256 seconds]
09:52 -!- gzhao408 [~textual@c-73-252-251-3.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
09:57 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
09:59 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
10:01 -!- lightlike [~lightlike@p200300c7ef127d0098aa4f7ef52ed5b3.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
10:01 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev
10:02 -!- Guyver2__ [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 264 seconds]
10:05 < nehan> "< wumpus> this is why we need actual maintainers and not a merge-bot :-)" <-- wait wumpus isn't a bot?
10:11 -!- Highway62 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev
10:12 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Ping timeout: 246 seconds]
10:12 -!- Highway62 is now known as Highway61
10:14 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Ping timeout: 240 seconds]
10:24 -!- PaulTroo_ [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Remote host closed the connection]
10:26 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
10:27 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 246 seconds]
10:28 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Ping timeout: 256 seconds]
10:28 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Remote host closed the connection]
10:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:29 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bd00d3b1f203...13c4635a3ecf
10:29 < bitcoin-git> bitcoin/master a51d0ad Fabian Jahr: rpc: Improve addnode remove command error message
10:30 < bitcoin-git> bitcoin/master 13c4635 Wladimir J. van der Laan: Merge #19696: rpc: Fix addnode remove command error
10:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:30 < bitcoin-git> [bitcoin] laanwj merged pull request #19696: rpc: Fix addnode remove command error (master...rpc_net_tests) https://github.com/bitcoin/bitcoin/pull/19696
10:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:32 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection]
10:32 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
10:33 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
11:00 -!- amcrae1 [~amcrae@185.244.214.217] has quit []
11:02 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 246 seconds]
11:02 -!- sipsorcery [~sipsorcer@37.228.243.134] has quit [Read error: Connection reset by peer]
11:06 -!- gzhao408 [~textual@c-73-252-251-3.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
11:07 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
11:12 -!- Landryl3 [~Landryl@ns528256.ip-192-99-10.net] has joined #bitcoin-core-dev
11:12 -!- Galvas_ [uid459296@gateway/web/irccloud.com/x-oradxrfemdnderpm] has joined #bitcoin-core-dev
11:13 -!- GoldmanSats_ [sid428607@gateway/web/irccloud.com/x-jsdnoqgcxqwxudlx] has joined #bitcoin-core-dev
11:13 -!- hsmiths_ [uid95325@gateway/web/irccloud.com/x-buhwceikvfquyquo] has joined #bitcoin-core-dev
11:13 -!- jkczyz_ [sid419941@gateway/web/irccloud.com/x-rebgtlkvrvslbhur] has joined #bitcoin-core-dev
11:13 -!- ajonas_ [sid385278@gateway/web/irccloud.com/x-rymtsmerpmdkptpu] has joined #bitcoin-core-dev
11:13 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex]
11:13 -!- bosma_ [sid103570@gateway/web/irccloud.com/x-yxqbjmmtvdjlnpbm] has joined #bitcoin-core-dev
11:20 -!- meshcoll- [meshcollid@gateway/shell/ircnow/x-qdhdkfhknqtjboec] has joined #bitcoin-core-dev
11:20 -!- Netsplit *.net <-> *.split quits: ajonas, jkczyz, meshcollider, Landryl, TheFuzzStone[m], bosma, thunderbiscuit[m, Galvas, GoldmanSats, hsmiths
11:20 -!- Landryl3 is now known as Landryl
11:20 -!- hsmiths_ is now known as hsmiths
11:20 -!- jkczyz_ is now known as jkczyz
11:20 -!- Galvas_ is now known as Galvas
11:20 -!- bosma_ is now known as bosma
11:22 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-xpkyziydjunbcssq] has quit [Remote host closed the connection]
11:27 -!- thunderbiscuit[m [thunderbis@gateway/shell/matrix.org/x-whgcphpbnfjnqwev] has joined #bitcoin-core-dev
11:31 -!- pinheadmz [~pinheadmz@2600:380:bc4a:ee96:b00c:a440:1640:cfcf] has joined #bitcoin-core-dev
11:38 -!- PaulTroo_ [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has joined #bitcoin-core-dev
11:42 -!- Davterra [~Davterra@89.45.90.22] has joined #bitcoin-core-dev
11:48 -!- go121212 [go1111111@gateway/vpn/privateinternetaccess/go1111111] has quit [Ping timeout: 265 seconds]
11:48 -!- kyprizel [~kyprizel@185.163.110.125] has joined #bitcoin-core-dev
11:49 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
11:49 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-eqhxcimgttyalrtz] has joined #bitcoin-core-dev
11:49 -!- TheFuzzStone[m] [thefuzzsto@gateway/shell/matrix.org/x-kfkxcubdaveiuvwm] has joined #bitcoin-core-dev
11:57 -!- sipsorcery [~sipsorcer@37.228.243.134] has joined #bitcoin-core-dev
11:59 -!- PaulTro__ [~paultroon@86.106.121.169] has joined #bitcoin-core-dev
12:03 -!- PaulTroo_ [~paultroon@h-5-150-248-150.NA.cust.bahnhof.se] has quit [Ping timeout: 246 seconds]
12:10 < wumpus> nehan: shhh that's supposed to be secret
12:25 < michaelfolkson> If we were going to down the road of quantifying it, it would be a reputation score for each reviewer based on various metrics e.g. bugs found in past, code reviews that led to material changes in the code other than nits, number of PRs reviewed, understanding displayed in the past on the part of the codebase they are reviewing.
12:25 < michaelfolkson> Obivuosly we won't go down that road but highlights why simple ACK counts aren't sufficient
12:31 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
12:34 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!]
12:35 < michaelfolkson> The only downside to beginners posting comments about testing etc that I see is GitHub hides large swathes of comments (Marco has mentioned this before). I don't see any harm otherwise when the maintainers can just ignore them.
12:36 < michaelfolkson> Assuming we all understand that one ACK can be much more valuable than another ACK
12:37 -!- pinheadmz [~pinheadmz@2600:380:bc4a:ee96:b00c:a440:1640:cfcf] has quit [Ping timeout: 244 seconds]
12:38 -!- T3 [~T3@173.231.109.130] has joined #bitcoin-core-dev
12:43 < sipa> an "expand all" button on github pages would be really useful
12:44 < sipa> it's a pain to go through the history of big PRs as an author to see if you've addressed everything
12:47 < michaelfolkson> Something like this https://github.com/isaacs/github/issues/1190#issuecomment-367607027
12:48 < michaelfolkson> It must be a commonly requested feature
12:52 < wumpus> michaelfolkson: maybe, the thing is, as soon as you quantify it, people will try to game it
12:52 < michaelfolkson> It wasn't a serious suggestion. Just a thought exercise ;)
12:53 < michaelfolkson> In reality the discretion of maintainers is the best option of many worse options
12:56 < sipa> goodhart's law
13:05 < luke-jr> sipa: at least a few times, I didn't even realise I was missing the comments :/
13:09 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 256 seconds]
13:14 < wumpus> michaelfolkson: but yes it's annoying that github hides comments, like at some point they made the website too heavy for some browsers then they started hiding comments to compensate for that, if it was just dumb HTML there'd be no problem
13:14 -!- owowo [~ovovo@31.7.59.226] has joined #bitcoin-core-dev
13:14 -!- owowo [~ovovo@31.7.59.226] has quit [Changing host]
13:14 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
13:15 < sipa> i'm ok even with if hiding stuff by default
13:15 < wumpus> or even a forum-like "page 1 of N" interface would be better than this
13:15 < sipa> but clicking to expand everything can take ages
13:16 < wumpus> yes, when you expand everything it becomes really slow
13:16 < wumpus> there's probably 40MB of javascript running in the background
13:17 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
13:19  * sipa , remembering spendong 4 hours downloading several megabytes internet explorer when he first got internet..
13:21 -!- meshcoll- [meshcollid@gateway/shell/ircnow/x-qdhdkfhknqtjboec] has quit [Quit: ZNC 1.7.5 - https://znc.in]
13:22 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-zojudcrfkwmoipwe] has joined #bitcoin-core-dev
13:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:22 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/13c4635a3ecf...038a04eb80a5
13:22 < bitcoin-git> bitcoin/master c71bdf9 Hennadii Stepanov: build, test: Add support for llvm-cov
13:22 < bitcoin-git> bitcoin/master 8ebc050 Hennadii Stepanov: build: Add missed fuzz_filtered.info to COVERAGE_INFO
13:22 < bitcoin-git> bitcoin/master 75f9659 Hennadii Stepanov: build: Add missed fuzz.coverage/ directory to .gitignore
13:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:23 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19688: build: Add support for llvm-cov (master...200808-lcov) https://github.com/bitcoin/bitcoin/pull/19688
13:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:25 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 264 seconds]
13:26 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
13:42 -!- PaulTro__ [~paultroon@86.106.121.169] has quit [Remote host closed the connection]
13:42 -!- Davterra [~Davterra@89.45.90.22] has quit [Remote host closed the connection]
13:42 -!- Davterra [~Davterra@89.45.90.22] has joined #bitcoin-core-dev
13:51 -!- dergoegge [uid453889@gateway/web/irccloud.com/x-mzknfnwlewxltcow] has joined #bitcoin-core-dev
13:55 -!- proofofkeags [~proofofke@2601:280:c280:e500:74bb:1d24:1560:b03b] has joined #bitcoin-core-dev
14:00 -!- kyprizel [~kyprizel@185.163.110.125] has quit []
14:04 -!- Mario35Carroll [~Mario35Ca@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev
14:05 -!- go1111111 [~go1111111@104.156.98.86] has joined #bitcoin-core-dev
14:20 -!- kaimi1 [~kaimi@178.162.204.238] has joined #bitcoin-core-dev
14:32 -!- vincenzopalazzo [~vincent@host-95-246-119-127.retail.telecomitalia.it] has quit [Remote host closed the connection]
14:38 -!- fox2p [~fox2p@ec2-3-211-34-208.compute-1.amazonaws.com] has quit [Ping timeout: 240 seconds]
14:39 -!- fox2p [~fox2p@ec2-3-211-34-208.compute-1.amazonaws.com] has joined #bitcoin-core-dev
14:53 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 244 seconds]
15:09 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
15:11 -!- lightlike [~lightlike@p200300c7ef127d0098aa4f7ef52ed5b3.dip0.t-ipconnect.de] has quit [Quit: Leaving]
15:12 -!- Mario35Carroll [~Mario35Ca@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 256 seconds]
15:21 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection]
15:24 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
15:31 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev
15:53 -!- proofofkeags [~proofofke@2601:280:c280:e500:74bb:1d24:1560:b03b] has quit [Remote host closed the connection]
15:53 -!- marcoagner [~user@bl11-17-219.dsl.telepac.pt] has quit [Ping timeout: 240 seconds]
15:58 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
16:00 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
16:00 -!- reallll is now known as belcher
16:01 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
16:06 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 240 seconds]
16:14 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev
16:39 -!- Davterra [~Davterra@89.45.90.22] has quit [Remote host closed the connection]
16:40 -!- T3 [~T3@173.231.109.130] has quit [Ping timeout: 246 seconds]
16:49 -!- sipsorcery [~sipsorcer@37.228.243.134] has quit [Ping timeout: 246 seconds]
16:51 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Remote host closed the connection]
16:52 < fanquake> wumpus sipa: I've also been trying to make the point to GH https://0bin.net/paste/jzVybfePdQQQgBcs#Y2Vh1PlrS2WQBeT8TRJPJPfaOlIgcsR53q1iHk+AW2l
16:53 < fanquake> Obviously still not complaining loud enough
17:00 -!- kaimi1 [~kaimi@178.162.204.238] has quit []
17:03 -!- jarthur_ [~jarthur@2605:6000:1019:48d9:90c1:b33a:f651:6115] has joined #bitcoin-core-dev
17:06 -!- jarthur [~jarthur@cpe-66-68-134-212.austin.res.rr.com] has quit [Ping timeout: 265 seconds]
17:11 -!- gzhao408 [~textual@c-73-252-251-3.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
17:15 -!- gzhao408 [~textual@c-73-252-251-3.hsd1.ca.comcast.net] has quit [Client Quit]
17:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
17:21 < bitcoin-git> [bitcoin] meshcollider pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/038a04eb80a5...8a85377cd0b6
17:21 < bitcoin-git> bitcoin/master 4638224 Andrew Chow: Add psbtbumpfee RPC
17:21 < bitcoin-git> bitcoin/master 431071c Andrew Chow: Hide bumpfee's psbt creation behavior behind -deprecatedrpc
17:21 < bitcoin-git> bitcoin/master 79d6332 Andrew Chow: moveonly: Fix indentation in bumpfee RPC
17:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
17:22 -!- RISCi_ATOM1 [~RISCi_ATO@194.35.233.173] has joined #bitcoin-core-dev
17:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
17:22 < bitcoin-git> [bitcoin] meshcollider merged pull request #18654: rpc: separate bumpfee's psbt creation function into psbtbumpfee (master...psbtbumpfee) https://github.com/bitcoin/bitcoin/pull/18654
17:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
17:37 -!- ajonas_ [sid385278@gateway/web/irccloud.com/x-rymtsmerpmdkptpu] has quit []
17:38 -!- ajonas [sid385278@gateway/web/irccloud.com/x-eibrygsytgwxxmbq] has joined #bitcoin-core-dev
17:42 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
17:50 -!- jarthur_ [~jarthur@2605:6000:1019:48d9:90c1:b33a:f651:6115] has quit [Ping timeout: 260 seconds]
17:52 -!- Davterra [~Davterra@89.45.90.22] has joined #bitcoin-core-dev
18:11 -!- frogar [~frogar_@172.105.92.83] has quit [Remote host closed the connection]
18:12 -!- frogar [~frogar_@172.105.92.83] has joined #bitcoin-core-dev
18:21 -!- stevenroose [~steven@irc.roose.io] has quit [Ping timeout: 260 seconds]
18:25 -!- stevenroose [~steven@2001:19f0:6801:83a:d583:6c25:2f07:e17a] has joined #bitcoin-core-dev
18:34 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has quit [Ping timeout: 265 seconds]
18:39 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection]
18:39 -!- arowser_ [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev
18:40 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has joined #bitcoin-core-dev
18:42 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection]
18:44 -!- arowser_ [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection]
18:50 -!- arowser_ [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev
19:03 -!- arowser_ [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection]
19:04 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
19:10 -!- arowser_ [~arowser1@192.69.88.248] has quit [Ping timeout: 260 seconds]
19:11 -!- watersnake1 [~christian@24.61.159.12] has joined #bitcoin-core-dev
19:14 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
19:17 -!- watersnake1 [~christian@24.61.159.12] has quit [Quit: Leaving.]
19:18 -!- watersnake1 [~christian@24.61.159.12] has joined #bitcoin-core-dev
19:19 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
19:21 -!- watersnake1 [~christian@24.61.159.12] has quit [Client Quit]
19:24 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 256 seconds]
19:24 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
19:26 -!- arowser_ [~arowser1@192.69.88.248] has quit [Ping timeout: 246 seconds]
19:39 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
19:49 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
19:58 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
20:00 -!- RISCi_ATOM1 [~RISCi_ATO@194.35.233.173] has quit []
20:02 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]
20:12 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection]
20:12 -!- arowser_ [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev
20:16 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Remote host closed the connection]
20:17 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev
20:19 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 244 seconds]
20:21 -!- mdrjr1 [~mdrjr@185.244.214.217] has joined #bitcoin-core-dev
20:41 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has quit [Ping timeout: 240 seconds]
20:43 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Ping timeout: 246 seconds]
20:46 -!- arowser_ [~arowser1@192.69.88.248.16clouds.com] has quit [Ping timeout: 256 seconds]
20:46 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
20:52 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
21:18 -!- jarthur [~jarthur@2605:6000:1019:48d9:e59d:2b59:f63:a450] has joined #bitcoin-core-dev
21:27 -!- jarthur [~jarthur@2605:6000:1019:48d9:e59d:2b59:f63:a450] has quit []
21:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
21:46 -!- PaulTroo_ [~paultroon@86.106.121.169] has joined #bitcoin-core-dev
21:51 -!- PaulTroo_ [~paultroon@86.106.121.169] has quit [Ping timeout: 256 seconds]
21:59 -!- waldoirc [~Android@pool-108-28-58-104.washdc.fios.verizon.net] has joined #bitcoin-core-dev
22:05 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection]
22:09 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 240 seconds]
22:12 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has quit [Ping timeout: 240 seconds]
22:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds]
22:28 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
22:29 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
22:33 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 256 seconds]
22:34 -!- T3 [~T3@173.231.109.130] has joined #bitcoin-core-dev
22:39 < wumpus> fanquake: thanks 
22:44 -!- arowser_ [~arowser1@192.69.88.248] has quit [Remote host closed the connection]
22:44 -!- arowser_ [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev
23:00 -!- mdrjr1 [~mdrjr@185.244.214.217] has quit []
23:00 -!- proofofkeags [~proofofke@174-29-11-169.hlrn.qwest.net] has joined #bitcoin-core-dev
23:05 -!- arowser_ [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection]
23:05 -!- arowser_ [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev
23:20 -!- directhex1 [~directhex@184.75.223.227] has joined #bitcoin-core-dev
23:24 -!- arowser_ [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection]
23:24 -!- arowser_ [~arowser1@192.69.88.248] has joined #bitcoin-core-dev
23:28 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
23:33 -!- PaulTroo_ [~paultroon@86.106.121.169] has joined #bitcoin-core-dev
23:38 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has joined #bitcoin-core-dev
23:38 -!- sipsorcery [~sipsorcer@37.228.243.134] has joined #bitcoin-core-dev
23:53 -!- trash_mapache [~trash_map@2600:100e:b035:d3e4:3dde:70cc:ac61:513c] has joined #bitcoin-core-dev
23:54 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev
--- Log closed Thu Aug 13 00:00:41 2020