--- Log opened Thu Aug 27 00:00:00 2020
00:11 -!- marcoagner [~user@bl11-17-219.dsl.telepac.pt] has joined #bitcoin-core-dev
00:16 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 240 seconds]
00:30 -!- grawity1 [~grawity@195.206.169.184] has joined #bitcoin-core-dev
00:32 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
00:36 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
00:40 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 240 seconds]
00:42 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Ping timeout: 260 seconds]
00:46 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
00:46 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev
00:48 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
00:49 -!- jonatack [~jon@37.167.12.232] has joined #bitcoin-core-dev
00:49 -!- jonatack [~jon@37.167.12.232] has quit [Remote host closed the connection]
00:49 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
00:53 -!- jonatack [~jon@37.167.12.232] has joined #bitcoin-core-dev
00:57 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
01:02 -!- Pavlenex [~Thunderbi@185.244.212.67] has joined #bitcoin-core-dev
01:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:04 < bitcoin-git> [bitcoin] fanquake pushed 12 commits to master: https://github.com/bitcoin/bitcoin/compare/28f4e53e168f...2562d5d23863
01:04 < bitcoin-git> bitcoin/master f36140d fanquake: build: use patch rather than sed in bdb package
01:04 < bitcoin-git> bitcoin/master 335bd7f fanquake: build: use patch rather than sed in Boost package
01:04 < bitcoin-git> bitcoin/master 865cb23 fanquake: build: use patch rather than sed in fontconfig package
01:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:04 < bitcoin-git> [bitcoin] fanquake merged pull request #19761: build: improve sed robustness by not using sed (master...maximum_sed_robustness) https://github.com/bitcoin/bitcoin/pull/19761
01:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:06 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev
01:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:11 < bitcoin-git> [bitcoin] fanquake opened pull request #19817: build: libtapi 1100.0.11 (master...libtapi_1100011) https://github.com/bitcoin/bitcoin/pull/19817
01:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:19 -!- Pavlenex [~Thunderbi@185.244.212.67] has quit [Quit: Pavlenex]
01:25 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
01:29 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
01:32 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 258 seconds]
01:34 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
01:34 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
01:34 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
01:37 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds]
01:38 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
01:39 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
01:43 -!- jeremyrubin [~jr@2601:645:c200:f539:c134:ae7f:2da9:d893] has quit [Ping timeout: 260 seconds]
01:43 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 246 seconds]
01:46 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection]
01:46 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
02:00 -!- grawity1 [~grawity@195.206.169.184] has quit []
02:01 -!- thunderbiscuit[m [thunderbis@gateway/shell/matrix.org/x-hamfixdaukjsctbi] has quit [Quit: Idle for 30+ days]
02:04 -!- kexkey [~kexkey@89.36.78.166] has quit [Ping timeout: 240 seconds]
02:08 < wumpus> "improve sed robustness by not using sed" is still in the run for best commit message ever
02:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:11 < bitcoin-git> [bitcoin] jonatack opened pull request #19818: p2p: change `CInv::type` from `int` to `uint32_t`, fix UBSan warning (master...CInv-type-refactoring) https://github.com/bitcoin/bitcoin/pull/19818
02:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:19 -!- promag [~promag@188.251.225.32] has joined #bitcoin-core-dev
02:21 -!- Zao_ [~Zao_@104.254.90.203] has joined #bitcoin-core-dev
02:32 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
02:34 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Ping timeout: 240 seconds]
02:43 -!- Zao_ [~Zao_@104.254.90.203] has quit [Ping timeout: 258 seconds]
02:43 -!- jonatack [~jon@37.167.12.232] has quit [Read error: Connection reset by peer]
02:47 < _0x0ff> did testnet reset recently? none of the txs in mempool seem to be added into new blocks
02:52 < _0x0ff> did testnet reset recently? none of the txs in mempool seem to be added into new blocks
02:53 < _0x0ff> my apologies for a double message, wrong window
02:56 -!- elsimio [~elsimio@195.181.170.239] has joined #bitcoin-core-dev
03:00 -!- promag [~promag@188.251.225.32] has quit [Remote host closed the connection]
03:01 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:a983:51a8:1ad6:7118] has joined #bitcoin-core-dev
03:01 -!- promag [~promag@188.251.225.32] has joined #bitcoin-core-dev
03:02 -!- kristapsk___ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
03:05 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has quit [Ping timeout: 240 seconds]
03:10 -!- promag [~promag@188.251.225.32] has quit [Remote host closed the connection]
03:10 -!- promag [~promag@188.251.225.32] has joined #bitcoin-core-dev
03:16 -!- promag [~promag@188.251.225.32] has quit [Remote host closed the connection]
03:17 -!- promag [~promag@188.251.225.32] has joined #bitcoin-core-dev
03:18 -!- Kariane14Kling [~Kariane14@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev
03:25 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:a983:51a8:1ad6:7118] has quit [Remote host closed the connection]
03:25 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:a983:51a8:1ad6:7118] has joined #bitcoin-core-dev
03:29 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:a983:51a8:1ad6:7118] has quit [Ping timeout: 240 seconds]
03:32 -!- promag [~promag@188.251.225.32] has quit [Remote host closed the connection]
03:33 -!- promag [~promag@188.251.225.32] has joined #bitcoin-core-dev
03:37 -!- promag [~promag@188.251.225.32] has quit [Remote host closed the connection]
03:38 -!- promag [~promag@188.251.225.32] has joined #bitcoin-core-dev
03:41 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev
03:43 -!- promag [~promag@188.251.225.32] has quit [Remote host closed the connection]
03:43 -!- kristapsk___ [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
03:49 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev
03:55 -!- Kariane14Kling [~Kariane14@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 256 seconds]
03:57 -!- promag [~promag@188.251.225.32] has joined #bitcoin-core-dev
03:59 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
04:00 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
04:02 -!- promag [~promag@188.251.225.32] has quit [Remote host closed the connection]
04:05 -!- promag [~promag@188.251.225.32] has joined #bitcoin-core-dev
04:07 < _0x0ff> seems to be working now
04:10 -!- jp-tourist [af8628f1@KD175134040241.ppp-bb.dion.ne.jp] has joined #bitcoin-core-dev
04:10 -!- jp-tourist [af8628f1@KD175134040241.ppp-bb.dion.ne.jp] has quit [Remote host closed the connection]
04:12 < wumpus> testnet can't just 'reset', it's unreliable though sometimes because of flaky miner behavior, this is one of the reasons for signet
04:15 -!- promag [~promag@188.251.225.32] has quit [Remote host closed the connection]
04:16 -!- promag [~promag@188.251.225.32] has joined #bitcoin-core-dev
04:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:18 < bitcoin-git> [bitcoin] S3RK closed pull request #19774: wallet: deactivate descriptor (master...wallet_deactivate_descriptor) https://github.com/bitcoin/bitcoin/pull/19774
04:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:21 -!- promag [~promag@188.251.225.32] has quit [Remote host closed the connection]
04:31 < _0x0ff> wumpus: noted, thanks for clarifying. I needed testnet unfortunatelly, but everything is OK now.
04:46 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
04:51 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Quit: ZNC 1.7.5 - https://znc.in]
04:52 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev
04:53 -!- promag [~promag@188.251.225.32] has joined #bitcoin-core-dev
04:53 < vasild> sipa: any advices on which sha3-256 implementation to import in src/crypto/? (sha3-256 is needed to create torv3 addresses from the 32 byte address public key which we are going to be sending and storing)
04:59 < vasild> https://github.com/bitcoin/bips/blob/master/bip-0155.mediawiki#Appendix_B_Tor_v3_address_encoding -- I guess another option would be to send PUBKEY+CHECKSUM instead of just PUBKEY and never calculate the checksum, if adding sha3-256 would be undesirable
04:59 < vasild> wumpus: ^
05:00 -!- elsimio [~elsimio@195.181.170.239] has quit []
05:01 < wumpus> vasild: I don't really mind adding it; I think the more compact representation is elegant
05:02 < wumpus> vasild: I had just forgotten about it sorry
05:06 < sipsorcery> vasild: a year or so ago, when doing some ethereum work, I ran into issues with different sha3 implementations.
05:06 < vasild> yes, I agree
05:07 < sipsorcery> I think most of the problem comes from keccak and sha3 being used interchangeably.
05:07 < vasild> what issues?
05:08 < sipsorcery> given sha3 is only going to be for tov3 addresses wouldn't the safest issue be to take the sha3 source from the tor code base?
05:09 < vasild> ah, you mean if our sha3-256 produces different results than the tor's sha3-256?
05:09 < sipsorcery> All I can recall about the issue is that calling "sha3" from two different code bases gave different hashes.
05:09 < vasild> one of the libraries I am considering is cryptopp and it contains this comment:
05:10 < sipsorcery> I think within the keccak family different parameters can be set for the hash function.
05:10 < wumpus> that's curious, be careful to check against test vectors from the standard
05:10 < vasild> The Crypto++ implementation conforms to the FIPS 202 version of SHA3 using F1600 with XOF d=0x06
05:10 < vasild> Previous behavior (XOF d=0x01) is available in Keccak classes.
05:10 < wumpus> and against tor itself of course
05:10 < sipsorcery> Part of the issue seems to be that people started calling  keccak derived function sha3 before the nist standard came out
05:11 < sipsorcery> but i'm no expert, I just recall it being a pain at the time.
05:11 < wumpus> I suppose in our case as we will only use sha3 for tor, it's okay if it matches just what they happen to call sha3
05:12 < vasild> I already checked that "openssl sha3-256" produces same hash as the one used in torv3
05:12 < wumpus> I remember doing a similar experiment with Python
05:12 < sipsorcery> yes, could always call it tor-sha3 or something if there was likely to be doubt.
05:13 -!- promag [~promag@188.251.225.32] has quit [Remote host closed the connection]
05:14 -!- promag [~promag@188.251.225.32] has joined #bitcoin-core-dev
05:16 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
05:20 -!- someone235 [uid419897@gateway/web/irccloud.com/x-irycwryiavkziodk] has joined #bitcoin-core-dev
05:21 -!- promag [~promag@188.251.225.32] has quit [Ping timeout: 240 seconds]
05:22 -!- cprofitt1 [~cprofitt@104.254.90.203] has joined #bitcoin-core-dev
05:24 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
05:26 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
05:33 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
05:33 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
05:39 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Ping timeout: 258 seconds]
05:46 -!- _flow_ [~none@salem.informatik.uni-erlangen.de] has joined #bitcoin-core-dev
05:50 -!- twistedline [~twisted@unaffiliated/twistedline] has quit [Remote host closed the connection]
05:54 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has joined #bitcoin-core-dev
06:02 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
06:05 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Remote host closed the connection]
06:05 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev
06:07 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Remote host closed the connection]
06:07 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev
06:08 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Remote host closed the connection]
06:08 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev
06:08 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
06:09 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
06:10 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Remote host closed the connection]
06:10 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
06:10 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev
06:11 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
06:11 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Remote host closed the connection]
06:11 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev
06:12 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Remote host closed the connection]
06:12 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev
06:15 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
06:16 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
06:18 -!- Davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection]
06:27 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::1e7] has quit [Ping timeout: 260 seconds]
06:30 -!- gzhao408 [uid453516@gateway/web/irccloud.com/x-fsgjyobljojfjrcf] has joined #bitcoin-core-dev
06:32 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection]
06:32 -!- cprofitt1 [~cprofitt@104.254.90.203] has quit [Remote host closed the connection]
06:33 -!- melande [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev
06:34 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::1e7] has joined #bitcoin-core-dev
06:37 -!- Pavlenex [~Thunderbi@185.244.212.67] has joined #bitcoin-core-dev
06:42 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Read error: Connection reset by peer]
06:42 -!- Pavlenex [~Thunderbi@185.244.212.67] has quit [Quit: Pavlenex]
06:44 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev
06:48 -!- _flow_ [~none@salem.informatik.uni-erlangen.de] has quit [Quit: WeeChat 2.8]
06:48 -!- _flow_ [~none@salem.informatik.uni-erlangen.de] has joined #bitcoin-core-dev
06:48 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev
06:51 -!- Pavlenex [~Thunderbi@185.244.212.67] has joined #bitcoin-core-dev
06:51 -!- Pavlenex [~Thunderbi@185.244.212.67] has quit [Client Quit]
07:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:00 < bitcoin-git> [bitcoin] fanquake closed pull request #19700: wallet: Replace -zapwallettxes with wallet tool command (master...zapwallettxes-wallettool) https://github.com/bitcoin/bitcoin/pull/19700
07:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:00 -!- _flow_ [~none@salem.informatik.uni-erlangen.de] has quit [Quit: WeeChat 2.8]
07:00 -!- _flow_ [~none@salem.informatik.uni-erlangen.de] has joined #bitcoin-core-dev
07:03 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection]
07:03 -!- melande [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev
07:04 -!- gnomus [~gnomus@77.243.177.38] has joined #bitcoin-core-dev
07:04 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection]
07:05 -!- _flow_ [~none@salem.informatik.uni-erlangen.de] has quit [Quit: WeeChat 2.9]
07:05 -!- melande [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev
07:05 -!- _flow_ [~none@salem.informatik.uni-erlangen.de] has joined #bitcoin-core-dev
07:16 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds]
07:19 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
07:21 -!- Pavlenex [~Thunderbi@185.244.212.67] has joined #bitcoin-core-dev
07:21 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Quit: Leaving]
07:21 -!- Pavlenex [~Thunderbi@185.244.212.67] has quit [Client Quit]
07:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:22 < bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/2562d5d23863...91af7ef831d3
07:22 < bitcoin-git> bitcoin/master a13cafc João Barbosa: wallet: GetWalletTx requires cs_wallet lock
07:22 < bitcoin-git> bitcoin/master d8441f3 João Barbosa: wallet: IsMine overloads require cs_wallet lock
07:22 < bitcoin-git> bitcoin/master b8405b8 João Barbosa: wallet: IsChange requires cs_wallet lock
07:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:23 < bitcoin-git> [bitcoin] laanwj merged pull request #19289: wallet: GetWalletTx and IsMine require cs_wallet lock (master...2020-06-wallet-less-locks) https://github.com/bitcoin/bitcoin/pull/19289
07:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:28 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev
07:30 -!- _flow_ [~none@salem.informatik.uni-erlangen.de] has quit [Quit: WeeChat 2.9]
07:32 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
07:42 -!- Pavlenex [~Thunderbi@185.244.212.67] has joined #bitcoin-core-dev
07:44 < wumpus> in any case I would be really surprised if Tor would get SHA3 wrong/non-standard :)
07:45 < wumpus> vasild: do you have a replacement for #19628 in high prio for review?
07:45 < gribble> https://github.com/bitcoin/bitcoin/issues/19628 | net: change CNetAddr::ip to have flexible size by vasild · Pull Request #19628 · bitcoin/bitcoin · GitHub
07:48 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Remote host closed the connection]
07:48 -!- dergoegge [sid453889@gateway/web/irccloud.com/x-kkwvhggdkzeaxpvx] has joined #bitcoin-core-dev
07:49 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev
07:50 < MarcoFalke> #proposedmeetingtopic Status of 0.19 minor release https://github.com/bitcoin/bitcoin/issues?q=label%3A%22Needs+backport+%280.19%29%22+is%3Aclosed
07:50 < MarcoFalke> #proposedmeetingtopic Status of signet implementation in Bitcoin Core
08:00 -!- gnomus [~gnomus@77.243.177.38] has quit []
08:00 -!- dkrm [~dkrm@2001:41d0:8:3f7b::1] has joined #bitcoin-core-dev
08:04 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection]
08:05 -!- melande [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev
08:15 < elichai2> how does the `version`message work? how does it know my own IP address? (in the eyes of the receiving node)
08:16 < MarcoFalke> elichai2: It should be all zeros or another constant 
08:16 < elichai2> ohh, and I thought `CService` has some magic I can't figure out lol
08:17 < MarcoFalke> There certaily is magic, but #8740 changed what is sent
08:17 < gribble> https://github.com/bitcoin/bitcoin/issues/8740 | net: No longer send local address in addrMe by laanwj · Pull Request #8740 · bitcoin/bitcoin · GitHub
08:19 -!- proofofk_ [~proofofke@2601:280:c280:e500:4a6:fa07:fcee:cee8] has joined #bitcoin-core-dev
08:20 -!- proofofk_ [~proofofke@2601:280:c280:e500:4a6:fa07:fcee:cee8] has quit [Client Quit]
08:22 -!- tomatopotato [~tomatopot@84.39.117.57] has joined #bitcoin-core-dev
08:22 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection]
08:23 -!- sr_gi [~sr_gi@static-144-88-225-77.ipcom.comunitel.net] has quit [Ping timeout: 256 seconds]
08:23 -!- melande [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev
08:28 -!- relocate [~relocate@195.181.160.175.adsl.inet-telecom.org] has joined #bitcoin-core-dev
08:31 -!- alko89_ [~alko89@cpe-85-10-28-138.static.amis.net] has quit [Quit: ZNC 1.7.5 - https://znc.in]
08:36 < sipa> sipsorcery vasild wumpus: ethereum doesn't actually use sha3, but keccak with parameters that were proppsed for sha3 before it was finalized (and changed afterwards)
08:36 -!- alko89 [~alko89@unaffiliated/alko89] has joined #bitcoin-core-dev
08:37 -!- kexkey [~kexkey@89.36.78.166] has joined #bitcoin-core-dev
08:40 < sipsorcery> sipa: yes that's what I found out the hard way. it gets called sha3 in lots of places in the ethereum docs and code comments.
08:43 < sipsorcery> *that should be the C++ geth code base and docs (I didn't look over ALL the ethereum code)
08:45 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
08:49 -!- andreacab [~andreacab@12.46.194.178.dynamic.wline.res.cust.swisscom.ch] has joined #bitcoin-core-dev
08:49 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 240 seconds]
08:50 < jonasschnelli> I finally fixed the macOS build on bitcoinbuilds.org, github integration is next (since it was running more or less without troubles for months, except the missing macOS sdk which is a config problem)
08:54 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Read error: Connection reset by peer]
08:55 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
08:55 < hebasto> jonasschnelli: many thanks!
08:59 -!- andreacab [~andreacab@12.46.194.178.dynamic.wline.res.cust.swisscom.ch] has quit [Remote host closed the connection]
08:59 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:cdf8:70f8:fcaa:27c5] has joined #bitcoin-core-dev
09:01 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:cdf8:70f8:fcaa:27c5] has quit [Read error: Connection reset by peer]
09:01 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:cdf8:70f8:fcaa:27c5] has joined #bitcoin-core-dev
09:03 < elichai2> MarcoFalke: ha! thanks :)
09:04 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection]
09:05 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
09:05 -!- melande [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev
09:09 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev
09:13 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection]
09:15 < wumpus> jonasschnelli: thank you!
09:19 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:cdf8:70f8:fcaa:27c5] has quit [Remote host closed the connection]
09:21 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Quit: Defeated by Superior]
09:21 -!- Pavlenex [~Thunderbi@185.244.212.67] has quit [Quit: Pavlenex]
09:21 -!- melande [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev
09:23 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
09:26 < jonatack> jonasschnelli: nice one!
09:27 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 246 seconds]
09:29 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
09:30 -!- cato__ [~cato@gateway/tor-sasl/alec] has quit [Ping timeout: 240 seconds]
09:35 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::1e7] has quit [Ping timeout: 244 seconds]
09:37 -!- cato_ [~cato@gateway/tor-sasl/alec] has joined #bitcoin-core-dev
09:40 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev
09:41 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Remote host closed the connection]
09:42 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev
09:45 < Bullit> Bitcoin QT keeps closing at startup, it crashed suddenly during a youtube, i restarted my computer now Bitcoin QT does not proceed further then blockindex
09:46 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::1e7] has joined #bitcoin-core-dev
09:47 -!- Asbestos_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has quit [Quit: Leaving]
09:48 < Bullit> nope Bitcoin QT still fails to load into full blockchain
09:48 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has joined #bitcoin-core-dev
09:54 < luke-jr> vasild: I don't understand why we need to do the SHA3 on our end. Shouldn't we be able to give Tor the private key, and it give us back an address?
09:54 < wumpus> Bullit: what causes it to shut down? can you upload the last part of debug.log to some pastebin?
09:56 < wumpus> luke-jr: please read back this discussion; the .onion urls contain a sha-3 hash as checksum, but in addrv2 only the 32 bytes of raw address data is sent (to save bandwidth), not this checksum, so it needs to be computed client side
09:56 < sipa> right, this is not about computing our onion address, but to convert between the bip155 encoding and onion addresses
09:57 < sipa> vasild: happy to help find a sha3 implementation, if needed
09:57 < wumpus> indeed, it's not needed for determining our own address
09:58 -!- jeremyrubin [~jr@2601:645:c200:f539:10b:1840:c70a:412a] has joined #bitcoin-core-dev
09:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:58 < bitcoin-git> [bitcoin] dongcarl opened pull request #19822: chain: Fix CChain comparison UB (master...2020-08-chain-comparison-UB) https://github.com/bitcoin/bitcoin/pull/19822
09:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:59 < Bullit> wumpus: I have uploaded the result of the log of a new crash to pastebin, this is the link>https://pastebin.com/embed_iframe/RWbeCz16
10:05 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection]
10:06 -!- melande [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev
10:07 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Remote host closed the connection]
10:07 < luke-jr> wumpus: oh :x
10:07 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
10:07 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev
10:09 < wumpus> Bullit: that's really the end of the log? no error message?
10:09 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection]
10:12 -!- melande [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev
10:13 < wumpus> Bullit: in any case, the only advice I can give is to reindex using -reindex-chainstate, it's pretty clear thechainstate is currupt due to the sudden crash
10:17 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has quit [Ping timeout: 256 seconds]
10:26 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Ping timeout: 258 seconds]
10:30 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
10:33 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Ping timeout: 265 seconds]
10:34 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has joined #bitcoin-core-dev
10:43 -!- relocate [~relocate@195.181.160.175.adsl.inet-telecom.org] has quit [Quit: relocate]
10:44 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
10:47 < stevenroose> Is the coinbase maturity of regtest different than 100?
10:49 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 264 seconds]
10:50 < Bullit> wumpus: yes the log really ends in that 0% warning. just before the crash my mouse pointer indicates a loading, I register that loading as a normal interval
10:50 < MarcoFalke> stevenroose: no it should be 100
10:51 < MarcoFalke> COINBASE_MATURITY isn't even a chain param
10:52 < stevenroose> k yeah couldn't find it but wasn't sure if I got the name right
10:52 < stevenroose> MarcoFalke: thanks
10:58 < jonatack> stevenroose: some explanation in test/functional/interface_bitcoin_cli.py:17: # COINBASE_MATURITY (100) blocks. Therefore, after mining 101 blocks we expect
11:00 -!- tomatopotato [~tomatopot@84.39.117.57] has quit []
11:09 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
11:10 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has quit [Ping timeout: 240 seconds]
11:14 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 265 seconds]
11:17 < jonasschnelli> Bullit: no error on screen? What OS are you using? What version of Core?
11:19 < Bullit> jonasschnelli: A small load on my mouse pointer, and sudden crash, no error log, I am using Windows 10 (15 years experience) I have bitcoin QT 0.20, in the log it says QT 5.9.8
11:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:19 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/91af7ef831d3...b987e657cda9
11:19 < bitcoin-git> bitcoin/master a99a3c0 pasta: rpc: Validate provided keys for query_options parameter in listunspent
11:19 < bitcoin-git> bitcoin/master b987e65 MarcoFalke: Merge #19169: rpc: Validate provided keys for query_options parameter in l...
11:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:19 < jonasschnelli> Bullit: have you ran older versions of Core before? Or freshly installed for the first time on your system? 
11:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:20 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19169: rpc: Validate provided keys for query_options parameter in listunspent (master...bitcoin-validate-keys-listunspent) https://github.com/bitcoin/bitcoin/pull/19169
11:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:20 < Bullit> I ran Bitcoin QT 0.18 on a Linux laptop, which failed early august during the heat, I then installed Bitcoin QT 0.20 on this Windows machine
11:20 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection]
11:21 < jonasschnelli> Bullit: you can try to remove the data directory (where the local blocks, wallet, etc. is stored). Gives it kind of a fresh start. ONLY DO THIS IF YOU HAVEN'T USED THE WALLET
11:21 < jonasschnelli> See: https://en.bitcoin.it/wiki/Data_directory
11:21 -!- melande [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev
11:21 < jonasschnelli> just remove the complete folder
11:22 -!- tonsofpcs1 [~tonsofpcs@84.39.116.180] has joined #bitcoin-core-dev
11:22 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection]
11:23 -!- melande [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev
11:26 < Bullit> jonasschneli: the data directory is on my NAS, downloading and verifying of the blocks gave no problem, but in a Heavy Youtube about British Parliament bitcoin suddenly crashed
11:28 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds]
11:30 < wumpus> it's well known that bitcoin is one of the heaviest things to run and and excellent CPU burn in test, any subpar hardware will fail on it, I'd suggest you get better hardware first
11:31 < wumpus> otherwise you'll keep having this over and over again
11:31 < MarcoFalke> Are NAS supported even?
11:31 < MarcoFalke> I keep hearing corruption issues with remote disks
11:32 < Bullit> wumpus: my graphix card is from a 2014 litecoin miner, why would the hardware not suffice?
11:32 < wumpus> it's not a problem in itself depending on the file sytem, sometimes there's file locking problems, but otherwise it should work fine (as long as you don't have power loss or CPU overheats etc ofc but that's always)
11:32 < wumpus> Bullit: not cooled well enough if it crashes with heat
11:33 < Bullit> wumpus: watercooling with a i7 intell
11:33 < wumpus> still it sounds like a hardware issue
11:34 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
11:34 < wumpus> in any case: try reindexing, it'll probably make the problem go away until the next time things overheat
11:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:35 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b987e657cda9...15886b08aa5f
11:35 < bitcoin-git> bitcoin/master b6dcc6d Hennadii Stepanov: gui: Clarify block height label
11:35 < bitcoin-git> bitcoin/master 15886b0 MarcoFalke: Merge bitcoin-core/gui#40: Clarify block height label
11:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:35 < Bullit> wumpus: the Bitcoin QT crashes at startup, I do not see an opportunity to go into console without seeing my wallet first
11:36 < vasild> wumpus: not yet next PR to review, it would have been the next commit in https://github.com/bitcoin/bitcoin/pull/19031 but when I looked at it again I realized we can't to CNetAddr::ToString() of a TORv3 and this is where the sha3-256 came. I almost integrated some of the files from crypto++, they are in the public domain. I hope to be able to open a PR tomorrow.
11:36 < vasild> s/can't to/can't do/
11:37 < wumpus> Bullit: no need for that, you need to pass -reindex on the command line to the executable itself
11:40 -!- someone235 [uid419897@gateway/web/irccloud.com/x-irycwryiavkziodk] has quit [Quit: Connection closed for inactivity]
11:40 < Bullit> wumpus: I used a shortcut with -reindex, the Client opens and is reindexing, thanks for the advice
11:50 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has joined #bitcoin-core-dev
11:55 -!- pinheadmz [~pinheadmz@2600:380:585b:c01f:d822:7d8b:6e4e:7383] has joined #bitcoin-core-dev
11:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:56 < bitcoin-git> [bitcoin] Z5483 opened pull request #19823: WIP: ci: check if scripted diff is using BSD sed syntax (master...master) https://github.com/bitcoin/bitcoin/pull/19823
11:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:01 < meshcollider> meeting?
12:01 -!- Pavlenex [~Thunderbi@185.244.212.67] has joined #bitcoin-core-dev
12:01 < MarcoFalke> meeting!
12:02 < achow101> meetin'?
12:02 < sipa> meeting¿
12:02 -!- Pavlenex [~Thunderbi@185.244.212.67] has quit [Client Quit]
12:03 < jonasschnelli> #startmeeting
12:03 < lightningbot> Meeting started Thu Aug 27 19:03:12 2020 UTC.  The chair is jonasschnelli. Information about MeetBot at http://wiki.debian.org/MeetBot.
12:03 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
12:03 < jonasschnelli> hi
12:03 < MarcoFalke> lekker
12:03 < hebasto> hi
12:03 < jonatack> hallo
12:03 < meshcollider> hi
12:03 < sipa> hi
12:03 < wumpus> hi
12:03 < sipsorcery> hi
12:03 < amiti> hi
12:03 < MarcoFalke> hi
12:03 < achow101> hai
12:04  * MarcoFalke waiting for the mass-ping
12:04 < jonasschnelli> Am I right that the only proposed topics are form MarcoFalke? (0.19 minor release / signet)?
12:04 < wumpus> jonasschnelli: correct
12:04 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james
12:04 < wumpus> amiti fjahr jeremyrubin lightlike emilengler jonatack hebasto jb55 elichai2
12:05 < jonasschnelli> #topic High priority for review
12:05 < jonasschnelli> is there anything you want to add or remove or replace?
12:05 < wumpus> https://github.com/bitcoin/bitcoin/projects/8
12:05 < MarcoFalke> add #19717 :)
12:05 < gribble> https://github.com/bitcoin/bitcoin/issues/19717 | rpc: Assert that RPCArg names are equal to CRPCCommand ones (mining,zmq,rpcdump) by MarcoFalke · Pull Request #19717 · bitcoin/bitcoin · GitHub
12:06 < wumpus> MarcoFalke: replace #19629?
12:06 < gribble> https://github.com/bitcoin/bitcoin/issues/19629 | refactor: Keep mempool interface in validation by MarcoFalke · Pull Request #19629 · bitcoin/bitcoin · GitHub
12:06 < MarcoFalke> jup, removed the other
12:07 < jonasschnelli> done
12:07 < MarcoFalke> thx
12:07 < jonasschnelli> currently 10 blockers, 3 chasing concept ACK (same as last week)
12:08 < jonasschnelli> #topic Status of 0.19 minor release (MarcoFalke)
12:08 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
12:09 < MarcoFalke> Well, we should probably wrap that up and ship?
12:09 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Read error: Connection reset by peer]
12:09 < MarcoFalke> https://github.com/bitcoin/bitcoin/milestone/46 
12:09 < wumpus> sounds good to me, I had no idea that was ready?
12:09 < MarcoFalke> though, there is still some tagged for backport: https://github.com/bitcoin/bitcoin/issues?q=label%3A%22Needs+backport+%280.19%29%22 
12:10 < jonasschnelli> #19681 looks ready for merge
12:10 < gribble> https://github.com/bitcoin/bitcoin/issues/19681 | 0.19: Add txids with non-standard inputs to reject filter by sdaftuar · Pull Request #19681 · bitcoin/bitcoin · GitHub
12:11 < wumpus> agree
12:12 < wumpus> so does #18284?
12:12 < gribble> https://github.com/bitcoin/bitcoin/issues/18284 | [0.19] scheduler: Workaround negative nsecs bug in boosts wait_until by luke-jr · Pull Request #18284 · bitcoin/bitcoin · GitHub
12:12 < MarcoFalke> 18284 isn't a backport, though
12:13 < jonasschnelli> if we want to have the http race also fixed in 0.19.2, we should mark #19033 0.19.2,... otherwise move 18856
12:13 < gribble> https://github.com/bitcoin/bitcoin/issues/19033 | http: Release work queue after event base finish by promag · Pull Request #19033 · bitcoin/bitcoin · GitHub
12:13 < wumpus> it's labeled 0.19.2 and targetted for 0.19 thugh
12:13 < MarcoFalke> The bug is not a regression in 0.19, so I am not sure if we *need* to fix it
12:14 < MarcoFalke> and it doesn't happen on servers
12:14 < wumpus> why didn't you never comment that on the PR?
12:14 < wumpus> it has only ACKs now
12:14 < wumpus> so it looks ready to go at least
12:14 < MarcoFalke> ok, will leave a comment now
12:15 < wumpus> it's fine with me to not do it at all, but if no one comments that in months that's not very clear to the author
12:15 < jeremyrubin> it should only happen if you're mocking the time right?
12:16 < jonasschnelli> #19033 is ready for merge IMO.. a backport to 0.19.2 should be easy to fix 18856
12:16 < gribble> https://github.com/bitcoin/bitcoin/issues/19033 | http: Release work queue after event base finish by promag · Pull Request #19033 · bitcoin/bitcoin · GitHub
12:16 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection]
12:17 < MarcoFalke> jeremyrubin: No only if you hibernate/suspend
12:17 < jamesob> Can I have #19806 added?
12:17 < jeremyrubin> probably fine to fix then
12:17 < gribble> https://github.com/bitcoin/bitcoin/issues/19806 | validation: UTXO snapshot activation by jamesob · Pull Request #19806 · bitcoin/bitcoin · GitHub
12:17 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.9]
12:17 < jeremyrubin> jamesob: added to 0.19 backport?
12:17 -!- melande [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev
12:17 < MarcoFalke> high prio
12:17 < wumpus> the code change itself looked ok to me
12:17 < jonasschnelli> jeremyrubin: sure. Adding...
12:18 < jamesob> Oops, we're still on highprio right?
12:18 < wumpus> it's always possible to argue it's not *worth* fixing, but I think it's kind of strange if there is already a patch
12:18 < wumpus> if it can happen with hiberbate/suspend that seems like a legit issue?
12:18 < jonasschnelli> jamesob: no. 0.19.2 (but it's fine)
12:19 < MarcoFalke> wumpus: Jup, the code change looks fine obviously. Though, it is also boost. A previous version of the patch forgot to catch and re-throw boost::thread_interrupted
12:19 < MarcoFalke> I'd rather have a known bug that is well understood than an newly introduced intermittent unknown bug
12:19 < wumpus> is there any urgency to do another 0.19 release at all?
12:20 < jeremyrubin> reject filtering?
12:20 -!- lightlike [~lightlike@88.116.7.34] has joined #bitcoin-core-dev
12:20 < MarcoFalke> wumpus: Not really. Not sure how urgent the reject filtering needs to go out
12:20 < jeremyrubin> that was the main motivator iirc?
12:20 < sipa> i don't think that's urgent
12:22 < wumpus> not urgent enough to rush and skip other fixes at least
12:22 < jonasschnelli> Anything to add to 0.19.2? (MarcoFalke)
12:23 < MarcoFalke> Not really. Everything should be tagged already.
12:23 < jonasschnelli> #topic Status of signet implementation in Bitcoin Core (MarcoFalke)
12:23 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection]
12:24 < MarcoFalke> Pretty much a short topic. I only wanted to ask if anyone plans to ACK/NACK/review it.
12:24 < jeremyrubin> i played around with the impl yesterday. It's pretty good but currently lacking the contrib tools
12:24 < MarcoFalke> From my view it seems close to ready 
12:24 < jeremyrubin> It was hard for me to fully test it without the contrib tooling
12:24 -!- melande [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev
12:25 < MarcoFalke> jeremyrubin: I'd say Bitcoin Core is the wrong place to add contrib tools for the signet maintainers.
12:25 < MarcoFalke> They can have their own repo
12:25 < jeremyrubin> MarcoFalke: disagree -- we should be able to produce blocks for signet
12:25 < wumpus> we have a maintainer tools repo just add it there
12:25 < jeremyrubin> I don't care where the tools are
12:25 < wumpus> https://github.com/bitcoin-core/bitcoin-maintainer-tools
12:25 < jeremyrubin> But I care that I can't test a signet that I created
12:26 < sipa> i'm not sure it's really a maintainer tool
12:26 < MarcoFalke> I agree they should be public
12:26 < jeremyrubin> I'm saying that it's a bit of a merge precondition. I would ACK if I could finish testing it
12:26 < wumpus> it's pretty much free for all for anything maintainers need, no need to put signet tools anywhere else
12:26 < sipa> the expectations may be unclear, but i hope that over time various private signets get spun up - it could even replace regtest over time
12:26 < michaelfolkson> Can't test jeremyrubin? What can't you test exactly?
12:27 < jeremyrubin> Well I made my own signet script and network
12:27 < MarcoFalke> michaelfolkson: Mining blocks
12:27 < jeremyrubin> And i cannot produce blocks
12:27 < jeremyrubin> So I can't test peering it and seeing that it works
12:27 < sipa> doesn't mean it needs to be in the repo right now, but i don't think it'd be unreasonable to have the scripts for working/spining up a signet in the main repo
12:28 < jeremyrubin> https://en.bitcoin.it/wiki/Signet
12:28 < sipa> at some point
12:28 < wumpus> no big objection either, but I would say that there need to be tests for them if you'd put them in the main repo, there's already too many quasi-unmaintained tools
12:28 < sipa> agree
12:28 < michaelfolkson> Yeah I'm hazy about what should be in Core, what is covered by Core but I'm sure it will become clearer to me over time
12:29 < jeremyrubin> Yeah the tools could be somewhere, I'm just commenting that I can't finish testing and ACK without having block producing scripts.
12:29 < sipa> wumpus: yes, let's not merge things that are untested and then go broken without anyone noticing
12:29 < wumpus> in any case that doesn't seem necessary for the PR that is open now
12:29 < MarcoFalke> If they get added to the repo, I hope they are not written in bash at least *hides
12:29 < jeremyrubin> wumpus: one cannot tested ACK the current code
12:29 < sipa> jeremyrubin: i don't think that's a blocker for signet itself - the tools are available, right?
12:29 < sipa> just not in the PR
12:29 < jeremyrubin> I don't think so AFAIK
12:30 < wumpus> wait, the tools are not  available *at all*?
12:30 < wumpus> okay, that seems like a blocker
12:30 < jeremyrubin> I think they are quasi available
12:30 < wumpus> why not just ask kallewoof for them
12:30 < jeremyrubin> In that they exist against a prior version of Signet
12:30 < jonasschnelli> I guess kallewoof is asleep
12:30 < jonatack> signet is certainly the PR i've spent the most time doing re-reviews of these past 6 months. it would be nice to begin reviewing follow-ups instead of the whole thing every time. 
12:30 < jeremyrubin> I think they're still finishing them
12:31 < jeremyrubin> And it's fine if we want follow up work to add the full tools
12:31 < michaelfolkson> Is it a blocker? There will be future Signet related PRs
12:31 < jeremyrubin> but if people are wondering why I haven't ACKd it
12:31 < wumpus> in any case, in including the tools in bitcoin core's repo (+tests) should imo not be a requirement for this PR
12:31 < jeremyrubin> (which is more or less the current topic)
12:31 < wumpus> but they need to be available somewhere
12:31 < jeremyrubin> that's why
12:31 < sipa> jeremyrubin: seems very reasonable
12:31 < jeremyrubin> wumpus: +1, I'm happy with them being anywhere
12:32 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
12:32 < jonasschnelli> aren't the tools here: https://github.com/kallewoof/bitcoin/commit/50c839e1d91348408b40b3f8a53e0ef1a7f6da72
12:32 < MarcoFalke> jonasschnelli: There was a previous version that signed the block, not transactions
12:33 < MarcoFalke> I'd bet the current one would be easier to write from scratch
12:33 < sipa> i think it would be good if the signet consensus PR included a trivial python based functional test... even if it's a super simple one with just OP_TRUE as script or so
12:33 < wumpus> yes
12:33 < sipa> i don't see any actual testing apart from a fuzz test?
12:34 < MarcoFalke> sipa: I was planning to write some tests as a follow-up
12:34 < michaelfolkson> There is this too for setting up your own Signet https://github.com/kallewoof/signet-platform
12:34 < instagibbs> sipa, could have all tests run with --signet, and it handles it in background using generate* aliased? :)
12:35 < instagibbs> s/all/some/
12:35 < wumpus> re-running every test seems like overkill
12:35 < wumpus> right
12:35 < MarcoFalke> instagibbs: They'd run for years with that POW
12:35 < sipa> yeah, i just want to make sure the signet code is exercised in tests
12:35 < sipa> that does not seem to be the case in the current PR
12:35 < instagibbs> MarcoFalke, sigregtest ... right
12:35 < MarcoFalke> heh, regtest should already mimic mainnet in most params
12:36 < jeremyrubin> michaelfolkson: those tools don't seem to be current
12:36 < MarcoFalke> Jup, anything that was written before august is outdated
12:36 < instagibbs> aj and kallewoof have the current block keys, for final might be worth having keys in EU/US for timezone arbitrage 
12:36 < michaelfolkson> Volunteering? :)
12:37 < instagibbs> I'm moving their timezone, probably, so no
12:37 < instagibbs> lol
12:37 < instagibbs> voluntelling achow to run a node
12:37 < MarcoFalke> ack
12:37 < jeremyrubin> instagibbs: nack
12:38 < jeremyrubin> I think we shouldn't try to offer signet as any sort of "use the main one thing"
12:38 < jeremyrubin> let a thousand ships sail ;)
12:38 < michaelfolkson> Disagree. But I will post on the mailing list and you can disagree with me there 
12:38 < jeremyrubin> ok
12:39 < achow101> instagibbs: what am I being voluntold to do?
12:40 < jeremyrubin> also note that for signet there's not ~that much value in the current multisig setup
12:40 < jeremyrubin> it's 1 of N
12:40 < michaelfolkson> Third signer on Signet blocks being mined. Congrats achow101
12:40 < jeremyrubin> there's no M of N cordination
12:40 < jeremyrubin> so you can literally do a 1 of 1 and send anyone the key
12:40 < instagibbs> jeremyrubin, right it's less crucial but "hey bump your server"
12:41 < instagibbs> well, then it becomes 1 of 1 over time, anyways, not a huge deal
12:41 < achow101> chaincode should run a signet node then
12:41 < MarcoFalke> I'd presume it is 1 of 2 to protect against power outages
12:41 < jeremyrubin> it's current 1 of 2, which has no security improvement over 1 of 1 where two people know the 1
12:41 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
12:41 < instagibbs> it's not security
12:42 < instagibbs> it's outages
12:42 < instagibbs> hence timezone comment
12:42 < instagibbs> not nation :)
12:42 < jeremyrubin> it has no outages improvement
12:42 < sipa> i think you guys are talking past each other
12:42 < jeremyrubin> unless I'm missing something where you want to know which node created the block
12:42 < michaelfolkson> It does. If one signer is down blocks can still be mined using sigs from the other signer
12:43 < sipa> yeah, i think the only difference is accountability
12:43 < instagibbs> "why not" but also "I've stopped caring" :)
12:43 < sipa> not sure that matters
12:43 < instagibbs> so I'll concede i appear to care less and relent
12:43 < jeremyrubin> Yeah I'm not sure how to make my point more clear but I'll cede the balance of my time (too much CSPAN)
12:43 < instagibbs> you could softfork out on of the keys(haha)
12:44 < instagibbs> (100% not serious)
12:44  * jeremyrubin groans
12:44 -!- pinheadmz [~pinheadmz@2600:380:585b:c01f:d822:7d8b:6e4e:7383] has quit [Quit: pinheadmz]
12:45 < MarcoFalke> 1 of 2 also gives debugability. (You'll see which miner didn't produce blocks)
12:45 < jeremyrubin> you already get that with coinbase message if you want
12:45 < sipa> MarcoFalke: yeah, that's commonly called accountability
12:46 < jeremyrubin> there's maybe an edge on debuggable v.s. provably accountable if the miner-id is a unverified message
12:47 < sipa> i think this is getting off topic
12:47 < jonasschnelli> any other last minute topics?
12:47 < jonatack> so, signet is near-mergeable, just needs a sanity check functional test?
12:47 < jonatack> jonasschnelli: About 0.19.2 backports -- not a bugfix per se but perhaps #19455. It accompanies the cli -generate addition, which was in 0.19.
12:47 < gribble> https://github.com/bitcoin/bitcoin/issues/19455 | rpc generate: print useful help and error message by jonatack · Pull Request #19455 · bitcoin/bitcoin · GitHub
12:48 < luke-jr> re 18284 I don't get why we would intentionally *not* merge a bugfix
12:48 < MarcoFalke> luke-jr: Because of the risk that it introduces new bugs
12:48 < jonasschnelli> jonatack: 19455 is not really a bugfix?
12:48 < luke-jr> it's one thing if people don't give it reviews needed, but once it has review, it doesn't make sense to leave it out
12:48 < jeremyrubin> jonatack: I think one should be able to stand up a net and generate blocks, which might be a subset of that functional test. That's my watermark for tested ACK
12:48 < wumpus> I don't think it's particularly risky
12:49 < jonatack> jonasschnelli: it explains to people that run the former RPC generate that it is now CLI -generate instead
12:49 < wumpus> then again I ACKed it
12:50 < jonasschnelli> jonatack: I'd say no need to backport this... but no strong opinion.
12:50 < jonatack> because several tutorials online still mention rpc generate and it might be confusing for them. Yep, no worry, just mentioning.
12:50 < MarcoFalke> Yeah, I see it has two ACKs
12:51 < jonasschnelli> jonatack: Yes. That is a good point.
12:51 < wumpus> jonatack: I doubt meany people following tutorials will use a new 0.19.x
12:51 < jonasschnelli> yeah,.. that
12:51 < wumpus> not opposed to backporting it, but, these kind of backport releases tend to be used for old software on servers
12:52 < sipa> if used at all
12:52 < luke-jr> well, some end users intentionally hold back on major updates too; but still unlikely they'd be using the old version for something like this
12:52 < sipa> right
12:52 < wumpus> they're definitely downloaded looking at torrent seed server stats etc
12:53 < sipa> wumpus: good to know
12:55 < jonasschnelli> #endmeeting
12:55 < lightningbot> Meeting ended Thu Aug 27 19:55:02 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
12:55 < lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-08-27-19.03.html
12:55 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-08-27-19.03.txt
12:55 < lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-08-27-19.03.log.html
12:55 < jonasschnelli> \o
12:55 < jonatack> o/
12:55 < sipa> /o\
12:56 < jonasschnelli> \Ɵ (masks in public space, folks!)
12:58  * sipa hands jonasschnelli a really big /128 mask
12:58 < jonasschnelli> heh
12:58 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
12:59 < wumpus> hehe
12:59 < midnight> o7
13:00 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Remote host closed the connection]
13:00 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev
13:01 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds]
13:01 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection]
13:03 -!- melande [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev
13:05 -!- lightlike [~lightlike@88.116.7.34] has quit [Quit: Leaving]
13:10 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 240 seconds]
13:12 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev
13:13 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
13:14 < sipa> achow101: 415afcccd3e5583defdb76e3a280f48e98983301 seems pointless
13:14 < sipa> +    if (m_storage.CanSupportFeature(FEATURE_HD_SPLIT) && CHDChain::VERSION_HD_CHAIN_SPLIT) {
13:14 < achow101> sipa: indeed
13:14 -!- Guyver2__ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
13:14 < sipa> i'm not sure what it's supposed to do
13:15 < achow101> upgradewallet is slightly broken. see #18836
13:15 < gribble> https://github.com/bitcoin/bitcoin/issues/18836 | wallet: upgradewallet fixes and additional tests by achow101 · Pull Request #18836 · bitcoin/bitcoin · GitHub
13:15 < sipa> ok
13:16 < achow101> the original goal of that line was to have `m_hd_chain.nVersion <= CHDCHain::VERSION_HD_CHAIN_SPLIT` but I think that doesn't always work as well
13:16 < achow101> s/<=/<
13:17 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds]
13:21 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection]
13:23 -!- melande [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev
13:28 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
13:30 -!- Guyver2__ [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 264 seconds]
13:43 -!- balbirs [~balbirs__@ozlabs.org] has quit [Remote host closed the connection]
13:43 -!- balbirs [~balbirs__@bilbo.ozlabs.org] has joined #bitcoin-core-dev
13:45 -!- vincenzopalazzo [~vincent@host-79-26-113-47.retail.telecomitalia.it] has quit [Remote host closed the connection]
13:47 -!- Era76Macejkovic [~Era76Mace@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev
13:53 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
13:57 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 265 seconds]
14:00 -!- tonsofpcs1 [~tonsofpcs@84.39.116.180] has quit []
14:06 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!]
14:10 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
14:11 -!- Era76Macejkovic [~Era76Mace@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 264 seconds]
14:12 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection]
14:13 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
14:18 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:20 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection]
14:21 -!- Perlboy [~Perlboy@s91904426.blix.com] has joined #bitcoin-core-dev
14:21 -!- melande [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev
14:23 -!- dkrm [~dkrm@2001:41d0:8:3f7b::1] has quit [Ping timeout: 244 seconds]
14:26 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection]
14:31 -!- melande [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev
14:34 -!- reallll is now known as belcher
14:47 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 240 seconds]
15:12 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::1e7] has quit [Ping timeout: 272 seconds]
15:19 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection]
15:23 -!- melande [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev
15:32 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Quit: leaving]
15:36 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
15:51 -!- marcoagner [~user@bl11-17-219.dsl.telepac.pt] has quit [Ping timeout: 240 seconds]
15:55 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
15:57 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has quit [Ping timeout: 264 seconds]
15:59 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
15:59 -!- vasild_ is now known as vasild
16:05 < yanmaani> How do I build bitcoin using depends/ bdb4.8 but system qt / boost / whatever?
16:11 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::1e7] has joined #bitcoin-core-dev
16:16 -!- opsec_x12 [~opsec_x12@c-67-183-29-123.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
16:16 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection]
16:17 -!- melande [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev
16:23 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 240 seconds]
16:26 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
16:40 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection]
16:40 -!- watersnake1 [~christian@98.11.149.49] has joined #bitcoin-core-dev
16:41 -!- melande [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev
16:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
16:50 < bitcoin-git> [bitcoin] dhruv opened pull request #19825: rpc: simplify setban and consolidate BanMan functions (master...consolidate-ban-functions) https://github.com/bitcoin/bitcoin/pull/19825
16:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
16:55 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::1e7] has quit [Ping timeout: 272 seconds]
17:00 -!- Perlboy [~Perlboy@s91904426.blix.com] has quit []
17:03 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds]
17:05 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection]
17:06 < fanquake> Yea it's rare that we'd backport something that isn't actually bugfix, especially to such an old/stable branch.
17:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
17:06 -!- melande [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev
17:09 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
17:11 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev
17:17 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Remote host closed the connection]
17:17 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev
17:22 -!- zelazny [~zelazny@84.39.117.57] has joined #bitcoin-core-dev
17:23 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection]
17:24 -!- melande [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev
17:36 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Quit: Highway61]
17:41 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
17:47 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]
17:53 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
17:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
17:57 < bitcoin-git> [bitcoin] fanquake closed pull request #19009: Print "verifychain" progress every 1 step if user verifies whole blockchain. (master...patch-3) https://github.com/bitcoin/bitcoin/pull/19009
17:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
18:07 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection]
18:08 -!- melande [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev
18:10 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection]
18:14 -!- melande [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev
18:23 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
18:29 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
18:48  * kallewoof wakes up
18:49 < kallewoof> so, the mining stuff is a bit of a work in progress, but AJ is making a follow-up pull request on top of the current one, which has mining in it. the current miner I use on my end is this: https://github.com/kallewoof/bitcoin/tree/202008-signet-ajkey-scripts
18:51 < kallewoof> I'll look into making simple tests that check the current signet consensus stuff with what we have, if people are uncomfortable with the PR not having enoguh tests, but i personally think "worst thing that happens is that signet does not work" (everything else has tests, after all, and the signet code *is* touched then too) fwiw.
18:51 < kallewoof> wumpus sipa aj ^
18:58 < sipa> kallewoof: what PoW difficulty does (the default) signet have?
18:58 < kallewoof> sipa: very low, lower than main/testnet
18:58 < sipa> or maybe better, how low can you set it for a custom one
18:59 < kallewoof> it takes a few seconds on a cpu initially
18:59 < aj> kallewoof: poking at making it accept OP_TRUE as the block challenge with no witness commitment, so plain -generate works
18:59 < sipa> alternatively, if it can be made low enough, a block could be constructed entirely on the python side (the test framework probably has nearly everything already)
19:01 < kallewoof> we could also just pre-mine the block(s) in that case. if the coinbase etc. are all predefined we can set the nonce and such. shouldn't be needed tho as the difficulty is pretty low. (the original mining tests used the c++ miner though, so it may be slow actually..)
19:01 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]
19:01 < sipa> yeah, that's also a possibility
19:02 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection]
19:02 < sipa> mining from the python side means you could easily extend it with some less trivial challenge script too (though that would mean adding the sighash logic there as well, which may make sense anyway)
19:03 -!- melande [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev
19:04 < kallewoof> yeah, i mean the signing code is not big; we could literally drop the generate script into the test framework and use it
19:05 < kallewoof> aj: that would mean the generate script can import those things without doing import path hacks too.. maybe the contrib/signet stuff should just call ../../test/functional/test_framework/(signet_)generate.py or something
19:18 < sipa> kallewoof: fwiw, the powLimit in the signet PR doesn't exactly match the difficulty as specified in BIP325 (the digits after 00002adc28 should be zeroes)
19:18 < kallewoof> *blinks*
19:18 < aj> kallewoof: https://github.com/ajtowns/bitcoin/commit/33b01c42be9e4635c9f590c65d6c2873b0b0f8be allows you to set `-signet_blockscript=51` and then just pretend you're on regtest (except for difficulty)
19:19 < kallewoof> aj: nice, thanks
19:20 < aj> kallewoof: another option (short of including generate.py) might be have the blockscript be "OP_SHA256 x OP_EQUAL" which would mean just adding a constant suffix to the witness commitment for each block
19:20 < sipa> exercising the sighash logic would be even nicer :)
19:20  * sipa hides
19:23 < kallewoof> sipa: are you saying that the compact 0x1e2adc28 expands to 00002adc28000[...] and not the one that is there now? I derived it the other way around, and just kept it as is. Having zeroes makes sense but would mean another reset.
19:23 < sipa> kallewoof: yes
19:24 < sipa> well it wouldn't invalidate any existing blocks (with high probability), but it is technically a signet softfork i guess
19:24 < kallewoof> ohh... actually, you're right it wouldn't. it would just make the limit drop a small amount
19:25 < sipa> i mean: the implementation doesn't match the spec right now (and though the probability is small, it's not unobservable; one in 299928 attempts)
19:25 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection]
19:25 < sipa> one in 299928 *succesful* attempts
19:26 < aj> sipa: yeah, that needs generate.py or equivalent
19:26 -!- melande [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev
19:27 < kallewoof> aj: generate.py without the copy-pasted stuff is not large, though. maybe it should (permanently) reside in the test framework path
19:27 < kallewoof> but that means more for reviewers to review, so probably just try to hack something easy for now..
19:28 < aj> kallewoof: yeah, maybe; don't really want to add it in before cleaning it up more though
19:29 < kallewoof> aj: all right
19:30 < aj> sipa, kallewoof: changing the powLimit to 2adc280000000 doesn't seem to invalidate any existing blocks
19:30 < kallewoof> i just confirmed that it doesn't, too
19:30 < kallewoof> pushed squashie
19:54 < kallewoof> is there a point not squashing if you end up having to rebase on master due to a conflict? I can't see one personally, so gonna squash.
20:00 -!- zelazny [~zelazny@84.39.117.57] has quit []
20:08 < gwillen> kallewoof: if you squash + rebase in one operation it becomes slightly harder to tell whether the squash was just a squash or changed anything (when re-reviewing), but I don't know that it's a big deal
20:08 < gwillen> unless it's a large complex PR with a bunch of existing review
20:08 < gwillen> (and you can always use commandline git to check)
20:08 -!- melande1 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev
20:09 < gwillen> (but it's a bit of a PITA)
20:09 -!- melande [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection]
20:22 -!- Vogone [~Vogone@s91904426.blix.com] has joined #bitcoin-core-dev
20:23 -!- melande1 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection]
20:26 -!- melande1 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev
20:44 < kallewoof> gwillen: i made squash commits, then ended up with a conflict against master and rebased. the entire PR is as such "detached" from whatever commit reviewers saw the last time, so i could've added stuff to the other commits without anyone noticing at that point.
20:45 < sipa> kallewoof: unless PRs are huge (i haven't reviewed your signet one on detail, but it doesn't look very large), i find that most of the work in a review is understanding the flow of changes and how things fot together
20:46 < kallewoof> yeah, i thought so, but i caused poor jonatack to have to restart his review several times cause i kept squashing changes.
20:46 < sipa> once that's done, i don't mind reviewing things from scratch again... it'll go a lot faster
20:46 -!- roconnor [~roconnor@host-45-58-217-138.dyn.295.ca] has quit [Ping timeout: 258 seconds]
20:47 < sipa> and for the fact that you coukd introduce small bur dangerous changes that could be missed on re-review... well ideally that's what you have tests for
20:47 < kallewoof> *nod*
20:47 < sipa> they don't just help guarantee that functionality won't break, they also give reviewers confidence
20:48 < kallewoof> yeah, tests are important. i felt like i had them in the signet PR because i USED to have them, before I split it up to make review easier.
20:48 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds]
20:49 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Remote host closed the connection]
20:49 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has joined #bitcoin-core-dev
20:51 < sipa> kallewoof: i think i've moved in that direction as well; for segwit, everything was tested by adding segwit support into the wallet and using that to test the consensus logic... which i think made the change much bigger than it needed to be
20:52 < gwillen> I don't know if this is something we could add to one of the workflow docs under doc/, but it's not too hard to ask git to check for you whether squashing changed anything
20:52 < sipa> for taproot there is zero wallet support, and signing isn't even implemented in the consensus pr... but there are tests in python that just reimplement it
20:52 < gwillen> it's a bit fiddly, but now that github allows checking out arbitrary commits, including ones that were rebased-away, it's more straightforward
20:52 < kallewoof> sipa: yeah, i noticed! it makes sense, but i was surprised when i was trying to use it in btcdeb/tap :)
20:53 < sipa> kallewoof: right, i see how that complicates things :)
20:53 < kallewoof> gwillen: i am actually confused why git(hub) doesn't have a way to just compare changes since last time. like, give me a diff of what i reviewed before and now
20:54 < kallewoof> gwillen: i hit that "submit review" button so github clearly knows exactly where i was the last time..
20:54 < gwillen> I know that gitlab makes this possible, I thought github had some way to do this
20:54 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
20:54 < gwillen> but at least in gitlab, the only thing you can compare is "changes since last push", so if they rebase against changes to upstream, it's useless because the diff includes all the upstream changes too
20:56 < kallewoof> yeah... having a snapshot of the state when you last reviewed and comparing that to current form would be ideal
20:57 < sipa> i think there is just less effort done on making rebase-heavy workflows easy
20:58 < gwillen> at least when it says "so-and-so force-pushed from <id> to <id>", getting a direct diff on the command line is easy
20:58 < gwillen> just 'git fetch <id>' each of them, then 'git diff <id> <id>'
20:58 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 265 seconds]
20:59 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
20:59 < aj> i think lots of rebases is something a few open source projects do, but most/paying customers tend not to?
20:59 < gwillen> (however if that includes a rebase against new upstream changes, that command won't be useful because it will include those, the right command for that is a little more subtle)
21:00 < luke-jr> sipa: when you're splitting up the Taproot PR, I do think it would make sense to do consensus and policy separately
21:00 -!- melande1 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection]
21:00 < gwillen> ahhh, I always forget this -- in the github UI when you see "so-and-so force-pushed", the words "force-pushed" are a link to the diff
21:01 < gwillen> they kind of hide it, but if you click there you can see the changes in the force push
21:01 < luke-jr> gwillen: the notification emails have links that I suspect are supposed to be that, but they never seem to work for me
21:02 -!- melande1 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev
21:03 < aj> kallewoof, sipa: so currently signet/generate.py supports signing the blocktx via either constructing a psbt, or by calling signrawtransactionwithwallet directly. any reason to keep the latter or can/should i go psbt only, do you think?
21:03 < kallewoof> aj: i think psbt only is ok
21:04 -!- melande1 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection]
21:04 -!- infernix [nix@unaffiliated/infernix] has quit [Ping timeout: 260 seconds]
21:05 -!- melande1 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev
21:12 < sipa> aj: i'd do psbt only
21:18  * aj deletes some more code
21:21 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection]
21:21 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
21:24 < kallewoof> https://github.com/bitcoin/bitcoin/pull/18267/commits/cbb6f9439df8593c3aa52b56698788cc73108831 now tests OP_TRUE mining, and also submitblock checks the first 10 blocks in the current signet chain and also tries the first of those on a non-compatible (different challenge) signet chain.
21:31 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]
21:32 -!- ppisati [~ppisati@net-47-53-118-9.cust.vodafonedsl.it] has quit [Quit: leaving]
21:39 -!- ppisati [~ppisati@net-188-153-155-31.cust.vodafonedsl.it] has joined #bitcoin-core-dev
22:16 -!- baldur [~baldur@pool-173-56-240-14.nycmny.fios.verizon.net] has quit [Ping timeout: 240 seconds]
22:17 -!- baldur [~baldur@pool-173-56-240-14.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
22:17 -!- melande1 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection]
22:18 -!- melande1 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev
22:26 -!- melande1 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection]
22:29 -!- melande1 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev
22:31 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
22:53 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection]
23:00 -!- Vogone [~Vogone@s91904426.blix.com] has quit []
23:14 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::1e7] has joined #bitcoin-core-dev
23:14 -!- melande1 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection]
23:15 -!- melande1 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev
23:22 -!- openstackstatus1 [~openstack@178.239.168.171] has joined #bitcoin-core-dev
23:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:24 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to 0.19: https://github.com/bitcoin/bitcoin/compare/28a9df7d76a6...89a6bb924571
23:24 < bitcoin-git> bitcoin/0.19 ed0223e Luke Dashjr: scheduler: Workaround negative nsecs bug in boost's wait_until
23:24 < bitcoin-git> bitcoin/0.19 89a6bb9 MarcoFalke: Merge #18284: [0.19] scheduler: Workaround negative nsecs bug in boost's w...
23:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:24 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18284: [0.19] scheduler: Workaround negative nsecs bug in boost's wait_until (0.19...wrkarnd_boost_wait_until) https://github.com/bitcoin/bitcoin/pull/18284
23:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:24 -!- melande1 [~melande@gateway/tor-sasl/melande] has quit [Remote host closed the connection]
23:25 -!- melande1 [~melande@gateway/tor-sasl/melande] has joined #bitcoin-core-dev
23:29 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
23:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:33 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/15886b08aa5f...862fde88be70
23:33 < bitcoin-git> bitcoin/master cc26fab practicalswift: tests: Add fuzzing harness for CNode
23:33 < bitcoin-git> bitcoin/master 862fde8 MarcoFalke: Merge #19067: tests: Add fuzzing harness for CNode
23:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:34 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19067: tests: Add fuzzing harness for CNode (master...fuzzers-2020-05-25) https://github.com/bitcoin/bitcoin/pull/19067
23:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:36 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 260 seconds]
23:42 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev
23:51 -!- watersnake1 [~christian@98.11.149.49] has quit [Quit: Leaving.]
23:54 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:9ca6:af14:2fd6:b79f] has joined #bitcoin-core-dev
--- Log closed Fri Aug 28 00:00:01 2020