--- Log opened Mon Aug 31 00:00:04 2020 00:00 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::1e7] has joined #bitcoin-core-dev 00:08 -!- marcoagner [~user@2001:8a0:6a45:1900:2fd7:e0f0:d356:dd70] has joined #bitcoin-core-dev 00:19 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:dde1:f272:550e:1390] has joined #bitcoin-core-dev 00:21 -!- sturles [~sturles@unaffiliated/sturles] has quit [Ping timeout: 260 seconds] 00:26 -!- nanotube [~nanotube@unaffiliated/nanotube] has quit [Ping timeout: 240 seconds] 00:27 -!- vincenzopalazzo [~vincent@104.200.132.241] has joined #bitcoin-core-dev 00:32 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 244 seconds] 00:44 -!- nanotube [~nanotube@unaffiliated/nanotube] has joined #bitcoin-core-dev 01:00 -!- Netsplit *.net <-> *.split quits: aqua42, cryptapus, jMCg, cloudhead, face, go11111111111, baldur, a5m0, nanotube, IGHOR, (+6 more, use /NETSPLIT to show all of them) 01:00 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection] 01:05 -!- nanotube [~nanotube@unaffiliated/nanotube] has joined #bitcoin-core-dev 01:05 -!- jMCg [~jMCg@178.162.204.214] has joined #bitcoin-core-dev 01:05 -!- IGHOR [~quassel@176.121.4.135] has joined #bitcoin-core-dev 01:05 -!- ctrlbreak [~ctrlbreak@159.2.182.106] has joined #bitcoin-core-dev 01:05 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 01:05 -!- face [~face@207.154.206.50] has joined #bitcoin-core-dev 01:05 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 01:05 -!- baldur [~baldur@pool-173-56-240-14.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 01:05 -!- go11111111111 [~go1111111@104.156.98.86] has joined #bitcoin-core-dev 01:05 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 01:05 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 01:05 -!- a5m0 [~a5m0@unaffiliated/a5m0] has joined #bitcoin-core-dev 01:05 -!- JD2983 [~jarret@S01069050cacf3d53.ed.shawcable.net] has joined #bitcoin-core-dev 01:05 -!- cloudhead [~cloudhead@li1811-8.members.linode.com] has joined #bitcoin-core-dev 01:05 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 01:05 -!- aqua42 [~aqua42@amsterdam3.jp.net] has joined #bitcoin-core-dev 01:07 -!- sturles [~sturles@ulrik.uio.no] has joined #bitcoin-core-dev 01:07 -!- sturles [~sturles@ulrik.uio.no] has quit [Changing host] 01:07 -!- sturles [~sturles@unaffiliated/sturles] has joined #bitcoin-core-dev 01:11 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::1e7] has quit [Ping timeout: 272 seconds] 01:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:14 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/afffbb1bc640...269a7ccb2784 01:14 < bitcoin-git> bitcoin/master b266b3e Russell Yanofsky: refactor: Create interfaces earlier during initialization 01:14 < bitcoin-git> bitcoin/master e4f4350 Russell Yanofsky: refactor: Move wallet methods out of chain.h and node.h 01:14 < bitcoin-git> bitcoin/master 24bf176 Russell Yanofsky: gui refactor: Inline SplashScreen::ConnectWallet 01:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:14 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19099: refactor: Move wallet methods out of chain.h and node.h (master...pr/wclient) https://github.com/bitcoin/bitcoin/pull/19099 01:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:19 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::1e7] has joined #bitcoin-core-dev 01:23 -!- kljasdfvv [~flack@p200300d46f11fb00299c5ac58c6f9440.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 01:26 -!- zndtoshi [~zndtoshi@79.112.115.143] has joined #bitcoin-core-dev 01:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:30 < bitcoin-git> [bitcoin] sipsorcery opened pull request #19842: Update the vcpkg checkout commit ID in appveyor config (master...appveyor-vcpkg-update) https://github.com/bitcoin/bitcoin/pull/19842 01:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:33 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:dde1:f272:550e:1390] has quit [Remote host closed the connection] 01:34 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:dde1:f272:550e:1390] has joined #bitcoin-core-dev 01:38 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:dde1:f272:550e:1390] has quit [Ping timeout: 244 seconds] 01:39 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:dde1:f272:550e:1390] has joined #bitcoin-core-dev 01:46 -!- jonatack [~jon@213.152.161.40] has joined #bitcoin-core-dev 01:48 -!- sr_gi [~sr_gi@static-75-213-224-77.ipcom.comunitel.net] has quit [Read error: Connection reset by peer] 01:49 -!- sr_gi [~sr_gi@static-75-213-224-77.ipcom.comunitel.net] has joined #bitcoin-core-dev 01:57 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 01:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:58 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/269a7ccb2784...61b8c04d78fb 01:58 < bitcoin-git> bitcoin/master b667a90 practicalswift: tests: Add fuzzing harness for SigHasLowR(...) and ecdsa_signature_parse_d... 01:58 < bitcoin-git> bitcoin/master 46fcac1 practicalswift: tests: Add fuzzing harness for ec_seckey_import_der(...) and ec_seckey_exp... 01:58 < bitcoin-git> bitcoin/master 61b8c04 MarcoFalke: Merge #19379: tests: Add fuzzing harness for SigHasLowR(...) and ecdsa_sig... 01:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:59 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19379: tests: Add fuzzing harness for SigHasLowR(...) and ecdsa_signature_parse_der_lax(...) (master...fuzzers-SigHashLowR) https://github.com/bitcoin/bitcoin/pull/19379 01:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:00 -!- jMCg [~jMCg@178.162.204.214] has quit [] 02:00 -!- gmaxwell [~procyonid@wikimedia/KatWalsh/x-0001] has joined #bitcoin-core-dev 02:01 < gmaxwell> Does anyone have an actual stock 0.16.x node (or older) running? 02:03 -!- gmaxwell [~procyonid@wikimedia/KatWalsh/x-0001] has left #bitcoin-core-dev [] 02:26 -!- arowser [~arowser1@67.230.166.11.16clouds.com] has quit [Ping timeout: 256 seconds] 02:33 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:dde1:f272:550e:1390] has quit [Remote host closed the connection] 02:34 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:dde1:f272:550e:1390] has joined #bitcoin-core-dev 02:38 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:dde1:f272:550e:1390] has quit [Ping timeout: 260 seconds] 02:55 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:5946:f02d:a1c6:a4c] has joined #bitcoin-core-dev 02:58 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev 03:09 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:5946:f02d:a1c6:a4c] has quit [Remote host closed the connection] 03:09 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:5946:f02d:a1c6:a4c] has joined #bitcoin-core-dev 03:13 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:5946:f02d:a1c6:a4c] has quit [Ping timeout: 240 seconds] 03:26 -!- MasterGruntR75 [~MasterGru@217.146.82.202] has joined #bitcoin-core-dev 03:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:46 < bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/61b8c04d78fb...7721b318099e 03:46 < bitcoin-git> bitcoin/master 819f10f João Barbosa: wallet, refactor: Immutable CWalletTx::pwallet 03:46 < bitcoin-git> bitcoin/master 772ea48 João Barbosa: wallet: Avoid recursive lock in IsTrusted 03:46 < bitcoin-git> bitcoin/master 7721b31 Samuel Dobson: Merge #19773: wallet: Avoid recursive lock in IsTrusted 03:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:46 < bitcoin-git> [bitcoin] meshcollider merged pull request #19773: wallet: Avoid recursive lock in IsTrusted (master...2020-08-wallet-istrusted) https://github.com/bitcoin/bitcoin/pull/19773 03:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:58 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 04:05 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 04:18 -!- Eloise61Lakin [~Eloise61L@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev 04:20 -!- jonatack [~jon@213.152.161.40] has quit [Ping timeout: 240 seconds] 04:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:32 < bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7721b318099e...f98872f1279e 04:32 < bitcoin-git> bitcoin/master 6d1f513 Sjors Provoost: [rpc] fundrawtransaction, walletcreatefundedpsbt lock manually selected co... 04:32 < bitcoin-git> bitcoin/master f98872f Samuel Dobson: Merge #18244: rpc: fundrawtransaction and walletcreatefundedpsbt also lock... 04:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:33 < bitcoin-git> [bitcoin] meshcollider merged pull request #18244: rpc: fundrawtransaction and walletcreatefundedpsbt also lock manually selected coins (master...2020/03/rpc_coin_locks) https://github.com/bitcoin/bitcoin/pull/18244 04:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:33 -!- Eloise61Lakin [~Eloise61L@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 246 seconds] 04:38 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection] 04:41 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev 04:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:47 < bitcoin-git> [bitcoin] fanquake opened pull request #19844: remove usage of boost::bind (master...sneak_boost_bind) https://github.com/bitcoin/bitcoin/pull/19844 04:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:48 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::1e7] has quit [Ping timeout: 240 seconds] 04:52 < hebasto> MarcoFalke: fanquake: mind labeling #19838 ? 04:52 < gribble> https://github.com/bitcoin/bitcoin/issues/19838 | Good first issue: Improve thread safety annotation coverage · Issue #19838 · bitcoin/bitcoin · GitHub 04:58 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:5946:f02d:a1c6:a4c] has joined #bitcoin-core-dev 05:00 -!- MasterGruntR75 [~MasterGru@217.146.82.202] has quit [] 05:02 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:5946:f02d:a1c6:a4c] has quit [Remote host closed the connection] 05:03 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::1e7] has joined #bitcoin-core-dev 05:03 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:5946:f02d:a1c6:a4c] has joined #bitcoin-core-dev 05:07 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:5946:f02d:a1c6:a4c] has quit [Ping timeout: 260 seconds] 05:09 -!- TallTim [~TallTim@216.15.20.214] has quit [Quit: Textual IRC Client: www.textualapp.com] 05:14 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev 05:22 -!- sauce1 [~sauce@77.243.177.38] has joined #bitcoin-core-dev 05:29 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev 05:33 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 05:33 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Ping timeout: 256 seconds] 05:38 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 05:46 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 06:04 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:2442:b50:b448:db4] has joined #bitcoin-core-dev 06:05 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection] 06:05 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev 06:06 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection] 06:06 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev 06:08 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:2442:b50:b448:db4] has quit [Ping timeout: 240 seconds] 06:09 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection] 06:09 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev 06:10 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection] 06:10 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev 06:11 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection] 06:11 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev 06:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:16 < bitcoin-git> [bitcoin] vasild opened pull request #19845: net: CNetAddr: add support to (un)serialize as ADDRv2 (master...ser_addrv2_cnetaddr) https://github.com/bitcoin/bitcoin/pull/19845 06:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:22 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 240 seconds] 06:23 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection] 06:23 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 06:24 < vasild> I added a new file, but travis complains that the file is missing: https://travis-ci.org/github/bitcoin/bitcoin/jobs/722729138#L3366. I have no idea what's going on. I ran this via my "private" travis and it complained the same. I sneaked a "find ./ ..." in travis scripts and the file is not present indeed. But the file is present when I do a fresh git clone locally. 06:24 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 06:25 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection] 06:25 < vasild> I also tried clearing travis casche on my travis instance (https://travis-ci.org/github/vasild/bitcoin) and it did not fix it 06:25 < vasild> cache 06:25 -!- greg200831 [4b4b238f@c-75-75-35-143.hsd1.va.comcast.net] has joined #bitcoin-core-dev 06:25 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev 06:29 < vasild> same error in cirrus: https://cirrus-ci.com/task/6273748426817536?command=ci#L2469 06:42 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Remote host closed the connection] 06:43 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 06:46 -!- andreacab [~andreacab@12.46.194.178.dynamic.wline.res.cust.swisscom.ch] has joined #bitcoin-core-dev 06:49 -!- andreacab [~andreacab@12.46.194.178.dynamic.wline.res.cust.swisscom.ch] has quit [Remote host closed the connection] 06:49 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:4ceb:6f4c:103f:e0c8] has joined #bitcoin-core-dev 06:50 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection] 06:51 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev 06:51 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection] 06:52 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev 06:52 < instagibbs> who is actively contributing that knows the fee estimation guts the best? 06:54 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:4ceb:6f4c:103f:e0c8] has quit [Ping timeout: 272 seconds] 06:57 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 07:00 < aj> instagibbs: got a particular question? 07:01 -!- palazzovincenzo [~vincent@host-87-16-117-58.retail.telecomitalia.it] has joined #bitcoin-core-dev 07:01 -!- palazzovincenzo [~vincent@host-87-16-117-58.retail.telecomitalia.it] has quit [Remote host closed the connection] 07:03 -!- vincenzopalazzo [~vincent@104.200.132.241] has quit [Ping timeout: 256 seconds] 07:04 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection] 07:04 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 07:05 < instagibbs> if a user manually set their min mempool feerate to X, the estimator shouldn't be attempting to give estimates below those rates, yes? Excluding previously generated historical data 07:06 < instagibbs> which should decay over time IIRC 07:09 < aj> not sure it couldn't get results slightly below that due to bucketing (couldn't make it bug that way when i tried, but didn't try that hard), otherwise i think so 07:16 < instagibbs> user was getting 10x "upcharges" between estimated fee calls and wallet calls, seemingly over weeks, was curious how that persisted 07:17 < instagibbs> due to them setting a higher min relay fee* 07:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:18 < bitcoin-git> [bitcoin] Zero-1729 opened pull request #19846: build: enable unused member function diagnostic (master...enable-unused-member-function-diagnostic) https://github.com/bitcoin/bitcoin/pull/19846 07:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:18 -!- tralfaz [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev 07:19 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Ping timeout: 240 seconds] 07:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:21 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/f98872f1279e...c1e0c2ad3b6c 07:21 < bitcoin-git> bitcoin/master bd897ce Hennadii Stepanov: scripted-diff: Move previous_release.py to test/get_previous_releases.py 07:21 < bitcoin-git> bitcoin/master 0374e82 Hennadii Stepanov: util: Hard code previous release tarball checksums 07:21 < bitcoin-git> bitcoin/master c1e0c2a MarcoFalke: Merge #19813: util, ci: Hard code previous release tarball checksums 07:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:21 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19813: util, ci: Hard code previous release tarball checksums (master...200826-gpg) https://github.com/bitcoin/bitcoin/pull/19813 07:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:24 < aj> instagibbs: probably takes a while for old data to go away; if it was getting the estimate from the long_decay estimator, could be ~100 days for the old data to stop being worth considering? 07:26 < aj> instagibbs: maybe two weeks for medium estimator 07:27 < aj> instagibbs: (or maybe my maths is wrong; suhas/morcos/jnewbery might have a better idea) 07:28 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection] 07:31 < hebasto> aj: mind looking into #19668 ? 07:31 < instagibbs> aj, right i only know roughly when it'll give estimates, not when it stops 07:32 < instagibbs> users probably should be taking max(estimatesmartfee, minrelay) when doing their calculations but that's a bit unexpected 07:37 -!- Netsplit *.net <-> *.split quits: isis, hadjiszs_, DougieBot5000, waxwing, wraithm 07:37 -!- hadjiszs [~yourname@ns348042.ip-5-39-92.eu] has joined #bitcoin-core-dev 07:37 -!- waxwing [~waxwing@193.29.57.116] has joined #bitcoin-core-dev 07:37 -!- Netsplit over, joins: isis 07:38 -!- Netsplit over, joins: DougieBot5000 07:38 < aj> instagibbs: probably the fee estimator should be ignoring anything below minrelayfee, since that's guaranteed to be unusable and baded on old data at best? 07:39 -!- Netsplit over, joins: wraithm 07:40 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 07:43 < luke-jr> aj: or new data 07:43 < luke-jr> aj: or perhaps your minrelayfee just isn't what others are using 07:43 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev 07:45 < aj> luke-jr: the fee estimator won't see any transactions below your min relay fee, whatever others are using 07:46 < luke-jr> hm, true 07:46 < instagibbs> https://github.com/bitcoin/bitcoin/issues/19699 associated issue 07:48 < instagibbs> (in case anyone wants to take that on) 07:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:50 < bitcoin-git> [bitcoin] promag opened pull request #19847: test: gettxoutproof duplicate txid (master...2020-08-gettxoutproof) https://github.com/bitcoin/bitcoin/pull/19847 07:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:50 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #19848: Remove mempool global from interfaces (master...2008-nomemint) https://github.com/bitcoin/bitcoin/pull/19848 07:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:54 -!- andreacab [~andreacab@12.46.194.178.dynamic.wline.res.cust.swisscom.ch] has joined #bitcoin-core-dev 07:59 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Remote host closed the connection] 07:59 -!- andreacab [~andreacab@12.46.194.178.dynamic.wline.res.cust.swisscom.ch] has quit [Remote host closed the connection] 07:59 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6c0d:54:6ff0:3d6e] has joined #bitcoin-core-dev 08:00 -!- sauce1 [~sauce@77.243.177.38] has quit [] 08:00 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6c0d:54:6ff0:3d6e] has quit [Remote host closed the connection] 08:00 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6c0d:54:6ff0:3d6e] has joined #bitcoin-core-dev 08:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:04 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c1e0c2ad3b6c...068bc211881c 08:04 < bitcoin-git> bitcoin/master a104cae Aaron Clauson: Update the vcpkg checkout commit ID in appveyor config. 08:04 < bitcoin-git> bitcoin/master 068bc21 MarcoFalke: Merge #19842: Update the vcpkg checkout commit ID in appveyor config 08:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:05 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19842: Update the vcpkg checkout commit ID in appveyor config (master...appveyor-vcpkg-update) https://github.com/bitcoin/bitcoin/pull/19842 08:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:07 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection] 08:08 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev 08:08 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 08:18 -!- greg200831 [4b4b238f@c-75-75-35-143.hsd1.va.comcast.net] has quit [Ping timeout: 245 seconds] 08:21 -!- udsbotu [~udsbotu@178.162.204.214] has joined #bitcoin-core-dev 08:22 -!- tralfaz is now known as Davterra 08:25 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 08:30 -!- waxwing [~waxwing@193.29.57.116] has quit [Changing host] 08:30 -!- waxwing [~waxwing@unaffiliated/waxwing] has joined #bitcoin-core-dev 08:35 < sdaftuar> gleb: i've modified the sync-tips-with-feelers idea some, i have two approaches that i implemented 08:35 < sdaftuar> gleb: one problem i saw with the sync-tips-with-feelers idea was that feelers are chosen from the new table exclusively, in order to move things to the tried table 08:36 < sdaftuar> for ensuring that your tip isn't behind, i think you want to try peers in general, including from the tried table 08:37 < sdaftuar> so my first approach was to create a new kind of connection -- i think i called it "chain-sync" in my code, though maybe not a great name -- that is similar to feelers (in that we try every few minutes, on average, and when successfully connected to one we stay connected for about a minute to give headers-sync a chance to happen, and then we always disconnect 08:39 < sdaftuar> my alternate approach is a bit different: rather than create a new peer-type, just make a new block-relay-only connection (like feelers, try this once every few minutes), and again give the peer a chance to sync tips by waiting about a minute so that headers sync can occur 08:40 < sdaftuar> then, in choosing which block-relay peer to evict, evict either the new connection if it didn't teach you any new blocks, OR if it did, evict your next youngest block-relay peer 08:40 < sdaftuar> so this ends up being a block-relay-peer rotation algorithm, in the event that you're learning things from these connections 08:40 -!- Deinogalerix21 [~Deinogale@195.140.213.242] has joined #bitcoin-core-dev 08:41 < sdaftuar> (credit to gmaxwell for suggesting that second approach btw) 08:43 < sdaftuar> i think the second approach is probably better, because it lets us actually escape a scenario where we've been partitioned off the honest network 08:43 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection] 08:43 < sdaftuar> the main concern i had was whether we might skew the network graph as a whole to encourage block-relay connections to the fastest (eg mining) nodes, which will be more likely at random to occasionally give us a new block first even when we're not under attack 08:44 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev 08:44 < sdaftuar> but i've been running that patch for a couple weeks now and haven't yet triggered a scenario where i've evicted an older block-relay peer, so this might be fine 08:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:46 < bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/068bc211881c...89a8299a14af 08:46 < bitcoin-git> bitcoin/master fa93bc1 MarcoFalke: rpc: Remove unused return type from appendCommand 08:46 < bitcoin-git> bitcoin/master faaa46d MarcoFalke: rpc: Assert that RPCArg names are equal to CRPCCommand ones (mining) 08:46 < bitcoin-git> bitcoin/master fa32c1d MarcoFalke: rpc: Assert that RPCArg names are equal to CRPCCommand ones (zmq) 08:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:47 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19717: rpc: Assert that RPCArg names are equal to CRPCCommand ones (mining,zmq,rpcdump) (master...2008-rpcMisc) https://github.com/bitcoin/bitcoin/pull/19717 08:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:47 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection] 08:47 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev 09:01 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::1e7] has quit [Ping timeout: 260 seconds] 09:05 -!- tralfaz [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev 09:06 -!- Davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection] 09:08 -!- Deinogalerix21 [~Deinogale@195.140.213.242] has quit [Quit: WeeChat 2.9] 09:19 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 09:20 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::1e7] has joined #bitcoin-core-dev 09:25 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:6c0d:54:6ff0:3d6e] has quit [Remote host closed the connection] 09:26 -!- andreacab [~andreacab@37.120.205.83] has joined #bitcoin-core-dev 09:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:32 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #19849: Assert that RPCArg names are equal to CRPCCommand ones (blockchain,rawtransaction) (master...2008-rpcAssertNames) https://github.com/bitcoin/bitcoin/pull/19849 09:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:32 < hebasto> aj: thanks for your attention! 09:36 -!- andreacab [~andreacab@37.120.205.83] has quit [Remote host closed the connection] 09:37 -!- andreacab [~andreacab@37.120.205.83] has joined #bitcoin-core-dev 09:41 -!- andreacab [~andreacab@37.120.205.83] has quit [Ping timeout: 258 seconds] 09:50 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has joined #bitcoin-core-dev 09:54 -!- andreacab [~andreacab@37.120.205.83] has joined #bitcoin-core-dev 09:55 -!- andreaca_ [~andreacab@37.120.205.83] has joined #bitcoin-core-dev 09:59 -!- andreacab [~andreacab@37.120.205.83] has quit [Ping timeout: 240 seconds] 09:59 -!- TallTim [~TallTim@216.15.20.214] has joined #bitcoin-core-dev 10:00 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection] 10:00 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev 10:09 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection] 10:12 -!- tralfaz [~davterra@gateway/tor-sasl/tralfaz] has quit [Ping timeout: 240 seconds] 10:22 -!- watersnake1 [~christian@24.61.159.12] has joined #bitcoin-core-dev 10:24 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 10:29 < pinheadmz> does the bitcoind wallet ever spend coins that are `untrusted_pending` ? 10:35 -!- andreaca_ [~andreacab@37.120.205.83] has quit [Remote host closed the connection] 10:36 -!- andreacab [~andreacab@37.120.205.83] has joined #bitcoin-core-dev 10:37 -!- andreacab [~andreacab@37.120.205.83] has quit [Read error: No route to host] 10:37 -!- andreaca_ [~andreacab@37.120.205.83] has joined #bitcoin-core-dev 10:42 -!- andreaca_ [~andreacab@37.120.205.83] has quit [Ping timeout: 260 seconds] 10:49 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::1e7] has quit [Ping timeout: 272 seconds] 10:50 < achow101> pinheadmz: no 10:53 -!- _FUNK_ [bd6614e8@189.102.20.232] has joined #bitcoin-core-dev 10:55 -!- _FUNK_ [bd6614e8@189.102.20.232] has quit [Remote host closed the connection] 11:00 -!- udsbotu [~udsbotu@178.162.204.214] has quit [] 11:07 -!- andreacab [~andreacab@37.120.205.83] has joined #bitcoin-core-dev 11:08 -!- andreaca_ [~andreacab@37.120.205.83] has joined #bitcoin-core-dev 11:11 -!- andreacab [~andreacab@37.120.205.83] has quit [Ping timeout: 256 seconds] 11:22 -!- fimp [~fimp@184.75.221.3] has joined #bitcoin-core-dev 11:26 -!- shesek [~shesek@164.90.217.137] has joined #bitcoin-core-dev 11:26 -!- shesek [~shesek@164.90.217.137] has quit [Changing host] 11:26 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 11:26 -!- vincenzopalazzo [~vincent@host-87-16-117-58.retail.telecomitalia.it] has joined #bitcoin-core-dev 11:29 -!- andreaca_ [~andreacab@37.120.205.83] has quit [Remote host closed the connection] 11:30 -!- andreacab [~andreacab@37.120.205.83] has joined #bitcoin-core-dev 11:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:32 < bitcoin-git> [bitcoin] promag opened pull request #19851: refactor: Extract ParseOpCode from ParseScript (master...2020-08-parseopcode) https://github.com/bitcoin/bitcoin/pull/19851 11:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:35 -!- andreacab [~andreacab@37.120.205.83] has quit [Ping timeout: 265 seconds] 11:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:47 < bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/89a8299a14af...e796fdd4cb8e 11:47 < bitcoin-git> bitcoin/master e70512a Gregory Sanders: Make ordering of zmq consumption irrelevant to functional test 11:47 < bitcoin-git> bitcoin/master 2399a06 Gregory Sanders: Add test case for mempool->block zmq notification 11:47 < bitcoin-git> bitcoin/master a0f4f9c Gregory Sanders: Add zmq test for transaction pub during reorg 11:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:47 < bitcoin-git> [bitcoin] laanwj merged pull request #19507: Expand functional zmq transaction tests (master...zmq_testing) https://github.com/bitcoin/bitcoin/pull/19507 11:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:52 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Read error: Connection reset by peer] 11:57 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 11:58 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 256 seconds] 11:58 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 12:01 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 12:02 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev 12:02 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 12:03 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 12:03 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 12:04 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 12:05 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 12:05 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Remote host closed the connection] 12:06 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 12:07 < vasild> sipa: MakeUCharSpan() produces a different checksum, I guess because it includes the terminating \0 12:07 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 12:09 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::1e7] has joined #bitcoin-core-dev 12:09 < sipa> vasild: oh, indeed 12:09 < vasild> no need to check? 12:10 < sipa> MakeUCharSpan(str).first(15) would work, but is a bit less nice 12:11 < vasild> I added -1 somewhere there in the MakeSpanWhatever(~!@) code but it did not compile, anyway the terminating \0 _must_ be the reason :) 12:11 < sipa> or you can write: static constexpr unsigned char ONION_PREFIX[15] = "..."; hasher.Write(ONION_PREFIX); 12:11 < vasild> let me try first(15)... 12:12 -!- fimp [~fimp@184.75.221.3] has quit [Ping timeout: 264 seconds] 12:17 < vasild> "error: initializer-string for char array is too long" 12:18 < vasild> .first(15) compiles and produces the correct result, and is better than the reinterpret_cast 12:20 < vasild> another possibility: static constexpr unsigned char ONION_PREFIX[15]{'.', 'o', 'n', 'i', 'o', 'n', ' ', 'c', 'h', 'e', 'c', 'k', 's', 'u', 'm'}; 12:20 < vasild> ;-) 12:25 < sipa> ugh :) 12:25 < sipa> i guess that works, and doesn't even need the 15 12:29 -!- Guest56885 [~Lestaty@185.163.110.125] has joined #bitcoin-core-dev 12:32 < vasild> I rebased the code on top of #19841 and removed the sha3-256 I imported 12:32 < gribble> https://github.com/bitcoin/bitcoin/issues/19841 | Implement Keccak and SHA3_256 by sipa · Pull Request #19841 · bitcoin/bitcoin · GitHub 12:57 -!- andreacab [~andreacab@37.120.205.83] has joined #bitcoin-core-dev 12:58 -!- andreaca_ [~andreacab@37.120.205.83] has joined #bitcoin-core-dev 13:02 -!- andreacab [~andreacab@37.120.205.83] has quit [Ping timeout: 258 seconds] 13:03 -!- andreaca_ [~andreacab@37.120.205.83] has quit [Ping timeout: 258 seconds] 13:32 -!- andreaca_ [~andreacab@37.120.205.83] has joined #bitcoin-core-dev 13:36 -!- andreaca_ [~andreacab@37.120.205.83] has quit [Ping timeout: 240 seconds] 13:41 < fjahr> Has anyone investigated/reported the latest annoying Travis Arm64 failures? Examples: https://travis-ci.org/github/bitcoin/bitcoin/builds/722800233 https://travis-ci.org/github/bitcoin/bitcoin/builds/721669033 https://travis-ci.org/github/bitcoin/bitcoin/builds/721637124. Errors after ~ 1h 15min without any failure message I could find. Restarts seemed to solve it but I have restarted #19055 at least 5 times 13:41 < fjahr> now. I see other complaints from the past that Arm64 has been slow but at least they have seen some error messages. 13:41 < gribble> https://github.com/bitcoin/bitcoin/issues/19055 | Add MuHash3072 implementation by fjahr · Pull Request #19055 · bitcoin/bitcoin · GitHub 13:46 < sdaftuar> fjahr: i have notied that as well but don't know what to do about it 13:47 < sdaftuar> it had failed on one of my PRs, but restarting fixed it. i just restarted that same job on #19724 for the second time, trying to get a passing run 13:48 < gribble> https://github.com/bitcoin/bitcoin/issues/19724 | [net] Cleanup connection types- followups by amitiuttarwar · Pull Request #19724 · bitcoin/bitcoin · GitHub 13:49 < sdaftuar> if it is failing on a widespread basis we should probably remove the job until we come up with a way for it to be more robust. 13:58 < fjahr> sdaftuar: thanks, I agree. Not sure how widespread the persistent failures are though. I made a report on the community page but I don't have high hopes something is going to come out of it in the short term: https://travis-ci.community/t/arm64-failing-without-message/9775 14:00 -!- Guest56885 [~Lestaty@185.163.110.125] has quit [] 14:02 < sdaftuar> thanks for trying that! 14:22 -!- variable [~variable@84.39.117.57] has joined #bitcoin-core-dev 14:23 -!- variable is now known as Guest46143 14:25 -!- ctrlbreak [~ctrlbreak@159.2.182.106] has quit [Read error: Connection reset by peer] 14:26 -!- ctrlbreak [~ctrlbreak@159.2.182.106] has joined #bitcoin-core-dev 14:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:32 < bitcoin-git> [bitcoin] promag opened pull request #19852: refactor: Avoid duplicate map lookup in ScriptToAsmStr (master...2020-08-scripttoasmstr) https://github.com/bitcoin/bitcoin/pull/19852 14:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:48 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 14:59 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 15:06 -!- andreacab [~andreacab@37.120.205.83] has joined #bitcoin-core-dev 15:07 -!- andreaca_ [~andreacab@37.120.205.83] has joined #bitcoin-core-dev 15:11 -!- andreacab [~andreacab@37.120.205.83] has quit [Ping timeout: 264 seconds] 15:11 -!- andreaca_ [~andreacab@37.120.205.83] has quit [Ping timeout: 240 seconds] 15:16 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 256 seconds] 15:23 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 15:30 -!- opsec_x12 [~opsec_x12@44-25-143-49.ip.hamwan.net] has quit [Read error: Connection reset by peer] 15:31 -!- opsec_x12 [~opsec_x12@44-25-143-49.ip.hamwan.net] has joined #bitcoin-core-dev 15:51 -!- krusk8 [5d24c45b@93-36-196-91.ip61.fastwebnet.it] has joined #bitcoin-core-dev 15:52 -!- krusk8 [5d24c45b@93-36-196-91.ip61.fastwebnet.it] has quit [Remote host closed the connection] 15:56 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::1e7] has quit [Ping timeout: 240 seconds] 15:57 -!- gmaxwell [~procyonid@wikimedia/KatWalsh/x-0001] has joined #bitcoin-core-dev 15:58 < gmaxwell> https://github.com/bitcoin-core/secp256k1/pull/558 looks ready-ish to merge, so if anyone wanted to review ack this updated version that reflects the latest BIP340 changes (even R), it's time! 15:58 -!- gmaxwell [~procyonid@wikimedia/KatWalsh/x-0001] has left #bitcoin-core-dev [] 15:59 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 16:00 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 16:12 -!- vincenzopalazzo [~vincent@host-87-16-117-58.retail.telecomitalia.it] has quit [Quit: Leaving] 16:13 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection] 16:13 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 16:37 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::1e7] has joined #bitcoin-core-dev 16:43 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection] 16:43 -!- andreaca_ [~andreacab@37.120.205.83] has joined #bitcoin-core-dev 16:46 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection] 16:46 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev 16:47 -!- andreaca_ [~andreacab@37.120.205.83] has quit [Ping timeout: 240 seconds] 16:54 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev 16:58 -!- melande11 [~melande@gateway/tor-sasl/melande] has quit [Ping timeout: 240 seconds] 17:00 -!- Guest46143 [~variable@84.39.117.57] has quit [] 17:17 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 17:17 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 17:22 -!- slidercrank1 [~slidercra@89.47.234.28] has joined #bitcoin-core-dev 17:22 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 240 seconds] 17:34 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev 17:57 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 17:58 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 18:02 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 18:02 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 18:03 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 265 seconds] 18:12 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 18:13 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 258 seconds] 18:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:27 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e796fdd4cb8e...a1d14f522c45 18:27 < bitcoin-git> bitcoin/master 3340dba Andrew Chow: Remove -zapwallettxes 18:27 < bitcoin-git> bitcoin/master a1d14f5 fanquake: Merge #19671: wallet: Remove -zapwallettxes 18:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:27 < bitcoin-git> [bitcoin] fanquake merged pull request #19671: wallet: Remove -zapwallettxes (master...rm-zapwallettxes) https://github.com/bitcoin/bitcoin/pull/19671 18:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:29 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 18:31 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection] 18:31 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 18:35 -!- kotare [~kotare@114.23.246.137] has joined #bitcoin-core-dev 18:35 -!- kotare [~kotare@114.23.246.137] has quit [Client Quit] 18:43 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Ping timeout: 258 seconds] 18:45 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection] 18:45 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev 19:01 -!- andreacab [~andreacab@37.120.205.83] has joined #bitcoin-core-dev 19:01 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 19:02 -!- andreaca_ [~andreacab@37.120.205.83] has joined #bitcoin-core-dev 19:02 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 19:05 -!- andreacab [~andreacab@37.120.205.83] has quit [Ping timeout: 240 seconds] 19:06 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 240 seconds] 19:06 -!- andreaca_ [~andreacab@37.120.205.83] has quit [Remote host closed the connection] 19:22 < achow101> is there a way to do uint256 set hex without the byte reversing thing? 19:24 < sipa> ParseHex + std::copy ? 19:27 < achow101> ah, ther's a non-const begin() 19:33 -!- mrostecki_ [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev 19:35 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Ping timeout: 240 seconds] 19:37 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection] 19:37 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev 19:47 -!- andreaca_ [~andreacab@37.120.205.83] has joined #bitcoin-core-dev 19:51 -!- andreaca_ [~andreacab@37.120.205.83] has quit [Ping timeout: 240 seconds] 19:58 -!- marcoagner [~user@2001:8a0:6a45:1900:2fd7:e0f0:d356:dd70] has quit [Ping timeout: 240 seconds] 20:00 -!- slidercrank1 [~slidercra@89.47.234.28] has quit [] 20:24 -!- andreaca_ [~andreacab@37.120.205.83] has joined #bitcoin-core-dev 20:28 -!- andreaca_ [~andreacab@37.120.205.83] has quit [Ping timeout: 240 seconds] 20:56 -!- DJWillis [~DJWillis@s91904426.blix.com] has joined #bitcoin-core-dev 20:59 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 21:02 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 21:06 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 240 seconds] 21:16 -!- opsec_x12 [~opsec_x12@44-25-143-49.ip.hamwan.net] has quit [Read error: Connection reset by peer] 21:16 -!- opsec_x12 [~opsec_x12@44-25-143-49.ip.hamwan.net] has joined #bitcoin-core-dev 21:19 -!- earlz [~earlz@earlz.net] has quit [Ping timeout: 260 seconds] 21:20 -!- earlz [~earlz@earlz.net] has joined #bitcoin-core-dev 21:33 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 21:41 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::1e7] has quit [Ping timeout: 272 seconds] 22:04 -!- watersnake1 [~christian@24.61.159.12] has quit [Quit: Leaving.] 22:11 -!- IGHOR [~quassel@176.121.4.135] has quit [Quit: http://quassel-irc.org ? ??????????? ?????????. ????-??.] 22:13 -!- IGHOR [~quassel@176.121.4.135] has joined #bitcoin-core-dev 22:17 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection] 22:17 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev 22:28 -!- andreaca_ [~andreacab@37.120.205.83] has joined #bitcoin-core-dev 22:33 -!- andreaca_ [~andreacab@37.120.205.83] has quit [Ping timeout: 258 seconds] 22:37 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection] 22:37 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev 22:54 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 22:58 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection] 22:58 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev 23:00 -!- DJWillis [~DJWillis@s91904426.blix.com] has quit [] 23:03 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 23:07 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 240 seconds] 23:07 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 256 seconds] 23:10 -!- wullon587 [~wullon@241.243.86.88.rdns.comcable.net] has joined #bitcoin-core-dev 23:10 -!- wullon58 [~wullon@241.243.86.88.rdns.comcable.net] has quit [Read error: Connection reset by peer] 23:20 -!- dleffler1 [~dleffler@45.133.193.50] has joined #bitcoin-core-dev 23:28 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 23:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:28 < bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/a1d14f522c45...bab4cce1b0ee 23:28 < bitcoin-git> bitcoin/master af9ea55 Hennadii Stepanov: Use LockAssertion utility class instead of AssertLockHeld() 23:28 < bitcoin-git> bitcoin/master 3ddc150 Hennadii Stepanov: Add missed thread safety annotations 23:28 < bitcoin-git> bitcoin/master 23d71d1 Hennadii Stepanov: Do not hide compile-time thread safety warnings 23:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:29 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19668: Do not hide compile-time thread safety warnings (master...200805-assert) https://github.com/bitcoin/bitcoin/pull/19668 23:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 23:32 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has quit [Remote host closed the connection] 23:32 -!- arowser [~arowser1@192.69.88.248.16clouds.com] has joined #bitcoin-core-dev 23:58 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::1e7] has joined #bitcoin-core-dev --- Log closed Tue Sep 01 00:00:05 2020