--- Log opened Mon Sep 07 00:00:13 2020 00:03 -!- bosch [74cee564@116.206.229.100] has quit [Remote host closed the connection] 00:10 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 00:10 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 00:11 < vasild> sipa: https://github.com/bitcoin/bitcoin/pull/19728#pullrequestreview-469679233 "Why not treat all addresses equally (ie relay always to 2 nodes, even addresses from unreachable networks)?" 00:14 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 00:14 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 00:15 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:f8df:6cfc:b364:e801] has quit [Remote host closed the connection] 00:17 < sipa> vasild: maybe that's what will be needed, but i'd like to retain the existing behavior of primarily relaying reachable addresses 00:18 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:f8df:6cfc:b364:e801] has joined #bitcoin-core-dev 00:18 < sipa> so that ipv6 nodes find eachother preferentially etc 00:18 < vasild> ack 00:23 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:f8df:6cfc:b364:e801] has quit [Ping timeout: 272 seconds] 00:27 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 00:27 -!- marcoagner [~user@2001:8a0:6a45:1900:2fd7:e0f0:d356:dd70] has joined #bitcoin-core-dev 00:29 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 260 seconds] 00:30 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 00:31 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 256 seconds] 00:33 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:f8df:6cfc:b364:e801] has joined #bitcoin-core-dev 00:48 -!- kljasdfvv [~flack@p200300d46f11fb0024ae13d268da7ad8.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 00:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:52 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/78cb45d72251...07087051afe9 00:52 < bitcoin-git> bitcoin/master eeee110 MarcoFalke: Remove mempool global from init 00:52 < bitcoin-git> bitcoin/master fa0359c MarcoFalke: Remove mempool global from p2p 00:52 < bitcoin-git> bitcoin/master fafb381 MarcoFalke: Remove mempool global 00:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:52 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19556: Remove mempool global (master...Mf1808-txpoolGlobal) https://github.com/bitcoin/bitcoin/pull/19556 00:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:03 -!- promag [~promag@188.251.225.32] has joined #bitcoin-core-dev 01:04 -!- promag [~promag@188.251.225.32] has quit [Remote host closed the connection] 01:05 -!- promag [~promag@188.251.225.32] has joined #bitcoin-core-dev 01:20 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:f8df:6cfc:b364:e801] has quit [Remote host closed the connection] 01:21 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:f8df:6cfc:b364:e801] has joined #bitcoin-core-dev 01:24 -!- promag [~promag@188.251.225.32] has quit [Remote host closed the connection] 01:24 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:f8df:6cfc:b364:e801] has quit [Remote host closed the connection] 01:24 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:f8df:6cfc:b364:e801] has joined #bitcoin-core-dev 01:24 -!- promag [~promag@188.251.225.32] has joined #bitcoin-core-dev 01:26 -!- promag [~promag@188.251.225.32] has quit [Remote host closed the connection] 01:29 -!- promag [~promag@188.251.225.32] has joined #bitcoin-core-dev 01:32 -!- promag [~promag@188.251.225.32] has quit [Remote host closed the connection] 01:36 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 01:36 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 01:52 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 260 seconds] 02:00 -!- Hellaenergy [~Hellaener@77.243.177.38] has quit [] 02:00 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-xpbpbluppghmyxfi] has quit [Quit: Idle for 30+ days] 02:00 -!- mekster [~mekster@139.180.192.79] has quit [Quit: mekster] 02:06 -!- palazzovincenzo [~vincent@host-79-35-119-77.retail.telecomitalia.it] has joined #bitcoin-core-dev 02:07 -!- palazzovincenzo [~vincent@host-79-35-119-77.retail.telecomitalia.it] has quit [Client Quit] 02:08 -!- vincenzopalazzo [~vincent@host-79-23-116-18.retail.telecomitalia.it] has quit [Ping timeout: 240 seconds] 02:14 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:f8df:6cfc:b364:e801] has quit [Remote host closed the connection] 02:21 -!- tlyu [~tlyu@77.243.177.38] has joined #bitcoin-core-dev 02:22 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 265 seconds] 02:36 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 246 seconds] 02:38 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev 02:40 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev 02:42 -!- promag [~promag@188.251.225.32] has joined #bitcoin-core-dev 02:50 -!- mekster [~mekster@139.180.192.79] has joined #bitcoin-core-dev 02:52 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 265 seconds] 02:52 -!- promag [~promag@188.251.225.32] has quit [Remote host closed the connection] 02:56 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev 02:57 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:f8df:6cfc:b364:e801] has joined #bitcoin-core-dev 03:00 -!- promag [~promag@188.251.225.32] has joined #bitcoin-core-dev 03:01 < jnewbery> Great stuff Marco. Really good to see progress being made there. Thanks for getting it done. 03:01 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:f8df:6cfc:b364:e801] has quit [Ping timeout: 246 seconds] 03:02 -!- promag [~promag@188.251.225.32] has quit [Remote host closed the connection] 03:08 -!- promag [~promag@188.251.225.32] has joined #bitcoin-core-dev 03:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:10 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/07087051afe9...25839661305e 03:10 < bitcoin-git> bitcoin/master 46d955d Jeremy Rubin: Remove mapLinks in favor of entry inlined structs with iterator type erasu... 03:10 < bitcoin-git> bitcoin/master 296be8f Jeremy Rubin: Get rid of unused functions CTxMemPool::GetMemPoolChildren, CTxMemPool::Ge... 03:10 < bitcoin-git> bitcoin/master 2583966 MarcoFalke: Merge #19478: Remove CTxMempool::mapLinks data structure member 03:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:10 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19478: Remove CTxMempool::mapLinks data structure member (master...epoch-mempool-clean-split-3) https://github.com/bitcoin/bitcoin/pull/19478 03:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:16 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:dd57:ea89:2792:e80a] has joined #bitcoin-core-dev 03:18 -!- Keely73Feil [~Keely73Fe@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev 03:22 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:dd57:ea89:2792:e80a] has quit [Remote host closed the connection] 03:23 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:dd57:ea89:2792:e80a] has joined #bitcoin-core-dev 03:23 -!- jonatack [~jon@37.171.223.85] has joined #bitcoin-core-dev 03:27 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:dd57:ea89:2792:e80a] has quit [Ping timeout: 260 seconds] 03:31 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:423:c09e:890b:b364] has joined #bitcoin-core-dev 03:38 -!- promag [~promag@188.251.225.32] has quit [Remote host closed the connection] 03:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:42 < bitcoin-git> [bitcoin] naumenkogs opened pull request #19906: Bugfix: don't make collision from "tried" a feeler (master...2020-09-feeler-no-collisions) https://github.com/bitcoin/bitcoin/pull/19906 03:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:43 -!- promag [~promag@188.251.225.32] has joined #bitcoin-core-dev 03:56 -!- promag [~promag@188.251.225.32] has quit [Remote host closed the connection] 03:56 -!- worc3131 [~quassel@2a02:c7f:c026:9500:7d0b:65d0:38a4:4786] has joined #bitcoin-core-dev 03:59 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 04:03 -!- promag [~promag@188.251.225.32] has joined #bitcoin-core-dev 04:05 -!- promag [~promag@188.251.225.32] has quit [Remote host closed the connection] 04:06 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 04:11 -!- promag [~promag@188.251.225.32] has joined #bitcoin-core-dev 04:16 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:423:c09e:890b:b364] has quit [Remote host closed the connection] 04:16 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:423:c09e:890b:b364] has joined #bitcoin-core-dev 04:18 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 04:18 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 04:21 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:423:c09e:890b:b364] has quit [Ping timeout: 244 seconds] 04:26 -!- gzhao408 [uid453516@gateway/web/irccloud.com/x-srruwobpjzhulrgk] has joined #bitcoin-core-dev 04:28 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:8496:762a:539c:1d6] has joined #bitcoin-core-dev 04:31 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:8496:762a:539c:1d6] has quit [Remote host closed the connection] 04:32 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:8496:762a:539c:1d6] has joined #bitcoin-core-dev 04:33 -!- andreaca_ [~andreacab@2a02:120b:2c22:e0c0:5d3d:43a8:548a:e1ff] has joined #bitcoin-core-dev 04:36 -!- andreaca_ [~andreacab@2a02:120b:2c22:e0c0:5d3d:43a8:548a:e1ff] has quit [Remote host closed the connection] 04:36 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:8496:762a:539c:1d6] has quit [Ping timeout: 244 seconds] 04:37 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:5d3d:43a8:548a:e1ff] has joined #bitcoin-core-dev 04:41 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:5d3d:43a8:548a:e1ff] has quit [Ping timeout: 244 seconds] 04:42 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Ping timeout: 240 seconds] 04:49 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 04:53 -!- promag [~promag@188.251.225.32] has quit [Remote host closed the connection] 04:56 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 05:00 -!- tlyu [~tlyu@77.243.177.38] has quit [] 05:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:17 < bitcoin-git> [bitcoin] dr-orlovsky opened pull request #19907: util: add psbt combiner role (master...feat/psbt-combiner) https://github.com/bitcoin/bitcoin/pull/19907 05:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:20 -!- I440r [~I440r@178.162.204.214] has joined #bitcoin-core-dev 05:25 -!- Keely73Feil [~Keely73Fe@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 256 seconds] 05:33 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev 05:37 -!- jonatack [~jon@37.171.223.85] has quit [Read error: Connection reset by peer] 05:39 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 05:57 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 05:58 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 05:58 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 05:58 < yanmaani> achow101: If that's the case then maybe you could do it like: have a bdb database, open it, move all the stuff into a sqlite database 05:59 < yanmaani> on a clean shutdown, copy the data back into bdb, sync, exit 05:59 < yanmaani> (and remove sqlite) 05:59 < yanmaani> on a dirty shutdown, sqlite will still persist 06:01 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 260 seconds] 06:04 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 06:04 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 06:05 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 06:05 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 06:05 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Ping timeout: 265 seconds] 06:06 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 06:06 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 06:09 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 06:09 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 06:10 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 06:10 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 06:11 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 06:11 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 06:13 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 06:13 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 06:14 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 06:14 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 06:16 -!- bzb [~bzb@214.ip-51-79-55.net] has joined #bitcoin-core-dev 06:22 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 258 seconds] 06:26 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 260 seconds] 06:26 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev 06:28 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev 06:32 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Ping timeout: 256 seconds] 06:36 -!- Fitti [5fde19ce@aftr-95-222-25-206.unity-media.net] has joined #bitcoin-core-dev 06:39 -!- Fitti [5fde19ce@aftr-95-222-25-206.unity-media.net] has quit [Remote host closed the connection] 06:58 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 06:58 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 07:00 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 07:14 -!- bzb [~bzb@214.ip-51-79-55.net] has quit [Quit: Leaving] 07:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 07:18 -!- tralfaz [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev 07:19 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Ping timeout: 240 seconds] 07:28 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 07:28 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 07:29 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 07:30 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 07:30 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 07:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:46 < bitcoin-git> [bitcoin] naumenkogs closed pull request #19906: Bugfix: don't make collision from "tried" a feeler (master...2020-09-feeler-no-collisions) https://github.com/bitcoin/bitcoin/pull/19906 07:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:46 < bitcoin-git> [bitcoin] naumenkogs reopened pull request #19906: Bugfix: don't make collision from "tried" a feeler (master...2020-09-feeler-no-collisions) https://github.com/bitcoin/bitcoin/pull/19906 07:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:48 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #19909: txmempool: Remove unused clear() member function (master...2009-noTxpoolClear) https://github.com/bitcoin/bitcoin/pull/19909 07:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:55 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 07:58 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev 07:59 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 08:00 -!- I440r [~I440r@178.162.204.214] has quit [] 08:01 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Remote host closed the connection] 08:01 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev 08:03 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Remote host closed the connection] 08:04 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 264 seconds] 08:08 -!- shesek [~shesek@164.90.217.137] has joined #bitcoin-core-dev 08:08 -!- shesek [~shesek@164.90.217.137] has quit [Changing host] 08:08 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 08:10 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev 08:24 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 08:24 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 08:25 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev 08:26 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 08:28 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 08:28 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 08:29 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...] 08:40 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 08:49 < achow101> yanmaani: copying everything back into bdb is way harder than just reading data from it 08:49 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:3d57:2b99:a5bc:4839] has joined #bitcoin-core-dev 08:51 -!- grubles [~unknown@unaffiliated/grubles] has joined #bitcoin-core-dev 08:52 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev 08:56 -!- sankarshan1 [~sankarsha@195.206.169.184] has joined #bitcoin-core-dev 09:00 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:3d57:2b99:a5bc:4839] has quit [Remote host closed the connection] 09:06 -!- tralfaz is now known as Davterra 09:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:12 < bitcoin-git> [bitcoin] MarcoFalke pushed 11 commits to master: https://github.com/bitcoin/bitcoin/compare/25839661305e...147d50d63e07 09:12 < bitcoin-git> bitcoin/master 824bbd1 John Newbery: [move only] Collect all private members of PeerLogicValidation together 09:12 < bitcoin-git> bitcoin/master 2297b26 John Newbery: [net_processing] Pass chainparams to PeerLogicValidation constructor 09:12 < bitcoin-git> bitcoin/master 58bd369 John Newbery: scripted-diff: [net processing] Rename PeerLogicValidation to PeerManager 09:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:12 -!- Talkless [~Talkless@hst-227-49.splius.lt] has joined #bitcoin-core-dev 09:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:12 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19791: [net processing] Move Misbehaving() to PeerManager (master...2020-08-misbehaving-in-plv) https://github.com/bitcoin/bitcoin/pull/19791 09:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:13 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 265 seconds] 09:21 -!- mrostecki_ [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev 09:21 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 09:23 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 09:23 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Ping timeout: 240 seconds] 09:23 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 09:24 < luke-jr> achow101: btw, have you looked into if sqlite ever leaves stale/deleted data in db files? 09:25 < achow101> luke-jr: it does, but there's an option that can be enabled to overwrite the data 09:25 < luke-jr> cool 09:25 < achow101> that operation can also be done as a one time thing. IIRC I have set it to do that after encrypting 09:33 < phantomcircuit> achow101, you going to use wal or no? 09:33 < achow101> phantomcircuit: no 09:34 < achow101> wal is the cause of a bunch of bdb issues 09:34 < phantomcircuit> yeah 09:34 < phantomcircuit> it's why there's flush's everywhere and those do i think 3 fsync each call 09:35 < achow101> yeah, the PR explicitly disables wal too 09:37 < phantomcircuit> achow101, should set application_id as well 09:37 < achow101> hmm 09:37 < achow101> I suppose so 09:42 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 09:42 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 09:48 < phantomcircuit> achow101, is there manual vacuum being done? i dont see it 09:49 < achow101> It's in the Rewrite() function 09:52 < phantomcircuit> also need to set checkpoint_fullfsync if you want real fsync on osx 09:53 < phantomcircuit> wait no you want fullfsync 09:55 < achow101> You should leave comments on the PR 10:01 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 10:05 < phantomcircuit> achow101, btw i think sqlite in it's normal, non wal operation does create a separate journal file, but only for the time between the transaction commit and the fsync completing 10:05 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 264 seconds] 10:05 < achow101> phantomcircuit: yes, but it deletes it later 10:06 < achow101> everything still ends up in the database file after the write 10:06 < phantomcircuit> yeah immediately after the fsync completes 10:06 < phantomcircuit> achow101, did you consider opening the file with an exclusive lock? 10:07 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 10:07 < achow101> yes, but we already lock the .walletlock file in the directory so I don't think it's needed 10:07 < phantomcircuit> im writting a comment on the pr with some of this stuff btw 10:10 < phantomcircuit> achow101, also i notice that you implemented EraseKey which is called by nothing 10:10 < achow101> eh? Isn't it called by EraseIC? 10:12 < phantomcircuit> achow101, once again github search lies to me 10:12 < achow101> lol 10:13 < phantomcircuit> it feels like an elastic search cluster that's missing a server constantly 10:13 < phantomcircuit> (i think it's literally that, but azure) 10:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:17 < bitcoin-git> [bitcoin] jnewbery opened pull request #19910: net processing: Move peer_map to PeerManager (master...2020-08-peer-plv2) https://github.com/bitcoin/bitcoin/pull/19910 10:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:21 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection] 10:23 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 10:26 -!- lightlike [~lightlike@p200300c7ef11ae00c47a9d64995cb930.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 10:54 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 10:58 -!- sr_gi [~sr_gi@static-75-213-224-77.ipcom.comunitel.net] has quit [Read error: Connection reset by peer] 10:58 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 240 seconds] 11:00 -!- sankarshan1 [~sankarsha@195.206.169.184] has quit [] 11:19 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection] 11:21 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:98e3:60a1:d1c6:f602] has joined #bitcoin-core-dev 11:22 -!- neutraltc [~neutraltc@178.162.204.214] has joined #bitcoin-core-dev 11:25 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 246 seconds] 11:32 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev 11:32 -!- filchef [~filchef@212.104.97.177] has quit [Client Quit] 11:33 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev 11:38 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev 11:40 -!- valwal_ [sid334773@gateway/web/irccloud.com/x-wezdtzfnojtzpvay] has quit [] 11:43 -!- t420babe [~t420babe@pool-96-239-17-242.nycmny.fios.verizon.net] has quit [K-Lined] 11:43 -!- dongcarl [~dongcarl@unaffiliated/dongcarl] has quit [K-Lined] 11:48 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 260 seconds] 11:51 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 11:55 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:98e3:60a1:d1c6:f602] has quit [Remote host closed the connection] 11:56 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:98e3:60a1:d1c6:f602] has joined #bitcoin-core-dev 12:01 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:98e3:60a1:d1c6:f602] has quit [Ping timeout: 244 seconds] 12:08 -!- luke [~luke@bitnomial/staff/luke] has joined #bitcoin-core-dev 12:10 -!- vincenzopalazzo [~vincent@host-79-35-119-77.retail.telecomitalia.it] has joined #bitcoin-core-dev 12:11 -!- Talkless [~Talkless@hst-227-49.splius.lt] has quit [Quit: Konversation terminated!] 12:12 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 12:24 -!- luke [~luke@bitnomial/staff/luke] has quit [Max SendQ exceeded] 12:26 -!- luke [~luke@bitnomial/staff/luke] has joined #bitcoin-core-dev 12:30 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev 12:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:33 < bitcoin-git> [bitcoin] narula opened pull request #19911: net: guard vRecvGetData with cs_vRecv and orphan_work_set with g_cs_orphans (master...cs_vRecv) https://github.com/bitcoin/bitcoin/pull/19911 12:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:35 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 260 seconds] 12:35 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Remote host closed the connection] 12:36 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev 12:48 -!- ariard_ is now known as ariard 13:10 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 256 seconds] 13:21 -!- luke [~luke@bitnomial/staff/luke] has quit [Quit: sleep] 13:34 -!- proofofkeags [~proofofke@75-166-188-219.hlrn.qwest.net] has joined #bitcoin-core-dev 13:34 < jnewbery> hi folks. Reminder that tomorrow at 15:00 UTC is the next p2p meeting. We have one proposed topic so far: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings#8-sept-2020 13:34 < gribble> https://github.com/bitcoin/bitcoin/issues/8 | RPC command to sign text with wallet private key · Issue #8 · bitcoin/bitcoin · GitHub 13:34 < jnewbery> Feel free to add proposed topics to the wiki 13:36 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer] 13:37 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 13:51 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 264 seconds] 13:52 -!- melande2 is now known as melande 13:56 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 13:57 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:00 -!- neutraltc [~neutraltc@178.162.204.214] has quit [] 14:03 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 14:05 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 258 seconds] 14:06 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Read error: Connection timed out] 14:06 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 14:22 -!- AIM` [~AIM`@s91904426.blix.com] has joined #bitcoin-core-dev 14:29 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 14:29 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 14:32 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 246 seconds] 14:32 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 14:35 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 14:40 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 14:40 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 14:42 -!- dhruvm [~noreply@249.115.24.136.in-addr.arpa] has quit [Quit: leaving] 14:45 -!- dhruvm [~noreply@249.115.24.136.in-addr.arpa] has joined #bitcoin-core-dev 14:50 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 14:53 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 14:54 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 15:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 15:00 < bitcoin-git> [bitcoin] hebasto opened pull request #19913: refactor: Drop unused `UniqueLock(Mutex*, ...)` constructor in sync.h (master...200907-sync) https://github.com/bitcoin/bitcoin/pull/19913 15:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 15:01 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 15:01 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 15:10 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.9] 15:12 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 15:14 -!- isis [~isis@abulafia.patternsinthevoid.net] has quit [Ping timeout: 264 seconds] 15:15 -!- isis [~isis@abulafia.patternsinthevoid.net] has joined #bitcoin-core-dev 15:59 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 16:06 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 16:15 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Read error: Connection reset by peer] 16:15 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Remote host closed the connection] 16:16 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev 16:16 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev 16:30 -!- marcoagner [~user@2001:8a0:6a45:1900:2fd7:e0f0:d356:dd70] has quit [Ping timeout: 246 seconds] 16:31 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection] 16:36 -!- lightlike [~lightlike@p200300c7ef11ae00c47a9d64995cb930.dip0.t-ipconnect.de] has quit [Quit: Leaving] 16:36 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 256 seconds] 16:37 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 16:54 -!- nsh [~lol@wikipedia/nsh] has quit [Ping timeout: 265 seconds] 16:55 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 16:58 -!- nsh [~lol@wikipedia/nsh] has joined #bitcoin-core-dev 16:59 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 17:00 -!- AIM` [~AIM`@s91904426.blix.com] has quit [] 17:36 -!- kanzure [~kanzure@unaffiliated/kanzure] has quit [Ping timeout: 240 seconds] 17:37 -!- kanzure [~kanzure@unaffiliated/kanzure] has joined #bitcoin-core-dev 17:46 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has quit [Ping timeout: 264 seconds] 17:52 -!- davec [~davec@cpe-24-243-240-159.hot.res.rr.com] has joined #bitcoin-core-dev 17:56 -!- lahwran [~lahwran@s91904426.blix.com] has joined #bitcoin-core-dev 18:12 -!- berndj [~berndj@ns1.linksynergy.co.za] has quit [Remote host closed the connection] 18:12 -!- berndj [~berndj@ns1.linksynergy.co.za] has joined #bitcoin-core-dev 18:40 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 18:41 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 19:07 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 19:07 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 19:38 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 258 seconds] 19:40 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Ping timeout: 256 seconds] 19:45 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 19:45 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 19:56 -!- vadorovsky__ [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev 19:59 -!- mrostecki_ [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Ping timeout: 240 seconds] 20:00 -!- lahwran [~lahwran@s91904426.blix.com] has quit [] 20:22 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 20:22 -!- davidfg41 [~davidfg4@185.163.110.125] has joined #bitcoin-core-dev 20:22 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 20:23 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev 20:25 -!- dongcarl [~dongcarl@unaffiliated/dongcarl] has joined #bitcoin-core-dev 20:28 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Ping timeout: 240 seconds] 20:38 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev 20:38 -!- vadorovsky__ [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Remote host closed the connection] 20:38 -!- vadorovsky__ [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev 20:59 -!- Davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection] 20:59 -!- Davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev 21:15 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Remote host closed the connection] 21:22 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev 21:24 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Remote host closed the connection] 21:25 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev 21:31 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Ping timeout: 260 seconds] 21:32 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev 21:43 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Ping timeout: 240 seconds] 21:43 -!- rodarmor [sid210835@gateway/web/irccloud.com/x-oqmudmeotuswblda] has joined #bitcoin-core-dev 21:45 -!- elenaIncognito [71a137b5@113.161.55.181] has joined #bitcoin-core-dev 21:48 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev 22:02 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Quit: Leaving] 22:02 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Ping timeout: 264 seconds] 22:04 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev 22:04 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 22:10 -!- IGHOR [~quassel@176.121.4.135] has quit [Quit: http://quassel-irc.org ? ??????????? ?????????. ????-??.] 22:13 -!- IGHOR [~quassel@176.121.4.135] has joined #bitcoin-core-dev 22:15 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 22:15 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 22:17 -!- elenaIncognito [71a137b5@113.161.55.181] has quit [Remote host closed the connection] 22:20 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Ping timeout: 258 seconds] 22:41 < fanquake> Wumpus / sipa: can you block maza1374 22:41 -!- Davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Ping timeout: 240 seconds] 22:42 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 22:42 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 22:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:57 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #19914: refactor: Do not pass chain params to CheckForStaleTipAndEvictPeers twice (master...2009-netNo2ChainParams) https://github.com/bitcoin/bitcoin/pull/19914 22:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:58 -!- worc3131 [~quassel@2a02:c7f:c026:9500:7d0b:65d0:38a4:4786] has quit [Ping timeout: 260 seconds] 23:00 -!- davidfg41 [~davidfg4@185.163.110.125] has quit [] 23:17 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 246 seconds] 23:21 -!- nihui [~nihui@217.146.82.202] has joined #bitcoin-core-dev 23:23 -!- wumpus [~ircclient@pdpc/supporter/professional/wumpus] has joined #bitcoin-core-dev 23:37 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:5455:7615:e1e0:1a8e] has joined #bitcoin-core-dev 23:42 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:5455:7615:e1e0:1a8e] has quit [Remote host closed the connection] 23:42 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:5455:7615:e1e0:1a8e] has joined #bitcoin-core-dev 23:44 -!- arowser [~arowser1@204.124.180.72] has quit [Remote host closed the connection] 23:44 -!- arowser [~arowser1@204.124.180.72] has joined #bitcoin-core-dev 23:47 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:5455:7615:e1e0:1a8e] has quit [Ping timeout: 260 seconds] 23:47 < gleb> #19895 should be closed I assume. 23:47 < gribble> https://github.com/bitcoin/bitcoin/issues/19895 | I find this line very offensive. · Issue #19895 · bitcoin/bitcoin · GitHub 23:49 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 23:52 < aj> closed/locked 23:55 -!- marcoagner [~user@bl11-17-219.dsl.telepac.pt] has joined #bitcoin-core-dev 23:56 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Read error: Connection reset by peer] 23:57 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 23:58 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Ping timeout: 240 seconds] 23:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:59 < bitcoin-git> [bitcoin] hebasto closed pull request #19913: refactor: Drop unused `UniqueLock(Mutex*, ...)` constructor in sync.h (master...200907-sync) https://github.com/bitcoin/bitcoin/pull/19913 23:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] --- Log closed Tue Sep 08 00:00:12 2020