--- Log opened Sat Oct 03 00:00:36 2020
00:11 -!- S3RK [~s3rk@116.118.75.225] has joined #bitcoin-core-dev
00:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds]
00:16 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:cd2e:dfc7:2864:398] has joined #bitcoin-core-dev
00:48 < wumpus> amiti: sure but i think it's important to allow for flexibility, we don't really know all uses people have for the software, this is even more the case for open source software ... as long as it doesn't result in a direct bug / crash i don't see why it should be prevented
00:50 < wumpus> amiti: in this case there isn't any harm caused if someone does `-connect -dnsseed=1`, at most it wastes some bandwidth
00:54 < wumpus> software like bitcoind is primarily a tool, it's in the end not really up to the maintainers how people use it, there's some actually dangerous combinations that are possible: e.g. we strongly recommend that people don't bind RPC on anything but localhost, but if you really want to they can, and i guess there might be some legit scenarios where someone wants to do it
00:56 < wumpus> and yes, people might 'accidentally misunderstand how CLI flags work', but that's more of a risk for real footguns
00:57 < wumpus> dhruvm: i somewhat wonder what specifically made you concerned about this combination in the first place
01:02 < wumpus> also: maybe your node doesn't care about the addresses itself, but your node still takes part in address gossiping, so AddrMan functionality shouldn't be fully disabled, that'd be a logically separate choice
01:02 < wumpus> in any case a default is sufficient here, doing anything else would *add* complexity
01:08 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 260 seconds]
01:10 < wumpus> the higher level question would be 'should AddrMan be entirely disabled in some cases', we had some related discussion wrt. that for BIP155 for making it possible for nodes to signal that they don't take part in address gossip
01:19 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:cd2e:dfc7:2864:398] has quit [Ping timeout: 272 seconds]
01:22 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev
01:26 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
01:39 -!- digi_james [sid281632@gateway/web/irccloud.com/x-ybgmrpzqidouzgpo] has quit [Ping timeout: 272 seconds]
01:40 -!- digi_james [sid281632@gateway/web/irccloud.com/x-nwtegsatakxbqcim] has joined #bitcoin-core-dev
01:41 -!- michagogo [sid14316@wikia/Michagogo] has quit [Ping timeout: 272 seconds]
01:41 -!- drbrule [sid395654@gateway/web/irccloud.com/x-cqgwchvakrtjjklm] has quit [Ping timeout: 272 seconds]
01:42 -!- michagogo [sid14316@wikia/Michagogo] has joined #bitcoin-core-dev
01:43 -!- drbrule [sid395654@gateway/web/irccloud.com/x-xszuswimxvtaajbg] has joined #bitcoin-core-dev
01:48 -!- S3RK [~s3rk@116.118.75.225] has quit [Remote host closed the connection]
01:49 -!- S3RK [~s3rk@116.118.75.225] has joined #bitcoin-core-dev
01:53 -!- S3RK [~s3rk@116.118.75.225] has quit [Ping timeout: 258 seconds]
02:00 -!- r4d1x1 [~r4d1x@94.229.74.91] has quit []
02:04 -!- kexkey [~kexkey@37.120.205.214] has quit [Ping timeout: 246 seconds]
02:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:04 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20065: fuzz: Configure check for main function (master...2010-fuzzMainConfig) https://github.com/bitcoin/bitcoin/pull/20065
02:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
02:18 -!- frogar [~frogar_@172.105.92.83] has quit [Remote host closed the connection]
02:21 -!- martind1 [~martind@84.39.116.180] has joined #bitcoin-core-dev
02:22 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection]
02:29 -!- yancy [~root@li1543-67.members.linode.com] has joined #bitcoin-core-dev
02:52 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:cd2e:dfc7:2864:398] has joined #bitcoin-core-dev
02:57 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:cd2e:dfc7:2864:398] has quit [Remote host closed the connection]
02:57 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:cd2e:dfc7:2864:398] has joined #bitcoin-core-dev
03:02 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:cd2e:dfc7:2864:398] has quit [Ping timeout: 272 seconds]
03:10 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
03:12 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
03:18 -!- Katelynn2Hauck [~Katelynn2@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev
03:25 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has joined #bitcoin-core-dev
03:32 -!- b10c [~b10c@2a01:4f8:192:612a:216:3eff:fef3:dc6a] has quit [Quit: leaving]
03:33 -!- b10c [~b10c@2a01:4f8:192:612a:216:3eff:fef3:dc6a] has joined #bitcoin-core-dev
03:53 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
03:59 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
04:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:02 < bitcoin-git> [bitcoin] theStack opened pull request #20067: refactor: remove use of boost::algorithm::replace_first (master...20201003-get-rid-of-boost-replace_first) https://github.com/bitcoin/bitcoin/pull/20067
04:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:02 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds]
04:05 -!- Katelynn2Hauck [~Katelynn2@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 240 seconds]
04:34 < hebasto> could any one explain this https://travis-ci.org/github/bitcoin/bitcoin/jobs/732481553 ?
04:42 -!- worc3131 [~quassel@2a02:c7f:c026:9500:7d0b:65d0:38a4:4786] has quit [Ping timeout: 244 seconds]
04:42 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit []
04:44 < aj> hebasto: #19956 had "scripted diff" in the commit message instead of "scripted-diff"
04:44 < gribble> https://github.com/bitcoin/bitcoin/issues/19956 | rpc: Improve invalid vout value rpc error message by n1rna · Pull Request #19956 · bitcoin/bitcoin · GitHub
04:45 < wumpus> hebasto: none of your commits looks remotely like a scripted diff at least
04:46 < hebasto> that is it, looks very strange
04:46 < hebasto> aj: oh, thanks!
04:47 < wumpus> that error message really needs to have the commit id in it to be useful
04:47 < wumpus> test/lint/commit-script-check.sh line 40
04:48 < wumpus> but that seems to be it ^^
04:50 < hebasto> wumpus: what script is used for merging? is it its responsibility to check such variants?
04:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:51 < bitcoin-git> [bitcoin] laanwj opened pull request #20069: test: Mention commit id in scripted diff error (master...2020_10_scriptdiff_lint_errormsg) https://github.com/bitcoin/bitcoin/pull/20069
04:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:53 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has joined #bitcoin-core-dev
04:57 < hebasto> interesting that #19956 has no Travis CI check
04:57 < gribble> https://github.com/bitcoin/bitcoin/issues/19956 | rpc: Improve invalid vout value rpc error message by n1rna · Pull Request #19956 · bitcoin/bitcoin · GitHub
04:57 -!- martind1 [~martind@84.39.116.180] has quit [Remote host closed the connection]
04:58 -!- FredC [~FredC@178.239.168.171] has joined #bitcoin-core-dev
05:00 -!- FredC [~FredC@178.239.168.171] has quit []
05:22 -!- mrafiee [~mrafiee@84.39.116.180] has joined #bitcoin-core-dev
05:41 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Quit: jonatack]
05:56 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev
06:02 -!- alko89 [~alko89@unaffiliated/alko89] has quit [Quit: ZNC 1.7.5 - https://znc.in]
06:25 -!- alko89 [~alko89@unaffiliated/alko89] has joined #bitcoin-core-dev
06:27 < wumpus> hebasto: no, the script for merging doesn't check this, it's up to the maintainer merging it to do such checks or not
06:28 < wumpus> how deep is this linting script checking anyway? I'm a bit surprised it checks previous PRs, I don't think it should
06:35 < aj> wumpus: it's $TRAVIS_COMMIT_RANGE which is meant to be only the PR commits, but is all the commits from both the PR and that were merged since the PR's branch point, i think -- https://github.com/travis-ci/travis-ci/issues/4596  also #19654
06:35 < gribble> https://github.com/bitcoin/bitcoin/issues/19654 | lint: Dont use TRAVIS_COMMIT_RANGE in commit message linter by fjahr · Pull Request #19654 · bitcoin/bitcoin · GitHub
06:46 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
06:53 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has joined #bitcoin-core-dev
07:09 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
07:37 -!- davec [~davec@072-183-054-196.res.spectrum.com] has quit [Ping timeout: 246 seconds]
07:37 -!- davec [~davec@072-183-054-196.res.spectrum.com] has joined #bitcoin-core-dev
07:57 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
08:00 -!- mrafiee [~mrafiee@84.39.116.180] has quit []
08:09 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has joined #bitcoin-core-dev
08:14 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds]
08:22 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
08:22 -!- shoman94 [~shoman94@89.47.234.28] has joined #bitcoin-core-dev
08:43 -!- jkczyz [sid419941@gateway/web/irccloud.com/x-yaznznuikggdvlgi] has quit [Ping timeout: 272 seconds]
08:43 -!- moneyball [sid299869@gateway/web/irccloud.com/x-cxbxyqedlvekpsqc] has quit [Ping timeout: 272 seconds]
08:43 -!- moneyball [sid299869@gateway/web/irccloud.com/x-knmkcntuccvblapy] has joined #bitcoin-core-dev
08:43 -!- jkczyz [sid419941@gateway/web/irccloud.com/x-hcvvptwtteadyimp] has joined #bitcoin-core-dev
08:43 -!- endogenic [sid145991@gateway/web/irccloud.com/x-azhyqzdsopihumgd] has quit [Ping timeout: 272 seconds]
08:44 -!- pierre_rochard [sid299882@gateway/web/irccloud.com/x-qynfobvbtshhlvyc] has quit [Ping timeout: 272 seconds]
08:45 -!- NicolasDorier [sid129442@gateway/web/irccloud.com/x-fxglxttobzmtxxln] has quit [Ping timeout: 272 seconds]
08:45 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-orjtvsxyrbvwkkno] has quit [Ping timeout: 256 seconds]
08:45 -!- bosma [sid103570@gateway/web/irccloud.com/x-ucfnvwbnuqmjqgnp] has quit [Ping timeout: 260 seconds]
08:46 -!- pierre_rochard [sid299882@gateway/web/irccloud.com/x-sibfhtxywaxkekwa] has joined #bitcoin-core-dev
08:47 -!- endogenic [sid145991@gateway/web/irccloud.com/x-cysirwsrudjtolco] has joined #bitcoin-core-dev
08:48 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-hlnzquefznidhiso] has joined #bitcoin-core-dev
08:49 -!- bosma [sid103570@gateway/web/irccloud.com/x-covcbtpgqmbelwuu] has joined #bitcoin-core-dev
08:52 -!- NicolasDorier [sid129442@gateway/web/irccloud.com/x-jwyowwbzncraqita] has joined #bitcoin-core-dev
09:01 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
09:04 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has joined #bitcoin-core-dev
09:05 -!- sr_gi [~sr_gi@static-80-160-230-77.ipcom.comunitel.net] has quit [Read error: Connection reset by peer]
09:12 -!- shesek [~shesek@164.90.217.137] has joined #bitcoin-core-dev
09:12 -!- shesek [~shesek@164.90.217.137] has quit [Changing host]
09:12 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
09:12 < fjahr> Yeah, it's the same issue. $TRAVIS_COMMIT_RANGE is very unintuitive.
09:16 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
09:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:16 < bitcoin-git> [bitcoin] fjahr opened pull request #20071: ci: Don't use TRAVIS_COMMIT_RANGE for commit-script-check (master...commit_range) https://github.com/bitcoin/bitcoin/pull/20071
09:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:31 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
09:54 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
09:57 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds]
10:04 -!- cltrbreak_MAD2 is now known as ctrlbreak
10:09 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:cd2e:dfc7:2864:398] has joined #bitcoin-core-dev
10:20 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:cd2e:dfc7:2864:398] has quit [Remote host closed the connection]
10:20 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:cd2e:dfc7:2864:398] has joined #bitcoin-core-dev
10:25 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:cd2e:dfc7:2864:398] has quit [Ping timeout: 272 seconds]
10:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:32 < bitcoin-git> [bitcoin] fjahr opened pull request #20072: ci: Build Arm64 on Travis without functional tests (master...travis_arm) https://github.com/bitcoin/bitcoin/pull/20072
10:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:32 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
10:39 < fjahr> I think until #20071 is merged or the offending commit is rolled back, all new PRs will fail on Travis.
10:39 < gribble> https://github.com/bitcoin/bitcoin/issues/20071 | ci: Dont use TRAVIS_COMMIT_RANGE for commit-script-check by fjahr · Pull Request #20071 · bitcoin/bitcoin · GitHub
10:40 < fjahr> f471a3be00c2b6433b8c258b716982c0539da13f is the offender that would need to be removed
10:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:42 < bitcoin-git> [bitcoin] hebasto opened pull request #20073: [DO NOT MERGE] ci: Print TRAVIS_COMMIT_RANGE before fail (master...201003-travis) https://github.com/bitcoin/bitcoin/pull/20073
10:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:42 < fjahr> or as aj said #19956
10:42 < gribble> https://github.com/bitcoin/bitcoin/issues/19956 | rpc: Improve invalid vout value rpc error message by n1rna · Pull Request #19956 · bitcoin/bitcoin · GitHub
10:46 < sipa> fjahr: i haven't followed this; what is the problem with f471a3be ?
10:48 < fjahr> it has "scripted diff" instead of "scripted-diff" as a prefix, which makes the linter fail. But it was merged and since the linter uses TRAVIS_COMMIT_RANGE it checks all the pushed commits of a new PR. So when a new PR is opened all commits are checked, including the offending one in master.
10:50 < sipa> oh
10:51 < sipa> and the appveyor build is failing on #20071, for the ubrelated msys2 problem, sigh!
10:51 < gribble> https://github.com/bitcoin/bitcoin/issues/20071 | ci: Dont use TRAVIS_COMMIT_RANGE for commit-script-check by fjahr · Pull Request #20071 · bitcoin/bitcoin · GitHub
10:51 < hebasto> travis environment seems inconsistent; both #20072 and #20073 are built on the same base, but TRAVIS_COMMIT_RANGE seems have different base commit for them
10:51 < gribble> https://github.com/bitcoin/bitcoin/issues/20072 | ci: Build Arm64 on Travis without functional tests by fjahr · Pull Request #20072 · bitcoin/bitcoin · GitHub
10:51 < gribble> https://github.com/bitcoin/bitcoin/issues/20073 | [DO NOT MERGE] ci: Print TRAVIS_COMMIT_RANGE before fail by hebasto · Pull Request #20073 · bitcoin/bitcoin · GitHub
10:52 < fjahr> is this a ci deadlock?
10:52 < hebasto> what is "ci deadlock"?
10:53 < fjahr> a joke :)
10:53 < hebasto> :D
10:53 < fjahr> both ci fixes fail on another ci
10:53 < hebasto> let's get rid of TRAVIS_COMMIT_RANGE completely
10:53 < fjahr> I agree
10:54 < sipa> it seems TRAVIS_COMMIT_RANGE just isn't the right thing for sanity checks on PRs
10:54 < sipa> so agree
10:56 < fjahr> I am removing it from the whitespace linter which seems to be the only place left
10:56 < sipa> cool
10:56 < hebasto> it's a pity we cannot find out the actual value of TRAVIS_COMMIT_RANGE on failed builds
10:57 < sipa> it's just $MASTER...$MERGED_PR_HEAD, no?
10:58 < hebasto> in that case it should work, but it doesn't
10:58 < hebasto> compare 20072 and 20073
10:58 < fjahr> no, it is all the pushed commits, so for example when you rebase it is including all the rebase commits
10:59 < fjahr> I tried to explain it a bit better in https://github.com/bitcoin/bitcoin/pull/19654
10:59 < hebasto> fjahr: that is not the case for the recent 20072 and 20073
11:00 -!- shoman94 [~shoman94@89.47.234.28] has quit []
11:00 < hebasto> your 20072 has the same base commit as my 20073
11:00 < fjahr> I am not sure about the initial pushes when a PR is first opened. But since I saw my new or fail I assumed it goes back far, maybe even all commits.
11:01 < fjahr> that they are the same would make sense for new commits
11:01 < sipa> 54fc96ffa70ad3a53d32709101b7a2ce064d822e...f006f1679d0833f8d9c693553196a68a69e4f65f on #20073
11:01 < gribble> https://github.com/bitcoin/bitcoin/issues/20073 | [DO NOT MERGE] ci: Print TRAVIS_COMMIT_RANGE before fail by hebasto · Pull Request #20073 · bitcoin/bitcoin · GitHub
11:02 < hebasto> sipa: that is correct value
11:02 < hebasto> fjahr: 20072 has only one push, right?
11:02 < sipa> which is just master and the head of 20073
11:03 < sipa> try pushing a version of 20073, rebase on an older version of master?
11:05 < fjahr> a true, so maybe initial push is from master if your pr branch is up to date on master and if it's not up to date it is all commits from the last commit in the branch
11:05 < fjahr> *is from master HEAD
11:05 < sipa> note the ... syntax
11:05 < sipa> which does not mean "
11:05 < sipa> what you may expect
11:06 < sipa> it's all commits that are in A's history but not in B's, or the other way around (for A...B)
11:06 < sipa> if A and B have different snapshots of master in it, the difference between the two will be included in the range
11:06 < hebasto> sipa: experimental #20073 rebased on older base
11:06 < gribble> https://github.com/bitcoin/bitcoin/issues/20073 | [DO NOT MERGE] ci: Print TRAVIS_COMMIT_RANGE before fail by hebasto · Pull Request #20073 · bitcoin/bitcoin · GitHub
11:09 < sipa> yup
11:09 < sipa> so A is master, B is the head of your PR
11:09 < hebasto> failed with value 54fc96ffa70ad3a53d32709101b7a2ce064d822e...202ea04949ea9b742fa3368bb9104bb3a2099d3d
11:10 < sipa> which means that any commits in master that your PR has not been rebased on, are included
11:10 < hebasto> the latest TRAVIS_COMMIT_RANGE value is wrong; the base commit is 597488d37c9c358837616516d88f861f5c25f827
11:12 < sipa> i don't think it's wrong - it's doing what it's designed to, but that's not what we need
11:12 < hebasto> I'm wrong; the first is master commit
11:12 < hebasto> as it is `...` syntax
11:12 < sipa> fjahr: concept ack 20071
11:12 < fjahr> sipa: ty
11:14 < hebasto> sipa: I don't see how the commit range `54fc96ffa70ad3a53d32709101b7a2ce064d822e...202ea04949ea9b742fa3368bb9104bb3a2099d3d` includes the offender f471a3be00c2b6433b8c258b716982c0539da13f
11:14 < sipa> you're going to update it to also use that mechanism for the whitespace linter?
11:16 < hebasto> sipa: as the common commit is 597488d37c9c358837616516d88f861f5c25f827, which is later than offender 
11:16 < sipa> hebasto: the concept of X...Y is that if you have a git history of the form r-c1-c2-c3-X and r-c1-c4-Y, then X...Y is the set of commits (c2, c3, c4, X, Y)
11:16 < sipa> it is not a "range"
11:16 < sipa> it's a set difference
11:16 < hebasto> I understand this notion
11:16 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Read error: Connection reset by peer]
11:16 < hebasto> that why I'm asking
11:17 < sipa> hebasto: 54fc96ffa70ad3a53d32709101b7a2ce064d822e has the offender f471a3be00c2b6433b8c258b716982c0539da13f in its history; 202ea04949ea9b742fa3368bb9104bb3a2099d3d does not
11:18 < fjahr> sipa: I will unless 20071 already gets merged. But will finish the whitespace one soon.
11:18 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev
11:20 < sipa> hebasto: which also means the merge-base 597488d37c9c358837616516d88f861f5c25f827 does not have the offender in its history
11:20 < sipa> so i think you're just overlooking something
11:22 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Client Quit]
11:23 < hebasto> sipa: correct
11:26 < sipa> fjahr: i believe your code in 20071 is unnecessary; "$MERGE_BASE..HEAD" should be identical to "$(git merge-base HEAD $MERGE_BASE)..HEAD", unless there is a subtle difference between master and $MERGE_BASE ?
11:26 < hebasto> sipa: that means TRAVIS_COMMIT_RANGE for a new pr which is built on top of current HEAD (that merges the offender) should not include the offender, right?
11:26 < sipa> hebasto: correct
11:26 < sipa> that's my understanding, but i'm not entirely sure that re-pushes don't have extra behavior
11:27 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev
11:27 < hebasto> sipa: thanks
11:28 < sipa> fjahr: the merge-base with master may result in weird effects if it's a PR for a release branch rather than master
11:31 < fjahr> sipa: I am not sure if I understand. Did you mean it should be identical to "$(git merge-base HEAD)..HEAD"?
11:31 < fjahr> Otherwise I am confused because you still have $MERGE_BASE in there
11:32 < sipa> fjahr: i'm saying that you should use "$MERGE_BASE..HEAD" and not "$(git merge-base HEAD $MERGE_BASE)..HEAD" as you're doing now
11:32 < sipa> sorry
11:32 < sipa> fjahr: i'm saying that you should use "$MERGE_BASE..HEAD" and not "$(git merge-base HEAD master)..HEAD" as you're doing now
11:33 < sipa> what you're doing now is equivalent (as far as I understand) to "master..HEAD", which would be wrong for non-master PRs
11:34 < fjahr> in both commits or the second one I added?
11:35 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
11:35 < sipa> in all of them
11:35 < sipa> do you understand what i mean?
11:36 < fjahr> So there is already a variable $MERGE_BASE? I did not know that
11:36 < sipa> you're using it!
11:36 < sipa> COMMIT_RANGE="$MERGE_BASE..HEAD"
11:36 < sipa> oh
11:36 < sipa> i'm misreading, i see
11:36 < sipa> ignore me
11:36 < fjahr> :)
11:38 < sipa> try COMMIT_RANGE="$TRAVIS_BRANCH..HEAD" ?
11:38 < sipa> TRAVIS_BRANCH:
11:38 < sipa> for push builds, or builds not triggered by a pull request, this is the name of the branch. for builds triggered by a pull request this is the name of the branch targeted by the pull request.
11:38 < sipa> for builds triggered by a tag, this is the same as the name of the tag (TRAVIS_TAG).
11:45 < fjahr> I thought it might be good to not be dependent on travis variables. But you think it will be more robust?
11:46 -!- jrawsthorne [~jrawsthor@static.235.41.217.95.clients.your-server.de] has quit [Read error: Connection reset by peer]
11:47 -!- jrawsthorne [~jrawsthor@static.235.41.217.95.clients.your-server.de] has joined #bitcoin-core-dev
11:49 < fjahr> Ah, you mean only in 06_script.sh, not the other places...
11:49 < sipa> fjahr: i think your current code will cause non-master PRs to recheck the entire history back to where the release branch forked off
11:51 < fjahr> ah, I see, I think that is right
11:56 -!- Jamalaka [~Jamalaka@178.162.209.171] has joined #bitcoin-core-dev
12:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:01 < bitcoin-git> [bitcoin] robot-dreams opened pull request #20074: test: p2p_blockfilters tests for BIP157 config args (master...bip157-blockfilters-tests) https://github.com/bitcoin/bitcoin/pull/20074
12:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:04 -!- go11111111111 [go1111111@gateway/vpn/privateinternetaccess/go1111111] has joined #bitcoin-core-dev
12:05 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has joined #bitcoin-core-dev
12:07 -!- go1111111 [~go1111111@104.156.98.86] has quit [Ping timeout: 240 seconds]
12:09 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:889b:d790:ab88:c007] has joined #bitcoin-core-dev
12:10 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has quit [Ping timeout: 240 seconds]
12:12 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:889b:d790:ab88:c007] has quit [Remote host closed the connection]
12:12 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:889b:d790:ab88:c007] has joined #bitcoin-core-dev
12:19 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:889b:d790:ab88:c007] has quit [Remote host closed the connection]
12:20 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:889b:d790:ab88:c007] has joined #bitcoin-core-dev
12:24 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:889b:d790:ab88:c007] has quit [Ping timeout: 260 seconds]
13:11 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
13:17 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Read error: Connection reset by peer]
13:18 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev
13:22 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:00 -!- Jamalaka [~Jamalaka@178.162.209.171] has quit []
14:10 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Quit: ZNC 1.7.5 - https://znc.in]
14:11 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev
14:12 -!- wullon587 [~wullon@241.243.86.88.rdns.comcable.net] has joined #bitcoin-core-dev
14:13 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev
14:21 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev
14:22 -!- filchef [~filchef@212.104.97.177] has quit [Client Quit]
14:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:42 < bitcoin-git> [bitcoin] sipa opened pull request #20075: [DO NOT MERGE] Version of #20071 rebased on buggy commit, with extra logging (master...pr20071) https://github.com/bitcoin/bitcoin/pull/20075
14:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:50 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev
14:54 -!- kers [~kers@185.204.1.185] has joined #bitcoin-core-dev
14:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:57 < bitcoin-git> [bitcoin] sipa closed pull request #20075: [DO NOT MERGE] Version of #20071 rebased on buggy commit, with extra logging (master...pr20071) https://github.com/bitcoin/bitcoin/pull/20075
14:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:01 < dhruvm> wumpus: Referring to your message from 08:57, what made me curious about these cli flag combinations is that I am new to the codebase and trying to estaablish a mental model for how the p2p layer works. For me this has involved going through the code, asking people I have access to questions about why things are a certain way.
15:03 < dhruvm> When I saw that getaddr calls are still made in -connect mode I found myself confused as a new developer, and thought this may be confusing to future new devs as well. So the primary motivation was keeping things easy to understand.
15:09 < sipa> dhruvm: good thinking
15:10 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
15:12 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
15:17 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Read error: Connection reset by peer]
15:22 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev
15:53 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
16:03 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
16:12 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
16:17 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
16:30 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has joined #bitcoin-core-dev
16:34 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
16:34 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has quit [Ping timeout: 240 seconds]
16:40 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has joined #bitcoin-core-dev
16:40 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has quit [Client Quit]
16:42 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has joined #bitcoin-core-dev
16:50 -!- brianhoffman_ [~brianhoff@pool-71-191-34-154.washdc.fios.verizon.net] has joined #bitcoin-core-dev
16:52 -!- brianhoffman [~brianhoff@pool-71-191-34-154.washdc.fios.verizon.net] has quit [Ping timeout: 240 seconds]
16:52 -!- brianhoffman_ is now known as brianhoffman
16:55 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds]
17:00 -!- kers [~kers@185.204.1.185] has quit []
17:00 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
17:00 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
17:05 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
17:10 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has quit [Quit: leaving]
17:13 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection]
17:14 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
17:21 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Ping timeout: 240 seconds]
17:22 -!- theGrg [~theGrg@195.206.169.184] has joined #bitcoin-core-dev
17:27 -!- Randolf [~randolf@184.70.10.188] has joined #bitcoin-core-dev
17:28 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Read error: Connection reset by peer]
17:37 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds]
17:51 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev
18:27 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection]
18:29 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev
18:31 -!- kexkey [~kexkey@37.120.205.214] has joined #bitcoin-core-dev
18:31 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
18:32 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 240 seconds]
19:08 -!- RandolfR [~randolf@184.70.10.189] has joined #bitcoin-core-dev
19:10 -!- Randolf [~randolf@184.70.10.188] has quit [Ping timeout: 240 seconds]
19:12 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
19:24 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
19:24 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
19:25 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
19:27 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 272 seconds]
19:27 -!- RandolfR is now known as Randolf
19:30 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
19:30 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
19:35 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
19:35 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
19:40 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
19:41 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
19:42 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Ping timeout: 240 seconds]
19:51 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has joined #bitcoin-core-dev
19:58 -!- pepe_angila [94653e52@148.101.62.82] has joined #bitcoin-core-dev
20:00 -!- theGrg [~theGrg@195.206.169.184] has quit []
20:21 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
20:23 -!- Randolf [~randolf@184.70.10.189] has quit [Read error: Connection reset by peer]
20:26 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 260 seconds]
20:31 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
20:31 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
20:39 -!- pepe_angila [94653e52@148.101.62.82] has quit [Remote host closed the connection]
20:56 -!- pcmanus1 [~pcmanus@84.39.117.57] has joined #bitcoin-core-dev
21:24 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
21:27 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds]
21:39 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
21:42 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds]
22:11 -!- go121212 [~go1111111@104.156.98.86] has joined #bitcoin-core-dev
22:13 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds]
22:14 -!- go11111111111 [go1111111@gateway/vpn/privateinternetaccess/go1111111] has quit [Ping timeout: 240 seconds]
22:20 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
23:00 -!- pcmanus1 [~pcmanus@84.39.117.57] has quit []
23:20 -!- IOMonster1 [~IOMonster@178.162.209.171] has joined #bitcoin-core-dev
23:30 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
23:31 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
23:35 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
23:36 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
23:42 < amiti> wumpus: thanks for the thoughtful reply! helps to hear your outlook, and overall makes sense. I definitely agree with preventing anything dangerous, but questions around flexibility vs usability is more of a gray area. regarding `-connect  -dnsseed=1` it seems strange to engage in gossip if you don't actually care about the addresses, but reframing as a question of disabling AddrMan entirely seems like a good 
23:42 < amiti> bigger-picture direction to engage in 
--- Log closed Sun Oct 04 00:00:37 2020