--- Log opened Thu Oct 08 00:00:11 2020
--- Day changed Thu Oct 08 2020
00:00 -!- sethrogers23[m] [sethrogers@gateway/shell/matrix.org/x-icpaatufjnvzmlce] has joined #bitcoin-core-dev
00:00 -!- TheFuzzStone[m] [thefuzzsto@gateway/shell/matrix.org/x-biesaxxhmagppqbd] has joined #bitcoin-core-dev
00:00 -!- rcrtn32002[m] [crtn32002m@gateway/shell/matrix.org/x-pggfffuycocsrezw] has joined #bitcoin-core-dev
00:00 -!- snowkeld[m] [snowkeldma@gateway/shell/matrix.org/x-ycfalefqrnczphvq] has joined #bitcoin-core-dev
00:00 -!- kyoo[m] [kyoomatrix@gateway/shell/matrix.org/x-fylzqmvccqunwfgv] has joined #bitcoin-core-dev
00:00 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-ihqyrxcofnkxpzjr] has left #bitcoin-core-dev []
00:00 -!- tianshi[m] [tianshimat@gateway/shell/matrix.org/x-dsrpqyjinutvbkkl] has joined #bitcoin-core-dev
00:00 -!- RaphalBentgeac[m [raphaelben@gateway/shell/matrix.org/x-enewkwersnljifoo] has joined #bitcoin-core-dev
00:00 -!- Pasta[m] [pastapas1@gateway/shell/matrix.org/x-hdzbzqdiosxgrnnv] has joined #bitcoin-core-dev
00:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
00:30 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
00:31 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:9d05:b972:ca0b:bed0] has quit [Remote host closed the connection]
00:31 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:9d05:b972:ca0b:bed0] has joined #bitcoin-core-dev
00:32 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
00:32 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
00:33 -!- Netsplit *.net <-> *.split quits: RaphalBentgeac[m, leoburd, kallewoof, sethrogers23[m], mariorz, dergoegge, noganoo, jonatack, hsmiths
00:34 -!- emzy_ [~quassel@raspberry.emzy.de] has joined #bitcoin-core-dev
00:37 -!- RaphalBentgeac[m [raphaelben@gateway/shell/matrix.org/x-fcmvsdxyqekvmuzf] has joined #bitcoin-core-dev
00:37 -!- sethrogers23[m] [sethrogers@gateway/shell/matrix.org/x-fhfpacbiodkcgmso] has joined #bitcoin-core-dev
00:38 -!- dergoegge [sid453889@gateway/web/irccloud.com/x-jzdktyxxskljzfdk] has joined #bitcoin-core-dev
00:38 -!- hsmiths [uid95325@gateway/web/irccloud.com/x-pczrdzoxvqofogjr] has joined #bitcoin-core-dev
00:38 -!- mariorz [sid490@gateway/web/irccloud.com/x-jqjfzpvuedgznaeu] has joined #bitcoin-core-dev
00:38 -!- noganoo [sid146237@gateway/web/irccloud.com/x-dhagbkzxrshmzhyq] has joined #bitcoin-core-dev
00:38 -!- kallewoof [~quassel@240d:1a:759:6000:a7b1:451a:8874:e1ac] has joined #bitcoin-core-dev
00:44 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds]
00:44 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:9d05:b972:ca0b:bed0] has quit [Remote host closed the connection]
00:45 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:9d05:b972:ca0b:bed0] has joined #bitcoin-core-dev
00:46 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
00:50 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:9d05:b972:ca0b:bed0] has quit [Ping timeout: 272 seconds]
00:54 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:1cbc:d619:2a8a:c63b] has joined #bitcoin-core-dev
00:55 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:1cbc:d619:2a8a:c63b] has quit [Remote host closed the connection]
00:58 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:d9f8:8763:1c02:e987] has joined #bitcoin-core-dev
01:05 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
01:09 -!- jonatack [~jon@213.152.161.239] has joined #bitcoin-core-dev
01:10 -!- promag [~promag@188.251.225.32] has joined #bitcoin-core-dev
01:10 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex]
01:25 -!- Harekiet1 [~Harekiet@84.39.117.57] has joined #bitcoin-core-dev
01:29 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
01:29 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Client Quit]
01:31 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
01:33 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
01:34 -!- promag [~promag@188.251.225.32] has quit [Remote host closed the connection]
01:34 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev
01:35 < wumpus> the release notes should not be considered documentation, and it's good if the program is self-contained, I'd greatly prefer linking to some actual documentation instead-like the help text of options or other RPC calls
01:35 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has quit [Remote host closed the connection]
01:35 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has joined #bitcoin-core-dev
01:35 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
01:35 -!- promag [~promag@188.251.225.32] has joined #bitcoin-core-dev
01:36 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has joined #bitcoin-core-dev
01:37 -!- S3RK [~s3rk@47.246.66.115] has quit [Remote host closed the connection]
01:37 -!- promag [~promag@188.251.225.32] has quit [Remote host closed the connection]
01:40 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has quit [Ping timeout: 264 seconds]
01:45 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
01:52 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex]
01:54 -!- opsec_x12 [~opsec_x12@44-25-143-49.ip.hamwan.net] has quit [Read error: Connection reset by peer]
01:54 -!- opsec_x12 [~opsec_x12@44-25-143-49.ip.hamwan.net] has joined #bitcoin-core-dev
02:00 -!- Harekiet1 [~Harekiet@84.39.117.57] has quit []
02:03 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
02:15 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]
02:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
02:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
02:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
02:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
02:22 -!- sirkitree [~sirkitree@185.204.1.185] has joined #bitcoin-core-dev
02:24 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
02:27 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
02:28 -!- belcher [~belcher@unaffiliated/belcher] has quit [Client Quit]
02:40 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex]
02:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:40 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/283a73d7eaea...9dd4de2832e2
02:40 < bitcoin-git> bitcoin/master ec3916f Pieter Wuille: Use mockable time everywhere in net_processing
02:40 < bitcoin-git> bitcoin/master b6834e3 Pieter Wuille: Avoid 'timing mishap' warnings when mocking
02:40 < bitcoin-git> bitcoin/master 9dd4de2 MarcoFalke: Merge #20027: Use mockable time everywhere in net_processing
02:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:40 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20027: Use mockable time everywhere in net_processing (master...202009_mockable_netproc) https://github.com/bitcoin/bitcoin/pull/20027
02:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:45 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:d9f8:8763:1c02:e987] has quit [Remote host closed the connection]
02:46 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:d9f8:8763:1c02:e987] has joined #bitcoin-core-dev
02:46 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
02:49 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Client Quit]
02:50 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:d9f8:8763:1c02:e987] has quit [Ping timeout: 260 seconds]
02:51 -!- andreaca_ [~andreacab@2a02:120b:2c22:e0c0:b581:a4da:7aa0:1403] has joined #bitcoin-core-dev
02:55 -!- jonatack [~jon@213.152.161.239] has quit [Quit: jonatack]
03:00 -!- dermoth [~dermoth@unaffiliated/dermoth] has quit [Ping timeout: 272 seconds]
03:06 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
03:09 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Ping timeout: 272 seconds]
03:10 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
03:12 -!- dermoth [~dermoth@unaffiliated/dermoth] has joined #bitcoin-core-dev
03:12 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
03:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:13 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20103: test: Enable mocktime RPC for all test chains (master...2010-testMockAllChains) https://github.com/bitcoin/bitcoin/pull/20103
03:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:16 -!- vincenzopalazzo [~vincent@mob-109-119-44-160.net.vodafone.it] has joined #bitcoin-core-dev
03:18 -!- Elenor20Ziemann [~Elenor20Z@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev
03:21 -!- andreaca_ [~andreacab@2a02:120b:2c22:e0c0:b581:a4da:7aa0:1403] has quit [Remote host closed the connection]
03:21 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:b581:a4da:7aa0:1403] has joined #bitcoin-core-dev
03:23 -!- andreaca_ [~andreacab@2a02:120b:2c22:e0c0:f8fb:8430:4239:6d45] has joined #bitcoin-core-dev
03:25 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:b581:a4da:7aa0:1403] has quit [Ping timeout: 240 seconds]
03:33 -!- andreaca_ [~andreacab@2a02:120b:2c22:e0c0:f8fb:8430:4239:6d45] has quit [Remote host closed the connection]
03:34 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:f8fb:8430:4239:6d45] has joined #bitcoin-core-dev
03:35 -!- kallewoof [~quassel@240d:1a:759:6000:a7b1:451a:8874:e1ac] has quit [Read error: Connection reset by peer]
03:35 -!- kallewoof [~quassel@240d:1a:759:6000:a7b1:451a:8874:e1ac] has joined #bitcoin-core-dev
03:35 -!- emzy_ [~quassel@raspberry.emzy.de] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.]
03:36 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
03:36 -!- kallewoof [~quassel@240d:1a:759:6000:a7b1:451a:8874:e1ac] has quit [Read error: Connection reset by peer]
03:36 -!- kallewoof_ [~quassel@240d:1a:759:6000:a7b1:451a:8874:e1ac] has joined #bitcoin-core-dev
03:37 -!- worc3131 [~quassel@2a02:c7f:c026:9500:7d0b:65d0:38a4:4786] has quit [Ping timeout: 272 seconds]
03:38 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Client Quit]
03:39 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:f8fb:8430:4239:6d45] has quit [Ping timeout: 260 seconds]
03:40 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 240 seconds]
03:42 -!- S3RK [~s3rk@47.246.66.115] has quit [Remote host closed the connection]
03:42 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
03:44 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev
03:49 < wumpus> but no, there is no precedent for help options that are not RPC, and I'm not sure that's a good idea to introduce, it feels to me a kind of cluttery to use RPC help for that, it does reveal our lack of a more general user documentation. As a workaround isn't there some existing RPC where is would be appropriate?  
03:49 < wumpus> to be honest I think that error message is OK
03:50 < wumpus> it's long but it actually tells something useful
03:55 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Remote host closed the connection]
03:58 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev
04:14 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:f8fb:8430:4239:6d45] has joined #bitcoin-core-dev
04:17 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:f8fb:8430:4239:6d45] has quit [Remote host closed the connection]
04:17 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:f8fb:8430:4239:6d45] has joined #bitcoin-core-dev
04:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:19 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9dd4de2832e2...b337bd7bc087
04:19 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:f8fb:8430:4239:6d45] has quit [Remote host closed the connection]
04:19 < bitcoin-git> bitcoin/master fae7a1c MarcoFalke: fuzz: Configure check for main function
04:19 < bitcoin-git> bitcoin/master b337bd7 MarcoFalke: Merge #20065: fuzz: Configure check for main function
04:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:19 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20065: fuzz: Configure check for main function (master...2010-fuzzMainConfig) https://github.com/bitcoin/bitcoin/pull/20065
04:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:20 < bitcoin-git> [bitcoin] jnewbery opened pull request #20105: [net] Remove CombinerAll (master...2020-10-remove-combiner-all) https://github.com/bitcoin/bitcoin/pull/20105
04:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:20 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:f8fb:8430:4239:6d45] has joined #bitcoin-core-dev
04:20 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:f8fb:8430:4239:6d45] has quit [Remote host closed the connection]
04:20 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:f8fb:8430:4239:6d45] has joined #bitcoin-core-dev
04:21 -!- promag [~promag@188.251.225.32] has joined #bitcoin-core-dev
04:25 -!- S3RK [~s3rk@47.246.66.115] has quit [Remote host closed the connection]
04:26 -!- promag [~promag@188.251.225.32] has quit [Remote host closed the connection]
04:26 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:f8fb:8430:4239:6d45] has quit [Ping timeout: 272 seconds]
04:31 -!- roconnor [~roconnor@host-45-78-225-249.dyn.295.ca] has joined #bitcoin-core-dev
04:35 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 260 seconds]
04:43 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Remote host closed the connection]
04:44 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev
04:54 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
04:55 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:f8fb:8430:4239:6d45] has joined #bitcoin-core-dev
04:58 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 260 seconds]
05:00 -!- sirkitree [~sirkitree@185.204.1.185] has quit []
05:00 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:f8fb:8430:4239:6d45] has quit [Ping timeout: 272 seconds]
05:21 -!- dr-orlovsky [~dr-orlovs@31.14.40.19] has joined #bitcoin-core-dev
05:22 -!- Lthere [~Lthere@185.244.214.216] has joined #bitcoin-core-dev
05:23 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Remote host closed the connection]
05:25 < hebasto> for those who could be interested in Qt code -- https://github.com/users/hebasto/projects/1
05:26 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection]
05:26 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev
05:27 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:f8fb:8430:4239:6d45] has joined #bitcoin-core-dev
05:32 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:f8fb:8430:4239:6d45] has quit [Ping timeout: 272 seconds]
05:41 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
05:45 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Ping timeout: 264 seconds]
05:50 -!- Elenor20Ziemann [~Elenor20Z@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 256 seconds]
05:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:54 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20106: cirrus: Use kvm to avoid spurious CI failures in the default virtualization cluster (master...2010-ciOtherVirt) https://github.com/bitcoin/bitcoin/pull/20106
05:54 -!- sr_gi [~sr_gi@static-128-69-224-77.ipcom.comunitel.net] has quit [Read error: Connection reset by peer]
05:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:54 -!- sr_gi [~sr_gi@static-128-69-224-77.ipcom.comunitel.net] has joined #bitcoin-core-dev
05:57 -!- tralfaz is now known as davterra
06:00 -!- kallewoof_ [~quassel@240d:1a:759:6000:a7b1:451a:8874:e1ac] has left #bitcoin-core-dev []
06:00 -!- kallewoof [~quassel@240d:1a:759:6000:a7b1:451a:8874:e1ac] has joined #bitcoin-core-dev
06:02 < sdaftuar> rt
06:03  * sdaftuar notes that could have been worse
06:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:08 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b337bd7bc087...392c6f4fb253
06:08 < bitcoin-git> bitcoin/master 907f142 Andrew Chow: rpc: change no wallet loaded message to be clearer
06:09 < bitcoin-git> bitcoin/master 392c6f4 MarcoFalke: Merge #20101: rpc: change no wallet loaded message to be clearer
06:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:09 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20101: rpc: change no wallet loaded message to be clearer (master...better-no-wallet-error) https://github.com/bitcoin/bitcoin/pull/20101
06:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:12 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20107: doc: Collect release-notes snippets (master...2010-docRelSnip) https://github.com/bitcoin/bitcoin/pull/20107
06:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:22 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 240 seconds]
06:35 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
06:43 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev
06:45 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:f8fb:8430:4239:6d45] has joined #bitcoin-core-dev
06:46 -!- andreaca_ [~andreacab@2a02:120b:2c22:e0c0:8df2:6a95:b84d:63af] has joined #bitcoin-core-dev
06:47 -!- roconnor [~roconnor@host-45-78-225-249.dyn.295.ca] has quit [Read error: Connection reset by peer]
06:50 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:f8fb:8430:4239:6d45] has quit [Ping timeout: 260 seconds]
06:54 -!- kexkey [~kexkey@37.120.205.214] has joined #bitcoin-core-dev
06:55 -!- andreaca_ [~andreacab@2a02:120b:2c22:e0c0:8df2:6a95:b84d:63af] has quit [Remote host closed the connection]
06:56 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:8df2:6a95:b84d:63af] has joined #bitcoin-core-dev
07:00 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:8df2:6a95:b84d:63af] has quit [Ping timeout: 240 seconds]
07:09 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Ping timeout: 240 seconds]
07:11 -!- dr-orlovsky [~dr-orlovs@31.14.40.19] has quit [Ping timeout: 240 seconds]
07:12 -!- dr-orlovsky [~dr-orlovs@31.14.40.19] has joined #bitcoin-core-dev
07:30 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
07:32 -!- proofofkeags [~proofofke@174-29-30-112.hlrn.qwest.net] has joined #bitcoin-core-dev
07:34 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 240 seconds]
07:44 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has quit [Ping timeout: 240 seconds]
07:45 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
07:46 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has joined #bitcoin-core-dev
08:00 -!- Lthere [~Lthere@185.244.214.216] has quit []
08:22 -!- zacts [~zacts@141.98.102.187] has joined #bitcoin-core-dev
08:22 -!- zacts is now known as Guest4550
08:35 -!- proofofkeags [~proofofke@174-29-30-112.hlrn.qwest.net] has quit [Ping timeout: 240 seconds]
08:36 < dongcarl> vasild, sipa: I might be misremembering, but I recall having a discussion about the versionspace of serializers/unserializers and how we should separate them for different types?
08:38 < dongcarl> Oh I see that's still being worked on in #19503
08:38 < gribble> https://github.com/bitcoin/bitcoin/issues/19503 | Add parameter feature to serialization and use it for CAddress by sipa · Pull Request #19503 · bitcoin/bitcoin · GitHub
08:41 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
08:44 < vasild> yeah
08:50 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Read error: Connection reset by peer]
08:50 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
08:52 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev
08:53 < sipa> dongcarl: yeah, but i didn't want to hold up torv3 stuff with that
08:53 < sipa> so i hacen't pushed for it further
08:54 < dongcarl> Makes sense!
08:57 -!- palazzovincenzo [~vincent@37.162.86.245] has joined #bitcoin-core-dev
08:57 -!- palazzovincenzo [~vincent@37.162.86.245] has quit [Remote host closed the connection]
09:00 -!- vincenzopalazzo [~vincent@mob-109-119-44-160.net.vodafone.it] has quit [Ping timeout: 272 seconds]
09:00 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:3143:93cd:ba85:1e23] has joined #bitcoin-core-dev
09:03 -!- proofofkeags [~proofofke@c-73-34-43-4.hsd1.co.comcast.net] has joined #bitcoin-core-dev
09:05 -!- proofofkeags [~proofofke@c-73-34-43-4.hsd1.co.comcast.net] has quit [Remote host closed the connection]
09:09 -!- vincenzopalazzo [~vincent@37.162.86.245] has joined #bitcoin-core-dev
09:13 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:3143:93cd:ba85:1e23] has quit [Remote host closed the connection]
09:13 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:3143:93cd:ba85:1e23] has joined #bitcoin-core-dev
09:18 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:3143:93cd:ba85:1e23] has quit [Ping timeout: 260 seconds]
09:18 -!- Guest4550 [~zacts@141.98.102.187] has quit [Ping timeout: 240 seconds]
09:26 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
09:33 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-gpqibzfoiyliswbi] has joined #bitcoin-core-dev
09:37 -!- Ga1aCt1Cz00_ [~Ga1aCt1Cz@2a02:810a:8d40:5ebc:bd8d:573:437a:2d32] has joined #bitcoin-core-dev
09:41 -!- Ga1aCt1Cz00 [~Ga1aCt1Cz@2a02:810a:8d40:5ebc:cc6a:ab86:a44a:da6f] has quit [Ping timeout: 272 seconds]
09:58 -!- hari1 [~hari@195.206.169.184] has joined #bitcoin-core-dev
10:07 < wumpus> #19503 and TorV3 would be an interesting combination, but yes I don't think they should hold up each other
10:07 < gribble> https://github.com/bitcoin/bitcoin/issues/19503 | Add parameter feature to serialization and use it for CAddress by sipa · Pull Request #19503 · bitcoin/bitcoin · GitHub
10:33 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev
10:49 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:3143:93cd:ba85:1e23] has joined #bitcoin-core-dev
11:00 -!- hari1 [~hari@195.206.169.184] has quit []
11:22 -!- variable [~variable@185.244.214.216] has joined #bitcoin-core-dev
11:22 -!- variable is now known as Guest36719
11:33 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:3143:93cd:ba85:1e23] has quit [Remote host closed the connection]
11:33 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:3143:93cd:ba85:1e23] has joined #bitcoin-core-dev
11:38 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:3143:93cd:ba85:1e23] has quit [Ping timeout: 260 seconds]
11:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:42 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/392c6f4fb253...d9de00b3e067
11:42 < bitcoin-git> bitcoin/master 1afcd41 John Newbery: [net] Remove CombinerAll
11:42 < bitcoin-git> bitcoin/master d9de00b Wladimir J. van der Laan: Merge #20105: [net] Remove CombinerAll
11:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:43 < bitcoin-git> [bitcoin] laanwj merged pull request #20105: [net] Remove CombinerAll (master...2020-10-remove-combiner-all) https://github.com/bitcoin/bitcoin/pull/20105
11:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:45 -!- vincenzopalazzo [~vincent@37.162.86.245] has quit [Quit: Leaving]
11:57 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
11:58 -!- jonasschnelli [~jonasschn@2a01:4f9:2a:2510::2] has quit [Changing host]
11:58 -!- jonasschnelli [~jonasschn@unaffiliated/jonasschnelli] has joined #bitcoin-core-dev
12:01 < aj> meeting?
12:01 < jnewbery> e
12:02 < sipa> hi
12:02 < jonasschnelli> hi
12:02 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 272 seconds]
12:02 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:3143:93cd:ba85:1e23] has joined #bitcoin-core-dev
12:02 < wumpus> #startmeeting
12:02 < lightningbot> Meeting started Thu Oct  8 19:02:35 2020 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
12:02 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
12:02 < jnewbery> hi
12:02 < hebasto> hi
12:02 < aj> hiiii
12:02 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james
12:02 < wumpus> amiti fjahr jeremyrubin lightlike emilengler jonatack hebasto jb55 elichai2
12:03 < meshcollider> hi
12:03 < jonatack> ciao
12:03 < luke-jr> hi
12:04 < wumpus> FWIW: the 0.21 feature freeze is in a week, it probably makes more sense to discuss what is tagged for the 0.21 milestone as high priority for review at this point
12:04 < wumpus> this is https://github.com/bitcoin/bitcoin/milestone/45
12:06 < sipa> that's a long list
12:06 < wumpus> it looks like no other topics have been proposed for this week
12:06 < jonasschnelli> How is the merge back of the GUI repository handled? MarcoFalke?
12:06 < wumpus> yes, it's also likely outdated
12:06 < jonasschnelli> (Regarding freeze)
12:06 < wumpus> which makes it good to go over it I suppose
12:06 < vasild> hi
12:07 < wumpus> and at least two of the issues are simply 'follow release process'
12:07 < sipa> i think #19954 is pretty much done
12:07 < gribble> https://github.com/bitcoin/bitcoin/issues/19954 | tor: complete the TORv3 implementation by vasild · Pull Request #19954 · bitcoin/bitcoin · GitHub
12:07 < wumpus> yes
12:08 < hebasto> #18077 and #18710 could be moved to 0.22
12:08 < gribble> https://github.com/bitcoin/bitcoin/issues/18077 | net: Add NAT-PMP port forwarding support by hebasto · Pull Request #18077 · bitcoin/bitcoin · GitHub
12:08 < gribble> https://github.com/bitcoin/bitcoin/issues/18710 | Add local thread pool to CCheckQueue by hebasto · Pull Request #18710 · bitcoin/bitcoin · GitHub
12:08 < wumpus> hebasto: ok, thanks
12:08 < aj> #19543 doesn't have an associated PR yet?
12:08 < gribble> https://github.com/bitcoin/bitcoin/issues/19543 | Normalize fee units for RPC ("BTC/kB" and "sat/B) · Issue #19543 · bitcoin/bitcoin · GitHub
12:08 < nehan> 5
12:09 < nehan> (typo)
12:09 < jonatack> i've been focusing on #19953 the past day or so as it seems to be the highest priority along with tor v3
12:09 < gribble> https://github.com/bitcoin/bitcoin/issues/19953 | Implement BIP 340-342 validation (Schnorr/taproot/tapscript) by sipa · Pull Request #19953 · bitcoin/bitcoin · GitHub
12:09 < jonatack> aj: i planned to do #19543 after FF as it's a bugfix
12:09 < gribble> https://github.com/bitcoin/bitcoin/issues/19543 | Normalize fee units for RPC ("BTC/kB" and "sat/B) · Issue #19543 · bitcoin/bitcoin · GitHub
12:09 < hebasto> two drafts also could be moved?
12:09 < sipa> all todos are done for taproot, including the json tests in the qa-assets repo
12:09 < wumpus> jonatack: so that one needs 0.21 milestone?
12:10 < wumpus> aj: seems like it, but also seems not urgent for 0.21?
12:11 < wumpus> aj: oh "This needs to happen before the next major release. Otherwise, it will be a breaking change."
12:11 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection]
12:11 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
12:11 < aj> wumpus: yeah
12:11 < wumpus> ping MarcoFalke
12:11 -!- vasild_ is now known as vasild
12:11 < sipa> wumpus: i'd very much like to get taproot in 0.21, as the alternative (i expect) is that we'll want it early in 0.22 anyway, which will just complicate backports
12:11 < sipa> (the code, not activation obviously)
12:12 < wumpus> hebasto: done
12:12 < wumpus> sipa: agree!
12:12 < jonatack> +1
12:13 < meshcollider> I feel like we should really push for #19077 if possible just to have it in the same version as descriptor wallets like we discussed
12:14 < gribble> https://github.com/bitcoin/bitcoin/issues/19077 | wallet: Add sqlite as an alternative wallet database and use it for new descriptor wallets by achow101 · Pull Request #19077 · bitcoin/bitcoin · GitHub
12:14 < meshcollider> But it's a big PR 
12:14 < sipa> i haven't paid attention to the PR itself, but it seems it's been making lots of progress lately, including review
12:14 < meshcollider> Yeah it's had a decent amount of review already so it's not infeasible
12:15 < sipa> i know wumpus had reservations about having it in 0.21
12:15 < wumpus> looks like we're starting to run into issues building bdb 4.8 on some platforms at least: #19411
12:15 < gribble> https://github.com/bitcoin/bitcoin/issues/19411 | Unable to build BDB 4.8 on macOS Big Sur beta or Xcode 12.0 · Issue #19411 · bitcoin/bitcoin · GitHub
12:16 < wumpus> sipa: yes, it seems fairly risky to introduce a new wallet database format (which is used by default) in something last minute
12:16 < sipa> --with-incompatible-bdb lalala
12:16 < achow101> wumpus: it's only used by descriptor wallets which we already have marked as "experimental"
12:16 < wumpus> achow101: they're not created by default for new users?
12:16 < achow101> no
12:16 < wumpus> in that case I"m oay with it
12:17 < sipa> ah, descriptor wallets are not default for new wallets?
12:17 < achow101> not yet
12:17 < sipa> that's perhaps the best of both worlds... get descriptor wallets and sqlite in 0.21, but neither is default
12:17 < wumpus> if it's opt-in I see no problem 
12:18 < achow101> if descriptor wallets were the default, a lot of tests would be failing :p
12:20 < wumpus> wrt #20005 I'm not convinced we should do anything for it, the particular issue doesn't affect anything in our project and clearly in the longer run it's better left solved upstream
12:20 < gribble> https://github.com/bitcoin/bitcoin/issues/20005 | memcmp with constants that contain zero bytes are broken in GCC · Issue #20005 · bitcoin/bitcoin · GitHub
12:21 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
12:21 < sipa> agree
12:22 < sipa> it's good to continue discussing the options, but i don't think there is urgency
12:22 < wumpus> sure, but removing the milestone then
12:22 < sipa> we're not using gcc 9 or gcc 10 for releases either, i believe?
12:23 < wumpus> no, 8 at most
12:23 < hebasto> 7.4 for linux x86_64
12:25 < wumpus> yes, correct
12:25 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
12:25 < wumpus> otherwise there's agreement what is on the milestone right now?
12:26 < sipa> not everything will make it, but sure
12:27 < sipa> i'm also hoping for 19988
12:27 < sipa> given the amount of review it's had the past days
12:27 < jnewbery> I think 19988 is ready. It has three or four recent ACKs now
12:28 < meshcollider> #19988
12:28 < gribble> https://github.com/bitcoin/bitcoin/issues/19988 | Overhaul transaction request logic by sipa · Pull Request #19988 · bitcoin/bitcoin · GitHub
12:29 < sipa> 50% test code :)
12:29 < wumpus> added to milestone anyway
12:29 < sipa> thanks!
12:30 < sipa> unrelated: i've noticed that sometimes clicking "show resolved" on github expands everything, and sometimes not
12:30 < sipa> does anyone else have this, or know how it's caused?
12:30 < achow101> #16463 could be removed from the milestone I guess
12:31 < gribble> https://github.com/bitcoin/bitcoin/issues/16463 | [BIP 174] Implement serialization support for GLOBAL_XPUB field. by achow101 · Pull Request #16463 · bitcoin/bitcoin · GitHub
12:31 < wumpus> ok done
12:32 < wumpus> any other topics for today?
12:33 < jnewbery> I have a question about c++17
12:33 < aj> wumpus: you pinged about moving https://github.com/users/ajtowns/projects/1 under bitcoin/ ; happy to, might be nice to move the automation into drahtbot at the same time
12:34 < jnewbery> we're planning to move to c++17 (remove c++11 compat) in v0.21: https://github.com/bitcoin/bitcoin/issues/16684
12:34 < wumpus> no, in 0.22 right?
12:34 < wumpus> 0.21 introduces c++17 compilation by default
12:34 < jnewbery> oops sorry, yes v0.22
12:34 < wumpus> 0.22 is c++17 only
12:34 < wumpus> okay
12:35 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:3143:93cd:ba85:1e23] has quit [Remote host closed the connection]
12:35 < jnewbery> so after v0.21 branch we're theoretically free to use c++17 features throughout the codebase
12:35 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 256 seconds]
12:35 < wumpus> yes
12:35 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:3143:93cd:ba85:1e23] has joined #bitcoin-core-dev
12:35 < jnewbery> My question was whether it makes sense to try to keep c++11 compatability for consensus code for longer
12:35 < wumpus> for new code definitely, as for c++11, please don't file PRs to convert all old code at once
12:35 < wumpus> for the sake of doing so
12:36 < wumpus> there's no *need* for any compatibility with c++11 anymore
12:36 < jnewbery> ie use c++17 features in net processing/wallet/etc, but try to keep consensus code on c++11 for longer
12:36 < jnewbery> given that apparently compilers have bugs it might make sense to be more conservative with upgrading to the latest features in consensus
12:37 < wumpus> I think that will make things really complicated, even defining what is 'consensus code' is pretty hard right now
12:37 < jnewbery> but it's just a half-baked thought
12:37 < jnewbery> wumpus: right. It'd be nice if that separation were clearer
12:37 < wumpus> or do you only mean 'what is part of libconsensus' 
12:38 < wumpus> dongcarl's libbitcoinkernel is a nice idea but it's only an idea right now
12:38 -!- Pavlenex1 [~Thunderbi@178.220.163.83] has joined #bitcoin-core-dev
12:38 < aj> libbitcoinkernel? no hits on google
12:38 < wumpus> yes, it'd be nice but definitely not around the corner, I don't think it's in any shape to make C++ version depend on it
12:39 < wumpus> agree with regard to bugs though
12:39 < sipa> almost all of C++17 is in GCC 7, and all of it is in GCC 8
12:39 < wumpus> everything is broken let' go shopping 
12:39 < sipa> so i'd agree as far as being conservative w.r.t. C++ features in consensus-critical code, but i don't think that's necessarily a new idea
12:39 < sipa> we always want to be conservative there
12:40 < sipa> i don't think we need a "this subset of the code must remain c++11 compatible" rule
12:40 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:3143:93cd:ba85:1e23] has quit [Ping timeout: 272 seconds]
12:40 < sipa> whether enforced or not
12:40 < wumpus> I really thin kwe should make one decision for the entire codebase
12:40 < sipa> agree
12:41 < wumpus> if the recent discovery means that new versions of C++ are unsafe, that means, let's just give up on C++17 for now
12:41 < sipa> i don't think so
12:41 < wumpus> I don't particularly want the P2P code to be unsafe either
12:41 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Ping timeout: 240 seconds]
12:41 -!- Pavlenex1 is now known as Pavlenex
12:41 < sipa> it's a bug in a C89 feature FFS
12:41 < jnewbery> sipa: does it make sense to codify what you mean by 'conservative w.r.t c++ features in consensus-critical code'?
12:41 < wumpus> we don't have suffiient separateion of consensus-critical code from anything
12:42 < wumpus> we need to have that, sure
12:42 < wumpus> but it's more than you'd expect if you include util and compat and other indirect dependencies
12:42 < sipa> jnewbery: yeah, i'm trying to think what that would mean
12:43 < sipa> it's just a thought
12:43 < wumpus> honestly I think this is completely seperate from the c++17 question
12:43 < sipa> yes, agree
12:43 < wumpus> yes, it would be good to isolate the consensus code
12:43 < wumpus> then again this was a project since, 2012 or so...
12:44 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
12:44 < wumpus> also: leveldb is part of consensus
12:44 < sipa> i think the question for C++17 or not just depends on whether we expect build environments that people will want to use for 0.22 support it sufficiently or not
12:45 < wumpus> it's not like you can build the consensus code separately anyway
12:45 < sipa> indeed
12:45 < sipa> we *could* say that libconsensus needs to remain C++11 buildable - but i don't think there is much of a reason for that
12:46 < wumpus> I don't think so either
12:46 < wumpus> c++17 is already three years old anyway and most c++ compilers implemented it, or features from it, before that
12:46 < wumpus> it's not that we're super fast in adopting new c++ standards
12:46 < sipa> so let's discuss this after 0.21 branch off, whether we think requiring a C++17 build environment will be a problem by the time 0.22 gets released
12:47 < sipa> indeed
12:47 < jnewbery> sipa: +1
12:47 < jonatack> to summarize, if I may: before feature freeze in one week, please review 19953 (BIPs 340-342), 19954 (tor v3), 19988 (tx relay logic), and 19077 (sqlite wallet)
12:47 < wumpus> seems deviating from our plan here on last minute does need a very good reason though
12:47 < jnewbery> I am interested in how we judge 'conservative w.r.t c++ features', but not necessarily now
12:48 < sipa> wumpus: yeah
12:48 < wumpus> I think we need to be conservative in making changes to the consensus code, not so much specifically regarding c++ features
12:48 < aj> jnewbery: i think that was just a subset of "conservative in general"
12:48 < wumpus> right
12:49 < wumpus> which was also my first reply, don't change code for c++17 for the sake of using c++17
12:49 < sipa> and perhaps avoid features that reviewers may not be very familiar with - which is correlated but not the same as recently-introduced language features
12:49 < wumpus> any other topics?
12:50 < sipa> jonatack: +1
12:51 -!- Pavlenex1 [~Thunderbi@178.220.163.83] has joined #bitcoin-core-dev
12:52 < wumpus> honestly I'd feel a lot better if we had focused on isolating the consensus-critical code a long time ago, seems like something people like to talk about but it never really panned out yet
12:52 < sipa> wumpus: it's... hard
12:52 -!- Pavlenex [~Thunderbi@178.220.163.83] has quit [Ping timeout: 240 seconds]
12:52 -!- Pavlenex1 is now known as Pavlenex
12:52 < wumpus> sipa: yes :/
12:52 < wumpus> jonatack: agree!
12:54 < jnewbery> wumpus: we're moving in that direction ... slowly. #20049 and #20050 are next
12:54 < wumpus> sipa: it's hard but maybe one of the things remaining that's really worth doing
12:54 < gribble> https://github.com/bitcoin/bitcoin/issues/20049 | De-globalizing ChainstateManager · Issue #20049 · bitcoin/bitcoin · GitHub
12:54 < gribble> https://github.com/bitcoin/bitcoin/issues/20050 | validation: Prune (in)direct g_chainman usage related to ::LookupBlockIndex (bundle 1) by dongcarl · Pull Request #20050 · bitcoin/bitcoin · GitHub
12:54 < wumpus> jnewbery: I guess the main problem is that isolating the consensus code means changes to the consensus code which is a risk in itself so hard to do
12:55 < wumpus> jnewbery: but good to know!
12:55 < aj> wumpus: also that we want to switch between non-consensus and consensus code efficiently in lots of places
12:56 < sipa> yes, and given previous attempts at refactoring out consensus code ended us more than once is a worse half-baked state, it's harder to get reviewer enthousiasm for such changes
12:56 < wumpus> aj: yes defining an interface that makes sens in itself but doesn't make things a lot slower is another thing
12:57 < dongcarl> Definitely non-zero risks, which is why the focus should be on doing it incrementally, and testing it continuously :-)
12:57 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection]
12:57 < wumpus> definitely more interestedi n it than discussions about the icon color though :-)
12:57 < dongcarl> Hehe
12:57 < sipa> haha
12:57 < jonatack> hehe
12:57 < sipa> it is as BIP42 predicted
12:58 < sipa> "Prominent among them is the discussion on what to call 1 billion Bitcoin, which symbol color to use for it, and when wallet clients should switch to it by default. "
12:58 < wumpus> heh!
12:59 < wumpus> #endmeeting
12:59 < lightningbot> Meeting ended Thu Oct  8 19:59:20 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
12:59 < lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-10-08-19.02.html
12:59 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-10-08-19.02.txt
12:59 < lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-10-08-19.02.log.html
12:59 < achow101> time to add "prophet" to sipa's resume
13:02 < sipa> aj: fwiw, 19988 now has "time going backwards" unit tests
13:16 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
13:22 -!- filchef [~filchef@212.104.97.177] has quit [Quit: KVIrc 5.0.0 Aria http://www.kvirc.net/]
13:39 < vasild> CAddress::unser: time=1601829922, services=134218813, addr=62.107.200.30:8333
13:39 < vasild> CAddress::unser: time=1600339981, services=134217741, addr=akinbo7tlegsnsxn.onion:8333
13:40 < vasild> jonatack: wumpus: so...
13:41 < vasild> in the network there are some peers with services=unusually high value
13:42 < sipa> that's 0x0800000d
13:42 < vasild> they get in via p2p gossip into addrman without causing problems
13:42 < vasild> sipa: right
13:43 < vasild> using addrv1
13:44 < vasild> then addrman saves it on disk just fine in V3_BIP155 format using READWRITE(COMPACTSIZE(services_tmp))
13:44 < vasild> however, on read back from disk it bricks because ReadCompactSize() contains this at the end:
13:44 < vasild>     if (nSizeRet > (uint64_t)MAX_SIZE)
13:44 < vasild>         throw std::ios_base::failure("ReadCompactSize(): size too large");
13:45 < vasild> and MAX_SIZE is quite low value 0x02000000
13:45 < vasild> I wondered before wtf is that limit but decided it is harmless
13:46 < sipa> vasild: ehhhh
13:46 < sipa> this means we need to bypass that limit when deserializing addrv2
13:46 < vasild> so WriteCompactSize() can write >0x02000000 but ReadCompactSize() cannot read it back :-X
13:46 -!- balbirs [~balbirs__@bilbo.ozlabs.org] has quit [Quit: ZNC 1.7.5+deb1 - https://znc.in]
13:47 -!- balbirs [~balbirs__@ozlabs.org] has joined #bitcoin-core-dev
13:47 < sipa> vasild: it's a protection for the case where CompactSize format is used to actually encode a size
13:47 < sipa> and not just a number
13:48 < sipa> add a bool to ReadCompactSize to determine whether the limit is enforced or not?
13:49 < sipa> i guess we overlooked that in bip152, where it's also not used as a size, but restricted to pretty small numbers
13:49 < sipa> let me know if you need help with serialization framework stuff
13:50 < pinheadmz> where can i find the current version of bitcoin core in the source code? wihtout using git
13:50 < sipa> clientversion.h
13:51 < pinheadmz> (sorry meant for pr-reviews-club) thanks sipa
13:51 < vasild> hmm
13:51 < sipa> ah, it's in config/bitcoin-config.h now
13:52 < sipa> which may be generated by somwthing else still
13:52 < sipa> version numbers are aoways a mess, due to attempts to aboid having it in dozens of places
13:52 < pinheadmz> yeah thats why i expected there to be one source of truth that gets copioed arond
13:53 < sipa> it's in configure.ac i think
13:53 < sipa> top of the file
13:53 < pinheadmz> aha yes, this is what im looking for gracias
13:53 < vasild> sipa: how would we pass a bool parameter to ReadCompactSize() from               READWRITE(COMPACTSIZE(services_tmp));
13:54 < sipa> vasild: you can add template parameters to the compactsize wrapper
13:54 < vasild> inroduce READWRITE(COMPACTSIZE_UNBOUNDED(services_tmp))
13:54 < vasild> ?
13:54 < sipa> i can do that also
13:54 < sipa> though i'll be busy the next hour or so
13:55 < vasild> I am too sleepy, going to bed now, glad I nailed this down
13:55 < vasild> (the problem, not the solution)
13:56  * vasild bb in 9-10h
13:56 < jonatack> vasild: nice! sleepy here too, but it looks like that would explain what we are seeing. back on it tomorrow -- goodnight!
13:56 < vasild> jonatack: yeah, your disk is not corrupted! :-)
13:56 < sipa> vasild: what timezone are you in?
13:57 < vasild> UTC+2, it is 22:57 here
13:57 < jonatack> i suspect it's 2300
13:57 < vasild> sipa: you?
13:58 < sipa> vasild: UTC-7
13:58 < vasild> almost on the other side of the world :)
13:58 < sipa> lots of october 8th left for me
13:58 < jonatack> oh not in nyc then
13:58 < sipa> jonatack: not yet
14:00 -!- Guest36719 [~variable@185.244.214.216] has quit []
14:00  * vasild zZzZ
14:14 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds]
14:16 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
14:20 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection]
14:20 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
14:22 -!- dorena [~dorena@178.239.168.171] has joined #bitcoin-core-dev
14:22 -!- proofofkeags [~proofofke@c-73-34-43-4.hsd1.co.comcast.net] has joined #bitcoin-core-dev
14:23 -!- proofofkeags_ [~proofofke@c-73-34-43-4.hsd1.co.comcast.net] has joined #bitcoin-core-dev
14:23 -!- Pavlenex [~Thunderbi@178.220.163.83] has quit [Quit: Pavlenex]
14:25 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection]
14:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:26 < bitcoin-git> [bitcoin] glozow opened pull request #20109: Release notes and followups from 19339 (master...docs-absurdfee) https://github.com/bitcoin/bitcoin/pull/20109
14:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:26 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
14:27 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection]
14:28 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev
14:44 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
14:45 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection]
14:46 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
14:49 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection]
14:49 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
14:50 -!- worc3131 [~quassel@2a02:c7f:c026:9500:7d0b:65d0:38a4:4786] has joined #bitcoin-core-dev
14:58 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection]
14:59 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
15:06 -!- worc3131 [~quassel@2a02:c7f:c026:9500:7d0b:65d0:38a4:4786] has quit [Ping timeout: 272 seconds]
15:11 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
15:11 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection]
15:11 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
15:11 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
15:14 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection]
15:15 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
15:22 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection]
15:23 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
15:26 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection]
15:26 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
15:30 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has quit [Remote host closed the connection]
15:31 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has joined #bitcoin-core-dev
15:34 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection]
15:34 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
15:59 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
16:03 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 240 seconds]
16:04 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection]
16:04 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
16:09 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has quit [Remote host closed the connection]
16:10 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-dev
16:24 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection]
16:24 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection]
16:52 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
16:55 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds]
17:00 -!- dorena [~dorena@178.239.168.171] has quit []
17:00 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
17:05 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
17:10 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev
17:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
17:18 -!- diogorsergio [~diogorser@94.1.122.189] has quit [Ping timeout: 246 seconds]
17:18 -!- proofofkeags_ [~proofofke@c-73-34-43-4.hsd1.co.comcast.net] has quit [Ping timeout: 265 seconds]
17:18 -!- proofofkeags [~proofofke@c-73-34-43-4.hsd1.co.comcast.net] has quit [Ping timeout: 265 seconds]
17:21 -!- Wolfy87 [~Wolfy87@s91904426.blix.com] has joined #bitcoin-core-dev
17:21 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
17:24 -!- bjkkkk [2bfed90f@43.254.217.15] has joined #bitcoin-core-dev
17:25 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 272 seconds]
17:27 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has quit [Ping timeout: 264 seconds]
17:28 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has joined #bitcoin-core-dev
17:40 -!- placa [~placa@CableLink-187-160-61-247.PCs.InterCable.net] has joined #bitcoin-core-dev
17:44 -!- bjkkkk [2bfed90f@43.254.217.15] has quit [Ping timeout: 245 seconds]
17:46 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
17:53 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
17:58 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]
18:01 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 246 seconds]
18:05 -!- diogorsergio [~diogorser@94.6.169.41] has joined #bitcoin-core-dev
18:11 -!- nick108 [def0392c@222.240.57.44] has joined #bitcoin-core-dev
18:23 -!- nick108 [def0392c@222.240.57.44] has quit [Ping timeout: 245 seconds]
18:25 -!- sr_gi [~sr_gi@static-128-69-224-77.ipcom.comunitel.net] has quit [Read error: Connection reset by peer]
18:26 -!- sr_gi [~sr_gi@static-128-69-224-77.ipcom.comunitel.net] has joined #bitcoin-core-dev
18:26 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadmz]
18:33 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
18:53 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadmz]
18:59 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
19:07 -!- proofofkeags_ [~proofofke@174-29-30-112.hlrn.qwest.net] has joined #bitcoin-core-dev
19:07 -!- proofofkeags [~proofofke@174-29-30-112.hlrn.qwest.net] has joined #bitcoin-core-dev
19:09 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
19:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds]
19:21 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadmz]
19:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
19:47 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]
20:00 -!- Wolfy87 [~Wolfy87@s91904426.blix.com] has quit []
20:15 -!- proofofkeags_ [~proofofke@174-29-30-112.hlrn.qwest.net] has quit [Ping timeout: 260 seconds]
20:15 -!- proofofkeags [~proofofke@174-29-30-112.hlrn.qwest.net] has quit [Ping timeout: 260 seconds]
20:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
20:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]
20:21 -!- jpcw1 [~jpcw@195.206.169.184] has joined #bitcoin-core-dev
20:28 < sipa> vasild: https://github.com/sipa/bitcoin/commits/202010_compactsize_bound
20:28 < sipa> use with Using<CompactSizeFormatter<false>>(obj) instead of COMPACTSIZE(obj)
20:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
20:56 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 258 seconds]
21:17 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
21:20 -!- S3RK [~s3rk@47.246.66.115] has quit [Remote host closed the connection]
21:22 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
21:25 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
21:27 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 260 seconds]
21:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 272 seconds]
21:56 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
22:01 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
22:03 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
22:05 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds]
22:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]
22:30 -!- S3RK [~s3rk@47.246.66.115] has quit [Remote host closed the connection]
22:33 < hebasto> sipa: re "it's a protection for the case where CompactSize format is used to actually encode a size" in which cases? (`MAX_SIZE = 0x02000000` seems undocumented in the code)
22:38 < hebasto> it was added with alert system in 401926283a200994ecd7df8eae8ced8e0b067c46
22:39 < hebasto> right?
22:42 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
22:42 < hebasto> as alert system has been removed could we just revert back s/MAX_SIZE/INT_MAX/ ?
22:44 -!- placa [~placa@CableLink-187-160-61-247.PCs.InterCable.net] has quit [Read error: Connection reset by peer]
22:47 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 272 seconds]
22:55 < sipa> hebasto: most satoshi commits were aggregates of a bunch of unrelated things
22:55 < sipa> MAX_SIZE is the maximum size of serialized objects, 32 MiB
22:56 < hebasto> I see. Thanks!
23:00 -!- jpcw1 [~jpcw@195.206.169.184] has quit []
23:00 < hebasto> sipa: do you think that `TxRequestTracker::CountCandidates` is really required to be a part of `TxRequestTracker` public interface?
23:02 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Ping timeout: 240 seconds]
23:03 < sipa> hebasto: it makes testing easier
23:03 < sipa> but apart from that, it's unneeded - for now at least
23:03 < sipa> it could be used as part of an overload check later
23:11 -!- brianhoffman [~brianhoff@pool-71-191-34-154.washdc.fios.verizon.net] has quit [Read error: Connection reset by peer]
23:11 -!- brianhoffman_ [~brianhoff@pool-71-191-34-154.washdc.fios.verizon.net] has joined #bitcoin-core-dev
23:19 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
23:22 -!- BartK [~BartK@195.140.213.38] has joined #bitcoin-core-dev
23:24 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds]
23:40 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
23:43 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds]
23:44 -!- andreacab [~andreacab@12.46.194.178.dynamic.wline.res.cust.swisscom.ch] has joined #bitcoin-core-dev
23:44 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
23:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:46 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d9de00b3e067...380705ef4f00
23:46 < bitcoin-git> bitcoin/master faf2999 MarcoFalke: cirrus: Use kvm to avoid spurious CI failures in the default virtualizatio...
23:46 < bitcoin-git> bitcoin/master 380705e MarcoFalke: Merge #20106: cirrus: Use kvm to avoid spurious CI failures in the default...
23:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:46 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20106: cirrus: Use kvm to avoid spurious CI failures in the default virtualization cluster (master...2010-ciOtherVirt) https://github.com/bitcoin/bitcoin/pull/20106
23:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:57 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
23:59 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 272 seconds]
--- Log closed Fri Oct 09 00:00:41 2020