--- Log opened Sun Oct 11 00:00:43 2020
00:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:18 < bitcoin-git> [bitcoin] sipa opened pull request #20119: BIP155 follow-ups (master...202010_bip155_followup) https://github.com/bitcoin/bitcoin/pull/20119
00:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:32 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
00:36 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Client Quit]
00:37 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
00:39 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
00:40 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Client Quit]
00:43 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 240 seconds]
01:28 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
01:32 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:3c52:adcb:2c3f:e71a] has joined #bitcoin-core-dev
01:36 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:3c52:adcb:2c3f:e71a] has quit [Remote host closed the connection]
01:36 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev
01:36 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:3c52:adcb:2c3f:e71a] has joined #bitcoin-core-dev
01:40 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:3c52:adcb:2c3f:e71a] has quit [Ping timeout: 240 seconds]
01:42 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex]
02:00 -!- simonbusborg [~simonbusb@84.39.117.57] has quit []
02:01 -!- jonatack [~jon@185.206.225.51] has quit [Ping timeout: 260 seconds]
02:06 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
02:21 -!- NotASpy1 [~NotASpy@178.162.204.214] has joined #bitcoin-core-dev
02:31 -!- shesek [~shesek@164.90.217.137] has joined #bitcoin-core-dev
02:31 -!- shesek [~shesek@164.90.217.137] has quit [Changing host]
02:31 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
02:49 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
02:50 -!- jonatack [~jon@37.166.231.206] has joined #bitcoin-core-dev
02:52 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
02:56 -!- jonatack [~jon@37.166.231.206] has quit [Read error: Connection reset by peer]
02:57 -!- jonatack [~jon@185.206.225.51] has joined #bitcoin-core-dev
03:00 -!- jonatack [~jon@185.206.225.51] has quit [Read error: Connection reset by peer]
03:03 -!- jonatack [~jon@37.166.231.206] has joined #bitcoin-core-dev
03:08 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
03:08 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
03:11 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
03:11 -!- solitonmedic [~tougou@cpe-68-174-133-242.nyc.res.rr.com] has quit [Remote host closed the connection]
03:12 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
03:18 -!- Koby15Considine [~Koby15Con@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev
03:23 -!- Koby15Considine [~Koby15Con@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 256 seconds]
03:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:42 < bitcoin-git> [bitcoin] jonatack opened pull request #20120: rpc, bugfix: filter networks with empty names from getnetworkinfo (master...fix-getnetworkinfo-empty-networks) https://github.com/bitcoin/bitcoin/pull/20120
03:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:59 -!- ares_ [~ares@gateway/tor-sasl/virtu] has quit [Remote host closed the connection]
03:59 -!- ares_ [~ares@gateway/tor-sasl/virtu] has joined #bitcoin-core-dev
04:05 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
04:35 < michaelfolkson> Any way of resurrecting the part of #5872 you need luke-jr? Looks like #9946 (merged) attempted to address same issue
04:35 < gribble> https://github.com/bitcoin/bitcoin/issues/5872 | configure: BITCOIN_SUBDIR_TO_INCLUDE: Improve compatibility with paths including space and multiline cpp output by luke-jr · Pull Request #5872 · bitcoin/bitcoin · GitHub
04:35 < gribble> https://github.com/bitcoin/bitcoin/issues/9946 | Fix build errors if spaces in path or parent directory by pinheadmz · Pull Request #9946 · bitcoin/bitcoin · GitHub
04:36 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev
04:40 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Ping timeout: 240 seconds]
04:42 -!- jonatack [~jon@37.166.231.206] has quit [Ping timeout: 258 seconds]
04:48 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
04:53 -!- pinheadm_ [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
04:54 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Read error: Connection reset by peer]
04:56 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 240 seconds]
04:58 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
05:00 -!- NotASpy1 [~NotASpy@178.162.204.214] has quit []
05:03 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 265 seconds]
05:03 < dburkett> https://en.bitcoin.it/wiki/Bitcoin_Core_0.11_(ch_1):_Overview is such an excellent overview of the node design. Is anyone aware of a similar such overview for the wallet code?
05:22 -!- alct [~alct@217.146.82.202] has joined #bitcoin-core-dev
05:22 -!- gleb [~gleb@178.150.137.228] has quit [Ping timeout: 265 seconds]
05:29 -!- pinheadm_ [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadm_]
05:46 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
05:49 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
06:00 < michaelfolkson> John Newbery did a presentation at Chaincode Labs https://www.youtube.com/watch?v=j0V8elTzYAA
06:01 < michaelfolkson> Alternatively there are Bitcoin Core PR review club sessions on the wallet (scroll down to wallet) https://bitcoincore.reviews/meetings-components/
06:03 < michaelfolkson> Or this on the dev wiki https://github.com/bitcoin-core/bitcoin-devwiki/wiki/Wallet-Class-Structure-Changes
06:07 -!- filchef [~filchef@212.104.97.177] has quit [Quit: KVIrc 5.0.0 Aria http://www.kvirc.net/]
06:30 -!- alct [~alct@217.146.82.202] has quit [Remote host closed the connection]
06:32 -!- jonatack [~jon@109.232.227.138] has joined #bitcoin-core-dev
06:36 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds]
06:42 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
06:58 -!- cltrbreak_MAD2 [~ctrlbreak@159.2.182.106] has joined #bitcoin-core-dev
07:00 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has joined #bitcoin-core-dev
07:00 -!- mjevans- [~mjevans-@84.39.117.57] has joined #bitcoin-core-dev
07:08 < luke-jr> michaelfolkson: 9946 looks completely unrelated; 5872 is still a clean merge
07:26 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
07:32 -!- shaunsun [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has joined #bitcoin-core-dev
07:37 -!- Netsplit *.net <-> *.split quits: sethrogers23[m], snowkeld[m], icota[m]
07:37 -!- Netsplit over, joins: sethrogers23[m], icota[m], snowkeld[m]
07:37 < michaelfolkson> Hmm appears so. 9946 referred to your 5872 to address Issue 9933
07:37  * michaelfolkson shrugs
07:38 -!- Netsplit *.net <-> *.split quits: RaphalBentgeac[m, _flow_, moneyball__, jamesob, midnight
07:39 -!- Netsplit over, joins: midnight, moneyball__, _flow_, jamesob, RaphalBentgeac[m
07:40 -!- sethrogers23[m] [sethrogers@gateway/shell/matrix.org/x-zkkubkjpeviadhrg] has quit [Ping timeout: 244 seconds]
07:40 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-oeomhefeyifncioi] has quit [Ping timeout: 244 seconds]
07:40 -!- RaphalBentgeac[m [raphaelben@gateway/shell/matrix.org/x-vqhhqrhyrgetyuqc] has quit [Ping timeout: 244 seconds]
07:40 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 245 seconds]
07:41 -!- awesome_doge1 [awesome-do@gateway/shell/matrix.org/x-jcmhapuepomzeyee] has quit [Ping timeout: 260 seconds]
07:42 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection]
07:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:42 < bitcoin-git> [bitcoin] luke-jr opened pull request #20121: configure: Allow users to explicitly enable libsecp256k1's GMP bignum support (master...secp256k1_allow_bignum) https://github.com/bitcoin/bitcoin/pull/20121
07:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:43 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
07:46 -!- sethrogers23[m] [sethrogers@gateway/shell/matrix.org/x-dkxyrsvqfxhgiodv] has joined #bitcoin-core-dev
07:47 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
07:47 < luke-jr> michaelfolkson: afaict, it's simply because 5872 fixed a (completely different) issue with spaces in paths
07:47 -!- RaphalBentgeac[m [raphaelben@gateway/shell/matrix.org/x-ostnjjuhqfqioria] has joined #bitcoin-core-dev
07:52 -!- awesome_doge1 [awesome-do@gateway/shell/matrix.org/x-pcyqkrcbiarqvrlj] has joined #bitcoin-core-dev
07:52 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 272 seconds]
07:53 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-lwpewzcfbdxukyql] has joined #bitcoin-core-dev
08:00 -!- mjevans- [~mjevans-@84.39.117.57] has quit []
08:10 < pinheadmz> aw. 9946... one of my first contirbutions ever :-)
08:15 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
08:22 -!- reeiiko [~reeiiko@185.163.110.116] has joined #bitcoin-core-dev
08:26 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
08:28 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
08:31 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 256 seconds]
08:48 < michaelfolkson> Still causing problems in 2020 ;)
08:52 < luke-jr> eh?
08:55 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Ping timeout: 244 seconds]
08:57 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
08:58 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Read error: Connection reset by peer]
08:58 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
08:58 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
09:03 < michaelfolkson> Sorry, just a joke (ignore me)
09:03 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
09:08 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 256 seconds]
09:13 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
09:16 < sipa> luke-jr: fwiw, after secp256k1 PR 767 we'll probably remove bignum support entirely
09:16 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds]
09:24 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
09:24 -!- Guyver2__ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
09:24 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
09:26 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 264 seconds]
09:27 -!- proofofkeags_ [~proofofke@174-29-30-112.hlrn.qwest.net] has joined #bitcoin-core-dev
09:27 -!- proofofkeags [~proofofke@174-29-30-112.hlrn.qwest.net] has joined #bitcoin-core-dev
09:42 < luke-jr> sipa: why does that PR talk about ARM specifically? it looks generic?
09:44 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
09:47 < sipa> it is
09:47 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
09:48 < sipa> luke-jr: i think ARM benchmarking may appear disproportionally due to the fact that the author doesn'thave any nativd 32-bit hardware and had to ask others for numbers
10:00 < luke-jr> I see
10:14 -!- mdunnio_ [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
10:15 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex]
10:19 < dburkett> michaelfolkson: That presentation is exactly what I was looking for. Thanks!
10:24 -!- mdunnio_ [~mdunnio@208.59.170.5] has quit [Ping timeout: 260 seconds]
10:41 < michaelfolkson> No problem
10:46 < vasild> ariard: I think it is ok to just relay even if the receiver may end up ditching the address (not further gossip it)
10:53 -!- Ga1aCt1Cz00 [~Ga1aCt1Cz@2a02:810a:8d40:5ebc:5073:65d9:3f1c:1b0c] has joined #bitcoin-core-dev
10:55 -!- Ga1aCt1Cz00_ [~Ga1aCt1Cz@2a02:810a:8d40:5ebc:bd8d:573:437a:2d32] has quit [Ping timeout: 272 seconds]
11:00 -!- reeiiko [~reeiiko@185.163.110.116] has quit []
11:19 < wumpus> vasild: congrats on getting #19954 merged! 🎉
11:19 < gribble> https://github.com/bitcoin/bitcoin/issues/19954 | Complete the BIP155 implementation and upgrade to TORv3 by vasild · Pull Request #19954 · bitcoin/bitcoin · GitHub
11:21 < hebasto> wumpus: some tor-related stuff is waiting :) -- #19998 and #20002 
11:21 < gribble> https://github.com/bitcoin/bitcoin/issues/19998 | net: Add CNode::ConnectedThroughNetwork member function by hebasto · Pull Request #19998 · bitcoin/bitcoin · GitHub
11:21 < gribble> https://github.com/bitcoin/bitcoin/issues/20002 | net, rpc, cli: expose peer network in getpeerinfo; simplify/improve -netinfo by jonatack · Pull Request #20002 · bitcoin/bitcoin · GitHub
11:22 -!- beaups [~beaups@s91904426.blix.com] has joined #bitcoin-core-dev
11:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:43 < bitcoin-git> [bitcoin] practicalswift opened pull request #20122: Make Assert(…) usable in all contexts. Make implicit assumptions explicit. (master...Assert) https://github.com/bitcoin/bitcoin/pull/20122
11:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:11 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
12:11 -!- ja [janus@anubis.0x90.dk] has joined #bitcoin-core-dev
12:12 < vasild> wumpus: thanks, that was a true team effort!
12:12 < ja> fanquake: why is 13478 linked from https://github.com/bitcoin/bitcoin/issues/20104 ? it doesn't have recent discussion like claimed
12:16 < vasild> https://github.com/bitcoin/bips/blob/master/bip-0155.mediawiki "Status: Draft" -- should the status be changed?
12:16 < vasild> given that it is now implemented (and merged in `master`)?
12:21 < ja> vasild: indeed, it could be Proposed now. But Wladimir has to ack that change. So it is harder than getting things Rejected per timeout
12:24 < vasild> :)
12:26  * luke-jr prods wumpus
12:30 < sipa> luke-jr: 
12:30 < sipa> Peer services BIPs should be observed to be adopted by at least 1% of public listening nodes for one month.
12:31 < sipa> ah, that's for Final, not Proposed
12:36 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Quit: Leaving]
12:39 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
12:40 -!- jonatack [~jon@109.232.227.138] has quit [Ping timeout: 260 seconds]
12:42 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
12:43 -!- jonatack [~jon@134.19.179.147] has joined #bitcoin-core-dev
12:47 < jonatack> vasild: yes, congrats on 19954--i'm very glad to see it in 🚀
12:56 < sipa> indeed!
12:56 < sipa> vasild: ICYMI https://twitter.com/pwuille/status/1315105797517393920
12:57 < luke-jr> sipa: indeed
13:18 -!- Nebraskka [~Nebraskka@51.83.249.56] has quit [Quit: Good day old chaps]
13:18 -!- Nebraskka_ [~Nebraskka@51.83.249.56] has joined #bitcoin-core-dev
13:20 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
13:23 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Remote host closed the connection]
13:24 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
13:25 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 258 seconds]
13:27 -!- Nebraskka_ [~Nebraskka@51.83.249.56] has quit [Quit: Good day old chaps]
13:28 -!- Nebraskka [~Nebraskka@51.83.249.56] has joined #bitcoin-core-dev
13:35 -!- shaunsun [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has quit [Ping timeout: 272 seconds]
13:37 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
13:45 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev
13:57 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
14:00 -!- beaups [~beaups@s91904426.blix.com] has quit []
14:02 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds]
14:05 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
14:09 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
14:11 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
14:17 -!- Guyver2__ [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:20 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
14:22 -!- openstackstatus1 [~openstack@185.163.110.116] has joined #bitcoin-core-dev
14:22 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
14:24 < ja> wooow, i got an ack from Gavin! https://github.com/bitcoin/bips/pull/1010
14:47 < luke-jr> in a context where it means nothing
14:53 < ja> luke-jr: when would an ack be necessary for marking 'obsolete'? i thought it would be analogous to 'final' which you seem to wait for an explicit ack for here: https://github.com/bitcoin/bips/pull/926
14:54 < luke-jr> Final doesn't need an ACK, but Draft->Proposed does
14:54 < ja> luke-jr: is there something i can do to advance PR 926?
14:54 < luke-jr> I can't think of any scenario where ACK has meaning for Obsolete
14:54 < luke-jr> ja: ask morcos to ACK it?
14:55 < luke-jr> [again]
15:05 -!- ja [janus@anubis.0x90.dk] has left #bitcoin-core-dev ["luke-jr: alright, done, i have pinged morcos"]
15:07 < sipa> this is an unusual way of messaging a channel, but i guess it works
15:10 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
15:12 < fanquake> ja: you should ask hebasto
15:12 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
15:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:16 < bitcoin-git> [bitcoin] decryp2kanon opened pull request #20124: Add blockhash prefix (0x) for Testnet and Regtest (master...master) https://github.com/bitcoin/bitcoin/pull/20124
15:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:26 < bitcoin-git> [bitcoin] promag opened pull request #20125: rpc, wallet: Expose database format in getwalletinfo (master...2020-10-walletinfoformat) https://github.com/bitcoin/bitcoin/pull/20125
15:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:30 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Remote host closed the connection]
15:38 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has joined #bitcoin-core-dev
15:40 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev
15:40 < luke-jr> fanquake: hebasto isn't listed as an author..
15:41 < fanquake> luke-jr? he opened the issue
15:41 -!- filchef [~filchef@212.104.97.177] has quit [Client Quit]
15:41  * luke-jr sometimes wishes we could relax BIP stuff, sigh
15:41 < luke-jr> fanquake: only the author can approve Draft->Proposed status change
15:42 < fanquake> luke-jr: no idea what you're talking about. I was replying to "fanquake: why is 13478 linked from https://github.com/bitcoin/bitcoin/issues/20104 ? it doesn't have recent discussion like claimed"
15:42 < luke-jr> oh lol
15:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:45 < bitcoin-git> [bitcoin] theStack opened pull request #20126: test: p2p_leak_tx.py improvements (use MiniWallet, add p2p_locks acquires) (master...20201011-test-use-miniwallet-for-p2p_leak_tx) https://github.com/bitcoin/bitcoin/pull/20126
15:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:59 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer]
16:01 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
16:04 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Ping timeout: 240 seconds]
16:04 -!- afk11` [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev
16:06 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
16:25 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
16:43 < achow101> if I compile against the oldest version of sqlite I can find, and all of the tests pass, is it reasonable to assume that every version between that one and the latest are also compatible?
16:43 < achow101> aka I don't want to test every version of sqlite
16:44 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has joined #bitcoin-core-dev
16:47 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Read error: Connection reset by peer]
16:47 < sipa> what is the oldest version you tried?
16:47 < achow101> 3.8.0
16:47 < achow101> only because that was the oldest major release I could download
16:48 < sipa> given how little functionality i assume you're using, i think that's very reasonable
16:50 < achow101> turns out the actual oldest I could download (3.7.16) doesn't work anyways
16:50 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
16:59 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadmz]
16:59 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
16:59 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
17:00 -!- openstackstatus1 [~openstack@185.163.110.116] has quit []
17:00 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
17:02 < sipa> achow101: have you tried creating a wallet with the latest sqlite, and then opening it with a verdion that uses an older one?
17:02 < sipa> or is that exactly what you're tesfing here
17:02 < achow101> sipa: that's exactly what I did
17:03 < achow101> (as well as run all functional tests)
17:03 < sipa> cool
17:04 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
17:05 < luke-jr> what if new sqlite exits uncleanly?
17:09 < achow101> luke-jr: I'd guess that it'd work fine, but I'm not sure how to test that
17:09 < achow101> i'd have to kill bitcoind in the middle of a write somehow
17:10 < luke-jr> gdb breakpoint and the kill command? <.<
17:11 < achow101> hmm, ok..
17:31 -!- shaunsun [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has joined #bitcoin-core-dev
17:32 -!- shaunsun_ [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has joined #bitcoin-core-dev
17:36 -!- shaunsun [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has quit [Ping timeout: 260 seconds]
17:38 < achow101> luke-jr: handles it just fine
17:39 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
17:39 < luke-jr> +1
17:46 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 240 seconds]
17:46 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
17:52 -!- shaunsun_ [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has quit [Ping timeout: 260 seconds]
17:55 -!- Guest92188 [~flo@178.162.204.214] has joined #bitcoin-core-dev
18:02 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has quit [Quit: Find me in #TheHolyRoger or https://theholyroger.com]
18:04 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has joined #bitcoin-core-dev
18:07 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has quit [Read error: Connection reset by peer]
18:09 -!- kexkey [~kexkey@91.193.6.10] has joined #bitcoin-core-dev
18:11 -!- isis is now known as isis_
18:21 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
18:24 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
19:03 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
19:06 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has joined #bitcoin-core-dev
19:14 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
19:18 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 244 seconds]
19:20 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
19:24 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 244 seconds]
19:31 -!- proofofkeags_ [~proofofke@174-29-30-112.hlrn.qwest.net] has quit [Ping timeout: 240 seconds]
19:31 -!- proofofkeags [~proofofke@174-29-30-112.hlrn.qwest.net] has quit [Ping timeout: 240 seconds]
19:41 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer]
19:45 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
19:48 -!- proofofkeags_ [~proofofke@174-29-30-112.hlrn.qwest.net] has joined #bitcoin-core-dev
19:48 -!- proofofkeags [~proofofke@174-29-30-112.hlrn.qwest.net] has joined #bitcoin-core-dev
19:59 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
20:00 -!- Guest92188 [~flo@178.162.204.214] has quit []
20:04 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 244 seconds]
20:19 -!- proofofkeags_ [~proofofke@174-29-30-112.hlrn.qwest.net] has quit [Ping timeout: 256 seconds]
20:19 -!- proofofkeags [~proofofke@174-29-30-112.hlrn.qwest.net] has quit [Ping timeout: 256 seconds]
20:56 -!- larsivi [~larsivi@84.39.117.57] has joined #bitcoin-core-dev
21:31 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 244 seconds]
22:08 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
22:52 < hebasto> ja: #13478 is linked to #20104 as it is the recent discussion about minimum Qt version, and it lists arguments that should be considered in upcoming discussion
22:52 < gribble> https://github.com/bitcoin/bitcoin/issues/13478 | [RFC] gui: Minimum required Qt5 · Issue #13478 · bitcoin/bitcoin · GitHub
22:52 < gribble> https://github.com/bitcoin/bitcoin/issues/20104 | [RFC] qt: Minimum required Qt5 · Issue #20104 · bitcoin/bitcoin · GitHub
22:52 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev
23:00 -!- larsivi [~larsivi@84.39.117.57] has quit []
23:06 -!- rdbell [~rdbell@cpe-104-33-86-222.socal.res.rr.com] has joined #bitcoin-core-dev
23:22 -!- nandub [~nandub@84.39.117.57] has joined #bitcoin-core-dev
23:30 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Ping timeout: 240 seconds]
23:31 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection]
23:41 -!- andreacab [~andreacab@12.46.194.178.dynamic.wline.res.cust.swisscom.ch] has joined #bitcoin-core-dev
23:44 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev
23:52 -!- rdbell [~rdbell@cpe-104-33-86-222.socal.res.rr.com] has quit []
--- Log closed Mon Oct 12 00:00:44 2020