--- Log opened Mon Oct 12 00:00:44 2020
00:03 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
00:05 -!- gleb [~gleb@178.150.137.228] has joined #bitcoin-core-dev
00:07 < hebasto> achow101: https://sqlite.org/src/info/fda22108 looks scary, should we bump minimum sqlite up to 3.18.1 ?
00:07 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 256 seconds]
00:15 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
00:22 < vasild> "test/test_bitcoin: export of symbol in6addr_loopback not allowed"
00:22 -!- andreacab [~andreacab@12.46.194.178.dynamic.wline.res.cust.swisscom.ch] has quit [Remote host closed the connection]
00:22 < vasild> hmm
00:23 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:d57b:fbaf:949c:8555] has joined #bitcoin-core-dev
00:27 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:d57b:fbaf:949c:8555] has quit [Ping timeout: 244 seconds]
00:32 -!- S3RK [~s3rk@47.246.66.115] has quit [Remote host closed the connection]
00:44 -!- nandub [~nandub@84.39.117.57] has quit [Remote host closed the connection]
00:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:48 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/0b2abaa666d6...af22322dab1a
00:48 < bitcoin-git> bitcoin/master 79f3d9b Pieter Wuille: Mention BIP155 in doc/bips.md
00:48 < bitcoin-git> bitcoin/master 56f9dba Pieter Wuille: Only relay IPv4, IPv6, Tor addresses
00:48 < bitcoin-git> bitcoin/master af22322 fanquake: Merge #20119: BIP155 follow-ups
00:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:48 < bitcoin-git> [bitcoin] fanquake merged pull request #20119: BIP155 follow-ups (master...202010_bip155_followup) https://github.com/bitcoin/bitcoin/pull/20119
00:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:56 -!- promag [~promag@188.251.225.32] has joined #bitcoin-core-dev
01:00 -!- promag [~promag@188.251.225.32] has quit [Remote host closed the connection]
01:00 -!- promag [~promag@188.251.225.32] has joined #bitcoin-core-dev
01:02 -!- blardo [~blardo@195.206.169.184] has joined #bitcoin-core-dev
01:02 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
01:04 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:d57b:fbaf:949c:8555] has joined #bitcoin-core-dev
01:10 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
01:10 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:d57b:fbaf:949c:8555] has quit [Ping timeout: 272 seconds]
01:15 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 260 seconds]
01:18 -!- kljasdfvv [~flack@p200300d46f01520005d140ac005e7280.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
01:21 < vasild> sipa: 
01:21 < vasild> -        CService(CNetAddr(in6addr_loopback), 0 /* port */),
01:21 < vasild> +        CService(CNetAddr(in6_addr(IN6ADDR_LOOPBACK_INIT)), 0 /* port */),
01:21 < vasild> this should fix it
01:25 < sipa> vasild: that also works, i guess
01:26 < vasild> I don't fully understand this check, why don't we want to export any symbols?
01:26 < vasild> I mean - I can't judge if the above is better than adding in6addr_loopback to the list of exceptions
01:27 -!- promag_ [~promag@188.251.225.32] has joined #bitcoin-core-dev
01:28 -!- promag [~promag@188.251.225.32] has quit [Ping timeout: 256 seconds]
01:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:28 < bitcoin-git> [bitcoin] vasild opened pull request #20129: tests: don't export in6addr_loopback (master...fix_export_of_in6addr_loopback) https://github.com/bitcoin/bitcoin/pull/20129
01:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:29 < vasild> anyway - opened a PR, lets figure it out there
01:31 < sipa> vasild: added in #4089
01:31 < gribble> https://github.com/bitcoin/bitcoin/issues/4089 | devtools: add script to check symbols from Linux gitian executables by laanwj · Pull Request #4089 · bitcoin/bitcoin · GitHub
01:34 -!- promag_ [~promag@188.251.225.32] has quit [Remote host closed the connection]
01:35 < vasild> "This makes sure they are still compatible with the minimum supported Linux distribution versions."
01:37 < sipa> yeah, if we'd accidentally introduce a dependency on a symbol that's only available in a recent glibc for example, you can't run the binary on old systems
01:39 < vasild> I see
01:47 -!- promag [~promag@188.251.225.32] has joined #bitcoin-core-dev
01:51 -!- jonatack [~jon@134.19.179.147] has quit [Ping timeout: 244 seconds]
01:53 -!- isis_ is now known as isis
01:54 -!- promag [~promag@188.251.225.32] has quit [Remote host closed the connection]
02:00 -!- blardo [~blardo@195.206.169.184] has quit []
02:04 -!- kexkey [~kexkey@91.193.6.10] has quit [Ping timeout: 265 seconds]
02:05 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
02:09 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:d57b:fbaf:949c:8555] has joined #bitcoin-core-dev
02:09 -!- go11111111111 [go1111111@gateway/vpn/privateinternetaccess/go1111111] has joined #bitcoin-core-dev
02:12 -!- go121212 [~go1111111@104.156.98.86] has quit [Ping timeout: 260 seconds]
02:14 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:d57b:fbaf:949c:8555] has quit [Ping timeout: 272 seconds]
02:20 < kallewoof> sipa: maybe you realized, but you did s/fSuccess/fuccess/.
02:21 -!- DarTar [~DarTar@89.47.234.28] has joined #bitcoin-core-dev
02:22 < sipa> kallewoof: i guess there will be an "Updates 2020/10/12" in that case :)
02:22 < sipa> i shouldn't be making these changes at 2:24 am
02:23 < kallewoof> haha
02:23 < sipa> wait
02:23 < sipa> of course i was just testing if anyone was paying attention!
02:27 -!- glozow [uid453516@gateway/web/irccloud.com/x-buutjriyeafbzadq] has quit [Quit: Connection closed for inactivity]
02:35 -!- jonatack [~jon@37.166.80.90] has joined #bitcoin-core-dev
02:52 -!- jonatack [~jon@37.166.80.90] has quit [Read error: Connection reset by peer]
03:10 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
03:12 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
03:14 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection]
03:18 -!- Lillian89Heathco [~Lillian89@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev
03:27 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:d57b:fbaf:949c:8555] has joined #bitcoin-core-dev
03:28 -!- Lillian89Heathco [~Lillian89@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 272 seconds]
03:31 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:d57b:fbaf:949c:8555] has quit [Ping timeout: 272 seconds]
03:36 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev
03:38 -!- promag [~promag@188.251.225.32] has joined #bitcoin-core-dev
03:43 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
03:46 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:d57b:fbaf:949c:8555] has joined #bitcoin-core-dev
03:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:53 < bitcoin-git> [bitcoin] S3RK opened pull request #20130: Wallet: remove db mode string (master...wallet_remove_mode_3) https://github.com/bitcoin/bitcoin/pull/20130
03:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:54 -!- S3RK [~s3rk@47.246.66.115] has quit [Remote host closed the connection]
04:07 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
04:12 -!- promag [~promag@188.251.225.32] has quit [Remote host closed the connection]
04:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:12 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20131: test: Remove unused nVersion=1 in p2p tests (master...2010-testnVersion) https://github.com/bitcoin/bitcoin/pull/20131
04:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:15 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex]
04:21 -!- S3RK [~s3rk@47.246.66.115] has quit [Remote host closed the connection]
04:21 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
04:22 -!- S3RK [~s3rk@47.246.66.115] has quit [Read error: Connection reset by peer]
04:22 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
04:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:23 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #20097: fuzz: Version handshake (master...2010-fuzzHandshake) https://github.com/bitcoin/bitcoin/pull/20097
04:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:24 -!- promag [~promag@188.251.225.32] has joined #bitcoin-core-dev
04:28 -!- promag [~promag@188.251.225.32] has quit [Remote host closed the connection]
04:29 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
04:29 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
04:40 -!- neo_1 [~neo@2a01:cb1d:84aa:2d00:a9d:6d55:588b:94ce] has quit [Ping timeout: 272 seconds]
04:40 -!- jonatack [~jon@109.232.227.138] has joined #bitcoin-core-dev
04:42 -!- S3RK [~s3rk@47.246.66.115] has quit [Remote host closed the connection]
04:42 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
04:43 < jonatack> there are now "73 hidden items" in #19988 that can no longer be loaded (the link does nothing) :/
04:43 < gribble> https://github.com/bitcoin/bitcoin/issues/19988 | Overhaul transaction request logic by sipa · Pull Request #19988 · bitcoin/bitcoin · GitHub
04:47 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 258 seconds]
04:48 -!- jonatack [~jon@109.232.227.138] has quit [Ping timeout: 256 seconds]
04:49 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:d57b:fbaf:949c:8555] has quit [Ping timeout: 260 seconds]
04:49 -!- promag [~promag@188.251.225.32] has joined #bitcoin-core-dev
04:50 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #bitcoin-core-dev
04:52 -!- DarTar [~DarTar@89.47.234.28] has quit [Remote host closed the connection]
04:52 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Quit: Leaving]
04:54 -!- promag [~promag@188.251.225.32] has quit [Ping timeout: 258 seconds]
04:54 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
04:58 -!- shaunsun_ [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has joined #bitcoin-core-dev
04:59 -!- shaunsun__ [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has joined #bitcoin-core-dev
04:59 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 260 seconds]
05:01 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has joined #bitcoin-core-dev
05:02 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has joined #bitcoin-core-dev
05:02 -!- shaunsun_ [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has quit [Ping timeout: 260 seconds]
05:12 < willcl_ark> jonatack: seems like their gateway 502's when trying to load the comments, at the URL in this paste: https://0bin.net/paste/8-ysvxxl#vimu92Oplo3sSYaKT4n9EHDzDBE-Y2Daf1qUlblgunA
05:14 < jonatack> willcl_ark: indeed, it's been the case for a few days now, only the number of hidden comments keeps growing. i'm reviewing without the discussion.
05:15 < jonatack> hebasto mentioned it as well last week
05:15 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
05:20 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 260 seconds]
05:21 < willcl_ark> jonatack: ah I see.  How irritating for review.
05:23 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
05:23 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:d57b:fbaf:949c:8555] has joined #bitcoin-core-dev
05:24 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
05:27 -!- jcoe [seru@gateway/vpn/mullvad/joncoe] has joined #bitcoin-core-dev
05:27 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 260 seconds]
05:28 -!- jcoe [seru@gateway/vpn/mullvad/joncoe] has quit [Client Quit]
05:28 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:d57b:fbaf:949c:8555] has quit [Ping timeout: 272 seconds]
05:40 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 256 seconds]
05:41 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
05:45 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 240 seconds]
05:46 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
05:46 -!- shaunsun__ [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has quit [Read error: Connection reset by peer]
05:51 -!- shaunsun [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has joined #bitcoin-core-dev
05:56 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 240 seconds]
06:26 < wumpus> that's *really* bad
06:26 < wumpus> did anyone report this to github yet? we can't keep using the platform if this is the case
06:27 -!- kees1 [~kees@84.39.117.57] has joined #bitcoin-core-dev
06:27 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:d57b:fbaf:949c:8555] has joined #bitcoin-core-dev
06:31 < jonatack> wumpus: it looks like fanquake reported it 2-3 days ago: http://www.erisian.com.au/bitcoin-core-dev/log-2020-10-10.html#l-42
06:31 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:d57b:fbaf:949c:8555] has quit [Ping timeout: 272 seconds]
06:34 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:e990:bcf6:fcd1:29cc] has joined #bitcoin-core-dev
06:40 < fanquake> I have reported it to GitHub, and followed up with an employee today.
06:42 < michaelfolkson> Anyone know if GitLab suffers from this problem (hidden comments)? This specific bug should be resolved but they never get round to addressing the terrible hidden comments UX either
06:43 < michaelfolkson> I've never used GitLab
06:43 < luke-jr> sipa: imports vs exports?
06:44 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:e990:bcf6:fcd1:29cc] has quit [Remote host closed the connection]
06:44 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:e990:bcf6:fcd1:29cc] has joined #bitcoin-core-dev
06:45 < luke-jr> michaelfolkson: I have a GitLab repo that exceeded an arbitrary repo size limit years ago; opened an issue on their tracker, no response; pokes on Twitter, was told they'd look at it, still no response.. years later
06:45 < michaelfolkson> Fair enough. So that wouldn't improve the situation
06:45 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
06:46 < luke-jr> well, no idea if they have this issue, but it seems getting support is at least not likely
06:46 < hebasto> could gh cli show all comments?
06:46 < luke-jr> lol mishmash     License:             MIT Apache-2.0 BSD BSD-2 MPL-2.0
06:48 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:e990:bcf6:fcd1:29cc] has quit [Remote host closed the connection]
06:48 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:e990:bcf6:fcd1:29cc] has joined #bitcoin-core-dev
06:48 < michaelfolkson> Linus quote from Working in Public book. GitHub is "fine for hosting, but the pull requests and the online commit editing are just pure garbage" :) Old quote though
06:53 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:e990:bcf6:fcd1:29cc] has quit [Ping timeout: 272 seconds]
06:56 < michaelfolkson> hebasto: I don't think any of the gh cli commands are related to viewing PR comments https://cli.github.com/manual/gh_pr
06:58 < hebasto> michaelfolkson: so it's useless for that
06:59 < michaelfolkson> I think so. At least from looking at the docs. They seem to pushing a workflow where you approve the PR using the CLI but where discussion and review is done outside of the PR
07:04 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection]
07:05 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
07:05 < michaelfolkson> https://docs.github.com/en/free-pro-team@latest/rest/guides/working-with-comments
07:08 < jonatack> hebasto: i use gh cli a little and keep updating it, but the features added so far aren't what i'm hoping for. no getting the comments yet.
07:08 < jonatack> michaelfolkson: exactly
07:08 -!- pescador [~pescador@unaffiliated/pescador] has joined #bitcoin-core-dev
07:10 < jonatack> michaelfolkson: the globocorps and startup missions i was on until late 2018 used gitlab and mattermost instead of github and slack, which i was happy about, and we didn't have any issues at all -- i definitely preferred gitlab
07:11 < jonatack> s/used/mostly used/
07:12 < jonatack> michaelfolkson: but iirc the idea was to move away from any centralised service, if a migration were to happen
07:14 < michaelfolkson> Right. GitHub seems to be deteriorating to me. Often happens post acquisition by megacorp. 
07:20 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection]
07:20 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev
07:25 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Ping timeout: 240 seconds]
07:25 < wumpus> michaelfolkson: gitlab seems to handle things fine, e.g. freedesktop uses their own gitlab instance to host some active high-profile projects such as Mesa, no big issues from what i know
07:28 < michaelfolkson> Maybe I should try it if I am going to have an informed view rather than a speculative view...
07:28 < wumpus> they were also really, really careful to transition from olle mailinglist-based FOSS development, they never trusted github
07:29 < wumpus> (possibly because of Linus' opinion as you quoted :-) )
07:32 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Read error: Connection reset by peer]
07:33 < wumpus> jonatack: being able to see the diff in-line *with reviewer comments* in the terminal would be a great cli feature, wish it could do that
07:33 < wumpus> would save me a lot of switching between browser and terminal
07:34 < jonatack> yesss this is what i was hoping gh cli would add
07:35 < jonatack> whoever the PM is who is driving their features roadmap has very different priorities than ours
07:37 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
07:37 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
07:38 < achow101> hebasto: I don't think that's a problem for us. we don't use replace or auto-vacuumed databases
07:38 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
07:43 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev
07:43 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Read error: Connection reset by peer]
07:44 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
07:45 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 265 seconds]
07:51 -!- pescador [~pescador@unaffiliated/pescador] has quit [Remote host closed the connection]
07:53 < luke-jr> is there a way we can more strongly mark #18818 as a blocker? let's not forget part was backported to 0.20 …
07:53 < gribble> https://github.com/bitcoin/bitcoin/issues/18818 | Fix release tarball generated by gitian by luke-jr · Pull Request #18818 · bitcoin/bitcoin · GitHub
08:00 -!- kees1 [~kees@84.39.117.57] has quit []
08:00 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
08:01 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
08:01 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
08:01 -!- joerodgers [~joerodger@c-76-125-83-191.hsd1.ar.comcast.net] has joined #bitcoin-core-dev
08:05 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
08:06 < promag> achow101: feel free to cherry pick, otherwise I'll update it only after yours is merged #20125
08:06 < gribble> https://github.com/bitcoin/bitcoin/issues/20125 | rpc, wallet: Expose database format in getwalletinfo by promag · Pull Request #20125 · bitcoin/bitcoin · GitHub
08:21 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
08:21 -!- jhf [~jhf@185.244.214.216] has joined #bitcoin-core-dev
08:24 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 272 seconds]
08:24 -!- joerodgers [~joerodger@c-76-125-83-191.hsd1.ar.comcast.net] has quit [Ping timeout: 256 seconds]
08:26 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 260 seconds]
08:29 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds]
08:29 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
08:33 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has joined #bitcoin-core-dev
08:33 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has quit [Client Quit]
08:35 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex]
08:38 < hebasto> achow101: thanks
08:40 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
08:53 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
08:57 -!- cltrbreak_MAD2 is now known as ctrlbreak
09:02 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
09:03 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
09:04 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
09:04 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
09:07 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
09:10 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
09:11 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
09:14 -!- proofofkeags_ [~proofofke@c-73-34-43-4.hsd1.co.comcast.net] has joined #bitcoin-core-dev
09:14 -!- proofofkeags [~proofofke@c-73-34-43-4.hsd1.co.comcast.net] has joined #bitcoin-core-dev
09:15 -!- proofofkeags_ [~proofofke@c-73-34-43-4.hsd1.co.comcast.net] has quit [Remote host closed the connection]
09:15 -!- proofofkeags [~proofofke@c-73-34-43-4.hsd1.co.comcast.net] has quit [Remote host closed the connection]
09:15 -!- proofofkeags [~proofofke@c-73-34-43-4.hsd1.co.comcast.net] has joined #bitcoin-core-dev
09:15 -!- proofofkeags_ [~proofofke@c-73-34-43-4.hsd1.co.comcast.net] has joined #bitcoin-core-dev
09:19 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
09:21 -!- proofofkeags__ [~proofofke@c-73-34-43-4.hsd1.co.comcast.net] has joined #bitcoin-core-dev
09:21 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
09:23 -!- proofofkeags [~proofofke@c-73-34-43-4.hsd1.co.comcast.net] has quit [Ping timeout: 240 seconds]
09:23 -!- proofofkeags_ [~proofofke@c-73-34-43-4.hsd1.co.comcast.net] has quit [Ping timeout: 240 seconds]
09:24 -!- proofofkeags [~proofofke@c-73-34-43-4.hsd1.co.comcast.net] has joined #bitcoin-core-dev
09:39 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex]
09:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:41 < bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/af22322dab1a...f79a4a895279
09:41 < bitcoin-git> bitcoin/master d4dde24 Hennadii Stepanov: net: Add CNode::m_inbound_onion data member
09:41 < bitcoin-git> bitcoin/master 49fba9c Hennadii Stepanov: net: Add CNode::ConnectedThroughNetwork member function
09:41 < bitcoin-git> bitcoin/master 3984b78 Hennadii Stepanov: test: Add tests for CNode::ConnectedThroughNetwork
09:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:42 < bitcoin-git> [bitcoin] laanwj merged pull request #19998: net: Add CNode::ConnectedThroughNetwork member function (master...200922-istor) https://github.com/bitcoin/bitcoin/pull/19998
09:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:46 < luke-jr> jonatack: meshcollider: if you have a moment to re-ACK #19502 we can get it in :P
09:46 < gribble> https://github.com/bitcoin/bitcoin/issues/19502 | Bugfix: Wallet: Soft-fail exceptions within ListWalletDir file checks by luke-jr · Pull Request #19502 · bitcoin/bitcoin · GitHub
10:09 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
10:14 -!- joerodgers [~joerodger@c-76-125-83-191.hsd1.ar.comcast.net] has joined #bitcoin-core-dev
10:17 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:318d:a6fd:5d46:2a3a] has joined #bitcoin-core-dev
10:24 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 240 seconds]
10:30 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
10:34 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
10:34 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
10:34 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Read error: Connection reset by peer]
10:36 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
10:36 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
10:38 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:318d:a6fd:5d46:2a3a] has quit [Remote host closed the connection]
10:39 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:318d:a6fd:5d46:2a3a] has joined #bitcoin-core-dev
10:40 -!- andreaca_ [~andreacab@2a02:120b:2c22:e0c0:ad06:c697:eac0:6aef] has joined #bitcoin-core-dev
10:41 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 246 seconds]
10:42 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
10:43 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:318d:a6fd:5d46:2a3a] has quit [Ping timeout: 244 seconds]
10:50 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
10:56 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
11:00 -!- jhf [~jhf@185.244.214.216] has quit []
11:00 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 256 seconds]
11:01 -!- andreaca_ [~andreacab@2a02:120b:2c22:e0c0:ad06:c697:eac0:6aef] has quit [Remote host closed the connection]
11:01 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:ad06:c697:eac0:6aef] has joined #bitcoin-core-dev
11:05 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:ad06:c697:eac0:6aef] has quit [Remote host closed the connection]
11:06 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:ad06:c697:eac0:6aef] has joined #bitcoin-core-dev
11:08 -!- pescador [~pescador@62-251-9-102.ip.xs4all.nl] has joined #bitcoin-core-dev
11:08 -!- pescador [~pescador@62-251-9-102.ip.xs4all.nl] has quit [Changing host]
11:08 -!- pescador [~pescador@unaffiliated/pescador] has joined #bitcoin-core-dev
11:09 -!- pescador [~pescador@unaffiliated/pescador] has quit [Remote host closed the connection]
11:10 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:ad06:c697:eac0:6aef] has quit [Ping timeout: 244 seconds]
11:14 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
11:14 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
11:16 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev
11:18 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 256 seconds]
11:20 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
11:20 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
11:23 -!- owowo [~ovovo@91.193.4.10] has joined #bitcoin-core-dev
11:23 -!- owowo [~ovovo@91.193.4.10] has quit [Changing host]
11:23 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
11:25 < sipa> luke-jr: imports vs exports?
11:25 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
11:25 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
11:30 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
11:31 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
11:37 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 265 seconds]
11:43 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex]
11:44 -!- mekster [~mekster@139.180.192.79] has quit [Quit: mekster]
11:44 -!- mekster [~mekster@139.180.192.79] has joined #bitcoin-core-dev
11:48 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
11:52 -!- Pavlenex1 [~Thunderbi@178-223-156-85.dynamic.isp.telekom.rs] has joined #bitcoin-core-dev
11:54 -!- Pavlenex1 [~Thunderbi@178-223-156-85.dynamic.isp.telekom.rs] has quit [Client Quit]
11:55 -!- Pavlenex1 [~Thunderbi@178-223-156-85.dynamic.isp.telekom.rs] has joined #bitcoin-core-dev
11:56 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Ping timeout: 272 seconds]
11:56 -!- Pavlenex1 is now known as Pavlenex
11:57 -!- dwfreed1 [~dwfreed@178.162.204.214] has joined #bitcoin-core-dev
11:59 -!- Pavlenex [~Thunderbi@178-223-156-85.dynamic.isp.telekom.rs] has quit [Client Quit]
12:02 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
12:04 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Ping timeout: 260 seconds]
12:06 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
12:06 -!- reallll is now known as belcher
12:08 < MarcoFalke> I guess we could have moved the gui monotree to gitlab for comparison 
12:09 < MarcoFalke> Downside would be that all gui ppl need to create another account for review/pulls
12:11 < sipa> MarcoFalke: if we need to move, i'd suggest moving everything
12:11 < sipa> having split environments is even more annoying
12:13 < MarcoFalke> Moving everything will be so much pain that not seeing review comments on a few prs seems almost acceptable
12:13 < sipa> yes
12:14 < sipa> that doesn't mean it's not something we should consider if problems linger\
12:16 -!- kyoo[m] [kyoomatrix@gateway/shell/matrix.org/x-etfjimblzxcavkyd] has quit [Quit: killed]
12:16 -!- TheFuzzStone[m] [thefuzzsto@gateway/shell/matrix.org/x-tzemrjvzsabwqtlm] has quit [Quit: killed]
12:16 -!- Pasta[m] [pastapas1@gateway/shell/matrix.org/x-mgtozbmeouhttmpg] has quit [Quit: killed]
12:16 -!- rcrtn32002[m] [crtn32002m@gateway/shell/matrix.org/x-yvpognpwkvvutwrk] has quit [Quit: killed]
12:16 -!- awesome_doge1 [awesome-do@gateway/shell/matrix.org/x-pcyqkrcbiarqvrlj] has quit [Quit: killed]
12:16 -!- tianshi[m] [tianshimat@gateway/shell/matrix.org/x-wjdwwkwbaltmzekx] has quit [Quit: killed]
12:16 -!- sethrogers23[m] [sethrogers@gateway/shell/matrix.org/x-dkxyrsvqfxhgiodv] has quit [Quit: killed]
12:16 -!- snowkeld[m] [snowkeldma@gateway/shell/matrix.org/x-zydmlpbfrafyahbn] has quit [Quit: killed]
12:16 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-lwpewzcfbdxukyql] has quit [Quit: killed]
12:16 -!- RaphalBentgeac[m [raphaelben@gateway/shell/matrix.org/x-ostnjjuhqfqioria] has quit [Quit: killed]
12:19 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
12:20 -!- go121212 [~go1111111@104.156.98.86] has joined #bitcoin-core-dev
12:21 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 256 seconds]
12:22 -!- go11111111111 [go1111111@gateway/vpn/privateinternetaccess/go1111111] has quit [Ping timeout: 244 seconds]
12:24 -!- awesome_doge [awesome-do@gateway/shell/matrix.org/x-rqhslheiciljaitd] has joined #bitcoin-core-dev
12:31 -!- Pavlenex [~Thunderbi@178-223-156-85.dynamic.isp.telekom.rs] has joined #bitcoin-core-dev
12:31 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:ad06:c697:eac0:6aef] has joined #bitcoin-core-dev
12:38 -!- rcrtn32002[m] [crtn32002m@gateway/shell/matrix.org/x-xrszxbkalhvrojun] has joined #bitcoin-core-dev
12:38 -!- sethrogers23[m] [sethrogers@gateway/shell/matrix.org/x-nelrcczteyqmgkkg] has joined #bitcoin-core-dev
12:38 -!- kyoo[m] [kyoomatrix@gateway/shell/matrix.org/x-dwqgfwpcmurwhzcp] has joined #bitcoin-core-dev
12:38 -!- TheFuzzStone[m] [thefuzzsto@gateway/shell/matrix.org/x-otygpfkiusmgncbb] has joined #bitcoin-core-dev
12:38 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-cptnydtqzhiuimee] has joined #bitcoin-core-dev
12:38 -!- snowkeld[m] [snowkeldma@gateway/shell/matrix.org/x-exoaiqfhonxvordw] has joined #bitcoin-core-dev
12:38 -!- tianshi[m] [tianshimat@gateway/shell/matrix.org/x-ucmkocaufddvdwqq] has joined #bitcoin-core-dev
12:38 -!- RaphalBentgeac[m [raphaelben@gateway/shell/matrix.org/x-rjhqklaceapxoqbk] has joined #bitcoin-core-dev
12:38 -!- Pasta[m] [pastapas1@gateway/shell/matrix.org/x-vyyngsgzneodoicg] has joined #bitcoin-core-dev
12:41 < luke-jr> MarcoFalke: even on GtiHub, everyone has to create another repo…
12:56 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
12:56 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:ad06:c697:eac0:6aef] has quit [Remote host closed the connection]
12:59 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadmz]
13:00 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
13:02 < aj> looks like the api still works fwiw. http://azure.erisian.com.au/~aj/tmp/19988_COMMENTS.txt
13:03 < aj> generated by -- for a in `seq 1 18`; do curl -s https://api.github.com/repos/bitcoin/bitcoin/pulls/19988/comments?page=$a >19988_comments.$a; echo $a; done    and   for a in `seq 1 18`; do curl -s https://api.github.com/repos/bitcoin/bitcoin/pulls/19988/comments?page=$a >19988_comments.$a; echo $a; done
13:03 < aj> err
13:04 < aj> generated by -- for a in `seq 1 18`; do curl -s https://api.github.com/repos/bitcoin/bitcoin/pulls/19988/comments?page=$a >19988_comments.$a; echo $a; done    and   cat 19988_comments.? 19988_comments.?? | jq -r '.[] | (.user.login + " " + .path + ":" + ((.line//.original_line | tostring) // empty) + "   " + (.created_at), .body, "--------------------------")' > 19988_COMMENTS.txt
13:10 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
13:11 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
13:11 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
13:12 < sipa> aj: the "octodroid" android app also still works on it, though slowly
13:17 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 244 seconds]
13:19 < aj> sipa: does that mean giving your github pw to a thid party app dev?
13:20 < sipa> aj: it's open source, and *obviously* i reviewed the code and compiled it myself before using *cough*
13:20 -!- jonatack [~jon@104.254.90.235] has joined #bitcoin-core-dev
13:20 < jonatack> aj: grazie mille for http://azure.erisian.com.au/~aj/tmp/19988_COMMENTS.txt
13:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:27 < bitcoin-git> [bitcoin] practicalswift opened pull request #20137: tests: Update UBSan suppressions file with suppressions needed for clang 12 (current trunk) (master...clang-12-ubsan-suppressions) https://github.com/bitcoin/bitcoin/pull/20137
13:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:28 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
13:37 < luke-jr> sipa: ah, but did you compile your compiler yourself? ;)
13:38 < luke-jr> I guess step 1 to migrating to a decentralised system would be to write a nice GUI app for GitHub's API?
13:38 < luke-jr> (not Android because who wants to dev on their phone? XD)
13:38 -!- diogorsergio [~diogorser@94.6.169.41] has quit [Ping timeout: 260 seconds]
13:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:43 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20138: net: Assume that SetCommonVersion is called at most once per peer (master...2010-netVersionOnlyOnce) https://github.com/bitcoin/bitcoin/pull/20138
13:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:49 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Read error: Connection reset by peer]
13:49 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
13:51 < MarcoFalke> Ugh, is there any reason why GitHub would delete whole issues? #17298 is gone
13:51 < gribble> https://github.com/bitcoin/bitcoin/issues/17298 | HTTP Error 404: Not Found
13:53 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
13:55 < aj> MarcoFalke: yikes
13:56 < gwillen> what issue was it?
13:56 < fjahr> What was it? Definitely admins can delete issues but I wouldn't know why github would do it on it's own.
13:56 < gwillen> are you sure it existed? (and is whatever you thought it was?)
13:56 < MarcoFalke> sometimes spam is deleted, I think
13:56 < gwillen> I can't find any reference to it
13:57 < sipa> i can't find any reference to it either
13:58 < fjahr> Yeah, maybe that's what happened, spam issue was deleted by an admin
14:00 -!- dwfreed1 [~dwfreed@178.162.204.214] has quit []
14:02 -!- filchef [~filchef@212.104.97.177] has quit [Quit: KVIrc 5.0.0 Aria http://www.kvirc.net/]
14:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:07 < bitcoin-git> [bitcoin] stackman27 opened pull request #20139: Removed unused warning and formatted RPC result (master...upgradewallet_rpc_cleanup) https://github.com/bitcoin/bitcoin/pull/20139
14:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:08 < aj> "MinGW Runtime Assertion - Assertion failed! (#17298)"
14:08 < gribble> https://github.com/bitcoin/bitcoin/issues/17298 | HTTP Error 404: Not Found
14:10 < aj> closed by the submitter 31st oct 2019, doesn't seem at all spammy
14:10 < gwillen> one thing I notice is that its title is identical to the title of an older issue
14:10 < gwillen> which makes me wonder if github did some kind of erroneous database cleanup or something, although that would be crazy
14:11 < sipa> i can't imagine that i would have deleted this issue; i can't speak for other maintainers
14:11 < gwillen> (the older issue is #11812)
14:11 < gribble> https://github.com/bitcoin/bitcoin/issues/11812 | MinGW Runtime Assertion - Assertion failed! · Issue #11812 · bitcoin/bitcoin · GitHub
14:11 < gwillen> (I am taking aj's word for the contents of the newer issue since I can't see it -- I guess you had the page saved or something?)
14:11 < sipa> i have the old issue in my email
14:11 < sipa> yes, it's what aj says
14:11 < aj> gwillen: no it was when i was getting emails for everything
14:12 < sipa> SMTP notification is best notification
14:15 < MarcoFalke> The GitHub database optimization sounds plausible (and horrible)
14:16 < sipa> fanquake: do you have any insight?
14:17 < MarcoFalke> I've seen this happen at least three times. I can look up all the issues that were deleted, if needed.
14:21 < aj> https://api.github.com/repos/bitcoin/bitcoin/issues/17298/comments
14:21 < aj>  ^-- works
14:22 -!- CrystalNice [~CrystalNi@s91904426.blix.com] has joined #bitcoin-core-dev
14:22 < sipa> heh, so if it was deleted it's certainly not well deleted
14:22 < gwillen> the /events endpoints also still works, and the /labels endpoint gives an ... interesting failure (https://api.github.com/repos/bitcoin/bitcoin/issues/17298/labels)
14:23 < gwillen> it seems like the issue is labelled with a dangling label... I wonder if that's related to it being missing.
14:23 < sipa> can we try creating an issue and actually maintainer-deleting it, to see if the api result is identical?
14:23 < sipa> if not, it's more evidence of a screwup on github's side we should report
14:25 < aj> https://github.com/ajtowns/test-repo/issues/9
14:25 < aj> is what i get when i delete an issue; not a 404
14:26 < aj> and comments go away
14:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:27 < bitcoin-git> [bitcoin] sipa opened pull request #20140: Restore compatibility with old CSubNet serialization (master...202010_subnet_ser_compact) https://github.com/bitcoin/bitcoin/pull/20140
14:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:30 < sipa> aj: definitely looks like a github issue...
14:31 < sipa> MarcoFalke: we should report this
14:32 < achow101> can confirm, doesn't look like spam
14:35 < gwillen> hmmm, none of the submitter's comments seem to appear in /comments
14:35 < luke-jr> aj: test the dangling label theory?
14:35 < gwillen> I think I was mistaken about the dangling label, I think the ID it's complaining about is the issue itself
14:36 < gwillen> (github uses numeric IDs for the REST API, but string IDs for the graphQL API)
14:37 < gwillen> who was the submitter of the bug? I see a reply to a user named "StevenLee-CG" -- was that the submitter? That account doesn't seem to exist.
14:37 < gwillen> Which makes me wonder if what happened was they deleted the account, with prejudice, and all associated objects, or something.
14:39 < sipa> that seems plausible
14:40 < gwillen> seems kind of rude.
14:41 < sipa> aj: so your suggestion is removing the final commit from #19988 ?
14:41 < gribble> https://github.com/bitcoin/bitcoin/issues/19988 | Overhaul transaction request logic by sipa · Pull Request #19988 · bitcoin/bitcoin · GitHub
14:41 < aj> luke-jr: https://api.github.com/repos/ajtowns/test-repo/issues/10/labels  previously returned a "bug" label, after issue deletion just "Not found"
14:42 -!- jesseposner [~jesse@98.37.146.62] has joined #bitcoin-core-dev
14:42 < luke-jr> aj: I mean make an issue, give it a label, then delete the label
14:42 < luke-jr> but gwillen thinks it's not an issue, so..
14:43 < aj> sipa: moving that commit to a separate PR maybe? are there any benefits to that patch other than simplifying/deleting code?
14:43 < achow101> gwillen: when a user deletes their account, the issue should go to the "ghost" account
14:43 < gwillen> I don't think this was a voluntary deletion
14:43 < gwillen> I think this was some kind of aggressive admin deletion, like "account deleted for being a spammer" or for copyright violation or something
14:44 < gwillen> otherwise it would be weird for it to leave the database in an inconsistent state like this (although ... that's weird anyway, and perhaps their code is just bad)
14:44 < achow101> gwillen: perhaps. the user doesn't seem like a spammer though
14:45 < gwillen> do we have an example of a comment or issue filed by a subsequently-deleted user?
14:45 < sipa> aj: timing going backwards significantly seems like a problem in both variants really
14:45 < sipa> aj: and the only real solution is using a steady clock
14:46 < sipa> i'd say the code is a bit simpler now with the "now-monotonization" in it, and people have already looked at it
14:46 < sipa> so i'd rather keep it
14:46 < aj> sipa: in the original code it just means some announcements sit around until time catches up (in DELAYED or in REQUESTED if a notfound/tx doesn't come in) which doesn't seem a big deal?
14:47 < sipa> or all timeout instantly
14:47 < sipa> when it jumps forward
14:48 < aj> sipa: right, that's jumping forward. but it only means the single thing that's "next" will get queued up, which seems fine?
14:48 < sipa> i guess my comment is more about time jumping, not so much the backwards aspect of it
14:48 < sipa> hmm, true
14:49 < sipa> jnewbery: here?
14:49 < aj> sipa: (hidden motivation is that i don't want to re-review all the original code to update my ack while knowing that it's about to be removed and the logic switched around in the last commit)
14:50 < sipa> ok that's fair
14:58 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
15:00 -!- go11111111111 [go1111111@gateway/vpn/privateinternetaccess/go1111111] has joined #bitcoin-core-dev
15:02 -!- glozow [uid453516@gateway/web/irccloud.com/x-qkzbxqxrksojtzvz] has joined #bitcoin-core-dev
15:02 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 260 seconds]
15:03 -!- go121212 [~go1111111@104.156.98.86] has quit [Ping timeout: 256 seconds]
15:04 < jnewbery> sipa: hi
15:04 < sipa> jnewbery: i'm inclined to just remove the monotonic time last commit based on aj's comments above
15:04 < sipa> wdyt?
15:05 < jnewbery> fine by me. I have no strong opinion. I ACKed it before, I ACKed it after
15:06 < jnewbery> I would like to freeze the PR soon and get it merged (as I'm sure you would). Seems ready, and any loose ends can be tidied up after feature freeze
15:06 < sipa> jnewbery: regarding the invariants (but this is for a future PR), if TxRequestTracker maintains its own time (which it can do even if backward/forward at both allowed), then it's indeed possible to just enforce the invariants all the time with no real API complication
15:07 < sipa> so i like that idea
15:10 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
15:11 < jnewbery> sipa: yeah, the only thing I think we might need to be careful about is whether that increases to cost of ReceivedInv() and RequestedTx() in the worst case, and whether that can be exploited
15:12 < jnewbery> but I think it's ok
15:12 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
15:17 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
15:19 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 264 seconds]
15:21 -!- lukedashjr is now known as luke-jr
15:23 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection]
15:30 < fanquake> sipa: unsure. I can bring it up with GitHub if someone hasn’t already
15:37 -!- Pavlenex [~Thunderbi@178-223-156-85.dynamic.isp.telekom.rs] has quit [Quit: Pavlenex]
15:42 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
15:56 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
15:56 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
16:01 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
16:02 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
16:03 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
16:04 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
16:04 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
16:07 < sipa> vasild: see https://github.com/bitcoin/bitcoin/pull/20140
16:08 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 246 seconds]
16:09 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
16:09 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
16:14 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has joined #bitcoin-core-dev
16:16 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has quit [Client Quit]
16:20 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has joined #bitcoin-core-dev
16:21 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has quit [Client Quit]
16:33 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Read error: Connection reset by peer]
16:34 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
16:37 -!- shaunsun_ [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has joined #bitcoin-core-dev
16:39 -!- shaunsun [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has quit [Ping timeout: 260 seconds]
16:43 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
16:43 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
16:47 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
16:48 -!- shaunsun__ [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has joined #bitcoin-core-dev
16:48 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
16:49 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
16:50 -!- shaunsun_ [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has quit [Ping timeout: 260 seconds]
16:52 -!- shaunsun_ [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has joined #bitcoin-core-dev
16:55 -!- shaunsun__ [~shaunsun@c-76-26-29-34.hsd1.fl.comcast.net] has quit [Ping timeout: 272 seconds]
16:59 -!- shaunsun_ [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has quit [Ping timeout: 240 seconds]
17:00 -!- CrystalNice [~CrystalNi@s91904426.blix.com] has quit []
17:00 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
17:02 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
17:09 -!- proofofkeags [~proofofke@c-73-34-43-4.hsd1.co.comcast.net] has quit [Ping timeout: 246 seconds]
17:09 -!- proofofkeags__ [~proofofke@c-73-34-43-4.hsd1.co.comcast.net] has quit [Ping timeout: 246 seconds]
17:11 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has joined #bitcoin-core-dev
17:22 -!- ccallahan1 [~ccallahan@185.204.1.185] has joined #bitcoin-core-dev
17:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
17:38 < bitcoin-git> [bitcoin] sipa opened pull request #20141: Avoid the use of abs64 in timedata (master...202010_no_abs64) https://github.com/bitcoin/bitcoin/pull/20141
17:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
17:46 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
17:46 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
17:50 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
17:51 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
17:52 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
18:23 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds]
18:27 -!- proofofkeags_ [~proofofke@174-29-30-112.hlrn.qwest.net] has joined #bitcoin-core-dev
18:27 -!- proofofkeags [~proofofke@174-29-30-112.hlrn.qwest.net] has joined #bitcoin-core-dev
18:29 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has joined #bitcoin-core-dev
19:13 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
19:17 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Ping timeout: 240 seconds]
19:25 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
19:25 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Read error: Connection reset by peer]
19:26 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
19:26 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Read error: Connection reset by peer]
19:27 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
19:27 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Read error: Connection reset by peer]
19:32 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection]
19:32 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
19:36 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
19:36 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Read error: Connection reset by peer]
19:36 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
19:36 -!- S3RK [~s3rk@47.246.66.115] has quit [Ping timeout: 256 seconds]
19:41 -!- promag_ [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev
19:41 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Read error: Connection reset by peer]
20:00 -!- ccallahan1 [~ccallahan@185.204.1.185] has quit []
20:22 -!- rosseaux1 [~rosseaux@84.39.117.57] has joined #bitcoin-core-dev
20:37 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
21:07 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
21:08 -!- balbirs [~balbirs__@ozlabs.org] has quit [Ping timeout: 260 seconds]
21:14 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has joined #bitcoin-core-dev
21:16 -!- opsec_x12 [~opsec_x12@44-25-143-49.ip.hamwan.net] has quit [Read error: Connection reset by peer]
21:18 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has quit [Ping timeout: 260 seconds]
21:58 -!- balbirs [~balbirs__@ozlabs.org] has joined #bitcoin-core-dev
21:58 -!- proofofkeags_ [~proofofke@174-29-30-112.hlrn.qwest.net] has quit [Ping timeout: 260 seconds]
21:58 -!- proofofkeags [~proofofke@174-29-30-112.hlrn.qwest.net] has quit [Ping timeout: 260 seconds]
22:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
22:06 < bitcoin-git> [bitcoin] fanquake opened pull request #20142: [0.20] build: set minimum required Boost to 1.48.0 (0.20...min_boost_actually_1480) https://github.com/bitcoin/bitcoin/pull/20142
22:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
22:20 -!- rosseaux1 [~rosseaux@84.39.117.57] has quit [Remote host closed the connection]
22:34 -!- romtam [~romtam@s91904426.blix.com] has joined #bitcoin-core-dev
22:44 -!- S3RK [~s3rk@47.246.66.115] has quit [Remote host closed the connection]
22:54 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
23:00 -!- romtam [~romtam@s91904426.blix.com] has quit []
23:00 -!- jesseposner [~jesse@98.37.146.62] has quit [Ping timeout: 264 seconds]
23:04 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:b1c2:bcb9:b694:e401] has joined #bitcoin-core-dev
23:05 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:b1c2:bcb9:b694:e401] has quit [Remote host closed the connection]
23:05 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:b1c2:bcb9:b694:e401] has joined #bitcoin-core-dev
23:10 -!- andreacab [~andreacab@2a02:120b:2c22:e0c0:b1c2:bcb9:b694:e401] has quit [Ping timeout: 260 seconds]
23:22 -!- Wayno [~Wayno@185.163.110.116] has joined #bitcoin-core-dev
23:26 -!- jesseposner [~jesse@98.37.146.62] has joined #bitcoin-core-dev
23:30 -!- jesseposner [~jesse@98.37.146.62] has quit [Ping timeout: 240 seconds]
23:32 -!- S3RK [~s3rk@47.246.66.115] has quit [Remote host closed the connection]
23:33 -!- S3RK [~s3rk@47.246.66.115] has joined #bitcoin-core-dev
23:37 -!- b10c [~b10c@2a01:4f8:192:612a:216:3eff:fef3:dc6a] has joined #bitcoin-core-dev
23:58 -!- jesseposner [~jesse@98.37.146.62] has joined #bitcoin-core-dev
--- Log closed Tue Oct 13 00:00:45 2020