--- Log opened Tue Oct 20 00:00:52 2020 00:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:03 < bitcoin-git> [bitcoin] jonatack opened pull request #20193: p2p: improve onion detection in AttemptToEvictConnection (master...evict-inbound-onions) https://github.com/bitcoin/bitcoin/pull/20193 00:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:08 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Remote host closed the connection] 00:08 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 00:13 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Ping timeout: 265 seconds] 00:24 -!- BGL [~twenty@75-149-171-58-Washington.hfc.comcastbusiness.net] has quit [Ping timeout: 246 seconds] 00:32 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 00:35 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds] 00:36 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 00:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:43 < bitcoin-git> [bitcoin] fanquake closed pull request #20190: net: Hardcoded seeds update for 0.20.1 (master...seeds) https://github.com/bitcoin/bitcoin/pull/20190 00:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:52 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 01:00 -!- promag [~promag@176.79.5.27] has quit [Remote host closed the connection] 01:00 -!- promag [~promag@176.79.5.27] has joined #bitcoin-core-dev 01:02 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev 01:08 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Read error: Connection reset by peer] 01:09 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Remote host closed the connection] 01:10 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 01:10 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev 01:12 -!- worc3131 [~quassel@2a02:c7f:c026:9500:7d0b:65d0:38a4:4786] has quit [Remote host closed the connection] 01:13 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Remote host closed the connection] 01:13 -!- worc3131 [~quassel@2a02:c7f:c026:9500:a0d2:b9d1:42a4:69b4] has joined #bitcoin-core-dev 01:13 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev 01:14 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Ping timeout: 240 seconds] 01:22 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 01:22 -!- BGL [~twenty@75-149-171-58-Washington.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 01:22 -!- kljasdfvv [~flack@p200300d46f015200a9dce3084d086bb8.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!] 01:24 -!- kljasdfvv [~flack@p200300d46f015200480a4dc458c894c0.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 01:31 < elichai2> Anyone else is getting a bunch of `-Wsuggest-override` warnings in the qt system headers? 01:31 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 01:32 < elichai2> It's all from the expansion of the `Q_OBJECT` macro 01:34 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Ping timeout: 256 seconds] 01:36 -!- jonatack [~jon@213.152.162.10] has quit [Ping timeout: 258 seconds] 01:37 -!- reallll is now known as belcher 01:39 -!- promag [~promag@176.79.5.27] has quit [Remote host closed the connection] 01:39 -!- promag [~promag@dsl-5-27.bl27.telepac.pt] has joined #bitcoin-core-dev 01:46 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 01:46 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 01:49 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 272 seconds] 01:55 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Remote host closed the connection] 01:56 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 01:56 -!- promag [~promag@dsl-5-27.bl27.telepac.pt] has quit [Remote host closed the connection] 01:56 -!- promag [~promag@dsl-5-27.bl27.telepac.pt] has joined #bitcoin-core-dev 01:57 -!- promag_ [~promag@176.79.5.27] has joined #bitcoin-core-dev 01:57 -!- promag [~promag@dsl-5-27.bl27.telepac.pt] has quit [Read error: Connection reset by peer] 01:57 < vasild> elichai2: yes, I think I got those 01:59 < vasild> elichai2: "./configure --enable-suppress-external-warnings" should silence them 02:00 -!- JohninLex [~JohninLex@185.244.214.216] has quit [] 02:00 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Ping timeout: 260 seconds] 02:20 -!- havenwood1 [~havenwood@185.163.110.116] has joined #bitcoin-core-dev 02:24 < vasild> How to make a functional test that is skipped by default in CI, but make it easy to run it manually? 02:24 -!- kyoo[m] [kyoomatrix@gateway/shell/matrix.org/x-dwqgfwpcmurwhzcp] has quit [Quit: killed] 02:24 -!- awesome_doge [awesome-do@gateway/shell/matrix.org/x-rqhslheiciljaitd] has quit [Quit: killed] 02:24 -!- rcrtn32002[m] [crtn32002m@gateway/shell/matrix.org/x-xrszxbkalhvrojun] has quit [Quit: killed] 02:24 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-cptnydtqzhiuimee] has quit [Quit: killed] 02:24 -!- sethrogers23[m] [sethrogers@gateway/shell/matrix.org/x-nelrcczteyqmgkkg] has quit [Quit: killed] 02:25 -!- Pasta[m] [pastapas1@gateway/shell/matrix.org/x-vyyngsgzneodoicg] has quit [Quit: killed] 02:25 -!- tianshi[m] [tianshimat@gateway/shell/matrix.org/x-ucmkocaufddvdwqq] has quit [Quit: killed] 02:25 -!- TheFuzzStone[m] [thefuzzsto@gateway/shell/matrix.org/x-otygpfkiusmgncbb] has quit [Quit: killed] 02:25 -!- RaphalBentgeac[m [raphaelben@gateway/shell/matrix.org/x-rjhqklaceapxoqbk] has quit [Quit: killed] 02:25 -!- snowkeld[m] [snowkeldma@gateway/shell/matrix.org/x-exoaiqfhonxvordw] has quit [Quit: killed] 02:25 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev 02:32 -!- awesome_doge [awesome-do@gateway/shell/matrix.org/x-nyaqghsnbgpalekn] has joined #bitcoin-core-dev 02:34 -!- S3RK [~S3RK@116.118.73.30] has joined #bitcoin-core-dev 02:35 < jnewbery> vasild: look at EXTENDED_SCRIPTS in test/functional/test_runner.py 02:36 < aj> jnewbery: hey, is p2p meeting in 5h30m ? 02:36 < fanquake> aj: that's what I've got 02:37 < jnewbery> Yes, it's in 5h30min 02:37 < jnewbery> Are you out of daylight savings? It might make sense to shift the time for summer/winter 02:37 < aj> sydney socratic's got daylight savings so suddenly i don't know what time anything is 02:38 < aj> jnewbery: no daylight savings here, just +1000 UTC all year 02:38 < fanquake> the east coast is a mess of daylight savings 02:38 < vasild> jnewbery: ci/test/00_setup_env_native_qt5.sh:13:export TEST_RUNNER_EXTRA="--previous-releases --coverage --extended --exclude feature_dbcrash" 02:39 -!- jonasschnelli [~jonasschn@static.239.36.216.95.clients.your-server.de] has quit [Changing host] 02:39 -!- jonasschnelli [~jonasschn@unaffiliated/jonasschnelli] has joined #bitcoin-core-dev 02:39 < vasild> extended tests may still be run by this CI? 02:40 < jnewbery> aj: so I guess you're happy to keep it at the same time. It'll be an hour earlier for northern hemisphere folks, which might be upsetting for those on the US west coast 02:40 < jnewbery> vasild: ah, you'd also need to add the name of your test to the end of that config line 02:40 < vasild> What I tried is: I added a custom option to the script "--forcerun" and if it is not set then I raise SkipTest() 02:41 < vasild> but the test is still run by travis, and I have no clue why. It must have detected the option and run it with that option set... 02:42 < vasild> I tried running "test_runner.py --ci" locally, and the test is skipped as expected 02:43 < vasild> jnewbery: that would be quite ugly, no? 02:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:46 < bitcoin-git> [bitcoin] fanquake opened pull request #20195: build: fix mutex detection when building bdb on macOS (master...bdb_xcode12_implicit_function_decleration) https://github.com/bitcoin/bitcoin/pull/20195 02:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:48 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-znsexcvbrpqeuydj] has joined #bitcoin-core-dev 02:48 -!- kyoo[m] [kyoomatrix@gateway/shell/matrix.org/x-wjrvikkainhcxlwc] has joined #bitcoin-core-dev 02:48 -!- snowkeld[m] [snowkeldma@gateway/shell/matrix.org/x-gfaiyodbrvpiocct] has joined #bitcoin-core-dev 02:48 -!- TheFuzzStone[m] [thefuzzsto@gateway/shell/matrix.org/x-tdoeegdpmdfblkqr] has joined #bitcoin-core-dev 02:48 -!- sethrogers23[m] [sethrogers@gateway/shell/matrix.org/x-abwoglxxdnismaki] has joined #bitcoin-core-dev 02:48 -!- Pasta[m] [pastapas1@gateway/shell/matrix.org/x-uawgxogisyrllude] has joined #bitcoin-core-dev 02:48 -!- rCapital-Surpris [crtn32002m@gateway/shell/matrix.org/x-twvftpnsaszuavpj] has joined #bitcoin-core-dev 02:48 -!- tianshi[m] [tianshimat@gateway/shell/matrix.org/x-xcdqsbxtuhyiqtzj] has joined #bitcoin-core-dev 02:48 -!- RaphalBentgeac[m [raphaelben@gateway/shell/matrix.org/x-simcfrbvrxngvotq] has joined #bitcoin-core-dev 02:52 < jnewbery> vasild: People can live with ugly travis config I think :) 02:53 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex] 02:53 < vasild> jnewbery: ok, maybe ugly was not the right word, but it is also fragile because it means that the test will be run whenever "test_runner.py --extended" is executed 02:54 < vasild> and it will fail 02:54 < vasild> sometimes I run "test_runner.py --extended" locally 02:54 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 02:54 < vasild> I guess other people also do and I do not want to impose "always run with --extended --exclude foo" otherwise you will get failure 03:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:02 < bitcoin-git> [bitcoin] vasild opened pull request #20196: net: fix GetListenPort() to derive the proper port (master...fix_GetListenPort) https://github.com/bitcoin/bitcoin/pull/20196 03:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:05 -!- promag_ [~promag@176.79.5.27] has quit [Remote host closed the connection] 03:05 < vasild> jnewbery: I renamed the option from --forcerun to --ihave1111 and opened a PR, lets see if travis will still execute the code below this line: https://github.com/bitcoin/bitcoin/pull/20196/files#diff-6b91c5b0a9bd8c4d007ea9548808ae7ba98beb22ff236324d238815c68b3b8b1R62 03:06 -!- promag [~promag@176.79.5.27] has joined #bitcoin-core-dev 03:07 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 03:09 -!- promag [~promag@176.79.5.27] has quit [Remote host closed the connection] 03:10 -!- promag [~promag@176.79.5.27] has joined #bitcoin-core-dev 03:11 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 03:11 -!- vasild_ is now known as vasild 03:11 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 03:16 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 03:20 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 256 seconds] 03:29 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 03:31 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev 03:42 -!- brianhoffman [~brianhoff@pool-71-191-34-154.washdc.fios.verizon.net] has joined #bitcoin-core-dev 03:43 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Remote host closed the connection] 03:43 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 03:45 -!- andreaca_ [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 03:45 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Read error: Connection reset by peer] 03:47 -!- andreaca_ [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Remote host closed the connection] 03:48 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 03:50 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Read error: Connection reset by peer] 03:51 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 03:52 -!- S3RK [~S3RK@116.118.73.30] has quit [Ping timeout: 260 seconds] 04:06 -!- sethrogers23[m] [sethrogers@gateway/shell/matrix.org/x-abwoglxxdnismaki] has left #bitcoin-core-dev [] 04:22 -!- murrayn [~murray@unaffiliated/murrayn] has quit [Quit: ZNC 1.8.1 - https://znc.in] 04:23 -!- murray_ [~murray@static.38.4.181.135.clients.your-server.de] has joined #bitcoin-core-dev 04:29 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 04:29 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Remote host closed the connection] 04:29 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 04:30 -!- andreaca_ [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 04:30 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Read error: Connection reset by peer] 04:32 -!- andreaca_ [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Remote host closed the connection] 04:32 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 04:33 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Read error: Connection reset by peer] 04:33 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 04:35 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Remote host closed the connection] 04:36 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 04:36 -!- andreaca_ [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 04:36 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Read error: Connection reset by peer] 04:38 -!- promag [~promag@176.79.5.27] has quit [Remote host closed the connection] 04:38 -!- andreaca_ [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Remote host closed the connection] 04:38 -!- promag [~promag@176.79.5.27] has joined #bitcoin-core-dev 04:39 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 04:41 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Remote host closed the connection] 04:42 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 04:44 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Remote host closed the connection] 04:45 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 04:47 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Remote host closed the connection] 04:48 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 04:49 -!- andreaca_ [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 04:49 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Read error: Connection reset by peer] 04:51 -!- andreaca_ [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Remote host closed the connection] 04:52 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 04:54 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Remote host closed the connection] 04:54 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 04:55 -!- andreaca_ [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 04:55 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Read error: Connection reset by peer] 04:57 -!- andreaca_ [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Remote host closed the connection] 04:57 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 04:58 -!- andreaca_ [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 04:58 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Read error: Connection reset by peer] 05:00 -!- havenwood1 [~havenwood@185.163.110.116] has quit [] 05:00 -!- andreaca_ [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Remote host closed the connection] 05:00 -!- wishbone [~wishbone@pool-108-55-114-19.hrbgpa.fios.verizon.net] has joined #bitcoin-core-dev 05:00 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 05:05 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Ping timeout: 246 seconds] 05:09 < vasild> jnewbery: I figured it out - had to move the check earlier - from run_test() to setup_nodes() 05:19 -!- brimstone1 [~brimstone@84.39.117.57] has joined #bitcoin-core-dev 05:25 -!- ctrlbreak [~ctrlbreak@159.2.182.106] has quit [Remote host closed the connection] 05:25 -!- ctrlbreak [~ctrlbreak@159.2.182.106] has joined #bitcoin-core-dev 05:29 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 05:49 -!- jonatack [~jon@213.152.162.99] has joined #bitcoin-core-dev 05:51 -!- Ga1aCt1Cz00__ [~Ga1aCt1Cz@2a02:810a:8d40:5ebc:2143:af3d:c6b2:a825] has joined #bitcoin-core-dev 05:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:51 < bitcoin-git> [bitcoin] jonatack closed pull request #20193: p2p: practicalswift would like review of 19972 (master...evict-inbound-onions) https://github.com/bitcoin/bitcoin/pull/20193 05:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:55 -!- Ga1aCt1Cz00_ [~Ga1aCt1Cz@2a02:810a:8d40:5ebc:c407:85d0:bcbe:4132] has quit [Ping timeout: 272 seconds] 06:09 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 06:17 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Remote host closed the connection] 06:24 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 06:28 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 06:38 -!- promag [~promag@176.79.5.27] has quit [Remote host closed the connection] 06:38 -!- promag [~promag@176.79.5.27] has joined #bitcoin-core-dev 06:41 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 06:43 < jnewbery> vasild: good! 06:45 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 272 seconds] 06:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:46 < bitcoin-git> [bitcoin] jonatack opened pull request #20197: p2p: improve onion detection in AttemptToEvictConnection() (master...AttemptToEvictConnection-identify-onions-with-m_inbound_onion) https://github.com/bitcoin/bitcoin/pull/20197 06:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:59 < jonasschnelli> MarcoFalke: I saw that you have merged some PRs in the GUI repository. Are you going to open a PR on the main repository? 07:24 < jonasschnelli> with the settings.json file: is there a way to disable loading a specific wallet that has been stored in settings.json? 07:30 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Remote host closed the connection] 07:31 -!- glozow [uid453516@gateway/web/irccloud.com/x-fcolakpxkpqjawlp] has joined #bitcoin-core-dev 07:33 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection] 07:37 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 07:38 < ryanofsky> jonasschnelli, if you run with -nowallet on command line it resets the list and takes precedence, and you can add other wallets after like -nowallet -wallet=mywallet 07:40 < ryanofsky> also wallet is removed from settings if you unload it in the gui or call an rpc with load_on_startup=False 07:40 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 07:41 < ryanofsky> and #20186 will avoid creating the wallet, if you are trying to avoid creating, not loading 07:41 < gribble> https://github.com/bitcoin/bitcoin/issues/20186 | wallet: Make -wallet setting not create wallets by ryanofsky · Pull Request #20186 · bitcoin/bitcoin · GitHub 07:41 < jonasschnelli> thanks ryanofsky 07:43 < jonasschnelli> ryanofsky: settings.json is only in conjunction with the GUI, right? RPC loadwallet will not make create that file? 07:43 < ryanofsky> no problem. also you can run with -nosettings to ignore the whole file 07:44 < ryanofsky> yes by default loadwallet doesn't modify settings unless you pass load_on_startup=true or load_on_startup=false 07:45 < jonasschnelli> I guess the issue if someone creates a wallet with --wallet=mywallet in bitcoin.conf or via cli parameter, unloaded it and loads it again in the GUI (or with load_on_startup), restarts bitcoin with the same parameter will lead to a halt due to a duplicate -wallet parameter? 07:45 < jonasschnelli> (the issue can be overlooked / edge-case) 07:48 < ryanofsky> i think ideally duplicate wallet error would not be triggered by that, but it is an edge case 07:50 < ryanofsky> there maybe be similar cases worth fixing. like if a bitcoin.conf specifies a wallet to load, and you unload it and reload it in the gui, that should not trigger any duplicate wallet error 07:52 < ryanofsky> but in general the idea is for the gui to simply reload the same wallets you loaded last time, so you can stop using bitcoin.conf 07:52 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 07:55 < jonasschnelli> ryanofsky: the reason why I look at that issue is that probably some users have specified --wallet(s) in bitcoin.conf (or CLI parameter) and will eventually run into the load/unload issue 07:56 < jonasschnelli> They are potentially puzzled why the "duplicate error" pops up and core refuses to start 07:56 < ryanofsky> right, i'm agreeing that should be fixed 07:56 < jonatack> ryanofsky: i wonder if adding mention of -nowallet to -wallet would be helpful. like how -nosettings is documented in -settings. 07:56 < jonasschnelli> it's more an upgrade issue than a "I'm new to 0.21" thing 07:57 < jonasschnelli> ryanofsky: would it hurt to just de-duplicate those entries (ignore duplicates)? 07:58 < ryanofsky> jonatack, could be depending on the use case. I thought -nosettings was useful to document for a sysadmin who doesn't wants a static configuration and doesn't want dynamic settings being used 07:59 < ryanofsky> Use cases for -nowallet are more obscure as far as I know. We use them in the testing framework, and here we are talking about using it to work around a bug that should just be fixed 07:59 < jonatack> ryanofsky: oh ok. the "no" idiom is known, but TIL you can reset the wallet list with -nowallet 07:59 < ryanofsky> s/doesn't wants/just wants/ above 08:00 -!- brimstone1 [~brimstone@84.39.117.57] has quit [] 08:00 < jonasschnelli> I also wasn't aware of the -nowallet reset in the parameter order jonatack 08:00 < jnewbery> #startmeeting 08:00 < lightningbot> Meeting started Tue Oct 20 15:00:45 2020 UTC. The chair is jnewbery. Information about MeetBot at http://wiki.debian.org/MeetBot. 08:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic. 08:00 < jnewbery> #bitcoin-core-dev P2P Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james 08:01 < jnewbery> amiti fjahr jeremyrubin lightlike emilengler jonatack hebasto jb55 elichai2 08:01 < jonasschnelli> hi 08:01 < jnewbery> hi folks! 08:01 < gleb> Hi 08:01 < fanquake> hi 08:01 < ryanofsky> yeah -noXXX for a list setting clears the list. hopefully you never have to rely on this! 08:01 < amiti> hi 08:01 < sipa> hi 08:01 < ariard> hi 08:01 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 08:01 < jonatack> hallo 08:01 < sdaftuar> heya 08:01 < ajonas> hi 08:01 < jnewbery> first of all, congrats everyone for getting so many PRs reviewed and merged before feature freeze! 08:01 < awesome_doge> hi 08:02 < jnewbery> we got addrv2, transaction request overhaul, taproot and anchor connections all merged 08:02 < jnewbery> Just one proposed topic today: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings#20-oct-2020 08:02 < gribble> https://github.com/bitcoin/bitcoin/issues/20 | JSON-RPC callback · Issue #20 · bitcoin/bitcoin · GitHub 08:02 < jnewbery> Before we do that, does anyone have any updates or want to share what they're working on/prioritising? 08:03 < jnewbery> ok, our single topic is: 08:03 < jnewbery> Remove timestamps from addr messages? It seems like the timestamp is only used to leak information about our recent connectivity. It doesn't look like we use it to make decisions about who to connect to. (sdaftuar/jnewbery) 08:03 < jnewbery> sdaftuar: do you want to explain? 08:04 < sdaftuar> oy, i can try 08:04 < sdaftuar> i guess the background here is around looking at how addrman works, and what information it might leak about our peers (and whether or not that is ok, i guess) 08:04 < emzy> hi 08:05 < sdaftuar> i was chatting with jnewbery about the interaction specifically with block-relay-only peers, where we really don't want to leak anything 08:05 < sdaftuar> and one observation was that right now in master, we basically directly leak the time at which we were connected to a block-relay-only peer after we disconnect from that peer and then include the address in a getaddr response 08:05 < gleb> It does indeed leak info, but I never thought about solving the issue in this fashion... 08:05 < sdaftuar> we can fix that, but it led to wondering: what good does this time do anyone, anyway? 08:06 < sipa> is it actually not used for anything? 08:06 < sdaftuar> our own software seems to barely use those times: we use it to sometimes filter out responses to getaddr requests, and we use to sometimes to evict things from the new table 08:06 < gleb> There is a check in IsTerrible 08:06 < gleb> Seeing if it’s older than a month 08:06 < ariard> the fact it's not used by core addrman doesn't mean it's not used by some other bitcoin clients to decide its peering 08:06 < sdaftuar> but we do not use it for determining who to connect to, as far as i can tell. 08:08 < gleb> From what I remember I think you are right, but those existing features are not nothing 08:08 < jnewbery> using timestamps is already a well-known way of infering network topology: https://www.cs.umd.edu/projects/coinscope/coinscope.pdf 08:08 < sdaftuar> ariard: agreed. but i thought it might be worth polling people about how much good these timestamps can do, as they are necessarily unverifiable data? 08:08 < jonatack> CAddrMan::Good: "nTime is not updated here, to avoid leaking information about currently-connected peers." 08:09 < sipa> sdaftuar: good question 08:09 < sdaftuar> gleb: i imagine we could replace their use in those two places without that much trouble 08:09 < gleb> I think the way we use them, an adversary can’t really manipulate, because the checks are very moderate 08:10 < sdaftuar> eg by using nlasttry/nlastsuccess 08:10 < gleb> even if someone bumps their own addrs too much, they don’t really become “better” 08:10 < gleb> sdaftuar: and that won’t propagate through the network? 08:10 < gleb> it will have effect only locally at every node 08:11 < sdaftuar> gleb: given that we don't use them for much, it seems there is only downside to us by potentially telling our peers who we were connected to and at what time? 08:12 < gleb> Telling that a given address we’re relaying is not one year old... 08:12 < sdaftuar> we could still use nlastsuccess to filter out old addresses from our getaddr responses, i think? 08:12 < ariard> sdaftuar: right, unverifiable data doesn't mean it can be useful even if it's gentleman-style of enforcment 08:12 < ariard> a lot of alternatives p2p stack doesn't sanitize their addrs with a feeler connection 08:13 < gleb> and they can retell this fact to other peers without connecting by themselves. Just tell what we told 08:14 < sdaftuar> interestingly, we don't update that time field when we successfully connect to a peer via a feeler connection, i believe. 08:14 < gleb> I need to look better at the code. I’d be very happy to get rid of this stuff 08:14 < sipa> i'll also have a look in more detail 08:14 < jnewbery> ariard: tradeoff there seems to be between helping a [theoretical] alternative implementation make better decisions about who to connect to -vs- protecting our own privacy 08:14 < sipa> it's very appealing 08:14 -!- promag [~promag@176.79.5.27] has quit [Remote host closed the connection] 08:15 < jnewbery> by default we should always lean towards protecting our own privacy, unless doing so would be detrimental to the network as a whole 08:15 < ariard> jnewbery: I would favor protecting our own privacy, but as a good practice asking on the ml would be great, at least to warrant 08:15 -!- promag [~promag@dsl-5-27.bl27.telepac.pt] has joined #bitcoin-core-dev 08:15 < gleb> jnewbery: I suggest ariard thinks more whether time stamps can help light clients a lot comparing to feeler strategy 08:16 < amiti> +1 I don't have a complete understanding of these timestamps, but when I've looked at them in the past I've come to similar conclusions where they aren't used for much since they are unreliable and are easy to accidentally leak information 08:16 < jnewbery> ariard: +1. This would be a de facto change to the p2p protocol. Circulating it on the mailing list would be good manners, at least 08:17 < gleb> They are unreliable, but they also can’t be exploited actively I think (only leak info, passive exploit) 08:17 < sdaftuar> gleb: whether they can be exploited depends on how people are using them. i agree our software seems to be designed so that this is just an information leak 08:17 < jnewbery> I think another piece of (almost) useless data that we could stop sharing is the start_height in the version message, but that's maybe a different discussion 08:18 < amiti> yeah, exactly, they can't be exploited because we write logic to not rely on it 08:18 < ariard> Even assuming they're used by some lightclient p2p stack, inviting ecosystem-wise not relying on them due to their distrusted nature would be better 08:18 < sipa> we can stop using the nTime field without caring about what others do... if we'd start setting them differently (all zero? just the current time? random within some window?) we may want to seek opinions on the ml 08:19 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Remote host closed the connection] 08:19 < sdaftuar> agreed 08:19 < sipa> i imagine we'd do those at different points in time anyway 08:20 < gleb> Sipa: but Most of their use is already about setting them differently, it seems we mainly discussing dropping that :) 08:20 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 08:20 < gleb> or, well, using them to filter out responses I guess. We sort of “promised” to use them? 08:20 < gleb> whatever, i think we’re on the same page 08:20 < ariard> just set them to zero, in case of randomness source breakup that's not a fingerprint for your node 08:21 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 08:21 < gleb> Setting them to 0 would break compatibility 08:21 -!- grafa [~grafa@185.163.110.116] has joined #bitcoin-core-dev 08:21 < sipa> ariard: if our RNG has issues, we have bigger problems 08:22 < gleb> old nodes think that ntime < 10000000 is trash iirc 08:22 < sipa> ariard: and setting them to 0 would actively hurt relay chances on current code 08:22 < gleb> we probably should randomize them within a week window from now or so 08:22 < ariard> good to know, do we have other compatibility bounds to care about beyond ntime < 10000000 ? 08:23 < jnewbery> gleb: if time is < 100000000, we set it to some recent time: https://github.com/bitcoin/bitcoin/blob/f5bd46a4cc6d395ce71ecb99852c1774235a249c/src/net_processing.cpp#L2573-L2574 08:24 < gleb> Oh right, sorry, I’m on my phone 08:24 < jnewbery> maybe we just set it to MAX_UINT32 08:24 < sdaftuar> i have another related topic to mention while we're discussing addrman-- i opened a PR to fix some interactions between addrman and block-relay-only peers. it's a reversal from the direction i was leaning before about how this should work, so wanted to mention it in case anyone wanted to discuss 08:25 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Ping timeout: 272 seconds] 08:25 < sdaftuar> cc amiti and jnewbery as this came up during a recent PR under review 08:26 < jnewbery> #20187 08:26 < gribble> https://github.com/bitcoin/bitcoin/issues/20187 | Addrman: test-before-evict bugfix and improvements for block-relay-only peers by sdaftuar · Pull Request #20187 · bitcoin/bitcoin · GitHub 08:26 < sdaftuar> the tl;dr is that after looking into how eviction works from the new and tried tables, i decided it all works better to make sure that our block-relay-only peers in fact get moved to the tried table 08:27 < sdaftuar> which necessitates invoking addrman functions on those addresses and changing addrman state of course 08:27 < jnewbery> the change in net_processing seems reasonable to me. I haven't looked at the changes in net. 08:27 < sipa> right 08:27 < sdaftuar> but lots of things to consider (particularly privacy issues that are hard to reason about) so if someone spots a problem i'd love to discuss 08:28 < sdaftuar> one particular problem is if the timestamps we return in getaddr messages for those peers will stick out somehow! 08:28 < sipa> it's a balance beteeen not updating addrman to minimize detectability of block-only connections, and updating it to make sure we keep good ones 08:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:28 < bitcoin-git> [bitcoin] jonasschnelli opened pull request #20198: Show name, format and if uses descriptors in bitcoin-wallet tool (master...2020/10/wallet_tool_sqlite) https://github.com/bitcoin/bitcoin/pull/20198 08:28 < sdaftuar> yep 08:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:28 < amiti> the idea makes sense, I'll take a closer look at the code 08:29 < sdaftuar> (that's all i've got) 08:30 < jnewbery> While we're on the subject of addrman, it seems strange to me that it's owned by CConnMan. I think it makes sense to pull it out into a separate component that's owned by the node context object, so other components can access it directly. 08:30 < sipa> sdaftuar: do you believe there are more issues than fixed by your PR? 08:30 < jnewbery> Is there areason not to do that? 08:31 < ariard> what other components need access to addrman ? or might need in the future? 08:31 < sipa> jnewbery: whatever works 08:31 < jnewbery> ariard: net_processing and rpc 08:31 < gleb> No opinion on moving components around 08:31 < sdaftuar> sipa: not at the moment, i dont' think. the only other addrman-related thing i'm worrying about is addr relay i think 08:31 < sipa> and net 08:31 < sdaftuar> but that's a different type of issue 08:32 < jnewbery> currently net_processing access addrman through some forwarding functions in cconnman 08:32 < ariard> sounds good to move so 08:33 < jnewbery> any other topics before we wrap up? Anyone have any review begs? 08:34 < ariard> what outstanding p2p bugfixs/followups are required for current release ? 08:34 < jonatack> I plan to circle back soon to finish reviewing #19858 which looks pretty close 08:34 < gribble> https://github.com/bitcoin/bitcoin/issues/19858 | Periodically make block-relay connections and sync headers by sdaftuar · Pull Request #19858 · bitcoin/bitcoin · GitHub 08:34 -!- promag [~promag@dsl-5-27.bl27.telepac.pt] has quit [Remote host closed the connection] 08:34 -!- promag [~promag@dsl-5-27.bl27.telepac.pt] has joined #bitcoin-core-dev 08:35 < vasild> hi, I started looking into i2p support 08:35 < sdaftuar> jonatack: thanks -- guessing it won't be merged until after we branch off the next release though 08:35 < jnewbery> ariard: you can find current release issues/prs here: https://github.com/bitcoin/bitcoin/milestone/45 08:35 < sdaftuar> in case that affects your review priorities! 08:35 < jnewbery> (I have one review beg: the backport of wtxid relay to 0.20 #19606) 08:35 < gribble> https://github.com/bitcoin/bitcoin/issues/19606 | Backport wtxid relay to v0.20 by jnewbery · Pull Request #19606 · bitcoin/bitcoin · GitHub 08:36 < jnewbery> ok, seems like that's all. Thanks folks. See you in two weeks 08:36 < jonatack> vasild: nice! Oh, #20120 had 3 acks by vasild promag hebasto 08:36 < jnewbery> #endmeeting 08:36 < lightningbot> Meeting ended Tue Oct 20 15:36:26 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) 08:36 < lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-10-20-15.00.html 08:36 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-10-20-15.00.txt 08:36 < lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-10-20-15.00.log.html 08:36 < gribble> https://github.com/bitcoin/bitcoin/issues/20120 | net, rpc, test, bugfix: update GetNetworkName, GetNetworksInfo, regression tests by jonatack · Pull Request #20120 · bitcoin/bitcoin · GitHub 08:37 < jonatack> (it's more net than p2p) 08:37 < jnewbery> oh sorry vasild. I missed your message. Did you have more you wanted to share/discuss? 08:37 < vasild> no :) 08:37 < jnewbery> ok, I look forward to hearing more about it in another meeting then :) 08:43 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 08:52 -!- kexkey [~kexkey@89.36.78.166] has joined #bitcoin-core-dev 08:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:57 < bitcoin-git> [bitcoin] jonasschnelli opened pull request #20199: Ignoring (but warn) on dublicate -wallet parameters (master...2020/10/de-duplicate-wallets) https://github.com/bitcoin/bitcoin/pull/20199 08:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:58 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 09:03 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Ping timeout: 272 seconds] 09:25 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 09:26 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 09:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:26 < bitcoin-git> [bitcoin] adamjonas opened pull request #20200: doc: Remove breaking line of CODEOWNERS file (master...102020-fix-codeowners) https://github.com/bitcoin/bitcoin/pull/20200 09:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:29 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 272 seconds] 09:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:30 < bitcoin-git> [bitcoin] hebasto opened pull request #20201: build: pkg-config related cleanup (master...201020-pkg) https://github.com/bitcoin/bitcoin/pull/20201 09:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:31 < bitcoin-git> [bitcoin] achow101 opened pull request #20202: wallet: Make BDB support optional (master...opt-sqlite-bdb) https://github.com/bitcoin/bitcoin/pull/20202 09:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:31 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 09:36 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Ping timeout: 272 seconds] 09:38 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 09:38 -!- rabidus [~rabidus@dsl-olubng12-54fa0c-1.dhcp.inet.fi] has joined #bitcoin-core-dev 09:42 < hebasto> jonasschnelli: around? 09:48 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Remote host closed the connection] 10:12 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has quit [Remote host closed the connection] 10:15 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 272 seconds] 10:19 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 10:20 -!- lightlike [~lightlike@p200300c7ef213d00301373ab6ebfcb13.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 10:31 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 10:31 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 10:31 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 10:33 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection] 10:33 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev 10:37 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Remote host closed the connection] 10:38 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 10:42 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has quit [Ping timeout: 260 seconds] 10:47 -!- sr_gi [~sr_gi@static-128-69-224-77.ipcom.comunitel.net] has quit [Read error: Connection reset by peer] 10:47 -!- sr_gi [~sr_gi@static-128-69-224-77.ipcom.comunitel.net] has joined #bitcoin-core-dev 10:55 < luke-jr> achow101: did a UUID of some sort get in the SQLite wallet, to replace the BDB unique id? 10:55 < achow101> luke-jr: no. I think we determined it wasn't needed 10:55 < luke-jr> but it is 10:55 < luke-jr> ugh 10:55 < achow101> the BDB unique id is only needed to avoid some caching problem 10:55 < achow101> what is it needed for? 10:56 < luke-jr> prune locks, at least; who knows what else in the future 10:56 < achow101> how so? 10:56 < luke-jr> to uniquely identify a wallet no matter where the user moves/renames it 10:58 < achow101> it can be added in later 10:58 < luke-jr> not really 10:58 < luke-jr> backups made before the upgrade won't have it 11:00 -!- grafa [~grafa@185.163.110.116] has quit [] 11:03 < achow101> why do wallet files need to be uniquely identified? 11:03 < achow101> I remember looking at this before but I can't find the commit 11:06 < luke-jr> achow101: eg #19463 11:06 < gribble> https://github.com/bitcoin/bitcoin/issues/19463 | Prune locks by luke-jr · Pull Request #19463 · bitcoin/bitcoin · GitHub 11:06 < luke-jr> another example would be backup reminders 11:10 < achow101> i still don't see how not having a preexisting id is a problem. If you add the id to a wallet, and add the prune lock for that id, then we won't prune beyond the requirement for that wallet. when the backup is restored, sure a new id is generated, but we still haven't pruned too far 11:10 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has joined #bitcoin-core-dev 11:10 < achow101> it's just extra stuff in the db 11:17 < luke-jr> and have a poor UX because we have the wallet twice in prune locks confusing the user 11:17 < luke-jr> nevermind unknown future use cases 11:19 < achow101> sure, but a unique wallet id should not be at the db level 11:20 < sipa> having a warning for the user that two copies of the same wallets have been loaded seems moderately useful in any case 11:20 < achow101> we could make the id deterministic based on active spkman 11:21 < luke-jr> actually, right now users expect an error if they try to load two copies.. 11:21 < achow101> for legacy, use the current seed, or default key for the non-hd wallets as they still have default key. for descriptor, hash the active descriptors 11:21 < sipa> luke-jr: i usually just find it annoying that i can't load them at the same time :) 11:21 < sipa> but a warning seems useful 11:22 < achow101> the error for loading duplicates is because bdb has issues when duplicates are loaded, not for any functionality reason 11:22 < sipa> i know 11:22 -!- true-asset [~true-asse@89.47.234.28] has joined #bitcoin-core-dev 11:23 < luke-jr> achow101: "current" anything would be wrong since it can change 11:23 < sipa> luke-jr's argument is that users have come to rely on that behavior... i'm not convinced it is, but if it is, i think just documenting it in release notes that the same doesn't hold for sqlite/descriptor wallets is fine 11:23 < achow101> luke-jr: if it changes, then you have a new backup.. 11:24 < achow101> it's arguably not the same wallet 11:28 < achow101> luke-jr: you could also just prompt people to make a backup of their wallet(s) when they first use prune locks 11:31 < luke-jr> more bad UX for no reason 11:33 < achow101> let me rephrase my earlier suggestion: for wallets missing a unique id, compute one based on the contents of that wallet (e.g. seed, default key, descriptors) at that time. 11:33 < achow101> for valid backups of that wallet, the id will be the same. otherwise that backup is useless 11:34 < achow101> this id persists, so later backups will have the same id 11:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:34 < bitcoin-git> [bitcoin] luke-jr opened pull request #20204: Wallet: Generate UUID for SQLite wallets (master...sqlite_wallet_uuid) https://github.com/bitcoin/bitcoin/pull/20204 11:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:35 < jonasschnelli> hebasto: yes. now. But not for long. 11:35 < luke-jr> achow101: but older backups might not 11:35 < luke-jr> might as well just fix it now and avoid the mess later entirely 11:35 < achow101> luke-jr: why would they not? 11:36 < luke-jr> achow101: perhaps the user has rotated their seed 11:36 < achow101> then they made a new backup with the new seed 11:36 < achow101> and should be restoring that one 11:40 < luke-jr> oh, and since Core refuses to consider compatibility with non-Core wallets, this could mean it's not safe to use it until Core releases prune locks itself 11:40 < achow101> huh? 11:43 < luke-jr> achow101: for example, I couldn't put sqlite wallet + prune locks in Knots without a risk Core breaks it in the future 11:43 < luke-jr> Knots already has BDB + prune locks, which is safe because it doesn't require any wallet format changes 11:45 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex] 11:48 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 11:52 < jonasschnelli> achow101: do you have a clue why the wallet_hd --descriptor test is failing on bitcoinbuilds.org: https://bitcoinbuilds.org/index.php?ansilog=93718c91-dfa1-4b09-b5ac-5e82f75f4563.log#l6112? 11:56 < achow101> jonasschnelli: is that master? 11:56 < jonasschnelli> no... a PR. But it fails also on master. 11:56 < jonasschnelli> achow101: master would be here: https://bitcoinbuilds.org/index.php?build=3771 11:57 < jonasschnelli> (different error though) 12:01 < achow101> well the problem is this: "[default_wallet] CDataStream::read(): end of data: iostream error " 12:02 < achow101> so some record is too short 12:02 < achow101> but I can't replicate locally 12:06 < achow101> jonasschnelli: oh, it's luke-jr's uuid pr. the record is not written with our CDataStream stuff so it isn't correctly formatted 12:06 < achow101> master is a different problem 12:07 < jonasschnelli> Don't focus on lukes PR. I just saw that all PRs fail (as well as master)... 12:07 < jonasschnelli> so if you have a hint here (https://bitcoinbuilds.org/index.php?ansilog=25c20237-3134-4099-9b5a-d618161eae99.log#l61609) (master) that would be great 12:10 < luke-jr> achow101: huh? how isn't it? 12:11 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 256 seconds] 12:14 < achow101> luke-jr: whoops, forgot that DBBatch does use CDataStream. something's wrong with the length writing though 12:15 < luke-jr> ah, because it's const char[5] instead of std::string 12:15 -!- shesek [~shesek@164.90.217.137] has joined #bitcoin-core-dev 12:15 -!- shesek [~shesek@164.90.217.137] has quit [Changing host] 12:15 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 12:16 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 12:17 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex] 12:20 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:46 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has quit [Remote host closed the connection] 12:47 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has joined #bitcoin-core-dev 13:00 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Quit: Konversation terminated!] 13:02 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 13:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:06 < bitcoin-git> [bitcoin] achow101 opened pull request #20205: wallet: Properly support a wallet id (master...wallet-id) https://github.com/bitcoin/bitcoin/pull/20205 13:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:13 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer] 13:14 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 13:22 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 13:34 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 13:36 -!- chri_eb_ [~chris@gateway/tor-sasl/chrieb/x-28824719] has joined #bitcoin-core-dev 13:46 -!- user____ [~user@mail.deeplinkmedia.com] has joined #bitcoin-core-dev 13:50 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev 13:52 -!- user____ [~user@mail.deeplinkmedia.com] has quit [Quit: leaving] 13:52 -!- user____ [~user@mail.deeplinkmedia.com] has joined #bitcoin-core-dev 13:53 -!- user____ [~user@mail.deeplinkmedia.com] has quit [Client Quit] 13:53 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 13:56 -!- user____ [~user@mail.deeplinkmedia.com] has joined #bitcoin-core-dev 13:58 -!- chri_eb_ [~chris@gateway/tor-sasl/chrieb/x-28824719] has quit [Quit: chri_eb_] 14:00 -!- true-asset [~true-asse@89.47.234.28] has quit [] 14:01 -!- user____ [~user@mail.deeplinkmedia.com] has quit [Quit: leaving] 14:04 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 14:05 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 14:15 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 14:19 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 14:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:20 < bitcoin-git> [bitcoin] hebasto opened pull request #20206: wallet, refactor: Include headers instead of function declarations (master...201020-headers) https://github.com/bitcoin/bitcoin/pull/20206 14:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:22 -!- cassier [~cassier@195.206.169.184] has joined #bitcoin-core-dev 14:25 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex] 14:32 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 14:39 < achow101> jonasschnelli: I don't know what's wrong with that failure 15:00 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Remote host closed the connection] 15:04 -!- murray_ [~murray@static.38.4.181.135.clients.your-server.de] has left #bitcoin-core-dev [] 15:05 -!- murrayn [~murray@unaffiliated/murrayn] has joined #bitcoin-core-dev 15:11 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 15:13 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 15:23 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Ping timeout: 240 seconds] 15:29 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 15:33 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-hsmoouzzvmgsxqbl] has quit [Ping timeout: 272 seconds] 15:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 15:36 < bitcoin-git> [bitcoin] sipa opened pull request #20207: Follow-up extra comments on taproot code and tests (master...202010_taproot-comments) https://github.com/bitcoin/bitcoin/pull/20207 15:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 15:43 -!- meshcollider [meshcollid@gateway/shell/ircnow/x-pqgwfdruhplhobfa] has joined #bitcoin-core-dev 15:46 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 15:51 -!- filchef [~filchef@212.104.97.177] has quit [Quit: KVIrc 5.0.0 Aria http://www.kvirc.net/] 16:07 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 16:07 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 16:11 -!- lightlike [~lightlike@p200300c7ef213d00301373ab6ebfcb13.dip0.t-ipconnect.de] has quit [Quit: Leaving] 16:13 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 16:16 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 16:17 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Quit: Leaving] 16:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 16:34 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 16:34 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has joined #bitcoin-core-dev 16:37 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 16:46 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 16:58 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Ping timeout: 240 seconds] 17:00 -!- cassier [~cassier@195.206.169.184] has quit [] 17:59 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has joined #bitcoin-core-dev 18:07 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Ping timeout: 260 seconds] 18:08 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev 18:10 -!- worc3131 [~quassel@2a02:c7f:c026:9500:a0d2:b9d1:42a4:69b4] has quit [Ping timeout: 272 seconds] 18:31 -!- MarconM [~MarconM@217.146.82.202] has joined #bitcoin-core-dev 18:38 -!- solitonmedic [~tougou@cpe-68-174-133-242.nyc.res.rr.com] has joined #bitcoin-core-dev 18:44 -!- jesseposner [~jesse@98.37.146.62] has joined #bitcoin-core-dev 18:52 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 18:53 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 246 seconds] 19:21 -!- spinza [~spin@102.132.245.16] has quit [Read error: Connection reset by peer] 19:33 -!- per [~per@gateway/tor-sasl/wsm] has quit [Remote host closed the connection] 19:33 -!- per [~per@gateway/tor-sasl/wsm] has joined #bitcoin-core-dev 19:33 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev 19:52 -!- S3RK [~S3RK@116.118.73.30] has joined #bitcoin-core-dev 19:54 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds] 19:54 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 20:00 -!- MarconM [~MarconM@217.146.82.202] has quit [] 20:14 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 20:17 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 258 seconds] 20:18 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 20:22 -!- jonatack [~jon@213.152.162.99] has quit [Ping timeout: 265 seconds] 20:24 -!- jonatack [~jon@88.124.242.136] has joined #bitcoin-core-dev 20:52 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 246 seconds] 20:57 -!- banux1 [~banux@217.146.82.202] has joined #bitcoin-core-dev 21:34 -!- ares_ [~ares@gateway/tor-sasl/virtu] has quit [Remote host closed the connection] 21:34 -!- ares_ [~ares@gateway/tor-sasl/virtu] has joined #bitcoin-core-dev 22:04 -!- solitonmedic [~tougou@cpe-68-174-133-242.nyc.res.rr.com] has quit [Remote host closed the connection] 22:05 -!- solitonmedic [~tougou@cpe-68-174-133-242.nyc.res.rr.com] has joined #bitcoin-core-dev 22:06 -!- da39a3ee5e6b4b0d [~textual@n11211935170.netvigator.com] has joined #bitcoin-core-dev 22:07 < S3RK> achow101: wrt #19137 what is the value in allowing users to create legacy-sqlite and descriptor-bdb? You mentioned that you want to tie descriptor wallets to sqlite, so why not go straight to new migratewallet command? 22:07 < gribble> https://github.com/bitcoin/bitcoin/issues/19137 | wallettool: Add dump and createfromdump commands by achow101 · Pull Request #19137 · bitcoin/bitcoin · GitHub 22:09 < achow101> S3RK: it's a concession to those who want those but not an outright easy to use kind of thing 22:10 < achow101> also because those commands are useful for some debugging stuff and I'd hate to have to put any actual wallet application logic on those commands 22:15 < S3RK> hm.. I see that it could be useful for debugging. But what are the reasons for people to want those "non-standard" options? 22:16 < S3RK> just curious 22:18 < achow101> some people might want to make a legacy-sqlite because descriptor wallets are different enough that it has different behavior that they are concerned the migration will miss 22:18 < achow101> I don't think descriptor-bdb will be something that people will want 22:18 < sipa> agree 22:18 < sipa> i may convert my bdb-legacy wallets to sqlite-legacy though, if that's somewhat supported 22:19 < achow101> but also anyone who has made a descriptor wallet with master since the pr was merged will have descriptor-bdb and may want to make them descriptor-sqlite 22:20 < achow101> sipa: it should work, but will be eventually unsupported (see #20160) 22:20 < gribble> https://github.com/bitcoin/bitcoin/issues/20160 | Proposed Timeline for Legacy Wallet and BDB removal · Issue #20160 · bitcoin/bitcoin · GitHub 22:22 < sipa> achow101: if there is a way to convert legacy to descriptor, sure :) 22:22 < achow101> it'd be a lot easier if there was some way to test whether a set of scripts exactly matches everything IsMine will match on 22:23 < sipa> all you need is a way to generate a strict superset of that 22:23 < sipa> and then run IsMine on all elements of the superset in both 22:24 < achow101> how does one make this superset? 22:25 < sipa> go over all keys, scripts, pubkeys, scripthashes, and do everything you can with all of them 22:25 < sipa> P2PK, P2PKH, P2WPKH, P2SH-P2WPKH for all pubkeys/script, raw/P2SH/P2WSH for all scripts, P2SH/P2WSH for all scripthashes, ... 22:26 < achow101> have you seem #19602 22:26 < gribble> https://github.com/bitcoin/bitcoin/issues/19602 | wallet: Migrate legacy wallets to descriptor wallets by achow101 · Pull Request #19602 · bitcoin/bitcoin · GitHub 22:27 < achow101> specifically https://github.com/bitcoin/bitcoin/pull/19602/commits/628642df517d4b0e3d29c0fa77048805e8248f96 22:28 < sipa> well you'll want to call old.IsMine() on each generated candidate to determine whether to import it in new 22:28 < sipa> with more involved logic you can avoid that, but that'd mean duplication some of the IsMine logic 22:29 < achow101> I think one of the other commits does that 22:30 < achow101> the problem is moreso that a scriptPubKey is missing rather than a generated scriptPubKey is not IsMine 22:30 < sipa> right 22:30 -!- jesseposner [~jesse@98.37.146.62] has quit [Ping timeout: 265 seconds] 22:31 < achow101> and that requires convincing yourself that your understanding of IsMine is correct 22:32 < sipa> i think it's doable to get reasonable confidence in an ability to generate a superset 22:32 < sipa> go over all standard script templates, and construct all of them with all the elements you have 22:33 < achow101> I did that... and still missed something 22:33 < sipa> anyway, no urgency for that, i think 22:33 < sipa> ah, what did you miss? 22:33 < Bullit> about 17000 comments 22:34 < achow101> I think it was something about watchonly 22:35 < achow101> might've been the thing where a multisig is not our unless we have all of the keys 22:36 -!- ares_ [~ares@gateway/tor-sasl/virtu] has quit [Remote host closed the connection] 22:46 -!- glozow [uid453516@gateway/web/irccloud.com/x-fcolakpxkpqjawlp] has quit [Quit: Connection closed for inactivity] 22:46 -!- ares_ [~ares@gateway/tor-sasl/virtu] has joined #bitcoin-core-dev 22:54 < S3RK> achow101: thanks for the explanation. Could you look at #20153 ? If I didn't miss anything than it could discourage people by breaking their descriptor wallets. 22:54 < gribble> https://github.com/bitcoin/bitcoin/issues/20153 | wallet: do not import a descriptor with hardened derivations into a watch-only wallet by S3RK · Pull Request #20153 · bitcoin/bitcoin · GitHub 22:57 -!- jesseposner [~jesse@98.37.146.62] has joined #bitcoin-core-dev 23:00 -!- banux1 [~banux@217.146.82.202] has quit [] 23:00 -!- aj [aj@cerulean.erisian.com.au] has quit [Quit: .] 23:01 -!- solitonmedic [~tougou@cpe-68-174-133-242.nyc.res.rr.com] has quit [Quit: Leaving] 23:03 -!- jesseposner [~jesse@98.37.146.62] has quit [Ping timeout: 246 seconds] 23:04 -!- nothingmuch [~nothingmu@unaffiliated/nothingmuch] has quit [Ping timeout: 260 seconds] 23:04 -!- bsm117532 [~bsm117532@unaffiliated/bsm117532] has quit [Ping timeout: 260 seconds] 23:05 -!- lightningbot [~supybot@2400:8901::f03c:91ff:febb:bbc1] has quit [Read error: Connection reset by peer] 23:05 -!- bsm117532 [~bsm117532@unaffiliated/bsm117532] has joined #bitcoin-core-dev 23:05 -!- lightningbot [~supybot@2400:8901::f03c:91ff:febb:bbc1] has joined #bitcoin-core-dev 23:06 -!- ares_ [~ares@gateway/tor-sasl/virtu] has quit [Remote host closed the connection] 23:06 -!- ares_ [~ares@gateway/tor-sasl/virtu] has joined #bitcoin-core-dev 23:07 -!- nothingmuch [~nothingmu@unaffiliated/nothingmuch] has joined #bitcoin-core-dev 23:07 -!- aj [aj@cerulean.erisian.com.au] has joined #bitcoin-core-dev 23:18 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 23:20 -!- Andy2011Zoe [~Andy2011Z@217.146.82.202] has joined #bitcoin-core-dev 23:30 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 23:38 -!- chri_eb [~chris@gateway/tor-sasl/chrieb/x-28824719] has joined #bitcoin-core-dev 23:39 -!- jesseposner [~jesse@98.37.146.62] has joined #bitcoin-core-dev 23:43 -!- jesseposner [~jesse@98.37.146.62] has quit [Ping timeout: 256 seconds] 23:46 -!- andreacab [~andreacab@host-87-15-1-196.retail.telecomitalia.it] has joined #bitcoin-core-dev 23:47 -!- opsec_x12 [~opsec_x12@44-25-143-49.ip.hamwan.net] has quit [Read error: Connection reset by peer] 23:47 -!- tougou [~tougou@cpe-68-174-133-242.nyc.res.rr.com] has joined #bitcoin-core-dev 23:47 -!- tougou [~tougou@cpe-68-174-133-242.nyc.res.rr.com] has quit [Client Quit] 23:47 -!- opsec_x12 [~opsec_x12@44-25-143-49.ip.hamwan.net] has joined #bitcoin-core-dev 23:47 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 260 seconds] 23:51 -!- opsec_x12 [~opsec_x12@44-25-143-49.ip.hamwan.net] has quit [Read error: Connection reset by peer] 23:51 -!- opsec_x12 [~opsec_x12@44-25-143-49.ip.hamwan.net] has joined #bitcoin-core-dev --- Log closed Wed Oct 21 00:00:53 2020