--- Log opened Fri Oct 23 00:00:55 2020
00:06 < fanquake> Have queried GitHub in regards to CODEOWNERS and it's write permissions requirement. re #20200. https://0bin.net/paste/ZYpiRX9U#s67wu+CndcC5mYMooLlnvzqN5SrKW8119sQOKLa+Ju3
00:06 < gribble> https://github.com/bitcoin/bitcoin/issues/20200 | doc: revert #18949 since CODEOWNERS require write permission by adamjonas · Pull Request #20200 · bitcoin/bitcoin · GitHub
00:32 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 240 seconds]
00:33 -!- AdulrunaRedviva [c3d69d22@195.214.157.34] has joined #bitcoin-core-dev
00:35 -!- kabaum [~kabaum@h-13-35.A163.priv.bahnhof.se] has joined #bitcoin-core-dev
00:44 -!- jonatack [~jon@213.152.161.170] has quit [Ping timeout: 264 seconds]
00:47 -!- jesseposner [~jesse@98.37.146.62] has quit [Ping timeout: 272 seconds]
00:51 -!- mrostecki_ [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Remote host closed the connection]
01:02 -!- landakram [~mark@2601:642:100:33e0:38bd:cc14:7348:4a22] has joined #bitcoin-core-dev
01:08 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev
01:12 -!- jesseposner [~jesse@98.37.146.62] has joined #bitcoin-core-dev
01:19 -!- jesseposner [~jesse@98.37.146.62] has quit [Ping timeout: 256 seconds]
01:22 -!- wxss [~user@mail.deeplinkmedia.com] has quit [Quit: leaving]
01:23 -!- wxss [~user@mail.deeplinkmedia.com] has joined #bitcoin-core-dev
01:29 -!- jonatack [~jon@213.152.162.74] has joined #bitcoin-core-dev
01:31 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
01:35 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 256 seconds]
01:36 -!- kephra [~kephra@178.239.168.171] has quit [Remote host closed the connection]
01:47 -!- jesseposner [~jesse@98.37.146.62] has joined #bitcoin-core-dev
01:49 -!- andreacab [~andreacab@2001:b07:ad4:8982:d37:cc33:2b1b:46be] has joined #bitcoin-core-dev
01:52 -!- andreacab [~andreacab@2001:b07:ad4:8982:d37:cc33:2b1b:46be] has quit [Remote host closed the connection]
01:52 -!- andreacab [~andreacab@2001:b07:ad4:8982:d37:cc33:2b1b:46be] has joined #bitcoin-core-dev
01:52 -!- jesseposner [~jesse@98.37.146.62] has quit [Ping timeout: 260 seconds]
02:10 -!- andreacab [~andreacab@2001:b07:ad4:8982:d37:cc33:2b1b:46be] has quit [Remote host closed the connection]
02:10 -!- andreacab [~andreacab@2001:b07:ad4:8982:d37:cc33:2b1b:46be] has joined #bitcoin-core-dev
02:13 -!- prayank23 [~andr0irc@2405:205:252d:96c1:8d70:955c:c207:9d3a] has joined #bitcoin-core-dev
02:14 -!- andreacab [~andreacab@2001:b07:ad4:8982:d37:cc33:2b1b:46be] has quit [Ping timeout: 240 seconds]
02:16 -!- jesseposner [~jesse@98.37.146.62] has joined #bitcoin-core-dev
02:22 -!- DuncanT1 [~DuncanT@178.238.229.54] has joined #bitcoin-core-dev
02:26 < jonasschnelli> achow101: I guess your answer for https://github.com/bitcoin-core/gui/pull/43 would be welcome.
02:26 < jonasschnelli> (trying to close that PR)
02:40 -!- jesseposner [~jesse@98.37.146.62] has quit [Ping timeout: 260 seconds]
02:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:43 < bitcoin-git> [bitcoin] jnewbery opened pull request #20228: [addrman] Make addrman a top-level component (master...2020-10-addrman) https://github.com/bitcoin/bitcoin/pull/20228
02:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:50 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex]
02:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:55 < bitcoin-git> [bitcoin] jonasschnelli pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/9af7c1993b35...49984b44cfcd
02:55 < bitcoin-git> bitcoin/master 8071c75 Hennadii Stepanov: qt, refactor: Limit scope of QPainter object
02:55 < bitcoin-git> bitcoin/master 6954156 Hennadii Stepanov: qt: Fix visual quality of text in QR image
02:55 < bitcoin-git> bitcoin/master 49984b4 Jonas Schnelli: Merge bitcoin-core/gui#71: Fix visual quality of text in QR image
02:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:11 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
03:12 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
03:14 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Ping timeout: 240 seconds]
03:20 -!- Cathrine21Kuhic [~Cathrine2@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev
03:24 -!- kyoo[m] [kyoomatrix@gateway/shell/matrix.org/x-wjrvikkainhcxlwc] has quit [Quit: killed]
03:24 -!- awesome_doge [awesome-do@gateway/shell/matrix.org/x-nyaqghsnbgpalekn] has quit [Quit: killed]
03:24 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-znsexcvbrpqeuydj] has quit [Quit: killed]
03:24 -!- Pasta[m] [pastapas1@gateway/shell/matrix.org/x-uawgxogisyrllude] has quit [Quit: killed]
03:24 -!- snowkeld[m] [snowkeldma@gateway/shell/matrix.org/x-gfaiyodbrvpiocct] has quit [Quit: killed]
03:24 -!- rCapital-Surpris [crtn32002m@gateway/shell/matrix.org/x-twvftpnsaszuavpj] has quit [Quit: killed]
03:24 -!- RaphalBentgeac[m [raphaelben@gateway/shell/matrix.org/x-simcfrbvrxngvotq] has quit [Quit: killed]
03:24 -!- tianshi[m] [tianshimat@gateway/shell/matrix.org/x-xcdqsbxtuhyiqtzj] has quit [Quit: killed]
03:24 -!- TheFuzzStone[m] [thefuzzsto@gateway/shell/matrix.org/x-tdoeegdpmdfblkqr] has quit [Quit: killed]
03:28 -!- Cathrine21Kuhic [~Cathrine2@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 264 seconds]
03:32 -!- tianshi[m] [tianshimat@gateway/shell/matrix.org/x-jhojfbdajjaoebou] has joined #bitcoin-core-dev
03:37 -!- andreacab [~andreacab@2001:b07:ad4:8982:d99a:4aed:d384:62c1] has joined #bitcoin-core-dev
03:37 < jonasschnelli> I'm again banned in #bitcoin-dev and #bitcoin and #bitcoin-wizards ... if anyone know how to unban: thanks.
03:40 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
03:46 -!- andreacab [~andreacab@2001:b07:ad4:8982:d99a:4aed:d384:62c1] has quit [Remote host closed the connection]
03:47 -!- willcl_ark [~quassel@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Ping timeout: 264 seconds]
03:48 -!- snowkeld[m] [snowkeldma@gateway/shell/matrix.org/x-sbfuejevikgxhirq] has joined #bitcoin-core-dev
03:48 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-bexixapckmdedwln] has joined #bitcoin-core-dev
03:48 -!- TheFuzzStone[m] [thefuzzsto@gateway/shell/matrix.org/x-eojdtwlzolbqvndj] has joined #bitcoin-core-dev
03:48 -!- awesome_doge [awesome-do@gateway/shell/matrix.org/x-rxhpxlbaoteoamcv] has joined #bitcoin-core-dev
03:48 -!- kyoo[m] [kyoomatrix@gateway/shell/matrix.org/x-tvrbeptqwvrmietd] has joined #bitcoin-core-dev
03:48 -!- rCapital-Surpris [crtn32002m@gateway/shell/matrix.org/x-cjjnwfskkjjjiccx] has joined #bitcoin-core-dev
03:48 -!- Pasta[m] [pastapas1@gateway/shell/matrix.org/x-fcsmvphbsepzikyz] has joined #bitcoin-core-dev
03:48 -!- RaphalBentgeac[m [raphaelben@gateway/shell/matrix.org/x-ngiqrfyaklwgnpqv] has joined #bitcoin-core-dev
03:54 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
03:54 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
03:55 -!- andreacab [~andreacab@2001:b07:ad4:8982:a86b:d8c4:b6ea:97fb] has joined #bitcoin-core-dev
03:58 -!- willcl_ark [~quassel@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #bitcoin-core-dev
04:12 -!- jonatack [~jon@213.152.162.74] has quit [Ping timeout: 272 seconds]
04:18 -!- Monty47Hintz [~Monty47Hi@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev
04:20 -!- andreacab [~andreacab@2001:b07:ad4:8982:a86b:d8c4:b6ea:97fb] has quit [Remote host closed the connection]
04:20 -!- andreacab [~andreacab@2001:b07:ad4:8982:a86b:d8c4:b6ea:97fb] has joined #bitcoin-core-dev
04:23 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection]
04:25 -!- andreacab [~andreacab@2001:b07:ad4:8982:a86b:d8c4:b6ea:97fb] has quit [Ping timeout: 260 seconds]
04:30 -!- andreacab [~andreacab@2001:b07:ad4:8982:ad65:a24f:8dfb:c0a1] has joined #bitcoin-core-dev
04:36 -!- jesseposner [~jesse@98.37.146.62] has joined #bitcoin-core-dev
04:39 -!- andreacab [~andreacab@2001:b07:ad4:8982:ad65:a24f:8dfb:c0a1] has quit [Remote host closed the connection]
04:50 -!- jesseposner [~jesse@98.37.146.62] has quit [Ping timeout: 256 seconds]
05:00 -!- DuncanT1 [~DuncanT@178.238.229.54] has quit []
05:00 -!- Monty47Hintz [~Monty47Hi@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 240 seconds]
05:01 -!- jtimon [~quassel@146.228.11.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
05:03 < jtimon> is activation being discussed somewhere else beyond the thread "Modern Soft Fork Activation"  ?
05:03 < jtimon> or is the discussion stuck? I'll re-read, but I remember feeling like my points weren't being addressed
05:04 < fanquake> There is ##taproot-activation if you aren't in there already
05:04 < jtimon> I asked questions that I'm pretty sure were ignored
05:04 < jtimon> fanquake: awesome, thanks
05:05 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
05:19 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 256 seconds]
05:20 -!- oerjan [~oerjan@s91904426.blix.com] has joined #bitcoin-core-dev
05:27 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Ping timeout: 240 seconds]
05:34 -!- sr_gi [~sr_gi@static-128-69-224-77.ipcom.comunitel.net] has quit [Read error: Connection reset by peer]
05:35 -!- sr_gi [~sr_gi@static-128-69-224-77.ipcom.comunitel.net] has joined #bitcoin-core-dev
05:36 -!- kabaum [~kabaum@h-13-35.A163.priv.bahnhof.se] has quit [Ping timeout: 260 seconds]
05:38 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev
05:42 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
05:44 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev
05:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:47 < bitcoin-git> [bitcoin] bitcoin-foundation-admin opened pull request #20229: Adding a new Bitcoin logo, and release it under the public domain license. (master...master) https://github.com/bitcoin/bitcoin/pull/20229
05:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:48 -!- kljasdfvv [~flack@p200300d46f015200480a4dc458c894c0.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!]
05:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:54 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #20229: Adding a new Bitcoin logo, and release it under the public domain license. (master...master) https://github.com/bitcoin/bitcoin/pull/20229
05:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:54 < jonasschnelli> Lol #20229
05:54 < gribble> https://github.com/bitcoin/bitcoin/issues/20229 | Adding a new Bitcoin logo, and release it under the public domain license. by bitcoin-foundation-admin · Pull Request #20229 · bitcoin/bitcoin · GitHub
05:55 < jonasschnelli> On the other hand... they are right about the metadata in my original SVG
05:56 < jonasschnelli> MarcoFalke: not sure if removing the description text helps much... now they certainly claim censorship
05:57 < queip> that's the joke there? png version looks normal
05:57 < queip> btw lol  at what ever SVG editor: rgb(96.862745%, that's really precise RGB :o
05:58 < jonasschnelli> I guess my SVG is bad because I think I used Adobe Illustrator to create it and haven't cleand it.
05:59 < jonasschnelli> MarcoFalke: good point about the website... probably good you have removed that text
05:59 < jonasschnelli> The SV people recently started foundation activity in Switzerland.... I think its them. The webpage also links to bitcoin.com.
06:01 < MarcoFalke> The website asks for donations. Obviously don't send anything to their address
06:01 < MarcoFalke> I thought we blocked them already last time they spammed
06:01 < MarcoFalke> Maybe it's a new account
06:01 < fanquake> there's always a new account
06:03 -!- jonatack [~jon@213.152.162.114] has joined #bitcoin-core-dev
06:04 -!- jonatack [~jon@213.152.162.114] has quit [Client Quit]
06:04 -!- jonatack [~jon@213.152.162.114] has joined #bitcoin-core-dev
06:08 -!- asoltys [~root@s207-81-214-2.bc.hsia.telus.net] has joined #bitcoin-core-dev
06:08 -!- kljasdfvv [~flack@p200300d46f015200c90611daae55a4c8.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
06:25 -!- kljasdfvv [~flack@p200300d46f015200c90611daae55a4c8.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
06:25 -!- kljasdfvv [~flack@p200300d46f015200c90611daae55a4c8.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
06:28 -!- sr_gi2 [~sr_gi@static-128-69-224-77.ipcom.comunitel.net] has joined #bitcoin-core-dev
06:28 -!- sr_gi [~sr_gi@static-128-69-224-77.ipcom.comunitel.net] has quit [Quit: Ping timeout (120 seconds)]
06:28 -!- corollari__ [sid405633@gateway/web/irccloud.com/x-kxzrsmsgraquiztk] has quit [Ping timeout: 260 seconds]
06:29 -!- alko89 [~alko89@unaffiliated/alko89] has quit [Remote host closed the connection]
06:29 -!- sr_gi2 is now known as sr_gi
06:29 -!- justinmoon [~quassel@157.245.122.126] has quit [Quit: No Ping reply in 180 seconds.]
06:30 -!- corollari__ [sid405633@gateway/web/irccloud.com/x-mmtqtinsxduvodfk] has joined #bitcoin-core-dev
06:31 -!- justinmoon [~quassel@157.245.122.126] has joined #bitcoin-core-dev
06:31 -!- alko89 [~alko89@unaffiliated/alko89] has joined #bitcoin-core-dev
06:38 < queip> MarcoFalke: probably that troll, now asks in #bitcoin with some fake DMCA I  guess
06:40 < MarcoFalke> What a time sink. Best to ignore
06:41 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
06:42  * queip thumbsup. recently some fake-DMCA abusers got counter sued and lost money, just to keep in mind
06:46 -!- jesseposner [~jesse@98.37.146.62] has joined #bitcoin-core-dev
06:50 < kinlo> heh, it has been quite a while since I had someone using all the insults he can think of in my private windows :)
06:52 < queip> I am curious now, they commited some bitcoin.svg just to change git glame to them or something, got rejected, and now are DMCA-mad that their pressious bitcoin.svg sits there in PR? or smth? (besides that svg file is 404 anyway already)
06:52 < kinlo> do they really open dmca takedowns @ github?
06:52 -!- jesseposner [~jesse@98.37.146.62] has quit [Ping timeout: 264 seconds]
06:53 -!- oerjan [~oerjan@s91904426.blix.com] has quit [Remote host closed the connection]
06:53 < queip> kinlo: if yes then great opportunity to ditch github. Or at least prepare to do so in future. if we distribute PRs, Issues, and maybe searching all servers for git remote modules, then we can ignore any such problems. anyway if bitcoin GH is officially mirrored to other gits, wouldn't hurt to promote that knowledge in places
06:54 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds]
06:54 < kinlo> queip: surely github has experience with children trying to annoy their dmca department
06:55 < kinlo> given the talk he gave me in private, I don't think he's very mature
06:59 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
07:01 -!- b_b1 [~b_b@185.244.214.217] has joined #bitcoin-core-dev
07:29 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev
07:37 -!- darosior [~darosior@194.36.189.246] has quit [Quit: Ping timeout (120 seconds)]
07:39 -!- xurzua [~xurzua@181.74.31.104] has joined #bitcoin-core-dev
07:39 < jonasschnelli> For the one not following the GUI repository: https://github.com/bitcoin-core/gui/pull/108 (interactive mempool statistics). Ideas, reviews and testing welcome
07:42 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
07:44 < jonasschnelli> join #bitcoin-core-gui
07:47 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has quit [Quit: Lost terminal]
07:47 -!- andytoshi [~apoelstra@wpsoftware.net] has joined #bitcoin-core-dev
07:47 -!- andytoshi [~apoelstra@wpsoftware.net] has quit [Changing host]
07:47 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has joined #bitcoin-core-dev
07:53 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has quit [Remote host closed the connection]
07:53 -!- andytoshi [~apoelstra@wpsoftware.net] has joined #bitcoin-core-dev
07:53 -!- andytoshi [~apoelstra@wpsoftware.net] has quit [Changing host]
07:53 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has joined #bitcoin-core-dev
08:00 -!- b_b1 [~b_b@185.244.214.217] has quit []
08:01 < jonasschnelli> ##bitcoin-core-gui
08:20 -!- robotadam1 [~robotadam@154.13.1.56] has joined #bitcoin-core-dev
08:24 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
08:28 -!- jesseposner [~jesse@98.37.146.62] has joined #bitcoin-core-dev
08:28 -!- xurzua [~xurzua@181.74.31.104] has quit [Ping timeout: 258 seconds]
08:30 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex]
08:34 -!- jesseposner [~jesse@98.37.146.62] has quit [Ping timeout: 246 seconds]
08:35 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
08:39 -!- jesseposner [~jesse@98.37.146.62] has joined #bitcoin-core-dev
08:40 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
08:45 -!- kyoo[m] [kyoomatrix@gateway/shell/matrix.org/x-tvrbeptqwvrmietd] has quit [Ping timeout: 244 seconds]
08:48 -!- kyoo[m] [kyoomatrix@gateway/shell/matrix.org/x-bbpxarfwoqwpngyc] has joined #bitcoin-core-dev
08:49 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Remote host closed the connection]
08:53 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev
08:57 -!- ni291187 [~u931732@149.255.250.7] has joined #bitcoin-core-dev
08:57 -!- ni291187 [~u931732@149.255.250.7] has left #bitcoin-core-dev []
09:04 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
09:09 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds]
09:20 -!- bosch [7a94fe5f@122-148-254-95.sta.wbroadband.net.au] has joined #bitcoin-core-dev
09:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:28 < bitcoin-git> [bitcoin] hebasto opened pull request #20230: wallet: Fix bug when just created encrypted wallet cannot get address (master...201023-signal) https://github.com/bitcoin/bitcoin/pull/20230
09:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:46 -!- kexkey [~kexkey@static-198-54-132-142.cust.tzulo.com] has joined #bitcoin-core-dev
09:50 -!- nejon_ [sid38993@gateway/web/irccloud.com/x-tfdptfkfagjtjifr] has joined #bitcoin-core-dev
09:50 -!- rich [rich@2600:3c00::f03c:92ff:fe8e:dce6] has joined #bitcoin-core-dev
09:51 -!- ahmed__ [sid14086@gateway/web/irccloud.com/x-tjizlrtftbrptvgj] has joined #bitcoin-core-dev
09:51 -!- harding_ [quassel@2600:3c03::f03c:91ff:fe7b:78d1] has joined #bitcoin-core-dev
09:52 -!- willcl_ark_ [~quassel@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #bitcoin-core-dev
09:52 -!- windsok_ [~windsok@rarepepe.cash] has joined #bitcoin-core-dev
09:57 -!- Netsplit *.net <-> *.split quits: harding, mrostecki, davterra, k3tan, ares_, braydonf, paultroon, sdaftuar, andrewtoth, windsok,  (+14 more, use /NETSPLIT to show all of them)
09:57 -!- nejon_ is now known as nejon
09:57 -!- ahmed__ is now known as ahmed_
10:04 -!- Netsplit over, joins: Murch
10:05 -!- awesome_doge [awesome-do@gateway/shell/matrix.org/x-tfhrfhquwmimigoi] has joined #bitcoin-core-dev
10:07 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex]
10:10 -!- ctrlbreak_MAD [~ctrlbreak@159.2.182.106] has quit [Remote host closed the connection]
10:10 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
10:10 -!- ctrlbreak_MAD [~ctrlbreak@159.2.182.106] has joined #bitcoin-core-dev
10:13 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-psjyqsyrkhlykggg] has joined #bitcoin-core-dev
10:20 -!- kabaum [~kabaum@ua-84-216-128-32.bbcust.telenor.se] has joined #bitcoin-core-dev
10:29 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has joined #bitcoin-core-dev
10:29 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev
10:33 -!- ares_ [~ares@gateway/tor-sasl/virtu] has joined #bitcoin-core-dev
10:33 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
10:33 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev
10:34 -!- harding_ is now known as harding
10:35 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
10:35 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
10:36 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev
10:36 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
10:36 -!- landakram [~mark@2601:642:100:33e0:38bd:cc14:7348:4a22] has quit [Remote host closed the connection]
10:37 -!- sr_gi [~sr_gi@static-128-69-224-77.ipcom.comunitel.net] has quit [Read error: Connection reset by peer]
10:38 -!- sr_gi [~sr_gi@static-128-69-224-77.ipcom.comunitel.net] has joined #bitcoin-core-dev
10:40 -!- moneyball__ [sid299869@gateway/web/irccloud.com/x-epbknxfxacmkodvz] has left #bitcoin-core-dev []
10:41 -!- moneyball [sid299869@gateway/web/irccloud.com/x-epbknxfxacmkodvz] has joined #bitcoin-core-dev
10:42 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev
10:47 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev
10:47 -!- ctrlbreak_MAD [~ctrlbreak@159.2.182.106] has quit [Remote host closed the connection]
10:48 -!- ctrlbreak_MAD [~ctrlbreak@159.2.182.106] has joined #bitcoin-core-dev
10:49 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev
11:00 -!- robotadam1 [~robotadam@154.13.1.56] has quit []
11:10 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection]
11:10 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev
11:18 -!- bosma [sid103570@gateway/web/irccloud.com/x-pwxacjewiazcclny] has quit [Ping timeout: 272 seconds]
11:19 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev
11:19 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection]
11:20 -!- bosma [sid103570@gateway/web/irccloud.com/x-nvattcjjwoemkzxm] has joined #bitcoin-core-dev
11:22 -!- angvp [~angvp@195.206.169.184] has joined #bitcoin-core-dev
11:22 -!- angvp is now known as Guest48991
11:23 -!- kabaum [~kabaum@ua-84-216-128-32.bbcust.telenor.se] has quit [Ping timeout: 246 seconds]
11:31 -!- xurzua [~xurzua@181.74.31.104] has joined #bitcoin-core-dev
11:35 -!- bosch [7a94fe5f@122-148-254-95.sta.wbroadband.net.au] has quit [Ping timeout: 245 seconds]
11:37 -!- kabaum [~kabaum@84.216.128.9] has joined #bitcoin-core-dev
11:39 -!- prayank23 [~andr0irc@2405:205:252d:96c1:8d70:955c:c207:9d3a] has quit [Ping timeout: 244 seconds]
11:43 -!- user___ [~user@mail.deeplinkmedia.com] has joined #bitcoin-core-dev
11:45 < dongcarl> What's the reason that enabling fuzz disables all other targets
11:46 < sipa> what else would it do?
11:49 < dongcarl> I feel like I'm missing something cuz I expect it to just add targets instead of affecting other targets?
11:52 < sipa> dongcarl: ah, it needs a special compile flag (-fsanitize=fuz), which is incompatible with having a main function
11:52 -!- user___ [~user@mail.deeplinkmedia.com] has left #bitcoin-core-dev []
11:52 < sipa> it's not --enable-fuzz itself that's incomaptible with it (that's just switching the targets), but because it needs a compiler flag that's mutually exclusive with normal code
11:52 < dongcarl> Haha I see!
11:53 < sipa> dongcarl: there is an issue somewhere to instead enable building the fuzz test *code* (but without fuzzing) even in normal build mode
11:54 < sipa> which would greatly improve my grievances about it, that it's so easy to break compilation of the fuzz tests when you're changing other code, and won't notice because it needs a special build
11:54 < sipa> however the fuzz tests started using C++17 a while ago, so we need to wait until the main code is built with that too
11:54 < dongcarl> sipa: Totally agree... That's exactly what happened to me...
11:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:54 < bitcoin-git> [bitcoin] jonatack opened pull request #20231: wallet, rpc: universal feerate (sat/vB) param/option (master...universal-feerate) https://github.com/bitcoin/bitcoin/pull/20231
11:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:56 < sipa> dongcarl: i have a worktree set up for fuzz builds to test things in
11:56 < sipa> so i don't need to re-./configure and find the right flags every time
11:56 < dongcarl> Ah right, that's a good workaround for now
12:00 < achow101> wallet meeting?
12:00 < jonatack> yup
12:01 < achow101> #startmeeting
12:01 < lightningbot> Meeting started Fri Oct 23 19:01:26 2020 UTC.  The chair is achow101. Information about MeetBot at http://wiki.debian.org/MeetBot.
12:01 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
12:01 < jonatack> hi
12:01 < hebasto> hi
12:01 < michaelfolkson> hi
12:02 < achow101> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball ariard digi_james amiti fjahr jeremyrubin emilengler jonatack hebasto
12:02 < achow101>  jb55 kvaciral ariard digi_james amiti fjahr jeremyrubin lightlike emilengler jonatack hebasto jb55 elichai2
12:02 < achow101> topics?
12:02 < meshcollider> Hi
12:02 < achow101> oh you're awake
12:02 < jonatack> hey meshcollider 
12:02 < meshcollider> One topic proposal standardize feerate unit on sat/vB (or sat/kvB... or sat/sipa...) (jonatack)
12:03 < sipa> you were trying to cross the border
12:03 < meshcollider> Yes :) but glad you're hosting because my internet may be intermittent
12:04 < achow101> #topic standardize feerate unit on sat/vB (or sat/kvB... or sat/sipa...) (jonatack)
12:04 < jonatack> #11413 was merged in June
12:04 < gribble> https://github.com/bitcoin/bitcoin/issues/11413 | [wallet] [rpc] sendtoaddress/sendmany: Add explicit feerate option by kallewoof · Pull Request #11413 · bitcoin/bitcoin · GitHub
12:05 < jonatack> and introduced an explicit feerate option, that overloads conf_target and estimate_mode
12:05 < jonasschnelli> would this break the RPC API... I mean would we change existing RPC parameters?
12:05 < jonatack> which has the disadnvantage of being unsafe and confusing to use
12:05 < sipa> jonatack: it uses a different unit than other feerate RPC arguments?
12:06 < jonatack> 11413 allows a choice between 2 units:
12:06 < jonatack> BTC/kB and sat/B
12:06 -!- jtimon [~quassel@146.228.11.37.dynamic.jazztel.es] has quit [Ping timeout: 256 seconds]
12:07 < jonatack> I've been using this IRL regularly... apart from bumpfee where it is not working (fix in #20220)
12:07 < gribble> https://github.com/bitcoin/bitcoin/issues/20220 | wallet, rpc: explicit feerate follow-ups by jonatack · Pull Request #20220 · bitcoin/bitcoin · GitHub
12:07 < jonatack> but it's scary
12:07 < sipa> how do you choose between them?
12:07 < jonatack> MarcoFalke created an issue at #19453
12:07 < gribble> https://github.com/bitcoin/bitcoin/issues/19453 | refactor: reduce DefaultRequestHandler memory allocations by jonatack · Pull Request #19453 · bitcoin/bitcoin · GitHub
12:07 < jonatack> ugh
12:07 < luke-jr> sipa: the unit is specified s a string
12:08 < jonatack> #19543
12:08 < gribble> https://github.com/bitcoin/bitcoin/issues/19543 | Normalize fee units for RPC ("BTC/kB" and "sat/B) · Issue #19543 · bitcoin/bitcoin · GitHub
12:08 < jonatack> discussion here ^
12:08 < luke-jr> in place of the conservative/etc fee estimate mode
12:08 < sipa> ok
12:08 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Ping timeout: 240 seconds]
12:08 < jonatack> the idea is to not release 0.21 with the overloaded conf_target and estimate_mode params
12:08 < jonasschnelli> 20231 would change the feeRate in fundrawtransaction from BTC/kB to sat/B. Isn't that potentially dangerous?
12:09 < luke-jr> jonatack: too late
12:09 < sipa> we can't change the interpretation of RPC arguments of existing RPCs in released versions
12:09 < jonatack> 6 RPCs are affected: sendtoaddress, sendmany, send, bumpfee, fundraw, and walletcreatefundedpsbt
12:10 < sipa> not without a command-line argument to opt into other semantics, at least
12:10 < jonasschnelli> I guess if we extend/add a feemode parameter in which the default is BTC/kB,.. its probably fine
12:10 < jonatack> per discussion, it's better to not avoid releasing as-is and fix it 
12:10 < luke-jr> relevant #17356
12:10 < gribble> https://github.com/bitcoin/bitcoin/issues/17356 | RPC: Internal named params by luke-jr · Pull Request #17356 · bitcoin/bitcoin · GitHub
12:10 < sipa> jonatack: define 'fix it', what needs fixing?
12:10 < sipa> (just trying to understand the problem)
12:11 < jonatack> see #20220 and #19543
12:11 < gribble> https://github.com/bitcoin/bitcoin/issues/20220 | wallet, rpc: explicit feerate follow-ups by jonatack · Pull Request #20220 · bitcoin/bitcoin · GitHub
12:11 < gribble> https://github.com/bitcoin/bitcoin/issues/19543 | Normalize fee units for RPC ("BTC/kB" and "sat/B) · Issue #19543 · bitcoin/bitcoin · GitHub
12:12 < jonatack> there seems to be agreement to have a dedicated fee_rate option that uses a fixed unit of sat/vB
12:12 < jonatack> to replace overloading conf_target and estimate_mode
12:12 < jonatack> and it's not too hard to do
12:13 < jonatack> mostly test-writing to be sure all the plumbing is working
12:13 < sipa> so what would the changes be w.r.t 0.20 ?
12:14 < meshcollider> Concept ACK on fee_rate
12:14 < jonatack> either as-is with 11413 merged and fixups in 20220, e.g. overloading
12:14 < luke-jr> I don't understand the proposed solution
12:14 < jonatack> or stop overloading them asap before release 
12:14 < jonatack> before we have to do a deprecation cycle
12:14 < jonatack> to change them
12:14 < luke-jr> overloading them isn't a problem, so long as it's properly documented?
12:15 < jonatack> luke-jr: it's fraught
12:15 < sipa> jonatack: sorry for all the questions, i haven't read all these issues... but i'd like to understand what the problem is and what is being changed
12:15 < achow101> sipa: I don't think explicit feerate is in 0.20?
12:15 < jonasschnelli> oh. Why do we overload "conf_target" with a feerate.. :/
12:15 < luke-jr> jonasschnelli: it's only for positional
12:15 -!- prayank23 [~andr0irc@2402:8100:206a:8e79:7a31:5f6f:f515:71ad] has joined #bitcoin-core-dev
12:15 < luke-jr> jonasschnelli: with named args, they have separate names
12:15 < sipa> mostly to make sure we're not doing anything that breaks compatibility
12:15 < jonatack> achow101: no. it was merged late june
12:15 < luke-jr> jonasschnelli: for positional, it's pretty reasonable
12:16 < sipa> jonatack: would the feerate argument to `settxfee` be affected?
12:16 < jonatack> luke-jr: it's mixing types, and look at the fundraw and createpsbt helps... 
12:16 < luke-jr> jonatack: so the bug is documentation only
12:16 < jonatack> sipa: so far settxfee is not changed by 11413
12:17 < sipa> or existing RPCs that have feerates in their response?
12:17 < jonatack> luke-jr: mixed types, overloading, missing tests, broken bumpfee
12:18 < jonatack> luke-jr: i use it for positional, and it's scary. a bit more reassuring with -named
12:18 < jonatack> (have used it many times, i still re-check every time)
12:19 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev
12:19 < jonatack> sipa: so far i've looked at input params/options, not yet at output
12:20 < sipa> if we're introducing a sat/vB option, wouldn't it be better to have it everywhere?
12:20 < jonatack> i think so, yes. there seems to be fairly strong agreement to migrate to it.
12:20 < sipa> otherwise people could be copying output from estimatesmartfee and have it be interpreted as a different unit
12:20 < sipa> "migrate" ?
12:21 < sipa> you can't break compatibility
12:21 < jonatack> so we have to stay with BTC/kB?
12:21 < luke-jr> isn't that the reason we use BTC at all in RPC?
12:21 < sipa> for existing RPCs, definitely
12:21 < sipa> but you could add extra output arguments, and extra input arguments
12:21 < luke-jr> otherwise it'd be better to have satoshis everywhere..
12:21 < sipa> feerate, feerate_satvb e.g.
12:22 < luke-jr> sipa: that breaks positional
12:22 < sipa> how so?
12:22 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Read error: Connection reset by peer]
12:22 < luke-jr> sipa: positional doesn't have an arg name
12:22 < sipa> it'd be a completely separate argument
12:22 < luke-jr> that's terribly ugly
12:23 < sipa> yes
12:23 < jonatack> luke-jr: so far, in the rpcs where i've added feerate, i placed it just before verbose, which isn't dangerous
12:23 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
12:23 < jonatack> or could be after verbose as well, either way
12:23 < jonatack> e.g. last
12:23 < sipa> jonatack: so verbose moved?
12:23 < jonatack> sipa: no, this is what i'm looking at rn
12:23 -!- prayank23 [~andr0irc@2402:8100:206a:8e79:7a31:5f6f:f515:71ad] has quit [Ping timeout: 260 seconds]
12:24 < jonatack> adding "fee_rate" or "feerate_sat_vb" to sendtoaddress/sendmany/send etc
12:24 < luke-jr> btw why use vB at all, if not for API compatibility? ;)
12:24 < luke-jr> maybe it should be sat/WU ;)
12:25 < sipa> i think sat/vB makes sense, it's the most common unit used in practice for fees
12:25 < sipa> at least as an option
12:25 < sipa> but compatibility is a problem
12:26 < sipa> previous times when new units in RPC was brought up (mostly in the context of using sat instead of BTC for absolute amounts), it was suggested that this'd be done through a completely new version of the RPC API
12:26 < sipa> though that of course easily scope-creeps into discussions about what else to change
12:26 < jonatack> luke-jr: if it was me doing it greenfield, i might use sat/kvB (and call it sat/sipa for better marketing)
12:26 < jonatack> sipa: hm
12:26 < sipa> goh please no
12:26 < luke-jr> lol
12:27 < meshcollider> ugh, rpc versioning
12:27 < jonatack> for the 3 send rpcs, there is currently no feerate-like param
12:27 < luke-jr> can we split this topic up into two: what is actually _broken_ right now? 2) what is a future backward compat burden?
12:28 < jonatack> bumpfee, fundraw and WCFB do have them 
12:28 < emzy> As long as minimum fee is 1 sat/vB, this unit makes sense.
12:28 < luke-jr> emzy: JSON-RPC does not treat integers as special
12:28 < sipa> many client libraries do, though
12:29 < sipa> but indeed, JSON only has a "number" type with no distinction between integers and floating-point
12:29 < jonatack> luke-jr: minimum fixes are in #20220, except maybe additional clarity in the help about the confusing edges, which there currently are
12:29 < gribble> https://github.com/bitcoin/bitcoin/issues/20220 | wallet, rpc: explicit feerate follow-ups by jonatack · Pull Request #20220 · bitcoin/bitcoin · GitHub
12:30 < jonatack> what MarcoFalke, wumpus, Murch, kallewoof and I have been discussing is not overloading conf_target and estimate_mode before it's too late and released 
12:30 < luke-jr> sipa: I can't think of a sane way to prepare for broken client libs combined with sub-sat/WU fee rates :p
12:30 < michaelfolkson> What is WU?
12:30 < meshcollider> Weight unit
12:31 < luke-jr> weight units; ie, what consensus is really using
12:31 < michaelfolkson> Ah ta
12:31 < jonatack> Questions:
12:31 < luke-jr> jonatack: what is the difference between `int target = value.get_int();` and `const int target{value.get_int()};` that makes it so essential?
12:32 < jonatack> - move forward with fix to not overload those two params?
12:32 < luke-jr> I think they should be overloaded
12:32 < jonatack> - call it feerate or fee_rate?
12:32 < jonatack> luke-jr: it's WIP, no need to discuss style nits yet
12:32 < Murch> luke-jr: Do you think floats of sat/vB would be a problem?
12:33 < sipa> it is very late to still make changes to RPC arguments at this point
12:33 < luke-jr> Murch: JSON-RPC doesn't have floats, everything is precise decimal
12:33 < luke-jr> Murch: even if some clients might need to used floats for it, I don't see it likely to be a practical issue
12:33 < luke-jr> after all, floats have plenty of precision?
12:33 < Murch> So how do people input BTC/kB right now?
12:34 < jonatack> ISTM it can be simpler to add a fixed-unit feerate than keep overloading, and simpler code as well
12:34 < jonatack> above all, better for users 
12:34 < luke-jr> jonatack: ?
12:34 < jonatack> and i've been dogfooding the current version quite a bit
12:35 < luke-jr> callers should be able to specify fee as an estimate mode or absolute feerate.. I see no case where overloading is weird
12:35 < sipa> Murch: 0.00123456 if you want 123.456 sat/vB
12:35 < jonatack> Has anyone actually used it?
12:36 < jonatack> The explicit feerate with the overloaded args.
12:36 < Murch> sipa: Is that then not a float?
12:36 < sipa> Murch: JSON doesn't have a concept of floats/integers, just "numbers"
12:37 < jonatack> It's awfully odd to send txns with a feerate set with conf_target=2 and estimate_mode="sat/vb" 
12:37 < sipa> jonatack: but can't you use fee_rate=2 as well?
12:37 < luke-jr> jonatack: 20220 is long, and starting from the top looks like a bunch of completely unnecessary changes; I'm not opposed to them, but it's not helpful to understand what is in need of fixing
12:37 < Murch> I guess I'm missing the distinction, but I understand that it's not a problem to put in something with a value between 0 and 1
12:37 < jonatack> the names do not correspond at all to what is being done
12:38 < jonatack> luke-jr: 20220 mostly adds missing tests 
12:38 < sipa> Murch: read the JSON spec, it just has a number type
12:39 < sipa> Murch: the problem is with client libraries, which may map the number type to floating point types, which is bad for currency reasons
12:39 < luke-jr> Murch: JSON-RPC numbers are decimal strings; floats are fixed-size approximations
12:39 < sipa> bitcoin core has no problem with this, it parses the decimals exactly from json, without conversion to a floating point type at any point
12:39 < Murch> luke-jr: Thanks, I see.
12:40 < sipa> i think it's a good idea to try to avoid numbers with a decimal in our RPC, but that's not worth breaking compatibility over
12:40 < jonatack> luke-jr: with an important fix that i noted with a review comment and some help documentation fixes
12:41 < jonatack> (some of the helps are currently wrong)
12:41 < Murch> My alternative proposal was sat/kvB, which gives us an additional 3 decimal of precision for numbers that are safe integers
12:41 < Murch> (which, though would also get parsed as floats in client libraries potentially, I guess)
12:41 < emzy> Murch: thats also msat/vB
12:41 < Murch> emzy: sure.
12:42 < sipa> Murch: the bitcoin core RPC also lets you pass any amount as a string, in case your client library can't produce JSON numbers without going through a floating-point type
12:42 < luke-jr> emzy: but msat isn't an existing unit (in Bitcoin/Core at least)
12:42 < emzy> luke-jr: but Lighting uses it already.
12:42 < sipa> so you can have integer sats internally in the application, and format them as "%i.%06i" % (sats // 1000000, sats % 1000000) for example (python like)
12:43 < luke-jr> emzy: unfortunately :p
12:43 < sipa> we'll add a command line option to rename msat/vB to sat/kvB for luke-jr
12:44 < sipa> ;)
12:45 < Murch> mh, my nickname is the only one with a capital letter. Are you all anti-capitalists?
12:45 < emzy> I don't like the 1/k I think it is confusing
12:45 < luke-jr> lol
12:45 < jonatack> I'm not sure what people would like to do here. What we have now does have some issues per #19543 and other issues I found while adding tests, but happy to not work on it further if it's not needed.
12:45 < gribble> https://github.com/bitcoin/bitcoin/issues/19543 | Normalize fee units for RPC ("BTC/kB" and "sat/B) · Issue #19543 · bitcoin/bitcoin · GitHub
12:46 < sipa> jonatack: i'm going to refrain from commenting further until i understand what the problem and proposed solution are
12:47 < jonatack> I'm afraid people will definitely complain about the overloaded options having functions that don't have much to do with the param names.
12:47 < jonatack> e.g. conf_target for the fee rate
12:47 < luke-jr> jonatack: if you're using named params, you *shouldn't* be specifying it as conf_target
12:47 < jonatack> and there is also a feeRate or fee_rate arg next to it in some rpcs
12:47 < luke-jr> it should be the same position, but named fee_?rate
12:48 < jonatack> that in addition does not work if you use estimate_mode
12:48 < luke-jr> without #17356, we can't enforce the correct name is used, but that's beside the point
12:48 < gribble> https://github.com/bitcoin/bitcoin/issues/17356 | RPC: Internal named params by luke-jr · Pull Request #17356 · bitcoin/bitcoin · GitHub
12:49 < Murch> presumably `conf_target` and `feerate` would be exclusive or one would supersede if both are provided (exclusive is cleaner, though)
12:50 < jonatack> Ok, in issue 19543 I thought there was a pretty clear direction, but it seems not, and I suspect no one has been dogfooding the current new feature.
12:50 < luke-jr> Murch: ideally, if both were provided, we'd error
12:50 < luke-jr> or rather, if the wrong one were provided
12:50 < luke-jr> estimate_mode (perhaps should be renamed fee_mode) specifies which one is correct
12:51 < jonatack> luke-jr: we cannot rename estimate_mode
12:51 < luke-jr> (and with "fee_mode" there, "fee_rate" seems obvious over "feerate")
12:51 < luke-jr> jonatack: why not?
12:51 < jonatack> it's used for the fee estimation since some time
12:51 < luke-jr> so?
12:51 < luke-jr> we support multiple names
12:51 < luke-jr> deprecate the old one and keep allowing it
12:51 < jonatack> This is a mess.
12:52 < jonatack> I thought we had a good solution, but it seems best for me to drop it.
12:52 < jonatack> I'm done.
12:52 < sipa> :(
12:53 < jonatack> luke-jr: I with you had chimed in on the discussion in 19543
12:53 < jonatack> we seemed in agreement I thought
12:53 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection]
12:54 < jonatack> I'll get back to catching up on the reviewing.
12:54 < achow101> any other topics for the last 5 minutes?
12:55 < michaelfolkson> Is that an effective Approach NACK luke-jr?
12:55 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev
12:56 < luke-jr> michaelfolkson: I don't understand his proposed approach still :/
12:56 < sipa> i worry that i may have contributed to jonatack's frustration here by commenting without understanding the problem well
12:57 < michaelfolkson> Ok well if you both do look over it it would be good to get a formal Approach NACK if you really don't like it.
12:57 -!- jtimon [~quassel@146.228.11.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
12:57 < michaelfolkson> I haven't understood it all either
12:58 < jonatack> sipa, no worries, I'm not frustrated, it's just clearly too early in that people haven't tripped on the issues yet.
12:59 < jonatack> achow101: did you want to do high priority?
12:59 < Murch> How come that parameters to RPC are defined separately instead of in a dictionary that applies to all uses of the same parameter?
12:59 < Murch> I.e. why is something like feerate not defined once for the whole codebase?
12:59 < achow101> jonatack: I think all the high priority is already listed in the milestone
12:59 < jonatack> achow101: that's true
12:59 < sipa> Murch: what do you mean with "defined once" ?
13:00 < sipa> code for parsing it?
13:00 < achow101> #endmeeting
13:00 < lightningbot> Meeting ended Fri Oct 23 20:00:27 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
13:00 < lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-10-23-19.01.html
13:00 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-10-23-19.01.txt
13:00 < lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2020/bitcoin-core-dev.2020-10-23-19.01.log.html
13:00 < Murch> like a class that provides the parameter parsing, logic, and sanitation that can be used by various rpc to 
13:01 < sipa> we have that for amounts (AmountFromValue), and historically, feerates were always just amounts (per k(v)B)
13:02 < michaelfolkson> I have a question for achow101 if he's sticking around. You said in your blog post it will be possible to migrate legacy wallets to descriptor wallets. How does the descriptor wallet obtain the descriptor from the legacy wallet?
13:02 < sipa> jonatack: i think it'd be useful if you added a summary of the actual RPC changes in 20220 ?
13:02 < sipa> s/?//
13:02 < jtimon> sipa: is there not a CFeeRate class anymore?
13:03 < sipa> there is, but it doesn't RPC argument parsing
13:03 < sipa> feerates were just constructed from an amount
13:03 < jtimon> oh, I see
13:03 < achow101> michaelfolkson: going through all the keys in the legacy wallet and creating descriptors for them. it requires considering everything that IsMine matches on
13:03 < jtimon> yeah, yeah, from an amount is the one I know, murch wants one to parse from rpc
13:03 < jtimon> got it
13:03 < achow101> for HD wallets, it's pretty simple with computing the xprv for the hd seed and using a single descriptor. for non-HD but still only key things, it's a descriptor for each key
13:04 < achow101> for wallets with watchonly things and multisigs, it gets complicated
13:05 < jtimon> so what's the status on using bitcoin core with hardware wallets, multisig and all those cool things? is it still a separated branch?
13:05 < jtimon> or it is merged now?
13:05 < luke-jr> not even close afaik
13:05 < jtimon> :(
13:05 < sipa> PSBT works
13:05 < jonatack> sipa: do you mean discuss in the 20220 PR description the RPC changes of 11413?
13:06 < achow101> jtimon: if you're willing to do some command line stuff, it works
13:06 < achow101> *do command line stuff and use hwi separately
13:06 < sipa> jonatack: no, what changes in 20220
13:06 < jtimon> but I need to get a different branch with scripts and stuff, no?
13:06 < achow101> jtimon: no
13:06 < michaelfolkson> achow101: It effectively has to ask the legacy wallet what the equivalent descriptor is. I'd have thought in some scenarios this would be hard as the legacy wallet wasn't set up to answer that question.
13:07 < jtimon> achow101:  oh, I see, so I guess it's more or less a while back, but now merged, nice
13:07 < sipa> jtimon: you need HWI or other software that can talk to the hardware wallet
13:07 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
13:07 < jonatack> sipa, 20220 just adds missing test coverage, fixes a bug to make bumpfee work again, and does doc updates that were left over from 11413 (which was 3 years old when it was merged)
13:07 < jtimon> are there any plans to add that stuff to the qt interface?
13:07 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
13:08 < sipa> jonatack: oh ok, that explains why i couldn't find anything
13:08 < achow101> michaelfolkson: it's just kind of complex. but the set of scriptPubKeys is finite and not log(n!) so it's doable
13:08 < achow101> s/log/O
13:08 < michaelfolkson> OK thanks achow101
13:09 < achow101> jtimon: yes. https://github.com/bitcoin-core/gui/pull/4
13:09 < sipa> achow101, michaelfolkson: i think it depends on what level of compatibility you're talking about; constructing a set of descriptors that match exactly what a legacy wallet *right now* considers IsMine() is doable i think
13:09 < jonatack> yes, 20220 doesn't change the RPCs. I started changing them in 20231 today...simpler UI and code. 
13:09 < achow101> meshcollider: https://github.com/bitcoin/bitcoin/projects/16 can be closed/removed/whatever happens to completed project boards
13:10 < jtimon> achow101: oh, wow, and the gui is separated? I missed a lot
13:10 < sipa> making it also treat IsMine() any future script the legacy would have considered... is probably impossible if you want to cover al edge cases
13:10 < sipa> jtimon: same project, different repo
13:10 < sipa> it's still compiled as one thing
13:10 < sipa> so it's just the development/review workflow that moved elsewhere
13:10 < jtimon> oh, ok, just 2 projects for the PRs and stuff, right?
13:10 < achow101> yeah
13:11 -!- prayank23 [~andr0irc@2402:8100:206a:8e79:7a31:5f6f:f515:71ad] has joined #bitcoin-core-dev
13:11 < achow101> sipa: as long as we don't change legacy ismine, we don't have to worry about future stuff
13:11 -!- prayank23 [~andr0irc@2402:8100:206a:8e79:7a31:5f6f:f515:71ad] has quit [Read error: Connection reset by peer]
13:11 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
13:12 < jtimon> well, still very cool that this is getting into the gui
13:12 < sipa> achow101: it's also only crazy edge cases that you can't cover i think
13:13 < sipa> achow101: like having a HD chain that has a future key X, where multi(2,X,Y,Z) is a watch-only script, with Y and Z private keys you already have
13:14 -!- kabaum [~kabaum@84.216.128.9] has quit [Ping timeout: 260 seconds]
13:14 < achow101> sipa: well stop using the legacy wallet after it migrates :p
13:14 < sipa> achow101: of course
13:14 < sipa> just means you can't silently do the conversion
13:16 < luke-jr> "Welcome to Bitcoin Core 2022.11. You are using an ancient wallet version, that will not be supported in the next release. Do you want to upgrade now? This will invalidate old backups!"
13:17 < achow101> luke-jr: that's probably what will happen anyways
13:18 < achow101> actually, the current migration pr doesn't let you use the legacy stuff anyways. it currently makes a new descriptor wallets and essentially imports the descriptors for the legacy wallet
13:18 -!- Guest48991 [~angvp@195.206.169.184] has quit [Remote host closed the connection]
13:19 < sipa> achow101: how big is an sqlite wallet.dat if it has 6000 imported descriptors?
13:20 < sipa> oh, or will it convert hdchains correctly and only have 6?
13:20 < achow101> it should correctly convert hd chains
13:20 < achow101> I haven't tested the migration pr with sqlite yet. I think it might be broken
13:32 -!- Lthere [~Lthere@195.206.169.184] has joined #bitcoin-core-dev
13:33 < sipa> jonatack: so is there anything you'l were thinking of trying to get in 0.21, besides 20220?
13:34 < jonatack> sipa: re-reading, i now see your question "but can't you use fee_rate=2 as well"
13:34 < jonatack> and that's part of the oddness, with explicit feerate feature, no
13:35 < jonatack> and only for BTC/vB iiuc, feeRate doesn't handle sat/B but conf_target with estimate_mode does handle it
13:35 -!- jtimon [~quassel@146.228.11.37.dynamic.jazztel.es] has quit [Remote host closed the connection]
13:36 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds]
13:36 < sipa> too many ideas floating around
13:36 < jonatack> yeah it's fairly unsimple and unintuitive
13:39 < jonatack> tagged for 0.21 i also have #20115 and #20120, but no hurry, still a week :)
13:39 < gribble> https://github.com/bitcoin/bitcoin/issues/20115 | cli: -netinfo quick updates/fixups and release note by jonatack · Pull Request #20115 · bitcoin/bitcoin · GitHub
13:39 < gribble> https://github.com/bitcoin/bitcoin/issues/20120 | net, rpc, test, bugfix: update GetNetworkName, GetNetworksInfo, regression tests by jonatack · Pull Request #20120 · bitcoin/bitcoin · GitHub
13:40 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev
13:44 -!- berndj-blackout [~berndj@ns1.linksynergy.co.za] has joined #bitcoin-core-dev
13:46 -!- queip_ [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
13:47 -!- TheHoliestRoger_ [~TheHolies@unaffiliated/theholiestroger] has joined #bitcoin-core-dev
13:50 -!- Netsplit *.net <-> *.split quits: Nebraskka, cryptapus, Squidicuz, troygiorshev, queip, TheHoliestRoger, tryphe, baldur, IGHOR, nothingmuch,  (+5 more, use /NETSPLIT to show all of them)
13:50 -!- berndj-blackout is now known as berndj
13:50 -!- Netsplit over, joins: jeremyrubin, nothingmuch, tryphe, cryptapus, Nebraskka, IGHOR, Squidicuz, baldur, troygiorshev, Klox0480931 (+1 more)
13:51 -!- queip_ is now known as queip
13:51 -!- IGHOR [~quassel@176.121.4.135] has quit [Max SendQ exceeded]
13:51 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Max SendQ exceeded]
13:52 -!- IGHOR [~quassel@176.121.4.135] has joined #bitcoin-core-dev
13:52 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 246 seconds]
13:55 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
13:57 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
14:00 -!- Lthere [~Lthere@195.206.169.184] has quit []
14:03 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev
14:21 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
14:22 -!- ericbsd1 [~ericbsd@178.162.204.214] has joined #bitcoin-core-dev
14:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:42 < bitcoin-git> [bitcoin] jnewbery opened pull request #20233: addrman: make sanity checks a runtime option (master...2020-10-addrman-sanity) https://github.com/bitcoin/bitcoin/pull/20233
14:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:42 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev
14:43 -!- filchef [~filchef@212.104.97.177] has quit [Client Quit]
14:47 -!- twistedline [~twisted@2601:14d:8500:d3e0:fd1b:e7a9:674a:621a] has joined #bitcoin-core-dev
14:47 -!- twistedline [~twisted@2601:14d:8500:d3e0:fd1b:e7a9:674a:621a] has quit [Changing host]
14:47 -!- twistedline [~twisted@unaffiliated/twistedline] has joined #bitcoin-core-dev
15:10 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
15:12 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
15:35 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection]
15:36 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds]
15:42 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev
15:48 -!- ctrlbreak_MAD [~ctrlbreak@159.2.182.106] has quit [Remote host closed the connection]
15:49 -!- ctrlbreak_MAD [~ctrlbreak@159.2.182.106] has joined #bitcoin-core-dev
15:49 -!- xurzua [~xurzua@181.74.31.104] has quit [Ping timeout: 260 seconds]
15:52 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
15:58 -!- sanketh [sid461832@gateway/web/irccloud.com/x-bztwsqlnfacgpaal] has joined #bitcoin-core-dev
16:07 -!- prayank23 [~andr0irc@2402:8100:206a:8e79:167e:1530:86fc:f180] has joined #bitcoin-core-dev
16:09 -!- prayank23 [~andr0irc@2402:8100:206a:8e79:167e:1530:86fc:f180] has quit [Read error: Connection reset by peer]
16:15 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net]
16:18 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
16:26 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
16:27 -!- dviola [~diego@unaffiliated/dviola] has quit [Ping timeout: 264 seconds]
16:36 -!- brianhoffman_ [~brianhoff@pool-71-191-34-154.washdc.fios.verizon.net] has joined #bitcoin-core-dev
16:38 -!- brianhoffman [~brianhoff@pool-71-191-34-154.washdc.fios.verizon.net] has quit [Ping timeout: 258 seconds]
16:38 -!- brianhoffman_ is now known as brianhoffman
16:47 < achow101> if a multisig isn't being watched, should it be migrated during descriptor wallet migration?
16:53 < sipa> achow101: as in, it's not IsMine() in the legacy wallet?
16:53 < achow101> sipa: yes
16:53 < sipa> i'd say no
16:54 < achow101> but it was added and we can sign for it
16:54 < sipa> can you have a concept of an "unwatched" descriptor?
16:54 < achow101> nope
16:54 < sipa> which helps for signing, but isn't watching anything?
16:55 < sipa> it would be strange
16:55 < achow101> we can sign if it's part of a psbt
16:55 < achow101> but we wouldn't be able to fill that psbt with the script
16:55 < sipa> right
16:57 < sipa> descriptor wallets really don't have a concept that corresponds to that
16:57 < achow101> indeed
16:58 < sipa> and i think that's a good thing
16:58 < sipa> but it may be useful to have an option at migration time to convert all solvable things in the legacy wallet to watched things in the descriptor one
16:59 < sipa> if you really want, you'd be able to convert a legacy wallet into a descriptor wallet for balance watching, and another one with "all cruft i can participate in signing for"
17:00 -!- ericbsd1 [~ericbsd@178.162.204.214] has quit []
17:00 < achow101> it kind of does feel like we should separate privkeys and signing from balance watching thogh
17:01 < sipa> privkeys are something else still, i think
17:01 < sipa> but what if you have solvable non-signable non-watched things in a legacy wallet?
17:02 < achow101> that's the current problem, no?
17:02 < sipa> yes
17:02 < sipa> i'm saying forget private keys for a minute
17:03 < sipa> i figure this could occur if you had one wallet that has both your private balance, but also has multisig scripts imported for participating in a multisig fund
17:04 < sipa> that situation should really be converted to two wallets
17:04 < achow101> yes
17:04 < achow101> if that wallet also has other watchonly things, then it should be 3 wallets
17:05 < sipa> exactly
17:05 < sipa> descriptor wallets inherently can't solve anything that isn't watched... but anything you'd want to solve for should be watched by *someone*
17:05 < sipa> who is going to do coin selection otherwise?
17:06 < achow101> indeed, but then the other participants shouldn't need to have the multisig in their wallet
17:06 < achow101> I guess it made things easier before psbt
17:07 < sipa> right, but i think all we need is an option to convert anything solvable into a watched descriptor
17:07 < sipa> you'd use normal conversion for your personal part of the wallet
17:07 < sipa> and a separate solvable-to-watched conversion to extract the multisig "wallet", if you have a need for that
17:08 < achow101> I think we can just make the separate wallet and inform the user
17:08 < achow101> right now the migration will make a separate watchonly and inform the user
17:09 < sipa> ok
17:17 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
17:18 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
17:22 -!- milky1 [~milky@185.204.1.185] has joined #bitcoin-core-dev
17:43 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection]
17:49 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev
18:02 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds]
18:09 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
18:17 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit []
18:25 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Quit: ZNC 1.7.5 - https://znc.in]
18:27 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev
18:36 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 256 seconds]
18:43 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
18:43 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
18:47 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 240 seconds]
18:55 -!- dviola [~diego@187.39.22.189] has joined #bitcoin-core-dev
19:04 -!- Squidicuz [~squid@pool-72-74-34-120.bstnma.fios.verizon.net] has quit [Ping timeout: 240 seconds]
19:04 -!- Squidicuz [~squid@pool-72-74-34-120.bstnma.fios.verizon.net] has joined #bitcoin-core-dev
19:08 -!- Squidicuz [~squid@pool-72-74-34-120.bstnma.fios.verizon.net] has quit [Ping timeout: 240 seconds]
19:08 -!- Squidicc [~squid@pool-72-74-34-120.bstnma.fios.verizon.net] has joined #bitcoin-core-dev
19:10 -!- Squidicuz [~squid@pool-72-74-34-120.bstnma.fios.verizon.net] has joined #bitcoin-core-dev
19:11 -!- Squidicc [~squid@pool-72-74-34-120.bstnma.fios.verizon.net] has quit [Read error: Connection reset by peer]
19:28 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
19:30 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 240 seconds]
19:47 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Quit: Leaving]
20:00 -!- milky1 [~milky@185.204.1.185] has quit []
20:19 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadmz]
20:29 -!- prayank23 [~andr0irc@2402:8100:206b:802c:278c:1e6a:9297:25fc] has joined #bitcoin-core-dev
21:02 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection]
21:03 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev
21:16 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
21:31 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev
22:04 -!- openstackstatus1 [~openstack@94.229.74.91] has joined #bitcoin-core-dev
22:11 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadmz]
22:23 -!- prayank23 [~andr0irc@2402:8100:206b:802c:278c:1e6a:9297:25fc] has quit [Ping timeout: 260 seconds]
22:47 -!- aj [aj@cerulean.erisian.com.au] has quit [Quit: .]
22:49 -!- lightningbot [~supybot@2400:8901::f03c:91ff:febb:bbc1] has quit [Read error: Connection reset by peer]
22:50 -!- lightningbot [~supybot@2400:8901::f03c:91ff:febb:bbc1] has joined #bitcoin-core-dev
23:00 -!- openstackstatus1 [~openstack@94.229.74.91] has quit []
23:03 -!- aj [aj@cerulean.erisian.com.au] has joined #bitcoin-core-dev
23:21 -!- jayg [~jayg@178.238.229.54] has joined #bitcoin-core-dev
23:46 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev
--- Log closed Sat Oct 24 00:00:23 2020