--- Log opened Tue Nov 17 00:00:03 2020
--- Day changed Tue Nov 17 2020
00:00 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has quit [Ping timeout: 240 seconds]
00:14 -!- kcalvinalvin [~kcalvinal@ec2-52-79-199-97.ap-northeast-2.compute.amazonaws.com] has quit [Ping timeout: 256 seconds]
00:15 -!- kcalvinalvin [~kcalvinal@ec2-52-79-199-97.ap-northeast-2.compute.amazonaws.com] has joined #bitcoin-core-dev
00:33 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has joined #bitcoin-core-dev
01:00 -!- MaddinSM [~MaddinSM@185.204.1.185] has quit []
01:04 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has quit [Ping timeout: 240 seconds]
01:16 -!- AdulrunaRedviva [c3d69d22@195.214.157.34] has joined #bitcoin-core-dev
01:40 -!- da39a3ee5e6b4b0d [~da39a3ee5@cm-171-98-79-192.revip7.asianet.co.th] has joined #bitcoin-core-dev
01:56 -!- hardaker [~hardaker@193.56.252.12] has joined #bitcoin-core-dev
02:08 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
02:12 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
02:12 -!- vasild_ is now known as vasild
02:21 -!- MarcoFalke [~none@198.12.116.246] has quit [Quit: ZNC 1.7.1 - https://znc.in]
02:23 -!- MarcoFalke [~none@198.12.116.246] has joined #bitcoin-core-dev
02:47 -!- promag [~promag@188.251.225.32] has joined #bitcoin-core-dev
02:50 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
02:54 -!- promag_ [~promag@188.251.225.32] has joined #bitcoin-core-dev
02:54 -!- promag [~promag@188.251.225.32] has quit [Read error: Connection reset by peer]
02:57 -!- promag [~promag@188.251.225.32] has joined #bitcoin-core-dev
02:57 -!- da39a3ee5e6b4b0d [~da39a3ee5@cm-171-98-79-192.revip7.asianet.co.th] has quit [Ping timeout: 265 seconds]
03:00 -!- promag_ [~promag@188.251.225.32] has quit [Ping timeout: 265 seconds]
03:18 -!- Johathan56Kovace [~Johathan5@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev
03:24 -!- glozow [uid453516@gateway/web/irccloud.com/x-iymvwrqjwidgojhb] has quit [Quit: Connection closed for inactivity]
03:43 -!- Guest48480 [~luka@217.146.82.202] has quit [Remote host closed the connection]
03:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:45 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3457054c61d5...c463f70fb05e
03:45 < bitcoin-git> bitcoin/master 9636962 Sishir Giri: [upgradewallet] removed unused warning param
03:45 < bitcoin-git> bitcoin/master c463f70 MarcoFalke: Merge #20139: Wallet: do not return warnings from UpgradeWallet()
03:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:45 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20139: Wallet: do not return warnings from UpgradeWallet() (master...upgradewallet_rpc_cleanup) https://github.com/bitcoin/bitcoin/pull/20139
03:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:54 -!- belcher_ is now known as belcher
04:00 -!- hardaker [~hardaker@193.56.252.12] has quit []
04:02 -!- FredC [~FredC@178.239.168.171] has joined #bitcoin-core-dev
04:03 -!- promag [~promag@188.251.225.32] has quit [Remote host closed the connection]
04:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:05 < bitcoin-git> [gui] MarcoFalke merged pull request #96: Slight improve create wallet dialog (master...2020/09/create_wallet) https://github.com/bitcoin-core/gui/pull/96
04:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:05 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/c463f70fb05e...e7986c51bc7a
04:05 < bitcoin-git> bitcoin/master 5bff825 Sjors Provoost: [gui] create wallet: smarter checkbox toggling
04:05 < bitcoin-git> bitcoin/master c99d6f6 Sjors Provoost: gui: create wallet: name placeholder
04:05 < bitcoin-git> bitcoin/master ac64cec Sjors Provoost: gui: create wallet: add advanced section
04:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:22 -!- lahwran [~lahwran@185.163.110.116] has joined #bitcoin-core-dev
04:25 -!- lahwran [~lahwran@185.163.110.116] has quit [Remote host closed the connection]
04:28 -!- Johathan56Kovace [~Johathan5@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 240 seconds]
04:30 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
04:35 -!- promag [~promag@188.250.84.129] has quit [Ping timeout: 272 seconds]
04:39 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
04:43 -!- per [~per@gateway/tor-sasl/wsm] has joined #bitcoin-core-dev
04:44 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
04:47 -!- pinheadm_ [~pinheadmz@152.89.204.173] has quit [Ping timeout: 272 seconds]
04:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:52 < bitcoin-git> [bitcoin] MarcoFalke pushed 14 commits to master: https://github.com/bitcoin/bitcoin/compare/e7986c51bc7a...80e32e120ee4
04:52 < bitcoin-git> bitcoin/master 3f72791 Jon Atack: wallet: fix bug in RPC send options
04:52 < bitcoin-git> bitcoin/master 6112cf2 Jon Atack: wallet: add CFeeRate ctor doxygen documentation
04:52 < bitcoin-git> bitcoin/master e21212f Jon Atack: wallet: remove unneeded WALLET_BTC_KB_TO_SAT_B constant
04:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:52 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20305: wallet: introduce fee_rate sat/vB param/option (master...fee_rate_sat_vb) https://github.com/bitcoin/bitcoin/pull/20305
04:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:53 < MarcoFalke> looks like we can ship?
04:53 < MarcoFalke> Is there anything left other than #20401?
04:53 < gribble> https://github.com/bitcoin/bitcoin/issues/20401 | qt: Pre-splitoff translations update by laanwj · Pull Request #20401 · bitcoin/bitcoin · GitHub
04:55 -!- geekosaur [~geekosaur@217.146.82.202] has joined #bitcoin-core-dev
04:55 -!- geekosaur is now known as Guest21218
04:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:58 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/80e32e120ee4...831675c8dccf
04:58 < bitcoin-git> bitcoin/master bb6441b Wladimir J. van der Laan: qt: Pre-splitoff translations update
04:58 < bitcoin-git> bitcoin/master 831675c fanquake: Merge #20401: qt: Pre-splitoff translations update
04:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:58 < jonatack> MarcoFalke: (thanks!) maybe #20403 after bugfix update this afternoon
04:58 < gribble> https://github.com/bitcoin/bitcoin/issues/20403 | wallet: upgradewallet fixes, improvements, test coverage by jonatack · Pull Request #20403 · bitcoin/bitcoin · GitHub
04:58 -!- da39a3ee5e6b4b0d [~da39a3ee5@cm-171-98-79-192.revip7.asianet.co.th] has joined #bitcoin-core-dev
04:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:58 < bitcoin-git> [bitcoin] fanquake merged pull request #20401: qt: Pre-splitoff translations update (master...2020_11_translations_update) https://github.com/bitcoin/bitcoin/pull/20401
04:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:59 < MarcoFalke> jonatack: I don't think this should hold back an rc1
04:59 < MarcoFalke> It can be included in rc2 if it is ready by then
04:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:59 < bitcoin-git> [bitcoin] ajtowns opened pull request #20408: CConnman: move initialization into Init() (master...202011-connman-fuzz) https://github.com/bitcoin/bitcoin/pull/20408
04:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:00 < jonatack> MarcoFalke: sgtm
05:05 -!- AdulrunaRedviva [c3d69d22@195.214.157.34] has quit [Remote host closed the connection]
05:20 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has quit [Quit: The Lounge - https://thelounge.chat]
05:23 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
05:25 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
05:27 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
05:30 -!- Guest21218 [~geekosaur@217.146.82.202] has quit [Remote host closed the connection]
05:41 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
05:43 -!- da39a3ee5e6b4b0d [~da39a3ee5@cm-171-98-79-192.revip7.asianet.co.th] has quit [Ping timeout: 240 seconds]
05:43 -!- Livestradamus [~quassel@unaffiliated/livestradamus] has quit [Quit: I'm out.]
05:43 -!- Livestradamus [~quassel@unaffiliated/livestradamus] has joined #bitcoin-core-dev
05:44 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 272 seconds]
05:48 -!- da39a3ee5e6b4b0d [~da39a3ee5@cm-171-98-79-192.revip7.asianet.co.th] has joined #bitcoin-core-dev
05:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
05:51 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has joined #bitcoin-core-dev
05:54 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has quit [Read error: Connection reset by peer]
05:57 -!- Suigintou [~Suigintou@92.223.89.101] has joined #bitcoin-core-dev
05:57 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has joined #bitcoin-core-dev
05:58 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has quit [Client Quit]
05:59 -!- Landryl4 [~Landryl@ns528256.ip-192-99-10.net] has joined #bitcoin-core-dev
06:00 -!- Landryl4 [~Landryl@ns528256.ip-192-99-10.net] has quit [Client Quit]
06:01 -!- Landryl4 [~Landryl@ns528256.ip-192-99-10.net] has joined #bitcoin-core-dev
06:01 -!- Landryl4 [~Landryl@ns528256.ip-192-99-10.net] has quit [Client Quit]
06:03 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has joined #bitcoin-core-dev
06:34 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection]
06:35 -!- ajonas_ [sid385278@gateway/web/irccloud.com/x-texshgghcgszektg] has joined #bitcoin-core-dev
06:38 -!- ajonas_ [sid385278@gateway/web/irccloud.com/x-texshgghcgszektg] has left #bitcoin-core-dev []
06:39 -!- ajonas [sid385278@gateway/web/irccloud.com/x-fzklvcabnnbgevvy] has joined #bitcoin-core-dev
06:44 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
06:46 -!- tynes [~tynes@30.50.237.35.bc.googleusercontent.com] has quit [Ping timeout: 256 seconds]
06:47 -!- tralfaz is now known as davterra
06:48 -!- tynes [~tynes@30.50.237.35.bc.googleusercontent.com] has joined #bitcoin-core-dev
06:50 < jnewbery> hi folks. We'll get started on the p2p meeting in 10 minutes
06:51 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 264 seconds]
06:55 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
06:56 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has joined #bitcoin-core-dev
06:58 < fanquake> 🕰️
06:58 -!- tralfaz [~davterra@94.198.43.53] has joined #bitcoin-core-dev
06:58 -!- davterra [~davterra@94.198.43.106] has quit [Disconnected by services]
06:59 -!- tralfaz is now known as davterra
07:00 -!- Suigintou [~Suigintou@92.223.89.101] has quit []
07:00 < jnewbery> #startmeeting
07:00 < core-meetingbot> Meeting started Tue Nov 17 15:00:13 2020 UTC.  The chair is jnewbery. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
07:00 < core-meetingbot> Available commands: action commands idea info link nick
07:00 < amiti> hi
07:00 < jnewbery> #bitcoin-core-dev P2P Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral ariard digi_james 
07:00 < ariard> hello
07:00 < jnewbery> amiti fjahr jeremyrubin lightlike emilengler jonatack hebasto jb55 elichai2
07:00 < jnewbery> fanquake: your clock is 2 minutes fast
07:00 < sdaftuar> heya
07:00 < troygiorshev> hi!
07:00 < jnewbery> Hi folks. Welcome to the first p2p meeting of 22.0!
07:01 < ajonas> hi
07:01 < sdaftuar> we branched off already?
07:01 < jnewbery> The last 0.21 milestone PRs were merged today, so I guess the branch off is imminent.
07:01 -!- anekdotin [~edwin___@068-187-232-180.res.spectrum.com] has joined #bitcoin-core-dev
07:01 < jnewbery> We have one proposed topic for today's meeting: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings#17-nov-2020.
07:01 < gribble> https://github.com/bitcoin/bitcoin/issues/17 | listaccounts method · Issue #17 · bitcoin/bitcoin · GitHub
07:01 < ariard> yep
07:02 < jnewbery> Before we get to that, I think it'd be useful for us to all share what our goals/priorities are for the 22.0 release cycle.
07:02 < jonatack> hi
07:02 < jnewbery> does anyone want to go first?
07:02 < fanquake> hi
07:02 < kanzure> hi
07:03 < sdaftuar> i'd say that i think it'd be great to prioritize erlay now
07:03 < ariard> Im waiting for https://github.com/bitcoin/bitcoin/pull/19160 landing before to go forward with altnet
07:03 < ariard> agree with erlay
07:04 -!- glozow [uid453516@gateway/web/irccloud.com/x-ohnvkcxaiqyauzpi] has joined #bitcoin-core-dev
07:04 < jonatack> BIP 342 implementation. Erlay. (And non-p2p-specific: multiprocess, coinstats, consensus code separation, assumeUTXO...)
07:05 < jnewbery> For me, I'd like to make some substantial progress in clarifying the net/net_processing and net_processing/validation interfaces. Those two projects are tracked in #19398 and #20158.
07:05 < gribble> https://github.com/bitcoin/bitcoin/issues/19398 | Move remaining application layer data to net processing · Issue #19398 · bitcoin/bitcoin · GitHub
07:05 < gribble> https://github.com/bitcoin/bitcoin/issues/20158 | tree-wide: De-globalize ChainstateManager by dongcarl · Pull Request #20158 · bitcoin/bitcoin · GitHub
07:05 -!- dermoth [~dermoth@unaffiliated/dermoth] has quit [Read error: Connection reset by peer]
07:05 < sdaftuar> i plan to work on block-relay-only peering too, though i'm stuck on some annoying addr-relay things that might hold me up
07:05 < troygiorshev> With the feature freeze now thawed, I wanted to remind everyone about Per-Peer Message logging #19509.  It got a lot of attention a while ago and I think it's a feature a lot of people would appreciate.  Just needs a bit more review!
07:05 < gribble> https://github.com/bitcoin/bitcoin/issues/19509 | Per-Peer Message Capture by troygiorshev · Pull Request #19509 · bitcoin/bitcoin · GitHub
07:05 -!- dermoth [~dermoth@unaffiliated/dermoth] has joined #bitcoin-core-dev
07:05 < troygiorshev> I'm also paying attention to BIP324 #18242
07:05 < gribble> https://github.com/bitcoin/bitcoin/issues/18242 | Add BIP324 encrypted p2p transport de-/serializer (only used in tests) by jonasschnelli · Pull Request #18242 · bitcoin/bitcoin · GitHub
07:06 < jonatack> jnewbery: sdaftuar: good stuff. i plan to resume review of those.
07:06 < jnewbery> thanks jonatack!
07:06 < jonatack> troygiorshev: thank you, i meant BIP324 :)
07:06 < ariard> I'm planning to work on a better version of #18797 and so understand better tx-standarndes before going back to package relay
07:06 < gribble> https://github.com/bitcoin/bitcoin/issues/18797 | Export standard Script flags in bitcoinconsensus by ariard · Pull Request #18797 · bitcoin/bitcoin · GitHub
07:07 < amiti> in terms of my work: hoping to make progress on 19315 (adding full-relay and block-relay-only to tests), and I'm working on reviving rebroadcast  
07:07 < nehan> hi
07:09 < jonatack> amiti: will review
07:09 < jnewbery> ok, anyone want to add any topics before we get onto "Reducing CVE-2020-26895 class of bugs and Tx-standardness" (ariard)
07:09 < gleb> Hi
07:09 < aj> touch base on wtxid backport?
07:09 -!- da39a3ee5e6b4b0d [~da39a3ee5@cm-171-98-79-192.revip7.asianet.co.th] has quit [Ping timeout: 272 seconds]
07:09 < jnewbery> hi aj. Yes, let's do that one first
07:10 < jnewbery> #topic touch base on wtic backport (aj)
07:10 < core-meetingbot> topic: touch base on wtic backport (aj)
07:10 < jnewbery> *wtxid
07:10 < sdaftuar> i'm not sure we should have backported wtxid-relay to the 0.20 branch
07:11 < aj> #20317 and #20399
07:11 < gribble> https://github.com/bitcoin/bitcoin/issues/20317 | Backport wtxid orphan fetch to v0.20 by jnewbery · Pull Request #20317 · bitcoin/bitcoin · GitHub
07:11 < gribble> https://github.com/bitcoin/bitcoin/issues/20399 | Revert "Merge #19606: Backport wtxid relay to v0.20" by MarcoFalke · Pull Request #20399 · bitcoin/bitcoin · GitHub
07:11 -!- da39a3ee5e6b4b0d [~da39a3ee5@cm-171-98-79-192.revip7.asianet.co.th] has joined #bitcoin-core-dev
07:12 < aj> afaik, #19620 which is in 0.19 and 0.20 already does everything we really need wtxid to do backport-wise for taproot
07:12 < gribble> https://github.com/bitcoin/bitcoin/issues/19620 | Add txids with non-standard inputs to reject filter by sdaftuar · Pull Request #19620 · bitcoin/bitcoin · GitHub
07:12 < aj> so 20399 is there to revert wtxid relay from 0.20; or 20317 is there to fix up the orphan handling regression if there's a reason to keep it
07:13 < sdaftuar> (i missed that github discussion, catching up now)
07:13 < jnewbery> I don't have a strong opinion, but I
07:13 < jnewbery> 'm curious what has changed since this was discussed in a previous meeting, when people agreed that it should be backported
07:14 < aj> 19620 imo
07:15 < anekdotin> great job guys
07:15 < sdaftuar> (ok caught up)
07:16 < sdaftuar> i think that knowing that there was a crashing bug in that line of work sort of heightens the sense that backporting a feature is not really a great idea?
07:16 < sdaftuar> i don't think backporting it was a requirement in the first place, but i saw the reasoning that it was a nice-to-have.  but given that it indeed turned out to be risky, i'd say let's drop it, as there's no compelling reason for backport after #19620 either
07:16 < gribble> https://github.com/bitcoin/bitcoin/issues/19620 | Add txids with non-standard inputs to reject filter by sdaftuar · Pull Request #19620 · bitcoin/bitcoin · GitHub
07:17 < sdaftuar> so falling back on our principle of only backporting bugfixes seems like the prudent thing
07:20 < jonatack> A propos, sharing a message from moneyball who mentioned tripling down on testing (bug discovery+fixes) between now and the 0.21 release with all of the new features.
07:20 -!- TallTim [~TallTim@184-83-248-206-dynamic.midco.net] has joined #bitcoin-core-dev
07:20 < jnewbery> sdaftuar: do you think it should be reverted?
07:20 < sdaftuar> yeah
07:21 < jnewbery> because we're not confident in the code?
07:21 < sdaftuar> if 0.21 has some other crashign bug related to wtxid-relay, it'd be great to be able to go back to 0.20.2 or whatever and have it not crash!
07:21 -!- blardo [~blardo@178.239.168.171] has joined #bitcoin-core-dev
07:22 < aj> jnewbery: so i think your review beg on oct-20th should've resulted in some sort of a "do we really still need this?" response, rather than silence both here and on the PR -- i think that was the only time it was mentioned in these meetings since 19620
07:23 < jnewbery> aj: yeah, people agreed in the original meeting that it should have been backported, and then I've raised reviewing the PR in several meetings since then
07:23 < jnewbery> I don't think the presence of a bug that was caught in review and fixed in the follow up changes the facts, but I can understand that it makes people nervous
07:24 < jnewbery> so if people want it out, then it should be reverted
07:25 < jnewbery> #action revert #20317
07:25 < core-meetingbot> ACTION: revert #20317
07:25 < gribble> https://github.com/bitcoin/bitcoin/issues/20317 | Backport wtxid orphan fetch to v0.20 by jnewbery · Pull Request #20317 · bitcoin/bitcoin · GitHub
07:25 < gribble> https://github.com/bitcoin/bitcoin/issues/20317 | Backport wtxid orphan fetch to v0.20 by jnewbery · Pull Request #20317 · bitcoin/bitcoin · GitHub
07:26 < jnewbery> #topic Reducing CVE-2020-26895 class of bugs and Tx-standardness (ariard)
07:26 < core-meetingbot> topic: Reducing CVE-2020-26895 class of bugs and Tx-standardness (ariard)
07:26 < ariard> hello
07:26 < ariard> first and foremost, I apologize for the previous rounds of discussion on this issue, it was a bit noisy to talk grasp problem right this without this vuln being public
07:27 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
07:27 < ariard> for the context, lnd didn't check that counterparty commitment signatures were in the curve order /2 
07:28 < ariard> which means a malicous counterparty was able to feed them with non-relayable witness and thus complete break its security
07:29 -!- da39a3ee5e6b4b0d [~da39a3ee5@cm-171-98-79-192.revip7.asianet.co.th] has quit [Ping timeout: 265 seconds]
07:29 < ariard> because those time-sensitive transactions won't propagate before timelock expiration
07:29 < ariard> of the HTLCs
07:30 < ariard> I think the lesson it's not the first time that a LN implementation had issues with tx-standard, CL had some 2y ago IIRC about minimal relay fee
07:31 < ariard> so it sounds we have this class of vulns concerning any time-sensitive protocols, and how to mitigate it correctly is a bit unclear
07:31 < luke-jr> be strict on transaction form..
07:31 < sdaftuar> testmempoolaccept?
07:31 < aj> testmempoolaccept RPC isn't useful because you don't want to finish signing the tx, i guess?
07:31 < luke-jr> you can never rely on node/relay policies
07:31 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev
07:32 < luke-jr> just have to do what you can to reasonably pass them
07:32 < luke-jr> testmempoolaccept only tells you about your own policy
07:32 < ariard> aj: my concern with testmempoolaccept its checks are blurred with the fees ones
07:32 < ariard> but your transaction is okay because you plan to broadcast only in the future
07:33 < sdaftuar> luke-jr: i agree, but perhaps a belt and suspenders approach where you enforce a strict transaction form and also double-check against testmempoolaccept might be helpful
07:33 < luke-jr> it might detect bugs I suppose
07:33 < ariard> also you have a really code architecture thing, LN mobiles won't have a mempool but they need to do the check
07:33 < sdaftuar> or unexpected changes
07:34 < sdaftuar> ariard: i think you'll need to specify the problem a bit better if you are assuming not having access to a full node
07:34 < luke-jr> ariard: it can't be secure without your own full node anyway
07:34 < sdaftuar> for instance, do you have access to all the inputs?
07:34 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
07:34 < ariard> luke-jr: you might receive the headers from a trusted connection to your full node on your LN node
07:34 < luke-jr> so you mean you don't have RPC access?
07:35 < ariard> sdaftuar: I think we should assume no, it's concering any kind of LN clients
07:35 < luke-jr> too bad we removed the reject message..
07:35 < sdaftuar> ariard: if no, then isn't this problem hopeless?
07:35 < ariard> sdaftuar: you have access to the funding utxo of your channel
07:35 < ariard> always, that's a protocol assumption
07:36 < sdaftuar> ariard: but if i include an input you don't know about, then you must reject the transaction, because you have no way of knowing if it's valid, let alone standard?
07:36 < ariard> what you want to verify is the chain of transaction built from this utxo (commitment+HTLC txn) are tx-relay "valid"
07:36 < ariard> sdaftuar: for commitment transaction the utxo is 2-of-2
07:36 < luke-jr> ariard: not possible to do reliably..
07:37 -!- kexkey [~kexkey@static-198-54-132-91.cust.tzulo.com] has joined #bitcoin-core-dev
07:38 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 264 seconds]
07:38 < ariard> luke-jr: at least you should be able to be sure your transaction is accepted by your full-node
07:38 < luke-jr> nodes will relay what they want; there are no consensus rules forcing relay
07:38 < luke-jr> ariard: sure
07:38 < ariard> luke-jr: I finally agree with you on this, it's more a LN-client to its full-node relation we should care about?
07:39 < luke-jr> ariard: so this part of problem is because you don't necessarily have RPC access, and we no longer support the reject msg?
07:40 < ariard> luke-jr: I think it's more subtle, you have those LN transactions, that both you and your counterparty must agree on, but ultimately their validity is decided by your full-node
07:40 < aj> ariard: what good is a commitment tx with a low fee rate that won't be acceptable possibly for months? don't you want to know that your node will (currently) reject that?
07:40 < luke-jr> hmm, I suppose the TXOs spent in it migth also not be something you want broadcast yet
07:40 < ariard> aj: in the future we might have fixed-fee commitment transactions and their feerate adjusted by a CPFP+package relay
07:40 < ariard> but I may jump one step in the reasoning here, hard to see
07:41 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
07:41 < aj> ariard: right, but at that point you'd expect testmempoolaccept to support packages
07:41 < sdaftuar> aj: bold :)
07:42 < aj> sdaftuar: (easier to implement package testmempoolaccept than package relay anyway?)
07:42 < ariard> luke-jr: what's concerning is right now we are leaking those policy check directly in the LN spec, but we may should do the reverse and let those tx-relay be ultimaltey defined by LN clients
07:42 < sdaftuar> aj: fewer DoS vectors to worry about for sure!
07:42 < glozow> aj: hey guess what
07:43 < aj> glozow: you already did it??
07:43 < ariard> aj: yes if this the case, it's more a cod architecture reason, to have a strict transaction form lib
07:43 < glozow> a little bit, i have a math test this week though, and then i'll send you my draft of package testmempoolaccept
07:43 < luke-jr> ariard: the spec just needs to be narrow enough that there's a good hope any tx will be accpeted
07:44 < ariard> aj: we shouldn't require LN clients to have access to all the utxo set, you just care about your channel utxo only, testmempoolaccept assume you have access to the full set rn?
07:44 < luke-jr> double-checking against your own node makes sense, but ultimately shouldn't be your security check
07:45 < luke-jr> ariard: to open a channel, you need access to the entire UTXO set to be sure the inputs are valid..
07:45 < sdaftuar> ariard: oh, yes you're right that testmempoolaccept requires all inputs to be available in mempool or utxo set, so if you're testing validity further down a chain that won't work right now
07:45 < aj> ariard: i think if you pull some checks out of "here's my full node" into "here's my light library" you'll run the same risk of missing some checks that are actually needed; but ymmv of course
07:46 < ariard> luke-jr: I see your point, but you might not have access to the UTXO set for the rest of the discussion
07:46 < ariard> *protocol execution, sorry
07:46 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds]
07:47 < ariard> aj: yes that's exactly my worry, mempool checks are a bit blurred, and some we are interested with are also inside the script interpreter
07:47 < aj> ariard: maybe a psbt validator could make more sense, alternatively? partial so you don't need all the inputs or even all the signatures, but still get useful results like "fees look low!" "this is a dust output!" "this signature is wrong!"
07:48 < aj> ariard: psbts are (probably) common enough that it would justify thorough useful (re)implementation of standardness and consensus and sanity checks
07:48 < ariard> luke-jr: without entering in a light-client debtate, for LN if you assume people are using light-clients, it's not reason for them not being at least secure on tx-relay checks
07:48 < ariard> lke layering security reasoning
07:48 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
07:49 < jnewbery> ariard: testmempoolaccept does require the full UTXO set, but you could imagine a version where you provide the inputs, like signrawtransaction
07:49 < sdaftuar> philosophically though there is no such thing as "bitcoin's tx relay rules". i think that's luke's fundamental point (which I agree with)
07:49 < ariard> aj: only validating the inputs and not the other transaction check like version, number of max outputs
07:49 < ariard> ?
07:49 < aj> ariard: validating all the other stuff seems relevant for psbts in general, i think?
07:49 < luke-jr> ariard: your non-debatable premise is false
07:50 < ariard> sdaftuar: I finally agree with it, what I'm trying to understand is the margin we might have to make thing better
07:50 < sdaftuar> i think the best we can do is what luke suggested already: narrow what you accept to a small enough subset that you think will likely to always be relayable now and in the future, and hope for the best.
07:51 < sdaftuar> testing validity against a bunch of full-node implementations is a nice backup to make sure your code isn't broken or things haven't changed out from under you
07:53 < aj> sdaftuar: not very robust against hostile peers who have access to your code base to find checks you forgot to implement, though; hard to fuzz test for valid-but-non-standard sigs and the like even, afaik
07:53 < ariard> I see the point, which means anytime someone is implementing or desinging a L2 protocol you have to open your full-node code and understand those blurred checks
07:53 < jnewbery> ariard: do you have what you need from this discussion? Anything else you need or could use help with?
07:53 < ariard> aj: we should assume your counterparty shouldn't be able to observe your full-node implementation or policy, but can we really do this?
07:54 < ariard> jnewbery: if I'm reworking on a #18797 as a wrapper on top of testmempoolaccept like libconsensus is anyone have strong NACK?
07:54 < gribble> https://github.com/bitcoin/bitcoin/issues/18797 | Export standard Script flags in bitcoinconsensus by ariard · Pull Request #18797 · bitcoin/bitcoin · GitHub
07:55 < ariard> for code architecture reason, not making an assumption your LN client has access to a RPC interace
07:56 < jnewbery> I don't understand what you mean as a 'wrapper on top of testmempoolaccept'
07:56 < ariard> jnewbery: on top of ATMP, but it sounds we need to be able to pass a partial utxo set first to it
07:57 < jnewbery> but in any case, we should wrap this up. It's almost endmeeting time.
07:57 < jnewbery> Any last minute topics before we close?
07:57 < gleb> Just wanted to let you guys know that #18261 is ready for review (despite Travis being a bit unhappy, fixing that)
07:57 < sdaftuar> if you mean add package support to testmempoolaccept, i think that would be reasonable
07:57 < gribble> https://github.com/bitcoin/bitcoin/issues/18261 | Erlay: bandwidth-efficient transaction relay protocol by naumenkogs · Pull Request #18261 · bitcoin/bitcoin · GitHub
07:57 < sdaftuar> gleb: nice!
07:57 < ariard> yeah people want to run those LN clients on hardware, and you might not want to run a full-node with full resource on this
07:57 < ariard> jnewbery: sure, thanks anyone for the discussion
07:57 < jnewbery> sdaftuar: glozow has a draft implementation of that
07:57 < aj> gleb: haha, was just checking logs to see if it'd be rude to ask about that
07:58 < jnewbery> thanks gleb!
07:58 < ariard> jnewbery: is it coalesing the feerate check ?
07:58 < jnewbery> ariard: yes, returns feerate for each individual tx and the package
07:59 < jnewbery> ok, that's time. Thanks all!
07:59 < jnewbery> #endmeeting
07:59 < core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
07:59 < core-meetingbot> Meeting ended Tue Nov 17 15:59:08 2020 UTC.  
07:59 < core-meetingbot> Minutes:        https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2020/bitcoin-core-dev.2020-11-17-15.00.moin.txt
07:59 < ariard> jnewbery: checking if the feerate of the whole package is okay while one of the transaction might be under the mempool min fee
08:02 < jnewbery> ariard: I believe it would reject the package if any of the txs are below the min feerate (which makes sense while we don't have package relay). That could be changed later
08:03 < sipa> hi
08:03 < sipa> i guess i'm a bit late
08:03 < sdaftuar> sipa: off by one hour?
08:03 < luke-jr> XD
08:03 < sipa> actually i just forgot
08:04 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 272 seconds]
08:04 < pinheadmz> what time is the p2p meeting in UTC? the event just floated around my calendar due to daylight savings
08:05 < ariard> jnewbery: right, let do step by step, it's not bad to un-blurred those checks
08:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
08:06 < ariard> aj: I need to think about your psbt validator suggestion, because the caller being able to select the verification scope, it let you validate counterparty signature without actually to produce yours
08:07 < ariard> and that's a good thing, for LN, in the happy case you don't have to generate your LN commitment signature
08:10 < aj> ariard: might be something that's useful elsewhere (hardware wallets, multisig setups in general), which might help it stay maintained
08:13 -!- kljasdfvv [~flack@p200300d46f24de00370042481f229b06.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!]
08:14 -!- kljasdfvv [~flack@p200300d46f24de0037c8a8d81a15c016.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
08:16 -!- theChief [~Mohamed@bb121-6-182-56.singnet.com.sg] has quit []
08:26 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
08:35 < jnewbery> pinheadmz: it's 15:00 UTC on alternate Tuesdays: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings
09:08 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
09:22 -!- anekdotin [~edwin___@068-187-232-180.res.spectrum.com] has quit [Quit: Leaving]
09:32 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
09:32 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
09:35 -!- einyx [einyx@fsf/member/einyx] has quit [Ping timeout: 246 seconds]
09:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:36 < bitcoin-git> [bitcoin] jnewbery closed pull request #20317: Backport wtxid orphan fetch to v0.20 (0.20...2020-07-v20-wtxid-orphan) https://github.com/bitcoin/bitcoin/pull/20317
09:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:39 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
09:40 -!- einyx [einyx@fsf/member/einyx] has joined #bitcoin-core-dev
09:52 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
09:57 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
09:59 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds]
09:59 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
10:00 -!- blardo [~blardo@178.239.168.171] has quit []
10:07 -!- foxp2 [~foxp2@ec2-18-235-230-166.compute-1.amazonaws.com] has joined #bitcoin-core-dev
10:14 -!- twistedline_ [~twisted@c-73-200-216-219.hsd1.dc.comcast.net] has joined #bitcoin-core-dev
10:16 -!- twistedline [~twisted@unaffiliated/twistedline] has quit [Ping timeout: 260 seconds]
10:22 -!- dfkt [~dfkt@178.162.212.214] has joined #bitcoin-core-dev
10:29 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
10:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:30 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20410: wallet: Do not treat default constructed types as None-type (master...2011-rpcWalletNoneType) https://github.com/bitcoin/bitcoin/pull/20410
10:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:37 < achow101> so branching soon?
10:38 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Ping timeout: 272 seconds]
10:38 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadmz]
10:40 < MarcoFalke> https://i.redd.it/az0w7m53abb21.png
10:41 < MarcoFalke> ping wumpus :)
10:49 -!- cryptapus [~cryptapus@jupiter.osmus.org] has joined #bitcoin-core-dev
10:49 -!- cryptapus [~cryptapus@jupiter.osmus.org] has quit [Changing host]
10:49 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev
10:50 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
10:50 -!- miketwenty1 [~miketwent@ec2-52-73-85-113.compute-1.amazonaws.com] has joined #bitcoin-core-dev
10:51 < miketwenty1> Q: is there an equivalent gitian.sigs for guix build process?
10:52 < sipa> i assumed we'd just run the guix build inside gitian, but haven't followed in detail
10:56 < luke-jr> same here
10:56 < luke-jr> especially since Guix still requires trusted third-party blobs
10:56 < miketwenty1> sipa, right now in bitcoin-core repo we have the gitian sigs for non guix process .. but would we have a sigs folder for guix build process or am i thinking about this incorrectly?
10:57 < achow101> I would expect that we would keep the same assert files and have them in the same repo
10:57 < luke-jr> miketwenty1: at some point, I expect the gitian descriptors will be rewritten to use Guix instead of Ubuntu, and the depends/ build system will go away
10:57 < achow101> it would just be a slightly misnamed repo
10:57 < luke-jr> misnamed?
10:57 < miketwenty1> i see.. seems like the idea here is gitian build process improves with guix instead of replaces it?
10:57 < achow101> gitian.sigs wouldn't be strictly tied to gitian because in theory you could produce them without gitian
10:58 < luke-jr> achow101: in theory you already could :P
10:58 < achow101> I would expect the gitian descriptors to do the guix build because that makes the transition easier
10:58 < sipa> once we have guix-based deterministic builds, much of what gitian provides would be technically overkill
10:58 < luke-jr> miketwenty1: gitian is providing less of the deterministic stuff with guix
10:58 < sipa> but given that it already exists, and has infrastructure around it, it's probably easier to keep it (and just use guix inside gitian)
10:59 < achow101> luke-jr: iirc guix can be fully bootstrapped with only trusting a single small blob that is kind of verifiable. but it also takes forever to build everything
11:07 < wumpus> achow101: MarcoFalke: will do the split-off tomorrow morning (europe time)
11:07 < MarcoFalke> wumpus: Thanks
11:07 < achow101> ack
11:08 < luke-jr> achow101: "a single small blob" is still a blob
11:08 < luke-jr> and it's not very verifiable
11:08 < achow101> luke-jr: it can be disassembled and verified
11:09 < luke-jr> achow101: it's still too big for that
11:09 < MarcoFalke> I am not sure if it is easier to set up gitian than guix these days
11:09 -!- foxp2 [~foxp2@ec2-18-235-230-166.compute-1.amazonaws.com] has quit [Quit: \/\/]
11:10 < luke-jr> MarcoFalke: I have failed to setup Guix to date
11:10 < luke-jr> after spending hours on it
11:11 < MarcoFalke> It will still be easier to set up a debian vm and run the one-line install command for you than to setup gitian on a debian vm
11:12 < achow101> I have it setup but I don't remember how I did it
11:12 < luke-jr> "one-line install command" does not get you a trustless setup
11:12 < luke-jr> achow101: mind you, I refuse to run third-party binaries, and am using ppc64le
11:13 < MarcoFalke> Ok, then wait for debian to ship guix in the package manager, this will be as trustless as the current gitian build
11:13 < luke-jr> I suppose it's not entirely fair since I don't have gitian working on ppc64le, and Ubuntu is a huge blob :P
11:13 < luke-jr> MarcoFalke: I don't use Debian.
11:14 < MarcoFalke> Our gitian descriptors use debian/ubuntu
11:14 < luke-jr> inside the VM, yes
11:14 < MarcoFalke> So if you don't trust them, I doubt you can trust the overall build setup
11:15 < luke-jr> MarcoFalke: again, Guix is an improvement over Ubuntu, I fully agree with that
11:15 < luke-jr> but it isn't an alternative for gitian entirely at this point
11:16 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
11:16 < luke-jr> gitian can be setup without trusted binaries (outside the VM)
11:19 -!- az0re [~az0re@gateway/tor-sasl/az0re] has quit [Remote host closed the connection]
11:19 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
11:36 -!- FredC [~FredC@178.239.168.171] has quit [Remote host closed the connection]
11:56 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 246 seconds]
11:56 -!- ajbiz11 [~ajbiz11@217.146.82.202] has joined #bitcoin-core-dev
11:59 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
12:00 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
12:01 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
12:17 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has left #bitcoin-core-dev []
12:21 -!- az0re [~az0re@gateway/tor-sasl/az0re] has joined #bitcoin-core-dev
12:22 -!- syperf [~danie@2001:8a0:ba80:1a01:1c24:aaa4:ae86:9ba0] has joined #bitcoin-core-dev
12:35 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 246 seconds]
12:36 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
12:36 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
12:43 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds]
12:45 -!- miketwenty1 [~miketwent@ec2-52-73-85-113.compute-1.amazonaws.com] has quit [Ping timeout: 256 seconds]
12:58 -!- syperf [~danie@2001:8a0:ba80:1a01:1c24:aaa4:ae86:9ba0] has quit [Quit: Konversation terminated!]
13:00 -!- dfkt [~dfkt@178.162.212.214] has quit []
13:12 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
13:15 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds]
13:17 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev
13:22 -!- havenwood1 [~havenwood@185.204.1.185] has joined #bitcoin-core-dev
13:25 -!- miketwenty1 [~miketwent@ec2-18-235-230-166.compute-1.amazonaws.com] has joined #bitcoin-core-dev
13:26 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
13:32 -!- b10c [~b10c@2a01:4f8:192:612a:216:3eff:fef3:dc6a] has quit [Remote host closed the connection]
13:43 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
13:47 -!- miketwenty1 [~miketwent@ec2-18-235-230-166.compute-1.amazonaws.com] has quit [Remote host closed the connection]
13:49 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds]
13:50 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
14:02 -!- syperf [~danie@2001:8a0:ba80:1a01:1c24:aaa4:ae86:9ba0] has joined #bitcoin-core-dev
14:04 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
14:04 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
14:07 -!- miketwenty1 [~miketwent@c-98-251-86-215.hsd1.ga.comcast.net] has joined #bitcoin-core-dev
14:08 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
14:12 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
14:12 -!- vasild_ is now known as vasild
14:15 -!- miketwenty1 [~miketwent@c-98-251-86-215.hsd1.ga.comcast.net] has quit [Remote host closed the connection]
14:15 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has quit [Quit: leaving]
14:16 -!- syperf [~danie@2001:8a0:ba80:1a01:1c24:aaa4:ae86:9ba0] has quit [Quit: Konversation terminated!]
14:36 -!- filchef [~filchef@212.104.97.177] has quit [Quit: KVIrc 5.0.0 Aria http://www.kvirc.net/]
14:42 -!- Squidicuz [~squid@pool-72-74-34-120.bstnma.fios.verizon.net] has quit [Quit: Oh no, not again]
14:45 -!- promag [~promag@188.250.84.129] has quit [Remote host closed the connection]
14:57 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
15:02 -!- promag [~promag@188.250.84.129] has quit [Remote host closed the connection]
15:04 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
15:55 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds]
16:00 -!- havenwood1 [~havenwood@185.204.1.185] has quit []
16:02 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
16:02 -!- mrostecki_ [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev
16:05 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Ping timeout: 240 seconds]
16:05 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has quit [Quit: Ping timeout (120 seconds)]
16:06 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has joined #bitcoin-core-dev
16:08 -!- aqua429 [~aqua42@amsterdam3.jp.net] has joined #bitcoin-core-dev
16:08 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
16:10 -!- aqua42 [~aqua42@amsterdam3.jp.net] has quit [Ping timeout: 240 seconds]
16:10 -!- aqua429 is now known as aqua42
16:15 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
16:22 -!- Nolar [~Nolar@185.163.110.116] has joined #bitcoin-core-dev
16:25 -!- shesek` [~shesek@164.90.217.137] has joined #bitcoin-core-dev
16:25 -!- x58743446 [~face@207.154.206.50] has joined #bitcoin-core-dev
16:25 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 260 seconds]
16:25 -!- x58743445 [~face@207.154.206.50] has quit [Ping timeout: 260 seconds]
16:29 -!- da39a3ee5e6b4b0d [~da39a3ee5@cm-171-98-78-149.revip7.asianet.co.th] has joined #bitcoin-core-dev
16:29 -!- jrawsthorne_ [~jrawsthor@static.235.41.217.95.clients.your-server.de] has quit [Ping timeout: 256 seconds]
16:29 -!- jrawsthorne [~jrawsthor@static.235.41.217.95.clients.your-server.de] has joined #bitcoin-core-dev
16:30 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has quit [Ping timeout: 256 seconds]
16:30 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has joined #bitcoin-core-dev
16:31 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
16:31 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
16:31 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds]
16:31 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev
16:46 -!- Ami71 [4c7ec8bc@76.126.200.188] has joined #bitcoin-core-dev
16:58 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 256 seconds]
17:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
17:01 < bitcoin-git> [bitcoin] troygiorshev opened pull request #20411: Fix Version Message Deserialization Discrepancy (master...2020-11-test-framework-version-msg-fix) https://github.com/bitcoin/bitcoin/pull/20411
17:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
17:06 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Read error: Connection reset by peer]
17:09 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has joined #bitcoin-core-dev
17:24 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit []
17:26 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has quit [Read error: Connection reset by peer]
17:27 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has joined #bitcoin-core-dev
18:32 -!- ajbiz11 [~ajbiz11@217.146.82.202] has quit [Remote host closed the connection]
18:43 -!- da39a3ee5e6b4b0d [~da39a3ee5@cm-171-98-78-149.revip7.asianet.co.th] has quit [Ping timeout: 240 seconds]
18:44 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Ping timeout: 260 seconds]
18:51 -!- mrd [~mrd@185.204.1.185] has joined #bitcoin-core-dev
18:52 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-dev
18:52 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Changing host]
18:52 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev
19:00 -!- Nolar [~Nolar@185.163.110.116] has quit []
19:12 -!- Ami71 [4c7ec8bc@76.126.200.188] has quit [Remote host closed the connection]
19:17 -!- da39a3ee5e6b4b0d [~da39a3ee5@cm-171-98-78-149.revip7.asianet.co.th] has joined #bitcoin-core-dev
19:23 -!- WalkGood [~WalkGood@84.39.117.57] has joined #bitcoin-core-dev
19:41 -!- Guest13027 [~dqx@unaffiliated/dqx] has quit [Quit: leaving]
19:54 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
19:57 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds]
20:00 -!- da39a3ee5e6b4b0d [~da39a3ee5@cm-171-98-78-149.revip7.asianet.co.th] has quit [Ping timeout: 256 seconds]
20:32 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds]
20:34 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev
20:44 -!- da39a3ee5e6b4b0d [~da39a3ee5@cm-171-98-78-149.revip7.asianet.co.th] has joined #bitcoin-core-dev
21:15 -!- da39a3ee5e6b4b0d [~da39a3ee5@cm-171-98-78-149.revip7.asianet.co.th] has quit [Ping timeout: 264 seconds]
21:17 -!- mrd [~mrd@185.204.1.185] has quit [Remote host closed the connection]
21:20 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
21:23 < luke-jr> feature_taproot is failing 100% of the time for me on master - anyone else?
21:23 < luke-jr> line 1454 test_framework.authproxy.JSONRPCException: 'signrawtransactionwithwallet' RPC took longer than 30.000000 seconds. Consider using larger timeout for calls that take longer to return. (-344)
21:27 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
21:29 < aj> luke-jr: finishes successfully in 3minutes total here
21:29 < sipa> luke-jr: do you have #20292?
21:29 < gribble> https://github.com/bitcoin/bitcoin/issues/20292 | test: Fix intermittent feature_taproot issue by MarcoFalke · Pull Request #20292 · bitcoin/bitcoin · GitHub
21:29 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 246 seconds]
21:30 < luke-jr> yes, current master
21:31 < luke-jr> annoyingly, if I skip the long tests before it, it passes :/
21:32 < sipa> actually, does it work if you revert 20292?
21:32 -!- Guest89105 [~serAphim@178.162.212.214] has joined #bitcoin-core-dev
21:37 < sipa> this is so silly, it's the most boring part of the test, moving some funds from one node to the other
21:39 < luke-jr> XD
21:39 < luke-jr> scarily, it looks like it's inside SignatureHash<CTransaction> it gets stuck
21:42 < aj> using pre-segwit addresses and getting O(N^2) hashing somehow?
21:42 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds]
21:42 < luke-jr> yes, it still failed with 20292 reverted
21:43 < luke-jr> oh wait, I only reverted the top commit of 20292
21:44  * luke-jr waits another 5 mins for the test to run x.x
21:48 < luke-jr> ok, yes, with 20292 reverted, it does pass
21:50 < aj> ah, if i time just that line it takes 19.8 seconds
21:58 -!- da39a3ee5e6b4b0d [~da39a3ee5@cm-171-98-78-149.revip7.asianet.co.th] has joined #bitcoin-core-dev
22:00 -!- WalkGood [~WalkGood@84.39.117.57] has quit []
22:04 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Read error: Connection reset by peer]
22:09 < sipa> luke-jr: i think that's easy to fix
22:10 -!- dviola [~diego@unaffiliated/dviola] has quit [Ping timeout: 240 seconds]
22:19 < aj> sipa, luke-jr: https://0bin.net/paste/+iS27p55#Yuci8YopMbLnpPlnKVBxGxo4oowQpq5Q9nxnz8HYolp  seems like it works?
22:20 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
22:22 < aj> also much faster, the entire loop takes 4s vs 19.8s for just the signing previously?
22:23 -!- nhandler1 [~nhandler@84.39.117.57] has joined #bitcoin-core-dev
22:35 < sipa> aj: i was just going to use createrawtx with no inputs, and only part of the funds as output, and then call fundrawtx
22:35 < sipa> but yes, that also workz
22:44 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev
22:44 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Remote host closed the connection]
22:52 < MarcoFalke> Another alternative would be to set "self.rpc_timeout = 240" like in some other tests
22:58 < aj> MarcoFalke: quicker tests are better tests though
23:00 < sipa> yeah, this is just a waste of time
23:00 < sipa> it's isn't even testing anything
23:07 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
23:08 -!- da39a3ee5e6b4b0d [~da39a3ee5@cm-171-98-78-149.revip7.asianet.co.th] has quit [Ping timeout: 240 seconds]
23:12 -!- TallTim [~TallTim@184-83-248-206-dynamic.midco.net] has quit [Ping timeout: 240 seconds]
23:14 -!- TallTim [~TallTim@184-83-248-206-dynamic.midco.net] has joined #bitcoin-core-dev
23:16 -!- hizkifw [hizkifwmat@gateway/shell/matrix.org/x-ddnsrzqakswfnoft] has joined #bitcoin-core-dev
--- Log closed Wed Nov 18 00:00:20 2020