--- Log opened Wed Nov 25 00:00:26 2020 00:01 -!- Pavlenex [~Thunderbi@178.220.103.52] has joined #bitcoin-core-dev 00:03 -!- reallll is now known as belcher 00:10 < sipa> w00t 00:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:18 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.21: https://github.com/bitcoin/bitcoin/compare/17294c182039...7264bcd20f70 00:18 < bitcoin-git> bitcoin/0.21 ba19f9b Wladimir J. van der Laan: build: Bump RC to rc2 00:18 < bitcoin-git> bitcoin/0.21 7264bcd Wladimir J. van der Laan: qt: Pre-rc2 translations update 00:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:18 < bitcoin-git> [bitcoin] laanwj pushed tag v0.21.0rc2: https://github.com/bitcoin/bitcoin/compare/v0.21.0rc2 00:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:22 < wumpus> I'm suddenly seeing really strange behavior with gen-manpages.sh: all \- seem to be removed? (see https://github.com/laanwj/bitcoin/commit/d552e128254621fe6f4a44cb59a7759ad4b29f40 ) might be a local issue, not pushing a manual pages update 00:24 < wumpus> have fun building rc2 anyhow :) 00:27 < fanquake> manpage gremlins 00:27 * fanquake started trying to build 0.21.1rc1 00:27 < wumpus> remove non-determinism in one place and ... 00:30 < wumpus> the issue is the 'sed -i "s/\\\-${BTCVER[1]}//g" ${MANDIR}/${cmdname}.1', ${BTCVER[1]} evaluates to an empty string 00:30 -!- az0re [~az0re@gateway/tor-sasl/az0re] has quit [Remote host closed the connection] 00:31 < wumpus> what triggered this is that I ran it after tagging, there is still some weirdness in the version script with tags, generating a different kind of version spec 00:32 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 00:34 < wumpus> how easy commands like sed turn into run-away gremlins gives me shivers but at least this shouldn't normally happen 00:36 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 260 seconds] 00:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:49 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/efd4cdb81fc7...1e9e4b68f3cb 00:49 < bitcoin-git> bitcoin/master e95aaef Niklas Gögge: build: Avoid secp256k1.h include from system 00:49 < bitcoin-git> bitcoin/master 1e9e4b6 Wladimir J. van der Laan: Merge #20469: build: Avoid secp256k1.h include from system 00:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:49 < bitcoin-git> [bitcoin] laanwj merged pull request #20469: build: Avoid secp256k1.h include from system (master...fixincludeorder) https://github.com/bitcoin/bitcoin/pull/20469 00:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:53 -!- az0re [~az0re@gateway/tor-sasl/az0re] has joined #bitcoin-core-dev 00:57 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 01:01 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:11 -!- m9aq [~m9aq@106.37.187.213] has joined #bitcoin-core-dev 01:11 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 01:15 -!- vasild_ is now known as vasild 01:17 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 256 seconds] 01:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:28 < bitcoin-git> [bitcoin] practicalswift opened pull request #20487: draft: Add syscall sandboxing using seccomp-bpf (Linux secure computing mode) (master...seccomp-bpf-2020-11) https://github.com/bitcoin/bitcoin/pull/20487 01:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:29 -!- Kiminuo [~mix@217.138.199.36] has joined #bitcoin-core-dev 01:32 -!- Kiminuo [~mix@217.138.199.36] has quit [Client Quit] 01:32 -!- Kiminuo [~mix@217.138.199.36] has joined #bitcoin-core-dev 01:32 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:41 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev 01:42 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Remote host closed the connection] 01:42 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev 01:44 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Remote host closed the connection] 01:45 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev 01:52 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 01:58 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 240 seconds] 02:03 -!- zcd-alan [b70e8545@183.14.133.69] has quit [Remote host closed the connection] 02:04 -!- kexkey [~kexkey@static-198-54-132-118.cust.tzulo.com] has quit [Ping timeout: 246 seconds] 02:11 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Quit: WeeChat 2.9] 02:12 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 02:13 < Kiminuo> https://github.com/bitcoin/bitcoin/issues/20488 I would be very grateful for any feedback on this. 02:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:26 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to 0.21: https://github.com/bitcoin/bitcoin/compare/7264bcd20f70...4e964094dbcb 02:26 < bitcoin-git> bitcoin/0.21 fa05d19 MarcoFalke: test: Fix intermittent issue in mempool_compatibility 02:26 < bitcoin-git> bitcoin/0.21 4e96409 MarcoFalke: Merge #20486: [backport] test: Fix intermittent issue in mempool_compatibi... 02:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:26 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20486: [backport] test: Fix intermittent issue in mempool_compatibility (0.21...2011-testFixMempool) https://github.com/bitcoin/bitcoin/pull/20486 02:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:26 -!- m9aq [~m9aq@106.37.187.213] has quit [Quit: m9aq] 02:27 -!- robotadam1 [~robotadam@s91904426.blix.com] has joined #bitcoin-core-dev 02:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:28 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to 0.21: https://github.com/bitcoin/bitcoin/compare/4e964094dbcb...d47d16025e21 02:28 < bitcoin-git> bitcoin/0.21 fac4e13 MarcoFalke: refactor: Change pointer to reference because it can not be null 02:28 < bitcoin-git> bitcoin/0.21 fa69c2c MarcoFalke: wallet: Do not treat default constructed types as None-type 02:28 < bitcoin-git> bitcoin/0.21 d47d160 MarcoFalke: Merge #20485: [backport] wallet: Do not treat default constructed types as... 02:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:28 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20485: [backport] wallet: Do not treat default constructed types as None-type (0.21...2011-rpcWalletNoneType) https://github.com/bitcoin/bitcoin/pull/20485 02:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:40 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:44 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 02:47 -!- az0re [~az0re@gateway/tor-sasl/az0re] has quit [Remote host closed the connection] 02:56 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 260 seconds] 03:00 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 03:01 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Remote host closed the connection] 03:01 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 03:03 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 03:08 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has quit [Remote host closed the connection] 03:11 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-dev 03:18 -!- Domenica84Connel [~Domenica8@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev 03:21 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has quit [Ping timeout: 272 seconds] 03:22 -!- provoostenator_ [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-dev 03:22 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 265 seconds] 03:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:29 < bitcoin-git> [bitcoin] sipsorcery opened pull request #20489: CI msvc: only build vcpkg dependencies for release (not debug) to reduce build times (master...msvc_vcpkg_relonly) https://github.com/bitcoin/bitcoin/pull/20489 03:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:29 -!- Domenica84Connel [~Domenica8@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 240 seconds] 03:33 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:35 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev 03:39 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 256 seconds] 03:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:48 < bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/1e9e4b68f3cb...afdfd3c8c1ce 03:48 < bitcoin-git> bitcoin/master c46c18b Jon Atack: wallet: refactor GetClosestWalletFeature() 03:48 < bitcoin-git> bitcoin/master 2498b04 Andrew Chow: Don't upgrade to HD split if it is already supported 03:48 < bitcoin-git> bitcoin/master 99d56e3 Jon Atack: wallet: fix and improve upgradewallet result responses 03:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:48 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20403: wallet: upgradewallet fixes, improvements, test coverage (master...upgradewallet-improvements) https://github.com/bitcoin/bitcoin/pull/20403 03:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:50 -!- az0re [~az0re@gateway/tor-sasl/az0re] has joined #bitcoin-core-dev 03:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:51 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20490: [backport] wallet: upgradewallet fixes, improvements, test coverage (0.21...2011-backportWalletUpgrade) https://github.com/bitcoin/bitcoin/pull/20490 03:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:08 -!- da39a3ee5e6b4b0d [~da39a3ee5@67.23.55.162] has quit [Ping timeout: 256 seconds] 04:10 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 04:14 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 272 seconds] 04:24 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 04:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:27 < bitcoin-git> [bitcoin] hebasto opened pull request #20491: Drop noop gcc version checks (master...201125-gcc) https://github.com/bitcoin/bitcoin/pull/20491 04:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:39 < gleb> jnewbery: Thanks for catching what seems to be a mistake in asmap supplying implementation! We should make a fix, a couple more eyes would be useful as well, just to confirm our understanding. 04:39 < gleb> https://github.com/bitcoin/bitcoin/pull/16702/files/3c1bc40205a3fcab606e70b0e3c13d68b2860e34#r530338668 04:40 -!- mol [~mol@unaffiliated/molly] has quit [Quit: Leaving] 04:44 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Remote host closed the connection] 04:59 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.161.165] has joined #bitcoin-core-dev 05:00 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev 05:03 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds] 05:15 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 05:24 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection] 05:25 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 05:31 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 05:32 -!- mira [5631fc9d@ip-86-49-252-157.net.upcbroadband.cz] has joined #bitcoin-core-dev 05:32 -!- mira is now known as Guest78554 05:33 -!- Pavlenex [~Thunderbi@178.220.103.52] has quit [Quit: Pavlenex] 05:35 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 05:35 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection] 05:38 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 05:40 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 05:41 < wumpus> finally got around to pushing my gitian sigs for 0.21.0rc2 05:43 < wumpus> all osx matching up to now that's reassuring 05:47 -!- pinheadm_ [~pinheadmz@91.207.175.28] has joined #bitcoin-core-dev 05:50 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Ping timeout: 240 seconds] 05:53 -!- robotadam1 [~robotadam@s91904426.blix.com] has quit [Remote host closed the connection] 06:04 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 256 seconds] 06:04 < vasild> rc versions are not published to https://bitcoincore.org/bin/? 06:05 < wumpus> vasild: they are 06:05 < hebasto> no signed rc for now 06:05 < wumpus> see e.g. https://bitcoincore.org/bin/bitcoin-core-0.20.0/test.rc2/ 06:05 < wumpus> but this rc1 was dead on arrival 06:05 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:06 < vasild> ah, then it would be easy to upgrade the freebsd port to some rc 06:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 06:07 < vasild> because it expects to download the source code from https://bitcoincore.org/bin/... 06:09 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 265 seconds] 06:09 < vasild> that may help get more than 5 0.21.0 installations (according to https://bitnodes.io/nodes/) 06:14 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:20 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/afdfd3c8c1ce...5c0aebfcd42a 06:20 < bitcoin-git> bitcoin/master 62733fe Cory Fields: span: (almost) match std::span's constructor behavior 06:20 < bitcoin-git> bitcoin/master 1d58cc7 Cory Fields: span: add lifetimebound attribute 06:20 < bitcoin-git> bitcoin/master e3e7446 Cory Fields: Add lifetimebound to attributes for general-purpose usage 06:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:20 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19387: span: update constructors to match c++20 draft spec and add lifetimebound attribute (master...lifetimebound2) https://github.com/bitcoin/bitcoin/pull/19387 06:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:23 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.161.165] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 06:24 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev 06:26 < kanzure> hi, when adding keys to a git repo, i think it would be good practice to also paste the armored key into the pull request text or comments because some folks follow by email and that's a good redundancy 06:28 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 256 seconds] 06:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:39 < bitcoin-git> [bitcoin] ryanofsky opened pull request #20494: refactor: Move node and wallet code out of src/interfaces (master...pr/ipc-mv) https://github.com/bitcoin/bitcoin/pull/20494 06:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:43 -!- andyrtr1 [~andyrtr@178.239.168.171] has joined #bitcoin-core-dev 06:45 -!- Guest78554 [5631fc9d@ip-86-49-252-157.net.upcbroadband.cz] has quit [Ping timeout: 245 seconds] 06:48 < wumpus> kanzure: agree 06:48 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 07:05 < wumpus> do we ever add actual keys to a repository these days though? I think we only have fingerprints 07:06 < wumpus> the actual keys became both too big and too big a hassle to keep up to date 07:10 -!- miketwenty1 [~miketwent@ec2-35-174-232-195.compute-1.amazonaws.com] has joined #bitcoin-core-dev 07:11 -!- skyikot [~skyikot@gateway/tor-sasl/skyikot] has joined #bitcoin-core-dev 07:12 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 07:30 -!- Kiminuo [~mix@217.138.199.36] has quit [Ping timeout: 246 seconds] 07:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:33 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5c0aebfcd42a...19b8071eaeb3 07:33 < bitcoin-git> bitcoin/master fa18e7c Aaron Clauson: This change to the appveyor CI config for msvc builds reverses a change in... 07:33 < bitcoin-git> bitcoin/master 19b8071 MarcoFalke: Merge #20489: CI msvc: only build vcpkg dependencies for release (not debu... 07:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:33 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20489: CI msvc: only build vcpkg dependencies for release (not debug) to reduce build times (master...msvc_vcpkg_relonly) https://github.com/bitcoin/bitcoin/pull/20489 07:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:36 < elichai2> I'm looking at `IsInitialBlockDownload` and it's only does local checks on the state. do we anywhere check if another peer has a "better" chain and then start IBD from them? 07:37 -!- _Sam314-- [~sam@unaffiliated/iamthemusicman] has joined #bitcoin-core-dev 07:38 < _Sam314--> luke-jr, you are a despicable disgusting heap of rancid donkey shit. 07:42 < MarcoFalke> elichai2: FindNextBlocksToDownload? 07:44 < sipa> elichai2: IsIBD really has fairly little todo with the actual block download; it just informs a few heustistics 07:45 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 07:47 < elichai2> sipa: so the "meat" of IBD is in `FindNextBlocksToDownload`? I see it is called under some condition for a `getdata` message, but I don't think I understand that condition. I thought it will be like "if my peer and I have more than X blocks apart, do headers first and then change state to IBD and start downloading the blocks" 07:48 < _Sam314--> what does iritable bowl disease IBD has to do with bitcoin-core now? 07:49 < _Sam314--> luke-jr is diarreah from my IBD 07:50 < _Sam314--> btw there's a problem with IBD state in alpha bitcoin core 07:51 < _Sam314--> when it checks the blocks after rolling them back 07:51 < _Sam314--> you get a core dump and then have to restart 07:51 < _Sam314--> at least as of the last git pull i did last week 07:52 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has quit [Ping timeout: 240 seconds] 07:52 -!- mode/#bitcoin-core-dev [+b _Sam314--!*@*] by ChanServ 07:52 -!- _Sam314-- was kicked from #bitcoin-core-dev by ChanServ [Banned: 1w rude] 07:52 < pinheadm_> elichai2 findnextblocks... is the meat of all block downloading. At this point, the node has asked all peers for headers and it wants to check if any of those headers are valid and have more chainwork than our own current tip 07:52 < pinheadm_> if so, we download those blocks and verify them 07:52 -!- _Sam315-- [~sam@unaffiliated/iamthemusicman] has joined #bitcoin-core-dev 07:53 < pinheadm_> and then in some cases a reorg is necessary to get our chain to the most work tip 07:53 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has joined #bitcoin-core-dev 07:54 -!- proofofkeags__ [~proofofke@174-16-212-53.hlrn.qwest.net] has quit [Ping timeout: 272 seconds] 07:54 < sipa> elichai2: headers sync and blocks sync are not sequential processes that run as a separate thread or so; they both always work simultaneously, and are just defined by reactions to incoming messages 07:56 < sipa> elichai2: FindNextBlock... is primarily called from SendMessages 07:56 < _Sam315--> the fact that you turd lips harbor a lying a fuckface troll luke-jr who ruined the bitcoin ecosystem with lies is really sad to me. 07:57 < sipa> elichai2: which just runs periodically for every peer 07:58 < sipa> it decides based on the current state (which blocks we know the peer has, and which are already in flight) what to download 08:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:03 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/19b8071eaeb3...50091592dd87 08:03 < bitcoin-git> bitcoin/master 4df6567 Vasil Dimov: sync: make EnterCritical() & push_lock() type safe 08:03 < bitcoin-git> bitcoin/master 95975dd Vasil Dimov: sync: detect double lock from the same thread 08:03 < bitcoin-git> bitcoin/master 5009159 Wladimir J. van der Laan: Merge #19337: sync: detect double lock from the same thread 08:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:03 < bitcoin-git> [bitcoin] laanwj merged pull request #19337: sync: detect double lock from the same thread (master...detect_double_lock) https://github.com/bitcoin/bitcoin/pull/19337 08:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:03 < hebasto> wumpus: thanks ^ 08:03 < vasild> cool :) 08:08 < _Sam315--> Thank you for letting me vent, sorry for the interruption. Good day. 08:10 -!- _Sam315-- [~sam@unaffiliated/iamthemusicman] has left #bitcoin-core-dev ["Leaving"] 08:14 -!- kexkey [~kexkey@static-198-54-132-150.cust.tzulo.com] has joined #bitcoin-core-dev 08:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:26 < bitcoin-git> [bitcoin] Z5483 closed pull request #19823: ci: check if scripted diff is using BSD sed syntax (master...master) https://github.com/bitcoin/bitcoin/pull/19823 08:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:29 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 08:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:34 < bitcoin-git> [bitcoin] dongcarl opened pull request #20495: sync: Use decltype(auto) return type for WITH_LOCK (master...2020-11-decltype-auto) https://github.com/bitcoin/bitcoin/pull/20495 08:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:41 -!- jesseposner [~textual@2601:643:8980:bfd2:f8c7:7086:b02c:8117] has joined #bitcoin-core-dev 08:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:42 < bitcoin-git> [bitcoin] hebasto opened pull request #20496: Drop unneeded macOS framework dependencies (master...201125-as) https://github.com/bitcoin/bitcoin/pull/20496 08:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:42 -!- jesseposner [~textual@2601:643:8980:bfd2:f8c7:7086:b02c:8117] has quit [Client Quit] 08:43 -!- jesseposner [~jesseposn@2601:643:8980:bfd2:f8c7:7086:b02c:8117] has joined #bitcoin-core-dev 08:53 -!- lightlike [~lightlike@p200300c7ef192500384a4babe11cbcaf.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 08:54 -!- pinheadm_ [~pinheadmz@91.207.175.28] has quit [Quit: pinheadm_] 08:55 -!- pinheadmz [~pinheadmz@91.207.175.28] has joined #bitcoin-core-dev 08:59 -!- glozow [uid453516@gateway/web/irccloud.com/x-wgwavzwbrixyodio] has joined #bitcoin-core-dev 09:00 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 09:01 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 09:02 < kanzure> wumpus: well, if keys are too big it's possible to use the unsigned ones (for whatever that's worth!) 09:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:04 < bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to 0.21: https://github.com/bitcoin/bitcoin/compare/d47d16025e21...9facca3ce0ad 09:04 < bitcoin-git> bitcoin/0.21 c46c18b Jon Atack: wallet: refactor GetClosestWalletFeature() 09:04 < bitcoin-git> bitcoin/0.21 2498b04 Andrew Chow: Don't upgrade to HD split if it is already supported 09:04 < bitcoin-git> bitcoin/0.21 99d56e3 Jon Atack: wallet: fix and improve upgradewallet result responses 09:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:04 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20490: [backport] wallet: upgradewallet fixes, improvements, test coverage (0.21...2011-backportWalletUpgrade) https://github.com/bitcoin/bitcoin/pull/20490 09:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:05 -!- larryruane_ [uid473749@gateway/web/irccloud.com/x-vuztyjlkacjmkbdi] has joined #bitcoin-core-dev 09:14 -!- proofofkeags [~proofofke@c-73-34-43-4.hsd1.co.comcast.net] has joined #bitcoin-core-dev 09:22 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 09:23 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 09:29 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 09:33 -!- kristapsk_ is now known as kristapsk 09:46 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 09:48 -!- Pavlenex [~Thunderbi@178.220.103.52] has joined #bitcoin-core-dev 09:52 -!- pinheadm_ [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 09:55 -!- pinheadmz [~pinheadmz@91.207.175.28] has quit [Ping timeout: 256 seconds] 09:58 -!- jorgieporgie [~jorgiepor@bb115-66-182-100.singnet.com.sg] has joined #bitcoin-core-dev 09:59 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 10:05 -!- joelklabo [~textual@157-131-101-185.fiber.dynamic.sonic.net] has joined #bitcoin-core-dev 10:12 -!- ricks_ [~ricks_@unaffiliated/ricks-/x-3439430] has joined #bitcoin-core-dev 10:12 -!- ricks_ [~ricks_@unaffiliated/ricks-/x-3439430] has quit [Client Quit] 10:13 -!- jorgieporgie [~jorgiepor@bb115-66-182-100.singnet.com.sg] has quit [] 10:31 < achow101> gitian builders: 0.21.0rc2 detached sigs are pushed 10:38 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 10:39 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 10:42 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 10:43 * hebasto signing 10:44 * jonatack yoopi 10:58 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 11:20 -!- miketwenty1 [~miketwent@ec2-35-174-232-195.compute-1.amazonaws.com] has quit [Ping timeout: 240 seconds] 11:25 < emzy> I also did it for the first time. Now that I understand it. 11:33 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev 11:38 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 246 seconds] 11:40 -!- pinheadm_ [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadm_] 11:40 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 11:40 -!- joelklabo [~textual@157-131-101-185.fiber.dynamic.sonic.net] has quit [Quit: My iMac has gone to sleep. ZZZzzz…] 11:41 -!- blanching [~blanching@195.181.160.175.adsl.inet-telecom.org] has joined #bitcoin-core-dev 11:53 -!- Pavlenex [~Thunderbi@178.220.103.52] has quit [Quit: Pavlenex] 11:55 -!- Pavlenex [~Thunderbi@178.220.103.52] has joined #bitcoin-core-dev 11:58 -!- Pavlenex [~Thunderbi@178.220.103.52] has quit [Client Quit] 12:01 -!- Kiminuo [~mix@217.138.199.36] has joined #bitcoin-core-dev 12:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:07 < bitcoin-git> [bitcoin] sanket1729 opened pull request #20497: [Refactor] Add MAX_STANDARD_SCRIPTSIG_SIZE to policy (master...policy) https://github.com/bitcoin/bitcoin/pull/20497 12:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:23 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:30 -!- shesek [~shesek@164.90.217.137] has joined #bitcoin-core-dev 12:30 -!- shesek [~shesek@164.90.217.137] has quit [Changing host] 12:30 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 13:05 -!- lightlike [~lightlike@p200300c7ef192500384a4babe11cbcaf.dip0.t-ipconnect.de] has quit [Quit: Leaving] 13:14 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has quit [Read error: Connection reset by peer] 13:14 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has joined #bitcoin-core-dev 13:34 -!- blanching [~blanching@195.181.160.175.adsl.inet-telecom.org] has quit [Quit: blanching] 13:36 < sipa> when building master, in a clean work dir, empty ccache, configured with "./configure --with-incompatible-bdb", I get: 13:36 < sipa> /usr/bin/ld: cannot find -lQt5Core 13:37 < sipa> while configure finds qt5 fine, and "pkg-config Qt5Core --libs" outputs the expected -lQt5Core 13:37 < sipa> any ideas? 13:38 < sipa> ubuntu 20.10 13:40 -!- skyikot [~skyikot@gateway/tor-sasl/skyikot] has quit [Ping timeout: 240 seconds] 13:41 < sipa> (i get the same with various other Qt libs) 13:47 < sipa> same when building with clang 13:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:56 < bitcoin-git> [bitcoin] practicalswift opened pull request #20499: Remove obsolete NODISCARD ifdef forest. Use [[nodiscard]] (C++17). (master...remove-nodiscard-cruft) https://github.com/bitcoin/bitcoin/pull/20499 13:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:27 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:33 -!- openoms [~quassel@91.132.136.76] has joined #bitcoin-core-dev 14:37 -!- Kiminuo [~mix@217.138.199.36] has quit [Ping timeout: 256 seconds] 14:44 -!- joelklabo [~textual@157-131-101-185.fiber.dynamic.sonic.net] has joined #bitcoin-core-dev 14:54 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 240 seconds] 14:55 < sipa> vasild: uh, bizarre thing in addrv2 disk serialization... the decision whether to use compactsize nservices is based on the nVersion number stored in CAddress, but the decision whether to use addrv2 ip/network serialization is based on the context only 14:55 -!- twistedline [~twisted@unaffiliated/twistedline] has quit [Remote host closed the connection] 14:56 -!- twistedline [~twisted@unaffiliated/twistedline] has joined #bitcoin-core-dev 14:57 < sipa> so you can construct a peers.dat file where some addresses use compactsize nServices, and others don't, independent from whether the file format is V3_BIP155 or not) 15:02 * sipa suggests dropping support for that... 15:14 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 256 seconds] 15:14 -!- romanz [~romanz@bzq-84-109-216-152.red.bezeqint.net] has quit [Quit: WeeChat 2.8] 15:21 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev 15:35 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 15:46 < fanquake> sipa: did you resolve your linking issue? 15:47 < sipa> fanquake: no 15:48 < sipa> i just went back to building with --without-gui 15:49 < fanquake> hmm ok. Unfortunately I have no answers for you. Other than maybe a missing package. 15:52 < sipa> /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 exists 15:53 < sipa> i don't see a libQt5Core.a file though, which i'd expect to exist 15:56 < sipa> hmm, i don't see any .a files in /usr/lib though, so i suspect those aren't needed anymore when dynamically linking? 16:00 -!- skyikot [~skyikot@gateway/tor-sasl/skyikot] has joined #bitcoin-core-dev 16:08 -!- openoms [~quassel@91.132.136.76] has quit [Ping timeout: 256 seconds] 16:12 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 260 seconds] 16:18 -!- openoms [~quassel@91.132.136.76] has joined #bitcoin-core-dev 16:32 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Read error: Connection reset by peer] 16:35 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:7ef3:bc9a:f509:3193:e14d] has joined #bitcoin-core-dev 16:46 -!- joelklabo [~textual@157-131-101-185.fiber.dynamic.sonic.net] has quit [Quit: My iMac has gone to sleep. ZZZzzz…] 16:46 -!- proofofkeags [~proofofke@c-73-34-43-4.hsd1.co.comcast.net] has quit [Ping timeout: 240 seconds] 16:53 < luke-jr> is it intentional that the test framework's addmultisigaddress substitute for descriptor wallets doesn't accept addresses? 16:53 < achow101> luke-jr: yes 16:53 < luke-jr> k, makes sense 16:54 -!- nkuttler [~nkuttler@unaffiliated/nkuttler] has quit [Remote host closed the connection] 16:55 -!- nkuttler [~nkuttler@unaffiliated/nkuttler] has joined #bitcoin-core-dev 16:58 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:7ef3:bc9a:f509:3193:e14d] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 17:09 < luke-jr> achow101: I can't get it to work at all :/ 17:09 < luke-jr> test_framework.authproxy.JSONRPCException: Cannot import descriptor without private keys to a wallet with private keys enabled (-4) 17:12 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 17:18 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 240 seconds] 17:20 -!- larryruane_ [uid473749@gateway/web/irccloud.com/x-vuztyjlkacjmkbdi] has quit [Quit: Connection closed for inactivity] 17:22 < achow101> luke-jr: the error message is self explanatory. you need a wallet with private keys disabled 17:24 < luke-jr> achow101: but it's not supposed to be watch-only 17:25 < achow101> then it has to have at least one private key 17:25 < luke-jr> it does, addmultisigaddress still requires the pubkey passed though… 17:25 < achow101> how to setup multisigs in descriptor wallets is still an unsolved problem 17:25 < luke-jr> :/ 17:26 < achow101> what exactly are you trying to do? 17:28 < luke-jr> achow101: https://dpaste.com/5K7JHWDS4 17:30 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 17:30 < achow101> but why tho 17:30 < luke-jr> so it gets tested 17:31 < achow101> import a sortedmulti descriptor instead of adding more stuff to addmultsigaddress? 17:31 < luke-jr> this is from 2016 17:31 < luke-jr> and works with normal wallets 17:32 < achow101> since addmultisigaddress doesn't exist for descriptorwallets, I don't think it makes sense to try to test it for them 17:32 < luke-jr> fair enough 17:32 < achow101> the helper only exists for when we use addmultisigaddress to make a multisig to test other stuff 17:33 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Quit: WeeChat 2.9] 17:34 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 17:35 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 17:38 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 17:39 < CubicEarth> on the P2P side fo things, is there a reason for the client to not look for and prioritize downloading block data from sources on the LAN? 17:40 < sipa> CubicEarth: if you -addnode them, it'll likely fetch most blocks from there 17:40 < sipa> there is no functionality for automatically detecting other bitcoin node in the local network 17:45 < CubicEarth> I use addnode or connect :) It seemed like such functionality could be of benefit helping to make dissemination of the block data more user friendly. Totally understood that it would be a low priority in any case. 17:45 < CubicEarth> But is there a reason why such functionality would be bad? 17:47 < sipa> define more user friendly? 17:48 < sipa> i can see the use of detecting other nodes on a local network, but nobody has implemented that 17:48 < sipa> bneyond that, i don't know what you're asking for 17:48 < sipa> is it behaving badly currently? 17:50 < CubicEarth> One assumption I am making: the IBD can be costly in terms of ISP data caps 17:51 < sipa> ah 17:51 < sipa> i'd suggest to have one gateway node in your network, and have the other nodes not make outgoing connections, if you're concerned about that 17:54 < CubicEarth> Yeah, it is easy enough for me avoid pulling the data twice through my WAN 17:54 < CubicEarth> I was just thinking of making it happen with less user intervention 17:55 < sipa> doing it without user configuration is hard through 17:56 < sipa> you could have a rule say that causes a delay before fetching from external IPs to give a chance for a local node to announce it first to you 17:56 < sipa> but now you need to make sure there is one node in your network that doesn't have this delay, or you're just going to lag behind on all nodes 17:59 < CubicEarth> Isn't is trivial to know if a device is on the same ... subnet? 18:00 < CubicEarth> not sure if subnet is the right term... argh 18:00 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 240 seconds] 18:02 < sipa> CubicEarth: that's not the problem! 18:02 < sipa> the problem is making sure that not everyone on the same network is slowing down blocks from the outside 18:02 < sipa> they're still supposed to come in quickly to one node from outside 18:02 < sipa> so you need some kind of "leader election"... 18:03 < CubicEarth> Are you talking about just keeping up with new blocks as they are issued? I am thinking about when one node is far behind in block height 18:03 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 18:04 < sipa> ah, yes 18:04 < sipa> for IBD it should Just Work(tm) 18:04 < sipa> as it autoselects for faster peers 18:05 < sipa> though probably not aggressively enough to get ~all blocks from just local nodes 18:06 < CubicEarth> Interesting. I haven't noticed this to be the case, but I can test it going forward and see how it behaves 18:06 < CubicEarth> And I know i 18:07 < CubicEarth> I've asked this before, but I forget the answer... how far ahead of the validation will it download blocks? 18:07 < sipa> 1024 blocks 18:08 < CubicEarth> the "sliding window"? thanks 18:08 < sipa> yes 18:12 < CubicEarth> "The main purpose of this is so that blocks that are near one another on the blockchain are most likely contained in the same .dat file (where the raw block data is stored on disk)." 18:12 < CubicEarth> Still the case? 18:12 < sipa> yes 18:12 < sipa> otherwise you can't effectively prune 18:13 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadmz] 18:14 < CubicEarth> I've never looked at, or asked about how the .dat files were structured, but I had assumed the blocks were more or less kept in order. But actually each .dat file is just filled with whatever the next blocks to come in are? 18:15 < sipa> yep, they're just appended in the order they arrive 18:16 < sipa> you wouldn't know where to put things if you want to keep them in order 18:16 < sipa> as you don't know the size of the blocks you still miss 18:16 < CubicEarth> couldn't you use the headers? 18:16 < sipa> headers don't contain the block's sizes 18:17 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 18:24 < CubicEarth> Got it. And the reason to tie the sliding window to the validation is make sure that the sliding window never gets more than 1024 blocks ahead of blocks known to be good? 18:24 < CubicEarth> Because otherwise it would seem the sliding window could just be in relation to highest unbroken block in sequence, and could therefore advance far faster than validation. 18:24 < CubicEarth> *highest block in unbroken sequence 18:26 < CubicEarth> (meaning an attack could feed bad blocks, and then the blk.dat files would be more out of order) 18:29 < CubicEarth> sipa: You are always the person to answer my questions about the P2P stuff... and gmaxwell sometimes. Are you like the only person who knows all of the 'why' the p2p stuff is the way it is, or are you just the person willing to entertain my questions? 18:34 -!- proofofkeags [~proofofke@174-16-212-53.hlrn.qwest.net] has joined #bitcoin-core-dev 18:34 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 18:36 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 18:36 < sipa> CubicEarth: i mean... a block arrives, you don't have its parent(s) yet... where do you store it? 18:36 -!- proofofkeags [~proofofke@174-16-212-53.hlrn.qwest.net] has quit [Remote host closed the connection] 18:36 < sipa> CubicEarth: i've been around for a while :) 18:37 < sipa> and in this... i wrote a significant part of the block fetching logic 18:38 < sipa> +case 18:38 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:7ef3:25b7:f5b5:a852:f5c4] has joined #bitcoin-core-dev 18:38 < CubicEarth> so this about avoid disk thrashing? 18:39 < CubicEarth> is ... avoiding 18:39 < sipa> compared to which alternative? you haven't given any 18:40 < sipa> a possibility is just storing every block in a separate file 18:41 < sipa> that's great as it means you can delete whatever block at any time 18:41 < sipa> unfortunately most filesystems perform terribly with huge numbers of files 18:41 < sipa> another possibility is constantly rewriting block files 18:41 < sipa> to keep the blocks in order 18:50 < CubicEarth> I guess the question becomes how bad is it if that some blocks are way out of order. On the surface, it seems desirable for the block download to be independent of the cpu intensive validation. 18:52 < sipa> it is 18:52 < CubicEarth> Coupled with the LAN prioritization I was musing about, imagine that for some short period of time, you have a high bandwidth connection. It would be advantageous to be able to download all of the blocks right then 18:52 < sipa> it doesn't matter where blocks are stored for validation 18:52 < CubicEarth> and then let the cpu chew through it later 18:53 < CubicEarth> well that is good 18:53 < sipa> yeah, that sounds vaguely useful 18:56 -!- az0re [~az0re@gateway/tor-sasl/az0re] has quit [Remote host closed the connection] 18:58 -!- az0re [~az0re@gateway/tor-sasl/az0re] has joined #bitcoin-core-dev 18:58 < CubicEarth> You are saying those processes are independent, but at the moment, they are tied together with the 1024 block window? 18:59 < sipa> ah yes 18:59 < sipa> but it doesn't matter where things are stored for validation 18:59 < sipa> it's just restricted to make sure pruning is possible 19:04 < CubicEarth> interesting. Yeah, with pruning, especially if pruning is on because there just ins't *that much* disk space available, it all makes perfect sense. There is basically no advantage to what I am thinking. 19:04 < sipa> that's the only reason 19:05 < sipa> otherwise you could end up with 1000 block files, and each contains blocks from all over the chain 19:05 < sipa> so you can't delete any of them 19:05 < sipa> because they all also contain very recent blocks 19:08 < CubicEarth> I hear that, but I aren't we mixing two concepts here? because couldn't you still have the sliding window, but just have it be decoupled from validation? 19:09 < CubicEarth> or does the expose an attack vector? 19:09 < CubicEarth> that 19:09 < sipa> it's not tied to validation, except implicitly 19:09 < sipa> it's tied to the moving window 19:10 < sipa> which moves along the chain as far as it can while it has all blocks 19:10 < sipa> that happens to be identical to what validation needs 19:12 < CubicEarth> too bad validation can't get ahead of the block download ;) 19:12 < sipa> you see what i'm saying? 19:12 < sipa> we validate blocks as soon as we have all its parents (and those parents are validated) 19:13 < CubicEarth> I get that, and that fits my long held understanding 19:13 < sipa> and that's also when the download window moves (because limiting out-of-orderness has the exact same requirement) 19:15 < CubicEarth> that's why I was asking about the attack consideration, because otherwise you wouldn't need to validate the blocks to limit out-of-orderness, right? You would just need to make sure you didn't download to crazily 19:16 < sipa> oh i see 19:16 < sipa> you're talking about making validating independent of block download entirely 19:16 < sipa> that's a whole other can of worms 19:17 < CubicEarth> yeah 19:17 < sipa> right now we always make sure that the best chain we know about is the actively validated one 19:17 < sipa> if you drop that, the window could move ahead of validation 19:21 < CubicEarth> It seems like a feature that could add convenience, along with some inherent vulnerabilities. But it seems the consequences of those vulnerabilities being exploited would more or less be reduced to the loss of the convenience, along with perhaps some additional nuisance 19:22 -!- joelklabo [~textual@157-131-101-185.fiber.dynamic.sonic.net] has joined #bitcoin-core-dev 19:26 < CubicEarth> Meaning, if there was an option to allow the node to let the window move ahead, independent of the state of validation, the benefit would be the possibility that validation could continue on in absence of good network connectivity 19:27 < CubicEarth> And the risk would be that the wasn't the right chain in the end 19:28 < CubicEarth> And so downloading would need to happen again 19:29 < sipa> seems reasonable 19:54 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 19:55 -!- Klox04809318631 [~Klox@c-24-1-131-19.hsd1.il.comcast.net] has quit [Ping timeout: 240 seconds] 19:58 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 260 seconds] 20:12 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 20:13 -!- Klox04809318631 [~Klox@c-24-1-131-19.hsd1.il.comcast.net] has joined #bitcoin-core-dev 20:15 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 20:26 -!- Klox04809318631 [~Klox@c-24-1-131-19.hsd1.il.comcast.net] has quit [Quit: The Lounge - https://thelounge.github.io] 20:27 -!- Klox04809318631 [~Klox@c-24-1-131-19.hsd1.il.comcast.net] has joined #bitcoin-core-dev 20:36 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadmz] 21:00 -!- skyikot [~skyikot@gateway/tor-sasl/skyikot] has quit [Remote host closed the connection] 21:02 -!- skyikot [~skyikot@gateway/tor-sasl/skyikot] has joined #bitcoin-core-dev 21:02 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:7ef3:25b7:f5b5:a852:f5c4] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 21:14 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:7ef3:25b7:f5b5:a852:f5c4] has joined #bitcoin-core-dev 21:23 -!- joelklabo [~textual@157-131-101-185.fiber.dynamic.sonic.net] has quit [Quit: My iMac has gone to sleep. ZZZzzz…] 22:44 -!- Pavlenex [~Thunderbi@178.220.103.52] has joined #bitcoin-core-dev 23:10 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 23:10 -!- romanz [~romanz@bzq-84-109-216-152.cablep.bezeqint.net] has joined #bitcoin-core-dev 23:12 -!- jesseposner [~jesseposn@2601:643:8980:bfd2:f8c7:7086:b02c:8117] has quit [Quit: My Mac Mini has gone to sleep. ZZZzzz…] 23:19 -!- Kiminuo [~mix@217.138.199.36] has joined #bitcoin-core-dev 23:24 -!- romanz_ [~romanz@93.123.196.104.bc.googleusercontent.com] has joined #bitcoin-core-dev 23:24 -!- romanz [~romanz@bzq-84-109-216-152.cablep.bezeqint.net] has quit [Quit: WeeChat 2.8] 23:24 -!- romanz_ [~romanz@93.123.196.104.bc.googleusercontent.com] has quit [Client Quit] 23:24 -!- romanz [~romanz@93.123.196.104.bc.googleusercontent.com] has joined #bitcoin-core-dev 23:25 -!- kabaum [~kabaum@h-13-35.A163.priv.bahnhof.se] has joined #bitcoin-core-dev 23:35 -!- miketwenty1 [~miketwent@ip24-136-61-186.ga.at.cox.net] has joined #bitcoin-core-dev 23:39 -!- miketwenty1 [~miketwent@ip24-136-61-186.ga.at.cox.net] has quit [Ping timeout: 264 seconds] 23:53 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Remote host closed the connection] --- Log closed Thu Nov 26 00:00:27 2020