--- Log opened Thu Nov 26 00:00:27 2020
00:20 < wumpus> sipa: to link dynamically against qt you need libQt5Core.so, only libQt5Core.so.5 won't do, it should be created as a symlink though... sounds more like a weird linker path issue
00:22 < wumpus> it's in qtbase5-dev
00:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:22 < bitcoin-git> [bitcoin] fanquake opened pull request #20504: build: use more legible (q)make commands in qt package (master...legible_qt_config_cmds) https://github.com/bitcoin/bitcoin/pull/20504
00:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:24 < wumpus> ubuntu does not install statically linkable qt libraries, only dynamic linker ones, but that's fine if you're only building locally and not for distribution
00:36 -!- andyrtr1 [~andyrtr@178.239.168.171] has quit [Remote host closed the connection]
00:44 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev
00:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:45 < bitcoin-git> [bitcoin] dergoegge opened pull request #20505: [backport] build: Avoid secp256k1.h include from system (0.21...21_backport) https://github.com/bitcoin/bitcoin/pull/20505
00:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:53 < sipa> wumpus: bizarre, i installed and reinstalled all the packages
00:54 < sipa> i'll retry and symlink it myself
00:54 < sipa> thanks
00:54 < wumpus> so you have /usr/lib/x86_64-linux-gnu/libQt5Core.so but it can't find it during linking?
00:54 < sipa> only .so.5
00:55 < hebasto> sipa: waiting for my groovy installation complete to check your link issue
00:55 < wumpus> does "dpkg -S dpkg -L qtbase5-dev|grep libQt5Core.so" show it should be in there?
00:55 < wumpus> eh just "dpkg -L qtbase5-dev|grep libQt5Core.so"
00:56 < wumpus> you really shouldn't have to make the symlink yourself
00:58 < wumpus> maybe the file is somewhere else on ubuntu 20.10 I haven't used that yet
00:58 -!- jbarcelo [43daf305@67.218.243.5] has joined #bitcoin-core-dev
00:59 < sipa> wumpus: ok false alarm, i reinstalled it and now the .so file is there
00:59 < sipa> i must have reinstalled another package before
01:00 -!- snowkeld[m] [snowkeldma@gateway/shell/matrix.org/x-nbitttfhstlbskqd] has quit [Quit: Idle for 30+ days]
01:00 < wumpus> phew, still wonder how it came to be erased but good to know!
01:01 < sipa> yeah, no idea how this happened
01:01 < sipa> i haven't done many weird things in this install
01:01 < wumpus> could be a bug I mean that version of ubuntu is still very new
01:02 < sipa> wumpus: i remember yeard ago that a -l argument always needed a .a, was a wrong, or is that since outdated?
01:04 < wumpus> that's true on windows, it has these import libraries (.lib IIRC) to tell what is in a dll, but not (and never was) on linux, the linker links directly to the .so, linking to an .a is static linking
01:06 < wumpus> (there's also .la files with library metadata that are used by libtool, but these are not required for anything, and doesn't look like qt uses that system)
01:08 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net]
01:08 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
01:13 -!- jbarcelo [43daf305@67.218.243.5] has quit [Remote host closed the connection]
01:15 < sipa> wumpus: hmm, maybe i conflated windows stuff earlier then
01:16 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev
01:22 < wumpus> i think windows' .lib system is pretty nice, it allows for linking against a library without having the compiled library (the .lib is just a list of symbols), right now in the depends system we need to build some libraries (such as freetype) just to link against the system copy of it... that could be avoided in that case
01:26 < wumpus> though there is work on this under the name of 'interface stubs', but only in clang afaik, https://phoronix.com/scan.php?page=news_item&px=Clang-Interface-Stubs
01:27 < fanquake> also tbd stubs heh
01:27 < wumpus> fanquake: those are the macos specific kind isn't it?
01:27 < fanquake> yea
01:30 -!- skyikot [~skyikot@gateway/tor-sasl/skyikot] has quit [Ping timeout: 240 seconds]
01:30 < fanquake> https://github.com/fanquake/core-review/blob/master/tbd-stubs.md
01:30 < wumpus> would be so nice to just have (deterministically generated) stubs and headers for OS dependencies, this could even replace the symbol check because too new symbols would just not be in the stubs
01:32 < wumpus> fanquake: now for ELF :)
01:32 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
01:34 < vasild_> sipa: https://bpa.st/VU2Q makes sense?
01:34 -!- vasild_ is now known as vasild
01:34 < wumpus> fanquake: but yes that's certainly the idea, it's nice that they have a text based format too
01:36 < wumpus> "-interface-stub-version=experimental-yaml-elf-v1" hmm  let's see if my clang is new enough
01:38 < wumpus> "error: invalid value 'Invalid interface stub format: experimental-yaml-elf-v1 is deprecated.' " loool oh already deprecated
01:38 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection]
01:38 < vasild> serialization is ok, but deserialize could produce strange results indeed - the value stored in nVersion here `int nVersion = s.GetVersion();` will be overwritten 2 lines below by `READWRITE(nVersion);` by what comes in from disk. That overwritten nVersion will be used to make decision about compactsize services, but will not be used by READWRITEAS(CService, obj);, which will use s.GetVersion()
01:45 -!- willcl_ark [~quassel@cpc123780-trow7-2-0-cust177.18-1.cable.virginm.net] has quit [Quit: Quit]
01:56 < wumpus> experimental-ifs-v2 works but doesn't look like there is a text format anymore
01:57 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev
02:04 -!- willcl_ark [~quassel@cpc123780-trow7-2-0-cust177.18-1.cable.virginm.net] has joined #bitcoin-core-dev
02:05 -!- kexkey [~kexkey@static-198-54-132-150.cust.tzulo.com] has quit [Ping timeout: 272 seconds]
02:06 -!- willcl_ark [~quassel@cpc123780-trow7-2-0-cust177.18-1.cable.virginm.net] has quit [Client Quit]
02:07 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has joined #bitcoin-core-dev
02:12 < wumpus> otoh we're only linking against a few system C libraries not C++ libraries this makes things way simpler
02:14 < wumpus> e.g. ELF library -> text file with symbols and metadata -> ELF library with only symbols and metadata for linking
02:31 < wumpus> the only thing is that you'd end up with a file per architecture, as there might be symbol differences, but as we have only a limited number of architectures that's not too bad
02:34 -!- willcl_ark [~quassel@cpc123780-trow7-2-0-cust177.18-1.cable.virginm.net] has joined #bitcoin-core-dev
02:45 < hebasto> sipa: on fresh minimal ubuntu 20.10 `configure --with-incompatible-bdb && make` works flawlessly
02:56 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has quit [Remote host closed the connection]
02:57 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has joined #bitcoin-core-dev
03:02 < wumpus> https://llvm.org/devmtg/2019-10/slides/Lotfi-ClangInterfaceStubs.pdf
03:14 -!- reallll is now known as belcher
03:18 -!- Keira72Terry [~Keira72Te@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev
03:20 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Ping timeout: 240 seconds]
03:21 < wumpus> oh would have been more on-topic in #bitcoin-builds i guess sorry
03:22 -!- Keira72Terry [~Keira72Te@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 240 seconds]
03:29 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev
03:29 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
03:34 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Ping timeout: 256 seconds]
03:34 -!- hizkifw [hizkifwmat@gateway/shell/matrix.org/x-bkabzcpoowfubriy] has quit [Quit: Bridge terminating on SIGTERM]
03:34 -!- robert_spigler [robertspig@gateway/shell/matrix.org/x-iviqgumaaxfuxogk] has quit [Quit: Bridge terminating on SIGTERM]
03:34 -!- awesome_doge [awesome-do@gateway/shell/matrix.org/x-uzbkbocahofvpvuf] has quit [Quit: Bridge terminating on SIGTERM]
03:34 -!- rCapital-Surpris [crtn32002m@gateway/shell/matrix.org/x-qevdkhinzrrefbnr] has quit [Quit: Bridge terminating on SIGTERM]
03:34 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-usneaxcbtqzjekhe] has quit [Quit: Bridge terminating on SIGTERM]
03:35 -!- sirpesto [sirpestoma@gateway/shell/matrix.org/x-pkphqgkkgyfomhwu] has quit [Quit: Bridge terminating on SIGTERM]
03:37 -!- nckx [~nckx@tobias.gr] has quit [Ping timeout: 264 seconds]
03:38 -!- nckx [~nckx@tobias.gr] has joined #bitcoin-core-dev
03:40 -!- Pavlenex [~Thunderbi@178.220.103.52] has quit [Quit: Pavlenex]
03:42 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev
03:45 -!- sirpesto [sirpestoma@gateway/shell/matrix.org/x-pswhzwdostxtpaos] has joined #bitcoin-core-dev
03:46 < jonatack> MarcoFalke: thanks for fixing that stray line I added in the release note wiki. Just updated it to add the new fee_rate sat/vB changes and adjust the PR 11413 fee rate info. 
03:47 < jonatack> The wallet RPC changes are a bit spread out ATM and should probably be regrouped in one place under the Wallet section, Updated RPCs
03:49 -!- k3tan172 [~pi@gateway/tor-sasl/k3tan] has joined #bitcoin-core-dev
03:49 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has quit [Ping timeout: 240 seconds]
03:50 < jonatack> I didn't do that, other than moving the PR 11413 entries down to just after the new RPC send entry so it makes more sense.
03:50 < jonatack> As the 11413 entry now mentions RPC send.
03:53 -!- Pavlenex [~Thunderbi@178.220.103.52] has joined #bitcoin-core-dev
03:58 -!- promag [~promag@188.250.84.129] has quit [Remote host closed the connection]
04:00 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net]
04:01 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
04:04 < hebasto> wumpus: may I remind to post rc2 binaries to https://bitcoincore.org/bin/ ?
04:05 < wumpus> hebasto: already working on that
04:05 < hebasto> thanks!
04:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:09 < bitcoin-git> [bitcoin] hebasto closed pull request #19832: p2p: Put disconnecting logs into BCLog::NET category (master...200829-log) https://github.com/bitcoin/bitcoin/pull/19832
04:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:11 -!- Pavlenex [~Thunderbi@178.220.103.52] has quit [Quit: Pavlenex]
04:12 -!- awesome_doge [awesome-do@gateway/shell/matrix.org/x-qsnxxgllrqyjdxvn] has joined #bitcoin-core-dev
04:12 -!- rCapital-Surpris [crtn32002m@gateway/shell/matrix.org/x-zsrqemrmfzdyubjl] has joined #bitcoin-core-dev
04:12 -!- hizkifw [hizkifwmat@gateway/shell/matrix.org/x-gpsrokdzadhwpocp] has joined #bitcoin-core-dev
04:12 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-krvymnjpngwletgk] has joined #bitcoin-core-dev
04:12 -!- robert_spigler [robertspig@gateway/shell/matrix.org/x-vacanapkkzgpicki] has joined #bitcoin-core-dev
04:12 -!- k3tan172 is now known as k3tan
04:14 -!- Pavlenex [~Thunderbi@178.220.103.52] has joined #bitcoin-core-dev
04:18 -!- dleffler1 [~dleffler@178.239.168.171] has joined #bitcoin-core-dev
04:23 -!- jonatack [~jon@134.19.179.163] has quit [Quit: jonatack]
04:25 -!- Pavlenex [~Thunderbi@178.220.103.52] has quit [Quit: Pavlenex]
04:31 -!- jbarcelo [43daf305@67.218.243.5] has joined #bitcoin-core-dev
04:34 < wumpus> 0.21.0rc2 binaries up: https://bitcoincore.org/bin/bitcoin-core-0.21.0/test.rc2/
04:40 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev
04:42 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:7ef3:25b7:f5b5:a852:f5c4] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
04:42 < fanquake> 🚀
04:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:45 < bitcoin-git> [bitcoin] sipsorcery opened pull request #20506: WIP: AppVeyor CI fixes in preparation for next image bump (master...msvc-no-optimise) https://github.com/bitcoin/bitcoin/pull/20506
04:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:49 -!- MTennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev
04:53 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Ping timeout: 272 seconds]
05:07 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:7ef3:25b7:f5b5:a852:f5c4] has joined #bitcoin-core-dev
05:13 -!- Pavlenex [~Thunderbi@178.220.103.52] has joined #bitcoin-core-dev
05:25 -!- Pavlenex [~Thunderbi@178.220.103.52] has quit [Quit: Pavlenex]
05:35 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
05:36 -!- jonatack [~jon@88.124.242.136] has joined #bitcoin-core-dev
05:38 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
05:40 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 246 seconds]
05:41 -!- jonatack [~jon@82.102.27.171] has joined #bitcoin-core-dev
05:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:46 < bitcoin-git> [bitcoin] vasild opened pull request #20507: sync: print proper lock order location when double lock is detected (master...double_lock_print_location) https://github.com/bitcoin/bitcoin/pull/20507
05:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:49 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:7ef3:25b7:f5b5:a852:f5c4] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
05:53 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:7ef3:25b7:f5b5:a852:f5c4] has joined #bitcoin-core-dev
05:55 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has quit [Read error: Connection reset by peer]
05:56 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has joined #bitcoin-core-dev
05:59 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
06:10 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has quit [Ping timeout: 240 seconds]
06:11 -!- rebelution [~sam@20.68.25.16] has joined #bitcoin-core-dev
06:11 < rebelution> luke-jr ------->> [[ You are as grotesque as a disgraceful savage shitload of ineffectual repugnant maggot slime ]] <<-------
06:33 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
06:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:33 < bitcoin-git> [bitcoin] sipsorcery opened pull request #20508: IGNORE: Testing appveyor CI build with pre-built dependencies (master...msvc-vcpkg-prebuilt) https://github.com/bitcoin/bitcoin/pull/20508
06:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:40 -!- satwo [~textual@2600:1700:2d30:5310:a1c8:226c:c134:e878] has joined #bitcoin-core-dev
06:42 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
06:48 -!- kexkey [~kexkey@static-198-54-132-150.cust.tzulo.com] has joined #bitcoin-core-dev
06:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:54 < bitcoin-git> [bitcoin] vasild opened pull request #20509: net: CAddress deser: use stream's version, not what's coming from disk (master...caddress_deser_version) https://github.com/bitcoin/bitcoin/pull/20509
06:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:54 < vasild> sipa: ^
06:56 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 246 seconds]
06:57 -!- Klox04809318631 [~Klox@c-24-1-131-19.hsd1.il.comcast.net] has quit [Ping timeout: 240 seconds]
07:10 -!- Klox04809318631 [~Klox@c-24-1-131-19.hsd1.il.comcast.net] has joined #bitcoin-core-dev
07:15 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:7ef3:25b7:f5b5:a852:f5c4] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
07:21 -!- mode/#bitcoin-core-dev [+o wumpus] by ChanServ
07:21 -!- mode/#bitcoin-core-dev [+b *!*@20.68.25.16] by wumpus
07:21 -!- rebelution was kicked from #bitcoin-core-dev by wumpus [rebelution]
07:21 -!- mode/#bitcoin-core-dev [-o wumpus] by ChanServ
07:23 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
07:27 < luke-jr> any idea why bitcoind crashes at startup in Valgrind? :/
07:28 < luke-jr> with UBSan*
07:30 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has joined #bitcoin-core-dev
07:31 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
07:32 -!- dleffler1 [~dleffler@178.239.168.171] has quit []
07:33 -!- Kiminuo [~mix@217.138.199.36] has quit [Ping timeout: 272 seconds]
07:36 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadmz]
07:41 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
07:43 -!- jbarcelo [43daf305@67.218.243.5] has quit [Ping timeout: 245 seconds]
07:46 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Client Quit]
07:59 -!- jMCg [~jMCg@195.140.213.38] has joined #bitcoin-core-dev
08:03 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
08:06 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds]
08:07 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
08:11 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 246 seconds]
08:33 -!- promag [~promag@188.250.84.129] has quit [Remote host closed the connection]
08:34 -!- romanz [~romanz@93.123.196.104.bc.googleusercontent.com] has quit [Quit: WeeChat 2.3]
08:36 -!- romanz [~romanz@93.123.196.104.bc.googleusercontent.com] has joined #bitcoin-core-dev
08:39 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
08:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:45 < bitcoin-git> [bitcoin] jonatack opened pull request #20510: [backport] wallet: allow zero-fee fundrawtransaction/walletcreatefundedpsbt and other fixes (0.21...backport-fee_rate-follow-ups) https://github.com/bitcoin/bitcoin/pull/20510
08:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:49 -!- RickMortir22 [~RickMorti@45.135.187.65] has joined #bitcoin-core-dev
08:49 < RickMortir22> Anyone Can Help? - My Bitcoin Core dont Work Anymore, it stoped syng 19 hours ago and dont sync anymore, its shows "19 hours ago" forever, and status bar show "connecting..."
08:52 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
09:02 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
09:08 -!- satwo [~textual@2600:1700:2d30:5310:a1c8:226c:c134:e878] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
09:10 -!- RickMortir22 [~RickMorti@45.135.187.65] has quit []
09:11 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
09:16 -!- jesseposner [~jp@2601:643:8980:bfd2:29df:a2cb:6f55:8d6d] has joined #bitcoin-core-dev
09:19 < wumpus> luke-jr: no idea, I'm sure valgrind gives some kind of error?
09:21 -!- Pavlenex [~Thunderbi@178.220.103.52] has joined #bitcoin-core-dev
09:21 < wumpus> there's sanitizer suppressions for ubsan in fuzz/test/sanitizer_suppressions/ubsan
09:25 < MarcoFalke> can valgrind run with sanitizers on top, even?
09:31 < wumpus> that's a good question
09:34 -!- joelklabo [~textual@157-131-101-185.fiber.dynamic.sonic.net] has joined #bitcoin-core-dev
09:40 -!- skyikot [~skyikot@gateway/tor-sasl/skyikot] has joined #bitcoin-core-dev
09:58 < sipa> afaik no
09:58 -!- Kiminuo [~mix@217.138.199.36] has joined #bitcoin-core-dev
10:06 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has quit [Read error: Connection reset by peer]
10:06 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has joined #bitcoin-core-dev
10:11 < sipa> vasild: yes, that works
10:11 < glozow> #proposedmeetingtopic package validation design question
10:11 < sipa> i was working on a fix as part of rebasing the serialization parameters
10:11 < glozow> is that how u do it
10:12 < jnewbery> that's exactly how you do it!
10:13 < glozow> whew, thanks jnewbery
10:14 -!- jesseposner [~jp@2601:643:8980:bfd2:29df:a2cb:6f55:8d6d] has quit [Quit: My Mac Mini has gone to sleep. ZZZzzz…]
10:16 -!- Pavlenex [~Thunderbi@178.220.103.52] has quit [Quit: Pavlenex]
10:17 -!- Pavlenex [~Thunderbi@178.220.103.52] has joined #bitcoin-core-dev
10:24 < ajonas> #proposedmeetingtopic 2019-20 Coredev survey summary
10:30 -!- skyikot [~skyikot@gateway/tor-sasl/skyikot] has quit [Ping timeout: 240 seconds]
10:39 < sipa> ugh, anchors.dat stores CAddress objects on disk, without file versioning
10:39 < sipa> this means it doesn't support v2 addresses
10:40 < jonatack> good catch
10:41 < sipa> going to open an issue
10:50 < sipa> glozow: wth is peter wheel? ;)
10:53 < glozow> sipa: bitcoin gandalf, roams Middle Earth with the hobbitcoins
10:59 < hebasto> as anchors.dat is a new feature, could it use only v2 addresses?
11:00 < wumpus> #startmeeting
11:00 < core-meetingbot> Meeting started Thu Nov 26 19:00:49 2020 UTC.  The chair is wumpus. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
11:00 < core-meetingbot> Available commands: action commands idea info link nick
11:00 < sipa> hebasto: yes, but what when we introduce v3?
11:01 < jonasschnelli> hi
11:01 < wumpus> #bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik
11:01 < kanzure> hi
11:01 < wumpus> petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild wumpus
11:01 < hebasto> hi
11:01 < achow101> today's a us holiday so there may be fewer people
11:01 < jonatack> hola
11:01 < glozow> hi
11:01 < wumpus> congrats on rc2 everyone !
11:01 < fjahr> hi
11:01 < jb55> hi
11:01 < wumpus> achow101: yes, might be a short meeting
11:01 < sipa> hi
11:02 < ajonas> hi
11:02 < michaelfolkson> Happy Thanksgiving US peeps
11:02 -!- satwo [~textual@209-30-116-174.lightspeed.nsvltn.sbcglobal.net] has joined #bitcoin-core-dev
11:02 < wumpus> we do have two proposed meeting topics for today: package validation design question (glozow), 2019-20 Coredev survey summary (ajonas)
11:03 < wumpus> any any others if people have last minute proposals
11:03 < wumpus> #topic High priority for review
11:03 < core-meetingbot> topic: High priority for review
11:04 < wumpus> https://github.com/bitcoin/bitcoin/projects/8  9 blockers, 2 chasing concept ACK
11:04 -!- satwo [~textual@209-30-116-174.lightspeed.nsvltn.sbcglobal.net] has quit [Client Quit]
11:04 < jnewbery> hi
11:04 < wumpus> anything to add/remote or that is ready for merge?
11:04 < fjahr> Can we add #19055 to blockers again?
11:05 < gribble> https://github.com/bitcoin/bitcoin/issues/19055 | Add MuHash3072 implementation by fjahr · Pull Request #19055 · bitcoin/bitcoin · GitHub
11:05 < wumpus> fjahr:sure
11:05 < fjahr> thx
11:05 < sipa> #20207 should be ready... not really a blocker for me, but would be nice to get in
11:05 < gribble> https://github.com/bitcoin/bitcoin/issues/20207 | Follow-up extra comments on taproot code and tests by sipa · Pull Request #20207 · bitcoin/bitcoin · GitHub
11:06 < wumpus> you have nothing else on the list so will add it
11:08 < wumpus> that concludes the topic I think
11:08 < jonatack> not as a blocker, but maybe #20483 for backport to 0.21 to avoid the feeRate / fee_rate options being a potential source of confusion/footgun 
11:08 < gribble> https://github.com/bitcoin/bitcoin/issues/20483 | wallet: deprecate feeRate in fundrawtransaction/walletcreatefundedpsbt by jonatack · Pull Request #20483 · bitcoin/bitcoin · GitHub
11:08 < wumpus> ok
11:08 < jonatack> if not, otherwise it can wait
11:09 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection]
11:09 < wumpus> for 0.21.1 I guess? if it's not a bugfix I don't think we should merge it between rcs
11:09 < jonatack> (feeRate is in BTC/kB, fee_rate is in sat/vB)
11:10 < jonatack> wumpus: as you think best
11:10 < wumpus> in any case it's in the high prio list now
11:11 < jonatack> 👌
11:11 < wumpus> oh it's 8 files changes, of which 7 tests and only small changes in a cpp
11:12 < wumpus> could still be in a rc i guess
11:13 < wumpus> #topic package validation design question (glozow)
11:13 < core-meetingbot> topic: package validation design question (glozow)
11:13 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
11:13 < glozow> So I’m in the process of doing package mempool acceptance logic. I have a design question that boils down to “if a transaction in a package fails, should we reject the whole package immediately?”
11:13 < glozow> If it’s a package from p2p (i.e. through package relay) then it seems most logical to fail as early as possible. my draft implementation does all PreChecks first for this reason, and then we don’t do script checks.
11:13 < glozow> If we’re doing a testmempoolaccept for a package, however, it seems appropriate to fully validate each one so clients have more helpful information.
11:14 < glozow> Wondering if people have thoughts/opinions?
11:14 < sipa> you're basically asking if the whole package would fail, should the behavior sort of automatically retry with subpackages?
11:15 < sipa> (or be equivalent to that)
11:15 < glozow> sipa: yeah
11:15 < sipa> is there a need for that?
11:15 < jnewbery> That sounds reasonable to me. package acceptance over p2p should be atomic. If you're doing a testmempoolaccept it's helpful to return more granular acceptance information
11:16 < sipa> the idea is initially just having this as RPC?
11:16 < wumpus> yes, P2P clients don't get helpful information back anyway
11:16 < jnewbery> If there was a sendrawtransactionpackage we'd probably want that to be atomic I think
11:16 < glozow> yeah, i want to do 1 testmempoolaccept, 2 submit packages through rpc, 3 package relay
11:16 < sipa> no reason why the RPC can't be initially just only entire-package, and if there is a use for more granular acceptance, add RPC support for that later
11:16 < sipa> (if ever)
11:17 < wumpus> for RPC it's useful to at least get detailed information on which transaction failed, but it still makes sense for it to be atomic
11:17 < sipa> i could imagine that on P2P maybe there are reasons why you'd want to be able to accept subpackages, e.g. to avoid one bad transactions added to a package by an attacker can't prevent the entire package from being relayed
11:17 < sipa> but i think those are longer term questions
11:17 < jnewbery> I think if you submit a package (tx A -> tx B -> tx C) to testmempoolaccept it's helpful to the user to know whether A or B or C failed
11:18 < glozow> yes, i'm leaning towards running full checks for each tx until they pass/fail in a testaccept
11:19 < michaelfolkson> But surely something has gone badly wrong if you can't figure out which transaction in your package was the reason for the rejection?
11:19 < wumpus> sipa: right, shouldn't cache all the transactions individually as rejected
11:19 < glozow> yah good point
11:20 < michaelfolkson> I guess it depends on whether if there are weird rejection policies out there
11:21 < glozow> michaelfolkson: what kinds of weird rejection policies?
11:21 < jnewbery> Do we ever need to sort the txs in a package (from user or over P2P), or do we expect them always to be sorted?
11:21 < glozow> jnewbery: i think we should sort it ourselves
11:21 < sipa> jnewbery: i'd expect to use dependency ordering
11:21 < sipa> (first sort by how many parents in the package it has, then by txid)
11:21 < sipa> on either the sender or the receiver side
11:22 < michaelfolkson> glozow: I'm trying to think of reasons for a package rejection that isn't clear to the sender
11:22 < sipa> michaelfolkson: the obvious one is a new standardness rule on the network (e.g. softfork that enables new scripts, which the sender knows about but the receiver doesn't)
11:22 < sipa> if that happens in a leaf of a package
11:22 < jnewbery> sipa: how many parents or how many ancestors?
11:23 < sipa> jnewbery: either works
11:23 < sipa> presumably the receiver still wants the package without that leaf
11:23 < glozow> would you know how many ancestors without doing a few checks? uh oh
11:23 < sipa> glozow: that's trivial, i think?
11:23 < sipa> we do that sorting everywhere
11:23 < sipa> inside tx messages e.g.
11:23 < jnewbery> huh? A tx's parent can have more parents in the package than the child, no?
11:23 < glozow> ah okay cool
11:24 < sipa> jnewbery: oh sorry i mean you can either use ancestors, or depth
11:24 < sipa> not # of parents
11:24 < jnewbery> right
11:24 < sipa> but i think these are all questions for later
11:24 < jonatack> glozow: is your concern about a trade-off between resource use/ddos and full atomic validation?
11:25 < sipa> for now i think, as an RPC it's fine to just try atomically accepting the whole package
11:25 < michaelfolkson> sipa: Is it possible that post Taproot activation that an unupgraded node would reject Taproot transactions in a package? 
11:25 < sipa> michaelfolkson: they should
11:25 < sipa> (except there won't be pre-taproot post-package relay nodes :p)
11:26 < michaelfolkson> sipa hopes
11:26 < michaelfolkson> haha
11:26 < sipa> regardless of whether it activates or not
11:26 < glozow> jonatack: yeah, even if not a dos concern, it at least seems unproductive to run PolicyScriptChecks for any tx if we're going to reject the whole package, since those aren't even cached.
11:27 < sipa> policy checks are cheap though
11:27 < glozow> PolicyScriptChecks?
11:27 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds]
11:27 < jnewbery> sipa: PolicyScriptChecks are script/sig validation
11:27 < sipa> oh, ok
11:27 < sipa> not familiar with that function
11:28 < michaelfolkson> Why "they should"? What do they have to lose by accepting a anyonecanspend transaction as part of the package?
11:28 < sipa> michaelfolkson: soft fork safety relies on using transactions the unupgraded networks considers nonstandard
11:28 < jnewbery> sipa: it's a step in AcceptToMemoryPool
11:29 < jnewbery> added by sdaftuar when he split it possible to implment package acceptance I believe
11:29 < sipa> ah
11:29 < glozow> yeah added in #16400
11:29 < gribble> https://github.com/bitcoin/bitcoin/issues/16400 | refactor: Rewrite AcceptToMemoryPoolWorker() using smaller parts by sdaftuar · Pull Request #16400 · bitcoin/bitcoin · GitHub
11:30 < jnewbery> sipa: so you think the node should always dependency sort packages, both from p2p and rpc?
11:30 < jnewbery> seems to me that the sender/client should do that?
11:31 < sipa> jnewbery: yeah, no opening on whose responsibility it should be
11:31 < sipa> in P2P, i think it may make sense to force the burden on the sender, because they already know this information anyway
11:32 < glozow> sipa: so if you receive a package you don't check to see if it's sorted properly, you just reject if it doesn't work?
11:32 < jnewbery> I can see the argument for rpc to accept just a bag of txs and sort it
11:32 < sipa> glozow: yeah
11:32 < sipa> jnewbery: yeah
11:32 < glozow> (also so i don't take up too much time, just making sure, for RPC, it's ok if i do full validation checks for each tx in a testmempoolaccept package, and atomic for real package submissions?)
11:33 < sipa> glozow: i'd more think the other way around
11:33 < wumpus> there's one other, probably short, topic, so no you're not taking up too much time :)
11:33 < jnewbery> I think sipa is saying make both RPC and P2P atomic
11:33 < sipa> i'm saying, for now, only do RPC, and make it atomic
11:33 < sipa> because there is no need for anything else unless someone comes up with a use case
11:34 < sipa> for P2P package relay... i feel there may be a need for accepting subpackages, but that's a question we can discuss later
11:34 < jnewbery> I still think there's value to make RPC granular if it doesn't add too much complication, because providing the extra information to the user can be helpful
11:34 < sipa> extra information and being atomic aren't in conflict with each other
11:34 < sipa> you can report "the package failed... and this is the first problem i encountered, in tx A"
11:34 < wumpus> right
11:35 < jnewbery> ah, maybe we haven't described the problem well
11:35 < sipa> being non-atomic would be a result of the form "the subset of packages {A,B,C,...} is acceptable from your bag, but D failed because Y"
11:35 < jnewbery> there are many steps in AcceptToMemoryPool: Prechecks, policy checks, consensus checks
11:35 < sipa> at least that's how i interpreted it
11:36 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 260 seconds]
11:36 -!- joelklabo [~textual@157-131-101-185.fiber.dynamic.sonic.net] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
11:36 < michaelfolkson> Non-atomic would be accepting a subset of the package right? Rather than rejecting it outright and providing info why
11:36 < jnewbery> we should first do prechecks for all txs, then policy checks for all txs, then consensus checks for all txs
11:36 < sipa> jnewbery: agree
11:36 < glozow> so the question is, if A and B passed prechecks but C didn't, should we still run script checks for A and B?
11:37 < jnewbery> but if tx C fails prechecks, it might still be helpful to do policy checks for tx A and tx B and consensus checks for tx A and tx B so we can say to the user "tx A and tx B are good, but tx C fails in prechecks"
11:37 < sipa> i'd say no - for now - because the package in its entirety isn't acceptable
11:38 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
11:38 < michaelfolkson> I guess the concern that there is inefficiency. The sender keeps coming back with a smaller package that still gets rejected
11:38 < sipa> michaelfolkson: in RPC there is no "sender"
11:38 < glozow> what if there's a script error in A, and a prechecks error in C (and C depends on B which depends on A), it'd be more helpful to the RPC client to know how to fix the error in A first?
11:39 < sipa> and if the user wants that kind of functionality, we should add it
11:39 < sipa> glozow: is that a big design question that needs to be known up front?
11:39 < sipa> otherwise i'd just say do the simplest thing first, and iterate
11:40 -!- skyikot [~skyikot@gateway/tor-sasl/skyikot] has joined #bitcoin-core-dev
11:41 < glozow> it does affect the testmempoolaccept API, i'd like as helpful a response as possible if the package fails
11:42 < sipa> i feel that adding more detailed error reporting later can probably be done in a backward compatible manner
11:42 -!- eugene-ff [~eugene_ff@2604:2000:1383:472b:243e:c1cc:8b:e45f] has joined #bitcoin-core-dev
11:42 < MarcoFalke> I'd also say to do the simpler thing first. Literally any progress on teaching TATMP packages is a nice feature 
11:42 < glozow> ok, so atomic for now
11:42 < sipa> if the RPC is "your package is acceptable in its entirety: yes/no. here is a list of problems i found: []"
11:43 < MarcoFalke> Also, we can't keep policy error messages identical between releases anyway
11:43 < sipa> MarcoFalke: right
11:44 < glozow> got it, thanks everyone
11:44 < wumpus> #topic 2019-20 Coredev survey summary (ajonas)
11:44 < core-meetingbot> topic: 2019-20 Coredev survey summary (ajonas)
11:44 < MarcoFalke> glozow: Thanks for working on this!
11:44 < sipa> absolutely
11:45 < ajonas> In January, jnewbery sent out a survey that he planned to present the results of at the Coredev in March. Given that the meeting never happened, I put together a presentation/post summarizing the responses. Both can be found at https://adamjonas.com/bitcoin/coredev/retro/coredev-2019-retro/.
11:45 < ajonas> No action items. Just want to call it to people's attention.
11:45 < wumpus> ajonas: awesome!
11:45 < jnewbery> ajonas: thank you for picking this up
11:45 < michaelfolkson> For the summary watch the video I guess?
11:46 < ajonas> the post and the video are about the same
11:46 < sipa> short note: i just opened #20511, which i think is something to address for 0.21
11:46 < gribble> https://github.com/bitcoin/bitcoin/issues/20511 | anchors.dat doesnt support V2 addresses · Issue #20511 · bitcoin/bitcoin · GitHub
11:46 < jonatack> ajonas: wow! thanks!
11:46 < glozow> ajonas: wow cool!!!
11:46 < sipa> ajonas: thanks for that, will read (and maybe watch)
11:46 < jonasschnelli> nice!
11:46 < ajonas> thanks to jnewbery for sending it out and I hope we can do another round in early 2021.
11:47 < fjahr> ajonas: cool!
11:49 < wumpus> unless anyone wants to discuss a specific thing from that overview, I think this concludes the meeting
11:49 < jnewbery> I agree that there's much more value in these things if we repeat them periodically. Everyone who answered talked about their hopes for the project and their contributions in 2020, so looking back at those should be interesting for people
11:50 < wumpus> yes it's interesting I agree with most of the comments
11:51 < wumpus> #endmeeting
11:51 < core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
11:51 < core-meetingbot> Meeting ended Thu Nov 26 19:51:25 2020 UTC.  
11:51 < core-meetingbot> Minutes:        https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2020/bitcoin-core-dev.2020-11-26-19.00.moin.txt
11:52 < michaelfolkson> I'm guessing there will be no Core dev meeting until it can be done in person? People aren't keen on video conference like things
11:53 < MarcoFalke> michaelfolkson: IRC works better than video
11:53 < sipa> i'm personally not particularly interested in non-in-person coredev
11:54 < michaelfolkson> Fair enough
11:55 < michaelfolkson> I think it is IRC < Video < In person for engagement. But IRC definitely most convenient
11:58 -!- luke [~luke@bitnomial/staff/luke] has joined #bitcoin-core-dev
12:00 < jonatack> same for me as MarcoFalke and sipa ^
12:01 -!- joelklabo [~textual@157-131-101-185.fiber.dynamic.sonic.net] has joined #bitcoin-core-dev
12:03 < hebasto> ^ same
12:04 < michaelfolkson> To be clear I wasn't proposing video instead of IRC for the weekly meetings lol. Only as a possible substitute to the in person Core dev meeting until Covid is over
12:18 < michaelfolkson> Great video ajonas. Interested in how next year's will compare
12:19 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
12:23 < michaelfolkson> I'm guessing at least some of this has improved. Signet and BIP 157 have made progress. Coin selection less so presumably
12:25 < michaelfolkson> And process separation and fuzzing PRs struggle for review
12:25 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
12:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:36 < bitcoin-git> [bitcoin] emilengler opened pull request #20512: doc: Add bash as an OpenBSD dependency (master...2020-11-doc-build-openbsd-bash-dependency) https://github.com/bitcoin/bitcoin/pull/20512
12:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:40 < bitcoin-git> [bitcoin] bitcoinhodler opened pull request #20513: Release notes: remove mention of default wallet creation (master...no-default-wallet) https://github.com/bitcoin/bitcoin/pull/20513
12:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:46 -!- Kiminuo [~mix@217.138.199.36] has quit [Ping timeout: 240 seconds]
12:55 -!- satwo [~textual@2600:1700:2d30:5310:a1c8:226c:c134:e878] has joined #bitcoin-core-dev
12:58 -!- luke [~luke@bitnomial/staff/luke] has quit [Quit: sleep]
13:00 -!- satwo [~textual@2600:1700:2d30:5310:a1c8:226c:c134:e878] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
13:02 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
13:03 -!- schmeckin [~schmecks@198.181.163.31] has joined #bitcoin-core-dev
13:03 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
13:06 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net]
13:07 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
13:12 -!- schmeckin [~schmecks@198.181.163.31] has left #bitcoin-core-dev []
13:12 < aj> wumpus: any thoughts on "bitcoin-util grind" ? another option might be to add "bitcoin-cli -grind=HEADER" with the idea being to move it into bitcoin-util in a later PR that also includes other useful stuff, like psbt commands?
13:12 -!- schmeckin [~schmecks@198.181.163.31] has joined #bitcoin-core-dev
13:13 < schmeckin> It's amazing what a bunch of assholes yall are.  You wonder why you're being insulted after spending 8 years being corrupt pathological lieing fucktards instead of rectifying the issue?
13:13 < schmeckin> midnight ------->> [[ You are as rotten as a clumsy decaying myriad of smelly bat pus ]] <<-------
13:13 < schmeckin> luke-jr ------->> [[ You are as noxious as a dirty clumsy accumulation of rotten despicable disgusting cockroach dung ]] <<-------
13:13 < schmeckin> gmaxwell ------->> [[ You are as hostile as a barren mass of ineffectual bat orifices ]] <<-------
13:18 -!- schmeckin [~schmecks@198.181.163.31] has quit [Quit: Leaving]
13:30 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
13:30 -!- satwo [~textual@2600:1700:2d30:5310:a1c8:226c:c134:e878] has joined #bitcoin-core-dev
13:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:34 < bitcoin-git> [bitcoin] bitcoinhodler closed pull request #20513: Release notes: remove mention of default wallet creation (0.21...no-default-wallet) https://github.com/bitcoin/bitcoin/pull/20513
13:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:36 -!- gleb [~gleb@178.150.137.228] has quit [Quit: Ping timeout (120 seconds)]
13:37 -!- kexkey [~kexkey@static-198-54-132-150.cust.tzulo.com] has quit [Ping timeout: 256 seconds]
13:37 -!- gleb [~gleb@178.150.137.228] has joined #bitcoin-core-dev
13:56 -!- MTennis [~Tennis@unaffiliated/tennis] has quit [Ping timeout: 272 seconds]
13:57 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds]
14:00 -!- joelklabo [~textual@157-131-101-185.fiber.dynamic.sonic.net] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
14:01 -!- lightlike [~lightlike@p200300c7ef1bcf00887629e01a1f3407.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
14:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:02 < bitcoin-git> [bitcoin] sipa opened pull request #20514: Use addrv2 serialization in anchors.dat (master...202011_v2_anchors) https://github.com/bitcoin/bitcoin/pull/20514
14:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:06 < luke-jr> wumpus: not a sensible one https://dpaste.com/8KGS42GH5
14:08 < luke-jr> I mean, if this were correct, it wouldn't matter if it was Valgrind run or not XD
14:11 -!- Pavlenex [~Thunderbi@178.220.103.52] has quit [Quit: Pavlenex]
14:14 < luke-jr> oh lovely, it goes away if I LogPrintf the pointer -.-
14:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:16 < bitcoin-git> [bitcoin] sipsorcery closed pull request #20508: IGNORE: Testing appveyor CI build with pre-built dependencies (master...msvc-vcpkg-prebuilt) https://github.com/bitcoin/bitcoin/pull/20508
14:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:17 -!- Pavlenex [~Thunderbi@178.220.103.52] has joined #bitcoin-core-dev
14:21 -!- Pavlenex [~Thunderbi@178.220.103.52] has quit [Client Quit]
14:24 < michaelfolkson> Don't know why the trolls are targeting you today luke-jr. On behalf of humanity I apologize
14:26 < luke-jr> michaelfolkson: me either :/
14:28 < sipa> wumpus: qt compiles now, "apt install --reinstall qtbase5-dev" was enough to fix it
14:33 < luke-jr> O.o
14:34 < sipa> luke-jr: somehow i was missing libQt5Core.so (i only had .so.5)
14:34 < luke-jr> weird
14:45 -!- gleb [~gleb@178.150.137.228] has quit [Ping timeout: 260 seconds]
14:46 < luke-jr> hrm, -O0 doesn't crash in Valgrind
14:47 < luke-jr> not sure this tells me anything
14:51 < sipa> luke-jr: are you mixing sanitizers and valgrind?
14:54 < luke-jr> sipa: just ubsan
14:55 < sipa> that's certainly the least invasive
14:58 < luke-jr> I suppose I could rebuild without just to see
14:58 < luke-jr> but if it fails to reproduce, I'm not sure UBSan is at fault even then
14:59 < luke-jr> LogPrintfs down to FastRandomContext::rand64 leave the crash intact and show non-null ptr
15:00 < luke-jr> LogPrintfs in FastRandomContext::FillByteBuffer or ChaCha20::Keystream show the same non-null ptr and fix the crash
15:00 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
15:01 < sipa> luke-jr: i mean... if it were actually trying to write 4 bytes to nullptr, your process would segfault
15:01 < sipa> so if it works by just running, and not inside valgrind (both with ubsan enabled), it's a problem with the combination of the two
15:02 -!- gleb [~gleb@178.150.137.228] has joined #bitcoin-core-dev
15:05 < luke-jr> sipa: it does segfault :P
15:05 < luke-jr> inside valgrind*
15:06 < luke-jr> but not without UBSan
15:06 < luke-jr> strange
15:07 < sipa> luke-jr: but does it segfault *with* ubsan, but outside valgrind?
15:11 < luke-jr> sipa: no
15:11 < luke-jr> but that could just indicate a timing issuse
15:14 -!- filchef [~filchef@212.104.97.177] has quit [Read error: Connection reset by peer]
15:17 -!- jesseposner [~jp@2601:643:8980:bfd2:29df:a2cb:6f55:8d6d] has joined #bitcoin-core-dev
15:18 -!- gleb3 [~gleb@178.150.137.228] has joined #bitcoin-core-dev
15:19 -!- gleb [~gleb@178.150.137.228] has quit [Ping timeout: 260 seconds]
15:19 < sipa> luke-jr: could be, indeed
15:19 -!- gleb3 is now known as gleb
15:19 -!- jesseposner [~jp@2601:643:8980:bfd2:29df:a2cb:6f55:8d6d] has quit [Client Quit]
15:20 -!- jesseposner [~jp@2601:643:8980:bfd2:29df:a2cb:6f55:8d6d] has joined #bitcoin-core-dev
15:28 -!- satwo [~textual@2600:1700:2d30:5310:a1c8:226c:c134:e878] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
15:35 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
15:42 < luke-jr> in the meantime, the actual issue I was *trying* to debug, doesn't occur in Valgrind x.x
15:44 -!- MTennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev
15:54 -!- lightlike [~lightlike@p200300c7ef1bcf00887629e01a1f3407.dip0.t-ipconnect.de] has quit [Quit: Leaving]
15:58 -!- mrostecki [~mrostecki@gateway/tor-sasl/mrostecki] has quit [Quit: Leaving]
15:59 -!- mrostecki [mrostecki@nat/suse/x-kwnqnqspcazesbuo] has joined #bitcoin-core-dev
16:12 -!- MTennis [~Tennis@unaffiliated/tennis] has quit [Read error: Connection reset by peer]
16:18 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 256 seconds]
16:21 -!- yayaya [3aa55966@58.165.89.102] has joined #bitcoin-core-dev
16:21 -!- mrostecki[m] [mrosteckim@gateway/shell/matrix.org/x-umppgnaioxfkrbey] has joined #bitcoin-core-dev
16:22 -!- yayaya [3aa55966@58.165.89.102] has quit [Remote host closed the connection]
17:06 < luke-jr> hmm, no way to specify --timeout-factor for test-runner
17:10 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
17:12 -!- shesek [~shesek@164.90.217.137] has joined #bitcoin-core-dev
17:12 -!- shesek [~shesek@164.90.217.137] has quit [Changing host]
17:12 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
17:13 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadmz]
17:15 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
17:19 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
17:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
17:21 < bitcoin-git> [bitcoin] sipa opened pull request #20516: Introduce well-defined CAddress disk serialization (master...202011_disk_addr) https://github.com/bitcoin/bitcoin/pull/20516
17:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
17:29 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
17:31 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
17:31 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadmz]
17:36 -!- promag [~promag@188.250.84.129] has quit [Remote host closed the connection]
17:36 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
17:39 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
17:39 -!- vasild_ is now known as vasild
17:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
17:45 < bitcoin-git> [bitcoin] memolabed opened pull request #20517: 0.22 (master...0.21) https://github.com/bitcoin/bitcoin/pull/20517
17:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
17:47 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
17:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
17:47 < bitcoin-git> [bitcoin] fanquake closed pull request #20517: 0.22 (master...0.21) https://github.com/bitcoin/bitcoin/pull/20517
17:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
18:00 -!- jMCg [~jMCg@195.140.213.38] has quit [Remote host closed the connection]
18:05 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
18:07 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 240 seconds]
18:17 -!- RickMortir22 [~RickMorti@186.220.66.225] has joined #bitcoin-core-dev
18:17 < RickMortir22> Anyone Can Help? - My Bitcoin Core dont Work Anymore, it stoped syng 19 hours ago and dont sync anymore, its shows "19 hours ago" forever, and status bar show "connecting..."
18:17 < RickMortir22> Anyone Can Help? - My Bitcoin Core dont Work Anymore, it stoped syng 19 hours ago and dont sync anymore, its shows "19 hours ago" forever, and status bar show "connecting..."
18:27 -!- dibble707 [~J@37.120.218.106] has joined #bitcoin-core-dev
18:40 -!- RickMortir22 [~RickMorti@186.220.66.225] has quit []
18:41 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
18:53 -!- sunetoft [~sunetoft@185.103.96.147] has joined #bitcoin-core-dev
18:56 -!- az0re [~az0re@gateway/tor-sasl/az0re] has quit [Remote host closed the connection]
19:00 -!- az0re [~az0re@gateway/tor-sasl/az0re] has joined #bitcoin-core-dev
19:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds]
19:11 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadmz]
19:42 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has quit [Ping timeout: 240 seconds]
19:45 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has joined #bitcoin-core-dev
19:48 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
19:55 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
19:57 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 264 seconds]
20:06 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds]
20:07 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
20:32 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has quit [Read error: Connection reset by peer]
20:32 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has joined #bitcoin-core-dev
20:38 -!- dibble707 [~J@37.120.218.106] has quit [Quit: Leaving]
20:59 -!- Randolf [~randolf@184.70.10.189] has joined #bitcoin-core-dev
20:59 -!- Randolf [~randolf@184.70.10.189] has quit [Remote host closed the connection]
21:04 -!- Randolf [~randolf@184.70.10.189] has joined #bitcoin-core-dev
21:08 -!- flag [~flag@net-5-94-131-153.cust.vodafonedsl.it] has quit [Quit: leaving]
21:09 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
21:09 -!- RandolfR [~randolf@184.70.10.188] has joined #bitcoin-core-dev
21:12 -!- Randolf [~randolf@184.70.10.189] has quit [Ping timeout: 260 seconds]
21:15 -!- flag [~flag@net-93-66-71-105.cust.vodafonedsl.it] has joined #bitcoin-core-dev
21:16 -!- pinheadmz [~pinheadmz@pool-100-33-69-78.nycmny.fios.verizon.net] has quit [Quit: pinheadmz]
21:17 -!- RandolfR is now known as Randolf
21:41 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]
21:43 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:7ef3:407f:c35a:de9b:b845] has joined #bitcoin-core-dev
22:45 -!- Randolf [~randolf@184.70.10.188] has quit [Remote host closed the connection]
23:26 -!- Pavlenex [~Thunderbi@178.220.103.52] has joined #bitcoin-core-dev
23:26 -!- Pavlenex [~Thunderbi@178.220.103.52] has quit [Client Quit]
23:30 < fanquake> wumpus / sipa: can you block gloriashaw
23:31 < wumpus> sure
23:37 -!- Pavlenex [~Thunderbi@178.220.103.52] has joined #bitcoin-core-dev
23:39 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
23:49 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 246 seconds]
23:52 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:7ef3:407f:c35a:de9b:b845] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
23:53 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:7ef3:407f:c35a:de9b:b845] has joined #bitcoin-core-dev
23:53 -!- Kiminuo [~mix@141.98.103.116] has joined #bitcoin-core-dev
--- Log closed Fri Nov 27 00:00:28 2020