--- Log opened Mon Nov 30 00:00:31 2020 00:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:11 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2e1336dbfe8a...817aeca57a4c 00:11 < bitcoin-git> bitcoin/master 830ddf4 Hennadii Stepanov: Drop noop gcc version checks 00:11 < bitcoin-git> bitcoin/master 817aeca fanquake: Merge #20491: refactor: Drop noop gcc version checks 00:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:11 < bitcoin-git> [bitcoin] fanquake merged pull request #20491: refactor: Drop noop gcc version checks (master...201125-gcc) https://github.com/bitcoin/bitcoin/pull/20491 00:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:17 -!- Zack72 [58f3467e@88.243.70.126] has joined #bitcoin-core-dev 00:19 -!- Pavlenex [~Thunderbi@178.220.103.52] has joined #bitcoin-core-dev 00:22 -!- pinheadmz [~pinheadmz@71.190.30.138] has quit [Ping timeout: 240 seconds] 00:25 -!- pinheadmz [~pinheadmz@71.190.30.138] has joined #bitcoin-core-dev 00:28 -!- Zack72 [58f3467e@88.243.70.126] has quit [Remote host closed the connection] 00:38 -!- someone235 [uid419897@gateway/web/irccloud.com/x-xrruhlejkwndamue] has joined #bitcoin-core-dev 00:51 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:09 < willcl_ark> luke-jr: I've been trying out ripgrep recently. It can handle multiple directories and seems to be pretty fast. e.g. `rg CTxDestination bitcoin*` will search all directories in current dir starting with bitcoin. 01:14 < willcl_ark> There's also an interesting writeup of a 'speedtest' here FYI https://blog.burntsushi.net/ripgrep/ 01:14 < sipa> i've never had a situation where "git grep" in the bitcoin repo wasn't fast enough 01:24 -!- reallll is now known as belcher 01:32 < willcl_ark> Agreed. I imagined Luke might be trying to grep bitcoin and bitcoin-gui repos at the same time, and using some small script to bolt together two git searches? Not familiar with git-grep-all tbh :) 01:35 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has quit [Quit: Find me in #TheHolyRoger or https://theholyroger.com] 01:40 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 260 seconds] 01:41 -!- gleb [~gleb@178.150.137.228] has quit [Quit: Ping timeout (120 seconds)] 01:41 -!- gleb [~gleb@178.150.137.228] has joined #bitcoin-core-dev 01:43 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Remote host closed the connection] 01:47 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has joined #bitcoin-core-dev 01:59 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev 02:03 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.161.165] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 02:08 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 256 seconds] 02:08 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has quit [Read error: Connection reset by peer] 02:08 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has joined #bitcoin-core-dev 02:33 -!- bosch-0 [uid472282@gateway/web/irccloud.com/x-dsrkxgksxcxzzvbo] has joined #bitcoin-core-dev 02:36 -!- Kiminuo [~mix@141.98.103.172] has joined #bitcoin-core-dev 02:41 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev 02:43 -!- Pavlenex1 [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 02:46 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 272 seconds] 02:46 -!- Pavlenex [~Thunderbi@178.220.103.52] has quit [Ping timeout: 240 seconds] 02:46 -!- Pavlenex1 is now known as Pavlenex 03:09 -!- iamgr00t [~iamgr00t@unaffiliated/iamgr00t] has joined #bitcoin-core-dev 03:14 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev 03:18 -!- Jeffrey4Casper [~Jeffrey4C@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev 03:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:25 -!- Jeffrey4Casper [~Jeffrey4C@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 265 seconds] 03:28 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev 03:33 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 260 seconds] 03:46 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 03:49 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds] 04:04 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds] 04:25 -!- Trixar_za [~Trixar_za@185.163.110.116] has quit [Remote host closed the connection] 04:27 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.161.165] has joined #bitcoin-core-dev 04:54 -!- eugene-ff [~eugene_ff@2604:2000:1383:472b:a0ea:5202:fc81:f7d7] has joined #bitcoin-core-dev 05:05 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection] 05:05 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 05:07 -!- eugene-ff [~eugene_ff@2604:2000:1383:472b:a0ea:5202:fc81:f7d7] has quit [] 05:09 -!- eugene-ff [~eugene_ff@2604:2000:1383:472b:a0ea:5202:fc81:f7d7] has joined #bitcoin-core-dev 05:12 -!- eugene-ff [~eugene_ff@2604:2000:1383:472b:a0ea:5202:fc81:f7d7] has quit [Client Quit] 05:18 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.161.165] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 05:18 -!- aGHz_nfb [~aGHz_nfb@185.163.110.116] has joined #bitcoin-core-dev 05:26 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev 05:27 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has quit [Ping timeout: 240 seconds] 05:28 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has joined #bitcoin-core-dev 05:30 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 264 seconds] 05:35 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 05:38 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 05:38 -!- vasild_ is now known as vasild 05:50 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.161.165] has joined #bitcoin-core-dev 05:57 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 06:00 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev 06:01 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev 06:03 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 06:03 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 06:18 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has quit [Read error: Connection reset by peer] 06:19 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has joined #bitcoin-core-dev 06:21 < luke-jr> willcl_ark: git-grep-all searches all objects in the repo 06:21 < luke-jr> sipa: ^ 06:23 -!- bosch-0 [uid472282@gateway/web/irccloud.com/x-dsrkxgksxcxzzvbo] has quit [Quit: Connection closed for inactivity] 06:42 < willcl_ark> Ah I see luke-jr, thanks. Then ripgrep will not be able to help you as it can't search all repo objects. 06:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:44 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/817aeca57a4c...81d5af42f4db 06:44 < bitcoin-git> bitcoin/master 4848e71 practicalswift: scripted-diff: Use [[nodiscard]] (C++17) instead of NODISCARD 06:44 < bitcoin-git> bitcoin/master 79bff8e practicalswift: Remove NODISCARD 06:44 < bitcoin-git> bitcoin/master 81d5af4 MarcoFalke: Merge #20499: Remove obsolete NODISCARD ifdef forest. Use [[nodiscard]] (C... 06:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:45 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20499: Remove obsolete NODISCARD ifdef forest. Use [[nodiscard]] (C++17). (master...remove-nodiscard-cruft) https://github.com/bitcoin/bitcoin/pull/20499 06:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:54 -!- promag_ [~promag@188.250.84.129] has joined #bitcoin-core-dev 07:01 -!- sturles [~sturles@unaffiliated/sturles] has quit [Remote host closed the connection] 07:02 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Remote host closed the connection] 07:02 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev 07:03 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.161.165] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 07:07 -!- queip is now known as CobraKai 07:07 -!- CobraKai is now known as queip 07:08 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Read error: Connection reset by peer] 07:13 -!- miketwen_ [~miketwent@ec2-35-172-206-57.compute-1.amazonaws.com] has joined #bitcoin-core-dev 07:17 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 264 seconds] 07:19 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev 07:23 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 07:30 -!- Kiminuo [~mix@141.98.103.172] has quit [Ping timeout: 260 seconds] 07:33 -!- kexkey [~kexkey@static-198-54-132-105.cust.tzulo.com] has joined #bitcoin-core-dev 07:59 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 272 seconds] 07:59 -!- miketwen_ [~miketwent@ec2-35-172-206-57.compute-1.amazonaws.com] has quit [Remote host closed the connection] 08:03 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex] 08:09 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 08:15 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection] 08:18 -!- miketwenty1 [~miketwent@ec2-52-207-61-44.compute-1.amazonaws.com] has joined #bitcoin-core-dev 08:20 < hebasto> sipa: does your ip address crawler see tor v3 addresses in the main network due to rc2 has been published last week? 08:26 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 08:27 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev 08:28 -!- [\\\] is now known as tripleslash 08:36 -!- Dakata [25c9d7ee@aftr-37-201-215-238.unity-media.net] has joined #bitcoin-core-dev 08:37 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex] 08:39 -!- Dakata [25c9d7ee@aftr-37-201-215-238.unity-media.net] has quit [Remote host closed the connection] 08:39 -!- kristapsk_ is now known as kristapsk 08:45 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 08:59 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 09:10 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 09:21 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 240 seconds] 09:23 < sipa> hebasto: no 09:23 < sipa> hebasto: PRs welcome 09:24 < hebasto> sipa: thanks 09:26 < sipa> oh wait 09:26 < sipa> it can't even expose them over DNS 09:26 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 09:27 < hebasto> DNS restrictions? 09:29 < sipa> well there is no space for onion addresses in IPv6 09:29 < sipa> *v3 09:30 < luke-jr> TXT? 09:34 < luke-jr> SRV might be a good fit actually 09:35 < luke-jr> or URI record 09:36 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 09:36 < pinheadmz> lightning uses SRV in bolt 10: https://github.com/lightningnetwork/lightning-rfc/blob/master/10-dns-bootstrap.md#examples 09:36 < pinheadmz> pretty clever 09:40 < sipa> can standard resolvers query SRV records? 09:41 -!- lightlike [~lightlike@p200300c7ef177a00b8e983ade8f2d04e.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 09:44 < pinheadmz> what do you mean? the rfc is 20 years old, i think if the nameserver has an SRV record you can dig it 09:44 < pinheadmz> trying to find a live example 09:45 < pinheadmz> actually the exmple in bolt 10 works 09:45 < pinheadmz> dig lseed.bitcoinstats.com SRV 09:45 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 09:47 -!- jbarcelo [43daf305@67.218.243.5] has joined #bitcoin-core-dev 09:47 < sipa> pinheadmz: i mean, you can't just use getaddrinfo to retrieve it, can you? 09:47 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 264 seconds] 09:47 < sipa> you actually need a DNS client library 09:48 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 09:50 < pinheadmz> ah i see 09:52 -!- Kiminuo [~mix@141.98.103.172] has joined #bitcoin-core-dev 09:52 -!- Guyver2_ is now known as Guyver2 10:02 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 10:02 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex] 10:02 < luke-jr> well, presuambly we're not using getaddrinfo with Tor 10:02 < luke-jr> so the real question is if Tor can do it ;) 10:04 < sipa> we don't use DNS at all over Tor 10:05 < luke-jr> …wasn't that the topic? 10:06 < sipa> instead we use getaddr peers (just connect by name to a DNS seed, using the P2P protocol, do a getaddr, and wait for an addr response) 10:06 < sipa> luke-jr: what currently works for torv2 but not torv3 is learning about them over IPv4/IPv6 from seed nodes 10:09 < sipa> but maybe that's not all that important a use case 10:10 < pinheadmz> sipa when we use DNS seeds, we don't make a DNS request to the seed? 10:10 < sipa> pinheadmz: no, we *resolve* the seed 10:10 < sipa> and it resolves to one or more IP addresses 10:11 < pinheadmz> ah, TIL so there is no `dig bitcoin.sipa.de` or whatever. I always thought we use A records from the seed to bootstrap 10:11 < sipa> doing so likely makes your OS's/ISP's resolver connect to the DNS seed server, but that's transparent from bitcoin core's perspective 10:11 < sipa> all it sees is looking up a name, and getting IP addresses back, using your OS's name resolving functionality 10:14 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Read error: Connection reset by peer] 10:14 < pinheadmz> actually im not getting anything from seed.bitcoin.sipa.be but I am from `dig dnsseed.bluematt.me` 10:15 < pinheadmz> so when we bootstrap we use DNS to get a bunch of A records, then add those IPs to addrman and start connecting 10:15 < sipa> yeah 10:15 < sipa> but from bitcoin core's perspective there is no such thing as A or AAAA or CNAME or whatever records or DNS involved 10:16 < pinheadmz> yeah 10:16 < sipa> it asks for a name, and get IPv4 and IPv6 addresses back from the OS 10:16 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 10:16 < sipa> they could be coming from your local /etc/hosts file instead 10:17 -!- proofofkeags [~proofofke@c-73-34-43-4.hsd1.co.comcast.net] has joined #bitcoin-core-dev 10:18 < pinheadmz> but over tor we connect directly to the "seed" and do a getaddr 10:18 -!- user___ [~user@mail.deeplinkmedia.com] has quit [Ping timeout: 240 seconds] 10:19 < sipa> yes, because you can't do DNS resolving over Tor (that'd require a DNS implementation in bitcoin core, and route it over tor) 10:20 < sipa> instead we just "connect" to the seed, which makes the Tor exit node do the resolving - *not* tell us the result of that resolving - but instead forwarding our connection to it 10:21 < pinheadmz> oh I see, so it still may not be the full node at bitcoin.sipa.be that we conenct to, but any one of the nodes returned in A records to the exit node, which thinks we are just resolving a single service by name 10:21 < sipa> seed.bitcoin.sipa.be may not even *have* a full node 10:21 < pinheadmz> gotcha 10:22 < sipa> or maybe it's more accurate to say it "has" many full nodes, namely all the IPs it resolves to 10:22 < sipa> but none of them are particularly likely to be operated by the operator of the DNS seed itself 10:27 -!- dviola [~diego@unaffiliated/dviola] has quit [Ping timeout: 272 seconds] 10:29 -!- davterra [~davterra@68.235.43.102] has quit [Remote host closed the connection] 10:38 -!- jbarcelo [43daf305@67.218.243.5] has quit [Remote host closed the connection] 10:44 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 10:46 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 240 seconds] 10:48 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 11:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:44 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20535: test: Fix intermittent feature_taproot issue (master...2011-testTapInt) https://github.com/bitcoin/bitcoin/pull/20535 11:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:47 -!- davterra [~davterra@68.235.43.102] has joined #bitcoin-core-dev 11:57 < phantomcircuit> sipa, because they don't fit in ipv6 records i don't think there's anyway to return them that will be cached by intermediate servers, which is probably what really matters 11:58 < phantomcircuit> otherwise could just use the bootstrap peer mechanism 12:00 < sipa> phantomcircuit: right 12:11 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:15 -!- user____ [~user@mail.deeplinkmedia.com] has joined #bitcoin-core-dev 12:44 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 246 seconds] 12:45 -!- promag_ [~promag@188.250.84.129] has quit [] 12:49 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 13:24 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 265 seconds] 13:31 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 13:32 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 13:35 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 13:39 -!- Kiminuo [~mix@141.98.103.172] has quit [Ping timeout: 264 seconds] 13:40 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 13:49 -!- shesek [~shesek@164.90.217.137] has joined #bitcoin-core-dev 13:49 -!- shesek [~shesek@164.90.217.137] has quit [Changing host] 13:49 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 13:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:49 < bitcoin-git> [bitcoin] achow101 opened pull request #20536: wallet: Error with "Transaction too large" if the funded tx will end up being too large after signing (master...fundtx-error-large-tx) https://github.com/bitcoin/bitcoin/pull/20536 13:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:57 -!- HELPME1245a [~jg@89.249.64.220] has joined #bitcoin-core-dev 13:58 -!- HELPME1245a [~jg@89.249.64.220] has quit [Max SendQ exceeded] 13:58 -!- HELPME1245a [~jg@89.249.64.220] has joined #bitcoin-core-dev 13:58 -!- HELPME1245a [~jg@89.249.64.220] has quit [Max SendQ exceeded] 13:59 -!- HELPME1245a [~jg@89.249.64.220] has joined #bitcoin-core-dev 13:59 -!- HELPME1245a [~jg@89.249.64.220] has quit [Max SendQ exceeded] 13:59 -!- HELPME1245a [~jg@89.249.64.220] has joined #bitcoin-core-dev 13:59 -!- HELPME1245a [~jg@89.249.64.220] has quit [Max SendQ exceeded] 13:59 -!- HELPME1245a [~jg@89.249.64.220] has joined #bitcoin-core-dev 14:00 -!- HELPME1245a [~jg@89.249.64.220] has quit [Max SendQ exceeded] 14:00 -!- HELPME1245a [~jg@89.249.64.220] has joined #bitcoin-core-dev 14:13 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Ping timeout: 256 seconds] 14:19 -!- HELPME1245a [~jg@89.249.64.220] has quit [Quit: Leaving] 14:24 -!- filchef [~filchef@212.104.97.177] has quit [Read error: Connection reset by peer] 14:25 -!- nckx is now known as ncksneekx 14:26 -!- ncksneekx is now known as nckx 14:37 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev 14:37 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Client Quit] 14:38 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has quit [Read error: Connection reset by peer] 14:39 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has joined #bitcoin-core-dev 14:44 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 14:45 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 14:45 -!- vasild_ is now known as vasild 15:04 -!- ctrlbreak [~ctrlbreak@159.2.182.106] has quit [Read error: Connection reset by peer] 15:05 -!- ctrlbreak [~ctrlbreak@159.2.182.106] has joined #bitcoin-core-dev 15:07 -!- Klox04809318631 [~Klox@c-24-1-131-19.hsd1.il.comcast.net] has quit [Ping timeout: 240 seconds] 15:09 -!- Klox04809318631 [~Klox@c-24-1-131-19.hsd1.il.comcast.net] has joined #bitcoin-core-dev 15:11 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 15:11 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 15:12 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 15:23 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev 15:24 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 15:28 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 265 seconds] 15:35 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 15:39 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Read error: Connection reset by peer] 15:47 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 15:53 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 16:36 -!- Klox04809318631 [~Klox@c-24-1-131-19.hsd1.il.comcast.net] has quit [Ping timeout: 240 seconds] 16:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:37 < bitcoin-git> [bitcoin] theStack opened pull request #20537: refactor: replace manual Satoshis-to-BTC conversions with FormatMoney() (master...20201129-use-formatmoney) https://github.com/bitcoin/bitcoin/pull/20537 16:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:38 -!- Klox04809318631 [~Klox@c-24-1-131-19.hsd1.il.comcast.net] has joined #bitcoin-core-dev 17:06 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 17:13 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.161-165.dynamic.3bb.co.th] has joined #bitcoin-core-dev 17:18 -!- proofofkeags [~proofofke@c-73-34-43-4.hsd1.co.comcast.net] has quit [Ping timeout: 264 seconds] 17:26 -!- aGHz_nfb [~aGHz_nfb@185.163.110.116] has quit [Remote host closed the connection] 17:27 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 17:30 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 264 seconds] 17:39 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 17:39 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 17:40 -!- lightlike [~lightlike@p200300c7ef177a00b8e983ade8f2d04e.dip0.t-ipconnect.de] has quit [Quit: Leaving] 17:43 -!- davterra [~davterra@68.235.43.102] has quit [Quit: Leaving] 17:46 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 256 seconds] 17:47 -!- maop [~maop@195.140.213.38] has joined #bitcoin-core-dev 17:48 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 17:52 -!- davterra [~davterra@68.235.43.174] has joined #bitcoin-core-dev 18:01 -!- jesseposner [~jp@2601:643:8980:bfd2:f040:ed44:8391:19d3] has joined #bitcoin-core-dev 18:10 < andytoshi> holy shit the taproot python tests are extensive 18:10 < sipa> :) 18:13 < luke-jr> XD 18:29 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 18:32 -!- proofofkeags [~proofofke@174-16-212-53.hlrn.qwest.net] has joined #bitcoin-core-dev 18:33 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 18:42 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 18:43 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 264 seconds] 18:55 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 20:02 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 20:14 -!- az0re [~az0re@gateway/tor-sasl/az0re] has quit [Ping timeout: 240 seconds] 20:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 20:53 -!- miketwenty1 [~miketwent@ec2-52-207-61-44.compute-1.amazonaws.com] has quit [Remote host closed the connection] 20:56 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has quit [Quit: Find me in #TheHolyRoger or https://theholyroger.com] 21:01 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has joined #bitcoin-core-dev 21:03 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds] 21:12 -!- jonatack [~jon@82.102.27.171] has quit [Ping timeout: 240 seconds] 21:15 -!- jonatack [~jon@88.124.242.136] has joined #bitcoin-core-dev 21:21 -!- az0re [~az0re@gateway/tor-sasl/az0re] has joined #bitcoin-core-dev 21:55 -!- espiral [b9edb429@185.237.180.41] has joined #bitcoin-core-dev 21:55 -!- maop [~maop@195.140.213.38] has quit [Remote host closed the connection] 21:59 -!- espiral [b9edb429@185.237.180.41] has quit [Remote host closed the connection] 22:08 -!- gimps [~gimps@185.163.110.116] has joined #bitcoin-core-dev 22:08 -!- openoms [~quassel@91.132.136.76] has quit [Read error: Connection reset by peer] 22:08 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 22:09 -!- openoms [~quassel@91.132.136.76] has joined #bitcoin-core-dev 22:10 -!- IGHOR [~quassel@176.121.4.135] has quit [Quit: http://quassel-irc.org ? ??????????? ?????????. ????-??.] 22:12 -!- IGHOR [~quassel@176.121.4.135] has joined #bitcoin-core-dev 22:51 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 22:54 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection] 22:55 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 22:59 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has quit [Read error: Connection reset by peer] 23:00 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has joined #bitcoin-core-dev 23:00 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 23:06 -!- Kiminuo [~mix@141.98.103.172] has joined #bitcoin-core-dev 23:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:31 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/81d5af42f4db...ffd5e7a8567d 23:31 < bitcoin-git> bitcoin/master 9429a39 practicalswift: Handle rename failure in DumpMempool(...) by using RenameOver(...) return ... 23:31 < bitcoin-git> bitcoin/master ce9dd45 practicalswift: Add [[nodiscard]] to RenameOver(...) 23:31 < bitcoin-git> bitcoin/master ffd5e7a MarcoFalke: Merge #20519: Handle rename failure in DumpMempool(...) by using the Renam... 23:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:31 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20519: Handle rename failure in DumpMempool(...) by using the RenameOver(...) return value. Add [[nodiscard]] to RenameOver(...). (master...renameover-nodiscard) https://github.com/bitcoin/bitcoin/pull/20519 23:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:33 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] --- Log closed Tue Dec 01 00:00:32 2020