--- Log opened Fri Dec 04 00:00:36 2020
00:07 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
00:07 -!- promag [~promag@188.250.84.129] has quit [Remote host closed the connection]
00:08 < wumpus> I'll add an argument to the script instead
00:10 < wumpus> and help
00:14 < sipa>  great
00:23 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.167.167] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
00:33 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 264 seconds]
00:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:39 < bitcoin-git> [bitcoin] laanwj opened pull request #20567: test: Add option to git-subtree-check to do full check, add help (master...2020_12_subtree_check) https://github.com/bitcoin/bitcoin/pull/20567
00:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:41 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
00:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:44 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20568: rpc: Use FeeModes doc helper in estimatesmartfee (master...2012-rpcDocFee) https://github.com/bitcoin/bitcoin/pull/20568
00:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:48 -!- baldur [~baldur@pool-108-30-51-126.nycmny.fios.verizon.net] has quit [Remote host closed the connection]
00:50 -!- baldur [~baldur@pool-108-30-51-126.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
00:51 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.167-167.dynamic.3bb.co.th] has joined #bitcoin-core-dev
00:57 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.167-167.dynamic.3bb.co.th] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
01:01 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.167-167.dynamic.3bb.co.th] has joined #bitcoin-core-dev
01:01 -!- Pavlenex [~Thunderbi@178.220.68.122] has joined #bitcoin-core-dev
01:04 < promag> MarcoFalke: why just those 2 cases in #20566?
01:04 < gribble> https://github.com/bitcoin/bitcoin/issues/20566 | refactor: Use C++17 std::array where possible by MarcoFalke · Pull Request #20566 · bitcoin/bitcoin · GitHub
01:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:08 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e2ae6a2befad...257cf05f9b84
01:08 < bitcoin-git> bitcoin/master d3ef947 Hennadii Stepanov: build: Check that Homebrew's berkeley-db4 package is actually installed
01:08 < bitcoin-git> bitcoin/master 257cf05 Jonas Schnelli: Merge #20563: build: Check that Homebrew's berkeley-db4 package is actuall...
01:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:09 < bitcoin-git> [bitcoin] jonasschnelli merged pull request #20563: build: Check that Homebrew's berkeley-db4 package is actually installed (master...201203-bdb) https://github.com/bitcoin/bitcoin/pull/20563
01:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:09 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.167-167.dynamic.3bb.co.th] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
01:19 < wumpus> oh no did we break appveyor
01:20 < fanquake> 😿
01:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:30 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20569: test: Fix intermittent wallet_multiwallet issue with got_loading_error (master...2012-testWalletInt) https://github.com/bitcoin/bitcoin/pull/20569
01:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:37 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/257cf05f9b84...ca759bc743c9
01:37 < bitcoin-git> bitcoin/master 86e6add Adam Jonas: doc: rename CODEOWNERS to REVIEWERS
01:37 < bitcoin-git> bitcoin/master ca759bc Wladimir J. van der Laan: Merge #20200: doc: rename CODEOWNERS to REVIEWERS
01:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:37 < bitcoin-git> [bitcoin] laanwj merged pull request #20200: doc: rename CODEOWNERS to REVIEWERS (master...102020-fix-codeowners) https://github.com/bitcoin/bitcoin/pull/20200
01:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:41 < MarcoFalke> promag: Only const arrays can make use of C++17 std::array
01:42 < promag> MarcoFalke: I've added a comment there
01:45 < MarcoFalke> is appveyor broken again? Can't be
01:45 < hebasto> current https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/36658306 seems going ok
01:46 < wumpus> but it fails on #20567, which makes no sense as that script isn't run by appveyor
01:46 < gribble> https://github.com/bitcoin/bitcoin/issues/20567 | test: Add option to git-subtree-check to do full check, add help by laanwj · Pull Request #20567 · bitcoin/bitcoin · GitHub
01:47 < MarcoFalke> how is it possible that appveryor breaks our config every 12 days
01:57 < hebasto> could 20567 appveyor failure be spontaneous? re-run?
01:57 < MarcoFalke> hebasto: happening on all other builds as well, starting from now
01:58 < MarcoFalke> hm https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/36658306 did just pass
01:58 < hebasto> ^ exactly
01:59 < wumpus> nice https://github.com/bitcoin/bitcoin/pull/20567#issuecomment-738686199
02:05 -!- kexkey [~kexkey@static-198-54-132-121.cust.tzulo.com] has quit [Ping timeout: 260 seconds]
02:07 < jonasschnelli> fanquake: I think you can un-draft https://github.com/bitcoin/bitcoin/pull/19817
02:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:09 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/ca759bc743c9...dca80ffb45fc
02:09 < bitcoin-git> bitcoin/master fa86156 practicalswift: util: Allow Assert(...) to be used in all contexts
02:09 < bitcoin-git> bitcoin/master fac5efe MarcoFalke: util: Add Assume() identity function
02:09 < bitcoin-git> bitcoin/master faa0585 MarcoFalke: util: Remove probably misleading TODO
02:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:10 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20255: util: Add Assume() identity function (master...2010-assume) https://github.com/bitcoin/bitcoin/pull/20255
02:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
02:37 < wumpus> why is all the addrv2 discussion happening last minute between rcs
02:41 < jnewbery> there were lots of very large features merged just before feature freeze, so it's maybe not surprising that issues are being found now
02:42 < wumpus> my first public draft was apparently june 1, 2018, I posted it to the mailing list feb 18, 2019 (there we no replies at all), I created the PR for the BIPs repository on feb 27, 2019, it was merged jul 23, 2019. Vasild picked up the implementation april this year, and quite quickly had a working implementation (though some other detailed were still ironed out). It was discussed in
02:42 < wumpus> meetings multiple times.
02:42 < wumpus> does any of this feel rushed to you
02:42 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.167-167.dynamic.3bb.co.th] has joined #bitcoin-core-dev
02:43 < wumpus> I am still struggling to find out what I did wrong for even such a relatively straightforward proposal
02:46 -!- Pavlenex [~Thunderbi@178.220.68.122] has quit [Quit: Pavlenex]
02:46 < wumpus> I don't think people are exagerrating when they claim it has become almost imposible to make changes to bitcoin, even non-consensus, maybe this is a good thing! I don't know
02:47 -!- Pavlenex [~Thunderbi@178.220.68.122] has joined #bitcoin-core-dev
02:51 < wumpus> but it's too frustrating for me personally and I don't think I'll be working on BIPs again
02:51 -!- Pavlenex [~Thunderbi@178.220.68.122] has quit [Client Quit]
02:53 < wumpus> it wasn't even controversial in any way
02:54 < vasild> indeed, why was this brought up now? the btcd issue for disconnecting was opened in btcd's repo 20+ days ago
02:55 < wumpus> nor even a new idea! people had been talking about a new address mechanism for years before that, I mainly collected some ideas people already had
02:55 < wumpus> and wrote them down
02:56 < vasild> what about releasing 0.21 as is and _considering_ #20564 for 0.21.1 based on reception of 0.21?
02:56 < gribble> https://github.com/bitcoin/bitcoin/issues/20564 | Dont send sendaddrv2 to pre-70016 software by sipa · Pull Request #20564 · bitcoin/bitcoin · GitHub
03:01 < vasild> wumpus: ^
03:02 < wumpus> vasild: well, it being a temporary workaround it should probably be merged quickly
03:03 < wumpus> sipa's change is very low risk in itself
03:04 < vasild> I agree it is low risk and can be merged quickly, but I dont see it being temporary.
03:04 < wumpus> what people are (rightly) being worried about is the implications of this behavior
03:04 < wumpus> yes
03:07 < vasild> so we have team1 insisting that new messages should come with a protocol bump and impl1 should disconnect when it sees unknown message, team2 thinks it is ok to just ignore unknown messages.
03:08 < vasild> if team1 still insists and team2 follows suit, I don't see team1 changing their mind...
03:09 < wumpus> I don't agree at all that ignoring unknown messages is a DoS vector, if you want to DoS it's better to use a known message type that consumes resources
03:09 < vasild> right
03:09 < wumpus> or that has a large response for a small message
03:10 < wumpus> just flooding a host is uninteresting and possible in so many ways
03:12 < vasild> That is kind of obvious, but apparently not for everybody. My worry with 20564 is that it is going to reaffirm "new messages come with protocol bump"
03:13 < wumpus> and while I do agree the P2P code could use some more anti-DoS measures this is not one
03:13 < wumpus> right
03:18 < wumpus> vasild: maybe, though at least everyone in the PR agrees that it's a one time thing -- this says nothign about signaling to other implementations of course
03:18 < vasild> :)
03:20 -!- Ruben41Heaney [~Ruben41He@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev
03:27 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
03:30 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 246 seconds]
03:32 -!- Ruben41Heaney [~Ruben41He@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 260 seconds]
03:36 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has quit [Remote host closed the connection]
03:37 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has joined #bitcoin-core-dev
03:39 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection]
03:40 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
04:01 < jonasschnelli> <wumpus> my first public draft was apparently june 1, 2018, I posted it to the mailing list feb 18, 2019 (there we no replies at all), I created the PR for the BIPs repository on feb 27, 2019, it was merged jul 23, 2019. Vasild picked up the implementation april this year, and quite quickly had a working implementation (though some other detailed were still ironed out). [...]
04:02 < jonasschnelli> This is my main concern... fixing this quietly.
04:03 < jonasschnelli> It might lead to more reluctant testing and lesser interest to read BIPs more carefully
04:06 < wumpus> ... even less interest and we might as well puglish BIPs directly into the arctic code vault
04:09 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has quit [Read error: Connection reset by peer]
04:09 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has joined #bitcoin-core-dev
04:14 < wumpus> but I agree, the whole BIP process is there to standardize the bitcoin protocols, to coordinate between implementations, that's the point
04:17 < wumpus> well, it also helps coordinate between bitcoin core developers on a more conceptual level than implementation details, but that discussion happened on the BIP repo PRs, not on the mailing list
04:19 < wumpus> e.g. https://github.com/bitcoin/bips/pull/766 had some of the most fruitful discussion
04:20 -!- kinlo [~peter@unaffiliated/kinlo] has quit [Ping timeout: 260 seconds]
04:21 < wumpus> maybe it should have been on the mailing list but I'm not sure most of the people commenting there are even subscribed there, not least because a lot of people consider mailing lists an awful communication medium
04:22 -!- kinlo [~peter@unaffiliated/kinlo] has joined #bitcoin-core-dev
04:25 -!- popey1 [~popey@185.163.110.125] has quit [Remote host closed the connection]
04:30 -!- darkspadez|lapto [~darkspade@217.146.82.202] has joined #bitcoin-core-dev
04:37 < wumpus> it's also perfectly normal to find and fix issues in rcs at the implementation level, what is weird here is that BIP-level conceptual issues are raised now
04:38 < harding> FWIW, addrv2 was covered by the Optech newsletter six times total, three times this year.  https://bitcoinops.org/en/topics/addr-v2/  We also directly covered sdaftuar's March 2020 mailing list post about using new messages for feature negotiation with the call to action, "Daftuar is seeking feedback from maintainers of full nodes about whether the insertion of negotiation messages would cause any problems. If you’re aware of any
04:38 < harding>  problems, please reply to the thread."  http://bitcoinops.org/en/newsletters/2020/03/04/#improving-feature-negotiation-between-full-nodes-at-startup   Later (August), about the new wtxidrelay message, we wrote, "This behavior is already implemented in an unreleased development version of Bitcoin Core. If the maintainers of other implementations, or anyone else, opposes this change, please respond to the mailing list thread."  
04:38 < harding> https://bitcoinops.org/en/newsletters/2020/08/19/#proposed-bip-for-p2p-protocol-feature-negotiation  
04:38 < wumpus> harding: oh wow thanks for weighing in, I even forgot about that
04:42 < jonatack> Yes, it's not like we weren't publishing repeatedly about BIP 155 addrv2 arriving and testing, tweeting about it numerous times, people responding enthusiastically, etc.
04:43 < jonatack> also 2 review club sessions about it, one of which was covered with a monthly Optech feature writeup and quiz
04:44 < jonatack> I guess it's human nature to wait until things are really impending though
04:49 < jonatack> https://bitcoincore.reviews/19031 on 2020-07-15
04:49 < wumpus> it became a little more pressing with the Tor announcement that v2 was deprecated, but even then it was never hurried or rushed imo
04:50 < jonatack> https://bitcoincore.reviews/19845 on 2020-09-16 (the day after tor deprecated v2)
04:51 < jonatack> https://bitcoinops.org/en/topics/addr-v2 -> 3 posts in 2019, 3 posts in 2020 as harding wrote
04:52 < vasild> I opened https://github.com/btcsuite/btcd/pull/1671 to ignore unknown p2p messages in btcd
04:52 < jonatack> vasild: good idea
04:53 < wumpus> yes, good idea
04:57 -!- Pavlenex [~Thunderbi@178.220.68.122] has joined #bitcoin-core-dev
04:58 < vasild> they can probably rewrite the patch in a better way technically, but the point is how it will be received
05:00 < wumpus> right
05:06 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Read error: Connection reset by peer]
05:08 < vasild> btw, the freebsd port upgrade from 0.20.1 to 0.21.0rc2 was rejected by its maintainer, who does not want to track RCs: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251453
05:19 < jonasschnelli> I don't get this... configure.ac sets AC_SUBST(HAVE_WEAK_GETAUXVAL), this means it will not get evaluated in #if defined(HAVE_STRONG_GETAUXVAL) || defined(HAVE_WEAK_GETAUXVAL), right?
05:20 < jonasschnelli> (without setting CPPFLAGS to -DHAVE_WEAK_GETAUXVAL=@HAVE_WEAK_GETAUXVAL@)
05:24 < jonasschnelli> There is no AC_DEFINE for HAVE_WEAK_GETAUXVAL but randomenv.cpp is evaluating it. My guess is that getauxval will never be used in randomenv.cpp.
05:27 < sdaftuar> wumpus: just to share my opinion -- the issue in my mind is that this is a surprise to anyone that we implemented a feature that will cause existing software to disconnect us. i think it shouldn't have been a surprise to us, because every time this topic comes up on the mailing list, there is opposition to the idea of sending unknown messages without a protocol bump (as i rediscovered in august)
05:27 < sdaftuar> i know this BIP was advertised in several places, but the updated draft of it was never sent to the -dev list after the negotiation changed; so i think that's something that would have brought this to light to everyone sooner
05:28 < sdaftuar> at any rate, i'm not trying to advocate that we necessarily change our feature negotiation. i know lots of other people ahve strong views on it, and i don't myself
05:29 < sdaftuar> i just think that we should all be aware that this is an area where people disagree, and our communication should reflect that by making it clear what our software will do
05:29 < sdaftuar> (anyway, i also did basically zero work to help addrv2 make it this far, so thank you to everyone who has worked on it! i hope my words don't come across as criticism of the overall effort)
05:30 -!- darkspadez|lapto [~darkspade@217.146.82.202] has quit [Remote host closed the connection]
05:30 < wumpus> I didn't bother with them ailing list anymore because the first time it got exactly zero engagement
05:31 < sdaftuar> wumpus: yeah i have encountered that myself in the past too :(
05:31 < wumpus> I don't personally expecti t would have been different when sending it a second time but feel free to disagree
05:31 < wumpus> okay :/ yes I can only imagine how difficult it is to make say, consensus changes
05:31 < wumpus> if even seomthing like this...
05:32 < sdaftuar> my thought is that even if people don't engage, by sending it to the mailing list (which has historically been our place of publication of protocol changes) it shifts the burden to others to read, respond, or object
05:34 -!- forcer1 [~forcer@185.204.1.185] has joined #bitcoin-core-dev
05:35 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
05:35 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services]
05:35 -!- vasild_ is now known as vasild
05:36 < MarcoFalke> it is impossible to know how much reading engagement a post has received if the majority of subscribers are readers
05:36 < MarcoFalke> s/if/because/
05:38 < wumpus> sure...
05:40 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
05:40 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
05:40 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has quit [Client Quit]
05:46 < wumpus> it was kind of demotivating for a while in itself though
05:47 < kanzure> what is the mechanism by which ignoring an unknown message causes a DoS problem?
05:47 < sdaftuar> the great question :)
05:49 < wumpus> disconnecting literally generates more traffic than ignoring the message
05:51 < kanzure> MarcoFalke: readers also can't be determined on a github pull request or issue comment.
05:51 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.167-167.dynamic.3bb.co.th] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
05:52 < MarcoFalke> wumpus: I think it was an oversight of the btcd devs
05:52 < MarcoFalke> The first comment says "Thanks for reporting this! The easiest way to resolve this is to permit unknown messages rather than disconnecting as we do now"
05:53 < MarcoFalke> Maybe the btcd devs wouldn't have noticed even if the bip was sent to the mailing list
05:54 < MarcoFalke> it is easy to forget details of how the p2p protocol is implemented (or even how it changed in the past)
05:56 < MarcoFalke> code/bip review can never catch all issues upfront. They come up when implementing or running tests on real networks
05:58 < MarcoFalke> we are the first ones to implement the bip, so no one else had the chance to spot bugs while implementing
06:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:14 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/dca80ffb45fc...9601c0d7aab7
06:14 < bitcoin-git> bitcoin/master e373959 Block Mechanic: Android : Ensure pic build for bdb
06:14 < bitcoin-git> bitcoin/master 9601c0d fanquake: Merge #20565: Android : Ensure pic build for bdb
06:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:14 < bitcoin-git> [bitcoin] fanquake merged pull request #20565: Android : Ensure pic build for bdb (master...fix-bdb-android) https://github.com/bitcoin/bitcoin/pull/20565
06:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:18 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.167-167.dynamic.3bb.co.th] has joined #bitcoin-core-dev
06:18 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 272 seconds]
06:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:21 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9601c0d7aab7...c1604483d34f
06:21 < bitcoin-git> bitcoin/master fac7ab1 MarcoFalke: refactor: Use C++17 std::array where possible
06:21 < bitcoin-git> bitcoin/master c160448 MarcoFalke: Merge #20566: refactor: Use C++17 std::array where possible
06:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:21 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20566: refactor: Use C++17 std::array where possible (master...2012-array) https://github.com/bitcoin/bitcoin/pull/20566
06:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:27 -!- dviola [~diego@unaffiliated/dviola] has quit [Ping timeout: 256 seconds]
06:32 -!- Guyver2_ [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
06:35 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds]
06:46 -!- Pavlenex [~Thunderbi@178.220.68.122] has quit [Quit: Pavlenex]
07:01 -!- dviola [~diego@187.39.20.240] has joined #bitcoin-core-dev
07:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:05 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c1604483d34f...751ffaabad82
07:05 < bitcoin-git> bitcoin/master 773c42b Andrew Chow: tests: Test that a fully signed tx given to signrawtx is unchanged
07:05 < bitcoin-git> bitcoin/master 751ffaa MarcoFalke: Merge #20562: tests: Test that a fully signed tx given to signrawtx is unc...
07:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:06 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20562: tests: Test that a fully signed tx given to signrawtx is unchanged (master...test-signraw-fullysigned) https://github.com/bitcoin/bitcoin/pull/20562
07:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:21 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 256 seconds]
07:31 -!- virtu_ [~virtu@gateway/tor-sasl/virtu] has joined #bitcoin-core-dev
07:32 -!- virtu [~virtu@gateway/tor-sasl/virtu] has quit [Ping timeout: 240 seconds]
07:33 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
07:43 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.167-167.dynamic.3bb.co.th] has quit [Read error: Connection reset by peer]
07:51 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
07:53 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 240 seconds]
07:58 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
07:59 -!- pergaminho [~Cleber@189.26.121.248] has joined #bitcoin-core-dev
08:05 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
08:09 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 272 seconds]
08:09 -!- Provostro [~Pvo@168.62.56.135] has joined #bitcoin-core-dev
08:15 -!- Klox04809318631 [~Klox@c-24-1-131-19.hsd1.il.comcast.net] has joined #bitcoin-core-dev
08:15 < Provostro> Hi I asked about LedgerX and they told me to come here and speak with Kanzure
08:15 < Provostro> I was checking it out, but it seems like a scam.
08:15 < Provostro> the order books are scammy
08:15 < Provostro> kanzure, are you running a scam?
08:16 < Provostro> !tlast
08:16 < gribble> 18856.24
08:17 < luke-jr> Provostro: this channel is for Bitcoin Core development, not for speaking with specific people about other topics
08:17 < Provostro> I'd like to settle matter amicably, thats why i came to you to ask.
08:18 < Provostro> TO please stop running your scam, or pay me 100 btc.
08:18 < luke-jr> Provostro: /query kanzure
08:20 < Provostro> luke-jr, ok i typed that, now what?
08:20 < luke-jr> use that tab to talk privately with him
08:20 < Provostro> i like to do it publicly so the whole world knows who's a scammer
08:20 < luke-jr> well it's not welcome here
08:20 < Provostro> do you hagve an issue with that?
08:21 -!- openoms_ [~quassel@91.132.136.76] has quit [Ping timeout: 256 seconds]
08:23 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
08:24 < Provostro> luke-jr, perhaps you too are a scammer in on the scam?
08:25 -!- mode/#bitcoin-core-dev [+o luke-jr] by ChanServ
08:25 -!- mode/#bitcoin-core-dev [+q Provostro!*@*] by luke-jr
08:25 -!- mode/#bitcoin-core-dev [-o luke-jr] by luke-jr
08:26 -!- promag [~promag@188.250.84.129] has quit [Remote host closed the connection]
08:26 -!- openoms [~quassel@91.132.136.76] has joined #bitcoin-core-dev
08:29 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Read error: Connection reset by peer]
08:29 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
08:30 -!- reallll is now known as belcher
08:50 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
08:50 -!- Pavlenex [~Thunderbi@178.220.68.122] has joined #bitcoin-core-dev
08:52 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 240 seconds]
08:54 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
08:55 -!- jessepos_ [~jp@2600:380:c010:4d5b:595a:9185:2152:9cb8] has joined #bitcoin-core-dev
08:57 -!- jessepos_ [~jp@2600:380:c010:4d5b:595a:9185:2152:9cb8] has quit [Client Quit]
08:57 -!- jessepos_ [~jp@2600:380:c010:4d5b:595a:9185:2152:9cb8] has joined #bitcoin-core-dev
08:57 -!- kexkey [~kexkey@static-198-54-132-173.cust.tzulo.com] has joined #bitcoin-core-dev
08:58 -!- Pavlenex [~Thunderbi@178.220.68.122] has quit [Quit: Pavlenex]
09:00 -!- jesseposner [~jp@2601:643:8980:bfd2:21a3:28f3:d78:7f10] has quit [Ping timeout: 264 seconds]
09:05 -!- proofofkeags [~proofofke@174-16-212-53.hlrn.qwest.net] has joined #bitcoin-core-dev
09:14 -!- kexkey [~kexkey@static-198-54-132-173.cust.tzulo.com] has quit [Quit: Do, don't don't]
09:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:21 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to 0.21: https://github.com/bitcoin/bitcoin/compare/68bd88597a79...aa4b8ebfecdd
09:21 < bitcoin-git> bitcoin/0.21 54e1edc Jon Atack: Allow zero-fee fundrawtxn and walletcreatefundedpsbt calls
09:21 < bitcoin-git> bitcoin/0.21 6e4969f Jon Atack: Update feeRate (BTC/kvB) to fee_rate (sat/vB) in wallet_bumpfee
09:21 < bitcoin-git> bitcoin/0.21 6313362 Jon Atack: Use the correct incremental fee constant in bumpfee help
09:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:23 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20510: [backport] wallet: allow zero-fee fundrawtransaction/walletcreatefundedpsbt and other fixes (0.21...backport-fee_rate-follow-ups) https://github.com/bitcoin/bitcoin/pull/20510
09:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:24 -!- jesseposner [~jp@2601:643:8980:bfd2:888:c250:4010:2f1e] has joined #bitcoin-core-dev
09:26 -!- kljasdfvv [~flack@p200300d46f24de00448d0b09d893fcb7.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!]
09:28 -!- jessepos_ [~jp@2600:380:c010:4d5b:595a:9185:2152:9cb8] has quit [Ping timeout: 240 seconds]
09:34 < andytoshi> i have another CI question .. if i do bash -c 'set -e; source ./ci/lint/06_script.sh ' locally it bombs out with 
09:34 < andytoshi> test/functional/test_runner.py:42: error: Module has no attribute "getwindowsversion"
09:34 < andytoshi> presumably because i am not on windows
09:34 < andytoshi> is there a good way to deal with this
09:35 < sipa> ci/test_run_all.sh:set -o errexit; source ./ci/test/06_script_a.sh
09:35 < sipa> is that it?
09:35 < sipa> set -o errexit?
09:35 < sipa> oh, nvm, this is python
09:42 < andytoshi> yeah it's running the python linter
09:43 < andytoshi> the line i got is `set -o errexit; source ./ci/lint/06_script.sh` which is directly in .travis.yml
09:50 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
10:03 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 264 seconds]
10:06 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
10:17 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 240 seconds]
10:20 < MarcoFalke> andytoshi: You'll need to run the scripts in order, as they "pollute" the environment with variables
10:20 < MarcoFalke> s/in order/in the same bash/
10:20 < MarcoFalke> cp ./ci/test_run_all.sh ./ci/lint_run_all.sh && vim ./ci/lint_run_all.sh
10:21 < MarcoFalke> and then edit the file to run the same stuff that travis.yml runs
10:21 < andytoshi> i don't have apt and stuff
10:21 < andytoshi> i can't run the install scripts
10:21 < MarcoFalke> oh, the linters only run on ubuntu. I don't think they are tested on other operating systems
10:21 < andytoshi> as it happens, they pass on arch with very little modification
10:22 < andytoshi> just that it doesn't really check submodules (this is still a pass :)) and the one python issue which I'll try to PR to add a mypy whitelist to
10:22 < andytoshi> about sys.getwindowsversion not existing
10:26 -!- Pavlenex [~Thunderbi@178.220.68.122] has joined #bitcoin-core-dev
10:26 -!- Pavlenex [~Thunderbi@178.220.68.122] has quit [Client Quit]
10:26 -!- dviola [~diego@187.39.20.240] has left #bitcoin-core-dev []
10:27 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
10:28 -!- jbarcelo [43daf305@67.218.243.5] has joined #bitcoin-core-dev
10:31 -!- openoms [~quassel@91.132.136.76] has quit [Ping timeout: 240 seconds]
10:32 < wumpus> i don't get it, sys.getwindowsversion doesn't exist on ubuntu either
10:32 -!- openoms [~quassel@91.132.136.76] has joined #bitcoin-core-dev
10:33 < MarcoFalke> that part of the code is only executed when "os.name == 'nt'"
10:33 < wumpus> that makes sense
10:33 < andytoshi> yeah, it's just mypy that's complaining
10:34 < andytoshi> it's not an actual problem
10:34 < andytoshi> there are already mypy whitelists near that line related to windows stuff, i think this might've just been overlooked...but i'm surprissed that travis is ok with it
10:35 -!- virtu_ is now known as virtu
10:38 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
10:41 < jonatack> andytoshi: possibly fixed by #20240?
10:41 < gribble> https://github.com/bitcoin/bitcoin/issues/20240 | script: fix linter error in test runner by jonatack · Pull Request #20240 · bitcoin/bitcoin · GitHub
10:43 < andytoshi> jonatack: yeah i think so, though i don't really understand why your fix works
10:43 < jonatack> it fixes error: Module has no attribute "getwindowsversion" for me since several months
10:43 < andytoshi> what is mypy looking at that it thinks getwindowsversion is used by the original code, but not your new code?
10:44 < andytoshi> is it just smart enough to understand `sys.platform` check but not smart enough to understand the `os.name` check?
10:44 < jonatack> idk, i've been waiting for someone else to hit the same issue 
10:45 < jonatack> but it works :shrugs:
10:45 < andytoshi> heh, well, here i am, and my solution was to just add a `# type: ignore` on the offending line
10:46 < sipa> https://github.com/python/mypy/issues/8547
10:46 < sipa> using sys.platform is understood by mypy
10:46 < jonatack> andytoshi: yup, that works too: if os.name != 'nt' or sys.getwindowsversion() >= (10, 0, 14393):  # type: ignore 
10:47 < andytoshi> nice sipa 
10:47 < andytoshi> so jonatack as i commented on your PR, there are a bunch of existing #type : ignore that you can probably drop
10:47 < andytoshi> though we'd need a windows tester to be sure
10:48 -!- twistedline [~twisted@unaffiliated/twistedline] has quit [Ping timeout: 264 seconds]
10:49 -!- twistedline [~twisted@c-68-33-78-41.hsd1.md.comcast.net] has joined #bitcoin-core-dev
10:49 -!- twistedline [~twisted@c-68-33-78-41.hsd1.md.comcast.net] has quit [Changing host]
10:49 -!- twistedline [~twisted@unaffiliated/twistedline] has joined #bitcoin-core-dev
10:51 < jonatack> thanks sipa and andytoshi for the info. if no one looks at it before tomorrow i'll look into it.
10:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:51 < bitcoin-git> [bitcoin] OliverPetrovic opened pull request #20570: Logo added to the readme file. (master...master) https://github.com/bitcoin/bitcoin/pull/20570
10:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:55 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Quit: Gone frying asparagus or my Windows had a BSOD]
11:00 < achow101> wallet meeting?
11:01 -!- twistedline [~twisted@unaffiliated/twistedline] has quit [Remote host closed the connection]
11:01 < achow101> #startmeeting
11:01 < core-meetingbot> Meeting started Fri Dec  4 19:01:29 2020 UTC.  The chair is achow101. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
11:01 < core-meetingbot> Available commands: action commands idea info link nick
11:01 -!- twistedline [~twisted@c-68-33-78-41.hsd1.md.comcast.net] has joined #bitcoin-core-dev
11:01 -!- twistedline [~twisted@c-68-33-78-41.hsd1.md.comcast.net] has quit [Changing host]
11:01 -!- twistedline [~twisted@unaffiliated/twistedline] has joined #bitcoin-core-dev
11:01 < emzy> hi
11:01 < fjahr> hi
11:01 < jonatack> hi
11:01 < achow101> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball ariard digi_james amiti fjahr jeremyrubin emilengler jonatack hebasto
11:01 < achow101>  jb55 kvaciral ariard digi_james amiti fjahr jeremyrubin lightlike emilengler jonatack hebasto jb55 elichai
11:02 < achow101> any topics?
11:03 < achow101> #topic wallet high priority for review
11:03 < core-meetingbot> topic: wallet high priority for review
11:04 < achow101> any wallet prs for high priority to add/remove/discuss?
11:04 < jonatack> pls review minor bugfix #20546
11:04 < gribble> https://github.com/bitcoin/bitcoin/issues/20546 | wallet: check for non-representable CFeeRates (0-0.0009 sat/vB) by jonatack · Pull Request #20546 · bitcoin/bitcoin · GitHub
11:04 -!- twistedline_ [~twisted@c-68-33-78-41.hsd1.md.comcast.net] has joined #bitcoin-core-dev
11:05 < achow101> jonatack: is that for 0.21?
11:05 < jonatack> also found another bug in the send rpc; unlike the other rpcs, the fee rate cannot be passed as a string, only a number. Opening a fix today. 
11:05 < jonatack> achow101: idk if it's a backport-worthy bug, up to others i guess
11:06 < provoostenator> (hi)
11:06 < provoostenator> It's marked experimental
11:06 < provoostenator> So I guess it depends on how annoyhing it is in practice
11:06 -!- twistedline [~twisted@unaffiliated/twistedline] has quit [Ping timeout: 256 seconds]
11:06 < jonatack> achow101: the fix in both cases is simple, the work is mostly writing good test coverage
11:08 < achow101> doesn't seem backport worthy, but no strong opinion on that
11:08 < jonatack> provoostenator: the help says it's an amount (string or number), and the fix is one line, but not up to me 
11:08 < achow101> not the first time we've had a known issues section in the release notes
11:08 < kanzure> andytoshi: you can use import importlib; importlib.find_spec("somethingwindowsonly") and another function i forget.
11:09 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
11:09 < provoostenator> Well we probalby get another RC regardless because of a sendaddrv2 compatiblity issue with btcd
11:10 < jonatack> yess i'll just PR it and let ppl decide
11:10 < luke-jr> need another RC for the already merged stuff anyway
11:11 < jonatack> fjahr: i plan to review #19055 when i'm done with all the fee rate things
11:11 < gribble> https://github.com/bitcoin/bitcoin/issues/19055 | Add MuHash3072 implementation by fjahr · Pull Request #19055 · bitcoin/bitcoin · GitHub
11:11 < jonatack> as you've updated it
11:11 < fjahr> thanks
11:12 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has quit [Ping timeout: 240 seconds]
11:12 -!- jbarcelo [43daf305@67.218.243.5] has quit [Ping timeout: 245 seconds]
11:12 < provoostenator> I'm currently writing a PR for Specter to use descriptor wallets, so hopefully I don't encounter anything shocking on the core side.
11:13 < provoostenator> So far it works really well
11:13 < Murch> Hi
11:13 < provoostenator> It's annoying that getwalletinfo returns 3000 for keypool size
11:13 < achow101> it's not wrong though
11:13 < provoostenator> Although it's true, 
11:14 < provoostenator> No, but it would be nice get 1000 somewhere as well
11:14 < provoostenator> Because I don't want to rely on having 3 types of addresses
11:14 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has joined #bitcoin-core-dev
11:14 < provoostenator> Need that number in order to pick a sane "range" param for importdescriptors
11:14 < provoostenator> Which doesn't have a default afaik
11:14 < achow101> just only support one address type then
11:15 < luke-jr> yeah, descriptor wallets don't need to have all the other types do they?
11:15 < provoostenator> That's not the issue.  It's just that you can't know -keypoolsize 
11:15 < provoostenator> Unless you parse bitcoin.conf
11:16 < achow101> since each spkm reports its own keypoolsize, getwalletinfo could be more granular there
11:16 < provoostenator> The range param for importdescriptors isn't super useful anyway
11:16 < achow101> just some output stuff, not particularly hard
11:17 < provoostenator> Would be nice if the range param defaulted to -keypoolsize so you can omit it.
11:17 < achow101> i think it does?
11:20 < achow101> anything else?
11:21 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has joined #bitcoin-core-dev
11:23 < achow101> #endmeeting
11:23 < core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
11:23 < core-meetingbot> Meeting ended Fri Dec  4 19:23:24 2020 UTC.  
11:23 < core-meetingbot> Minutes:        https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2020/bitcoin-core-dev.2020-12-04-19.01.moin.txt
11:23  * luke-jr peers at topic being in there
11:23 < jonatack> provoostenator: they should call it spectre like in the old bond films
11:24 < luke-jr> reminder that "Spectre" is a current-day series of vulnerabilities..
11:24 < achow101> depends on whether you're british or american
11:25 -!- twistedline_ [~twisted@c-68-33-78-41.hsd1.md.comcast.net] has quit [Ping timeout: 256 seconds]
11:25 < fjahr> the latest one was also also called spectre and it wasn't that great sooo... :)
11:30 < provoostenator> achow101: ah you're right, range can be ommited.
11:37 -!- openoms [~quassel@91.132.136.76] has quit [Ping timeout: 256 seconds]
11:38 -!- openoms [~quassel@91.132.136.76] has joined #bitcoin-core-dev
11:40 < sipa> phantomcircuit or anyone else: you still have a large number of testnet coins?
11:41 < luke-jr> sipa: hi
11:41 < luke-jr> i herd u want TNBTC?
11:42 < luke-jr> how many & address?
11:42 < sipa> someone from bitgo is asking for some amount to test with
11:42 < sipa> ok, getting address
11:44 < phantomcircuit> sipa, i gave mine to matt
11:44 < phantomcircuit> either he gave them away or he's the testnet king
11:44 < sipa> ha
11:45 < gwillen> last christmas, I gave you my testnet coins, but the very next day, you gave them away
11:46 < luke-jr> hmm, testnet isn't letting me run it :x
11:46 < sipa> well, if anyone has some: 2N9KJZrryXJh26jqpX7cxHM7facYcSZrEFp
11:46 < achow101> sipa: how many?
11:46 < luke-jr> gwillen: are you implying bluematt isn't special?
11:46 < sipa> achow101: how many you have? :)
11:47 < achow101> several thousand
11:47 < gwillen> luke-jr: I would never
11:48 < sipa> gwillen: ok, you get a pass, it's december alright
11:48 < achow101> sipa: 6eb56f123eb1753fe6d74f5ce177c51eb99687afb34d70f72f598a1c85835bec
11:49 < sipa> achow101: thanks!
11:49 < gwillen> sipa: christmas music is allowed at any point after American Thanksgiving, I didn't make the rules
11:49 < sipa> gwillen: and i haven't heard any christmas songs yet this year for some reason
11:49 < luke-jr> gwillen: that's not the rules
11:49 < luke-jr> gwillen: Christmas music may begin on Christmas Day
11:50 < gwillen> you've failed to account for the effects of Christmas Creep, at this point you're lucky if it doesn't start right after Halloween
11:50 < achow101> luke-jr: begin or only on?
11:50 < luke-jr> achow101: well, Christmas is 40 days so
11:51 < luke-jr> Dec 25-Feb 2
11:51 < gwillen> actually I'm surprised you wouldn't allow for Christmas music starting during Advent
11:51 < luke-jr> Advent is supposed to be penetential
11:51 < gwillen> exactly, that's when the suffering should begin
11:51 < luke-jr> lol
11:54 -!- Provostro [~Pvo@168.62.56.135] has left #bitcoin-core-dev []
12:34 -!- pergaminho [~Cleber@189.26.121.248] has quit [Quit: Saindo]
12:35 -!- twistedline [~twisted@c-73-200-216-219.hsd1.dc.comcast.net] has joined #bitcoin-core-dev
12:35 -!- twistedline [~twisted@c-73-200-216-219.hsd1.dc.comcast.net] has quit [Changing host]
12:35 -!- twistedline [~twisted@unaffiliated/twistedline] has joined #bitcoin-core-dev
12:43 -!- twistedline [~twisted@unaffiliated/twistedline] has quit [Ping timeout: 256 seconds]
12:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:46 < bitcoin-git> [bitcoin] hebasto opened pull request #20571: refactor: Use deduction guide for std::array<uint8_t, N> (master...201204-u8) https://github.com/bitcoin/bitcoin/pull/20571
12:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:48 -!- twistedline [~twisted@unaffiliated/twistedline] has joined #bitcoin-core-dev
12:49 -!- davterra [~davterra@static-198-54-131-92.cust.tzulo.com] has quit [Quit: Leaving]
12:57 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds]
13:03 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 265 seconds]
13:13 -!- forcer1 [~forcer@185.204.1.185] has quit [Remote host closed the connection]
13:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:20 < bitcoin-git> [bitcoin] hebasto opened pull request #20572: ci: Adjust Cirrus CI task names (follow up) (master...201204-cirrus) https://github.com/bitcoin/bitcoin/pull/20572
13:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:20 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
13:32 -!- Harekiet1 [~Harekiet@84.39.117.57] has joined #bitcoin-core-dev
13:35 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
13:36 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 272 seconds]
13:38 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
13:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:52 < bitcoin-git> [bitcoin] jonatack opened pull request #20573: wallet, bugfix: allow send with string fee_rate amounts (master...send-allow-feerates-as-strings) https://github.com/bitcoin/bitcoin/pull/20573
13:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:59 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
14:18 -!- dviola [~diego@unaffiliated/dviola] has quit [Ping timeout: 272 seconds]
14:28 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev
14:29 -!- filchef [~filchef@212.104.97.177] has quit [Client Quit]
14:31 -!- dviola [~diego@187.39.20.240] has joined #bitcoin-core-dev
14:33 -!- miketwenty1 [~miketwent@ec2-18-211-157-212.compute-1.amazonaws.com] has quit [Ping timeout: 272 seconds]
14:34 -!- dviola [~diego@187.39.20.240] has left #bitcoin-core-dev []
14:36 -!- Guyver2_ [~Guyver@guyver2.xs4all.nl] has quit [Remote host closed the connection]
14:52 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
15:00 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
15:03 -!- twistedline_ [~twisted@c-73-200-216-219.hsd1.dc.comcast.net] has joined #bitcoin-core-dev
15:06 -!- twistedline [~twisted@unaffiliated/twistedline] has quit [Ping timeout: 260 seconds]
15:21 -!- twistedline [~twisted@c-73-200-216-219.hsd1.dc.comcast.net] has joined #bitcoin-core-dev
15:21 -!- twistedline [~twisted@c-73-200-216-219.hsd1.dc.comcast.net] has quit [Changing host]
15:21 -!- twistedline [~twisted@unaffiliated/twistedline] has joined #bitcoin-core-dev
15:23 -!- twistedline_ [~twisted@c-73-200-216-219.hsd1.dc.comcast.net] has quit [Ping timeout: 240 seconds]
15:27 -!- miketwenty1 [~miketwent@ec2-52-72-204-35.compute-1.amazonaws.com] has joined #bitcoin-core-dev
15:28 -!- miketwenty1 [~miketwent@ec2-52-72-204-35.compute-1.amazonaws.com] has quit [Remote host closed the connection]
15:29 -!- miketwenty1 [~miketwent@ec2-18-211-157-212.compute-1.amazonaws.com] has joined #bitcoin-core-dev
15:44 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
15:49 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
15:49 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
15:57 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds]
16:01 -!- twistedline [~twisted@unaffiliated/twistedline] has quit [Read error: Connection reset by peer]
16:02 -!- twistedline [~twisted@c-73-200-216-219.hsd1.dc.comcast.net] has joined #bitcoin-core-dev
16:02 -!- twistedline [~twisted@c-73-200-216-219.hsd1.dc.comcast.net] has quit [Changing host]
16:02 -!- twistedline [~twisted@unaffiliated/twistedline] has joined #bitcoin-core-dev
16:10 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev
16:20 -!- az0re [~az0re@gateway/tor-sasl/az0re] has quit [Ping timeout: 240 seconds]
16:26 -!- az0re [~az0re@gateway/tor-sasl/az0re] has joined #bitcoin-core-dev
16:34 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.167.167] has joined #bitcoin-core-dev
16:40 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has quit [Read error: Connection reset by peer]
16:40 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has joined #bitcoin-core-dev
16:41 -!- davterra [~davterra@static-198-54-131-156.cust.tzulo.com] has joined #bitcoin-core-dev
16:56 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 246 seconds]
17:01 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
17:10 < fanquake> wumpus / sipa: can you block allunderone from the devwiki
17:19 -!- tylerchambers [~tylercham@155.138.202.203] has quit [Ping timeout: 240 seconds]
17:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
17:26 < bitcoin-git> [bitcoin] fanquake closed pull request #20570: Logo added to the readme file. (master...master) https://github.com/bitcoin/bitcoin/pull/20570
17:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
17:35 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
17:35 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services]
17:35 -!- vasild_ is now known as vasild
18:08 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
18:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
18:10 < bitcoin-git> [bitcoin] SoiledCold5 opened pull request #20574: Update README.md (master...patch-2) https://github.com/bitcoin/bitcoin/pull/20574
18:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
18:10 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 265 seconds]
18:30 -!- miketwenty1 [~miketwent@ec2-18-211-157-212.compute-1.amazonaws.com] has quit [Remote host closed the connection]
18:41 -!- tylerchambers [~tylercham@155.138.202.203] has joined #bitcoin-core-dev
18:49 -!- davterra [~davterra@static-198-54-131-156.cust.tzulo.com] has quit [Ping timeout: 240 seconds]
19:11 -!- miketwenty1 [~miketwent@ec2-18-211-157-212.compute-1.amazonaws.com] has joined #bitcoin-core-dev
19:13 -!- Netsplit *.net <-> *.split quits: _flow_, midnight, niska`
19:18 -!- Netsplit over, joins: midnight, _flow_, niska`
19:26 -!- midnight [~midnight@unaffiliated/midnightmagic] has quit [Max SendQ exceeded]
19:28 -!- midnight [~midnight@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
19:33 -!- jessepos_ [~jp@2601:643:8980:bfd2:d437:5b18:4154:8907] has joined #bitcoin-core-dev
19:36 -!- jesseposner [~jp@2601:643:8980:bfd2:888:c250:4010:2f1e] has quit [Ping timeout: 264 seconds]
19:41 -!- jesseposner [~jp@2601:643:8980:bfd2:919a:9c07:5dbc:913c] has joined #bitcoin-core-dev
19:45 -!- jessepos_ [~jp@2601:643:8980:bfd2:d437:5b18:4154:8907] has quit [Ping timeout: 260 seconds]
19:56 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.167.167] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
20:08 -!- tylerchambers [~tylercham@155.138.202.203] has quit [Ping timeout: 246 seconds]
20:13 -!- miketwenty1 [~miketwent@ec2-18-211-157-212.compute-1.amazonaws.com] has quit [Remote host closed the connection]
20:22 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 246 seconds]
20:25 -!- miketwenty1 [~miketwent@ec2-52-72-204-35.compute-1.amazonaws.com] has joined #bitcoin-core-dev
20:25 -!- tylerchambers [~tylercham@155.138.202.203] has joined #bitcoin-core-dev
20:40 -!- tylerchambers [~tylercham@155.138.202.203] has quit [Ping timeout: 265 seconds]
20:49 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection]
21:08 -!- flag [~flag@net-93-66-71-105.cust.vodafonedsl.it] has quit [Quit: leaving]
21:14 -!- flag [~flag@net-93-66-71-105.cust.vodafonedsl.it] has joined #bitcoin-core-dev
21:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
21:27 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/751ffaabad82...f35e4d906fee
21:27 < bitcoin-git> bitcoin/master 667b6a2 Hennadii Stepanov: ci: Adjust Cirrus CI task names (follow up)
21:27 < bitcoin-git> bitcoin/master f35e4d9 MarcoFalke: Merge #20572: ci: Adjust Cirrus CI task names (follow up)
21:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
21:37 -!- jarolrod [uid475272@gateway/web/irccloud.com/x-rlfzxaphdcoussrw] has quit [Quit: Connection closed for inactivity]
22:03 -!- miketwenty1 [~miketwent@ec2-52-72-204-35.compute-1.amazonaws.com] has quit [Remote host closed the connection]
22:04 -!- Harekiet1 [~Harekiet@84.39.117.57] has quit [Remote host closed the connection]
22:05 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev
22:05 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Remote host closed the connection]
22:06 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev
22:06 -!- miketwen_ [~miketwent@ec2-52-72-204-35.compute-1.amazonaws.com] has joined #bitcoin-core-dev
22:10 -!- miketwen_ [~miketwent@ec2-52-72-204-35.compute-1.amazonaws.com] has quit [Remote host closed the connection]
22:10 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 265 seconds]
22:11 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev
22:15 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 265 seconds]
22:19 -!- miketwen_ [~miketwent@ec2-52-72-204-35.compute-1.amazonaws.com] has joined #bitcoin-core-dev
22:42 -!- Seran1 [~Seran@185.103.96.147] has joined #bitcoin-core-dev
22:54 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
22:57 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds]
23:07 -!- tylerchambers [~tylercham@155.138.202.203] has joined #bitcoin-core-dev
23:08 -!- miketwen_ [~miketwent@ec2-52-72-204-35.compute-1.amazonaws.com] has quit [Remote host closed the connection]
23:08 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev
23:13 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 256 seconds]
23:15 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 260 seconds]
23:34 -!- Arvidt [~Arvidt@p4fde7d96.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
23:37 < Arvidt> Since I upgraded from 0.20.1-x86_64-linux-gnu to 0.21.0rc2-x86_64-linux-gnu I do not get any inbound connections anymore.
23:37 < Arvidt> Is this a known issue?
23:38 < Arvidt> (bitcoin.conf: server=1 onlynet=onion onion=127.0.0.1:9050 listen=1)
23:39 < Arvidt> Did not find a bug in github regarding this.
23:40 < sipa> Arvidt: are you relying on the tor autoconfiguration?
23:41 < sipa> in that case, 0.21 likely upgraded to a v3 onion service, and there are currently very few nodes capable of connecting to those
23:50 -!- Pavlenex [~Thunderbi@178.220.68.122] has joined #bitcoin-core-dev
23:59 < Arvidt> Thanks, Sipa. Yes, I have Tor cookie auth, and IIRC so Bitcoind can automatically announce it's Onion Service (legacy name hidden service). I see in bitcoind log:
--- Log closed Sat Dec 05 00:00:36 2020