--- Log opened Sat Dec 05 00:00:36 2020
00:00 < Arvidt> tor: Got service ID s5om67..., advertising service s5om67....onion:8333
00:00 < Arvidt> AddLocal(s5om67....onion:8333,4)
00:01 < Arvidt> The Onion Service has a v3 looong address
00:04 < wumpus> fanquake: done
00:05 < wumpus> yes, it will take a while to bootstrap torv3 use
00:06 < wumpus> and it's currently hard to 'meet' other torv3 nodes especially if your peer doesn't know any torv3 nodes yet
00:07 -!- Pavlenex [~Thunderbi@178.220.68.122] has quit [Quit: Pavlenex]
00:08 < wumpus> PMed you a torv3 node
00:22 -!- eugene-ff [~eugene_ff@2604:2000:1383:472b:310b:6ed3:ba5c:483f] has joined #bitcoin-core-dev
00:28 -!- eugene-ff [~eugene_ff@2604:2000:1383:472b:310b:6ed3:ba5c:483f] has quit [Remote host closed the connection]
00:29 -!- eugene-ff [~eugene_ff@2604:2000:1383:472b:310b:6ed3:ba5c:483f] has joined #bitcoin-core-dev
00:33 -!- eugene-ff [~eugene_ff@2604:2000:1383:472b:310b:6ed3:ba5c:483f] has quit [Ping timeout: 244 seconds]
00:38 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev
00:42 -!- Seran1 [~Seran@185.103.96.147] has quit [Remote host closed the connection]
00:42 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 256 seconds]
00:48 < wumpus> is there some new scheme that pays out per commit or something? what's with the one line changes to README.md
00:50 -!- xchg [~xchg@185.204.1.185] has joined #bitcoin-core-dev
01:02 < gwillen> at one point there was a free t-shirt https://www.theregister.com/2020/10/01/digitalocean_hacktoberfest_pull_request_spam/
01:02 < gwillen> that was awhile ago but I can imagine there are smaller things in the same genre
01:09 < Arvidt> Thanks Wumpus, will see how v3 gossip will evolve. Fascinating to observe.
01:09 < wumpus> Arvidt: it's a good test :)
01:09 < Arvidt> Ah, found the v3 inbound issue report here: https://github.com/bitcoin/bitcoin/issues/20555
01:10 < wumpus> gwillen: the infamous hacktoberfest t-shirt
01:12 < gwillen> yeah
01:18 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.167-167.dynamic.3bb.co.th] has joined #bitcoin-core-dev
01:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:44 < bitcoin-git> [bitcoin] laanwj closed pull request #20574: Update README.md (master...patch-2) https://github.com/bitcoin/bitcoin/pull/20574
01:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:44 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
01:44 -!- Talkless [~Talkless@mail.dargis.net] has quit [Client Quit]
01:53 < jonatack> Arvidt: just PMed you as well
01:54 < jonatack> Arvidt: yup, i have had no inbounds on my tor v3 service since a month or so, except for hebasto in both my inbounds and outbounds as we addnode each other
01:55 -!- face [~face@207.154.206.50] has joined #bitcoin-core-dev
02:13 < wumpus> bah, would it maybe make sense to add some default v3 bootstrap peers, at least temporarily, to bootstrap this, otherwise 0.21+ needs to be widely adopted before peers with addrv2 gossipping find each other randomly at meast moderately often
02:13 < wumpus> maybe this works out organically i don't know
02:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:18 < bitcoin-git> [bitcoin] hebasto reopened pull request #19832: p2p: Put disconnecting logs into BCLog::NET category (master...200829-log) https://github.com/bitcoin/bitcoin/pull/19832
02:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:21 < jonatack> sigh
02:27 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
02:33 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.167-167.dynamic.3bb.co.th] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
02:50 -!- Arvidt [~Arvidt@p4fde7d96.dip0.t-ipconnect.de] has quit [Quit: leaving]
02:50 < jonatack> wumpus: it might make sense, temporarily
02:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:54 < bitcoin-git> [bitcoin] practicalswift opened pull request #20575: Do not run functions with necessary side-effects in assert() (master...side-effect-free-assert) https://github.com/bitcoin/bitcoin/pull/20575
02:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:01 -!- eugene-ff [~eugene_ff@2604:2000:1383:472b:1d62:2833:da71:d6db] has joined #bitcoin-core-dev
03:06 -!- eugene-ff [~eugene_ff@2604:2000:1383:472b:1d62:2833:da71:d6db] has quit [Ping timeout: 264 seconds]
03:11 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a985:6507:1c52:205b:26de] has joined #bitcoin-core-dev
03:15 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
03:16 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
03:16 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a985:6507:1c52:205b:26de] has quit [Ping timeout: 264 seconds]
03:18 -!- Randy27Gottlieb [~Randy27Go@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev
03:22 -!- Randy27Gottlieb [~Randy27Go@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 240 seconds]
03:34 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:d01b:63a8:de53:5983] has joined #bitcoin-core-dev
03:45 -!- Pavlenex [~Thunderbi@178.220.68.122] has joined #bitcoin-core-dev
03:56 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:d01b:63a8:de53:5983] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
03:57 -!- wallet42___ [sid154231@gateway/web/irccloud.com/x-nsfflmahewctnkwz] has joined #bitcoin-core-dev
03:57 -!- wallet42__ [sid154231@gateway/web/irccloud.com/x-qugxujcnhfaqwroa] has quit [Ping timeout: 272 seconds]
03:58 -!- midnight [~midnight@unaffiliated/midnightmagic] has quit [Ping timeout: 272 seconds]
03:59 -!- midnight [~midnight@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
04:04 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
04:11 -!- jonatack [~jon@134.19.179.187] has quit [Ping timeout: 264 seconds]
04:15 -!- jonatack [~jon@88.124.242.136] has joined #bitcoin-core-dev
04:26 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
04:26 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 256 seconds]
04:27 -!- jonatack [~jon@213.152.161.149] has joined #bitcoin-core-dev
04:27 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds]
04:33 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:d01b:63a8:de53:5983] has joined #bitcoin-core-dev
04:54 -!- dviola [~diego@unaffiliated/dviola] has quit [Ping timeout: 272 seconds]
04:58 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
05:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:01 < bitcoin-git> [bitcoin] theStack opened pull request #20577: doc: libconsensus: add missing error code description, fix NBitcoin link (master...201212-doc-libbitcoinconsensus-fixes) https://github.com/bitcoin/bitcoin/pull/20577
05:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:03 < bitcoin-git> [bitcoin] theStack closed pull request #20537: refactor: replace manual Satoshis-to-BTC conversions with FormatMoney() (master...20201129-use-formatmoney) https://github.com/bitcoin/bitcoin/pull/20537
05:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:25 < hebasto> mind blocking Humblya in git? looks like a spam.
05:35 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
05:35 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services]
05:35 -!- vasild_ is now known as vasild
05:42 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev
05:42 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
05:42 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
06:06 -!- Nordom [~nordom@c-563fe353.039-3-64736c10.bbcust.telenor.se] has joined #bitcoin-core-dev
06:28 -!- shesek [~shesek@164.90.217.137] has joined #bitcoin-core-dev
06:28 -!- shesek [~shesek@164.90.217.137] has quit [Changing host]
06:28 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
06:29 -!- davterra [~davterra@static-198-54-131-124.cust.tzulo.com] has joined #bitcoin-core-dev
06:31 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev
06:40 -!- eugene-ff [~eugene_ff@2604:2000:1383:472b:c5ad:8ebd:9c9f:9ead] has joined #bitcoin-core-dev
06:55 < wumpus> done
07:00 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:d01b:63a8:de53:5983] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
07:07 -!- jarolrod [uid475272@gateway/web/irccloud.com/x-gboiwuijghoxtmus] has joined #bitcoin-core-dev
07:10 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:d01b:63a8:de53:5983] has joined #bitcoin-core-dev
07:11 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Quit: ZNC 1.7.5 - https://znc.in]
07:12 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:d01b:63a8:de53:5983] has quit [Client Quit]
07:19 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Remote host closed the connection]
07:20 -!- miketwenty1 [~miketwent@ec2-18-211-157-212.compute-1.amazonaws.com] has joined #bitcoin-core-dev
07:23 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:d01b:63a8:de53:5983] has joined #bitcoin-core-dev
07:34 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:d01b:63a8:de53:5983] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
07:37 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th] has joined #bitcoin-core-dev
07:42 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
07:54 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
08:08 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 246 seconds]
08:09 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
08:30 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 246 seconds]
08:31 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
09:17 -!- jarolrod [uid475272@gateway/web/irccloud.com/x-gboiwuijghoxtmus] has quit [Quit: Connection closed for inactivity]
09:31 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 265 seconds]
09:33 -!- Pavlenex [~Thunderbi@178.220.68.122] has quit [Quit: Pavlenex]
09:44 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
09:46 -!- miketwenty1 [~miketwent@ec2-18-211-157-212.compute-1.amazonaws.com] has quit [Remote host closed the connection]
09:46 -!- miketwenty1 [~miketwent@ec2-52-72-204-35.compute-1.amazonaws.com] has joined #bitcoin-core-dev
09:56 -!- miketwenty1 [~miketwent@ec2-52-72-204-35.compute-1.amazonaws.com] has quit [Remote host closed the connection]
10:10 -!- miketwen_ [~miketwent@ec2-18-211-157-212.compute-1.amazonaws.com] has joined #bitcoin-core-dev
10:29 -!- miketwen_ [~miketwent@ec2-18-211-157-212.compute-1.amazonaws.com] has quit [Remote host closed the connection]
10:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:41 < bitcoin-git> [bitcoin] vova557 opened pull request #20578: Добавить лицензию (master...patch-9) https://github.com/bitcoin/bitcoin/pull/20578
10:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:45 -!- miketwenty1 [~miketwent@ec2-18-211-157-212.compute-1.amazonaws.com] has joined #bitcoin-core-dev
10:47 -!- miketwenty1 [~miketwent@ec2-18-211-157-212.compute-1.amazonaws.com] has quit [Remote host closed the connection]
10:48 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev
10:52 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 260 seconds]
10:54 -!- miketwenty1 [~miketwent@ec2-52-72-204-35.compute-1.amazonaws.com] has joined #bitcoin-core-dev
10:55 -!- miketwenty1 [~miketwent@ec2-52-72-204-35.compute-1.amazonaws.com] has quit [Remote host closed the connection]
11:05 -!- prusnak [sid403625@gateway/web/irccloud.com/x-lfcyzjgfjcjtebkp] has quit [Read error: Connection reset by peer]
11:05 -!- prusnak [sid403625@gateway/web/irccloud.com/x-kpjuhwlaoukjuvhi] has joined #bitcoin-core-dev
11:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:10 < bitcoin-git> [bitcoin] promag opened pull request #20580: wallet: Some cleanups around LegacyScriptPubKeyMan (master...2020-12-wallet-legacy) https://github.com/bitcoin/bitcoin/pull/20580
11:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:16 -!- jarolrod [uid475272@gateway/web/irccloud.com/x-jyjckbpmmlrppool] has joined #bitcoin-core-dev
11:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:31 < bitcoin-git> [bitcoin] sipa closed pull request #20578: Добавить лицензию (master...patch-9) https://github.com/bitcoin/bitcoin/pull/20578
11:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:37 < promag> hebasto: what's the motivation for #20205?
11:37 < gribble> https://github.com/bitcoin/bitcoin/issues/20205 | wallet: Properly support a wallet id by achow101 · Pull Request #20205 · bitcoin/bitcoin · GitHub
11:42 -!- openoms [~quassel@91.132.136.76] has quit [Ping timeout: 240 seconds]
11:43 -!- Emcy_ [~Emcy@unaffiliated/emcy] has quit [Read error: Connection reset by peer]
11:46 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th] has joined #bitcoin-core-dev
11:49 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
11:49 -!- openoms [~quassel@91.132.136.76] has joined #bitcoin-core-dev
11:51 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th] has quit [Ping timeout: 256 seconds]
11:52 -!- miketwenty1 [~miketwent@ec2-52-72-204-35.compute-1.amazonaws.com] has joined #bitcoin-core-dev
12:00 -!- TallTim [~TallTim@184-83-248-206-dynamic.midco.net] has quit [Ping timeout: 240 seconds]
12:03 -!- TallTim [~TallTim@184-83-248-206-dynamic.midco.net] has joined #bitcoin-core-dev
12:04 -!- miketwenty1 [~miketwent@ec2-52-72-204-35.compute-1.amazonaws.com] has quit [Remote host closed the connection]
12:05 -!- miketwenty1 [~miketwent@ec2-18-211-157-212.compute-1.amazonaws.com] has joined #bitcoin-core-dev
12:15 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
12:17 -!- lightningbot [~supybot@2400:8901::f03c:91ff:febb:bbc1] has quit [Disconnected by services]
12:18 -!- miketwenty1 [~miketwent@ec2-18-211-157-212.compute-1.amazonaws.com] has quit [Remote host closed the connection]
12:19 -!- lightningbot [~supybot@2400:8901::f03c:91ff:febb:bbc1] has joined #bitcoin-core-dev
12:21 -!- corollari__ [sid405633@gateway/web/irccloud.com/x-ewpibfnedfuyrtis] has quit [Quit: Connection closed for inactivity]
12:21 -!- glozow [uid453516@gateway/web/irccloud.com/x-schtdhedlhiejllo] has joined #bitcoin-core-dev
12:30 < luke-jr> promag: wrong PR?
12:32 < luke-jr> promag: unique wallet IDs allow warning the user if you try to open two copies of the same wallet, maintaining prune locks for them even when unloaded, etc
12:36 -!- sirpesto [sirpestoma@gateway/shell/matrix.org/x-pswhzwdostxtpaos] has quit [Ping timeout: 246 seconds]
12:36 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-krvymnjpngwletgk] has quit [Ping timeout: 246 seconds]
12:36 -!- rCapital-Surpris [crtn32002m@gateway/shell/matrix.org/x-zsrqemrmfzdyubjl] has quit [Ping timeout: 246 seconds]
12:36 -!- hizkifw [hizkifwmat@gateway/shell/matrix.org/x-gpsrokdzadhwpocp] has quit [Ping timeout: 246 seconds]
12:36 -!- robert_spigler [robertspig@gateway/shell/matrix.org/x-vacanapkkzgpicki] has quit [Ping timeout: 246 seconds]
12:37 -!- awesome_doge [awesome-do@gateway/shell/matrix.org/x-qsnxxgllrqyjdxvn] has quit [Ping timeout: 264 seconds]
12:38 -!- mrostecki[m] [mrosteckim@gateway/shell/matrix.org/x-umppgnaioxfkrbey] has quit [Ping timeout: 268 seconds]
12:57 -!- hizkifw [hizkifwmat@gateway/shell/matrix.org/x-samcakpcewyopehm] has joined #bitcoin-core-dev
12:59 -!- robert_spigler [robertspig@gateway/shell/matrix.org/x-wikobeixfdltefwb] has joined #bitcoin-core-dev
13:01 -!- rCapital-Surpris [crtn32002m@gateway/shell/matrix.org/x-acloonqktcalgnlj] has joined #bitcoin-core-dev
13:04 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-kuzwqzbpfmsdlpxj] has joined #bitcoin-core-dev
13:10 -!- awesome_doge [awesome-do@gateway/shell/matrix.org/x-ppzyeoqssdnptngl] has joined #bitcoin-core-dev
13:11 -!- sirpesto [sirpestoma@gateway/shell/matrix.org/x-xxyfhuktzbmhzksy] has joined #bitcoin-core-dev
13:25 -!- miketwenty1 [~miketwent@ec2-52-72-204-35.compute-1.amazonaws.com] has joined #bitcoin-core-dev
13:25 -!- miketwenty1 [~miketwent@ec2-52-72-204-35.compute-1.amazonaws.com] has quit [Remote host closed the connection]
13:31 < promag> luke-jr: right, I mean #20243
13:31 < gribble> https://github.com/bitcoin/bitcoin/issues/20243 | rpc, wallet: Expose wallet id in getwalletinfo RPC output by hebasto · Pull Request #20243 · bitcoin/bitcoin · GitHub
13:34 < promag> seems a bit premature, thats all
13:41 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Quit: Leaving]
13:41 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
13:44 < luke-jr> I guess it makes sense to expose it
13:45 -!- az0re [~az0re@gateway/tor-sasl/az0re] has quit [Ping timeout: 240 seconds]
14:20 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:23 < pinheadmz> at the meeting this week there was talk about btcd and libbitcoin disconnecting on unkown p2p message types. i think bcoin does this as well, but that behavior could be changed. does Bitcoin Core have another way to mitigate spam attacks with unknown messages? or is it not a concern because they are simply not processed?
14:26 < sipa> pinheadmz: unknown messages are never worse than spamming with known messages
14:27 < pinheadmz> makes sense, no computational cost
14:27 < pinheadmz> but theres no kind of overall bandwidth rate limit for peers ?
14:28 < sipa> no, but there could be
14:29 < sipa> not a hard limit, but we could always deprioritize processing messages from the most demanding peers when resources are low
14:31 < pinheadmz> and whats the drawback to tying addrv2 to a protocol version bump ?
14:32 < sipa> pinheadmz: central coordination on what every protocol version means
14:33 < sipa> it's so bizarre to me
14:33 < pinheadmz> i see yeah reading up the chatter on bip155 PR as well...
14:33 < sipa> it seems everyone working on bitcoin core feels this is weird and makes things harder for alternative implementations
14:33 < sipa> and all alternative implementations are confused why we do this!
14:34 < pinheadmz> weird / bizarre = using central coordination on protocol versions ?
14:34 < sipa> bitcoin core shouldn't be decided what messages are allowed on the network
14:34 < pinheadmz> aha i see
14:34 < sipa> *deciding
14:36 < sipa> (also bitcoin core itself has always ignored unknown messages
14:36 < pinheadmz> yeah i noticed that, i dunno why bcoin didnt implement the same way
14:37 < pinheadmz> its not a ban, but its an assert(false) in message handler which i believe disconencts the peer
14:37 < sipa> i can see why someone would think that it feels "wrong" to allow unknown messages
14:37 < sipa> but there really is no downside
14:37 < pinheadmz> re: coordination though - BIPs are good places to pick service bits, etc at the community level - thats not really "bitcoin core deciding:
14:38 < pinheadmz> still i agree ignoring unkown messages is the simplest way to make the protocl extensible
14:39 < sipa> pinheadmz: service oks, those require coordination
14:40 < sipa> but protocol versions are worse, as they're sequential
14:40 < sipa> and there is no functional difference between "sending an empty message to announce feature support" vs setting a service bit, except that service bits are more limited (only 64), and are rumoured (which only matters for feature discovery)
14:57 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Read error: Connection reset by peer]
14:58 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
14:59 -!- GonnaSellSomeCoo [~textual@162-245.23-155.PUBLIC.monkeybrains.net] has joined #bitcoin-core-dev
15:14 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev
15:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:22 < bitcoin-git> [bitcoin] promag closed pull request #20580: wallet: Some cleanups around LegacyScriptPubKeyMan (master...2020-12-wallet-legacy) https://github.com/bitcoin/bitcoin/pull/20580
15:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:34 -!- GonnaSellSomeCoo [~textual@162-245.23-155.PUBLIC.monkeybrains.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
15:36 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Quit: Konversation terminated!]
15:36 -!- az0re [~az0re@gateway/tor-sasl/az0re] has joined #bitcoin-core-dev
15:38 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev
15:42 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net]
15:43 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
15:44 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 246 seconds]
15:54 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
16:09 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:d01b:63a8:de53:5983] has joined #bitcoin-core-dev
16:09 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:d01b:63a8:de53:5983] has quit [Client Quit]
16:25 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:d01b:63a8:de53:5983] has joined #bitcoin-core-dev
16:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
16:31 < bitcoin-git> [bitcoin] practicalswift opened pull request #20581: Don't make "in" parameters look like "out"/"in-out" parameters: pass by ref to const instead of ref to non-const (master...const-ref-parameters) https://github.com/bitcoin/bitcoin/pull/20581
16:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
16:40 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:d01b:63a8:de53:5983] has quit [Quit: Textual IRC Client: www.textualapp.com]
16:41 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th] has joined #bitcoin-core-dev
17:35 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services]
17:35 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
17:35 -!- vasild_ is now known as vasild
17:45 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
17:54 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
17:58 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]
18:07 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
18:08 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 240 seconds]
18:37 -!- xchg [~xchg@185.204.1.185] has quit [Remote host closed the connection]
18:58 -!- paolo|out [~paolo|out@185.163.110.125] has joined #bitcoin-core-dev
19:08 -!- adiabat [~adiabat@63.209.32.102] has quit [Ping timeout: 256 seconds]
19:10 -!- GonnaSellSomeCoo [~textual@162-245.23-155.PUBLIC.monkeybrains.net] has joined #bitcoin-core-dev
19:31 -!- GonnaSellSomeCoo [~textual@162-245.23-155.PUBLIC.monkeybrains.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
19:42 -!- pinheadmz [~pinheadmz@71.190.30.138] has quit [Read error: Connection reset by peer]
19:43 -!- pinheadmz [~pinheadmz@71.190.30.138] has joined #bitcoin-core-dev
19:52 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:d01b:63a8:de53:5983] has joined #bitcoin-core-dev
19:56 -!- GonnaSellSomeCoo [~textual@162-245.23-155.PUBLIC.monkeybrains.net] has joined #bitcoin-core-dev
20:02 -!- GonnaSellSomeCoo [~textual@162-245.23-155.PUBLIC.monkeybrains.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
20:05 -!- virtu [~virtu@gateway/tor-sasl/virtu] has quit [Ping timeout: 240 seconds]
20:07 -!- virtu [~virtu@gateway/tor-sasl/virtu] has joined #bitcoin-core-dev
20:23 -!- pinheadmz [~pinheadmz@71.190.30.138] has quit [Quit: pinheadmz]
20:38 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:a9cd:d01b:63a8:de53:5983] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
20:55 -!- jonatack [~jon@213.152.161.149] has quit [Ping timeout: 246 seconds]
20:56 -!- jonatack [~jon@88.124.242.136] has joined #bitcoin-core-dev
21:03 -!- adiabat [~adiabat@63.209.32.102] has joined #bitcoin-core-dev
21:18 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
21:18 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
21:21 -!- pbase [~pbase@unaffiliated/pbase] has joined #bitcoin-core-dev
21:33 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Read error: Connection reset by peer]
21:34 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
21:56 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
22:00 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds]
22:41 -!- da39a3ee5e6b4b0d [~da39a3ee5@ppp-223-24-171-28.revip6.asianet.co.th] has joined #bitcoin-core-dev
23:57 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
--- Log closed Sun Dec 06 00:00:37 2020