--- Log opened Wed Dec 09 00:00:42 2020 00:05 -!- ygdy [8b8ac376@139.138.195.118] has joined #bitcoin-core-dev 00:06 -!- Pavlenex [~Thunderbi@178.220.68.122] has joined #bitcoin-core-dev 00:10 < wumpus> queip: in my exerpeince the main 'it seems stuck' issue is that GUI main thread hangs on block validation sometimes, due to lock contention, this can even cause some operating systems to pop up the 'has this program crashed' dialog, see also #17145 00:10 < gribble> https://github.com/bitcoin/bitcoin/issues/17145 | GUI event loop should be block free · Issue #17145 · bitcoin/bitcoin · GitHub 00:10 -!- ossifrage_ is now known as ossifrag 00:10 -!- ossifrag is now known as ossifrage 00:11 < wumpus> agree that the logging is sometimes too verbose too, though I'm fairly sure worrying peer behavior was all moved to the net category by now 00:11 -!- ygdy [8b8ac376@139.138.195.118] has quit [Remote host closed the connection] 00:13 -!- az0re [~az0re@gateway/tor-sasl/az0re] has quit [Ping timeout: 240 seconds] 00:23 < wumpus> the thing is also that some of the information is useful for troubleshooting. some level of misbehavior is perfectly normal on a P2P network, and it can (unlikely) happen that they get all misbehaving peers and thus no blocks, "not logging by default" would pretty much make us blind in trying to diagnose issues 00:25 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.29.209] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 00:26 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 00:31 -!- Pavlenex [~Thunderbi@178.220.68.122] has quit [Quit: Pavlenex] 00:36 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Read error: Connection reset by peer] 00:38 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev 00:41 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 00:44 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds] 00:57 -!- virtu [~virtu@gateway/tor-sasl/virtu] has quit [Ping timeout: 240 seconds] 01:12 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 240 seconds] 01:12 -!- az0re [~az0re@gateway/tor-sasl/az0re] has joined #bitcoin-core-dev 01:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:24 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/90ef622ab534...a3586d592078 01:24 < bitcoin-git> bitcoin/master 7e9e7fe Carl Dong: qt/test: [FIX] Add forgotten Context setting in RPCNestedTests 01:24 < bitcoin-git> bitcoin/master 81137c6 Carl Dong: test: Add new ChainTestingSetup and use it 01:24 < bitcoin-git> bitcoin/master a3586d5 MarcoFalke: Merge #20323: tests: Create or use existing properly initialized NodeConte... 01:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:25 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20323: tests: Create or use existing properly initialized NodeContexts (master...2020-10-chainman-fixes) https://github.com/bitcoin/bitcoin/pull/20323 01:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:49 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:04 -!- kexkey [~kexkey@static-198-54-132-109.cust.tzulo.com] has quit [Ping timeout: 260 seconds] 02:05 -!- Pavlenex [~Thunderbi@178.220.68.122] has joined #bitcoin-core-dev 02:11 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th] has joined #bitcoin-core-dev 02:34 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 02:37 -!- belcher_ is now known as belcher 02:42 -!- Pavlenex [~Thunderbi@178.220.68.122] has quit [Quit: Pavlenex] 02:46 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has quit [Remote host closed the connection] 02:46 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has joined #bitcoin-core-dev 03:09 -!- darosior9 is now known as darosior 03:10 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 03:14 < wumpus> fanquake: nice, there was a githubdark firefox extension which i've used here and there, but yes it was about time they integrated it into the website i guess 03:14 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 03:15 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 03:16 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 03:16 -!- ctrlbreak [~ctrlbreak@159.2.182.106] has quit [Ping timeout: 272 seconds] 03:18 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 264 seconds] 03:21 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 03:22 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 03:24 -!- peterrizzo [~peterrizz@ool-44c18924.dyn.optonline.net] has joined #bitcoin-core-dev 03:40 < wumpus> in some places it draws a white circle behind my user icon in others the background is transparent as it should 03:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:40 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20606: Remove unused bits from service flags enum (master...2012-netServiceFlags) https://github.com/bitcoin/bitcoin/pull/20606 03:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:55 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 04:23 -!- Pavlenex [~Thunderbi@178.220.68.122] has joined #bitcoin-core-dev 04:25 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.29.209] has joined #bitcoin-core-dev 04:38 < wumpus> apart from that the dark theme is nice, imo, i'm ashamed to admit but i like Microsoft's recent style of visual design (also e.g. vscode) 04:41 < jonatack> yes, the new dark mode isn't bad, thought i liked the dark reader version too, hopefully with the extension disabled pages will load faster 04:41 < jonatack> though* 04:41 -!- pinheadmz [~pinheadmz@71.190.30.138] has joined #bitcoin-core-dev 04:42 < promag> is is possible to make depends qt but don't erase the build? 04:43 < fanquake> promag: not quite sure what you mean? 04:43 < fanquake> as in make -C depends qt_built ? 04:43 < fanquake> That will stop building qt after the build stage 04:44 < wumpus> ohh that's good to have 04:44 < fanquake> yea you can do that with all the stages 04:45 < fanquake> i.e make -C depends libevent_configured 04:45 < fanquake> or make -C depends boost_preprocessed etc 04:55 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 05:01 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.29.209] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 05:11 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 272 seconds] 05:11 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 05:17 -!- peterrizzo [~peterrizz@ool-44c18924.dyn.optonline.net] has quit [Quit: peterrizzo] 05:23 < promag> ah nice 05:23 < promag> going to try that 05:25 < promag> just noticed at then end of depends/packages.md 05:29 -!- ctrlbreak [~ctrlbreak@159.2.165.130] has joined #bitcoin-core-dev 05:30 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 05:33 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 258 seconds] 05:35 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 05:35 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services] 05:35 -!- vasild_ is now known as vasild 05:36 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has quit [Quit: Leaving] 05:40 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 05:41 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has joined #bitcoin-core-dev 05:41 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection] 05:41 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 05:42 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection] 05:42 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 05:43 -!- instagibbs [~greg@061093103011.ctinets.com] has joined #bitcoin-core-dev 05:44 < wumpus> i'd really like to get #20434 in, it seems ready and while it's not blocking me in any direct sense, it'd get th more controverial parts of #14066 out of the way so we can finally move forward with that 05:44 < gribble> https://github.com/bitcoin/bitcoin/issues/20434 | contrib: Parse ELF directly for symbol and security checks by laanwj · Pull Request #20434 · bitcoin/bitcoin · GitHub 05:44 < gribble> https://github.com/bitcoin/bitcoin/issues/14066 | gitian-linux: Build binaries for 64-bit POWER by luke-jr · Pull Request #14066 · bitcoin/bitcoin · GitHub 05:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:46 < bitcoin-git> [bitcoin] naumenkogs closed pull request #19843: Refactoring and minor improvement for self-advertisements (master...2020-08-refactor-advertiselocal) https://github.com/bitcoin/bitcoin/pull/19843 05:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:47 < bitcoin-git> [bitcoin] naumenkogs reopened pull request #19843: Refactoring and minor improvement for self-advertisements (master...2020-08-refactor-advertiselocal) https://github.com/bitcoin/bitcoin/pull/19843 05:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:49 < fanquake> wumpus: I've been meaning to look sorry 05:50 < fanquake> also reminds me to add the remaining symbol test for PE 05:53 < wumpus> not anyone's specific's fault but it's dragging on too long, three(?) major releases later and we still don't have powerpc binaries :) 05:53 -!- selenamarie [~selenamar@s91904426.blix.com] has quit [Remote host closed the connection] 05:53 < wumpus> fanquake: thanks! 05:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:56 < bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/a3586d592078...795afe6e63a1 05:56 < bitcoin-git> bitcoin/master a529fd3 John Newbery: [net processing] Move GetNodeStateStats into PeerManager 05:56 < bitcoin-git> bitcoin/master ed7e469 John Newbery: [net_processing] Move peer_map to PeerManager 05:56 < bitcoin-git> bitcoin/master a20ab22 John Newbery: [net processing] Make GetPeerRef const 05:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:57 < bitcoin-git> [bitcoin] fanquake merged pull request #19910: net processing: Move peer_map to PeerManager (master...2020-08-peer-plv2) https://github.com/bitcoin/bitcoin/pull/19910 05:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:57 -!- kabaum [~kabaum@h-13-35.A163.priv.bahnhof.se] has quit [Ping timeout: 256 seconds] 05:58 -!- peterrizzo [~peterrizz@ool-44c18924.dyn.optonline.net] has joined #bitcoin-core-dev 06:02 -!- milky1 [~milky@185.163.110.125] has joined #bitcoin-core-dev 06:12 -!- kabaum [~kabaum@h-13-35.A163.priv.bahnhof.se] has joined #bitcoin-core-dev 06:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 06:30 < promag> fanquake: qt_staged deletes qt_built? 06:33 < promag> fanquake: nevermind, _staged removes extract_dir which contains build_dir :( 06:33 < promag> rebuild 06:34 -!- kabaum [~kabaum@h-13-35.A163.priv.bahnhof.se] has quit [Ping timeout: 240 seconds] 06:35 -!- kabaum [~kabaum@h-13-35.A163.priv.bahnhof.se] has joined #bitcoin-core-dev 06:44 -!- jrayhawk [~jrayhawk@unaffiliated/jrayhawk] has quit [Quit: Lost terminal] 06:46 -!- jrayhawk [~jrayhawk@unaffiliated/jrayhawk] has joined #bitcoin-core-dev 07:00 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 07:06 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 07:10 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 258 seconds] 07:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:15 < bitcoin-git> [bitcoin] fanquake opened pull request #20608: contrib: add symbol check test for PE binaries (master...symbol_check_test_pe) https://github.com/bitcoin/bitcoin/pull/20608 07:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:38 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/795afe6e63a1...42ed7f51fafa 07:38 < bitcoin-git> bitcoin/master fa40168 MarcoFalke: Remove unused bits from service flags enum 07:38 < bitcoin-git> bitcoin/master 42ed7f5 Wladimir J. van der Laan: Merge #20606: Remove unused bits from service flags enum 07:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:38 < bitcoin-git> [bitcoin] laanwj merged pull request #20606: Remove unused bits from service flags enum (master...2012-netServiceFlags) https://github.com/bitcoin/bitcoin/pull/20606 07:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:52 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 07:52 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 07:52 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 07:52 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 08:04 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 08:05 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 08:08 -!- kexkey [~kexkey@static-198-54-132-157.cust.tzulo.com] has joined #bitcoin-core-dev 08:09 -!- miketwenty1 [~miketwent@ec2-52-72-204-35.compute-1.amazonaws.com] has joined #bitcoin-core-dev 08:10 -!- miketwen_ [~miketwent@ec2-18-205-136-236.compute-1.amazonaws.com] has joined #bitcoin-core-dev 08:13 -!- miketwenty1 [~miketwent@ec2-52-72-204-35.compute-1.amazonaws.com] has quit [Ping timeout: 258 seconds] 08:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:17 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/42ed7f51fafa...7212db4d2a55 08:17 < bitcoin-git> bitcoin/master fa11110 MarcoFalke: util: Allow use of C++14 chrono literals 08:17 < bitcoin-git> bitcoin/master 7212db4 MarcoFalke: Merge #20602: util: Allow use of C++14 chrono literals 08:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:18 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20602: util: Allow use of C++14 chrono literals (master...2012-chronoLiterals) https://github.com/bitcoin/bitcoin/pull/20602 08:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:20 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 08:43 -!- Pavlenex [~Thunderbi@178.220.68.122] has quit [Quit: Pavlenex] 08:48 -!- Pavlenex [~Thunderbi@178.220.68.122] has joined #bitcoin-core-dev 08:49 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 08:49 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds] 08:53 -!- glozow [uid453516@gateway/web/irccloud.com/x-sunfxzxwwbiziafi] has joined #bitcoin-core-dev 08:54 -!- pergaminho [~Cleber@189.26.121.248] has joined #bitcoin-core-dev 08:58 -!- joelklabo [~textual@108-196-216-127.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 09:04 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 09:21 -!- larryruane_ [uid473749@gateway/web/irccloud.com/x-ucsaxcwppqjkhsjq] has joined #bitcoin-core-dev 10:03 -!- Pavlenex [~Thunderbi@178.220.68.122] has quit [Quit: Pavlenex] 10:05 -!- openoms [~quassel@91.132.136.76] has quit [Ping timeout: 256 seconds] 10:05 -!- openoms [~quassel@91.132.136.76] has joined #bitcoin-core-dev 10:06 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 10:20 < promag> how do you interpret the eyes reaction on a comment? 10:21 < sipa> i interpret it as "surprised" 10:21 < sipa> i also don't think i've ever used it myself, so i may be off :) 10:27 < jonatack> promag: good question, idk either, sometimes it seems like "i'll have a look" and probably more often "surprised" like sipa says 10:28 -!- Pavlenex [~Thunderbi@178.220.68.122] has joined #bitcoin-core-dev 10:30 < belcher_> iv seen it used as "im watching this / im interested" 10:30 -!- mol [~mol@unaffiliated/molly] has quit [Remote host closed the connection] 10:30 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 10:30 < sipa> oh! 10:30 < sipa> that's a completely different interpretation 10:32 < promag> https://twitter.com/lukehefson/status/1086367967460364293 10:33 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 256 seconds] 10:33 < jonatack> thanks! ambiguous is right 10:34 < promag> "taking look?" 10:35 < promag> I use it as "hmmmm ok ok ok ... hmmm nahh... hmmmm maybe .... later" 10:35 < promag> otherwise a comment sounds better right? 10:36 < pinheadmz> in my experience it means "huh, *someone* should take a look at this!" ... haha 10:37 -!- promag [~promag@188.250.84.129] has quit [Read error: Connection reset by peer] 10:38 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev 10:40 -!- az0re [~az0re@gateway/tor-sasl/az0re] has quit [Quit: Leaving] 10:41 -!- Guyver2_ [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 10:44 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds] 10:50 -!- Pavlenex [~Thunderbi@178.220.68.122] has quit [Quit: Pavlenex] 10:56 < jonatack> The meeting log is up at https://bitcoincore.reviews/20477 11:00 < luke-jr> [18:20:08] how do you interpret the eyes reaction on a comment? <-- "N. was here, saw this, nothing to say" 11:03 -!- Cory [~Cory@unaffiliated/cory] has quit [Ping timeout: 240 seconds] 11:05 < jonatack> ("meeting log is up" -> oops, wrong channel) 11:12 -!- Cory [~Cory@unaffiliated/cory] has joined #bitcoin-core-dev 11:13 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 11:30 -!- virtu [~virtu@gateway/tor-sasl/virtu] has joined #bitcoin-core-dev 11:32 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has quit [Ping timeout: 240 seconds] 11:32 -!- promag [~promag@188.250.84.129] has quit [Read error: Connection reset by peer] 11:32 -!- promag_ [~promag@188.250.84.129] has joined #bitcoin-core-dev 11:33 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has joined #bitcoin-core-dev 11:48 -!- filchef [~filchef@212.104.97.177] has joined #bitcoin-core-dev 12:05 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:11 < sdaftuar> #19858 should be ready for merge -- it had 4 acks over a month ago -- but has needed a couple trivial rebases in the last two weeks 12:11 < gribble> https://github.com/bitcoin/bitcoin/issues/19858 | Periodically make block-relay connections and sync headers by sdaftuar · Pull Request #19858 · bitcoin/bitcoin · GitHub 12:11 < sdaftuar> if reviewers could verify the latest version of the code so that we can get this in i would appreciate it! 12:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:38 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/7212db4d2a55...0038ce97584f 12:38 < bitcoin-git> bitcoin/master 90c0f26 MarcoFalke: Squashed 'src/crc32c/' changes from 224988680f..b5ef9be675 12:38 < bitcoin-git> bitcoin/master fa7c8d1 MarcoFalke: build: Update crc32c subtree 12:38 < bitcoin-git> bitcoin/master 0038ce9 Wladimir J. van der Laan: Merge #20603: build: Update crc32c subtree 12:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:38 < bitcoin-git> [bitcoin] laanwj merged pull request #20603: build: Update crc32c subtree (master...2012-crcSubtree) https://github.com/bitcoin/bitcoin/pull/20603 12:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:53 -!- glozow [uid453516@gateway/web/irccloud.com/x-sunfxzxwwbiziafi] has quit [Quit: Connection closed for inactivity] 13:01 -!- pergaminho [~Cleber@189.26.121.248] has quit [Quit: Saindo] 13:07 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 13:08 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 13:16 -!- belcher_ is now known as belcher 13:42 -!- Guyver2_ [~Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 13:47 < ariard> bookmarked 19858 to review it again tmrw! 13:48 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev 13:48 -!- miketwe__ [~miketwent@ec2-18-205-136-236.compute-1.amazonaws.com] has joined #bitcoin-core-dev 13:51 -!- miketwen_ [~miketwent@ec2-18-205-136-236.compute-1.amazonaws.com] has quit [Ping timeout: 272 seconds] 13:53 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 264 seconds] 14:28 -!- filchef [~filchef@212.104.97.177] has quit [Quit: KVIrc 5.0.0 Aria http://www.kvirc.net/] 14:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:53 < bitcoin-git> [gui] luke-jr opened pull request #148: Bugfix: GUI: Restore SendConfirmationDialog button default to "Yes" (master...bugfix_gui_bumpyes) https://github.com/bitcoin-core/gui/pull/148 14:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:57 -!- jrawsthorne [~jrawsthor@static.235.41.217.95.clients.your-server.de] has quit [Read error: Connection reset by peer] 14:57 -!- jrawsthorne [~jrawsthor@static.235.41.217.95.clients.your-server.de] has joined #bitcoin-core-dev 15:09 -!- peterrizzo [~peterrizz@ool-44c18924.dyn.optonline.net] has quit [Read error: Connection reset by peer] 15:09 -!- peterrizzo [~peterrizz@ool-44c18924.dyn.optonline.net] has joined #bitcoin-core-dev 15:33 -!- posseidoun [~sami@96.30.204.77.rev.sfr.net] has joined #bitcoin-core-dev 15:35 -!- posseidoun [~sami@96.30.204.77.rev.sfr.net] has left #bitcoin-core-dev [] 15:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 15:36 < bitcoin-git> [bitcoin] apoelstra opened pull request #20609: configure: output notice that test binary is disabled by fuzzing (master...2020-12--fuzz-config-output) https://github.com/bitcoin/bitcoin/pull/20609 15:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 15:42 -!- peterrizzo [~peterrizz@ool-44c18924.dyn.optonline.net] has quit [Quit: peterrizzo] 15:45 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 240 seconds] 15:45 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 265 seconds] 15:48 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 16:01 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th] has joined #bitcoin-core-dev 16:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 16:30 -!- milky1 [~milky@185.163.110.125] has quit [Remote host closed the connection] 16:41 -!- virtu [~virtu@gateway/tor-sasl/virtu] has quit [Ping timeout: 240 seconds] 16:43 -!- virtu [~virtu@gateway/tor-sasl/virtu] has joined #bitcoin-core-dev 16:50 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 256 seconds] 16:51 -!- dachary1 [~dachary@217.146.82.202] has joined #bitcoin-core-dev 17:09 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 17:28 < wumpus> why does fuzzing disable all other targets? 17:28 < wumpus> if it's a matter of compile flags we could only pass those for the fuzzing binaries i suppose? 17:30 < sipa> wumpus: every object has to be compiled with fuzzing enabled 17:30 < sipa> if you do, nothing but the fuzz binary makes any sense 17:30 < sipa> i have a separate worktree for fuzz builds 17:31 < sipa> because it's so exclusive with everything else 17:31 < sipa> (it needs a separate ./configure) 17:33 < wumpus> sipa: hmm we could compile every object twice in that case i guess 17:33 < sipa> i asked cfields before if it was possible to have a separate target for every object with fuzzing enabled 17:33 < sipa> but he said it was hard 17:33 < wumpus> that would make sense, i mean this keeps coming up 17:34 < sipa> my biggest gripe with the fuzz builds is that it's impossible to even do any compilation of the fuzz code without a separate configure step 17:34 < sipa> after merging them all in one binary it'd be easy to permit building the fuzz binary without fuzzing enabled, though 17:34 < wumpus> making say the fuzz objects .fuzz.o would also prevent them accidentally being linked into a non-fuzz binary (or the other wayr around) 17:35 < wumpus> yes, that might help 17:35 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services] 17:35 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 17:35 -!- vasild_ is now known as vasild 17:37 -!- jarolrod [uid475272@gateway/web/irccloud.com/x-zdbkvysnmfxkmryf] has joined #bitcoin-core-dev 17:39 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has quit [Read error: Connection reset by peer] 17:40 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has joined #bitcoin-core-dev 17:41 < sipa> it'd be great if we could have a .fuzz.o for everything 17:41 < sipa> not sure how much work it is 17:43 < wumpus> i trust cfields is right that this is hard to realize with auto* build system for some reason 17:49 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 17:49 < sipa> we could even make a "dummy" fuzz binary when building without fuzzing that can only run existing seeds through the fuzz tests 17:49 < sipa> which would mean you can do the CI fuzz things without separate build 17:50 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev 17:52 < aj> sipa: ooo! that's a good idea! 17:54 * sipa suggests calling it phonyfuzz 17:54 < aj> phuzz 17:54 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 17:55 < aj> faux+fuzz=fauzz? 17:55 < fanquake> .PHONY 18:05 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev 18:06 < wumpus> let's try to merge #20560 soon then 18:06 < gribble> https://github.com/bitcoin/bitcoin/issues/20560 | fuzz: Link all targets once by MarcoFalke · Pull Request #20560 · bitcoin/bitcoin · GitHub 18:08 -!- miketwe__ [~miketwent@ec2-18-205-136-236.compute-1.amazonaws.com] has quit [Ping timeout: 240 seconds] 18:11 -!- miketwen_ [~miketwent@ec2-34-202-224-110.compute-1.amazonaws.com] has joined #bitcoin-core-dev 18:11 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds] 18:14 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 240 seconds] 18:17 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 240 seconds] 18:19 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 18:23 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 18:30 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev 18:30 -!- miketwen_ [~miketwent@ec2-34-202-224-110.compute-1.amazonaws.com] has quit [Read error: Connection reset by peer] 18:31 -!- miketwen_ [~miketwent@ec2-34-202-224-110.compute-1.amazonaws.com] has joined #bitcoin-core-dev 18:35 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 264 seconds] 18:44 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev 18:47 -!- miketwen_ [~miketwent@ec2-34-202-224-110.compute-1.amazonaws.com] has quit [Ping timeout: 264 seconds] 18:56 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds] 19:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 19:12 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0038ce97584f...17918a987aee 19:12 < bitcoin-git> bitcoin/master 7d0271b Russell Yanofsky: depends: Set CMAKE_INSTALL_RPATH for native packages 19:12 < bitcoin-git> bitcoin/master 17918a9 fanquake: Merge #20046: depends: Set CMAKE_INSTALL_RPATH for native packages 19:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 19:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 19:13 < bitcoin-git> [bitcoin] fanquake merged pull request #20046: depends: Set CMAKE_INSTALL_RPATH for native packages (master...pr/ipc-rpath) https://github.com/bitcoin/bitcoin/pull/20046 19:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 19:28 -!- samuel-pedraza [47edaff3@gateway/web/cgi-irc/kiwiirc.com/ip.71.237.175.243] has joined #bitcoin-core-dev 19:30 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 258 seconds] 19:33 -!- dermoth_ [~dermoth@unaffiliated/dermoth] has joined #bitcoin-core-dev 19:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 19:34 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/17918a987aee...054710615c5e 19:34 < bitcoin-git> bitcoin/master ae9b489 fanquake: contrib: add symbol check test for PE 19:34 < bitcoin-git> bitcoin/master 0547106 fanquake: Merge #20608: contrib: add symbol check test for PE binaries 19:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 19:34 -!- dermoth [~dermoth@unaffiliated/dermoth] has quit [Disconnected by services] 19:34 -!- dermoth_ is now known as dermoth 19:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 19:34 < bitcoin-git> [bitcoin] fanquake merged pull request #20608: contrib: add symbol check test for PE binaries (master...symbol_check_test_pe) https://github.com/bitcoin/bitcoin/pull/20608 19:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 19:35 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 20:54 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 20:59 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 264 seconds] 20:59 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 21:16 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 21:22 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th] has joined #bitcoin-core-dev 21:26 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th] has quit [Client Quit] 21:26 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds] 21:29 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 21:48 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 22:10 -!- jkczyz [sid419941@gateway/web/irccloud.com/x-ibaprrhpcssnfiuj] has quit [Read error: Connection reset by peer] 22:10 -!- jkczyz [sid419941@gateway/web/irccloud.com/x-iecubrfqgzplxinh] has joined #bitcoin-core-dev 22:11 -!- dburkett [sid411344@gateway/web/irccloud.com/x-jsncuetqmrckjftg] has quit [Read error: Connection reset by peer] 22:11 -!- ahmed_ [sid14086@gateway/web/irccloud.com/x-pookjqmmhysqtsxx] has quit [Ping timeout: 268 seconds] 22:11 -!- moneyball [sid299869@gateway/web/irccloud.com/x-wjkdiocnrkijgqvm] has quit [Ping timeout: 268 seconds] 22:11 -!- dburkett [sid411344@gateway/web/irccloud.com/x-tkxwhnhavbsakwkd] has joined #bitcoin-core-dev 22:11 -!- Galvas [sid459296@gateway/web/irccloud.com/x-xysgxmoclwsvmqxp] has quit [Read error: Connection reset by peer] 22:11 -!- bosma [sid103570@gateway/web/irccloud.com/x-pkpfwlunsrhdoepd] has quit [Read error: Connection reset by peer] 22:11 -!- moneyball [sid299869@gateway/web/irccloud.com/x-rochyfnjwpmypxlr] has joined #bitcoin-core-dev 22:11 -!- Galvas [sid459296@gateway/web/irccloud.com/x-bwbwszkdaytmfgex] has joined #bitcoin-core-dev 22:11 -!- bosma [sid103570@gateway/web/irccloud.com/x-itslqunxawvbudln] has joined #bitcoin-core-dev 22:12 -!- ahmed_ [sid14086@gateway/web/irccloud.com/x-jtijyzavnpaqnvsx] has joined #bitcoin-core-dev 22:15 -!- twistedline__ [~twisted@2601:14d:8500:a77d:2985:36c3:6c1f:47b8] has joined #bitcoin-core-dev 22:16 -!- twistedline_ [~twisted@c-73-200-216-219.hsd1.dc.comcast.net] has quit [Ping timeout: 272 seconds] 22:28 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.29.209] has joined #bitcoin-core-dev 22:31 -!- mrostecki [mrostecki@nat/suse/x-oplejjvnaxzshynh] has quit [Quit: WeeChat 1.8] 22:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:32 < bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/054710615c5e...f5b2ea3e5918 22:32 < bitcoin-git> bitcoin/master 5805b82 John Newbery: [net processing] Move PushNodeVersion into PeerManager 22:32 < bitcoin-git> bitcoin/master f3f61d0 John Newbery: [net processing] Add IgnoresIncomingTxs() function to PeerManager 22:32 < bitcoin-git> bitcoin/master 4d510aa John Newbery: [init] Use MakeUnique<> to construct peerman 22:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:32 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20217: net: Remove g_relay_txes (master...2020-10-remove-grelaytxes) https://github.com/bitcoin/bitcoin/pull/20217 22:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:39 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 22:44 -!- Pavlenex [~Thunderbi@178.220.68.122] has joined #bitcoin-core-dev 22:53 -!- Pavlenex [~Thunderbi@178.220.68.122] has quit [Quit: Pavlenex] 22:54 -!- Pavlenex [~Thunderbi@178.220.68.122] has joined #bitcoin-core-dev 23:02 -!- Pavlenex [~Thunderbi@178.220.68.122] has quit [Quit: Pavlenex] 23:23 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 23:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:27 < bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/f5b2ea3e5918...22f13c1e088e 23:27 < bitcoin-git> bitcoin/master 30bc8fa Sebastian Falbesoner: net: save high-bandwidth mode states in CNodeStats 23:27 < bitcoin-git> bitcoin/master a7ed00f Sebastian Falbesoner: rpc: expose high-bandwidth mode states via getpeerinfo 23:27 < bitcoin-git> bitcoin/master dab6583 Sebastian Falbesoner: doc: release note for new getpeerinfo fields "bip152_hb_{from,to}" 23:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:27 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19776: net, rpc: expose high bandwidth mode state via getpeerinfo (master...20200821-rpc-expose-high-handwidth-mode-state-via-getpeerinfo) https://github.com/bitcoin/bitcoin/pull/19776 23:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:28 -!- gleb [~gleb@178.150.137.228] has quit [Ping timeout: 260 seconds] 23:33 -!- samuel-pedraza [47edaff3@gateway/web/cgi-irc/kiwiirc.com/ip.71.237.175.243] has quit [Ping timeout: 240 seconds] 23:36 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Read error: Connection reset by peer] 23:39 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 23:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:48 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/22f13c1e088e...38176dc66523 23:48 < bitcoin-git> bitcoin/master ce207d6 Jon Atack: wallet, bugfix: allow send to take string fee rate values 23:48 < bitcoin-git> bitcoin/master 6fa72ce Jon Atack: test: add coverage for passing fee rate as a string 23:48 < bitcoin-git> bitcoin/master 38176dc MarcoFalke: Merge #20573: wallet, bugfix: allow send with string fee_rate amounts 23:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:49 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20573: wallet, bugfix: allow send with string fee_rate amounts (master...send-allow-feerates-as-strings) https://github.com/bitcoin/bitcoin/pull/20573 23:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:56 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 23:58 -!- Pavlenex [~Thunderbi@178.220.68.122] has joined #bitcoin-core-dev --- Log closed Thu Dec 10 00:00:43 2020