--- Log opened Sun Dec 13 00:00:45 2020 00:22 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds] 00:32 -!- mrd [~mrd@185.103.96.147] has joined #bitcoin-core-dev 00:42 -!- mrd [~mrd@185.103.96.147] has quit [Remote host closed the connection] 00:42 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 00:50 < jonasschnelli> I upgraded my system and my gitian LXC console can no longer access the internet (it can fetch via apt-cacher-ng, but not the depends packages). Any idea? 00:51 < jonasschnelli> sudo lxc-execute -n gitian -f var/lxc.config -- sudo -u root -i -- ping 8.8.8.8 <- times out 00:54 < sipa> jonasschnelli: there is that snippet of code you need to run to set up network interfaces 00:54 < jonasschnelli> sipa: I guess you'r refering to https://github.com/bitcoin-core/docs/blob/master/gitian-building/gitian-building-setup-gitian-debian.md#setting-up-debian-for-gitian-building 00:54 < jonasschnelli> I did that 00:58 < sipa> ok 00:58 < jonasschnelli> sipa: what do you have in gitian-builder/var/lxc-config for the key lxc.net.0.ipv4.address? 00:58 < sipa> i just followed the docs, on a fresh debian install 00:59 < jonasschnelli> and my br0 has inet 10.0.2.2?! shouldn't it be 10.0.3.1?! 01:08 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-209.dynamic.3bb.co.th] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 01:09 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.29.209] has joined #bitcoin-core-dev 01:15 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.29.209] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 01:16 -!- jonatack [~jon@88.124.242.136] has joined #bitcoin-core-dev 01:20 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 240 seconds] 01:42 -!- Pavlenex [~Thunderbi@185.245.85.251] has joined #bitcoin-core-dev 01:43 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection] 01:43 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 02:23 -!- virtu [~virtu@gateway/tor-sasl/virtu] has quit [Ping timeout: 240 seconds] 02:25 -!- virtu [~virtu@gateway/tor-sasl/virtu] has joined #bitcoin-core-dev 02:29 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 02:31 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.29.209] has joined #bitcoin-core-dev 02:56 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection] 02:57 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 03:08 -!- espadrine [~espadrine@s91904426.blix.com] has joined #bitcoin-core-dev 03:08 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev 03:18 -!- Ole76Christianse [~Ole76Chri@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev 03:23 -!- Ole76Christianse [~Ole76Chri@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 246 seconds] 03:27 < wumpus> on my gitian host the host br0 is 10.0.3.2 03:28 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds] 03:28 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev 03:31 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 03:50 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.29.209] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 03:53 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.29.209] has joined #bitcoin-core-dev 03:53 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.29.209] has quit [Client Quit] 03:53 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.29.209] has joined #bitcoin-core-dev 03:57 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.29.209] has quit [Client Quit] 03:57 < wumpus> though as long as they're used consistently throughout it doesn't really matter what the exact addresses are 04:05 -!- mj_node [~mj_node@122.0.25.130] has joined #bitcoin-core-dev 04:14 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Quit: Leaving] 04:30 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:bbcd:2474:9519:9fb5:8678] has joined #bitcoin-core-dev 04:37 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 04:37 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 04:52 -!- Pavlenex [~Thunderbi@185.245.85.251] has quit [Quit: Pavlenex] 04:56 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 04:57 < wumpus> achow101: phantomcircuit: FWIW here's my (very makeshift) python script from last night that uses macholib and asn1crypto to extract and print the signature information from a macos binary: https://gist.github.com/laanwj/a0e00bcd3fe4cd2aa1c0803e91310495 04:59 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 246 seconds] 05:03 < wumpus> all dependencies are pure python as it is now; but for actual verification it's hard to get around openssl i'm afraid 05:14 < Talkless> Anyone using QtCreator to work with bitcoin core? It's code model does not find any of bitcoin core includes, all underlined. I've created project as Autotools. 05:17 -!- iamgr00t_ [~iamgr00t@unaffiliated/iamgr00t] has joined #bitcoin-core-dev 05:17 -!- iamgr00t [~iamgr00t@unaffiliated/iamgr00t] has quit [Ping timeout: 260 seconds] 05:18 -!- kinlo [~peter@unaffiliated/kinlo] has quit [Ping timeout: 260 seconds] 05:21 -!- kinlo [~peter@unaffiliated/kinlo] has joined #bitcoin-core-dev 05:37 < wumpus> i think you need to manually configure somehow what paths to look in for include files 05:38 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 05:41 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 264 seconds] 05:42 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 05:45 -!- Pavlenex [~Thunderbi@185.245.85.251] has joined #bitcoin-core-dev 05:45 -!- Pavlenex [~Thunderbi@185.245.85.251] has quit [Client Quit] 05:47 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 05:49 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 05:49 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 05:52 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 05:53 -!- espadrine [~espadrine@s91904426.blix.com] has quit [Remote host closed the connection] 06:00 -!- davterra [~davterra@107.182.237.18] has quit [Quit: Leaving] 06:02 < wumpus> https://github.com/wbond/certvalidator "A Python library for validating X.509 certificates or paths" maybe this is useful 06:03 -!- pinheadmz [~pinheadmz@71.190.30.138] has joined #bitcoin-core-dev 06:09 < wumpus> some examples https://github.com/wbond/certvalidator/blob/master/docs/usage.md, iwonder if the simple example simply works 06:11 -!- potato [~Thunderbi@240d:1a:3d4:7d00:6195:91a4:15a2:31e8] has quit [Ping timeout: 264 seconds] 06:19 -!- kabaum [~kabaum@h-13-35.A163.priv.bahnhof.se] has quit [Remote host closed the connection] 06:21 -!- promag_ [~promag@188.250.84.129] has joined #bitcoin-core-dev 06:21 -!- promag [~promag@188.250.84.129] has quit [Read error: Connection reset by peer] 06:22 < wumpus> oh that only validates the certificates, not the CMS SignerInfo 06:25 < wumpus> this handles *some kinds of* SignerINfo, but not the CMS one: https://github.com/ralphje/signify/blob/master/signify/signerinfo.py 06:27 < wumpus> though rfc2315 and rfc5652 look very similar 06:28 -!- alko89 [~alko89@unaffiliated/alko89] has quit [Quit: ZNC 1.7.5 - https://znc.in] 06:28 -!- jessepos_ [~jp@2601:643:8980:bfd2:65bd:87f1:eb2b:e04e] has joined #bitcoin-core-dev 06:29 < wumpus> wait, CMS is RFC 5652 06:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:31 < bitcoin-git> [bitcoin] hebasto opened pull request #20641: depends: Use Qt top-level build facilities (master...201213-top) https://github.com/bitcoin/bitcoin/pull/20641 06:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:32 < wumpus> it's just the pyasn naming instead of asn1crypto, because of course, crypto can never be confusing enough 06:32 -!- jesseposner [~jp@2601:643:8980:bfd2:4ca5:5aef:8068:2da7] has quit [Ping timeout: 264 seconds] 06:33 -!- alko89 [~alko89@unaffiliated/alko89] has joined #bitcoin-core-dev 06:33 < jamesob> hm, when importing a watch-only wallet, is there any risk to using `scantxoutset` to find the oldest UTXO, and then using that as the base block to pass to `rescanblockchain` for that wallet? you might miss the transactions for some spent coins, but wondering if that even matters. 06:34 < wumpus> we'll get there, apparently it is a very similar mechanism as PE authenticode (windows code signing) 06:35 < wumpus> jamesob: you'd say the resulting balance and utxo set should be the same, would definitely test though 06:35 < jamesob> wumpus: right, that's what I'd think 06:37 -!- pinheadmz [~pinheadmz@71.190.30.138] has quit [Quit: pinheadmz] 06:38 -!- fearbeag [~sseanicid@bras-base-clwdon2201w-grc-18-216-209-44-58.dsl.bell.ca] has joined #bitcoin-core-dev 06:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:40 < bitcoin-git> [bitcoin] hebasto opened pull request #20642: depends: Drop unneeded patches for qt package (master...201213-patch) https://github.com/bitcoin/bitcoin/pull/20642 06:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:42 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:bbcd:2474:9519:9fb5:8678] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 06:43 -!- pinheadmz [~pinheadmz@71.190.30.138] has joined #bitcoin-core-dev 06:45 < harding> jamesob: you'd have to guess the range for scantxoutset, though. If you guess too low then it'll look like the wallet is empty. 06:46 < jamesob> you mean the upper end of the range? I'd just assume go to tip; I'm just thinking you could use `scatxoutset` to truncate the lower bound 06:47 < harding> jamesob: sorry, I meant the derived address range, which I think non-Bitcoin Core software usually calls the gap limit. 06:47 < jamesob> harding: oh! gotcha; yeah I was talking about the rescan range in height units 06:47 < harding> $ bitcoin-cli help scantxoutset | grep '"range"' 06:47 < harding> "range": n or [n,n], (numeric or array, optional, default=1000) The range of HD chain indexes to explore (either end or [begin,end]) 06:48 < wumpus> maybe the best way forward is to add apple macho verification support to signify and upstream it; conceptually it's similar and there's bound to be so much shared code, e.g. this is the signature extraction and check for signed PE files: https://github.com/ralphje/signify/blob/master/signify/signed_pe.py 06:48 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 06:51 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 06:59 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev 07:00 -!- pinheadmz [~pinheadmz@71.190.30.138] has quit [Remote host closed the connection] 07:01 -!- pinheadmz [~pinheadmz@71.190.30.138] has joined #bitcoin-core-dev 07:10 -!- twistedline [~twisted@unaffiliated/twistedline] has quit [Remote host closed the connection] 07:10 -!- twistedline [~twisted@unaffiliated/twistedline] has joined #bitcoin-core-dev 07:12 -!- mj_node [~mj_node@122.0.25.130] has quit [Quit: Leaving] 07:14 -!- twistedline [~twisted@unaffiliated/twistedline] has quit [Remote host closed the connection] 07:14 -!- twistedline [~twisted@unaffiliated/twistedline] has joined #bitcoin-core-dev 07:32 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds] 07:43 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 07:57 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 08:00 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-guhcgzevcwsswvxj] has quit [Quit: Idle for 30+ days] 08:00 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 264 seconds] 08:27 -!- jonatack [~jon@88.124.242.136] has joined #bitcoin-core-dev 08:29 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 08:32 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 240 seconds] 08:32 -!- jonatack [~jon@88.124.242.136] has joined #bitcoin-core-dev 08:37 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 256 seconds] 08:38 -!- jonatack [~jon@88.124.242.136] has joined #bitcoin-core-dev 08:43 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 256 seconds] 08:44 -!- jonatack [~jon@134.19.179.139] has joined #bitcoin-core-dev 08:45 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 08:48 < wumpus> okay, scrap that, of couuurse pyasn1 (in contrast to asn1crypto) can't parse the signature data, well let's see if i can get it to work with that 08:57 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 08:59 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 09:07 < michaelfolkson> Will we want a BIP 44 coin type index for Signet? 09:07 < michaelfolkson> The default Signet 09:08 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds] 09:08 < michaelfolkson> Looking at the registered coin types for BIP 44. Sooooo many s***coins https://github.com/satoshilabs/slips/blob/master/slip-0044.md 09:08 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev 09:09 < michaelfolkson> Perhaps too early. Perhaps should only be considered once Signet is more stable/mature 09:10 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 09:15 -!- kexkey [~kexkey@static-198-54-132-142.cust.tzulo.com] has joined #bitcoin-core-dev 09:18 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev 09:25 -!- fearbeag [~sseanicid@bras-base-clwdon2201w-grc-18-216-209-44-58.dsl.bell.ca] has quit [Ping timeout: 256 seconds] 09:27 < wumpus> wow i got it to validate 09:29 < wumpus> michaelfolkson: the consensus seems to be that new testnets will simply use testnet's parameters 09:35 < michaelfolkson> wumpus: Are there any parameters (descriptors, HD wallet, network etc) where this could pose problems? I guess it only gets complicated if the user is switching between testnet and signet 09:36 < michaelfolkson> And presumably not many will be doing that 09:36 < michaelfolkson> (regularly switching back and forth I mean) 09:36 < luke-jr> michaelfolkson: signet is for testing only. any problems, you get to pick up pieces ;) 09:37 < luke-jr> user is assumed to know what he is doing 09:39 < michaelfolkson> luke-jr: I guess... would still be nice to help them avoid unnecessary gotchas perhaps 09:45 -!- fearbeag [~sseanicid@bras-base-clwdon2201w-grc-18-216-209-44-58.dsl.bell.ca] has joined #bitcoin-core-dev 09:51 -!- alko89 [~alko89@unaffiliated/alko89] has quit [Quit: ZNC 1.7.5 - https://znc.in] 09:51 -!- alko89 [~alko89@unaffiliated/alko89] has joined #bitcoin-core-dev 10:01 -!- tralfaz [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev 10:02 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection] 10:05 < achow101> wumpus: nice! does it rely on openssl for the validation? 10:06 < wumpus> achow101: it uses oscrypto.asymmetric, no idea what that uses internally 10:06 < achow101> can you update the gist? 10:07 < wumpus> sure 10:09 -!- alko89 [~alko89@unaffiliated/alko89] has quit [Quit: ZNC 1.7.5 - https://znc.in] 10:10 -!- alko89 [~alko89@unaffiliated/alko89] has joined #bitcoin-core-dev 10:12 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Remote host closed the connection] 10:12 < wumpus> achow101: updated, note that it doesn't verify the intermediate certificate chain yet, only the final signatures on the SignerDatas 10:12 < achow101> great 10:14 < wumpus> I tried to use certvalidator to do that, but it gets into problems, even when manually providing the sorted certificate chain to the path validator it barks on some apple-specific extension *shrug* 10:16 < wumpus> it's cool to find so much code that *almost* does what i want but is just that little bit off 10:17 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 10:20 -!- fearbeag [~sseanicid@bras-base-clwdon2201w-grc-18-216-209-44-58.dsl.bell.ca] has quit [Ping timeout: 264 seconds] 10:21 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev 10:24 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Remote host closed the connection] 10:36 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Quit: Leaving] 10:50 < wumpus> ok, updated gist again, it can now optionally validate the certificate chain (however, this required a one-line patch to certvalidator unfortunately) 10:54 < sipa> awesome 10:55 < jonasschnelli> shall I try to gbuild and detach-sign 20638? 10:56 < jonasschnelli> or are you guys in the middle of fixing the internet? 10:57 < sipa> #20638 10:57 < gribble> https://github.com/bitcoin/bitcoin/issues/20638 | build: Fix macOS code signing by pre-allocating space for the code signature during gitian build by achow101 · Pull Request #20638 · bitcoin/bitcoin · GitHub 10:57 < sipa> jonasschnelli: yeah, try please 10:59 < wumpus> jonasschnelli: i guess we're working on a tool that checks the signature (i wrote the part that validates the CMS envelope, achow101 the part that checks hashes against the binary), this doesn't replace or delay #20638 10:59 < gribble> https://github.com/bitcoin/bitcoin/issues/20638 | build: Fix macOS code signing by pre-allocating space for the code signature during gitian build by achow101 · Pull Request #20638 · bitcoin/bitcoin · GitHub 11:00 < achow101> wumpus: are you sure that it's validating the right thing? the data being passed into verify is more than just the hash of the CodeDirectory 11:00 < achow101> it also seems like it hashes the data too 11:01 < wumpus> I'm pretty sure it validtes the right thing, the SignerInfos contain signed_attrs that has the list of hashes 11:01 < wumpus> my script doesn't validate the actual hashes against the binary of course 11:01 < achow101> right, that's the part I'm adding to it 11:02 < sipa> do you know where to find the page sizes used? 11:02 < achow101> i'd be surprised if the verify is able to pull out the hashes from the "signed_attrs" because that seems like some apple specific stuff 11:02 < achow101> sipa: it's embedded in CodeDirectory 11:02 < achow101> or do you mean in the source? 11:04 < sipa> achow101: just wondering if you can account for that (so that it'd keep working if a different page size is used at some point) 11:04 < achow101> yep, definitely accounting for that 11:04 < sipa> wumpus, achow101: easy to test if it's validating the right thing; if you damage the signature, does it fail? 11:05 < sipa> or better, damage the message being signed 11:06 < wumpus> to get out your hashes data you need for attr in signerinfo['signed_attrs']: if attr['type'].native == SEC_OID_APPLE_HASH_AGILITY_V2: print(attr['values'][0].contents) 11:07 < wumpus> that gets the byte data, which i guess is simply concatenated hashes 11:08 < wumpus> it can extract everything, it's of no help parsing it of course 11:10 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev 11:10 < achow101> there's a field named "message_digest" that I'm trying to grab 11:10 < achow101> that's not an apple specific thing apparently 11:11 < achow101> apparently the hash is in the sig 3 times in 3 different fields 11:12 < wumpus> attr['type'].native == 'message_digest' 11:12 < achow101> also, oscrypto uses openssl in the backend 11:12 < wumpus> yes it seems so, on linux 11:14 < jonasschnelli> achow101: 6b2c9ac15da01cc4fa3951059fdf44c4eebd432288af6691ef94604f601b9ab9 bitcoin-6753b74195d8-osx-unsigned.tar.gz 11:14 < wumpus> in any case if you can find something else that does the "rsa_pkcs1v15_verify" i guess it'd be straightforward to replace 11:15 < wumpus> sipa: yes, damaging either the signature or data makes it fail 11:16 < jonasschnelli> bad new 11:16 < jonasschnelli> +s 11:16 < jonasschnelli> dist/Bitcoin-Qt.app: invalid or unsupported format for signature 11:16 -!- kexkey [~kexkey@static-198-54-132-142.cust.tzulo.com] has quit [Ping timeout: 256 seconds] 11:16 < jonasschnelli> when calling ./detached-sig-create.sh -s "Bitcoin" 11:16 < jonasschnelli> ^ achow101 11:16 < sipa> ugh 11:16 < achow101> eh? 11:16 < achow101> damnit 11:17 < sipa> it detects that too much space was added? 11:17 < jonasschnelli> probably 11:17 < sipa> or that it has too much space which isn"t 0x2000 aligned? 11:17 < achow101> no, it tries to parse existing signatures 11:17 < sipa> oh 11:17 < achow101> it's all 0's, so obviouslyu it doesn't parse 11:17 < achow101> I thought the -f option we give it ignores that 11:19 < jonasschnelli> The file has a MP_EMPTY_SPACE of size 8, then MP_CODE_SIG with size 256208 11:19 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 11:20 < jonasschnelli> achow101: -f option? 11:20 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 265 seconds] 11:20 < achow101> --force 11:20 < sipa> what binary is called that fails? 11:21 < jonasschnelli> sipa: I ran ./detached-sig-create.sh but I guess the one that matter is the dist/Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt 11:21 < jonasschnelli> achow101: but your PR doesn't add --force or -f 11:21 < achow101> it's already there 11:21 < achow101> look at the codesign command in detached-sig-create 11:21 < sipa> jonasschnelli: i mean what tool is called that gives that error 11:21 < jonasschnelli> let me look... 11:22 < sipa> is it codesign or something else 11:22 < jonasschnelli> set -x tells me: + codesign -f --file-list sign.temp/signatures.txt -s Bitcoin dist/Bitcoin-Qt.app 11:22 < achow101> it's codesign 11:23 < jonasschnelli> stupid question: why can't we just use the open source variant of codesign (if that exists)? to match codesign_allocate? 11:23 < achow101> mmm, what if we cut off the allocated space? 11:24 < achow101> jonasschnelli: there's no open source variant of codesign. codesign also requires codesign_allocate to be signed by apple, so we can't use the open source variant of that either 11:24 < sipa> jonasschnelli: codesign only accepts apple-signed versions of codesign_allocate 11:24 < achow101> "If the CODESIGN_ALLOCATE environment variable is set, it identifies a substitute codesign_allocate tool used to allocate space for code signatures in Mach-O binaries. This is used by Xcode SDK distributions to provide architectural support for non-native platforms such as iPhones. 11:24 < achow101> The system will not accept such substitutes unless they are specially signed (by Apple)." 11:24 < jonasschnelli> hmm.. apple style again 11:25 < sipa> we can also try patching our codesign_allocate to roubd to 0x2000 11:25 < sipa> it's a bit more brittle, but i don't see how it can fail 11:28 < jonasschnelli> should we also file a bug at apples issue tracker for a long term fix of this? 11:29 -!- belcher_ is now known as belcher 11:29 < achow101> they have one? 11:29 < achow101> hmm, what if we put in an empty SuperBlob? 11:34 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 11:34 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 11:35 < achow101> jonasschnelli: if you do "printf "\xfa\xde\x0c\xc0" | dd of=dist/Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt bs=1 seek=26391600 count=4 conv=notrunc" and then try to sign, does it work? 11:35 * jonasschnelli doing... 11:36 < jonasschnelli> still getting: dist/Bitcoin-Qt.app: invalid or unsupported format for signature 11:36 < achow101> darn 11:37 < jonasschnelli> what if we overwrite the bytes with an "valid" signature we extract from a successful signing? 11:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:38 < bitcoin-git> [bitcoin] sipa opened pull request #20644: Add patch to make codesign_allocate compatible with Apple's (master...202012_codesign_allocate_segalign) https://github.com/bitcoin/bitcoin/pull/20644 11:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:38 < sipa> jonasschnelli: can you try that? ^ 11:38 < sipa> (entirely untested) 11:38 < achow101> jonasschnelli: would probably work 11:38 < jonasschnelli> okay.. I'll clear the cache and run it 11:39 < jonasschnelli> achow101: I mean you could probably replace the zero signature (the allocation) with the largest signature you find in 0.12 11:39 < jonasschnelli> maybe the tool only validates the header or so,.. so combining with the allocation hack might work? 11:39 < jonasschnelli> trying sipa patch now 11:40 < achow101> with the -f option, codesign will only warn if the existing sig is invalid. but I guess it needs to be properly formatted first 11:40 < achow101> maybe not even warn 11:40 < achow101> so you could try to apply the rc3 sig to the pr's build and then sign that 11:40 -!- lontivero [~lontivero@186.183.48.250] has joined #bitcoin-core-dev 11:41 < jonasschnelli> achow101: what does codesign_allocate do with the existing sig? Just expand? 11:41 < jonasschnelli> (I mean in your PR) 11:41 < achow101> yes 11:41 < jonasschnelli> that could work... 11:41 < achow101> wumpus: huh, I guess it does sign the whole "signed_attrs" thing and not just the message digest as I previously thought 11:41 < jonasschnelli> But how would I apply the sig? 11:42 < achow101> run detached-sig-apply.sh locally 11:42 < jonasschnelli> yes... I could try that 11:44 < sipa> my PR doesn't work 11:44 < sipa> fixing 11:46 < jonasschnelli> achow101: can I take a unsigned.tar.gz from master,... manually apply the sig (detached-sig-apply.sh) on linux, execute your patch ${CODESIGN_ALLOCATE} -i ${BINARY_RESULT} -a x86_64 ${SIG_SIZE_EST} -o ${BINARY_RESULT} and then try to sign on OSX? 11:46 < jonasschnelli> without gitian at all? 11:46 < jonasschnelli> I can take the same cc_tools (form the cache) 11:47 < achow101> to test, the sig creation, yes 11:47 < jonasschnelli> sipa: so 6e9f0fa7f7ce95cc4ddf0e5cc4c49ab75361efe7 is it? 11:48 < sipa> jonasschnelli: yup 11:48 < sipa> unfortunately, this working isn't a guarantee it will always work 11:48 < sipa> because the build may randomly be 0x2000 aligned 11:49 < jonasschnelli> sipa: could we detect this easly? 11:49 < jonasschnelli> (well,... wumpus verification tool would) 11:49 < achow101> jonasschnelli: is there some kind of dev testing code signing cert? I'd like to be able to test this stuff 11:49 < jonasschnelli> achow101: sure. I can try to make you one 11:50 < achow101> There's no apple default? 11:50 < jonasschnelli> I don't know 11:50 < achow101> ah, i'll look into it later 11:50 < jonasschnelli> I guess if I hand you out a different certificate, end uses would have no plan/idea to differenciate those 11:50 < achow101> yeah 11:51 < sipa> you won't have a certificate chain leading back to apple 11:51 < sipa> or perhaps one which doesn't convey codesigning rights 11:52 < achow101> I wouldn't be surprised if apple didn't let you sign with such a cert 11:52 < jonasschnelli> sipa: so your cctools patch is only relevant for the signing step? I don't need to rebuild the actual unsigned release build? 11:53 -!- Pavlenex [~Thunderbi@185.245.85.251] has joined #bitcoin-core-dev 11:53 < jonasschnelli> it only affects detached-sig-apply.sh, right? 11:53 < achow101> yes 11:54 < sipa> jonasschnelli: right 11:54 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 11:54 < achow101> ah, there's instructions for a self signed cert. this may work 11:55 < jonasschnelli> but! gitian-osx-signer.yml does not build the depends? So I need to clear the cache and do the release build anyways 11:56 < sipa> ah right 11:56 < sipa> you need it because the signing step uses the binaries produced in the unsigned build step 11:56 < jonasschnelli> yes 11:57 < sipa> ugh 11:57 < sipa> my patch fails 11:58 < sipa> sorry i will test this more and get back 11:58 < jonasschnelli> sipa: sure. No hurry 11:58 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Remote host closed the connection] 12:03 -!- lontivero [~lontivero@186.183.48.250] has quit [Ping timeout: 260 seconds] 12:04 < achow101> at this point it feels like the long term solution is to write our own codesigning tool 12:04 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 12:06 < sipa> sounds like you're well on the way to do that :) 12:06 < sipa> if you have a tool that can verify signatures, signing doesn't sound too far away 12:06 < achow101> signing is probably 2 orders of magnitude harder than verification 12:07 < achow101> the current unknown things being how to generate Info.plist, CodeResources file, and the internal requirements blob 12:07 < jonasschnelli> achow101: fatal error: /home/jonasschnelli/bitcoin-depends2/depends/x86_64-apple-darwin20/native/bin/x86_64-apple-darwin20-codesign_allocate: size for '-a x86_64 258611375' not a multiple of 16 12:08 < sipa> round up to a multiple of 16 12:08 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 12:08 < jonasschnelli> stat -c %s signed-app/Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt 12:08 < jonasschnelli> -> 26698160 12:08 < achow101> oh, I totally forgot about that didn't I 12:09 < jonasschnelli> ((((26698160 / 4096) + 1) * 32) + 50000) == 258611375 12:09 < sipa> use 51200 instead of 50000 12:09 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 272 seconds] 12:09 < sipa> 50*1024 12:09 < sipa> or so 12:09 < jonasschnelli> can I round up to 258611376? 12:09 < jonasschnelli> 26698160 to 12:09 < jonasschnelli> 258611376 12:09 < jonasschnelli> ahm.. no 12:10 < sipa> how do i see files inside lxc? 12:10 < jonasschnelli> lxc-attach 12:10 < sipa> hmm? 12:11 < sipa> my build failed and it created a file with the rejected patch description 12:11 < jonasschnelli> sudo lxc-attach -n gitian -f var/lxc.config 12:11 < jonasschnelli> (and you should get a shell of your lxc container) 12:11 < jonasschnelli> make sure you are in the gitian-builder dir 12:11 < sipa> 1095 failed to get init pid 12:12 < jonasschnelli> oh.. dunno 12:12 < jonasschnelli> sudo lxc-start -n gitian -f var/lxc.config (maybe that first) 12:12 < sipa> thanks, works! 12:13 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 12:16 < sipa> it just fails to apple the patch 12:16 < sipa> that makes no sense 12:16 < achow101> seems to be very apple-y 12:17 < sipa> lol 12:17 < sipa> that was a typo 12:17 < jonasschnelli> achow101: still getting dist/Bitcoin-Qt.app: invalid or unsupported format for signature 12:18 < jonasschnelli> (when manually apply the signature on linux with /detached-sig-apply.sh, adding the codesign_allocate thing and trying to sign again 12:18 < achow101> do codesign_allocate first then detached sig apply? 12:18 < jonasschnelli> no. 12:18 < achow101> codesign_allocate might be overwriting the sig with 0s 12:23 < jonasschnelli> achow101 the other way around work for signing... 12:23 < jonasschnelli> (I mean for successful signing on my mac) 12:23 < achow101> yay 12:23 < jonasschnelli> dist/Bitcoin-Qt.app: replacing existing signature 12:24 < achow101> this is such a stupid workaround 12:24 < jonasschnelli> shall I try to use this detached signature to build the release? 12:24 < achow101> to be clear, you did codesign-allocate with the overestimate, applied some other signature, then signed 12:24 < achow101> yes, try that 12:25 < jonasschnelli> yes... 12:25 < jonasschnelli> I did: /home/jonasschnelli/bitcoin-depends2/depends/x86_64-apple-darwin20/native/bin/x86_64-apple-darwin20-codesign_allocate -i dist/Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt -a x86_64 258611376 -o dist/Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt 12:25 < jonasschnelli> tar -czf bitcoin-0.21.0rc3-osx-unsigned.tar.gz ./ 12:26 < jonasschnelli> ./detached-sig-apply.sh bitcoin-0.21.0rc3-osx-unsigned.tar.gz ../bitcoin-detached-sigs/osx (<--- the git repo for the signatures) 12:26 < sipa> ok it seems copy-pasting the "git diff" output introduced some space/tab changes... 12:26 < achow101> jonasschnelli: awesome 12:26 < jonasschnelli> let me 2bl check first 12:27 < jonasschnelli> Yes. I think I have done that correctly 12:28 < jonasschnelli> I mean I can just try to apply this signature I created on my mac no on linux with ./detached-sig-apply.sh 12:28 < jonasschnelli> right? 12:28 < jonasschnelli> no need for gitian 12:28 < sipa> i believe so 12:28 < achow101> yea 12:29 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:32 -!- twistedline [~twisted@unaffiliated/twistedline] has quit [Ping timeout: 240 seconds] 12:34 < sipa> jonasschnelli: ok gitian manages to compile native_cctools with my patch now 12:34 < jonasschnelli> The dbl-signing approach seems not to work 12:34 < sipa> if you want to try (if the other approach works, also fine of course) 12:35 < achow101> jonasschnelli: how so? 12:35 < jonasschnelli> What I did: 12:35 < jonasschnelli> 1. I replace the signature in the detached-signtaure local repo with the one I just successfully did on my mac (after codesign_allocate on linux 12:36 < jonasschnelli> 2. on linux, I executed ./detached-sig-apply.sh bitcoin-0.21.0rc3-osx-unsigned-2.tar.gz ../bitcoin-detached-sigs/osx 12:36 < jonasschnelli> (bitcoin-0.21.0rc3-osx-unsigned-2.tar.gz is from the rc3 release, unsigned, untouched) 12:36 < jonasschnelli> (../bitcoin-detached-sigs/osx hold the new signature) 12:37 < jonasschnelli> then downloaded signed-app/Bitcoin-Qt.app to my mac 12:37 < achow101> jonasschnelli: for the final apply, you need to use the one that had the codesign-allocate and bad sig thing 12:37 < jonasschnelli> achow101: ah... 12:37 < jonasschnelli> okay.. let me try that 12:38 < jonasschnelli> achow101: still getting /Users/jonasschnelli/Desktop/Bitcoin-Qt.app: invalid Info.plist (plist or signature have been modified) 12:39 < jonasschnelli> Maybe I did something wrong... 12:39 < jonasschnelli> let me upload some files so you can test it 12:40 < achow101> you started with the original rc3? 12:40 < jonasschnelli> https://bitcoin.jonasschnelli.ch/bitcoin-0.21.0rc3-osx-unsigned-dbl-sign.tar.gz (<--- the 1. codesign_alloc, apply rc3 sig) 12:43 < jonasschnelli> https://bitcoin.jonasschnelli.ch/signature-osx-dbl-sign.tar.gz (<--- the output from detach-sig-create on my mac which run successful on the output above) 12:45 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 260 seconds] 12:46 < sipa> jonasschnelli: ok, gitian unsigned build with my patch works (which doesn't mean much, aS the codesign_allocate tool hasn't been invoked) 12:46 < achow101> jonasschnelli: somehow the Info.plist hash doesn't match. 12:46 < jonasschnelli> sipa: okay... I try that asap 12:47 < achow101> jonasschnelli: I'm going to fixup my pr and I think we should try again from scratch 12:47 < jonasschnelli> achow101: yes. Lets do that. 12:47 -!- twistedline [~twisted@unaffiliated/twistedline] has joined #bitcoin-core-dev 12:47 < jonasschnelli> I think I mixed up your PR with rc3 (different version numbers) 12:47 < achow101> possible 12:48 < jonasschnelli> okay.. gbuilding a4118c6e200e02e7560f8bc213697aa2909d95b1 12:57 < jonasschnelli> I can't use the rc3 sig for the cctool patch test,.. since it's master now and has different version numbers. 12:57 < jonasschnelli> So trying to sign independent 12:58 < jonasschnelli> I hoped by deleting the cctools only in the cache, I can avoid rebuilding the whole dependencies.... but it looks like it builds everything again 13:02 < jonasschnelli> I have to continue tomorrow (10pm here,... will start again in 11h)... 13:26 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 13:27 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds] 13:29 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev 13:32 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 256 seconds] 13:33 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 256 seconds] 13:40 -!- Pavlenex [~Thunderbi@185.245.85.251] has quit [Quit: Pavlenex] 14:01 -!- jesseposner [~jp@2601:643:8980:bfd2:3c52:ceaf:5e03:1c52] has joined #bitcoin-core-dev 14:04 -!- jessepos_ [~jp@2601:643:8980:bfd2:65bd:87f1:eb2b:e04e] has quit [Ping timeout: 260 seconds] 14:06 < achow101> updated wumpus's script to do hash checking https://gist.github.com/achow101/fef2415d99965de66ac083b54b83df6e 14:14 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has quit [Ping timeout: 240 seconds] 14:16 -!- k3tan [~pi@gateway/tor-sasl/k3tan] has joined #bitcoin-core-dev 14:17 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Ping timeout: 240 seconds] 14:18 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev 14:24 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 14:26 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 14:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:37 < bitcoin-git> [bitcoin] jonatack opened pull request #20646: p2p: do not disconnect post-verack sendaddrv2 on signet (master...signet-keep-post-verack-sendaddrv2-peers) https://github.com/bitcoin/bitcoin/pull/20646 14:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:53 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Remote host closed the connection] 14:57 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 15:00 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 15:07 < achow101> sipa: does your pr gitian build? I have a self signed cert so I can test codesigning now 15:13 < sipa> achow101: yes 15:13 < sipa> i did a gitian build of the unsigned stage myself 16:07 < achow101> ok, I think my pr works now 16:07 < achow101> I was able to do the whole macOS build and sign process and got valid binaries out the other end 16:07 < achow101> will check sipa's pr now 16:14 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev 16:14 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Remote host closed the connection] 16:15 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev 16:19 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Remote host closed the connection] 16:21 -!- virtu [~virtu@gateway/tor-sasl/virtu] has quit [Ping timeout: 240 seconds] 16:23 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer] 16:23 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev 16:27 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 16:31 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:bbcd:9454:7ae:76c2:209d] has joined #bitcoin-core-dev 16:43 -!- virtu [~virtu@gateway/tor-sasl/virtu] has joined #bitcoin-core-dev 16:49 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 16:50 -!- aisak [be4a1432@190.74.20.50] has joined #bitcoin-core-dev 17:05 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 17:14 < achow101> sipa: 3021d9722182e2dfdcd29b1dec11514d66f3e566d5ae505d69c2c68b21f68a27 bitcoin-a4118c6e200e-osx-unsigned.tar.gz match? 17:18 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 256 seconds] 17:19 < sipa> achow101: match 17:19 < achow101> vmsize 0x0000000000083000 17:19 < achow101> no good I think 17:19 < sipa> achow101: that's expected 17:20 < achow101> how so? 17:20 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:bbcd:9454:7ae:76c2:209d] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 17:20 < sipa> it'll be corrected at signature-attach time, not before 17:20 < achow101> yes, this is post signing 17:20 < sipa> oh 17:20 < sipa> :( 17:20 < sipa> wth 17:20 < achow101> pre-signing is vmsize 0x0000000000043428 17:20 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev 17:21 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 258 seconds] 17:21 < achow101> our validation script correctly fails it too 17:23 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 17:24 < sipa> bizarre 17:27 < fanquake> the saga continues 17:28 < achow101> at least the bogus sig trick works 17:28 -!- aisak [be4a1432@190.74.20.50] has quit [Remote host closed the connection] 17:28 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 17:33 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 264 seconds] 17:35 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:bbcd:9454:7ae:76c2:209d] has joined #bitcoin-core-dev 17:36 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 17:36 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services] 17:36 -!- vasild_ is now known as vasild 17:44 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Quit: Leaving] 17:44 < sipa> achow101: i can't comprehend how it *did* round to 0x1000, but not 0x2000 17:45 < sipa> the constant 0x1000 should exist anymore in any of the used code 17:45 < sipa> is it possible it used a cached codesign_allocate from a previous build? 17:48 < achow101> I don't think so 17:48 < achow101> I definitely cleared the cache 17:52 < achow101> the vmsize is also wildly off. it should've been 0x7b000 17:52 < achow101> I thought maybe it had accidentally used my hack, but the unsigned was correct and the tarball matches yourss 17:53 -!- az0re [~az0re@gateway/tor-sasl/az0re] has joined #bitcoin-core-dev 17:54 < sipa> ok, perhaps changing this constant affects far more 17:54 < sipa> still doesn't explain why the number isn't a multiple of 0x2000, though 17:54 < sipa> i don't see how that's possible 17:57 < sipa> achow101: do you have the unsigned Bitcoin-Qt binary somewhere? 17:58 < achow101> yeah, do you need it? 17:58 < sipa> oh, i guess i have it too! 17:59 < achow101> I would expect so, since you did the gitian build 18:00 < sipa> yeah, i do 18:01 < sipa> any way to see the vmsize from linux? 18:01 < achow101> native_cctools also has otool 18:01 < achow101> it'll be x86_64-apple-darwin-otool 18:02 < achow101> it'll be x86_64-apple-darwin-otool -l Bitcoin-Qt 18:03 < sipa> what's the sig size? 18:04 < achow101> 224592 18:05 < sipa> unsigned: 18:05 < sipa> segname __LINKEDIT 18:05 < sipa> vmaddr 0x00000001018fa000 18:05 < sipa> vmsize 0x0000000000043428 18:05 < sipa> i run: 18:05 < sipa> $ ./codesign_allocate -i dist/Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt -a x86_64 224592 -o out 18:06 < sipa> output: 18:06 < sipa> segname __LINKEDIT 18:06 < sipa> vmaddr 0x00000001018fa000 18:06 < sipa> vmsize 0x000000000007c000 18:06 < achow101> hmmm 18:06 < achow101> ??????? 18:07 < sipa> this is using the codesign_allocate tool in my gitian build output 18:07 < achow101> I guess I have an unclean environment 18:08 < achow101> oh, it must be grabbing the wrong unsigned tarball 18:08 -!- fearbeag [~sseanicid@bras-base-clwdon2201w-grc-18-216-209-44-58.dsl.bell.ca] has joined #bitcoin-core-dev 18:15 < achow101> I can't get it to make the correct size 18:16 < sipa> how are you invoking gitian-build.py ? 18:16 < achow101> i'm using gbuild directly 18:16 < achow101> https://drive.google.com/file/d/1xFdpQoAKHNG9eC6Jw5rY7gzIwb7rgR-q/view?usp=sharing is the sig tarball if you want to try 18:17 < achow101> I'll try applying it manually 18:20 < sipa> my best guess is thah somehow it's using the wrong bitcoin-osx-unsigned.tar.gz 18:22 < achow101> running it locally instead of gitian definintely does the right thing 18:23 < achow101> and it is valid 18:25 -!- fearbeag [~sseanicid@bras-base-clwdon2201w-grc-18-216-209-44-58.dsl.bell.ca] has quit [Ping timeout: 256 seconds] 18:31 -!- fearbeag [~sseanicid@bras-base-clwdon2201w-grc-18-216-209-44-58.dsl.bell.ca] has joined #bitcoin-core-dev 18:33 < achow101> ok, I got it working, it is valid now 18:33 < achow101> it was the filenames... 18:35 < sipa> 2 hardest problems in computer science: concurrency, off by one errors, and naming stuff 18:35 < achow101> heh 18:37 -!- fearbeag [~sseanicid@bras-base-clwdon2201w-grc-18-216-209-44-58.dsl.bell.ca] has quit [Ping timeout: 256 seconds] 18:37 -!- fearbeag [~sseanicid@bras-base-clwdon2201w-grc-18-216-209-44-58.dsl.bell.ca] has joined #bitcoin-core-dev 18:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:38 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ade38b6ee8f9...25bc840e038f 18:38 < bitcoin-git> bitcoin/master a33442f Antoine Riard: Remove m_is_manual_connection from CNodeState 18:38 < bitcoin-git> bitcoin/master 25bc840 fanquake: Merge #20617: p2p: Remove m_is_manual_connection from CNodeState 18:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:38 < bitcoin-git> [bitcoin] fanquake merged pull request #20617: p2p: Remove m_is_manual_connection from CNodeState (master...2020-12-remove-is-manual-connection) https://github.com/bitcoin/bitcoin/pull/20617 18:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:41 -!- fearbeag [~sseanicid@bras-base-clwdon2201w-grc-18-216-209-44-58.dsl.bell.ca] has quit [Remote host closed the connection] 18:41 -!- fearbeag [~sseanicid@bras-base-clwdon2201w-grc-18-216-209-44-58.dsl.bell.ca] has joined #bitcoin-core-dev 18:42 < fanquake> Given the state of the last few PRs, looks like Appveyor is broken? I'm seeing: 18:42 < fanquake> EXEC : error : Building package openssl-windows:x64-windows-static failed with: BUILD_FAILED ... 18:46 -!- fearbeag [~sseanicid@bras-base-clwdon2201w-grc-18-216-209-44-58.dsl.bell.ca] has quit [Ping timeout: 258 seconds] 18:52 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 19:02 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has joined #bitcoin-core-dev 19:07 -!- fearbeag [~sseanicid@bras-base-clwdon2201w-grc-18-216-209-44-58.dsl.bell.ca] has joined #bitcoin-core-dev 19:11 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds] 19:12 -!- fearbeag [~sseanicid@bras-base-clwdon2201w-grc-18-216-209-44-58.dsl.bell.ca] has quit [Ping timeout: 260 seconds] 19:15 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.9] 19:17 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 19:30 < luke-jr> appveyor always broken..? 20:15 -!- tralfaz [~davterra@gateway/tor-sasl/tralfaz] has quit [Quit: Leaving] 20:42 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev 20:51 -!- jessepos_ [~jp@2601:643:8980:bfd2:447f:3dcb:9ae8:5b10] has joined #bitcoin-core-dev 20:55 -!- jesseposner [~jp@2601:643:8980:bfd2:3c52:ceaf:5e03:1c52] has quit [Ping timeout: 260 seconds] 20:56 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Remote host closed the connection] 20:59 -!- az0re [~az0re@gateway/tor-sasl/az0re] has quit [Quit: Leaving] 21:23 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:bbcd:9454:7ae:76c2:209d] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 21:36 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 264 seconds] 22:09 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 22:09 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 22:20 -!- vanaltj1 [~vanaltj@84.39.117.57] has joined #bitcoin-core-dev 22:53 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:bbcd:9454:7ae:76c2:209d] has joined #bitcoin-core-dev 23:06 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 264 seconds] 23:15 -!- jesseposner [~jp@2601:643:8980:bfd2:3cdc:b002:cf8:d4b2] has joined #bitcoin-core-dev 23:19 -!- jessepos_ [~jp@2601:643:8980:bfd2:447f:3dcb:9ae8:5b10] has quit [Ping timeout: 260 seconds] 23:29 -!- tlev [~tlev@li120-195.members.linode.com] has quit [Quit: Ping timeout (120 seconds)] 23:29 -!- tlev [~tlev@li120-195.members.linode.com] has joined #bitcoin-core-dev 23:33 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 23:33 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 23:37 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:bbcd:9454:7ae:76c2:209d] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 23:39 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:bbcd:9454:7ae:76c2:209d] has joined #bitcoin-core-dev --- Log closed Mon Dec 14 00:00:46 2020