--- Log opened Wed Dec 16 00:00:48 2020
00:05 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:cecf:a55b:90cf:1ae1:4d7b] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
00:18 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
00:19 -!- da39a3ee5e6b4b0d [~da39a3ee5@49.228.254.151] has joined #bitcoin-core-dev
00:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds]
00:20 < wumpus> achow101: "It's a mini scripting language with opcodes and stuff" can you compile DOOM for it?
00:22 < jonasschnelli> heh
00:22 < sipa> yes, but does it run linux?
00:23 < wumpus> achow101: but nice work
00:23 < wumpus> sipa: finally a way to run linux on a mac !
00:24 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 264 seconds]
00:25 -!- Klox048093186316 [~Klox@c-24-1-131-19.hsd1.il.comcast.net] has quit [Read error: Connection reset by peer]
00:32 < sipa> i mean, there is a linux system compiled to JS that runs in the browser right?
00:35 < jonasschnelli> OMG
00:36 < jonasschnelli> RiscV64 with X11 in my browser: https://bellard.org/jslinux/vm.html?cpu=riscv64&url=buildroot-riscv64-xwin.cfg&graphic=1&mem=256
00:37 < sipa> wow
00:37 < sipa> even works on my phone
00:39 < wumpus> jonasschnelli: risc-v is clearly the new webassembly
00:39 < jonasschnelli> windows98 with minesweeper: http://copy.sh/v86/?profile=windows98
00:41 < sipa> wth
00:42 < sipa> if my phone's cpu is fast enough to run a browser, in which an emulated operating system can run, and really all i do with it is using it as a pocket watch with wikipedia and irc functionality, i'm doing something wront
00:43 < wumpus> that one is veeery slow here
00:44 < wumpus> sipa: i'm sure it drains the battery like crazy, i guess that's the main bottleneck to doing more CPU heavy things on a phone
00:49 -!- Pavlenex [~Thunderbi@185.103.110.235] has joined #bitcoin-core-dev
00:53 -!- Pavlenex [~Thunderbi@185.103.110.235] has quit [Client Quit]
01:03 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
01:24 -!- vincenzopalazzo [~vincent@2001:b07:6474:9d49:fc00:1cb5:3dd3:aa91] has joined #bitcoin-core-dev
01:28 -!- Pavlenex [~Thunderbi@185.103.110.235] has joined #bitcoin-core-dev
01:28 < wumpus> does anyone maybe have a better idea how we can avoid introducing a circular dependency here between coinstats and validation: https://github.com/bitcoin/bitcoin/pull/19806#pullrequestreview-552964012
01:31 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
01:31 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
01:42 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
01:43 < jonasschnelli> I don't see other options than a separate implementation unit
01:53 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
01:55 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Ping timeout: 260 seconds]
02:06 < wumpus> I think it makes logical sense too, snapshot handling is adjacent to but not part of validation
02:08 < wumpus> woohoo, appveyor cooked up a new reason to fail "The object or library file 'C:\Qt5.9.8_x64_static_vs2019\lib\Qt5Core.lib' was created by a different version of the compiler than other objects like 'x64\Release\bitcoin-qt\main.obj'; rebuild all objects and libraries with the same"
02:09 < wumpus> don't know if it's general or only on the 0.21 branch
02:13 -!- shesek [~shesek@164.90.217.137] has joined #bitcoin-core-dev
02:13 -!- shesek [~shesek@164.90.217.137] has quit [Changing host]
02:13 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
02:13 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 246 seconds]
02:15 -!- jonatack [~jon@134.19.179.147] has joined #bitcoin-core-dev
02:23 -!- da39a3ee5e6b4b0d [~da39a3ee5@49.228.254.151] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
02:35 < vasild> jonatack: I2P! :)
02:40 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
02:41 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:cecf:313a:ef0a:c021:651e] has joined #bitcoin-core-dev
02:41 < vasild> What is the reason we don't gossip host names, e.g. bitcoinnode.foo.org:8333?
02:41 < wumpus> we really don't want DNS lookups in the P2P code
02:42 < vasild> wumpus: Why? For performance reasons?
02:42 < wumpus> also working with dynamically-sized strings in any network protocol has a large potential to introduce bugs
02:43 < wumpus> security/privacy reasons mostly, it's harder to do with tor
02:43 < vasild> I see
02:45 < wumpus> I don't really see much of an advantage in it personally, DNS is useful for humans, but for a addresses sent over a network protocol it seems to me it adds an unnecessary level of indirection 
02:46 < vasild> yeah, maybe some benefit could be that a hostname could resolve to a few IP addresses or if the address changes over time, then addrman entries need not be updated
02:47 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev
02:47 < vasild> I asked because in I2P we do need to do a lookup - the .b32.i2p address must be resolved to a "destination" (a few 100s of bytes) and then we connect to that "destination"
02:48 < wumpus> i didn't know that when writing the BIP
02:48 < wumpus> should we have gossipped destinations directly?
02:49 < wumpus> though we can fit 512 bytes i guess the size does make it impractical
02:51 < hebasto> wumpus: to fix appveyor on 0.21 the baclport of the recent changes seem required: #20489, #20506
02:51 < gribble> https://github.com/bitcoin/bitcoin/issues/20489 | CI msvc: only build vcpkg dependencies for release (not debug) to reduce build times by sipsorcery · Pull Request #20489 · bitcoin/bitcoin · GitHub
02:51 < gribble> https://github.com/bitcoin/bitcoin/issues/20506 | ci: AppVeyor fixes for Visual Studio 2019 16.8.1 image by sipsorcery · Pull Request #20506 · bitcoin/bitcoin · GitHub
02:51 -!- Pavlenex1 [~Thunderbi@185.103.110.235] has joined #bitcoin-core-dev
02:52 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 256 seconds]
02:52 -!- Pavlenex [~Thunderbi@185.103.110.235] has quit [Ping timeout: 256 seconds]
02:52 -!- Pavlenex1 is now known as Pavlenex
02:53 < hebasto> should I take care of it?
02:53 < vasild> wumpus: I think it is fine as it is, gossiping destinations directly seems an overkill to me
02:54 < vasild> but it opens the opportunity to allow i2p hostnames, e.g. zzz.i2p in addition to .b32.i2p addresses
02:56 < vasild> also, lontivero mentioned in https://github.com/bitcoin/bitcoin/pull/20254#discussion_r543586946 that even .b32.i2p addresses may have different length :-X
02:57 < vasild> eventually, maybe we would update bip155 to mandate the i2p addr size is allowed to be either 32 or 35 bytes
02:58 < wumpus> fwiw, I would prefer not to broadcast hostnames, keep the gossiping to (low level) network addresses, preferably fixed length
02:58 < vasild> wumpus: right
03:00 < wumpus> right--the current protocol mandates a specific I2P address scheme, same as we do for TorV1/V2, if there's a different one in the future then we'll need to add a new address type
03:01 < vasild> i2p-exotic, length=35
03:01 < wumpus> I intentionally didn't leave any extensibility within one address type, to make it straightforward to handle
03:04 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
03:05 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
03:06 -!- einyx [einyx@fsf/member/einyx] has joined #bitcoin-core-dev
03:06 -!- einyx_ [~einyx@fsf/member/einyx] has quit [Ping timeout: 265 seconds]
03:08 -!- Aaronva__ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
03:09 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds]
03:10 -!- Aaronva__ [~AaronvanW@unaffiliated/aaronvanw] has quit [Read error: Connection reset by peer]
03:10 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
03:10 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds]
03:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:11 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20671: Replace boost::optional with std::optional (master...2012-stdOpt) https://github.com/bitcoin/bitcoin/pull/20671
03:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:12 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
03:15 -!- Aaronva__ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
03:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 272 seconds]
03:16 -!- Aaronva__ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
03:17 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
03:17 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds]
03:17 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [K-Lined]
03:18 -!- Lisandro23Bechte [~Lisandro2@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev
03:21 -!- dadybayo [d4707bc5@212.112.123.197] has joined #bitcoin-core-dev
03:22 -!- Lisandro23Bechte [~Lisandro2@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 240 seconds]
03:26 -!- dadybayo [d4707bc5@212.112.123.197] has quit [Remote host closed the connection]
03:28 < hebasto> wumpus: are you still seeing an issue with appveyor on the 0.21 branch?
03:31 -!- aj [aj@cerulean.erisian.com.au] has quit [Ping timeout: 256 seconds]
03:38 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has quit [Remote host closed the connection]
03:39 < jonatack> vasild: hey, sorry, was reviewing. keeping each address types simple sgtm.
03:40 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has joined #bitcoin-core-dev
03:41 < vasild> jonatack: yeah, so on IP2 I am doing final self re-review and test ci runs to ensure it is still green and will open a PR with proper I2P support which will supersede #20254
03:41 < gribble> https://github.com/bitcoin/bitcoin/issues/20254 | Add I2P support using statically configured destinations by vasild · Pull Request #20254 · bitcoin/bitcoin · GitHub
03:42 < jonatack> vasild: nice, will look out for that
03:42 < vasild> I wonder if it makes sense to write a primitive SAM proxy server in python in order to test it in the functional tests... maybe yes
03:43 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has quit [Ping timeout: 256 seconds]
03:43 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has joined #bitcoin-core-dev
03:45 < vasild> so far I used a hackish unit tests that kind of starts the "entire" bitcoind by calling CConnman::Start() and requires a running i2p server - not acceptable
03:45 -!- peterrizzo [~peterrizz@ool-44c18924.dyn.optonline.net] has joined #bitcoin-core-dev
03:51 -!- midnight [~midnight@unaffiliated/midnightmagic] has quit [Ping timeout: 244 seconds]
03:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:57 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #16168: DevelopOmniLayer (master...develop) https://github.com/bitcoin/bitcoin/pull/16168
03:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:00 -!- midnight [~midnight@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
04:17 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has quit [Read error: Connection reset by peer]
04:17 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has joined #bitcoin-core-dev
04:17 -!- Kiminuo [~mix@141.98.103.124] has quit [Read error: Connection reset by peer]
04:18 -!- Kiminuo [~mix@141.98.103.124] has joined #bitcoin-core-dev
04:28 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:cecf:313a:ef0a:c021:651e] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
04:28 -!- Pavlenex [~Thunderbi@185.103.110.235] has quit [Quit: Pavlenex]
04:30 -!- jonatack [~jon@134.19.179.147] has quit [Quit: jonatack]
04:33 -!- jonatack [~jon@88.124.242.136] has joined #bitcoin-core-dev
04:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:33 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/dff0f6f753ea...b440c33179e7
04:33 < bitcoin-git> bitcoin/master ed73f8c practicalswift: net: Move eviction node selection logic to SelectNodeToEvict(...)
04:33 < bitcoin-git> bitcoin/master 685c428 practicalswift: test: Add unit testing of node eviction logic
04:33 < bitcoin-git> bitcoin/master fee8823 practicalswift: Assert eviction at >= 29 candidates. Assert non-eviction at <= 20 candidat...
04:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:34 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20477: net: Add unit testing of node eviction logic (master...unit-test-node-eviction-logic) https://github.com/bitcoin/bitcoin/pull/20477
04:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:37 -!- aj [aj@cerulean.erisian.com.au] has joined #bitcoin-core-dev
04:38 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 246 seconds]
04:39 -!- jonatack [~jon@213.152.186.173] has joined #bitcoin-core-dev
04:46 -!- peterrizzo [~peterrizz@ool-44c18924.dyn.optonline.net] has quit [Quit: peterrizzo]
04:51 -!- Pavlenex [~Thunderbi@185.103.110.235] has joined #bitcoin-core-dev
04:53 -!- Pavlenex [~Thunderbi@185.103.110.235] has quit [Client Quit]
04:57 -!- pinheadmz [~pinheadmz@71.190.30.138] has joined #bitcoin-core-dev
04:57 -!- lontivero [~lontivero@186.183.51.80] has joined #bitcoin-core-dev
04:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:59 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b440c33179e7...6af8a6232b2d
04:59 < bitcoin-git> bitcoin/master 267f259 Hennadii Stepanov: depends: Drop workaround for a fixed bug in Qt build system
04:59 < bitcoin-git> bitcoin/master 6af8a62 Jonas Schnelli: Merge #20650: depends: Drop workaround for a fixed bug in Qt build system
04:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:00 < bitcoin-git> [bitcoin] jonasschnelli merged pull request #20650: depends: Drop workaround for a fixed bug in Qt build system (master...201214-xcb) https://github.com/bitcoin/bitcoin/pull/20650
05:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:02 -!- davterra [~davterra@107.182.237.19] has quit [Quit: Leaving]
05:06 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has joined #bitcoin-core-dev
05:07 < wumpus> hebasto: let's see how #20669 goes
05:07 < gribble> https://github.com/bitcoin/bitcoin/issues/20669 | [0.21] final rc4 backports by MarcoFalke · Pull Request #20669 · bitcoin/bitcoin · GitHub
05:08 < wumpus> vasild: we don't have testing for socks5 either, but agree it'd make sense
05:08 < wumpus> vasild: oh wait we do lol
05:09 < vasild> I will at least try to do it and hope it does not end in too many lines of python code
05:10 < vasild> test/functional/test_framework/socks5.py class Socks5Server() ... 
05:10 < vasild> 160 lines
05:11 < vasild> btw, I noticed that we do send(sock, buf, size) and expect the return value to be "size" which is not robust
05:11 < vasild> also, the socket is non-blocking
05:11 < wumpus> true, it can't be generally relied on, e.g. if the system call is interrupted
05:12 < vasild> I guess it mostly works because the socks5 proxy is usually on localhost where the connection is "fast and stable" :)
05:13 < Jackielove4u> Does anybody here have rc3 running ?
05:14 < jonasschnelli> Jackielove4u: yes. Why?
05:14 -!- potato [~Thunderbi@240d:1a:3d4:7d00:9851:bcf:fdb3:6c0d] has quit [Ping timeout: 260 seconds]
05:15 < wumpus> hey, didn't we create an issue for rc test reports this time?
05:15 -!- lontivero [~lontivero@186.183.51.80] has quit [Ping timeout: 260 seconds]
05:15 < Jackielove4u> my rc3 node does not accept any incoming connections
05:15 < wumpus> looks like we forgot
05:15 < fanquake> #20555
05:15 < gribble> https://github.com/bitcoin/bitcoin/issues/20555 | v0.21.0 testing · Issue #20555 · bitcoin/bitcoin · GitHub
05:15 < Jackielove4u> i am trying to connect my rc3 client to my rc3 node
05:15 < wumpus> oh it's just not pinned
05:16 < fanquake> Yea I just pinned it
05:16 < Jackielove4u> with connect= parameter
05:16 < wumpus> thanks :)
05:16 < Jackielove4u> the connection gets dropped instantly
05:16 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:cecf:313a:ef0a:c021:651e] has joined #bitcoin-core-dev
05:16 < Jackielove4u> can i get a ip from any of you guys
05:16 < Jackielove4u> to try to connect to you
05:17 < Jackielove4u> i was able to get it fixed though by reverting this commit: https://github.com/bitcoin/bitcoin/pull/20612/commits/9e806887a8f9ef63431b28d7dfd0470aa663dd02
05:18 < Jackielove4u> not sure if this is the expected behaviour (rc3 not able to connect to rc3)
05:19 < wumpus> strange, that commit is supposed to *fix* disconnections by not sending sendaddrv2 to nodes we're not sure support it
05:20 -!- vincenzopalazzo [~vincent@2001:b07:6474:9d49:fc00:1cb5:3dd3:aa91] has quit [Remote host closed the connection]
05:22 < Jackielove4u> Can anybody replicate? or give me your node ip so i can try to connect to yours
05:22 < vasild> Jackielove4u: did you try to connect rc2 with rc3?
05:22 < Jackielove4u> no i did not
05:23 < Jackielove4u> i can try
05:23 < vasild> rc3 <-> {rc3, <=0.20.1} should be fine
05:24 < vasild> Jackielove4u: run both nodes with -debug=net and show both logs here (by pastebin) 
05:25 -!- jackgassett [~jackgasse@84.39.117.57] has quit [Remote host closed the connection]
05:26 < MarcoFalke> Indeed rc3 <-> rc3 should be fine
05:27 < vasild> this is strange: https://bpa.st/HMPA why disconnect due to ping timeout (20 minutes), 2 minutes after we have received some messages from the peer?
05:28 < vasild> 1. should we disconnect in this case, given that the connection is obviously not dead and 2. where is the pong message in this particular case?
05:28 -!- lontivero [~lontivero@186.183.3.180] has joined #bitcoin-core-dev
05:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:28 < bitcoin-git> [bitcoin] hebasto opened pull request #20673:  depends: Use more legible qmake commands in qt package  (master...201216-subdir) https://github.com/bitcoin/bitcoin/pull/20673
05:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:29 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Remote host closed the connection]
05:30 < jnewbery> vasild: the peer didn't respond to a ping message. We should disconnect. It also looks like it hasn't sent you a verack (and possibly not a version either)
05:31 < vasild> jnewbery: I removed the non-relevant messages
05:31 < vasild> just left the first one to show when the connection starts and addrv2 to show that something has arrived
05:31 < jnewbery> vasild: can you provide full logs? Very difficult to debug issues from partial logs
05:33 < jnewbery> but to answer your question, yes we always disconnect a peer that doesn't respond to a ping within 20 minutes. See InactivityCheck() in net.cpp
05:34 < MarcoFalke> Something's clearly wrong with the connection if they don't respond with pong
05:35 < jnewbery> Jackielove4u: I assume you also dropped the subsequent commit https://github.com/bitcoin/bitcoin/pull/20612/commits/9e806887a8f9ef63431b28d7dfd0470aa663dd02 as well? rc2 and rc3 don't play nice together with that commit, but rc3 <-> rc3 should be fine (and we have big problems if not)
05:36 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:cecf:313a:ef0a:c021:651e] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
05:36 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
05:36 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services]
05:36 -!- vasild_ is now known as vasild
05:36 < Jackielove4u> rc3 <-> rc3 without dropping that commit is not connecting for me
05:36 -!- peterrizzo [~peterrizz@ool-44c18924.dyn.optonline.net] has joined #bitcoin-core-dev
05:38 < vasild> jnewbery: here is the full log since you asked https://bpa.st/BE5Q, but I did not intend to debug this (yet), just ask if the behavior looks reasonable. You already answered the first question.
05:38 < vasild> I dont have the logs of the other side with -debug=net
05:39 < aj> jnewbery: re 19858 ; that log snippet is quite trimmed. https://0bin.net/paste/wnUMx2lG#XKm3fF9Wp8dOX03IKYazBTZaCDYN6CegUK-VW5rWjeJ is a more recent example
05:40 < jnewbery> argh. why do people mess with logs??
05:41 < Jackielove4u> If anybody is willing to share their node ip (that is running rc3), i can try to connect to yours and see if i get a connection
05:42 < vasild> jnewbery: in my case I left the few relevant lines to make it easier to do a high-level overview, which would be more tedious with 700+ lines of log
05:42 < Jackielove4u> rc3 <-> <=0.20.1 works fine
05:42 -!- Pavlenex [~Thunderbi@185.103.110.235] has joined #bitcoin-core-dev
05:43 < vasild> Jackielove4u: did you run with -debug=net?
05:43 < Jackielove4u> not yet, my kid is yelling that his nerf gun is stuck and need to fix that first
05:43 < vasild> :-D
05:43 < Jackielove4u> its lockdown in the netherlands
05:44 < Jackielove4u> so i have to deal with kids now also
05:44 < jnewbery> vasild: there's something wrong with that peer. It's also not _sending_ pings every two minutes as we'd expect from a Bitcoin Core node
05:45 -!- Dogechain [~Dogechain@84.39.117.57] has joined #bitcoin-core-dev
05:46 < vasild> hmm, both peers do not send pings every 2 minutes
05:46 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
05:47 -!- promag__ [~promag@188.250.84.129] has joined #bitcoin-core-dev
05:47 -!- promag [~promag@188.250.84.129] has quit [Read error: Connection reset by peer]
05:48 < jnewbery> I wonder if there's a problem with that connection. The getdata/block round trip time is often over a minute
05:48 -!- promag_ [~promag@188.250.84.129] has quit [Ping timeout: 256 seconds]
05:49 < vasild> jnewbery: that's over i2p and is for some reason very slow
05:49 -!- lontivero [~lontivero@186.183.3.180] has quit [Ping timeout: 265 seconds]
05:49 < vasild> I think I overcooked the settings on one of my i2p routers
05:49 < wumpus> is it a very slow CPU? i think it's possible for networking to hang on block validation if it takes very long
05:50 < wumpus> oh, i2p
05:50 < vasild> cpu should be fine (not very slow)
05:53 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
05:53 < Jackielove4u> nerf gun fixed
05:53 -!- vincenzopalazzo [~vincent@2001:b07:6474:9d49:1cd0:876b:6bfb:cb4a] has joined #bitcoin-core-dev
05:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:53 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6af8a6232b2d...a023094fc417
05:53 < bitcoin-git> bitcoin/master 3b064fc Michael Dietz: test: run mempool_expiry.py even with wallet disabled
05:53 < bitcoin-git> bitcoin/master a023094 MarcoFalke: Merge #20276: test: run mempool_expiry.py even with wallet disabled
05:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:53 < jnewbery> vasild: is it possible that your router is dropping packets? I don't know anything about how i2p works. Does it have reliable delivery?
05:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:53 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20276: test: run mempool_expiry.py even with wallet disabled (master...mempool-expiry-miniwallet) https://github.com/bitcoin/bitcoin/pull/20276
05:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:54 < vasild> huh
05:54 < jnewbery> aj: ah I see you added fRelay logging. Great. Then the peer is misbehaving by sending those invs. I'd guess badly implemented spy nodes. I've seen issues before where peers mysteriously ignored fRelay.
05:54 < vasild> it has "stream" and "datagram" options, let me reread the docs..
05:54 < Jackielove4u> upon testing i saw that my bitcoin core rc3 client (run on a desktop) and my schildbach wallet (run on android) does not connect to my rc3 bitcoin core node (run on a server)
05:56 < Jackielove4u> bitcoin core rc3 client (run on a desktop) and my schildbach wallet (run on android) does connect to bitcoin core 0.20.x and lower
05:57 < aj> jnewbery: yeah; as per the comment i added -- i forgot to redact my ip before pasting that log snippet, then noticed my ip wasn't in the log; so those peers are definitely not pristine bitcoin core, so don't think it's our bug on the sending side either
05:58 < aj> Jackielove4u: what's a bitcoin core rc3 client?
05:59 < vasild> jnewbery: "Virtual streams are guaranteed to be sent reliably and in order..." (from https://geti2p.net/en/docs/api/samv3)
05:59 < Jackielove4u> with client i mean qt
05:59 < aj> jnewbery: also, i think that's the first example of that code actually catching a spy-ish node in the wild, yay!
05:59 < Jackielove4u> with node i mean bitcoind
05:59 < MarcoFalke> Jackielove4u: This sounds like an issue unrelated to rc3
06:00 < aj> Jackielove4u: sounds like the client or the node is still at rc2 rather than rc3 to me
06:00 < Jackielove4u> both are certainly on rc3
06:01 < aj> Jackielove4u: run both with -debug=net and check for a line about sendaddrv2 just prior to the disconnection
06:02 -!- lontivero [~lontivero@186.183.3.236] has joined #bitcoin-core-dev
06:03 < MarcoFalke> Yes, without the debug log we can't debug this any further
06:16 -!- lontivero [~lontivero@186.183.3.236] has quit [Ping timeout: 256 seconds]
06:21 < sdaftuar> aj: i've tried to debug this same issue (where a node appears to send us inv's after we start a blocks-only connection) many times over the years, and never been able to replicate using known bitcoin core software on both ends.
06:22 < sdaftuar> would be good to write up your analysis on github maybe so that we have notes for the next time we look into something like this
06:22 < sdaftuar> (since it's one of those things where we can never quite be sure whether a peer is lying or we have a bug!)
06:29 -!- lontivero [~lontivero@186.183.51.4] has joined #bitcoin-core-dev
06:31 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:cecf:313a:ef0a:c021:651e] has joined #bitcoin-core-dev
06:39 < aj> sdaftuar: updated https://github.com/bitcoin/bitcoin/pull/19858#issuecomment-746312882
06:40 < jnewbery> If you consider BIP37 and optional standard, then it's not really a violation of the protocol to send tx INVs after receiving a version with fRelay = false
06:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:40 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a023094fc417...2d4eeaf9c588
06:40 < bitcoin-git> bitcoin/master c175690 Jarol Rodriguez: doc: Update for FreeBSD 12.2, add GUI Build Instructions
06:40 < bitcoin-git> bitcoin/master 2d4eeaf Wladimir J. van der Laan: Merge #20601: doc: Update for FreeBSD 12.2, add GUI Build Instructions
06:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:41 < bitcoin-git> [bitcoin] laanwj merged pull request #20601: doc: Update for FreeBSD 12.2, add GUI Build Instructions (master...master) https://github.com/bitcoin/bitcoin/pull/20601
06:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:41 < jnewbery> *an optional
06:42 < aj> jnewbery: i think if we're wanting a no-tx connection (to conserve b/w eg) then disconnecting is still the right thing to do if we receive txs on it?
06:45 -!- lontivero_ [~lontivero@186.183.3.32] has joined #bitcoin-core-dev
06:47 < jnewbery> aj: right. Perhaps we should also disconnect peers that don't provide fRelay in their version message to make it explicit that support for fRelay is required
06:48 -!- lontivero [~lontivero@186.183.51.4] has quit [Ping timeout: 268 seconds]
06:48 < aj> jnewbery: hmm, i guess i'm not logging whether these peers are sending frelay or not
06:49 < jnewbery> that'd be interesting. If they sent it but ignored the value that we sent
06:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:49 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/2d4eeaf9c588...9dbcd3710521
06:49 < bitcoin-git> bitcoin/master fa8e15f MarcoFalke: test: pep8 wallet_multiwallet.py
06:49 < bitcoin-git> bitcoin/master fab48da MarcoFalke: test: Fix intermittent wallet_multiwallet issue with got_loading_error
06:49 < aj> jnewbery: that's what i'd guess they're doing. not seeing much advantage in disconnecting 0s-15s earlier though
06:49 < bitcoin-git> bitcoin/master 9dbcd37 MarcoFalke: Merge #20569: test: Fix intermittent wallet_multiwallet issue with got_loa...
06:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:50 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20569: test: Fix intermittent wallet_multiwallet issue with got_loading_error (master...2012-testWalletInt) https://github.com/bitcoin/bitcoin/pull/20569
06:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:50 < jnewbery> or maybe we should deprecate fRelay and always use a feefilter message with MAX_MONEY
06:52 < aj> what happened with the p2p v2 messages? did it ever even get a proper bip?
06:53 < jonasschnelli> aj: soon
06:53 < jonasschnelli> I'm currently working on the new AEAD (with internal rekeying)
06:53 < jonasschnelli> Which should end up in the BIP
06:54 < jonasschnelli> Discussion is somewhat still ongoing https://gist.github.com/jonasschnelli/c530ea8421b8d0e80c51486325587c52 (but I guess its ready to work into the BIP)
06:54 < jnewbery> aj: what percentage of additional block-relay-only peers are you seeing this quick disconnect from? Does this limit the effectiveness of the additional block-relay-only peer mechanism?
06:55  * jonasschnelli fears scope creep in v2
06:55 < aj> jnewbery: handwavy guess, maybe 10%?
06:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:56 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20674: fuzz: Call SendMessages after ProcessMessage to increase coverage (master...2012-fuzzSendMessages) https://github.com/bitcoin/bitcoin/pull/20674
06:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:56 < aj> jnewbery: i changed the timer to 20s (which doesn't really work because of the 30s min lifetime), which is the only reason i'm seeing lots
06:58 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev
07:00 < sdaftuar> jnewbery: i think depending on your addrman, you might see a similar percentage of connections never get instantiated (because you have stale addresses that you're trying to connect to)
07:00 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Read error: Connection reset by peer]
07:00 < sdaftuar> jnewbery: but i think that is fine; if we eventually are able to find honest peers with putting low load on the network, that's much better than where we were before
07:01 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev
07:01 -!- pinheadmz [~pinheadmz@71.190.30.138] has quit [Read error: Connection reset by peer]
07:01 < sdaftuar> s/instantiated/connected/
07:01 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Remote host closed the connection]
07:02 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev
07:03 -!- pinheadmz [~pinheadmz@71.190.30.138] has joined #bitcoin-core-dev
07:04 < aj> jnewbery: ~12.5% -- 366 "inv sent in violation of protocol" disconnections versus 2559 "disconnecting extra block-relay-only peer" messages. there's also a bunch of "i tried making a b-r-o extra conn, but they basically immediately disconnected me examples, which i haven't looked into at all
07:05 < jnewbery> sdaftuar: does that depend on whether we're making progress through all the addresses in our addrman? If we're eclipsed then maybe our peers will be able to churn our new tables and we'll only ever connect to bad peers
07:08 < Jackielove4u> jnewbery: you were right
07:08 < Jackielove4u> rc2 and rc3 dont work nicely along
07:08 < Jackielove4u> it seems my node was indeed still on rc2
07:08 < jnewbery> Jackielove4u: phew. That's good news :)
07:09 < Jackielove4u> sorry for wasting your times
07:09 < sdaftuar> jnewbery: we pull from both the new table and tried table in making these connections
07:09 < sdaftuar> if someone takes over the whole addrman, it's game over of course
07:10 -!- Kiminuo [~mix@141.98.103.124] has quit [Ping timeout: 256 seconds]
07:13 < sdaftuar> i guess if somehow our only honest addrman addresses were in the same netgroups as our existing outbound connections, we would never finnd them
07:13 < sdaftuar> but that seems like a pretty small effect given that we only have 10 peers
07:13 < aj> Jackielove4u: that's okay, the "i told you so" seratonin release makes it all worthwhile ;)
07:13 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has quit [Quit: Ping timeout (120 seconds)]
07:14 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has joined #bitcoin-core-dev
07:16 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection]
07:17 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
07:19 -!- miketwen_ [~miketwent@ec2-3-216-176-187.compute-1.amazonaws.com] has joined #bitcoin-core-dev
07:19 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev
07:19 -!- pinheadm_ [~pinheadmz@71.190.30.138] has joined #bitcoin-core-dev
07:21 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 246 seconds]
07:23 -!- pinheadmz [~pinheadmz@71.190.30.138] has quit [Ping timeout: 272 seconds]
07:23 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
07:23 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
07:24 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
07:28 -!- lontivero_ [~lontivero@186.183.3.32] has quit [Ping timeout: 260 seconds]
07:33 -!- kexkey [~kexkey@static-198-54-132-94.cust.tzulo.com] has joined #bitcoin-core-dev
07:37 < jnewbery> I guess a more general point is that we select with replacement, so if there are only a few honest peers in our addrman, then it'll take a long time to pick them
07:38 < jnewbery> the new table is 4x the capacity of the tried table. I'd expect in reality the number of addresses are much more skewed towards the new table, but that's just a guess
07:40 -!- lontivero_ [~lontivero@186.183.50.42] has joined #bitcoin-core-dev
07:41 < sdaftuar> jnewbery: i think we choose from new vs tried with 50% probability, don't we?
07:43 < jnewbery> oh you're right!
07:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:44 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9dbcd3710521...3f205808a5f2
07:44 < bitcoin-git> bitcoin/master cd03513 Wladimir J. van der Laan: init: Signal-safe instant shutdown
07:44 < bitcoin-git> bitcoin/master 3f20580 Wladimir J. van der Laan: Merge #20605: init: Signal-safe instant shutdown
07:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:44 < bitcoin-git> [bitcoin] laanwj merged pull request #20605: init: Signal-safe instant shutdown (master...2020_12_instant_shutdown) https://github.com/bitcoin/bitcoin/pull/20605
07:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:49 < jnewbery> sdaftuar: do you have a sense of what proportion of connection attempts fail after being selected in ThreadOpenConnections() ?
07:53 < sdaftuar> maybe half-ish
07:53 < sdaftuar> i just did a quick check to see how many successful block-relay only connections i've had, and it's about half what you'd expect if every connection succeeded and we connect to one every 5 minutes
07:54 < sdaftuar> but i'm sure it depends a lot on your addrman. the node i just checked is on both tor and ipv4, i'm sure there are quirks with how tor addresses are relayed, etc
07:55 < aj> jnewbery: could add logging for IsFeelerConn() -> fDisconect=true and cmpare that to how often we see "Making feeler connection to" log entries
07:57 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
07:57 -!- belcher [~belcher@unaffiliated/belcher] has quit [Read error: Connection reset by peer]
07:58 < jnewbery> aj: good idea
08:00 < jnewbery> I wonder if we should do the IsDiscouraged() check earlier. If you end up with some discouraged addresses in your addrman, I guess they'll just stay there and you'll sometimes select them but never be able to connect
08:08 -!- Pavlenex [~Thunderbi@185.103.110.235] has quit [Quit: Pavlenex]
08:12 -!- joelklabo [~textual@108-196-216-127.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
08:17 -!- belcher_ is now known as belcher
08:20 -!- robert_spigler [robertspig@gateway/shell/matrix.org/x-gyzoapdcugmmdwow] has quit [Ping timeout: 268 seconds]
08:21 -!- robert_spigler [robertspig@gateway/shell/matrix.org/x-xnfysvtnctlvjxpj] has joined #bitcoin-core-dev
08:21 -!- ctrlbreak [~ctrlbreak@159.2.165.130] has quit [Remote host closed the connection]
08:21 -!- ctrlbreak [~ctrlbreak@159.2.165.130] has joined #bitcoin-core-dev
08:34 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:cecf:313a:ef0a:c021:651e] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
08:38 -!- promag__ is now known as promag
08:44 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev
08:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:45 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/3f205808a5f2...69f1ee1922e3
08:45 < bitcoin-git> bitcoin/master 6d3af3a Ivan Metlushko: wallettool: pass in DatabaseOptions into MakeWallet
08:45 < bitcoin-git> bitcoin/master 345e88e Ivan Metlushko: wallettool: add param to create descriptors wallet
08:45 < bitcoin-git> bitcoin/master 173cc9b Ivan Metlushko: test: walettool create descriptors
08:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:45 -!- davterra [~davterra@107.182.237.19] has joined #bitcoin-core-dev
08:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:45 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20365: wallettool: add parameter to create descriptors wallet (master...wallet_tool_create_descriptors) https://github.com/bitcoin/bitcoin/pull/20365
08:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:49 -!- samuel-pedraza [47edaff3@gateway/web/cgi-irc/kiwiirc.com/ip.71.237.175.243] has joined #bitcoin-core-dev
08:50 -!- Kiminuo [~mix@141.98.103.124] has joined #bitcoin-core-dev
08:56 -!- lightlike [~lightlike@p200300c7ef22ad008d562e74d2695fa7.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
08:59 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
09:01 -!- Pavlenex [~Thunderbi@185.103.110.235] has joined #bitcoin-core-dev
09:02 -!- proofofkeags [~proofofke@174-16-212-53.hlrn.qwest.net] has joined #bitcoin-core-dev
09:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:09 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/69f1ee1922e3...ad3d4b3929ab
09:09 < bitcoin-git> bitcoin/master 83f8821 Pieter Wuille: refactor: add IsAddrCompatible() to CNode
09:09 < bitcoin-git> bitcoin/master 37fe80e Pieter Wuille: Only consider addrv2 peers for relay of non-addrv1 addresses
09:09 < bitcoin-git> bitcoin/master ad3d4b3 Wladimir J. van der Laan: Merge #20661: Only select from addrv2-capable peers for torv3 address rela...
09:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:09 < bitcoin-git> [bitcoin] laanwj merged pull request #20661: Only select from addrv2-capable peers for torv3 address relay (master...202012_torv2_relay_only_addrv2) https://github.com/bitcoin/bitcoin/pull/20661
09:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:14 < MarcoFalke> Backport of this ^ conflicts with 7fabe0f359ae16ed36ce4ca2c33631d038c21448
09:15 < MarcoFalke> Should 7fabe0f359ae16ed36ce4ca2c33631d038c21448 also be backported?
09:15 < MarcoFalke> #19763 
09:15 < gribble> https://github.com/bitcoin/bitcoin/issues/19763 | net: dont try to relay to the address originator by vasild · Pull Request #19763 · bitcoin/bitcoin · GitHub
09:15 -!- Pavlenex [~Thunderbi@185.103.110.235] has quit [Quit: Pavlenex]
09:16 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]
09:17 < vasild> it would be easy to resolve, in case it is decided not to backport 19763
09:19 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
09:31 < sdaftuar> MarcoFalke: hm I'm not sure it's worth backporting #19763 myself. if we are concerned about addr propagation though, i would imagine that (after #20661) #20561 would be a bigger impact to get torv3 addresses to propagate quicker
09:31 < gribble> https://github.com/bitcoin/bitcoin/issues/19763 | net: dont try to relay to the address originator by vasild · Pull Request #19763 · bitcoin/bitcoin · GitHub
09:31 < gribble> https://github.com/bitcoin/bitcoin/issues/20661 | Only select from addrv2-capable peers for torv3 address relay by sipa · Pull Request #20661 · bitcoin/bitcoin · GitHub
09:31 < gribble> https://github.com/bitcoin/bitcoin/issues/20561 | p2p: periodically clear m_addr_known by sdaftuar · Pull Request #20561 · bitcoin/bitcoin · GitHub
09:31 < sdaftuar> as without 20561, self-announcements go out far less frequently 
09:32 < sdaftuar> curious what others think though
09:32 < sipa> agree
09:33 -!- Pavlenex [~Thunderbi@185.103.110.235] has joined #bitcoin-core-dev
09:33 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection]
09:34 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev
09:36 < MarcoFalke> I don't feel strongly what to backport and what not, I guess one question is how much are v3 addresses considered to be supported in 0.21.0
09:37 < MarcoFalke> Maybe it is best to leave it for 0.21.1 
09:38 < sdaftuar> i didn't quite understand how all this works -- is it the case that tor users who upgrade to 0.21 will suddenly switch to having a v3 address?
09:38 < sdaftuar> (sorry if this badly misunderstands how bitcoind and tor work together)
09:38 < sipa> sdaftuar: if they use tor autoconfig  yes
09:38 < sdaftuar> thanks -- that lines up with my own experience, i didn't know if i had done something unusual
09:38 < luke-jr> only v3?
09:38 < luke-jr> or also?
09:38 < sdaftuar> luke-jr: yes, as far as i can tell
09:39 < luke-jr> not sure that's a good idea
09:39 < sipa> only v3
09:39 < luke-jr> well, I guess they can still connect to v2 peers?
09:39 < sipa> yes
09:39 < sipa> as long as tor v2 isn"t disabled network-wide
09:39 < sipa> in 10 months or so
09:40 < luke-jr> wen bitcoin-dnsseed support v3? :P
09:40 < sipa> luke-jr: makes little sense, as they can't be exposed through dns
09:40 < luke-jr> sipa: can be exposed via web :x
09:41 < luke-jr> pretty sure they can be on DNS too tho
09:41 < luke-jr> just needs to use a different record type
09:42 < sipa> luke-jr: then we need actual DNS client functionality, and can't just use OS resolvers
09:44 < luke-jr> Tor won't do it for us?
09:45 < sipa> tor has no DNS resolving functionality as far as i know
09:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:45 < bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/ad3d4b3929ab...5b6f970e3fda
09:45 < bitcoin-git> bitcoin/master a07910a Antoine Riard: test: Makes wtxidrelay support a generic P2PInterface option
09:45 < bitcoin-git> bitcoin/master 06efb31 Antoine Riard: Add functional test test_txid_inv_delay
09:45 < bitcoin-git> bitcoin/master d3b5eac Antoine Riard: Add mutation for functional test test_preferred_inv
09:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:46 < bitcoin-git> [bitcoin] laanwj merged pull request #20171: Add functional test test_txid_inv_delay (master...2020-10-txid-delay-test) https://github.com/bitcoin/bitcoin/pull/20171
09:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:46 < sipa> there is a "connect me to this NAME" function that we use
09:46 < sipa> which does the resolving at an exit node and forwards the connection there
09:46 < sipa> but we never see the IP it resolved to
09:48 < wumpus> tor has DNS lookup support, however it only looks up one address, it cannot be used to get multiple results nor special records
09:48 < wumpus> (it's a socks5 extension which we don't use)
09:48 < wumpus> so indeed, DNS seeds are useless for it
09:49 < sipa> we could have seed nodes that are available for getaddr oneshot connections, exposed over hidden services
09:50 < wumpus> yes
09:50 < sipa> that may be a useful thing to add to my seeder
09:50 < sipa> PRs welcome :)
09:50 < sdaftuar> sipa: hm if we're relying on that we should revisit some of the issues we discussed in the last few months about how addrfetch connections work
09:51 < sdaftuar> actually, i think it's only an issue if the addrfetch peer you connect to is running bitcoin core, so maybe not an issue if your seeder is custom sofwtare with different behavior
09:52 < sipa> sdaftuar: when you run with onlynet=tor all DNS seed requests are converted into addrfetch connections to the DNS seeds
09:52 < sipa> which means it's doing an extra indirection
09:53 < sipa> this works fine, but it means seed requests do go outside of the tor network
09:54 < sdaftuar> when you say "we could have seed nodes that are available for getaddr one shot connections" - does that mean that we have hardcoded addresses available for that, or are you saying that there's a dns resolution that happens so that we would connect to a random bitcoin core node for the addrfetch behavior?
09:55 < sipa> my proposal is adding hardcoded addrfetchable hidden service addresses, which act as a seeder (and only support addrfetch), instead of as a full node
09:55 < sdaftuar> ah ok, that makes sense
09:56 < sdaftuar> i assume your seeder doesn't (eg) announce it's own address to the node that connects to it before responding to a getaddr request
09:56 < sdaftuar> as i think that behavior in bitcoin core causes problems with the addrfetch logic
10:00 < sipa> you can't connect to my seeder; its only publicly reachable interface is DNS
10:00 < sdaftuar> oh so "PRs welcome" meant we need to add quite a bit of functionality? :)
10:01 < sipa> yes :D
10:01 < sdaftuar> haha ok
10:01 < sipa> it does have support for bitcoin P2P connections though (as it uses those for crawling)
10:01 < sipa> but it doesn't listen
10:02 < sdaftuar> pretty sure if i tried to add listening support I'd end up letting your seeder get dosed in some way or other
10:02 < sipa> yeah... maybe it's better to do it as a patch to bitcoin core itself
10:06 < wumpus> sipa: i guess the first thing would be to make the crawler understand addrv2 and crawl torv3's, so that we have them in the list for hardcoded seeds
10:06 < sdaftuar> that seems straightforward. we basically just need a tool to manage the addrman a little more directly?
10:06 < sipa> yeah
10:07 < sipa> sdaftuar: my seeder does more than addrman, it keeps more statistics about connections and uptime
10:07 < sipa> but apart from that it's pretty similar
10:07 < sdaftuar> i was imagining that your seeder would run along side it, rather than be integrated into it?
10:07 < sdaftuar> but i don't know how feasible or practical that is
10:25 < Kiminuo> I have, out of frustration, changed CI tests from Ubuntu 18.04 to Ubuntu 20.04 and also bumped Clang (https://github.com/bitcoin/bitcoin/pull/19245/commits/cf948ffac6fc950066cd8975485a37a90d15ae07) but CI did not notice the change (https://github.com/bitcoin/bitcoin/runs/1562869764). Does CI require some sort of cache invalidation to do the build I want?
10:27 < Kiminuo> The idea being that I'm struggling with Ubuntu 18.04 & std::filesystem so when I upgrade to 20.04 for my https://github.com/bitcoin/bitcoin/pull/19245 I can at least move it an inch forward to have green tests.
10:28 < Kiminuo> And then I can attempt to lower dependencies back (clang, Ubuntu).
10:28 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds]
10:30 < Kiminuo> I have tested locally using https://github.com/bitcoin/bitcoin/tree/master/ci#configurations before pushing that commit and it was green for Win64 test.
10:38 < sipa> Kiminuo: i'm very confused by the travis output
10:38 < sipa> where are all the travis jobs?
10:39 < sipa> (unrelated to your PR)
10:39 < sipa> i just don't know where to look anymore
10:39 < Kiminuo> moved to cirrus?
10:39 < sipa> oh?
10:39 < sipa> oh it seems there are more cirrus jobs now
10:39 < Kiminuo> https://github.com/bitcoin/bitcoin/runs/1562869764 I can see tests on the left, can you?
10:40 < sipa> maybe there is just one travis job left, and that's why it isn't showing a list?
10:40 < Kiminuo> https://github.com/bitcoin/bitcoin/pull/20658 i think this PR moves completely testing from Travis to Cirrus CI
10:41 < Kiminuo> but that's just my impression, I just check bitcoin core PRs but not in-depth
10:41 < sipa> seems i completely missed that :)
10:41 < wumpus> yes, travis is being phased out
10:42 < wumpus> they are stopping the free tier
10:43 < sipa> i saw they're moving to travis-ci.com, but travis-ci.com does have a free option it seems?
10:43 < sipa> anyway, no objecting to moving
10:46 < wumpus> i thought more than just the name changed but i don't know the exact details
10:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:46 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5b6f970e3fda...427f8c2cff01
10:46 < bitcoin-git> bitcoin/master 8989577 Dmitry Petukhov: Fix length of R check in test/key_tests.cpp:key_signature_tests
10:46 < bitcoin-git> bitcoin/master 427f8c2 Wladimir J. van der Laan: Merge #20248: test: fix length of R check in key_signature_tests
10:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:46 < bitcoin-git> [bitcoin] laanwj merged pull request #20248: test: fix length of R check in key_signature_tests (master...fix-test-key-signature-low-r) https://github.com/bitcoin/bitcoin/pull/20248
10:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:46 < sipa> Kiminuo: the failing build you link so is a mingw build; it's not compiled with gcc or clang
10:46 < luke-jr> eh?
10:47 < luke-jr> mingw = gcc
10:47 < sipa> at least not the usual gcc or clang packages; it's based on the gcc codebase of course
10:51 < Kiminuo> sipa, but how come that it builds for me locally with: FILE_ENV="./ci/test/00_setup_env_win64.sh" ./ci/test_run_all.sh  ... meaning, in my Docker it seems to work but not on Cirrus CI
10:51 < sipa> perhaps you have a more recent mingw-w64?
10:52 < Kiminuo> but that's not possible, right? Docker is environment agnostic
10:52 < sipa> ok, then i have no clue, sorry :)
10:52 < sipa> i don't know anything about docker
10:52 < Kiminuo> well, CI tests run in Docker
10:53 < Kiminuo> so I'm very confused by this
10:53 < sipa> ping MarcoFalke?
10:55 < sipa> http://mingw-w64.org/doku.php/download makes me believe the latest mingw-w64 release is based on GCC 8.3.0
10:55 < sipa> but it's also possible i'm misinterpreting that, and mingw is really just some patchset/tooling that can be built with any underlying GCC version
10:57 -!- samuel-pedraza [47edaff3@gateway/web/cgi-irc/kiwiirc.com/ip.71.237.175.243] has quit [Quit: Connection closed]
10:59 < Kiminuo> yeah
11:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:01 < bitcoin-git> [bitcoin] vova557 opened pull request #20675: Vova557 (master...patch-11) https://github.com/bitcoin/bitcoin/pull/20675
11:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:03 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection]
11:03 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev
11:04 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 268 seconds]
11:07 -!- Pavlenex [~Thunderbi@185.103.110.235] has quit [Quit: Pavlenex]
11:07 < Kiminuo> sipa, I will need to find somebody who would like to finish that PR 19245. C++ building, linking and Bitcoin build system is not something I have adequate knowledge of. It takes me ages to move it an inch forward. I kind of did what I could. Can this be possibly discussed at a dev meeting?
11:08 < sipa> Kiminuo: sure; if you just want to leave up for grabs, no discussion necessary... but mentioning it in the meeting may help moving it forward
11:08 < Kiminuo> Another approach would be some "mentored approach". That is probably less ideal for me because I can help with programming side but not build side. And this PR needs the later.
11:09 < Kiminuo> right
11:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:09 < bitcoin-git> [bitcoin] sdaftuar opened pull request #20676: Replace m_tx_relay/nullptr checks in net_processing.cpp (master...2020-12-refactor-m_tx_relay) https://github.com/bitcoin/bitcoin/pull/20676
11:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:12 < jnewbery> sdaftuar: > we basically need a tool to manage the addrman a little more directly
11:13 < jnewbery> What are the requirements? We can add addresses to addrman using addpeeraddress. Shouldn't be too difficult to enhance that a bit more
11:13 < sdaftuar> jnewbery: i dunno, i might have misunderstood what sipa had in mind!
11:14 < sdaftuar> but the ability to add and remove addresses from addrman was what i was imagining was needed
11:16 < sipa> well, one option is to just integrate the dns seeder (excluding the dns serving feature and/or crawling, but at least the database part) into bitcoin core, and
11:16 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
11:16 < sipa> but that's probably not the right way
11:17 < sipa> another is to have a way of specifying on the command line "serve getaddr requests from data provided by $SCRIPT" or so, which would then be able to query a crawler
11:18 < sipa> and in either case, adding support for addrv2 to the crawler is probably a first step
11:20 < sdaftuar> i assume this is the code: https://github.com/sipa/bitcoin-seeder ?
11:20 < sipa> yes
11:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:30 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/427f8c2cff01...ae9ee5bdb18c
11:30 < bitcoin-git> bitcoin/master ea36a45 John Newbery: [net] Make p2p recv buffer timeout 20 minutes for all peers
11:30 < bitcoin-git> bitcoin/master ae9ee5b MarcoFalke: Merge #20651: net: Make p2p recv buffer timeout 20 minutes for all peers
11:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:30 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20651: net: Make p2p recv buffer timeout 20 minutes for all peers (master...2020-12-recv-buffer-timeout) https://github.com/bitcoin/bitcoin/pull/20651
11:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:32 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #20675: Vova557 (master...patch-11) https://github.com/bitcoin/bitcoin/pull/20675
11:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:36 < Kiminuo> @MarcoFalke, Hi, could you mark this https://github.com/bitcoin/bitcoin/pull/19245 PR with "up for grabs", "looking for help" or something in similar vein?
11:37 < Kiminuo> I have just modified the PR description to add as much as I know about the issue.
11:37 -!- Netsplit *.net <-> *.split quits: cncr04s
11:38 -!- cncr04s_ [~cncr04s@afxr.net] has joined #bitcoin-core-dev
11:47 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Read error: Connection reset by peer]
11:51 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
11:52 -!- peterrizzo [~peterrizz@ool-44c18924.dyn.optonline.net] has quit [Quit: peterrizzo]
11:52 -!- Dogechain [~Dogechain@84.39.117.57] has quit [Remote host closed the connection]
11:54 -!- peterrizzo [~peterrizz@ool-44c18924.dyn.optonline.net] has joined #bitcoin-core-dev
12:00 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 256 seconds]
12:01 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Quit: Leaving]
12:01 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has quit [Remote host closed the connection]
12:02 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has joined #bitcoin-core-dev
12:11 -!- cncr04s_ [~cncr04s@afxr.net] has quit [Quit: See you real soon!]
12:12 -!- Netsplit over, joins: cncr04s
12:13 -!- Guest98077 [~meoblast0@217.146.82.202] has joined #bitcoin-core-dev
12:15 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
12:29 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
13:00 -!- davterra [~davterra@107.182.237.19] has quit [Remote host closed the connection]
13:01 -!- joelklabo [~textual@108-196-216-127.lightspeed.sntcca.sbcglobal.net] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
13:05 -!- lightlike [~lightlike@p200300c7ef22ad008d562e74d2695fa7.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
13:10 -!- davterra [~davterra@107.182.237.19] has joined #bitcoin-core-dev
13:10 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev
13:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:13 < bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/ae9ee5bdb18c...4acbcfa97d20
13:13 < bitcoin-git> bitcoin/master 22437fc Carl Dong: build: Run libdmg-hfsplus's DMG tool in make deploy
13:13 < bitcoin-git> bitcoin/master 0df9819 fanquake: build: Replace genisoimage with xorriso
13:13 < bitcoin-git> bitcoin/master 7587d11 fanquake: build: remove cdrkit package from depends
13:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:13 -!- dermoth [~dermoth@unaffiliated/dermoth] has quit [Ping timeout: 265 seconds]
13:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:13 < bitcoin-git> [bitcoin] laanwj merged pull request #20470: build: Replace genisoimage with xorriso (master...2020-11-xorriso) https://github.com/bitcoin/bitcoin/pull/20470
13:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:15 -!- dermoth [~dermoth@unaffiliated/dermoth] has joined #bitcoin-core-dev
13:17 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Read error: Connection reset by peer]
13:18 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev
13:23 -!- lontivero_ [~lontivero@186.183.50.42] has quit [Ping timeout: 265 seconds]
13:26 < jeremyrubin> Has anyone dealt with mysterious undeclared identifier for template functions defined within a .cpp unit? E.g., I have template<T> foo.... defined but for some reason function bar trying to call foo says no such identifier?
13:27 < jeremyrubin> I'm able to compile the same code on one machine and not the other
13:27 < jeremyrubin> maybe a build cache bug... let me distclean
13:34 -!- Kiminuo [~mix@141.98.103.124] has quit [Quit: Leaving]
13:46 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:00 < andytoshi> is this in uint256.cpp? this has templates in a .cpp file and then "explicit instantiations" below that you need to add if you add any functions
14:00 < andytoshi> or more generally, if you have templates which live outside a header
14:02 < jeremyrubin> hmm yeah it was actually in script/interpreter with init.cpp
14:02 < jeremyrubin> maybe the clang on this VM can't instantiate a local method if it isn't explicit 
14:02 -!- Pavlenex [~Thunderbi@185.103.110.235] has joined #bitcoin-core-dev
14:03 < jeremyrubin> but I feel like something that is local only and not visible from header shouldn't need explicit inst?
14:03 < sipa> jeremyrubin: what's the actual code?
14:04 < sipa> i would be very surprised if any modern compiler has a bug w.r.t. this
14:04 < sipa> it's possible it's something that depends on what C++ version you're using, and some compilers permit stuff from future versions
14:05 < jeremyrubin> let me wait on a distclean rebuild... maybe some issue with that 
14:05 < jeremyrubin> this VPS is slow so will take a few
14:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:14 < bitcoin-git> [bitcoin] sdaftuar opened pull request #20677: doc: Remove shouty enums in net_processing comments (master...2020-12-remove-shouty-enums) https://github.com/bitcoin/bitcoin/pull/20677
14:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:15 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/4acbcfa97d20...1811e488d53b
14:15 < bitcoin-git> bitcoin/master 281cf99 practicalswift: Do not run functions with necessary side-effects in assert()
14:15 < bitcoin-git> bitcoin/master 5021810 practicalswift: Make CanFlushToDisk a const member function
14:15 < bitcoin-git> bitcoin/master 1811e48 Wladimir J. van der Laan: Merge #20575: Do not run functions with necessary side-effects in assert()...
14:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:15 < bitcoin-git> [bitcoin] laanwj merged pull request #20575: Do not run functions with necessary side-effects in assert() (master...side-effect-free-assert) https://github.com/bitcoin/bitcoin/pull/20575
14:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:19 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev
14:30 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Ping timeout: 264 seconds]
14:31 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
14:32 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
14:37 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Read error: Connection reset by peer]
14:39 -!- pinheadm_ [~pinheadmz@71.190.30.138] has quit [Quit: pinheadm_]
14:39 -!- pinheadmz [~pinheadmz@71.190.30.138] has joined #bitcoin-core-dev
14:55 -!- midnight [~midnight@unaffiliated/midnightmagic] has quit [Ping timeout: 272 seconds]
14:57 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
14:59 -!- midnight [~midnight@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
15:08 -!- az0re [~az0re@gateway/tor-sasl/az0re] has joined #bitcoin-core-dev
15:15 -!- midnight [~midnight@unaffiliated/midnightmagic] has quit [Ping timeout: 258 seconds]
15:18 -!- joelklabo [~textual@108-196-216-127.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
15:18 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev
15:19 -!- vincenzopalazzo [~vincent@2001:b07:6474:9d49:1cd0:876b:6bfb:cb4a] has quit [Remote host closed the connection]
15:23 -!- Pavlenex [~Thunderbi@185.103.110.235] has quit [Quit: Pavlenex]
15:33 -!- midnight [~midnight@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
15:44 -!- miketwen_ [~miketwent@ec2-3-216-176-187.compute-1.amazonaws.com] has quit [Remote host closed the connection]
15:53 -!- miketwenty1 [~miketwent@ec2-3-216-176-187.compute-1.amazonaws.com] has joined #bitcoin-core-dev
16:08 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Read error: Connection reset by peer]
16:11 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Read error: Connection reset by peer]
16:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
16:17 < bitcoin-git> [bitcoin] sh-abhi opened pull request #20678: Add on autoconf as a dependency when building on macOS (master...autoconf-dependency) https://github.com/bitcoin/bitcoin/pull/20678
16:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
16:29 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 268 seconds]
16:29 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev
16:34 -!- peterrizzo [~peterrizz@ool-44c18924.dyn.optonline.net] has quit [Quit: peterrizzo]
16:41 < jeremyrubin> sipa: andytoshi: I think it was just something about having templates declared in the header, and defined in the .cpp and not explicitly specialized was making this specific clang unhappy. Other versions seem to resolve it ok... so not sure what's up w/ that.
16:42 < jeremyrubin> for now I guess problem solved
16:50 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:cecf:313a:ef0a:c021:651e] has joined #bitcoin-core-dev
17:01 -!- jesseposner [~jp@2601:645:200:162f:6076:878b:f936:e5fc] has joined #bitcoin-core-dev
17:03 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has quit [Remote host closed the connection]
17:03 -!- jesseposner [~jp@2601:645:200:162f:6076:878b:f936:e5fc] has quit [Client Quit]
17:04 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has joined #bitcoin-core-dev
17:08 -!- lontivero [~lontivero@186.183.50.181] has joined #bitcoin-core-dev
17:09 -!- Highway61 [~Thunderbi@unaffiliated/highway61] has quit [Remote host closed the connection]
17:16 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
17:24 -!- Netsplit *.net <-> *.split quits: helo, valwal_, phantomcircuit, infernix, takinbo, amiti, michaelfolkson, da39a3ee5e6b4b0d, hhghhkqweaeasd, real_or_random,  (+7 more, use /NETSPLIT to show all of them)
17:30 -!- Netsplit over, joins: takinbo, RubenSomsen, da39a3ee5e6b4b0d, amiti, achow101, michaelfolkson, windsok, real_or_random, phantomcircuit, ccook (+7 more)
17:33 -!- instagibbs [~greg@061093103011.ctinets.com] has quit [Ping timeout: 256 seconds]
17:36 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
17:36 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services]
17:36 -!- vasild_ is now known as vasild
17:38 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Quit: Leaving]
17:44 -!- az0re [~az0re@gateway/tor-sasl/az0re] has quit [Quit: Leaving]
17:52 -!- potato [~Thunderbi@240d:1a:3d4:7d00:e8f9:dc3f:1a8d:3976] has joined #bitcoin-core-dev
17:55 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
17:58 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection]
17:58 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
18:26 < dhruvm> CI re-run please? https://cirrus-ci.com/task/5046307649748992
18:51 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
18:52 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 246 seconds]
18:54 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
19:01 -!- jesseposner [~jp@2601:645:200:162f:a05d:e05c:c95e:bea7] has joined #bitcoin-core-dev
19:03 -!- pinheadmz [~pinheadmz@71.190.30.138] has quit [Quit: pinheadmz]
19:07 -!- pinheadmz [~pinheadmz@71.190.30.138] has joined #bitcoin-core-dev
19:09 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:cecf:313a:ef0a:c021:651e] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
19:11 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:cecf:bc4d:596d:63fe:f2dd] has joined #bitcoin-core-dev
19:21 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:cecf:bc4d:596d:63fe:f2dd] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
19:23 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:cecf:bc4d:596d:63fe:f2dd] has joined #bitcoin-core-dev
19:46 -!- pinheadmz [~pinheadmz@71.190.30.138] has quit [Read error: Connection reset by peer]
19:49 -!- pinheadmz [~pinheadmz@71.190.30.138] has joined #bitcoin-core-dev
19:53 -!- davterra [~davterra@107.182.237.19] has quit [Ping timeout: 268 seconds]
19:55 -!- onokatio [~Thunderbi@91.193.7.56] has joined #bitcoin-core-dev
19:55 -!- onokatio [~Thunderbi@91.193.7.56] has quit [Client Quit]
20:17 -!- hirish [~hirish@ip85.ip-137-74-20.eu] has joined #bitcoin-core-dev
20:18 -!- hirish_ [~hirish@ip85.ip-137-74-20.eu] has quit [Ping timeout: 256 seconds]
20:21 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:cecf:bc4d:596d:63fe:f2dd] has quit [Quit: Textual IRC Client: www.textualapp.com]
20:37 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:cecf:c08f:f3d8:5294:ef76] has joined #bitcoin-core-dev
20:54 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
21:17 -!- Guest98077 [~meoblast0@217.146.82.202] has quit [Remote host closed the connection]
21:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
21:19 < bitcoin-git> [bitcoin] fanquake closed pull request #20504: build: use more legible (q)make commands in qt package (master...legible_qt_config_cmds) https://github.com/bitcoin/bitcoin/pull/20504
21:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
21:30 -!- miketwenty1 [~miketwent@ec2-3-216-176-187.compute-1.amazonaws.com] has quit [Remote host closed the connection]
21:34 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds]
21:36 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
21:37 -!- Guest60747 [~geekosaur@84.39.117.57] has joined #bitcoin-core-dev
21:38 < fanquake> It's strange how people fight against dropping support for versions of macOS (at the potential detriment of the rest of the project), while at the same time seemingly have no issue with dropping support for versions of operating systems that are almost certainly used by more Bitcoin Core users, and/or are supported for far longer into the future.
21:39 < gwillen> I assume people mostly fight in favor of supporting OSes they use themselves
21:39 < gwillen> I don't know how far back with go with macOS, but e.g. I'm on 10.14.6, so if that got dropped I basically couldn't use or work on the project anymore
21:40 < sipa> fanquake: which one are people discussing dropping?
21:40 < fanquake> sipa: https://github.com/bitcoin/bitcoin/issues/20627#issuecomment-747216439 moving to using Qt 6 would drop support for Windows 7 & 8.x, as well as Ubuntu 18.04.
21:42 < sipa> fanquake: i thought it was just a suggested or build dependency
21:43 < sipa> if it breaks window 8 / ubuntu 18.04 that seems like a no go
21:43 < sipa> could we use qt6 for osx, and qt5 for the rest?
21:43 < sipa> *macos
21:45 < gwillen> it seems that dongcarl doesn't think it would break those platforms, judging from his comment -- it seems like there is some question as to what exactly Qt6 claims to support / actually supports
21:46 < fanquake> sipa: as far as I know those are runtime requirements
21:46 < sipa> well we'd need to know
21:46 < fanquake> Me and Carl also discussed in the builds channel this morning
21:50 < sipa> if it's easy for source to be compatible with both it may make sense to use qt6 on macos depends builds, and qt5 for others
21:52 < luke-jr> well we need to support building with Qt5 anyway
21:53 < luke-jr> it'll be a while before distros deploy Qt6
21:56 < dhruvm> May I request a CI re-run? https://cirrus-ci.com/task/5046307649748992
21:56 < dhruvm> (If there's another easier than to ask here, please let me know)
21:56 < dhruvm> *another easier way
21:56 < sipa> done
21:57 < sipa> not sure what's needed to give people permission to restart cirrus
21:57 < fanquake> Not even sure if I can restart Cirrus at the moment 😅
21:57 -!- lontivero [~lontivero@186.183.50.181] has quit [Ping timeout: 264 seconds]
21:58 < dhruvm> I am in the right place then :D
22:00 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
22:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
22:03 < bitcoin-git> [bitcoin] fanquake closed pull request #20600: Depends : Qt Use Top-Level Structure (master...add-qml-depends) https://github.com/bitcoin/bitcoin/pull/20600
22:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
22:04 -!- Guest60747 [~geekosaur@84.39.117.57] has quit [Remote host closed the connection]
22:10 -!- Guest58575 [~ds@185.204.1.185] has joined #bitcoin-core-dev
22:11 -!- IGHOR [~quassel@176.121.4.135] has quit [Quit: http://quassel-irc.org ? ??????????? ?????????. ????-??.]
22:19 -!- IGHOR [~quassel@176.121.4.135] has joined #bitcoin-core-dev
22:28 -!- mrostecki [mrostecki@nat/suse/x-wasokcvpgafclwxo] has quit [Quit: WeeChat 1.8]
22:43 < MarcoFalke> I think to reset Cirrus CI, you'd need to be added to the Bitcoin Core project and then authed on Cirrus via GitHub
23:06 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:cecf:c08f:f3d8:5294:ef76] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
23:12 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
23:13 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
23:15 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds]
23:16 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 240 seconds]
23:17 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
23:17 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
23:20 -!- da39a3ee5e6b4b0d [~da39a3ee5@49.228.254.151] has joined #bitcoin-core-dev
23:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:24 < bitcoin-git> [bitcoin] rex4539 opened pull request #20679: Fix insecure links (master...https) https://github.com/bitcoin/bitcoin/pull/20679
23:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:24 < bitcoin-git> [bitcoin] fanquake closed pull request #20679: Fix insecure links (master...https) https://github.com/bitcoin/bitcoin/pull/20679
23:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:36 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 240 seconds]
23:36 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 240 seconds]
23:37 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
23:37 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
23:45 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has quit [Read error: Connection reset by peer]
23:46 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has joined #bitcoin-core-dev
--- Log closed Thu Dec 17 00:00:48 2020