--- Log opened Fri Dec 18 00:00:52 2020
00:01 < wumpus> jeremyrubin: correct, i think
00:03 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
00:05 -!- da39a3ee5e6b4b0d [~da39a3ee5@49.228.254.151] has joined #bitcoin-core-dev
00:16 -!- jessepos_ [~jp@2601:645:200:162f:f9e7:eb3b:d9b9:fb74] has joined #bitcoin-core-dev
00:19 -!- jesseposner [~jp@2601:645:200:162f:a05d:e05c:c95e:bea7] has quit [Ping timeout: 260 seconds]
00:53 -!- jesseposner [~jp@2601:645:200:162f:9cea:b906:dc79:8b94] has joined #bitcoin-core-dev
00:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:54 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3dd3f7c0af7e...20f4a9421ba6
00:54 < bitcoin-git> bitcoin/master faeb40b MarcoFalke: ci: Install missing lint packages
00:54 < bitcoin-git> bitcoin/master 20f4a94 MarcoFalke: Merge #20682: ci: Install missing lint packages
00:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:55 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20682: ci: Install missing lint packages (master...2012-testDel) https://github.com/bitcoin/bitcoin/pull/20682
00:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:57 -!- jessepos_ [~jp@2601:645:200:162f:f9e7:eb3b:d9b9:fb74] has quit [Ping timeout: 268 seconds]
01:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:04 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/20f4a9421ba6...83e4670fd7cd
01:04 < bitcoin-git> bitcoin/master 6d1e85f Suhas Daftuar: Clean up logging of outbound connection type
01:04 < bitcoin-git> bitcoin/master 83e4670 MarcoFalke: Merge #20690: Clean up logging of outbound connection type
01:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:04 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20690: Clean up logging of outbound connection type (master...2020-12-clean-up-outbound-logging) https://github.com/bitcoin/bitcoin/pull/20690
01:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:07 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has quit [Read error: Connection reset by peer]
01:09 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has joined #bitcoin-core-dev
01:11 < vasild> wumpus: if UPnP is "phased out", what about routers that only support UPnP?
01:20 -!- jessepos_ [~jp@2601:645:200:162f:4081:3039:8161:4792] has joined #bitcoin-core-dev
01:23 < vasild> gleb: wrt https://github.com/bitcoin/bitcoin/pull/20685#issuecomment-747959538 -- by "non-popular overlay" do you mean I2P? What "privacy/security side-effects" side effects?
01:24 -!- jesseposner [~jp@2601:645:200:162f:9cea:b906:dc79:8b94] has quit [Ping timeout: 264 seconds]
01:34 < gleb> vasild: Yeah, if there's only a handful of I2P nodes in the network, and a user wants to run on I2P exclusively — that'd be pretty risky.
01:34 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
01:34 < gleb> Consider an eclipse attack or traffic analysis
01:35 < gleb> On the Bitcoin p2p protocol layer I mean.
01:35 < vasild> ah, this one, I see
01:36 < vasild> yeah, running i2p _exclusively_ in the beginning (first 7 years) will may be not a good idea :)
01:37 < vasild> that belongs to doc/i2p.md (not existent yet)
01:37 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Ping timeout: 265 seconds]
01:39 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-dev
01:39 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Changing host]
01:39 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev
01:53 -!- da39a3ee5e6b4b0d [~da39a3ee5@49.228.254.151] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
01:55 -!- jesseposner [~jp@2601:645:200:162f:359d:6f20:f957:7c54] has joined #bitcoin-core-dev
01:58 -!- jessepos_ [~jp@2601:645:200:162f:4081:3039:8161:4792] has quit [Ping timeout: 260 seconds]
02:01 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has quit [Read error: Connection reset by peer]
02:02 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has joined #bitcoin-core-dev
02:04 -!- kexkey [~kexkey@static-198-54-132-110.cust.tzulo.com] has quit [Ping timeout: 246 seconds]
02:05 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds]
02:31 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
02:33 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
02:36 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds]
02:39 -!- gh0str3c0n [~gh0str3c0@105.112.131.33] has joined #bitcoin-core-dev
02:40 -!- jessepos_ [~jp@2601:645:200:162f:b8f8:3090:90c1:84f] has joined #bitcoin-core-dev
02:40 -!- gh0str3c0n [~gh0str3c0@105.112.131.33] has quit [Client Quit]
02:43 -!- jesseposner [~jp@2601:645:200:162f:359d:6f20:f957:7c54] has quit [Ping timeout: 264 seconds]
02:45 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
02:51 < wumpus> vasild: how much is that really still a thing?
02:51 < vasild> no idea
02:52 < wumpus> i think UPnP is a terrible protocol, but I'm biased because the only RCE for bitcoin core that I know of used a UPnP xml parsing vulnerability
02:53 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 240 seconds]
02:54 < wumpus> one advantage of NATPMP/PCP is that the protocol consists of super simple binary packets, doesn't involve that kind of parsing at all
02:54 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
02:54 < wumpus> so we could even consider enabling it by default
02:55 < hebasto> ^ +1
02:55 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
02:57 -!- jesseposner [~jp@2601:645:200:162f:942e:52e4:5e83:4e03] has joined #bitcoin-core-dev
02:57 < vasild> Sure, if no downsides. What is that "random ports mapping" luke-jr mentioned (https://github.com/bitcoin/bitcoin/pull/18077#issuecomment-588484002)?
02:57 < wumpus> but yes that's separate from the question 'should it be supported at all', i don't think upnp support is much code to maintain and if it's disabled by default it's low risk so i don't actually feel strongly about that
02:57 < wumpus> i have no idea i have never heard that before
02:58 < wumpus> basically i just though the 'NAT PMP is a low priority protocol' was a strange comment
02:58 < vasild> it is
02:59 < vasild> (strange comment)
03:00 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev
03:00 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net]
03:00 -!- jessepos_ [~jp@2601:645:200:162f:b8f8:3090:90c1:84f] has quit [Ping timeout: 258 seconds]
03:00 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
03:03 < wumpus> i think the NAT PMP PR is almost ready, the code change looks good to me and it works, we should definitely have it in 0.22
03:04 < wumpus> discussion on whether to enable it by default or whether or not to deprecate UPnP doesn't need to be at the same time
03:05 < wumpus> right now it adds it as an opt-in feature just like UPnP that's a good way to get started
03:06 < wumpus> never delay anything on decisions that might be controversial or we'll still be waiting for it to get merged in 2025 :-)
03:13 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.29.10] has joined #bitcoin-core-dev
03:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:17 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/83e4670fd7cd...f1dbf92ff047
03:17 < bitcoin-git> bitcoin/master 634f6ec Wladimir J. van der Laan: contrib: Parse ELF directly for symbol and security checks
03:17 < bitcoin-git> bitcoin/master a0a7718 Luke Dashjr: contrib: Changes to checks for PowerPC64
03:17 < bitcoin-git> bitcoin/master f1dbf92 Wladimir J. van der Laan: Merge #20434: contrib: Parse ELF directly for symbol and security checks
03:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:18 < bitcoin-git> [bitcoin] laanwj merged pull request #20434: contrib: Parse ELF directly for symbol and security checks (master...2020_11_pixie) https://github.com/bitcoin/bitcoin/pull/20434
03:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:29 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Quit: Pavlenex]
03:31 -!- RISCi_ATOM1 [~RISCi_ATO@84.39.117.57] has quit [Remote host closed the connection]
03:37 -!- peterrizzo [~peterrizz@ool-44c18924.dyn.optonline.net] has joined #bitcoin-core-dev
03:44 -!- jessepos_ [~jp@2601:645:200:162f:c4c5:f1a2:d167:ddbe] has joined #bitcoin-core-dev
03:48 -!- jesseposner [~jp@2601:645:200:162f:942e:52e4:5e83:4e03] has quit [Ping timeout: 260 seconds]
03:48 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.29.10] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
03:52 -!- joeykrim1 [~joeykrim@184.75.221.35] has joined #bitcoin-core-dev
03:57 -!- jesseposner [~jp@2601:645:200:162f:b09d:272e:2a8b:923] has joined #bitcoin-core-dev
04:00 -!- jessepos_ [~jp@2601:645:200:162f:c4c5:f1a2:d167:ddbe] has quit [Ping timeout: 264 seconds]
04:06 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Read error: Connection reset by peer]
04:06 -!- Pavlenex [~Thunderbi@141.98.103.251] has joined #bitcoin-core-dev
04:08 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev
04:10 -!- Pavlenex [~Thunderbi@141.98.103.251] has quit [Client Quit]
04:12 -!- joeykrim1 [~joeykrim@184.75.221.35] has quit [Ping timeout: 256 seconds]
04:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:19 < bitcoin-git> [bitcoin] hebasto opened pull request #20697: ci: Fix COMMIT_RANGE variable value  (master...201218-range) https://github.com/bitcoin/bitcoin/pull/20697
04:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:20 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
04:25 -!- jessepos_ [~jp@2601:645:200:162f:8920:56b:4b8c:29fc] has joined #bitcoin-core-dev
04:25 -!- phillip [~phillip@217.146.82.202] has joined #bitcoin-core-dev
04:27 < promag> block kuaixbdsk3738?
04:28 -!- jesseposner [~jp@2601:645:200:162f:b09d:272e:2a8b:923] has quit [Ping timeout: 268 seconds]
04:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:33 < bitcoin-git> [bitcoin] romanz opened pull request #20702: rpc: Add getblocklocations  (master...locations) https://github.com/bitcoin/bitcoin/pull/20702
04:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:59 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-10.dynamic.3bb.co.th] has joined #bitcoin-core-dev
05:03 -!- jesseposner [~jp@2601:645:200:162f:5df7:4664:563e:a339] has joined #bitcoin-core-dev
05:07 -!- jessepos_ [~jp@2601:645:200:162f:8920:56b:4b8c:29fc] has quit [Ping timeout: 260 seconds]
05:15 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
05:19 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds]
05:19 < wumpus> promag: what did they do ?
05:28 -!- Aaronvan_ is now known as AaronvanW
05:30 -!- phillip [~phillip@217.146.82.202] has quit [Remote host closed the connection]
05:31 -!- Jaykul1 [~Jaykul@185.103.96.147] has joined #bitcoin-core-dev
05:36 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
05:36 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services]
05:36 -!- vasild_ is now known as vasild
05:36 < promag> wumpus: create a bunch of dumb issues afaict
05:41 -!- glozow [uid453516@gateway/web/irccloud.com/x-cmrzaiubcrrifiqv] has joined #bitcoin-core-dev
05:41 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-10.dynamic.3bb.co.th] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
05:43 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.29.10] has joined #bitcoin-core-dev
05:47 -!- jessepos_ [~jp@2601:645:200:162f:d0d4:6fc8:58da:772f] has joined #bitcoin-core-dev
05:51 -!- jesseposner [~jp@2601:645:200:162f:5df7:4664:563e:a339] has quit [Ping timeout: 264 seconds]
05:52 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has quit [Ping timeout: 256 seconds]
05:58 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
05:59 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
06:03 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection]
06:03 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
06:03 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Write error: Broken pipe]
06:03 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev
06:03 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
06:03 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
06:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:07 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20715: util: Add ArgsManager::GetCommands() and use it in bitcoin-wallet (master...2012-argsCmd) https://github.com/bitcoin/bitcoin/pull/20715
06:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:10 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev
06:28 -!- jesseposner [~jp@2601:645:200:162f:6dfe:6561:a145:b640] has joined #bitcoin-core-dev
06:31 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.29.10] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
06:31 -!- jessepos_ [~jp@2601:645:200:162f:d0d4:6fc8:58da:772f] has quit [Ping timeout: 260 seconds]
06:34 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-10.dynamic.3bb.co.th] has joined #bitcoin-core-dev
06:39 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-10.dynamic.3bb.co.th] has quit [Ping timeout: 240 seconds]
06:41 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-10.dynamic.3bb.co.th] has joined #bitcoin-core-dev
06:47 -!- _0x0ff [~potatoe@2001:bc8:47b0:123::1] has quit [Changing host]
06:47 -!- _0x0ff [~potatoe@unaffiliated/0x0ff/x-1210984] has joined #bitcoin-core-dev
06:48 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Ping timeout: 240 seconds]
06:50 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
06:54 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 264 seconds]
06:55 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 264 seconds]
06:56 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
06:59 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 256 seconds]
07:00 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev
07:00 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Remote host closed the connection]
07:00 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev
07:01 -!- jessepos_ [~jp@2601:645:200:162f:5097:9b7d:9170:ce6f] has joined #bitcoin-core-dev
07:04 -!- jesseposner [~jp@2601:645:200:162f:6dfe:6561:a145:b640] has quit [Ping timeout: 260 seconds]
07:07 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
07:07 -!- _0x0ff [~potatoe@unaffiliated/0x0ff/x-1210984] has quit [Quit: into the offlines]
07:08 -!- _0x0ff [~potatoe@163.172.166.225] has joined #bitcoin-core-dev
07:08 -!- _0x0ff [~potatoe@163.172.166.225] has quit [Changing host]
07:08 -!- _0x0ff [~potatoe@unaffiliated/0x0ff/x-1210984] has joined #bitcoin-core-dev
07:31 -!- jonatack [~jon@213.152.186.173] has quit [Ping timeout: 268 seconds]
07:40 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev
07:41 -!- miketwen_ [~miketwent@ec2-3-83-70-127.compute-1.amazonaws.com] has joined #bitcoin-core-dev
07:42 -!- jesseposner [~jp@2601:645:200:162f:81ee:e2b7:1499:d389] has joined #bitcoin-core-dev
07:43 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 240 seconds]
07:46 -!- jessepos_ [~jp@2601:645:200:162f:5097:9b7d:9170:ce6f] has quit [Ping timeout: 268 seconds]
07:48 -!- greypw [~greypw@unaffiliated/greypw] has quit [Quit: I'll be back!]
07:49 -!- greypw [~greypw@unaffiliated/greypw] has joined #bitcoin-core-dev
07:51 -!- peterrizzo [~peterrizz@ool-44c18924.dyn.optonline.net] has quit [Quit: peterrizzo]
07:57 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
07:58 -!- jessepos_ [~jp@2601:645:200:162f:952d:242:9592:26e] has joined #bitcoin-core-dev
08:00 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 268 seconds]
08:01 -!- belcher_ is now known as belcher
08:02 -!- jesseposner [~jp@2601:645:200:162f:81ee:e2b7:1499:d389] has quit [Ping timeout: 264 seconds]
08:05 -!- joelklabo [~textual@108-196-216-127.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
08:06 -!- peterrizzo [~peterrizz@ool-44c18924.dyn.optonline.net] has joined #bitcoin-core-dev
08:11 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds]
08:19 -!- da39a3ee5e6b4b0d [~da39a3ee5@mx-ll-171.5.29-10.dynamic.3bb.co.th] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
08:20 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
08:28 -!- lightningbot [~supybot@2400:8901::f03c:91ff:febb:bbc1] has quit [Remote host closed the connection]
08:28 -!- lightningbot [~supybot@2400:8901::f03c:91ff:febb:bbc1] has joined #bitcoin-core-dev
08:30 -!- jesseposner [~jp@2601:645:200:162f:f8ca:2dd4:5b19:c33c] has joined #bitcoin-core-dev
08:34 -!- jessepos_ [~jp@2601:645:200:162f:952d:242:9592:26e] has quit [Ping timeout: 258 seconds]
08:36 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds]
08:47 -!- peterrizzo [~peterrizz@ool-44c18924.dyn.optonline.net] has quit [Quit: peterrizzo]
08:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:49 < bitcoin-git> [bitcoin] hebasto opened pull request #20716: ci: Fix COMMIT_RANGE variable value for cloned repos (master...201218-cloned) https://github.com/bitcoin/bitcoin/pull/20716
08:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:50 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
08:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:55 < bitcoin-git> [bitcoin] hebasto closed pull request #20716: ci: Fix COMMIT_RANGE variable value for cloned repos (master...201218-cloned) https://github.com/bitcoin/bitcoin/pull/20716
08:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:55 < bitcoin-git> [bitcoin] hebasto reopened pull request #20716: ci: Fix COMMIT_RANGE variable value for cloned repos (master...201218-cloned) https://github.com/bitcoin/bitcoin/pull/20716
08:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:02 < bitcoin-git> [bitcoin] hebasto closed pull request #20716: ci: Fix COMMIT_RANGE variable value for cloned repos (master...201218-cloned) https://github.com/bitcoin/bitcoin/pull/20716
09:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:05 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection]
09:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:05 < bitcoin-git> [bitcoin] hebasto opened pull request #20717: ci: Fix COMMIT_RANGE variable value for cloned repos (master...201218-clone) https://github.com/bitcoin/bitcoin/pull/20717
09:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:05 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Read error: Connection reset by peer]
09:06 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
09:06 < hebasto> cirrus builds somehow are not triggefred by new prs
09:18 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev
09:20 -!- hhghhkqweaeasd [~flack@p200300d46f24de0023b487635c149e9b.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!]
09:27 -!- kexkey [~kexkey@static-198-54-132-138.cust.tzulo.com] has joined #bitcoin-core-dev
09:32 -!- lightningbot [~supybot@2400:8901::f03c:91ff:febb:bbc1] has quit [Remote host closed the connection]
09:33 -!- aj [aj@cerulean.erisian.com.au] has quit [Ping timeout: 240 seconds]
09:41 < wumpus> promag: cannot find the account at all
09:43 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds]
09:44 -!- aj [aj@cerulean.erisian.com.au] has joined #bitcoin-core-dev
09:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:51 < bitcoin-git> [gui] luke-jr opened pull request #157: Refactor P2PKH filtering, via AddressBookSortFilterProxyModel (master...gui_filter_p2pkh) https://github.com/bitcoin-core/gui/pull/157
09:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:53 -!- lightningbot [~supybot@cerulean.erisian.com.au] has joined #bitcoin-core-dev
09:59 < hebasto> sorry for mess with the recent prs open-close, but I have no clue why cirrus is down on the main repo, and it works fine in the gui repo
10:02 -!- peterrizzo [~peterrizz@ool-44c18924.dyn.optonline.net] has joined #bitcoin-core-dev
10:03 -!- peterrizzo [~peterrizz@ool-44c18924.dyn.optonline.net] has quit [Client Quit]
10:05 -!- alko89 [~alko89@unaffiliated/alko89] has quit [Quit: ZNC 1.7.5 - https://znc.in]
10:05 -!- lightningbot [~supybot@cerulean.erisian.com.au] has quit [Ping timeout: 240 seconds]
10:05 -!- alko89 [~alko89@unaffiliated/alko89] has joined #bitcoin-core-dev
10:06 -!- aj [aj@cerulean.erisian.com.au] has quit [Ping timeout: 272 seconds]
10:13 -!- aj [aj@cerulean.erisian.com.au] has joined #bitcoin-core-dev
10:14 < promag> wumpus: fanquake took care of it
10:15 -!- peterrizzo_ [~peterrizz@ool-44c18924.dyn.optonline.net] has joined #bitcoin-core-dev
10:15 -!- lightningbot [~supybot@2400:8901::f03c:91ff:febb:bbc1] has joined #bitcoin-core-dev
10:15 -!- jeremyrubin [~jr@c-73-15-215-148.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
10:40 -!- proofofkeags [~proofofke@174-16-212-53.hlrn.qwest.net] has joined #bitcoin-core-dev
10:58 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit []
11:00 -!- jonatack [~jon@88.124.242.136] has joined #bitcoin-core-dev
11:01 < jonatack> wallet meeting?
11:02 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
11:02 < jonatack> (or is it off until next year)
11:02 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection]
11:02 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev
11:03 < jonatack> e.g. Jan 1st, or more likely, 15th
11:03 < achow101> last wallet meeting of this year
11:03 -!- kiltzman [~k1ltzman@195.189.99.96] has joined #bitcoin-core-dev
11:03 < achow101> #startmeeting
11:03 < core-meetingbot> Meeting started Fri Dec 18 19:03:49 2020 UTC.  The chair is achow101. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
11:03 < core-meetingbot> Available commands: action commands idea info link nick
11:03 < emzy> hi
11:03 < jonatack> huzzah
11:04 < achow101> #bitcoin-core-dev Wallet Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik petertodd phantomcircuit promag provoostenator 
11:04 < achow101> ryanofsky sdaftuar sipa vasild wumpus
11:04 < achow101> any topics?
11:06 < achow101> i suppose we're all focused on 0.21 right now
11:08 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 260 seconds]
11:08 < achow101> ok then. next meeting will be Jan 15
11:09 < achow101> #endmeeting
11:09 < core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
11:09 < core-meetingbot> Meeting ended Fri Dec 18 19:09:00 2020 UTC.  
11:09 < core-meetingbot> Minutes:        https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2020/bitcoin-core-dev.2020-12-18-19.03.moin.txt
11:09 < sipa>  that was fast
11:10 -!- jonatack [~jon@88.124.242.136] has joined #bitcoin-core-dev
11:10 < jonatack> sorry, freenode keeps kicking me off, it doesn't like my vpn
11:14 -!- Jaykul1 [~Jaykul@185.103.96.147] has quit [Remote host closed the connection]
11:14 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
11:18 -!- peterrizzo_ [~peterrizz@ool-44c18924.dyn.optonline.net] has quit [Quit: peterrizzo_]
11:28 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 272 seconds]
11:29 -!- jonatack [~jon@213.152.162.154] has joined #bitcoin-core-dev
11:35 -!- RC-3004 [~RC-3004@84.39.117.57] has joined #bitcoin-core-dev
11:48 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 264 seconds]
11:48 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
11:49 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
12:02 -!- dermoth [~dermoth@unaffiliated/dermoth] has quit [Ping timeout: 240 seconds]
12:10 -!- glozow [uid453516@gateway/web/irccloud.com/x-cmrzaiubcrrifiqv] has quit [Quit: Connection closed for inactivity]
12:24 -!- virtu [~virtu@gateway/tor-sasl/virtu] has quit [Ping timeout: 240 seconds]
12:47 -!- virtu [~virtu@gateway/tor-sasl/virtu] has joined #bitcoin-core-dev
12:50 -!- dermoth [~dermoth@unaffiliated/dermoth] has joined #bitcoin-core-dev
13:01 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 264 seconds]
13:10 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev
13:13 -!- miketwen_ [~miketwent@ec2-3-83-70-127.compute-1.amazonaws.com] has quit [Ping timeout: 246 seconds]
13:19 -!- glozow [uid453516@gateway/web/irccloud.com/x-yjlujyyyfvchoyym] has joined #bitcoin-core-dev
13:30 -!- flag [~flag@net-93-66-71-105.cust.vodafonedsl.it] has quit [Ping timeout: 260 seconds]
13:31 -!- flag [~flag@net-93-66-71-105.cust.vodafonedsl.it] has joined #bitcoin-core-dev
13:33 -!- miketwen_ [~miketwent@ec2-3-83-70-127.compute-1.amazonaws.com] has joined #bitcoin-core-dev
13:37 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 265 seconds]
13:53 < achow101> would it be desirable for the MacOS code signing tool to still use codesign_allocate?
13:53 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
13:53 < sipa> do you think you can easily replicate it in python?
13:54 < achow101> not really. it seems like macholib doesn't quite do what we need, so I would need to implement my own macho parser and modifier
13:54 < achow101> and that is decidely non trivial
13:54 < sipa> no need then, i think
13:54 < sipa> there is a working open-source tool that does this
13:55 < achow101> right, we just need the signer to also use that
13:55 < sipa> indeed
13:55 < sipa> (and the right one!)
13:56 < achow101> at least it's an easy problem to fix and solve since this works on non-macs too
13:56 < achow101> and won't enforce apple signed codesign_allocate
13:57 < sipa> and if you so desire, the functionality could be added to your tool later with no downsides
14:04 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:16 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
14:17 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
14:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
14:30 -!- filchef [~filchef@89.253.179.83] has joined #bitcoin-core-dev
14:52 -!- filchef [~filchef@89.253.179.83] has quit [Read error: Connection reset by peer]
15:09 < andytoshi> i'm having trouble building the fuzztests and i can't remember what i did last week that made it work
15:09 < andytoshi> getting stuff like
15:09 < andytoshi> /home/apoelstra/code/bitcoin/bitcoin/fuzz/src/./test/fuzz/fuzz.h:18: multiple definition of `FuzzFrameworkEmptyFun()'; test/fuzz/fuzz-addition_overflow.o:/home/apoelstra/code/bitcoin/bitcoin/fuzz/src/./test/fuzz/fuzz.h:18: first defined here
15:09 < andytoshi> lots of these "multiple definition" errosr
15:12 < sipa> this may be a result of #20560 being merged; does a make clean help?
15:12 < gribble> https://github.com/bitcoin/bitcoin/issues/20560 | fuzz: Link all targets once by MarcoFalke · Pull Request #20560 · bitcoin/bitcoin · GitHub
15:12 < sipa> or a re-configuree
15:12 < andytoshi> sipa: no, i've done lots of `make distclean` and `git clean -xf`, switching between clang and gcc, etc
15:13 < andytoshi> thanks, i'll take a look at 20560 and try reverting it
15:13 < sipa> how are you ./configure'ing?
15:13 < andytoshi> ./configure --with-incompatible-bdb CPPFLAGS='-DARENA_DEBUG -DDEBUG_LOCKORDER' --with-sanitizers=address,integer,undefined CC=clang CXX='clang++'  --enable-fuzz --with-boost-process
15:13 < sipa> you need --with-sanitizers=...,fuzz if you want to build fuzz tests
15:13 < andytoshi> oh! thanks
15:14 < andytoshi> i think i was going to get there, my next thing was to grep through the CI config scripts and see what i was missing
15:14 < sipa> though it seems something was changed w.r.t not doing that, as dongcarl noticed: https://github.com/bitcoin/bitcoin/pull/20560#issuecomment-748339644
15:15 < sipa> i think we had some rudimentary support for building without specifically enabling fuzz, but the result wouldn't actually support fuzzing, just making sure stuff compiles
15:15 < andytoshi> yeah, i've kept half an eye on that stuff but i'm not sure where we wound up
15:15 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
15:16 < andytoshi> there is also some configuration which doesn't work with clang for me, but i can't remember what now
15:16 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
15:18 < sipa> it's --with-sanitizer=fuzzer (+ whatever other sanitizers you want to enable in the fuzz tests)
15:18 < sipa> * --with-sanitizers
15:19 < andytoshi> yep. building now. will know in 15-20 mins :)
15:19 < sipa> also see doc/fuzzing.md
15:25 < sipa> you need more CPU cores (or more RAM)
15:25 < sipa> :)
15:32 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
15:32 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
15:34 < andytoshi> i have them! but i am building my computer in canada and i'm not there yet (and because of weird shipping costs i have half the parts with me and half of them there)
15:34 < andytoshi> in a week i'll fly in, pockets full of RAM and a EPYC 7502, and i won't have to worry about this stuff
15:34 < andytoshi> anyway...looks like it worked, except now it's telling me that there are no test to run and to reconfigure with --with-daemon
15:34 < andytoshi> which definitely is new to me
15:35 < andytoshi> and doesn't appear in the CI scripts
15:35 < jonatack> so far the only change i've noticed since 20560 is how to run a fuzzer (the new way is documented in doc/fuzzing.md)
15:36 < jonatack> ./autogen.sh ; ./configure --enable-fuzz --with-sanitizers=address,fuzzer,undefined CC=clang CXX=clang++ && make distclean ; make -j5
15:36 < jonatack> is my usual for fuzzing i think
15:36 < andytoshi> ok that looks familiar. but when i try to run test/fuzz/test_runner.py it says i should reconfigure with --with-daemon
15:37 < sipa> bizarre
15:37 < sipa> i tested the PR before ACK'ing, including running test_runner.py
15:37 < jonatack> oh i never got that script to work, i thought it was for the ci
15:37 < jonatack> i just run individual fuzzers
15:37 < andytoshi> hmm, it was definitely working for me a week ago
15:38 < andytoshi> but i wasn't keeping track of what commit or what workdir i was in or anything, so idk what might've changed
15:38 < jonatack> it's been a year since i last tried tho
15:38 < sipa> i think you're callig test/functional/test_runner.py, not test/fuzz/test_runner.py
15:39 < andytoshi> haha dammit
15:39 < andytoshi> well i already did `make clean` so now i gotta wait another 20 minutes
15:39 < andytoshi> fridays..
15:39 < sipa> sounds like you need to install ccache
15:39 < andytoshi> yeah, i really should
15:40 < andytoshi> i installed it, is there anything else i should do? i guess reconfigure so Core detects that i have it
15:40 < sipa> configure will automatically make use of it; all you need to do is install it
15:40 < andytoshi> great thanks
15:40 < jonatack> oh, it does work now...yay!
15:41 < andytoshi> the fact that test_runner wasn't yelling at me for providing no corpus should've tipped me off that i was running the wrong script..
15:42 < andytoshi> sipa: also, is there a good way to run all the fuzzers, against the qa-assets corpus, with a ton of iterations
15:42 < andytoshi> other than editing test_runner.py runs=1 to runs=100000
15:43 < sipa> why would you want to do more than 1 iteration
15:43 -!- siropushselski [~sirikosir@80.72.89.153.coresnet.bg] has joined #bitcoin-core-dev
15:43 < andytoshi> to test more mutations
15:44 < sipa> (i should add that i didn't even knew about the existence of this script before reviewing 20560, i've never actually used it in production)
15:44 < sipa> if you want mutations, you need to start it with -g
15:44 < andytoshi> i assume that if you increase the --runs parameter, it will start from the seeds in the qa-assets corpus, and then search from there
15:44 < sipa> if you don't, it'll just run the existing corpus, with no mutations
15:44 < andytoshi> will -g use the qa-assets corpus? it sounds from the help text like it'll just overwrite it
15:45 < sipa> that would be ridiculous, but let me check because i don't actually know
15:45 < sipa> "Create new corpus seeds (or extend the existing ones) by running"
15:45 < sipa> according to --help
15:45 < andytoshi> ok, cool, i just can't read
15:48 < andytoshi> hooray it's going!
16:06 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
16:19 -!- promag [~promag@188.250.84.129] has quit [Remote host closed the connection]
16:20 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
16:24 -!- Legousk [~Henkie@178-84-68-9.dynamic.upc.nl] has quit [Quit: Leaving]
16:25 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.29.10] has joined #bitcoin-core-dev
16:30 -!- developer [250800f3@37.8.0.243] has joined #bitcoin-core-dev
16:38 -!- developer [250800f3@37.8.0.243] has quit [Remote host closed the connection]
16:40 -!- developer [250800f3@37.8.0.243] has joined #bitcoin-core-dev
16:41 -!- developer [250800f3@37.8.0.243] has quit [Remote host closed the connection]
16:54 -!- da2ce7 [~da2ce7@opentransactions/dev/da2ce7] has quit [Ping timeout: 256 seconds]
16:55 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Read error: Connection reset by peer]
16:59 -!- da2ce7 [~da2ce7@opentransactions/dev/da2ce7] has joined #bitcoin-core-dev
17:10 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
17:15 -!- RC-3004 [~RC-3004@84.39.117.57] has quit [Remote host closed the connection]
17:19 -!- proofofkeags [~proofofke@174-16-212-53.hlrn.qwest.net] has quit [Ping timeout: 256 seconds]
17:29 -!- roconnor [~roconnor@host-45-58-200-239.dyn.295.ca] has quit [Ping timeout: 258 seconds]
17:36 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
17:36 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services]
17:36 -!- vasild_ is now known as vasild
17:36 -!- zerstoerer [~zerstoere@139.28.218.148] has joined #bitcoin-core-dev
17:40 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 246 seconds]
17:45 -!- roconnor [~roconnor@host-45-58-208-179.dyn.295.ca] has joined #bitcoin-core-dev
17:45 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
18:11 < dhruvm> If I run FUZZ=process_message src/test/fuzz/fuzz qa-assets/fuzz_seed_corpus/process_message and it creates a new file in qa-assets/fuzz_seed_corpus/process_message/..., does that mean this run uncovered an input that can increase converage?
18:12 -!- pinheadmz [~pinheadmz@71.190.30.138] has quit [Ping timeout: 240 seconds]
18:14 -!- pinheadmz [~pinheadmz@71.190.30.138] has joined #bitcoin-core-dev
18:16 < sipa> dhruvm: or a shorter input than an existing one with the same coverage
18:20 < dhruvm> so they are always worth contributing back to the corpus?
18:24 < dhruvm> also, reg the line that starts with "INITED": does that mean all the seeds in the corpus were tried, and now, the fuzzer will mutate them to try and increase coverage?
18:24 < sipa> yes
18:25 < dhruvm> perfect, thanks.
18:25 -!- da39a3ee5e6b4b0d [~da39a3ee5@171.5.29.10] has quit [Quit: Textual IRC Client: www.textualapp.com]
18:26 -!- jarolrod [uid475272@gateway/web/irccloud.com/x-gbmckvtqrpvteemn] has quit [Ping timeout: 260 seconds]
18:26 -!- jarolrod [uid475272@gateway/web/irccloud.com/x-dequyziutcuulwgj] has joined #bitcoin-core-dev
18:27 -!- b10c [~b10c@2a01:4f8:192:612a:216:3eff:fef3:dc6a] has quit [Ping timeout: 260 seconds]
18:27 -!- robert_spigler [robertspig@gateway/shell/matrix.org/x-xnfysvtnctlvjxpj] has quit [Ping timeout: 260 seconds]
18:27 -!- endogenic [sid145991@gateway/web/irccloud.com/x-mljoynrkytaqlzva] has quit [Ping timeout: 260 seconds]
18:27 -!- b10c [~b10c@2a01:4f8:192:612a:216:3eff:fef3:dc6a] has joined #bitcoin-core-dev
18:28 -!- endogenic [sid145991@gateway/web/irccloud.com/x-mpexyroazklhiktg] has joined #bitcoin-core-dev
18:28 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
18:28 -!- robert_spigler [robertspig@gateway/shell/matrix.org/x-nwcwosbgxjhkfqnh] has joined #bitcoin-core-dev
18:52 -!- alharbi [5cf139b1@92.241.57.177] has joined #bitcoin-core-dev
18:58 -!- alharbi [5cf139b1@92.241.57.177] has quit [Remote host closed the connection]
19:06 < phantomcircuit> sipa, are all the fuzzing targets in the same binary again?
19:07 < sipa> phantomcircuit: yes
19:07 < sipa> env variable to select which fuzz target you want
19:07 < sipa> FUZZ=txrequest ./src/test/fuzz/fuzz
19:11 < phantomcircuit> sipa, iirc that significantly reduces the effectiveness of the fuzzing, wasn't it broken out before?
19:12 < phantomcircuit> (i know the original was not, but i thought that was fixed)
19:12 < sipa> phantomcircuit: we benchmarked it, and it doesn't really affect it
19:12 < sipa> what does affect fuzzing effectively is taking the fuzz target from the _input_
19:12 < sipa> but we don't do that now; it's taking the target from an env var
19:18 < phantomcircuit> sipa, oh interesting
19:18 < phantomcircuit> i wouldn't have expected that
19:19 < sipa> the problem is that if the fuzz target is taken from the input, it'll try to cross-pollinate inputs across targets
19:20 < phantomcircuit> the docs say pretty clearly that reducing the number of branches will make the actual fuzzing not necessarily faster, but better since there will be fewer collisions in the uh ... branch marking things
19:20 < phantomcircuit> but it's probably not that significant with the targets we're fuzzing
19:22 < sipa> yeah, and many fuzz targets link in large amounts of the codebase anyway
19:22 < sipa> which means there isn't too much difference between the amount of reachable branches in the code
19:23 < phantomcircuit> sipa, makes sense
19:30 < sipa> (and without -flto and -ffunction-sections it probably doesn't matter at all, as tons of unreachable branches will stay in the binary)
19:52 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has quit [Quit: Leaving]
19:55 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has joined #bitcoin-core-dev
19:56 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
20:03 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
20:03 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
20:08 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev
20:12 -!- miketwen_ [~miketwent@ec2-3-83-70-127.compute-1.amazonaws.com] has quit [Ping timeout: 268 seconds]
20:17 -!- miketwen_ [~miketwent@ec2-3-83-70-127.compute-1.amazonaws.com] has joined #bitcoin-core-dev
20:20 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 260 seconds]
20:27 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds]
20:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:33 < bitcoin-git> [bitcoin] fanquake closed pull request #20719: (master) (master...(master)) https://github.com/bitcoin/bitcoin/pull/20719
20:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:46 -!- brutalist [~brutalist@104.143.92.31] has joined #bitcoin-core-dev
20:47 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has quit [Ping timeout: 260 seconds]
20:47 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has joined #bitcoin-core-dev
20:49 -!- kristapsk___ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
20:49 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
20:50 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
20:58 -!- promag [~promag@188.250.84.129] has quit [Remote host closed the connection]
20:58 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
21:00 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has quit [Read error: Connection reset by peer]
21:13 -!- brutalist [~brutalist@104.143.92.31] has quit [Quit: brutalist]
21:14 -!- Mercury_Vapor [~Mercury_V@174-082-166-092.res.spectrum.com] has joined #bitcoin-core-dev
21:20 -!- pinheadmz [~pinheadmz@71.190.30.138] has quit [Quit: pinheadmz]
21:21 -!- abraham [~abraham@45.91.22.36] has joined #bitcoin-core-dev
21:25 -!- abraham [~abraham@45.91.22.36] has quit [Client Quit]
21:32 < achow101> code signing tool might be ready for rc4 :)
21:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
21:32 < achow101> s/for/by
21:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 272 seconds]
21:44 < phantomcircuit> sipa, er am i missing something, im following the docs in docs/fuzzing.md to build and this is definitely not working
21:44 < phantomcircuit>  /usr/bin/ld: error: test/fuzz/fuzz-crypto_chacha20_poly1305_aead.o: <corrupt x86 feature size: 0x8>
21:45 < phantomcircuit> infinite more errors just like that
21:45 -!- jessepos_ [~jp@2601:645:200:162f:c485:a1f9:c55:8d3e] has joined #bitcoin-core-dev
21:48 < sipa> what OS?
21:48 < phantomcircuit> debian 10
21:48 < phantomcircuit> went most universal thing i could without using ubuntu
21:49 < sipa> never seen that error
21:49 < sipa> x86_64 i presume?
21:49 -!- jesseposner [~jp@2601:645:200:162f:f8ca:2dd4:5b19:c33c] has quit [Ping timeout: 264 seconds]
21:50 < phantomcircuit> sipa, yes
21:50 < phantomcircuit> sipa, yeah i haven't either
21:53 < sipa> and you did a make clean or so?
21:53 < sipa> or started from a cpean source tree
21:53 < phantomcircuit> it's a brand new source tree
21:54 < sipa> which gcc or clang?
21:59 < phantomcircuit> sipa, first clang which gave that error and now gcc which also gives the same error (error is from ld)
22:02 < sipa> which version is it?
22:03 -!- flag [~flag@net-93-66-71-105.cust.vodafonedsl.it] has quit [Quit: leaving]
22:06 < phantomcircuit> sipa, of what
22:06 < phantomcircuit> f1dbf92ff0475a01d20170ea422c1d086acbbc57
22:06 < phantomcircuit> clang version 7.0.1-8+deb10u2 (tags/RELEASE_701/final)
22:06 < phantomcircuit> gcc (Debian 8.3.0-6) 8.3.0
22:06 < phantomcircuit> GNU ld (GNU Binutils for Debian) 2.31.1
22:08 < sipa> should be recent enough
22:09 < phantomcircuit> sipa, im going to blow away and start over maybe something is messed up
22:10 -!- flag [~flag@net-93-66-71-105.cust.vodafonedsl.it] has joined #bitcoin-core-dev
22:10 < phantomcircuit> sipa, hmm i just noticed
22:10 < phantomcircuit> Makefile.am:336: warning: .INTERMEDIATE was already defined in condition !BUILD_DARWIN, which is included in condition TRUE ...
22:10 < phantomcircuit> Makefile.am:140: ... '.INTERMEDIATE' previously defined here
22:11 < phantomcircuit> from autogen.sh
22:11 < phantomcircuit> output
22:18 < sipa> https://github.com/bitcoin/bitcoin/pull/20684 ?
22:22 < fanquake> sounds very much like a local issue
22:24 < phantomcircuit> fanquake, it's literally a brand new debian 10
22:24 -!- glozow [uid453516@gateway/web/irccloud.com/x-yjlujyyyfvchoyym] has quit [Quit: Connection closed for inactivity]
22:28 < phantomcircuit> sipa, fixes the autogen.sh warning but not the linker failure
22:32 < phantomcircuit> 0.20.1 works fine, i'll bisect
22:34 < phantomcircuit> nvm i spoke too soon
22:35 -!- miketwen_ [~miketwent@ec2-3-83-70-127.compute-1.amazonaws.com] has quit [Remote host closed the connection]
22:36 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev
22:41 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 260 seconds]
22:43 < phantomcircuit> fanquake, i dont think it's a local issue especially cause everything but building for fuzzing seems to work fine
22:45 < sipa> what debian version?
22:49 < phantomcircuit> sipa, 10.7
22:53 < phantomcircuit> sipa, exactly what i did http://192.241.205.97/bitcoin-fuzz.txt
22:56 -!- mol [~mol@unaffiliated/molly] has quit [Read error: Connection reset by peer]
22:57 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
22:58 < fanquake> phantomcircuit: you're right. I've just seen the same with Clang 7. Don't have time to look into it now though.
22:58 < fanquake> How did our fuzz tests end up broken like this?
23:06 < fanquake> he
23:06 < fanquake> *heh
23:07 < phantomcircuit> fanquake, iono dont ask me :P
23:07 < sipa> works fine here
23:07 < sipa> clang 11.0.0-2
23:08 < fanquake> So it looks like the issue is actually with some older versions of clang and -fcf-protection=full
23:08 < fanquake> I can recreate the same ld output with a simple testcase
23:08 < fanquake> https://gist.github.com/fanquake/9b33555fcfebef8eb8c0795a71732bc6
23:15 < fanquake> Don't see the issue with Clang 9. Haven't tested with 8.
23:17 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection]
23:21 < fanquake> Clang 8 also fine.
23:21 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
23:33 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
23:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds]
23:42 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
23:42 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
23:43 < fanquake> phantomcircuit: I don't understand why you don't see issues building normally, as that option would be present in both builds.
23:43 < fanquake> I've just built bitcoin-cli and see the same linking issue.
23:45 < phantomcircuit> fanquake, i guess because normal builds aren't using clang but gcc?
23:46 < fanquake> Right. I assumed you were using Clang all the time.
23:55 -!- promag_ [~promag@188.250.84.129] has joined #bitcoin-core-dev
23:55 -!- promag [~promag@188.250.84.129] has quit [Read error: Connection reset by peer]
--- Log closed Sat Dec 19 00:00:50 2020