--- Log opened Mon Dec 21 00:00:05 2020
--- Day changed Mon Dec 21 2020
00:00 -!- einyx [einyx@fsf/member/einyx] has quit [Ping timeout: 240 seconds]
00:00 -!- einyx [einyx@fsf/member/einyx] has joined #bitcoin-core-dev
00:01 < wumpus> fanquake: that's really strange. the only explanation i can think of is that the PR was before hidden by github due to an admin action (e.g. some kind of account suspend that hides the persons PRs), and that was turned out, retrospectively revealing the PRs
00:03 < wumpus> the metadata archive (https://github.com/zw/bitcoin-gh-meta) doesn't have a file for it *at all* so it was not visible through the API either
00:05 -!- kristapsk___ [~KK@gateway/tor-sasl/kristapsk] has quit [Ping timeout: 240 seconds]
00:14 -!- robbiet480 [~robbiet48@185.103.96.147] has quit [Remote host closed the connection]
00:28 -!- Michael95 [7d3b9770@cm125-59-151-112.hkcable.com.hk] has joined #bitcoin-core-dev
00:34 -!- aowi [~aowi@195.140.213.38] has joined #bitcoin-core-dev
00:41 -!- Michael95 [7d3b9770@cm125-59-151-112.hkcable.com.hk] has quit [Remote host closed the connection]
00:45 -!- ctrlbreak [~ctrlbreak@159.2.165.130] has quit [Ping timeout: 260 seconds]
01:08 < wumpus> MarcoFalke: https://github.com/bitcoin/bitcoin/pull/20720#issuecomment-748815722  beware, github-merge will still include your not-an-ACK as if an ACK :)
01:12 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
01:27 -!- kljasdfvv [~flack@p200300d46f24de001700ed034ece04c2.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
01:30 -!- shesek [~shesek@164.90.217.137] has joined #bitcoin-core-dev
01:30 -!- shesek [~shesek@164.90.217.137] has quit [Changing host]
01:30 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
01:37 -!- promag_ [~promag@188.250.84.129] has joined #bitcoin-core-dev
01:37 -!- promag [~promag@188.250.84.129] has quit [Read error: Connection reset by peer]
01:47 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev
01:51 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 260 seconds]
01:54 -!- jeremyrubin [~jr@c-24-4-205-116.hsd1.ca.comcast.net] has quit [Ping timeout: 260 seconds]
02:04 -!- kexkey [~kexkey@static-198-54-132-106.cust.tzulo.com] has quit [Ping timeout: 260 seconds]
02:06 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev
02:11 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 272 seconds]
02:33 -!- Lightsword [~Lightswor@107.170.253.193] has quit [Quit: ZNC]
02:53 -!- Guest_43 [49871b68@c-73-135-27-104.hsd1.md.comcast.net] has joined #bitcoin-core-dev
02:59 -!- Guest_43 [49871b68@c-73-135-27-104.hsd1.md.comcast.net] has quit [Remote host closed the connection]
03:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:10 < bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/e9efb64a0772...f061da288783
03:10 < bitcoin-git> bitcoin/master 93504da Hennadii Stepanov: ci: Fix COMMIT_RANGE variable value for PRs
03:10 < bitcoin-git> bitcoin/master 10af252 Hennadii Stepanov: ci: Drop Travis-specific way to set COMMIT_RANGE variable
03:10 < bitcoin-git> bitcoin/master c123892 Hennadii Stepanov: ci: Drop Travis-specific workaround for shellcheck
03:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:11 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #20697: ci: Fix COMMIT_RANGE variable value for PRs (master...201218-range) https://github.com/bitcoin/bitcoin/pull/20697
03:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:18 -!- Mack69Reichel [~Mack69Rei@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev
03:23 -!- Mack69Reichel [~Mack69Rei@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 240 seconds]
03:38 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has quit [Remote host closed the connection]
03:40 < wumpus> i wish there was a way to add 'blocked on issue/PR X' metadata to github issues
03:41 < wumpus> this could make it immediately visible what (for the project) the current blockers are and why something is blocked
03:45 < wumpus> some age-old issue tracking systems (maybe Trac?) had this
03:56 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-dev
04:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:12 < bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/f061da288783...68c7acf6bb77
04:12 < bitcoin-git> bitcoin/master fadd402 MarcoFalke: psbt: Assert that tx has a value in UpdatePSBTOutput
04:13 < bitcoin-git> bitcoin/master fa7e803 MarcoFalke: Remove unused MakeOptional
04:13 < bitcoin-git> bitcoin/master fa4435e MarcoFalke: Replace boost::optional with std::optional
04:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:13 < bitcoin-git> [bitcoin] laanwj merged pull request #20671: Replace boost::optional with std::optional (master...2012-stdOpt) https://github.com/bitcoin/bitcoin/pull/20671
04:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:16 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has quit [Quit: Find me in #TheHolyRoger or https://theholyroger.com]
04:17 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has joined #bitcoin-core-dev
04:23 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev
04:28 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 246 seconds]
04:31 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
04:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:45 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #19426: refactor: Change * to & in MutableTransactionSignatureCreator (master...2007-refactorSign) https://github.com/bitcoin/bitcoin/pull/19426
04:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:53 -!- seberm [~seberm@ip4-83-240-4-221.cust.nbox.cz] has quit [Ping timeout: 256 seconds]
05:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:05 < bitcoin-git> [bitcoin] hebasto opened pull request #20735: script: Remove outdated extract-osx-sdk.sh (master...201221-doc) https://github.com/bitcoin/bitcoin/pull/20735
05:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:09 -!- seberm [~seberm@ip4-83-240-4-221.cust.nbox.cz] has joined #bitcoin-core-dev
05:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:25 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20736: rpc: Replace boost::variant with std::variant for RPCArg.m_fallback (master...2012-rpcStdVariant) https://github.com/bitcoin/bitcoin/pull/20736
05:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:27 -!- seberm [~seberm@ip4-83-240-4-221.cust.nbox.cz] has quit [Quit: Leaving]
05:36 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
05:36 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services]
05:36 -!- vasild_ is now known as vasild
05:41 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
05:58 -!- glozow [uid453516@gateway/web/irccloud.com/x-qztvvxooimjmdskr] has joined #bitcoin-core-dev
05:59 -!- tralfaz [~davterra@gateway/tor-sasl/tralfaz] has quit [Quit: Leaving]
06:14 -!- miketwenty1 [~miketwent@ec2-54-235-98-1.compute-1.amazonaws.com] has joined #bitcoin-core-dev
06:23 -!- pergaminho [~Cleber@189.26.121.248] has joined #bitcoin-core-dev
06:25 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 268 seconds]
06:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:25 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/68c7acf6bb77...1077c93a3410
06:25 < bitcoin-git> bitcoin/master 11a3272 Michael Dietz: test: run mempool_resurrect.py even with wallet disabled
06:25 < bitcoin-git> bitcoin/master 1077c93 MarcoFalke: Merge #20692: test: run mempool_resurrect.py even with wallet disabled
06:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:25 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20692: test: run mempool_resurrect.py even with wallet disabled (master...mempool-resurrect-to-miniwallet) https://github.com/bitcoin/bitcoin/pull/20692
06:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:35 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20737: test: Add missing assignment in mempool_resurrect.py (master...2012-testAssign) https://github.com/bitcoin/bitcoin/pull/20737
06:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:36 < luke-jr> are there any Windows devs among us at this point? <.<
06:39 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev
06:42 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Read error: Connection reset by peer]
06:46 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
06:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:50 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20738: [0.20] final rc2 backports (0.20...2012-20rc2) https://github.com/bitcoin/bitcoin/pull/20738
06:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:50 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 260 seconds]
06:52 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
06:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:54 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20739: [0.19] final rc2 backports (0.19...2012-19rc2) https://github.com/bitcoin/bitcoin/pull/20739
06:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:58 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #20737: test: Add missing assignment in mempool_resurrect.py (master...2012-testAssign) https://github.com/bitcoin/bitcoin/pull/20737
06:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:58 < bitcoin-git> [bitcoin] MarcoFalke reopened pull request #20737: test: Add missing assignment in mempool_resurrect.py (master...2012-testAssign) https://github.com/bitcoin/bitcoin/pull/20737
06:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:03 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
07:04 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
07:05 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
07:08 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds]
07:20 -!- roconnor [~roconnor@host-45-78-199-13.dyn.295.ca] has quit [Quit: Konversation terminated!]
07:20 -!- roconnor [~roconnor@host-45-78-199-13.dyn.295.ca] has joined #bitcoin-core-dev
07:29 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
07:32 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds]
07:33 -!- flack [~flack@p200300d46f24de004c18346cd31417ca.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
07:58 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
08:01 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 256 seconds]
08:03 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
08:07 -!- flack [~flack@p200300d46f24de004c18346cd31417ca.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!]
08:08 -!- kljasdfvv [~flack@p200300d46f24de001700ed034ece04c2.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!]
08:26 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
08:39 -!- lightningbot [~supybot@2400:8901::f03c:91ff:febb:bbc1] has quit [Remote host closed the connection]
08:39 -!- lightningbot [~supybot@cerulean.erisian.com.au] has joined #bitcoin-core-dev
08:49 -!- flack [~flack@p200300d46f24de009aeea424a998fca2.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
08:53 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
08:55 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 240 seconds]
09:03 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev
09:14 -!- flack [~flack@p200300d46f24de009aeea424a998fca2.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!]
09:20 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has quit [Read error: Connection reset by peer]
09:21 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has joined #bitcoin-core-dev
09:22 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Quit: Leaving]
09:24 -!- while [~while@dsl-50-5-16-66.fuse.net] has joined #bitcoin-core-dev
09:25 -!- pentium2000 [~while@dsl-50-5-16-66.fuse.net] has quit [Read error: Connection reset by peer]
09:25 -!- kexkey [~kexkey@static-198-54-132-138.cust.tzulo.com] has joined #bitcoin-core-dev
09:26 -!- Talkless [~Talkless@mail.dargis.net] has quit [Remote host closed the connection]
09:26 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
09:36 < wumpus> luke-jr: did we ever ? besides sipsorcery who is still active
09:39 < wumpus> looks like macos has the most developer enthousiasm these days, with linux close second
09:42 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection]
09:42 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
09:43 < wumpus> luke-jr: btw please rebase #14066 it'd be nice to get that in soon
09:43 < gribble> https://github.com/bitcoin/bitcoin/issues/14066 | gitian-linux: Build binaries for 64-bit POWER by luke-jr · Pull Request #14066 · bitcoin/bitcoin · GitHub
09:44 -!- Anduck [~Anduck@unaffiliated/anduck] has quit [Ping timeout: 246 seconds]
09:45 -!- roconnor [~roconnor@host-45-78-199-13.dyn.295.ca] has quit [Ping timeout: 264 seconds]
09:45 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has quit [Ping timeout: 264 seconds]
09:45 -!- tlev [~tlev@li120-195.members.linode.com] has quit [Ping timeout: 264 seconds]
09:45 -!- tlev1 [~tlev@li120-195.members.linode.com] has joined #bitcoin-core-dev
09:46 -!- troygiorshev [~troygiors@d67-193-140-136.home3.cgocable.net] has joined #bitcoin-core-dev
09:50 -!- jeremyrubin [~jr@2601:645:c200:14:d16a:4949:3622:4cc0] has joined #bitcoin-core-dev
10:14 -!- aowi [~aowi@195.140.213.38] has quit [Remote host closed the connection]
10:18 < sipsorcery> Nicolas Dorier is most likely still Windows, so I'm not completely alone.
10:23 < luke-jr> ☺
10:35 -!- Khaytsus1 [~Khaytsus@185.204.1.185] has joined #bitcoin-core-dev
10:42 -!- miketwenty1 [~miketwent@ec2-54-235-98-1.compute-1.amazonaws.com] has quit [Remote host closed the connection]
10:42 -!- belcher_ is now known as belcher
10:42 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev
10:47 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 256 seconds]
10:48 -!- miketwenty1 [~miketwent@ec2-54-235-98-1.compute-1.amazonaws.com] has joined #bitcoin-core-dev
10:55 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
10:57 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
10:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:59 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1d7243d30720...2556a973ed58
10:59 < bitcoin-git> bitcoin/master b23349b Ben Carman: rpc: Add missing description of vout in getrawtransaction help text
10:59 < bitcoin-git> bitcoin/master 2556a97 MarcoFalke: Merge #20731: rpc: Add missing description of vout in getrawtransaction he...
10:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:59 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20731: rpc: Add missing description of vout in getrawtransaction help text (master...fix-getrawtransaction-help-text) https://github.com/bitcoin/bitcoin/pull/20731
10:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:01 < achow101> jonasschnelli: I found and fixed the bug in signapple. had an extra line I thought I removed. should work now
11:12 < phantomcircuit> so what should i do with `slow-unit` test cases? those are test cases that took longer than the timeout to fuzz (i think the timeout is huge btw, like 2 minutes or something)
11:16 < wumpus> phantomcircuit: either ignore them for fuzzing or figure out *why* they take so long, I do think there are some test cases that take unreasonably long
11:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:21 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2556a973ed58...cc2a5ef9b2ff
11:21 < bitcoin-git> bitcoin/master fab46b3 MarcoFalke: test: Fix restart node race
11:21 < bitcoin-git> bitcoin/master cc2a5ef Wladimir J. van der Laan: Merge #20683: test: Fix restart node race
11:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:21 < bitcoin-git> [bitcoin] laanwj merged pull request #20683: test: Fix restart node race (master...2012-testNodeStart) https://github.com/bitcoin/bitcoin/pull/20683
11:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:23 -!- openoms [~quassel@91.132.136.76] has quit [Ping timeout: 258 seconds]
11:23 -!- openoms [~quassel@91.132.136.76] has joined #bitcoin-core-dev
11:23 < phantomcircuit> wumpus, now that i look more it's kinda hard to do that actually cause it just puts them in the top directory with no indication of which test it was running
11:39 < wumpus> phantomcircuit: wait, which tests are you running?
11:43 < wumpus> for the unit tests you can enable verbose debugging e.g. -l all (great overkill) or -l test_suite
11:45 < sipa> wumpus: it's the process_message fuzz test i believe
11:45 -!- JohnnyBitcoin [~JohnnyBit@ool-45712dcc.dyn.optonline.net] has joined #bitcoin-core-dev
11:47 < wumpus> sipa: okay no idea about that one
11:49 < phantomcircuit> wumpus, im generating more fuzzing targets
11:50 < phantomcircuit> sipa, i think im going to have to create working directories for each test to capture the crash, timeout, slow tests cause they just get dumped into the cwd without any indication of which target they were running
11:52 < sipa> phantomcircuit: perhaps add that functionality to test/fuzz/test_runner.py
11:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:53 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cc2a5ef9b2ff...f4ac48d30a84
11:53 < bitcoin-git> bitcoin/master 1fbb8b6 Hennadii Stepanov: script: Remove outdated extract-osx-sdk.sh
11:53 < bitcoin-git> bitcoin/master f4ac48d Wladimir J. van der Laan: Merge #20735: script: Remove outdated extract-osx-sdk.sh
11:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:53 < bitcoin-git> [bitcoin] laanwj merged pull request #20735: script: Remove outdated extract-osx-sdk.sh (master...201221-doc) https://github.com/bitcoin/bitcoin/pull/20735
11:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:54 < phantomcircuit> sipa, there's some other improvements i can make to the test_runner.py as well so yeah i guess that makes sense
11:55 < sipa> 100000 is not very many iterations for some of the fuzz targets
12:03 < phantomcircuit> sipa, there's a max_total_time parameter but it doesn't quite seem to work right
12:03 < phantomcircuit> or maybe im misunderstanding how it's supposed to work
12:06 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
12:15 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
12:17 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
12:24 -!- Khaytsus1 [~Khaytsus@185.204.1.185] has quit [Remote host closed the connection]
12:27 < phantomcircuit> sipa, right it reads and executes the corpus once before checking the total runtime, but it includes the time to run the corpus in the total time
12:27 < phantomcircuit> potential for footgun there is high
12:27 < sipa> phantomcircuit: another useful feature would be setting a certain % of runs to get the -use_value_profile=1 flag
12:30 < phantomcircuit> sipa, what's that flag do?
12:31 < phantomcircuit> oh records the inputs to cmp
12:31 < phantomcircuit> interesting
12:31 < sipa> phantomcircuit: libfuzzer has two mechanisms to measure "coverage", one that doesn't really like at the values used in branching, and one that does
12:31 < sipa> https://llvm.org/docs/LibFuzzer.html#value-profile
12:32 < sipa> doing that occasionally lets it more rapidly discover more varied inputs, but not necessarily inputs that lead to more actual coverage'
12:32 < phantomcircuit> sipa, yeah i was going to change the generation to use max_total_time, and then run each target with -jobs=$par -workers=$par instead of running each target with a single worker but all in parallel
12:32 < sipa> hmm, why?
12:33 < phantomcircuit> what happens now with high parallelism is some of the targets finish instantly and some take forever but only use 1 core
12:33 < sipa> it should start new ones, i think?
12:35 < phantomcircuit> sipa, there's ~150 tests, i have 128 cores, so what happens is i end up with like 16 of them running after about 30 seconds
12:36 < sipa> hmm, this works very differently than what i imagined i would do
12:37 < sipa> i'd just make it start N threads, pick a target randomly from the set you selected, and if one ends, start a new one
12:38 < sipa> that would be a lot better than what -jobs/-workers in libfuzzer can do, as it's not restricted to one single configuration for all threads
12:38 < sipa> when fuzzing manually i usually run with some distribution of -max_len and -use_value_profile parameters
12:38 < sipa> instead of all the same
12:41 < phantomcircuit> sipa, also if you run with -runs=10000 and -workers=128 some of the workers finish faster
12:41 -!- Enola63Gusikowsk [~Enola63Gu@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev
12:41 < sipa> yeah
12:41 < phantomcircuit> i think the only way to actually be efficient is the max total time
12:41 < sipa> i just want something that runs forever, and starts random targets, and starts new ones when one ends
12:42 < phantomcircuit> sipa, yeah that's basically what i was going to do
12:44 -!- Wayno [~Wayno@185.103.96.147] has joined #bitcoin-core-dev
12:45 < phantomcircuit> sipa, my concept with -workers/jobs was to run each of the things in sequence but race to finish
12:45 < wumpus> yes with fuzzing it's kind of hard to determine when to terminate anyway?
12:45 < phantomcircuit> the timing thing is annoying though cause it means i have to like benchmark loading the corpus or something
12:45 < wumpus> what would it be, 'we covered all code paths 100%'?
12:46 < phantomcircuit> wumpus, i think you're just never done is really the answer
12:46 < wumpus> right
12:46 -!- Enola63Gusikowsk [~Enola63Gu@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 272 seconds]
12:49 -!- ChaNn3L [~acid@ppp-2-85-248-171.home.otenet.gr] has joined #bitcoin-core-dev
12:50 -!- SiNoNe [~acid~475@c156-110.icpnet.pl] has joined #bitcoin-core-dev
12:54 -!- JohnnyBitcoin [~JohnnyBit@ool-45712dcc.dyn.optonline.net] has quit [Read error: Connection reset by peer]
12:59 < phantomcircuit> sipa, i guess what i can do is run without -jobs/workers and just keep starting new jobs randomly
12:59 < sipa> yeah
12:59 < phantomcircuit> for the targets with a large existing corpus they really have to run for quite a while to be useful
13:10 -!- mtotheb [~m@89.205.133.143] has joined #bitcoin-core-dev
13:11 -!- pergaminho [~Cleber@189.26.121.248] has quit [Quit: Saindo]
13:12 -!- mtotheb [~m@89.205.133.143] has left #bitcoin-core-dev []
13:14 -!- proofofkeags_ [~proofofke@174-29-3-187.hlrn.qwest.net] has joined #bitcoin-core-dev
13:28 -!- SiNoNe [~acid~475@c156-110.icpnet.pl] has quit [Quit: /!\ [ •  .::[ »«]• You must to try hard to find me. .  • [»« ]::.  • ] /!\]
13:29 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection]
13:30 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has quit [Read error: Connection reset by peer]
13:31 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
13:31 -!- sr_gi [~sr_gi@80.174.218.168.dyn.user.ono.com] has joined #bitcoin-core-dev
13:32 -!- SiNoNe [~acid~612@c156-110.icpnet.pl] has joined #bitcoin-core-dev
13:50 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
13:58 -!- SiNoNe [~acid~612@c156-110.icpnet.pl] has quit [Quit: .::[ »«]• °†a©id™†° S©®ip†° • [»« ]::. .::[ »«]• Get Armed • [»« ]::. .::[ »«]• http://burn.at/irc_acid • [»« ]::.]
14:16 -!- udecker [~udecker@173.243.88.22] has joined #bitcoin-core-dev
14:19 < CubicEarth> sipa: fyi - when my addnode is on the lan, core 0.19 pulled about 750 MB from the local node, and the other 750 MB spread out among the other wan peers, during a ~10 day sync catchup
14:20 -!- glozow [uid453516@gateway/web/irccloud.com/x-qztvvxooimjmdskr] has quit [Quit: Connection closed for inactivity]
14:20 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev
14:22 -!- udecker [~udecker@173.243.88.22] has left #bitcoin-core-dev []
14:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:25 < bitcoin-git> [bitcoin] achow101 closed pull request #20638: build: Fix macOS code signing by pre-allocating space for the code signature during gitian build (master...mac-codesign-fixed-alloc) https://github.com/bitcoin/bitcoin/pull/20638
14:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:28 < phantomcircuit> CubicEarth, that sounds about right just cause the lan peer is going to respond to requests with lower latecy
14:31 < CubicEarth> yeah, I was just curious what the ratio would be
14:37 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection]
14:37 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
14:39 -!- jessepos_ [~jp@2601:645:200:162f:c80:1b9c:6dcc:7fac] has joined #bitcoin-core-dev
14:40 -!- jesseposner [~jp@2601:645:200:162f:30e7:b32e:18ab:9a91] has quit [Ping timeout: 260 seconds]
14:41 -!- jesseposner [~jp@c-73-15-111-74.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
14:44 -!- jessepos_ [~jp@2601:645:200:162f:c80:1b9c:6dcc:7fac] has quit [Ping timeout: 260 seconds]
14:46 -!- ctrlbreak [~ctrlbreak@159.2.165.130] has joined #bitcoin-core-dev
14:50 < wumpus> it's interesting that it's almost 50/50
14:51 < wumpus> there's no logic at all to prefer local peers
14:57 < sdaftuar> CubicEarth: did you notice if your lan peer ever got disconnected during that catchup time?
14:58 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
14:58 < sdaftuar> context: https://github.com/bitcoin/bitcoin/issues/9213
15:00 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds]
15:02 -!- ChaNn3L [~acid@ppp-2-85-248-171.home.otenet.gr] has quit [Quit: .::[ »«]• °†a©id™†° S©®ip†° • [»« ]::. .::[ »«]• Get Armed • [»« ]::. .::[ »«]• http://burn.at/irc_acid • [»« ]::.]
15:02 < phantomcircuit> sipa, also good to know -workers with -merge just means it does the same thing a many many times for no reason
15:03 < phantomcircuit> so the existing test_runner.py does the right thing
15:05 < sipa> phantomcircuit: yeah, it just invokes itself a few times with a simple scheduler
15:09 -!- Madars [~null@unaffiliated/madars] has quit [Quit: WeeChat 1.9.1]
15:16 -!- SiNoNe_aCid [~acid@45.139.213.30] has joined #bitcoin-core-dev
15:21 -!- valwal_ [sid334773@gateway/web/irccloud.com/x-xpdkkmqnrtcjkded] has quit [Ping timeout: 260 seconds]
15:21 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-yvkrhcmnpcotzlkv] has quit [Ping timeout: 264 seconds]
15:22 -!- bosma [sid103570@gateway/web/irccloud.com/x-itslqunxawvbudln] has quit [Ping timeout: 264 seconds]
15:22 -!- SiNoNe_aCid [~acid@45.139.213.30] has quit [Ping timeout: 256 seconds]
15:23 -!- eragmus [sid136308@gateway/web/irccloud.com/x-igibofjeoqzcptra] has quit [Ping timeout: 264 seconds]
15:23 -!- tylerchambers [uid477594@gateway/web/irccloud.com/x-raafweykxwvatycu] has quit [Ping timeout: 272 seconds]
15:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:24 < bitcoin-git> [bitcoin] practicalswift opened pull request #20740: fuzz: Update FuzzedDataProvider.h from upstream (LLVM) (master...bump-FuzzedDataProvider.h) https://github.com/bitcoin/bitcoin/pull/20740
15:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:52 -!- proofofkeags_ [~proofofke@174-29-3-187.hlrn.qwest.net] has quit [Read error: Connection reset by peer]
15:53 -!- proofofkeags [~proofofke@174-29-3-187.hlrn.qwest.net] has joined #bitcoin-core-dev
15:55 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Read error: Connection reset by peer]
16:04 < aj> CubicEarth: i think the limit (if one node has 0 latency and infinite bandwidth) is ~90% -- you'd request 16*9=144=MAX_BLOCKS_IN_TRANSIT_PER_PEER*(m_max_outbound-1) blocks from the other outbounds, but stop requesting from the fast peer after 1024-144 (1024=BLOCK_DOWNLOAD_WINDOW) blocks, at which point your fast peer is gated on the slow peers
16:05 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 256 seconds]
16:07 < aj> sdaftuar: i had the thought that it'd be nice if faster peers progressively got larger max_in_transit figures, with everyone starting off at just 1 or 2, but never looked into it. i manually kill the connections to slow nodes when i'm resyncing for a few days or more :-/
16:08 < sipa> aj: yeah, and also making it adaptive based on block sizes
16:08 < sipa> though i guess that mostly matters for the historic part of the chain
16:09 < sipa> but 1024 is huge overkill for recent blocks
16:09 < sipa> eh, 1024 as total window size
16:09 < sipa> you were talking about per-peer limits
16:16 < aj> sipa: yeah, but smaller total window on its own would make slow peers even more of a nuisance
16:17 < sipa> indeed
16:44 -!- miketwenty1 [~miketwent@ec2-54-235-98-1.compute-1.amazonaws.com] has quit [Ping timeout: 264 seconds]
17:01 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit []
17:05 -!- openoms [~quassel@91.132.136.76] has quit [Ping timeout: 256 seconds]
17:07 -!- openoms [~quassel@91.132.136.76] has joined #bitcoin-core-dev
17:19 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
17:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
17:29 < bitcoin-git> [bitcoin] prayank23 opened pull request #20741: doc: Update 'Secure string handling' (master...walletname-security) https://github.com/bitcoin/bitcoin/pull/20741
17:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
17:32 -!- while [~while@dsl-50-5-16-66.fuse.net] has quit [Read error: Connection reset by peer]
17:36 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services]
17:36 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
17:36 -!- vasild_ is now known as vasild
17:43 < CubicEarth> sdaftuar: I don't think it disconnected, but it was only about 15 or 20 minutes to catch up the ~1500 blocks behind
18:31 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer]
18:32 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
18:40 -!- udecker [~udecker@173.243.88.22] has joined #bitcoin-core-dev
18:41 -!- udecker [~udecker@173.243.88.22] has quit [Client Quit]
18:42 -!- udecker [~udecker@173.243.88.22] has joined #bitcoin-core-dev
19:00 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 256 seconds]
19:02 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev
19:05 < phantomcircuit> sipa, monkeying with mutate_depth and use_value_profile resulted in lots of new test cases
19:05 < phantomcircuit> really interesting
19:05 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
19:12 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
19:12 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 256 seconds]
19:17 -!- lukedashjr is now known as luke-jr
19:19 -!- Wayno [~Wayno@185.103.96.147] has quit [Remote host closed the connection]
19:40 -!- flukiluke1 [~flukiluke@217.146.82.202] has joined #bitcoin-core-dev
20:46 -!- udecker [~udecker@173.243.88.22] has quit [Quit: udecker]
21:48 < fanquake> #20644 wont backport cleanly to 0.19 or 0.20, as the version of cctools is older. I've put together what should be an equivalent patch. Would be good for someone to double check it. Just finishing a gbuild
21:48 < fanquake> https://github.com/fanquake/bitcoin/commit/bd943d195903edcb8a4464eeed22871326e42be8
21:48 < gribble> https://github.com/bitcoin/bitcoin/issues/20644 | Add patch to make codesign_allocate compatible with Apples by sipa · Pull Request #20644 · bitcoin/bitcoin · GitHub
21:49 < fanquake> Can pull it into #20739 if it looks ok
21:49 < gribble> https://github.com/bitcoin/bitcoin/issues/20739 | [0.19] final rc2 backports by MarcoFalke · Pull Request #20739 · bitcoin/bitcoin · GitHub
21:50 < sipa> fanquake: looks equivalent
21:51 < sipa> but if we're going to use achow's signapple tool, we don't actually need these patches (it won't matter if we take them or not)
22:26 < jonasschnelli> achow101: still getting that (a different) error: https://gist.github.com/jonasschnelli/557c1534461bc85925527c6a6a9a4d27
22:28 < sipa> jonasschnelli: are you trying to run the gitian-compiled codesign_allocate binary on macos?
22:28 < sipa> it's a.linux binary
22:29 < jonasschnelli> oh... that might be the problem.
22:30 < sipa> you'll probably either want to do the whole thing on linux, or compile the cctools codesign_allocate for macos
22:30 < jonasschnelli> success
22:31 < jonasschnelli> will try now to compile the cctools for mac.
22:33 < sipa> success? it worked?
22:34 < jonasschnelli> Yeah. But with the mac internal codesign_allocate binary...
22:34 < sipa> ah
22:34 -!- az0re [~az0re@gateway/tor-sasl/az0re] has joined #bitcoin-core-dev
22:56 -!- sturles [~sturles@unaffiliated/sturles] has quit [Ping timeout: 260 seconds]
22:56 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 258 seconds]
22:58 -!- sturles [~sturles@unaffiliated/sturles] has joined #bitcoin-core-dev
23:08 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev
23:09 < achow101> macports uses the open source cctools so that would work
23:17 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection]
23:28 < jonasschnelli> okay... installing it now through MacPorts
23:36 -!- lz [cac05003@202.192.80.3] has joined #bitcoin-core-dev
23:43 -!- fsaf [49aa8ac6@c-73-170-138-198.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
23:44 -!- fsaf [49aa8ac6@c-73-170-138-198.hsd1.ca.comcast.net] has quit [Remote host closed the connection]
23:46 < jonasschnelli> shall I test with internal codesign_allocate and with the macports cctools version?
23:47 -!- udecker [~udecker@173.243.88.22] has joined #bitcoin-core-dev
23:48 < jonasschnelli> https://bitcoin.jonasschnelli.ch/bitcoin-0.21.0rc3-osx-unsigned_csalloc_macports.zip
23:49 < jonasschnelli> https://bitcoin.jonasschnelli.ch/bitcoin-0.21.0rc3-osx-unsigned-csalloc_internal.zip
23:49 < jonasschnelli> testing now the gitian signer
23:49 -!- abraham [~abraham@45.91.22.224] has joined #bitcoin-core-dev
23:58 < sipa> jonasschnelli: whatever is compatible with what gitian does at attaching tome
23:59 < jonasschnelli> stuffing the csalloc_internal signature through gitian signer gives me a "Bitcoin-Qt.app: invalid signature (code or signature have been modified)" when verifying on my mac
23:59 < jonasschnelli> (now testing with the cctools codesign_allocate signature)
--- Log closed Tue Dec 22 00:00:52 2020