--- Log opened Mon Dec 28 00:01:00 2020
00:38 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
00:39 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
00:41 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:f14e:453d:14dc:75b2:51ff] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
00:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:49 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/4a8f4ac4fc07...ddbf7a6f5051
00:49 < bitcoin-git> bitcoin/master 5e0dedb Hennadii Stepanov: build: Define .INTERMEDIATE target once only
00:49 < bitcoin-git> bitcoin/master ddbf7a6 fanquake: Merge #20684: build: Define .INTERMEDIATE target once only
00:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:49 < bitcoin-git> [bitcoin] fanquake merged pull request #20684: build: Define .INTERMEDIATE target once only (master...201217-target) https://github.com/bitcoin/bitcoin/pull/20684
00:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:53 -!- az0re [~az0re@gateway/tor-sasl/az0re] has quit [Quit: Leaving]
01:09 -!- udecker [~udecker@173.243.88.22] has joined #bitcoin-core-dev
01:23 -!- udecker [~udecker@173.243.88.22] has quit [Quit: udecker]
01:27 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 240 seconds]
01:28 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
01:43 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
01:45 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
02:09 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
02:20 -!- dr-orlovsky [~dr-orlovs@31.14.40.19] has quit [Ping timeout: 260 seconds]
02:35 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
02:39 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:f14e:453d:14dc:75b2:51ff] has joined #bitcoin-core-dev
02:42 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
02:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
02:54 -!- dr-orlovsky [~dr-orlovs@31.14.40.19] has joined #bitcoin-core-dev
03:05 -!- prayank [~andr0irc@2402:8100:206b:9d05:c010:2b88:25e4:ed6e] has joined #bitcoin-core-dev
03:06 < prayank> Can someone review this PR: https://github.com/bitcoin/bitcoin/pull/20741 and maybe merge it if 2-3 ACKs are enough for this change?
03:06 < prayank> There is no code. Only adding some information to docs.
03:07 < prayank> It's an alternative to https://github.com/bitcoin/bitcoin/pull/20393 which I think is not the best solution
03:14 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit []
03:17 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
03:18 -!- Terence17Jerde [~Terence17@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev
03:25 -!- Terence17Jerde [~Terence17@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 256 seconds]
03:27 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Quit: WeeChat 2.9]
03:30 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
03:44 -!- Wolfy87 [~Wolfy87@5.253.204.132] has quit [Remote host closed the connection]
04:05 -!- coppro [~coppro@185.204.1.185] has joined #bitcoin-core-dev
04:09 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection]
04:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:26 < bitcoin-git> [bitcoin] multisignature opened pull request #20784: doc: Typos in test README (master...master) https://github.com/bitcoin/bitcoin/pull/20784
04:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:28 < bitcoin-git> [bitcoin] multisignature closed pull request #20774: Update README.md (master...master) https://github.com/bitcoin/bitcoin/pull/20774
04:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:29 < bitcoin-git> [gui] jonatack closed pull request #162: Add network to peers window and peer details (master...display-peer-networks) https://github.com/bitcoin-core/gui/pull/162
04:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:29 < bitcoin-git> [gui] jonatack closed pull request #163: Peer details: replace Direction with Connection Type (master...display-peer-conn-types) https://github.com/bitcoin-core/gui/pull/163
04:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:33 -!- promag [~promag@188.250.84.129] has quit [Remote host closed the connection]
04:33 -!- jonatack [~jon@88.124.242.136] has joined #bitcoin-core-dev
04:33 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
04:49 < michaelfolkson> prayank: I've reviewed. I'm a touch confused though on what the comment is saying. You can explain here rather than on the PR if you'd like
04:50 < michaelfolkson> I'm probably missing context
04:52 -!- pergaminho [~Cleber@189.26.121.248] has joined #bitcoin-core-dev
04:53 < prayank> I hope you read the conversation in issue: https://github.com/bitcoin/bitcoin/issues/20128
05:05 < michaelfolkson> I looked at it. It appears reviewers were confused with the motivation in that issue too
05:07 < michaelfolkson> Just a pointer, if you are going to ask people to review, writing things like "I hope you did this...." isn't the best way to succeed in getting that review
05:08 -!- prayank [~andr0irc@2402:8100:206b:9d05:c010:2b88:25e4:ed6e] has quit [Ping timeout: 264 seconds]
05:13 -!- prayank [~andr0irc@2402:8100:206b:9d05:9d48:3132:568a:cf31] has joined #bitcoin-core-dev
05:14 < prayank> michaelfolkson: I've replied to your questions in the PR
05:16 < michaelfolkson> Ok thanks. Probably better to start discussing a PoC here than on a PR for documentation if you have one
05:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:19 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ddbf7a6f5051...7f9ae870115e
05:19 < bitcoin-git> bitcoin/master 1ef2138 fanquake: lint: run mypy over contrib/devtools
05:19 < bitcoin-git> bitcoin/master 7f9ae87 Wladimir J. van der Laan: Merge #20451: lint: run mypy over contrib/devtools
05:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:19 < bitcoin-git> [bitcoin] laanwj merged pull request #20451: lint: run mypy over contrib/devtools (master...contrib_devtools_mypy) https://github.com/bitcoin/bitcoin/pull/20451
05:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:29 -!- prayank [~andr0irc@2402:8100:206b:9d05:9d48:3132:568a:cf31] has quit [Ping timeout: 264 seconds]
05:31 -!- prayank [~andr0irc@2409:4053:2196:bd29:796e:9270:5347:3e40] has joined #bitcoin-core-dev
05:39 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 240 seconds]
05:50 -!- jeremyrubin [~jr@2607:fb90:46c:8e30:300e:3023:6b28:256b] has quit [Ping timeout: 260 seconds]
05:51 -!- promag [~promag@188.250.84.129] has quit [Remote host closed the connection]
05:51 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
05:56 -!- prayank [~andr0irc@2409:4053:2196:bd29:796e:9270:5347:3e40] has quit [Read error: Connection reset by peer]
05:57 -!- glozow [uid453516@gateway/web/irccloud.com/x-krdsowlryxrnjbwu] has joined #bitcoin-core-dev
06:05 -!- Murch [murch@2a01:4f8:141:1272::2] has joined #bitcoin-core-dev
06:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:08 < bitcoin-git> [bitcoin] SkybuckFlying opened pull request #20785: Changed (char **) to (const char **) for VS2019 (master...master) https://github.com/bitcoin/bitcoin/pull/20785
06:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:11 -!- jadi [~jadi@91.184.66.255] has quit [Ping timeout: 260 seconds]
06:25 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 240 seconds]
06:26 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
06:31 -!- pinheadmz [~pinheadmz@71.190.30.138] has joined #bitcoin-core-dev
06:33 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 240 seconds]
06:34 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 264 seconds]
06:34 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev
06:34 -!- jonatack [~jon@213.152.162.10] has joined #bitcoin-core-dev
06:45 -!- promag [~promag@188.250.84.129] has quit [Remote host closed the connection]
06:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:45 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #20785: Changed (char **) to (const char **) for VS2019 (master...master) https://github.com/bitcoin/bitcoin/pull/20785
06:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:46 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
06:55 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds]
06:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:59 < bitcoin-git> [bitcoin] jonatack closed pull request #20779: net, rpc, gui: add network to peers window and peer details (master...display-peer-networks) https://github.com/bitcoin/bitcoin/pull/20779
06:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:03 < jonatack> too much nonsense and complication with transversal changes between the gui and the main repo. i tried to follow the contributing guide, but apparently it has to be more complicated, with preliminary pulls in one gating changes in the other. nah.
07:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:05 < bitcoin-git> [bitcoin] jonatack closed pull request #20778: net, p2p, gui: replace direction with connection type in gui peer details window (master...display-peer-conn-types) https://github.com/bitcoin/bitcoin/pull/20778
07:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:08 < jonatack> I understand the reasons for splitting the repos, but unreasonably complicating things for contributions to the gui repo to the point where opening multiple pulls and reading between tea leaves in the CONTRIBUTING guide and still being wrong surely wasn't one of them.
07:12 < jonatack> For simple changes like those pulls, too much bandwidth is taken by this and it's a waste of bandwidth.
07:14 < michaelfolkson> I think the separation between GUI and non GUI makes sense. Though I don't know what happened in this particular example. Why can't the PR in the non-GUI repo state as a motivation a future change to the GUI. And then once that is merged, open a PR in the GUI for the GUI specific changes
07:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:15 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20786: net: [refactor] Prefer integral types in CNodeStats (master...2012-net) https://github.com/bitcoin/bitcoin/pull/20786
07:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:17 < michaelfolkson> Sounds more of a "I am used to things how used to be done" rather than any new problem. Reviewers in the non-GUI repo will need to get used to reviewing changes that are lining up a future PR in the GUI repo
07:17 < michaelfolkson> But maybe I'm missing something
07:25 < michaelfolkson> I get it is still confusing and there are teething problems which is frustrating
07:29 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:f14e:453d:14dc:75b2:51ff] has quit [Ping timeout: 260 seconds]
07:30 < jonatack> michaelfolkson: per the contributing guide, changes to the gui that are also transversal are to be opened in the main repo. the pulls were originally gui code only, to avoid this issue. reviewers asked for transversal changes with the main repo. i followed the guide and opened second pulls in the main repo. nope, new rule: you need to open one part of the them in the main repo, hope
07:30 < jonatack> someone will understand why it's a good idea and review it (attracting review is hard enough), then open a second pull for the gui-only changes in the gui repo. for simple changes like these, that seems unreasonably complicating things and a waste of bandwidth. 
07:32 < jonatack> maybe if a maintainer does it, it can work, but for simple contributors it's a large increase in difficulty in making gui changes that also touch the main repo.
07:33 < michaelfolkson> For a traversal change the code obviously needs to be written for both the GUI and the main repo at some stage. So it isn't more code, it is just a question of process for how you get review.
07:34 < michaelfolkson> Go to GUI for a design/concept ACK on a visual. Go back to the non-GUI repo for an ACK on the non-GUI code. Then back to the GUI repo for review of the GUI code.
07:34 < jonatack> I think the contributing guide needs to be updated if this is the complicated new process to follow.
07:34 < MarcoFalke> I can see the point that opening two pulls is a slightly heavier process and may delay things a bit, but it shouldn't cost more review. 6 commits are still to be reviewed. It shouldn't matter if two are in main and 4 in gui or all in one.
07:36 < michaelfolkson> Right, that's what it seems like to me too. The bottleneck is always the actual review and getting the ACKs. Slighty heavier as you say but the biggest problem is getting the actual review
07:36 < jonatack> MarcoFalke: I think leaving the pulls in the gui repo was fine in this case (simple, non-dangerous changes).
07:37 < MarcoFalke> Yeah, maybe relaxing the rules a bit to allow simple refactors also in the gui repo might be a good solution
07:37 < jonatack> ISTM that getting review twice is at least twice as hard, especially for gui-motivated changes in the main repo.
07:37 < MarcoFalke> I was hoping that the cross-repo pulls aren't too numerous for it to matter much
07:37 < jonatack> This seems to be one of the first times iirc
07:46 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection]
07:47 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
08:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:00 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20787: Use C++17 std::array deduction for OUTPUT_TYPES, ALL_FEE_ESTIMATE_HORIZONS (master...2012-WswitchFeeEstimateHorizon) https://github.com/bitcoin/bitcoin/pull/20787
08:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:03 -!- promag [~promag@188.250.84.129] has quit [Remote host closed the connection]
08:03 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
08:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:12 < bitcoin-git> [bitcoin] vasild opened pull request #20788: net: add RAII socket and use it instead of bare SOCKET (master...sock) https://github.com/bitcoin/bitcoin/pull/20788
08:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:55 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit []
08:57 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev
09:10 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
09:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:18 < bitcoin-git> [bitcoin] multisignature closed pull request #20784: doc: Typos in test README (master...master) https://github.com/bitcoin/bitcoin/pull/20784
09:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:26 -!- Keele [~keele@88-115-110-150.elisa-laajakaista.fi] has joined #bitcoin-core-dev
09:30 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
09:39 -!- promag [~promag@188.250.84.129] has quit [Remote host closed the connection]
09:40 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
09:41 -!- promag [~promag@188.250.84.129] has quit [Remote host closed the connection]
09:42 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
09:46 -!- promag [~promag@188.250.84.129] has quit [Remote host closed the connection]
09:47 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
10:14 -!- joelklabo [~textual@108-196-216-127.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
10:20 -!- kexkey [~kexkey@static-198-54-132-110.cust.tzulo.com] has joined #bitcoin-core-dev
10:21 -!- pinheadmz [~pinheadmz@71.190.30.138] has quit [Read error: Connection reset by peer]
10:22 -!- pinheadmz [~pinheadmz@71.190.30.138] has joined #bitcoin-core-dev
10:28 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
10:29 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Ping timeout: 240 seconds]
10:29 -!- promag [~promag@188.250.84.129] has quit [Remote host closed the connection]
10:30 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
10:38 -!- virtu [~virtu@gateway/tor-sasl/virtu] has quit [Remote host closed the connection]
10:38 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection]
10:38 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
10:38 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection]
10:38 -!- kristapsk_ [~KK@gateway/tor-sasl/kristapsk] has quit [Write error: Broken pipe]
10:38 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection]
10:38 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Write error: Broken pipe]
10:38 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Write error: Broken pipe]
10:38 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev
10:39 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
10:41 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
10:44 -!- virtu [~virtu@gateway/tor-sasl/virtu] has joined #bitcoin-core-dev
10:45 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev
10:47 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
10:49 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
10:54 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev
10:54 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
10:54 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
10:54 -!- pingwindyktator [~pingwindy@pingwindyktator.me] has quit [Quit: The Lounge - https://thelounge.chat]
10:54 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
10:54 -!- pingwindyktator [~pingwindy@pingwindyktator.me] has joined #bitcoin-core-dev
11:02 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection]
11:02 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection]
11:02 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
11:03 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
11:15 < wumpus> jonatack: fwiw i think that's a great addition and wouldn't have minded reviewing it
11:15 -!- quijote [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev
11:16 -!- quijote is now known as Guest21778
11:16 -!- joelklabo [~textual@108-196-216-127.lightspeed.sntcca.sbcglobal.net] has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
11:21 < wumpus> I don't want to get involved in gui design decisions I just can't do that, just too subjective and arbitrary, but adding useful information to the debug window is something that shouldn't be too difficult?
11:25 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has quit [Quit: leaving]
11:26 -!- andytoshi [~apoelstra@wpsoftware.net] has joined #bitcoin-core-dev
11:26 -!- andytoshi [~apoelstra@wpsoftware.net] has quit [Changing host]
11:26 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has joined #bitcoin-core-dev
11:28 < luke-jr> hmm, on that note I wonder if "tailing" the debug log would be a good feature for the GUI
11:29 < wumpus> i think a live debug log view would be awesome
11:30 < wumpus> though implementing it in a way that is efficient (doesn't end up logging everything to memory) is non-trivial
11:32 < wumpus> qt's build in stuff is really bad at handling large amounts of data in general, this is why the current 'open log' button forks out to an external editor
11:32 < luke-jr> well, if it only shows the last N lines, it's probably not hard
11:32 < luke-jr> adding a scrollbar would ofc :P
11:36 < wumpus> right, 'subscribe to log messages and keep the last 10' or so would be easy enough and maybe useful enough
11:37 < wumpus> or, last 1000, it's not like messages take that much memory :)
11:42 -!- promag [~promag@188.250.84.129] has quit [Remote host closed the connection]
11:43 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
11:45 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds]
11:45 -!- jeremyrubin [~jr@2607:fb90:8062:c5e6:300e:3023:6b28:256b] has joined #bitcoin-core-dev
11:54 < phantomcircuit> wumpus, i've seen text boxes that compress the text that isn't being actively displayed but i cant remember anything about them except the concept
11:56 < wumpus> phantomcircuit: it's definitely possible to do things like that, just qt doesn't do it by default, if you want anything smart you have to implement it yourself
12:06 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
12:13 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds]
12:14 < jonatack> wumpus: yes, and both pulls were reviewed, finished, collaborated together with hebasto, had acks... but then it unraveled with the process, I followed the instructions in contributing.md but it seems to needs updating, and the new process is arduous for contributors without the social capital to garner review on two repos for one change.
12:14 < jonatack> (the new new process, not the new process :D)
12:18 < jonatack> it's hard enough to garner review in one repo alone
12:20 < jonatack> simple changes like that aren't worth it imho. i've resolved to concentrate on more interesting things that are worth doing that for. 
12:24 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev
12:34 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
12:37 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 240 seconds]
12:39 < luke-jr> phantomcircuit: it would make more sense if we're goibng to that complexity, to just load it off disk as needed
12:50 -!- pergaminho [~Cleber@189.26.121.248] has quit [Quit: Saindo]
13:03 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
13:04 < wumpus> jonatack: I hadn't noticed it, if you'd told me I'd have merged it
13:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:05 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #20789: fuzz: Rework strong and weak net enum fuzzing (master...2012-fuzzRefactor) https://github.com/bitcoin/bitcoin/pull/20789
13:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]
13:07 < wumpus> jonatack: for changes that both involve invasive changes to the GUI and to the core code, it's probably better to do it in phases, but this isn't one of them
13:10 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
13:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
13:14 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds]
13:20 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds]
13:23 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
13:32 -!- joelklabo [~textual@108-196-216-127.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
13:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:38 < bitcoin-git> [bitcoin] jonatack opened pull request #20790: policy: create CFeeRate::FromSatB and FromBtcKb named ctors (master...CFeeRate-named-constructors) https://github.com/bitcoin/bitcoin/pull/20790
13:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:42 < bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/7f9ae870115e...e3dd0a56cfa7
13:42 < bitcoin-git> bitcoin/master 5370533 Amiti Uttarwar: [rpc] Remove deprecated "addnode" field from getpeerinfo
13:42 < bitcoin-git> bitcoin/master 094c3be Amiti Uttarwar: [rpc] Remove deprecated "banscore" field from getpeerinfo
13:42 < bitcoin-git> bitcoin/master b1a936d Amiti Uttarwar: [rpc] Remove deprecated "whitelisted" field from getpeerinfo
13:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:43 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20755: [rpc] Remove deprecated fields from getpeerinfo (master...2020-12-getpeerinfo-deprecate) https://github.com/bitcoin/bitcoin/pull/20755
13:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:45 < bitcoin-git> [gui] jonatack reopened pull request #163: Peer details: replace Direction with Connection Type (master...display-peer-conn-types) https://github.com/bitcoin-core/gui/pull/163
13:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:46 < bitcoin-git> [gui] jonatack reopened pull request #162: Add network to peers window and peer details (master...display-peer-networks) https://github.com/bitcoin-core/gui/pull/162
13:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:47 -!- ChaNn3L [~acid~335@ppp-2-85-255-192.home.otenet.gr] has left #bitcoin-core-dev []
13:54 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has joined #bitcoin-core-dev
14:17 -!- promag [~promag@188.250.84.129] has quit [Remote host closed the connection]
14:17 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
14:18 < jonatack> (thanks for the guidance)
14:22 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection]
14:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:57 < bitcoin-git> [gui] laanwj merged pull request #162: Add network to peers window and peer details (master...display-peer-networks) https://github.com/bitcoin-core/gui/pull/162
14:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:57 < bitcoin-git> [bitcoin] laanwj pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/e3dd0a56cfa7...d875bcc8f9ac
14:57 < bitcoin-git> bitcoin/master af9103c Jon Atack: net, rpc: change CNodeStats::m_network from string to Network
14:57 < bitcoin-git> bitcoin/master 0d5613f Jon Atack: gui: create GUIUtil::NetworkToQString() utility function
14:57 < bitcoin-git> bitcoin/master e0e5506 Jon Atack: gui: fix broken doxygen formatting in src/qt/guiutil.h
14:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:59 -!- MasterdonX [~masterdon@45.9.249.244] has joined #bitcoin-core-dev
15:08 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]
15:09 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
15:12 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Read error: Connection reset by peer]
15:20 -!- zivl [~zivl@unaffiliated/zivl] has joined #bitcoin-core-dev
15:20 -!- zivl [~zivl@unaffiliated/zivl] has quit [Client Quit]
15:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:56 < bitcoin-git> [bitcoin] jonatack opened pull request #20791: p2p: remove unused legacyWhitelisted bool variable (master...rm-unused-legacyWhitelisted) https://github.com/bitcoin/bitcoin/pull/20791
15:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
16:00 -!- promag [~promag@188.250.84.129] has quit [Remote host closed the connection]
16:01 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
16:08 -!- dmobi [~dmobi@2001:464c:ebe5:0:d09b:d346:9407:cdeb] has joined #bitcoin-core-dev
16:15 -!- Emcy_ [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
16:15 -!- Emcy_ [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection]
16:25 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Read error: Connection reset by peer]
16:37 -!- codex47 [54f3c497@84.243.196.151] has joined #bitcoin-core-dev
16:40 -!- da39a3ee5e6b4b0d [~da39a3ee5@2403:6200:8876:f14e:f414:9b65:b890:9d87] has joined #bitcoin-core-dev
16:41 -!- codex47 [54f3c497@84.243.196.151] has quit [Remote host closed the connection]
16:50 -!- dmobi [~dmobi@2001:464c:ebe5:0:d09b:d346:9407:cdeb] has quit [Ping timeout: 260 seconds]
17:23 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 240 seconds]
17:24 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has quit [Remote host closed the connection]
17:25 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has joined #bitcoin-core-dev
17:26 -!- [\\\] [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev
17:27 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Ping timeout: 246 seconds]
17:36 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
17:36 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services]
17:36 -!- vasild_ is now known as vasild
18:09 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
18:50 -!- promag [~promag@188.250.84.129] has quit [Remote host closed the connection]
18:51 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
18:55 -!- promag [~promag@188.250.84.129] has quit [Remote host closed the connection]
18:56 -!- dmobi [~dmobi@2001:464c:ebe5:0:7347:9cf7:e6b0:c6fa] has joined #bitcoin-core-dev
18:56 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
19:41 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Read error: Connection reset by peer]
19:42 -!- az0re [~az0re@gateway/tor-sasl/az0re] has joined #bitcoin-core-dev
19:43 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
19:48 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 260 seconds]
19:48 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
20:30 -!- jeremyrubin [~jr@2607:fb90:8062:c5e6:300e:3023:6b28:256b] has quit [Ping timeout: 264 seconds]
20:31 -!- jeremyrubin [~jr@2601:645:c200:14:346f:5d3:a503:bdf1] has joined #bitcoin-core-dev
21:00 -!- glozow [uid453516@gateway/web/irccloud.com/x-krdsowlryxrnjbwu] has quit [Quit: Connection closed for inactivity]
21:17 -!- coppro [~coppro@185.204.1.185] has quit [Remote host closed the connection]
21:46 -!- iammarkps [31e415a3@49.228.21.163] has joined #bitcoin-core-dev
22:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
22:17 < bitcoin-git> [bitcoin] kallewoof closed pull request #20154: BIP-322 support (master...202010-bip322) https://github.com/bitcoin/bitcoin/pull/20154
22:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
22:17 -!- iammarkps [31e415a3@49.228.21.163] has quit [Remote host closed the connection]
23:09 -!- promag_ [~promag@188.250.84.129] has joined #bitcoin-core-dev
23:09 -!- promag [~promag@188.250.84.129] has quit [Read error: Connection reset by peer]
23:20 -!- jadi [~jadi@213.207.201.119] has joined #bitcoin-core-dev
23:33 -!- az0re [~az0re@gateway/tor-sasl/az0re] has quit [Remote host closed the connection]
23:35 -!- az0re [~az0re@gateway/tor-sasl/az0re] has joined #bitcoin-core-dev
23:56 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection]
23:57 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
23:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:58 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d875bcc8f9ac...069f37c0fd42
23:58 < bitcoin-git> bitcoin/master 8f9ca31 Jon Atack: p2p: remove unused legacyWhitelisted variable
23:58 < bitcoin-git> bitcoin/master 069f37c MarcoFalke: Merge #20791: p2p: remove unused legacyWhitelisted in AcceptConnection()
23:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:58 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20791: p2p: remove unused legacyWhitelisted in AcceptConnection() (master...rm-unused-legacyWhitelisted) https://github.com/bitcoin/bitcoin/pull/20791
23:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
--- Log closed Tue Dec 29 00:01:01 2020