--- Log opened Thu Jan 21 00:00:22 2021 00:20 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 00:29 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services] 00:29 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 00:29 -!- vasild_ is now known as vasild 00:34 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services] 00:34 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 00:34 -!- vasild_ is now known as vasild 00:35 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 00:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:39 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/80486e7e2d8c...3734adba390c 00:39 < bitcoin-git> bitcoin/master 4efb6c2 Sebastian Falbesoner: zmq test: deduplicate test setup code (node restart, topics subscription) 00:39 < bitcoin-git> bitcoin/master 3734adb fanquake: Merge #20953: test: dedup zmq test setup code (node restart, topics subscr... 00:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:39 < bitcoin-git> [bitcoin] fanquake merged pull request #20953: test: dedup zmq test setup code (node restart, topics subscription) (master...2021-zmq_dedup_test_setup_code) https://github.com/bitcoin/bitcoin/pull/20953 00:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:39 < bitcoin-git> [bitcoin] fanquake reopened pull request #20523: zmq: deduplicate 'sequence' publisher message creation/sending (master...20201128-zmq-refactor-dedup_sequence_msg_sending) https://github.com/bitcoin/bitcoin/pull/20523 00:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:02 -!- jespada_ [~jespada@90.254.241.81] has quit [Ping timeout: 272 seconds] 01:03 -!- jespada [~jespada@90.254.241.81] has joined #bitcoin-core-dev 01:06 -!- az0re [~az0re@gateway/tor-sasl/az0re] has joined #bitcoin-core-dev 01:15 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:16 -!- mrostecki [mrostecki@nat/suse/x-rhwimopaeoiioxvh] has quit [Quit: WeeChat 1.8] 01:19 -!- realEthanZou[m] [realethanz@gateway/shell/matrix.org/x-xmqpsrjmzlcjrnml] has quit [Quit: authenticating] 01:19 -!- realEthanZou[m] [realethanz@gateway/shell/matrix.org/x-jxuebckvscpweqeg] has joined #bitcoin-core-dev 01:25 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:34 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:36 -!- jespada_ [~jespada@90.254.241.81] has joined #bitcoin-core-dev 01:36 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Read error: Connection reset by peer] 01:37 -!- jespada [~jespada@90.254.241.81] has quit [Ping timeout: 256 seconds] 01:37 -!- _0x0ff [~potatoe@unaffiliated/0x0ff/x-1210984] has quit [Ping timeout: 256 seconds] 01:37 -!- _0x0ff [~potatoe@163.172.166.225] has joined #bitcoin-core-dev 01:37 -!- _0x0ff [~potatoe@163.172.166.225] has quit [Changing host] 01:37 -!- _0x0ff [~potatoe@unaffiliated/0x0ff/x-1210984] has joined #bitcoin-core-dev 02:04 -!- kexkey [~kexkey@static-198-54-132-90.cust.tzulo.com] has quit [Ping timeout: 246 seconds] 02:11 -!- mrostecki [mrostecki@nat/suse/x-wtywsuerpzvrrlsv] has joined #bitcoin-core-dev 02:21 -!- realEthanZou[m] [realethanz@gateway/shell/matrix.org/x-jxuebckvscpweqeg] has quit [Quit: issued !quit command] 02:29 -!- realEthanZou[m] [realethanz@gateway/shell/matrix.org/x-iclpfmvmxcqmfqeu] has joined #bitcoin-core-dev 02:41 -!- realEthanZou[m] [realethanz@gateway/shell/matrix.org/x-iclpfmvmxcqmfqeu] has left #bitcoin-core-dev ["User left"] 03:18 -!- Jimmy18Kassulke [~Jimmy18Ka@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev 03:22 -!- Jimmy18Kassulke [~Jimmy18Ka@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 240 seconds] 03:25 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 3.0] 03:31 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 03:36 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 03:39 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds] 03:46 -!- olc29 [4f9bc195@149.red-79-155-193.dynamicip.rima-tde.net] has joined #bitcoin-core-dev 03:51 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 03:52 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 04:15 -!- olc29 [4f9bc195@149.red-79-155-193.dynamicip.rima-tde.net] has quit [Quit: Connection closed] 04:30 -!- belcher_ is now known as belcher 04:35 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 04:35 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 05:12 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 05:15 -!- spinza [~spin@102.132.245.16] has quit [Ping timeout: 240 seconds] 05:46 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev 05:54 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 268 seconds] 06:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:04 < bitcoin-git> [bitcoin] ben-kaufman opened pull request #20976: doc: fix broken link to whitepaper in README (master...fix-wp-link) https://github.com/bitcoin/bitcoin/pull/20976 06:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:32 -!- csknk [~csknk@unaffiliated/csknk] has joined #bitcoin-core-dev 06:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:32 < bitcoin-git> [gui] hebasto opened pull request #194: Save/restore RPCConsole geometry only for window (master...210121-window) https://github.com/bitcoin-core/gui/pull/194 06:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:32 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 06:34 -!- michael38 [7d3b9770@cm125-59-151-112.hkcable.com.hk] has joined #bitcoin-core-dev 06:35 -!- michael38 [7d3b9770@cm125-59-151-112.hkcable.com.hk] has quit [Client Quit] 06:37 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 06:41 -!- Kiminuo [~mix@217.138.199.12] has joined #bitcoin-core-dev 07:01 -!- mdunnio [~mdunnio@172.97.43.112] has joined #bitcoin-core-dev 07:05 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 07:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:06 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/3734adba390c...85fee49c39cc 07:06 < bitcoin-git> bitcoin/master 713314a Carl Dong: fuzz: Consolidate fuzzing TestingSetup initialization 07:06 < bitcoin-git> bitcoin/master abb6fa7 Carl Dong: fuzz: Initialize a full TestingSetup where appropriate 07:06 < bitcoin-git> bitcoin/master 85fee49 MarcoFalke: Merge #20946: fuzz: Consolidate fuzzing TestingSetup initialization 07:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:07 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20946: fuzz: Consolidate fuzzing TestingSetup initialization (master...2021-01-make-fuzzing-ctx) https://github.com/bitcoin/bitcoin/pull/20946 07:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:08 -!- promag [~promag@188.250.84.129] has quit [Remote host closed the connection] 07:09 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev 07:09 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 07:13 -!- promag [~promag@188.250.84.129] has quit [Ping timeout: 240 seconds] 07:14 -!- jjf [642211e3@pool-100-34-17-227.phlapa.fios.verizon.net] has joined #bitcoin-core-dev 07:19 -!- vadorovsky [vadorovsky@gateway/shell/matrix.org/x-ascnatrwkiaxhdev] has quit [Quit: Bridge terminating on SIGTERM] 07:20 -!- pmuens[m] [pmuensmatr@gateway/shell/matrix.org/x-dyynoprjgdcsipfi] has quit [Quit: Bridge terminating on SIGTERM] 07:20 -!- satwhale[m] [satwhalebi@gateway/shell/matrix.org/x-eihjcfhpnrmtsdkp] has quit [Quit: Bridge terminating on SIGTERM] 07:20 -!- robert_spigler [robertspig@gateway/shell/matrix.org/x-jarlquohwdvsreoz] has quit [Quit: Bridge terminating on SIGTERM] 07:20 -!- marty[m]1 [jmacawmatr@gateway/shell/matrix.org/x-svvamkzvdufqewto] has quit [Quit: Bridge terminating on SIGTERM] 07:20 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-iopmavcdjfxpsgts] has quit [Quit: Bridge terminating on SIGTERM] 07:20 -!- Thomas[m]1 [thomaseizi@gateway/shell/matrix.org/x-zdmmrueyfywdqtsk] has quit [Quit: Bridge terminating on SIGTERM] 07:21 -!- Mercury_Vapor [~Mercury_V@174-082-158-108.res.spectrum.com] has quit [Quit: Leaving] 07:22 -!- nckx [~nckx@tobias.gr] has quit [Ping timeout: 264 seconds] 07:22 -!- nckx [~nckx@tobias.gr] has joined #bitcoin-core-dev 07:28 -!- Mercury_Vapor [~Mercury_V@174-082-158-108.res.spectrum.com] has joined #bitcoin-core-dev 07:30 -!- jjf [642211e3@pool-100-34-17-227.phlapa.fios.verizon.net] has quit [Quit: Ping timeout (120 seconds)] 07:31 -!- marty[m] [jmacawmatr@gateway/shell/matrix.org/x-nfcxffzgldqtttyh] has joined #bitcoin-core-dev 07:42 < elichai2> achow101: I posted the survey on multiple Israeli bitcoin forums/groups, I hope they'll answer it (I feel like the Israeli community uses the gui a lot more than the international one) 07:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:47 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/85fee49c39cc...1f45e8550953 07:47 < bitcoin-git> bitcoin/master b396467 Carl Dong: locks: Annotate CTxMemPool::check to require cs_main 07:47 < bitcoin-git> bitcoin/master 1f45e85 MarcoFalke: Merge #20972: locks: Annotate CTxMemPool::check to require cs_main 07:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:48 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20972: locks: Annotate CTxMemPool::check to require cs_main (master...2021-01-CTxMemPool-spendheight-lock-inversion) https://github.com/bitcoin/bitcoin/pull/20972 07:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:52 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1f45e8550953...11cbd4bb54af 07:52 < bitcoin-git> bitcoin/master ff44cae Russell Yanofsky: test: Change feature_config_args.py not to rely on strange regtest=0 behav... 07:52 < bitcoin-git> bitcoin/master 11cbd4b MarcoFalke: Merge #17556: test: Change feature_config_args.py not to rely on strange r... 07:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:53 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #17556: test: Change feature_config_args.py not to rely on strange regtest=0 behavior (master...pr/wdpy) https://github.com/bitcoin/bitcoin/pull/17556 07:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:53 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev 07:55 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 07:56 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 08:02 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Remote host closed the connection] 08:03 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 08:06 -!- Thomas[m]2 [thomaseizi@gateway/shell/matrix.org/x-azqpygslwwrpdrpb] has joined #bitcoin-core-dev 08:06 -!- robert_spigler [robertspig@gateway/shell/matrix.org/x-abfcudhvaeocjoxd] has joined #bitcoin-core-dev 08:06 -!- vadorovsky [vadorovsky@gateway/shell/matrix.org/x-jqevrflbpbywutyh] has joined #bitcoin-core-dev 08:06 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-itxkddlrjoovovxc] has joined #bitcoin-core-dev 08:06 -!- satwhale[m] [satwhalebi@gateway/shell/matrix.org/x-hdtsxxunreqcsfji] has joined #bitcoin-core-dev 08:07 -!- pmuens[m] [pmuensmatr@gateway/shell/matrix.org/x-bkfidczhyopfdsxk] has joined #bitcoin-core-dev 08:11 -!- mdunnio [~mdunnio@172.97.43.112] has quit [Remote host closed the connection] 08:14 -!- mdunnio [~mdunnio@172.97.43.112] has joined #bitcoin-core-dev 08:30 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 08:30 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 08:31 < b10c> #proposedmeetingtopic USDTs (User Statically Defined Traces) tracepoints in Core? 08:32 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 08:33 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 08:33 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 256 seconds] 08:45 -!- Luke-Jr-jr [~Luke-Jr-j@195.140.213.38] has quit [Ping timeout: 260 seconds] 08:50 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has joined #bitcoin-core-dev 08:56 -!- BitLuck [2f07b1df@047-007-177-223.res.spectrum.com] has joined #bitcoin-core-dev 09:20 -!- BitLuck [2f07b1df@047-007-177-223.res.spectrum.com] has quit [Quit: Connection closed] 09:23 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 09:26 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 09:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:49 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/11cbd4bb54af...45952dab9d2f 09:49 < bitcoin-git> bitcoin/master 66576c4 Kiminuo: test: Clear forced -walletdir setting after wallet init_tests 09:49 < bitcoin-git> bitcoin/master da9caa1 Kiminuo: Replace fs::absolute calls with AbsPathJoin calls 09:49 < bitcoin-git> bitcoin/master 45952da MarcoFalke: Merge #20932: refactor: Replace fs::absolute calls with AbsPathJoin calls 09:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:49 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20932: refactor: Replace fs::absolute calls with AbsPathJoin calls (master...feature/fs-AbsPathJoin) https://github.com/bitcoin/bitcoin/pull/20932 09:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:52 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/45952dab9d2f...53bbbe5a204c 09:52 < bitcoin-git> bitcoin/master d4feb68 Hennadii Stepanov: qt: Use layout manager for Create Wallet dialog 09:52 < bitcoin-git> bitcoin/master 53bbbe5 MarcoFalke: Merge bitcoin-core/gui#171: Use layout manager for Create Wallet dialog 09:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:53 < bitcoin-git> [gui] MarcoFalke merged pull request #171: Use layout manager for Create Wallet dialog (master...210101-wallet) https://github.com/bitcoin-core/gui/pull/171 09:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:55 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/53bbbe5a204c...7f653c3b22f0 09:55 < bitcoin-git> bitcoin/master d439921 Hennadii Stepanov: qt: Add TransactionOverviewWidget class 09:55 < bitcoin-git> bitcoin/master f0d0479 Hennadii Stepanov: qt: Fix TxViewDelegate layout 09:55 < bitcoin-git> bitcoin/master af58f5b Hennadii Stepanov: qt: Stop the effect of hidden widgets on the size of QStackedWidget 09:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:56 < bitcoin-git> [gui] MarcoFalke merged pull request #176: Fix TxViewDelegate layout (master...210103-delegate) https://github.com/bitcoin-core/gui/pull/176 09:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:56 < Kiminuo> \o/ 10:05 -!- flamingspinach1 [~flamingsp@185.244.214.217] has joined #bitcoin-core-dev 10:09 < sdaftuar> pinheadmz: i believe we compare fee rate with directly conflicted transactions, and total fee of the new transaction versus all to-be-evicted transactions 10:10 < sdaftuar> pinheadmz: my recollection is that there are a few issues with how rbf is implemented which we should fix though 10:10 < sdaftuar> jnewbery may have memory/notes on that 10:12 < sdaftuar> (even part from the more well known issues like pinning or using ancestor feerates) 10:17 < pinheadmz> sdaftuar thanks thats my understanding as well. Don't see the rate comparison explicitly in the BIP though -- should I open a PR to the BIP? Or, what is the thinking on back-porting implementation to design notes like that 10:23 < TallTim> "The Bitcoin Core website was modified to remove references to the whitepaper, their local copy of the whitepaper PDF was deleted, and with less than 2 hours of public review this change was merged." 10:23 < TallTim> Way to go kowtowing to CSW. 10:23 < TallTim> On topic, it involves Bitcoin Core website operations and the devs that are spineless. 10:30 -!- kvaciral [~kvaciral@212.8.251.11] has joined #bitcoin-core-dev 10:30 < jnewbery> pinheadmz: I don't think I have notes anywhere, and just a very hazy recollection of some of the details. It's all in MemPoolAccept::PreChecks(). I'd be happy to go through it with you at some point if that's helpful. 10:31 < darosior> pinheadmz: it was in the very first implem though 10:31 < darosior> iirc 10:32 < darosior> pinheadmz: but then if you amend the BIP for this disrepancy, should also mention others (eg: carve-out rule) 10:32 < sipa> i don't think these things belong in BIPs 10:33 < sipa> at least not until there is a clear single recommended approach to dealing with these problems 10:33 < sipa> it seems to me it's a work in progress on how to address them 10:33 < sipa> if there really is a discrepancy between bip125 and what bitcoin core implements, it could be mentioned in doc/bips.md 10:34 < jnewbery> I think the best place for documentation of our high-level conceptual approach to these things is probably https://github.com/bitcoin-core/bitcoin-devwiki/wiki 10:34 < jnewbery> but even there it's possible that it'll diverge from the code over time 10:43 < luke-jr> TallTim: #Bitcoin (also the first part is a lie, and CSW had nothing to do with it) 10:46 < TallTim> The problem with that spin is that it will embolden CSW anyway. You guys may be great at code, but terrible at optics. 10:47 < sdaftuar> sipa: whether bips are the right place or not is unclear to me, but i think communicating relay policies like this so that 3rd party wallets know what behavior to aim for is helpful. in the case of bip125, my hesitation towards amending or redrafting is that we should fix the implementation in other ways anyway 10:47 < luke-jr> TallTim: again, #Bitcoin. It is off-topic here (this is about development of Bitcoin Core, not about developers of Bitcoin Core) 10:47 < sipa> sdaftuar: fair 10:48 < TallTim> Sure thing, code away while your enemies advance. 10:48 < TallTim> I said what I had to say. 10:48 < luke-jr> TallTim: I would like to discuss it with you, but in #Bitcoin 10:48 < TallTim> Its okay, I'm done. 10:49 < sipa> sdaftuar: my point is not that it shouldn't described or documented, only that there isn't a clear solution (yet) that we can write up and say "this is what everyone should be doing" - it's more a work in progress 10:49 < sdaftuar> agreed 10:52 -!- kexkey [~kexkey@static-198-54-132-138.cust.tzulo.com] has joined #bitcoin-core-dev 10:58 -!- pinheadmz [~pinheadmz@68.161.139.178] has quit [Quit: pinheadmz] 11:00 < achow101> meeting? 11:00 < wumpus> #startmeeting 11:00 < core-meetingbot> Meeting started Thu Jan 21 19:00:38 2021 UTC. The chair is wumpus. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings. 11:00 < core-meetingbot> Available commands: action commands idea info link nick 11:00 < jonasschnelli> hi 11:00 < hebasto> hi 11:00 < meshcollider> hi 11:00 < fjahr> hi 11:00 < wumpus> #bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik 11:00 < sipa> hi 11:00 < jonatack> hi 11:00 < wumpus> petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild wumpus 11:00 < achow101> hi 11:01 < jb55> hi 11:01 < MarcoFalke> ai 11:01 < glozow> hai 11:01 < aj> yohoho 11:01 < b10c> hi 11:01 < jnewbery> hi 11:02 < wumpus> two proposed topics for this week: Thoughts on a future IRC meeting discussing taproot activation? (benthecarman), USDTs (User Statically Defined Traces) tracepoints in Core (b10c) 11:03 < wumpus> but let's start with high priority for review 11:04 < wumpus> #topic High priority for review 11:04 < core-meetingbot> topic: High priority for review 11:04 < wumpus> https://github.com/bitcoin/bitcoin/projects/8 11 blockers, 1 bugfix, 2 chasing concept ACK 11:04 < wumpus> anything to add/remove or that is (in your opinion) ready for merge? 11:05 < promag> hi 11:06 < wumpus> looks like not :) 11:06 < wumpus> #topic USDTs (User Statically Defined Traces) tracepoints in Core (b10c) 11:06 < core-meetingbot> topic: USDTs (User Statically Defined Traces) tracepoints in Core (b10c) 11:06 < b10c> While #19866 is merged, I agree with jnewbery's comment in #20960 that there should be an approach discussion before adding USDTs all over the code. 11:07 < wumpus> this would continue #19866 11:07 < gribble> https://github.com/bitcoin/bitcoin/issues/19866 | eBPF Linux tracepoints by jb55 · Pull Request #19866 · bitcoin/bitcoin · GitHub 11:07 < gribble> https://github.com/bitcoin/bitcoin/issues/20960 | doc: Add tracing.md, documenting eBPF tracing by laanwj · Pull Request #20960 · bitcoin/bitcoin · GitHub 11:07 < gribble> https://github.com/bitcoin/bitcoin/issues/19866 | eBPF Linux tracepoints by jb55 · Pull Request #19866 · bitcoin/bitcoin · GitHub 11:07 < wumpus> I tried to document a bit in #20960 11:07 < gribble> https://github.com/bitcoin/bitcoin/issues/20960 | doc: Add tracing.md, documenting eBPF tracing by laanwj · Pull Request #20960 · bitcoin/bitcoin · GitHub 11:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:07 < bitcoin-git> [bitcoin] dongcarl opened pull request #20980: guix: Test security-check sanity before performing them (master...2020-12-guix-mingw-extra-flags) https://github.com/bitcoin/bitcoin/pull/20980 11:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:08 -!- pinheadmz [~pinheadmz@68.161.139.178] has joined #bitcoin-core-dev 11:08 < b10c> I personally do think it makes sense to add USDTs when there is a real longer-term use-case and user. Some example script using the USDT are always good too 11:08 < jonasschnelli> are traces also supported on macOS? 11:08 < wumpus> yes, agree with that 11:08 < wumpus> jonasschnelli: no, this is a linux thing 11:08 < b10c> for ad-hoc tracing/debugging either uprobes or temporary USDT probes can be used 11:09 < wumpus> that was my point in https://github.com/bitcoin/bitcoin/pull/19866#issuecomment-717128433 as well 11:09 < jb55> the motivating example was to not have invasive logging code for everything that needs tracing, like logging raw net msgs. we can utilize tracepoints for that. 11:09 < jb55> and they are nice since they are scriptable 11:09 < wumpus> to have some dedicated static probe point handy for common tasks like logging packets, and collecting statistics (e.g. like the statoshi fork) 11:09 < wumpus> yes 11:10 < jb55> but yeah linux only (and in theory macos but I haven't tested that) 11:10 < wumpus> in any case in other platforms they're simply not compiled in 11:11 < wumpus> I'm not sure what there's actually to discuss here, it seems we agree 11:12 < jb55> I think the general pattern should be pass in any raw struct args that might be useful for bcc scripts/etc. then maybe helper arguments for simpler bpftrace scripts 11:12 < jonasschnelli> I think this would simplify things like getting a mempool fee histogram (15836). Concept ack. 11:12 < b10c> jnewbery's point was to not have to many so the code becomes undreable 11:12 < wumpus> i agree, that should not be the idea 11:13 < wumpus> also they need to be documented, so that they can be used without consulting the source code (that was my point with tracing.md) 11:13 < b10c> I'd be happy to open an issue to collect possible traces 11:13 < b10c> wumpus yeah, agree 11:13 < wumpus> sounds good to me 11:13 < jb55> the network code one will be useful, and connectblock was useful for IBD benchmarks 11:14 < b10c> collect and discuss ofc 11:14 < jnewbery> jb55: I don't think BPF should be seen as an alternative to message dumping. I think they serve different purposes in different situations 11:14 < wumpus> and yes, the idea will be to have their interface, more or less, stable 11:14 < jb55> wumpus: :+1: 11:14 < wumpus> this means something like statoshi can be built withou having to rebase every version, otherwise one might as well use gdb breakpoints on specific functions/code lines 11:14 < jb55> jnewbery: yes its complimentary 11:15 < wumpus> BPF can be used for packet dumping and much more (even packet manipulation IIRC) 11:16 < jnewbery> the nice thing about message dumping as regular functionality is that it can be turned on/off by regular users on any platform 11:16 < jnewbery> BPF can do much more powerful things, but requires a bit of specialized knowledge 11:17 < jnewbery> Do we know what other projects do? Do they have USDT tracepoints in their master branch? 11:17 < wumpus> yes, that's fine, I don't think it has to be one or the other, though I would prefer not to add and maintain a complete tracing infrastructure inside bitcoin core when there are existing solutions, but if it has a clear scope, sure 11:17 < wumpus> yes, many daemon software does 11:17 < jonasschnelli> DTrace is available on macOS,.. does this mean it would be conceptually possible to extend this to macOS as well? 11:17 < jb55> yes 11:17 < wumpus> jonasschnelli: it's conceptually possible to extend it to solaris and macos 11:18 < jonasschnelli> ok 11:18 < wumpus> and freebsd probably 11:18 < jb55> it uses the same macros that should place dtrace probes, but I haven't tested 11:18 < b10c> NodeJS and V8 are two examples where USDTs are in 'master' 11:19 < jnewbery> Great. This is all pretty new to me, but it's very exciting. Thanks jb55, b10c and wumpus for working on it! 11:19 < jonasschnelli> sys/sdt.h is available on mac (includes mach/machine/sdt.h) 11:19 < jonasschnelli> DTRACE_PROBE is defined 11:19 < luke-jr> b10c: not exactly a project I'd want to imitate :P 11:20 < jnewbery> Lots of great resources here: http://brendangregg.com/ for people who want to learn more about BPF 11:20 < b10c> luke-jr: agree :) 11:20 < luke-jr> (it's also only one example: NodeJS is an extension to V8) 11:20 < wumpus> luke-jr: would agree, except in one sense: v8 is extremely performance focused 11:20 < luke-jr> wumpus: true 11:20 < luke-jr> mind you I'm not objecting 11:21 < wumpus> USDT's are very lightweight which makes them useful for counting/measuring things which might otherwise give too much overhead 11:22 < jb55> they are basically nops until the kernel hooks into it afaik 11:22 < wumpus> okay, I'm not exactly sure about the taproot topic, benthecarman isn't here 11:23 < luke-jr> basically the idea is to schedule a day to finish the BIP/code reviews and make a formal proposal; not really a dev topic though 11:23 < luke-jr> well, code review is of course 11:24 < fjahr> IMHO the main conversation should be on the mailing list. Allows more people to participate due to it being async. 11:24 < luke-jr> but not sure there's anything for _this_ meeting 11:24 < wumpus> luke-jr: I agree 11:24 < jonasschnelli> --enable-ebpf works out of the box on macOS 11:24 < luke-jr> fjahr: the idea was simply to get us to the starting poitn for the ML 11:24 < wumpus> jonasschnelli: wow! 11:25 < michaelfolkson> A lot easier to hammer things out in a meeting and then communicate with the ML 11:25 < fjahr> luke-jr: ok, that's great 11:25 < luke-jr> BIP finalised + code reviewed + some idea what to do for activation, then propose that to the ML for further comment 11:26 < michaelfolkson> Just need to get date, time finalized. Could communicate that to mailing list and taproot activation channel 11:28 -!- Netsplit *.net <-> *.split quits: rodarmor, dergoegge 11:28 < wumpus> ok, that concludes the topic as far as this meeting goes, i guess 11:28 -!- dergoegge [sid453889@gateway/web/irccloud.com/x-uboeuicxeymktnyo] has joined #bitcoin-core-dev 11:28 -!- rodarmor [sid210835@gateway/web/irccloud.com/x-yghbonktithatvir] has joined #bitcoin-core-dev 11:28 < wumpus> any other topics? 11:28 < jb55> jonasschnelli: good to know! very cool. 11:29 < nickler> luke-jr: what are the relevant PRs and issues? The two from aj to the BIP8 and your #19573? 11:29 < gribble> https://github.com/bitcoin/bitcoin/issues/19573 | Replace unused BIP 9 logic with draft BIP 8 by luke-jr · Pull Request #19573 · bitcoin/bitcoin · GitHub 11:29 < luke-jr> nickler: yes 11:31 < luke-jr> (obviously aj's BIP PRs may require changes to my code PR) 11:32 < nickler> the PRs are https://github.com/bitcoin/bips/pull/1020 and https://github.com/bitcoin/bips/pull/1021 for the record 11:32 < luke-jr> ty 11:32 < michaelfolkson> And needs to be US and Aus friendly time? 11:33 < aj> luke-jr: haven't checked in a while, but i think the code changes for the bip updates are in the reviews on 19573 11:33 < aj> luke-jr: (this time on a different day seemed to work ok for the taproot reviews fwiw; not great for .au/asia but *shrug*) 11:34 < luke-jr> weekday or weekend? :P 11:34 < michaelfolkson> Next week? Week after? 11:35 < michaelfolkson> Maybe Tuesday 26th Jan or Tuesday 2nd February? 11:36 < luke-jr> fine with me 11:37 < luke-jr> if peopel can't make it, we can always do a 2nd meeting *shrug* 11:37 < fjahr> Maybe give a channel for people to post their thoughts beforehand if they can't join 11:37 < michaelfolkson> Ok let's say Tuesday 2nd February. Give some time to get the word out. Same time as this meeting. 11:37 < michaelfolkson> There is the ##taproot-activation channel 11:37 < luke-jr> someone want to mail the ML? 11:38 < michaelfolkson> In the absence of other volunteers I'm happy to 11:38 < michaelfolkson> Just the links that nickler shared? 11:39 < nickler> perhaps also good to add link to bitcoin wiki page and aj's post 11:39 < luke-jr> good idea, then there's a wiki page to add more info to 11:39 < michaelfolkson> Right ok, I've got them 11:39 -!- jessepos_ [~jp@2601:645:200:162f:edcb:662b:a209:afa] has quit [Quit: Textual IRC Client: www.textualapp.com] 11:39 < luke-jr> nickler: there's also the code, after the BIP reviews 11:39 < luke-jr> err michaelfolkson: * 11:39 -!- jesseposner [~jp@2601:645:200:162f:edcb:662b:a209:afa] has joined #bitcoin-core-dev 11:40 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 11:40 < michaelfolkson> Ok I'll share some of the links on the ##taproot-activation channel and if I miss any please add more before I send to the mailing list 11:40 < michaelfolkson> Can take it to that channel from here 11:41 < sipa> i think that makes sense 11:41 < sipa> this isn't just a bitcoin core thing 11:41 < wumpus> right 11:43 < wumpus> any other topics? 11:45 < michaelfolkson> Not from me 11:45 < wumpus> #endmeeting 11:45 < core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt 11:45 < core-meetingbot> Meeting ended Thu Jan 21 19:45:20 2021 UTC. 11:45 < core-meetingbot> Minutes: https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2021/bitcoin-core-dev.2021-01-21-19.00.moin.txt 11:57 < MarcoFalke> ugh 11:57 < MarcoFalke> looks like appveyor is not installed on the gui repo 11:57 < sipa> can i help? 11:57 < MarcoFalke> one sec 11:57 < MarcoFalke> (master is failing now) 12:01 -!- ogo [~ogo@gateway/tor-sasl/ogo] has quit [Ping timeout: 268 seconds] 12:02 < MarcoFalke> Whoopsie, it's DrahtBots fault. They should have enabled it through their account. 12:02 < MarcoFalke> Done now: https://ci.appveyor.com/project/DrahtBot/gui/builds/37384682 12:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:10 < bitcoin-git> [gui] MarcoFalke closed pull request #177: Use "fusion" style on macOS Big Sur with old Qt (master...210107-style) https://github.com/bitcoin-core/gui/pull/177 12:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:11 < bitcoin-git> [gui] MarcoFalke reopened pull request #177: Use "fusion" style on macOS Big Sur with old Qt (master...210107-style) https://github.com/bitcoin-core/gui/pull/177 12:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:11 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 12:12 -!- promag_ [~promag@188.250.84.129] has joined #bitcoin-core-dev 12:12 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 12:14 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Remote host closed the connection] 12:14 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 12:14 -!- csknk [~csknk@unaffiliated/csknk] has quit [Ping timeout: 256 seconds] 12:15 -!- csknk [~csknk@unaffiliated/csknk] has joined #bitcoin-core-dev 12:15 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 256 seconds] 12:15 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 12:15 -!- promag [~promag@188.250.84.129] has quit [Ping timeout: 256 seconds] 12:19 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 12:23 -!- Tokamak [~Tokamak@204.141.173.217] has joined #bitcoin-core-dev 12:29 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:34 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Ping timeout: 268 seconds] 12:35 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 12:44 -!- csknk [~csknk@unaffiliated/csknk] has quit [Quit: leaving] 12:56 -!- kvaciral [~kvaciral@212.8.251.11] has quit [Quit: leaving] 13:08 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 244 seconds] 13:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:11 < bitcoin-git> [bitcoin] hebasto opened pull request #20983: Fix MSVC build after gui#176 (master...210121-appveyor) https://github.com/bitcoin/bitcoin/pull/20983 13:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:12 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 13:13 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 13:17 -!- alephone [~Aleph@38.142.252.2] has joined #bitcoin-core-dev 13:20 -!- alephone [~Aleph@38.142.252.2] has quit [Quit: Leaving] 13:58 -!- CubicEarth_ [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer] 14:01 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 14:02 -!- ogo [~ogo@gateway/tor-sasl/ogo] has joined #bitcoin-core-dev 14:10 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [] 14:24 -!- larryruane_ [uid473749@gateway/web/irccloud.com/x-eugggjwjgztpovof] has quit [Quit: Connection closed for inactivity] 14:24 < Emcy> wumpus hey you dont know me because im just a random bitcoiner, but i know youre getting a lot of heat because of events that happened today and how you reacted. I want to say that i personally appreciate the work you do and have done for bitcoin very much, and i know many others do too, even if most of the time no one says it. So im saying it now. 14:24 < Emcy> so, thanks for everything 14:28 -!- ogo [~ogo@gateway/tor-sasl/ogo] has quit [Ping timeout: 268 seconds] 14:29 < wumpus> Emcy: thank you 14:31 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 14:42 -!- Kiminuo [~mix@217.138.199.12] has quit [Ping timeout: 265 seconds] 14:48 -!- roconnor [~roconnor@host-45-58-196-78.dyn.295.ca] has joined #bitcoin-core-dev 14:54 -!- ogo [~ogo@gateway/tor-sasl/ogo] has joined #bitcoin-core-dev 14:55 -!- Satoshin [9a4699ce@154.70.153.206] has joined #bitcoin-core-dev 15:00 -!- norisgOG [~norisgOG@89.45.6.105] has joined #bitcoin-core-dev 15:03 -!- Satoshin [9a4699ce@154.70.153.206] has quit [Ping timeout: 248 seconds] 15:04 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 15:05 -!- ogo [~ogo@gateway/tor-sasl/ogo] has quit [Remote host closed the connection] 15:06 -!- ogo [~ogo@gateway/tor-sasl/ogo] has joined #bitcoin-core-dev 15:06 -!- ogo [~ogo@gateway/tor-sasl/ogo] has quit [Remote host closed the connection] 15:06 -!- ogo [~ogo@gateway/tor-sasl/ogo] has joined #bitcoin-core-dev 15:11 -!- ogo [~ogo@gateway/tor-sasl/ogo] has quit [Client Quit] 15:16 -!- ogo [~ogo@gateway/tor-sasl/ogo] has joined #bitcoin-core-dev 15:18 -!- jespada_ [~jespada@90.254.241.81] has quit [Ping timeout: 256 seconds] 15:19 -!- roconnor [~roconnor@host-45-58-196-78.dyn.295.ca] has quit [Ping timeout: 265 seconds] 15:20 -!- jespada [~jespada@90.254.241.81] has joined #bitcoin-core-dev 15:25 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev 15:38 -!- b100100 [~b100100@91.193.4.10] has joined #bitcoin-core-dev 15:40 -!- mdunnio [~mdunnio@172.97.43.112] has quit [Remote host closed the connection] 15:47 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Remote host closed the connection] 15:48 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 15:54 -!- b100100 [~b100100@91.193.4.10] has quit [Quit: Leaving] 15:58 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 15:59 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 16:18 -!- promag_ [~promag@188.250.84.129] has quit [Remote host closed the connection] 16:24 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 16:24 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev 16:24 -!- promag [~promag@188.250.84.129] has quit [Remote host closed the connection] 16:25 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 16:27 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 268 seconds] 16:34 -!- triagra [9a105d6b@154.16.93.107] has joined #bitcoin-core-dev 16:41 -!- Netsplit *.net <-> *.split quits: sdaftuar, andrewtoth_, morcos, yanmaani, virtu, sipa, DeanWeen, braydonf, davterra, vasild, (+5 more, use /NETSPLIT to show all of them) 16:44 -!- triagra [9a105d6b@154.16.93.107] has quit [Quit: Ping timeout (120 seconds)] 16:45 -!- triagra [9a105d6b@154.16.93.107] has joined #bitcoin-core-dev 16:46 -!- flamingspinach1 [~flamingsp@185.244.214.217] has quit [Remote host closed the connection] 16:49 -!- triagra [9a105d6b@154.16.93.107] has quit [Client Quit] 16:50 -!- triagra [9a105d6b@154.16.93.107] has joined #bitcoin-core-dev 16:58 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 16:58 -!- Netsplit over, joins: jb55 16:59 -!- Netsplit over, joins: ghost43 17:01 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev 17:02 -!- promag [~promag@188.250.84.129] has quit [Remote host closed the connection] 17:03 -!- devnewton [~devnewton@139.28.218.148] has joined #bitcoin-core-dev 17:03 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev 17:04 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 17:05 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev 17:07 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 17:08 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 17:08 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev 17:12 -!- virtu [~virtu@gateway/tor-sasl/virtu] has joined #bitcoin-core-dev 17:12 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 17:12 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 17:18 -!- triagra [9a105d6b@154.16.93.107] has quit [Quit: Ping timeout (120 seconds)] 17:32 -!- triagra222 [9a105d6b@154.16.93.107] has joined #bitcoin-core-dev 17:34 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 17:35 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 268 seconds] 17:40 -!- triagra222 [9a105d6b@154.16.93.107] has quit [Quit: Connection closed] 17:44 -!- triagra222 [b2efadb0@178.239.173.176] has joined #bitcoin-core-dev 17:49 -!- triagra222 [b2efadb0@178.239.173.176] has quit [Quit: Ping timeout (120 seconds)] 17:50 -!- triagra222 [b2efadb0@178.239.173.176] has joined #bitcoin-core-dev 17:54 -!- triagra222 [b2efadb0@178.239.173.176] has quit [Client Quit] 17:55 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has quit [Ping timeout: 264 seconds] 18:00 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...] 18:14 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 268 seconds] 18:15 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Remote host closed the connection] 18:15 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 18:16 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 18:16 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev 18:16 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 18:23 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev 19:20 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...] 19:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 19:28 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7f653c3b22f0...d6c3c43ef8d9 19:28 < bitcoin-git> bitcoin/master c5354e4 Hennadii Stepanov: Fix MSVC build after gui#176 19:28 < bitcoin-git> bitcoin/master d6c3c43 fanquake: Merge #20983: Fix MSVC build after gui#176 19:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 19:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 19:28 < bitcoin-git> [bitcoin] fanquake merged pull request #20983: Fix MSVC build after gui#176 (master...210121-appveyor) https://github.com/bitcoin/bitcoin/pull/20983 19:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 19:32 -!- udecker [~udecker@173.243.88.22] has quit [Ping timeout: 246 seconds] 19:39 -!- udecker [~udecker@173.243.88.22] has joined #bitcoin-core-dev 20:04 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection] 20:05 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev 20:09 -!- jeremyrubin [~jr@2601:645:c200:14:91a5:d8cb:fe32:d136] has joined #bitcoin-core-dev 20:14 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev 20:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 20:17 < bitcoin-git> [bitcoin] fanquake pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/d6c3c43ef8d9...019aa248d931 20:17 < bitcoin-git> bitcoin/master 37fe73a Carl Dong: build: Add var printing target to src/Makefile.am 20:17 < bitcoin-git> bitcoin/master c9eb4cf Carl Dong: guix: Add support for darwin builds 20:17 < bitcoin-git> bitcoin/master f3835dc Carl Dong: build: Make xorrisofs reproducible with -volume_date 20:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 20:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 20:18 < bitcoin-git> [bitcoin] fanquake merged pull request #17920: guix: Build support for macOS (master...2020-01-guix-macos) https://github.com/bitcoin/bitcoin/pull/17920 20:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 20:21 < fanquake> Guix trifecta 20:21 < fanquake> macOS was always coming in last 20:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 20:59 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/019aa248d931...4bd586607d63 20:59 < bitcoin-git> bitcoin/master 9624442 Sebastian Falbesoner: zmq: deduplicate 'sequence' publisher message creation/sending 20:59 < bitcoin-git> bitcoin/master 4bd5866 fanquake: Merge #20523: zmq: deduplicate 'sequence' publisher message creation/sendi... 20:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 21:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 21:00 < bitcoin-git> [bitcoin] fanquake merged pull request #20523: zmq: deduplicate 'sequence' publisher message creation/sending (master...20201128-zmq-refactor-dedup_sequence_msg_sending) https://github.com/bitcoin/bitcoin/pull/20523 21:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 21:33 -!- mosh [~chaos@anarchy.consolegfx.com] has joined #bitcoin-core-dev 21:36 -!- jespada [~jespada@90.254.241.81] has quit [Ping timeout: 265 seconds] 21:36 -!- Tokamak [~Tokamak@204.141.173.217] has quit [Ping timeout: 240 seconds] 21:37 -!- jespada [~jespada@90.254.241.81] has joined #bitcoin-core-dev 21:42 -!- michael67 [7d3b9770@cm125-59-151-112.hkcable.com.hk] has joined #bitcoin-core-dev 21:50 -!- mj_node [~mj_node@202.187.154.51] has joined #bitcoin-core-dev 21:52 -!- michael67 [7d3b9770@cm125-59-151-112.hkcable.com.hk] has quit [Quit: Ping timeout (120 seconds)] 21:55 -!- Tokamak [~Tokamak@204.141.172.64] has joined #bitcoin-core-dev 22:15 < sipa> aj: thanks for clearing that up in #20970 22:15 < gribble> https://github.com/bitcoin/bitcoin/issues/20970 | Fix a bug that personal signet can not be created. by fujicoin · Pull Request #20970 · bitcoin/bitcoin · GitHub 22:24 < midnight> /w gmax 22:24 < midnight> dangit 22:29 -!- patriot2939 [~patriot29@unaffiliated/patriot2939] has quit [Ping timeout: 246 seconds] 22:30 -!- patriot2939 [~patriot29@unaffiliated/patriot2939] has joined #bitcoin-core-dev 22:34 -!- Kiminuo [~mix@217.138.199.12] has joined #bitcoin-core-dev 22:37 -!- guest534543 [~mix@193.9.112.92] has joined #bitcoin-core-dev 22:41 -!- Kiminuo [~mix@217.138.199.12] has quit [Ping timeout: 272 seconds] 22:47 -!- patriot2939 [~patriot29@unaffiliated/patriot2939] has quit [Ping timeout: 272 seconds] 22:47 -!- patriot2939 [~patriot29@unaffiliated/patriot2939] has joined #bitcoin-core-dev 23:21 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 264 seconds] 23:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:34 < bitcoin-git> [gui] MarcoFalke opened pull request #196: IGNORE TEST APPVEYOR (master...MarcoFalke-patch-1) https://github.com/bitcoin-core/gui/pull/196 23:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:38 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 23:38 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 23:40 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 23:41 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 23:44 -!- ogo [~ogo@gateway/tor-sasl/ogo] has joined #bitcoin-core-dev --- Log closed Fri Jan 22 00:00:22 2021