--- Log opened Tue Jan 26 00:00:07 2021
--- Day changed Tue Jan 26 2021
00:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:00 < bitcoin-git> [bitcoin] fanquake opened pull request #21010: refactor: remove straggling boost::mutex usage (master...why_new_boost_depend) https://github.com/bitcoin/bitcoin/pull/21010
00:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:01 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 272 seconds]
00:06 < wumpus> hahaha the remaining test was literallly a test to test the boost mutex lock functionality *itself*
00:07 < fanquake> the best kind of unused code
00:07 < wumpus> yess
00:07 < sipa> we should add a test that removing said test is safe
00:08 < sipa> 00:06:32 < wumpus> hahaha the remaining test was literallly a test to test the boost mutex lock functionality itself
00:08 -!- rpite [~rpite@47.187.219.52] has joined #bitcoin-core-dev
00:08 < sipa> that's pretty hilarious
00:15 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Ping timeout: 268 seconds]
00:15 < wumpus> it is :)
00:15 < wumpus> boost::thread_group would be fairly low-hanging fruit to get rid of now too
00:16 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev
00:18 -!- Tokamak [~Tokamak@204.141.172.64] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
00:20 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
00:29 -!- viraltaco_ [~taco@unaffiliated/d-b/x-8688605] has joined #bitcoin-core-dev
00:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:32 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/16ae3368f2a2...280d0bd0bd19
00:32 < bitcoin-git> bitcoin/master f827e15 fanquake: refactor: remove straggling boost::mutex usage
00:32 < bitcoin-git> bitcoin/master 280d0bd MarcoFalke: Merge #21010: refactor: remove straggling boost::mutex usage
00:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:32 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #21010: refactor: remove straggling boost::mutex usage (master...why_new_boost_depend) https://github.com/bitcoin/bitcoin/pull/21010
00:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:33 < viraltaco_> Why do you hate std::mutex :( 
00:34 < sipa> ?
00:35 < viraltaco_> I'm trying to socialize. Don't mind unless it works 
00:36 < sipa> i'd say it's working
00:37 -!- S3RK [~S3RK@213.55.241.156] has joined #bitcoin-core-dev
00:40 < viraltaco_> How are public addresses generated? 😕 I'd like to end up with something nice but I can't brute force my way to that because I don't have infinite time, or resources :( (hate when that happens)
00:42 < sipa> viraltaco_: that"s off topic her; try #bitcoin, or https://bitcoin.stackexchange.com
00:42 < viraltaco_> You must know where it is in the code, tho D: 
00:43 < viraltaco_> I tried to find it but I have adhd, so I ended up here when I started learning solidity 
00:43 < sipa> i do, but i'm not going to answer here, as this is not the place
00:44 < sipa> i'm happy to answer on bitcoin se
00:44 < viraltaco_> aight
00:49 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
00:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:49 < bitcoin-git> [gui] MarcoFalke merged pull request #167: raise helpMessageDialog (master...help-message-raise) https://github.com/bitcoin-core/gui/pull/167
00:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:49 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/280d0bd0bd19...cbe439629e2b
00:49 < bitcoin-git> bitcoin/master 7711446 randymcmillan: raise helpMessageDialog
00:49 < bitcoin-git> bitcoin/master cbe4396 MarcoFalke: Merge bitcoin-core/gui#167: raise helpMessageDialog
00:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:54 < vasild> < wumpus> hahaha the remaining test was literallly a test to test the boost mutex lock functionality *itself*
00:54 < vasild> wumpus: if you mean this test: https://github.com/bitcoin/bitcoin/pull/21010/files#diff-5032793d826572728e0cb737ebba6695f83085300ee2ff04bfa88343eba4482aL113, it is more than that
00:55 < vasild> it tests that our debug lock order/double lock detector would detect a double lock if the underlying mutex is boost::mutex
00:55 -!- n1ma [2ffeaa16@47.254.170.22] has joined #bitcoin-core-dev
00:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:58 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cbe439629e2b...ce75fc36edc8
00:58 < bitcoin-git> bitcoin/master fa39c8a MarcoFalke: test: Work around libFuzzer deadlock
00:58 < bitcoin-git> bitcoin/master ce75fc3 MarcoFalke: Merge #20971: test: Work around libFuzzer deadlock
00:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:58 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20971: test: Work around libFuzzer deadlock (master...2101-fuzzDeadlock) https://github.com/bitcoin/bitcoin/pull/20971
00:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:00 -!- pmuens[m] [pmuensmatr@gateway/shell/matrix.org/x-ogxnmgkfnwkctxqz] has quit [Quit: Idle for 30+ days]
01:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:02 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ce75fc36edc8...32d44d2b1ca3
01:02 < bitcoin-git> bitcoin/master 58232e3 practicalswift: fuzz: Avoid -fsanitize=integer warnings in fuzzing harnesses
01:02 < bitcoin-git> bitcoin/master f0f8b1a practicalswift: fuzz: Add UBSan suppressions needed for fuzz tests to not warn under -fsan...
01:02 < bitcoin-git> bitcoin/master 32d44d2 MarcoFalke: Merge #21000: fuzz: Add UBSan suppressions needed for fuzz tests to not wa...
01:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:02 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #21000: fuzz: Add UBSan suppressions needed for fuzz tests to not warn under -fsanitize=integer (master...fsanitize-integer) https://github.com/bitcoin/bitcoin/pull/21000
01:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:10 < wumpus> viraltaco_: we love std::mutex so much that we are banishing every other kind of mutex, like boosts
01:10 < viraltaco_> `bool CWallet::IsWalletFlagSet(uint64_t flag) const` why not `bool CWallet::IsWalletFlagSet(const uint64_t flag) const noexcept`? :C 
01:10 < wumpus> vasild: okay
01:10 < viraltaco_> (cf: https://github.com/bitcoin/bitcoin/blob/32d44d2b1ca3881eeaa8d28d6c411002bc38b154/src/wallet/wallet.cpp#L1472 )
01:11 < viraltaco_> Why don't users get rewards for running full nodes? 😕 I think it used to be a thing 
01:12 < wumpus> #bitcoin please
01:13 < wumpus> this channel is for development, it is not a general bitcoin related social channel
01:15 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
01:17 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
01:17 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
01:17 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has quit [Read error: Connection reset by peer]
01:19 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-dev
01:20 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
01:20 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
01:21 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
01:25 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
01:26 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
01:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:30 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/32d44d2b1ca3...d38e2d9a19c9
01:30 < bitcoin-git> bitcoin/master 232d1f9 Prayank: Add information to "Confirm fee bump" window
01:30 < bitcoin-git> bitcoin/master d38e2d9 Jonas Schnelli: Merge bitcoin-core/gui#186: Add information to "Confirm fee bump" window
01:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:30 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
01:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:31 < bitcoin-git> [gui] jonasschnelli merged pull request #186: Add information to "Confirm fee bump" window (master...bump-fee) https://github.com/bitcoin-core/gui/pull/186
01:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:31 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
01:34 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has quit [Remote host closed the connection]
01:35 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
01:36 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
01:39 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection]
01:40 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev
01:40 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
01:40 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
01:41 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
01:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:41 < bitcoin-git> [gui] jonasschnelli merged pull request #189: qt: drop workaround for QTBUG-42503 which was fixed in Qt 5.5.0 (master...qtbug-42503) https://github.com/bitcoin-core/gui/pull/189
01:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:42 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d38e2d9a19c9...5f65f135977e
01:42 < bitcoin-git> bitcoin/master a2a3f4c Pavol Rusnak: qt: drop workaround for QTBUG-42503 which was fixed in Qt 5.5.0
01:42 < bitcoin-git> bitcoin/master 5f65f13 Jonas Schnelli: Merge bitcoin-core/gui#189: qt: drop workaround for QTBUG-42503 which was ...
01:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:45 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
01:46 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
01:50 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
01:51 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
02:04 -!- kexkey [~kexkey@static-198-54-132-152.cust.tzulo.com] has quit [Ping timeout: 240 seconds]
02:14 < wumpus> vasild: i agree there is more to that test than seemed at first glace
02:14 < vasild> it is good that is gone now, together with the rest of boost::mutex usage :)
02:15 < wumpus> that definitely :)
02:15 < viraltaco_> Is QT new? I don't remember core using QT before… Am I wrong? 
02:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:16 < bitcoin-git> [gui] MarcoFalke merged pull request #183: Add include for std::bind. (master...functional) https://github.com/bitcoin-core/gui/pull/183
02:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:16 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5f65f135977e...e130ff38c91a
02:16 < bitcoin-git> bitcoin/master 2a39ccf sinetek: Add include for std::bind.
02:16 < bitcoin-git> bitcoin/master e130ff3 MarcoFalke: Merge bitcoin-core/gui#183: Add include for std::bind.
02:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:26 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services]
02:26 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
02:26 -!- vasild_ is now known as vasild
02:27 < wumpus> viraltaco_: again, #bitcoin please
02:29 -!- viraltaco_ [~taco@unaffiliated/d-b/x-8688605] has left #bitcoin-core-dev ["👋"]
03:00 -!- theStack [~honeybadg@vps1648322.vs.webtropia-customer.com] has left #bitcoin-core-dev []
03:01 -!- theStack [~honeybadg@vps1648322.vs.webtropia-customer.com] has joined #bitcoin-core-dev
03:01 < theStack> could anyone with write access to the repository convert #21008 to draft please? (the "fix" seems to fail on two cirrus instances immediately :/)
03:01 < gribble> https://github.com/bitcoin/bitcoin/issues/21008 | test: fix zmq test flakiness, improve speed by theStack · Pull Request #21008 · bitcoin/bitcoin · GitHub
03:06 < aj> theStack: done
03:07 < theStack> aj: thanks!
03:07 -!- n1ma [2ffeaa16@47.254.170.22] has quit [Quit: Ping timeout (120 seconds)]
03:17 < wumpus> theStack: is it not possible to convert your own PRs to draft?
03:18 < fjahr> It is, just did it last night
03:18 < wumpus> phew, i just assumed everyone had that option, but wasn't sure :)
03:18 < fjahr> It is a link below the participants on the right iirc
03:19 < fjahr> “Convert to draft”
03:20 -!- robert_spigler [robertspig@gateway/shell/matrix.org/x-bpcjxeplbxvwmnfj] has quit [Quit: Bridge terminating on SIGTERM]
03:20 -!- Thomas[m]1 [thomaseizi@gateway/shell/matrix.org/x-gtjbdqzmrdmnojqz] has quit [Quit: Bridge terminating on SIGTERM]
03:20 -!- satwhale[m] [satwhalebi@gateway/shell/matrix.org/x-dbqxdiphhdoisamf] has quit [Quit: Bridge terminating on SIGTERM]
03:20 -!- marty[m]1 [jmacawmatr@gateway/shell/matrix.org/x-zgmzrasscymgznkc] has quit [Quit: Bridge terminating on SIGTERM]
03:20 -!- vadorovsky [vadorovsky@gateway/shell/matrix.org/x-lhrlefcfvzytblos] has quit [Quit: Bridge terminating on SIGTERM]
03:20 -!- suzziminer[m] [suzziminer@gateway/shell/matrix.org/x-qnmpvfofbwaggdoh] has quit [Quit: Bridge terminating on SIGTERM]
03:20 < wumpus> ya, it's a bit stealth, i always have to do a browser search to find it, also *converting from draft* is in a wholly different place (a button at the bottom)
03:20 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-siusbsmcggrluxrz] has quit [Quit: Bridge terminating on SIGTERM]
03:21 < aj> yeah, it's text not a button for some reason?
03:31 -!- vadorovsky [vadorovsky@gateway/shell/matrix.org/x-udchcueruetlwodq] has joined #bitcoin-core-dev
03:46 < wumpus> rightt it's becoming so cluttered
03:55 -!- midnight [~midnight@unaffiliated/midnightmagic] has quit [Ping timeout: 240 seconds]
03:57 -!- midnight [~midnight@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
04:04 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-edwxmfygcknzvzdm] has joined #bitcoin-core-dev
04:04 -!- Thomas[m]1 [thomaseizi@gateway/shell/matrix.org/x-ttkngbbcpwntnuwl] has joined #bitcoin-core-dev
04:04 -!- robert_spigler [robertspig@gateway/shell/matrix.org/x-lbuupayhytlukzpn] has joined #bitcoin-core-dev
04:04 -!- suzziminer[m] [suzziminer@gateway/shell/matrix.org/x-jipjewathhgpnlbn] has joined #bitcoin-core-dev
04:04 -!- marty[m]1 [jmacawmatr@gateway/shell/matrix.org/x-ykqdjfzepgmimbhx] has joined #bitcoin-core-dev
04:04 -!- satwhale[m] [satwhalebi@gateway/shell/matrix.org/x-lygpugkdpqucexsc] has joined #bitcoin-core-dev
04:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:05 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #21012: ci: Fuzz with integer sanitizer (master...2101-fuzzIntSan) https://github.com/bitcoin/bitcoin/pull/21012
04:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:08 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
04:14 < setpill> Question about the gitian stuff again - what's the point of apt-cacher-ng? Is there a reason to not just straight up use ubuntu package servers?
04:25 < wumpus> setpill: if you do a lot of VM work (e.g. spin up new VMs, upgrade them, throw them away again) like gitian does then having your own apt cache makes sense
04:25 < wumpus> it's an optimization but not necessary
04:26 < wumpus> e.g. mind that gitian *never* upgrades the base image, does an apt-get dist-upgrade as first thing which (even with caching) is one of the longest-taking parts of the build
04:27 < wumpus> it wouldn't necessarily have to be like that but it is :)
04:27 < setpill> Trying to set up a CI/CD-friendly docker-only pipeline
04:28 < setpill> Since it uses docker, any needed caching can be done through that
04:30 < wumpus> it's one more thing that won't be needed anymore after moving to guix builds (which also handles caching dependencies itself)
04:31 < setpill> Also fwiw gitian-builder/bin/make-base-vm does do `docker build --pull` so in that part of the process the base image is "upgraded" (or at least the latest version is fetched from upstream)
04:31 < setpill> Hmm rightr
04:31 < wumpus> okay, it does not do so for LXC and KVM builds, i always use LXC
04:33 < wumpus> (and i use a lot of VMs even outside of gitian, so running my own apt cacher makes sense)
04:33 < setpill> Yeah, that makes sense.
04:34 < setpill> I'll just add a flag to disable it, since installing apt-cacher-ng in the host image is kind of a pita
04:35 < setpill> Since building docker images from within docker needs alpine-based images
04:48 < setpill> Out of curiosity - is the guix approach going to be docker-friendly?
04:49 < setpill> Would be nice to have, to make it easier to set up automated builds. Docker-based workflows and infrastructure are pretty widespread.
04:56 < prusnak> MarcoFalke: 
04:57 < prusnak> MarcoFalke: will you upload your public GPG key to github, so the history shows Verified instead of Unverified?
04:57 < prusnak> https://github.com/bitcoin/bitcoin/commits/master
04:57 -!- belcher_ is now known as belcher
05:20 -!- ironhelix [~x@136.144.43.193] has quit [Ping timeout: 256 seconds]
05:23 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
05:24 < MarcoFalke> prusnak: no I won't, we should be trusing GitHub less, rather than more
05:26 < MarcoFalke> setpill: Yes, guix can run in docker
05:26 < prusnak> fair enough
05:57 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has joined #bitcoin-core-dev
06:08 < wumpus> MarcoFalke: good point, centralizing both the git hosting and signature verification in one place somewhat defeats the reason to sign commits in the first place
06:08 < wumpus> e.g. if github is compromised they could add arbitrary commits and also show them as verified
06:09 < wumpus> at least if you verify locally it protects against that
06:10 < hebasto> it's pretty easy to verify commit sigs locally
06:16 < wumpus> btw does github have some kind of shortcut to quickly jump to a PR/issue by number? i keep ending up having to edit the browser URL, it feels like this should be easier
06:21 < aj> wumpus: i setup https://github.com/bitcoin/bitcoin/pull/%s as a bookmark in firefox with the keyword "btc" so i can type "btc 12345" in the url bar to get to PR 12345
06:21 < aj> wumpus: seems to redirect fine if i put an issue number in too
06:22 < wumpus> aj: seems like a good idea
06:22 < wumpus> i'm always disappointed that typing, say '#<issue>' in the search bar doesn't simply take you to that issue
06:23 < wumpus> noooo it searches for that number in the source code, that's soo useful for a jump-to feature
06:25 < wumpus> but handling it at the browser level makes sense thanks
06:27 -!- LiterallyMe [~Literally@180.red-2-137-54.dynamicip.rima-tde.net] has joined #bitcoin-core-dev
06:35 < jnewbery> Hi folks. We have a p2p meeting in about 25 minutes. Two proposed topics at https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings#26-jan-2021
06:35 < gribble> https://github.com/bitcoin/bitcoin/issues/26 | Confirmations not appearing for sent coins after recovering wallet from archive · Issue #26 · bitcoin/bitcoin · GitHub
06:35 < jnewbery> Feel free to add more topics
06:37 < jonatack> jnewbery: i moved my topics to the feb 9 meeting
06:39 < jnewbery> ok
06:40 < jnewbery> wumpus: I have pr -> https://github.com/bitcoin/bitcoin/pull/%s and bc -> https://github.com/bitcoin/bitcoin/search?q=%s . The second one is particularly useful for jumping from a commit hash in git to the commit/PR in github
06:42 < jonatack> i've been using this from the command line: gh pr view <number> -w
06:43 < jonatack> with https://cli.github.com/
06:44 -!- g0te [590cb6aa@dynamic-089-012-182-170.89.12.pool.telefonica.de] has joined #bitcoin-core-dev
06:44 -!- jrawsthorne [~jrawsthor@static.235.41.217.95.clients.your-server.de] has quit [Read error: Connection reset by peer]
06:44 -!- jrawsthorne [~jrawsthor@static.235.41.217.95.clients.your-server.de] has joined #bitcoin-core-dev
06:44 -!- yunier2002 [~yunier200@c-73-85-126-91.hsd1.fl.comcast.net] has quit [Ping timeout: 246 seconds]
06:44 < jonatack> not being too dependent on it but trying to do more GitHub interaction from the command line, it's getting slowly better, not a full replacement yet
06:51 < aj> <aj> jnewbery: what do you think of a "p2p agenda/priorities" page on the devwiki, that's just "current status" rather than an "rss feed/log" like the p2p meeting page is? be a nice place to capture/update todo lists, and could serve as an agenda each week (for both overall priorities and a hashtag-proposedp2pmeetingtopic thing) ?
06:53 < jnewbery> < jnewbery> aj: ACK. If you create the first version of the page I can link to it from the p2p meeting page, and I'll add my own priorities
06:53 < aj> jnewbery: hmm, i don't remember seeing that
06:53 < jnewbery> I think it's a good idea
06:54 < aj> jnewbery: ah, i'd gone to sleep by then perhaps
06:55 < jonatack> also: gh pr view <number> -c (e.g. --comments) allows loading all the PR comments without the "84 hidden items" messages and clicking through over and over
06:55 < wumpus> jonatack: oh nice, does that also work authenticated?
06:57 < wumpus> yes the hidden items are another frequent source of confusion
06:57 < jnewbery> jonatack: that is nice! The hidden items are github's worst feature
06:57 < jonatack> yess. but it takes getting used to the output.
06:57 < jonatack> wumpus: authenticated?
06:59 < wumpus> jonatack: yes, for posting things, and accessing private repositories
07:00 < jnewbery> #startmeeting
07:00 < jnewbery> #bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik petertodd 
07:00 < jnewbery> phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild wumpus
07:00 < jnewbery> hi
07:00 < amiti> hi
07:00 < wumpus> hi
07:00 < vasild> hi
07:00 < jonatack> hi
07:01 < jnewbery> No proposed topics this week: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings#26-jan-2021
07:01 < gribble> https://github.com/bitcoin/bitcoin/issues/26 | Confirmations not appearing for sent coins after recovering wallet from archive · Issue #26 · bitcoin/bitcoin · GitHub
07:01 < emzy> hi
07:01 < jnewbery> Does anyone have any updates that they'd like to share with the group?
07:02 < jnewbery> could be a short meeting :)
07:03 < sipa> great
07:03 < aj> jnewbery: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-Current-Priorities
07:03 < jnewbery> I agree
07:04 < emzy> Is there a monitor for DNS seeds?
07:04 < MarcoFalke> I've been making small progress fuzzing net_processing, but it is moving slow. Currently waiting on #20044 :) 
07:04 < gribble> https://github.com/bitcoin/bitcoin/issues/20044 | Make all of net_processing (and some of net) use std::chrono types by sipa · Pull Request #20044 · bitcoin/bitcoin · GitHub
07:04 < jnewbery> Thanks aj!
07:04 < jnewbery> sipa: are you happy to make 20044 up for grabs?
07:04 < wumpus> emzy: there's a script in maintainer-tools that checks if they're up and if they return results
07:04 < glozow> hai
07:05 < sipa> jnewbery: ack
07:05 < jnewbery> ok, let's call the meeting there. Homework for next meeting on Feb 9 is to fill in your priorities in https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-Current-Priorities so we have something to talk about
07:05 < jnewbery> #endmeeting
07:05 < MarcoFalke> but who's grabbing it?
07:06 < sipa> i suggest a gr-grab-by-combat to decide it
07:07 < vasild> I just added it to my to-review list
07:07 < aj> sipa: compile by combat?
07:07 < emzy> wumpus: tnx. I found it. I will include that in my personal icinga monitoring.
07:07 < wumpus> jonatack: seems like a nice tool, the only thing i dislike is that it's written in go, i'd managed to avoid having to install a go toolchain on my bitcoin dev VM until now :-)
07:07 < wumpus> emzy: yeah if you need some other output format like json feel free to add that
07:07 < wumpus> (as a command line option)
07:10 < vasild> I am just trying to figure why a newly added fuzz test to ser/unser addrman crashes. After that I will review 20044 if somebody has rebased it, or I can rebase it if nobody has done so by then.
07:11 < MarcoFalke> vasild: Which pull?
07:12 < vasild> MarcoFalke: you mean the fuzz test? I wrote a test for #20557
07:12 < gribble> https://github.com/bitcoin/bitcoin/issues/20557 | addrman: Fix new table bucketing during unserialization by jnewbery · Pull Request #20557 · bitcoin/bitcoin · GitHub
07:12 < MarcoFalke> oh, you wrote the fuzz tests and it doesn't have a pull yet?
07:12 < vasild> yes
07:12 < MarcoFalke> heh, can't help there
07:12 < MarcoFalke> good luck
07:13 < vasild> 90% chance it is a problem in the test itself and 10% chance it discovered a real problem.
07:13 < vasild> :-D
07:14 < aj> sipa/jnewbery: up for grabs prs are usually closed, no?
07:15 -!- ovovo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
07:16 < vasild> https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-Current-Priorities -- all entries are from Jan 27, but today is Jan 26.
07:16 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 265 seconds]
07:17 < aj> vasild: says you
07:17 < jonatack> vasild: my guess is it's tomorrow down under
07:17 < vasild> :-D
07:17 < aj> recommended documentary series on the topic https://www.imdb.com/title/tt0069647/
07:21 -!- Kiminuo [~mix@193.9.112.92] has quit [Ping timeout: 272 seconds]
07:28 < jnewbery> aj: usually, yes
07:34 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 268 seconds]
07:34 -!- jrawsthorne [~jrawsthor@static.235.41.217.95.clients.your-server.de] has quit [Read error: Connection reset by peer]
07:34 -!- jrawsthorne [~jrawsthor@static.235.41.217.95.clients.your-server.de] has joined #bitcoin-core-dev
07:43 -!- jrawsthorne [~jrawsthor@static.235.41.217.95.clients.your-server.de] has quit [Read error: Connection reset by peer]
07:44 -!- jrawsthorne [~jrawsthor@static.235.41.217.95.clients.your-server.de] has joined #bitcoin-core-dev
07:45 -!- jrawsthorne [~jrawsthor@static.235.41.217.95.clients.your-server.de] has quit [Read error: Connection reset by peer]
07:45 -!- jrawsthorne [~jrawsthor@static.235.41.217.95.clients.your-server.de] has joined #bitcoin-core-dev
07:48 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
07:49 -!- ovovo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 260 seconds]
07:49 -!- owowo [~ovovo@2a02:29b8:dc01:597::1e] has joined #bitcoin-core-dev
07:49 -!- owowo [~ovovo@2a02:29b8:dc01:597::1e] has quit [Changing host]
07:49 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
07:58 -!- exhoplex [~echo@139.180.133.130] has quit [Ping timeout: 264 seconds]
07:59 -!- exhoplex [~echo@139.180.133.130] has joined #bitcoin-core-dev
07:59 -!- IGHOR [~quassel@176.121.4.135] has joined #bitcoin-core-dev
08:06 -!- g0te [590cb6aa@dynamic-089-012-182-170.89.12.pool.telefonica.de] has quit [Quit: Ping timeout (120 seconds)]
08:10 < vasild> MarcoFalke: hmm, generating 50k addresses to fill addrman would require a few 100s of kilobytes of fuzzing input, is that reasonable? I think not.
08:11 < MarcoFalke> We have more then 5 GB of inputs
08:11 < MarcoFalke> +1MB shouldn't matter
08:13 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 272 seconds]
08:13 -!- owowo [~ovovo@91.193.4.76] has joined #bitcoin-core-dev
08:13 -!- owowo [~ovovo@91.193.4.76] has quit [Changing host]
08:13 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
08:14 < vasild> hmm
08:23 -!- Tokamak [~Tokamak@204.141.173.217] has joined #bitcoin-core-dev
08:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:31 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #20044: Make all of net_processing (and some of net) use std::chrono types (master...202009_chrono_types) https://github.com/bitcoin/bitcoin/pull/20044
08:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:35 -!- Emcy_ [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
08:35 -!- sr_gi [~sr_gi@static-6-109-229-77.ipcom.comunitel.net] has quit [Read error: Connection reset by peer]
08:36 -!- sr_gi [~sr_gi@static-6-109-229-77.ipcom.comunitel.net] has joined #bitcoin-core-dev
08:39 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 272 seconds]
08:58 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Ping timeout: 268 seconds]
08:59 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev
09:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:03 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #21012: ci: Fuzz with integer sanitizer (master...2101-fuzzIntSan) https://github.com/bitcoin/bitcoin/pull/21012
09:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:09 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
09:09 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
09:10 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
09:11 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
09:15 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
09:16 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
09:18 < vasild> jnewbery: review https://github.com/jnewbery/bitcoin/pull/18 carefully, it looks a bit suspicious to me.
09:20 < vasild> the fuzz test adds just a few entries to addrman as far as I have observed, even though there should be 1..100 sources with each one providing 1..1000 addresses. I will play with it further tomorrow...
09:20 -!- kabaum [~kabaum@h-13-35.A163.priv.bahnhof.se] has quit [Ping timeout: 264 seconds]
09:20 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
09:20  * vasild afk
09:21 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
09:21 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit []
09:25 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev
09:25 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
09:26 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
09:27 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/]
09:30 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Ping timeout: 268 seconds]
09:34 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev
09:35 -!- cypherr [9d2adebb@157.42.222.187] has joined #bitcoin-core-dev
09:40 -!- pinheadmz [~pinheadmz@68.161.139.178] has quit [Ping timeout: 264 seconds]
09:42 -!- pinheadmz [~pinheadmz@pool-71-105-114-182.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
09:42 -!- rc_423_ [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has quit [Read error: Connection reset by peer]
09:42 -!- rc_423_ [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has joined #bitcoin-core-dev
09:52 < jnewbery> vasild: thanks for writing the test!
09:58 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
10:07 -!- kabaum [~kabaum@h-13-35.A163.priv.bahnhof.se] has joined #bitcoin-core-dev
10:10 -!- xurzua [~xurzua@190.114.53.17] has joined #bitcoin-core-dev
10:20 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
10:20 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
10:28 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 268 seconds]
10:43 -!- rpite [~rpite@47.187.219.52] has quit [Ping timeout: 240 seconds]
10:44 -!- ironhelix [~x@45.132.115.138] has joined #bitcoin-core-dev
10:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:49 < bitcoin-git> [bitcoin] stackman27 opened pull request #21014: test: Run mempool_accept.py even with wallet disabled  (master...diswallet_mempoolaccept) https://github.com/bitcoin/bitcoin/pull/21014
10:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:54 -!- funkyb [~funkyb@195.140.213.38] has quit [Remote host closed the connection]
11:03 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
11:04 -!- norisgOG [~norisgOG@91.193.7.40] has joined #bitcoin-core-dev
11:05 -!- r251d [~r251d@50.121.84.2] has joined #bitcoin-core-dev
11:08 -!- cypherr [9d2adebb@157.42.222.187] has quit [Quit: Connection closed]
11:08 < norisgOG> Hello, when running regtest on docker: I only have to expose 18443?
11:09 -!- r251d [~r251d@50.121.84.2] has quit [Client Quit]
11:10 -!- jespada [~jespada@90.254.242.138] has quit [Ping timeout: 272 seconds]
11:12 -!- jespada [~jespada@90.254.242.138] has joined #bitcoin-core-dev
11:24 < wumpus> depends on what you want to do, for RPC, yes, for P2P you'd have to open 18444 as well
11:25 < norisgOG> wumpus so p2p means when I will run more then one node?
11:25 < norisgOG> so they connect 
11:25 < sipa> norisgOG: you open the P2P port if you want other nodes (run by other people) to connect to you
11:25 < sipa> otherwise you can only connect out
11:26 < norisgOG> sipa ok so when I am planning to build 2 docker regtest nodes I have to expose 18444 for that matter?
11:27 < wumpus> in the particular case of regtest, the other nodes are likely also run by yourself, but yes :)
11:27 < sipa> norisgOG: yes, at least on one of them
11:33 < norisgOG> so when starting a regtest network, when starting all nodes lets say 2 of them how do they that they belong to one regtest network, and not every single bitcoind instance starts its own regtest env?
11:36 < wumpus> regtest nodes won't automatically connect to any other, by default they're on their own, to make a network they can be manually connected using the 'addnode' RPC
11:36 < wumpus> (or -connect on the command line, i guess)
11:38 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 246 seconds]
11:38 < norisgOG> ok so as soon as I connect another node lets say typing the command  (bitcoind -regtest -server -addnode=10.7.0.11:12345) and then when I start bitcoind form 10.7.0.11 it will connect to the regtest of the former?
11:38 < norisgOG> I will try :)
11:38 < sipa> yes just play around
11:42 -!- Kiminuo [~mix@193.9.112.92] has joined #bitcoin-core-dev
11:48 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-dev
12:05 < norisgOG> I followed the build process in doc/unix-build but its missing the configure: error: libdb_cxx headers missing, Bitcoin Core requires this library for wallet functionality
12:05 < norisgOG> but there is no libdb specified in the unix requirements ?
12:06 < norisgOG> it just states something like Ubuntu and Debian have their own libdb-dev and libdb++-dev packages, is there a reason why they are not listed in the above sudo apt install command ?
12:06 < norisgOG> because of the libdb 4.8 problem 
12:07 < sipa> norisgOG: this is getting off topic; there are several answers about this on https://bitcoin.stackexchange.com, and people are probably willing to help on #bitcoin
12:07 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
12:08 < norisgOG> ok thx
12:12 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has quit [Ping timeout: 265 seconds]
12:14 -!- robot-dreams [sid463268@gateway/web/irccloud.com/x-uhgzatjvtwqykwof] has quit [Read error: Connection reset by peer]
12:14 -!- sgeisler [sid356034@gateway/web/irccloud.com/x-vujfkpumblhsmpnn] has quit [Ping timeout: 272 seconds]
12:14 -!- hebasto [sid449604@gateway/web/irccloud.com/x-oxyuptmwgagemmqw] has quit [Ping timeout: 272 seconds]
12:14 -!- robot-dreams [sid463268@gateway/web/irccloud.com/x-ztegzrteixgwybxf] has joined #bitcoin-core-dev
12:14 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-dev
12:14 -!- endogenic [sid145991@gateway/web/irccloud.com/x-ovnidtnzezycjysd] has quit [Ping timeout: 265 seconds]
12:14 -!- norisgOG [~norisgOG@91.193.7.40] has left #bitcoin-core-dev []
12:15 -!- davterra [uid458765@gateway/web/irccloud.com/x-wjfyfunqjdcmbxxo] has quit [Ping timeout: 265 seconds]
12:15 -!- fjahr [sid374480@gateway/web/irccloud.com/x-hnkxvlxetyetlbcs] has quit [Ping timeout: 265 seconds]
12:15 -!- mariorz [sid490@gateway/web/irccloud.com/x-hkxkusnuvirrxqfb] has quit [Ping timeout: 272 seconds]
12:15 -!- hebasto [sid449604@gateway/web/irccloud.com/x-ytveymggjyvonvas] has joined #bitcoin-core-dev
12:15 -!- sgeisler [sid356034@gateway/web/irccloud.com/x-ewftbqbwsshxekwe] has joined #bitcoin-core-dev
12:16 -!- davterra [uid458765@gateway/web/irccloud.com/x-lhpbswxfklwpxape] has joined #bitcoin-core-dev
12:16 -!- endogenic [sid145991@gateway/web/irccloud.com/x-vnrquafaguoomvls] has joined #bitcoin-core-dev
12:17 -!- mariorz [sid490@gateway/web/irccloud.com/x-xezngmztrpwbthjn] has joined #bitcoin-core-dev
12:17 -!- fjahr [sid374480@gateway/web/irccloud.com/x-wkigcsbdradvztsy] has joined #bitcoin-core-dev
12:20 -!- petezz4 [~textual@82-75-26-197.cable.dynamic.v4.ziggo.nl] has joined #bitcoin-core-dev
12:20 -!- petezz4 [~textual@82-75-26-197.cable.dynamic.v4.ziggo.nl] has quit [Client Quit]
12:36 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
12:40 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
12:41 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
12:48 -!- jedi1 [~jedi@185.204.1.185] has joined #bitcoin-core-dev
12:50 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 268 seconds]
12:55 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Remote host closed the connection]
12:56 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev
12:59 -!- Kvaciral [~kvaciral@212.8.251.11] has joined #bitcoin-core-dev
13:01 -!- xurzua [~xurzua@190.114.53.17] has quit [Ping timeout: 246 seconds]
13:03 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
13:16 -!- Kvaciral [~kvaciral@212.8.251.11] has quit [Quit: leaving]
13:18 -!- nesh [68c88e8a@104.200.142.138] has joined #bitcoin-core-dev
13:33 -!- Kiminuo [~mix@193.9.112.92] has quit [Ping timeout: 246 seconds]
13:40 -!- kvaciral [~kvaciral@212.8.251.11] has joined #bitcoin-core-dev
14:03 -!- norisgOG [~norisgOG@91.193.7.40] has joined #bitcoin-core-dev
14:17 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
14:17 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
14:20 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
14:21 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
14:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:24 < bitcoin-git> [bitcoin] dhruv opened pull request #21015: Make all of net_processing (and some of net) use std::chrono types (master...pr-20044) https://github.com/bitcoin/bitcoin/pull/21015
14:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:25 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
14:26 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
14:26 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services]
14:26 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev
14:26 -!- vasild_ is now known as vasild
14:30 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
14:32 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
14:39 -!- LiterallyMe [~Literally@180.red-2-137-54.dynamicip.rima-tde.net] has quit [Quit: LiterallyMe]
14:42 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:48 -!- nesh [68c88e8a@104.200.142.138] has quit [Quit: Connection closed]
14:51 -!- Siamak [60e3704c@pool-96-227-112-76.phlapa.fios.verizon.net] has joined #bitcoin-core-dev
14:56 -!- Siamak [60e3704c@pool-96-227-112-76.phlapa.fios.verizon.net] has quit [Quit: Connection closed]
14:59 -!- niska` [~niska@static.38.6.217.95.clients.your-server.de] has quit [Quit: Leaving]
15:08 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds]
15:08 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
15:08 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
15:10 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
15:11 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
15:15 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
15:16 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
15:16 -!- theStack [~honeybadg@vps1648322.vs.webtropia-customer.com] has quit [Quit: Lost terminal]
15:17 -!- niska [~niska@static.38.6.217.95.clients.your-server.de] has joined #bitcoin-core-dev
15:20 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
15:21 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
15:22 -!- n4b3ts3 [98ced563@152.206.213.99] has joined #bitcoin-core-dev
15:26 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 272 seconds]
15:28 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
15:29 -!- n4b3ts3 [98ced563@152.206.213.99] has quit [Quit: Connection closed]
15:29 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 268 seconds]
15:33 -!- Tokamak_ [~Tokamak@204.141.173.217] has joined #bitcoin-core-dev
15:34 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
15:35 -!- Tokamak [~Tokamak@204.141.173.217] has quit [Ping timeout: 246 seconds]
15:40 -!- rpite [~rpite@47.187.219.52] has joined #bitcoin-core-dev
15:42 -!- sr_gi [~sr_gi@static-6-109-229-77.ipcom.comunitel.net] has quit [Quit: The Lounge - https://thelounge.chat]
15:48 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
15:49 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
15:51 -!- xurzua [~xurzua@190.114.53.17] has joined #bitcoin-core-dev
15:52 -!- Tokamak_ [~Tokamak@204.141.173.217] has quit [Ping timeout: 260 seconds]
15:54 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds]
15:55 -!- Tokamak [~Tokamak@204.141.173.217] has joined #bitcoin-core-dev
16:04 -!- ironhelix [~x@45.132.115.138] has quit [Remote host closed the connection]
16:14 -!- rpite [~rpite@47.187.219.52] has quit [Ping timeout: 256 seconds]
16:29 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
16:30 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
16:31 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
16:35 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
16:36 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
16:40 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
16:49 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
16:50 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
17:04 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 268 seconds]
17:05 -!- xurzua [~xurzua@190.114.53.17] has quit [Quit: xurzua]
17:05 -!- rpite [~rpite@47.187.219.52] has joined #bitcoin-core-dev
17:18 -!- jackk_ [~jackk@205.178.111.134] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
17:23 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]
17:28 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 268 seconds]
17:30 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
17:30 -!- az0re [~az0re@gateway/tor-sasl/az0re] has quit [Remote host closed the connection]
17:32 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev
17:34 -!- oozebrood [~oozebrood@mobile-166-177-184-1.mycingular.net] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
18:01 < fanquake> So here's a new? annoying GitHub behaviour.
18:02 < fanquake> https://github.com/bitcoin-core/gui/pull/189 was merged, with "Fixes: https://github.com/bitcoin-core/gui/issues/101" in the description.
18:02 < fanquake> So #101 got auto-closed when it was merged.
18:02 < gribble> https://github.com/bitcoin/bitcoin/issues/101 | Shy clients by gavinandresen · Pull Request #101 · bitcoin/bitcoin · GitHub
18:02 < fanquake> 101 was then re-opened, because it needed further fixing.
18:02 < fanquake> I fetched upstream, merged it into my bitcoin fork, then pushed that back to GitHub (fanquake/bitcoin).
18:02 < fanquake> Github then re-closed 101...
18:03 < fanquake> I don't think I've ever seen that happen before?
18:03 < fanquake> Does this happen when anyone (with merge permissions, or maybe not even that?) just does the same?
18:03 < fanquake> Seems like something we should have definitely noticed in the past if so
18:03 < sipa> i also think we don't have much experience with such "fixes: <issue on other repo>" tags
18:05 < fanquake> It seems quite annoying if GitHub will close issues in the bitcoin-core/gui repo, when I, or potentially anyone else, push to their own repos (fanquake/bitcoin)
18:06 < sipa> you should try to see if it works for a repo you don't have write access to ;)
18:07 -!- Asbestos_Vapor [~Mercury_V@174-082-158-108.res.spectrum.com] has joined #bitcoin-core-dev
18:08 < fanquake> I will save debugging GitHub for this afternoon
18:10 -!- Mercury_Vapor [~Mercury_V@174-082-158-108.res.spectrum.com] has quit [Ping timeout: 265 seconds]
18:15 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has quit [Remote host closed the connection]
18:16 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
18:19 -!- provoostenator [~quassel@provoostenator.sprovoost.nl] has joined #bitcoin-core-dev
18:22 -!- az0re [~az0re@gateway/tor-sasl/az0re] has joined #bitcoin-core-dev
18:23 -!- jouke_ [~jouke@a80-100-203-151.adsl.xs4all.nl] has quit [Ping timeout: 272 seconds]
18:24 -!- jouke [~jouke@87.215.139.178] has joined #bitcoin-core-dev
18:27 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection]
18:28 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev
18:35 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
18:48 -!- ghosty43 [499e01a2@c-73-158-1-162.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
18:48 -!- ghosty1 [~beau@c-73-158-1-162.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
18:49 -!- ghosty43 [499e01a2@c-73-158-1-162.hsd1.ca.comcast.net] has quit [Client Quit]
19:02 -!- Tokamak [~Tokamak@204.141.173.217] has quit [Ping timeout: 240 seconds]
19:21 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
19:29 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
19:30 -!- sob3rkid [de6ab109@222.106.177.9] has joined #bitcoin-core-dev
19:30 -!- sob3rkid [de6ab109@222.106.177.9] has quit [Client Quit]
19:30 -!- sob3rkid [de6ab109@222.106.177.9] has joined #bitcoin-core-dev
19:53 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]
20:08 -!- Netsplit *.net <-> *.split quits: core-meetingbot`, midnight, vadorovsky, jakesyl
20:08 -!- Netsplit *.net <-> *.split quits: jkczyz, _flow_, wallet42___, ahmed_
20:15 -!- Netsplit over, joins: jkczyz, wallet42___, ahmed_
20:16 -!- oozebrood [~oozebrood@mobile-166-177-184-1.mycingular.net] has joined #bitcoin-core-dev
20:20 -!- robert_spigler [robertspig@gateway/shell/matrix.org/x-lbuupayhytlukzpn] has quit [Ping timeout: 246 seconds]
20:20 -!- Thomas[m]1 [thomaseizi@gateway/shell/matrix.org/x-ttkngbbcpwntnuwl] has quit [Ping timeout: 240 seconds]
20:20 -!- marty[m]1 [jmacawmatr@gateway/shell/matrix.org/x-ykqdjfzepgmimbhx] has quit [Ping timeout: 248 seconds]
20:20 -!- suzziminer[m] [suzziminer@gateway/shell/matrix.org/x-jipjewathhgpnlbn] has quit [Ping timeout: 265 seconds]
20:20 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-edwxmfygcknzvzdm] has quit [Ping timeout: 265 seconds]
20:20 -!- satwhale[m] [satwhalebi@gateway/shell/matrix.org/x-lygpugkdpqucexsc] has quit [Ping timeout: 260 seconds]
20:34 -!- midnight [~midnight@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
20:34 -!- core-meetingbot` [~meetingbo@2a01:4f9:2a:2510::2] has joined #bitcoin-core-dev
20:34 -!- jakesyl [sid56879@gateway/web/irccloud.com/x-cfpxvfoqzzaxcsfp] has joined #bitcoin-core-dev
20:34 -!- _flow_ [~none@salem.informatik.uni-erlangen.de] has joined #bitcoin-core-dev
20:36 -!- Netsplit *.net <-> *.split quits: core-meetingbot`, midnight, jakesyl, _flow_
20:38 -!- Netsplit over, joins: jakesyl, midnight, _flow_, core-meetingbot`
20:46 -!- vadorovsky [vadorovsky@gateway/shell/matrix.org/x-elvkeajlrekmjmrq] has joined #bitcoin-core-dev
20:50 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-bdxdltdflppwpgom] has joined #bitcoin-core-dev
20:53 -!- Thomas[m]1 [thomaseizi@gateway/shell/matrix.org/x-iqvvepmjkxrsybkv] has joined #bitcoin-core-dev
20:54 -!- Netsplit *.net <-> *.split quits: core-meetingbot`, midnight, jakesyl, _flow_
20:55 -!- udecker [~udecker@173.243.88.22] has quit [Quit: udecker]
20:57 -!- nckx [~nckx@tobias.gr] has quit [Ping timeout: 264 seconds]
20:57 -!- Netsplit over, joins: jakesyl, midnight, _flow_, core-meetingbot`
20:57 -!- nckx [~nckx@tobias.gr] has joined #bitcoin-core-dev
21:00 -!- Thomas[m]1 [thomaseizi@gateway/shell/matrix.org/x-iqvvepmjkxrsybkv] has quit [Ping timeout: 240 seconds]
21:01 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-bdxdltdflppwpgom] has quit [Ping timeout: 246 seconds]
21:01 -!- vadorovsky [vadorovsky@gateway/shell/matrix.org/x-elvkeajlrekmjmrq] has quit [Ping timeout: 258 seconds]
21:01 -!- Tokamak [~Tokamak@204.141.172.64] has joined #bitcoin-core-dev
21:13 -!- sob3rkid [de6ab109@222.106.177.9] has quit [Ping timeout: 248 seconds]
21:17 -!- jedi1 [~jedi@185.204.1.185] has quit [Remote host closed the connection]
21:37 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
21:40 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds]
21:42 -!- marty[m]1 [jmacawmatr@gateway/shell/matrix.org/x-hkgwzzrfgkomphwj] has joined #bitcoin-core-dev
21:46 -!- HedgeMage1 [~HedgeMage@178.239.168.171] has joined #bitcoin-core-dev
21:50 -!- suzziminer[m] [suzziminer@gateway/shell/matrix.org/x-wqghnbyhyaehomvr] has joined #bitcoin-core-dev
21:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
21:59 -!- satwhale[m] [satwhalebi@gateway/shell/matrix.org/x-wauwwusxowjibgfi] has joined #bitcoin-core-dev
22:04 -!- icota[m] [icotamatri@gateway/shell/matrix.org/x-yooawcqxgpkjerld] has joined #bitcoin-core-dev
22:07 -!- Thomas[m]1 [thomaseizi@gateway/shell/matrix.org/x-yqvfqlehgfmzpakh] has joined #bitcoin-core-dev
22:11 -!- IGHOR [~quassel@176.121.4.135] has quit [Quit: http://quassel-irc.org ? ??????????? ?????????. ????-??.]
22:13 -!- vadorovsky [vadorovsky@gateway/shell/matrix.org/x-zonrwvsckxwydhqz] has joined #bitcoin-core-dev
22:15 -!- robert_spigler [robertspig@gateway/shell/matrix.org/x-tubwgvbdnkssyqah] has joined #bitcoin-core-dev
22:16 -!- ghosty1 [~beau@c-73-158-1-162.hsd1.ca.comcast.net] has quit [Quit: Leaving.]
22:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
22:22 < bitcoin-git> [gui] Bosch-0 opened pull request #199: Added updated bitcoin PNG / SVG icon (master...bitcoin_icon) https://github.com/bitcoin-core/gui/pull/199
22:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
22:23 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 265 seconds]
22:24 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 264 seconds]
22:28 -!- IGHOR [~quassel@176.121.4.135] has joined #bitcoin-core-dev
22:34 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Ping timeout: 268 seconds]
22:36 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev
22:39 < dhruvm> fanquake: https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
22:39 < dhruvm> (doesn't address the weird behavior with your own fork though)
22:41 -!- Tokamak [~Tokamak@204.141.172.64] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
22:46 -!- sob3rkid [de6ab109@222.106.177.9] has joined #bitcoin-core-dev
22:47 -!- sob3rkid [de6ab109@222.106.177.9] has quit [Client Quit]
22:49 < gwillen> since 2013 apparently: https://github.blog/2013-03-18-closing-issues-across-repositories/
22:50 < gwillen> requires you have permission to push to the mentioned repository
22:51 < sipa> gwillen: way to shatter our dreams about having discovered an amazing oversight in github's security :(
22:57 < gwillen> don't worry, I'm sure you'll find another one pretty soon
23:09 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
23:12 -!- jespada [~jespada@90.254.242.138] has quit [Ping timeout: 265 seconds]
23:14 -!- jespada [~jespada@90.254.242.138] has joined #bitcoin-core-dev
23:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:16 < bitcoin-git> [bitcoin] fanquake opened pull request #21016: refactor: remove boost::thread_group usage (master...remove_boost_threadgroup) https://github.com/bitcoin/bitcoin/pull/21016
23:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:29 -!- Kiminuo [~mix@193.9.112.92] has joined #bitcoin-core-dev
23:50 -!- guest534543 [~mix@193.9.112.92] has joined #bitcoin-core-dev
23:54 -!- Kiminuo [~mix@193.9.112.92] has quit [Ping timeout: 272 seconds]
--- Log closed Wed Jan 27 00:00:27 2021