--- Log opened Tue Feb 02 00:00:33 2021 00:00 -!- real_or_random [~real_or_r@173.249.7.254] has joined #bitcoin-core-dev 00:00 -!- Abel [464d705e@S0106a84e3fe91183.cg.shawcable.net] has quit [Quit: Ping timeout (120 seconds)] 00:06 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 00:13 -!- johnbendi [~mindbende@154.118.35.250] has quit [Remote host closed the connection] 00:13 -!- johnbendi [~mindbende@154.118.35.250] has joined #bitcoin-core-dev 00:17 < jnewbery> wumpus: #21051 fixes an appveyor failure, so if PRs rebase on master they should work again 00:17 < gribble> https://github.com/bitcoin/bitcoin/issues/21051 | Fix -Wmismatched-tags warnings by hebasto · Pull Request #21051 · bitcoin/bitcoin · GitHub 00:32 -!- oozebrood [~oozebrood@2603-6080-b202-d300-752f-1fa0-bc8f-e229.res6.spectrum.com] has quit [Read error: Connection reset by peer] 00:33 -!- oozebrood [~oozebrood@2603-6080-b202-d300-752f-1fa0-bc8f-e229.res6.spectrum.com] has joined #bitcoin-core-dev 00:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:37 < bitcoin-git> [bitcoin] S3RK opened pull request #21063: wallet, rpc: update listdescriptors response format (master...listdescriptors_format) https://github.com/bitcoin/bitcoin/pull/21063 00:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:38 < wumpus> luke-jr: knots linux gitian build is running out of disk space here, i guess due to the added powerpc platforms 00:43 -!- mfi_ [~matthias@p200300df3f0f7d482efa1781436ecaf1.dip0.t-ipconnect.de] has quit [Quit: Leaving] 00:44 -!- mode/#bitcoin-core-dev [+o wumpus] by ChanServ 00:44 -!- mode/#bitcoin-core-dev [-b $j:#bitcoin-global-bans] by wumpus 00:44 <@wumpus> fanquake_: can you talk again now? 00:46 -!- Asbestos_Vapor [~Mercury_V@174.82.158.108] has joined #bitcoin-core-dev 00:48 -!- DougieBot5000 [~DougieBot@unaffiliated/dougiebot5000] has quit [Remote host closed the connection] 00:49 -!- DougieBot5000 [~DougieBot@unaffiliated/dougiebot5000] has joined #bitcoin-core-dev 00:49 -!- copumpkin [~copumpkin@unaffiliated/copumpkin] has quit [Ping timeout: 240 seconds] 00:49 -!- Mercury_Vapor [~Mercury_V@174-082-158-108.res.spectrum.com] has quit [Ping timeout: 240 seconds] 00:52 -!- mode/#bitcoin-core-dev [+b $j:#bitcoin-global-bans] by wumpus 00:52 <@wumpus> restored, that didn't make a difference 00:53 -!- fanquake_ [sid369002@gateway/web/irccloud.com/x-fabjqugvqpcyhsnz] has quit [Changing host] 00:53 -!- fanquake_ [sid369002@unaffiliated/fanquake] has joined #bitcoin-core-dev 00:53 -!- fanquake_ [sid369002@unaffiliated/fanquake] has quit [Changing host] 00:53 -!- fanquake_ [sid369002@gateway/web/irccloud.com/x-fabjqugvqpcyhsnz] has joined #bitcoin-core-dev 00:53 < fanquake_> ping 00:53 <@wumpus> hey ! 00:53 -!- fanquake_ is now known as fanquake 00:54 < sipa> hi 00:54 < fanquake> success 00:55 <@wumpus> PSA: if you find yourself unable to talk here or change your nick, make sure you're identified with nickserv 00:55 -!- mode/#bitcoin-core-dev [-o wumpus] by ChanServ 01:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:04 < bitcoin-git> [bitcoin] fanquake opened pull request #21064: refactor: use std::shared_mutex & remove Boost Thread (master...use_std_shared_mutex) https://github.com/bitcoin/bitcoin/pull/21064 01:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:09 -!- johnbendi [~mindbende@154.118.35.250] has quit [Ping timeout: 265 seconds] 01:10 < wumpus> so boost::preprocessor, boost::thread soon to be gone, boost::filesystem also on the horizon 01:11 < wumpus> boost::date_time is only used in one function ParseISO8601DateTime but this ran into some issues last time as there's no good c++11 replacement #17245 01:11 < gribble> https://github.com/bitcoin/bitcoin/issues/17245 | wallet: Remove Boost from DecodeDumpTime by elichai · Pull Request #17245 · bitcoin/bitcoin · GitHub 01:12 < fanquake> yes. there are two funcs in there that are trivial to replace, and probably should just be done. ParseISO8601DateTime is more difficult. 01:12 < wumpus> boost::signals2 is used in quite a lot of places 01:12 < wumpus> (most notably gui and other interfaces) 01:13 < wumpus> boost::algorithm stuff is trivial to replace when we want to 01:13 < sipa> and boost::multiindex is used by mempool and txrequest, and i don't think a replacement outside boost even exists for that 01:13 < wumpus> that leaves boost::multi_index and boost::process, I think we'll be stuck with those for now 01:14 < sipa> multi_index is header only, which is less of a pain i guess 01:14 < wumpus> right 01:14 < wumpus> multi_index is the only one that offers unique functionality 01:15 < wumpus> we could look into factoring it out into a separate library some day 01:16 < wumpus> but yes header-only is good in this case 01:16 < wumpus> we might reach the point where we don't need to *compile* boost anymore 01:16 < fanquake> also, the boost::system we compile in depends is already a dummy library 01:17 < fanquake> It has one symbol, that is dummy_symbol() iirc 01:17 < wumpus> hah why 01:17 -!- RusAlex [~Chel@unaffiliated/rusalex] has quit [Ping timeout: 240 seconds] 01:17 < sipa> literally, "dummy_symbol" ? 01:17 < fanquake> it's basically been deprecated, think possibly even removed in a later Boost version 01:18 < fanquake> sipa yea 01:18 < fanquake> 0000000000000000 T boost::system::dummy_exported_function() 01:18 < sipa> loi 01:19 < wumpus> so it's just there so that software doesn't need to change their -l.... linker flags 01:19 < aj> sipa: let's replace boost::multi_index with sqlite! 01:19 -!- RusAlex [~Chel@unaffiliated/rusalex] has joined #bitcoin-core-dev 01:19 < wumpus> aj: i had the same cursed thought once but managed to keep it to myself :) 01:21 < wumpus> i'm sure it would be possible but also a very large change to how things are done and it's unclear what the performance impact would be, also it makes sqlite a required dependency which i'm not sure is great 01:22 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 01:35 < wumpus> and leveldb, the database we already have a strong dependency on, doesn't offer indexing functionality 01:39 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Ping timeout: 258 seconds] 01:40 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 01:52 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has quit [Ping timeout: 240 seconds] 01:58 -!- nkuttler [~nkuttler@unaffiliated/nkuttler] has quit [Quit: K-Lined] 02:00 -!- nkuttler [~nkuttler@unaffiliated/nkuttler] has joined #bitcoin-core-dev 02:04 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev 02:05 -!- kexkey [~kexkey@static-198-54-132-140.cust.tzulo.com] has quit [Ping timeout: 258 seconds] 02:10 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has joined #bitcoin-core-dev 02:19 -!- virtu [~virtu@gateway/tor-sasl/virtu] has quit [Ping timeout: 268 seconds] 02:20 -!- jungly [~jungly@host-95-246-194-139.retail.telecomitalia.it] has quit [Ping timeout: 258 seconds] 02:20 -!- virtu [~virtu@gateway/tor-sasl/virtu] has joined #bitcoin-core-dev 02:26 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 02:26 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services] 02:26 -!- vasild_ is now known as vasild 02:34 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 02:35 -!- jespada [~jespada@90.254.242.138] has quit [Quit: Leaving] 02:35 -!- jungly [~jungly@host-95-246-194-139.retail.telecomitalia.it] has joined #bitcoin-core-dev 02:37 < aj> wumpus: might create encoding issues and stuff too, since each field needs to be sql'ed not just an entry in a struct 02:42 < real_or_random> https://github.com/bitcoin-core/secp256k1/pull/889 cirrus ci doesn't build this PR. I suspect because the author doesn't have write permission. 02:42 < real_or_random> but "Require approval for builds from users without write permissions" is not enabled in cirrus settings?! 02:50 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 264 seconds] 02:51 -!- jonatack [jon@gateway/vpn/airvpn/jonatack] has quit [Ping timeout: 264 seconds] 02:52 -!- jonatack [~jon@88.124.242.136] has joined #bitcoin-core-dev 02:52 -!- livestradamus [~quassel@unaffiliated/livestradamus] has quit [Quit: No Ping reply in 180 seconds.] 02:53 -!- livestradamus [~quassel@unaffiliated/livestradamus] has joined #bitcoin-core-dev 02:53 -!- rpite [~rpite@47.187.219.52] has joined #bitcoin-core-dev 02:57 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 03:03 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Remote host closed the connection] 03:03 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 03:04 -!- rpite is now known as test 03:05 -!- test is now known as Guest95959 03:06 -!- Guest95959 is now known as AAAAAAAAAAAAAAAA 03:06 -!- AAAAAAAAAAAAAAAA is now known as _ 03:07 -!- _ is now known as ________________ 03:07 -!- ________________ is now known as { 03:07 -!- { is now known as | 03:07 -!- | is now known as _|_|_|_|_|_|_|__ 03:09 -!- _|_|_|_|_|_|_|__ is now known as rpite 03:11 -!- dlb76_ [~dlb76@88.99.80.63] has quit [Ping timeout: 272 seconds] 03:18 -!- Orlo89Wiegand [~Orlo89Wie@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev 03:20 -!- jungly [~jungly@host-95-246-194-139.retail.telecomitalia.it] has quit [Ping timeout: 265 seconds] 03:22 -!- Kiminuo [~Kiminuo@185.216.35.116] has joined #bitcoin-core-dev 03:34 < wumpus> aj: it's something to be careful with, though sqlite explicitly supports binary data in parametrized queries iirc 03:34 < wumpus> (clightning makes fairly heavy use of this) 03:35 < wumpus> real_or_random: hmm let's see 03:36 < wumpus> I don't think the author needs write permission normally for cirrus builds we have these enabled for all PRs on bitcoin 03:37 -!- Ezis [Ezis@gateway/vpn/protonvpn/ezis] has quit [Quit: Leaving] 03:42 -!- jespada [~jespada@90.254.242.138] has joined #bitcoin-core-dev 03:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:45 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/f72d80b07af8...1e69800d5e60 03:45 < bitcoin-git> bitcoin/master 12f5028 Hennadii Stepanov: refactor: Move STRINGIZE macro to macros.h 03:45 < bitcoin-git> bitcoin/master e99db77 Hennadii Stepanov: Drop boost/preprocessor dependencies 03:45 < bitcoin-git> bitcoin/master 1e69800 Wladimir J. van der Laan: Merge #21059: Drop boost/preprocessor dependencies 03:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:46 < bitcoin-git> [bitcoin] laanwj merged pull request #21059: Drop boost/preprocessor dependencies (master...210201-macro) https://github.com/bitcoin/bitcoin/pull/21059 03:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:55 < wumpus> from the Finnish translation: "Avaa %1 -debug-loki tämänhetkisestä data-hakemistosta. Tämä voi viedä muutaman sekunnin suurille lokitiedostoille." .... i don't think -debug-loki is quite right :) 03:57 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev 04:00 < wumpus> or maybe it is, it's not a translation of an option but of "Open the %1 debug log file from the current data directory. This can take a few seconds for large log files." 04:01 < setpill> loki is Finnish for log 04:02 < wumpus> setpill: right, i somehow didn't expect that, but makes sense then! 04:10 -!- murr4y [ali@38.95.231.35.bc.googleusercontent.com] has quit [Quit: WeeChat 3.0] 04:11 -!- Orlo89Wiegand [~Orlo89Wie@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 265 seconds] 04:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:12 < bitcoin-git> [bitcoin] MarcoFalke pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/1e69800d5e60...384e090f9345 04:12 < bitcoin-git> bitcoin/master dbf779d Troy Giorshev: Clean PushMessage and ProcessMessages 04:12 < bitcoin-git> bitcoin/master f2a77ff Troy Giorshev: Add CaptureMessage 04:12 < bitcoin-git> bitcoin/master 4d1a582 Troy Giorshev: Call CaptureMessage at appropriate locations 04:12 < Kiminuo> Hi, I was thinking that it would be nice to replace: https://github.com/bitcoin/bitcoin/pull/20744/files#diff-2bd57d7fbec4bb262834d155c304ebe15d26f73fea87c75ff273df3529a15510R1819 with a function. So I did https://github.com/bitcoin/bitcoin/pull/21052/files#diff-56faa53f40da7bfc47077d7c93254d0d1f7eba69a3c5d88f67be9505f334178eR42 but this is problematic because it introduces a new circular dependency: fs -> random -> logging -> fs where I add 04:12 < Kiminuo> the edge "fs -> random". 04:12 < Kiminuo> So I think this approach is not good. Do you agree? 04:12 < Kiminuo> (Unless there is a better place to put "GetUniquePath" but it seems to me that fsbridge is ideal for this.) 04:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:13 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #19509: Per-Peer Message Capture (master...message-dump) https://github.com/bitcoin/bitcoin/pull/19509 04:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:13 < Kiminuo> There are many different possible solutions for the "GetUniquePath" function implementation that I can think of:1 04:13 < Kiminuo> 1. One can leave it as it is in https://github.com/bitcoin/bitcoin/pull/20744/files#diff-2bd57d7fbec4bb262834d155c304ebe15d26f73fea87c75ff273df3529a15510R1819. I don't like this too much though. Hence the PR. 04:13 < Kiminuo> 2. One can probably use "#include " to avoid using "#include random.h". That sounds doable but it sounds like too much maintenance burden for such primitive function. 04:13 < Kiminuo> 3. Or more simply, use rand() from with some seed. 04:13 < Kiminuo> 4. Maybe some simple transformation based on current time (like hashing?) would suffice here. 04:13 < Kiminuo> wumpus, ^ do you possibly have an opinion on this? 04:28 < real_or_random> wumpus: oh the PR is simply not rebased on the newest master and so it does not have the .cirrus.yml... 04:29 < wumpus> Kiminuo: util/getuniquepath.cpp :-) 04:30 < wumpus> Kiminuo: imo, the best way to solve circular dependencies is to just factor it out to a new module 04:31 < wumpus> Kiminuo: I definitely prefer sticking with our own random generator and not libc's 04:31 < wumpus> real_or_random: whoops 04:31 < Kiminuo> wumpus, yeah, util/getuniquepath.cpp can be done. But is it preferable? 04:32 < Kiminuo> I mean from some grand scheme of things. 04:32 < real_or_random> wumpus: I wonder if it's possible to configure Cirrus to run on the merge result instead of the PR branch. There's a "Config resolution strategy" setting but it's not documented 04:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:44 < bitcoin-git> [bitcoin] fanquake opened pull request #21065: build: make macOS HOST in download-osx generic (master...correct_host_download_osx) https://github.com/bitcoin/bitcoin/pull/21065 04:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:56 -!- promag [~promag@188.250.84.129] has quit [Remote host closed the connection] 04:57 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev 04:57 -!- ovovo [~ovovo@91.193.4.10] has joined #bitcoin-core-dev 04:57 -!- ovovo [~ovovo@91.193.4.10] has quit [Changing host] 04:57 -!- ovovo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 04:58 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 258 seconds] 04:59 < wumpus> Kiminuo: to me it is 05:00 < Kiminuo> wumpus, ok. Interestingly, I though you would not like this solution the most.. so I skipped it in my list. :-D 05:01 -!- jungly [~jungly@host-95-246-194-139.retail.telecomitalia.it] has joined #bitcoin-core-dev 05:01 -!- promag [~promag@188.250.84.129] has quit [Ping timeout: 240 seconds] 05:02 < wumpus> I mean, small compilation units allow for the most specific dependency management (and speed up build time too) 05:02 < wumpus> also the unique path code is only used in the tests 05:02 < wumpus> thinking of it, you could even put it inside the test-specific utils under src/tests 05:03 < Kiminuo> Yeah. When somebody needs it outside of tests, it can be refactored. 05:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:05 < bitcoin-git> [bitcoin] hebasto opened pull request #21066: build: Drop boost-system dependency (master...210202-system) https://github.com/bitcoin/bitcoin/pull/21066 05:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:36 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev 05:36 -!- webHunter [552ae8fa@host-85-42-232-250.business.telecomitalia.it] has joined #bitcoin-core-dev 05:40 -!- promag [~promag@188.250.84.129] has quit [Ping timeout: 256 seconds] 05:41 -!- superfly1 [~superfly@185.163.110.108] has joined #bitcoin-core-dev 05:41 -!- belcher_ is now known as belcher 05:42 -!- virtu [~virtu@gateway/tor-sasl/virtu] has quit [Ping timeout: 268 seconds] 05:42 -!- Kiminuo [~Kiminuo@185.216.35.116] has quit [Ping timeout: 240 seconds] 05:43 -!- Kiminuo [~Kiminuo@185.216.35.116] has joined #bitcoin-core-dev 05:43 -!- virtu [~virtu@gateway/tor-sasl/virtu] has joined #bitcoin-core-dev 05:45 -!- murr4y [ali@38.95.231.35.bc.googleusercontent.com] has joined #bitcoin-core-dev 05:48 -!- Kiminuo [~Kiminuo@185.216.35.116] has quit [Ping timeout: 258 seconds] 05:53 -!- Kiminuo [~Kiminuo@185.216.35.116] has joined #bitcoin-core-dev 05:54 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev 05:59 -!- webHunter [552ae8fa@host-85-42-232-250.business.telecomitalia.it] has quit [Quit: Ping timeout (120 seconds)] 06:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:07 < bitcoin-git> [bitcoin] jonatack closed pull request #20877: netinfo: user help and argument parsing improvements (master...netinfo-help-follow-ups) https://github.com/bitcoin/bitcoin/pull/20877 06:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:08 < bitcoin-git> [bitcoin] jonatack reopened pull request #20877: netinfo: user help and argument parsing improvements (master...netinfo-help-follow-ups) https://github.com/bitcoin/bitcoin/pull/20877 06:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:26 -!- webHunter [552ae8fa@host-85-42-232-250.business.telecomitalia.it] has joined #bitcoin-core-dev 06:33 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 06:41 -!- webHunter [552ae8fa@host-85-42-232-250.business.telecomitalia.it] has quit [Quit: Ping timeout (120 seconds)] 06:47 -!- Kimi [~Kiminuo@185.216.35.116] has joined #bitcoin-core-dev 06:50 -!- Kimi_ [~Kiminuo@217.138.199.12] has joined #bitcoin-core-dev 06:50 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 06:51 -!- Kiminuo [~Kiminuo@185.216.35.116] has quit [Ping timeout: 272 seconds] 06:53 -!- Kimi [~Kiminuo@185.216.35.116] has quit [Ping timeout: 246 seconds] 06:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:53 < bitcoin-git> [bitcoin] x4e opened pull request #21067: Fix whitepaper link in ReadMe (master...fix-whitepaper-link) https://github.com/bitcoin/bitcoin/pull/21067 06:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:54 < bitcoin-git> [bitcoin] fanquake closed pull request #21067: Fix whitepaper link in ReadMe (master...fix-whitepaper-link) https://github.com/bitcoin/bitcoin/pull/21067 06:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:59 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Read error: Connection reset by peer] 07:03 -!- Kimi_ [~Kiminuo@217.138.199.12] has quit [Ping timeout: 246 seconds] 07:05 -!- rpite [~rpite@47.187.219.52] has quit [Quit: rpite] 07:08 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev 07:10 -!- Tokamak [~Tokamak@204.141.173.217] has joined #bitcoin-core-dev 07:26 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Remote host closed the connection] 07:26 -!- copumpkin [~copumpkin@unaffiliated/copumpkin] has joined #bitcoin-core-dev 07:27 -!- copumpkin [~copumpkin@unaffiliated/copumpkin] has quit [Client Quit] 07:28 -!- copumpkin [~copumpkin@unaffiliated/copumpkin] has joined #bitcoin-core-dev 07:28 -!- Tokamak [~Tokamak@204.141.173.217] has left #bitcoin-core-dev ["Textual IRC Client: www.textualapp.com"] 07:29 < luke-jr> wumpus: in my experience, because gitian copies all the caches in even if not used 07:30 < luke-jr> wumpus: if you use KVM gitian, https://github.com/devrandom/gitian-builder/pull/172 07:40 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev 07:46 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 07:49 -!- rpite [~rpite@47.187.219.52] has joined #bitcoin-core-dev 07:49 -!- rpite [~rpite@47.187.219.52] has quit [Client Quit] 07:58 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Remote host closed the connection] 07:59 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 08:07 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection] 08:08 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 08:18 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Remote host closed the connection] 08:18 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 08:19 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Client Quit] 08:19 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 08:21 -!- jespada [~jespada@90.254.242.138] has quit [Ping timeout: 240 seconds] 08:24 -!- jespada [~jespada@90.254.242.138] has joined #bitcoin-core-dev 08:31 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Remote host closed the connection] 08:31 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 08:35 -!- rpite [~rpite@47.187.219.52] has joined #bitcoin-core-dev 08:40 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 09:04 -!- cfields [~cfields@unaffiliated/cfields] has quit [Ping timeout: 260 seconds] 09:08 < luke-jr> something wrong with master 09:08 < luke-jr> /home/dev/Bitcoin/bitcoin/wt1/src/pubkey.cpp:180: undefined reference to `secp256k1_xonly_pubkey_parse' 09:09 < luke-jr> build system failing to detect a need to rebuild something? :/ 09:09 < luke-jr> (this working tree location last used to build 0.19.0.1 for previous-releases testing) 09:10 -!- sas87 [31e0f487@135.244.224.49.dyn.cust.vf.net.nz] has joined #bitcoin-core-dev 09:10 < luke-jr> autogen didn't help; explicit configure did 09:11 -!- cfields [~cfields@unaffiliated/cfields] has joined #bitcoin-core-dev 09:12 -!- sas87 [31e0f487@135.244.224.49.dyn.cust.vf.net.nz] has quit [Client Quit] 09:16 -!- sas90 [31e0f487@135.244.224.49.dyn.cust.vf.net.nz] has joined #bitcoin-core-dev 09:17 -!- sas90 [31e0f487@135.244.224.49.dyn.cust.vf.net.nz] has quit [Client Quit] 09:18 < setpill> Trying to get guix building working in docker... Running into this error https://gist.github.com/setpill/3f7fbb7a0767f9d6939db5c1373588e6 09:19 < setpill> Seems to always happen at the same point 09:24 < setpill> Some context; running docker with --privileged, image based on https://github.com/fanquake/core-review/blob/master/guix/Dockerfile with only change being to add macOS SDK stuff 09:26 -!- rpite [~rpite@47.187.219.52] has quit [Quit: rpite] 09:27 < setpill> Is this a known error that is caused by me somehow having overlooked a crucial instruction? 09:31 -!- shaunsun [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has joined #bitcoin-core-dev 09:38 -!- tonysanak [d847dcf5@216-71-220-245.dyn.novuscom.net] has joined #bitcoin-core-dev 09:41 -!- ishaqm [~ishaqm@host-78-148-172-229.as13285.net] has joined #bitcoin-core-dev 09:44 < ishaqm> for a simulation, i want to modify regtest so that blocks require mining. Would hard-coding a higher difficulty in CRegTestParams work? 09:46 -!- bitlearn [b1121d3f@177.18.29.63.dynamic.adsl.gvt.net.br] has joined #bitcoin-core-dev 10:09 -!- virtu [~virtu@gateway/tor-sasl/virtu] has quit [Ping timeout: 268 seconds] 10:09 -!- virtu [~virtu@gateway/tor-sasl/virtu] has joined #bitcoin-core-dev 10:10 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 10:15 -!- stijnbtc [~stijnbtc@77-165-254-59.fixed.kpn.net] has joined #bitcoin-core-dev 10:17 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 268 seconds] 10:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:17 < bitcoin-git> [bitcoin] hebasto closed pull request #21066: build: Drop boost-system dependency (master...210202-system) https://github.com/bitcoin/bitcoin/pull/21066 10:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:17 -!- kexkey [~kexkey@static-198-54-132-140.cust.tzulo.com] has joined #bitcoin-core-dev 10:20 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 10:22 < luke-jr> reminder: 38 minutes until ##Taproot-activation meeting 10:24 -!- stijnbtc [~stijnbtc@77-165-254-59.fixed.kpn.net] has quit [Quit: Powered by WinIRC] 10:33 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev 10:33 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 10:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:34 < bitcoin-git> [bitcoin] practicalswift opened pull request #21068: Add GitHub Codespaces integration to allow for easy onboarding of future generations of contributors (master...github-codespaces) https://github.com/bitcoin/bitcoin/pull/21068 10:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:34 -!- bitlearn [b1121d3f@177.18.29.63.dynamic.adsl.gvt.net.br] has quit [Quit: Connection closed] 10:41 < miketwenty1> Between Noon and 5 pm EST on March 30th (Tuesday).. There will be a remote speaking opportunity for a bitcoin core developer at a "Open Source 101" event. The idea would be someone who can explain about how the project is maintained, how people can contribute, why it's important, etc. Less about the bitcoin tech and more about the project and contribution to the project. I imagine history would also be a very interesting piece 10:41 < miketwenty1> of this. If you're interested please email me mtidwell021@gmail.com and I'll give you more details. 10:41 < miketwenty1> I imagine maybe achow101, sipa, jnewbery, or someone else, would know a good person for this?, or may be interested yourselves. 10:43 < luke-jr> wumpus: I don't know of a single open source software package that bundles fonts… 10:46 -!- CodeShark____ [sid126576@gateway/web/irccloud.com/x-lykhywlaecnkcjgo] has joined #bitcoin-core-dev 10:47 -!- proofofkeags [~proofofke@97-118-232-73.hlrn.qwest.net] has joined #bitcoin-core-dev 10:52 -!- StijnBtc [~StijnBtc@77-165-254-59.fixed.kpn.net] has joined #bitcoin-core-dev 10:52 -!- schulzemic [~ada@193.27.14.104] has joined #bitcoin-core-dev 10:53 -!- tonysanak [d847dcf5@216-71-220-245.dyn.novuscom.net] has quit [Quit: Ping timeout (120 seconds)] 10:53 -!- tonysanak [d847dcf5@216-71-220-245.dyn.novuscom.net] has joined #bitcoin-core-dev 10:54 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 10:56 -!- rpite [~rpite@47.187.219.52] has joined #bitcoin-core-dev 11:00 -!- Stijnbtc_ [~StijnBtc@77-165-254-59.fixed.kpn.net] has joined #bitcoin-core-dev 11:00 -!- ajonas__ [sid385278@gateway/web/irccloud.com/x-hdjjphhkyxisxfqq] has quit [] 11:02 -!- ajonas [sid385278@gateway/web/irccloud.com/x-ywrjihwxueudgghe] has joined #bitcoin-core-dev 11:02 < wumpus> luke-jr: no idea, but I don't really see a problem with it, as there's fonts available with a free enough license 11:02 -!- krakatoa69 [49cb5a1f@c-73-203-90-31.hsd1.co.comcast.net] has joined #bitcoin-core-dev 11:03 < wumpus> this is similar to static linking imo -- be as independent as possible from what happens to be installed on the system 11:03 < luke-jr> wumpus: except most of our static linking isn't detrimental to user experience 11:03 < luke-jr> and fonts are fairly stable in compariosn 11:03 < wumpus> assuming that fonts are installed corrently when they are not (or somehow not locatable) can also be detrimental to the user experience 11:03 -!- wangchun [sid444603@gateway/web/irccloud.com/x-jhisperlklrsryzq] has joined #bitcoin-core-dev 11:04 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 11:04 < wumpus> not sure about that, we've had quite some of these reported issues throughout the history of the project, especially with monospace fonts 11:04 -!- r251d [~r251d@50.121.84.2] has joined #bitcoin-core-dev 11:04 < wumpus> always had very ugly hacks to work around it, i think shipping a font is realtively clean 11:05 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #bitcoin-core-dev 11:05 < wumpus> for building from source i'm sure we could add an option to not embed them 11:06 < wumpus> this is only about the distributed binaries 11:06 -!- yunier2002 [~yunier200@c-73-85-126-91.hsd1.fl.comcast.net] has joined #bitcoin-core-dev 11:07 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 268 seconds] 11:08 -!- yunier2002 [~yunier200@c-73-85-126-91.hsd1.fl.comcast.net] has quit [Remote host closed the connection] 11:08 -!- yunier2002 [~yunier200@c-73-85-126-91.hsd1.fl.comcast.net] has joined #bitcoin-core-dev 11:08 -!- StijnBtc [~StijnBtc@77-165-254-59.fixed.kpn.net] has quit [Quit: Leaving] 11:08 -!- Stijnbtc_ [~StijnBtc@77-165-254-59.fixed.kpn.net] has quit [Quit: Leaving] 11:09 -!- yunier2002 [~yunier200@c-73-85-126-91.hsd1.fl.comcast.net] has quit [Remote host closed the connection] 11:09 -!- yunier2002 [~yunier200@c-73-85-126-91.hsd1.fl.comcast.net] has joined #bitcoin-core-dev 11:12 < sipa> wumpus: you know we do have -chain=X, right? ;) 11:16 -!- jungly [~jungly@host-95-246-194-139.retail.telecomitalia.it] has quit [Ping timeout: 265 seconds] 11:18 < wumpus> sipa: we do?!? 11:18 < wumpus> no, I was not aware that ever got merged 11:20 < wumpus> seems absolutely superior to "radio button" options like -regtest -testnet 11:21 < wumpus> though it's a bit weird to have both 11:21 < aj> wumpus: geez, read the code sometime! 11:22 < wumpus> aj: hehe 11:23 < aj> wumpus: (i was going to quote the bit where it checks you only specify one of -chain, -signet etc, but now i can't find it, so apparently i should read the code sometime too) 11:24 -!- promag [~promag@188.250.84.129] has quit [Remote host closed the connection] 11:24 < sipa> git grep -- '"-chain"' 11:24 < wumpus> aj: that's the code that #21039 changes 11:24 < gribble> https://github.com/bitcoin/bitcoin/issues/21039 | refactor: dont throw in GetChainName() by fanquake · Pull Request #21039 · bitcoin/bitcoin · GitHub 11:28 < jonatack> i could see why software clients might use -chain= but cli examples seem to always be -regtest, -testnet, -signet iirc 11:28 < jonatack> seems handier for manual cli use 11:29 < jonatack> (my interpretation of why having both can make sense) 11:30 < aj> sipa: no, everyone should know all the code by heart, without having to grep, clearly 11:32 -!- NoDeal [aef6c776@118.sub-174-246-199.myvzw.com] has joined #bitcoin-core-dev 11:36 -!- tonysanak82 [d847dcf5@216-71-220-245.dyn.novuscom.net] has joined #bitcoin-core-dev 11:36 < wumpus> yes it's clearly something way too many people are used to by now 11:38 < aj> less typing when invoking "bitcoin-cli -testnet .." etc is a win 11:38 < sipa> yeah, and -testnet -regtest also exist far longer thaj -chain 11:39 < wumpus> aj: for the client it's absolutely a good thing 11:39 -!- tonysanak [d847dcf5@216-71-220-245.dyn.novuscom.net] has quit [Ping timeout: 248 seconds] 11:40 < wumpus> I agree, it's better seen as '-testnet is a shorthand for -chain=test` 11:40 < wumpus> though that's not how the argument parsing code works at the moment 11:40 < jonatack> yes 11:41 < wumpus> I don't think it even protects aginst multiple -chain=X like it does against -testnet -regtest ? 11:41 < sipa> indeed 11:43 < aj> should have the same protection as other options that aren't meant to be vectors? 11:45 -!- Kiminuo [~Kiminuo@217.138.199.12] has joined #bitcoin-core-dev 11:48 < wumpus> "src/bitcoin-cli -chain=test -chain=main getblockchaininfo" doesn't raise any error here, it's interpreted as just -chain=main 11:49 < wumpus> which is fine, it's the same behavior as for other duplicated options, i just meant that the explicit protection that the shorthand network arguments have is different 11:50 < wumpus> it's slightly inconsistent but also not big deal 12:02 -!- prayank [~andr0irc@2402:8100:206c:5226:348b:b4b2:a2f5:ad48] has joined #bitcoin-core-dev 12:09 -!- rpite [~rpite@47.187.219.52] has quit [Ping timeout: 258 seconds] 12:11 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:14 -!- rpite [~rpite@47.187.219.52] has joined #bitcoin-core-dev 12:19 -!- NoDeal [aef6c776@118.sub-174-246-199.myvzw.com] has quit [Quit: Connection closed] 12:23 -!- someone235 [uid419897@gateway/web/irccloud.com/x-dejxuzdpsjnwmdly] has joined #bitcoin-core-dev 12:33 -!- krakatoa69 [49cb5a1f@c-73-203-90-31.hsd1.co.comcast.net] has quit [Ping timeout: 248 seconds] 12:33 -!- jungly [~jungly@host-95-246-194-139.retail.telecomitalia.it] has joined #bitcoin-core-dev 12:34 -!- NoDeal [aec5028d@141.sub-174-197-2.myvzw.com] has joined #bitcoin-core-dev 12:38 -!- r251d [~r251d@50.121.84.2] has quit [Quit: r251d] 12:40 -!- krakatoa69 [49cb5a1f@c-73-203-90-31.hsd1.co.comcast.net] has joined #bitcoin-core-dev 12:46 -!- CodeShark____ [sid126576@gateway/web/irccloud.com/x-lykhywlaecnkcjgo] has quit [] 12:52 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 12:52 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 13:00 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev 13:00 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Remote host closed the connection] 13:00 -!- krakatoa69 [49cb5a1f@c-73-203-90-31.hsd1.co.comcast.net] has quit [Quit: Connection closed] 13:01 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 13:03 -!- NoDeal [aec5028d@141.sub-174-197-2.myvzw.com] has quit [Quit: Ping timeout (120 seconds)] 13:29 -!- prayank [~andr0irc@2402:8100:206c:5226:348b:b4b2:a2f5:ad48] has quit [Ping timeout: 258 seconds] 13:29 < wumpus> okayy, restarting the knots gitian linux build for the third time, hopefully i made the disk image large enough this time... 13:30 < wumpus> to be honest i'm not actually sure why gitian bothers with a disk image at all for lxc, it's a container, it could just use a directory of the host, but anyhow 13:32 < sipa> i suspect for historic reasons 13:32 < wumpus> make the base image a .tar.gz and unzip it, voila, new target 13:32 < sipa> lxc was added later, i think 13:33 < wumpus> right i wouldn't be surprised if that's the entire explanation 13:36 -!- Kimi [~Kiminuo@109.183.7.106] has joined #bitcoin-core-dev 13:39 -!- tonysanak82 [d847dcf5@216-71-220-245.dyn.novuscom.net] has quit [Ping timeout: 248 seconds] 13:40 -!- Kiminuo [~Kiminuo@217.138.199.12] has quit [Ping timeout: 265 seconds] 13:44 -!- shaunsun [shaunsun@gateway/vpn/privateinternetaccess/shaunsun] has quit [Quit: Leaving] 14:01 -!- webHunter [92f1b4db@146-241-180-219.dyn.eolo.it] has joined #bitcoin-core-dev 14:02 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 268 seconds] 14:09 -!- webHunter [92f1b4db@146-241-180-219.dyn.eolo.it] has quit [Ping timeout: 248 seconds] 14:18 -!- schulzemic [~ada@193.27.14.104] has quit [Quit: Konversation terminated!] 14:23 -!- superfly1 [~superfly@185.163.110.108] has quit [Remote host closed the connection] 14:27 -!- vasild_ [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 14:27 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Disconnected by services] 14:27 -!- vasild_ is now known as vasild 14:28 < fanquake> setpill: if you remove "https://guix.carldong.io" from https://github.com/fanquake/core-review/blob/master/guix/Dockerfile#L44 and rebuild the docker image, it should work. 14:39 -!- Guest62723 [~ds@139.28.218.148] has joined #bitcoin-core-dev 14:45 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 14:52 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 268 seconds] 14:52 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Remote host closed the connection] 14:55 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 14:56 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has quit [Read error: Connection reset by peer] 14:58 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 240 seconds] 14:58 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 14:59 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Remote host closed the connection] 15:03 -!- lukedashjr is now known as luke-jr 15:04 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 15:04 -!- dr-bonez [~drbonez@2601:280:4b00:96b0:a3fa:7b45:700d:a57a] has joined #bitcoin-core-dev 15:06 -!- cguida [bbbecdab@fixed-187-190-205-171.totalplay.net] has joined #bitcoin-core-dev 15:07 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Remote host closed the connection] 15:13 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev 15:13 -!- Kimi [~Kiminuo@109.183.7.106] has quit [Ping timeout: 246 seconds] 15:23 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 15:28 -!- proofofkeags [~proofofke@97-118-232-73.hlrn.qwest.net] has quit [Remote host closed the connection] 15:28 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 268 seconds] 15:31 -!- jungly [~jungly@host-95-246-194-139.retail.telecomitalia.it] has quit [Ping timeout: 240 seconds] 15:32 -!- cguida [bbbecdab@fixed-187-190-205-171.totalplay.net] has quit [Quit: Ping timeout (120 seconds)] 15:36 -!- cguida [bbbecdab@fixed-187-190-205-171.totalplay.net] has joined #bitcoin-core-dev 15:37 -!- rpite [~rpite@47.187.219.52] has quit [Ping timeout: 256 seconds] 15:38 -!- kexkey [~kexkey@static-198-54-132-140.cust.tzulo.com] has quit [Ping timeout: 258 seconds] 15:42 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 15:42 -!- ishaqm [~ishaqm@host-78-148-172-229.as13285.net] has quit [Remote host closed the connection] 15:46 -!- StopAndDecrypt_ [~StopAndDe@67.213.221.3] has joined #bitcoin-core-dev 15:46 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Remote host closed the connection] 15:47 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [Ping timeout: 246 seconds] 15:55 -!- johnbendi [~mindbende@154.118.4.227] has joined #bitcoin-core-dev 15:59 -!- johnbendi [~mindbende@154.118.4.227] has quit [Ping timeout: 258 seconds] 16:00 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 16:04 -!- btc_lsd [annalee@kosher.marriageiguana.com] has joined #bitcoin-core-dev 16:06 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 268 seconds] 16:06 -!- comboy [~quassel@tesuji.pl] has joined #bitcoin-core-dev 16:11 -!- Netsplit *.net <-> *.split quits: comboy_, btc_thc 16:11 -!- Netsplit *.net <-> *.split quits: cguida 16:14 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 268 seconds] 16:17 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 16:20 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Remote host closed the connection] 16:34 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Remote host closed the connection] 16:34 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev 16:35 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 16:36 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 16:37 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 258 seconds] 16:40 -!- lukedashjr is now known as luke-jr 16:41 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 268 seconds] 16:44 -!- promag [~promag@188.250.84.129] has quit [Remote host closed the connection] 16:53 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 16:53 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 240 seconds] 16:53 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 16:54 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev 16:57 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Remote host closed the connection] 16:57 -!- lukedashjr is now known as luke-jr 17:01 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [] 17:01 -!- rpite [~rpite@47.187.219.52] has joined #bitcoin-core-dev 17:12 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 17:18 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 268 seconds] 17:19 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 17:26 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Read error: Connection reset by peer] 17:26 -!- TheRec_ [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 17:29 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 17:33 -!- promag [~promag@188.250.84.129] has quit [Remote host closed the connection] 17:34 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev 17:36 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 268 seconds] 17:38 -!- promag [~promag@188.250.84.129] has quit [Ping timeout: 240 seconds] 17:49 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 17:51 < ghost43> I've just upgraded to 0.21 and it seems to have broken a downstream app that uses the HTTP JSON-RPC API. It used to work with 0.20.1 but with 0.21 I am now getting HTTP 403 Forbidden. 17:51 < ghost43> specifically, this used to work: 17:51 < ghost43> $ curl --data-binary '{"jsonrpc":"1.0","id":"curltext","method":"getblockchaininfo","params":[]}' -H 'content-type:text/plain;' http://user:pass@172.19.1.10:8332/ 17:52 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Remote host closed the connection] 17:52 < ghost43> I have another bitcoind that still runs 0.20.1, and for that one the curl command gets the expected response, while it gets status 403 for 0.21 17:53 < ghost43> any idea? 17:53 < sipa> WFM 17:53 < sipa> i suspect there is an issue with your authentication 17:53 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 17:54 < luke-jr> ghost43: are you using rpcuser/rpcpassword or rpcauth? 17:57 < ghost43> luke-jr: my bitcoin.conf has a line "rpcauth=..." 17:57 < ghost43> and the downstream client is connecting through HTTP accessing an URL such as http://user:pass@172.19.1.10:8332/ 17:58 < luke-jr> does it work from localhost? 17:58 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 18:00 -!- openoms [~quassel@cpc115064-stok20-2-0-cust91.1-4.cable.virginm.net] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 18:01 < ghost43> luke-jr: oh hmm yes it does 18:01 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 258 seconds] 18:01 < luke-jr> what are your rpcbind/rpcallowip settings? 18:02 -!- openoms [~quassel@91.132.136.76] has joined #bitcoin-core-dev 18:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:03 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/384e090f9345...ea96e17e1f2c 18:03 < bitcoin-git> bitcoin/master 572fd0f wodry: doc: More precise -debug and -debugexclude doc 18:03 < bitcoin-git> bitcoin/master ea96e17 fanquake: Merge #21060: doc: More precise -debug and -debugexclude doc 18:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:04 < bitcoin-git> [bitcoin] fanquake merged pull request #21060: doc: More precise -debug and -debugexclude doc (master...patch-1) https://github.com/bitcoin/bitcoin/pull/21060 18:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:07 < sanket1729> Where libsecp256k1 library is built in bitcoin core build process? I can't find it in src/.libs 18:08 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 18:09 < sanket1729> nvm, found it. It is in src/secp256k1/.libs 18:09 < fanquake> it will be in src/secp256k1/.libs 18:09 < ghost43> luke-jr: I have "rpcbind=0.0.0.0:8332" in bitcoin.conf, and passing "-rpcallowip=::/0" on CLI. it is all part of a non-trivial docker setup; so it is not actually exposed to the internet 18:13 -!- madara_uchicoin [68b1c364@gateway/web/cgi-irc/kiwiirc.com/ip.104.177.195.100] has joined #bitcoin-core-dev 18:14 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 268 seconds] 18:18 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev 18:18 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Client Quit] 18:25 < ghost43> ok I've figured it out 18:25 < ghost43> rpcallowip=::/0 used to work but is now broken 18:25 < ghost43> rpcallowip=0.0.0.0/0 works. 18:25 < ghost43> luke-jr, sipa ^ 18:25 < sipa> uh 18:26 < sipa> that's not good 18:26 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 18:28 < ghost43> I will open an issue on github 18:29 < sipa> yes, please 18:29 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Remote host closed the connection] 18:33 -!- madara_uchicoin [68b1c364@gateway/web/cgi-irc/kiwiirc.com/ip.104.177.195.100] has quit [Quit: Connection closed] 18:33 -!- nibbier [~quassel@mx01.geekbox.info] has quit [Ping timeout: 246 seconds] 18:34 -!- madara_uchicoin [68b1c364@gateway/web/cgi-irc/kiwiirc.com/ip.104.177.195.100] has joined #bitcoin-core-dev 18:44 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 18:48 -!- madara_uchicoin [68b1c364@gateway/web/cgi-irc/kiwiirc.com/ip.104.177.195.100] has left #bitcoin-core-dev [] 18:49 -!- nibbier [~quassel@mx01.geekbox.info] has joined #bitcoin-core-dev 18:50 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 268 seconds] 18:52 < luke-jr> eh, that sounds reasonable? 18:53 < luke-jr> if you bind IPv4 and only allow IPv6.. what do you expect? XD 18:53 < luke-jr> (also, not a good idea to allow connections from the internet) 18:58 < sipa> ah 19:02 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 19:03 -!- murrayn [~murray@unaffiliated/murrayn] has quit [Ping timeout: 240 seconds] 19:04 < ghost43> luke-jr: my point is that this exact setup worked up until I upgraded bitcoind 19:05 < ghost43> how can I bind/allow both ipv4 and ipv6 btw? 19:05 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Remote host closed the connection] 19:05 < ghost43> can the config var be duplicated or something? comma separated maybe? 19:08 < ghost43> anyway, opened issue #21070, feel free to close. it might help others just by virtue of search engines indexing it :) 19:08 < gribble> https://github.com/bitcoin/bitcoin/issues/21070 | RPC: conf var rpcallowip=::/0 stopped working when upgrading to 0.21 · Issue #21070 · bitcoin/bitcoin · GitHub 19:08 < luke-jr> ghost43: duplicate 19:09 < ghost43> luke-jr: oh, of which one? I tried to search :/ 19:09 < luke-jr> ghost43: but typically binding IPv6 "wraps" IPv4 too 19:10 < luke-jr> ghost43: no, I mean duplicate rpcbind/rpcallowip 19:10 < ghost43> I see 19:10 < sipa> since 0.21 we starting treating addresses/netmasks as tagged per network 19:10 < sipa> so you can't actually have a netmask anymore that matches both ipv4 and ipv6 19:11 < sipa> this is easy to restore if we wanted to, though 19:11 < sipa> i suspect this will result in a few subtle breakages, perhaps some more severe than this 19:20 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 19:20 -!- murray [~murray@static.38.4.181.135.clients.your-server.de] has joined #bitcoin-core-dev 19:20 -!- murray is now known as Guest28944 19:26 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 268 seconds] 19:40 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 19:43 -!- corollari_ [uid405633@gateway/web/irccloud.com/x-iroavaddsvqbaies] has joined #bitcoin-core-dev 19:44 -!- owowo [~ovovo@31.7.59.226] has joined #bitcoin-core-dev 19:44 -!- owowo [~ovovo@31.7.59.226] has quit [Changing host] 19:44 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 19:46 -!- ovovo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 246 seconds] 19:46 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 268 seconds] 20:00 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 20:06 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 268 seconds] 20:08 -!- rpite [~rpite@47.187.219.52] has quit [Ping timeout: 265 seconds] 20:10 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 20:17 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 20:23 -!- jespada [~jespada@90.254.242.138] has quit [Ping timeout: 240 seconds] 20:23 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 268 seconds] 20:27 -!- jespada [~jespada@90.254.242.138] has joined #bitcoin-core-dev 20:36 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 20:43 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 268 seconds] 20:50 -!- baldur [~baldur@pool-108-30-51-126.nycmny.fios.verizon.net] has quit [Ping timeout: 246 seconds] 20:54 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 20:55 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 21:00 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 21:02 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 268 seconds] 21:03 -!- baldur [~baldur@pool-108-30-51-126.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 21:07 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection] 21:12 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 21:14 -!- johnbendi [~mindbende@154.118.4.227] has joined #bitcoin-core-dev 21:15 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 21:16 -!- drbonez_ [~drbonez@2601:280:4b00:96b0:638e:615f:48f7:2b2b] has joined #bitcoin-core-dev 21:21 -!- dr-bonez [~drbonez@2601:280:4b00:96b0:a3fa:7b45:700d:a57a] has quit [Ping timeout: 264 seconds] 21:21 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 268 seconds] 21:33 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 21:35 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev 21:39 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 268 seconds] 21:40 -!- promag [~promag@188.250.84.129] has quit [Ping timeout: 256 seconds] 21:51 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 21:55 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Remote host closed the connection] 22:11 -!- corollari_ [uid405633@gateway/web/irccloud.com/x-iroavaddsvqbaies] has quit [Quit: Connection closed for inactivity] 22:12 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 22:18 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 268 seconds] 22:29 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 22:32 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Remote host closed the connection] 22:49 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 22:49 -!- Guest28944 [~murray@static.38.4.181.135.clients.your-server.de] has left #bitcoin-core-dev [] 22:50 -!- murrayn [~murray@unaffiliated/murrayn] has joined #bitcoin-core-dev 22:55 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 268 seconds] 23:08 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 268 seconds] 23:08 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 23:12 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Remote host closed the connection] 23:18 -!- drbonez_ [~drbonez@2601:280:4b00:96b0:638e:615f:48f7:2b2b] has quit [Ping timeout: 264 seconds] 23:26 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 23:33 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 268 seconds] 23:37 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev 23:41 -!- promag [~promag@188.250.84.129] has quit [Ping timeout: 240 seconds] 23:41 -!- jungly [~jungly@host-79-23-186-173.retail.telecomitalia.it] has joined #bitcoin-core-dev 23:44 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 23:48 -!- Guest62723 [~ds@139.28.218.148] has quit [Remote host closed the connection] 23:48 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Remote host closed the connection] 23:52 -!- jonatack [~jon@88.124.242.136] has quit [Ping timeout: 258 seconds] 23:52 -!- abian [~abian@185.204.1.185] has joined #bitcoin-core-dev 23:52 -!- jonatack [jon@gateway/vpn/airvpn/jonatack] has joined #bitcoin-core-dev 23:52 -!- abian is now known as Guest38429 23:53 -!- einyx [einyx@fsf/member/einyx] has quit [Ping timeout: 246 seconds] 23:58 -!- johnbendi [~mindbende@154.118.4.227] has quit [Ping timeout: 240 seconds] --- Log closed Wed Feb 03 00:00:34 2021