--- Log opened Wed Mar 10 00:00:53 2021
00:11 -!- roconnor [~roconnor@host-45-58-192-182.dyn.295.ca] has quit [Remote host closed the connection]
00:11 -!- roconnor [~roconnor@host-45-58-192-182.dyn.295.ca] has joined #bitcoin-core-dev
00:17 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
00:50 -!- asdlkfjwerpoicvx [~flack@p200300d46f1aca00801e2ec5d2a57b1b.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
00:53 -!- circ-user-JiP1n [~circuser-@net-5-94-23-208.cust.vodafonedsl.it] has joined #bitcoin-core-dev
00:57 -!- grubles [~unknown@unaffiliated/grubles] has quit [Ping timeout: 260 seconds]
01:07 -!- tvn [~tvn@37.120.211.188] has quit [Remote host closed the connection]
01:12 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Ping timeout: 260 seconds]
01:14 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
01:18 -!- sr_gi [~sr_gi@static-57-159-230-77.ipcom.comunitel.net] has quit [Read error: Connection reset by peer]
01:19 -!- grubles [~unknown@96.30.199.172] has joined #bitcoin-core-dev
01:19 -!- grubles [~unknown@96.30.199.172] has quit [Changing host]
01:19 -!- grubles [~unknown@unaffiliated/grubles] has joined #bitcoin-core-dev
01:20 -!- sr_gi [~sr_gi@static-57-159-230-77.ipcom.comunitel.net] has joined #bitcoin-core-dev
01:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:43 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/eea6196c3d80...7cdadf91d513
01:43 < bitcoin-git> bitcoin/master a6b0fe2 John Newbery: [net processing] Remove unused CNode.address member
01:43 < bitcoin-git> bitcoin/master 7cdadf9 MarcoFalke: Merge #21395: Net processing: Remove unused CNode.address member
01:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:43 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #21395: Net processing: Remove unused CNode.address member (master...2021-03-remove-address) https://github.com/bitcoin/bitcoin/pull/21395
01:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:49 < bitcoin-git> [bitcoin] fanquake opened pull request #21404: refactor: Remove MakeUnique<T>() (master...remove_makeunique) https://github.com/bitcoin/bitcoin/pull/21404
01:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:49 < bitcoin-git> [bitcoin] fanquake opened pull request #21405: compat: remove memcpy -> memmove backwards compatibility alias (master...remove_memcpy_back_compat) https://github.com/bitcoin/bitcoin/pull/21405
01:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:50 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
01:57 -!- talbtcha [58e26d9d@88.226.109.157] has quit [Quit: Connection closed]
02:04 -!- ishaqm [~ishaqm@79-66-4-138.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev
02:08 -!- talbtcha [58e26d9d@88.226.109.157] has joined #bitcoin-core-dev
02:09 -!- talbtcha [58e26d9d@88.226.109.157] has quit [Client Quit]
02:12 -!- ishaqm [~ishaqm@79-66-4-138.dynamic.dsl.as9105.com] has quit [Remote host closed the connection]
02:27 -!- jonatack [~jon@37.173.131.107] has joined #bitcoin-core-dev
02:31 -!- circ-user-JiP1n [~circuser-@net-5-94-23-208.cust.vodafonedsl.it] has quit [Remote host closed the connection]
02:31 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
02:33 -!- jonatack [~jon@37.173.131.107] has quit [Read error: Connection reset by peer]
02:34 -!- jonatack [~jon@37.173.131.107] has joined #bitcoin-core-dev
02:35 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
02:35 -!- awesome_doge [~Thunderbi@118-163-120-175.HINET-IP.hinet.net] has quit [Ping timeout: 245 seconds]
02:36 -!- chrisguidaOld[m] [chrisguida@gateway/shell/matrix.org/x-hfxpptthejaixdjs] has quit [Quit: Bridge terminating on SIGTERM]
02:36 -!- zeropoint[m] [zeropointi@gateway/shell/matrix.org/x-zyplrbiamqpmyscg] has quit [Quit: Bridge terminating on SIGTERM]
02:36 -!- iridis[m] [iridismatr@gateway/shell/matrix.org/x-wadheebfwaipgxpm] has quit [Quit: Bridge terminating on SIGTERM]
02:36 -!- leanbarba[m] [leanbarbam@gateway/shell/matrix.org/x-tajbpoyrpojyixfp] has quit [Quit: Bridge terminating on SIGTERM]
02:36 -!- robert_spigler [robertspig@gateway/shell/matrix.org/x-fqzdcayiqboawwcs] has quit [Quit: Bridge terminating on SIGTERM]
02:36 -!- vdero133[m] [vdero133ma@gateway/shell/matrix.org/x-xfimriyqxcowcdwz] has quit [Quit: Bridge terminating on SIGTERM]
02:36 -!- vadorovsky [vadorovsky@gateway/shell/matrix.org/x-gbovdylruzlmumqk] has quit [Quit: Bridge terminating on SIGTERM]
02:36 -!- suzziminer[m] [suzziminer@gateway/shell/matrix.org/x-cjfslzsmnrrmyqsw] has quit [Quit: Bridge terminating on SIGTERM]
02:36 -!- Thomas[m]1 [thomaseizi@gateway/shell/matrix.org/x-pgbrmczgdgpzqsbb] has quit [Quit: Bridge terminating on SIGTERM]
02:38 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Ping timeout: 246 seconds]
02:41 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
02:47 -!- robert_spigler [robertspig@gateway/shell/matrix.org/x-xaqdenlnphxppscx] has joined #bitcoin-core-dev
02:52 -!- jonatack [~jon@37.173.131.107] has quit [Read error: Connection reset by peer]
02:53 -!- jonatack [~jon@37.173.131.107] has joined #bitcoin-core-dev
02:55 -!- suzziminer[m] [suzziminer@gateway/shell/matrix.org/x-xasxzzuophihqkpo] has joined #bitcoin-core-dev
03:13 -!- Thomas[m]1 [thomaseizi@gateway/shell/matrix.org/x-rdgxtsmgipijqlhr] has joined #bitcoin-core-dev
03:13 -!- vadorovsky [vadorovsky@gateway/shell/matrix.org/x-cjsaltgrfbcsdfya] has joined #bitcoin-core-dev
03:13 -!- iridis[m] [iridismatr@gateway/shell/matrix.org/x-huodujsloxbpbzyi] has joined #bitcoin-core-dev
03:13 -!- leanbarba[m] [leanbarbam@gateway/shell/matrix.org/x-kecnhwmogrrujpxt] has joined #bitcoin-core-dev
03:13 -!- vdero133[m] [vdero133ma@gateway/shell/matrix.org/x-fleuddsxfjecosyb] has joined #bitcoin-core-dev
03:13 -!- chrisguidaOld[m] [chrisguida@gateway/shell/matrix.org/x-npwltavnodeqbewh] has joined #bitcoin-core-dev
03:13 -!- zeropoint[m] [zeropointi@gateway/shell/matrix.org/x-mlwgvotlnvdoubwh] has joined #bitcoin-core-dev
03:28 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
03:32 -!- jungly [~jungly@host-79-55-185-171.retail.telecomitalia.it] has quit [Ping timeout: 260 seconds]
03:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds]
03:33 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
03:39 -!- jungly [~jungly@host-79-55-185-171.retail.telecomitalia.it] has joined #bitcoin-core-dev
03:59 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
04:04 -!- avii [51a74997@151.81-167-73.customer.lyse.net] has joined #bitcoin-core-dev
04:05 -!- jungly [~jungly@host-79-55-185-171.retail.telecomitalia.it] has quit [Ping timeout: 264 seconds]
04:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:43 < bitcoin-git> [bitcoin] vasild opened pull request #21407: i2p: limit the size of incoming messages (master...limit_RecvUntilTerminator) https://github.com/bitcoin/bitcoin/pull/21407
04:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:56 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
04:56 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
05:01 < vasild> jonatack: how big is ./oom-da39a3ee5e6b4b0d3255bfef95601890afd80709? Can I get it in order to reproduce?
05:03 < vasild> "base unit: 0000000000000000000000000000000000000000", does it contain just a bunch of zeros? I tried with a file that contains 20 zero bytes, but it executed without errors
05:10 -!- wenyi [8be26a10@139.226.106.16] has joined #bitcoin-core-dev
05:18 -!- awesome_doge [~Thunderbi@2001-b400-e272-0349-b938-37a3-0138-72fb.emome-ip6.hinet.net] has joined #bitcoin-core-dev
05:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 264 seconds]
05:33 -!- wenyi [8be26a10@139.226.106.16] has quit [Quit: Connection closed]
05:39 -!- jungly [~jungly@host-79-55-185-171.retail.telecomitalia.it] has joined #bitcoin-core-dev
05:39 -!- very_sneaky [~very_snea@45.67.96.42] has quit [Ping timeout: 276 seconds]
05:45 -!- awesome_doge [~Thunderbi@2001-b400-e272-0349-b938-37a3-0138-72fb.emome-ip6.hinet.net] has quit [Ping timeout: 260 seconds]
06:00 < jonatack> vasild: it is an empty file.... -rw-r--r--  1        0 Mar 10 13:20 oom-da39a3ee5e6b4b0d3255bfef95601890afd80709
06:01 < vasild> executes without issues here: Executed /tmp/oom in 1 ms
06:01 < vasild> can you reproduce?
06:01 < jonatack> do you also get OOM with?  src/test/fuzz/fuzz ../qa-assets/fuzz_seed_corpus/
06:01 < jonatack> FUZZ=i2p src/test/fuzz/fuzz ../qa-assets/fuzz_seed_corpus/
06:02 < jonatack> (i don't have the fuzz build anymore, testing another PR, will re-check a bit later)
06:05 < vasild> I did not try but this usage looks strange: ../qa-assets/fuzz_seed_corpus/ does not contain any seeds, just subdirectories, shouldn't that be ../qa-assets/fuzz_seed_corpus/i2p/ ?
06:06 < vasild> I run it like "src/test/fuzz/fuzz /some/new/empty/directory"
06:07 < vasild> anyway, I ran it over the weekend (~2 days) without seeing any issues
06:34 -!- leonardo_ [sid489830@gateway/web/irccloud.com/x-hewqwxmrmupgkqpa] has joined #bitcoin-core-dev
06:35 -!- ishaqm [~ishaqm@79-66-4-138.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev
06:44 -!- jonatack [~jon@37.173.131.107] has quit [Read error: Connection reset by peer]
06:44 -!- scedastik [~scedastik@c-68-58-168-96.hsd1.mi.comcast.net] has joined #bitcoin-core-dev
06:45 -!- scedastik [~scedastik@c-68-58-168-96.hsd1.mi.comcast.net] has left #bitcoin-core-dev []
06:45 -!- scedastik [~scedastik@c-68-58-168-96.hsd1.mi.comcast.net] has joined #bitcoin-core-dev
06:45 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection]
06:46 -!- jonatack [~jon@37.173.131.107] has joined #bitcoin-core-dev
06:59 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev
07:09 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
07:11 -!- IGHOR [~quassel@176.121.4.135] has quit [Quit: http://quassel-irc.org ? ??????????? ?????????. ????-??.]
07:12 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 260 seconds]
07:14 -!- kabaum [~kabaum@h-13-35.A163.priv.bahnhof.se] has quit [Ping timeout: 260 seconds]
07:16 -!- promag [~promag@188.250.84.129] has quit [Read error: Connection reset by peer]
07:16 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
07:17 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
07:18 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection]
07:21 -!- kabaum [~kabaum@h-13-35.A163.priv.bahnhof.se] has joined #bitcoin-core-dev
07:23 -!- IGHOR [~quassel@176.121.4.135] has joined #bitcoin-core-dev
07:24 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
07:26 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 260 seconds]
07:26 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
07:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
07:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
07:31 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds]
07:32 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection]
07:35 < luke-jr> jnewbery: CI is supposed to merge PRs to master before running tests.. it should never require a rebase O.o
07:35 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
07:37 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
07:44 < jnewbery> luke-jr: hmmm, i'm not sure that's working on #19391. It doesn't look like _any_ Cirrus CI jobs have been run on it
07:44 < gribble> https://github.com/bitcoin/bitcoin/issues/19391 | RPC/Mining: Clean out pre-Segwit miner compatibility code by luke-jr · Pull Request #19391 · bitcoin/bitcoin · GitHub
07:44 < jnewbery> only travis and appveyor. I guess that's because the branch is from before cirrus was a thing
07:45 < aj> i think it's just that the last update to the PR was before cirrus was a thing?
07:47 < jnewbery> I think it's generally useful for reviewers to rebase on master fairly regularly. If you don't then they either have to rebase it themselves, or building takes forever since everything needs to be recompiled
07:49 < aj> you don't have to rebase, just "git checkout origin/master; git merge pull/origin/12345"
07:51 -!- rex4539_ [~rex4539@gateway/tor-sasl/rex4539] has quit [Remote host closed the connection]
07:52 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev
08:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:02 < bitcoin-git> [gui] MarcoFalke merged pull request #229: Fix regression with initial sorting after pr205 (master...210227-sort) https://github.com/bitcoin-core/gui/pull/229
08:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:02 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7cdadf91d513...63314b8211d7
08:02 < bitcoin-git> bitcoin/master c524dc5 Hennadii Stepanov: qt: Fix regression with initial sorting after pr205
08:02 < bitcoin-git> bitcoin/master 63314b8 MarcoFalke: Merge bitcoin-core/gui#229: Fix regression with initial sorting after pr20...
08:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:05 < bitcoin-git> [bitcoin] luke-jr closed pull request #19391: RPC/Mining: Clean out pre-Segwit miner compatibility code (master...gbt_rm_versionforce) https://github.com/bitcoin/bitcoin/pull/19391
08:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:06 < luke-jr> hmm, surely there's some way to trigger a CI re-run
08:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:06 < bitcoin-git> [bitcoin] luke-jr reopened pull request #19391: RPC/Mining: Clean out pre-Segwit miner compatibility code (master...gbt_rm_versionforce) https://github.com/bitcoin/bitcoin/pull/19391
08:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:07 < MarcoFalke> EDITOR=true git commit --amend && git push ... ... -f
08:07 < luke-jr> MarcoFalke: yeah, but that's ugly :P
08:08 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Ping timeout: 268 seconds]
08:08 < MarcoFalke> git commit --allow-empty -m empty && git push ... ... && sleep 15 && git push ... HEAD~:... -f
08:08 < luke-jr> >_<
08:08 < hebasto> nice progress with #21376 -- 2 ACKs already :)
08:08 < gribble> https://github.com/bitcoin/bitcoin/issues/21376 | depends: Qt 5.12.10 by fanquake · Pull Request #21376 · bitcoin/bitcoin · GitHub
08:08 < luke-jr> I thought DrahtBot did it somehow
08:09 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev
08:14 -!- jonatack [~jon@37.173.131.107] has quit [Ping timeout: 246 seconds]
08:15 -!- jonatack [~jon@37.173.131.107] has joined #bitcoin-core-dev
08:15 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 264 seconds]
08:15 -!- proofofkeags [~proofofke@205.209.28.54] has joined #bitcoin-core-dev
08:26 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
08:32 -!- pox [~pox@gateway/tor-sasl/pox] has quit [Quit: pox]
08:32 -!- mol [~mol@unaffiliated/molly] has quit [Read error: Connection reset by peer]
08:33 -!- pox [~pox@gateway/tor-sasl/pox] has joined #bitcoin-core-dev
08:33 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
08:36 < jnewbery> aj: good tip with the git merge. As a reviewer though, I want the thing I review to be as close as possible to the thing that master would be if the branch is merged, which for this project is the branch rebased on master. Probably doesn't make that much difference though
08:38 < hebasto> jnewbery: also `git fetch origin pull/12345/merge`
08:40 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 246 seconds]
08:40 < luke-jr> jnewbery: actually, what aj suggested is the closest thing (aside from the commit message and PGP sig)
08:44 < queip> anyone knowing wallet code around? if you don't mind I wanted to confirm, is Core quaranteed to correctly load and show history/ballance if you load many wallet files, of which some are the same wallet but older backup of it.  does the fact same key exists in many wallets is not bugging out some assumptions in code
08:45 < queip> (if you load it all at once)
08:45 < luke-jr> queip: you can't load more than one at a time
08:47 < queip> luke-jr: you mean, loading older backup -wallet=wallet1.dat  while also loading new version of it -wallet=wallet2.dat is not allowed?
08:47 < luke-jr> right
08:47 < queip> is it safe (detected and refused)?
08:47 < jnewbery> luke-jr: oh yes, you're right
08:47 < luke-jr> queip: yes, for bdb wallets
08:47 < queip> luke-jr: do the wallets contain some internal UUID set on creation?
08:47 < luke-jr> queip: yes
08:48 < queip> oh great
08:48 < luke-jr> the experimetnal descriptor wallets / sqlite are missing this at the moment
08:48 < queip> including old (but post 2011) versions?
08:48 < luke-jr> see #20205
08:48 < gribble> https://github.com/bitcoin/bitcoin/issues/20205 | wallet: Properly support a wallet id by achow101 · Pull Request #20205 · bitcoin/bitcoin · GitHub
08:48 < queip> interesting
08:48 < luke-jr> queip: I'm not sure when the safe detection was added
08:48 -!- pox [~pox@gateway/tor-sasl/pox] has quit [Quit: pox]
08:50 -!- pox [~pox@gateway/tor-sasl/pox] has joined #bitcoin-core-dev
08:51 -!- pox [~pox@gateway/tor-sasl/pox] has quit [Client Quit]
08:51 -!- infernix [nix@unaffiliated/infernix] has quit [Remote host closed the connection]
08:52 -!- infernix [~nix@unaffiliated/infernix] has joined #bitcoin-core-dev
08:53 < MarcoFalke> I generally merge/rebase a pull before review if I want to test it. My ccache is populated with latest master, so applying changes on top of master will make it compile faster
08:53 < luke-jr> nice tip, I should do that
08:54 < luke-jr> gcmw() { git checkout --detach origin/master && git merge "$@"; } ? :p
08:55 < sipsorcery>     
08:55 < MarcoFalke> just git rebase/merge bitcoin/master (not a lot to type with auto-complete)
08:56 -!- jespada [~jespada@90.254.243.187] has quit [Ping timeout: 245 seconds]
08:58 -!- eoin [332556a5@51.37.86.165] has joined #bitcoin-core-dev
08:58 -!- lightlike [~lightlike@p200300c7ef13e3001907dbbcf7a603f5.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
08:59 -!- jespada [~jespada@90.254.243.187] has joined #bitcoin-core-dev
08:59 < jnewbery> MarcoFalke: yes, same
09:04 < jonatack> same, I usually rebase unless it was just rebased
09:08 -!- ishaqm [~ishaqm@79-66-4-138.dynamic.dsl.as9105.com] has quit [Remote host closed the connection]
09:20 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
09:21 -!- asdlkfjwerpoicvx [~flack@p200300d46f1aca00801e2ec5d2a57b1b.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!]
09:21 -!- jeremyrubin [~jr@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev
09:31 < jeremyrubin> Who runs drahbot?
09:32 < jeremyrubin> it might be nice to add an annotation when drahbot lists conflicts for last commented date (was looking at #21404 for this)
09:32 < gribble> https://github.com/bitcoin/bitcoin/issues/21404 | refactor: Remove MakeUnique () by fanquake · Pull Request #21404 · bitcoin/bitcoin · GitHub
09:32 < sipa> MarcoFalke: ^
09:33 < MarcoFalke> What is an "annotation"?
09:34 < jeremyrubin> when drahbot comments with the lists of PRs conflicting, a label that shows when the PR was last updated
09:34 < MarcoFalke> There is a dropdown "edited <". For example: https://github.com/bitcoin/bitcoin/pull/21244#issuecomment-782685008
09:34 < MarcoFalke> It shows the last time the comment was edited
09:34 < jeremyrubin> no I'm saying that for every PR listed
09:35 < jeremyrubin> it might be convenient to show if it's something that's stale or not
09:35 < jeremyrubin> If you look at https://github.com/bitcoin/bitcoin/pull/21404#issuecomment-795722299
09:35 -!- ovovo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 246 seconds]
09:35 < jeremyrubin> + jnewbery's comment: Concept ACK, although I agree with Marco that we should wait for drahtbot to tell us how many PRs this conflicts with, and hold back if any of those are important and close to being merged.
09:36 < jeremyrubin> recency of PR update as a proxy for importance
09:37 < MarcoFalke> Oh you mean each conflict pr in the list would have a (last updated: date). That is certainly possible, but would need to be updated on probably every run
09:37 < MarcoFalke> you mean inverse proxy? ;)
09:38 < jeremyrubin> 'heuristic'
09:39 < MarcoFalke> For example #20966  is important, but it doesn't have any comments (apart from "Needs rebase" and "Rebased")
09:39 < jeremyrubin> it's not super important, I've found myself wanting this before though when I get random conflicts. I could see how it would be annoying to have to go back through and filter updates by drahbot/non drahbot etc
09:39 < gribble> https://github.com/bitcoin/bitcoin/issues/20966 | banman: save the banlist in a JSON format on disk by vasild · Pull Request #20966 · bitcoin/bitcoin · GitHub
09:40 < jeremyrubin> MarcoFalke: is drahbot open source somewhere?
09:40 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
09:40 < MarcoFalke> The code is too ugly to make open source
09:41 < MarcoFalke> You'd be able to write nicer code in less than 5 minutes
09:41 < jeremyrubin> invite me to the repo I could take a look... 
09:41 < jeremyrubin> Maybe counting commit tagged ACKs for the current git tip could be a good heuristic too?
09:42 < jeremyrubin> MarcoFalke: not the hugest fan of devops-y stuff so it would probably take me > 5 mins :)
09:42 < MarcoFalke> Yeah, the ACK would be a good idea
09:42 < MarcoFalke> *ACKs
09:43 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
09:43 < jeremyrubin> Maybe also adding the ability for maintainers / PR author to comment clearack if they think the acks need to be invalidated (e.g., someone finds a bug)
09:43 < jeremyrubin> don't need to get too fancy
09:44 < jeremyrubin> but I think improving the tooling a bit could help deduplicate a lot of replicated manual work
09:44 < MarcoFalke> heh, all I know about devops is how to write a loop in bash. DrahtBot is basically a `while true; ./label_rebase.py ; done`, where the python script just imports a github api library and then tags all pulls needing rebase...
09:45 < MarcoFalke> That's what NACK is for
09:47 < jeremyrubin> I think NACK is ambiguous between NACK this and all bugfixes of this v.s. "the current ACKs should be invalidated"
09:47 < jeremyrubin> But I guess it's not too important
09:48 < MarcoFalke> Concept NACK / Approach NACK are about the concept/Approach
09:48 < MarcoFalke> NACK commit_id is about a specific id
09:48 < MarcoFalke> (at least that's how I use it)
09:48 < MarcoFalke> Probably should be documented as such
09:48 < sipa> yes
09:48 < jeremyrubin> yeah 
09:49 < jeremyrubin> Could be nice to have an @admiralackbot that has a documented ACKs API to better collate and style conform what ACKs have been used... GH also has builtin "approved changes" but I don't find it explicit enough for my tastes
09:50 < jeremyrubin> Maybe I'll hack one together if people like the idea of having something like that
09:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:53 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #21408: doc: Explain how NACK commit_id works (master...2103-docNack) https://github.com/bitcoin/bitcoin/pull/21408
09:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:53 < MarcoFalke> sipa: jeremyrubin: ^ 
09:55 -!- az0re [~az0re@gateway/tor-sasl/az0re] has quit [Remote host closed the connection]
10:02 < jeremyrubin> MarcoFalke: there's some annoying things with how git works that it probably makes sense to clarify around e.g., rebase + push -f that would make NACK id stale that we should clarify NACK <id> becomes NACK untill explicitly lifted
10:02 < jeremyrubin> I made a comment as such but it feels... overkill
10:03 < MarcoFalke> jeremyrubin: You can re-NACK (just like a re-ACK)
10:04 < jeremyrubin> I think on the balance it's safer to require re-ack, but not to require re-nack
10:04 < MarcoFalke> Also, if you use the GitHub NACK feature, the merge button will turn red (instead of green)
10:04 < MarcoFalke> Even after rebase
10:05 < MarcoFalke> I think it is safe to assume a NACK is "sticky" until unsticked (no need to document that)
10:05 -!- eoin [332556a5@51.37.86.165] has quit [Ping timeout: 240 seconds]
10:05 < achow101> queip: if you load multiple wallets with the same keys, it will handle them independently. It will show all of the same transactions, although the timestamps of those transactions may differ. If you copy the wallet file, for bdb wallets, we don't allow you to load the copies due to caching (and other) issues with bdb itself. There is no other reason that loading duplicate wallets would be disallowed.
10:05 < MarcoFalke> Obviously to be on the safe side, I'd still encourage to re-NACK if needed.
10:06 < MarcoFalke> If the documentation is too verbose, chances are less people will read it
10:10 -!- jonatack [~jon@37.173.131.107] has quit [Quit: jonatack]
10:10 -!- jonatack [~jon@37.173.131.107] has joined #bitcoin-core-dev
10:10 -!- jonatack [~jon@37.173.131.107] has quit [Read error: Connection reset by peer]
10:10 -!- jonatack [~jon@37.173.131.107] has joined #bitcoin-core-dev
10:11 -!- jonatack [~jon@37.173.131.107] has quit [Client Quit]
10:11 -!- jonatack [~jon@37.173.131.107] has joined #bitcoin-core-dev
10:12 -!- jonatack [~jon@37.173.131.107] has quit [Client Quit]
10:12 -!- jonatack [~jon@37.173.131.107] has joined #bitcoin-core-dev
10:15 < MarcoFalke> what about adding labels to denote the number of ACKs?
10:16 -!- nathanael [~nathanael@unaffiliated/nathanael] has joined #bitcoin-core-dev
10:16 -!- avii [51a74997@151.81-167-73.customer.lyse.net] has quit [Quit: Connection closed]
10:16 < MarcoFalke> which color are ACKs?
10:17 < MarcoFalke> https://github.com/bitcoin/bitcoin/labels/1%20ACK
10:22 < jeremyrubin> love that idea, it's simple
10:23 < jeremyrubin> if people abuse it we can make it only count ACKs on a list (just for the tooling, people could add themselves) but I think ACK labels are great
10:24 < luke-jr> MarcoFalke: the label should be coloured lime green /s
10:24 -!- copumpkin [~copumpkin@unaffiliated/copumpkin] has quit [Remote host closed the connection]
10:24 < MarcoFalke> luke-jr: Did that
10:24 < luke-jr> lol
10:24 < jeremyrubin> a different shade though
10:24 < jeremyrubin> (jk)
10:25 -!- copumpkin [~copumpkin@unaffiliated/copumpkin] has joined #bitcoin-core-dev
10:25 < luke-jr> jeremyrubin: wait, you mean it should be key-lime green?
10:26 < jeremyrubin> Mmm was thinking chartreuse actually 
10:26 -!- cguida [~Adium@2806:2f0:51c1:5cee:111d:a146:4654:4a12] has joined #bitcoin-core-dev
10:27 < luke-jr> wut
10:28 < jeremyrubin> it comes from the french liquor chartreuse, which comes from "charter house", where a charter can be a conferrence of privilege.
10:30 -!- mol_ [mol@gateway/vpn/protonvpn/molly] has joined #bitcoin-core-dev
10:32 -!- jungly [~jungly@host-79-55-185-171.retail.telecomitalia.it] has quit [Ping timeout: 276 seconds]
10:33 -!- ccdle12 [955adef3@243.222.90.149.rev.vodafone.pt] has joined #bitcoin-core-dev
10:34 < jonatack> nah, these liquors usually were made by monks or nuns
10:34 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds]
10:34 < jonatack> this one by carthusian monks located in the chartreuse mountains near the french alps
10:38 -!- pox [~pox@gateway/tor-sasl/pox] has joined #bitcoin-core-dev
10:38 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
10:45 -!- roconnor [~roconnor@host-45-58-192-182.dyn.295.ca] has quit [Ping timeout: 256 seconds]
10:46 -!- jonatack [~jon@37.173.131.107] has quit [Read error: Connection reset by peer]
10:47 -!- jonatack [~jon@37.173.131.107] has joined #bitcoin-core-dev
10:51 -!- az0re [~az0re@gateway/tor-sasl/az0re] has joined #bitcoin-core-dev
10:54 -!- smctwo [~smctwo@86.98.5.100] has joined #bitcoin-core-dev
10:58 -!- jonatack [~jon@37.173.131.107] has quit [Quit: jonatack]
11:28 -!- jonatack [~jon@37.173.131.107] has joined #bitcoin-core-dev
11:32 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
11:34 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 264 seconds]
11:34 -!- tlev6 [~tlev@li120-195.members.linode.com] has joined #bitcoin-core-dev
11:34 -!- rockhouse1 [~rockhouse@unaffiliated/rockhouse] has joined #bitcoin-core-dev
11:35 -!- Emcy_ [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
11:35 -!- pinheadmz_ [~pinheadmz@hns-contributor.dev] has joined #bitcoin-core-dev
11:35 -!- Emcy_ [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection]
11:36 -!- Emcy_ [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
11:37 -!- justinmoon_ [~quassel@157.245.122.126] has joined #bitcoin-core-dev
11:37 -!- IGHOR_ [~quassel@176.121.4.135] has joined #bitcoin-core-dev
11:38 -!- Chris_St1 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
11:38 -!- grubles_ [~unknown@96.30.199.172] has joined #bitcoin-core-dev
11:38 -!- grubles_ [~unknown@96.30.199.172] has quit [Changing host]
11:38 -!- grubles_ [~unknown@unaffiliated/grubles] has joined #bitcoin-core-dev
11:38 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev
11:38 -!- dhruvm_ [~dhruv@165.227.49.220] has joined #bitcoin-core-dev
11:39 -!- mekster9 [~mekster@139.180.192.79] has joined #bitcoin-core-dev
11:39 -!- Setherson [~Setherson@108-255-110-61.lightspeed.tukrga.sbcglobal.net] has quit [Ping timeout: 256 seconds]
11:41 -!- smctwo [~smctwo@86.98.5.100] has quit [Remote host closed the connection]
11:42 -!- thrasher`_ [~thrasher@173.209.42.7] has joined #bitcoin-core-dev
11:42 -!- Netsplit *.net <-> *.split quits: thrasher`, tlev, rockhouse, IGHOR, pinheadmz, Evel-Knievel, Emcy, Chris_Stewart_5, dhruvm, shesek,  (+7 more, use /NETSPLIT to show all of them)
11:42 -!- rockhouse1 is now known as rockhouse
11:42 -!- tlev6 is now known as tlev
11:42 -!- mekster9 is now known as mekster
11:43 -!- Netsplit over, joins: Evel-Knievel
11:43 -!- GankMove [~GankMove@unaffiliated/gankmove] has joined #bitcoin-core-dev
11:43 -!- smctwo [~smctwo@86.98.5.100] has joined #bitcoin-core-dev
11:45 -!- nickler [~nickler@static.219.205.69.159.clients.your-server.de] has joined #bitcoin-core-dev
11:45 -!- jespada [~jespada@90.254.243.187] has quit [Ping timeout: 246 seconds]
11:45 -!- spinza [~spin@102.132.245.16] has quit [Read error: Connection reset by peer]
11:45 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Ping timeout: 246 seconds]
11:46 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev
11:46 -!- Chris_St1 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Quit: WeeChat 2.8]
11:47 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
11:47 -!- pinheadmz_ [~pinheadmz@hns-contributor.dev] has quit [Quit: ZNC 1.8.2+deb1+bionic2 - https://znc.in]
11:48 -!- jespada [~jespada@90.254.243.187] has joined #bitcoin-core-dev
11:48 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
11:48 -!- adiabat_ [~adiabat@63.209.32.102] has joined #bitcoin-core-dev
11:49 -!- shesek [~shesek@164.90.217.137] has joined #bitcoin-core-dev
11:49 -!- shesek [~shesek@164.90.217.137] has quit [Changing host]
11:49 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
11:50 -!- pinheadmz [~pinheadmz@hns-contributor.dev] has joined #bitcoin-core-dev
11:50 -!- marcoagn1 [~user@2001:8a0:ffc6:8700:fbe1:d95d:7692:d3c7] has joined #bitcoin-core-dev
11:56 -!- jungly [~jungly@host-79-55-185-171.retail.telecomitalia.it] has joined #bitcoin-core-dev
11:58 -!- ccdle12 [955adef3@243.222.90.149.rev.vodafone.pt] has quit [Ping timeout: 240 seconds]
12:01 -!- TheRec_ [~toto@drupal.org/user/146860/view] has quit []
12:04 -!- ctrlbreak_MAD [~ctrlbreak@159.2.165.130] has joined #bitcoin-core-dev
12:07 -!- ctrlbreak [~ctrlbreak@159.2.165.130] has quit [Ping timeout: 260 seconds]
12:19 < wumpus> it's an interesting idea but i'm not really sure using labels for something like counting acks is a good idea, it really goes aside of the idea of labeling
12:20 < wumpus> there are already so many labels
12:21 < wumpus> ui-wise it's basically a more limited version of what bitcoinacks is doing but without the names
12:23 < wumpus> (and no- please don't create acked-by-wumpus acked-by-sipa etc labels xD)
12:26 < sipa> ACK
12:26 < sipa> (no such labels)
12:38 < wumpus> just 'number of acks' is also such an easy metric to game, if you're going to merge it's probably more important to pay attention to the rest
12:40 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-vulfyaligsvkvsgx] has quit []
12:41 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-lbtetyyqbzzbklbc] has joined #bitcoin-core-dev
12:50 -!- jungly [~jungly@host-79-55-185-171.retail.telecomitalia.it] has quit [Ping timeout: 264 seconds]
12:55 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev
13:00 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Remote host closed the connection]
13:02 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev
13:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:04 < bitcoin-git> [bitcoin] jonatack opened pull request #21410: test: increase rpc_timeout for fundrawtx test_transaction_too_large (master...give-test_transaction_too_large-more-time) https://github.com/bitcoin/bitcoin/pull/21410
13:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:05 -!- bosma [sid103570@gateway/web/irccloud.com/x-qkfgcmheeavarutv] has quit []
13:05 -!- bosma [sid103570@gateway/web/irccloud.com/x-jlshhtkcwznyecfy] has joined #bitcoin-core-dev
13:13 -!- smctwo_ [~smctwo@86.98.5.100] has joined #bitcoin-core-dev
13:14 -!- roconnor [~roconnor@host-45-58-192-182.dyn.295.ca] has joined #bitcoin-core-dev
13:17 -!- smctwo [~smctwo@86.98.5.100] has quit [Ping timeout: 272 seconds]
13:18 -!- smctwo_ [~smctwo@86.98.5.100] has quit [Ping timeout: 246 seconds]
13:18 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
13:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:19 < bitcoin-git> [bitcoin] jonatack opened pull request #21411: test: add logging, reduce blocks generated in wallet groups test (master...wallet_groups-test) https://github.com/bitcoin/bitcoin/pull/21411
13:19 -!- very_sneaky [~very_snea@45.67.96.24] has joined #bitcoin-core-dev
13:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:23 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
13:25 -!- eragmus [sid136308@gateway/web/irccloud.com/x-uddttftymtbhneef] has quit []
13:25 -!- eragmus [sid136308@gateway/web/irccloud.com/x-gtdiviqjvshbjmlo] has joined #bitcoin-core-dev
13:31 -!- jonatack_ [~jon@37.171.231.252] has joined #bitcoin-core-dev
13:34 -!- jonatack_ [~jon@37.171.231.252] has quit [Client Quit]
13:34 -!- jonatack_ [~jon@37.171.231.252] has joined #bitcoin-core-dev
13:35 -!- jonatack [~jon@37.173.131.107] has quit [Ping timeout: 264 seconds]
13:51 -!- nathanael [~nathanael@unaffiliated/nathanael] has quit [Quit: nathanael]
13:53 -!- jonatack_ [~jon@37.171.231.252] has quit [Quit: jonatack_]
13:54 -!- jonatack [~jon@37.171.231.252] has joined #bitcoin-core-dev
13:56 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
13:58 -!- GankMove [~GankMove@unaffiliated/gankmove] has quit [Quit: GankMove]
14:04 < fanquake> I agree with wumpus, not sure about the value of “n ACKs” labels.
14:05 < fanquake> Also, please don’t have drahtbot start adding and removing ACK labels because some spam/unknown accounts drive by and drop ACKs on things. That’s just more noise.
14:07 < fanquake> I think jeremyrubin idea of having some sort of last updated time in the conflict comment is a good one.
14:13 -!- scedastik [~scedastik@c-68-58-168-96.hsd1.mi.comcast.net] has quit [Quit: scedastik]
14:16 -!- brg444 [uid207215@gateway/web/irccloud.com/x-nimakvacfthwvsmg] has quit []
14:16 -!- brg444 [sid207215@gateway/web/irccloud.com/x-xnuuimdvztgcwauq] has joined #bitcoin-core-dev
14:32 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection]
14:42 -!- roconnor [~roconnor@host-45-58-192-182.dyn.295.ca] has quit [Ping timeout: 264 seconds]
14:42 -!- jungly [~jungly@host-79-55-185-171.retail.telecomitalia.it] has joined #bitcoin-core-dev
14:49 -!- nathanael [~nathanael@unaffiliated/nathanael] has joined #bitcoin-core-dev
14:57 -!- jungly [~jungly@host-79-55-185-171.retail.telecomitalia.it] has quit [Ping timeout: 245 seconds]
15:02 < phantomcircuit> wumpus, thoughts on removing zmq? afaict 100% of the users of it are using it in a way that is either dangerous or requires low interval polling anyways
15:04 -!- Nebraskka [~Nebraskka@51.83.249.56] has quit [Remote host closed the connection]
15:04 -!- queip [~queip@unaffiliated/rezurus] has quit [Remote host closed the connection]
15:05 -!- Nebraskka [~Nebraskka@51.83.249.56] has joined #bitcoin-core-dev
15:06 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
15:09 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
15:10 -!- valwal_ [sid334773@gateway/web/irccloud.com/x-ulxywzaegjotuyuq] has quit []
15:10 -!- valwal_ [sid334773@gateway/web/irccloud.com/x-afzpjvgfuispbzys] has joined #bitcoin-core-dev
15:17 -!- roconnor [~roconnor@host-45-58-192-182.dyn.295.ca] has joined #bitcoin-core-dev
15:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:31 < bitcoin-git> [bitcoin] glozow opened pull request #21413: [rfc] add option to bypass contextual timelocks in testmempoolaccept? (master...2021-03-bypass-timelocks) https://github.com/bitcoin/bitcoin/pull/21413
15:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:40 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds]
15:44 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 264 seconds]
15:48 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
16:01 -!- shesek [~shesek@164.90.217.137] has joined #bitcoin-core-dev
16:01 -!- shesek [~shesek@164.90.217.137] has quit [Changing host]
16:01 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
16:05 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Remote host closed the connection]
16:22 -!- stortz [c8b9cbcf@200.185.203.207] has joined #bitcoin-core-dev
16:26 -!- rex4539_ [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev
16:30 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 268 seconds]
16:42 -!- Setherson [~Setherson@108-255-110-61.lightspeed.tukrga.sbcglobal.net] has joined #bitcoin-core-dev
17:01 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
17:04 -!- lightlike [~lightlike@p200300c7ef13e3001907dbbcf7a603f5.dip0.t-ipconnect.de] has quit [Quit: Leaving]
17:13 < fanquake> I'm aware of some large companies that are using zmq extensively in production
17:18 < jeremyrubin> the ZMQ interface we have always struck me as a bit weird
17:18 < jeremyrubin> I guess if it works for people it works
17:18 < jeremyrubin> but I think phantomcircuit your intuition is correct that it might be used wrongly
17:18 < sipa> it'd be saner if it contained just txids/block hashes
17:18 < sipa> and didn't contain any actual data
17:20 < phantomcircuit> fanquake, then they are risking financial loss
17:20 < phantomcircuit> the zmq interface has zero reliability guarantees
17:21 < fanquake> let us know what you plan on replacing it with
17:21 < phantomcircuit> sipa, even then it's pointless, you need to poll to guarantee consistency, so why not just poll?
17:21 < phantomcircuit> fanquake, let me know whose using it so i can not use them
17:23 < sipa> phantomcircuit: depending on the application it's perfectly fine to poll infrequently, and also poll immediately when a zmq notification comes in
17:24 -!- instagibbs [~greg@119247204116.ctinets.com] has joined #bitcoin-core-dev
17:26 < phantomcircuit> sipa, the class of application for which that's ok is basically restricted to the websites displaying the mempool
17:26 < phantomcircuit> sipa, if the zmq interface was narrowed to be a single bit "you want to poll" that would be fine
17:26 < phantomcircuit> but also nobody would use that
17:27 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...]
17:27 < instagibbs> sipa, there are multiple subscriptions for just hashes, "sequence" notifier also lets you detect dropped messages and fallback to a poll
17:28 < sipa> right, that was added
17:29 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev
17:34 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds]
17:42 -!- pox [~pox@gateway/tor-sasl/pox] has quit [Remote host closed the connection]
17:44 -!- pox [~pox@gateway/tor-sasl/pox] has joined #bitcoin-core-dev
17:46 -!- instagibbs [~greg@119247204116.ctinets.com] has quit [Quit: Leaving]
17:54 -!- proofofkeags [~proofofke@205.209.28.54] has quit [Ping timeout: 265 seconds]
18:00 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-lbtetyyqbzzbklbc] has quit [Quit: Connection closed for inactivity]
18:01 -!- molz_ [mol@gateway/vpn/protonvpn/molly] has joined #bitcoin-core-dev
18:03 -!- instagibbs [~greg@119247204116.ctinets.com] has joined #bitcoin-core-dev
18:05 -!- mol_ [mol@gateway/vpn/protonvpn/molly] has quit [Ping timeout: 265 seconds]
18:20 -!- jonatack [~jon@37.171.231.252] has quit [Ping timeout: 265 seconds]
18:23 -!- proofofkeags [~proofofke@97-118-232-73.hlrn.qwest.net] has joined #bitcoin-core-dev
18:32 -!- rockhouse5 [~rockhouse@unaffiliated/rockhouse] has joined #bitcoin-core-dev
18:33 -!- real_or_random [~real_or_r@2a02:c207:3002:7468::1] has joined #bitcoin-core-dev
18:36 -!- comboy_ [~quassel@tesuji.pl] has joined #bitcoin-core-dev
18:36 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has quit [Quit: Ping timeout (120 seconds)]
18:36 -!- Guest52984 [~real_or_r@173.249.7.254] has quit [Quit: ZNC 1.8.2 - https://znc.in]
18:36 -!- comboy [~quassel@tesuji.pl] has quit [Remote host closed the connection]
18:36 -!- rockhouse5 is now known as rockhouse
18:45 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 246 seconds]
18:57 -!- stortz [c8b9cbcf@200.185.203.207] has quit [Quit: Connection closed]
19:05 -!- victorSN [~victorSN@unaffiliated/victorsn] has quit [Quit: Ping timeout (120 seconds)]
19:06 -!- victorSN [~victorSN@unaffiliated/victorsn] has joined #bitcoin-core-dev
19:23 -!- ircmaxell1 [~ircmaxell@217.146.82.202] has joined #bitcoin-core-dev
19:29 -!- victorSN [~victorSN@unaffiliated/victorsn] has quit [Quit: Ping timeout (120 seconds)]
19:30 -!- victorSN [~victorSN@unaffiliated/victorsn] has joined #bitcoin-core-dev
19:31 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
19:32 -!- NickNick [6402d18c@pool-100-2-209-140.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
19:33 -!- tushar-1728 [85ed075c@133.237.7.92] has joined #bitcoin-core-dev
19:34 < phantomcircuit> instagibbs, yes but that means you have a system where failing to do something results in a synchronization failure instead of a system where you're polling
19:35 -!- rex4539_ [~rex4539@gateway/tor-sasl/rex4539] has quit [Ping timeout: 268 seconds]
19:50 -!- NickNick [6402d18c@pool-100-2-209-140.nycmny.fios.verizon.net] has quit [Quit: Connection closed]
19:55 -!- stortz [c8b9cbcf@200.185.203.207] has joined #bitcoin-core-dev
19:56 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
19:56 -!- stortz [c8b9cbcf@200.185.203.207] has quit [Client Quit]
19:59 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 246 seconds]
20:05 -!- tushar-1728 [85ed075c@133.237.7.92] has quit [Ping timeout: 240 seconds]
20:05 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds]
20:06 -!- instagibbs [~greg@119247204116.ctinets.com] has quit [Quit: Leaving]
20:10 -!- awesome_doge [~Thunderbi@118-163-120-175.HINET-IP.hinet.net] has joined #bitcoin-core-dev
20:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:14 < bitcoin-git> [bitcoin] jarolrod opened pull request #21414: doc: update macOS depends platform triplets (master...macOS-platform-triplets) https://github.com/bitcoin/bitcoin/pull/21414
20:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:43 -!- baldur_ [~baldur@pool-108-30-51-126.nycmny.fios.verizon.net] has quit [Ping timeout: 260 seconds]
20:56 -!- baldur_ [~baldur@pool-108-30-51-126.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
20:59 -!- jespada [~jespada@90.254.243.187] has quit [Ping timeout: 276 seconds]
21:02 -!- jespada [~jespada@90.254.243.187] has joined #bitcoin-core-dev
21:20 -!- JokerAscensionEx [~egp_@2.95.74.168] has quit [Remote host closed the connection]
22:01 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
22:03 -!- taky_ [~taky@64.64.117.140] has quit [Ping timeout: 264 seconds]
22:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
22:04 < bitcoin-git> [bitcoin] fanquake opened pull request #21415: refactor: remove Optional & nullopt (master...remove_optional_wrapper) https://github.com/bitcoin/bitcoin/pull/21415
22:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
22:09 < wumpus> phantomcircuit: i don't want to remove zmq, i really like to have a notification mechanism that is not 'call out to a process'
22:09 < wumpus> phantomcircuit: that is the thing i dislike deeply so let's just agree to disagree
22:11 -!- smctwo [~smctwo@94.204.225.231] has joined #bitcoin-core-dev
22:11 < phantomcircuit> wumpus, how about not sending actual data
22:11 < wumpus> *all* notification mechanisms have some degree of unreliability, there is no such thing as 100% reliable notification
22:12 < wumpus> the sequence numbers solve most concerns it pretty well imo and yes you *can* use it wrong
22:12 < wumpus> we had this discussion soo many times
22:13 < wumpus> i like having actual data this is good for low-latency default path
22:15 < wumpus> there are valid reasons for using different kinds of designs, different compromises
22:16 -!- smctwo [~smctwo@94.204.225.231] has quit [Ping timeout: 272 seconds]
22:34 -!- awesome_doge [~Thunderbi@118-163-120-175.HINET-IP.hinet.net] has quit [Quit: awesome_doge]
22:35 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 264 seconds]
23:10 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
23:11 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
23:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:18 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #21408: doc: Explain how NACK commit_id works (master...2103-docNack) https://github.com/bitcoin/bitcoin/pull/21408
23:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:31 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-yxxvxjiwadouvumq] has joined #bitcoin-core-dev
23:32 -!- mrostecki [mrostecki@nat/suse/x-psigibnclcfhfbgx] has quit [Quit: WeeChat 1.8]
23:32 -!- ogo [~ogo@gateway/tor-sasl/ogo] has quit [Remote host closed the connection]
23:32 -!- ogo [~ogo@gateway/tor-sasl/ogo] has joined #bitcoin-core-dev
23:33 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
23:38 -!- jungly [~jungly@host-79-55-189-201.retail.telecomitalia.it] has joined #bitcoin-core-dev
23:58 -!- awesome_doge [~Thunderbi@118-163-120-175.HINET-IP.hinet.net] has joined #bitcoin-core-dev
--- Log closed Thu Mar 11 00:00:43 2021