--- Log opened Thu Mar 18 00:00:59 2021 00:32 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 00:32 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 00:34 -!- very_sne_ [~very_snea@45.67.96.48] has joined #bitcoin-core-dev 00:35 -!- very_sneaky [~very_snea@45.67.96.48] has quit [Ping timeout: 245 seconds] 00:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 00:44 -!- mol_ [mol@gateway/vpn/protonvpn/molly] has quit [Read error: Connection reset by peer] 00:46 -!- mol [mol@gateway/vpn/protonvpn/molly] has joined #bitcoin-core-dev 00:55 -!- very_sne_ is now known as very_sneaky 00:55 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev 01:01 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds] 01:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:02 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e057e01b7b7b...6834e02c896b 01:02 < bitcoin-git> bitcoin/master fa2a80b MarcoFalke: refactor: Pass PeerManagerImpl members only once 01:02 < bitcoin-git> bitcoin/master 6834e02 MarcoFalke: Merge #21425: refactor: Pass PeerManagerImpl members only once 01:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:02 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #21425: refactor: Pass PeerManagerImpl members only once (master...2103-refactorMember) https://github.com/bitcoin/bitcoin/pull/21425 01:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:11 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:33 -!- very_sneaky [~very_snea@45.67.96.48] has quit [Remote host closed the connection] 01:33 -!- very_sneaky [~very_snea@45.67.96.48] has joined #bitcoin-core-dev 01:37 -!- very_sneaky [~very_snea@45.67.96.48] has quit [Ping timeout: 245 seconds] 01:39 -!- very_sneaky [~very_snea@45.67.96.48] has joined #bitcoin-core-dev 01:42 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev 01:47 -!- asdlkfjwerpoicvx [~flack@p200300d46f036d00c1d36e0236d372cb.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 01:58 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Ping timeout: 265 seconds] 02:02 -!- gnusha [~gnusha@unaffiliated/kanzure/bot/gnusha] has quit [Ping timeout: 264 seconds] 02:02 -!- gnusha [~gnusha@unaffiliated/kanzure/bot/gnusha] has joined #bitcoin-core-dev 02:02 -!- Topic for #bitcoin-core-dev: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt 02:02 -!- Topic set by wumpus [] [Tue Nov 3 06:37:20 2020] 02:02 [Users #bitcoin-core-dev] 02:02 [ _0x0ff ] [ kabaum ] 02:02 [ _flow__ ] [ kakobrekla ] 02:02 [ a5m0 ] [ kallewoof ] 02:02 [ Abelian ] [ kanzure ] 02:02 [ achow101 ] [ kcalvinalvin ] 02:02 [ adam3us ] [ kiltzman ] 02:02 [ adiabat_ ] [ kinlo ] 02:02 [ ahmed_ ] [ kvaciral ] 02:02 [ aj ] [ Landryl ] 02:02 [ ajonas ] [ leanbarba[m] ] 02:02 [ amiti ] [ leonardo_ ] 02:02 [ Anduck ] [ lesderid ] 02:02 [ andytoshi ] [ lightningbot ] 02:02 [ aqua42 ] [ Lightsword ] 02:02 [ ariard ] [ lio17 ] 02:02 [ arik__ ] [ luke-jr ] 02:02 [ asdlkfjwerpoicvx] [ marcoagn1 ] 02:02 [ asoltys ] [ MarcoFalke ] 02:02 [ asukan ] [ mariorz ] 02:02 [ b10c ] [ mdrollette ] 02:02 [ baldur ] [ meshcollider ] 02:02 [ belcher_ ] [ michaelfolkson ] 02:02 [ berndj ] [ michagogo_ ] 02:02 [ BGL ] [ midnight ] 02:02 [ bitdex ] [ mmitech___ ] 02:02 [ bosma ] [ mol ] 02:02 [ braydonf ] [ moneyball ] 02:02 [ brg444 ] [ morcos ] 02:02 [ brikk ] [ Murch ] 02:02 [ bsm117532 ] [ murr4y ] 02:02 [ btc_thc ] [ murrayn ] 02:02 [ ccook ] [ nanotube ] 02:02 [ cdecker ] [ nckx ] 02:02 [ cfields ] [ Nebraskka ] 02:02 [ cguida2 ] [ nehan ] 02:02 [ chjj ] [ nejon ] 02:02 [ Chris_St1 ] [ nibbier ] 02:02 [ cncr04s ] [ nickler ] 02:02 [ comboy_ ] [ niftynei ] 02:02 [ commavir ] [ niska ] 02:02 [ copumpkin ] [ nkuttler ] 02:02 [ core-meetingbot ] [ Norrin ] 02:02 [ cornfeedhobo ] [ nothingmuch ] 02:02 [ Cory ] [ notmandatory ] 02:02 [ criley ] [ nsh ] 02:02 [ cryptapus ] [ nullptr| ] 02:02 [ ctrlbreak_MAD ] [ ogo ] 02:02 [ CubicEarth ] [ oozebrood ] 02:02 [ da2ce7 ] [ openoms ] 02:02 [ darosior ] [ ossifrage ] 02:02 [ davec ] [ owowo ] 02:02 [ davterra ] [ paracyst_ ] 02:02 [ dburkett ] [ parazyd ] 02:02 [ DeanGuss ] [ phantomcircuit ] 02:02 [ deltreey ] [ pierre_rochard ] 02:02 [ dergoegge ] [ pingwindyktator ] 02:02 [ dermoth ] [ pinheadmz ] 02:02 [ Dev0n ] [ pox ] 02:02 [ dhruvm ] [ Processus42 ] 02:02 [ digi_james ] [ promag ] 02:02 [ dkrm ] [ provoostenator_ ] 02:02 [ dlb76_ ] [ prusnak ] 02:02 [ dongcarl ] [ qubenix ] 02:02 [ doubleqp ] [ queip ] 02:02 [ DougieBot5000 ] [ rabidus ] 02:02 [ dqx ] [ raj_149 ] 02:02 [ dr-orlovsky ] [ rc_423 ] 02:02 [ dunk ] [ real_or_random ] 02:02 [ dviola ] [ rh0nj ] 02:02 [ earlz ] [ rich ] 02:02 [ einyx ] [ roasbeef ] 02:02 [ elichai2 ] [ robert_spigler ] 02:02 [ Eliel ] [ robot-dreams ] 02:02 [ Emcy ] [ rockhouse ] 02:02 [ emzy ] [ rodarmor ] 02:02 [ endogenic ] [ romanz_ ] 02:02 [ ensign ] [ RubenSomsen ] 02:02 [ eragmus ] [ ryanofsky_ ] 02:02 [ Eric3 ] [ S3RK ] 02:02 [ esotericnonsense] [ s7r ] 02:02 [ Evel-Knievel ] [ sanket1729 ] 02:02 [ face ] [ schmidty ] 02:02 [ fanquake ] [ sdaftuar ] 02:02 [ felixweis ] [ SebastianNoelLbk] 02:02 [ fjahr ] [ sgeisler ] 02:02 [ flag ] [ shesek ] 02:02 [ freedomcode ] [ sipa ] 02:02 [ GAit ] [ so ] 02:02 [ Galvas ] [ spinza ] 02:02 [ ghost43_ ] [ stevenroose ] 02:02 [ gleb ] [ sturles ] 02:02 [ glozow ] [ suzziminer[m] ] 02:02 [ gnusha ] [ takinbo ] 02:02 [ GoldmanSats__ ] [ TallTim ] 02:02 [ greypw ] [ TD-Linux ] 02:02 [ gribble ] [ thaumavorio ] 02:02 [ grubles ] [ TheHoliestRoger ] 02:02 [ Guest86647 ] [ TheRec ] 02:02 [ Guyver2 ] [ TheV01d ] 02:02 [ gwillen ] [ Thomas[m]1 ] 02:02 [ hadjiszs ] [ thrasher`_ ] 02:02 [ harding ] [ tlev ] 02:02 [ hebasto ] [ treyzania ] 02:02 [ helo ] [ tripleslash ] 02:02 [ hirish ] [ tylerchambers ] 02:02 [ hsmiths ] [ uasf ] 02:02 [ hugohn ] [ unauvum ] 02:02 [ IGHOR ] [ vadorovsky ] 02:02 [ infernix ] [ valwal ] 02:02 [ IPGlider ] [ vasild ] 02:02 [ iridis[m] ] [ vdero133[m] ] 02:02 [ isis ] [ very_sneaky ] 02:02 [ isis_ ] [ victorSN ] 02:02 [ Isthmus ] [ virtu ] 02:02 [ Jackielove4u ] [ wallet42____ ] 02:02 [ jakesyl ] [ wangchun ] 02:02 [ jamesob ] [ wangchun_ ] 02:02 [ jarolrod_ ] [ warren ] 02:02 [ jb55 ] [ willcl_ark ] 02:02 [ jeremyrubin ] [ windsok ] 02:02 [ jespada ] [ winz_07 ] 02:02 [ jesseposner ] [ wraithm ] 02:02 [ jkczyz ] [ wumpus ] 02:02 [ jnewbery ] [ wxss_ ] 02:02 [ jonasschnelli ] [ yanmaani ] 02:02 [ jrawsthorne ] [ yunier2002 ] 02:02 [ jrayhawk ] [ Zenton ] 02:02 [ justanotheruser ] [ zeropoint[m] ] 02:02 [ justinmoon_ ] 02:02 -!- Irssi: #bitcoin-core-dev: Total of 257 nicks [0 ops, 0 halfops, 0 voices, 257 normal] 02:02 -!- Channel #bitcoin-core-dev created Mon Nov 17 07:08:12 2014 02:04 -!- Irssi: Join to #bitcoin-core-dev was synced in 122 secs 02:05 -!- IGHOR [~quassel@176.121.4.135] has quit [Quit: No Ping reply in 180 seconds.] 02:07 -!- IGHOR [~quassel@176.121.4.135] has joined #bitcoin-core-dev 02:22 -!- ishaqm [~ishaqm@host-92-7-175-205.as43234.net] has joined #bitcoin-core-dev 02:34 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev 02:38 -!- yoitsdope [~Android@172.58.30.188] has joined #bitcoin-core-dev 02:39 -!- jungly [~jungly@host-62-211-30-194.retail.telecomitalia.it] has joined #bitcoin-core-dev 02:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:46 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/6834e02c896b...a65e772fec62 02:46 < bitcoin-git> bitcoin/master 61a0f8f Hennadii Stepanov: test: Cleanup test files in test-{security,symbol}-check.py 02:46 < bitcoin-git> bitcoin/master 0fc0c00 Hennadii Stepanov: test: Drop unused get_machine function 02:46 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:46 < bitcoin-git> bitcoin/master a65e772 fanquake: Merge #21428: test: Cleanup in test-{security,symbol}-check.py 02:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:46 < bitcoin-git> [bitcoin] fanquake merged pull request #21428: test: Cleanup in test-{security,symbol}-check.py (master...210313-check) https://github.com/bitcoin/bitcoin/pull/21428 02:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:46 -!- vasild [~vd@gateway/tor-sasl/vasild] has quit [Remote host closed the connection] 02:47 -!- vasild [~vd@gateway/tor-sasl/vasild] has joined #bitcoin-core-dev 03:01 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 03:14 -!- yoitsdope [~Android@172.58.30.188] has quit [Quit: -a- IRC for Android 2.1.59] 03:49 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 04:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:26 -!- El_Profesor [05b1be09@5.177.190.9] has joined #bitcoin-core-dev 04:28 -!- El_Profesor [05b1be09@5.177.190.9] has quit [Client Quit] 04:42 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 04:44 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 276 seconds] 04:50 -!- Guyver2_ is now known as Guyver2 04:50 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection] 04:50 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 04:57 -!- Chris_St1 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds] 04:59 -!- Chris_St1 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 05:08 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev 05:13 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Ping timeout: 256 seconds] 05:26 -!- belcher_ is now known as belcher 05:37 -!- very_sneaky [~very_snea@45.67.96.48] has quit [Remote host closed the connection] 05:37 -!- very_sneaky [~very_snea@45.67.96.48] has joined #bitcoin-core-dev 05:51 -!- ishaqm [~ishaqm@host-92-7-175-205.as43234.net] has quit [Remote host closed the connection] 06:11 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 244 seconds] 06:24 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 06:33 -!- willmoffat [~willmoffa@37.120.211.188] has joined #bitcoin-core-dev 06:50 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 07:23 -!- Guest46819 [~gx@116.227.171.12] has joined #bitcoin-core-dev 07:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:23 < bitcoin-git> [bitcoin] Sjors opened pull request #21467: Move external signer out of wallet module (master...2021/03/signer_no_wallet) https://github.com/bitcoin/bitcoin/pull/21467 07:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:31 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 07:34 -!- Landryl [~Landryl@ns528256.ip-192-99-10.net] has quit [Quit: The Lounge - https://thelounge.chat] 07:34 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 244 seconds] 07:35 < michaelfolkson> #proposedmeetingtopic Taproot activation PRs and attempting to finalize startheight 07:40 -!- Guest46819 [~gx@116.227.171.12] has quit [Quit: Leaving] 07:40 -!- very_sneaky [~very_snea@45.67.96.48] has quit [Remote host closed the connection] 07:41 -!- very_sneaky [~very_snea@45.67.96.48] has joined #bitcoin-core-dev 07:42 -!- very_sneaky [~very_snea@45.67.96.48] has quit [Remote host closed the connection] 07:46 -!- jonatack [~jon@37.164.254.128] has joined #bitcoin-core-dev 07:47 -!- very_sneaky [~very_snea@45.67.96.48] has joined #bitcoin-core-dev 07:47 -!- very_sneaky [~very_snea@45.67.96.48] has quit [Remote host closed the connection] 07:50 -!- raj_149 [~quassel@ec2-18-217-191-36.us-east-2.compute.amazonaws.com] has quit [Ping timeout: 240 seconds] 07:51 -!- raj_149 [~quassel@ec2-18-217-191-36.us-east-2.compute.amazonaws.com] has joined #bitcoin-core-dev 08:15 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 268 seconds] 08:16 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 08:30 -!- stortz [c8b9cbcf@200.185.203.207] has joined #bitcoin-core-dev 08:41 -!- uasf [~uasf@2604:a880:2:d0::1bda:1001] has quit [Remote host closed the connection] 08:49 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 244 seconds] 08:51 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 08:51 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 08:55 -!- cguida [~Adium@2806:2f0:51c1:5cee:e8b7:2427:f328:897b] has joined #bitcoin-core-dev 08:58 -!- cguida2 [~Adium@2806:2f0:51c1:5cee:c090:a5b7:3ef1:75c4] has quit [Ping timeout: 265 seconds] 09:08 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Ping timeout: 268 seconds] 09:09 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev 09:17 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: setpill] 09:19 -!- roconnor [~roconnor@host-45-58-230-226.dyn.295.ca] has joined #bitcoin-core-dev 09:33 -!- jespada [~jespada@90.254.243.187] has quit [Ping timeout: 246 seconds] 09:34 -!- jespada [~jespada@90.254.243.187] has joined #bitcoin-core-dev 09:40 -!- pox [~pox@gateway/tor-sasl/pox] has quit [Quit: pox] 09:47 -!- owowo [~ovovo@91.193.4.61] has joined #bitcoin-core-dev 09:47 -!- owowo [~ovovo@91.193.4.61] has quit [Changing host] 09:47 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 10:04 -!- cltrbreak_MAD2 [~ctrlbreak@159.2.165.130] has joined #bitcoin-core-dev 10:07 -!- ctrlbreak_MAD [~ctrlbreak@159.2.165.130] has quit [Ping timeout: 264 seconds] 10:08 -!- pox [~pox@gateway/tor-sasl/pox] has joined #bitcoin-core-dev 10:11 -!- pox [~pox@gateway/tor-sasl/pox] has quit [Client Quit] 10:23 -!- asdlkfjwerpoicvx [~flack@p200300d46f036d00c1d36e0236d372cb.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!] 10:28 -!- pox [~pox@gateway/tor-sasl/pox] has joined #bitcoin-core-dev 10:28 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 10:30 -!- Arvidt [~Arvidt@gateway/tor-sasl/arvidt] has joined #bitcoin-core-dev 10:31 -!- lightlike [~lightlike@p200300c7ef1e930039155a25f8e4eaba.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 10:36 < Arvidt> Any preference for having base-10 (kB/MB/GB) or base-2 (KiB/MiB/GiB) prefix for GUI network peer tab data transferred/throughput value? See https://github.com/bitcoin-core/gui/pull/248 Would be thankful to get some feedback. 10:39 < luke-jr> Arvidt: base 10 sucks ;) 10:40 < hebasto> luke-jr: what reasons for? 10:40 < luke-jr> hebasto: 10 is a multiple of 5 and 2 10:41 < luke-jr> but more importantly, networks tend to use base-1024 measurements 10:42 < sipa> my gigabit ethernet does 1000000000 bits/s 10:42 < luke-jr> sipa: it does? :o 10:42 < sipa> yes 10:42 < luke-jr> hmm 10:42 < sipa> all network stuff is 1000-based, as far as i know' 10:43 < sipa> only disk sizes use 1024-based units conventionally 10:43 < sipa> or on-disk sizes 10:43 < luke-jr> RAM typically does even now 10:43 < sipa> that's true, RAM is also typically 1024-based 10:44 < luke-jr> well, decimal still sucks, but we should match what other stuff does 10:44 < luke-jr> eg, torrent clients, browsers, etc 10:55 < jeremyrubin> can we use nats? 10:55 < jeremyrubin> I think the thing with the MiB MB is it's always "close enough" if you mix em up 10:56 < sipa> it's 7.3% off! 10:59 < jeremyrubin> I think that's why people get away with confusing labeling 11:00 < sipa> once you get to peta/pebi it's a 12.6% difference 11:00 < jeremyrubin> you should file a CFPB complaint :) 11:01 < sipa> child for parent bays? 11:02 < jeremyrubin> I guess CFPB only does financial fraud 11:02 < jeremyrubin> anyways off topic 11:13 -!- spinza [~spin@102.132.245.16] has quit [Ping timeout: 260 seconds] 11:19 -!- jungly [~jungly@host-62-211-30-194.retail.telecomitalia.it] has quit [Ping timeout: 256 seconds] 11:26 < Arvidt> OK I just left the 1000-based prefixes then and just corrected the divisor from 1024 to 1000. Thanks for Your feedback 11:29 -!- stortz [c8b9cbcf@200.185.203.207] has quit [Quit: Connection closed] 11:29 * luke-jr proposes using 1024-based units when it is a good thing, and 1000-based units when it is bad or a cost :P 11:29 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 11:30 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has quit [Remote host closed the connection] 11:32 -!- rex4539 [~rex4539@gateway/tor-sasl/rex4539] has joined #bitcoin-core-dev 11:35 -!- larryruane_ [uid473749@gateway/web/irccloud.com/x-etkneexubbqqgdwq] has joined #bitcoin-core-dev 11:43 -!- kvaciral [~kvaciral@212.8.251.11] has quit [Quit: Lost terminal] 11:55 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Ping timeout: 264 seconds] 11:55 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev 11:58 -!- kvaciral [~kvaciral@212.8.251.11] has joined #bitcoin-core-dev 12:00 < Arvidt> The good thing with binary prefix is that one can be pretty sure the programmers are aware of the complex and (hopefully) knew what they have programmed 12:00 < jnewbery> meet? 12:00 < wumpus> #startmeeting 12:00 < core-meetingbot> Meeting started Thu Mar 18 19:00:46 2021 UTC. The chair is wumpus. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings. 12:00 < core-meetingbot> Available commands: action commands idea info link nick 12:00 < achow101> hi 12:00 < jnewbery> hi 12:00 < amiti> hi 12:00 < sipa> hi 12:00 < fjahr> hi 12:00 < michaelfolkson> hi 12:00 < hebasto> hi 12:01 < wumpus> #bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik 12:01 < wumpus> petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild wumpus 12:01 < glozow> hi 12:01 < meshcollider> hi 12:01 < wumpus> no proposed meeting topics in http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt 12:01 < michaelfolkson> I proposed one. Did I do it wrong? :) 12:01 < wumpus> (fwiw: you can propose meeting topics with #proposedmeetingtopic during the week) 12:02 < wumpus> michaelfolkson: oh? maybe overlooked it 12:02 < jeremyrubin> hi 12:02 < luke-jr> hi 12:02 < wumpus> ah yes 12:02 < dongcarl> hi 12:02 < luke-jr> [14:35:46] #proposedmeetingtopic Taproot activation PRs and attempting to finalize startheight 12:02 < wumpus> Taproot activation PRs and attempting to finalize startheight (michaelfolkson) 12:02 < jonatack> hi 12:03 < wumpus> luke-jr: yes it was the last line, after a lot of spam, which is why i missed it sorry 12:03 < wumpus> any last minute topic proposals? 12:03 -!- OP_NOP [OP_NOP@gateway/vpn/privateinternetaccess/opnop/x-41418994] has joined #bitcoin-core-dev 12:03 < wumpus> #topic High priority for review 12:03 < core-meetingbot> topic: High priority for review 12:04 < achow101> #21392 for me 12:04 < gribble> https://github.com/bitcoin/bitcoin/issues/21392 | Implement BIP 8 based Speedy Trial activation by achow101 · Pull Request #21392 · bitcoin/bitcoin · GitHub 12:04 < wumpus> https://github.com/bitcoin/bitcoin/projects/8 8 blockers, 2 chasing concept ACKs right now 12:04 < sipa> i think #20861 is ready for merge 12:04 < gribble> https://github.com/bitcoin/bitcoin/issues/20861 | BIP 350: Implement Bech32m and use it for v1+ segwit addresses by sipa · Pull Request #20861 · bitcoin/bitcoin · GitHub 12:05 < dongcarl> Not enough to be a meeting topic but would like to give a quick Guix update once the meeting's over 12:05 < jnewbery> sipa: I agree 12:05 < wumpus> achow101: 21392 addded 12:05 < wumpus> sipa: good to know! will take a look 12:05 < jonatack> review beg for #20197 12:05 < gribble> https://github.com/bitcoin/bitcoin/issues/20197 | p2p: protect onions in AttemptToEvictConnection(), add eviction protection test coverage by jonatack · Pull Request #20197 · bitcoin/bitcoin · GitHub 12:06 < jonatack> repeated ACK by vasild and numerous concept acks 12:06 < sipa> jnewbery: will have a look 12:06 < sipa> eh 12:06 < sipa> jonatack: ^ 12:06 < jonatack> sipa: ty! 12:07 < wumpus> jonatack: will have a look too 12:07 < wumpus> any more suggestions for additions/removals? 12:09 < wumpus> #topic Taproot activation PRs and attempting to finalize startheight (michaelfolkson) 12:09 < core-meetingbot> topic: Taproot activation PRs and attempting to finalize startheight (michaelfolkson) 12:09 < michaelfolkson> Ok cool. So after a torturous process of many weeks (which none of us have enjoyed) I think (!) we are close on Taproot activation 12:10 < michaelfolkson> achow101 has already linked to his PR implementing Speedy Trial 12:10 -!- willcl_ark [~quassel@unaffiliated/willcl-ark/x-8282106] has quit [Remote host closed the connection] 12:10 < michaelfolkson> aj has an alternative PR https://github.com/bitcoin/bitcoin/pull/21377 12:11 < michaelfolkson> Now there is obviously the added complication of needing to finalize a startheight 12:11 < wumpus> any specific reason to have competing PRs? 12:12 < achow101> 21377 uses the MTP start and timeouts, 21392 uses height 12:12 -!- openoms_ [~quassel@91.132.136.76] has joined #bitcoin-core-dev 12:12 -!- openoms [~quassel@91.132.136.76] has quit [Ping timeout: 256 seconds] 12:12 < michaelfolkson> aj PR changes less code, uses existing BIP 9 code 12:12 -!- willcl_ark [~quassel@unaffiliated/willcl-ark/x-8282106] has joined #bitcoin-core-dev 12:12 < wumpus> right, thanks 12:13 < michaelfolkson> There is an added complication that some people seem not like to BIP 8 and so trying to get around using it (I think but I could be wrong) 12:13 < michaelfolkson> That is a sense I get (which some people have told me is wrong) 12:14 < michaelfolkson> Speedy Trial doesn't have a relaxed proposed timetable 12:14 < achow101> people seem to not like some aspects of BIP 8, but the change to heights is generally seen to be a good change 12:14 < michaelfolkson> https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2021-March/018594.html 12:14 < luke-jr> ST would be very controversial with MTP, or without a clear documentation/disclaimer 12:14 < michaelfolkson> Those are proposed dates 12:15 < achow101> no one is trying to "get around using BIP 8" because they don't like it. 21377 exists because it is a minimal change, not because MTP is better or that heights are bad. 12:15 < michaelfolkson> So we don't have much time to work with if we are going to keep to that proposed timetable 12:15 < michaelfolkson> achow101: I've got the sense that it is more than that (but as I said I've been corrected) 12:16 < jeremyrubin> I think that ST with MTP is only really controversial with activate MTP, not activate height 12:16 < achow101> michaelfolkson: the objections I've seen have been to the lockinontimeout parameter. please don't generalize that to disliking the entirety of bip 8 12:16 < jeremyrubin> It's really easy to get around the signaling periods issue by targetting a mid-signal period activate height and time 12:16 < michaelfolkson> achow101: Right but lockinontimeout is in BIP 8 12:16 < jeremyrubin> given the short timetable, mining drift will likely be minimal 12:17 < michaelfolkson> achow101: So that seems to be the only reason for disliking BIP 8 (at least in my view) 12:17 < luke-jr> achow101's proposal seems the least controversial at the moment 12:17 < jeremyrubin> s/activate height and time/start,end height and time/ 12:17 < michaelfolkson> A startheight of May 1st was proposed which doesn't leave much time 12:17 < luke-jr> michaelfolkson: it's for signalling, not activation 12:18 < achow101> michaelfolkson: it really does not matter and trying to focus on that bip number distinction is bikeshedding, a waste of time, and no one (except you) cares 12:18 < luke-jr> a release May 1 is okay with that startheight 12:18 < michaelfolkson> achow101: I don't care about it personally :) I just don't want it delaying reviewing of PR(s) 12:19 < jeremyrubin> To restate more clearly: The main reason to prefer Achow's w/ start height and time is to fix the issue of a known number of singalling periods by using heights and not times. The main reason to prefer AJ's is smaller diff. Either will work. Because of the 3 month period proposed, we can likely set times so that we have a known number of periods with high confidence. 12:19 < jeremyrubin> I don't have a preference either way 12:19 < achow101> jeremyrubin: note that 21377 has changed to using an activation height. It only uses MTP for start and timeout time 12:20 < jeremyrubin> Yep! 12:20 < michaelfolkson> luke-jr: Assuming. a release of May 1 when does the PR need to be merged by? 12:20 < michaelfolkson> I'm kind of in the dark on whether the proposed startheight of May 1st is doable 12:20 < luke-jr> michaelfolkson: typically there's at least 1 week of a RC 12:21 < luke-jr> add a few days to backport I guess 12:21 < achow101> Note that the windows signing certificate expires next week. I'm in the process of renewing it currently, but it's a process that takes some time 12:21 < jeremyrubin> achow101: my point about known periods is just that if you pick start/end heights that are mid-signaling period there's unlikely to be enough drift to cause an off-by-one in intended # of singaling. I agree that height is superior in general. 12:21 < michaelfolkson> And what needs to be done in advance of May 1st. Lots of communication to mining pools, users etc? 12:21 < achow101> so any future release will need to wait for that cert to be renewed 12:21 < jeremyrubin> and activationheight is agreed on across both proposals 12:21 < luke-jr> michaelfolkson: ST is okay because it's okay if ST fails 12:21 < wumpus> achow101: good to know 12:22 < michaelfolkson> luke-jr: Right but we want to give it as good chance as we can to succeed 12:22 < michaelfolkson> Releasing quietly and waiting until it fails shouldn't be the plan 12:22 < wumpus> achow101: i guess we have no releases planned immediately so given it cawn be resolved in a month or so it's no big deal 12:22 < jeremyrubin> I don't think we should wait for a windows signing cert personally -- I don't like the notion of Microsoft being in the way of bitcoin development 12:23 < achow101> jeremyrubin: I expect I'll have it resolved by the time we're ready to make a release anyways 12:23 < wumpus> jeremyrubin: that doesn't seem to be the case at all 12:23 < meshcollider> Is this going to be 21.1 release, not 22? 12:23 < luke-jr> jeremyrubin: we could always publish the unsigned binaries, but it'd be better to not have an odd release 12:24 < wumpus> not codesigning it will probably hinder adoption i think that would be even worse and besides there is no real hurry 12:24 < michaelfolkson> Normally competing PRs is good, gives a chance for people to pursue different approaches. Given the short timetable I'm not sure if this is as important for this. But obviously not going to ask people to only review one PR 12:25 < jeremyrubin> sure, i just don't think we should ever be in a position that we delay anything due to a third party vendor -- if signing binaries with MSFT approval opens us up to coercion, we should probably plan to deprecate that sort of signing. Let's not discuss further in this meeting though 12:25 < wumpus> please 12:26 < wumpus> there is no talk of coercion at all here, if there was i'd agree with you ,for now we have enough real issues let's not make up any 12:26 < achow101> in order to make the May 1st start time, I think we should get 0.21.1 by April 24th at the latest 12:26 < wumpus> right 12:26 < michaelfolkson> If we are going to change the proposed timetable I personally think that is ok but I can't speak for certain with all the ACKers on this if it changes *substantially* https://gist.github.com/michaelfolkson/92899f27f1ab30aa2ebee82314f8fe7f 12:27 < michaelfolkson> But it sounds like May 1st is doable which is great 12:27 < achow101> For 2 RCs, we need to get everything in by April 10th 12:27 < jeremyrubin> michaelfolkson: I don't see any concrete dates there? 12:28 < jeremyrubin> so I don't know what people are ACKing w.r.t. a timeline 12:28 < michaelfolkson> If anyone has concerns though about this timetable please raise them. Personally I think a delay of a few weeks would be ok 12:28 < achow101> Since this requires backport, I think having the PRs merged to master by April 3rd is the latest 12:28 < achow101> then a week for backport 12:28 < achow101> then RC1 and so on 12:28 < michaelfolkson> jeremyrubin: They are ACKing the proposal 12:28 < wumpus> so the real bottleneck is trusting the code enough to merge it (including the backport), it is better to not split reviewers over multiple PRs if possible 12:29 < achow101> indeed 12:29 < wumpus> maybe two competing approaches is fine but let's not open more :-) 12:29 < michaelfolkson> wumpus: Personally I would agree. I also don't want it to be rushed. If the timetable needs to be pushed back I think that is ok 12:29 < michaelfolkson> But if we can avoid that it would be great 12:30 < jeremyrubin> michaelfolkson: I just don't see a specific startheight/startime in the proposal 12:30 < wumpus> aiming for april 3 sgtm 12:30 < luke-jr> I opened a PR with just the height/user-facing stuff, but it already conflicts between 0.21 and master, so I'm not sure it gains anything over just reviewing+merging achow's as-is 12:30 < sipa> 2 weeks (tm) 12:30 < wumpus> it is short time though 12:30 < luke-jr> let's aim for March 25th then 12:30 < luke-jr> :P 12:30 < michaelfolkson> jeremyrubin: Good point. The dates were in a follow up email https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2021-March/018594.html 12:30 < jeremyrubin> michaelfolkson: so I'm not sure what timetable you think is being ackd 12:30 < sipa> let's just focus on code review 12:30 < jeremyrubin> Gotcha, but it's unclear that was ACKd. My read is people ACKd the general shape of it 12:31 < sipa> let me know what to look at 12:31 < wumpus> we should probably delay merging anything that conflicts 12:31 < michaelfolkson> jeremyrubin: That's fair challenge 12:31 < jeremyrubin> so I think it's fine for core to pick reasonable times 12:31 < meshcollider> #21392 12:31 < gribble> https://github.com/bitcoin/bitcoin/issues/21392 | Implement BIP 8 based Speedy Trial activation by achow101 · Pull Request #21392 · bitcoin/bitcoin · GitHub 12:31 < meshcollider> FWIW I don't think the size of the diff of achow101's version is really an issue ^ 12:31 < amiti> my two cents: I don't think either PR is close to being RFM, both need significantly more review. looks like 21392 is currently failing CI. If the goal is to quickly merge with safety, I think 21377 makes more sense (as I stated on the PR) 12:31 < wumpus> having to rebase the PR all the time will not make it getting through review easier, after all 12:31 < amiti> the diff is much smaller and mostly tests 12:32 < wumpus> amiti: +1 12:32 < luke-jr> amiti: consensus comes first 12:32 < achow101> the ci failure on 21392 should be fixed now 12:33 < amiti> achow101: cool, and I'm not opposed to 21392, I'm just saying its a bigger patch requires more review. 12:34 < michaelfolkson> I know I sound like a broken record but BIP 8 has been updated and BIP 9 is "dead" according to one of the authors. So from a BIP perspective BIP 8 would be easier. I get amiti's argument that code diff wise AJ's smaller 12:34 < jeremyrubin> I don't think "BIP9 is dead" is useful here 12:34 < jeremyrubin> the code works fine 12:34 < michaelfolkson> Code is most important 12:34 < amiti> michaelfolkson: I don't think it makes sense to fixate on the associated bip number. the main difference between these two PRs are using block height vs MTP 12:35 < jeremyrubin> the property that achow101's PR improves is a fixed # of signals 12:35 < achow101> it comes down to mtp vs block height 12:35 < michaelfolkson> amiti: I think there is consensus on block height from what I've seen 12:35 < jeremyrubin> The question is if it is worth addtl review on new code. 12:35 < jeremyrubin> I agree that height is superior long term 12:35 < michaelfolkson> (but there are still a lot of reviewers who haven't looked at it yet) 12:35 < amiti> micahelfolkson: I don't think you can claim that there is consensus on either, neither patch has been thoroughly reviewed 12:35 < achow101> with mtp, we run the risk of losing 2 signaling periods. with already few signaling periods, this has the possibility of failng to activate due to bad luck 12:35 < luke-jr> jeremyrubin: without height, ST doesn't have community support 12:36 < achow101> amiti: consensus on the concept 12:36 < jeremyrubin> But it's important to mind that for ST, it's a very short window of time (3 months) so by targetting a mid-period we have a known # of signals with high confidence 12:36 < luke-jr> amiti: consensus has nothing to do with review 12:36 < michaelfolkson> amiti: I'm only basing it on what I've seen in discussions and meetings. I personally don't have a (strong) view 12:36 < michaelfolkson> We've had meetings with a number of Core contributors showing up and discussing it 12:36 < jeremyrubin> achow101: the risk is tiny with MTP if you target mid signal periods, and only the last one matters 12:37 < michaelfolkson> Deliberately off this channel so as not to block this channel for weeks/months 12:37 < jeremyrubin> (is my point about mid period times falling on deaf ears?) 12:37 < jeremyrubin> you would need a super large hashrate shift to happen, and then we'd have bigger problems 12:37 < jonatack> will review both soon 12:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:38 < bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/a65e772fec62...8ec881d3b694 12:38 < bitcoin-git> bitcoin/master da2bb69 Pieter Wuille: Implement Bech32m encoding/decoding 12:38 < bitcoin-git> bitcoin/master 25b1c6e Pieter Wuille: Add Bech32m test vectors 12:38 < bitcoin-git> bitcoin/master fe5e495 Pieter Wuille: Use Bech32m encoding for v1+ segwit addresses 12:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:38 < sipa> \o/ 12:38 < jnewbery> yay! 12:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:38 < bitcoin-git> [bitcoin] laanwj merged pull request #20861: BIP 350: Implement Bech32m and use it for v1+ segwit addresses (master...202101_bech32m) https://github.com/bitcoin/bitcoin/pull/20861 12:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:38 < jnewbery> thanks wumpus 12:38 < wumpus> \o/ 12:38 < achow101> jeremyrubin: I get that, but both start and end matter. 12:38 < jonatack> b-b-b-bech32mmmmmm 12:38 < michaelfolkson> jeremyrubin: I think that would be a material change to the proposal 12:38 < glozow> :M: 12:39 < achow101> jeremyrubin: that would move the start time to april 24th, which also affects our timelin for merging things 12:39 < jnewbery> is the conclusion to this conversation going to be that people should review PRs? 12:39 < achow101> I guess we could just ignore that first half-period 12:39 < wumpus> so summary re: taproot activation: aim for april 3 for 0.21.1rc1, review both PRs asap, please hold up merging conflicting PRs for now 12:39 < jeremyrubin> achow101: exactly... it can't hit threshold anyways 12:40 -!- cguida1 [~Adium@2806:2f0:51c1:5cee:41d1:9092:8e63:5d71] has joined #bitcoin-core-dev 12:40 < jnewbery> wumpus: sounds good! 12:40 < michaelfolkson> Right, agreed jnewbery wumpus 12:40 < amiti> wumpus: sounds good :) 12:40 < wumpus> if we can make a decision between the two PRs quickly that would be even better 12:41 < wumpus> and allow focusing attention, but obviously that shouldn't be done in the meeting 12:42 < michaelfolkson> Yup 12:42 < luke-jr> only one of them is socially viable anyway.. 12:42 < wumpus> any other topics? 12:42 < amiti> also want to quickly mention #21380, adds fuzz tests to version bits, useful coverage whichever PR/technique we go with 12:42 < gribble> https://github.com/bitcoin/bitcoin/issues/21380 | tests: Add fuzzing harness for versionbits by ajtowns · Pull Request #21380 · bitcoin/bitcoin · GitHub 12:42 < achow101> dongcarl had one? 12:42 < michaelfolkson> amiti: Cool 12:43 < luke-jr> achow101: I think he wanted to do it after the meeting tho 12:43 -!- cguida [~Adium@2806:2f0:51c1:5cee:e8b7:2427:f328:897b] has quit [Ping timeout: 265 seconds] 12:43 < wumpus> achow101: but for after the meeting he said 12:43 < wumpus> yea 12:43 < dongcarl> Just a quick Guix update once everyone's done discussing :-) 12:43 < wumpus> amiti: good point 12:44 < midnight> \o/ also! 12:44 < wumpus> #endmeeting 12:44 < core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt 12:44 < core-meetingbot> Meeting ended Thu Mar 18 19:44:39 2021 UTC. 12:44 < core-meetingbot> Minutes: https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2021/bitcoin-core-dev.2021-03-18-19.00.moin.txt 12:44 < dongcarl> Here's my quick Guix update: 12:44 < dongcarl> Originally, I planned to build things heads-down for 5 wks (ending today) then do user-testing + refinement for 5 weeks (ending on April 22nd). /1 12:44 < dongcarl> However, many of you were eager enough to test my half-baked scripts, and I’m actually glad we did it this way because many pitfalls were discovered and fixed along the way (see #21375)! Thanks all! /2 12:44 < dongcarl> So the new plan (operation “roll-with-it”) is this: we do the building + user testing for 4 more weeks (ending on April 15th), and after that we’ll agree on a commit on which to perform a non-codesigned build and upload signatures to `guix.sigs`. /3 12:45 < gribble> https://github.com/bitcoin/bitcoin/issues/21375 | guix: Misc feedback-based fixes + hier restructuring by dongcarl · Pull Request #21375 · bitcoin/bitcoin · GitHub 12:45 < dongcarl> I will update the umbrella ticket with this updated timeline today. This does not eat into our 4 week contingency buffer period 12:46 < achow101> dongcarl: cool! 12:46 < hebasto> nice 12:46 < sipa> sgtm, i'm all set up 12:46 < dongcarl> :-) 12:46 < achow101> I'll start testing after taproot stuff is merged :) 12:46 < dongcarl> Thanks again all for testing! 12:48 < jnewbery> dongcarl: thanks for the update. Very impressive that you're making such great progress with guix _and_ on #20158 12:48 < gribble> https://github.com/bitcoin/bitcoin/issues/20158 | tree-wide: De-globalize ChainstateManager by dongcarl · Pull Request #20158 · bitcoin/bitcoin · GitHub 12:48 < jonatack> dongcarl: nice! haven't dove into it yet but looking forward 12:48 < dongcarl> jnewbery: :-) Hehe thanks John! 12:48 < dongcarl> jonatack: Reach out any time if you run into anything! 12:51 -!- jonatack_ [~jon@37.173.214.42] has joined #bitcoin-core-dev 12:52 -!- jonatack [~jon@37.164.254.128] has quit [Ping timeout: 245 seconds] 12:53 < wumpus> dongcarl: sounds great to me! 12:53 < jonatack_> dongcarl: (whoops lost the connection) thanks! seems to be the culmination of quite a bit of work leading to this point, so good to see! 12:53 < wumpus> i've been doing regular guix builds of master and PRs and it seems to work quite smoothly now 12:54 < dongcarl> wumpus: Glad to hear it! 12:54 < achow101> dongcarl: has the gnutls problem been fixed in a release yet? 12:55 < dongcarl> achow101: Not yet, I think upstream is coordinating one soon. I will post on the mailing list again to ask for an update. 12:56 < dongcarl> See it as... Very temporary incentive to bootstrap Guix from source XP 12:56 < achow101> ugh 12:56 < sipa> or enable substitutes for just gnutls *ducks* 12:58 < hebasto> dongcarl: any update on non-determinism issue for macos builds? 12:58 < dongcarl> hebasto: see #bitcoin-builds 12:58 < dongcarl> or reset your system time *ducks* 12:59 -!- Arvidt [~Arvidt@gateway/tor-sasl/arvidt] has left #bitcoin-core-dev [] 13:01 < sipa> wumpus: how do you use the backport.py script? 13:01 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 13:03 < aj> MarcoFalke: are we at "->soon" for 21380 yet? 13:04 -!- OP_NOP [OP_NOP@gateway/vpn/privateinternetaccess/opnop/x-41418994] has quit [Ping timeout: 260 seconds] 13:09 < wumpus> sipa: run it from the repository directory, easiest is to pass the PR numbers on the command line 13:10 < wumpus> sipa: with the branch checked out you want to backport to 13:11 < sipa> that's what i assumed, but it says: Missing: [...] 13:11 < wumpus> what is the exact command line you are giving? 13:11 < sipa> doesn't matter, #20861 isn't a trivial backport anyway 13:11 < gribble> https://github.com/bitcoin/bitcoin/issues/20861 | BIP 350: Implement Bech32m and use it for v1+ segwit addresses by sipa · Pull Request #20861 · bitcoin/bitcoin · GitHub 13:11 < wumpus> mind that you have to specify the PR number without # as that makes it a comment :) 13:12 < wumpus> also, make sure the 'master' branch is up to date and has that PR 13:12 < sipa> i did: ~/git/bitcoin-maintainer-tools/backport.py 20861 13:15 < wumpus> maybe `git fetch origin master:master` to make sure your repository's master branch is up to date (even if you are on the 0.21 branch) 13:17 < hebasto> wumpus: luke-jr: I'll appreciate your opinion on #21465 :) 13:17 < gribble> https://github.com/bitcoin/bitcoin/issues/21465 | translation: Provide more context to Transifex translators · Issue #21465 · bitcoin/bitcoin · GitHub 13:19 < wumpus> i will have a look 13:19 < hebasto> wumpus: thanks 13:25 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 13:31 < wumpus> hebasto: sorry, i think some of the changes are a bit questionable/unnecessary, fine to let other people weigh in i don't have strong opinions about it but you asked me explicitly :) 13:31 -!- Chris_St1 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 256 seconds] 13:33 -!- Chris_St1 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 13:38 < hebasto> wumpus: I was talking about 21465, not #21463... 13:38 < gribble> https://github.com/bitcoin/bitcoin/issues/21463 | doc: Address feedback from Transifex translator community by hebasto · Pull Request #21463 · bitcoin/bitcoin · GitHub 13:39 < hebasto> anyway, thanks for your feedback on 21463 13:48 -!- S3RK_ [~S3RK@213.55.245.6] has joined #bitcoin-core-dev 13:49 -!- S3RK [~S3RK@213.55.241.122] has quit [Ping timeout: 246 seconds] 13:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:54 < bitcoin-git> [bitcoin] sipa opened pull request #21469: Implement Bech32m encoding/decoding (0.21 backport) (0.21...202103_bech32m_0.21) https://github.com/bitcoin/bitcoin/pull/21469 13:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:55 -!- S3RK_ [~S3RK@213.55.245.6] has quit [Ping timeout: 264 seconds] 13:55 -!- S3RK [~S3RK@213.55.241.127] has joined #bitcoin-core-dev 13:59 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev 14:18 < wumpus> hebasto: oh, yes, will take a look at that one too, I assumed it was the one you just opened 14:22 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 14:26 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 264 seconds] 14:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:26 < bitcoin-git> [bitcoin] sipa opened pull request #21470: Implement Bech32m encoding/decoding (0.20 backport) (0.20...202103_bech32m_0.20) https://github.com/bitcoin/bitcoin/pull/21470 14:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:28 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Ping timeout: 268 seconds] 14:29 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev 14:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:30 < bitcoin-git> [bitcoin] sipa opened pull request #21471: bugfix: fix bech32_encode calls in gen_key_io_test_vectors.py (master...202103_bech32m_fix_genscript) https://github.com/bitcoin/bitcoin/pull/21471 14:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:45 < bitcoin-git> [bitcoin] sipa opened pull request #21472: BIP 350: Implement Bech32m and use it for v1+ segwit addresses (0.19 backport) (0.19...202103_bech32m_0.19) https://github.com/bitcoin/bitcoin/pull/21472 14:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:49 -!- einyx [einyx@fsf/member/einyx] has quit [Ping timeout: 246 seconds] 14:50 -!- einyx [einyx@fsf/member/einyx] has joined #bitcoin-core-dev 14:52 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Ping timeout: 246 seconds] 14:53 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 14:54 -!- gleb2 [~gleb@178.150.137.228] has joined #bitcoin-core-dev 14:54 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Remote host closed the connection] 14:55 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 14:57 -!- gleb [~gleb@178.150.137.228] has quit [Ping timeout: 264 seconds] 14:57 -!- gleb2 is now known as gleb 14:58 -!- so [~so@unaffiliated/so] has quit [Ping timeout: 246 seconds] 14:59 -!- so [~so@unaffiliated/so] has joined #bitcoin-core-dev 15:00 -!- commavir [~vir@23.226.237.192] has quit [Ping timeout: 264 seconds] 15:00 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has quit [Remote host closed the connection] 15:00 -!- commavir [~vir@23.226.237.192] has joined #bitcoin-core-dev 15:00 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has joined #bitcoin-core-dev 15:06 < luke-jr> hebasto: I guess it's a good idea; but might be a good idea to ask Transifex to support it in TS files first? 15:09 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Ping timeout: 268 seconds] 15:12 -!- spinza [~spin@102.132.245.16] has quit [Ping timeout: 256 seconds] 15:16 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 15:18 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev 15:18 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev 15:20 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Remote host closed the connection] 15:21 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev 15:21 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has quit [Remote host closed the connection] 15:21 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has joined #bitcoin-core-dev 15:30 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 260 seconds] 15:31 < hebasto> luke-jr: they have a paid service for fork flow with XLIFF 15:31 < hebasto> "Translate using XLIFF files as an intermediate format if you’re working with professional translators" -- https://www.transifex.com/pricing/ 15:31 < hebasto> *for work 15:32 < luke-jr> wait, we'd need to pay to use it? 15:32 < hebasto> no 15:33 < hebasto> conversion on their side is paid -- "File conversion to XLIFF format is only available on the Premium plan and up." 15:33 < hebasto> suggesting conversion on our side 15:33 < luke-jr> i c 15:48 -!- very_sneaky [~very_snea@45.67.96.48] has joined #bitcoin-core-dev 15:50 -!- very_sneaky [~very_snea@45.67.96.48] has quit [Remote host closed the connection] 15:55 -!- larryruane_ [uid473749@gateway/web/irccloud.com/x-etkneexubbqqgdwq] has quit [Quit: Connection closed for inactivity] 16:10 -!- jonatack_ [~jon@37.173.214.42] has quit [Ping timeout: 240 seconds] 16:24 -!- very_sneaky [~very_snea@45.67.96.48] has joined #bitcoin-core-dev 16:40 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has quit [Remote host closed the connection] 16:41 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has joined #bitcoin-core-dev 16:42 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has quit [Max SendQ exceeded] 16:42 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has joined #bitcoin-core-dev 16:43 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has quit [Remote host closed the connection] 16:44 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has joined #bitcoin-core-dev 16:44 -!- lightlike [~lightlike@p200300c7ef1e930039155a25f8e4eaba.dip0.t-ipconnect.de] has quit [Quit: Leaving] 16:44 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has quit [Remote host closed the connection] 16:45 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has joined #bitcoin-core-dev 16:46 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has quit [Max SendQ exceeded] 16:46 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has joined #bitcoin-core-dev 16:56 -!- stortz [c8b9cbcf@200.185.203.207] has joined #bitcoin-core-dev 17:01 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has quit [Remote host closed the connection] 17:02 -!- rc_423 [~r_423@cpe-75-185-100-189.cinci.res.rr.com] has joined #bitcoin-core-dev 17:04 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Remote host closed the connection] 17:05 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev 17:16 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev 17:17 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Remote host closed the connection] 17:17 -!- miketwenty1 [~miketwent@136.55.84.49] has joined #bitcoin-core-dev 17:17 -!- miketwenty1 [~miketwent@136.55.84.49] has quit [Client Quit] 17:24 -!- very_sneaky [~very_snea@45.67.96.48] has quit [Ping timeout: 246 seconds] 17:29 -!- ogo [~ogo@gateway/tor-sasl/ogo] has quit [Quit: Leaving] 18:09 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 18:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:16 < bitcoin-git> [bitcoin] fkorotkov opened pull request #21473: [ci] Use regular containers (master...patch-3) https://github.com/bitcoin/bitcoin/pull/21473 18:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:44 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 18:50 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 18:55 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds] 19:09 -!- stortz [c8b9cbcf@200.185.203.207] has quit [Quit: Connection closed] 19:31 -!- willmoffat [~willmoffa@37.120.211.188] has quit [Remote host closed the connection] 19:46 -!- tvn [~tvn@195.140.213.38] has joined #bitcoin-core-dev 19:58 -!- Janty [d06833a3@208.104.51.163] has joined #bitcoin-core-dev 20:32 -!- marcelo [~marcelo@251-45-231-201.fibertel.com.ar] has joined #bitcoin-core-dev 20:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 20:33 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8ec881d3b694...47d79c941abc 20:33 < bitcoin-git> bitcoin/master 5c0210e Pieter Wuille: bugfix: fix bech32_encode calls in gen_key_io_test_vectors.py 20:33 < bitcoin-git> bitcoin/master 47d79c9 fanquake: Merge #21471: bugfix: fix bech32_encode calls in gen_key_io_test_vectors.p... 20:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 20:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 20:33 < bitcoin-git> [bitcoin] fanquake merged pull request #21471: bugfix: fix bech32_encode calls in gen_key_io_test_vectors.py (master...202103_bech32m_fix_genscript) https://github.com/bitcoin/bitcoin/pull/21471 20:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 20:35 -!- mol_ [mol@gateway/vpn/protonvpn/molly] has joined #bitcoin-core-dev 20:38 -!- mol [mol@gateway/vpn/protonvpn/molly] has quit [Ping timeout: 264 seconds] 20:44 -!- oozebroo- [~oozebrood@bishop.xerrero.com] has joined #bitcoin-core-dev 20:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 20:54 -!- marcelo [~marcelo@251-45-231-201.fibertel.com.ar] has quit [Quit: marcelo] 20:54 -!- mgbtcc [~marcelo@251-45-231-201.fibertel.com.ar] has joined #bitcoin-core-dev 21:02 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection] 21:03 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev 21:06 -!- mgbtcc [~marcelo@251-45-231-201.fibertel.com.ar] has quit [Quit: mgbtcc] 21:17 -!- prayank [~andr0irc@2401:4900:30d0:b453:d900:b6f0:db5d:cd1c] has joined #bitcoin-core-dev 21:20 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 21:22 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 256 seconds] 21:25 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds] 21:33 -!- jespada [~jespada@90.254.243.187] has quit [Ping timeout: 245 seconds] 21:36 -!- jespada [~jespada@90.254.243.187] has joined #bitcoin-core-dev 22:01 -!- oozebroo- [~oozebrood@bishop.xerrero.com] has quit [Quit: ZNC 1.8.2 - https://znc.in] 22:03 -!- oozebroo- [~oozebrood@bishop.xerrero.com] has joined #bitcoin-core-dev 22:15 -!- oozebroo- [~oozebrood@bishop.xerrero.com] has quit [Quit: ZNC 1.8.2 - https://znc.in] 22:16 -!- oozebroo- [~oozebrood@bishop.xerrero.com] has joined #bitcoin-core-dev 22:18 -!- oozebroo- [~oozebrood@bishop.xerrero.com] has quit [Client Quit] 22:20 -!- oozebroo- [~oozebrood@bishop.xerrero.com] has joined #bitcoin-core-dev 22:23 -!- oozebroo- [~oozebrood@bishop.xerrero.com] has quit [Client Quit] 22:27 -!- oozebrood [oozebrood@2600:3c03::f03c:91ff:fe18:53af] has quit [Quit: ZNC 1.7.x-nightly-20160720-f1ef8c79 - http://znc.in] 22:55 -!- tvn [~tvn@195.140.213.38] has quit [Remote host closed the connection] 23:13 -!- jungly [~jungly@host-82-53-131-133.retail.telecomitalia.it] has joined #bitcoin-core-dev 23:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 23:55 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 264 seconds] 23:59 -!- jungly [~jungly@host-82-53-131-133.retail.telecomitalia.it] has quit [Ping timeout: 264 seconds] --- Log closed Fri Mar 19 00:00:00 2021