--- Log opened Thu Apr 15 00:00:26 2021 00:01 -!- adiabat_ [~adiabat@63.209.32.102] has joined #bitcoin-core-dev 00:02 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev 00:10 -!- mrostecki [mrostecki@nat/suse/x-dsxgooamcbgldcek] has quit [Quit: WeeChat 1.8] 00:14 < provoostenator> luke-jr: if you're still adament about a BIP 8 speedy trial, rebasing #21392 would seem more productive than reverting #21377 00:14 < gribble> https://github.com/bitcoin/bitcoin/issues/21392 | Implement BIP 8 based Speedy Trial activation by achow101 · Pull Request #21392 · bitcoin/bitcoin · GitHub 00:14 < gribble> https://github.com/bitcoin/bitcoin/issues/21377 | Speedy trial support for versionbits by ajtowns · Pull Request #21377 · bitcoin/bitcoin · GitHub 00:16 < provoostenator> Because even if you loose that argument, the PR will be useful if we want future softforks to use (parts of) BIP 8. 00:16 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 00:17 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 00:17 < provoostenator> Though there is the downside of not being able to burry BIP 9 forks as a whole for a while. 00:21 -!- jespada [~jespada@90.254.243.187] has quit [Quit: Sleeping] 00:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:21 < bitcoin-git> [bitcoin] jonatack opened pull request #21690: test: use higher value in cnetaddr_basic link-local test (master...cnetaddr-link-local-test) https://github.com/bitcoin/bitcoin/pull/21690 00:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:26 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 00:44 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection] 00:44 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev 00:46 -!- harrigan [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has quit [Read error: Connection reset by peer] 00:46 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has joined #bitcoin-core-dev 00:48 -!- harrigan- [~harrigan@ptr-93-89-242-235.ip.airwire.ie] has joined #bitcoin-core-dev 00:51 -!- harrigan [~harrigan@ptr-93-89-242-202.ip.airwire.ie] has quit [Ping timeout: 246 seconds] 00:54 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Ping timeout: 260 seconds] 00:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:57 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #21691: test: Check that no versionbits are re-used (master...2104-testVersionbits) https://github.com/bitcoin/bitcoin/pull/21691 00:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:07 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/9712f75746e3...a5e756b74e18 01:07 < bitcoin-git> bitcoin/master fa78590 MarcoFalke: test: Use mocktime to avoid intermittent failure 01:07 < bitcoin-git> bitcoin/master fa40d6a MarcoFalke: test: Reset mocktime in the common setup 01:07 < bitcoin-git> bitcoin/master a5e756b MarcoFalke: Merge #21676: test: Use mocktime to avoid intermittent failure in rpc_test... 01:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:07 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #21676: test: Use mocktime to avoid intermittent failure in rpc_tests (master...2104-testFixMocktime) https://github.com/bitcoin/bitcoin/pull/21676 01:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:09 -!- asdlkfjwerpoicvx [~flack@p200300d46f1691000cf60444e69d2bad.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 01:14 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection] 01:14 -!- gzg [~gzg@79.112.37.189] has joined #bitcoin-core-dev 01:14 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 01:14 -!- gzg [~gzg@79.112.37.189] has quit [Client Quit] 01:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:20 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a5e756b74e18...7cb0bcb68110 01:20 < bitcoin-git> bitcoin/master f979b32 Andrew Chow: Add mainnet and testnet taproot activation params 01:20 < bitcoin-git> bitcoin/master 7cb0bcb MarcoFalke: Merge #21686: Speedy trial activation parameters for Taproot 01:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:20 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev 01:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:21 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #21686: Speedy trial activation parameters for Taproot (master...taproot-mtp-st-params) https://github.com/bitcoin/bitcoin/pull/21686 01:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:35 < jnewbery> \o/ 01:36 < jnewbery> We now have a client that can enforce taproot rules on mainnet. Huge thanks to everyone who helped us get here. Now lets put it in front of users :) 01:39 -!- jespada [~jespada@90.254.243.187] has joined #bitcoin-core-dev 01:40 -!- looy [55a4cbf6@ti0185a400-2540.bb.online.no] has joined #bitcoin-core-dev 01:42 -!- looy [55a4cbf6@ti0185a400-2540.bb.online.no] has quit [Client Quit] 01:43 < robert_spigler> Thank you everyone for all your hard work! 01:47 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 01:47 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:50 < bitcoin-git> [bitcoin] MarcoFalke pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/7cb0bcb68110...c6b30ccb2eee 01:50 < bitcoin-git> bitcoin/master 5198a02 Vasil Dimov: style: remove extra white space 01:50 < bitcoin-git> bitcoin/master 0c90ff1 Vasil Dimov: fuzz: set errno from FuzzedSock::Wait() if it simulates a failure 01:50 < bitcoin-git> bitcoin/master 9668e43 Vasil Dimov: fuzz: make FuzzedSock::Wait() sometimes simulate an occurred event 01:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:51 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #21630: fuzz: split FuzzedSock interface and implementation (master...FuzzedSock_move) https://github.com/bitcoin/bitcoin/pull/21630 01:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:13 -!- aqua42 [~aqua42@amsterdam3.jp.net] has quit [Ping timeout: 260 seconds] 02:19 -!- mars [~niamh@aaubervilliers-654-1-61-83.w86-218.abo.wanadoo.fr] has joined #bitcoin-core-dev 02:41 -!- mrostecki [mrostecki@nat/suse/x-xbaoykqszzoacevo] has joined #bitcoin-core-dev 02:53 -!- Bhk [9681a60e@150.129.166.14] has joined #bitcoin-core-dev 02:54 -!- Bhk [9681a60e@150.129.166.14] has quit [Client Quit] 03:18 -!- Kirstin38Mitchel [~Kirstin38@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev 03:42 -!- IGHOR [~quassel@176.121.4.135] has quit [Quit: No Ping reply in 180 seconds.] 03:43 -!- IGHOR [~quassel@176.121.4.135] has joined #bitcoin-core-dev 03:45 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Remote host closed the connection] 03:46 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has joined #bitcoin-core-dev 03:50 -!- jadi [~jadi@37.98.3.133] has joined #bitcoin-core-dev 03:50 < hebasto> wumpus: I cannot see any way how the `contrib/bitcoin-qt.pro` is used in the translation process, neither in the main repo nor in https://github.com/bitcoin-core/bitcoin-maintainer-tools. Besides it looks outdated and unmaintained. May I ask you to confirm/deny my assumption? 04:16 -!- Kirstin38Mitchel [~Kirstin38@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 265 seconds] 05:06 < wumpus> hebasto: it is not used for anything, it exists to be able to edit the qt forms in qt designer nothing more 05:07 < wumpus> i'm not sure if it is even *necessary* for that, but it is why it is there 05:08 < hebasto> wumpus: thanks, qt designer does not need *.pro file at all 05:08 < hebasto> maybe qt creator does 05:09 < wumpus> feel free to create a PR to remove it, best way to find out if someone wants to keep it, you are right it hasn't been updated in a long time 05:09 < hebasto> ok 05:09 < wumpus> fwiw, the only question i get about it ever is why it exists 05:10 < hebasto> it was in use with `qmake` years ago (what I found digging into the repo history) 05:11 < wumpus> yes, that was the original reason, but when we switched to automake it was kept around for use w/ qt's GUI tools 05:12 < hebasto> I've noticed it in https://github.com/bitcoin/bitcoin/blame/master/doc/translation_process.md#L25 05:16 -!- aqua42 [~aqua42@amsterdam3.jp.net] has joined #bitcoin-core-dev 05:21 < wumpus> what it says there is definitely not true anymore 05:21 < hebasto> I'll submit a pr 05:21 < wumpus> thanks! 05:24 -!- Kiminuo [~Kiminuo@185.216.35.121] has joined #bitcoin-core-dev 05:25 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 05:27 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 252 seconds] 05:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:28 < bitcoin-git> [bitcoin] hebasto opened pull request #21694: build: Use XLIFF file to provide more context to Transifex translators (master...210415-xliff) https://github.com/bitcoin/bitcoin/pull/21694 05:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:43 -!- Kiminuo [~Kiminuo@185.216.35.121] has quit [Ping timeout: 240 seconds] 05:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:46 < bitcoin-git> [bitcoin] hebasto opened pull request #21695: Remove no longer used contrib/bitcoin-qt.pro from the repo (master...210415-pro) https://github.com/bitcoin/bitcoin/pull/21695 05:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:46 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 05:56 -!- ogo [~ogo@gateway/tor-sasl/ogo] has quit [Remote host closed the connection] 05:56 -!- ogo [~ogo@gateway/tor-sasl/ogo] has joined #bitcoin-core-dev 06:00 -!- ogo [~ogo@gateway/tor-sasl/ogo] has quit [Remote host closed the connection] 06:01 -!- ogo [~ogo@gateway/tor-sasl/ogo] has joined #bitcoin-core-dev 06:03 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 06:05 -!- jadi [~jadi@37.98.3.133] has quit [Ping timeout: 268 seconds] 06:06 -!- ogo [~ogo@gateway/tor-sasl/ogo] has quit [Remote host closed the connection] 06:07 -!- ogo [~ogo@gateway/tor-sasl/ogo] has joined #bitcoin-core-dev 06:07 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 252 seconds] 06:08 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Ping timeout: 240 seconds] 06:09 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev 06:13 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev 06:16 -!- ogo [~ogo@gateway/tor-sasl/ogo] has quit [Remote host closed the connection] 06:16 -!- ogo [~ogo@gateway/tor-sasl/ogo] has joined #bitcoin-core-dev 06:20 -!- ogo [~ogo@gateway/tor-sasl/ogo] has quit [Remote host closed the connection] 06:21 -!- ogo [~ogo@gateway/tor-sasl/ogo] has joined #bitcoin-core-dev 06:33 -!- gimps [~gimps@185.169.233.12] has quit [Remote host closed the connection] 06:39 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-mkeozeabwxqrpqhd] has quit [Quit: Connection closed for inactivity] 06:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:54 < bitcoin-git> [bitcoin] jonatack opened pull request #21696: DONOTMERGE test: drop cnetaddr link-local assert for macOS 10.14 to re-verify CI (master...cnetaddr-link-local-test-1) https://github.com/bitcoin/bitcoin/pull/21696 06:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:58 < bitcoin-git> [bitcoin] jonatack opened pull request #21697: DONOTMERGE test: drop cnetaddr link-local assert for all CIs except macOS 10.14 (master...cnetaddr-link-local-test-2) https://github.com/bitcoin/bitcoin/pull/21697 06:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:00 < bitcoin-git> [bitcoin] fanquake closed pull request #21697: DONOTMERGE test: drop cnetaddr link-local assert for all CIs except macOS 10.14 (master...cnetaddr-link-local-test-2) https://github.com/bitcoin/bitcoin/pull/21697 07:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:01 < jonatack> fanquake: I was going to close after the CI results. 07:01 < fanquake> why did you open two 07:02 < jonatack> fanquake: they test different things. wasn't going to open any further ones. two is enough 07:02 < jonatack> i guess it looked like a rampage hehe 07:02 < fanquake> The diff is identical 07:02 < fanquake> what are they testing differently? 07:03 < jonatack> not identical, they are intended to re-verify that one assert passes only the macOS 10.14 CI and the other one passes all the other CIs but not the macOS 10.14 one 07:04 < fanquake> I see. Can't this be tested in #21690 then? 07:04 < gribble> https://github.com/bitcoin/bitcoin/issues/21690 | test: use higher value in cnetaddr_basic link-local test by jonatack · Pull Request #21690 · bitcoin/bitcoin · GitHub 07:04 < fanquake> I don't see why we need 3 separate PRs. 07:04 < jonatack> this was the case last October. Before improving the documentation on the context, I wanted to re-verify to be sure it was still the case. 07:06 < jonatack> yes, sorry. can they just run and i'll re-close 07:11 < vasild> I am using my personal fork at https://github.com/vasild/bitcoin/pull/4/ for CI "experiments" 07:12 < jonatack> I used to run them on my own travis, but that is no longer. I've seen DONOTMERGE PRs done before to test CI results so I didn't think it was an issue. 07:15 < vasild> why is it no longer? 07:15 < jonatack> travis shut it down. are you using a paid travis account? (maybe i am missing something) 07:16 < vasild> ah, yes, travis is no longer, but I have free cirrus account for open source and linked it to https://github.com/vasild/bitcoin 07:17 < vasild> I think it operates as well as the cirrus hooked on the main repo, may be slower and have less concurrent jobs, but that is fine since I am the only one using it (occassionally) 07:17 < jonatack> ah! good to know 07:35 < luke-jr> provoostenator: MarcoFalke already blocked me from doing so; I have no reason to expect decent behaviour from devs strongarming BIP9 back in at this point anyway. Something is clearly going on behind the scenes. 07:40 < luke-jr> provoostenator: after all, it had plenty of review and was RTM weeks before this BIP9 stuff, and still wasn't merged anyway 07:43 -!- tlyu [~tlyu@178.239.168.171] has joined #bitcoin-core-dev 07:48 -!- davterra [~davterra@gateway/tor-sasl/tralfaz] has quit [Quit: Leaving] 07:54 < michaelfolkson> Anyone know the rationale for moving the start time a week earlier (April 24th) than Russell originally proposed (May 1st)? https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2021-March/018594.html 07:55 < michaelfolkson> If you do can you provide a link to that discussion? Thanks 07:56 < luke-jr> that ensures the height chosen is more stable on May 1st, and harder for miners to manipulate 07:57 < luke-jr> ultimately BIP9 uses starttime to choose a height based on difficulty-period boundaries (2 weeks long) 07:57 < luke-jr> it doesn't use the time directly 07:57 < michaelfolkson> Ah gotcha, makes sense. Thanks 08:11 < MarcoFalke> luke-jr: Not sure what you mean with "blocked". I am happy to reopen the pull I closed earlier today. I just think that it doesn't qualify for "high priority for review" 08:13 < luke-jr> MarcoFalke: I mean I can't rebase it with it closed. 08:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:14 < bitcoin-git> [bitcoin] MarcoFalke reopened pull request #19573: Replace unused BIP 9 logic with draft BIP 8 (master...bip8) https://github.com/bitcoin/bitcoin/pull/19573 08:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:14 < MarcoFalke> luke-jr: ^ 08:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:15 < bitcoin-git> [bitcoin] vasild opened pull request #21700: net: expand Sock and fuzz-test more of CConnman (master...Sock_expand) https://github.com/bitcoin/bitcoin/pull/21700 08:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:17 < luke-jr> thanks. but I'm not sure there's any point if the BIP9-pushing group is going to prevent a merge 08:20 < luke-jr> actually, this has LOT=True support and such too. Maybe it makes sense to close it anyway, and just reopen heights separately (when/if the issue of merging it gets resolved) :| 08:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:20 < bitcoin-git> [bitcoin] luke-jr closed pull request #19573: Replace unused BIP 9 logic with draft BIP 8 (master...bip8) https://github.com/bitcoin/bitcoin/pull/19573 08:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:23 -!- dviola [~diego@unaffiliated/dviola] has quit [Ping timeout: 252 seconds] 08:23 < michaelfolkson> We already have a number of people on the BIP 9 PR saying it should be a new BIP rather than a revision of BIP 9. Obviously that is no guarantee (stranger things have happened) but I will NACK revising BIP 9 08:25 < michaelfolkson> I also offered to work on a new BIP for Speedy Trial a month ago https://gist.github.com/michaelfolkson/92899f27f1ab30aa2ebee82314f8fe7f#gistcomment-3668053 08:27 < vasild> All calls to LogPrintf() and LogPrint() should be terminated with \n ... LogPrint(BCLog::NET, 08:27 < kallewoof> speaking of revisions of BIPs, it would be splendid if https://github.com/bitcoin/bips/pull/1016 moved forward. 08:27 < vasild> what an annoying deficiency in test/lint/lint-logs.sh 08:31 < michaelfolkson> kallewoof: Yeah that will need to be revisited after this activation stuff has played out 08:33 < kallewoof> michaelfolkson: I don't see the connection, but sure, as long as it's addressed. 08:34 < michaelfolkson> kallewoof: At least for me (and I suspect for Luke too) activation has been eating time 08:35 < luke-jr> kallewoof: maybe there should be a new BIP, also eliminating BIP Comments and adding Markdown back into the mix. certain people have decided to skip BIPs because they don't like people leaving comments, and I can only guess the Lightning BOLT stuff is because they prefer markdown… 08:36 < luke-jr> but probably someone will need to talk to those groups to see if that resolves their complaints or not 08:37 < kallewoof> luke-jr: You mean like https://github.com/bitcoin/bips/pull/1015 ? I don't have a preference personally. 08:38 < luke-jr> kallewoof: yeah, but addressing more than just the one issue you have 08:38 < kallewoof> luke-jr: the comments/markdown stuff? okay, first i heard. i'll look into that and update 1015. 08:40 < luke-jr> it's probably a can of worms ;.; 08:40 < kallewoof> luke-jr: I could use some excitement. 08:40 < luke-jr> O.o 08:43 < kallewoof> luke-jr: on a serious note, if you want help with the bip maintenance stuff, i'll gladly assist. 08:46 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 08:49 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 260 seconds] 08:58 -!- proofofkeags [~proofofke@205.209.28.54] has joined #bitcoin-core-dev 08:58 -!- jeremyrubin [~jr@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev 08:59 < achow101> #proposedmeetingtopic 0.21 backports and 0.21.1rc1 09:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:07 < bitcoin-git> [bitcoin] achow101 opened pull request #21701: [0.2] Speedy trial activation for Taproot (0.21...0.21-taproot-st) https://github.com/bitcoin/bitcoin/pull/21701 09:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:30 -!- ogo [~ogo@gateway/tor-sasl/ogo] has quit [Remote host closed the connection] 09:30 -!- ogo [~ogo@gateway/tor-sasl/ogo] has joined #bitcoin-core-dev 09:30 -!- ogo [~ogo@gateway/tor-sasl/ogo] has quit [Remote host closed the connection] 09:31 -!- ogo [~ogo@gateway/tor-sasl/ogo] has joined #bitcoin-core-dev 09:32 -!- asdlkfjwerpoicvx [~flack@p200300d46f1691000cf60444e69d2bad.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!] 09:35 -!- jeremyrubin [~jr@024-176-247-182.res.spectrum.com] has quit [Remote host closed the connection] 09:37 -!- jeremyrubin [~jr@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev 09:52 -!- BGL [~twenty@75-149-171-58-Washington.hfc.comcastbusiness.net] has quit [Ping timeout: 252 seconds] 09:55 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Quit: Leaving] 09:56 -!- lightlike [~lightlike@p200300c7ef1c430089b0c7f84dcf94a9.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 09:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:59 < bitcoin-git> [bitcoin] jonatack closed pull request #21696: DONOTMERGE test: drop cnetaddr link-local assert for macOS 10.14 to re-verify CI (master...cnetaddr-link-local-test-1) https://github.com/bitcoin/bitcoin/pull/21696 09:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:02 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 10:02 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 10:03 -!- Maryam32Murphy [~Maryam32M@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev 10:05 -!- jungly [~jungly@host-95-250-39-128.retail.telecomitalia.it] has quit [Ping timeout: 240 seconds] 10:12 -!- Maryam32Murphy [~Maryam32M@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 252 seconds] 10:13 -!- ogo [~ogo@gateway/tor-sasl/ogo] has quit [Remote host closed the connection] 10:14 -!- ogo [~ogo@gateway/tor-sasl/ogo] has joined #bitcoin-core-dev 10:15 -!- ogo [~ogo@gateway/tor-sasl/ogo] has quit [Remote host closed the connection] 10:16 -!- ogo [~ogo@gateway/tor-sasl/ogo] has joined #bitcoin-core-dev 10:17 -!- diego1 [~diego@187.39.20.53] has joined #bitcoin-core-dev 10:18 -!- diego1 [~diego@187.39.20.53] has left #bitcoin-core-dev [] 10:18 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 10:29 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Ping timeout: 260 seconds] 10:32 -!- suzziminer[m] [suzziminer@gateway/shell/matrix.org/x-dquzymimrljolbhb] has left #bitcoin-core-dev [] 10:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:37 < bitcoin-git> [bitcoin] JeremyRubin opened pull request #21702: Implement BIP-119 Validation (CheckTemplateVerify) (master...checktemplateverify-rebase-4-15-21) https://github.com/bitcoin/bitcoin/pull/21702 10:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:55 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev 11:01 -!- sanket1729 [~sanket172@ec2-100-24-255-95.compute-1.amazonaws.com] has joined #bitcoin-core-dev 11:03 -!- Kiminuo [~Kiminuo@185.216.35.121] has joined #bitcoin-core-dev 11:03 < harding> amiti: re your mailing list post, I know that in 2015 BRD wallet used addr messages to find nodes but I don't think it sent any messages. Obviously that was eons ago in Bitcoin time and I don't know what it does now. 11:04 < harding> amiti: it's the only lightweight client I've ever heard of that used decentralized peer discovery. 11:05 < provoostenator> I suspect most of the Lnd / Btcd based lightning wallets also use p2p to discover bitcoin peers. 11:07 < provoostenator> Wallets like Breez (iOs) and Zap have an Lnd log export function too so you can see what it's doing. 11:07 < harding> provoostenator: yeah, but if they're btcd based, they're full nodes, right? So they're probably advertising addrs. I think neutrino just uses the dns seeds (but I'm definitely not an expert). 11:08 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 11:08 < provoostenator> They use client-side filtering (neutrino) so not really full nodes 11:08 < provoostenator> I would guess, but better to check the logs, they use the DNS seeds to find nodes that support neutrino, since DNS seeds can filter those. 11:10 < provoostenator> https://github.com/sipa/bitcoin-seeder/blob/master/main.cpp#L168 11:10 < harding> Yeah, there was a discussion in here about a year ago between roasbeef and the operators of various seeds to get them to update their filter subdomains, so I assumed they used seeds. However, obviously using seeds doesn't preclude them also using decentralized peer discovery. 11:10 < provoostenator> I have: dig -t A x49.seed.bitcoin.sprovoost.nl 11:11 < provoostenator> Indeed, that should just be the first step. 11:11 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 11:11 < provoostenator> In fact, at my seed doesn't have a node running. 11:12 < provoostenator> Well I guess you could repeatedly beg a DNS seed for more peers. 11:15 -!- BGL [~twenty@75-149-171-58-Washington.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 11:19 < provoostenator> luke-jr: the LOT=true was nowhere near RTM. The BIP 8 speedy trial PR by achow101 was much closer. 11:21 < provoostenator> (I think you already concluded that yourself in a comment later today 11:21 < lightlike> harding: BRD does indeed seem to participate in addr relay: By sending GETADDR and only accepting ADDRS after that: https://github.com/breadwallet/breadwallet-core/blob/develop/bitcoin/BRPeer.c#L283 11:22 -!- jeremyrubin [~jr@024-176-247-182.res.spectrum.com] has quit [Ping timeout: 240 seconds] 11:22 < lightlike> in that case, no problem for amiti's proposal 11:22 < harding> lightlike: ah, if they send getaddr then they're maybe ok for amiti's proposed change. 11:22 < harding> Yeah. 11:25 -!- jeremyrubin [~jr@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev 11:29 < Kiminuo> Hi guys, a quick question: I have this PR https://github.com/bitcoin/bitcoin/pull/21244 and it got one ACK. Now, should I just wait patiently until somebody else will review the PR? Or am I supposed to do something else to increase the chance of merging it? I'm not in hurry. I would just like to understand the review process better. 11:31 < jeremyrubin> Kiminuo: you can "review nag" people to take a look 11:31 < jeremyrubin> if it gets > 2 ACKs it's possible for it to be merged 11:31 < Kiminuo> jeremyrubin, should I do it here on IRC or on Github? How impolite it is? :) 11:31 < jeremyrubin> but there's limited bandwidth for review, especially from maintainers, so you're waiting for a megre access contrib to review it as well 11:32 < Kiminuo> yeah, I see 11:32 < jeremyrubin> Kiminuo: it's not too impolite, but often times it can be a little quid-pro-quo. E.g., you do some review for someone else and they review for you 11:32 < Kiminuo> jeremyrubin, I have actually tried that a bit as that seems friendly to me 11:32 < Kiminuo> (not too much, just a bit) 11:33 < jeremyrubin> It's also (no offense) a low priority PR since it has no external effect on users 11:33 < jeremyrubin> e.g., pure refactor 11:33 < jeremyrubin> right now reviewers are completely focused on preparing the RC1 for taproot 11:33 < jeremyrubin> (most likely) 11:33 < jeremyrubin> So figuring out which PRs must be bundled with that 11:34 < Kiminuo> jeremyrubin, Yes, that's true. I kind of like small improvements as it opens doors for the true heroes :) 11:34 < jeremyrubin> Yep -- and these things can be great 11:35 < jeremyrubin> My advice to newer contributors is to think about momentum v.s. velocity 11:35 < jeremyrubin> momentum is mass * velocity 11:35 < amiti> harding, provoostenator, lightlike: thanks!! that's super helpful feedback. glad to see BRD would not be negatively impacted, I'll take a closer look at the others mentioned. 11:35 < jeremyrubin> so to get more momentum, you can either try to increase core velocity or increase your mass 11:36 < jeremyrubin> You can't really do much to improve velocity (other than helping review others code ofc) 11:36 < jeremyrubin> But for momentum... just work on more stuff! 11:36 < jrawsthorne> I also had the same question. I'm looking for reviewers for #21158. Would be important for alternative clients wanting to use core for taproot validation. Will see if there's any review I can help with 11:36 < gribble> https://github.com/bitcoin/bitcoin/issues/21158 | lib: Add Taproot support to libconsensus by jrawsthorne · Pull Request #21158 · bitcoin/bitcoin · GitHub 11:36 < jeremyrubin> Many devs have tons of PRs open at once, and each one makes a little progress over time 11:36 < luke-jr> provoostenator: yes it was. 5 ACKs 11:36 < jeremyrubin> and once you have enough projects going on it keeps you pretty busy responding to feedback 11:37 < jeremyrubin> Of course you don't want to flood the repo with low priority work 11:37 < jeremyrubin> so I'd recommend picking up 1 more complicated project (e.g., glozow's testmempool package) 11:37 < jeremyrubin> and then having little things to work on in the meantime 11:38 < Kiminuo> jeremyrubin, That makes a lot of sense. I have this PR https://github.com/bitcoin/bitcoin/pull/21422 that I'm really after and https://github.com/bitcoin/bitcoin/pull/21244 is just a side hassle 11:38 < Kiminuo> So I kind of work as expected. That's good news. I'll try to put some effort into those reviews. 11:39 < provoostenator> luke-jr: at most 1 ACK from someone with relevant expertise in this code, plenty of critical feedback from people who DO have that expertise 11:40 < jeremyrubin> Kiminuo: MHM -- the feerate histogram sounds like a great feature! 11:40 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 11:40 < jeremyrubin> Can anyone help me figure out what's up with https://github.com/bitcoin/bitcoin/pull/21702/checks?check_run_id=2355293832 11:40 < jeremyrubin> Does clang dislike .cpp defined local templates? 11:40 < provoostenator> Even aj who wrote several of the commits hasn't ACK'd it. 11:41 < Kiminuo> :) 11:42 < michaelfolkson> provoostenator luke-jr: I said at the time and I'll say again those ACKs were from inexperienced reviewers such as myself. So it wasn't ready for merge imo. But after the aj Andrew competing PRs I'm not exactly sure what aj will ACK anymore 11:44 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 11:44 -!- larryruane_ [uid473749@gateway/web/irccloud.com/x-owttibdjsvfioccp] has quit [] 11:45 -!- larryruane_ [uid473749@gateway/web/irccloud.com/x-cyzkxkevrbubbkye] has joined #bitcoin-core-dev 11:50 -!- lightlike [~lightlike@p200300c7ef1c430089b0c7f84dcf94a9.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds] 11:50 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Quit: WeeChat 2.9] 11:50 -!- lightlike [~lightlike@p200300c7ef1c4300056a7e5292fbb9bf.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 11:53 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 11:59 < ariard> jrawsthorne: will review back #21158 :) 11:59 < gribble> https://github.com/bitcoin/bitcoin/issues/21158 | lib: Add Taproot support to libconsensus by jrawsthorne · Pull Request #21158 · bitcoin/bitcoin · GitHub 11:59 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 12:00 < provoostenator> Meeting? 12:00 < wumpus> #startmeeting 12:00 < provoostenator> hi 12:00 < hebasto> hi 12:00 < achow101> hi 12:00 < meshcollider> hi 12:00 < ariard> hi 12:00 < wumpus> hi 12:00 < michaelfolkson> hi 12:00 < wumpus> #bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik 12:00 < wumpus> petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild wumpus 12:00 < amiti> hi 12:00 < lightlike> hi 12:00 < jeremyrubin> hallo 12:01 < glozow> hi 12:01 < jnewbery> hi 12:01 < gleb> hi 12:01 < jonatack> hi 12:01 < wumpus> two porosed meeting topics (http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt) : short info/update on the "Bitcoin Core Code Signing Association" status. (jonasschnelli) 0.21 backports and 0.21.1rc1 (achow101) 12:01 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 258 seconds] 12:01 < wumpus> any last minute topic suggestions? 12:02 < wumpus> #topic High priority for review 12:02 < jonasschnelli> hi 12:02 < wumpus> https://github.com/bitcoin/bitcoin/projects/8 10 blockers, 2 chasing concept ACK right now 12:03 < wumpus> anyone have suggestions of something to add/remove or that is ready for merge? 12:03 < gleb> I was thinking whether to put #21515 in high-prio at this point. The code is pretty much ready from my side (although ariard promised to contribute fuzzing), but at the same time we probably need to merge minisketch first separately 12:03 < gribble> https://github.com/bitcoin/bitcoin/issues/21515 | Erlay: bandwidth-efficient transaction relay protocol by naumenkogs · Pull Request #21515 · bitcoin/bitcoin · GitHub 12:04 < gleb> For which I expected sipa would be here and say a word :) 12:04 < sipa> a word 12:04 < gleb> haha 12:04 < sipa> i can PR minisketch as a subtree if that's what people want 12:04 -!- Randolf [~randolf@184.70.10.188] has joined #bitcoin-core-dev 12:04 < wumpus> if it is blocked by something else i'm not sure it makes sense to add to blockers 12:05 < jonatack> #19521 seems ready 12:05 < gribble> https://github.com/bitcoin/bitcoin/issues/19521 | Coinstats Index by fjahr · Pull Request #19521 · bitcoin/bitcoin · GitHub 12:05 < sipa> i believe we're also going to do a review club on the c++ minisketch code; perhaps we want that first 12:05 < wumpus> jonatack: thanks, good to know 12:05 < gleb> sipa: is that scheduled? 12:05 < ariard> yeah let's PR minisketch first, will make erlay review easier 12:06 < glozow> +1 12:06 < wumpus> okay let's do that first then 12:06 < gleb> alright, then the plan is review club -> minisketch pr/review -> erlay pr review. 12:06 < wumpus> sgtm 12:06 < gleb> In the meanwhile people are welcome to start reviewing erlay 21515 :) 12:06 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 12:07 < ariard> erlay pr review can advance a bit, we should figure out testing on a signet :) 12:07 < sipa> gleb: jnewbery just ask me to do one on the 21st 12:07 < sipa> why signet? 12:07 < gleb> that's soon, great. 12:07 < provoostenator> Signet has a 1 byte mempool... 12:08 < provoostenator> Mainnet seems more interesting for erlay 12:08 < provoostenator> (for reckless devs) 12:08 < sipa> indeed 12:08 < ariard> oh can't generate a bigger mempool on the default signet 12:08 < lightlike> doesn't help much though if you are the only one running it on mainnet :-) 12:08 < provoostenator> Well signet is centralized so it could be made bigger 12:08 < gleb> I was running couple of my erlay nodes at mainnet a while ago, would do again. 12:08 < ariard> yeah but testing on mainnet you may not find other erlay peers? 12:09 < sipa> ariard: -connect is your friend :) 12:09 < gleb> sounds like something i should coordinate. 12:09 < ariard> sipa: ahah -connect is my friend but still need to find erlay friends 12:10 < ariard> something we can coordinate out of meeting for sure 12:10 < gleb> Perhaps by the next week meeting i can have a solid testing plan like that. 12:10 < jonatack> ariard: guess how we tested tor v3 and i2p ;) 12:10 < wumpus> i'm happy to help testing it fwiw 12:10 < gleb> alright, seems like we have an idea of how to proceed. 12:11 < wumpus> #topic Short info/update on the "Bitcoin Core Code Signing Association" status (jonasschnelli) 12:11 < sipa> paging jonasschnelli 12:12 < jonasschnelli> (have some lags) 12:12 < jonasschnelli> In order to obtain new certificates for code signing, we need to register the Bitcoin Core Code Signing Association in switzerland 12:12 -!- ccdle12 [955adef3@243.222.90.149.rev.vodafone.pt] has joined #bitcoin-core-dev 12:12 < jonasschnelli> which requires some paperwork and yearly chores 12:12 < jonasschnelli> (like tax declaration, financial statements, etc.) 12:13 < achow101> For context, the CA/B forum changed the requirements for organization validation for code signing certificates. So we need to register the association with government authority in order to get a certificate issued. 12:13 < jonasschnelli> The Bitcoin Association Switzerland is now helping me to set this up... 12:13 < sipa> What is CA/B ? 12:13 < achow101> Certificate Authority / Browser forum 12:13 < jonasschnelli> but since gov is necesarry for that part,..it might take awhile 12:13 < achow101> that's the group that sets the rules for CAs and other related things 12:13 < sipa> jonasschnelli: it's swiss government, aren't they super fast :) 12:13 < jonasschnelli> no in everything. :) 12:13 < jonasschnelli> *not 12:14 < sipa> ok, what's a realistic timeline? 12:14 < jonasschnelli> I don't have an estimate... and without the proper registration, we won't get new window certificates 12:14 < jonasschnelli> (unsure about mac) 12:14 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:14 < jonasschnelli> As soon as the lawyer take on the job, I think i can get an est. 12:14 < achow101> I expect Apple will now have similar requirements as they must adhere to the same rules to remain a CA 12:14 < jonasschnelli> probably 2-3 month, 12:14 < jonasschnelli> achow101: very likely 12:15 < sipa> could we try to do this in another jurisdiction? 12:15 < sipa> where it's faster 12:15 < achow101> An alternative I am beginning to explore now is to setup a LLC in the US, But I am not sure if that will be any faster 12:15 < jonasschnelli> maybe it is also 3-4 weeks... as said. Just a wild guess right now 12:16 < BlueMatt> achow101: you should be able to get an LLC in most states in a few days, max 12:16 < BlueMatt> I know new york is like well under a week, maybe 1 biz day 12:16 < jonasschnelli> a US LLC would be an option. 12:16 < achow101> There are additional requirements for newly created organizations too... 12:16 < roconnor> how about buying a shelf company. :D 12:16 < jonasschnelli> If we want, we could do both (as sort of a redundancy) 12:17 < sipa> a shelf company or a shell company? 12:17 < provoostenator> A SPAC? 12:17 < sipa> i like switzerland as a jurisdiction though, for things like this 12:17 < jonasschnelli> me 2 12:17 < provoostenator> We could raise billions for the certificate in the current market climate :-) 12:17 < jonasschnelli> I can probably give an update on the est in a few days 12:18 < sipa> this is currently a problem for signing new windows binaries, right? 12:18 < achow101> yes 12:18 < sipa> and we expect it will be a problem for apple binaries too in the near future? 12:18 < jonasschnelli> Things that hit the company registry, often take a few weeks (AFAIK). Because ,... hm... its a gov database. :) 12:18 < roconnor> https://en.wikipedia.org/wiki/Shelf_corporation 12:18 < achow101> sipa: yes 12:18 < roconnor> but I probably shouldn't be commenting since i have no idea what I'm talking about. 12:18 < provoostenator> But yeah, all things equal - other than some delay - I'd rather see this thing in Switserland than in the US. 12:18 < jonasschnelli> I could try to extend the apple certificate and see what happens... 12:19 < wumpus> hopefully it doesn't get retroactively revoked too 12:19 < jonasschnelli> That would really surprise me. 12:20 < jonasschnelli> I think apple isn't that restrictive (as long as it is not malware) 12:20 < wumpus> okay, great 12:20 < jonasschnelli> conclusion: we are on it. No clear esta. I'll keep you updated. 12:20 < wumpus> thank you! 12:20 < sipa> okay 12:21 < sipa> sounds good 12:21 < wumpus> #topic 0.21 backports and 0.21.1rc1 (achow101) 12:22 < achow101> to meet the timeline discussed previously for taproot activation, we need to have 0.21.1rc1 in the next few days 12:22 < jeremyrubin> \o/ 12:22 < achow101> the parameters have been merged into master, so all that's left is to do the backport 12:23 < achow101> and close out any remaining 0.21.1 backports 12:23 < jeremyrubin> achow101: also it's worth pointing out that backports are only required insofar as people want to signal via a backport client 12:24 < jeremyrubin> backports aren't blocking IMO for signaling, e.g. some miners use a recent core to gate old core patched mining nodes 12:24 < wumpus> isn't the backport the most important thing? at least the 0.21.x one 12:24 < achow101> considering that 22.0 probably won't land until after the timeout time, we need to have the backport 12:24 < wumpus> besides that softforks are never introduced in major versions 12:24 < provoostenator> n00b question, but signalling has to be done manually by miners anyway right? Or does getblocktemplate do that automagically? 12:24 < jeremyrubin> true, I just mean that the backports (given the minactivetime) can happen anytime before that height quite safely 12:25 < jeremyrubin> unless we think that miners will do signaling via backported clients 12:25 < jeremyrubin> But I agree we should get them out promptly, just that I don't perceive it as blocking 12:25 < jeremyrubin> but others can disagree with that assessment 12:25 < achow101> there are currently 5 things tagged for backport (or as backport) to 0.21. 12:25 < achow101> 3 are as backport, 2 are for backport 12:25 < harding> provoostenator: GBT does it automatically; I tested that was working as part of my review of 21377 (on regtest with vbparams). 12:26 < harding> provoostenator: but minres will probably do it manually anyway. 12:26 < provoostenator> Ah you're right, I do remember regtest signalling, just nevered inspected how that works. 12:26 < hebasto> wumpus: is it assumed to update translations for 0.21.1? 12:26 < jonatack> note bene, i'd suggest adding #21644 for backport, it fixes a bug in v0.21 12:26 < gribble> https://github.com/bitcoin/bitcoin/issues/21644 | p2p, bugfix: use NetPermissions::HasFlag() in CConnman::Bind() by jonatack · Pull Request #21644 · bitcoin/bitcoin · GitHub 12:27 < wumpus> hebasto: yes, unless there is a reason for skipping that? 12:27 < provoostenator> Anyway I would much miners to use the 0.21.1 release as soon as it comes out rather than "oh yeah, I'll remember to upgrade later". 12:27 < provoostenator> So not blocking, but we should not wait too long either. 12:28 < hebasto> wumpus: no reasons for skipping at all :) just want to restore wiped out Ukrainian translation 12:28 < jeremyrubin> provoostenator: +1 -- just note that the "later" is by minactivationheight 12:29 < wumpus> hebasto: makes sense! 12:29 < achow101> I think it would be reasonable to merge the current backports and leave the rest tagged for 0.21.1 for 0.21.2? 12:29 < wumpus> achow101: would agree, unless they are critical bugs of course 12:29 < wumpus> but we can definitely leave 'would be nice' stuff for 0.21.2 12:30 < sipa> makes sense 12:30 < provoostenator> There's a Boost dependency URL change PR, which should probably go in too 12:30 < provoostenator> #21662 12:30 < gribble> https://github.com/bitcoin/bitcoin/issues/21662 | build: update Boost download URL by fdoving · Pull Request #21662 · bitcoin/bitcoin · GitHub 12:30 < hebasto> ^ agree 12:31 -!- glozow is now known as help 12:31 -!- help is now known as glozow 12:31 < wumpus> any other topics? 12:32 < wumpus> #endmeeting 12:33 < achow101> well if there are current PRs that we should have for 0.21.1, please tag them as such 12:35 < roconnor> Apparently Companies Incorporated will sell Wolf and Associates LLC from Marshall Islands for $4809. 12:36 < achow101> I don't think a shelf company would be the way to go 12:36 < roconnor> Though if we have to sign binaries with that name, that will be confusing... 12:36 < jonatack> just updated the description in the PR I mentioned...peers with the download net permission flag are incorrectly not being added to local addresses because they are mistakenly seen as noban peers 12:36 < achow101> seems kinda sketchy 12:37 < roconnor> I mean, they are for people who want "to save the time involved in taking the steps to create a new corporation." 12:37 < roconnor> which tends to be for sketch organizations. But we want it for good purposes. :D 12:38 < jonatack> achow101: agree 12:38 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Ping timeout: 240 seconds] 12:39 < roconnor> That said, Wikipedia also claims "In Australia, a new company can get registered within 10 minutes." 12:39 < roconnor> but achow101 mention something about restrictions regarding certificates for newly formed corporations. 12:39 -!- cguida [~Adium@2601:282:200:ae00:3dcc:eebe:8776:8907] has quit [Quit: Leaving.] 12:39 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev 12:39 -!- cguida [~Adium@2601:282:200:ae00:1de6:ad14:289f:e840] has joined #bitcoin-core-dev 12:40 < achow101> The validation requirements are specified in https://cabforum.org/wp-content/uploads/baseline_requirements_for_the_issuance_and_management_of_code_signing.v2.2.pdf section 11.1.1 12:41 < achow101> A new LLC would run into "If the Subject’s or Subject’s Affiliate’s, Parent Company’s, or Subsidiary Company’sdate of formation, as indicated by either a QIIS or QGIS, was less than three years prior to the date of the Certificate Request, verify the identity of the Certificate Requester" 12:41 < sipsorcery> dunno if it's of any use but Nicolas Dorier was/is involved in a Swiss company. 12:41 < achow101> but I don't know if that would be a significant issue 12:41 < sipsorcery> he'd probably be able to offer advice if needed 12:43 < sipsorcery> maybe it would even help with the costs given it's a bitcoin company... 12:44 < roconnor> oh, that doesn't sound like that big of a hurdle if I'm reading that correctly. 12:44 -!- cguida [~Adium@2601:282:200:ae00:1de6:ad14:289f:e840] has quit [Ping timeout: 258 seconds] 12:45 < achow101> probably 12:59 -!- stortz [c8b9c69a@unaffiliated/stortz] has joined #bitcoin-core-dev 13:01 < aj> gleb: (could spin up a dedicated signet for erlay pretty easily, but either way would need something to fake txs on it -- that could just be something that generates txs to send to itself on a poisson timer though?) 13:04 -!- smartineng [~Icedove@88.135.18.171] has quit [Quit: smartineng] 13:23 -!- cguida [~Adium@205.209.28.54] has joined #bitcoin-core-dev 13:23 -!- cguida [~Adium@205.209.28.54] has quit [Client Quit] 13:24 -!- cguida [~Adium@205.209.28.54] has joined #bitcoin-core-dev 13:29 -!- ccdle12 [955adef3@243.222.90.149.rev.vodafone.pt] has quit [Quit: Connection closed] 13:29 -!- Guyver2__ [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 13:31 -!- Guyver2__ is now known as Guyver2 13:31 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 265 seconds] 13:37 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Ping timeout: 260 seconds] 13:40 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Read error: Connection reset by peer] 13:40 -!- TheRec_ [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-dev 13:40 -!- TheRec_ [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Changing host] 13:40 -!- TheRec_ [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 13:43 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev 13:46 -!- cmirror [~cmirror@4.53.92.114] has quit [Quit: (Botdeath)] 13:48 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev 13:51 -!- ovovo [~ovovo@2a02:20c8:4124::5e] has joined #bitcoin-core-dev 13:51 -!- ovovo [~ovovo@2a02:20c8:4124::5e] has quit [Changing host] 13:51 -!- ovovo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 13:53 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 265 seconds] 13:59 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:04 < jeremyrubin> BTW trying to debug https://github.com/bitcoin/bitcoin/runs/2355293835 still 14:04 < jeremyrubin> What is expected here? 14:04 < jeremyrubin> these identifiers are definitely present in this translation unit 14:08 -!- TheRec_ [~toto@drupal.org/user/146860/view] has quit [Ping timeout: 246 seconds] 14:11 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-dev 14:11 -!- TheRec [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Changing host] 14:11 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 14:11 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 258 seconds] 14:14 -!- duringo [ad004d10@173.0.77.16] has joined #bitcoin-core-dev 14:14 -!- Randolf [~randolf@184.70.10.188] has quit [Quit: Leaving] 14:24 -!- Kiminuo [~Kiminuo@185.216.35.121] has quit [Ping timeout: 265 seconds] 14:30 < jeremyrubin> pet peeve: could we make all the build artifacts go into a hidden directory? cfields_? 14:41 < jeremyrubin> I think i fixed the ident issue, was the order of defns. 14:41 < jeremyrubin> err declarations 14:46 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 14:46 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 14:47 -!- lightlike [~lightlike@p200300c7ef1c4300056a7e5292fbb9bf.dip0.t-ipconnect.de] has quit [Quit: Leaving] 14:51 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 260 seconds] 15:41 -!- joerodgers [joerodgers@gateway/vpn/mullvad/joerodgers/x-62861712] has joined #bitcoin-core-dev 15:57 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Ping timeout: 240 seconds] 15:59 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev 16:04 -!- molz_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 16:07 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 268 seconds] 16:09 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Ping timeout: 260 seconds] 16:24 -!- TheRec_ [~toto@84-75-225-47.dclient.hispeed.ch] has joined #bitcoin-core-dev 16:24 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Remote host closed the connection] 16:24 -!- TheRec_ [~toto@84-75-225-47.dclient.hispeed.ch] has quit [Changing host] 16:24 -!- TheRec_ [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 16:29 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev 16:41 -!- cguida [~Adium@205.209.28.54] has quit [Quit: Leaving.] 16:43 -!- OP_NOP_ [OP_NOP@gateway/vpn/privateinternetaccess/opnop/x-41418994] has joined #bitcoin-core-dev 16:46 -!- OP_NOP [OP_NOP@gateway/vpn/privateinternetaccess/opnop/x-41418994] has quit [Ping timeout: 240 seconds] 16:46 -!- _joerodgers [joerodgers@gateway/vpn/mullvad/joerodgers/x-62861712] has joined #bitcoin-core-dev 16:46 -!- joerodgers [joerodgers@gateway/vpn/mullvad/joerodgers/x-62861712] has quit [Ping timeout: 252 seconds] 16:48 -!- meinwolf [~meinwolf@unaffiliated/meinwolf] has quit [Remote host closed the connection] 16:48 -!- meinwolf [~meinwolf@unaffiliated/meinwolf] has joined #bitcoin-core-dev 16:56 -!- molz_ [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds] 17:15 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Ping timeout: 260 seconds] 17:24 -!- cguida [~Adium@2601:282:200:ae00:e490:2f4c:807a:8528] has joined #bitcoin-core-dev 17:25 -!- cguida [~Adium@2601:282:200:ae00:e490:2f4c:807a:8528] has quit [Client Quit] 17:25 -!- Chad34 [4246945f@ip95.ip-66-70-148.net] has joined #bitcoin-core-dev 17:26 -!- proofofkeags [~proofofke@205.209.28.54] has quit [Ping timeout: 265 seconds] 17:30 -!- aj [aj@cerulean.erisian.com.au] has quit [Quit: leaving] 17:30 -!- aj [aj@cerulean.erisian.com.au] has joined #bitcoin-core-dev 17:31 -!- stortz [c8b9c69a@unaffiliated/stortz] has quit [Quit: Connection closed] 17:45 -!- rny is now known as strstr 18:12 -!- cguida [~Adium@2601:282:200:ae00:e490:2f4c:807a:8528] has joined #bitcoin-core-dev 18:14 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev 18:17 -!- cguida [~Adium@2601:282:200:ae00:e490:2f4c:807a:8528] has quit [Quit: Leaving.] 18:30 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 18:31 -!- jeremyrubin [~jr@024-176-247-182.res.spectrum.com] has quit [Remote host closed the connection] 18:31 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 252 seconds] 18:41 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...] 18:43 -!- duringo [ad004d10@173.0.77.16] has quit [Quit: Connection closed] 18:44 -!- duringo [ad004d10@173.0.77.16] has joined #bitcoin-core-dev 18:50 -!- Chad34 [4246945f@ip95.ip-66-70-148.net] has quit [Quit: Connection closed] 18:51 -!- tlyu [~tlyu@178.239.168.171] has quit [Remote host closed the connection] 18:53 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 19:07 -!- serAphim1 [~serAphim@217.146.82.202] has joined #bitcoin-core-dev 19:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 19:11 < bitcoin-git> [bitcoin] fanquake pushed 6 commits to 0.21: https://github.com/bitcoin/bitcoin/compare/e358b43f7d89...0fe5b6130cc1 19:11 < bitcoin-git> bitcoin/0.21 48fc675 Andrew Chow: wallet: Use existing feerate instead of getting a new one 19:11 < bitcoin-git> bitcoin/0.21 34c89f9 Andrew Chow: wallet: Replace nFeeRateNeeded with effective_fee 19:11 < bitcoin-git> bitcoin/0.21 bcd7166 Andrew Chow: wallet: Move long term feerate setting to CreateTransaction 19:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 19:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 19:11 < bitcoin-git> [bitcoin] fanquake merged pull request #21520: [0.21] wallet: Avoid requesting fee rates multiple times during coin selection (0.21...0.21-createtx-same-feerate) https://github.com/bitcoin/bitcoin/pull/21520 19:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 19:19 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev 20:00 -!- cguida [~Adium@2601:282:200:ae00:e490:2f4c:807a:8528] has joined #bitcoin-core-dev 20:02 -!- cguida [~Adium@2601:282:200:ae00:e490:2f4c:807a:8528] has quit [Client Quit] 20:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 20:09 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c6b30ccb2eee...585cbe225753 20:09 < bitcoin-git> bitcoin/master 5f2be6e Hennadii Stepanov: Remove no longer used contrib/bitcoin-qt.pro from the repo 20:09 < bitcoin-git> bitcoin/master 585cbe2 fanquake: Merge #21695: Remove no longer used contrib/bitcoin-qt.pro from the repo 20:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 20:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 20:09 < bitcoin-git> [bitcoin] fanquake merged pull request #21695: contrib: remove no longer used contrib/bitcoin-qt.pro (master...210415-pro) https://github.com/bitcoin/bitcoin/pull/21695 20:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 20:26 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 252 seconds] 20:38 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 20:42 -!- jeremyrubin [~jr@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev 21:09 -!- strstr is now known as rny 21:25 -!- flag [~flag@net-93-146-98-117.cust.vodafonedsl.it] has quit [Quit: leaving] 21:28 -!- ogo [~ogo@gateway/tor-sasl/ogo] has quit [Ping timeout: 240 seconds] 21:29 -!- ogo [~ogo@gateway/tor-sasl/ogo] has joined #bitcoin-core-dev 21:30 -!- ogo [~ogo@gateway/tor-sasl/ogo] has quit [Remote host closed the connection] 21:31 -!- ogo [~ogo@gateway/tor-sasl/ogo] has joined #bitcoin-core-dev 21:32 -!- flag [~flag@net-93-146-98-117.cust.vodafonedsl.it] has joined #bitcoin-core-dev 22:11 < wumpus> let's move #20966 and #19362 to 0.21.2? 22:11 < gribble> https://github.com/bitcoin/bitcoin/issues/20966 | banman: save the banlist in a JSON format on disk by vasild · Pull Request #20966 · bitcoin/bitcoin · GitHub 22:11 < gribble> https://github.com/bitcoin/bitcoin/issues/19362 | rpc/blockchain: Reset scantxoutset progress before inferring descriptors by prusnak · Pull Request #19362 · bitcoin/bitcoin · GitHub 22:13 < fanquake> wumpus: ACK. Had been thinking similar 22:18 < wumpus> fanquake: okay done ! 22:19 -!- VmVds [7da880c5@197.128.168.125.sta.wbroadband.net.au] has joined #bitcoin-core-dev 22:19 < fanquake> CI now fixed in #21701, so that is also ready for review 22:19 < gribble> https://github.com/bitcoin/bitcoin/issues/21701 | [0.21] Speedy trial activation for Taproot by achow101 · Pull Request #21701 · bitcoin/bitcoin · GitHub 22:20 < fanquake> We'll also want to get #21614 in 22:20 < gribble> https://github.com/bitcoin/bitcoin/issues/21614 | [0.21] test: Backports by MarcoFalke · Pull Request #21614 · bitcoin/bitcoin · GitHub 22:22 < aj> 21701 conflicts with 21614? 22:25 < fanquake> If the changes in 4546ac5af1c4105a0cf78a407fefcb189822bcf5 in 21614 are covered in a commit in 21701, we can drop that change from 21614 22:27 < aj> 21377 should have cherry-picked cleanly on top of 21614; i guess some/all of them were included in the "fuzz: test versionbits delayed activation" commit though? 22:28 < fanquake> Yes it looks like some of those changes are included in b529222ad18f7facbaff394455875b4aa65d653e 22:29 < wumpus> agree it is not good if the last two PRs conflict, that introduces a rebase bottleneck 22:30 < fanquake> I think if we get 21701 in. We can always open a PR to make the required followups. Otherwise, marco will be active soon, and should be able to rebase/modify 21614 22:30 < fanquake> aj is #21691 meant to be backported as well? 22:30 < gribble> https://github.com/bitcoin/bitcoin/issues/21691 | test: Check that no versionbits are re-used by MarcoFalke · Pull Request #21691 · bitcoin/bitcoin · GitHub 22:31 < aj> fanquake: doesn't need to be 22:31 < aj> fanquake: (it's only relevant if we introduce more soft forks that reuse version bits) 22:32 < aj> one of them's included in the NEVER_ACTIVE commit, which looks like it means the vbits fuzzer won't work for earlier commits 22:42 -!- awesome_doge1 [~Thunderbi@118-163-120-175.HINET-IP.hinet.net] has joined #bitcoin-core-dev 22:59 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 23:01 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds] 23:08 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Ping timeout: 240 seconds] 23:08 -!- smartineng [~Icedove@88.135.18.171] has joined #bitcoin-core-dev 23:08 -!- smartineng [~Icedove@88.135.18.171] has quit [Excess Flood] 23:09 -!- smartineng [~Icedove@88.135.18.171] has joined #bitcoin-core-dev 23:11 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev 23:20 -!- Kiminuo [~Kiminuo@194.213.208.81] has joined #bitcoin-core-dev 23:26 -!- Kimi [~Kiminuo@141.98.103.172] has joined #bitcoin-core-dev 23:29 -!- Kiminuo [~Kiminuo@194.213.208.81] has quit [Ping timeout: 240 seconds] 23:34 -!- jungly [~jungly@host-87-18-193-226.retail.telecomitalia.it] has joined #bitcoin-core-dev 23:39 -!- jadi [~jadi@37.98.3.133] has joined #bitcoin-core-dev 23:39 -!- isis [~isis@abulafia.patternsinthevoid.net] has quit [Remote host closed the connection] 23:39 -!- isis_ [~isis@abulafia.patternsinthevoid.net] has quit [Read error: Connection reset by peer] 23:44 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev 23:46 < wumpus> oh yea i think aiming for activating one soft fork is enough for this release, or do you mean releasing without it will make reusing the bits impossible in the future? 23:47 < aj> no, it's just a test to make sure we're not currently reusing bits 23:47 < wumpus> right, thanks 23:48 < wumpus> at least backporting tests is very low risk 23:48 < aj> safely reusing bits in the future just means we need to make sure the first activation is actually finished (FAILED/ACTIVE) and preferably buried (SoftForkHeight = 987654) rather than signaled 23:49 < aj> (or we could switch to signaling by something other than nVersion and avoid worrying about bit reuse entirely) 23:51 < aj> (we've got another 9 bits before we need to reuse any and another 3 additional bits reusing bits for buried activations before we have to worry about this. would be impressive if we added that many soft forks to 0.21...) 23:52 < aj> err, 10+3 not 9+3 23:52 < aj> oh no, i'm counting taproot, 9+3 was right 23:54 < wumpus> that *would* be impressive yes 23:56 < wumpus> definitely doesn't sound like we're going to run out of bits any time soon --- Log closed Fri Apr 16 00:00:27 2021