--- Log opened Wed Apr 21 00:00:32 2021
00:08 -!- S3RK_ is now known as S3RK
00:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:17 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e507acb1184f...e16f8720dca2
00:17 < bitcoin-git> bitcoin/master c799a19 Hennadii Stepanov: build, qt: No longer need to set QT_RCC_TEST=1 for determinism
00:17 < bitcoin-git> bitcoin/master e16f872 fanquake: Merge #21655: build, qt: No longer need to set QT_RCC_TEST=1 for determini...
00:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:17 < bitcoin-git> [bitcoin] fanquake merged pull request #21655: build, qt: No longer need to set QT_RCC_TEST=1 for determinism (master...210411-qhash) https://github.com/bitcoin/bitcoin/pull/21655
00:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:18 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Ping timeout: 240 seconds]
00:19 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev
00:25 -!- duringo [ad004d0f@173.0.77.15] has quit [Ping timeout: 240 seconds]
00:32 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection]
00:33 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev
00:35 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
00:37 -!- _andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 240 seconds]
00:43 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Ping timeout: 240 seconds]
00:44 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev
00:47 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
00:59 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
01:02 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Ping timeout: 260 seconds]
01:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
01:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
01:14 -!- lkqwejhhgasdjhgn [~kljkljklk@p200300d46f169100125d29b1d7810672.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
01:26 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev
01:58 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
02:01 -!- johonchain [~johnoncha@2a01:cb14:cf6:bc00:1c3:e45a:be45:2560] has joined #bitcoin-core-dev
02:12 -!- moorcock75 [~niamh@128.127.26.178] has joined #bitcoin-core-dev
02:14 -!- mars [~niamh@aaubervilliers-654-1-61-83.w86-218.abo.wanadoo.fr] has quit [Ping timeout: 240 seconds]
03:01 -!- promag_ [~promag@188.250.84.129] has joined #bitcoin-core-dev
03:01 -!- johonchain [~johnoncha@2a01:cb14:cf6:bc00:1c3:e45a:be45:2560] has quit [Ping timeout: 260 seconds]
03:03 -!- promag [~promag@188.250.84.129] has quit [Ping timeout: 246 seconds]
03:18 -!- Ervin75Gerlach [~Ervin75Ge@static.57.1.216.95.clients.your-server.de] has joined #bitcoin-core-dev
03:18 -!- promag_ [~promag@188.250.84.129] has quit []
03:19 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
03:21 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
03:22 < wumpus> hebasto: almost, but not exactly: the notification you are seeing is due to the switch of the auto-update URL of the 0.21 resource in transifex from master to the (correct) 0.21 branch, not due to the merge of your PR
03:23 < wumpus> there is no transifex resource pointing at master, i guess we could create a translation for 0.22 early if we really want to test the new message extraction
03:24 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 258 seconds]
03:25 < wumpus> normally this is done at the time of the translation freeze in the release process to reduce the amount of duplicate work translators have to do due to code churn
03:25 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
03:26 < hebasto> wumpus: thanks
03:28 < wumpus> but it might be a good idea to try earlier now than the planned 2021-06-01 to have more time to adapt the fetch script or other tooling if needed
03:31 < wumpus> .. let's just try
03:38 -!- biteskola [~biteskola@170.76.76.188.dynamic.jazztel.es] has joined #bitcoin-core-dev
03:45 -!- pox [~pox@gateway/tor-sasl/pox] has quit [Quit: pox]
03:47 -!- pox [~pox@gateway/tor-sasl/pox] has joined #bitcoin-core-dev
03:49 < hebasto> sgtm
03:55 -!- Ervin75Gerlach [~Ervin75Ge@static.57.1.216.95.clients.your-server.de] has quit [Ping timeout: 240 seconds]
03:56 < wumpus> ok: it seems not possible to change the file type for an existing resource, the 22.x one has to be 'born' from the xlf (another reason we can't backport this)
03:58 < wumpus> this also means it is likely that transifex-migrate-resource won't work as-is to copy the previous release's translations but well see
03:59 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
04:00 < wumpus> i... hope the better translator experience is worth all this
04:03 < wumpus> on the other hand i read something about transifex deprecating the v2 API, so that script (which uses that) likely wouldn't work for much longer
04:07 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Ping timeout: 240 seconds]
04:18 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev
04:33 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Ping timeout: 240 seconds]
04:34 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
04:34 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev
04:35 < wumpus> hebasto: okay, as somehow expected: tx pull gets back documents formatted as xliff... which makes me wonder, do we need .ts files at all, can't we convert the whole pipeline to that format?
04:36 < wumpus> i mean does qt support it natively? it is a qt specific format right? why is ts still used?
04:40 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
04:50 -!- ShapeShifter499 [~ShapeShif@2601:204:dc80:a73d::9ea] has joined #bitcoin-core-dev
04:50 -!- ShapeShifter499 [~ShapeShif@2601:204:dc80:a73d::9ea] has quit [Changing host]
04:50 -!- ShapeShifter499 [~ShapeShif@unaffiliated/shapeshifter499] has joined #bitcoin-core-dev
04:50 -!- ShapeShifter499 [~ShapeShif@unaffiliated/shapeshifter499] has quit [Remote host closed the connection]
04:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:53 < bitcoin-git> [gui] laanwj opened pull request #286: qt: Bump transifex slug for 22.x (master...2021-04-transifex-slug-022x) https://github.com/bitcoin-core/gui/pull/286
04:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:54 -!- biteskola [~biteskola@170.76.76.188.dynamic.jazztel.es] has quit [Ping timeout: 252 seconds]
04:54 -!- sr_gi [~sr_gi@static-167-163-230-77.ipcom.comunitel.net] has quit [Read error: Connection reset by peer]
04:54 -!- sr_gi [~sr_gi@static-167-163-230-77.ipcom.comunitel.net] has joined #bitcoin-core-dev
04:56 < hebasto> wumpus: it seems `lrelease` tool expects ts-files as an input
04:57 < wumpus> hebasto: that's curious, i wonder why they don't add support directly, but yea then we don't get around converting them
05:03 < wumpus> (not sure yet whether to do the conversion as part of the fetch-translations script or during the build, i guess during fetch is most efficient as there is no point doing it on every build if they don't change)
05:05 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds]
05:06 < wumpus> ok: XLIFF is not a qt-specific format, it is a generic interchange format for translations, that is why
05:07 < hebasto> yeah, and it seems widely adopted
05:08 < wumpus> right i really like the idea of standardization here
05:10 < hebasto> wumpus: I can see a new 22.x translation with a "XLIFF" tag on the Transifex now
05:10 < wumpus> ideally it means that tooling only needs to support one format, so more cooperation on that
05:10 < wumpus> hebasto: great!
05:11 < hebasto> iiuc, some settings you've done on transifex, right?
05:12 < wumpus> yes, i created the new resource and uploaded the xlf file
05:13 < wumpus> the only difference is that i cannot copy the previous releases translations as other times (at least not with the existing transifex-migrate-resource.py script, as i said above)
05:14 < wumpus> 22.x resource is updating directly from master
05:14 < hebasto> most string translations are migrated  "via Translation memory"...
05:15 < wumpus> maybe that is enough
05:15 < wumpus> i guess translation memory has improved since years ago
05:18 < hebasto> you could look at string 24 and see "developers note" -- it works :)
05:22 -!- johonchain [~johnoncha@2a01:cb14:cf6:bc00:1c3:e45a:be45:2560] has joined #bitcoin-core-dev
05:25 < wumpus> i see... nice ! definitely seems useful to have additional information like that
05:34 -!- mars [~niamh@aaubervilliers-654-1-61-83.w86-218.abo.wanadoo.fr] has joined #bitcoin-core-dev
05:36 -!- moorcock75 [~niamh@128.127.26.178] has quit [Ping timeout: 240 seconds]
05:48 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Quit: Leaving]
05:48 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
05:50 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Client Quit]
05:51 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
05:51 -!- Chris_Stewart_5 [~Chris_Ste@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
06:05 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
06:08 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Ping timeout: 240 seconds]
06:10 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
06:12 -!- Thor95 [4b48bcff@c-75-72-188-255.hsd1.mn.comcast.net] has joined #bitcoin-core-dev
06:18 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev
06:37 -!- seha [~textual@209.150.59.145] has joined #bitcoin-core-dev
06:38 -!- seha [~textual@209.150.59.145] has quit [Client Quit]
06:43 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Ping timeout: 240 seconds]
06:44 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev
07:01 < hebasto> wumpus: going to submit comparison between ts vs xliff in the transifex editor; should I post it as a comment to #21694 or submit a separated issue in the gui repo?
07:01 < gribble> https://github.com/bitcoin/bitcoin/issues/21694 | build: Use XLIFF file to provide more context to Transifex translators by hebasto · Pull Request #21694 · bitcoin/bitcoin · GitHub
07:02 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
07:05 < wumpus> hebasto: I think it would make sense to make a new issue for it, also so that translators can comment maybe
07:05 < wumpus> would make sense to send some announcement on transifex as well
07:06 < hebasto> good idea!
07:07 < hebasto> fwiw, I posted https://twitter.com/hhebasto/status/1384848598714785792
07:35 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]
07:36 -!- OP_NOP [OP_NOP@gateway/vpn/privateinternetaccess/opnop/x-41418994] has joined #bitcoin-core-dev
07:42 -!- Spanktar [~Spanktar@195.140.213.38] has joined #bitcoin-core-dev
07:46 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
07:48 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
08:32 -!- OP_NOP [OP_NOP@gateway/vpn/privateinternetaccess/opnop/x-41418994] has quit [Ping timeout: 246 seconds]
08:33 -!- shesek [~shesek@unaffiliated/shesek] has quit [Remote host closed the connection]
08:33 -!- shesek [~shesek@164.90.217.137] has joined #bitcoin-core-dev
08:33 -!- shesek [~shesek@164.90.217.137] has quit [Changing host]
08:33 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
08:36 -!- proofofkeags_ [~proofofke@205.209.28.54] has joined #bitcoin-core-dev
08:58 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
09:04 -!- biteskola [~biteskola@170.76.76.188.dynamic.jazztel.es] has joined #bitcoin-core-dev
09:06 -!- biteskola [~biteskola@170.76.76.188.dynamic.jazztel.es] has quit [Read error: Connection reset by peer]
09:06 -!- biteskola [~biteskola@170.76.76.188.dynamic.jazztel.es] has joined #bitcoin-core-dev
09:25 -!- lkqwejhhgasdjhgn [~kljkljklk@p200300d46f169100125d29b1d7810672.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!]
09:35 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Ping timeout: 240 seconds]
09:37 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
09:42 -!- lightlike [~lightlike@p200300c7ef13f900c0bd9cb5668835d9.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
09:52 -!- IGHOR [~quassel@176.121.4.135] has quit [Read error: Connection reset by peer]
09:54 -!- IGHOR [~quassel@176.121.4.135] has joined #bitcoin-core-dev
10:00 -!- johonchain [~johnoncha@2a01:cb14:cf6:bc00:1c3:e45a:be45:2560] has quit [Ping timeout: 260 seconds]
10:01 -!- larryruane_ [uid473749@gateway/web/irccloud.com/x-elisawrkhzqhccwc] has joined #bitcoin-core-dev
10:02 -!- ironhelix [~d@154.6.28.63] has joined #bitcoin-core-dev
10:05 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
10:07 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
10:09 -!- will [~will@dynamic-190-25-109-205.dynamic.etb.net.co] has joined #bitcoin-core-dev
10:10 -!- will is now known as Guest87833
10:10 -!- Guest87833 [~will@dynamic-190-25-109-205.dynamic.etb.net.co] has quit [Client Quit]
10:25 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net]
10:28 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
10:33 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Ping timeout: 260 seconds]
10:39 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds]
10:49 -!- duringo [ad004d53@173.0.77.83] has joined #bitcoin-core-dev
10:50 -!- proofofkeags_ [~proofofke@205.209.28.54] has quit [Ping timeout: 252 seconds]
10:51 -!- proofofkeags [~proofofke@205.209.28.54] has joined #bitcoin-core-dev
10:51 -!- cguida [~Adium@205.209.28.54] has joined #bitcoin-core-dev
10:54 -!- smctwo [~smctwo@bba597217.alshamil.net.ae] has joined #bitcoin-core-dev
11:07 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev
11:30 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 245 seconds]
11:30 -!- sanket1729 [~sanket172@ec2-100-24-255-95.compute-1.amazonaws.com] has joined #bitcoin-core-dev
11:40 -!- sanket1729 [~sanket172@ec2-100-24-255-95.compute-1.amazonaws.com] has quit [Remote host closed the connection]
11:41 -!- sanket1729 [~sanket172@ec2-100-24-255-95.compute-1.amazonaws.com] has joined #bitcoin-core-dev
11:47 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
11:52 -!- Thor95 [4b48bcff@c-75-72-188-255.hsd1.mn.comcast.net] has quit [Quit: Connection closed]
11:59 < jnewbery> #proposedmeetingtopic adding a second BIP editor
11:59 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Ping timeout: 260 seconds]
12:02 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev
12:03 -!- promag [~promag@188.250.84.129] has quit [Read error: Connection reset by peer]
12:03 -!- promag_ [~promag@188.250.84.129] has joined #bitcoin-core-dev
12:16 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
12:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 252 seconds]
12:21 < hebasto> wumpus: luke-jr: https://github.com/bitcoin-core/gui/issues/287 presents the results of experimental usage of XLIFF translation file; your opinion will be much appreciated 
12:25 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
12:29 < wumpus> hebasto: thanks will take a look
12:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:35 < bitcoin-git> [bitcoin] whb07 opened pull request #21745: includes refactor pubkey.cpp/pubkey.h (master...refactor_imports_pubkey) https://github.com/bitcoin/bitcoin/pull/21745
12:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:39 -!- jungly [~jungly@host-79-35-191-191.retail.telecomitalia.it] has quit [Ping timeout: 240 seconds]
12:47 -!- smartineng [~Icedove@88.135.18.171] has quit [Quit: smartineng]
13:25 -!- mutatrum [~quassel@2001:984:6da9:1:9dee:c7fc:d23e:45fe] has joined #bitcoin-core-dev
13:26 -!- johonchain [~johnoncha@2a01:cb14:cf6:bc00:1c3:e45a:be45:2560] has joined #bitcoin-core-dev
13:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:29 < bitcoin-git> [gui] hebasto merged pull request #286: qt: Bump transifex slug for 22.x (master...2021-04-transifex-slug-022x) https://github.com/bitcoin-core/gui/pull/286
13:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:29 < bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e16f8720dca2...e7776e20ed0d
13:29 < bitcoin-git> bitcoin/master 4173059 W. J. van der Laan: qt: Bump transifex slug for 22.x
13:29 < bitcoin-git> bitcoin/master e7776e2 Hennadii Stepanov: Merge bitcoin-core/gui#286: qt: Bump transifex slug for 22.x
13:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:49 -!- mol_ [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
13:51 -!- mol [~mol@unaffiliated/molly] has quit [Ping timeout: 240 seconds]
14:00 -!- rhyslindmark [~rhyslindm@157-131-223-103.fiber.dynamic.sonic.net] has joined #bitcoin-core-dev
14:00 -!- rhyslindmark [~rhyslindm@157-131-223-103.fiber.dynamic.sonic.net] has quit [Client Quit]
14:20 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:24 -!- lightlike [~lightlike@p200300c7ef13f900c0bd9cb5668835d9.dip0.t-ipconnect.de] has quit [Quit: Leaving]
14:25 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 240 seconds]
14:26 -!- joerodgers [joerodgers@gateway/vpn/mullvad/joerodgers/x-62861712] has joined #bitcoin-core-dev
14:38 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
14:45 -!- smctwo [~smctwo@bba597217.alshamil.net.ae] has quit [Remote host closed the connection]
14:55 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
14:55 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
14:57 -!- biteskola [~biteskola@170.76.76.188.dynamic.jazztel.es] has quit [Ping timeout: 252 seconds]
15:02 -!- johonchain [~johnoncha@2a01:cb14:cf6:bc00:1c3:e45a:be45:2560] has quit [Ping timeout: 260 seconds]
15:07 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
15:51 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Ping timeout: 260 seconds]
15:56 -!- ogo [~ogo@gateway/tor-sasl/ogo] has quit [Quit: Leaving]
15:59 -!- instagibbs [~greg@119247204116.ctinets.com] has joined #bitcoin-core-dev
16:00 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev
16:07 -!- cguida [~Adium@205.209.28.54] has quit [Quit: Leaving.]
16:23 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 245 seconds]
16:24 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
16:26 -!- sanket1729 [~sanket172@ec2-100-24-255-95.compute-1.amazonaws.com] has quit [Ping timeout: 240 seconds]
16:27 -!- jonatack [jon@gateway/vpn/airvpn/jonatack] has quit [Ping timeout: 252 seconds]
16:28 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Ping timeout: 240 seconds]
16:33 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev
16:37 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Ping timeout: 260 seconds]
16:46 -!- vv8 [~egp_@2.95.117.163] has quit [Ping timeout: 260 seconds]
17:00 -!- sanket1729 [~sanket172@ec2-100-24-255-95.compute-1.amazonaws.com] has joined #bitcoin-core-dev
17:01 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
17:04 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 240 seconds]
17:05 -!- belcher_ is now known as belcher
17:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
17:20 < bitcoin-git> [bitcoin] jamesob opened pull request #21746: refactor: init: mark fReset const (master...2021-04-freset-const) https://github.com/bitcoin/bitcoin/pull/21746
17:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
17:29 -!- proofofkeags [~proofofke@205.209.28.54] has quit [Ping timeout: 245 seconds]
17:54 < yanmaani> How come Bitcoin doesn't use a custom assert macro? That way, if NDEBUG is set, assert could be ((void)__VA_ARGS__) instead, allowing for compilation without assertions to be made.
18:03 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Remote host closed the connection]
18:03 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev
18:12 < luke-jr> yanmaani: afaik it's UB to redefine assert?
18:12 < yanmaani> luke-jr: if assert.h is included, yes
18:12 < yanmaani> but a custom assert macro, i.e. #define assert2(...) is OK
18:12 < yanmaani> and so is redefining assert() without including assert.h
18:13 < yanmaani> so `#ifdef NDEBUG #define assert(...) ((void)__VA_ARGS__) #else #include <assert.h> #endif` should be OK
18:21 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
18:22 < yanmaani> Is there any easy way to get a CPubKey from a CScript or CTxDestination? Or do you simply have to re-implement the logic in SignStep/
18:22 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 246 seconds]
18:23 < yanmaani> Can you take the CScript, pass it into Solver(), and then case vSolutions[0] to a key ID?
18:23 < yanmaani> (a CKeyID)
18:27 < yanmaani> oh wait, ToKeyID(ExtractDestination(script)) should work right?
18:47 -!- vv8 [~egp_@2.95.117.163] has joined #bitcoin-core-dev
18:48 -!- someone235 [uid419897@gateway/web/irccloud.com/x-lgclatcodxssvxbu] has quit [Quit: Connection closed for inactivity]
18:58 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has quit [Ping timeout: 240 seconds]
18:59 -!- braydonf [~braydon@gateway/tor-sasl/braydonf] has joined #bitcoin-core-dev
19:19 -!- GarouDan [~GarouDan@191.242.119.219.fibra.plimtelecom.com.br] has quit [Remote host closed the connection]
19:26 -!- GarouDan [~GarouDan@191.242.119.219.fibra.plimtelecom.com.br] has joined #bitcoin-core-dev
19:29 -!- GarouDan [~GarouDan@191.242.119.219.fibra.plimtelecom.com.br] has quit [Remote host closed the connection]
20:10 -!- mol [~mol@unaffiliated/molly] has joined #bitcoin-core-dev
20:13 -!- mol_ [~mol@unaffiliated/molly] has quit [Ping timeout: 265 seconds]
20:25 < BlueMatt> yanmaani: bitcoin core generally has historically treated assert() as "if this isn't true, we probably have buggy hardware, or otherwise may lose funds, continuing is unsafe". so running without assertions is definitely *not* a goal
20:32 < jeremyrubin> keep in mind that it's much safer for the network *as a whole* to shut down as a result of an assertion violation than it is for an assumption to be violated
20:34 < jeremyrubin> but that sounds more like a wizards convo
20:43 < yanmaani> BlueMatt: true, but what if I want to...? but maybe then I should just take the 5 seconds to write another macro :P
20:43 < jeremyrubin> There's an Assume macro i think
20:43 < BlueMatt> what?
20:44 < yanmaani> jeremyrubin: Doesn't that do something else? "This is true else UB"
20:44 < jeremyrubin> no i think the RPCs use it to return errors
20:44 < BlueMatt> you asked why bitcoin core doesn't use something other than assert(), I answered why. There is, to my knowledge, nothing in bitcoin core that will abort() in a debug build and not in a release build, which appears to be what you want.
20:45 < BlueMatt> modulo a few subsystem-specific constructs
20:45 < jeremyrubin> yanmaani: if you want to get rid of then, best bet is to e.g. refactor code to not use pointers
20:45 < yanmaani> BlueMatt: right, I understand. And I can sort of see why it wouldn't be worthwhile to add it, either. Since it's a 5 second change and all.
20:45 < yanmaani> jeremyrubin: I was thinking of __builtin_assume, sorry
20:46 < jeremyrubin> There are a few good examples where we use ptrs that could be references or reference_wrappers
20:46 < jeremyrubin> so maybe try to refactor where we're using non nullable ptr asserts
21:05 -!- roconnor [~roconnor@host-45-58-216-246.dyn.295.ca] has quit [Ping timeout: 260 seconds]
21:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
21:28 < bitcoin-git> [bitcoin] widecoin-project opened pull request #21748: 1.1 (master...1.1) https://github.com/bitcoin/bitcoin/pull/21748
21:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
21:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
21:29 < bitcoin-git> [bitcoin] fanquake closed pull request #21748: 1.1 (master...1.1) https://github.com/bitcoin/bitcoin/pull/21748
21:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
21:30 -!- GarouDan [~GarouDan@191.242.119.219.fibra.plimtelecom.com.br] has joined #bitcoin-core-dev
21:34 -!- GarouDan [~GarouDan@191.242.119.219.fibra.plimtelecom.com.br] has quit [Ping timeout: 240 seconds]
21:47 -!- einyx_ [einyx@fsf/member/einyx] has joined #bitcoin-core-dev
21:47 -!- einyx [einyx@fsf/member/einyx] has quit [Ping timeout: 260 seconds]
21:54 -!- smctwo [~smctwo@bba597217.alshamil.net.ae] has joined #bitcoin-core-dev
21:57 -!- smctwo [~smctwo@bba597217.alshamil.net.ae] has quit [Remote host closed the connection]
22:00 -!- smartineng [~Icedove@88.135.18.171] has joined #bitcoin-core-dev
22:00 -!- smartineng [~Icedove@88.135.18.171] has quit [Excess Flood]
22:01 -!- smartineng [~Icedove@88.135.18.171] has joined #bitcoin-core-dev
22:25 -!- ogo [~ogo@gateway/tor-sasl/ogo] has joined #bitcoin-core-dev
22:25 -!- ogo_ogo [~ogo@gateway/tor-sasl/ogo] has joined #bitcoin-core-dev
22:33 -!- _rny [~rny@gateway/tor-sasl/renlord] has quit [Remote host closed the connection]
22:36 -!- rny [~rny@gateway/tor-sasl/renlord] has joined #bitcoin-core-dev
22:55 -!- Spanktar [~Spanktar@195.140.213.38] has quit [Remote host closed the connection]
22:57 -!- jeremyrubin [~jr@024-176-247-182.res.spectrum.com] has quit [Ping timeout: 240 seconds]
22:59 -!- jeremyrubin [~jr@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev
23:17 -!- jungly [~jungly@host-79-35-189-233.retail.telecomitalia.it] has joined #bitcoin-core-dev
23:23 -!- jungly [~jungly@host-79-35-189-233.retail.telecomitalia.it] has quit [Ping timeout: 260 seconds]
23:23 -!- jungly [~jungly@host-79-35-189-233.retail.telecomitalia.it] has joined #bitcoin-core-dev
23:36 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev
23:51 < jnewbery> yanmaani: I think you're looking for ASSUME(). Take a look in src/util/check.h
--- Log closed Thu Apr 22 00:00:33 2021