--- Log opened Wed Jun 02 00:00:26 2021 00:03 -!- dvd [~dvd@nat-pool-rdu-t.redhat.com] has quit [Read error: Connection reset by peer] 00:04 -!- dvd [~dvd@nat-pool-rdu-t.redhat.com] has joined #bitcoin-core-dev 00:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:21 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/a83bbf02c762...2fccd9cf3036 00:21 < bitcoin-git> bitcoin/master e3c866e Martin Ankerl: test: update nanobench from release 4.0.0 to 4.3.4 00:21 < bitcoin-git> bitcoin/master 44d05d0 Martin Ankerl: test: remove sanitizer suppression for nanobench 00:21 < bitcoin-git> bitcoin/master 2fccd9c MarcoFalke: Merge bitcoin/bitcoin#22082: test: update nanobench from release 4.0.0 to ... 00:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:21 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #22082: test: update nanobench from release 4.0.0 to 4.3.4 (master...2021-05-update-nanobench) https://github.com/bitcoin/bitcoin/pull/22082 00:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:33 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection] 00:33 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev 00:33 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 252 seconds] 00:42 -!- linuxgeek [linuxgeek@14-203-172-78.tpgi.com.au] has joined #bitcoin-core-dev 00:44 -!- Kiminuo [~Kiminuo@141.98.103.180] has joined #bitcoin-core-dev 00:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:49 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #22121: doc: Various validation doc fixups (master...2106-docVal) https://github.com/bitcoin/bitcoin/pull/22121 00:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:52 -!- lkqwejhhgasdjhgn [~kljkljklk@p200300d46f03bc00450477d61102fa6c.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 01:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:04 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #22122: ci: Bump macOS image to big-sur-xcode-12.5 (master...2106-ciMac) https://github.com/bitcoin/bitcoin/pull/22122 01:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:25 -!- ksprd2 [~ksprd@212.14.60.132] has joined #bitcoin-core-dev 01:31 < hebasto> gh did not update a pr after force pushing my local branch -- any advice? 01:32 < _aj_> push the parent commit, then re-push the commit you actually want 01:33 < hebasto> _aj_: thanks, will try it 01:33 < jnewbery> github doesn't seem to be letting me leave comments right now. Maybe they're having a partial outage? 01:33 < _aj_> (or make a dummy child commit, then get rid of it) 01:35 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 01:36 < jnewbery> yeah, github is having lots of issues right now 01:37 < hebasto> indeed, https://www.githubstatus.com/incidents/76nv9h8pmkv4?utm_ts=1622622945 01:41 -!- smartin [~Icedove@88.135.18.171] has joined #bitcoin-core-dev 02:06 -!- evias [~evias__@196.red-88-6-131.staticip.rima-tde.net] has joined #bitcoin-core-dev 02:06 -!- evias [~evias__@196.red-88-6-131.staticip.rima-tde.net] has quit [Changing host] 02:06 -!- evias [~evias__@user/evias] has joined #bitcoin-core-dev 02:06 < promag> yup, issues downloading archives for depends build 02:07 < jnewbery> I'm able to leave comments again, so it's at least partially resolved 02:10 < hebasto> works for me too 02:11 < promag> #22123 fixes depends for m1 02:11 <@gribble> https://github.com/bitcoin/bitcoin/issues/22123 | depends: Fix qt.mk for mac arm64 by promag · Pull Request #22123 · bitcoin/bitcoin · GitHub 02:27 -!- sagi [~sagi@bzq-79-178-136-188.red.bezeqint.net] has quit [Ping timeout: 272 seconds] 02:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:28 < bitcoin-git> [bitcoin] promag opened pull request #22123: depends: Fix qt.mk for mac arm64 (master...2021-06-fix-aarch64_darwin) https://github.com/bitcoin/bitcoin/pull/22123 02:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:30 -!- hendi [sid489601@id-489601.tooting.irccloud.com] has joined #bitcoin-core-dev 02:30 -!- ksprd2 [~ksprd@212.14.60.132] has quit [Ping timeout: 272 seconds] 02:36 -!- ksprd2 [~ksprd@212.14.60.132] has joined #bitcoin-core-dev 02:41 -!- jonatack [~jonatack@user/jonatack] has quit [Quit: Ping timeout (120 seconds)] 02:41 -!- ksprd2 [~ksprd@212.14.60.132] has quit [Ping timeout: 244 seconds] 02:43 -!- sagi [~sagi@bzq-79-178-136-188.red.bezeqint.net] has joined #bitcoin-core-dev 02:56 -!- ksprd2 [~ksprd@212.14.60.132] has joined #bitcoin-core-dev 03:05 -!- ksprd2 [~ksprd@212.14.60.132] has quit [Ping timeout: 272 seconds] 03:16 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 03:16 -!- ksprd2 [~ksprd@212.14.60.132] has joined #bitcoin-core-dev 03:18 -!- belcher_ [~belcher@user/belcher] has quit [Ping timeout: 272 seconds] 03:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:24 < bitcoin-git> [gui] laanwj merged pull request #351: Translations update (master...210601-tr) https://github.com/bitcoin-core/gui/pull/351 03:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:25 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2fccd9cf3036...e3d644a127e1 03:25 < bitcoin-git> bitcoin/master 0680460 Hennadii Stepanov: qt: Translations update 03:25 < bitcoin-git> bitcoin/master e3d644a W. J. van der Laan: Merge bitcoin-core/gui#351: Translations update 03:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:28 -!- belcher [~belcher@user/belcher] has joined #bitcoin-core-dev 03:29 < fanquake> promag: what's wrong with it now. I thought that line had already been added to fix it 03:29 < fanquake> I wouldn't have to ask if that PR, or even the commit had a useful description 03:30 < fanquake> Why does this trend of opening description-less, or just very poorly explained PRs seem to be becoming more frequent 03:32 -!- ksprd2 [~ksprd@212.14.60.132] has quit [Ping timeout: 245 seconds] 03:35 < laanwj> yes lets encourage PRs to have useful descriptions 03:36 < laanwj> at the least: what does it change, what does it fix, even more helpful "how to test" "how to review" 03:40 -!- ksprd2 [~ksprd@212.14.60.132] has joined #bitcoin-core-dev 03:45 -!- ksprd2 [~ksprd@212.14.60.132] has quit [Ping timeout: 244 seconds] 03:46 -!- ksprd2 [~ksprd@212.14.60.132] has joined #bitcoin-core-dev 03:50 < fanquake> laanwj: Yes. I've tried to summarize something similar here: https://github.com/bitcoin/bitcoin/pull/21570#issuecomment-819220600 03:50 -!- ksprd2 [~ksprd@212.14.60.132] has quit [Ping timeout: 244 seconds] 03:51 -!- Guest64 [~Guest64@184.75.221.35] has joined #bitcoin-core-dev 03:52 -!- ksprd2 [~ksprd@212.14.60.132] has joined #bitcoin-core-dev 03:55 < _aj_> yay for descriptive PR descriptions 03:56 < michaelfolkson> Is this worth putting in CONTRIBUTING.md? (the fanquake guidance) 03:57 -!- ksprd2 [~ksprd@212.14.60.132] has quit [Ping timeout: 272 seconds] 03:57 < laanwj> definitely (if there isn't anything like that in there yet) 03:58 -!- ksprd2 [~ksprd@212.14.60.132] has joined #bitcoin-core-dev 03:59 < michaelfolkson> OK happy to add this to my to do list (assuming fanquake doesn't want to open the PR) 04:02 < fanquake> I'm not fussed. I'd like to think it's obvious that when you open a PR, you should take 2 minutes to summarize your change, including relevant / useful info, and save reviewers having to ask dumb things like "what is the bug", "how does it fix it" etc. 04:02 -!- belcher [~belcher@user/belcher] has quit [Quit: Leaving] 04:05 -!- ksprd2 [~ksprd@212.14.60.132] has quit [Ping timeout: 245 seconds] 04:06 < laanwj> i agree, but mentioning it explicitly in a document might be useful to point people to instead of having to type it out time after time 04:06 < michaelfolkson> fanquake: Right but sometimes people struggle with what needs explaining to others when it is obvious to them. Guidance often helps as a reminder not to take shortcuts with explanations 04:09 -!- ksprd2 [~ksprd@212.14.60.132] has joined #bitcoin-core-dev 04:10 < michaelfolkson> I'll open the PR adding fanquake as a co-author then 04:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:10 < bitcoin-git> [bitcoin] hebasto opened pull request #22124: 0.20: Update translations after closing 0.20.x on Transifex (0.20...210602-0.20-tr) https://github.com/bitcoin/bitcoin/pull/22124 04:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:14 -!- ksprd2 [~ksprd@212.14.60.132] has quit [Ping timeout: 252 seconds] 04:15 -!- ksprd2 [~ksprd@212.14.60.132] has joined #bitcoin-core-dev 04:43 -!- belcher [~belcher@user/belcher] has joined #bitcoin-core-dev 04:57 -!- belcher [~belcher@user/belcher] has quit [Quit: Leaving] 04:57 -!- belcher [~belcher@user/belcher] has joined #bitcoin-core-dev 05:01 < hebasto> the Transifex.com labeled 33 languages with the "no translators" label. Those languages look abandoned as zero strings are translated for all versions. Suggesting to remove them to keep our repository tide. Or is this a topic for a weekly meeting? 05:02 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 05:03 < laanwj> hebasto: the transifex import script is supposed to strip empty translations, doesn't it do this anymore? 05:06 < laanwj> that would be the place to solve it, i think it's okay to leave the languages on transifex so that people who want to translate them can do so 05:06 < hebasto> ah, right -- no empty translations in the repo, it works 05:07 < laanwj> i tend to universally accept requests to add base languages (e.g. "nl"), but careful about adding dialects "nl_EN", too easy to come up with nonsense ones and i don't have time to investigate this 05:07 < hebasto> sounds reasonable to me 05:12 < laanwj> though i wish the language requests came with a description field so people can provide more information about the language they want to translate to, this would make it easier to recognize non-flippant requests 05:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:15 < bitcoin-git> [bitcoin] dgoncharov opened pull request #22126: build: Disable make builtin rules. (master...disable_builtin_rules) https://github.com/bitcoin/bitcoin/pull/22126 05:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:15 < laanwj> unfortunately translations provide a fairly easy vandalism angle for people that want to mess with things, because it's inherently hard to check for language you don't know 05:27 < hebasto> as usually in open-source, translationss are done and kept in a good state by people who care about it. If nobody cares, the result is unpredicted 05:28 < hebasto> *translations 05:30 < laanwj> right, it's just even more complicated by language barriers 05:34 -!- Kiminuo [~Kiminuo@141.98.103.180] has quit [Ping timeout: 272 seconds] 05:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:47 < bitcoin-git> [bitcoin] Vaultbank opened pull request #22128: Create Lil* (master...patch-1) https://github.com/bitcoin/bitcoin/pull/22128 05:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:48 < bitcoin-git> [bitcoin] fanquake closed pull request #22128: Create Lil* (master...patch-1) https://github.com/bitcoin/bitcoin/pull/22128 05:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:48 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 252 seconds] 05:48 < laanwj> that was fast :) 06:06 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 06:18 < ufotofu> are the build instructions for linux slightly out of date? the past couple of times i've attempted building have resulted in a libboost related error that was resolved by installing libboost-all-dev (on ubuntu). 06:18 < laanwj> as far as i know they are up to date, which version of ubuntu are you using 06:19 < ufotofu> not sure which package it needed specifically, out of the many libboost-all-dev installs 06:19 < ufotofu> 21.04 06:19 < laanwj> libboost-all-dev is al extreme sledgehammer so we would like to avoid that 06:19 < ufotofu> yeah understood 06:20 < ufotofu> this occurred on ppc64le and now on riscv64 too. can't remember if i ran into it on x86_64. 06:22 < promag> fanquake: yup my bad 06:23 < laanwj> that might explain things, i suppose most people following the instrucitons will be using x86_64, ppc and risc-v are usually cross-compiled, anyhow let us know if you figure out which package is missing 06:24 < laanwj> it might also be a bug in the platform-specific parts of the boost detection am scripting (vaguely remember that a architecture-specific path is injected somewhere) 06:31 < ufotofu> pretty sure i ran into it on arm64 too so you're probably right 06:34 -!- ksprd2 [~ksprd@212.14.60.132] has quit [Ping timeout: 245 seconds] 06:36 -!- ksprd2 [~ksprd@212.14.60.132] has joined #bitcoin-core-dev 06:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:48 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to 0.20: https://github.com/bitcoin/bitcoin/compare/55631547ea88...8b5c83b4aa8c 06:48 < bitcoin-git> bitcoin/0.20 56baeba Hennadii Stepanov: 0.20: Update translations after closing 0.20.x on Transifex 06:48 < bitcoin-git> bitcoin/0.20 8b5c83b W. J. van der Laan: Merge bitcoin/bitcoin#22124: 0.20: Finalize translations after closing 0.2... 06:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:48 < bitcoin-git> [bitcoin] laanwj merged pull request #22124: 0.20: Finalize translations after closing 0.20.x on Transifex (0.20...210602-0.20-tr) https://github.com/bitcoin/bitcoin/pull/22124 06:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:53 -!- thedragon [~thedragon@user/thedragon] has quit [Quit: Leaving] 06:58 -!- davterra [~davterra@178.128.106.205] has quit [Ping timeout: 264 seconds] 06:58 < laanwj> ufotofu: see also #17010 06:58 <@gribble> https://github.com/bitcoin/bitcoin/issues/17010 | Missing Boost::System on ARM Ubuntu 18.04 · Issue #17010 · bitcoin/bitcoin · GitHub 06:59 < laanwj> might need a similar change like #18558 for ppc and risc-v 06:59 <@gribble> https://github.com/bitcoin/bitcoin/issues/18558 | build: Fix boost detection for arch armv7l by hebasto · Pull Request #18558 · bitcoin/bitcoin · GitHub 06:59 -!- davterra [~davterra@178.128.106.205] has joined #bitcoin-core-dev 07:00 < laanwj> unfortunately there's all kinds of variability in directory names and it needs to be handled per platform... 07:02 < ufotofu> hm might be related. i'm running into it after running `make`. 07:03 < laanwj> okay that seems to be a different issue 07:03 < ufotofu> configure doesn't seem to catch that it's missing 07:10 < laanwj> i'd be very interested to know t he exact error you are getting 07:15 < ufotofu> https://pastebin.com/raw/GfvaFpXG 07:15 < ufotofu> that's all that was still in my buffer 07:19 < laanwj> thanks-that looks like boost_thread isn't linked correctly, which is weird, i guess this is for 0.21? fwiw the master branch no longer uses boost thread at all so might have solved this issue 07:19 -!- thedragon [~thedragon@user/thedragon] has joined #bitcoin-core-dev 07:19 < ufotofu> v0.21.1 07:23 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has quit [Quit: Konversation terminated!] 07:24 < hebasto> ufotofu: https://github.com/bitcoin/bitcoin/blob/0.21/doc/build-unix.md mentions the `libboost-thread-dev` package 07:25 < promag> fanquake: added details 07:26 < ufotofu> hebasto: hmm not under the ubuntu & debian dependency build instructions though 07:28 < ufotofu> i don't see where it specifically mentions libboost-thread-dev either 07:28 < hebasto> have you followed the link https://github.com/bitcoin/bitcoin/blob/0.21/doc/build-unix.md ? 07:29 < ufotofu> oh, right 07:29 < laanwj> it might be that you followed the instructions on the master branch, which don't mention installing boost-thread-dev because it is no longer needed 07:29 < ufotofu> aha ok that makes sense 07:32 < ufotofu> ok sorry for wasting your time >_> 07:33 < hebasto> np, happy your problem is solved 07:33 < laanwj> no problem, i think it's a bug that configure doesn't report the missing library but it fails at link time, though probably not worth fixing anymore 07:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:53 < bitcoin-git> [bitcoin] laanwj pushed 17 commits to master: https://github.com/bitcoin/bitcoin/compare/e3d644a127e1...a7d17daa5cd8 07:53 < bitcoin-git> bitcoin/master 883a5c7 fanquake: test: remove BasicTestingSetup from allocator unit tests 07:53 < bitcoin-git> bitcoin/master 0559065 fanquake: test: remove BasicTestingSetup from amount unit tests 07:53 < bitcoin-git> bitcoin/master 4c389ba fanquake: test: remove BasicTestingSetup from arith_uint256 unit tests 07:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:53 < bitcoin-git> [bitcoin] laanwj merged pull request #22086: test: remove BasicTestingSetup from unit tests that don't need it (master...remove_unneeded_test_setup) https://github.com/bitcoin/bitcoin/pull/22086 07:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:01 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a7d17daa5cd8...1186910b6b7b 08:01 < bitcoin-git> bitcoin/master dafab2b Jarol Rodriguez: doc: improve note on choosing posix mingw32 08:01 < bitcoin-git> bitcoin/master 1186910 W. J. van der Laan: Merge bitcoin/bitcoin#22088: doc: improve note on choosing posix mingw32 08:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:01 < bitcoin-git> [bitcoin] laanwj merged pull request #22088: doc: improve note on choosing posix mingw32 (master...windows-ubuntu-note) https://github.com/bitcoin/bitcoin/pull/22088 08:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:10 -!- prusnak [sid403625@tooting.irccloud.com] has quit [Changing host] 08:10 -!- prusnak [sid403625@user/prusnak] has joined #bitcoin-core-dev 08:25 -!- Guest64 [~Guest64@184.75.221.35] has quit [Quit: Client closed] 08:26 -!- jonatack [jonatack@user/jonatack] has joined #bitcoin-core-dev 08:50 -!- jarthur [~jarthur@2603-8080-1540-002d-f5de-bb6e-193b-06d2.res6.spectrum.com] has joined #bitcoin-core-dev 08:59 -!- jonatack [jonatack@user/jonatack] has left #bitcoin-core-dev [] 09:17 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 09:20 < hebasto> achow101: meshcollider: how we could get debugging info about wallet load crash in a way safe for users? (context -- #22083) 09:21 <@gribble> https://github.com/bitcoin/bitcoin/issues/22083 | Bitcoin-Qt crashes on OS X · Issue #22083 · bitcoin/bitcoin · GitHub 09:25 -!- lkqwejhhgasdjhgn [~kljkljklk@p200300d46f03bc00450477d61102fa6c.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!] 09:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:28 < bitcoin-git> [bitcoin] theStack opened pull request #22130: test: refactor: dedup utility function chain_transaction() (master...20210601-test-dedup_chain_transaction) https://github.com/bitcoin/bitcoin/pull/22130 09:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:40 -!- ksprd2 [~ksprd@212.14.60.132] has quit [Ping timeout: 245 seconds] 09:42 -!- evias [~evias__@user/evias] has quit [Quit: Leaving] 09:54 < hebasto> laanwj: could you have a look at https://github.com/bitcoin/bitcoin/pull/21654#issuecomment-839428062, please? 09:56 < achow101> hebasto: the best way would be to get them to be able to replicate the crash on testnet or regtest and then send us the offending wallet file 10:01 -!- lightlike [~lightlike@user/lightlike] has joined #bitcoin-core-dev 10:13 -!- b10c [uid500648@id-500648.charlton.irccloud.com] has joined #bitcoin-core-dev 10:16 -!- sagi [~sagi@bzq-79-178-136-188.red.bezeqint.net] has quit [Ping timeout: 245 seconds] 10:23 -!- AaronvanW [~AaronvanW@12.174.108.202] has joined #bitcoin-core-dev 10:23 -!- AaronvanW [~AaronvanW@12.174.108.202] has quit [Remote host closed the connection] 10:25 -!- sagi [~sagi@bzq-79-178-136-188.red.bezeqint.net] has joined #bitcoin-core-dev 10:30 -!- sagi [~sagi@bzq-79-178-136-188.red.bezeqint.net] has quit [Ping timeout: 244 seconds] 10:43 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Ping timeout: 272 seconds] 10:43 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev 11:08 -!- bomb-on [~bomb-on@194.144.47.113] has joined #bitcoin-core-dev 11:24 -!- AaronvanW [~AaronvanW@207.200.214.109] has joined #bitcoin-core-dev 11:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:31 < bitcoin-git> [bitcoin] hebasto opened pull request #22133: build, qt: Make QWindowsVistaStylePlugin available again (regression) (master...210602-style) https://github.com/bitcoin/bitcoin/pull/22133 11:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:37 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1186910b6b7b...2aab8a6dd0b5 11:37 < bitcoin-git> bitcoin/master 9a09695 Fu Yong Quah: build: Add /opt/homebrew to path to look for boost libraries 11:37 < bitcoin-git> bitcoin/master 2aab8a6 W. J. van der Laan: Merge bitcoin/bitcoin#21231: Add /opt/homebrew to path to look for boost l... 11:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:38 < bitcoin-git> [bitcoin] laanwj merged pull request #21231: Add /opt/homebrew to path to look for boost libraries (master...modify-boost-path-for-m1-macs) https://github.com/bitcoin/bitcoin/pull/21231 11:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:38 -!- roconnor_ [~roconnor@host-45-58-218-136.dyn.295.ca] has joined #bitcoin-core-dev 11:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:39 < bitcoin-git> [gui] hebasto closed pull request #322: Improve Overview tab look on Windows (master...210508-frame) https://github.com/bitcoin-core/gui/pull/322 11:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:41 -!- roconnor [~roconnor@host-184-164-3-109.dyn.295.ca] has quit [Ping timeout: 252 seconds] 11:41 -!- powerjungle [~powerjung@h081217087223.dyn.cm.kabsi.at] has quit [Quit: ZNC - https://znc.in] 11:52 -!- roconnor_ is now known as roconnor 12:02 -!- powerjungle [~powerjung@h081217087223.dyn.cm.kabsi.at] has joined #bitcoin-core-dev 12:29 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:57 -!- smartin [~Icedove@88.135.18.171] has quit [Quit: smartin] 13:23 -!- b10c [uid500648@id-500648.charlton.irccloud.com] has quit [Quit: Connection closed for inactivity] 13:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:42 < bitcoin-git> [bitcoin] kiminuo opened pull request #22135: CRegTestParams: Use `args` instead of `gArgs`. (master...feature/2021-06-02-chainparams-n-gArgs) https://github.com/bitcoin/bitcoin/pull/22135 13:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:52 -!- AaronvanW [~AaronvanW@207.200.214.109] has quit [Remote host closed the connection] 14:02 -!- evias [~evias__@196.red-88-6-131.staticip.rima-tde.net] has joined #bitcoin-core-dev 14:02 -!- evias [~evias__@196.red-88-6-131.staticip.rima-tde.net] has quit [Changing host] 14:02 -!- evias [~evias__@user/evias] has joined #bitcoin-core-dev 15:43 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Ping timeout: 252 seconds] 15:58 -!- evias [~evias__@user/evias] has quit [Quit: This computer has gone to sleep] 16:07 -!- bomb-on [~bomb-on@194.144.47.113] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 16:31 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev 17:02 -!- jarthur [~jarthur@2603-8080-1540-002d-f5de-bb6e-193b-06d2.res6.spectrum.com] has quit [Ping timeout: 264 seconds] 17:07 -!- jarthur [~jarthur@2603-8080-1540-002d-f5de-bb6e-193b-06d2.res6.spectrum.com] has joined #bitcoin-core-dev 17:07 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 17:08 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Ping timeout: 272 seconds] 17:10 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 252 seconds] 17:11 -!- lightlike [~lightlike@user/lightlike] has quit [Quit: Leaving] 17:14 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 17:21 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 252 seconds] 17:39 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 17:39 -!- Zenton [~user@user/zenton] has quit [Remote host closed the connection] 17:55 < fanquake> promag: thanks 18:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:19 < bitcoin-git> [bitcoin] Empact reopened pull request #13226: Optimize SelectCoinsBnB by tracking the selection by index rather than by position (master...select-bnb-by-index) https://github.com/bitcoin/bitcoin/pull/13226 18:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:24 -!- jarthur [~jarthur@2603-8080-1540-002d-f5de-bb6e-193b-06d2.res6.spectrum.com] has quit [Remote host closed the connection] 18:24 -!- jarthur_ [~jarthur@cpe-70-114-198-37.austin.res.rr.com] has joined #bitcoin-core-dev 18:25 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 252 seconds] 18:34 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 19:56 -!- jarthur_ [~jarthur@cpe-70-114-198-37.austin.res.rr.com] has quit [Read error: Connection reset by peer] 20:00 -!- jarthur [~jarthur@2603-8080-1540-002d-f5de-bb6e-193b-06d2.res6.spectrum.com] has joined #bitcoin-core-dev 21:31 -!- jarthur_ [~jarthur@2603-8080-1540-002d-2dc9-1669-3128-3208.res6.spectrum.com] has joined #bitcoin-core-dev 21:32 -!- belcher_ [~belcher@user/belcher] has joined #bitcoin-core-dev 21:35 -!- jarthur [~jarthur@2603-8080-1540-002d-f5de-bb6e-193b-06d2.res6.spectrum.com] has quit [Ping timeout: 264 seconds] 21:36 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 245 seconds] 21:43 -!- dongcarl [~dongcarl@96.224.58.144] has quit [Ping timeout: 244 seconds] 22:01 -!- dongcarl [~dongcarl@96.224.58.144] has joined #bitcoin-core-dev 22:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:47 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2aab8a6dd0b5...fd7a770d32af 22:47 < bitcoin-git> bitcoin/master faa8dfd MarcoFalke: ci: Bump macOS image to big-sur-xcode-12.5 22:47 < bitcoin-git> bitcoin/master fd7a770 MarcoFalke: Merge bitcoin/bitcoin#22122: ci: Bump macOS image to big-sur-xcode-12.5 22:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:48 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #22122: ci: Bump macOS image to big-sur-xcode-12.5 (master...2106-ciMac) https://github.com/bitcoin/bitcoin/pull/22122 22:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:16 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fd7a770d32af...001116719191 23:16 < bitcoin-git> bitcoin/master 5f23531 Kiminuo: CRegTestParams: Use `args` instead of `gArgs`. 23:16 < bitcoin-git> bitcoin/master 0011167 MarcoFalke: Merge bitcoin/bitcoin#22135: CRegTestParams: Use `args` instead of `gArgs`... 23:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:16 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #22135: CRegTestParams: Use `args` instead of `gArgs`. (master...feature/2021-06-02-chainparams-n-gArgs) https://github.com/bitcoin/bitcoin/pull/22135 23:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:19 -!- senx8 [~senx@2600:1700:42f0:f60:c0f4:898b:4a73:14b1] has joined #bitcoin-core-dev 23:20 -!- SenX [~textual@2600:1700:42f0:f60:c0f4:898b:4a73:14b1] has joined #bitcoin-core-dev 23:22 -!- senx8 [~senx@2600:1700:42f0:f60:c0f4:898b:4a73:14b1] has quit [Client Quit] 23:25 -!- sagi [~sagi@bzq-79-178-136-188.red.bezeqint.net] has joined #bitcoin-core-dev 23:27 -!- linuxgeek [linuxgeek@14-203-172-78.tpgi.com.au] has left #bitcoin-core-dev [] 23:44 -!- jarthur [~jarthur@2603-8080-1540-002d-7c3e-5f85-a09f-91e1.res6.spectrum.com] has joined #bitcoin-core-dev 23:48 -!- jarthur_ [~jarthur@2603-8080-1540-002d-2dc9-1669-3128-3208.res6.spectrum.com] has quit [Ping timeout: 272 seconds] 23:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:54 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/001116719191...a9435e34457e 23:54 < bitcoin-git> bitcoin/master 3737126 practicalswift: Mark `CheckTxInputs` `[[nodiscard]]` (out-param `txfee` only set if call i... 23:54 < bitcoin-git> bitcoin/master a9435e3 MarcoFalke: Merge bitcoin/bitcoin#22065: Mark `CheckTxInputs` `[[nodiscard]]`. Avoid U... 23:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:54 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #22065: Mark `CheckTxInputs` `[[nodiscard]]`. Avoid UUM in fuzzing harness `coins_view`. (master...nodiscard-CheckTxInputs) https://github.com/bitcoin/bitcoin/pull/22065 23:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] --- Log closed Thu Jun 03 00:00:28 2021