--- Log opened Sun Jun 06 00:00:30 2021 00:46 -!- Kiminuo [~Kiminuo@141.98.103.140] has joined #bitcoin-core-dev 00:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:47 < bitcoin-git> [bitcoin] sipa opened pull request #22166: Add support for inferring tr() descriptors (master...202106_infer_tap) https://github.com/bitcoin/bitcoin/pull/22166 00:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:10 -!- smartin [~Icedove@88.135.18.171] has joined #bitcoin-core-dev 01:20 -!- evias [~evias__@user/evias] has joined #bitcoin-core-dev 01:31 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 01:33 -!- gribble [~gribble@bitcoin/bot/gribble] has quit [Remote host closed the connection] 01:36 -!- gribble [~gribble@bitcoin/bot/gribble] has joined #bitcoin-core-dev 01:36 -!- mode/#bitcoin-core-dev [+o gribble] by ChanServ 01:43 -!- evias [~evias__@user/evias] has quit [Quit: This computer has gone to sleep] 02:08 -!- Kiminuo [~Kiminuo@141.98.103.140] has quit [Ping timeout: 250 seconds] 02:21 -!- kabaum [~kabaum@host-78-77-217-248.mobileonline.telia.com] has joined #bitcoin-core-dev 02:26 -!- bomb-on [~bomb-on@194.144.47.113] has joined #bitcoin-core-dev 02:34 -!- gribble [~gribble@bitcoin/bot/gribble] has quit [Remote host closed the connection] 02:38 -!- kabaum [~kabaum@host-78-77-217-248.mobileonline.telia.com] has quit [Ping timeout: 272 seconds] 02:40 -!- gribble [~gribble@bitcoin/bot/gribble] has joined #bitcoin-core-dev 02:40 -!- mode/#bitcoin-core-dev [+o gribble] by ChanServ 03:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:00 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #22167: refactor: Remove char serialize (master...2105-uin8t) https://github.com/bitcoin/bitcoin/pull/22167 03:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:30 -!- evias [~evias__@user/evias] has joined #bitcoin-core-dev 03:36 -!- rahulbile [~rahulbile@103.80.117.111] has joined #bitcoin-core-dev 03:58 -!- evias [~evias__@user/evias] has quit [Quit: This computer has gone to sleep] 04:25 -!- rahulbile [~rahulbile@103.80.117.111] has quit [Quit: Client closed] 04:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:37 < bitcoin-git> [bitcoin] promag opened pull request #22168: wallet: Avoid exception when loading with unsupported external signer (master...2021-06-wallet-extsig) https://github.com/bitcoin/bitcoin/pull/22168 04:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:02 -!- ratelius [ratelius@gateway/vpn/protonvpn/ratelius] has quit [Ping timeout: 264 seconds] 05:09 -!- evias [~evias__@user/evias] has joined #bitcoin-core-dev 05:11 -!- evias [~evias__@user/evias] has quit [Client Quit] 05:22 -!- Guest6773 [~Guest67@184.75.209.46] has joined #bitcoin-core-dev 05:54 -!- kabaum [~kabaum@host-78-77-217-248.mobileonline.telia.com] has joined #bitcoin-core-dev 06:05 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 06:06 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 06:18 -!- kabaum [~kabaum@host-78-77-217-248.mobileonline.telia.com] has quit [Ping timeout: 264 seconds] 06:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:37 < bitcoin-git> [gui] promag closed pull request #88: Support block hash alias in console (master...2020-09-block-alias-console) https://github.com/bitcoin-core/gui/pull/88 06:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:57 < bitcoin-git> [bitcoin] jonatack opened pull request #22169: p2p, rpc, fuzz: various tiny follow-ups (master...p2p-rpc-fuzz-various-followups) https://github.com/bitcoin/bitcoin/pull/22169 06:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:26 -!- jespada [~jespada@90.254.242.55] has joined #bitcoin-core-dev 07:32 -!- mamilis [uid502224@id-502224.tinside.irccloud.com] has quit [Quit: Connection closed for inactivity] 07:54 < michaelfolkson2> Do you do requests for your Twitch channel achow101? :) Wouldn't mind some Twitch review of some of the Taproot wallet support PRs e.g. #21365 and #22166. Or a Taproot wallet support PR you are working on but hasn't been opened yet 07:55 <@gribble> https://github.com/bitcoin/bitcoin/issues/21365 | Basic Taproot signing support for descriptor wallets by sipa · Pull Request #21365 · bitcoin/bitcoin · GitHub 07:55 <@gribble> https://github.com/bitcoin/bitcoin/issues/22166 | Add support for inferring tr() descriptors by sipa · Pull Request #22166 · bitcoin/bitcoin · GitHub 07:55 -!- michaelfolkson2 is now known as michaelfolkson 08:11 -!- nima [~nima@2001:1c00:2507:9000:786a:a400:73a0:e764] has joined #bitcoin-core-dev 08:11 -!- nima [~nima@2001:1c00:2507:9000:786a:a400:73a0:e764] has quit [Client Quit] 08:11 -!- n1rna [~n1rna@2001:1c00:2507:9000:786a:a400:73a0:e764] has joined #bitcoin-core-dev 08:11 < n1rna> hiall 08:11 < n1rna> quick question 08:12 < n1rna> I can't seem to be able to run the `verify-commit` script successfully 08:12 < n1rna> this is what I'm getting right now 08:12 < n1rna> ``` 08:12 < n1rna> ~/p/bitcoin$ ./contrib/verify-commits/verify-commits.py origin/master 08:12 < n1rna> Using verify-commits data from /home/nima/p/bitcoin/contrib/verify-commits 08:12 < n1rna> No parent of 38ab7d0765e52b8c9d93a677de70736a2e3a58a0 was signed with a trusted key! 08:12 < n1rna> Parents are: 08:12 < n1rna> commit 898dd9e262e4911fdf729bfe84b026c4e869802d 08:12 < n1rna> Merge: 8f5c9a7fd fa2b6c62c 08:12 < n1rna> Author: MarcoFalke 08:12 < n1rna> Date: Sat Jun 5 08:41:34 2021 +0200 08:12 < n1rna> Merge bitcoin/bitcoin#22150: test: Remove unused node from feature_nulldummy 08:12 < n1rna> fa2b6c62cd9a43d5896bb4b06a3ae64b7199843f test: Remove unused node from feature_nulldummy (MarcoFalke) 08:12 < n1rna> Pull request description: 08:12 < n1rna> This is confusing and might even slow down the test. 08:12 < n1rna> This reverts a change that was added a year ago in d438d60 and then the need for it was removed by 95d5d5e six months ago. 08:12 <@gribble> https://github.com/bitcoin/bitcoin/issues/22150 | test: Remove unused node from feature_nulldummy by MarcoFalke · Pull Request #22150 · bitcoin/bitcoin · GitHub 08:12 < n1rna> Top commit has no ACKs. 08:12 < n1rna> Tree-SHA512: 9a86792e9a634cf7bbd4e7a21b1acdfc3baba1b1962fe2b9b73848436d10351d2326dca01313c097ba2342dde7207add73e731d053c0bfa888a5d8f2b233a7cf 08:12 < n1rna> commit 69b8b5d72c47d42a9e69e6666af89606057be15b 08:12 < n1rna> Author: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> 08:12 < n1rna> Date: Wed May 12 21:39:48 2021 +0300 08:13 < n1rna> sorry for the formatting 08:13 < n1rna> but what am I doing wrong? 08:14 < n1rna> I also tried running this before running the verify script 08:14 < n1rna> `git log --merges --before="2 days ago" -1 --format='%H' > ./contrib/verify-commits/trusted-sha512-root-commit` 08:14 < n1rna> but no difference 08:18 < n1rna> Looks like marco's commits with `falke.marco@gmail.com` are not signed 08:27 -!- Guest44 [~Guest44@2001:1c00:2507:9000:786a:a400:73a0:e764] has joined #bitcoin-core-dev 08:27 < n1rna> any insights? 08:27 -!- Guest44 [~Guest44@2001:1c00:2507:9000:786a:a400:73a0:e764] has quit [Client Quit] 08:41 -!- Talkless [~Talkless@mail.dargis.net] has quit [Read error: Connection reset by peer] 08:42 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 08:51 -!- lorx [~mounty@2603-6080-5e02-fc6d-507b-f56b-8556-2c67.res6.spectrum.com] has joined #bitcoin-core-dev 08:51 -!- lorx [~mounty@2603-6080-5e02-fc6d-507b-f56b-8556-2c67.res6.spectrum.com] has quit [Remote host closed the connection] 09:02 -!- davterra [~davterra@178.128.106.205] has quit [Quit: Leaving] 09:07 -!- odhiaum [~eryigearl@ip210-219.telenet.dn.ua] has joined #bitcoin-core-dev 09:07 -!- odhiaum [~eryigearl@ip210-219.telenet.dn.ua] has quit [Remote host closed the connection] 09:39 -!- evias [~evias__@196.red-88-6-131.staticip.rima-tde.net] has joined #bitcoin-core-dev 09:39 -!- evias [~evias__@196.red-88-6-131.staticip.rima-tde.net] has quit [Changing host] 09:39 -!- evias [~evias__@user/evias] has joined #bitcoin-core-dev 09:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:39 < bitcoin-git> [bitcoin] baptistapedro opened pull request #22171: Create sanitizestring.cpp (master...fuzz-fix-SanitizeStr) https://github.com/bitcoin/bitcoin/pull/22171 09:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:17 < achow101> michaelfolkson: sure 10:17 < achow101> n1rna: please don't paste terminal outputsl like that, it's very spammy 10:17 < achow101> n1rna: the commits are signed, but marco's key has expired 10:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:28 < bitcoin-git> [bitcoin] jonatack opened pull request #22172: doc: update tor.md, release notes with removal of tor v2 support (master...tor-v2-removal-documentation) https://github.com/bitcoin/bitcoin/pull/22172 10:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:38 -!- evias [~evias__@user/evias] has quit [Ping timeout: 264 seconds] 10:42 -!- sagi [~sagi@bzq-79-183-156-48.red.bezeqint.net] has quit [Ping timeout: 245 seconds] 10:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:55 < bitcoin-git> [bitcoin] achow101 opened pull request #22173: wallet: Do not load external signers wallets when unsupported (master...check-external-signer-flags) https://github.com/bitcoin/bitcoin/pull/22173 10:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:02 < bitcoin-git> [bitcoin] promag closed pull request #22168: wallet: Avoid exception when loading with unsupported external signer (master...2021-06-wallet-extsig) https://github.com/bitcoin/bitcoin/pull/22168 11:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:15 -!- OP_NOP_ [~OP_NOP@154.3.250.73] has quit [Ping timeout: 264 seconds] 11:33 < n1rna> achow101 sorry for pasting the output. I sholdve used pastebin 11:37 -!- n1rna [~n1rna@2001:1c00:2507:9000:786a:a400:73a0:e764] has quit [Quit: Client closed] 11:53 -!- sagi [~sagi@bzq-79-183-156-48.red.bezeqint.net] has joined #bitcoin-core-dev 12:01 -!- sipa_ is now known as sipa 12:03 -!- Guest42 [~Guest42@2603-7000-af3f-1930-dceb-caa5-ffb5-89e0.res6.spectrum.com] has joined #bitcoin-core-dev 12:06 -!- Guest42 [~Guest42@2603-7000-af3f-1930-dceb-caa5-ffb5-89e0.res6.spectrum.com] has quit [Client Quit] 12:06 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:15 -!- sagi [~sagi@bzq-79-183-156-48.red.bezeqint.net] has quit [Ping timeout: 272 seconds] 12:39 < kanzure> MarcoFalke: i think you're using copy-paste for your "close github comment" comment text since it's always the same; might be worth updating the IRC channel network in the message. 12:51 -!- Guest6773 [~Guest67@184.75.209.46] has quit [Ping timeout: 250 seconds] 13:03 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Quit: Defeated by Superior] 13:09 < darosior> n1rna: had the same issue, you can get Marco's key from OpenPGP iirc 13:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:37 < bitcoin-git> [bitcoin] hebasto opened pull request #22174: build, qt: Fix libraries linking order for Linux hosts (master...210606-order) https://github.com/bitcoin/bitcoin/pull/22174 13:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:41 < hebasto> ^ hope it does not breach qt pull embargo :) 13:41 -!- copumpkin [~woohoo@user/copumpkin] has quit [Read error: Connection reset by peer] 13:43 -!- Guest7 [~Guest7@lnsm2-torontoxn-142-127-159-190.dsl.bell.ca] has joined #bitcoin-core-dev 13:44 -!- Guest7 [~Guest7@lnsm2-torontoxn-142-127-159-190.dsl.bell.ca] has quit [Client Quit] 13:45 -!- smartin [~Icedove@88.135.18.171] has quit [Quit: smartin] 14:05 -!- AaronvanW [~AaronvanW@207.200.214.109] has joined #bitcoin-core-dev 14:06 -!- AaronvanW [~AaronvanW@207.200.214.109] has quit [Remote host closed the connection] 14:08 -!- ratelius [ratelius@gateway/vpn/protonvpn/ratelius] has joined #bitcoin-core-dev 14:15 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev 14:17 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Read error: Connection reset by peer] 14:18 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev 14:20 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Read error: Connection reset by peer] 14:20 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev 14:29 -!- cncr04s [~cncr04s@afxr.net] has joined #bitcoin-core-dev 15:02 -!- belcher_ is now known as belcher 17:21 -!- earnestly [~earnest@user/earnestly] has quit [Ping timeout: 264 seconds] 18:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:02 < bitcoin-git> [bitcoin] sidhujag opened pull request #22175: Dev 4.x bls (master...dev-4.x-bls) https://github.com/bitcoin/bitcoin/pull/22175 18:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:02 < bitcoin-git> [bitcoin] sidhujag closed pull request #22175: Dev 4.x bls (master...dev-4.x-bls) https://github.com/bitcoin/bitcoin/pull/22175 18:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:41 -!- davterra [~davterra@178.128.106.205] has joined #bitcoin-core-dev 18:41 -!- AaronvanW [~AaronvanW@207.200.214.109] has joined #bitcoin-core-dev 18:50 -!- gwillen [~gwillen@user/gwillen] has quit [Ping timeout: 272 seconds] 18:50 -!- gwillen [~gwillen@li450-236.members.linode.com] has joined #bitcoin-core-dev 18:59 -!- jespada [~jespada@90.254.242.55] has quit [Ping timeout: 264 seconds] 19:01 -!- jespada [~jespada@90.254.242.55] has joined #bitcoin-core-dev 19:06 -!- bomb-on [~bomb-on@194.144.47.113] has quit [Quit: aллилѹіа!] 19:20 -!- tripleslash [~triplesla@user/tripleslash] has quit [Ping timeout: 272 seconds] 19:21 -!- tripleslash [~triplesla@user/tripleslash] has joined #bitcoin-core-dev 20:16 -!- Guest67 [~Guest67@192.145.117.228] has joined #bitcoin-core-dev 20:18 -!- Guest67 [~Guest67@192.145.117.228] has quit [Client Quit] 20:21 -!- p3r3grin [~kevin@user/p3r3grin] has joined #bitcoin-core-dev 20:45 -!- AaronvanW [~AaronvanW@207.200.214.109] has quit [Remote host closed the connection] 20:57 -!- earnestly [~earnest@user/earnestly] has joined #bitcoin-core-dev 21:01 -!- sagi [~sagi@bzq-79-183-156-48.red.bezeqint.net] has joined #bitcoin-core-dev 21:05 -!- sagi [~sagi@bzq-79-183-156-48.red.bezeqint.net] has quit [Ping timeout: 264 seconds] 21:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 21:07 < bitcoin-git> [bitcoin] Empact opened pull request #22176: test: Correct outstanding -Werror=sign-compare errors (master...2021-06-sign-compare) https://github.com/bitcoin/bitcoin/pull/22176 21:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 21:33 -!- belcher_ [~belcher@user/belcher] has joined #bitcoin-core-dev 21:34 -!- vnogueir- [~vnogueira@user/vnogueira] has joined #bitcoin-core-dev 21:35 -!- vnogueira [~vnogueira@user/vnogueira] has quit [Remote host closed the connection] 21:36 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 245 seconds] 22:01 -!- p3r3grin [~kevin@user/p3r3grin] has quit [Quit: WeeChat 3.1] 22:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:04 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e033ca137946...1cc123f40522 22:04 < bitcoin-git> bitcoin/master c274574 Jon Atack: p2p, rpc, fuzz: various tiny follow-ups 22:04 < bitcoin-git> bitcoin/master 1cc123f fanquake: Merge bitcoin/bitcoin#22169: p2p, rpc, fuzz: various tiny follow-ups 22:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:04 < bitcoin-git> [bitcoin] fanquake merged pull request #22169: p2p, rpc, fuzz: various tiny follow-ups (master...p2p-rpc-fuzz-various-followups) https://github.com/bitcoin/bitcoin/pull/22169 22:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:06 < bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/1cc123f40522...260b1d74fee1 22:06 < bitcoin-git> bitcoin/master b043ca8 fanquake: test: convert docs into type annotations in test_framework/util.py 22:06 < bitcoin-git> bitcoin/master 8bfcba3 fanquake: test: convert docs into type annotations in test_framework/wallet.py 22:06 < bitcoin-git> bitcoin/master 68ace23 fanquake: test: convert docs into type annotations in test_framework/test_node.py 22:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:06 < bitcoin-git> [bitcoin] fanquake merged pull request #22092: test: convert documentation into type annotations (master...more_mypy_test_utils) https://github.com/bitcoin/bitcoin/pull/22092 22:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:21 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/260b1d74fee1...791f985a6072 22:21 < bitcoin-git> bitcoin/master fa910b4 MarcoFalke: util: Properly handle -noincludeconf on command line 22:21 < bitcoin-git> bitcoin/master 791f985 fanquake: Merge bitcoin/bitcoin#22137: util: Properly handle -noincludeconf on comma... 22:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 22:21 < bitcoin-git> [bitcoin] fanquake merged pull request #22137: util: Properly handle -noincludeconf on command line (take 2) (master...2106-utilTake2) https://github.com/bitcoin/bitcoin/pull/22137 22:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 22:45 -!- Guest50 [~Guest50@2601:644:4202:2690:d14f:ede1:1c11:42f8] has joined #bitcoin-core-dev 22:53 -!- Guest50 [~Guest50@2601:644:4202:2690:d14f:ede1:1c11:42f8] has quit [Quit: Client closed] 23:20 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has joined #bitcoin-core-dev 23:29 -!- kabaum [~kabaum@h-46-59-13-35.A163.priv.bahnhof.se] has joined #bitcoin-core-dev --- Log closed Mon Jun 07 00:00:31 2021