--- Log opened Tue Jun 15 00:00:38 2021
00:08 < laanwj> NSIS has a possibility to add an EULA, and some projects use that to show the license, but always found it strange to show an open source license as one, you don't need to accept the license to use the software as it doesn't impose any instructions on use
00:08 < laanwj> instructions->limitations
00:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:09 < bitcoin-git> [bitcoin] S3RK opened pull request #22249: test: kill process group to avoid dangling processes when using `--failfast` (master...test_kill_process_group) https://github.com/bitcoin/bitcoin/pull/22249
00:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:20 -!- jespada [~jespada@90.254.242.55] has quit [Ping timeout: 264 seconds]
00:22 -!- jespada [~jespada@90.254.242.55] has joined #bitcoin-core-dev
00:42 -!- karliatto [~karliatto@195.122.197.178] has joined #bitcoin-core-dev
00:50 < vasild> laanwj: open source licenses usually contain something like "the author is not liable for any damages due to the use of software"
00:52 < laanwj> yes
00:53 < laanwj> i'm not opposed to showing the license, but treating it as an EULA that you have to agree to before continuing is strange for a FOSS license
01:01 -!- lkqwejhhgasdjhgn [~kljkljklk@p200300d46f03bc006aa596b89d3e737b.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
01:35 < instagibbs_> elichai2, ok well yes you're going to miss messages like that on block connect with such a low watermark
01:45 -!- evias [~evias__@196.red-88-6-131.staticip.rima-tde.net] has joined #bitcoin-core-dev
01:45 -!- evias [~evias__@196.red-88-6-131.staticip.rima-tde.net] has quit [Changing host]
01:45 -!- evias [~evias__@user/evias] has joined #bitcoin-core-dev
02:17 -!- evias [~evias__@user/evias] has quit [Quit: This computer has gone to sleep]
02:30 < glozow> could I ask for a rerun of this CI job please? https://github.com/bitcoin/bitcoin/pull/21800/checks?check_run_id=2821522273
02:36 -!- _aj_ [aj@cerulean.erisian.com.au] has quit [Changing host]
02:36 -!- _aj_ [aj@user/aj/x-5857768] has joined #bitcoin-core-dev
02:41 < laanwj> glozow: done
02:41 < glozow> laanwj: thank you! :)
02:45 -!- evias [~evias__@196.red-88-6-131.staticip.rima-tde.net] has joined #bitcoin-core-dev
02:45 -!- evias [~evias__@196.red-88-6-131.staticip.rima-tde.net] has quit [Changing host]
02:45 -!- evias [~evias__@user/evias] has joined #bitcoin-core-dev
03:37 -!- sagi [~sagi@bzq-79-180-140-8.red.bezeqint.net] has joined #bitcoin-core-dev
03:44 -!- sagi [~sagi@bzq-79-180-140-8.red.bezeqint.net] has quit [Ping timeout: 264 seconds]
03:58 -!- stevenroose [~steven@2001:19f0:6801:83a:5157:a229:22ca:bdf9] has quit [Quit: ZNC 1.7.4 - https://znc.in]
03:58 -!- stevenroose [~steven@2001:19f0:6801:83a:5b0:2160:99b2:6c0e] has joined #bitcoin-core-dev
04:09 -!- cdecker [~cdecker@243.86.254.84.ftth.as8758.net] has joined #bitcoin-core-dev
04:15 -!- belcher [~belcher@user/belcher] has joined #bitcoin-core-dev
04:29 < laanwj> we could use some more review for the taproot signing / descriptor support (#22166, #21365) would be nice to get into 22.0
04:29 <@gribble> https://github.com/bitcoin/bitcoin/issues/22166 | Add support for inferring tr() descriptors by sipa · Pull Request #22166 · bitcoin/bitcoin · GitHub
04:29 <@gribble> https://github.com/bitcoin/bitcoin/issues/21365 | Basic Taproot signing support for descriptor wallets by sipa · Pull Request #21365 · bitcoin/bitcoin · GitHub
04:50 -!- sagi [~sagi@bzq-79-180-140-8.red.bezeqint.net] has joined #bitcoin-core-dev
05:07 -!- sagi [~sagi@bzq-79-180-140-8.red.bezeqint.net] has quit [Ping timeout: 272 seconds]
05:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:14 < bitcoin-git> [bitcoin] vasild opened pull request #22250: doc: add basic I2P documentation (master...i2p_doc) https://github.com/bitcoin/bitcoin/pull/22250
05:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:25 < vasild> fanquake: wrt https://github.com/bitcoin/bitcoin/pull/22250#issuecomment-861453715 maybe jonatack meant "can be merged _even_ after FF", i.e. can be merged before or after FF
05:41 -!- l3kk0 [~l3kk0@c-73-22-213-40.hsd1.il.comcast.net] has quit [Remote host closed the connection]
05:42 -!- l3kk0 [~l3kk0@c-73-22-213-40.hsd1.il.comcast.net] has joined #bitcoin-core-dev
06:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:05 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #22251: [WIP] ci: Use cirrus isolation feature (master...2106-ciTest) https://github.com/bitcoin/bitcoin/pull/22251
06:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:08 -!- belcher [~belcher@user/belcher] has quit [Remote host closed the connection]
06:08 < fanquake> vasild: I guess. Documentation can be merged / fixed any time.
06:10 -!- belcher [~belcher@user/belcher] has joined #bitcoin-core-dev
06:24 -!- Nick3 [~Nick3@mx2.inteco-constr.com] has joined #bitcoin-core-dev
06:25 -!- niska [~niska@static.38.6.217.95.clients.your-server.de] has quit [Ping timeout: 252 seconds]
06:27 -!- niska [~niska@static.38.6.217.95.clients.your-server.de] has joined #bitcoin-core-dev
06:31 -!- davterra [~davterra@178.128.106.205] has joined #bitcoin-core-dev
06:46 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Ping timeout: 272 seconds]
06:53 -!- sagi [~sagi@bzq-79-180-140-8.red.bezeqint.net] has joined #bitcoin-core-dev
06:59 -!- karliatto [~karliatto@195.122.197.178] has quit [Quit: Konversation terminated!]
06:59 -!- sagi [~sagi@bzq-79-180-140-8.red.bezeqint.net] has quit [Ping timeout: 265 seconds]
07:10 < jonatack> fanquake: vasild: yes, that's what i was trying to say, in case the pull was opened today with urgent intention ;)
07:10 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has quit [Quit: Konversation terminated!]
07:20 -!- sagi [~sagi@bzq-79-180-140-8.red.bezeqint.net] has joined #bitcoin-core-dev
07:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:23 < bitcoin-git> [bitcoin] glozow opened pull request #22252: policy: Trim Packages when transaction with same txid exists in mempool (master...2021-06-mempool-matches) https://github.com/bitcoin/bitcoin/pull/22252
07:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:24 < bitcoin-git> [bitcoin] glozow opened pull request #22253: [validation/mempool] distinguish between same tx and same nonwitness tx already in mempool (master...2021-06-same-txid-diff-wtxid) https://github.com/bitcoin/bitcoin/pull/22253
07:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:25 -!- sibilant_ [~sibilant@194.59.250.58] has joined #bitcoin-core-dev
07:25 -!- sibilant_ [~sibilant@194.59.250.58] has quit [Changing host]
07:25 -!- sibilant_ [~sibilant@user/sibilant] has joined #bitcoin-core-dev
07:27 -!- b10c [uid500648@id-500648.charlton.irccloud.com] has quit []
07:27 -!- b10c [uid500648@id-500648.charlton.irccloud.com] has joined #bitcoin-core-dev
07:28 -!- sibilant [~sibilant@user/sibilant] has quit [Ping timeout: 268 seconds]
07:38 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
07:41 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 252 seconds]
07:41 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev
07:41 -!- Nick3 [~Nick3@mx2.inteco-constr.com] has quit [Quit: Leaving]
07:44 -!- [\\\] [~triplesla@user/tripleslash] has quit [Read error: Connection reset by peer]
07:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:45 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #22251: [WIP] ci: Use cirrus isolation feature (master...2106-ciTest) https://github.com/bitcoin/bitcoin/pull/22251
07:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:46 -!- tripleslash [~triplesla@user/tripleslash] has joined #bitcoin-core-dev
07:51 -!- major1 [~major@gateway/tor-sasl/major] has quit [Ping timeout: 252 seconds]
07:52 -!- major1 [~major@gateway/tor-sasl/major] has joined #bitcoin-core-dev
08:03 -!- sagi [~sagi@bzq-79-180-140-8.red.bezeqint.net] has quit [Ping timeout: 268 seconds]
08:11 -!- sibilant__ [~sibilant@194.59.250.58] has joined #bitcoin-core-dev
08:11 -!- sibilant__ [~sibilant@194.59.250.58] has quit [Changing host]
08:11 -!- sibilant__ [~sibilant@user/sibilant] has joined #bitcoin-core-dev
08:15 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Ping timeout: 265 seconds]
08:15 -!- sibilant_ [~sibilant@user/sibilant] has quit [Ping timeout: 265 seconds]
08:15 -!- niska [~niska@static.38.6.217.95.clients.your-server.de] has quit [Quit: Leaving]
08:15 -!- niska [~niska@static.38.6.217.95.clients.your-server.de] has joined #bitcoin-core-dev
08:35 -!- lkqwejhhgasdjhgn [~kljkljklk@p200300d46f03bc006aa596b89d3e737b.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!]
08:37 -!- AaronvanW [~AaronvanW@71pc74.sshunet.nl] has quit [Remote host closed the connection]
08:38 -!- cdecker [~cdecker@243.86.254.84.ftth.as8758.net] has quit [Ping timeout: 272 seconds]
08:40 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 252 seconds]
08:48 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
08:53 -!- cdecker [~cdecker@243.86.254.84.ftth.as8758.net] has joined #bitcoin-core-dev
09:08 -!- AaronvanW [~AaronvanW@71pc74.sshunet.nl] has joined #bitcoin-core-dev
09:10 -!- reez [~textual@45-30-22-183.lightspeed.nsvltn.sbcglobal.net] has joined #bitcoin-core-dev
09:12 -!- AaronvanW [~AaronvanW@71pc74.sshunet.nl] has quit [Ping timeout: 240 seconds]
09:15 -!- reez [~textual@45-30-22-183.lightspeed.nsvltn.sbcglobal.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
09:18 -!- nanotube [~nanotube@user/nanotube] has joined #bitcoin-core-dev
09:24 -!- Guest142 [~Guest14@177-86-157-80.netecom.net.br] has joined #bitcoin-core-dev
09:25 -!- Guest142 [~Guest14@177-86-157-80.netecom.net.br] has quit [Client Quit]
09:25 -!- AaronvanW [~AaronvanW@71pc74.sshunet.nl] has joined #bitcoin-core-dev
09:29 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Read error: Connection reset by peer]
09:30 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
09:30 -!- yanmaani1 is now known as yanmaani
09:35 -!- sagi [~sagi@bzq-79-180-140-8.red.bezeqint.net] has joined #bitcoin-core-dev
09:35 -!- lightlike [~lightlike@user/lightlike] has joined #bitcoin-core-dev
09:42 -!- reez [~textual@45-30-22-183.lightspeed.nsvltn.sbcglobal.net] has joined #bitcoin-core-dev
09:44 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
09:44 -!- reez [~textual@45-30-22-183.lightspeed.nsvltn.sbcglobal.net] has quit [Client Quit]
09:49 -!- sagi [~sagi@bzq-79-180-140-8.red.bezeqint.net] has quit [Ping timeout: 272 seconds]
09:55 -!- dhruv [~dhruv@165.227.49.220] has quit [Remote host closed the connection]
09:57 -!- dhruv [~dhruv@165.227.49.220] has joined #bitcoin-core-dev
10:01 -!- reez [~textual@45-30-22-183.lightspeed.nsvltn.sbcglobal.net] has joined #bitcoin-core-dev
10:02 < jnewbery_> Hi folks. As a reminder, we have a p2p meeting scheduled for today in around 4 hours time. If you have any topics that you'd like to discuss, feel free to add them to the wiki page here: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings
10:06 -!- AaronvanW [~AaronvanW@71pc74.sshunet.nl] has quit [Ping timeout: 244 seconds]
10:07 -!- sagi [~sagi@bzq-79-180-140-8.red.bezeqint.net] has joined #bitcoin-core-dev
10:11 < jnewbery_> As always, feel free to update your own priorities at https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-Current-Priorities to let others know what you're working on
10:16 < sipa> has #21528 and #22245 be
10:16 <@gribble> https://github.com/bitcoin/bitcoin/issues/21528 | [p2p] Reduce addr blackholes by amitiuttarwar · Pull Request #21528 · bitcoin/bitcoin · GitHub
10:16 <@gribble> https://github.com/bitcoin/bitcoin/issues/22245 | [p2p] Stop sending SENDADDRV2 message to block-relay-only peers by amitiuttarwar · Pull Request #22245 · bitcoin/bitcoin · GitHub
10:16 < sipa> has #21528 and #22245 been brought up?
10:16 <@gribble> https://github.com/bitcoin/bitcoin/issues/21528 | [p2p] Reduce addr blackholes by amitiuttarwar · Pull Request #21528 · bitcoin/bitcoin · GitHub
10:16 <@gribble> https://github.com/bitcoin/bitcoin/issues/22245 | [p2p] Stop sending SENDADDRV2 message to block-relay-only peers by amitiuttarwar · Pull Request #22245 · bitcoin/bitcoin · GitHub
10:16 < sipa> sorry for double-gribbling
10:19 < amiti> hi sipa! I was going to give a quick update about 21528, but didn't put it as a meeting topic. do you wanna discuss? I'm happy to put them both on the agenda
10:20 < sipa> i saw some discussion with laanwj about bip155 changes, so maybe it's useful
10:20 < sipa> (i don't have much to add myself specifically)
10:21 -!- AaronvanW [~AaronvanW@71pc74.sshunet.nl] has joined #bitcoin-core-dev
10:22 < sipa> i'd like to see #22144 and #22147 in 22.0 too, if people want to discuss those
10:22 <@gribble> https://github.com/bitcoin/bitcoin/issues/22144 | Randomize message processing peer order by sipa · Pull Request #22144 · bitcoin/bitcoin · GitHub
10:22 <@gribble> https://github.com/bitcoin/bitcoin/issues/22147 | p2p: Protect last outbound HB compact block peer by sdaftuar · Pull Request #22147 · bitcoin/bitcoin · GitHub
10:23 -!- reez [~textual@45-30-22-183.lightspeed.nsvltn.sbcglobal.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
10:27 < ariard> i would be glad to log mines, but i don't have w/ access to this board since it has been moved :/
10:27 < ariard> another reminder, transaction relay workshop a hour and half from now on #l2-onchain-support (19:00 utc)
10:37 < amiti> sipa: ok! I'll add as a topic and we can discuss or it'll just be a quick update 
10:41 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net]
10:42 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
10:45 -!- orionwl[m] [~orionwlx0@2001:470:69fc:105::80] has quit [Quit: Client limit exceeded: 10000]
10:48 -!- sagi [~sagi@bzq-79-180-140-8.red.bezeqint.net] has quit [Ping timeout: 272 seconds]
10:56 -!- CaptainLionBTC [~User@47.157.125.162] has joined #bitcoin-core-dev
11:18 -!- prusnak[m] [~stickmatr@2001:470:69fc:105::98c] has quit [Quit: Client limit exceeded: 10000]
11:19 -!- gmaxwell [~gmaxwell@user/gmaxwell] has joined #bitcoin-core-dev
11:20 -!- gmaxwell [~gmaxwell@user/gmaxwell] has left #bitcoin-core-dev []
11:22 -!- sagi [~sagi@bzq-79-180-140-8.red.bezeqint.net] has joined #bitcoin-core-dev
11:28 -!- Henry151 [~bishop@user/henry151] has joined #bitcoin-core-dev
11:30 -!- Henry151 [~bishop@user/henry151] has quit [Client Quit]
11:32 -!- dongcarl[m] [~dongcarlm@2001:470:69fc:105::82] has quit [Quit: Client limit exceeded: 10000]
11:32 -!- Henry151 [~bishop@user/henry151] has joined #bitcoin-core-dev
11:45 -!- swambo [~swambo@46.221.8.248] has joined #bitcoin-core-dev
11:50 -!- gleb [~gleb@178.150.137.228] has joined #bitcoin-core-dev
11:51 -!- prayank [~andr0irc@51.15.9.205] has joined #bitcoin-core-dev
11:56 -!- cold [~cold@user/cold] has joined #bitcoin-core-dev
11:56 -!- devrandom [~devrandom@2001:470:69fc:105::d4d] has quit [Quit: Client limit exceeded: 10000]
11:57 -!- swambo_ [~swambo@176.237.239.28] has joined #bitcoin-core-dev
12:00 -!- swambo [~swambo@46.221.8.248] has quit [Ping timeout: 240 seconds]
12:01 -!- kvaciral[m] [~kvaciralx@2001:470:69fc:105::17b] has quit [Quit: Client limit exceeded: 10000]
12:05 < provoostenator> Can of worms of the day...  #22254
12:05 -!- orionwl[m] [~orionwlx0@2001:470:69fc:105::80] has joined #bitcoin-core-dev
12:05 <@gribble> https://github.com/bitcoin/bitcoin/issues/22254 | Boost::ASIO (used by Boost::Process) uses (falsely?) deprecated std::allocator · Issue #22254 · bitcoin/bitcoin · GitHub
12:06 < provoostenator> When people start blaming compilers,  I start running.
12:06 -!- dongcarl[m] [~dongcarlm@2001:470:69fc:105::82] has joined #bitcoin-core-dev
12:07 -!- sagi [~sagi@bzq-79-180-140-8.red.bezeqint.net] has quit [Ping timeout: 240 seconds]
12:07 -!- takinbo [~takinbo@2a01:4f8:160:60aa:fee::10] has joined #bitcoin-core-dev
12:07 -!- kvaciral[m] [~kvaciralx@2001:470:69fc:105::17b] has joined #bitcoin-core-dev
12:07 -!- devrandom [~devrandom@2001:470:69fc:105::d4d] has joined #bitcoin-core-dev
12:07 -!- prusnak[m] [~stickmatr@2001:470:69fc:105::98c] has joined #bitcoin-core-dev
12:07 < achow101> What's the difference between --enable-fuzz and --enable-fuzz-binary?
12:08 < provoostenator> I think --enable-fuzz is what you need to actually fuzz, but then you don't get any of the other binaries.
12:08 < provoostenator> Whereas --enable-fuzz-binary just makes sure you didn't break anything? (it's slow though)
12:08 < achow101> but the fuzz binary built without enable-fuzz doesn't seem to work?
12:09 < provoostenator> (slow to build that is, I think it's not supposed to work)
12:09 < sipa> achow101: it works, it just doesn't fuzz
12:10 < sipa> you need to provide it an input on stdin
12:10 < achow101> oh
12:10 < sipa> rather than finding fuzzing inputs on its own
12:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:15 < bitcoin-git> [bitcoin] luke-jr opened pull request #22255: [0.21] wallet: Do not iterate a directory if having an error while accessing it (0.21...listwalletdir_iterate_inf-0.19) https://github.com/bitcoin/bitcoin/pull/22255
12:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:20 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
12:21 < achow101> provoostenator: interestingly, compiling 5c06af49efba407f062fdbf124b6d571fedd73fa from #21935 with --enable-fuzz --disable-external-signer works, but does not with only --disable-external-signer
12:21 <@gribble> https://github.com/bitcoin/bitcoin/issues/21935 | Enable external signer support by default, reduce #ifdef by Sjors · Pull Request #21935 · bitcoin/bitcoin · GitHub
12:23 < achow101> oh, it disables the wallet with --enable-fuzz
12:26 -!- mrjumper[m] [~mr-jumper@2001:470:69fc:105::7f1] has quit [Quit: Client limit exceeded: 10000]
12:48 -!- takinbo [~takinbo@2a01:4f8:160:60aa:fee::10] has quit [Changing host]
12:48 -!- takinbo [~takinbo@user/takinbo] has joined #bitcoin-core-dev
12:51 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
12:56 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev
12:58 -!- takinbo is now known as takinbo_
12:59 -!- takinbo_ [~takinbo@user/takinbo] has quit [Quit: takinbo_]
12:59 -!- takinbo [~takinbo@user/takinbo] has joined #bitcoin-core-dev
13:00 -!- andrewtoth [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Ping timeout: 252 seconds]
13:01 -!- swambo_ [~swambo@176.237.239.28] has quit [Ping timeout: 240 seconds]
13:08 -!- Ara [~Ara@user/ara] has quit [Quit: Leaving]
13:09 -!- reez [~textual@45-30-22-183.lightspeed.nsvltn.sbcglobal.net] has joined #bitcoin-core-dev
13:12 -!- CaptainLionBTC [~User@47.157.125.162] has quit [Ping timeout: 244 seconds]
13:20 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 252 seconds]
13:21 -!- roconnor [~roconnor@host-184-164-16-124.dyn.295.ca] has quit [Remote host closed the connection]
13:21 -!- Ara [~Ara@user/ara] has joined #bitcoin-core-dev
13:22 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
13:28 -!- reez [~textual@45-30-22-183.lightspeed.nsvltn.sbcglobal.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
13:31 -!- Ara [~Ara@user/ara] has quit [Quit: Leaving]
13:32 -!- DougieBot5000 [~Ara@user/ara] has joined #bitcoin-core-dev
13:34 -!- DougieBot5000 [~Ara@user/ara] has quit [Client Quit]
13:37 -!- prayank [~andr0irc@51.15.9.205] has quit [Quit: irc thread exit]
13:41 -!- Ara [~Ara@user/ara] has joined #bitcoin-core-dev
13:51 -!- AaronvanW [~AaronvanW@71pc74.sshunet.nl] has quit [Ping timeout: 268 seconds]
13:54 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Read error: Connection reset by peer]
13:55 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
13:56 -!- cdecker [~cdecker@243.86.254.84.ftth.as8758.net] has quit [Ping timeout: 264 seconds]
14:00 < jnewbery_> #startmeeting
14:00 < core-meetingbot> Meeting started Tue Jun 15 21:00:16 2021 UTC.  The chair is jnewbery_. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
14:00 < core-meetingbot> Available commands: action commands idea info link nick
14:00 -!- mrjumper[m] [~mr-jumper@2001:470:69fc:105::7f1] has joined #bitcoin-core-dev
14:00 < jnewbery_> #bitcoin-core-dev Meeting: achow101 aj amiti ariard bluematt cfields Chris_Stewart_5 digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik 
14:00 < jnewbery_> petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild wumpus
14:00 < amiti> hi
14:00 < ariard> yo
14:00 < lightlike> hi
14:00 < michaelfolkson> hi
14:01 < jnewbery_> Hi folks. We have two items on the agenda today: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/P2P-IRC-meetings#15-jun-2021
14:01 <@gribble> https://github.com/bitcoin/bitcoin/issues/15 | Option to specify external IP address · Issue #15 · bitcoin/bitcoin · GitHub
14:01 < jnewbery_> Does anyone have any last minute topics to add?
14:02 < jnewbery_> ok, let's get started on the topics
14:02 < jnewbery_> #topic locking in net_processing
14:02 < core-meetingbot> topic: locking in net_processing
14:02 < _aj_> hi
14:03 < sipa> hi
14:03 < jnewbery_> #21527 is currently waiting for review. It adds a new lock to PeerMan, which I think later can be used to replace all the usage of cs_main in net_processing.
14:03 <@gribble> https://github.com/bitcoin/bitcoin/issues/21527 | net_processing: lock clean up by ajtowns · Pull Request #21527 · bitcoin/bitcoin · GitHub
14:03 < jnewbery_> It'd unblock a lot of work to modularize net_processing and enforce clearer interfaces with validation and net
14:04 < glozow> hi
14:04 < jnewbery_> The PR is languishing a bit and had some pushback from vasild, but I think it's probably the right direction to take
14:06 < ariard> doesn't sound to big, i can have a look on it this week
14:06 < jnewbery_> Thanks ariard
14:06 -!- swambo_ [~swambo@176.237.239.28] has joined #bitcoin-core-dev
14:07 < amiti> I'm a concept / approach ACK on the pr. I intend to review it, hopefully soon 
14:07 < michaelfolkson> Seems like vasild can give an ACK (with reservations) from his comments which might help it along too
14:08 < jnewbery_> ok, if there aren't any questions on the approach, then we can move on to the next topic
14:08 < jnewbery_> #topic Reduce addr blackholes
14:08 < core-meetingbot> topic: Reduce addr blackholes
14:08 < jnewbery_> (amiti)
14:09 < amiti> hi! I brought #21528 out of draft this week, and opened #22245 as a small change I'd like to see in v22 
14:09 <@gribble> https://github.com/bitcoin/bitcoin/issues/21528 | [p2p] Reduce addr blackholes by amitiuttarwar · Pull Request #21528 · bitcoin/bitcoin · GitHub
14:09 <@gribble> https://github.com/bitcoin/bitcoin/issues/22245 | [p2p] Stop sending SENDADDRV2 message to block-relay-only peers by amitiuttarwar · Pull Request #22245 · bitcoin/bitcoin · GitHub
14:10 < amiti> the biggest concern about 21528 was around compatibility of other software on the network, and I looked at every client I could, opened issues confirming my understanding, posted on mailing list, mentioned it here multiple times... so I feel like its okay to move forward with these changes :) 
14:10 < sipa> so the policy is going to be "if you ever send anything addr related, we assume you care about addresses"?
14:11 < amiti> yeah
14:11 < amiti> updated from "we assume you care about addresses regardless"
14:11 -!- swambo_ [~swambo@176.237.239.28] has quit [Ping timeout: 240 seconds]
14:13 -!- cdecker [~cdecker@243.86.254.84.ftth.as8758.net] has joined #bitcoin-core-dev
14:13 < amiti> and then there was a question about BIP155 on #22245, I've posted my thoughts on the PR, but want to give anyone the chance to raise questions / any remaining concerns 
14:13 <@gribble> https://github.com/bitcoin/bitcoin/issues/22245 | [p2p] Stop sending SENDADDRV2 message to block-relay-only peers by amitiuttarwar · Pull Request #22245 · bitcoin/bitcoin · GitHub
14:14 < amiti> ok, if not, this is just an update then :) 
14:15 < lightlike> #22245 would make sendaddrv2 kind of non-parallel with the other feature negotiation message wtxidrelay (which must be send regardless of whether we do tx relay)
14:15 <@gribble> https://github.com/bitcoin/bitcoin/issues/22245 | [p2p] Stop sending SENDADDRV2 message to block-relay-only peers by amitiuttarwar · Pull Request #22245 · bitcoin/bitcoin · GitHub
14:15 < lightlike>  not sure if consistency something that is valuable at this spot though
14:16 < sipa> i don't think so
14:16 < amiti> lightlike: why must wtxidrelay be sent regardless of tx relay?
14:16 < sipa> if you don't care about addresses, sending sendaddrv2 is just irrelevant
14:16 < lightlike> "The wtxidrelay message MUST be sent in response to a version message from a peer whose protocol version is >= 70016 and prior to sending a verack" (BIP 339)
14:16 < sipa> so presumably, someone who doesn't care about addresses at all is not going to send it
14:16 < ariard> sounds more an oddity of bip339
14:16 < amiti> lightlike: ah, gotcha
14:17 < sipa> in order to implement BIP339 you must send wtxidrelay
14:17 < sipa> but you're free not to implement BIP339
14:18 < sipa> someone who doesn't care about addrv2 isn't going to implement BIP155, and thus isn't going to send sendaddrv2 either?
14:18 < jnewbery_> lightlike: that MUST means "you must send it if you want the peer to relay transactions using wtxid". I disagreed with using that language at the time because I thought it was confusing.
14:18 < sipa> (which also applies to anyone who doesn't care about addresses in the first place)
14:19 < lightlike> jnewbery_: ah, ok, then it is not an issue.
14:20 < michaelfolkson> What's the latest on #21061 amiti? Is the new approach finalized/agreed or is it still up in the air somewhat?
14:20 <@gribble> https://github.com/bitcoin/bitcoin/issues/21061 | [p2p] Introduce node rebroadcast module by amitiuttarwar · Pull Request #21061 · bitcoin/bitcoin · GitHub
14:21 < michaelfolkson> I read the Suhas comments
14:21 < amiti> michaelfolkson: still working on it, I'll post an update on the PR when its more concrete 
14:21 < michaelfolkson> Cool
14:21 < amiti> ok, I guess that concludes the Reduce addr blackholes topic 
14:21 < jnewbery_> thanks amiti
14:21 < ariard> w.r.t to erlay, gleb should release the new version of the simulator this week
14:21 < ariard> and down to review more minisketch once i'm done with the current package-PRs
14:22 < jnewbery_> ariard: good to hear that it's still being worked on!
14:23 < jnewbery_> ok, any last updates before we end the meeting?
14:23 < jnewbery_> #endmeeting
14:23 < core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
14:23 < core-meetingbot> Meeting ended Tue Jun 15 21:23:38 2021 UTC.  
14:23 < core-meetingbot> Minutes:        https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2021/bitcoin-core-dev.2021-06-15-21.00.moin.txt
14:30 -!- CaptainLion [~User@47.157.125.162] has joined #bitcoin-core-dev
14:41 -!- smartin [~Icedove@88.135.18.171] has quit [Quit: smartin]
14:46 -!- sibilant__ is now known as sibilant
14:47 -!- prayank [~andr0irc@51.158.144.32] has joined #bitcoin-core-dev
14:47 -!- haakon [~haakonn@82.196.8.209] has quit [Ping timeout: 252 seconds]
14:48 -!- haakon [~haakonn@82.196.8.209] has joined #bitcoin-core-dev
14:52 < prayank> Can we merge this? https://github.com/bitcoin/bitcoin/pull/21157 or if anyone has issues with the changes in PR feel free to comment
15:02 < achow101> are we pushing back feature freeze? there are still 15 open prs in the milestone
15:07 -!- martinus_ [~martinus@046125249003.public.t-mobile.at] has joined #bitcoin-core-dev
15:10 -!- martinus [~martinus@212095005140.public.telering.at] has quit [Ping timeout: 272 seconds]
15:25 -!- sibilant_ [~sibilant@host-95-197-90-27.mobileonline.telia.com] has joined #bitcoin-core-dev
15:25 -!- sibilant_ [~sibilant@host-95-197-90-27.mobileonline.telia.com] has quit [Changing host]
15:25 -!- sibilant_ [~sibilant@user/sibilant] has joined #bitcoin-core-dev
15:27 -!- sibilant [~sibilant@user/sibilant] has quit [Ping timeout: 240 seconds]
15:41 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Ping timeout: 240 seconds]
15:41 -!- evias [~evias__@user/evias] has quit [Ping timeout: 272 seconds]
15:48 -!- AaronvanW [~AaronvanW@71pc74.sshunet.nl] has joined #bitcoin-core-dev
15:49 -!- pigeons_ is now known as pigeons
15:51 -!- TallTim_ is now known as TallTim
15:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:53 < bitcoin-git> [bitcoin] theStack opened pull request #22257: test: refactor: use `{From,To}Hex` helpers for msg (de)serialization from/to hex (master...202106-test-refactor-replace_manual_deser_with_fromtohex) https://github.com/bitcoin/bitcoin/pull/22257
15:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
16:05 -!- roconnor [~roconnor@host-184-164-16-124.dyn.295.ca] has joined #bitcoin-core-dev
16:17 -!- ratelius [ratelius@gateway/vpn/protonvpn/ratelius] has quit [Ping timeout: 268 seconds]
16:18 -!- promag_ [~promag@188.250.84.129] has joined #bitcoin-core-dev
16:18 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
16:21 -!- AaronvanW [~AaronvanW@71pc74.sshunet.nl] has quit [Ping timeout: 240 seconds]
16:21 -!- promag [~promag@188.250.84.129] has quit [Ping timeout: 272 seconds]
16:29 -!- baldur [~baldur@pool-108-30-51-126.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
16:29 -!- prayank [~andr0irc@51.158.144.32] has quit [Quit: irc thread exit]
16:30 -!- lightlike [~lightlike@user/lightlike] has quit [Quit: Leaving]
16:32 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev
16:37 -!- baldur [~baldur@pool-108-30-51-126.nycmny.fios.verizon.net] has quit [Quit: Leaving]
16:38 -!- baldur [~baldur@pool-108-30-51-126.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
16:42 -!- jespada [~jespada@90.254.242.55] has quit [Ping timeout: 272 seconds]
16:44 -!- jespada [~jespada@90.254.247.46] has joined #bitcoin-core-dev
17:05 -!- b10c [uid500648@id-500648.charlton.irccloud.com] has quit [Quit: Connection closed for inactivity]
17:35 -!- GIANTWORLDKEEPER [~pjetcetal@2.95.204.25] has quit [Ping timeout: 244 seconds]
17:36 -!- Guest69 [~Guest69@218.212.21.21] has joined #bitcoin-core-dev
17:51 -!- GIANTWORLDKEEPER [~pjetcetal@2.95.204.25] has joined #bitcoin-core-dev
18:18 -!- AaronvanW [~AaronvanW@71pc74.sshunet.nl] has joined #bitcoin-core-dev
18:38 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Ping timeout: 272 seconds]
18:42 -!- DeanGuss [~dean@user/deanguss] has quit [Excess Flood]
18:44 -!- DeanGuss [~dean@nonplayercharacter.me] has joined #bitcoin-core-dev
18:44 -!- DeanGuss [~dean@nonplayercharacter.me] has quit [Changing host]
18:44 -!- DeanGuss [~dean@user/deanguss] has joined #bitcoin-core-dev
18:52 -!- instagibbs_ [~instagibb@119247204116.ctinets.com] has quit [Ping timeout: 252 seconds]
18:52 -!- AaronvanW [~AaronvanW@71pc74.sshunet.nl] has quit [Ping timeout: 268 seconds]
19:07 -!- instagibbs_ [~instagibb@119247204116.ctinets.com] has joined #bitcoin-core-dev
19:26 -!- jackielove4u [uid43977@user/jackielove4u] has quit [Quit: Connection closed for inactivity]
19:29 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection]
19:29 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
19:38 -!- martinus__ [~martinus@212095005005.public.telering.at] has joined #bitcoin-core-dev
19:41 -!- martinus_ [~martinus@046125249003.public.t-mobile.at] has quit [Ping timeout: 268 seconds]
20:00 -!- gleb [~gleb@178.150.137.228] has quit [Read error: Connection reset by peer]
20:01 -!- gleb [~gleb@178.150.137.228] has joined #bitcoin-core-dev
20:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:27 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/eb63b1db2c4d...6bc1eca01b2f
20:27 < bitcoin-git> bitcoin/master 79c02c8 Pieter Wuille: Randomize message processing peer order
20:27 < bitcoin-git> bitcoin/master 6bc1eca fanquake: Merge bitcoin/bitcoin#22144: Randomize message processing peer order
20:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:28 < bitcoin-git> [bitcoin] fanquake merged pull request #22144: Randomize message processing peer order (master...202106_rand_peers) https://github.com/bitcoin/bitcoin/pull/22144
20:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:31 -!- cdecker5 [~cdecker@243.86.254.84.ftth.as8758.net] has joined #bitcoin-core-dev
20:31 -!- cdecker [~cdecker@243.86.254.84.ftth.as8758.net] has quit [Read error: Connection reset by peer]
20:31 -!- cdecker5 is now known as cdecker
20:39 -!- leqock [~leqock@46.49.116.215] has joined #bitcoin-core-dev
20:49 -!- AaronvanW [~AaronvanW@71pc74.sshunet.nl] has joined #bitcoin-core-dev
21:00 -!- sagi [~sagi@176.230.171.92] has joined #bitcoin-core-dev
21:02 -!- ratelius [ratelius@gateway/vpn/protonvpn/ratelius] has joined #bitcoin-core-dev
21:04 -!- leqock [~leqock@46.49.116.215] has quit [Quit: Leaving]
21:04 -!- leqock [~leqock@46.49.116.215] has joined #bitcoin-core-dev
21:21 -!- AaronvanW [~AaronvanW@71pc74.sshunet.nl] has quit [Ping timeout: 240 seconds]
21:24 -!- dviola [~diego@user/dviola] has joined #bitcoin-core-dev
21:38 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 268 seconds]
21:41 -!- vnogueira [~vnogueira@user/vnogueira] has quit [Remote host closed the connection]
21:41 -!- vnogueira [~vnogueira@user/vnogueira] has joined #bitcoin-core-dev
21:47 -!- leqock [~leqock@46.49.116.215] has quit [Quit: Leaving]
21:47 -!- leqock [~leqock@46.49.116.215] has joined #bitcoin-core-dev
21:48 -!- leqock [~leqock@46.49.116.215] has quit [Remote host closed the connection]
21:49 -!- leqock [~leqock@46.49.116.215] has joined #bitcoin-core-dev
21:50 -!- leqock [~leqock@46.49.116.215] has quit [Client Quit]
21:50 -!- belcher [~belcher@user/belcher] has joined #bitcoin-core-dev
21:51 -!- leqock [~leqock@46.49.116.215] has joined #bitcoin-core-dev
21:51 -!- arnabsen [~arnabsen@45.116.190.221] has joined #bitcoin-core-dev
22:05 -!- dviola [~diego@user/dviola] has quit [Quit: WeeChat 3.2]
23:07 -!- dermoth_ [~dermoth@user/dermoth] has joined #bitcoin-core-dev
23:07 -!- dermoth [~dermoth@user/dermoth] has quit [Killed (NickServ (GHOST command used by dermoth_))]
23:07 -!- dermoth_ is now known as dermoth
23:10 -!- swambo_ [~swambo@176.237.239.28] has joined #bitcoin-core-dev
23:11 -!- Guest19 [~Guest19@117.96.136.173] has joined #bitcoin-core-dev
23:12 -!- Guest19 [~Guest19@117.96.136.173] has quit [Client Quit]
23:17 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
23:18 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has joined #bitcoin-core-dev
23:18 -!- swambo_ [~swambo@176.237.239.28] has quit [Quit: Konversation terminated!]
23:19 -!- AaronvanW [~AaronvanW@71pc74.sshunet.nl] has joined #bitcoin-core-dev
23:37 -!- smartin [~Icedove@88.135.18.171] has joined #bitcoin-core-dev
23:46 -!- jarthur [~jarthur@2603-8080-1540-002d-75b5-effb-8a85-a266.res6.spectrum.com] has quit [Quit: jarthur]
23:52 -!- AaronvanW [~AaronvanW@71pc74.sshunet.nl] has quit [Ping timeout: 268 seconds]
--- Log closed Wed Jun 16 00:00:39 2021