--- Log opened Fri Jun 18 00:00:41 2021
00:07 -!- chrysanthematic [~chrysanth@82.2.21.4] has quit [Quit: chrysanthematic]
00:14 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net]
00:15 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
00:16 -!- bomben [~benjamin@ip5f5a4754.dynamic.kabel-deutschland.de] has joined #bitcoin-core-dev
00:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:17 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5c2e2afe990a...ad0c8f356ee8
00:17 < bitcoin-git> bitcoin/master 8f7704d fanquake: build: improve detection of eBPF support
00:17 < bitcoin-git> bitcoin/master ad0c8f3 fanquake: Merge bitcoin/bitcoin#22238: build: improve detection of eBPF support
00:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:17 -!- bomb-on [~bomb-on@194.144.47.113] has quit [Ping timeout: 272 seconds]
00:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:17 < bitcoin-git> [bitcoin] fanquake merged pull request #22238: build: improve detection of eBPF support (master...no_probes_darwin_for_now) https://github.com/bitcoin/bitcoin/pull/22238
00:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:17 -!- gribble [~gribble@bitcoin/bot/gribble] has quit [Remote host closed the connection]
00:20 -!- gribble [~gribble@bitcoin/bot/gribble] has joined #bitcoin-core-dev
00:20 -!- mode/#bitcoin-core-dev [+o gribble] by ChanServ
00:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:22 < bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/ad0c8f356ee8...da69d9965a11
00:22 < bitcoin-git> bitcoin/master 8732f7b fanquake: scripts: LIEF 0.11.5
00:22 < bitcoin-git> bitcoin/master 29615ae fanquake: scripts: check minimum required macOS vesion is set
00:22 < bitcoin-git> bitcoin/master c972345 fanquake: scripts: check minimum required Windows version is set
00:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:22 < bitcoin-git> [bitcoin] fanquake merged pull request #21871: scripts: add checks for minimum required OS versions (master...new_tests_on_lief) https://github.com/bitcoin/bitcoin/pull/21871
00:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:23 -!- belcher_ is now known as belcher
00:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:23 < bitcoin-git> [bitcoin] fanquake closed pull request #22142: build: split depends Qt into native and target builds (master...split_qt_again) https://github.com/bitcoin/bitcoin/pull/22142
00:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:27 -!- vnogueira [~vnogueira@user/vnogueira] has quit [Remote host closed the connection]
00:27 -!- vnogueira [~vnogueira@user/vnogueira] has joined #bitcoin-core-dev
00:29 -!- powerjungle [~powerjung@h081217087223.dyn.cm.kabsi.at] has quit [Quit: ZNC - https://znc.in]
00:29 -!- major1 [~major@gateway/tor-sasl/major] has quit [Remote host closed the connection]
00:29 -!- major1 [~major@gateway/tor-sasl/major] has joined #bitcoin-core-dev
00:39 -!- rich- is now known as PaulTroon
00:42 -!- PaulTroon is now known as yakshaver
00:43 -!- yakshaver is now known as remyers
00:48 -!- laanwj [~laanwj@user/laanwj] has quit [Read error: Connection reset by peer]
00:50 -!- laanwj [~laanwj@user/laanwj] has joined #bitcoin-core-dev
00:50 -!- lkqwejhhgasdjhgn [~kljkljklk@p200300d46f03bc006a84494ddc6e0025.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
01:08 -!- sagi [~sagi@bzq-79-180-140-8.red.bezeqint.net] has quit [Ping timeout: 244 seconds]
01:31 -!- bomben [~benjamin@ip5f5a4754.dynamic.kabel-deutschland.de] has quit [Ping timeout: 268 seconds]
01:37 -!- kabaum [~kabaum@host-78-77-216-135.mobileonline.telia.com] has joined #bitcoin-core-dev
01:39 -!- smartin [~Icedove@88.135.18.171] has joined #bitcoin-core-dev
01:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:42 < bitcoin-git> [bitcoin] SpicaLab opened pull request #22276:  gui: update text to eliminate safety hazards (0.21...0.21) https://github.com/bitcoin/bitcoin/pull/22276
01:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:47 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #22277: test: Properly set BIP34 height in CreateNewBlock_validity unit test (master...2106-test34) https://github.com/bitcoin/bitcoin/pull/22277
01:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:51 < vasild> amiti: Hello! One sure way to bring my attention is to mention my nick on IRC or on github. But I realize that you could not have pinged personally everybody that could be interested. I should read meeting logs, but I dont always do, which is my bad.
01:53 < vasild> Following everything that is going on would be a near-full time experience, just to keep up to date. I don't do it.
01:56 < vasild> I said that "you *seem* to be unaware of previous" works because there are no comments from you on those discussion threads. I think it would have helped if you posted a comment on e.g. https://github.com/bitcoin/bitcoin/pull/17194 "this (or similar) problem is addressed by other means in https://github.com/bitcoin/bitcoin/pull/21528"
02:00 < vasild> gleb: Your input on https://github.com/bitcoin/bitcoin/pull/21528 would be very valuable.
02:02 -!- kexkey_ [~kexkey@static-198-54-132-110.cust.tzulo.com] has joined #bitcoin-core-dev
02:03 -!- jonatack [jonatack@user/jonatack] has quit [Quit: Connection closed]
02:04 -!- kexkey [~kexkey@static-198-54-132-142.cust.tzulo.com] has quit [Ping timeout: 240 seconds]
02:22 -!- kabaum [~kabaum@host-78-77-216-135.mobileonline.telia.com] has quit [Read error: Connection reset by peer]
02:27 -!- gribble [~gribble@bitcoin/bot/gribble] has quit [Remote host closed the connection]
02:28 -!- dunxen [dunxen@gateway/vpn/protonvpn/dunxen] has joined #bitcoin-core-dev
02:29 -!- gribble [~gribble@bitcoin/bot/gribble] has joined #bitcoin-core-dev
02:29 -!- mode/#bitcoin-core-dev [+o gribble] by ChanServ
02:38 -!- kabaum [~kabaum@host-78-77-216-135.mobileonline.telia.com] has joined #bitcoin-core-dev
02:47 -!- Guest6988 [~Guest69@182.69.199.37] has joined #bitcoin-core-dev
02:48 -!- Guest6988 [~Guest69@182.69.199.37] has left #bitcoin-core-dev []
02:54 -!- dunxen [dunxen@gateway/vpn/protonvpn/dunxen] has quit [Quit: Leaving...]
03:10 -!- mamilis [uid502224@id-502224.tinside.irccloud.com] has joined #bitcoin-core-dev
03:11 < michaelfolkson> amiti: My two cents. I don't think you could have done any more to ensure everyone was aware of the PR and I can see why you're frustrated. A Bitcoin Core PR review club, bringing it up in P2P meeting(s), bringing it up in Core dev meeting, mailing list post etc
03:12 < michaelfolkson> Hence I'm surprised anyone who follows Core P2P development wasn't aware of the PR. However, I think this is just an unfortunate circumstance where one specific detail of the PR didn't become obvious until very late
03:13 < michaelfolkson> I don't think you could have done any more or that the process needs improving. Just hopefully won't happen again with any kind of regularity
03:18 < michaelfolkson> The vasild suggestion to refer to or post on old related PRs is a good one but a minor improvement on what you've already done
03:18 < michaelfolkson> (imo)
03:20 < vasild> +1
03:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:21 < bitcoin-git> [bitcoin] glozow closed pull request #22253: validation: distinguish between same tx and same-nonwitness-data tx in mempool (master...2021-06-same-txid-diff-wtxid) https://github.com/bitcoin/bitcoin/pull/22253
03:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:23 -!- sagi [~sagi@bzq-79-180-140-8.red.bezeqint.net] has joined #bitcoin-core-dev
03:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:36 < bitcoin-git> [bitcoin] glozow reopened pull request #22253: validation: distinguish between same tx and same-nonwitness-data tx in mempool (master...2021-06-same-txid-diff-wtxid) https://github.com/bitcoin/bitcoin/pull/22253
03:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:42 -!- jonatack [jonatack@user/jonatack] has joined #bitcoin-core-dev
03:57 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
04:11 -!- emcy [~emcy@user/emcy] has quit [Quit: Leaving]
04:11 -!- sagi [~sagi@bzq-79-180-140-8.red.bezeqint.net] has quit [Ping timeout: 268 seconds]
04:12 -!- Guest2359 [~Guest23@145.40.166.209] has joined #bitcoin-core-dev
04:12 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Ping timeout: 240 seconds]
04:14 -!- Guest2359 [~Guest23@145.40.166.209] has quit [Client Quit]
04:24 -!- emcy [~emcy@user/emcy] has joined #bitcoin-core-dev
04:36 -!- emcy [~emcy@user/emcy] has quit [Remote host closed the connection]
04:45 -!- emcy [~emcy@user/emcy] has joined #bitcoin-core-dev
04:57 -!- kabaum [~kabaum@host-78-77-216-135.mobileonline.telia.com] has quit [Ping timeout: 268 seconds]
05:01 -!- Pree [~Pree@43.224.1.253] has joined #bitcoin-core-dev
05:13 < Pree> Hello everyone myself Preeti Sharma. I'm new to this organization but have a decent knowledge in blockchain domain. While exploring the repo I was quite overwhelmed with the work and want to contribute but need someone to colab with on issues. If anyone up for collaboration or can guide me feel free to connect
05:13 < Pree> :https://www.linkedin.com/in/preeti-sharma-155a85181/ 
05:17 < laanwj> re: #22250  i've had quite a lot of stability issues with i2pd (~monthly segfaults), running git master version now (to get tracebacks) and it hasn't crashed yet, but would be careful to recommend using it
05:17 <@gribble> https://github.com/bitcoin/bitcoin/issues/22250 | doc: add basic I2P documentation by vasild · Pull Request #22250 · bitcoin/bitcoin · GitHub
05:17 -!- vnogueira [~vnogueira@user/vnogueira] has quit [Remote host closed the connection]
05:18 < laanwj> linking only the official client probably makes sense for now
05:18 -!- vnogueira [~vnogueira@user/vnogueira] has joined #bitcoin-core-dev
05:19 -!- Alina-malina [~Alina-mal@user/alina-malina] has joined #bitcoin-core-dev
05:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:25 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/da69d9965a11...0844084c13af
05:25 < bitcoin-git> bitcoin/master 451b96f S3RK: test: kill process group to avoid dangling processes
05:25 < bitcoin-git> bitcoin/master 0844084 MarcoFalke: Merge bitcoin/bitcoin#22249: test: kill process group to avoid dangling pr...
05:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:25 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #22249: test: kill process group to avoid dangling processes when using `--failfast` (master...test_kill_process_group) https://github.com/bitcoin/bitcoin/pull/22249
05:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:25 -!- bomben [~benjamin@ip5f5a4754.dynamic.kabel-deutschland.de] has joined #bitcoin-core-dev
05:28 -!- sagi [~sagi@bzq-79-180-140-8.red.bezeqint.net] has joined #bitcoin-core-dev
05:37 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev
05:40 < vasild> laanwj: "~monthly segfaults" -- I hope you mean i2pd, not bitcoin core
05:41 < vasild> https://github.com/PurpleI2P/i2pd/issues/1568 Use after free in SAM
05:42 < vasild> if you are on freebsd, setting MALLOC_CONF=junk:true,abort:true in the environment helps to get crashes more often :)
05:44 < vasild> Because on Linux and on FreeBSD without this setting, reading a memory soon after it is free()'d seems to work and get the data which was there before the free(), as if free() did not happen.
05:46 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
05:49 -!- sagi [~sagi@bzq-79-180-140-8.red.bezeqint.net] has quit [Ping timeout: 252 seconds]
05:50 < laanwj> vasild: i2pd
05:50 < vasild> phew ;)
05:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:51 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #19281: test: fix dangling bitcoind in functional tests (master...test_terminate_gracefully) https://github.com/bitcoin/bitcoin/pull/19281
05:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:51 < laanwj> vasild: and thanks i'll try that :)
05:53 < vasild> malloc.conf(3) man has some explanation what those settings do
05:54 < laanwj> in any case, as long as this issue isn't resolved, we probably shouldn't be recommending it
05:54 < laanwj> (so I think your document is okay as-is in that regard)
05:57 -!- bomben [~benjamin@ip5f5a4754.dynamic.kabel-deutschland.de] has quit [Quit: Konversation terminated!]
06:06 < vasild> I deliberately refrained from recommending any particular i2p router. I have no reason to assume that the java one is better.
06:06 < laanwj> java at least doesn't have use after free problems
06:06 < vasild> yes :)
06:07 < laanwj> but this was in the context of jonatack mentioning a minimal version to use
06:07 < laanwj> which would make sense in itself
06:07 < vasild> and also I did not want to turn the bitcoin doc i2p.md into "how to install and configure i2p router", which obviously belongs to that i2p router docs
06:07 < laanwj> sure
06:08 < laanwj> though I also think being helpful in things like that can help to get more I2P nodes running
06:09 < laanwj> unlike tor, i2p is still quite unknown and the existing documentation isn't that great in my experience... not that it means we need to maintain it of course
06:30 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has quit [Quit: Konversation terminated!]
06:33 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
06:34 < jonatack> yes, i was thinking of adding a section that describes some issues to be aware of...in the case of i2pd, there are three, maybe four different ones AFAICT
06:34 < jonatack> can be done later
06:35 < laanwj> i'm somewhat worried they don't take https://github.com/PurpleI2P/i2pd/issues/1568 more seriously
06:36 < laanwj> use-after-free can be a serious expoitable issue
06:36 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 268 seconds]
06:37 < jonatack> (a) minimum version on debian reported by sdaftuar v2.33 no go, 2.35 ok (b) use after free bug report by vasild, (c) crashes on freebsd seen by laanwj, (d) 2.36 stops working for me after 2-3 bitcoind restarts on debian
06:41 < laanwj> do I get it right (regarding #20234) that it's not possible to not bind a P2P port at all?
06:41 <@gribble> https://github.com/bitcoin/bitcoin/issues/20234 | net: dont extra bind for Tor if binds are restricted by vasild · Pull Request #20234 · bitcoin/bitcoin · GitHub
06:42 < laanwj> I'm a bit confused about the assert(connOptions.bind_on_any)
06:42 < laanwj> if it gets there and there are no binds at all it will crash with an assertion error, so that's supposed to be impossible
06:44 < provoostenator> Re Core Dev meetup in autumn: good idea.  Prague would be nice.  Not in North Korea please.
06:47 < jonatack> iirc connOptions.bind_on_any == true means there are no binds
06:48 < laanwj> my interpretation is that it means "bind on all interfaces"
06:48 < jonatack> seems it could use a comment
06:48 < laanwj> if it means no binds, it's not a good name imo
06:48 < laanwj> please make it something like bind_on_none
06:49 < vasild> ah, the Core Dev meeting, if it is in Europe I will most likely attend
06:50 < vasild> laanwj: I have completely forgotten what that does, neet to refresh my memory... :)
06:52 < laanwj> bitcoind -nobind -noconnect still works so it must be that I'm misunderstanding the code
06:52 -!- goatpig [~goat@h-94-254-2-155.A498.priv.bahnhof.se] has joined #bitcoin-core-dev
06:53 -!- Pree [~Pree@43.224.1.253] has quit [Quit: Client closed]
06:53 -!- Guest45 [~Guest45@177.172.15.104] has joined #bitcoin-core-dev
06:53 -!- Guest45 [~Guest45@177.172.15.104] has quit [Client Quit]
06:58 < laanwj> it does seem bind_on_any is true in that case
07:00 < laanwj> clearly it is not binding on "any" though :)
07:04 < laanwj> oh I mixed it up with -nolisten maybe?
07:08 -!- lightlike [~lightlike@user/lightlike] has joined #bitcoin-core-dev
07:09 < laanwj> right: -nobind isn't actually a thing, -nolisten is ... the behavior for -nolisten/listen=0 is different in that things still get added to binds they just don't get actually bound
07:09 < laanwj> so it works out
07:10 < laanwj> (albeit the execution flow might be confusing to some people in that case)
07:12 < jonatack> ah nice (was away responding to ariard's coredev email)
07:15 < vasild> actually what does -nofoo mean if the foo argument is not a boolean but is supposed to take string arguments? e.g. -foo="askjdh"
07:16 < laanwj> it used to be that -nofoo is always equivalent to -foo=0 , so -nobind would be -bind=0 which is senseless, but i don't think that is the case anymore? i didn't see any bind arguments passed in
07:18 < lightlike> there is this user/bot "mostafarahimifard" who goes over PRs and likes every post in them (e.g. in 22261, 22253, 15228 etc.). i guess it's harmless, but distracting.
07:19 < lightlike> havent seen any actual contribution by them
07:19 < laanwj> lightlike: thanks, let's see
07:20 < jonatack> lightlike: laanwj: yes, see my review comments in 20234 for example
07:22 < laanwj> we have a fan !
07:22 < jonatack> it's cute :)
07:35 < jamesob> Reading over old docs... remember when we had things called pcoinsTip and chainActive lol
07:37 < lightlike> to add to the confusion, the combination "-nobind=0" will get converted to "-bind=1" by the ParameterParser. E.g. "-noconnect=0" results in the node trying to connect to a peer with IP "1".
07:38 < sipa> haha
07:38 < laanwj> i've argued in the past  that -noXXX shouldn't be allowed to have arguments because it's just confusing
07:39 < sipa> yeah
07:39 -!- emcy [~emcy@user/emcy] has quit [Quit: Leaving]
07:39 < laanwj> i think it was kept out of some backward compatibility concern but i dunno, seems more confusing than is worth it
07:40 < jonatack> agree.  i don't use them.  at least on startup the debug log begins by printing the passed config options (thanks larryruane!) and i sometimes look at what it parsed
07:41 < laanwj> in any case it think the distinction between "what to bind" and "whether to bind at all" makes sense in this case, and is definitely not something that should be changed in #20234, i was just confused for a minute how it could possibly work
07:41 <@gribble> https://github.com/bitcoin/bitcoin/issues/20234 | net: dont extra bind for Tor if binds are restricted by vasild · Pull Request #20234 · bitcoin/bitcoin · GitHub
07:42 < sipa> are there options where a "0" value is a legitimate input that doesn't usefully mean "absense" ?
07:43 < laanwj> no ideaa, there are so many options!
07:43 < jonatack> lightlike: indeed, -noonion=0 -> debug log: "Command-line arg: onion=true"
07:46 < jonatack> and noconnect=0 -> Command-line arg: connect=true ... Binding RPC on address ::1 port 38332 failed.   (no connections at all)
07:47 < vasild> we should add support for multiple negations, like -nonofoo should mean -foo
07:47 < laanwj> -nonononononononono
07:47 < vasild> :-D
07:49 < sipa> i think we should add a -nonogram=file option that dumps a pixelated image representing your config
07:49 < laanwj> i think another reason that we've been very loose with that is that option parsing used to be very loose, e.g. as in there didn't even use to be a path for reporting parse errors from downstream, with the new framework it should be possible
07:49 < sipa> which can of course be disabled using -nogram
07:49 < laanwj> lol!
07:56 < vasild> laanwj: "it's not possible to not bind a P2P port at all" -- https://github.com/bitcoin/bitcoin/pull/20234 is not supposed to change this behavior which is - no, you can't specify "don't bind at all" using -bind=... if -bind is not given then we bind on 0.0.0.0, if -bind=foo is given then we bind on foo
07:57 < laanwj> vasild: I realize this now
07:57 < vasild> however -listen=0 would achieve that
07:58 < vasild> I just tried what would happen if I provide invalid arg to bind like -bind=1.2.3.4:1234 and it quit with this useful message: Error: Unable to bind to 1.2.3.4:1234 on this computer (bind returned error Can't assign requested address (49)) ... Failed to listen on any port. Use -listen=0 if you want this.
07:58 < laanwj> I was right in the sense it's not possible to do that with -bind, but yes, there's -listen for that, so it's fine
07:59 < vasild> so, is https://github.com/bitcoin/bitcoin/pull/20234 ok? any concerns or comments needed?
07:59 < laanwj> yes, it's nice that the error reporting works there
07:59 < vasild> (in this aspect)
07:59 < laanwj> no, not really
08:00 < vasild> ok, the logic in that assert is if -bind= is not given then assert we are going to bind on 0.0.0.0 (any)
08:00 < laanwj> that makes sense, it is true, the interaction with -listen doesn't really matter there i guess
08:01 < laanwj> if you don't want to listen at all, then listening on tor makes no sense either
08:03 < vasild> should we use the seeds to establish at least one I2P connection, makes sense if the user has bothered setting up an I2P/SAM proxy? Came from https://github.com/bitcoin/bitcoin/pull/22250#discussion_r654480480
08:04 < laanwj> vasild: do you mean 'there should always be at least one outgoing I2P connection if the user has set up I2P' (similar for Tor)?
08:05 < vasild> no actually, it is a broader question: should we try to establish at least one I2P (or Tor) connection if the user has bothered to setup the relevant proxy which includes two things: put the seeds in addrman (I am not sure if they are not put by default?) and then take such an address from addrman and try to connect to it
08:05 < vasild> yes, this is what I mean
08:05 < vasild> or well, if there are already incoming ones, then maybe not bother
08:05 < laanwj> I'm not actually sure about that, maybe from a 'don't become isolated' point of view it makes sense
08:06 < vasild> laanwj: s/outgoing/ in your comment
08:06 < vasild> s/outgoing//
08:06 < laanwj> if you set up all overlay networks then making sure there is a conenction to all of them makes eclipse harder
08:06 < sipa> i think a "protect at least one peer of each network" is probably less invasive
08:06 < laanwj> but there might be drawbacks too
08:06 < laanwj> yes
08:07 < vasild> sipa: we already protect existent connections (per network), the thing is, if we dont have any (to a given network).
08:07 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
08:07 < sipa> yes, i understand the difference
08:08 < laanwj> vasild: i guess that applies only to the case where the user adds an overlay network later, while not having addresses for them yet
08:08 < laanwj> which should be relatively rare (except now in the beginning)
08:08 < vasild> I am not sure either, but it just does not seem right if a user has bothered to setup I2P proxy and configure bitcoin core to use it and to have 0 i2p connections (same for tor)
08:09 < laanwj> yes, though adding such functionality for 0.22 is going to be too late anyway, is this still a concern by 0.23?
08:10 < vasild> maybe not, if it always happens to have some tor connections and having 0 connections is only issue for i2p, then we can assume that in the future it will get better and we can do nothing
08:10 < vasild> was just a random thought
08:11 < laanwj> but regarding seeding per network, might make sense, i dunno
08:11  * vasild afk
08:12 < laanwj> to be clar, 'we have zero I2P peers and want to connect to I2P so connect to the seed nodes for them' (also s/I2P/Tor) sound somewhat sensible to me
08:13 < laanwj> especially as I2P peers are more likely to know about other I2P peers than general ones
08:13 < laanwj> it's not a bad idea
08:14 < jonatack> yes, this reviewer encountered that issue IIUC: https://github.com/bitcoin/bitcoin/pull/22250#issuecomment-861824184
08:14 < laanwj> what will also be important is to keep our I2P and TOrV3 hardcoded seeds up to date (also a 23.0 issue, for 22.0 we're fine)
08:14 < jonatack> set it up but then no I2P peers
08:14 < laanwj> right
08:15 < jonatack> was planning to (maybe) propose an update to the I2P seeds before -final, as the I2P ones are evolving, a couple seem unreliable and i am seeing more choice)
08:16 < laanwj> sgtm
08:42 -!- javi404 [~quassel@pool-173-63-15-246.nwrknj.fios.verizon.net] has joined #bitcoin-core-dev
08:51 -!- lkqwejhhgasdjhgn [~kljkljklk@p200300d46f03bc006a84494ddc6e0025.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!]
09:05 -!- Guest8 [~Guest8@fin-vz1.gullo.me] has joined #bitcoin-core-dev
09:09 -!- jonatack [jonatack@user/jonatack] has quit [Ping timeout: 252 seconds]
09:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:11 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/0844084c13af...da1e6d5911f0
09:11 < bitcoin-git> bitcoin/master 511a5af sanket1729: Fixed inconsistencies between code and comments
09:11 < bitcoin-git> bitcoin/master 5531119 sanket1729: Added new test for future blocks reacceptance
09:11 < bitcoin-git> bitcoin/master da1e6d5 MarcoFalke: Merge bitcoin/bitcoin#14604: tests: Add test and refactor feature_block.py...
09:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:11 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #14604: tests: Add test and refactor feature_block.py (master...feature-block-test) https://github.com/bitcoin/bitcoin/pull/14604
09:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:22 -!- Guest58 [~Guest58@202.78.236.183] has joined #bitcoin-core-dev
09:22 -!- Guest58 [~Guest58@202.78.236.183] has quit [Client Quit]
09:25 -!- Guest13 [~Guest13@173.208.98.184] has joined #bitcoin-core-dev
09:25 < Guest13> hi
09:26 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
09:34 -!- lightlike [~lightlike@user/lightlike] has quit [Quit: Leaving]
09:39 -!- evias [~evias__@user/evias] has quit [Quit: This computer has gone to sleep]
09:39 -!- mamilis [uid502224@id-502224.tinside.irccloud.com] has quit [Quit: Connection closed for inactivity]
09:46 -!- lightlike [~lightlike@user/lightlike] has joined #bitcoin-core-dev
09:46 -!- Guest13 [~Guest13@173.208.98.184] has quit [Quit: Client closed]
09:49 -!- jonatack [jonatack@user/jonatack] has joined #bitcoin-core-dev
10:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:32 < bitcoin-git> [bitcoin] laanwj pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/da1e6d5911f0...0f47e01d7d49
10:32 < bitcoin-git> bitcoin/master 1a45cd2 Anthony Towns: contrib/signet: Fix typos
10:32 < bitcoin-git> bitcoin/master a383ce5 Anthony Towns: contrib/signet/miner: --grind-cmd is required for calibrate
10:32 < bitcoin-git> bitcoin/master e665438 Anthony Towns: contrib/signet/miner: Automatic timestamp for first block
10:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:32 < bitcoin-git> [bitcoin] laanwj merged pull request #20923: signet miner followups (master...202101-signet-tweak) https://github.com/bitcoin/bitcoin/pull/20923
10:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:55 -!- Guest32 [~Guest32@182.69.199.37] has joined #bitcoin-core-dev
10:56 -!- sagi [~sagi@bzq-79-180-140-8.red.bezeqint.net] has joined #bitcoin-core-dev
11:07 -!- Guest8 [~Guest8@fin-vz1.gullo.me] has quit [Quit: Client closed]
11:15 -!- l3kk0 [~l3kk0@c-73-22-213-40.hsd1.il.comcast.net] has quit [Read error: Connection reset by peer]
11:16 -!- l3kk0 [~l3kk0@TASTYWORKS.ear2.Chicago2.Level3.net] has joined #bitcoin-core-dev
11:32 -!- Guest8 [~Guest8@fin-vz1.gullo.me] has joined #bitcoin-core-dev
11:33 -!- Guest8 [~Guest8@fin-vz1.gullo.me] has quit [Client Quit]
11:36 -!- emcy [~emcy@user/emcy] has joined #bitcoin-core-dev
11:42 -!- Aaronvan_ [~AaronvanW@45.133.192.68] has joined #bitcoin-core-dev
11:45 -!- AaronvanW [~AaronvanW@71pc74.sshunet.nl] has quit [Ping timeout: 252 seconds]
11:54 -!- bomb-on [~bomb-on@194.144.47.113] has joined #bitcoin-core-dev
11:58 -!- AaronvanW [~AaronvanW@71pc74.sshunet.nl] has joined #bitcoin-core-dev
12:00 < achow101> wallet meeting?
12:01 < achow101> #startmeeting
12:01 < core-meetingbot> Meeting started Fri Jun 18 19:01:11 2021 UTC.  The chair is achow101. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
12:01 < core-meetingbot> Available commands: action commands idea info link nick
12:01 < achow101> #bitcoin-core-dev wallet Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik petertodd 
12:01 < achow101> phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild
12:01 < michaelfolkson> hi
12:01 < cold> hi!
12:02 < achow101> any meeting topics for today? none that I see in the log
12:02 -!- sagi [~sagi@bzq-79-180-140-8.red.bezeqint.net] has quit [Ping timeout: 268 seconds]
12:02 -!- Aaronvan_ [~AaronvanW@45.133.192.68] has quit [Ping timeout: 252 seconds]
12:02 < michaelfolkson> #21365 got merged
12:02 <@gribble> https://github.com/bitcoin/bitcoin/issues/21365 | Basic Taproot signing support for descriptor wallets by sipa · Pull Request #21365 · bitcoin/bitcoin · GitHub
12:03 < michaelfolkson> #22154 still to be merged
12:03 <@gribble> https://github.com/bitcoin/bitcoin/issues/22154 | Add OutputType::BECH32M and related wallet support for fetching bech32m addresses by achow101 · Pull Request #22154 · bitcoin/bitcoin · GitHub
12:03 < sipa> and #22166 
12:03 <@gribble> https://github.com/bitcoin/bitcoin/issues/22166 | Add support for inferring tr() descriptors by sipa · Pull Request #22166 · bitcoin/bitcoin · GitHub
12:03 < sipa> 22166 is less critical to have for 22.0 i think
12:03 < achow101> For the 22.0 milstone, wallet PRs are #22166, #22154, #21329, and #19651
12:03 <@gribble> https://github.com/bitcoin/bitcoin/issues/22166 | Add support for inferring tr() descriptors by sipa · Pull Request #22166 · bitcoin/bitcoin · GitHub
12:03 <@gribble> https://github.com/bitcoin/bitcoin/issues/22154 | Add OutputType::BECH32M and related wallet support for fetching bech32m addresses by achow101 · Pull Request #22154 · bitcoin/bitcoin · GitHub
12:03 <@gribble> https://github.com/bitcoin/bitcoin/issues/21329 | descriptor wallet: Cache last hardened xpub and use in normalized descriptors by achow101 · Pull Request #21329 · bitcoin/bitcoin · GitHub
12:03 <@gribble> https://github.com/bitcoin/bitcoin/issues/19651 | wallet: importdescriptors update existing by S3RK · Pull Request #19651 · bitcoin/bitcoin · GitHub
12:04 < michaelfolkson> They are all included in feature freeze right?
12:04 < michaelfolkson> I didn't follow when the feature freeze was extended to
12:04 < achow101> I don't think we gave a hard deadline for feature freeze
12:04 < sipa> feature freeze is always a bit of a fuzzy concept
12:04 < sipa> as the boundary between bug and feature isn't always clear either
12:05 < michaelfolkson> Ok cool
12:05 < achow101> istm #22154 and #19651 are more bugfix-ish and can be merged after feature freeze
12:05 <@gribble> https://github.com/bitcoin/bitcoin/issues/22154 | Add OutputType::BECH32M and related wallet support for fetching bech32m addresses by achow101 · Pull Request #22154 · bitcoin/bitcoin · GitHub
12:05 <@gribble> https://github.com/bitcoin/bitcoin/issues/19651 | wallet: importdescriptors update existing by S3RK · Pull Request #19651 · bitcoin/bitcoin · GitHub
12:06 < michaelfolkson> So priority is #22154 it appears
12:06 <@gribble> https://github.com/bitcoin/bitcoin/issues/22154 | Add OutputType::BECH32M and related wallet support for fetching bech32m addresses by achow101 · Pull Request #22154 · bitcoin/bitcoin · GitHub
12:07 < achow101> I would rather we focus on #22166 and #21329 for feature freeze
12:08 <@gribble> https://github.com/bitcoin/bitcoin/issues/22166 | Add support for inferring tr() descriptors by sipa · Pull Request #22166 · bitcoin/bitcoin · GitHub
12:08 <@gribble> https://github.com/bitcoin/bitcoin/issues/21329 | descriptor wallet: Cache last hardened xpub and use in normalized descriptors by achow101 · Pull Request #21329 · bitcoin/bitcoin · GitHub
12:10 < achow101> anything else to discuss?
12:10 < michaelfolkson> Ok and #22275 is pretty small
12:10 <@gribble> https://github.com/bitcoin/bitcoin/issues/22275 | A few follow-ups for taproot signing by sipa · Pull Request #22275 · bitcoin/bitcoin · GitHub
12:10 < michaelfolkson> Nope, that's it I think
12:11 < achow101> #endmeeting
12:11 < core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
12:11 < core-meetingbot> Meeting ended Fri Jun 18 19:11:06 2021 UTC.  
12:11 < core-meetingbot> Minutes:        https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2021/bitcoin-core-dev.2021-06-18-19.01.moin.txt
12:15 -!- chrysanthematic [~chrysanth@109.70.150.245] has joined #bitcoin-core-dev
12:38 -!- jespada [~jespada@90.254.247.46] has quit [Quit: Textual IRC Client: www.textualapp.com]
12:41 -!- chrysanthematic [~chrysanth@109.70.150.245] has quit [Quit: chrysanthematic]
12:47 -!- kabaum [~kabaum@host-78-77-216-135.mobileonline.telia.com] has joined #bitcoin-core-dev
12:58 -!- chrysanthematic [~chrysanth@89.38.69.171] has joined #bitcoin-core-dev
13:03 -!- chrysanthematic [~chrysanth@89.38.69.171] has quit [Changing host]
13:03 -!- chrysanthematic [~chrysanth@user/chrysanthematic] has joined #bitcoin-core-dev
13:03 -!- chrysanthematic [~chrysanth@user/chrysanthematic] has quit [Quit: chrysanthematic]
13:04 -!- chrysanthematic [~chrysanth@user/chrysanthematic] has joined #bitcoin-core-dev
13:07 -!- brcolow [~brcolow@ip68-0-136-132.tc.ph.cox.net] has joined #bitcoin-core-dev
13:25 -!- kabaum [~kabaum@host-78-77-216-135.mobileonline.telia.com] has quit [Ping timeout: 272 seconds]
13:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:36 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #22278: Add LIFETIMEBOUND to CScript where needed (master...2106-scriptBound) https://github.com/bitcoin/bitcoin/pull/22278
13:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:37 -!- Guest436 [~Guest4@2001:1970:539d:6200:35ab:7b5b:70fa:4926] has joined #bitcoin-core-dev
13:40 -!- Guest436 [~Guest4@2001:1970:539d:6200:35ab:7b5b:70fa:4926] has quit [Client Quit]
13:42 -!- Guest48 [~Guest48@2001:1970:539d:6200:35ab:7b5b:70fa:4926] has joined #bitcoin-core-dev
13:42 -!- Guest48 [~Guest48@2001:1970:539d:6200:35ab:7b5b:70fa:4926] has quit [Client Quit]
13:59 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
14:22 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:28 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
14:29 -!- smartin [~Icedove@88.135.18.171] has quit [Quit: smartin]
14:46 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
14:46 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
14:47 -!- l3kk0 [~l3kk0@TASTYWORKS.ear2.Chicago2.Level3.net] has quit [Ping timeout: 244 seconds]
14:47 -!- l3kk0 [~l3kk0@8.6.144.228] has joined #bitcoin-core-dev
15:14 -!- l3kk0 [~l3kk0@8.6.144.228] has quit [Ping timeout: 268 seconds]
15:23 -!- chrysanthematic [~chrysanth@user/chrysanthematic] has quit [Ping timeout: 264 seconds]
15:32 -!- lightlike [~lightlike@user/lightlike] has quit [Quit: Leaving]
15:32 -!- Guest32 [~Guest32@182.69.199.37] has quit [Ping timeout: 250 seconds]
15:34 -!- l3kk0 [~l3kk0@c-73-22-213-40.hsd1.il.comcast.net] has joined #bitcoin-core-dev
15:44 -!- chrysanthematic [~chrysanth@user/chrysanthematic] has joined #bitcoin-core-dev
16:02 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 252 seconds]
16:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
16:18 < bitcoin-git> [bitcoin] apoelstra opened pull request #22279: fuzz: add missing ECCVerifyHandle to base_encode_decode (master...2021-06--fuzztestix) https://github.com/bitcoin/bitcoin/pull/22279
16:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
16:20 -!- chrysanthematic [~chrysanth@user/chrysanthematic] has quit [Quit: chrysanthematic]
16:24 -!- chrysanthematic [~chrysanth@user/chrysanthematic] has joined #bitcoin-core-dev
16:27 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
16:32 -!- major1 [~major@gateway/tor-sasl/major] has quit [Remote host closed the connection]
16:32 < ariard> glozow: have a look on my last comment in #22252 but also on my mail published today highlighting my thinking and the context we should consider, here https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2021-June/019084.html
16:32 <@gribble> https://github.com/bitcoin/bitcoin/issues/22252 | policy: Trim Packages when transaction with same txid exists in mempool by glozow · Pull Request #22252 · bitcoin/bitcoin · GitHub
16:32 -!- major1 [~major@gateway/tor-sasl/major] has joined #bitcoin-core-dev
16:33 < ariard> hope it'll clear up miscommunications among us, and yes we can exchange on it during tuesday's meeting :) (actually quite a resource pointer for it)
16:34 -!- chrysanthematic [~chrysanth@user/chrysanthematic] has quit [Ping timeout: 268 seconds]
16:34 < ariard> it might be a good weekend read for anyone interested by L2 devs making all this noise about the mempool :p
16:45 -!- chrysanthematic [~chrysanth@user/chrysanthematic] has joined #bitcoin-core-dev
16:50 -!- chrysanthematic [~chrysanth@user/chrysanthematic] has quit [Ping timeout: 272 seconds]
17:06 -!- belcher_ [~belcher@user/belcher] has joined #bitcoin-core-dev
17:07 -!- zesty [uid446484@id-446484.charlton.irccloud.com] has quit [Quit: Connection closed for inactivity]
17:10 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 252 seconds]
17:27 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Ping timeout: 268 seconds]
17:37 -!- gwillen [gwillen@user/gwillen] has joined #bitcoin-core-dev
17:40 -!- sagi [~sagi@bzq-79-180-140-8.red.bezeqint.net] has joined #bitcoin-core-dev
17:43 -!- gwillen [gwillen@user/gwillen] has quit [Quit: WeeChat 3.2]
17:43 -!- gwillen [gwillen@2600:3c01::f03c:92ff:fe31:d7fb] has joined #bitcoin-core-dev
17:44 -!- gwillen [gwillen@2600:3c01::f03c:92ff:fe31:d7fb] has quit [Changing host]
17:44 -!- gwillen [gwillen@user/gwillen] has joined #bitcoin-core-dev
17:45 -!- gwillen [gwillen@user/gwillen] has quit [Client Quit]
17:45 -!- gwillen [gwillen@user/gwillen] has joined #bitcoin-core-dev
17:46 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
17:50 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 252 seconds]
17:56 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 268 seconds]
17:58 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
18:08 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection]
18:09 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
18:11 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
18:11 -!- sagi [~sagi@bzq-79-180-140-8.red.bezeqint.net] has quit [Ping timeout: 268 seconds]
18:49 -!- jtrag [~jtrag@c-71-207-125-151.hsd1.pa.comcast.net] has quit [Quit: <-----  is PODAK (Passed out drunk at keyboard), and he has somehow managed to quit/disconnect...]
19:52 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 252 seconds]
20:04 -!- zesty [uid446484@id-446484.charlton.irccloud.com] has joined #bitcoin-core-dev
20:39 -!- bomb-on [~bomb-on@194.144.47.113] has quit [Quit: aллилѹіа!]
20:46 -!- Guest6974 [~Guest69@218.212.21.21] has joined #bitcoin-core-dev
20:49 -!- Guest6974 [~Guest69@218.212.21.21] has quit [Client Quit]
21:07 -!- dvd [~dvd@nat-pool-rdu-t.redhat.com] has quit [Quit: ZNC 1.7.5 - https://znc.in]
21:07 -!- dvd [~dvd@nat-pool-rdu-t.redhat.com] has joined #bitcoin-core-dev
21:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
21:08 < bitcoin-git> [bitcoin] hebasto opened pull request #22281: build: Avoid @GLIBC_2.29 libm symbols when --enable-glibc-back-compat (master...210619-lm) https://github.com/bitcoin/bitcoin/pull/22281
21:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
21:40 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection]
21:41 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
22:47 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
22:49 -!- gribble [~gribble@bitcoin/bot/gribble] has quit [Remote host closed the connection]
22:51 -!- gribble [~gribble@bitcoin/bot/gribble] has joined #bitcoin-core-dev
22:51 -!- mode/#bitcoin-core-dev [+o gribble] by ChanServ
23:05 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection]
23:06 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev
23:13 -!- vnogueira [~vnogueira@user/vnogueira] has quit [Remote host closed the connection]
23:14 -!- vnogueira [~vnogueira@user/vnogueira] has joined #bitcoin-core-dev
23:25 -!- gribble [~gribble@bitcoin/bot/gribble] has quit [Remote host closed the connection]
23:30 -!- gribble [~gribble@bitcoin/bot/gribble] has joined #bitcoin-core-dev
23:30 -!- mode/#bitcoin-core-dev [+o gribble] by ChanServ
23:47 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection]
23:47 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev
23:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:50 < bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/0f47e01d7d49...e172ea880498
23:50 < bitcoin-git> bitcoin/master faff3f3 MarcoFalke: test: Add txin.sequence option to MiniWallet
23:50 < bitcoin-git> bitcoin/master fab871f MarcoFalke: test: Remove unused generate() from test
23:50 < bitcoin-git> bitcoin/master fab7e99 MarcoFalke: test: Use MiniWallet in test_no_inherited_signaling RBF test
23:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:50 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #22210: test: Use MiniWallet in test_no_inherited_signaling RBF test (master...2106-testMiniWallet) https://github.com/bitcoin/bitcoin/pull/22210
23:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
--- Log closed Sat Jun 19 00:00:42 2021