--- Log opened Mon Jun 21 00:00:12 2021 --- Day changed Mon Jun 21 2021 00:00 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev 00:16 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev 00:20 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has quit [Ping timeout: 265 seconds] 00:28 -!- kabaum [~kabaum@host-217-213-127-97.mobileonline.telia.com] has joined #bitcoin-core-dev 00:44 < _aj_> laanwj: i've added 19438 to the 22.0 milestone; if it makes more sense for it not to be there it can always be removed i guess 00:50 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev 01:00 -!- lkqwejhhgasdjhgn [~kljkljklk@p200300d46f03bc009d710c742f152aa1.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 01:08 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has quit [Ping timeout: 258 seconds] 01:12 -!- ChristianDecker[ [~cdeckerma@2001:470:69fc:105::2e8e] has joined #bitcoin-core-dev 01:15 -!- joshuajbouw [~jbouw@user/joshua] has joined #bitcoin-core-dev 01:18 -!- bkheist [~bkheist@ip-213-127-32-252.ip.prioritytelecom.net] has joined #bitcoin-core-dev 01:19 -!- AaronvanW [~AaronvanW@71pc74.sshunet.nl] has joined #bitcoin-core-dev 01:19 -!- evias [~evias__@196.red-88-6-131.staticip.rima-tde.net] has joined #bitcoin-core-dev 01:19 -!- evias [~evias__@196.red-88-6-131.staticip.rima-tde.net] has quit [Changing host] 01:19 -!- evias [~evias__@user/evias] has joined #bitcoin-core-dev 01:19 -!- bkheist [~bkheist@ip-213-127-32-252.ip.prioritytelecom.net] has quit [Client Quit] 01:22 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev 01:27 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has quit [Ping timeout: 268 seconds] 01:39 < jnewbery> _aj_: Definitely agree that 19438 would be good to get in for the next release 01:45 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 01:46 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev 01:52 -!- jackielove4u [uid43977@user/jackielove4u] has quit [Quit: Connection closed for inactivity] 01:54 -!- jespada [~jespada@90.254.247.46] has joined #bitcoin-core-dev 01:57 -!- kryptonz [~kryptonz@86.105.9.67] has joined #bitcoin-core-dev 01:58 -!- kryptonz [~kryptonz@86.105.9.67] has left #bitcoin-core-dev [] 02:03 -!- kexkey [~kexkey@static-198-54-132-142.cust.tzulo.com] has joined #bitcoin-core-dev 02:05 -!- kexkey_ [~kexkey@static-198-54-132-126.cust.tzulo.com] has quit [Ping timeout: 265 seconds] 02:07 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 244 seconds] 02:07 -!- belcher_ is now known as belcher 02:14 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev 02:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:16 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f6a25bea826e...6a67366fdc3e 02:16 < bitcoin-git> bitcoin/master 4e353cb João Barbosa: http: Release work queue after event base finish 02:16 < bitcoin-git> bitcoin/master 6a67366 W. J. van der Laan: Merge bitcoin/bitcoin#19033: http: Release work queue after event base fin... 02:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:16 < bitcoin-git> [bitcoin] laanwj merged pull request #19033: http: Release work queue after event base finish (master...2020-05-fix-race-interrupt-http-server) https://github.com/bitcoin/bitcoin/pull/19033 02:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:18 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has quit [Ping timeout: 252 seconds] 02:19 -!- AaronvanW [~AaronvanW@71pc74.sshunet.nl] has quit [Ping timeout: 268 seconds] 02:27 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection] 02:27 -!- vnogueira [~vnogueira@user/vnogueira] has quit [Remote host closed the connection] 02:27 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection] 02:27 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection] 02:27 < laanwj> _aj_: it seems kind of involved (19 files changes, including consensus code), and i'm not sure it's a good idea to add further features to the 22.0 milestone 02:28 < laanwj> i mean we're already slipping the feature freeze with the currentl ylabeled PRs 02:28 < laanwj> hebasto: haven't read *anything* about stopping ARM 32 bit support 02:28 < laanwj> hebasto: that would be extremely sudden 02:29 < hebasto> laanwj: ok 02:30 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev 02:30 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev 02:31 -!- vnogueira [~vnogueira@user/vnogueira] has joined #bitcoin-core-dev 02:33 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 02:35 < laanwj> if the libc symbol issue is not solvable we could bump thje minimum libc for that platform 02:37 < laanwj> that will affect a lot less people than dropping the platform completely 02:38 < hebasto> ^^ sgtm, will look into possible implementation 02:40 < laanwj> thanks! 02:41 < hebasto> laanwj: what do you think about getrandom and getentropy symbols? 02:41 < laanwj> i don't know 02:42 < laanwj> they both come from dependencies at least (libevent and qt respectively) which apparently need their own internal random generation and seeding 02:43 < hebasto> cannot see the way to make boost ignore new random.h without patching 02:43 < laanwj> what happens if you build those libraries against older libc which doesn't have those symbols? 02:43 < laanwj> i mean i'm sure it has some kind of build-time detection for them? 02:44 < hebasto> package (at least boost) auto detects glibc version 02:44 < laanwj> or does libevent and qt refuse to build against older glibc 02:44 < laanwj> clear, that's what imean 02:44 < laanwj> what if the glibc doesn't have those symbols 02:45 < hebasto> no issues with glibc 2.27 on bionic 02:45 < laanwj> (which is the case for the version we are trying to support) 02:46 < hebasto> ^^ until #22244 was merged 02:46 < laanwj> sure, but we need it to run against glibc 2.17, which we somehow determined to be the minimum glibc at some point the distributed binaries sshould run agianst 02:47 < laanwj> all #22244 did was fix the check 02:47 < hebasto> right :) 02:47 < laanwj> it was not actually running on those platforms, the check was wrong because it ignored some symbols 02:48 < hebasto> if our release will be made via guix there is an idea to point it to glib 2.25 02:48 < hebasto> err 2.24 02:48 < laanwj> yes, if that is possible it would solve a large part of the problem 02:49 < hebasto> dongcarl: ^ 02:50 < laanwj> i would really prefer compiling and linking against the minimum glibc version that we support at run time, working around every symbol individually is very error prone 02:50 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev 02:50 -!- jackielove4u [uid43977@user/jackielove4u] has joined #bitcoin-core-dev 02:50 * MarcoFalke wen musl? 02:51 < laanwj> providing our own implementation of getrandom and getentropy seems unwise 02:51 < laanwj> MarcoFalke: yes please 02:51 < laanwj> no way we're going to be able to switch to that before 22.0 though 02:51 < hebasto> maybe 23.0? 02:51 < laanwj> sgtm 02:55 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has quit [Ping timeout: 258 seconds] 02:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:58 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #20509: net: CAddress deser: use stream's version, not what's coming from disk (master...caddress_deser_version) https://github.com/bitcoin/bitcoin/pull/20509 02:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:08 < bitcoin-git> [bitcoin] laanwj opened pull request #22294: build: Perform boost::process detection with BOOST_CPPFLAGS (master...2021-06-boost-process-detection) https://github.com/bitcoin/bitcoin/pull/22294 03:08 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:14 -!- AaronvanW [~AaronvanW@71pc74.sshunet.nl] has joined #bitcoin-core-dev 03:18 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev 03:22 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has quit [Ping timeout: 252 seconds] 03:33 -!- Kiminuo [~Kiminuo@141.98.103.236] has joined #bitcoin-core-dev 03:41 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Ping timeout: 268 seconds] 03:47 < Kiminuo> Hi, would anyone know how to correctly write L1562 ad L1563 here https://github.com/bitcoin/bitcoin/pull/21422#pullrequestreview-675206546? 03:48 -!- evias [~evias__@user/evias] has quit [Quit: This computer has gone to sleep] 03:51 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev 03:55 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has quit [Ping timeout: 265 seconds] 03:59 -!- evias [~evias__@user/evias] has joined #bitcoin-core-dev 04:01 < laanwj> _aj_: on the other hand it has been open for a long time and does have had a lot of review 04:02 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev 04:14 -!- orionwl [~laanwj@user/laanwj] has joined #bitcoin-core-dev 04:16 -!- laanwj [~laanwj@user/laanwj] has quit [Ping timeout: 268 seconds] 04:23 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""] 05:00 -!- Kiminuo [~Kiminuo@141.98.103.236] has quit [Quit: Client closed] 05:00 -!- AaronvanW [~AaronvanW@71pc74.sshunet.nl] has quit [Quit: Leaving...] 05:05 -!- AaronvanW [~AaronvanW@71pc74.sshunet.nl] has joined #bitcoin-core-dev 05:06 -!- sagi [~sagi@bzq-79-180-140-8.red.bezeqint.net] has joined #bitcoin-core-dev 05:12 -!- Kiminuo [~Kiminuo@141.98.103.236] has joined #bitcoin-core-dev 05:37 -!- GIANTWORLDKEEPER [~pjetcetal@2.95.227.207] has quit [Read error: Connection reset by peer] 05:45 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev 05:46 -!- sagi [~sagi@bzq-79-180-140-8.red.bezeqint.net] has quit [Ping timeout: 265 seconds] 05:49 -!- cryptapus [~cryptapus@user/cryptapus] has quit [Quit: Konversation terminated!] 05:50 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has quit [Ping timeout: 258 seconds] 05:52 -!- cryptapus [~cryptapus@user/cryptapus] has joined #bitcoin-core-dev 05:55 < _aj_> orionwl: yeah, no harm no foul if you need to pull it out 05:58 -!- kabaum [~kabaum@host-217-213-127-97.mobileonline.telia.com] has quit [Ping timeout: 265 seconds] 06:06 -!- sagi [~sagi@bzq-79-180-140-8.red.bezeqint.net] has joined #bitcoin-core-dev 06:20 -!- sagi [~sagi@bzq-79-180-140-8.red.bezeqint.net] has quit [Ping timeout: 252 seconds] 06:20 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev 06:20 -!- sagi [~sagi@bzq-109-65-142-68.red.bezeqint.net] has joined #bitcoin-core-dev 06:24 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has quit [Ping timeout: 252 seconds] 06:32 -!- sagi [~sagi@bzq-109-65-142-68.red.bezeqint.net] has quit [Ping timeout: 250 seconds] 06:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:55 < bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/6a67366fdc3e...6556da77d75f 06:55 < bitcoin-git> bitcoin/master a7fcc8e Christian Decker: rpc: Add a `-rpcwaittimeout` parameter to limit time spent waiting 06:55 < bitcoin-git> bitcoin/master c490e17 Christian Decker: doc: Add release notes for the `-rpcwaittimeout` cli parameter 06:55 < bitcoin-git> bitcoin/master f76cb10 Christian Decker: rpc: Prefix rpcwaittimeout error with details on its nature 06:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:55 < bitcoin-git> [bitcoin] laanwj merged pull request #21056: rpc: Add a `-rpcwaittimeout` parameter to limit time spent waiting (master...rpcwait-timeout) https://github.com/bitcoin/bitcoin/pull/21056 06:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:02 -!- Kiminuo [~Kiminuo@141.98.103.236] has quit [Ping timeout: 246 seconds] 07:07 -!- kittywhiskers [~kittywhis@user/kittywhiskers] has quit [Quit: kittywhiskers] 07:09 -!- davterra [~davterra@178.128.106.205] has quit [Quit: Leaving] 07:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:13 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/6556da77d75f...74013641e035 07:13 < bitcoin-git> bitcoin/master ce024b1 Sebastian Falbesoner: test: MiniWallet: force P2PK signature to have fixed size (71 bytes) 07:13 < bitcoin-git> bitcoin/master d6d2ab9 Sebastian Falbesoner: test: MiniWallet: fix fee calculation for P2PK and check tx vsize 07:13 < bitcoin-git> bitcoin/master 7401364 MarcoFalke: Merge bitcoin/bitcoin#22089: test: MiniWallet: fix fee calculation for P2P... 07:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:13 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #22089: test: MiniWallet: fix fee calculation for P2PK and check tx vsize (master...202105-test-miniwallet-fix_p2pk_fee_calculation) https://github.com/bitcoin/bitcoin/pull/22089 07:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:15 -!- sagi [~sagi@bzq-109-65-142-68.red.bezeqint.net] has joined #bitcoin-core-dev 07:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:27 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #22296: doc: Final merge of release notes snippets (master...2106-doRel) https://github.com/bitcoin/bitcoin/pull/22296 07:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:38 -!- Guest82 [~Guest82@121.13.76.188.dynamic.jazztel.es] has joined #bitcoin-core-dev 07:47 -!- GIANTWORLDKEEPER [~pjetcetal@2.95.227.207] has joined #bitcoin-core-dev 07:49 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev 07:55 < orionwl> hebasto: thanks for doing the research wrt #22280 #22287 #22281 07:55 -!- orionwl is now known as laanwj 07:57 * laanwj also wonders what happened to gribble 07:58 -!- sagi [~sagi@bzq-109-65-142-68.red.bezeqint.net] has quit [Ping timeout: 258 seconds] 07:59 -!- Guest82 [~Guest82@121.13.76.188.dynamic.jazztel.es] has quit [Quit: Client closed] 08:06 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 08:07 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has quit [Ping timeout: 252 seconds] 08:07 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev 08:14 -!- kabaum [~kabaum@host-217-213-121-175.mobileonline.telia.com] has joined #bitcoin-core-dev 08:16 -!- laanwj [~laanwj@user/laanwj] has quit [Ping timeout: 265 seconds] 08:22 -!- laanwj [~laanwj@user/laanwj] has joined #bitcoin-core-dev 08:36 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev 08:37 -!- GIANTWORLDKEEPER [~pjetcetal@2.95.227.207] has quit [Remote host closed the connection] 08:39 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 08:41 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has quit [Ping timeout: 265 seconds] 08:42 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 258 seconds] 08:53 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev 08:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:57 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/74013641e035...398dd6783389 08:57 < bitcoin-git> bitcoin/master fa09fd1 MarcoFalke: doc: Final merge of release notes snippets 08:57 < bitcoin-git> bitcoin/master 398dd67 MarcoFalke: Merge bitcoin/bitcoin#22296: doc: Final merge of release notes snippets, m... 08:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:57 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #22296: doc: Final merge of release notes snippets, mv to wiki (master...2106-doRel) https://github.com/bitcoin/bitcoin/pull/22296 08:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:58 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 08:59 * MarcoFalke (mic) Release notes now being edited on https://github.com/bitcoin-core/bitcoin-devwiki/wiki/22.0-Release-Notes-draft 08:59 -!- lkqwejhhgasdjhgn [~kljkljklk@p200300d46f03bc009d710c742f152aa1.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!] 09:00 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has quit [Ping timeout: 265 seconds] 09:01 -!- jessepos_ [~jesse@2601:647:0:89:6de9:9aa6:8bb7:1691] has quit [Quit: Textual IRC Client: www.textualapp.com] 09:02 -!- jesseposner [~jesse@2601:647:0:89:6de9:9aa6:8bb7:1691] has joined #bitcoin-core-dev 09:06 -!- evias_ [~evias__@196.red-88-6-131.staticip.rima-tde.net] has joined #bitcoin-core-dev 09:08 -!- evias [~evias__@user/evias] has quit [Ping timeout: 250 seconds] 09:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:10 < bitcoin-git> [bitcoin] amitiuttarwar closed pull request #21528: [p2p] Reduce addr blackholes (master...2021-03-addr-defer2) https://github.com/bitcoin/bitcoin/pull/21528 09:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:11 < bitcoin-git> [bitcoin] amitiuttarwar reopened pull request #21528: [p2p] Reduce addr blackholes (master...2021-03-addr-defer2) https://github.com/bitcoin/bitcoin/pull/21528 09:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:11 -!- sagi [~sagi@bzq-109-67-175-199.red.bezeqint.net] has joined #bitcoin-core-dev 09:18 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev 09:22 -!- angela [~angela@223.226.41.193] has joined #bitcoin-core-dev 09:23 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has quit [Ping timeout: 268 seconds] 09:25 < angela> Hello! :) I have been reading a lot about bitcoin recently and have been thoroughly moved! I want to start understanding and contributing to bitcoin-core. Can someone recommend good newbie contributor resources? Thanks 09:27 < sipa> angela: https://medium.com/@amitiu/onboarding-to-bitcoin-core-7c1a83b20365 and https://jonatack.github.io/articles/how-to-contribute-pull-requests-to-bitcoin-core contain a lot of information 09:30 < angela> Thanks sipa! Just what I was looking for! 09:37 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev 09:52 -!- GIANTWORLDKEEPER [~pjetcetal@2.95.227.207] has joined #bitcoin-core-dev 10:05 -!- angela [~angela@223.226.41.193] has quit [Quit: Client closed] 10:14 -!- evias_ [~evias__@196.red-88-6-131.staticip.rima-tde.net] has quit [Quit: This computer has gone to sleep] 10:25 < jamesob> anyone have tips for running `lint-all.sh` locally? do we have a container image to mount into or something? because when I run it naively, I get about a bazillion errors many of which don't occur on CI 10:29 < dongcarl> Sorry, just caught up on the discussion here... orionwl[m] laanwj hebasto see #bitcoin-core-builds for some of my thoughts 10:33 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Ping timeout: 250 seconds] 10:40 -!- sagi [~sagi@bzq-109-67-175-199.red.bezeqint.net] has quit [Ping timeout: 252 seconds] 10:46 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev 10:47 -!- gribble [~gribble@bitcoin/bot/gribble] has joined #bitcoin-core-dev 10:47 -!- mode/#bitcoin-core-dev [+o gribble] by ChanServ 10:55 -!- sagi [~sagi@bzq-109-67-175-199.red.bezeqint.net] has joined #bitcoin-core-dev 10:55 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev 11:09 -!- kabaum [~kabaum@host-217-213-121-175.mobileonline.telia.com] has quit [Ping timeout: 265 seconds] 11:16 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has quit [Remote host closed the connection] 11:16 -!- sagi [~sagi@bzq-109-67-175-199.red.bezeqint.net] has quit [Ping timeout: 265 seconds] 11:17 -!- powerjungle [~powerjung@h081217087223.dyn.cm.kabsi.at] has joined #bitcoin-core-dev 11:22 -!- kabaum [~kabaum@host-217-213-153-74.mobileonline.telia.com] has joined #bitcoin-core-dev 11:24 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev 11:35 -!- RDK [~Raoul@p200300db6717ba104091b710af9d7498.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 11:42 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has quit [Remote host closed the connection] 11:49 -!- RDK [~Raoul@p200300db6717ba104091b710af9d7498.dip0.t-ipconnect.de] has quit [Quit: Leaving] 11:49 -!- RDK [~Raoul@p200300db6717ba104091b710af9d7498.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 11:50 -!- RDK_ [~Raoul@p200300db6717ba104091b710af9d7498.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 11:50 -!- RDK_ [~Raoul@p200300db6717ba104091b710af9d7498.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 11:52 < jonatack> jamesob: i use a bash alias to run "test/lint/lint-circular-dependencies.sh ; ./test/lint/lint-python.sh" 11:52 < jonatack> since those seem to be the ones i ever ran up against 11:52 -!- RDK_ [~Raoul@p200300db6717ba104091b710af9d7498.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 11:52 < jonatack> (agree; lint-all was always unusable for me) 11:55 -!- RDK__ [~Raoul@p200300db6717ba104091b710af9d7498.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 11:56 -!- RDK_ [~Raoul@p200300db6717ba104091b710af9d7498.dip0.t-ipconnect.de] has quit [Client Quit] 11:56 -!- RDK [~Raoul@p200300db6717ba104091b710af9d7498.dip0.t-ipconnect.de] has quit [Quit: Leaving] 11:57 -!- RDK__ [~Raoul@p200300db6717ba104091b710af9d7498.dip0.t-ipconnect.de] has quit [Client Quit] 11:57 -!- evias_ [~evias__@196.red-88-6-131.staticip.rima-tde.net] has joined #bitcoin-core-dev 11:58 -!- evias_ [~evias__@196.red-88-6-131.staticip.rima-tde.net] has quit [Client Quit] 12:02 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 12:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:09 < bitcoin-git> [bitcoin] amanciojsilvjr opened pull request #22297: Bitcoin<>nuclear (master...master) https://github.com/bitcoin/bitcoin/pull/22297 12:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:11 < bitcoin-git> [bitcoin] sipa closed pull request #22297: Bitcoin<>nuclear (master...master) https://github.com/bitcoin/bitcoin/pull/22297 12:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:12 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev 12:14 < jamesob> jonatack: thanks; even when I run individual `lint-*.sh` scripts, the results can diverge quite a bit from CI. pretty frustrating 12:16 < jonatack> jamesob: oh? huh. i think those two at least were ok for me along with test/lint/lint-spelling.sh 12:18 < jonatack> is that new? 12:22 < jamesob> haven't tried those two; the ones giving me trouble are logs, whitespace, and shell 12:25 -!- kabaum [~kabaum@host-217-213-153-74.mobileonline.telia.com] has quit [Ping timeout: 265 seconds] 12:28 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has quit [Remote host closed the connection] 12:30 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev 12:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:31 < bitcoin-git> [bitcoin] amanciojsilvjr opened pull request #22298: CryptoGraphyBTC (master...master) https://github.com/bitcoin/bitcoin/pull/22298 12:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:34 -!- flow [~none@salem.informatik.uni-erlangen.de] has quit [Changing host] 12:34 -!- flow [~none@gentoo/developer/flow] has joined #bitcoin-core-dev 12:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:35 < bitcoin-git> [bitcoin] sipa closed pull request #22298: CryptoGraphyBTC (master...master) https://github.com/bitcoin/bitcoin/pull/22298 12:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:42 < bitcoin-git> [bitcoin] amanciojsilvjr opened pull request #22299: Create Bitcoin<>nuclear.defense (master...patch-4) https://github.com/bitcoin/bitcoin/pull/22299 12:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:43 < bitcoin-git> [bitcoin] sipa closed pull request #22299: Create Bitcoin<>nuclear.defense (master...patch-4) https://github.com/bitcoin/bitcoin/pull/22299 12:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:54 < bitcoin-git> [bitcoin] amanciojsilvjr opened pull request #22300: Create Bitcoin<>nuclear.defense (master...patch-6) https://github.com/bitcoin/bitcoin/pull/22300 12:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:55 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 12:57 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev 12:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:58 < bitcoin-git> [bitcoin] sipa closed pull request #22300: Create Bitcoin<>nuclear.defense (master...patch-6) https://github.com/bitcoin/bitcoin/pull/22300 12:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:11 -!- Kiminuo [~Kiminuo@141.98.103.236] has joined #bitcoin-core-dev 13:28 -!- jarthur [~jarthur@2603-8080-1540-002d-f1a7-3092-c6c9-daa4.res6.spectrum.com] has joined #bitcoin-core-dev 13:40 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has quit [Remote host closed the connection] 13:41 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev 13:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:42 < bitcoin-git> [bitcoin] amanciojsilvjr opened pull request #22301: Amanciojsilvjr patch 2 (master...amanciojsilvjr-patch-2) https://github.com/bitcoin/bitcoin/pull/22301 13:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:45 -!- lightlike [~lightlike@user/lightlike] has joined #bitcoin-core-dev 13:46 -!- evias_ [~evias__@196.red-88-6-131.staticip.rima-tde.net] has joined #bitcoin-core-dev 13:46 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has quit [Ping timeout: 258 seconds] 13:46 -!- evias_ [~evias__@196.red-88-6-131.staticip.rima-tde.net] has quit [Client Quit] 13:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:47 < bitcoin-git> [bitcoin] amanciojsilvjr closed pull request #22301: Amanciojsilvjr patch 2 (master...amanciojsilvjr-patch-2) https://github.com/bitcoin/bitcoin/pull/22301 13:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:47 < bitcoin-git> [bitcoin] amanciojsilvjr reopened pull request #22301: Amanciojsilvjr patch 2 (master...amanciojsilvjr-patch-2) https://github.com/bitcoin/bitcoin/pull/22301 13:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:47 < bitcoin-git> [bitcoin] sipa closed pull request #22301: Amanciojsilvjr patch 2 (master...amanciojsilvjr-patch-2) https://github.com/bitcoin/bitcoin/pull/22301 13:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:51 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev 13:53 -!- Kiminuo [~Kiminuo@141.98.103.236] has quit [Ping timeout: 246 seconds] 14:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:02 < bitcoin-git> [bitcoin] amanciojsilvjr opened pull request #22302: Create Bitcoin<>nuclear.defense (master...patch-6) https://github.com/bitcoin/bitcoin/pull/22302 14:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:02 -!- doubleqp [~doubleqp@162.55.6.42] has quit [Ping timeout: 268 seconds] 14:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:06 < bitcoin-git> [bitcoin] sipa closed pull request #22302: Create Bitcoin<>nuclear.defense (master...patch-6) https://github.com/bitcoin/bitcoin/pull/22302 14:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:21 < bitcoin-git> [bitcoin] amanciojsilvjr opened pull request #22303: Create Bitcoin<>nuclear.defense (master...patch-4) https://github.com/bitcoin/bitcoin/pull/22303 14:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:23 < bitcoin-git> [bitcoin] sipa closed pull request #22303: Create Bitcoin<>nuclear.defense (master...patch-4) https://github.com/bitcoin/bitcoin/pull/22303 14:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:24 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has quit [Remote host closed the connection] 14:25 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev 14:29 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has quit [Ping timeout: 258 seconds] 14:45 -!- doubleqp [~doubleqp@162.55.6.42] has joined #bitcoin-core-dev 14:53 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev 14:57 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has quit [Ping timeout: 252 seconds] 15:02 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev 15:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 15:26 < bitcoin-git> [bitcoin] amanciojsilvjr opened pull request #22304: CryptoGraphyBTC> [bitcoin] hebasto closed pull request #22304: CryptoGraphyBTC> hebasto: any reason you limited palette updates to macOS? 17:15 < hebasto> luke-jr: not limited, rather focused on macOS 17:17 < hebasto> and macOS has auto-change of appearance feature 17:59 -!- sagi [~sagi@bzq-79-179-156-161.red.bezeqint.net] has joined #bitcoin-core-dev 18:08 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has quit [Remote host closed the connection] 18:12 < luke-jr> hebasto: #ifdef Q_OS_MACOS 18:13 -!- bomb-on [~bomb-on@194.144.47.113] has joined #bitcoin-core-dev 18:13 < hebasto> windows and linux were not goals for that pr, and were not tested 18:14 < hebasto> I agree it could be accepted for other platforms 18:18 < luke-jr> limiting features to one platform arbitrarily doesn't seem to make sense, especially when it's the hardest-to-test platform :P 18:19 < hebasto> I don't understand your point. it was not "arbitrarily" -- there was users' request 18:21 < hebasto> getting dark mode work on linux highly depends on DE, btw 18:22 -!- evanlinjin [~evanlinji@218-35-179-62.cm.dynamic.apol.com.tw] has joined #bitcoin-core-dev 18:22 -!- evanlinjin [~evanlinji@218-35-179-62.cm.dynamic.apol.com.tw] has quit [Remote host closed the connection] 18:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:22 < bitcoin-git> [bitcoin] hebasto opened pull request #22305: build: Avoid fcntl64@GLIBC_2.28 in libsqlite3.a (master...210622-fcntl) https://github.com/bitcoin/bitcoin/pull/22305 18:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:23 < luke-jr> hebasto: but it's certain to have the same issues without this code 18:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:25 < bitcoin-git> [bitcoin] amitiuttarwar opened pull request #22306: [test] Improvements to p2p_addr_relay.py (master...2021-06-addr-tests) https://github.com/bitcoin/bitcoin/pull/22306 18:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:27 -!- davterra [~davterra@178.128.106.205] has joined #bitcoin-core-dev 18:29 < hebasto> luke-jr: ofc, because it was not its goal to change behavior on Linux or Windows 18:37 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev 18:39 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has quit [Remote host closed the connection] 18:59 -!- sagi [~sagi@bzq-79-179-156-161.red.bezeqint.net] has quit [Ping timeout: 252 seconds] 19:11 < kanzure> win 5 19:11 < kanzure> whoops 19:31 -!- bomb-on [~bomb-on@194.144.47.113] has quit [Quit: aллилѹіа!] 19:39 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev 19:44 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has quit [Ping timeout: 252 seconds] 19:45 -!- gribble [~gribble@bitcoin/bot/gribble] has quit [Remote host closed the connection] 19:52 -!- gribble [~gribble@bitcoin/bot/gribble] has joined #bitcoin-core-dev 19:52 -!- mode/#bitcoin-core-dev [+o gribble] by ChanServ 20:36 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Ping timeout: 268 seconds] 21:01 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 21:03 < robertspigler> re: travel restrictions for developer meetup, the Kayak travel website has a world map where you can select any origin country, and then see all the restrictions 21:29 < Bullit> Yeah if you didnt know google has 1379 members and the stockbroker application Alphabet A and Alphabet C are runaway CEO´s saddly what is suggested about the kayak is googles suggestion in from europe to america by kayak 21:35 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev 22:15 -!- nanotube [~nanotube@user/nanotube] has quit [Ping timeout: 240 seconds] 22:16 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev 22:16 -!- nanotube [~nanotube@user/nanotube] has joined #bitcoin-core-dev 22:24 -!- smartin [~Icedove@88.135.18.171] has joined #bitcoin-core-dev 22:25 -!- sagi [~sagi@176.230.171.147] has joined #bitcoin-core-dev 22:38 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has quit [Remote host closed the connection] 22:38 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev 22:43 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has quit [Ping timeout: 252 seconds] 22:44 -!- Kiminuo [~Kiminuo@141.98.103.76] has joined #bitcoin-core-dev 22:56 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev 23:04 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has quit [Ping timeout: 258 seconds] 23:07 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 244 seconds] 23:07 -!- sagi [~sagi@176.230.171.147] has quit [Ping timeout: 265 seconds] 23:11 -!- sagi [~sagi@176.230.171.147] has joined #bitcoin-core-dev 23:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:13 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/398dd6783389...672870ab7ba5 23:13 < bitcoin-git> bitcoin/master 168b6c3 Josiah Baker: add dummy file param to fix jupyter 23:13 < bitcoin-git> bitcoin/master 672870a MarcoFalke: Merge bitcoin/bitcoin#22201: test: Fix TestShell to allow running in Jupyt... 23:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:14 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #22201: test: Fix TestShell to allow running in Jupyter Notebook (master...josibake-parse-only-known-arguments-in-testshell) https://github.com/bitcoin/bitcoin/pull/22201 23:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:15 -!- Kiminuo [~Kiminuo@141.98.103.76] has quit [Ping timeout: 246 seconds] 23:18 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev 23:23 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has quit [Ping timeout: 252 seconds] 23:27 -!- jarthur [~jarthur@2603-8080-1540-002d-f1a7-3092-c6c9-daa4.res6.spectrum.com] has quit [Ping timeout: 252 seconds] 23:35 -!- Kiminuo [~Kiminuo@141.98.103.76] has joined #bitcoin-core-dev 23:41 -!- jarthur [~jarthur@2603-8080-1540-002d-f9cc-6895-8b3d-e0f4.res6.spectrum.com] has joined #bitcoin-core-dev 23:42 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 23:44 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has joined #bitcoin-core-dev 23:49 -!- jeremyru_ [~jeremyrub@024-176-247-182.res.spectrum.com] has quit [Ping timeout: 268 seconds] 23:55 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Remote host closed the connection] 23:55 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev 23:59 -!- donny [uid133844@id-133844.brockwell.irccloud.com] has joined #bitcoin-core-dev --- Log closed Tue Jun 22 00:00:45 2021