--- Log opened Mon Jul 19 00:00:10 2021
00:01 < vasild> achow101: sipa: but does our lock order detect potential issues like: lock A, lock B, unlock B, unlock A; at this time the lock stack for the thread would be empty, then at a later time: lock B, lock A.
00:02 < vasild> looking at src/sync.cpp I think it will not detect ^
00:05 -!- davterra [~davterra@143.244.186.214] has joined #bitcoin-core-dev
00:06 -!- user__ [~davterra@143.244.186.214] has quit [Read error: Connection reset by peer]
00:11 -!- AaronvanW [~AaronvanW@178.239.173.218] has joined #bitcoin-core-dev
00:16 -!- AaronvanW [~AaronvanW@178.239.173.218] has quit [Ping timeout: 268 seconds]
00:28 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
00:28 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev
00:29 -!- AaronvanW [~AaronvanW@178.239.173.217] has joined #bitcoin-core-dev
00:31 -!- goatpig [~goat@2a01cb0801f0f600be47f4aa218cbe13.ipv6.abo.wanadoo.fr] has joined #bitcoin-core-dev
00:34 -!- AaronvanW [~AaronvanW@178.239.173.217] has quit [Ping timeout: 255 seconds]
00:45 -!- AaronvanW [~AaronvanW@178.239.173.218] has joined #bitcoin-core-dev
00:46 < laanwj> no, it doesn't detect that, i guess it would require quite a lot of extra record-keeping
00:47 < laanwj> keeping track of current locking state versus historical locking state
00:47 -!- jarthur [~jarthur@2603-8080-1540-002d-7828-89c1-5bc4-4b6a.res6.spectrum.com] has quit [Quit: jarthur]
00:50 -!- AaronvanW [~AaronvanW@178.239.173.218] has quit [Ping timeout: 268 seconds]
00:52 < vasild> right, that would be significant runtime performance overhead
00:52 < S3RK> now I'm confused. What's the difference between "conflicting relative orders are observed" and "locking state versus hisotrical locking state"?
00:53 < vasild> hmm, actually not, the "lock orders" database can be global, need not be per-thread, so at least the size/memory overhead would not be too much
00:54 -!- user__ [~davterra@143.244.186.214] has joined #bitcoin-core-dev
00:55 < vasild> S3RK: "conflicting relative orders are observed" probably means that some thread locked A, B (in that order) and another thread locked B and tries to lock A, _while_ the first thread still holds both mutexes
00:56 -!- davterra [~davterra@143.244.186.214] has quit [Ping timeout: 258 seconds]
00:57 < vasild> while "locking state versus hisotrical locking state" imples that we remember that the first thread has locked A,B even after it releases those mutexes, so if we do that it is possible to detect if another thread locks B,A even after the first thread has released all mutexes
00:57 < S3RK> how is it possible that the second thred locked B while the first thread still holds both?
00:58 -!- kiran [~kiran@218.185.248.66] has joined #bitcoin-core-dev
00:58 -!- kiran21 [~kiran@218.185.248.66] has joined #bitcoin-core-dev
00:58 -!- cold [~cold@user/cold] has quit [Ping timeout: 265 seconds]
00:58 -!- kiran21 [~kiran@218.185.248.66] has quit [Client Quit]
00:59 < vasild> it is not possible, of course, I am talking nonsense. The scenario is: thread1: lock A, thread2: lock B, thread1: try to lock B, thread2: try to lock A
01:00 < vasild> The thing is that after a thread releases a lock we delete it from its lock-stack == we forget that it ever locked it.
01:00 < S3RK> hm... this sounds like deadlock detection. I thought debug_lockorder is something more
01:00 -!- cold [~cold@user/cold] has joined #bitcoin-core-dev
01:02 < vasild> see push_lock() and pop_lock() in src/sync.cpp
01:02 < S3RK> will do, thanks
01:03 -!- earnestly [~earnest@user/earnestly] has joined #bitcoin-core-dev
01:06 -!- jarthur [~jarthur@cpe-70-114-198-37.austin.res.rr.com] has joined #bitcoin-core-dev
01:22 < S3RK> lockorder is actually removed in DeleteLock() but I'm not familiar with the code at all to understnd fully how it works
01:33 < jnewbery> vasild: with DEBUG_LOCKORDER, we keep a global object to track all the previous lock stacks, to detect any potential lock inversions: https://github.com/bitcoin/bitcoin/blob/e8f85e0e86e92e583b8984455b7bf9d0a777578a/src/sync.cpp#L90-L104
01:34 < vasild> aha, so we already do!
01:36 < vasild> but wait, we do erase() from DeleteLock()
01:47 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Ping timeout: 255 seconds]
01:48 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev
01:52 -!- AaronvanW [~AaronvanW@178.239.173.218] has joined #bitcoin-core-dev
01:55 -!- jarthur [~jarthur@cpe-70-114-198-37.austin.res.rr.com] has quit [Quit: jarthur]
01:56 -!- AaronvanW [~AaronvanW@178.239.173.218] has quit [Ping timeout: 252 seconds]
02:03 < laanwj> huh, I thought the idea behind using thread-local storage in DEBUG_LOCKORDER was to avoid the overhead of having any global synchronized objects in the lock tracking
02:03 < laanwj> but yeah that can't be the case, it has to cross-check
02:04 < laanwj> it was never intended to be really efficient or low-overhead, that's why it's only enabled with debug builds
02:07 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
02:07 < jnewbery> I think DeleteLock() is called when the mutex is destroyed, not when the lock is released
02:08 < jnewbery> LeaveCritical() is the function called when the lock is released
02:10 -!- AaronvanW [~AaronvanW@178.239.173.217] has joined #bitcoin-core-dev
02:12 < laanwj> that seems to be the case, it is called from the destructor of AnnotatedMixin, which is used to define RecursiveMutex etc
02:15 -!- AaronvanW [~AaronvanW@178.239.173.217] has quit [Ping timeout: 255 seconds]
02:28 -!- AaronvanW [~AaronvanW@178.239.173.217] has joined #bitcoin-core-dev
02:32 -!- AaronvanW [~AaronvanW@178.239.173.217] has quit [Ping timeout: 255 seconds]
02:36 < _aj_> laanwj: it's not really thread local storage, it's a global map (GetLockData()) indexed by thread id? it used to be thread local prior to #18881 by the looks
02:36 <@gribble> https://github.com/bitcoin/bitcoin/issues/18881 | Prevent UB in DeleteLock() function by hebasto · Pull Request #18881 · bitcoin/bitcoin · GitHub
02:37 < laanwj> _aj_: correct, the TLS is only used for the thread names
02:37 < laanwj> I must have mixed a few things up
02:38 < laanwj> I remember it differently than that it is
02:43 < laanwj> it did use thread_local before last year (26c093a9957756f3743c2347fe0abd90f81159c4, #18881)
02:43 <@gribble> https://github.com/bitcoin/bitcoin/issues/18881 | Prevent UB in DeleteLock() function by hebasto · Pull Request #18881 · bitcoin/bitcoin · GitHub
02:44 < vasild> A simple confirmation that lock order is being remembered: https://bpa.st/2CBQ
02:45 -!- AaronvanW [~AaronvanW@178.239.167.157] has joined #bitcoin-core-dev
02:50 -!- AaronvanW [~AaronvanW@178.239.167.157] has quit [Ping timeout: 252 seconds]
03:01 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Ping timeout: 255 seconds]
03:02 -!- AaronvanW [~AaronvanW@178.239.173.216] has joined #bitcoin-core-dev
03:07 -!- AaronvanW [~AaronvanW@178.239.173.216] has quit [Ping timeout: 256 seconds]
03:19 < vasild> It seems some i2p nodes run #22112 while others don't (yet): https://bpa.st/LUGQ
03:19 <@gribble> https://github.com/bitcoin/bitcoin/issues/22112 | Force port 0 in I2P by vasild · Pull Request #22112 · bitcoin/bitcoin · GitHub
03:21 -!- AaronvanW [~AaronvanW@178.239.167.157] has joined #bitcoin-core-dev
03:23 < vasild> This is the list of i2p nodes I am aware of: https://bpa.st/UOXQ, I (tried to) connect to each one and observed whether they advertise themselves with port 0 or 8333.
03:25 < vasild> jonatack: do you have more i2p addresses than listed in https://bpa.st/UOXQ ?
03:25 -!- AaronvanW [~AaronvanW@178.239.167.157] has quit [Ping timeout: 252 seconds]
03:25 -!- naiza [~naiza@180.188.251.163] has joined #bitcoin-core-dev
03:26 < jonatack> yes, 3 other i2p ones, otherwise i have the same list
03:29 < jonatack> 4, sent them to you
03:30 -!- promag [~promag@188.250.84.129] has quit [Quit: Leaving...]
03:39 -!- AaronvanW [~AaronvanW@178.239.167.158] has joined #bitcoin-core-dev
03:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:42 < bitcoin-git> [bitcoin] laanwj pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/e8f85e0e86e9...d3474b8df2f9
03:42 < bitcoin-git> bitcoin/master 0d64b8f Pieter Wuille: Rate limit the processing of incoming addr messages
03:42 < bitcoin-git> bitcoin/master 5648138 Pieter Wuille: Randomize the order of addr processing
03:42 < bitcoin-git> bitcoin/master b4ece8a Pieter Wuille: Functional tests for addr rate limiting
03:42 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 255 seconds]
03:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:43 < bitcoin-git> [bitcoin] laanwj merged pull request #22387: Rate limit the processing of rumoured addresses (master...202106_rate_limit_addr) https://github.com/bitcoin/bitcoin/pull/22387
03:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:43 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
03:43 -!- AaronvanW [~AaronvanW@178.239.167.158] has quit [Ping timeout: 252 seconds]
03:44 -!- dr-orlovsky [~dr-orlovs@31.14.40.19] has joined #bitcoin-core-dev
03:45 < emzy> vasild: I will update my i2p node to master later today.
03:47 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev
03:50 -!- dr-orlovsky [~dr-orlovs@31.14.40.19] has quit [Quit: ZNC 1.8.0 - https://znc.in]
03:53 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
03:53 -!- grettke is now known as grettke-away
03:56 -!- grettke-away is now known as grettke
03:57 -!- AaronvanW [~AaronvanW@178.239.173.217] has joined #bitcoin-core-dev
04:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:01 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #22493: fuzz: Extend addrman fuzz test with deserialize (master...2107-fuzzAddrDeser) https://github.com/bitcoin/bitcoin/pull/22493
04:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:02 < jnewbery> vasild: in 22112, is there anything stopping peers from gossipping non-port 0 I2P addresses to us? Will those addresses be entered into our addrman?
04:08 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
04:13 < michaelfolkson> fanquake robertspigler: Added a StackExchange post for the discussion of Guix within Gitian. Happy to edit/take it down if you don't want it up https://bitcoin.stackexchange.com/questions/107638/whats-the-purpose-of-using-guix-within-gitian-doesnt-that-reintroduce-depende/
04:17 < laanwj> IIRC nothing is stopping peers from gossiping non-port 0 I2P addresses, they will get stored (but not connected to, until our I2P SAM support supports non-zero ports, or other software that does). After next start (when CAddrMan::ResetI2PPorts is invoked) the ports will be changed to 0. That's meant to be a temporary measure.
04:19 < laanwj> I sometimes wonder if ResetI2PPorts is needed at all--I mean, the amount of I2P peers that has already been gossipped is bound to be very low, peers will broadcast the new port after upgrading, the old ones will drop from the database at some point
04:20 < laanwj> the old behavior has never been in a release
04:22 -!- naiza [~naiza@180.188.251.163] has quit [Ping timeout: 252 seconds]
04:24 < jonatack> It was needed to continue making outbound connections to existing I2P peers with port 8333 in the addrman, which otherwise can no longer be connected to nor (afaik) manually removed from the addrman.  The alternative would be for the existing 20-30 peers that have run an I2P service to delete their peers.dat
04:25 < vasild> emzy: great! you may also want to pick up https://github.com/bitcoin/bitcoin/pull/22471
04:25 < jonatack> or to have all upgraded to current master and restarted, so that ResetI2PPorts() can then be removed before 22.0 instead of at some point afterward
04:25 < jonatack> as it was planned to be a transitory measure
04:25 < laanwj> right
04:26 < jonatack> (I considered adding a hidden RPC to manually remove addresses from addrman, but that seems like an unneeded attack vector)
04:27 < vasild> yeah, I don't have a strong opinion but removing ResetI2PPorts() from final 22.0 looks plausible
04:27 < laanwj> if it's a one-time upgrade, some versioning mechanism that runs it only once (instead of every node start) would make sense, that said, not having it end up in a release at all would maybe be best
04:28 < jonatack> seems most prudent
04:28 < fanquake> I'm not yet caught up on the all new addrman brokenness, but surely we shouldn't be writing code to compensate for code that was already broken when added to master.
04:28 < fanquake> All the bugs should be fixed, and anyone running master just needs to update, delete their peers.dat / whatever. It's not like there is  any significant amount of people actually using i2p yet.
04:28 < laanwj> fanquake: right
04:28 < fanquake> Working around broken code in master so as not to inconvinience a minority that are running pre-production software seems backwards .
04:29 < jonatack> istm they need to all delete peers.dat (or upgrade to current master first) though
04:29 < laanwj> could even add a release note, though there may be better ways of reaching the few people who test I2P with bitcoin core master
04:30 < jonatack> yes, i know who all of them are except the bitcorn one
04:30 < laanwj> in any case it's complciated a bit by having ResetI2PPorts in master as well... like, eveyrone who ran master *in between* that function being added and re moved will not need to remove peers.dat :)
04:31 < jonatack> right :) 
04:34 < vasild> I like solving problems by deleting code :) especially if the code looks risky/hackish and especially if I wrote it ;)
04:35 < laanwj> vasild: agree, glad you're ok with it
04:35 < vasild> ok, should we leave master for some more time with ResetI2PPorts() or remove it immediately?
04:36 < laanwj> we could have a PR and merge it as last thing before the branch-off
04:37 < laanwj> but I imagine that's going to be soon
04:37 < laanwj> with #22387 merged and the I2P addrman issues solved I don't think there's any blockers left?
04:37 <@gribble> https://github.com/bitcoin/bitcoin/issues/22387 | Rate limit the processing of rumoured addresses by sipa · Pull Request #22387 · bitcoin/bitcoin · GitHub
04:38 < laanwj> this would replace both #22471 and #22468
04:38 <@gribble> https://github.com/bitcoin/bitcoin/issues/22471 | addrman: reset I2P ports in all "new" buckets by vasild · Pull Request #22471 · bitcoin/bitcoin · GitHub
04:38 <@gribble> https://github.com/bitcoin/bitcoin/issues/22468 | addrman: dont overwrite addr_info when resetting I2P ports by vasild · Pull Request #22468 · bitcoin/bitcoin · GitHub
04:39 < laanwj> but not  #22455
04:39 <@gribble> https://github.com/bitcoin/bitcoin/issues/22455 | addrman: detect on-disk corrupted nNew and nTried during unserialization by vasild · Pull Request #22455 · bitcoin/bitcoin · GitHub
04:40 < jonatack> right
04:41 < MarcoFalke> Wouldn't #22465 need to go in before rc1?
04:41 <@gribble> https://github.com/bitcoin/bitcoin/issues/22465 | guix: Pin kernel-header version, time-machine to upstream 1.3.0 commit by dongcarl · Pull Request #22465 · bitcoin/bitcoin · GitHub
04:42 < laanwj> MarcoFalke: yes
04:43 < laanwj> though I am honestly not sure how much of a difference it makes in practice; kernel version dependency is generally an issue for static linking of libc
04:44 < laanwj> libc is supposed to abstract the kernel details from the application; but this might be leaky in some cases
04:47 < laanwj> (for example when the application, or one of the statically linked libraries, manually invokes syscalls without handling the non-present case)
04:47 < jonatack> can open the pull
04:47 < laanwj> i don't think this is the case for us but...
04:48 < jonatack> (vasild: can open the pull)
04:49 < vasild> yes, I will shortly
04:51 -!- orionwl[m] [~orionwlx0@2001:470:69fc:105::80] has quit [Quit: Bridge terminating on SIGTERM]
04:51 -!- robertspigler [~robertspi@2001:470:69fc:105::2d53] has quit [Quit: Bridge terminating on SIGTERM]
04:51 -!- merkle_noob[m] [~merklenoo@2001:470:69fc:105::bad0] has quit [Quit: Bridge terminating on SIGTERM]
04:51 -!- mrjumper[m] [~mr-jumper@2001:470:69fc:105::7f1] has quit [Quit: Bridge terminating on SIGTERM]
04:51 -!- prusnak[m] [~stickmatr@2001:470:69fc:105::98c] has quit [Quit: Bridge terminating on SIGTERM]
04:51 -!- RCasatta[m] [~rcasattam@2001:470:69fc:105::c85] has quit [Quit: Bridge terminating on SIGTERM]
04:51 -!- Enki[m] [~enkimatri@2001:470:69fc:105::382c] has quit [Quit: Bridge terminating on SIGTERM]
04:51 -!- cdecker[m] [~cdeckerma@2001:470:69fc:105::2e8e] has quit [Quit: Bridge terminating on SIGTERM]
04:51 -!- vasanth2[m] [~vasanth2m@2001:470:69fc:105::3548] has quit [Quit: Bridge terminating on SIGTERM]
04:51 -!- eli[m] [~elinixbit@2001:470:69fc:105::ba64] has quit [Quit: Bridge terminating on SIGTERM]
04:51 -!- prayank[m] [~prayankni@2001:470:69fc:105::ba63] has quit [Quit: Bridge terminating on SIGTERM]
04:51 -!- M0xb10c[m] [~M0xb10cni@2001:470:69fc:105::bac4] has quit [Quit: Bridge terminating on SIGTERM]
04:51 -!- poucatreta[m] [~poucatret@2001:470:69fc:105::20ae] has quit [Quit: Bridge terminating on SIGTERM]
04:51 -!- vhs43[m] [~vhs43matr@2001:470:69fc:105::ba6d] has quit [Quit: Bridge terminating on SIGTERM]
04:51 -!- kvaciral[m] [~kvaciralx@2001:470:69fc:105::17b] has quit [Quit: Bridge terminating on SIGTERM]
04:51 -!- tutwidi[m] [~tutwidima@2001:470:69fc:105::ead] has quit [Quit: Bridge terminating on SIGTERM]
04:51 -!- vincenzopalazzo [~vincenzop@2001:470:69fc:105::a67] has quit [Quit: Bridge terminating on SIGTERM]
04:51 -!- devrandom [~devrandom@2001:470:69fc:105::d4d] has quit [Quit: Bridge terminating on SIGTERM]
04:53 -!- orionwl[m] [~orionwlx0@2001:470:69fc:105::80] has joined #bitcoin-core-dev
04:55 -!- vincenzopalazzo [~vincenzop@2001:470:69fc:105::a67] has joined #bitcoin-core-dev
04:55 -!- devrandom [~devrandom@2001:470:69fc:105::d4d] has joined #bitcoin-core-dev
04:55 -!- prusnak[m] [~stickmatr@2001:470:69fc:105::98c] has joined #bitcoin-core-dev
04:55 -!- robertspigler [~robertspi@2001:470:69fc:105::2d53] has joined #bitcoin-core-dev
04:55 -!- merkle_noob[m] [~merklenoo@2001:470:69fc:105::bad0] has joined #bitcoin-core-dev
04:55 -!- eli[m] [~elinixbit@2001:470:69fc:105::ba64] has joined #bitcoin-core-dev
04:55 -!- mrjumper[m] [~mr-jumper@2001:470:69fc:105::7f1] has joined #bitcoin-core-dev
04:55 -!- vasanth2[m] [~vasanth2m@2001:470:69fc:105::3548] has joined #bitcoin-core-dev
04:55 -!- Enki[m] [~enkimatri@2001:470:69fc:105::382c] has joined #bitcoin-core-dev
04:55 -!- vhs43[m] [~vhs43matr@2001:470:69fc:105::ba6d] has joined #bitcoin-core-dev
04:55 -!- poucatreta[m] [~poucatret@2001:470:69fc:105::20ae] has joined #bitcoin-core-dev
04:55 -!- tutwidi[m] [~tutwidima@2001:470:69fc:105::ead] has joined #bitcoin-core-dev
04:55 -!- cdecker[m] [~cdeckerma@2001:470:69fc:105::2e8e] has joined #bitcoin-core-dev
04:55 -!- M0xb10c[m] [~M0xb10cni@2001:470:69fc:105::bac4] has joined #bitcoin-core-dev
04:55 -!- kvaciral[m] [~kvaciralx@2001:470:69fc:105::17b] has joined #bitcoin-core-dev
04:55 -!- RCasatta[m] [~rcasattam@2001:470:69fc:105::c85] has joined #bitcoin-core-dev
04:55 -!- prayank[m] [~prayankni@2001:470:69fc:105::ba63] has joined #bitcoin-core-dev
05:03 -!- AaronvanW [~AaronvanW@178.239.173.217] has quit [Ping timeout: 252 seconds]
05:05 -!- piku [~piku@47.202.125.123] has joined #bitcoin-core-dev
05:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:14 < bitcoin-git> [bitcoin] theStack opened pull request #22495: p2p: refactor: tidy up `PeerManagerImpl::Misbehaving(...)` (master...202107-net-tidy_up_misbehaving) https://github.com/bitcoin/bitcoin/pull/22495
05:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:16 -!- AaronvanW [~AaronvanW@178.239.173.218] has joined #bitcoin-core-dev
05:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:21 < bitcoin-git> [bitcoin] jnewbery opened pull request #22496: [addrman] Remove RemoveInvalid() and ResetI2PPorts() (master...2021-07-remove-addrman-hotfix) https://github.com/bitcoin/bitcoin/pull/22496
05:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:21 -!- AaronvanW [~AaronvanW@178.239.173.218] has quit [Ping timeout: 268 seconds]
05:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:26 < bitcoin-git> [bitcoin] vasild opened pull request #22497: scripted-diff: remove ResetI2PPorts() (revert e0a2b390c14) (master...remove_ResetI2PPorts) https://github.com/bitcoin/bitcoin/pull/22497
05:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:27 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d3474b8df2f9...54e31742d208
05:27 < bitcoin-git> bitcoin/master 816f29e Vasil Dimov: addrman: detect on-disk corrupted nNew and nTried during unserialization
05:27 < bitcoin-git> bitcoin/master 54e3174 MarcoFalke: Merge bitcoin/bitcoin#22455: addrman: detect on-disk corrupted nNew and nT...
05:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:28 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #22455: addrman: detect on-disk corrupted nNew and nTried during unserialization (master...addrman_detect_negative) https://github.com/bitcoin/bitcoin/pull/22455
05:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:32 -!- AaronvanW [~AaronvanW@178.239.167.157] has joined #bitcoin-core-dev
05:35 -!- lightlike [~lightlike@user/lightlike] has joined #bitcoin-core-dev
05:36 -!- AaronvanW [~AaronvanW@178.239.167.157] has quit [Ping timeout: 246 seconds]
05:49 -!- AaronvanW [~AaronvanW@178.239.173.217] has joined #bitcoin-core-dev
05:53 -!- AaronvanW [~AaronvanW@178.239.173.217] has quit [Ping timeout: 268 seconds]
05:55 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Ping timeout: 268 seconds]
06:01 -!- grettke [~grettke@2605:a000:bfc0:6:8139:caa:65c0:6ba8] has joined #bitcoin-core-dev
06:05 -!- instagibbs [~instagibb@119247204116.ctinets.com] has quit [Ping timeout: 255 seconds]
06:06 -!- instagibbs [~instagibb@45.128.36.162] has joined #bitcoin-core-dev
06:07 -!- AaronvanW [~AaronvanW@178.239.173.216] has joined #bitcoin-core-dev
06:10 -!- Bilnon [~8iIn0n@2a01:4b00:8e07:7900:86dd:c745:c933:bc6a] has quit [Quit: Leaving]
06:11 -!- AaronvanW [~AaronvanW@178.239.173.216] has quit [Ping timeout: 255 seconds]
06:14 -!- kiran [~kiran@218.185.248.66] has quit [Ping timeout: 246 seconds]
06:24 -!- AaronvanW [~AaronvanW@178.239.173.218] has joined #bitcoin-core-dev
06:26 -!- sebx2a [sid356034@id-356034.highgate.irccloud.com] has quit []
06:26 -!- sebx2a [sid356034@id-356034.highgate.irccloud.com] has joined #bitcoin-core-dev
06:29 -!- AaronvanW [~AaronvanW@178.239.173.218] has quit [Ping timeout: 255 seconds]
06:40 -!- AaronvanW [~AaronvanW@178.239.167.157] has joined #bitcoin-core-dev
06:43 -!- grettke [~grettke@2605:a000:bfc0:6:8139:caa:65c0:6ba8] has quit [Ping timeout: 252 seconds]
06:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:44 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #22498: Check that CAddrMan::m_key is not null after deserialize (master...2107-addrmanKeyZero) https://github.com/bitcoin/bitcoin/pull/22498
06:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:45 -!- AaronvanW [~AaronvanW@178.239.167.157] has quit [Ping timeout: 258 seconds]
06:46 < MarcoFalke> Should addrman related pull requests be tagged with "p2p"?
06:47 -!- instagibbs [~instagibb@45.128.36.162] has quit [Ping timeout: 255 seconds]
06:52 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
06:54 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
06:55 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 265 seconds]
06:55 -!- Guyver2_ is now known as Guyver2
06:56 -!- AaronvanW [~AaronvanW@178.239.173.218] has joined #bitcoin-core-dev
07:02 -!- AaronvanW [~AaronvanW@178.239.173.218] has quit [Ping timeout: 268 seconds]
07:02 -!- instagibbs [~instagibb@119247204116.ctinets.com] has joined #bitcoin-core-dev
07:10 < laanwj> I think so, yes
07:10 < MarcoFalke> ok, adjusting DrahtBot to do so
07:14 -!- AaronvanW [~AaronvanW@178.239.173.216] has joined #bitcoin-core-dev
07:16 -!- Guest9039 [~Guest90@pool-70-106-180-198.clppva.fios.verizon.net] has joined #bitcoin-core-dev
07:16 < MarcoFalke> Done: https://github.com/bitcoin/bitcoin/pull/22498#event-5038754615
07:16 < laanwj> thanks!
07:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:17 < bitcoin-git> [bitcoin] sriramdvt opened pull request #22499: Update assumed chain params (master...update_chainparams) https://github.com/bitcoin/bitcoin/pull/22499
07:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:19 -!- AaronvanW [~AaronvanW@178.239.173.216] has quit [Ping timeout: 246 seconds]
07:23 -!- AaronvanW [~AaronvanW@178.239.173.216] has joined #bitcoin-core-dev
07:27 -!- Guest9039 [~Guest90@pool-70-106-180-198.clppva.fios.verizon.net] has quit [Quit: Ping timeout (120 seconds)]
07:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:51 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #22500: Assert in CAddrMan::Check() (master...2107-addrmanCheckAssert) https://github.com/bitcoin/bitcoin/pull/22500
07:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:56 -!- josibake [sid509132@id-509132.brockwell.irccloud.com] has joined #bitcoin-core-dev
08:00 -!- Guest9080 [~Guest90@pool-70-106-180-198.clppva.fios.verizon.net] has joined #bitcoin-core-dev
08:00 -!- Guest9080 [~Guest90@pool-70-106-180-198.clppva.fios.verizon.net] has quit [Client Quit]
08:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:01 < bitcoin-git> [bitcoin] jonatack opened pull request #22501: cli: add new address statistics to -netinfo (master...netinfo-addr-statistics) https://github.com/bitcoin/bitcoin/pull/22501
08:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:13 -!- grettke is now known as grettke-away
08:20 -!- johnpc [~johnpc@c-68-42-75-183.hsd1.mi.comcast.net] has joined #bitcoin-core-dev
08:27 -!- AaronvanW [~AaronvanW@178.239.173.216] has quit [Ping timeout: 252 seconds]
08:29 -!- AaronvanW [~AaronvanW@209.235.170.242] has joined #bitcoin-core-dev
08:32 < josibake> for anyone who's interested, #22235 (automatic generation of example bitcoin.conf) is ready for review
08:32 <@gribble> https://github.com/bitcoin/bitcoin/issues/22235 | script: add script to generate example bitcoin.conf by josibake · Pull Request #22235 · bitcoin/bitcoin · GitHub
08:37 -!- johnpc [~johnpc@c-68-42-75-183.hsd1.mi.comcast.net] has quit [Quit: johnpc]
08:42 < dergoegge> is anyone aware of `sendrawtransaction` being used in the way that gleb mentioned here: https://github.com/bitcoin/bitcoin/pull/22340#issuecomment-875542706 ?
08:43 -!- user__ [~davterra@143.244.186.214] has quit [Quit: Leaving]
08:48 -!- AaronvanW [~AaronvanW@209.235.170.242] has quit [Remote host closed the connection]
08:50 -!- pncl [~pncl___@5.245.211.197] has joined #bitcoin-core-dev
08:52 -!- Jaamg [jaamg@kapsi.fi] has quit [Ping timeout: 268 seconds]
08:52 -!- Jaamg [jaamg@kapsi.fi] has joined #bitcoin-core-dev
08:56 -!- jarthur [~jarthur@2603-8080-1540-002d-acff-de01-3c77-7564.res6.spectrum.com] has joined #bitcoin-core-dev
08:58 -!- AaronvanW [~AaronvanW@50-207-231-44-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
09:18 < jarolrod> MarcoFalke: circling back on drahtbot and updating it to label addrman changed `P2P`. Maybe it also should remove the `Needs Guix Build` label when it posts its guix build. We still want people to run a guix build and compare hashes right?
09:19 < jarolrod> ^ should not remove
09:19 -!- johnpc [~johnpc@c-68-42-75-183.hsd1.mi.comcast.net] has joined #bitcoin-core-dev
09:19 < MarcoFalke> Anyone is free to run as many guix builds as they wish
09:20 < MarcoFalke> Not sure if we should use the label to indicate *someone* (other than DrahtBot) should run the build
09:20 < hebasto> ^ yeah :)
09:20 < jarolrod> oh ok i see, it's for drahtbot
09:21 < MarcoFalke> I guess DrahtBot could use "Build" as label to create a guix build 
09:21 < MarcoFalke> Not sure if it will be fast enough to keep up, though
09:21 < MarcoFalke> It is running on half a core (one thread)
09:21 < jarolrod> that's ok, no need for change then
09:23 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
09:30 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
09:30 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
09:46 -!- grettke-away is now known as grettke
09:46 -!- grettke is now known as grettke-away
09:52 -!- grettke-away is now known as grettke
10:00 -!- johnpc [~johnpc@c-68-42-75-183.hsd1.mi.comcast.net] has quit [Ping timeout: 268 seconds]
10:05 -!- davterra [~davterra@143.244.186.214] has joined #bitcoin-core-dev
10:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:14 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #22502: scripted-diff: Revert "fuzz: Add Temporary debug assert for oss-fuzz issue" (master...2107-fuzzTempRevert) https://github.com/bitcoin/bitcoin/pull/22502
10:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:23 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Ping timeout: 245 seconds]
10:34 -!- AaronvanW [~AaronvanW@50-207-231-44-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection]
10:35 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
10:50 -!- Guest62 [~Guest62@210.14.100.70] has joined #bitcoin-core-dev
10:51 -!- Guest62 [~Guest62@210.14.100.70] has quit [Client Quit]
10:54 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev
10:59 -!- user__ [~davterra@178.128.106.205] has joined #bitcoin-core-dev
11:01 -!- davterra [~davterra@143.244.186.214] has quit [Ping timeout: 256 seconds]
11:02 -!- pncl [~pncl___@5.245.211.197] has quit [Quit: Leaving]
11:03 -!- pncl [~pncl___@5.245.211.197] has joined #bitcoin-core-dev
11:04 -!- pncl [~pncl___@5.245.211.197] has quit [Remote host closed the connection]
11:04 -!- pncl [~pncl___@5.245.211.197] has joined #bitcoin-core-dev
11:05 -!- AaronvanW [~AaronvanW@50-207-231-44-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
11:10 -!- AaronvanW [~AaronvanW@50-207-231-44-static.hfc.comcastbusiness.net] has quit [Ping timeout: 268 seconds]
11:15 -!- Guest85 [~Guest85@1-14-107-185.static.kviknet.dk] has joined #bitcoin-core-dev
11:16 < Guest85> Hey guys! I'm new here, just a quick question?
11:17 -!- user__ [~davterra@178.128.106.205] has quit [Ping timeout: 255 seconds]
11:25 < laanwj> i guess we could rename the label to something like Drahtbot: GUIX build, if that's more clear
11:28 -!- Guest85 [~Guest85@1-14-107-185.static.kviknet.dk] has quit [Quit: Client closed]
11:28 < laanwj> i understand the confusion because the other 'needs...' labels imply a contributor has to do something
11:29 < sipa> drahtbuild-requested
11:29 < jarolrod> ^^ I had been using that label to find pr's that need a guix build done :)
11:40 -!- AaronvanW [~AaronvanW@50-207-231-44-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
11:40 -!- Alexandme [~Alexandme@31.4.207.203] has joined #bitcoin-core-dev
11:42 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
11:45 -!- Alexandme [~Alexandme@31.4.207.203] has quit [Ping timeout: 258 seconds]
11:45 -!- AaronvanW [~AaronvanW@50-207-231-44-static.hfc.comcastbusiness.net] has quit [Ping timeout: 255 seconds]
12:02 < MarcoFalke> Sure, will rename
12:25 -!- pncl [~pncl___@5.245.211.197] has quit [Quit: Leaving]
12:36 -!- meshcollider [meshcollid@meshcollider.jujube.ircnow.org] has quit [Changing host]
12:36 -!- meshcollider [meshcollid@user/meshcollider] has joined #bitcoin-core-dev
12:37 -!- AaronvanW [~AaronvanW@50-207-231-44-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
12:40 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Ping timeout: 240 seconds]
12:44 -!- AaronvanW [~AaronvanW@50-207-231-44-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection]
12:44 -!- AaronvanW [~AaronvanW@50-207-231-44-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
12:59 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
13:23 < jonatack> fwiw seeing 4 new I2P addresses since a few hours ago and 5 inbound I2Ps advertising port 8333 (running with marco's ADDRMAN_DEBUG assert branch)
13:24 < jonatack> s/running/i am running/
13:24 -!- hex17or [~hex17or@gateway/tor-sasl/hex17or] has quit [Ping timeout: 244 seconds]
13:26 -!- hex17or [~hex17or@gateway/tor-sasl/hex17or] has joined #bitcoin-core-dev
13:29 -!- davterra [~davterra@178.128.106.205] has joined #bitcoin-core-dev
13:54 -!- ghost43_ [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
13:55 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Ping timeout: 244 seconds]
13:55 -!- jarthur_ [~jarthur@2603-8080-1540-002d-c49d-5e9c-d3a7-cf1f.res6.spectrum.com] has joined #bitcoin-core-dev
13:58 -!- jarthur [~jarthur@2603-8080-1540-002d-acff-de01-3c77-7564.res6.spectrum.com] has quit [Ping timeout: 240 seconds]
14:00 -!- grettke is now known as grettke-away
14:03 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev
14:08 -!- jarthur_ [~jarthur@2603-8080-1540-002d-c49d-5e9c-d3a7-cf1f.res6.spectrum.com] has quit [Ping timeout: 255 seconds]
14:12 -!- grettke-away [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Ping timeout: 265 seconds]
14:16 -!- jarthur [~jarthur@2603-8080-1540-002d-8911-e5b6-6ab4-72d3.res6.spectrum.com] has joined #bitcoin-core-dev
14:45 -!- lightlike [~lightlike@user/lightlike] has quit [Quit: Leaving]
14:57 -!- ufotofu_ [~ufotofu@user/ufotofu] has left #bitcoin-core-dev [WeeChat 2.7.1]
15:00 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
15:10 < jonatack> never mind about the port 8333 part; i had not noticed that the ADDRMAN_DEBUG assert branch was before the I2P Port 0 merge...rebased, rebuilt, restarted, no inbound I2Ps with port 8333 -> to bed
15:12 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
15:26 < dhruv> btc-irc
15:27 < dhruv> whoops, gotta be careful. sorry.
15:31 -!- AaronvanW [~AaronvanW@50-207-231-44-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection]
15:34 -!- grettke is now known as grettke-away
15:39 -!- AaronvanW [~AaronvanW@209.235.170.242] has joined #bitcoin-core-dev
15:43 -!- Ge0g3 [~Geoge@2a02:c7f:aead:e900:c15d:3f7:c2ca:c564] has quit [Remote host closed the connection]
15:43 -!- Ge0ge [~Geoge@2a02:c7f:aead:e900:c15d:3f7:c2ca:c564] has quit [Remote host closed the connection]
15:43 -!- Ge0ge [~Geoge@2a02:c7f:aead:e900:ff42:84f:3162:e0d3] has joined #bitcoin-core-dev
15:43 -!- Ge0g3 [~Geoge@2a02:c7f:aead:e900:ff42:84f:3162:e0d3] has joined #bitcoin-core-dev
15:43 -!- Geoge [~Geoge@2a02:c7f:aead:e900:c15d:3f7:c2ca:c564] has quit [Remote host closed the connection]
15:43 -!- Geoge [~Geoge@2a02:c7f:aead:e900:ff42:84f:3162:e0d3] has joined #bitcoin-core-dev
15:48 -!- emcy [~emcy@user/emcy] has quit [Quit: Leaving]
15:54 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Ping timeout: 245 seconds]
15:57 -!- hex17or [~hex17or@gateway/tor-sasl/hex17or] has quit [Ping timeout: 244 seconds]
16:08 -!- emcy [~emcy@user/emcy] has joined #bitcoin-core-dev
16:18 -!- lukedashjr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
16:19 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 258 seconds]
16:20 -!- vysn [~vysn@user/vysn] has quit [Remote host closed the connection]
16:20 -!- lukedashjr is now known as luke-jr
16:28 -!- kexkey [~kexkey@static-198-54-132-135.cust.tzulo.com] has joined #bitcoin-core-dev
16:29 -!- Aaronvan_ [~AaronvanW@159.48.55.175] has joined #bitcoin-core-dev
16:33 -!- grettke-away is now known as grettke
16:33 -!- kexkey [~kexkey@static-198-54-132-135.cust.tzulo.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
16:33 -!- AaronvanW [~AaronvanW@209.235.170.242] has quit [Ping timeout: 255 seconds]
16:34 -!- kexkey [~kexkey@static-198-54-132-135.cust.tzulo.com] has joined #bitcoin-core-dev
16:38 -!- kexkey [~kexkey@static-198-54-132-135.cust.tzulo.com] has quit [Ping timeout: 252 seconds]
16:39 -!- kexkey [~kexkey@dsl-173-206-97-88.tor.primus.ca] has joined #bitcoin-core-dev
16:45 -!- kexkey [~kexkey@dsl-173-206-97-88.tor.primus.ca] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
16:47 -!- kexkey [~kexkey@dsl-173-206-97-88.tor.primus.ca] has joined #bitcoin-core-dev
16:51 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev
16:56 -!- belcher_ [~belcher@user/belcher] has joined #bitcoin-core-dev
16:59 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 265 seconds]
17:19 -!- grettke is now known as grettke-away
17:25 -!- kexkey [~kexkey@dsl-173-206-97-88.tor.primus.ca] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
17:27 -!- kexkey [~kexkey@dsl-173-206-97-88.tor.primus.ca] has joined #bitcoin-core-dev
17:34 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Ping timeout: 255 seconds]
17:46 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
17:47 -!- AaronvanW [~AaronvanW@209.235.170.242] has joined #bitcoin-core-dev
17:51 -!- Aaronvan_ [~AaronvanW@159.48.55.175] has quit [Ping timeout: 252 seconds]
17:51 -!- hex17or [~hex17or@gateway/tor-sasl/hex17or] has joined #bitcoin-core-dev
17:57 -!- grettke-away is now known as grettke
18:01 -!- kexkey [~kexkey@dsl-173-206-97-88.tor.primus.ca] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
18:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
18:03 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/54e31742d208...624a19333022
18:03 < bitcoin-git> bitcoin/master d4b67c8 Vasil Dimov: scripted-diff: remove ResetI2PPorts() (revert e0a2b390c14)
18:03 < bitcoin-git> bitcoin/master 624a193 fanquake: Merge bitcoin/bitcoin#22497: scripted-diff: remove ResetI2PPorts() (revert...
18:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
18:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
18:03 < bitcoin-git> [bitcoin] fanquake merged pull request #22497: scripted-diff: remove ResetI2PPorts() (revert e0a2b390c14) (master...remove_ResetI2PPorts) https://github.com/bitcoin/bitcoin/pull/22497
18:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
18:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
18:03 < bitcoin-git> [bitcoin] fanquake closed pull request #22468: addrman: don't overwrite addr_info when resetting I2P ports (master...reset_i2p_ports_no_overwrite_pos) https://github.com/bitcoin/bitcoin/pull/22468
18:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
18:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
18:03 < bitcoin-git> [bitcoin] fanquake closed pull request #22471: addrman: reset I2P ports in all "new" buckets (master...reset_all_new_i2p_ports) https://github.com/bitcoin/bitcoin/pull/22471
18:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
18:11 -!- davterra [~davterra@178.128.106.205] has quit [Quit: Leaving]
18:27 -!- earnestly [~earnest@user/earnestly] has quit [Ping timeout: 258 seconds]
18:33 -!- grettke is now known as grettke-away
19:00 -!- AaronvanW [~AaronvanW@209.235.170.242] has quit [Remote host closed the connection]
19:03 -!- AaronvanW [~AaronvanW@209.235.170.242] has joined #bitcoin-core-dev
19:07 -!- grettke-away is now known as grettke
19:08 -!- AaronvanW [~AaronvanW@209.235.170.242] has quit [Ping timeout: 265 seconds]
19:18 -!- davterra [~davterra@143.244.186.214] has joined #bitcoin-core-dev
19:46 -!- piku_ [~piku@95.sub-174-212-40.myvzw.com] has joined #bitcoin-core-dev
19:47 -!- piku [~piku@47.202.125.123] has quit [Ping timeout: 258 seconds]
19:48 -!- piku__ [~piku@199.241.28.160] has joined #bitcoin-core-dev
19:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:49 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/624a19333022...d542603c5ac9
19:49 < bitcoin-git> bitcoin/master facd567 MarcoFalke: scripted-diff: Revert "fuzz: Add Temporary debug assert for oss-fuzz issue...
19:49 < bitcoin-git> bitcoin/master d542603 fanquake: Merge bitcoin/bitcoin#22502: scripted-diff: Revert "fuzz: Add Temporary de...
19:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
19:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:49 < bitcoin-git> [bitcoin] fanquake merged pull request #22502: scripted-diff: Revert "fuzz: Add Temporary debug assert for oss-fuzz issue" (master...2107-fuzzTempRevert) https://github.com/bitcoin/bitcoin/pull/22502
19:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
19:51 -!- davterra [~davterra@143.244.186.214] has quit [Ping timeout: 258 seconds]
19:51 -!- piku_ [~piku@95.sub-174-212-40.myvzw.com] has quit [Ping timeout: 265 seconds]
19:56 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
20:02 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
20:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:10 < bitcoin-git> [bitcoin] fanquake pushed 10 commits to master: https://github.com/bitcoin/bitcoin/compare/d542603c5ac9...e7441a6a4583
20:10 < bitcoin-git> bitcoin/master 263220a Carl Dong: guix: Check for a sane services database
20:10 < bitcoin-git> bitcoin/master fc4f844 Carl Dong: guix: Update various check_tools lists
20:10 < bitcoin-git> bitcoin/master 46ce6ce Carl Dong: tree-wide: Rename gitian-keys to builder-keys
20:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:10 < bitcoin-git> [bitcoin] fanquake merged pull request #21711: guix: Add full installation and usage documentation (master...2021-03-guix-docs) https://github.com/bitcoin/bitcoin/pull/21711
20:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:17 -!- AaronvanW [~AaronvanW@209.235.170.242] has joined #bitcoin-core-dev
20:19 -!- AaronvanW [~AaronvanW@209.235.170.242] has quit [Client Quit]
20:25 -!- grettke is now known as grettke-away
20:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:40 < bitcoin-git> [bitcoin] fanquake pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/e7441a6a4583...4fdd0ff9ee90
20:40 < bitcoin-git> bitcoin/master dca6c90 fanquake: macdeploy: remove unused plistlib import
20:40 < bitcoin-git> bitcoin/master 3d26b6b fanquake: macdeploy: fix framework printing when passing -verbose
20:40 < bitcoin-git> bitcoin/master 639f064 fanquake: macdeploy: select the plugins we need, rather than excluding those we don't
20:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:40 < bitcoin-git> [bitcoin] fanquake merged pull request #22199: macdeploy: minor fixups and simplifications (master...macdeploy_further_simplify) https://github.com/bitcoin/bitcoin/pull/22199
20:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:51 -!- Guest1 [~Guest1@2601:680:c200:6cc:9997:7de6:7bf6:ac0d] has joined #bitcoin-core-dev
20:51 -!- Guest1 [~Guest1@2601:680:c200:6cc:9997:7de6:7bf6:ac0d] has quit [Client Quit]
21:01 -!- piku__ [~piku@199.241.28.160] has quit [Ping timeout: 255 seconds]
21:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
21:24 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/4fdd0ff9ee90...201c5e4aec52
21:24 < bitcoin-git> bitcoin/master 90fd13b Carl Dong: guix: Pin kernel header version
21:24 < bitcoin-git> bitcoin/master e6a94d4 Carl Dong: guix: Bump to version-1.3.0 from upstream
21:24 < bitcoin-git> bitcoin/master 201c5e4 fanquake: Merge bitcoin/bitcoin#22465: guix: Pin kernel-header version, time-machine...
21:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
21:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
21:24 < bitcoin-git> [bitcoin] fanquake merged pull request #22465: guix: Pin kernel-header version, time-machine to upstream 1.3.0 commit (master...2021-07-guix-kernel-old) https://github.com/bitcoin/bitcoin/pull/22465
21:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
22:05 -!- kexkey [~kexkey@dsl-173-206-97-88.tor.primus.ca] has joined #bitcoin-core-dev
22:09 -!- kexkey [~kexkey@dsl-173-206-97-88.tor.primus.ca] has quit [Client Quit]
22:11 -!- grettke-away is now known as grettke
22:52 -!- Ananta-shesha [~pjetcetal@128-71-13-182.broadband.corbina.ru] has quit [Quit: EXIT]
22:55 -!- Ananta-shesha [~pjetcetal@128-71-13-182.broadband.corbina.ru] has joined #bitcoin-core-dev
23:03 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
23:11 -!- rohitrjn [uid508254@id-508254.highgate.irccloud.com] has quit [Quit: Connection closed for inactivity]
23:19 -!- smartin [~Icedove@88.135.18.171] has joined #bitcoin-core-dev
23:51 -!- belcher_ is now known as belcher
23:59 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev
--- Log closed Tue Jul 20 00:00:11 2021