--- Log opened Tue Jul 20 00:00:11 2021
00:04 -!- kiran [~quassel@27.59.188.129] has joined #bitcoin-core-dev
00:08 -!- kiran [~quassel@27.59.188.129] has quit [Read error: Connection reset by peer]
00:39 -!- jarthur [~jarthur@2603-8080-1540-002d-8911-e5b6-6ab4-72d3.res6.spectrum.com] has quit [Quit: jarthur]
00:56 -!- earnestly [~earnest@user/earnestly] has joined #bitcoin-core-dev
00:58 -!- gleb [~gleb@178.150.137.228] has joined #bitcoin-core-dev
01:06 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Ping timeout: 255 seconds]
01:16 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev
02:05 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Ping timeout: 255 seconds]
02:20 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev
02:32 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Remote host closed the connection]
02:34 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev
02:37 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Remote host closed the connection]
02:38 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev
02:39 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Remote host closed the connection]
02:41 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev
02:43 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Remote host closed the connection]
02:44 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev
02:50 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Ping timeout: 255 seconds]
02:50 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev
03:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:24 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/201c5e4aec52...5c8820b399f9
03:24 < bitcoin-git> bitcoin/master 54c7754 fanquake: build: use aarch64 Clang if cross-compiling for darwin on aarch64
03:24 < bitcoin-git> bitcoin/master 5c8820b fanquake: Merge bitcoin/bitcoin#22436: build: use aarch64 Clang if cross-compiling f...
03:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:24 < bitcoin-git> [bitcoin] fanquake merged pull request #22436: build: use aarch64 Clang if cross-compiling for darwin on aarch64 (master...arm64_macos_cross_clang) https://github.com/bitcoin/bitcoin/pull/22436
03:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:27 -!- sdaftuar [~sdaftuar@user/sdaftuar] has quit [Ping timeout: 240 seconds]
04:17 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
04:35 -!- vnogueira [~vnogueira@user/vnogueira] has quit [Remote host closed the connection]
04:35 -!- vnogueir- [~vnogueira@user/vnogueira] has joined #bitcoin-core-dev
04:58 < jnewbery> fanquake: #22096 and #22261 look ready for merge
04:58 <@gribble> https://github.com/bitcoin/bitcoin/issues/22096 | p2p: AddrFetch - dont disconnect on self-announcements by mzumsande · Pull Request #22096 · bitcoin/bitcoin · GitHub
04:58 <@gribble> https://github.com/bitcoin/bitcoin/issues/22261 | [p2p/mempool] Two small fixes to node broadcast logic by jnewbery · Pull Request #22261 · bitcoin/bitcoin · GitHub
05:00 < fanquake> 👀
05:03 -!- piku__ [~piku@199.241.28.160] has joined #bitcoin-core-dev
05:03 -!- smartin [~Icedove@88.135.18.171] has quit [Ping timeout: 256 seconds]
05:09 -!- piku__ [~piku@199.241.28.160] has quit [Ping timeout: 256 seconds]
05:09 -!- piku [~piku@47.202.125.35] has joined #bitcoin-core-dev
05:10 -!- piku [~piku@47.202.125.35] has quit [Read error: Connection reset by peer]
05:11 -!- piku [~piku@47.202.125.35] has joined #bitcoin-core-dev
05:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:27 < bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/5c8820b399f9...e4487fd5bbce
05:27 < bitcoin-git> bitcoin/master b6c5d1e Martin Zumsande: p2p: AddrFetch - don't disconnect on self-announcements
05:27 < bitcoin-git> bitcoin/master 533500d Martin Zumsande: p2p: Add timeout for AddrFetch peers
05:27 < bitcoin-git> bitcoin/master c34ad33 Martin Zumsande: net, rpc: Enable AddrFetch connections for functional testing
05:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:28 < bitcoin-git> [bitcoin] fanquake merged pull request #22096: p2p: AddrFetch - don't disconnect on self-announcements (master...202105_addrfetch_fix) https://github.com/bitcoin/bitcoin/pull/22096
05:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:45 -!- instagibbs [~instagibb@119247204116.ctinets.com] has quit [Ping timeout: 268 seconds]
05:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:59 < bitcoin-git> [bitcoin] fanquake pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/e4487fd5bbce...8ed8164e6f1e
05:59 < bitcoin-git> bitcoin/master 2837a9f John Newbery: [mempool] Only add a transaction to the unbroadcast set when it's added to...
05:59 < bitcoin-git> bitcoin/master 847b6ed Duncan Dean: [test] Test transactions are not re-added to unbroadcast set
05:59 < bitcoin-git> bitcoin/master cd48372 John Newbery: [mempool] Allow rebroadcast for same-txid-different-wtxid transactions
05:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:59 < bitcoin-git> [bitcoin] fanquake merged pull request #22261: [p2p/mempool] Two small fixes to node broadcast logic (master...2021-06-broadcast-fixes) https://github.com/bitcoin/bitcoin/pull/22261
05:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:02 < bitcoin-git> [bitcoin] jnewbery opened pull request #22505: addrman: Remove unused test_before_evict argument from Good() (master...2021-07-addrman-good-test-before-evict) https://github.com/bitcoin/bitcoin/pull/22505
06:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:02 < jnewbery> 🙏
06:04 < MarcoFalke> wen rc1?
06:04 < fanquake> just about
06:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:06 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/8ed8164e6f1e...539023ab4155
06:06 < bitcoin-git> bitcoin/master 25d99e6 Andrew Chow: Reorder dumpwallet so that cs_main functions go first
06:06 < bitcoin-git> bitcoin/master 9b85a5e Andrew Chow: tests: Test for dumpwallet lock order issue
06:06 < bitcoin-git> bitcoin/master 539023a MarcoFalke: Merge bitcoin/bitcoin#22492: wallet: Reorder locks in dumpwallet to avoid ...
06:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:06 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #22492: wallet: Reorder locks in dumpwallet to avoid lock order assertion (master...dumpwallet-lock-order) https://github.com/bitcoin/bitcoin/pull/22492
06:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:06 < MarcoFalke> 🚢 
06:08 < laanwj> time to branch?
06:08 < laanwj> #22499 is left
06:08 <@gribble> https://github.com/bitcoin/bitcoin/issues/22499 | Update assumed chain params by sriramdvt · Pull Request #22499 · bitcoin/bitcoin · GitHub
06:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:10 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/539023ab4155...42af9596ce85
06:10 < bitcoin-git> bitcoin/master eeddd1c Sriram: Update assumed chain params
06:10 < bitcoin-git> bitcoin/master 42af959 fanquake: Merge bitcoin/bitcoin#22499: Update assumed chain params
06:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:10 < MarcoFalke> I don't think it is blocking rc1. Sure, could get one or two more ACKs, but there are 2 weeks to gather them
06:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:10 < bitcoin-git> [bitcoin] fanquake merged pull request #22499: Update assumed chain params (master...update_chainparams) https://github.com/bitcoin/bitcoin/pull/22499
06:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:10 -!- instagibbs [~instagibb@119247204116.ctinets.com] has joined #bitcoin-core-dev
06:10 < MarcoFalke> (assumevalid won't take any effect until it is buried by 2 weeks worth of blocks)
06:11 < laanwj> going to branch off 22.0, please don't merge anything for a bit
06:11 < MarcoFalke> fanquake: Are you tagging rc1 tis time?
06:11 < fanquake> Post-merge ACKs can still accumulate.
06:11 < hebasto> I've verified that there no changes in translatable string since string freeze
06:11 < MarcoFalke> *this
06:12 < laanwj> i guess the branch should be called "22", not "0.22"?
06:12 < laanwj> or 22.0
06:12 < MarcoFalke> There will be 22.1, surely
06:12 < fanquake> I think 22.0
06:12 < laanwj> yes, but not a branch
06:12 < hebasto> 22.1 is a tag, branch could be 22
06:12 < laanwj> i think 22 (just dropping 0.) is more in line with the plan
06:12 < laanwj> right
06:13 < laanwj> 22.x would be a possibility too
06:13 < hebasto> even better :)
06:14 < laanwj> ok, doing that
06:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:27 < bitcoin-git> [bitcoin] laanwj pushed 1 commit to master: https://github.com/bitcoin/bitcoin/compare/42af9596ce85...3d8c714d8e79
06:27 < bitcoin-git> bitcoin/master 3d8c714 W. J. van der Laan: build: Bump master version to 22.99.0
06:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:30 < laanwj> branch 22.x was created, master is free for 23.x merging
06:30 < hebasto> \o/
06:31 < laanwj> tag format will be: v22.0rc1 right? or v22.0.0rc1?
06:33 < laanwj> any opinions? we've always used vX.Y.Z, and in exceptional cases vX.Y.Z.W (eg v0.20.0.1)
06:33 < MarcoFalke> v22.0rc1 Seems fine
06:34 < MarcoFalke> I don't think anyone is using regex on the version tags, and if the regex breaks, it will be a good thing 
06:35 -!- davterra [~davterra@143.244.186.214] has joined #bitcoin-core-dev
06:37 < laanwj> well, I am (for https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/master/make-tag.py), but I need to update that anyhow because '_CLIENT_VERSION_REVISION' is not a thing anymore, so it doesn't matter too much, just need a consistent naming
06:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:38 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3d8c714d8e79...9faa4b68db80
06:38 < bitcoin-git> bitcoin/master fa621ed MarcoFalke: refactor: Pass script verify flags as uint32_t
06:38 < bitcoin-git> bitcoin/master 9faa4b6 MarcoFalke: Merge bitcoin/bitcoin#22232: refactor: Pass interpreter flags as uint32_t ...
06:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:39 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #22232: refactor: Pass interpreter flags as uint32_t instead of signed int  (master...2106-refactorFlags) https://github.com/bitcoin/bitcoin/pull/22232
06:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:39 < laanwj> it's weird that we got rid of REVISION but not BUILD
06:39 < MarcoFalke> Anyone who does use a regex will have to update it. "Breaking" the format will hopefully "notify" anyone that the regex needs update.
06:39 < laanwj> BUILD is the fourth number, we have an optional fourth number now but not a third one
06:40 < MarcoFalke> I don't expect BUILD to be used
06:40 < laanwj> we did use it sometimes
06:40 < laanwj> but I would have expected to now use REVISION for that, as, it's moved by one
06:41 < MarcoFalke> Hmm, worst case is we just use vX.Y+1 instead of REVISION/BUILD
06:41 < laanwj> now we can have, e.g. v22.0.0.2, v22.1.0.3, etc which is fine, 
06:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:41 < bitcoin-git> [bitcoin] hebasto opened pull request #22506: build: Support x86_64 <-> arm64 cross-compiling for macOS (master...210720-xmac) https://github.com/bitcoin/bitcoin/pull/22506
06:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:42 < laanwj> I'd personally prefer changing BUILD to REVISION
06:42 < laanwj> getting rid of it completely is an option too of course, but I don't see why we should artificially limit ourselves that way
06:44 < laanwj> #define BUILD_DESC "v" STRINGIZE(CLIENT_VERSION_MAJOR) "." STRINGIZE(CLIENT_VERSION_MINOR) "." STRINGIZE(CLIENT_VERSION_BUILD)
06:44 < laanwj> oh
06:44 < laanwj> we just use non-standard naming, okay, fine too
06:45 < jonatack> yay! so IIUC this is when we taildraggers start using guix?
06:46 < laanwj> i'll tag it in a few minutes
06:47 < laanwj> need to update the script to check the new versioning scheme correctly
06:50 < jarolrod> 🎉
06:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:51 < bitcoin-git> [bitcoin] laanwj pushed tag v22.0rc1: https://github.com/bitcoin/bitcoin/compare/v22.0rc1
06:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:52 < hebasto> nice!
07:06 < laanwj> you can start your guix builds now! let's hope it will all go as expected
07:06 < laanwj> sure we did a test run, but this is the first actual rc
07:10 -!- AaronvanW [~AaronvanW@209.235.170.242] has joined #bitcoin-core-dev
07:10 < hebasto> anyone who needs a simple step-by-step guide for guix builds could follow this one https://gist.github.com/hebasto/7293726cbfcd0b58e1cfd5418316cee3
07:11 < jonatack> thanks hebasto!
07:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:28 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #22507: doc: Adjust commit message template for the guix.sigs repo (master...2107-docGuixCommit) https://github.com/bitcoin/bitcoin/pull/22507
07:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:34 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
08:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:09 < bitcoin-git> [bitcoin] apoelstra opened pull request #22508: fuzz: replace every fuzzer-controlled while loop with a macro (master...2021-07--fuzzer-loops) https://github.com/bitcoin/bitcoin/pull/22508
08:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:17 -!- pncl [~pncl___@5.245.211.197] has joined #bitcoin-core-dev
08:27 -!- vnogueir- [~vnogueira@user/vnogueira] has quit [Remote host closed the connection]
08:27 -!- vnogueira [~vnogueira@user/vnogueira] has joined #bitcoin-core-dev
08:39 -!- Victorsueca [~Victorsue@90.165.120.190] has joined #bitcoin-core-dev
08:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:40 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/9faa4b68db80...951850bebfde
08:40 < bitcoin-git> bitcoin/master fa27f03 MarcoFalke: Move LoadBlockIndexDB to BlockManager
08:40 < bitcoin-git> bitcoin/master faa54e3 MarcoFalke: Move pblocktree global to BlockManager
08:40 < bitcoin-git> bitcoin/master 951850b MarcoFalke: Merge bitcoin/bitcoin#22371: Move pblocktree global to BlockManager
08:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:40 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #22371: Move pblocktree global to BlockManager (master...2106-treeGlobalNooo) https://github.com/bitcoin/bitcoin/pull/22371
08:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:49 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
08:50 -!- grettke is now known as grettke-away
08:50 -!- grettke-away is now known as grettke
08:51 -!- grettke is now known as grettke-away
08:51 -!- jonatack99 [~jonatack@user/jonatack] has joined #bitcoin-core-dev
08:55 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 246 seconds]
08:59 -!- jonatack99 [~jonatack@user/jonatack] has quit [Ping timeout: 246 seconds]
09:01 -!- grettke-away [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
09:01 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
09:05 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
09:25 -!- johnpc [~johnpc@c-68-42-75-183.hsd1.mi.comcast.net] has joined #bitcoin-core-dev
09:30 -!- johnpc [~johnpc@c-68-42-75-183.hsd1.mi.comcast.net] has quit [Ping timeout: 268 seconds]
09:35 -!- andytosh1 is now known as andytoshi
09:45 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
09:58 -!- pncl [~pncl___@5.245.211.197] has quit [Remote host closed the connection]
10:04 < shiza> I have an usage question about an old wallet. Is that still off topic?
10:05 < shiza> I asked in #bitcoin about five hourse ago, but I can wait more.
10:07 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
10:07 < sipa> https://bitcoin.stackexchange.com may be a better place (search for existing questions on the topic first)
10:44 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Remote host closed the connection]
10:45 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev
11:01 -!- piku [~piku@47.202.125.35] has quit [Quit: Leaving]
11:10 < shiza> I read some questions not to much success, then messing with the console commands quickly gave info useful enough. :)
11:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:23 < bitcoin-git> [bitcoin] sriramdvt opened pull request #22509: test: Use MiniWallet in mempool_accept.py (master...mini_memaccept) https://github.com/bitcoin/bitcoin/pull/22509
11:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:33 < hebasto> #20586 has 3 ACKs, isn't it a good time to merge it, just after branching off :)
11:33 <@gribble> https://github.com/bitcoin/bitcoin/issues/20586 | Fix Windows build with --enable-werror by hebasto · Pull Request #20586 · bitcoin/bitcoin · GitHub
11:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:35 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/951850bebfde...bb09ec6f106c
11:35 < bitcoin-git> bitcoin/master fafade9 MarcoFalke: doc: Adjust commit message template for the guix.sigs repo
11:35 < bitcoin-git> bitcoin/master bb09ec6 W. J. van der Laan: Merge bitcoin/bitcoin#22507: doc: Adjust commit message template for the g...
11:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:35 < bitcoin-git> [bitcoin] laanwj merged pull request #22507: doc: Adjust commit message template for the guix.sigs repo (master...2107-docGuixCommit) https://github.com/bitcoin/bitcoin/pull/22507
11:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:42 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has quit [Ping timeout: 265 seconds]
11:44 -!- grettke is now known as grettke-away
11:44 -!- grettke-away [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
11:44 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has joined #bitcoin-core-dev
11:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:48 < bitcoin-git> [gui] ShaMan239 opened pull request #384: add copy subnet action for banned peer (master...copy-subnet) https://github.com/bitcoin-core/gui/pull/384
11:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:53 -!- AaronvanW [~AaronvanW@209.235.170.242] has quit [Remote host closed the connection]
11:53 -!- AaronvanW [~AaronvanW@209.235.170.242] has joined #bitcoin-core-dev
11:59 -!- AaronvanW [~AaronvanW@209.235.170.242] has quit [Ping timeout: 255 seconds]
12:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:09 < bitcoin-git> [bitcoin] siv2r closed pull request #22312: changes for wait_for_getheaders to include hash_list (master...modify-wait-getheaders) https://github.com/bitcoin/bitcoin/pull/22312
12:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:15 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
12:17 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Ping timeout: 256 seconds]
12:24 -!- AaronvanW [~AaronvanW@209.235.170.242] has joined #bitcoin-core-dev
12:28 -!- AaronvanW [~AaronvanW@209.235.170.242] has quit [Ping timeout: 252 seconds]
12:39 -!- AaronvanW [~AaronvanW@209.235.170.242] has joined #bitcoin-core-dev
12:44 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev
13:00 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
13:00 -!- grettke is now known as grettke-away
13:05 < jamesob> Do we ever expect to support an index that actually requires sequential indexing? Jimpo's BaseIndex advertises that it will index sequentially, but at the moment none of the particular indexers require this. Furthermore, we will have BlockConnected events triggering indexing out of order once we start using background chainstates for assumeutxo.
13:06 < sipa> maybe the index itself can handle this if this ever becomes a requirement?
13:07 < sipa> i.e. it'd cache the last block it is synchronized up to, and only does work when that last block changes
13:08 < jamesob> Hm yeah, I think an indexer subclass could potentially override Init or ThreadSync to build itself once background chainstates are out of use
13:09 < jamesob> But anyway I'm thinking of removing the sequential advertisement (which for now only exists in the class documentation) since we don't even make use of that assumption at the moment
13:09 -!- rich- is now known as yakshaver_
13:10 -!- grettke-away [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
13:11 -!- yakshaver_ is now known as yakshaver
13:26 -!- AaronvanW [~AaronvanW@209.235.170.242] has quit [Remote host closed the connection]
13:26 < jamesob> Hm, am I missing something of does txindex (via BaseIndex) not handle reorgs properly? BlockDisconnected events are not handled by BaseIndex and I can't see where unlinked block txns would be removed from the txindex... I guess this isn't a problem so long as inclusion in the index is not ever treated to mean "confirmed in the active chain"
13:27 < sipa> they're not removed no
13:27 < sipa> it allows you to look up transactions in inactive chains, if they haven't been re-confirmed in the main chain
13:28 < jamesob> good to know - maybe I'll make a note of that in the class doc
13:31 -!- jespada [~jespada@90.254.247.46] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
13:33 -!- grettke-away [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
13:33 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Ping timeout: 255 seconds]
13:40 -!- AaronvanW [~AaronvanW@50-207-231-44-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
13:43 -!- grettke-away [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
13:44 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev
13:57 < luke-jr> can whoever controls the @Bitcoincoreorg Twitter handle retweet https://twitter.com/LukeDashjr/status/1417589399215292420?s=20 ?
14:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:20 < bitcoin-git> [bitcoin] theStack opened pull request #22510: test: add test for RPC error 'Transaction already in block chain' (master...202107-test-tx_already_in_blockchain) https://github.com/bitcoin/bitcoin/pull/22510
14:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:37 -!- VzxPLnHqr__ [VzxPLnHqr@gateway/vpn/protonvpn/vzxplnhqr] has quit [Remote host closed the connection]
14:43 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:47 -!- vysn [~vysn@user/vysn] has quit [Quit: WeeChat 3.0.1]
14:49 < sipa> luke-jr: what is going on?
14:50 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
14:57 -!- vysn [~vysn@user/vysn] has quit [Remote host closed the connection]
14:58 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
15:08 -!- jespada [~jespada@90.254.247.46] has joined #bitcoin-core-dev
15:15 -!- jespada [~jespada@90.254.247.46] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
15:16 -!- pncl [~pncl___@5.245.211.197] has joined #bitcoin-core-dev
15:17 < robertspigler> Congratulations on the branch-off!
15:21 -!- pncl [~pncl___@5.245.211.197] has quit [Quit: Leaving]
15:23 -!- jespada [~jespada@90.254.247.46] has joined #bitcoin-core-dev
15:24 -!- pncl [~pncl___@5.245.211.197] has joined #bitcoin-core-dev
15:24 -!- pncl [~pncl___@5.245.211.197] has quit [Remote host closed the connection]
15:46 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Ping timeout: 252 seconds]
15:57 -!- jespada [~jespada@90.254.247.46] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
16:07 -!- larryruane [sid473749@id-473749.highgate.irccloud.com] has joined #bitcoin-core-dev
16:16 -!- Guest67 [~Guest67@2601:c9:c001:5c30:4869:da64:b339:84b4] has joined #bitcoin-core-dev
16:21 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has joined #bitcoin-core-dev
16:27 -!- Guest67 [~Guest67@2601:c9:c001:5c30:4869:da64:b339:84b4] has quit [Ping timeout: 246 seconds]
16:35 -!- jonatack [~jonatack@user/jonatack] has quit [Quit: Client closed]
16:36 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
16:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
16:49 < bitcoin-git> [bitcoin] dongcarl opened pull request #22511: guix: Silence `getent(1)` invocation (master...2021-07-guix-silence-getent) https://github.com/bitcoin/bitcoin/pull/22511
16:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
16:56 -!- belcher_ [~belcher@user/belcher] has joined #bitcoin-core-dev
16:56 -!- sipsorcery [~sipsorcer@2a02:8084:6981:7880::3] has quit [Ping timeout: 255 seconds]
16:59 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 258 seconds]
17:04 -!- Victorsueca [~Victorsue@90.165.120.190] has quit [Ping timeout: 255 seconds]
17:08 -!- AaronvanW [~AaronvanW@50-207-231-44-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection]
17:22 -!- earnestly [~earnest@user/earnestly] has quit [Ping timeout: 268 seconds]
17:28 -!- AaronvanW [~AaronvanW@209.235.170.242] has joined #bitcoin-core-dev
17:36 -!- Victorsueca [~Victorsue@90.165.120.190] has joined #bitcoin-core-dev
17:37 -!- grettke is now known as grettke-away
17:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
17:41 < bitcoin-git> [bitcoin] fanquake closed pull request #21014: test: Run mempool_accept.py even with wallet disabled  (master...diswallet_mempoolaccept) https://github.com/bitcoin/bitcoin/pull/21014
17:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
17:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
17:43 < bitcoin-git> [bitcoin] fanquake closed pull request #20874: test: Run mempool_limit.py even with wallet disabled (master...diswallet_mempoollimit) https://github.com/bitcoin/bitcoin/pull/20874
17:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
18:33 -!- grettke-away [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
19:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:13 < bitcoin-git> [bitcoin] achow101 opened pull request #22512: Consolidate XOnlyPubKey lookup hack (master...xonly-lookup-hack) https://github.com/bitcoin/bitcoin/pull/22512
19:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
19:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:16 < bitcoin-git> [bitcoin] achow101 opened pull request #22513: rpc: Allow walletprocesspsbt to sign without finalizing (master...psbt-no-finalize) https://github.com/bitcoin/bitcoin/pull/22513
19:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
19:54 -!- emcy [~emcy@user/emcy] has quit [Ping timeout: 268 seconds]
20:23 -!- emcy [~emcy@user/emcy] has joined #bitcoin-core-dev
20:50 -!- jarthur [~jarthur@2603-8080-1540-002d-0c88-90bf-c374-a374.res6.spectrum.com] has joined #bitcoin-core-dev
20:51 < luke-jr> sipa: looks like someone is sending out mass emails claiming to be a closed beta of Core, spoofing the sender(s)
20:53 -!- sdaftuar [~sdaftuar@user/sdaftuar] has joined #bitcoin-core-dev
21:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
21:33 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bb09ec6f106c...0fffd6c4fb35
21:33 < bitcoin-git> bitcoin/master f036dfb John Newbery: [addrman] Remove unused test_before_evict argument from Good()
21:33 < bitcoin-git> bitcoin/master 0fffd6c fanquake: Merge bitcoin/bitcoin#22505: addrman: Remove unused test_before_evict argu...
21:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
21:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
21:33 < bitcoin-git> [bitcoin] fanquake merged pull request #22505: addrman: Remove unused test_before_evict argument from Good() (master...2021-07-addrman-good-test-before-evict) https://github.com/bitcoin/bitcoin/pull/22505
21:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
22:21 -!- AaronvanW [~AaronvanW@209.235.170.242] has quit [Remote host closed the connection]
22:59 -!- vnogueira [~vnogueira@user/vnogueira] has quit [Remote host closed the connection]
23:00 -!- vnogueira [~vnogueira@user/vnogueira] has joined #bitcoin-core-dev
23:05 -!- jarthur [~jarthur@2603-8080-1540-002d-0c88-90bf-c374-a374.res6.spectrum.com] has quit [Quit: jarthur]
23:11 -!- Bilnon [~8iIn0n@2a01:4b00:8e07:7900:35d9:e35a:5f6c:f892] has joined #bitcoin-core-dev
23:12 -!- dermoth [~dermoth@user/dermoth] has quit [Read error: Connection reset by peer]
23:13 -!- dermoth [~dermoth@user/dermoth] has joined #bitcoin-core-dev
23:19 -!- Bilnon [~8iIn0n@2a01:4b00:8e07:7900:35d9:e35a:5f6c:f892] has quit [Quit: Leaving]
23:21 < laanwj> a closed beta, sigh, of course
23:41 < luke-jr> did the website release announcements just stop suddenly for a reason btw?
23:41 < luke-jr> after 0.16
23:42 < fanquake> What do you mean by website release annoucements
23:43 -!- gleb [~gleb@178.150.137.228] has quit [Ping timeout: 268 seconds]
23:43 < fanquake> If posts on bitcoincore.org announcing releases, then no: https://bitcoincore.org/en/2021/05/01/release-0.21.1/
23:44 < luke-jr> fanquake: the website used to have a way for people to subscribe to get emails
23:45 < fanquake> Well if anything has changed it'll be in https://github.com/bitcoin-core/bitcoincore.org
23:47 < luke-jr> cb60122e4fd39eff115000e94fad611829ea1208  Announcements: Update text on pages and posts to point to RSS feed
23:48 < fanquake> https://bitcoincore.org/en/list/announcements/join/
23:48 < luke-jr> apparently it broke https://github.com/bitcoin-core/bitcoincore.org/pull/610
23:52 -!- vnogueira [~vnogueira@user/vnogueira] has quit [Remote host closed the connection]
23:52 -!- vnogueira [~vnogueira@user/vnogueira] has joined #bitcoin-core-dev
23:55 < laanwj> yes, it broke, it was a btcdrak thing
23:57 < laanwj> bitcoin-core-dev is the announcement list now https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-core-dev
23:59 < laanwj> (it's set to moderated, so every post has to be manually accepted, and nothing will come from @bitcoincore.org, just the mail the original sender used)
--- Log closed Wed Jul 21 00:00:12 2021