--- Log opened Fri Jul 30 00:00:23 2021
00:00 -!- sipsorcery [~sipsorcer@37.228.225.67] has joined #bitcoin-core-dev
00:07 -!- Alexandme [~Alexandme@31.4.185.189] has quit [Ping timeout: 240 seconds]
00:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:16 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to 0.21: https://github.com/bitcoin/bitcoin/compare/52778f42452d...068ac69b56d6
00:16 < bitcoin-git> bitcoin/0.21 89426c4 Hennadii Stepanov: ci: Fix macOS brew install command
00:16 < bitcoin-git> bitcoin/0.21 681f728 Hennadii Stepanov: ci: Build with --enable-werror by default, and document exceptions
00:16 < bitcoin-git> bitcoin/0.21 55e941f MarcoFalke: test: Fix intermittent feature_taproot issue
00:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:16 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #22578: [0.21] Additional backports (0.21...0_21_fix_macOS_ci) https://github.com/bitcoin/bitcoin/pull/22578
00:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:49 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
01:10 -!- lkqwejhhgasdjhgn [~kljkljklk@p200300d46f0d870002ba78b5606655e4.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
02:09 -!- sipsorcery [~sipsorcer@37.228.225.67] has quit [Ping timeout: 250 seconds]
02:15 -!- sipsorcery [~sipsorcer@37.228.225.67] has joined #bitcoin-core-dev
02:22 -!- kljaejklasd [~kljkljklk@p57bc9bc8.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
02:23 -!- lkqwejhhgasdjhgn [~kljkljklk@p200300d46f0d870002ba78b5606655e4.dip0.t-ipconnect.de] has quit [Ping timeout: 245 seconds]
02:23 < vasild> Looking at a CI fuzzer output: https://cirrus-ci.com/task/5466383543697408?logs=ci#L2794
02:23 < vasild> how could I reproduce that failure?
02:24 < vasild> running with the same seed on the same corpus does not reproduce for some reason :/
02:25 < vasild> is there a way to retrieve ./crash-0671aac15e619e99522e2119487eaa9cc97e5a34 from the CI machine?
02:27 < vasild> when the fuzzer fails locally it prints the file name and also its contents in base64, but the CI log does not contain the base64 dump of the file, any idea why?
02:29 < vasild> MarcoFalke: ^
02:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:47 < bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/9c9939ce54d8...b6c3fceed6b9
02:47 < bitcoin-git> bitcoin/master 0a9129c Jon Atack: test: assert on the value of getblockchaininfo#time
02:47 < bitcoin-git> bitcoin/master 78c3610 Jon Atack: test: assert on mediantime in getblockheader and getblockchaininfo
02:47 < bitcoin-git> bitcoin/master d548dc7 Jon Atack: test: replace magic values by constants in rpc_blockchain.py
02:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:47 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #22520: test: improve rpc_blockchain.py tests and assert on time and mediantime (master...getblockchaininfo-time-tests) https://github.com/bitcoin/bitcoin/pull/22520
02:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:50 < bitcoin-git> [bitcoin] jonatack opened pull request #22589: net, doc: update I2P hardcoded seeds and docs for 22.0 (master...i2p-seeds-and-doc-updates) https://github.com/bitcoin/bitcoin/pull/22589
02:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:28 -!- promag_ [~promag@188.250.84.129] has quit [Read error: Connection reset by peer]
03:28 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
03:29 -!- promag_ [~promag@188.250.84.129] has joined #bitcoin-core-dev
03:29 -!- promag [~promag@188.250.84.129] has quit [Read error: Connection reset by peer]
03:32 -!- stick2[m] is now known as stick3[m]
03:34 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
03:34 -!- promag_ [~promag@188.250.84.129] has quit [Read error: Connection reset by peer]
03:35 -!- stick3[m] is now known as stick[m][m]
03:36 -!- promag_ [~promag@188.250.84.129] has joined #bitcoin-core-dev
03:36 -!- promag [~promag@188.250.84.129] has quit [Read error: Connection reset by peer]
03:37 -!- jespada [~jespada@90.254.247.46] has quit [Ping timeout: 250 seconds]
03:39 -!- jespada [~jespada@90.254.247.46] has joined #bitcoin-core-dev
04:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:31 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b6c3fceed6b9...78f040a6b350
04:31 < bitcoin-git> bitcoin/master 8ca51af Martin Zumsande: test: Disable automatic connections by default
04:31 < bitcoin-git> bitcoin/master 78f040a MarcoFalke: Merge bitcoin/bitcoin#22490: test: Disable automatic connections per defau...
04:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:31 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #22490: test: Disable automatic connections per default in the functional tests (master...202107_test_noautoconnect) https://github.com/bitcoin/bitcoin/pull/22490
04:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:50 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
05:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:06 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/78f040a6b350...da1c0c64fd09
05:06 < bitcoin-git> bitcoin/master 84c8747 Sebastian Falbesoner: test: remove unneeded initialization code in feature_rbf.py
05:06 < bitcoin-git> bitcoin/master a3f6397 Sebastian Falbesoner: test: feature_rbf.py: make MiniWallet instance available for all sub-tests...
05:06 < bitcoin-git> bitcoin/master aa02c64 Sebastian Falbesoner: test: use MiniWallet for simple doublespend test in feature_rbf.py
05:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:06 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #22330: test: use MiniWallet for simple doublespend sub-test in feature_rbf.py (master...202106-test-feature_rbf_use_miniwallet_for_doublespend) https://github.com/bitcoin/bitcoin/pull/22330
05:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:15 -!- babasancheti [~babasanch@43.249.232.15] has quit [Quit: Client closed]
05:43 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
06:10 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 246 seconds]
06:20 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
06:23 -!- Guest76 [~Guest76@122.186.85.154] has joined #bitcoin-core-dev
06:24 -!- neha_ [~neha@41.213.196.104.bc.googleusercontent.com] has joined #bitcoin-core-dev
06:24 -!- sdaftuar1 [~sdaftuar@user/sdaftuar] has joined #bitcoin-core-dev
06:25 -!- Guest76 [~Guest76@122.186.85.154] has quit [Client Quit]
06:25 -!- andytosh1 [~apoelstra@s66-183-0-205.bc.hsia.telus.net] has joined #bitcoin-core-dev
06:25 -!- ariard__ [~ariard@167.99.46.220] has joined #bitcoin-core-dev
06:25 -!- Lightsword_ [~Lightswor@user/lightsword] has joined #bitcoin-core-dev
06:34 -!- Netsplit *.net <-> *.split quits: Lightsword, sdaftuar, andytoshi, ariard, neha
06:34 -!- Lightsword_ is now known as Lightsword
07:12 -!- berndj [~berndj@ns2.linksynergy.co.za] has quit [Ping timeout: 252 seconds]
07:24 -!- babasancheti [~babasanch@43.249.232.15] has joined #bitcoin-core-dev
07:26 -!- dviola [~diego@user/dviola] has quit [Quit: WeeChat 3.2]
07:51 -!- berndj [~berndj@ns1.linksynergy.co.za] has joined #bitcoin-core-dev
08:02 -!- AaronvanW [~AaronvanW@200.31.177.15] has joined #bitcoin-core-dev
08:13 -!- AaronvanW [~AaronvanW@200.31.177.15] has quit [Remote host closed the connection]
08:22 -!- Jackielove4u [uid43977@user/jackielove4u] has quit [Quit: Connection closed for inactivity]
08:40 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
08:51 -!- sipsorcery [~sipsorcer@37.228.225.67] has quit [Ping timeout: 258 seconds]
08:57 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
08:59 -!- kljaejklasd [~kljkljklk@p57bc9bc8.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!]
09:28 -!- mongojuice [~mongo@user/mongojuice] has joined #bitcoin-core-dev
09:36 -!- babasancheti [~babasanch@43.249.232.15] has quit [Quit: Client closed]
09:44 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection]
09:44 -!- promag_ [~promag@188.250.84.129] has quit [Remote host closed the connection]
09:45 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
09:45 -!- promag [~promag@188.250.84.129] has joined #bitcoin-core-dev
09:53 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 240 seconds]
09:59 -!- jarthur [~jarthur@2603-8080-1540-002d-04f3-22d4-21b0-5129.res6.spectrum.com] has joined #bitcoin-core-dev
10:17 -!- AaronvanW [~AaronvanW@200.31.177.15] has joined #bitcoin-core-dev
10:26 -!- jespada [~jespada@90.254.247.46] has quit [Quit: Textual IRC Client: www.textualapp.com]
10:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:28 < bitcoin-git> [bitcoin] tylerchambers opened pull request #22590: Don't overwrite settings.json if it exists but can't be read. (master...fix-22571) https://github.com/bitcoin/bitcoin/pull/22590
10:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:36 -!- gene [~gene@gateway/tor-sasl/gene] has joined #bitcoin-core-dev
10:40 -!- AaronvanW [~AaronvanW@200.31.177.15] has quit [Quit: Leaving...]
10:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:41 < bitcoin-git> [bitcoin] tylerchambers closed pull request #22590: Util: don't overwrite existing but unreadable settings.json (master...fix-22571) https://github.com/bitcoin/bitcoin/pull/22590
10:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:57 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
11:02 -!- Lightsword [~Lightswor@user/lightsword] has quit [Quit: ZNC]
11:06 -!- jarthur [~jarthur@2603-8080-1540-002d-04f3-22d4-21b0-5129.res6.spectrum.com] has quit [Ping timeout: 240 seconds]
11:11 -!- jarthur [~jarthur@2603-8080-1540-002d-5820-3b18-1b1d-34b9.res6.spectrum.com] has joined #bitcoin-core-dev
11:24 -!- gene [~gene@gateway/tor-sasl/gene] has quit [Remote host closed the connection]
11:25 -!- gene [~gene@gateway/tor-sasl/gene] has joined #bitcoin-core-dev
11:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:29 < bitcoin-git> [bitcoin] tylerchambers opened pull request #22591: Util: error if settings.json exists, but is unreadable. (master...fix-22571) https://github.com/bitcoin/bitcoin/pull/22591
11:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:52 -!- hex17or [~hex17or@gateway/tor-sasl/hex17or] has quit [Ping timeout: 244 seconds]
11:57 -!- hex17or [~hex17or@gateway/tor-sasl/hex17or] has joined #bitcoin-core-dev
12:00 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 246 seconds]
12:04 < achow101> #startmeeting
12:04 < core-meetingbot> Meeting started Fri Jul 30 19:04:00 2021 UTC.  The chair is achow101. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
12:04 < core-meetingbot> Available commands: action commands idea info link nick
12:04 < michaelfolkson> hi
12:04 < achow101> #bitcoin-core-dev Wallet Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik petertodd 
12:04 < achow101> phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild
12:04 < S3RK> hi
12:04 < sipa> hi
12:04 < achow101> any topics to discuss?
12:04 < kvaciral[m]> hi
12:04 < michaelfolkson> I'll ask a couple of questions if there are no topics
12:05 < achow101> michaelfolkson: go ahead
12:06 < michaelfolkson> So there are a couple of PRs #22364 and #19602 making Taproot, bech32m the defaults (and intended to be merged after activation)
12:06 <@gribble> https://github.com/bitcoin/bitcoin/issues/22364 | wallet: Make a tr() descriptor by default by achow101 · Pull Request #22364 · bitcoin/bitcoin · GitHub
12:06 <@gribble> https://github.com/bitcoin/bitcoin/issues/19602 | wallet: Migrate legacy wallets to descriptor wallets by achow101 · Pull Request #19602 · bitcoin/bitcoin · GitHub
12:06 < michaelfolkson> These are intended to a version post activation (from what I can understand)
12:07 < S3RK> I believe 19602 is unrelated to taproot, no?
12:07 < achow101> 19602 is unrelated to taproot
12:07 < michaelfolkson> Are these dependent on whether other wallets in the ecosystem support Taproot?
12:08 < michaelfolkson> Oh sorry got wrong PR number, Sjors PR to make bech32m default was supposed to be
12:08 < achow101> michaelfolkson: no. the default address type will remain bech32
12:08 < achow101> so p2wpkh will be the default address type
12:08 < michaelfolkson> #22260 it should have been
12:08 <@gribble> https://github.com/bitcoin/bitcoin/issues/22260 | Make bech32m the default, except where needed. Update GUI checkbox. by Sjors · Pull Request #22260 · bitcoin/bitcoin · GitHub
12:09 < achow101> 22260 would be dependent on the rest of the ecosystem being able to accept bech32m addresses
12:09 < michaelfolkson> Right. And #22364 is in same boat?
12:10 <@gribble> https://github.com/bitcoin/bitcoin/issues/22364 | wallet: Make a tr() descriptor by default by achow101 · Pull Request #22364 · bitcoin/bitcoin · GitHub
12:10 < michaelfolkson> Wallets in ecosystem would need to be able to send to P2TR (which hopefully they will)
12:10 < achow101> no, 22364 just needs activation
12:10 < sipa> no, that just enables the wallet to construct p2tr addresses
12:10 < sipa> it won't create them unless asked to
12:10 < achow101> 22364 give the option for users to make p2tr addresses, but do not give them out by default
12:11 < sipa> right now, you need to manually import a tr() descriptor before you can construct p2tr addresses
12:11 < S3RK> I have a related question. What's the path to add tr descriptor to an exisitng wallet? 
12:11 < sipa> with 22364, such a tr() descriptor will be created by default
12:11 < achow101> with 22364 should also need an option in the GUI which I think can be taken from 22260
12:12 < achow101> S3RK: currently the only way is to use importdescriptors
12:12 < michaelfolkson> Ohh ok. I thought that was making the default descriptor a Taproot descriptor. That is just allowing you to make a Taproot descriptor, gotcha
12:12 < achow101> but I think we should add something (maybe to upgradewallet) that can generate a tr descriptor for the wallet
12:12 < S3RK> achow101: yes, I was thinking the same
12:12 < S3RK> manually constructing tr based on your existing master key is a bit tedious 
12:12 < sipa> michaelfolkson: there is no "default descriptor"
12:13 < sipa> michaelfolkson: there is a default descriptor per address type
12:13 < sipa> right now, no default bech32m descriptor is created, so no bech32m addresses can be requested
12:13 < sipa> with 22364, a default bech32m descriptor will be created
12:13 -!- prayank [~andr0irc@51.158.144.31] has joined #bitcoin-core-dev
12:13 < sipa> (but there will also still be default bech32 and legacy descriptors)
12:14 < michaelfolkson> Ok thanks
12:15 < michaelfolkson> Then a question on Miniscript (that we discussed at the last wallet meeting)
12:15 < S3RK> achow101: do you have any toughts on how a new command might work? we don't want a command just for the taproot, do we?
12:15 < michaelfolkson> But I'll wait for above to finish
12:15 < achow101> S3RK: I'm thinking maybe a new RPC for generating descriptors in general
12:16 < S3RK> what's the input for it would look like?
12:16 < achow101> generatedescriptor bech32m
12:16 < achow101> ?
12:17 < S3RK> michaelfolkson: sorry for hijacking your quesitons 
12:17 < prayank> getnewdescriptor -tr ?
12:17 < michaelfolkson> No it is fine, I'm not only one here :)
12:17 < achow101> I think the argument would be the address type, and the descriptor generated depends on whatever the default for the address type we choose
12:17 < achow101> this would change with future descriptors though
12:18 < achow101> there's also some issues with sharing the same master private key as other descriptors (or rather lack of)
12:18 < sipa> achow101: how would it know what key to use?
12:18 < S3RK> good question
12:19 < achow101> sipa: generate a new one?
12:19 < S3RK> meh..
12:19 < S3RK> now when I create new wallet don't I have one master key for all descriptors?
12:19 < sipa> achow101: i'm mostly asking because i wonder if it could be extended later to help with a multisig workflow
12:19 < achow101> S3RK: yes
12:20 < S3RK> it's really nice to have one master key I think. I'd like to keep that
12:20 < achow101> sipa: how would that work?
12:20 < sipa> achow101: i don't really know...
12:20 < achow101> S3RK: after a wallet is created, there isn't really a concept of "the wallet's master private key"
12:21 < achow101> especially if people import things afterwards
12:21 < S3RK> yeah, I understand. But I that was the promise of HD
12:22 < achow101> the promise of descriptors is also that it doesn't matter
12:22 < achow101> since the key is in the descriptor
12:22 < gene> hi
12:23 < S3RK> I kind of agree, but harder to backup and interropability is worse
12:23 < achow101> S3RK: there could be a second argument that gives the address type to take the master privkey from
12:23 < sipa> S3RK: well you need to backup either the wallet file, or the descriptors individually
12:24 < sipa> just having the key is not enough in any case
12:24 < achow101> e.g. "generatedescriptor bech32m bech32" would mean "make a descriptor that makes bech32m addresses using the master key from the current active external bech32 descriptor"
12:24 < sipa> but with a different derivation path?
12:24 < achow101> yes
12:25 < sipa> how would it figure out what path to use?
12:25 < S3RK> sipa: yes and there is also limited amount of derivations paths. I can just generate descriptors for all of them
12:25 < sipa> S3RK: i really dislike that notion :)
12:26 < sipa> especially if multisig becomes more common, with individual signers participating possibly in multiple multisigs, you can't just assume you can iterate over all possible derivation paths
12:26 < achow101> sipa: I think it would just use the default derivation path. for tr that's in BIP 86
12:26 < S3RK> yes, multisig makes everything more complicated
12:27 < sipa> achow101: right, fair; perhaps it could check if that some other descriptor already uses that default derivation path
12:28 < achow101> if we wanted to be more specific about which descriptor to take things from, we do have a descriptor id thing
12:29 < achow101> but we might want to formalize descriptor ids before using them
12:29 < gene> does the concept of domain separation apply to descriptors?
12:30 < S3RK> gene: what do you mean by domain separation?
12:31 < gene> having a specific prefix for derivation paths specific to the use-case
12:32 < achow101> gene: the point of descriptors is that we can move away from doing that because the derivation paths are explicit in the descriptor
12:32 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
12:32 < S3RK> there is a notion of an "account" in the derivation path. not sure if that's what you want
12:33 < gene> not account, more like all tr addrs use m/45' where all normal use m/44'
12:33 < prayank> Do we have any transaction on Testnet that has P2TR outputs? If someone tried and has transaction id, please share. I want to check few things in my node, different explorers.
12:33 < achow101> sipa: we could also make the derivation path be overridden by the user
12:33 < michaelfolkson> prayank: We do, I'll find you a link
12:33 < achow101> gene: that exists already, see BIPs 44/49/84/86
12:34 < gene> achow101: thanks +1
12:34 < S3RK> sipa achow101: thanks for you ideas. we don't have to solve it now. Let's think about it and check back later
12:35 < achow101> right, we still have time
12:35 < achow101> michaelfolkson: you had somehing else?
12:35 < michaelfolkson> Right on Miniscript...
12:36 < michaelfolkson> I know nothing ever is final, final but is Miniscript considered "final" now. Time for a BIP etc?
12:36 < michaelfolkson> There are still small changes being made every now and again
12:37 < michaelfolkson> It seems gnarly getting these libraries into Core (Minisketch, Miniscript etc) when Core can change, the PR can change and the external library can change
12:38 < michaelfolkson> Presumably the libsecp approach of keeping it as an external library rather than a subset of it being merged into Core isn't viable
12:38 < achow101> looking briefly at rust-miniscript, it seems like changes aren't really being made to miniscript itself but rather to the specific implementation
12:38 < michaelfolkson> And this would be final like Miniscript version 1, obviously Miniscript would change with Taproot etc
12:38 < sipa> i don't tyink the current spec will change anymore
12:38 < achow101> I think the same can be said of sipa's c++ miniscript implementation
12:38 < sipa> but the c++ miniscript repo isn"t even up to date with that spec i think
12:39 < sipa> of course more extensions can be added
12:39 < michaelfolkson> There are a few issues and open PRs on sipa's C++ implementation
12:39 < michaelfolkson> (I think... from memory)
12:39 < achow101> sipa: is your website still the up to date spec?
12:39 < sipa> there has been some.more activity recently, so i think we'll be able to make.progress there soonish
12:39 < sipa> achow101: i don't remember
12:39 < sipa> too swapped out...
12:40 < sipa> (afk)
12:40 < prayank> michaelfolkson: Thanks :) you can share here. I will check in logs if my IRC app disconnects.
12:41 < michaelfolkson> James' Python implementation has been sitting there for a similar time so it would nice to get a "
12:41 < michaelfolkson> "final" BIP spec
12:41 < achow101> I can ask sanket or andytoshi if either of them would like to write a BIP
12:42 < michaelfolkson> Happy to help (and not be named as a co-author on the BIP)
12:42 < michaelfolkson> If needed
12:42 < achow101> (I expect the only person who is actually fully up to date on all of the particulars is sanket)
12:43 < michaelfolkson> Ok cool, that was my question having glanced over the open Miniscript PR earlier
12:43 < achow101> anything else to discuss?
12:44 < S3RK> I have one more small question
12:44 < michaelfolkson> And ideally not 10 BIPs for Miniscript :)
12:44  * michaelfolkson ducks
12:44 < S3RK> how do we decide whether make listing private descriptors a separate RPC? #21500
12:44 <@gribble> https://github.com/bitcoin/bitcoin/issues/21500 | wallet, rpc: add an option to list private descriptors by S3RK · Pull Request #21500 · bitcoin/bitcoin · GitHub
12:45 < achow101> S3RK: I think that's a personal preference type of thing
12:45 < achow101> I don't particularly care either way, but it makes sense to continue to just add an option to the existing RPC
12:45 < S3RK> me too. should I solicit more opinions?
12:46 < achow101> I don't think many people care
12:47 < S3RK> ok. oh.. one more thing
12:47 < S3RK> do we want to consider a CI setup without BDB?
12:47 < gene> adding a separate RPC could increase security by allowing people to disable it
12:47 < achow101> S3RK: that would probably be a good idea
12:48 < achow101> gene: There's currently no way to disable specific RPCs
12:48 < gene> oh...
12:48 < gene> guessing no way to disable RPC options then either?
12:48 < achow101> that's correct
12:49 < gene> may look into how much work it would be to add that feature
12:50 < achow101> anything else?
12:50 < S3RK> nope
12:50 < michaelfolkson> Nope
12:50 < achow101> #endmeeting
12:50 < core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
12:50 < core-meetingbot> Meeting ended Fri Jul 30 19:50:18 2021 UTC.  
12:50 < core-meetingbot> Minutes:        https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2021/bitcoin-core-dev.2021-07-30-19.04.moin.txt
12:50 -!- Guest9 [~Guest9@85.red-2-139-120.dynamicip.rima-tde.net] has joined #bitcoin-core-dev
12:50 < michaelfolkson> Thanks achow101 et al
12:50 < achow101> I'll probably prototype some possible upgrade methods on monday
12:50 < gene> thanks :3
12:51 < prayank> gene: option to disable RPCs sounds interesting. Although I doubt many people would agree to add it.
12:51 < gene> why?
12:51 < S3RK> achow101: you mean adding tr descriptor to exsting wallet?
12:51 < achow101> S3RK: yeah
12:51 < S3RK> achow101: ping me if when you have something to share
12:51 < achow101> sure
12:53 < gene> my general impression of bitcoin devs is a high respect and concern for security. adding a feature that increases the ability of users to secure themselves seems like it fits
12:53 -!- Guest9 [~Guest9@85.red-2-139-120.dynamicip.rima-tde.net] has quit [Client Quit]
12:53 < achow101> gene: I think there have been some ideas around multiple RPC users and permissions for those users
12:54 < michaelfolkson> prayank: Just interested in testnet, not mainnet or signet? 0xB10C is the guru here
12:54 < achow101> It would probably be better to do something related to that rather than disabling RPCs.
12:54 < achow101> but generally our protection against unauthorized exports of wallet privkeys is to enable wallet encryption
12:54 < achow101> and not expose RPCs publicly
12:55 < michaelfolkson> prayank: I'm guessing you saw this https://b10c.me/blog/007-spending-p2tr-pre-activation/
12:55 < prayank> michaelfolkson: Only testnet. Not sure if it's possible to do it on mainnet safely before activation.
12:55 < gene> right, but what if I (as theoretical user) want to expose an RPC to get current block height, but not query addresses?
12:56 < prayank> Reading the link now
12:56 < michaelfolkson> prayank: Oh it isn't. If you read that blog post 0xB10C effectively "stole" the funds at the Taproot outputs on mainnet
12:56 < S3RK> gener: I also wonder how is it solved in the industry right now
12:56 -!- tecnecio [~tecnecio_@85.red-2-139-120.dynamicip.rima-tde.net] has joined #bitcoin-core-dev
12:57 < achow101> gene: you might be interested in the discussion in #12248
12:57 <@gribble> https://github.com/bitcoin/bitcoin/issues/12248 | RPC Whitelist Files · Issue #12248 · bitcoin/bitcoin · GitHub
12:57 < gene> the separation of users is a good idea, too. accounts (user credentials) can be hacked, though. so, think that disabling the RPC as the ultimate way to secure against an attack on public node
12:57 < achow101> oh, perhaps #12763 already implements some of this?
12:57 <@gribble> https://github.com/bitcoin/bitcoin/issues/12763 | Add RPC Whitelist Feature from #12248 by JeremyRubin · Pull Request #12763 · bitcoin/bitcoin · GitHub
12:57 < S3RK> here we go :) 
12:57 < gene> will look at those, thanks for the links
12:59 < gene> 12248 looks like exactly what I was thinking about
12:59 < gene> plus more
13:00 < _aj_> "there's currently no way to disable specific RPCs" -- doesn't #12763 provide that?
13:00 <@gribble> https://github.com/bitcoin/bitcoin/issues/12763 | Add RPC Whitelist Feature from #12248 by JeremyRubin · Pull Request #12763 · bitcoin/bitcoin · GitHub
13:01 < _aj_> ah, should've spent less time scrolled back
13:05 -!- Lightsword [~Lightswor@user/lightsword] has joined #bitcoin-core-dev
13:07 < blkncd> prayank: here are testnet spends https://twitter.com/0xB10C/status/1415697704726978570 and corresponding P2TR outputs
13:09 < michaelfolkson> prayank: You can't search for tb1p addresses on blockstream.info it appears. Need the full address
13:10 < prayank> Awesome. Those links will be helpful. Still reading the first one. Thanks michaelfolkson and blkncd
13:15 -!- gene [~gene@gateway/tor-sasl/gene] has quit [Quit: gene]
13:19 -!- prayank [~andr0irc@51.158.144.31] has quit [Quit: irc thread exit]
13:52 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
13:57 -!- tecnecio [~tecnecio_@85.red-2-139-120.dynamicip.rima-tde.net] has quit [Quit: Leaving]
14:48 -!- promag [~promag@188.250.84.129] has quit [Quit: Leaving...]
15:13 -!- goatpig [~goat@2a01cb0801f0f6003f157119e61ceee6.ipv6.abo.wanadoo.fr] has quit [Quit: Konversation terminated!]
15:48 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 256 seconds]
16:05 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has quit [Remote host closed the connection]
16:06 -!- andrewtoth_ [~andrewtot@gateway/tor-sasl/andrewtoth] has joined #bitcoin-core-dev
16:26 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
16:33 -!- vysn [~vysn@user/vysn] has quit [Remote host closed the connection]
16:50 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
16:51 -!- earnestly [~earnest@user/earnestly] has quit [Ping timeout: 258 seconds]
17:03 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 240 seconds]
17:13 -!- belcher_ [~belcher@user/belcher] has joined #bitcoin-core-dev
17:17 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 272 seconds]
17:31 -!- jarthur [~jarthur@2603-8080-1540-002d-5820-3b18-1b1d-34b9.res6.spectrum.com] has quit [Quit: jarthur]
17:38 -!- jetpack [~jetpack@2605:2700:1:100e:ddb4:196e:c17a:3b92] has quit [Remote host closed the connection]
17:38 -!- mongojuice [~mongo@user/mongojuice] has quit [Quit: Leaving]
17:38 -!- jetpack [~jetpack@2605:2700:1:100e:ddb4:196e:c17a:3b92] has joined #bitcoin-core-dev
18:08 < andytosh1> achow101: re writing a miniscript BIP, i'm happy to help in principle, though would need to sync with sipa about how the BIP would relate to his website then (should the website be largely replaced by the BIP? what if they differ? etc)
18:09 < sipa> i'd like to first get the sites and implementations in sync before writing a BIP
18:15 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
18:16 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
19:02 -!- freesprung [~freesprun@136-25-131-81.cab.webpass.net] has quit [Quit: Ping timeout (120 seconds)]
19:02 -!- freesprung [~freesprun@136-25-131-81.cab.webpass.net] has joined #bitcoin-core-dev
19:33 < andytosh1> makes sense
19:46 -!- prayank [~andr0irc@51.158.144.31] has joined #bitcoin-core-dev
19:50 < prayank> Sorry if this is offtopic. Has anyone tried reading messages in Wireshark that bitcoin nodes use? Couldn't see anything helpful in INV or GETDATA or TX
19:50 < prayank> https://superuser.com/questions/1666715/read-packets-in-wireshark
19:50 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
19:54 < sipa> i thought wireshark had a bitcoin protocol analyzer
19:54 < sipa> though it may be very outdated
19:55 < sipa> prayank: that output looks correct?
19:56 < sipa> it's reporting an inv with 1 entry, which has type 5, and hash 1a72fe...
19:56 < sipa> it seems it doesn't know that type 5 is MSG_WTX (defined in BIP339)
19:56 < sipa> but otherwise this is fine
19:59 < gwillen> prayank: the annotated hex dumps you linked were hand-annotated by a person, I think, not automatically by an app
20:00 < prayank> It has a filter for bitcoin protocol. So I have two regtest nodes and did transaction from one which got relayed. I was expecting to see tx id in some message.
20:01 < sipa> the txid is there; 1a72fe...
20:01 < sipa> (it's a wtxid, because it's a MSG_WTX)
20:01 < sipa> also printed in reverse, i assume
20:01 < prayank> Interesting. Will check again.
20:01 < sipa> what i don't understand is why the dump in your screenshot doesn't include the string "inv"
20:02 < prayank> Not sure
20:02 < sipa> what if you click on reassembled TCP?
20:06 < prayank> Hex dump changes below in last section
20:10 < sipa> does it include the string "inv" then?
20:10 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
20:12 < prayank> Yes
20:12 < sipa> ok
20:13 < prayank> But I still couldn't find tx id. Let me share value for INV GETDATA TX from Wireshark and my actual Tx ID
20:13 < sipa> the txid isn't there
20:13 < sipa> the wtxid is
20:14 < sipa> and i assume it's printed in reverse (because the human-readable formatting of txids/wtxids is in the opposite order of the wire protocol)
20:16 < sipa> you can also use the -capturemessages feature btw, which will dump the p2p messages sent/received
20:16 < sipa> and the included contrib/message-capture/message-capture-parser.py tool can parse and print those
20:20 < prayank> Cool. Thanks. One last question. Maybe dumb q. Where do I check wtxid? I don't see in decoderawtransaction
20:21 < sipa> oh, it reports the wtxid as "hash"
20:21 < sipa> for silly historical reasons
20:22 < prayank> Thanks
20:26 < prayank> And yes I found WTXID in Wireshark. You are right about it being reverse.
20:27 < prayank> INV: f84ef7024f4a9d91605a5c1eae28664391ce0c8dc29d2fb396af24fe5c3a6499
20:27 < prayank> WTXID: 99643a5cfe24af96b32f9dc28d0cce91436628ae1e5c5a60919d4a4f02f74ef8
20:50 -!- prayank [~andr0irc@51.158.144.31] has quit [Quit: irc thread exit]
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:36 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
22:17 -!- jesseposner [~jesse@2601:647:0:89:ddb:3ed4:ff62:b4de] has quit [Ping timeout: 272 seconds]
22:19 -!- jesseposner [~jesse@2601:647:0:89:dc4d:9de6:d972:6985] has joined #bitcoin-core-dev
23:29 < michaelfolkson> andytosh1: If I had to guess there would be a transitional period where the spec moves from the website to a draft BIP. While the BIP is in draft it can still be changed 
23:30 < michaelfolkson> andytosh1: But the website would still be used for the interactive parts, compiler, analyzer etc
23:32 < michaelfolkson> For the question on what is the authoritative resource if the C++ implementation disagrees with the Rust implementation that disagrees with the website that disagrees with the draft BIP that is definitely a question for sipa, you, Sanket etc ;)
23:45 < michaelfolkson> Perhaps this can/should move ##miniscript
23:48 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
--- Log closed Sat Jul 31 00:00:24 2021