--- Log opened Thu Aug 05 00:00:29 2021 00:02 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 00:07 -!- RDK [~Raoul@p200300db6740bb27a53104dc8bdf7ba3.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 00:13 -!- AaronvanW [~AaronvanW@190.150.26.4] has quit [Ping timeout: 252 seconds] 00:24 -!- copumpkin [~woohoo@user/copumpkin] has quit [Ping timeout: 272 seconds] 00:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:31 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/e9472e6828ab...dd981b5e840c 00:31 < bitcoin-git> bitcoin/master aa79c91 Amiti Uttarwar: [docs] Add release notes for #21528 00:31 < bitcoin-git> bitcoin/master 9778b0f Amiti Uttarwar: [net_processing] Provide debug error if code assumptions change. 00:31 < bitcoin-git> bitcoin/master dd981b5 MarcoFalke: Merge bitcoin/bitcoin#22618: [p2p] Small follow-ups to 21528 00:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:32 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #22618: [p2p] Small follow-ups to 21528 (master...2021-08-blackhole-followup) https://github.com/bitcoin/bitcoin/pull/22618 00:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:42 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/dd981b5e840c...7d60f7ec6bbf 00:42 < bitcoin-git> bitcoin/master faa670d MarcoFalke: test: Properly set BIP34 height in CreateNewBlock_validity unit test 00:42 < bitcoin-git> bitcoin/master 7d60f7e MarcoFalke: Merge bitcoin/bitcoin#22277: test: Properly set BIP34 height in CreateNewB... 00:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:42 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #22277: test: Properly set BIP34 height in CreateNewBlock_validity unit test (master...2106-test34) https://github.com/bitcoin/bitcoin/pull/22277 00:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:48 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 00:53 < MarcoFalke> fanquake: Yeah, must be GitHub's fault 00:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:54 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #22630: test: Add missing include (master...2108-testMissingInclude) https://github.com/bitcoin/bitcoin/pull/22630 00:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:57 -!- earnestly [~earnest@user/earnestly] has joined #bitcoin-core-dev 01:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:01 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7d60f7ec6bbf...c4b42aa4ffa1 01:01 < bitcoin-git> bitcoin/master 6666ec9 MarcoFalke: test: Add missing include 01:01 < bitcoin-git> bitcoin/master c4b42aa fanquake: Merge bitcoin/bitcoin#22630: test: Add missing include 01:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 01:01 < bitcoin-git> [bitcoin] fanquake merged pull request #22630: test: Add missing include (master...2108-testMissingInclude) https://github.com/bitcoin/bitcoin/pull/22630 01:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 01:02 < fanquake> MarcoFalke: gunna blame that merge conflict on GitHub too hey 01:02 -!- b10c [uid500648@id-500648.charlton.irccloud.com] has joined #bitcoin-core-dev 01:04 < MarcoFalke> fanquake: Nah. I should probably get DrahtBot to detect those 01:05 -!- belcher_ is now known as belcher 01:06 -!- lkqwejhhgasdjhgn [~kljkljklk@p200300d46f0d8700346fa1868eb47e04.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 01:13 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev 01:15 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection] 01:15 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 01:31 -!- copumpkin [~woohoo@user/copumpkin] has joined #bitcoin-core-dev 01:31 -!- AaronvanW [~AaronvanW@190.150.26.4] has joined #bitcoin-core-dev 02:04 -!- AaronvanW [~AaronvanW@190.150.26.4] has quit [Ping timeout: 256 seconds] 02:09 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 02:15 < michaelfolkson> Is there a reason Issues are disabled on the BIPs repo? 02:17 < michaelfolkson> A few people have commented that the Schnorr/Taproot BIPs are perhaps a little dense for implementers and could perhaps be better tailored for them (more info targeted towards to them) 02:17 < laanwj> yes--the bip editors don't handle issues, you have to address issues with BIPs with the individual authors or on the bitcoin mailing list 02:18 < michaelfolkson> Hmm ok, thanks. It does make it hard to do what I described above. I don't particularly want the BIP authors to have to look at it until it is agreed that it is a universally agreed improvement 02:19 < michaelfolkson> Tbh I'm a bit skeptical at trying to make changes to the BIPs but some people like the idea 02:19 < laanwj> i'm also sceptical as to what you propose; a BIP is a spec not an implementation guide 02:20 < laanwj> you could write an implementation guide as say, a blog post to make it easier for people to implement things, but it wouldn't replace the spec 02:20 < michaelfolkson> Right, I agree with that 02:22 < laanwj> or, a new "informative BIP" 02:23 -!- meshcollider [meshcollid@user/meshcollider] has quit [Ping timeout: 272 seconds] 02:26 -!- muhblockchain [~muhblockc@user/muhblockchain] has joined #bitcoin-core-dev 02:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:28 < bitcoin-git> [bitcoin] hebasto opened pull request #22631: doc: Add packages that provide Qt Wayland plugin for Linux (master...210805-wayland) https://github.com/bitcoin/bitcoin/pull/22631 02:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:41 -!- hardtotell [~hardtotel@satyr.seedboxes.cc] has quit [Quit: ZNC 1.6.3+deb1+trusty0 - http://znc.in] 02:45 -!- meshcollider [meshcollid@meshcollider.jujube.ircnow.org] has joined #bitcoin-core-dev 02:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:46 < bitcoin-git> [bitcoin] fanquake closed pull request #22479: p2p, doc: log DEBUG_ADDRMAN consistency checks, add developer notes info (master...debug-addrman) https://github.com/bitcoin/bitcoin/pull/22479 02:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:46 -!- hardtotell [~hardtotel@satyr.seedboxes.cc] has joined #bitcoin-core-dev 02:49 -!- RDK_ [~Raoul@p200300db6740bb95b61e90a4c93b893b.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 02:52 -!- RDK [~Raoul@p200300db6740bb27a53104dc8bdf7ba3.dip0.t-ipconnect.de] has quit [Ping timeout: 272 seconds] 03:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:07 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #22632: test: Set regtest.BIP66Height = 102 to speed up tests (master...2108-regtestFasterBip66) https://github.com/bitcoin/bitcoin/pull/22632 03:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:09 -!- RDK_ [~Raoul@p200300db6740bb95b61e90a4c93b893b.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 03:09 -!- RDK_ [~Raoul@p200300db6740bb95b61e90a4c93b893b.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 03:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:16 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c4b42aa4ffa1...f4328ebef52f 03:16 < bitcoin-git> bitcoin/master 5a1bef6 Zero-1729: test: refactor: remove binascii from test_framework 03:16 < bitcoin-git> bitcoin/master f4328eb MarcoFalke: Merge bitcoin/bitcoin#22619: test: refactor: use consistent bytes <-> hex-... 03:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:22 -!- AaronvanW [~AaronvanW@190.150.26.4] has joined #bitcoin-core-dev 03:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:50 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #22619: test: refactor: use consistent bytes <-> hex-string conversion in functional test framework (master...test-remove-binascii-in-test-framework) https://github.com/bitcoin/bitcoin/pull/22619 03:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:55 -!- AaronvanW [~AaronvanW@190.150.26.4] has quit [Ping timeout: 252 seconds] 04:04 -!- RDK_ [~Raoul@p200300db6740bb95b61e90a4c93b893b.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 04:04 -!- RDK_ [~Raoul@p200300db6740bb95b61e90a4c93b893b.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 04:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:18 < bitcoin-git> [bitcoin] Zero-1729 opened pull request #22633: refactor: follow-ups to 22619 (master...follow-ups-to-22605) https://github.com/bitcoin/bitcoin/pull/22633 04:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:27 -!- b10c [uid500648@id-500648.charlton.irccloud.com] has quit [Quit: Connection closed for inactivity] 04:31 -!- AaronvanW [~AaronvanW@190.150.26.4] has joined #bitcoin-core-dev 04:38 -!- smartin [~Icedove@88.135.18.171] has joined #bitcoin-core-dev 04:41 < muhblockchain> is there a tool to convert dump from hidden rpc that dumps utxo to file into a human readable address,balance? if not, would a concept be accepted possibly to make a human readable dump, or do we heavily discourage users from using such tools 05:24 -!- b10c [uid500648@id-500648.charlton.irccloud.com] has joined #bitcoin-core-dev 05:45 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 05:49 -!- AaronvanW [~AaronvanW@190.150.26.4] has quit [Ping timeout: 240 seconds] 05:52 -!- gribble [~gribble@bitcoin/bot/gribble] has quit [Remote host closed the connection] 05:56 -!- gribble [~gribble@bitcoin/bot/gribble] has joined #bitcoin-core-dev 05:56 -!- mode/#bitcoin-core-dev [+o gribble] by ChanServ 06:00 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 258 seconds] 06:04 -!- jonatack [~jonatack@user/jonatack] has quit [Quit: Client closed] 06:11 < laanwj> there's a PR for this feel free to help testing it #18689 06:11 <@gribble> https://github.com/bitcoin/bitcoin/issues/18689 | rpc: allow dumptxoutset to dump human-readable data by pierreN · Pull Request #18689 · bitcoin/bitcoin · GitHub 06:16 < muhblockchain> feels like xmass 06:18 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 06:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:19 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/f4328ebef52f...d67330d11245 06:19 < bitcoin-git> bitcoin/master 6408b24 Vasil Dimov: fuzz: move init code to the CAddrManDeterministic constructor 06:19 < bitcoin-git> bitcoin/master 8765179 Vasil Dimov: fuzz: check that ser+unser produces the same AddrMan 06:19 < bitcoin-git> bitcoin/master d67330d MarcoFalke: Merge bitcoin/bitcoin#21129: fuzz: check that ser+unser produces the same ... 06:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:19 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #21129: fuzz: check that ser+unser produces the same AddrMan (master...fuzz_addrman_serunser) https://github.com/bitcoin/bitcoin/pull/21129 06:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:45 -!- RDK_ [~Raoul@p200300db6740bb95b61e90a4c93b893b.dip0.t-ipconnect.de] has quit [Quit: Leaving] 06:46 -!- RDK [~Raoul@p200300db6740bb95b61e90a4c93b893b.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 06:47 -!- RDK [~Raoul@p200300db6740bb95b61e90a4c93b893b.dip0.t-ipconnect.de] has quit [Client Quit] 06:49 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:49 -!- RDK [~Raoul@p200300db6740bb95b61e90a4c93b893b.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 06:49 -!- RDK [~Raoul@p200300db6740bb95b61e90a4c93b893b.dip0.t-ipconnect.de] has quit [Client Quit] 06:50 -!- RDK [~RDK@p200300db6740bb95b61e90a4c93b893b.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 06:51 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 276 seconds] 06:51 -!- Guyver2_ is now known as Guyver2 06:59 -!- AaronvanW [~AaronvanW@190.150.26.4] has joined #bitcoin-core-dev 07:04 -!- jonatack [~jonatack@user/jonatack] has quit [Quit: Client closed] 07:06 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 07:16 -!- babasancheti [~babasanch@43.249.232.25] has joined #bitcoin-core-dev 07:37 -!- AaronvanW [~AaronvanW@190.150.26.4] has quit [Quit: Leaving...] 07:45 -!- AaronvanW [~AaronvanW@190.150.26.4] has joined #bitcoin-core-dev 07:47 -!- RDK [~RDK@p200300db6740bb95b61e90a4c93b893b.dip0.t-ipconnect.de] has quit [Quit: Leaving] 07:53 -!- gribble [~gribble@bitcoin/bot/gribble] has quit [Remote host closed the connection] 08:00 -!- gribble [~gribble@bitcoin/bot/gribble] has joined #bitcoin-core-dev 08:00 -!- mode/#bitcoin-core-dev [+o gribble] by ChanServ 08:17 -!- babasancheti [~babasanch@43.249.232.25] has quit [Quit: Client closed] 08:18 -!- babasancheti [~babasanch@43.249.232.25] has joined #bitcoin-core-dev 08:22 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev 08:37 -!- bomb-on [~bomb-on@194.144.47.113] has joined #bitcoin-core-dev 08:40 -!- Guest78 [~Guest78@122.170.109.217] has joined #bitcoin-core-dev 08:41 -!- Guest78 [~Guest78@122.170.109.217] has quit [Client Quit] 08:41 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 08:44 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 250 seconds] 08:44 -!- Guyver2_ is now known as Guyver2 08:49 -!- roconnor [~roconnor@host-45-78-236-232.dyn.295.ca] has joined #bitcoin-core-dev 08:58 -!- Guyver2_ [~Guyver@2001:985:f3f:1:9521:339d:9d85:c755] has joined #bitcoin-core-dev 09:01 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 258 seconds] 09:02 -!- Guyver2_ is now known as Guyver2 09:06 -!- Evel-Knievel [~Evel-Knie@81.82.247.68] has quit [Ping timeout: 258 seconds] 09:07 -!- b10c [uid500648@id-500648.charlton.irccloud.com] has quit [Quit: Connection closed for inactivity] 09:08 -!- Evel-Knievel [~Evel-Knie@81.82.247.68] has joined #bitcoin-core-dev 09:12 -!- lkqwejhhgasdjhgn [~kljkljklk@p200300d46f0d8700346fa1868eb47e04.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!] 09:12 -!- Evel-Knievel [~Evel-Knie@81.82.247.68] has quit [] 09:13 -!- Evel-Knievel [~Evel-Knie@81.82.247.68] has joined #bitcoin-core-dev 09:53 -!- lightlike [~lightlike@user/lightlike] has joined #bitcoin-core-dev 10:27 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev 11:07 -!- babasancheti [~babasanch@43.249.232.25] has quit [Quit: Client closed] 11:25 -!- murch [~murchin@user/murch] has quit [Quit: WeeChat 2.8] 12:00 < laanwj> #startmeeting 12:00 < core-meetingbot> Meeting started Thu Aug 5 19:00:22 2021 UTC. The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings. 12:00 < core-meetingbot> Available commands: action commands idea info link nick 12:00 < michaelfolkson> hi 12:00 < achow101> hi 12:01 < larryruane> hi 12:01 < laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos 12:01 < laanwj> nehan NicolasDorier paveljanik petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild 12:01 < jamesob> hi 12:01 < _aj_> hey 12:01 < jarolrod> Hi 12:01 < kvaciral[m]> hi 12:01 < laanwj> welcome to the weekly bitcoin-core-dev meeting 12:02 < laanwj> it looks like there are no pre-proposed topics (which you can propose any time during the week with #proposedmeetingtopic) 12:02 < luke-jr> hi 12:02 < sipa> hi 12:02 < laanwj> any last minute topic proposals? 12:03 < laanwj> the 22.0rc2 announcement went out today, hopefully we'll get some testing 12:03 < gene> hi 12:03 < jonatack> hi 12:03 < laanwj> #topic High priority for review 12:03 < core-meetingbot> topic: High priority for review 12:04 < laanwj> 7 blockers in https://github.com/bitcoin/bitcoin/projects/8, no bugfixes, nothing chasing concept ACK 12:04 < laanwj> anything to add/remove/replace or that is ready for merge? 12:05 < hebasto> hi 12:05 < gene> maybe a dumb question, what is blocking on the issues? just a need for more review/testing? 12:05 < laanwj> gene: yes 12:05 < gene> s/issues/prs 12:06 < gene> laanwj: ok, thanks 12:06 < laanwj> it's high priority for review, so it needs more review, though manual testing can also be useful if you can test specific things not covered by the test suite 12:07 < laanwj> it's blocking in the sense that it blocks further work by the author (or someone else) 12:08 < gene> is it helpful to ask for the specific areas in the PRs that the author would like more review? 12:08 < gene> the few I've reviewed so far seem to have a lot of discussion already 12:09 < laanwj> that depends, it is probably better to ask out of band (say, on IRC) than in the PR itself 12:09 < michaelfolkson> I haven't seen much direction from PR authors on parts of the PR that need particular focus. Sometimes there is guidance on what could be tested, suggestions for new reviewers 12:10 < michaelfolkson> Perhaps for good reason. You don't want everyone just doing the same thinig 12:10 < laanwj> in general the idea is to review the entire code change not only specific areas, but if there are say, consensus changes, then those are the most important (but also tests, in the sense that they really test what they're supposed to check) 12:11 < laanwj> but in general the entire change is important, what you are best able to review are the parts that you understand best (or want to learn about) 12:12 < laanwj> anyhow, apparently there are no proposed changes to high priority for review, and no other topics, so we should probably close the meeting 12:12 < michaelfolkson> I have a quick topic 12:13 < jonatack> gene: maybe helpful if you haven't seen it https://jonatack.github.io/articles/how-to-review-pull-requests-in-bitcoin-core 12:13 < kanzure> i don't mean to discuss particular locations or times, but the travel plans are still not finalized right? 12:13 < michaelfolkson> In process of attempting to arrange a IRC meeting or two to discuss the BIP process and possible improvements to it. Kalle and Luke seem up for it 12:13 -!- AaronvanW [~AaronvanW@190.150.26.4] has quit [Remote host closed the connection] 12:14 < michaelfolkson> It has been a while since the BIP process was reviewed and amended and a few people have suggestions for editing it 12:14 < laanwj> #topic proposed IRC meeting about BIP process 12:14 < core-meetingbot> topic: proposed IRC meeting about BIP process 12:14 < gene> jonatack: thanks, will read 12:14 < michaelfolkson> Aiming for September probably (IRC channel to be worked out) 12:15 < sipa> michaelfolkson: please discuss this on the ML, of you haven't already 12:15 < michaelfolkson> BIP process wishlist with some people's thoughts here https://github.com/bitcoin/bips/wiki/BIP-Process-wishlist 12:15 < michaelfolkson> sipa: Right 12:15 < laanwj> kanzure: i think so, not sure if ariard is here he'll know best 12:15 < jamesob> kanzure laanwj: not finalized yet; close? 12:16 < jamesob> it's down to two locations, at any rate 12:17 < michaelfolkson> Will send to the ML once details are sorted 12:17 < laanwj> ok 12:18 < laanwj> any other topics? 12:18 < larryruane> Just want to mention that I'm available for review, please ping me, I'm on IRC 24x7, but I'm only able to spend about 20% time (have an 80% "real" other job) 12:18 < larryruane> I'll keep an eye on high priority for review list 12:18 < laanwj> larryruane: any specific area you're interested in reviewing? 12:19 < larryruane> utils (logging), performance, want to learn about P2P especially mempool 12:19 -!- evanb [~evanb@66.194.134.138] has joined #bitcoin-core-dev 12:20 < laanwj> re: mempool you might want to look at #21800 that one should be pretty close 12:20 <@gribble> https://github.com/bitcoin/bitcoin/issues/21800 | mempool/validation: mempool ancestor/descendant limits for packages by glozow · Pull Request #21800 · bitcoin/bitcoin · GitHub 12:20 < ajonas> Also want to mention that josibake created a testing guide for 22.0 to go along with #22634 and it's now posted on the dev-wiki. 12:20 <@gribble> https://github.com/bitcoin/bitcoin/issues/22634 | v22.0 testing · Issue #22634 · bitcoin/bitcoin · GitHub 12:20 < larryruane> 👍 12:20 < laanwj> ajonas: will add the link to the issue, thanks! 12:22 < laanwj> #endmeeting 12:22 < core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt 12:22 < core-meetingbot> Meeting ended Thu Aug 5 19:22:28 2021 UTC. 12:22 < core-meetingbot> Minutes: https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2021/bitcoin-core-dev.2021-08-05-19.00.moin.txt 12:23 < gene> thanks for the meeting and review tips all 12:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:29 < bitcoin-git> [bitcoin] jamesob closed pull request #21620: ChainstateManager locking improvements (master...2021-04-cs-lock-improvements) https://github.com/bitcoin/bitcoin/pull/21620 12:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:44 -!- AaronvanW [~AaronvanW@190.150.26.4] has joined #bitcoin-core-dev 12:50 -!- AaronvanW [~AaronvanW@190.150.26.4] has quit [Ping timeout: 276 seconds] 12:56 -!- AaronvanW [~AaronvanW@190.150.26.4] has joined #bitcoin-core-dev 12:58 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!] 13:01 -!- jonatack [~jonatack@user/jonatack] has quit [Quit: Client closed] 13:03 -!- b10c [uid500648@id-500648.charlton.irccloud.com] has joined #bitcoin-core-dev 13:09 -!- lightlike [~lightlike@user/lightlike] has quit [Ping timeout: 272 seconds] 13:16 -!- evanb [~evanb@66.194.134.138] has quit [Quit: Connection closed] 13:16 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 13:17 -!- Evolver [sid32215@user/evolver] has quit [Ping timeout: 272 seconds] 13:17 -!- smartin [~Icedove@88.135.18.171] has quit [Quit: smartin] 13:18 -!- Jackielove4u [uid43977@user/jackielove4u] has quit [Ping timeout: 272 seconds] 13:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:19 < bitcoin-git> [bitcoin] jamesob opened pull request #22640: Improve speed, memory efficiency with alternate hashmap (#2) (master...2019-08-robinhood) https://github.com/bitcoin/bitcoin/pull/22640 13:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:20 -!- c_arc [~c_arc@4.53.92.114] has joined #bitcoin-core-dev 13:24 < _aj_> jamesob: would be good to have the PR description describe the change (since that goes in the commit log), and have the commentary on reopening in a followup comment (imho, etc) 13:26 < _aj_> jamesob: might be good to recombine the data and get a memory-usage-vs-height graph 13:32 < jamesob> _aj_: thanks for the look. if we get to the point where we're close to merge, I'll edit the description - but I think that's probably a ways off 13:32 < jamesob> hm actually you're right, I'll just do it now 13:33 -!- belcher [~belcher@user/belcher] has quit [Read error: Connection reset by peer] 13:38 -!- Evolver [sid32215@user/evolver] has joined #bitcoin-core-dev 13:45 -!- belcher [~belcher@user/belcher] has joined #bitcoin-core-dev 13:52 -!- Guyver2 [~Guyver@2001:985:f3f:1:9521:339d:9d85:c755] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 13:59 -!- jonatack [~jonatack@user/jonatack] has quit [Quit: Client closed] 14:03 -!- Jackielove4u [uid43977@user/jackielove4u] has joined #bitcoin-core-dev 14:25 -!- mekster6 [~mekster@user/mekster] has quit [Quit: mekster6] 14:25 -!- mekster6 [~mekster@user/mekster] has joined #bitcoin-core-dev 14:27 -!- AaronvanW [~AaronvanW@190.150.26.4] has quit [Read error: Connection reset by peer] 14:28 -!- AaronvanW [~AaronvanW@190.150.26.4] has joined #bitcoin-core-dev 14:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:53 < bitcoin-git> [bitcoin] Shubhankar-Gambhir opened pull request #22641: Test : Added test for disabled wallet (master...master) https://github.com/bitcoin/bitcoin/pull/22641 14:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 15:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 15:58 < bitcoin-git> [bitcoin] dongcarl opened pull request #22642: release: Release with separate SHA256SUMS and sig files (master...2021-08-distribute-separate-asc-and-SHASUM) https://github.com/bitcoin/bitcoin/pull/22642 15:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:07 < bitcoin-git> [bitcoin] dongcarl opened pull request #22643: guix-verify: Non-zero exit code when anything fails (master...2021-08-guix-verify-exit-code) https://github.com/bitcoin/bitcoin/pull/22643 16:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:26 -!- vysn [~vysn@user/vysn] has quit [Remote host closed the connection] 17:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:07 < bitcoin-git> [bitcoin] fanquake opened pull request #22644: Deprecate UPnP support, require 2.1 or later (master...miniupnpc_pkg_config) https://github.com/bitcoin/bitcoin/pull/22644 17:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:27 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev 18:07 -!- bomb-on [~bomb-on@194.144.47.113] has quit [Quit: aллилѹіа!] 18:10 < ariard> kanzure: yes we're finalizing travel plans, sending an update mail next week! 18:20 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev 18:22 -!- earnestly [~earnest@user/earnestly] has quit [Ping timeout: 258 seconds] 18:27 -!- b10c [uid500648@id-500648.charlton.irccloud.com] has quit [Quit: Connection closed for inactivity] 19:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 19:05 < bitcoin-git> [bitcoin] fanquake opened pull request #22645: scripts: prevent GCC optimising test symbols in test-symbol-check (master...gcc_optimising_pow) https://github.com/bitcoin/bitcoin/pull/22645 19:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 19:30 -!- copumpkin [~woohoo@user/copumpkin] has quit [Quit: Textual IRC Client: www.textualapp.com] 19:36 -!- copumpkin [~woohoo@user/copumpkin] has joined #bitcoin-core-dev 20:14 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 265 seconds] 20:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 20:14 < bitcoin-git> [bitcoin] fanquake opened pull request #22646: [POC] Tighter Univalue integration, remove `--with-system-univalue` (master...tighter_univalue_integration) https://github.com/bitcoin/bitcoin/pull/22646 20:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 20:15 -!- dermoth_ [~dermoth@user/dermoth] has joined #bitcoin-core-dev 20:15 -!- dermoth [~dermoth@user/dermoth] has quit [Killed (NickServ (GHOST command used by dermoth_))] 20:15 -!- dermoth_ is now known as dermoth 20:18 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev 20:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 20:34 < bitcoin-git> [gui] achow101 opened pull request #396: gui: ensure external signer option remains disabled without signers (master...ensure-no-extsigner) https://github.com/bitcoin-core/gui/pull/396 20:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 20:34 -!- AaronvanW [~AaronvanW@190.150.26.4] has quit [Remote host closed the connection] 20:38 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 258 seconds] 20:39 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev 20:42 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Read error: Connection reset by peer] 20:47 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev 21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection] 21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev 21:05 -!- AaronvanW [~AaronvanW@190.150.26.4] has joined #bitcoin-core-dev 21:10 -!- AaronvanW [~AaronvanW@190.150.26.4] has quit [Ping timeout: 240 seconds] 21:24 -!- AaronvanW [~AaronvanW@190.150.26.4] has joined #bitcoin-core-dev 22:08 -!- AaronvanW [~AaronvanW@190.150.26.4] has quit [Remote host closed the connection] 22:24 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 244 seconds] 22:26 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev 22:44 -!- vnogueira [~vnogueira@user/vnogueira] has quit [Ping timeout: 244 seconds] 23:07 -!- jespada [~jespada@90.254.247.46] has quit [Ping timeout: 258 seconds] 23:08 -!- jespada [~jespada@90.254.247.46] has joined #bitcoin-core-dev 23:10 -!- jarthur [~jarthur@2603-8080-1540-002d-b0eb-14a2-3229-7a8f.res6.spectrum.com] has quit [Ping timeout: 240 seconds] 23:17 -!- jarthur [~jarthur@2603-8080-1540-002d-dd8f-ae40-8c90-f67d.res6.spectrum.com] has joined #bitcoin-core-dev 23:41 -!- vnogueira [~vnogueira@user/vnogueira] has joined #bitcoin-core-dev --- Log closed Fri Aug 06 00:00:30 2021