--- Log opened Wed Aug 11 00:00:35 2021
00:01 -!- jarthur [~jarthur@cpe-70-114-198-37.austin.res.rr.com] has quit [Ping timeout: 268 seconds]
00:09 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
00:20 -!- bomb-on [~bomb-on@194.144.47.113] has joined #bitcoin-core-dev
00:30 -!- AaronvanW [~AaronvanW@190.61.38.167] has quit [Ping timeout: 268 seconds]
00:37 -!- hex17or [~hex17or@gateway/tor-sasl/hex17or] has quit [Ping timeout: 244 seconds]
00:39 -!- hex17or [~hex17or@gateway/tor-sasl/hex17or] has joined #bitcoin-core-dev
00:43 -!- AaronvanW [~AaronvanW@190.61.38.167] has joined #bitcoin-core-dev
00:50 -!- bomb-on [~bomb-on@194.144.47.113] has quit [Quit: aллилѹіа!]
00:58 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
01:03 -!- earnestly [~earnest@user/earnestly] has joined #bitcoin-core-dev
01:18 -!- AaronvanW [~AaronvanW@190.61.38.167] has quit [Ping timeout: 248 seconds]
01:32 -!- AaronvanW [~AaronvanW@190.61.38.167] has joined #bitcoin-core-dev
01:46 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 268 seconds]
01:49 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
01:54 < jnewbery> roasbeef: > since the "new" protocol essentially uses the space between version and verack for interactive protocol feature negotiation instead of service bits
01:54 < jnewbery> My mental model is that service bits are for permanent attributes of the node. They communicate what services the node is capable of providing (historic blocks, segwit serialized blocks & txs, compact block filters, etc), and that service support is gossipped around the network in addrs.
01:54 < jnewbery> That allows nodes that require specific services to find peers that support those services.
01:55 < jnewbery> Feature negotiation using individual messages like sendcmpct, wtxidrelay, sendaddrv2, etc are for features for that specific connection. It's perfectly fine for a node to negotiate those features on some of its connections and not on others.
01:55 < jnewbery> If you need to support addrv2 and not wtxidrelay, it's safe to use p2p protocol version 70016 and just not send `wtxidrelay` during the version handshake. The peer will see that you don't support wtxidrelay and won't inv txs to you using wtxid.
02:05 -!- AaronvanW [~AaronvanW@190.61.38.167] has quit [Ping timeout: 248 seconds]
02:11 -!- AaronvanW [~AaronvanW@190.61.38.167] has joined #bitcoin-core-dev
02:15 -!- AaronvanW [~AaronvanW@190.61.38.167] has quit [Ping timeout: 268 seconds]
02:20 -!- AaronvanW [~AaronvanW@190.61.38.167] has joined #bitcoin-core-dev
02:20 -!- b10c [uid500648@id-500648.charlton.irccloud.com] has joined #bitcoin-core-dev
02:39 -!- RDK [~RDK@p200300db67137b57a131755bfc5ae9ef.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
02:54 -!- AaronvanW [~AaronvanW@190.61.38.167] has quit [Ping timeout: 272 seconds]
03:07 -!- AaronvanW [~AaronvanW@190.61.38.167] has joined #bitcoin-core-dev
03:14 -!- lkqwejhhgasdjhgn [~kljkljklk@p200300d46f0d87003d82f747617071bf.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
03:17 -!- RDK [~RDK@p200300db67137b57a131755bfc5ae9ef.dip0.t-ipconnect.de] has quit [Quit: Leaving]
03:24 -!- SpellChecker [~SpellChec@gateway/tor-sasl/spellchecker] has joined #bitcoin-core-dev
03:26 -!- bomb-on [~bomb-on@194.144.47.113] has joined #bitcoin-core-dev
03:41 -!- AaronvanW [~AaronvanW@190.61.38.167] has quit [Ping timeout: 248 seconds]
03:47 -!- AaronvanW [~AaronvanW@190.61.38.167] has joined #bitcoin-core-dev
03:52 -!- AaronvanW [~AaronvanW@190.61.38.167] has quit [Ping timeout: 268 seconds]
03:56 -!- AaronvanW [~AaronvanW@190.61.38.167] has joined #bitcoin-core-dev
04:21 -!- babasancheti [~babasanch@43.249.232.30] has quit [Quit: Client closed]
04:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:25 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to 0.21: https://github.com/bitcoin/bitcoin/compare/4b523c8f0a72...89d148c8c65b
04:25 < bitcoin-git> bitcoin/0.21 bf672ce W. J. van der Laan: build: Bump version to 0.21.2rc1
04:25 < bitcoin-git> bitcoin/0.21 e94e433 W. J. van der Laan: doc: Update manual pages for 0.21.2
04:25 < bitcoin-git> bitcoin/0.21 89d148c W. J. van der Laan: qt: Translations update for 0.21.2rc1
04:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:29 -!- AaronvanW [~AaronvanW@190.61.38.167] has quit [Ping timeout: 258 seconds]
04:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:44 < bitcoin-git> [bitcoin] laanwj pushed 1 commit to 22.x: https://github.com/bitcoin/bitcoin/compare/873fbc745d03...d3bd5410f64e
04:44 < bitcoin-git> bitcoin/22.x d3bd541 W. J. van der Laan: doc: Manual pages update for 22.0rc2
04:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:44 -!- AaronvanW [~AaronvanW@190.61.38.167] has joined #bitcoin-core-dev
04:45 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
04:49 -!- Zenton [~user@user/zenton] has quit [Remote host closed the connection]
04:54 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Remote host closed the connection]
04:54 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
05:17 -!- AaronvanW [~AaronvanW@190.61.38.167] has quit [Ping timeout: 248 seconds]
05:19 -!- common [~common@user/common] has joined #bitcoin-core-dev
05:36 -!- AaronvanW [~AaronvanW@190.61.38.167] has joined #bitcoin-core-dev
05:58 -!- vnogueir- [~vnogueira@user/vnogueira] has joined #bitcoin-core-dev
06:00 -!- vnogueira [~vnogueira@user/vnogueira] has quit [Ping timeout: 244 seconds]
06:05 -!- AaronvanW [~AaronvanW@190.61.38.167] has quit [Ping timeout: 258 seconds]
06:06 < Talkless> what does "Code review ACK" mean, how it's different.. from others? :)
06:07 < hebasto> Talkless: reviewed only, not actually tested
06:07 < Talkless> hebasto: so same as utACK ?
06:07 < Talkless> or is there still difference?
06:07 < hebasto> yes, but `utACK` is kind of undocumented
06:08 < sipa_> and it may mean "i haven't thought if this is a good idea, but the code changes look fine"
06:08 < hebasto> also https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#peer-review
06:11 -!- AaronvanW [~AaronvanW@190.61.38.167] has joined #bitcoin-core-dev
06:12 < sipa_> i interpret crACK as an utACK without concept/approach ACK
06:14 -!- jonatack [~jonatack@user/jonatack] has quit [Quit: Client closed]
06:16 -!- AaronvanW [~AaronvanW@190.61.38.167] has quit [Ping timeout: 268 seconds]
06:17 < jnewbery> sipa_: oh interesting, I'd just started using it instead of utACK (since it seems more precise)
06:18 < hebasto> jnewbery: agree, crACK seems more precise and looks fancy
06:20 -!- AaronvanW [~AaronvanW@190.61.38.167] has joined #bitcoin-core-dev
06:20 < sipa_> no reason why you can't write a while sentence to elaborate on exactly what you did
06:20 < sipa_> *whole
06:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:22 < bitcoin-git> [gui] hebasto merged pull request #354: Refactor open date range to use std::optional (master...2021-06-date-range) https://github.com/bitcoin-core/gui/pull/354
06:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:22 < bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c3545a739678...3d9cdb16897b
06:22 < bitcoin-git> bitcoin/master 4830f49 João Barbosa: qt: Refactor open date range to use std::optional
06:22 < bitcoin-git> bitcoin/master 3d9cdb1 Hennadii Stepanov: Merge bitcoin-core/gui#354: Refactor open date range to use std::optional
06:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:31 < Talkless> hebasto: Code review ACK is alos not docummented..? :/
06:31 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
06:31 < laanwj> "code review ACK" for me is "i've looked at the code changes and they look good to me, no comments, no critical conceptual issues, have run the auto-tests locally but not done any specific testing" (by far my most common kind of ACK)
06:34 < Talkless> laanwj: and utACK ?
06:35 < laanwj> i try to never use that
06:35 < laanwj> it's just too aspecific
06:38 < laanwj> i do "tested ACK" (which means I did some specific testing of the feature or change, and generally code review too, unless mentioned otherwise), "concept ACK" (didn't look at the code but the described concept sounds good, I do not include a commit id with this), "concept and code review ACK" sometimes (I especially like the concept and also reviewed the code)
06:39 < Talkless> OK so I'll not gonna use utACK
06:44 < jonatack> i guess part of the job of maintaining is evaluating what different people mean with their ACKs :)
06:45 < hebasto> the simplest way is just to follow our own dev docs
06:48 < jonatack> ("code review ACK" isn't described in CONTRIBUTING.md, much less "crACK" ;)
06:50 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 244 seconds]
06:54 -!- AaronvanW [~AaronvanW@190.61.38.167] has quit [Ping timeout: 248 seconds]
06:56 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 258 seconds]
06:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:56 < bitcoin-git> [gui] hebasto merged pull request #317: Add Direction column to Peers Tab (master...direction-col-peers) https://github.com/bitcoin-core/gui/pull/317
06:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:56 < bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3d9cdb16897b...77e23ca94503
06:56 < bitcoin-git> bitcoin/master 6971e79 Jon Atack: gui: add Direction column to peers tab
06:56 < bitcoin-git> bitcoin/master 77e23ca Hennadii Stepanov: Merge bitcoin-core/gui#317: Add Direction column to Peers Tab
06:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:59 -!- AaronvanW [~AaronvanW@190.61.38.167] has joined #bitcoin-core-dev
06:59 < jonatack> oh, nice to see this cleared up ^ thank you jarolrod for picking it up
07:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:00 < bitcoin-git> [gui] hebasto closed pull request #372: Remove "Type" column from peers window (master...remove-peers-type-column) https://github.com/bitcoin-core/gui/pull/372
07:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:00 < jonatack> ty hebasto
07:00 < hebasto> thanks to jonatack and jarolrod 
07:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:02 < bitcoin-git> [gui] hebasto closed pull request #400: Honor inbound/outbound arrow prefix when sorting peer address column (master...address_prefix_sort) https://github.com/bitcoin-core/gui/pull/400
07:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:04 -!- vnogueir- is now known as vnogueira
07:04 -!- AaronvanW [~AaronvanW@190.61.38.167] has quit [Ping timeout: 268 seconds]
07:07 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
07:08 -!- AaronvanW [~AaronvanW@190.61.38.167] has joined #bitcoin-core-dev
07:22 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
07:23 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 244 seconds]
07:46 -!- gleb [~gleb@178.150.137.228] has quit [Ping timeout: 272 seconds]
07:47 < Talkless> jonatack: eyah, reviewing docs could be better...
07:48 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
08:28 -!- AaronvanW [~AaronvanW@190.61.38.167] has quit [Ping timeout: 268 seconds]
08:32 -!- gleb7 [~gleb@178.150.137.228] has joined #bitcoin-core-dev
08:35 -!- muhblockchain [~muhblockc@user/muhblockchain] has joined #bitcoin-core-dev
08:42 -!- AaronvanW [~AaronvanW@190.61.38.167] has joined #bitcoin-core-dev
08:48 -!- lightlike [~lightlike@user/lightlike] has joined #bitcoin-core-dev
09:01 -!- VzxPLnHqr [VzxPLnHqr@gateway/vpn/protonvpn/vzxplnhqr] has joined #bitcoin-core-dev
09:05 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
09:10 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
09:15 -!- AaronvanW [~AaronvanW@190.61.38.167] has quit [Ping timeout: 245 seconds]
09:21 < achow101> laanwj: are we doing 0.21.2rc1 soon?
09:23 -!- jarthur [~jarthur@2603-8080-1540-002d-cd06-376d-051c-caa6.res6.spectrum.com] has joined #bitcoin-core-dev
09:23 -!- Naiza [~Naiza@180.188.251.211] has joined #bitcoin-core-dev
09:24 -!- lkqwejhhgasdjhgn [~kljkljklk@p200300d46f0d87003d82f747617071bf.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!]
09:33 -!- AaronvanW [~AaronvanW@190.61.38.167] has joined #bitcoin-core-dev
09:38 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 268 seconds]
09:42 -!- lightlike [~lightlike@user/lightlike] has left #bitcoin-core-dev [Leaving]
09:45 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
09:50 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 244 seconds]
09:56 -!- raj [~raj_@2409:4061:28c:fa97:40c0:3b6c:57b7:2a1d] has joined #bitcoin-core-dev
10:01 -!- kuler [~kulernil@gateway/tor-sasl/kuler] has joined #bitcoin-core-dev
10:03 -!- AaronvanW [~AaronvanW@190.61.38.167] has quit [Ping timeout: 268 seconds]
10:10 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
10:13 -!- AaronvanW [~AaronvanW@190.61.38.167] has joined #bitcoin-core-dev
10:15 < Talkless> laanwj: about "Tested ACK" means only that you tested GUI for expected behaviour, but did not ran any unit/functional tests..? Here's also ambiguity  :/
10:17 < sipa_> really, if you feel there is ambiguity, write a sentence that describes what you did
10:28 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
10:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:32 < bitcoin-git> [gui] hebasto opened pull request #403: refactor: Make paths to update Encryption and HD wallet statuses simpler (master...210811-hd) https://github.com/bitcoin-core/gui/pull/403
10:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:34 -!- Aaronvan_ [~AaronvanW@190.61.38.167] has joined #bitcoin-core-dev
10:35 -!- AaronvanW [~AaronvanW@190.61.38.167] has quit [Read error: Connection reset by peer]
10:45 -!- Jackielove4u [uid43977@user/jackielove4u] has quit [Quit: Connection closed for inactivity]
10:51 -!- SpellChecker [~SpellChec@gateway/tor-sasl/spellchecker] has quit [Quit: bye]
10:54 -!- SpellChecker [~SpellChec@gateway/tor-sasl/spellchecker] has joined #bitcoin-core-dev
11:01 -!- raj [~raj_@2409:4061:28c:fa97:40c0:3b6c:57b7:2a1d] has quit [Quit: Leaving]
11:04 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 272 seconds]
11:08 -!- janb [~arjan@home.connected.by.freedominter.net] has joined #bitcoin-core-dev
11:17 -!- Naiza [~Naiza@180.188.251.211] has quit [Quit: Connection closed]
11:17 -!- VzxPLnHqr [VzxPLnHqr@gateway/vpn/protonvpn/vzxplnhqr] has quit [Remote host closed the connection]
11:22 -!- Jackielove4u [uid43977@user/jackielove4u] has joined #bitcoin-core-dev
11:24 -!- lightlike [~lightlike@user/lightlike] has joined #bitcoin-core-dev
11:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:38 < bitcoin-git> [bitcoin] theStack opened pull request #22684: test: check for invalid `-prune` parameters (master...202108-test-check_invalid_prune_parameters) https://github.com/bitcoin/bitcoin/pull/22684
11:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:54 -!- Aaronvan_ [~AaronvanW@190.61.38.167] has quit [Remote host closed the connection]
11:54 -!- AaronvanW [~AaronvanW@190.61.38.167] has joined #bitcoin-core-dev
11:59 -!- AaronvanW [~AaronvanW@190.61.38.167] has quit [Ping timeout: 252 seconds]
12:03 -!- AaronvanW [~AaronvanW@190.61.38.167] has joined #bitcoin-core-dev
12:04 -!- SpellChecker [~SpellChec@gateway/tor-sasl/spellchecker] has quit [Remote host closed the connection]
12:06 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 244 seconds]
12:07 -!- SpellChecker [~SpellChec@gateway/tor-sasl/spellchecker] has joined #bitcoin-core-dev
12:08 -!- AaronvanW [~AaronvanW@190.61.38.167] has quit [Ping timeout: 272 seconds]
12:12 -!- AaronvanW [~AaronvanW@190.61.38.167] has joined #bitcoin-core-dev
12:17 -!- AaronvanW [~AaronvanW@190.61.38.167] has quit [Ping timeout: 256 seconds]
12:21 -!- AaronvanW [~AaronvanW@190.61.38.167] has joined #bitcoin-core-dev
12:25 -!- AaronvanW [~AaronvanW@190.61.38.167] has quit [Ping timeout: 248 seconds]
12:29 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
12:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:30 < bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/77e23ca94503...e614cc8cd808
12:30 < bitcoin-git> bitcoin/master 0237d95 Prateek Sancheti: qt: Add Load PSBT functionaliy with nowallet
12:30 < bitcoin-git> bitcoin/master e614cc8 Hennadii Stepanov: Merge bitcoin-core/gui#399: Fix "Load PSBT" functionality when no wallet l...
12:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:30 -!- AaronvanW [~AaronvanW@190.61.38.167] has joined #bitcoin-core-dev
12:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:30 < bitcoin-git> [gui] hebasto merged pull request #399: Fix "Load PSBT" functionality when no wallet loaded (master...i232-0806) https://github.com/bitcoin-core/gui/pull/399
12:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:32 -!- babasancheti [~babasanch@43.249.232.30] has joined #bitcoin-core-dev
12:35 -!- babasancheti [~babasanch@43.249.232.30] has quit [Client Quit]
12:45 -!- AaronvanW [~AaronvanW@190.61.38.167] has quit [Ping timeout: 245 seconds]
12:49 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
12:58 -!- AaronvanW [~AaronvanW@190.61.38.167] has joined #bitcoin-core-dev
13:10 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 244 seconds]
13:15 -!- meshcollider [meshcollid@user/meshcollider] has quit [Remote host closed the connection]
13:17 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
13:21 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
13:24 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 248 seconds]
13:24 -!- Guyver2_ is now known as Guyver2
13:28 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
13:32 -!- AaronvanW [~AaronvanW@190.61.38.167] has quit [Ping timeout: 268 seconds]
13:33 -!- mdrollette [~mdrollett@user/mdrollette] has joined #bitcoin-core-dev
13:36 -!- meshcollider [meshcollid@meshcollider.jujube.ircnow.org] has joined #bitcoin-core-dev
13:37 -!- AaronvanW [~AaronvanW@190.61.38.167] has joined #bitcoin-core-dev
13:41 -!- sipa_ is now known as sipa
13:42 -!- AaronvanW [~AaronvanW@190.61.38.167] has quit [Ping timeout: 248 seconds]
13:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:46 < bitcoin-git> [bitcoin] dongcarl opened pull request #22685: clientversion: No suffix #if CLIENT_VERSION_IS_RELEASE (master...2021-08-clientversion-is-cursed) https://github.com/bitcoin/bitcoin/pull/22685
13:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:46 -!- AaronvanW [~AaronvanW@190.61.38.167] has joined #bitcoin-core-dev
13:53 -!- Guest71 [~Guest71@2407:7000:9893:b100:51c8:a639:3376:962e] has joined #bitcoin-core-dev
13:54 -!- Guest71 [~Guest71@2407:7000:9893:b100:51c8:a639:3376:962e] has quit [Client Quit]
14:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:00 < bitcoin-git> [bitcoin] achow101 closed pull request #22680: guix: make git tag and commit known prior to building (master...guix-use-tag) https://github.com/bitcoin/bitcoin/pull/22680
14:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:05 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:20 -!- AaronvanW [~AaronvanW@190.61.38.167] has quit [Ping timeout: 252 seconds]
14:21 -!- Lightsword [~Lightswor@user/lightsword] has quit [Quit: ZNC]
14:26 -!- AaronvanW [~AaronvanW@190.61.38.167] has joined #bitcoin-core-dev
14:30 -!- AaronvanW [~AaronvanW@190.61.38.167] has quit [Ping timeout: 268 seconds]
14:35 -!- AaronvanW [~AaronvanW@190.61.38.167] has joined #bitcoin-core-dev
14:55 -!- vnogueir- [~vnogueira@user/vnogueira] has joined #bitcoin-core-dev
14:56 -!- vnogueira [~vnogueira@user/vnogueira] has quit [Remote host closed the connection]
14:58 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
14:58 -!- Lightsword [~Lightswor@user/lightsword] has joined #bitcoin-core-dev
15:01 -!- AaronvanW [~AaronvanW@190.61.38.167] has quit [Remote host closed the connection]
15:23 -!- SpellChecker [~SpellChec@gateway/tor-sasl/spellchecker] has quit [Remote host closed the connection]
15:26 -!- SpellChecker [~SpellChec@gateway/tor-sasl/spellchecker] has joined #bitcoin-core-dev
15:29 -!- Ananta-shesha [~pjetcetal@2.95.210.188] has quit [Ping timeout: 256 seconds]
15:31 -!- Ananta-shesha [~pjetcetal@2.95.210.188] has joined #bitcoin-core-dev
15:48 -!- hex17or [~hex17or@gateway/tor-sasl/hex17or] has quit [Ping timeout: 244 seconds]
15:51 -!- hex17or [~hex17or@gateway/tor-sasl/hex17or] has joined #bitcoin-core-dev
15:55 -!- hex17or [~hex17or@gateway/tor-sasl/hex17or] has quit [Remote host closed the connection]
15:56 -!- hex17or [~hex17or@gateway/tor-sasl/hex17or] has joined #bitcoin-core-dev
15:58 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Remote host closed the connection]
15:58 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
15:59 -!- lightlike [~lightlike@user/lightlike] has quit [Quit: Leaving]
16:03 < fanquake> achow101: yes
16:08 -!- meshcollider [meshcollid@meshcollider.jujube.ircnow.org] has quit [Changing host]
16:08 -!- meshcollider [meshcollid@user/meshcollider] has joined #bitcoin-core-dev
16:15 -!- vnogueir- [~vnogueira@user/vnogueira] has quit [Remote host closed the connection]
16:16 -!- vnogueira [~vnogueira@user/vnogueira] has joined #bitcoin-core-dev
16:17 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 245 seconds]
16:18 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
16:21 -!- nanotube [~nanotube@user/nanotube] has quit [Ping timeout: 248 seconds]
16:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
16:29 < bitcoin-git> [gui] hebasto merged pull request #390: Add SubFeeFromAmount to options  (master...i386_0729) https://github.com/bitcoin-core/gui/pull/390
16:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
16:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
16:29 < bitcoin-git> [bitcoin] hebasto pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/e614cc8cd808...9948f114f8e6
16:29 < bitcoin-git> bitcoin/master ad28b66 Prateek Sancheti: qt: Add SubFeeFromAmount option
16:29 < bitcoin-git> bitcoin/master 62b125f Prateek Sancheti: qt, refactor: Fix indentation
16:29 < bitcoin-git> bitcoin/master 9948f11 Hennadii Stepanov: Merge bitcoin-core/gui#390: Add SubFeeFromAmount to options
16:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
16:35 -!- nanotube [~nanotube@user/nanotube] has joined #bitcoin-core-dev
16:49 -!- bomb-on [~bomb-on@194.144.47.113] has quit [Quit: aллилѹіа!]
16:53 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
17:04 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 256 seconds]
17:13 -!- b10c [uid500648@id-500648.charlton.irccloud.com] has quit [Quit: Connection closed for inactivity]
17:13 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
17:19 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection]
17:35 -!- earnestly [~earnest@user/earnestly] has quit [Ping timeout: 272 seconds]
17:46 -!- jonatack [~jonatack@user/jonatack] has quit [Quit: Client closed]
17:54 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 245 seconds]
17:55 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
17:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
17:58 < bitcoin-git> [bitcoin] fanquake pushed tag v0.21.2rc1: https://github.com/bitcoin/bitcoin/compare/v0.21.2rc1
17:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
18:00 < fanquake> I've pushed up a tag for v0.21.2rc1
18:00 < fanquake> Hopefully everyone remembers how to gitian buildd
18:01 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 244 seconds]
18:01 < achow101> \o/
18:11 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
18:16 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
18:18 -!- vysn [~vysn@user/vysn] has quit [Remote host closed the connection]
18:36 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Remote host closed the connection]
18:36 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
19:07 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Remote host closed the connection]
19:08 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
19:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:16 < bitcoin-git> [bitcoin] achow101 opened pull request #22686: wallet: Use GetSelectionAmount in ApproximateBestSubset (master...use-getselectionvalue) https://github.com/bitcoin/bitcoin/pull/22686
19:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
19:41 -!- cold [~cold@user/cold] has joined #bitcoin-core-dev
19:42 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 256 seconds]
19:42 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
19:59 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Remote host closed the connection]
19:59 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
20:07 < fanquake> sipa / wumpus: can you block ljkt7334
20:24 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Read error: Connection reset by peer]
20:36 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has quit [Remote host closed the connection]
20:36 -!- ghost43 [~ghost43@gateway/tor-sasl/ghost43] has joined #bitcoin-core-dev
20:42 -!- AaronvanW [~AaronvanW@190.61.38.167] has joined #bitcoin-core-dev
20:46 -!- AaronvanW [~AaronvanW@190.61.38.167] has quit [Ping timeout: 268 seconds]
20:51 -!- AaronvanW [~AaronvanW@190.61.38.167] has joined #bitcoin-core-dev
20:58 -!- AaronvanW [~AaronvanW@190.61.38.167] has quit [Ping timeout: 248 seconds]
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:02 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
21:03 -!- kuler [~kulernil@gateway/tor-sasl/kuler] has quit [Remote host closed the connection]
21:03 < laanwj> congrats on your first tag fanquake 
21:08 < _aj_> #fanquake
21:09 -!- AaronvanW [~AaronvanW@190.61.38.167] has joined #bitcoin-core-dev
21:22 -!- AaronvanW [~AaronvanW@190.61.38.167] has quit [Ping timeout: 256 seconds]
21:40 -!- belcher_ [~belcher@user/belcher] has joined #bitcoin-core-dev
21:44 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 248 seconds]
21:51 -!- kuler [~kulernil@gateway/tor-sasl/kuler] has joined #bitcoin-core-dev
23:01 -!- belcher_ is now known as belcher
23:34 -!- bomb-on [~bomb-on@194.144.47.113] has joined #bitcoin-core-dev
--- Log closed Thu Aug 12 00:00:36 2021