--- Log opened Wed Aug 18 00:00:41 2021
00:12 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
00:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:16 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #22734: addrman: Avoid crash on corrupt data (master...2108-addrmanNoCrash) https://github.com/bitcoin/bitcoin/pull/22734
00:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:17 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
00:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:24 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #22498: Check that CAddrMan::nKey is not null after deserialize (master...2107-addrmanKeyZero) https://github.com/bitcoin/bitcoin/pull/22498
00:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:28 -!- bomb-on [~bomb-on@194.144.47.113] has quit [Quit: aллилѹіа!]
00:29 -!- bomb-on [~bomb-on@194.144.47.113] has joined #bitcoin-core-dev
00:44 -!- lkqwejhhgasdjhgn [~kljkljklk@p200300d46f05b800e0761eafdb2814c6.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
00:51 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
00:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:51 < bitcoin-git> [bitcoin] fanquake closed pull request #15836: Add feerate histogram to getmempoolinfo (master...2019/04/feeinfo) https://github.com/bitcoin/bitcoin/pull/15836
00:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:00 -!- bomb-on [~bomb-on@194.144.47.113] has quit [Quit: aллилѹіа!]
01:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:01 < bitcoin-git> [bitcoin] fanquake closed pull request #19216: wallet: Remove first parameter to ScanForWalletTransactions start_hash (master...2020-06-07-wallet-scanforwallettransactions) https://github.com/bitcoin/bitcoin/pull/19216
01:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:05 < bitcoin-git> [bitcoin] fanquake closed pull request #17805: test: Add test for rpcwhitelistdefault (master...2019-12-rpc-whitelistdefault-test) https://github.com/bitcoin/bitcoin/pull/17805
01:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:09 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
01:21 -!- b10c [uid500648@id-500648.charlton.irccloud.com] has joined #bitcoin-core-dev
01:22 -!- NorrinRadd [~username@154.6.20.113] has quit [Ping timeout: 245 seconds]
01:26 -!- NorrinRadd [~username@154.6.20.113] has joined #bitcoin-core-dev
01:34 < laanwj> larryruane: might want to tag josibake its his guide
01:35 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 240 seconds]
01:37 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
01:47 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
01:55 -!- Guest3121 [~Guest31@103.138.75.117] has joined #bitcoin-core-dev
01:56 < Guest3121> I meet a problem about verifying commit script , need help now.
01:57 < Guest3121> what I did as follow:
01:57 < Guest3121> 1. gpg --keyserver hkps://keys.openpgp.org --recv-keys $(<contrib/verify-commits/trusted-keys)
01:58 < Guest3121> 2. git fetch origin && ./contrib/verify-commits/verify-commits.py origin/master && git checkout origin/master
01:58 < Guest3121> console printed some log as follow:
01:58 < Guest3121> Using verify-commits data from /Users/geeker/tmp/bitcoin/contrib/verify-commits
01:58 < Guest3121> No parent of 803ef70fd9f65ef800567ff9456fac525bc3e3c2 was signed with a trusted key!
01:58 < Guest3121> Parents are:
01:59 < Guest3121> who can tell me why? thanks a lot
02:00 -!- Guest3121 [~Guest31@103.138.75.117] has quit [Quit: Client closed]
02:00 -!- Guest3154 [~Guest31@103.138.75.117] has joined #bitcoin-core-dev
02:22 < meshcollider> Guest3121: it may be because Marco's key is expired on some keyservers
02:25 -!- jespada [~jespada@90.254.247.46] has quit [Ping timeout: 245 seconds]
02:27 -!- jespada [~jespada@90.254.247.46] has joined #bitcoin-core-dev
02:28 < josibake> larryruane: thanks for reviewing the doc (and thanks hebasto for applying the fixes)
02:33 -!- Guest3154 [~Guest31@103.138.75.117] has quit [Quit: Ping timeout (120 seconds)]
02:55 -!- Guest317 [~Guest31@103.138.75.117] has joined #bitcoin-core-dev
03:02 < hebasto> josibake: yw
03:10 -!- Guest317 [~Guest31@103.138.75.117] has quit [Quit: Ping timeout (120 seconds)]
03:11 -!- bomb-on [~bomb-on@194.144.47.113] has joined #bitcoin-core-dev
03:42 -!- bomb-on [~bomb-on@194.144.47.113] has quit [Quit: aллилѹіа!]
04:23 -!- bomb-on [~bomb-on@194.144.47.113] has joined #bitcoin-core-dev
04:25 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
04:36 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
04:52 -!- bomb-on [~bomb-on@194.144.47.113] has quit [Quit: aллилѹіа!]
04:58 -!- bomb-on [~bomb-on@194.144.47.113] has joined #bitcoin-core-dev
05:00 -!- baldur [~baldur@pool-108-30-51-126.nycmny.fios.verizon.net] has quit [Ping timeout: 258 seconds]
05:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:09 < bitcoin-git> [bitcoin] fanquake closed pull request #20364: Follow-ups to 19107 (master...2020-11-19107-follow-ups) https://github.com/bitcoin/bitcoin/pull/20364
05:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:13 -!- baldur [~baldur@pool-108-30-51-126.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
05:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:13 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/bb9f76a7194a...e35c4a3d8057
05:13 < bitcoin-git> bitcoin/master f68c6ce fanquake: net: use clientInterface rather than uiInterface
05:13 < bitcoin-git> bitcoin/master d8ba632 fanquake: scripted-diff: replace clientInterface with m_client_interface in net
05:13 < bitcoin-git> bitcoin/master e35c4a3 fanquake: Merge bitcoin/bitcoin#22732: net: use m_client_interface rather than uiInt...
05:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:13 < bitcoin-git> [bitcoin] fanquake merged pull request #22732: net: use m_client_interface rather than uiInterface (master...use_uiinterface_in_net) https://github.com/bitcoin/bitcoin/pull/22732
05:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:13 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 240 seconds]
05:16 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
05:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:24 < bitcoin-git> [bitcoin] fanquake closed pull request #18242: Add BIP324 encrypted p2p transport de-/serializer (only used in tests) (master...2020/03/net_v2) https://github.com/bitcoin/bitcoin/pull/18242
05:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:24 < bitcoin-git> [bitcoin] fanquake closed pull request #14049: Enable libsecp256k1 ecdh module, add ECDH function to CKey (master...2018/08/bip151_ecdh) https://github.com/bitcoin/bitcoin/pull/14049
05:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:25 < bitcoin-git> [bitcoin] fanquake closed pull request #14032: Add p2p layer encryption with ECDH/ChaCha20Poly1305 (master...2018/08/bip151) https://github.com/bitcoin/bitcoin/pull/14032
05:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:27 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
05:28 -!- bomb-on [~bomb-on@194.144.47.113] has quit [Quit: aллилѹіа!]
05:28 -!- bomb-on [~bomb-on@194.144.47.113] has joined #bitcoin-core-dev
05:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:55 < bitcoin-git> [bitcoin] jnewbery opened pull request #22735: [net] Don't return an optional from TransportDeserializer::GetMessage() (master...2021-08-20364-rebased) https://github.com/bitcoin/bitcoin/pull/22735
05:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:05 < bitcoin-git> [bitcoin] jonatack opened pull request #22736: log, sync: change lock contention from preprocessor directive to log category (master...lockcontention-log-instead-of-define) https://github.com/bitcoin/bitcoin/pull/22736
06:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:20 < Talkless> If sqlite is used, berkleydb is not needed?
06:22 < sipa> bdb is needed to open bdb wallets
06:22 < sipa> :)
06:23 < Talkless> oh there's no "--without-bdb"
06:23 < Talkless> there is*
06:23 < Talkless> build-uinix could be a little more clear about that
06:24 < Talkless> build-unix.md *
06:33 -!- jonatack [~jonatack@user/jonatack] has quit [Quit: Client closed]
06:45 < Talkless> If I wanted to try 22rc2 with my "production" HW wallet, is there anything I should be aware..? Meaning, will signet/testnet addresses be completely different from mainnet? I don't recall if derivation paths differs for main/test/sig..?
06:49 < sipa> it being rc or release is indepedent from using it for mainnet or testnet/signet
07:02 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has quit [Quit: Konversation terminated!]
07:02 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
07:08 -!- AaronvanW [~AaronvanW@190.150.148.22] has joined #bitcoin-core-dev
07:17 < laanwj> i wouldn't recommend using a production HW wallet for testing, just for general safety (i don't know if it uses a different derivation path), you could use the emulator
07:25 -!- gambpang [~ishipman@207.181.230.156] has joined #bitcoin-core-dev
07:26 < Talkless> laanwj: yeah I kinda thought the same, currenlty setupping Trezor emulator
07:44 -!- babasancheti [~babasanch@43.249.232.30] has quit [Quit: Client closed]
07:47 -!- babasancheti [~babasanch@43.249.232.30] has joined #bitcoin-core-dev
07:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:55 < bitcoin-git> [bitcoin] laanwj closed pull request #22549: rpc: trigger error before dealing strSecret / strLabel (master...importprivkey_optimize) https://github.com/bitcoin/bitcoin/pull/22549
07:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:04 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
08:15 -!- muhblockchain [~muhblockc@user/muhblockchain] has joined #bitcoin-core-dev
08:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:17 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e35c4a3d8057...90499358e91e
08:17 < bitcoin-git> bitcoin/master 5449d44 fanquake: scripts: prevent GCC optimising test symbols in test-symbol-check
08:17 < bitcoin-git> bitcoin/master 9049935 W. J. van der Laan: Merge bitcoin/bitcoin#22645: scripts: prevent GCC optimising test symbols ...
08:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:17 < bitcoin-git> [bitcoin] laanwj merged pull request #22645: scripts: prevent GCC optimising test symbols in test-symbol-check (master...gcc_optimising_pow) https://github.com/bitcoin/bitcoin/pull/22645
08:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:31 -!- davterra [~davterra@143.198.56.186] has quit [Quit: Leaving]
08:41 -!- lkqwejhhgasdjhgn [~kljkljklk@p200300d46f05b800e0761eafdb2814c6.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!]
08:44 -!- contrapumpkin [~woohoo@user/copumpkin] has quit [Quit: Textual IRC Client: www.textualapp.com]
08:48 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
08:51 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 240 seconds]
08:51 -!- Guyver2_ is now known as Guyver2
09:03 -!- muhblockchain [~muhblockc@user/muhblockchain] has quit [Ping timeout: 240 seconds]
09:03 -!- cfields [~cfields@207.172.223.102] has quit [Quit: No Ping reply in 180 seconds.]
09:03 -!- cfields [~cfields@207.172.223.102] has joined #bitcoin-core-dev
09:10 -!- copumpkin [~woohoo@user/copumpkin] has joined #bitcoin-core-dev
09:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:11 < bitcoin-git> [bitcoin] theStack opened pull request #22738: test: fix failure in feature_nulldummy.py on single-core machines (master...202108-test-fix_nulldummy_test_on_singlecore) https://github.com/bitcoin/bitcoin/pull/22738
09:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:27 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 240 seconds]
09:30 -!- naiza [~naiza@180.188.251.67] has joined #bitcoin-core-dev
09:40 -!- sipsorcery [~sipsorcer@37.228.225.67] has joined #bitcoin-core-dev
09:46 -!- raj [~raj_@2409:4061:28c:fa97:95e1:3ff7:ebaa:9cf0] has joined #bitcoin-core-dev
10:04 -!- lukedashjr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
10:05 -!- lightlike [~lightlike@user/lightlike] has joined #bitcoin-core-dev
10:05 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 240 seconds]
10:06 -!- lukedashjr is now known as luke-jr
10:08 -!- lukedashjr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
10:12 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 252 seconds]
10:12 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
10:15 -!- jessebarton [~jessebart@ip72-203-188-10.tu.ok.cox.net] has joined #bitcoin-core-dev
10:15 -!- lukedashjr [~luke-jr@user/luke-jr] has quit [Ping timeout: 240 seconds]
10:16 -!- babasancheti [~babasanch@43.249.232.30] has quit [Quit: Client closed]
10:20 -!- lightlike [~lightlike@user/lightlike] has quit [Ping timeout: 245 seconds]
10:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:20 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #22159: build: Add --with-append-cxxflags option (master...2106-buildPattern) https://github.com/bitcoin/bitcoin/pull/22159
10:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:22 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
10:35 -!- davterra [~davterra@143.198.56.186] has joined #bitcoin-core-dev
10:46 -!- sipsorcery [~sipsorcer@37.228.225.67] has quit [Ping timeout: 240 seconds]
10:47 -!- common [~common@096-033-221-075.res.spectrum.com] has joined #bitcoin-core-dev
10:47 -!- common [~common@096-033-221-075.res.spectrum.com] has quit [Changing host]
10:47 -!- common [~common@user/common] has joined #bitcoin-core-dev
10:50 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
10:52 -!- lightlike [~lightlike@user/lightlike] has joined #bitcoin-core-dev
10:57 -!- raj [~raj_@2409:4061:28c:fa97:95e1:3ff7:ebaa:9cf0] has quit [Quit: Leaving]
11:02 -!- jonatack [~jonatack@user/jonatack] has quit [Quit: Client closed]
11:08 -!- chunkblob [~chunkblob@cpe-184-153-97-30.nyc.res.rr.com] has joined #bitcoin-core-dev
11:28 -!- naiza [~naiza@180.188.251.67] has quit [Quit: Connection closed]
11:33 -!- b10c [uid500648@id-500648.charlton.irccloud.com] has quit [Quit: Connection closed for inactivity]
11:38 -!- chunkblob [~chunkblob@cpe-184-153-97-30.nyc.res.rr.com] has quit [Quit: Connection closed]
11:42 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net]
11:42 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
11:47 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
11:55 -!- dviola [~diego@user/dviola] has quit [Ping timeout: 268 seconds]
11:56 -!- dviola [~diego@187.39.20.53] has joined #bitcoin-core-dev
11:57 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
12:00 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 240 seconds]
12:00 -!- Guyver2_ is now known as Guyver2
12:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:13 < bitcoin-git> [bitcoin] MarcoFalke pushed 23 commits to master: https://github.com/bitcoin/bitcoin/compare/90499358e91e...38975eccd498
12:13 < bitcoin-git> bitcoin/master 6f3d5ad fanquake: test: use f-strings in feature_asmap.py
12:13 < bitcoin-git> bitcoin/master 5453e87 fanquake: test: use f-strings in feature_backwards_compatibility.py
12:13 < bitcoin-git> bitcoin/master dca173c fanquake: test: use f-strings in feature_blocksdir.py
12:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:13 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #22229: test: consolidate to f-strings (part 1) (master...consolidate_to_f_strings) https://github.com/bitcoin/bitcoin/pull/22229
12:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:31 -!- AaronvanW [~AaronvanW@190.150.148.22] has quit [Remote host closed the connection]
12:36 -!- muhblockchain [~muhblockc@user/muhblockchain] has joined #bitcoin-core-dev
12:49 -!- gene [~gene@gateway/tor-sasl/gene] has joined #bitcoin-core-dev
12:52 -!- gleb7 [~gleb@178.150.137.228] has joined #bitcoin-core-dev
12:55 -!- gene [~gene@gateway/tor-sasl/gene] has quit [Ping timeout: 244 seconds]
13:01 -!- AaronvanW [~AaronvanW@190.150.148.22] has joined #bitcoin-core-dev
13:06 -!- AaronvanW [~AaronvanW@190.150.148.22] has quit [Ping timeout: 258 seconds]
13:10 -!- adiabat [~adiabat@63.209.32.102] has quit [Remote host closed the connection]
13:18 -!- jessebarton [~jessebart@ip72-203-188-10.tu.ok.cox.net] has quit [Quit: Connection closed]
13:20 -!- AaronvanW [~AaronvanW@190.150.148.22] has joined #bitcoin-core-dev
13:20 -!- dviola [~diego@187.39.20.53] has quit [Changing host]
13:20 -!- dviola [~diego@user/dviola] has joined #bitcoin-core-dev
13:20 -!- jonatack [~jonatack@user/jonatack] has quit [Quit: Client closed]
13:35 -!- AaronvanW [~AaronvanW@190.150.148.22] has quit [Ping timeout: 252 seconds]
13:36 -!- cryptolightning [~cryptolig@70-131-42-184.lightspeed.rlghnc.sbcglobal.net] has joined #bitcoin-core-dev
13:40 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 244 seconds]
13:41 -!- cryptolightning [~cryptolig@70-131-42-184.lightspeed.rlghnc.sbcglobal.net] has quit [Changing host]
13:41 -!- cryptolightning [~cryptolig@user/cryptolightning] has joined #bitcoin-core-dev
13:46 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
13:58 -!- gene [~gene@gateway/tor-sasl/gene] has joined #bitcoin-core-dev
13:58 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
14:00 -!- adiabat [~adiabat@63.209.32.102] has joined #bitcoin-core-dev
14:00 -!- adiabat [~adiabat@63.209.32.102] has quit [Client Quit]
14:00 -!- adiabat [~adiabat@63.209.32.102] has joined #bitcoin-core-dev
14:11 -!- AaronvanW [~AaronvanW@190.150.148.22] has joined #bitcoin-core-dev
14:26 -!- jonatack [~jonatack@user/jonatack] has quit [Quit: Client closed]
14:38 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:40 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
14:40 -!- AaronvanW [~AaronvanW@190.150.148.22] has quit [Remote host closed the connection]
14:46 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
14:47 -!- gene [~gene@gateway/tor-sasl/gene] has quit [Quit: gene]
15:04 -!- gambpang [~ishipman@207.181.230.156] has quit [Remote host closed the connection]
15:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:16 < bitcoin-git> [bitcoin] fanquake closed pull request #21496: fuzz: execute each file in dir without fuzz engine (master...21461-fuzz-directory-without-engine) https://github.com/bitcoin/bitcoin/pull/21496
15:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:18 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 240 seconds]
15:49 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 240 seconds]
15:58 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
16:08 -!- AaronvanW [~AaronvanW@190.150.30.183] has joined #bitcoin-core-dev
16:13 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection]
16:14 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
16:31 < jamesob> (on fuzz tests) wondering, would there be much benefit to adding more specific ConsumeDeserializable implementations? E.g. in a usage like this https://github.com/bitcoin/bitcoin/blob/master/src/test/fuzz/chain.cpp#L17, given the current definition (https://github.com/bitcoin/bitcoin/blob/master/src/test/fuzz/util.h#L100-L112) looks like it'd take ages to generate an actually valid, nontrivial cblockindex entry
16:32 < jamesob> browsing some of the corpus, it looks like most of the input strings are very brief and probably don't exercise much (https://github.com/bitcoin-core/qa-assets/tree/main/fuzz_seed_corpus/chain)
16:33 < jamesob> I could imagine we'd get quicker exploration of the tree if we did more specific Consume* implementations that actually targeted the particular datatypes of things we want to deserialize. But maybe it doesn't matter so much? Maybe MarcoFalke practicalswift can weigh in
16:45 < sipa> jamesob: cblockindex seems pretty simple already?
16:45 < sipa> all fixed sized fields etc
16:46 < jamesob> yeah that's true
16:49 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
16:51 < sipa> the fact that most seeds are small isn't necessarily a bad sign; it can just mean there isn't much to explore 
16:51 < jamesob> also I'm curious why we use the `while (fuzzed_data_provider.ConsumeBool())` construct when performing CallOneOf chains instead of having the fuzz generate a random ranged int to do a `for` over; seems like it'll be hard to generate a lengthy chain of random actions under the coin-flip-until-tails model
16:51 < sipa> fuzzing is not random
16:52 < sipa> or at least, not uniformly random
16:52 < sipa> choices that lead to more.coverage will be explored more than others
16:53 < jamesob> oh yeah right, because it's using some notion of coverage to guide seed growth - so the idea is the `while` construct will result in the most succinct execution to hit some branch?
16:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
16:58 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/38975eccd498...cabbd01d8557
16:58 < bitcoin-git> bitcoin/master f12fbad fanquake: windres: use PACKAGE_VERSION rather than building more version numbers
16:58 < bitcoin-git> bitcoin/master cabbd01 fanquake: Merge bitcoin/bitcoin#22724: windres: use PACKAGE_VERSION rather than buil...
16:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
16:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
16:58 < bitcoin-git> [bitcoin] fanquake merged pull request #22724: windres: use PACKAGE_VERSION rather than building more version numbers (master...windres_version_somplify) https://github.com/bitcoin/bitcoin/pull/22724
16:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
17:12 -!- lukedashjr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
17:13 -!- lightlike [~lightlike@user/lightlike] has quit [Quit: Leaving]
17:14 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 252 seconds]
17:15 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
17:19 -!- lukedashjr [~luke-jr@user/luke-jr] has quit [Ping timeout: 268 seconds]
17:21 -!- AaronvanW [~AaronvanW@190.150.30.183] has quit [Remote host closed the connection]
17:22 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 240 seconds]
17:24 -!- jessebarton [~jessebart@ip72-203-188-10.tu.ok.cox.net] has joined #bitcoin-core-dev
17:26 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
17:28 -!- earnestly [~earnest@user/earnestly] has quit [Ping timeout: 240 seconds]
17:29 -!- lukedashjr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
17:32 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 252 seconds]
17:34 -!- lukedashjr [~luke-jr@user/luke-jr] has quit [Ping timeout: 240 seconds]
17:34 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
17:40 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
17:42 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 240 seconds]
17:51 -!- AaronvanW [~AaronvanW@190.150.30.183] has joined #bitcoin-core-dev
17:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
17:54 < bitcoin-git> [bitcoin] fanquake opened pull request #22739: doc: link to managing-wallets from docs README (master...link_managing_wallets) https://github.com/bitcoin/bitcoin/pull/22739
17:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
17:56 -!- AaronvanW [~AaronvanW@190.150.30.183] has quit [Ping timeout: 252 seconds]
17:57 -!- tecnecio [~tecnecio_@214.red-2-139-121.dynamicip.rima-tde.net] has joined #bitcoin-core-dev
18:05 -!- tecnecio [~tecnecio_@214.red-2-139-121.dynamicip.rima-tde.net] has quit [Quit: Leaving]
18:05 -!- davterra [~davterra@143.198.56.186] has quit [Quit: Leaving]
18:11 -!- AaronvanW [~AaronvanW@190.150.30.183] has joined #bitcoin-core-dev
18:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
18:16 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/cabbd01d8557...607a6338a737
18:16 < bitcoin-git> bitcoin/master cd37356 Dhruv Mehta: [crypto] Fix K1/K2 use in ChaCha20-Poly1305 AEAD
18:16 < bitcoin-git> bitcoin/master 607a633 fanquake: Merge bitcoin/bitcoin#22331: crypto: Fix K1/K2 use in ChaCha20-Poly1305 AE...
18:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
18:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
18:17 < bitcoin-git> [bitcoin] fanquake merged pull request #22331: crypto: Fix K1/K2 use in ChaCha20-Poly1305 AEAD (master...15649-followups) https://github.com/bitcoin/bitcoin/pull/22331
18:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
18:17 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
18:18 -!- belcher_ [~belcher@user/belcher] has joined #bitcoin-core-dev
18:22 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 268 seconds]
18:22 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 240 seconds]
18:25 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
18:26 -!- AaronvanW [~AaronvanW@190.150.30.183] has quit [Ping timeout: 248 seconds]
18:33 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 245 seconds]
18:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
18:42 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/607a6338a737...638855af631e
18:42 < bitcoin-git> bitcoin/master 62a09a3 Russell Yanofsky: refactor: remove ::vpwallets and related global variables
18:42 < bitcoin-git> bitcoin/master 638855a fanquake: Merge bitcoin/bitcoin#19101: refactor: remove ::vpwallets and related glob...
18:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
18:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
18:43 < bitcoin-git> [bitcoin] fanquake merged pull request #19101: refactor: remove ::vpwallets and related global variables (master...pr/novp) https://github.com/bitcoin/bitcoin/pull/19101
18:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
18:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
18:44 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/638855af631e...b784ab10f555
18:44 < bitcoin-git> bitcoin/master 1ea11e1 fanquake: doc: link to managing-wallets from doc readme
18:44 < bitcoin-git> bitcoin/master b784ab1 fanquake: Merge bitcoin/bitcoin#22739: doc: link to managing-wallets from docs READM...
18:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
18:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
18:45 < bitcoin-git> [bitcoin] fanquake merged pull request #22739: doc: link to managing-wallets from docs README (master...link_managing_wallets) https://github.com/bitcoin/bitcoin/pull/22739
18:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
19:12 -!- freesprung [~freesprun@136-25-131-81.cab.webpass.net] has quit [Quit: zzz]
19:13 -!- freesprung [~freesprun@136.25.131.81] has joined #bitcoin-core-dev
19:17 -!- AaronvanW [~AaronvanW@190.150.30.183] has joined #bitcoin-core-dev
19:50 -!- AaronvanW [~AaronvanW@190.150.30.183] has quit [Ping timeout: 252 seconds]
20:17 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 240 seconds]
20:33 -!- davterra [~davterra@143.198.56.186] has joined #bitcoin-core-dev
20:41 -!- AaronvanW [~AaronvanW@190.150.30.183] has joined #bitcoin-core-dev
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:11 -!- jessebarton [~jessebart@ip72-203-188-10.tu.ok.cox.net] has quit [Quit: Connection closed]
21:14 -!- AaronvanW [~AaronvanW@190.150.30.183] has quit [Ping timeout: 268 seconds]
21:17 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection]
21:17 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
22:04 -!- AaronvanW [~AaronvanW@190.150.30.183] has joined #bitcoin-core-dev
22:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
22:10 < bitcoin-git> [bitcoin] amitiuttarwar opened pull request #22740: [addrman] Move serialization code to cpp (master...2021-08-move-addrman-serialize) https://github.com/bitcoin/bitcoin/pull/22740
22:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
22:38 -!- AaronvanW [~AaronvanW@190.150.30.183] has quit [Ping timeout: 268 seconds]
23:08 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has joined #bitcoin-core-dev
23:09 -!- tralfaz [~davterra@143.198.56.186] has joined #bitcoin-core-dev
23:10 -!- davterra [~davterra@143.198.56.186] has quit [Read error: Connection reset by peer]
23:21 -!- belcher_ is now known as belcher
23:26 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 246 seconds]
23:28 -!- AaronvanW [~AaronvanW@190.150.30.183] has joined #bitcoin-core-dev
23:30 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
23:34 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection]
23:35 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
23:38 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
23:50 -!- gleb7 [~gleb@178.150.137.228] has quit [Ping timeout: 258 seconds]
--- Log closed Thu Aug 19 00:00:42 2021