--- Log opened Mon Aug 23 00:00:46 2021
00:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:03 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e826b22da252...58b559fab025
00:03 < bitcoin-git> bitcoin/master a381374 Jadi: net: do not advertise address where nobody is listening
00:03 < bitcoin-git> bitcoin/master 58b559f MarcoFalke: Merge bitcoin/bitcoin#20769: net: fixes #20657 - Advertised address where ...
00:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:03 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20769: net: fixes #20657 - Advertised address where nobody is listening (master...fixes-issue-20657) https://github.com/bitcoin/bitcoin/pull/20769
00:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:11 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 240 seconds]
00:22 -!- AaronvanW [~AaronvanW@190.150.30.183] has quit [Ping timeout: 240 seconds]
00:31 -!- johnzwen- [~johnzweng@zweng.at] has quit [Quit: Leaving...]
00:32 -!- johnzweng [~johnzweng@zweng.at] has joined #bitcoin-core-dev
00:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:35 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/58b559fab025...489beb39842f
00:35 < bitcoin-git> bitcoin/master a3b559c Shubhankar Gambhir: test: added test for disabled wallet
00:35 < bitcoin-git> bitcoin/master 489beb3 MarcoFalke: Merge bitcoin/bitcoin#22641: test: Split rpc_signmessage test for disabled...
00:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:35 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #22641: test: Split rpc_signmessage test for disabled wallet (master...master) https://github.com/bitcoin/bitcoin/pull/22641
00:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:39 -!- babasancheti [~babasanch@43.249.232.30] has joined #bitcoin-core-dev
00:47 -!- SpellChecker [~SpellChec@gateway/tor-sasl/spellchecker] has quit [Remote host closed the connection]
00:51 -!- SpellChecker [~SpellChec@gateway/tor-sasl/spellchecker] has joined #bitcoin-core-dev
00:52 -!- lkqwejhhgasdjhgn [~kljkljklk@p200300d46f3896001a375f77d20536e4.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
01:13 -!- AaronvanW [~AaronvanW@190.150.30.183] has joined #bitcoin-core-dev
01:24 -!- Henrik [~textual@84.212.107.177] has joined #bitcoin-core-dev
01:46 -!- AaronvanW [~AaronvanW@190.150.30.183] has quit [Ping timeout: 250 seconds]
02:20 -!- johnzweng [~johnzweng@zweng.at] has quit [Quit: Leaving...]
02:23 -!- johnzweng [~johnzweng@zweng.at] has joined #bitcoin-core-dev
02:37 -!- AaronvanW [~AaronvanW@190.150.30.183] has joined #bitcoin-core-dev
02:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:50 < bitcoin-git> [bitcoin] jnewbery opened pull request #22777: net processing: don't request tx relay on feeler connections (master...2021-08-feeler-no-frelay) https://github.com/bitcoin/bitcoin/pull/22777
02:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:01 < bitcoin-git> [bitcoin] glozow closed pull request #22252: policy: Trim Packages when transaction with same txid exists in mempool (master...2021-06-mempool-matches) https://github.com/bitcoin/bitcoin/pull/22252
03:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:02 -!- Henrik [~textual@84.212.107.177] has quit [Quit: Textual IRC Client: www.textualapp.com]
03:03 -!- Henrik [~textual@84.212.107.177] has joined #bitcoin-core-dev
03:09 -!- AaronvanW [~AaronvanW@190.150.30.183] has quit [Ping timeout: 240 seconds]
03:14 -!- Henrik [~textual@84.212.107.177] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
03:25 -!- dr-orlovsky [~dr-orlovs@31.14.40.18] has joined #bitcoin-core-dev
03:28 -!- Henrik [~textual@84.212.107.177] has joined #bitcoin-core-dev
03:48 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
03:48 -!- kabaum [~kabaum@h-46-59-13-35.A163.priv.bahnhof.se] has joined #bitcoin-core-dev
03:48 -!- kabaum_ [~kabaum@h-46-59-13-35.A163.priv.bahnhof.se] has joined #bitcoin-core-dev
03:52 -!- kabaum_ [~kabaum@h-46-59-13-35.A163.priv.bahnhof.se] has left #bitcoin-core-dev []
03:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:59 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/489beb39842f...f6f7a12462b3
03:59 < bitcoin-git> bitcoin/master 6bb5470 nthumann: util: Check if specified config file cannot be opened
03:59 < bitcoin-git> bitcoin/master 127b460 nthumann: test: Check if specified config file cannot be opened
03:59 < bitcoin-git> bitcoin/master f6f7a12 MarcoFalke: Merge bitcoin/bitcoin#22622: util: Check if specified config file cannot b...
03:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:59 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #22622: util: Check if specified config file cannot be opened (master...check_conf_file) https://github.com/bitcoin/bitcoin/pull/22622
03:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:01 -!- AaronvanW [~AaronvanW@190.150.30.183] has joined #bitcoin-core-dev
04:01 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 246 seconds]
04:02 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
04:22 -!- babasancheti [~babasanch@43.249.232.30] has quit [Quit: Client closed]
04:24 -!- b10c [uid500648@id-500648.charlton.irccloud.com] has joined #bitcoin-core-dev
04:32 < laanwj> robertspigler: good to see at least they're honest about it--a web ui stack imports so many dependencies, through different package managers, etc, it's very hard to minimize the risk of a third-party compromise affecting the software supply chain
04:33 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
04:33 -!- AaronvanW [~AaronvanW@190.150.30.183] has quit [Ping timeout: 250 seconds]
04:34 -!- vysn [~vysn@user/vysn] has quit [Remote host closed the connection]
04:34 < laanwj> qt's dependendency management is delightfully dumb and simple in comparison
04:42 < fanquake> you're only one npm install away from downloading a malicious left-pad
05:04 -!- Yihen [~textual@103.138.75.117] has quit [Remote host closed the connection]
05:20 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
05:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:20 < bitcoin-git> [bitcoin] jnewbery opened pull request #22778: net processing: Reduce resource usage for inbound block-relay-only connections (master...2021-02-tx-relay-init) https://github.com/bitcoin/bitcoin/pull/22778
05:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:25 -!- AaronvanW [~AaronvanW@190.150.30.183] has joined #bitcoin-core-dev
05:27 -!- muhblockchain [~muhblockc@user/muhblockchain] has quit [Ping timeout: 248 seconds]
05:31 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 244 seconds]
05:34 -!- Henrik [~textual@84.212.107.177] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
05:43 -!- Henrik [~textual@84.212.107.177] has joined #bitcoin-core-dev
05:58 -!- AaronvanW [~AaronvanW@190.150.30.183] has quit [Ping timeout: 252 seconds]
06:08 < michaelfolkson> Has anyone in the past tried to add encryption to the RPC interface? Or is there a particular reason why that shouldn't be done?
06:09 < michaelfolkson> Couldn't find anything from a cursory PR search
06:14 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
06:14 < sipa> there used to be!
06:15 < sipa> it was deleted because it's pointless complexity
06:15 < sipa> it's intended for communication with trusted, local software
06:15 < sipa> there is documentation on how to ssl wrap
06:15 < sipa> it
06:19 -!- NorrinRadd [~username@154.6.20.210] has quit [Ping timeout: 248 seconds]
06:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:35 < bitcoin-git> [gui] Saibato opened pull request #407: bugfix: initialize IsHDEnabled correctly. (master...icon_update) https://github.com/bitcoin-core/gui/pull/407
06:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:41 -!- AaronvanW [~AaronvanW@190.150.30.183] has joined #bitcoin-core-dev
06:42 < michaelfolkson> sipa: Thanks
06:48 -!- Randolf [~randolf@184.70.10.188] has joined #bitcoin-core-dev
06:57 -!- videre_e [~videre_e@159.242.234.75] has joined #bitcoin-core-dev
06:58 < videre_e> is it possible to do mining bitcoins on a nvidia card?
06:59 < Randolf> videre_e: This is the development channel.  For mining questions, please ask in the #bitcoin-mining channel instead:  /join #bitcoin-mining
07:00 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
07:01 -!- Henrik [~textual@84.212.107.177] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
07:07 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
07:08 -!- vnogueira [~vnogueira@user/vnogueira] has joined #bitcoin-core-dev
07:08 < laanwj> bitcoind's control socket is supposed to be local-only, i wish we'd used a UNIX socket from the beginning (as clightning does)
07:09 < laanwj> and encryption is pointless when communicating to a local service, the OS can intercept everything anyhow
07:12 < laanwj> fanquake: unfortunately, rust has the same problem, i guess it's possible to use it without cargo almost everything uses that, it's possible to keep dependencies to a minimum but the indirect dep tree blows up fast
07:13 < Randolf> Is there a serious interest in adding UNIX sockets support?
07:14 < Randolf> I do like the idea of using this because it's more efficient -- I find with SMTP server milters that UNIX sockets perform better than TCP/IP connections (even through localhost).
07:16 < laanwj> i have some ancient PRs where i implemented UNIX socket support, it's easy for RPC at the server side, at the client side it is blocked on a libevent issue in libevent http, which is still not solved upstream
07:16 < laanwj> so we basically cannot do it, at least in bitcoin-cli, without some really ugly hacks around libevent
07:16 < Randolf> Yuck.
07:17 < Randolf> So this seems more like a libevent issue.
07:17 < laanwj> if you don't care about bitcoin-cli (e.g. use it from python) server-side might be enough thogh
07:17 < Randolf> Perhaps it should be implemented on the server-side anyway, and then eventually the cli could be fixed over time?
07:17 < laanwj> yes, i filed a PR to implement the necessary support in libevent but it was never merged
07:18 < Randolf> Which PR?
07:18 < laanwj> it's kind of an annoyance for me so i don't really want to go back to it
07:18 < Randolf> Oh.
07:18 < Randolf> I'm sorry to hear that.
07:18 < laanwj> feel free to pick it up ofc
07:19 < laanwj> https://github.com/libevent/libevent/pull/479 https://github.com/libevent/libevent/issues/907
07:20 < Randolf> Thanks.
07:20 < Randolf> I want to follow it, at least.  I don't know if I can pick it up though as I'm not a seasoned C/C++ developer yet.
07:21 < laanwj> i did suggest doing only the server side at the time, but this made it controversial somehow
07:21 < laanwj> i'm actually really bad at getting my own PRs in open source projects merged
07:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:21 < bitcoin-git> [bitcoin] darosior opened pull request #22779: policy: correct (lower) the dust threshold for Taproot outputs (master...taproot_dust_limit) https://github.com/bitcoin/bitcoin/pull/22779
07:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:28 < laanwj> another reason why i wish we had used it from the beginning because in that case, support for UNIX sockets in the HTTP lib would have been a hard requirement so we'd never have chosen libevent's in the first place-
07:28 < sipa> iirc, my suggestion at the time was just dropping libevent for bitcoin-cli, as bitcoind-compatible-httpd should be very simple to implement by hand :)
07:29 < sipa> of course, suggestions are easy if you don't follow up with code
07:30 < laanwj> i dread getting into implementing a HTTP client, it sounds easy in theory but also i have enough experience with the avalanche of inadvertent complexity involved in such projects by now
07:31 -!- videre_e [~videre_e@159.242.234.75] has left #bitcoin-core-dev [leave!]
07:32 < Randolf> laanwj: Even with Qt5's libraries that take care of various tedious aspects of the implementation details, it's still hard (so I agree with you).
07:32 < laanwj> can't we just use libcurl *ducks*
07:32  * Randolf laughs
07:33 < sipa> laanwj: a fully compliant HTTP client sounds terrible, but my point is that we don't actually need that, just something that's compatible with bitcoind. but also, i'm not actually volunteering to write this :)
07:34 < laanwj> sipa: yeah, true, it's just that we now have squashed most of the usability issues in bitcoin-cli (after the libevent switch), that would basically start over
07:35 < laanwj> most actual work will subtle things like error handling, timeouts, etc
07:35 < laanwj> then again, if someone wants to take this on, i'm not exactly stopping them
07:36 < Randolf> That doesn't sound like a minor undertaking.
07:40 < sipa> we could use boost::beast *ducks*
07:40 < laanwj> it doesn't, and seeing that it's not been picked up after so many years, it probably isn't really that much "serious interest" in it (the original question), just a would-be-nice thing
07:41 < laanwj> sipa: hah
07:46 < Randolf> Boost created so many problems for me that I avoid it as if it were the plague -- they keep breaking backward compatibility, and then on some systems it's not possible to run different software that each depend on versions of the Boost libraries that aren't compatible.
07:47 < sipa> i think our current effort is reducing boost usage to the extent possible to headers-only libraries
07:47 < sipa> which at least avoid all the runtime build/link/compatibility issues
07:47 < Randolf> I remember -- I was part of the meetings where that was decided.
07:48 < Randolf> As I recall, it wasn't a difficult decision.
07:50 < laanwj> right, the impulse has been to move away from boost, long, long ago it used boost::asio for the RPC socket it was one of the first things
07:51 < laanwj> there were a lot of stability issues and from what i remember it had a high overhead, there's zero chance of going back to that
07:52 < laanwj> libevent is good performance-wise but the HTTP library is very, very limited
07:54 < laanwj> but we deemed it'd be enough for our use for RPC (which is also quite limited)
07:56 < Randolf> Ah.
07:57 -!- Henrik [~textual@84.212.107.177] has joined #bitcoin-core-dev
08:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:04 < bitcoin-git> [gui] MarcoFalke closed pull request #407: bugfix: initialize IsHDEnabled correctly. (master...icon_update) https://github.com/bitcoin-core/gui/pull/407
08:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:15 < laanwj> which, everything considered, it mostly also is-we have run into some limitations around streaming data (without buffering it all in memory) and UNIX sockets
08:36 -!- Henrik [~textual@84.212.107.177] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
08:49 -!- Guest65 [~Guest65@net-93-144-79-2.cust.vodafonedsl.it] has joined #bitcoin-core-dev
08:49 -!- Randolf [~randolf@184.70.10.188] has quit [Quit: Leaving]
08:49 -!- Guest65 [~Guest65@net-93-144-79-2.cust.vodafonedsl.it] has quit [Client Quit]
09:06 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 240 seconds]
09:10 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
09:12 -!- lkqwejhhgasdjhgn [~kljkljklk@p200300d46f3896001a375f77d20536e4.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!]
09:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:21 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/f6f7a12462b3...dbcb5742c48f
09:21 < bitcoin-git> bitcoin/master 5d47860 Pieter Wuille: refactor: move CAddress-without-nTime logic to net_processing
09:21 < bitcoin-git> bitcoin/master 75290ae Pieter Wuille: Drop us=... message in net debug for sending version message
09:21 < bitcoin-git> bitcoin/master dbcb574 MarcoFalke: Merge bitcoin/bitcoin#20541: Move special CAddress-without-nTime logic to ...
09:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:21 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #20541: Move special CAddress-without-nTime logic to net_processing (master...202012_addr_without_time_is_no_addr) https://github.com/bitcoin/bitcoin/pull/20541
09:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:32 < theStack> could one of the maintainers take a look at #22565? with seven ACKs (including one by kallewoof, the original author of the script), this PR should be ripe for merging
09:32 <@gribble> https://github.com/bitcoin/bitcoin/issues/22565 | [script] signets getcoins.py improvements by NikhilBartwal · Pull Request #22565 · bitcoin/bitcoin · GitHub
09:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:54 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #22780: doc: Remove incorrect INIT_PROTO_VERSION from nTime comment (master...2108-docFix) https://github.com/bitcoin/bitcoin/pull/22780
09:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:01 -!- lightlike [~lightlike@user/lightlike] has joined #bitcoin-core-dev
10:12 < jonatack> 2021-08-23T17:08:07Z [opencon] ADDRMAN CONSISTENCY CHECK FAILED!!! err=-17 bitcoind: ./addrman.h:707: void CAddrMan::Check() const: Assertion `false' failed. Aborted
10:12 < jonatack> seeing addrman check failures for the first time, since the merge of  #20541
10:13 <@gribble> https://github.com/bitcoin/bitcoin/issues/20541 | Move special CAddress-without-nTime logic to net_processing by sipa · Pull Request #20541 · bitcoin/bitcoin · GitHub
10:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:13 < bitcoin-git> [bitcoin] Saibato opened pull request #22781: wallet: fix the behavior of IsHDEnabled, return false in case of a blank hd wallet. (master...fix_ishdenabled) https://github.com/bitcoin/bitcoin/pull/22781
10:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:14 < jonatack> maybe it's just my peers.dat or a coincidence
10:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:19 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/dbcb5742c48f...1bbe289f201c
10:19 < bitcoin-git> bitcoin/master 1c612b2 NikhilBartwal: [script] Update signet getcoins.py for custom network
10:19 < bitcoin-git> bitcoin/master b0c8246 NikhilBartwal: Add cleaner errors for unsuccessful faucet transactions
10:19 < bitcoin-git> bitcoin/master 1bbe289 W. J. van der Laan: Merge bitcoin/bitcoin#22565: [script] signet's getcoins.py improvements
10:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:20 < bitcoin-git> [bitcoin] laanwj merged pull request #22565: [script] signet's getcoins.py improvements (master...update_signet_getcoins) https://github.com/bitcoin/bitcoin/pull/22565
10:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:26 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #22782: Remove unused MaybeSetAddrName (master...2108-noMaybeSetAddrName) https://github.com/bitcoin/bitcoin/pull/22782
10:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:27 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1bbe289f201c...b1c4a4ed395e
10:27 < bitcoin-git> bitcoin/master 2b3d8f3 Hennadii Stepanov: qt: Handle new added plurals in bitcoin_en.ts
10:27 < bitcoin-git> bitcoin/master b1c4a4e W. J. van der Laan: Merge bitcoin-core/gui#406: Handle new added plurals in bitcoin_en.ts
10:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:28 < bitcoin-git> [gui] laanwj merged pull request #406: Handle new added plurals in bitcoin_en.ts (master...210821-plurals) https://github.com/bitcoin-core/gui/pull/406
10:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:37 < bitcoin-git> [bitcoin] hebasto opened pull request #22783: build: Cleanup depends build system (master...210823-pkg) https://github.com/bitcoin/bitcoin/pull/22783
10:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:37 < jonatack> hm, i haven't been able to reproduce the issue on the other chain, only on mainnet. but it's the first time the addrman check failed for me (five times out of five restarts) after a couple of months of running it
10:37 < jonatack> *chains
10:40 < jonatack> "2021-08-23T17:25:48Z [init] addrman lost 22813 new and 2 tried addresses due to collisions or invalid addresses"
10:46 < jonatack> it had been about a week since the previous restart
10:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:59 < bitcoin-git> [gui] ShaMan239 opened pull request #408: Add missing mnemonics in menu bar options (master...mnemonic-shortcuts) https://github.com/bitcoin-core/gui/pull/408
10:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:08 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 240 seconds]
11:18 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
11:19 < jonatack> ok, addrman check failed again on restart after a fresh recreated peers.dat...will open an issue
11:20 < sipa> jonatack: by "check failed" do you mean consistency check, or that message about lost addresses above?
11:23 < jonatack> sipa: both, in succession
11:23 < jonatack> 2021-08-23T18:12:24Z [init] Bucketing method was updated, re-bucketing addrman entries from disk
11:23 < jonatack> 2021-08-23T18:12:24Z [init] addrman lost 2216 new and 0 tried addresses due to collisions or invalid addresses
11:24 < jonatack> 2021-08-23T18:14:06Z [opencon] Addrman checks started: new 10626, tried 16, total 10642
11:24 < jonatack> 2021-08-23T18:14:06Z [opencon] ADDRMAN CONSISTENCY CHECK FAILED!!! err=-17 bitcoind: ./addrman.h:707: void CAddrMan::Check() const: Assertion `false' failed. Aborted
11:24 < jonatack> (sorry for all the lines)
11:24 < sipa> jonatack: what codebase version?
11:24 < sipa> and it's actually a cleanly created peers.dat, or something from a possibly older version of the codebase?
11:26 < jonatack> sipa: first with a well-used peers.dat. a couple days ago i noticed that it strangely lost about 30k addresses. then today the check failed. i then renamed the corrupt peers.dat and restarted. all well. i then restarted a few minutes later. re-fail.
11:27 < jonatack> on current master dbcb5742c48f
11:28 < MarcoFalke> So it doesn't happen on previous master commits?
11:28 < jonatack> i was also testing #21879 rebased to master just before. let me reverify that it's not that.
11:28 <@gribble> https://github.com/bitcoin/bitcoin/issues/21879 | Wrap accept() and extend usage of Sock by vasild · Pull Request #21879 · bitcoin/bitcoin · GitHub
11:29 < jonatack> will rinse and repeat
11:31 < sipa> jonatack: ok, let me know 
11:32 < jonatack> MarcoFalke: am retrying on master and on, say, f5a406f003a0603251 from saturday
11:33 -!- gleb7 [~gleb@178.150.137.228] has quit [Ping timeout: 252 seconds]
11:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:43 < bitcoin-git> [gui] ShaMan239 opened pull request #409: Fix window title of wallet loading window (master...wallet-window-title) https://github.com/bitcoin-core/gui/pull/409
11:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:51 -!- Henrik [~textual@84.212.107.177] has joined #bitcoin-core-dev
11:52 < jonatack> i've re-reproduced on current master and on saturday, now trying just before the addrman#clear change
11:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:58 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b1c4a4ed395e...ec6db8e85838
11:58 < bitcoin-git> bitcoin/master faa5fa9 MarcoFalke: fuzz: Use LIMITED_WHILE instead of limit_max_ops
11:58 < bitcoin-git> bitcoin/master ec6db8e MarcoFalke: Merge bitcoin/bitcoin#22769: fuzz: Use LIMITED_WHILE instead of limit_max_...
11:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:58 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #22769: fuzz: Use LIMITED_WHILE instead of limit_max_ops (master...2108-fuzzRefactor) https://github.com/bitcoin/bitcoin/pull/22769
11:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:58 -!- gleb7 [~gleb@178.150.137.228] has joined #bitcoin-core-dev
12:04 < jonatack> update: the issue appears to be in one of the addrman#clear commits, e35c4a3 works, 4d2fa97 fails
12:08 < laanwj> jonatack: great catch!
12:12 < jonatack> laanwj: thanks! ok the issue begins appearing for me with 181a1207ba "[addrman] Move peers.dat parsing to init.cpp"
12:12 < laanwj> that's a pure code move-maybe something with initialization order?
12:13 -!- nathanael [~nathanael@user/nathanael] has quit [Quit: connection reset by purr]
12:15 < jonatack> double checking; it's the *second* restart that sees the issue, so it's a bit weird
12:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:16 < bitcoin-git> [gui] hebasto merged pull request #408: Add missing mnemonics in menu bar options (master...mnemonic-shortcuts) https://github.com/bitcoin-core/gui/pull/408
12:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:16 < bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ec6db8e85838...d3203a99d886
12:16 < bitcoin-git> bitcoin/master 7c33e3a Shashwat: qt: Add missing mnemonics in menu bar options
12:16 < bitcoin-git> bitcoin/master d3203a9 Hennadii Stepanov: Merge bitcoin-core/gui#408: Add missing mnemonics in menu bar options
12:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:16 < MarcoFalke> jonatack: The crash happens after "Loading P2P addresses…" or later?
12:20 -!- Henrik [~textual@84.212.107.177] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
12:20 < jonatack> re-reproduced 3 times at that commit.
12:21 < jonatack> 2021-08-23T19:18:27Z [init] init message: Loading P2P addresses…
12:21 < jonatack> 2021-08-23T19:18:27Z [init] Bucketing method was updated, re-bucketing addrman entries from disk
12:21 < jonatack> 2021-08-23T19:18:27Z [init] addrman lost 677 new and 0 tried addresses due to collisions or invalid addresses
12:21 < jonatack> 2021-08-23T19:18:27Z [init] Addrman checks started: new 5013, tried 8, total 5021
12:21 < jonatack> 2021-08-23T19:18:27Z [init] Addrman checks completed successfully
12:21 < jonatack> 2021-08-23T19:18:27Z [init] Loaded 5021 addresses from peers.dat  201m
12:21 < jonatack> -> the first check passes
12:21 -!- nathanael [~nathanael@user/nathanael] has joined #bitcoin-core-dev
12:21 < MarcoFalke> Oh I found the issue. It is asmap related.
12:21 < MarcoFalke> jonatack: Are you using asmap?
12:21 < jonatack> yes
12:22 < jonatack> the second check fails after addcon thread start / opencon thread start
12:22 < MarcoFalke> The asmap must be loaded before addrman
12:22 < jonatack> ah. init order as laanwj suggested
12:23 < MarcoFalke> 181a1207ba made it load in the  wrong order
12:24 < MarcoFalke> I won't be working on a fix (bed time)
12:25 < MarcoFalke> Unless it is still unfixed tomorrow, heh
12:25 < jonatack> makes sense. i'll have a look as i'm now used to reproducing it :D  
12:29 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
12:29 < jonatack> that explains why i was only seeing it on mainnet, too 
12:34 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
12:35 < sipa> jonatack: nice catch
12:36 < sipa> loading asmap after loading addrman would explain it
12:36 < sipa> both the lost addresses and the consistency check
12:48 < jnewbery> jonatack: MarcoFalke: good catch. Thank you - I'll work on a fix tomorrow.
13:00 < jnewbery> I didn't realise that connman was reaching into addrman to modify its internal data after construction. I think the fix is to pass asmap as a parameter to addrman's ctor, set it in the intializer list and make it const.
13:01 < sipa> that sounds cleaner
13:05 < jnewbery> Eventually asmap probably shouldn't be part of addrman at all, but that can wait until later
13:07 < laanwj> while reviewing i noticed the ordering change but didn't realize this interaction was there
13:40 -!- TheCharlatan [~drgrid@2a01:4f9:4a:2adc::2] has quit [Ping timeout: 240 seconds]
13:41 < jonatack> jnewbery: agree, improving separation and less reaching into other class internals will avoid future hard-to-spot issues
13:42 -!- TheCharlatan [~drgrid@2a01:4f9:4a:2adc::2] has joined #bitcoin-core-dev
13:43 < jonatack> a test wouldn't have caught this unless it ran both -asmap and -checkaddrman...best to make the code cleaner
14:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:01 < bitcoin-git> [gui] benthecarman opened pull request #410: gui: Uppercase 'bitcoin:' in QR code URI (master...uppercase-uri) https://github.com/bitcoin-core/gui/pull/410
14:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:08 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
14:08 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Read error: Connection reset by peer]
14:08 -!- Guyver2_ is now known as Guyver2
14:20 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 240 seconds]
14:29 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:47 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
14:49 -!- gene [~gene@gateway/tor-sasl/gene] has joined #bitcoin-core-dev
15:01 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
15:03 -!- ExEric3 [~exeric3@178.132.3.92] has quit [Read error: Connection reset by peer]
15:04 -!- ExEric3 [~exeric3@178.132.3.92] has joined #bitcoin-core-dev
15:38 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 240 seconds]
15:45 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
15:54 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
15:55 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
16:02 -!- b10c [uid500648@id-500648.charlton.irccloud.com] has quit [Quit: Connection closed for inactivity]
16:03 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection]
16:04 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
16:06 -!- bomb-on [~bomb-on@194.144.47.113] has quit [Quit: aллилѹіа!]
16:20 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 240 seconds]
16:27 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 240 seconds]
16:27 < robertspigler> laanwj: yes, refreshingly honest!
16:30 -!- lightlike [~lightlike@user/lightlike] has quit [Quit: Leaving]
16:45 -!- gene [~gene@gateway/tor-sasl/gene] has quit [Quit: gene]
17:00 -!- AaronvanW [~AaronvanW@190.150.30.183] has quit [Quit: Leaving...]
17:03 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection]
17:08 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
17:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
17:15 < bitcoin-git> [bitcoin] fpelliccioni opened pull request #22786: fix tests (master...fix_scriptnum_test) https://github.com/bitcoin/bitcoin/pull/22786
17:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
17:23 -!- earnestly [~earnest@user/earnestly] has quit [Ping timeout: 240 seconds]
17:37 -!- jespada [~jespada@90.254.247.46] has quit [Ping timeout: 258 seconds]
17:42 -!- jespada [~jespada@90.254.245.194] has joined #bitcoin-core-dev
18:12 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection]
18:21 -!- gene [~gene@gateway/tor-sasl/gene] has joined #bitcoin-core-dev
18:22 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 250 seconds]
18:32 -!- gene [~gene@gateway/tor-sasl/gene] has quit [Quit: gene]
18:35 -!- belcher [~belcher@user/belcher] has joined #bitcoin-core-dev
18:56 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
19:05 -!- SpellChecker [~SpellChec@gateway/tor-sasl/spellchecker] has quit [Quit: bye]
19:05 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
19:09 -!- SpellChecker [~SpellChec@gateway/tor-sasl/spellchecker] has joined #bitcoin-core-dev
19:15 -!- Yihen [~textual@103.138.75.117] has joined #bitcoin-core-dev
19:29 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
19:39 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
19:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:44 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d3203a99d886...61a843e43bf1
19:44 < bitcoin-git> bitcoin/master 5ef2738 fanquake: util: make ParseMoney return a std::optional<CAmount>
19:44 < bitcoin-git> bitcoin/master f7752ad fanquake: util: check MoneyRange() inside ParseMoney()
19:44 < bitcoin-git> bitcoin/master 61a843e fanquake: Merge bitcoin/bitcoin#22220: util: make ParseMoney return a std::optional<...
19:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
19:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:44 < bitcoin-git> [bitcoin] fanquake merged pull request #22220: util: make ParseMoney return a std::optional<CAmount> (master...parse_money_optional) https://github.com/bitcoin/bitcoin/pull/22220
19:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:12 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/61a843e43bf1...b20ad0eb16b9
20:12 < bitcoin-git> bitcoin/master 16652a9 Martin Zumsande: refactor: Remove unused KeyIDHasher
20:12 < bitcoin-git> bitcoin/master 4c69571 Martin Zumsande: doc: remove outdated comment
20:12 < bitcoin-git> bitcoin/master b20ad0e fanquake: Merge bitcoin/bitcoin#22772: refactor: hasher cleanup (follow-up to 19935)...
20:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:13 < bitcoin-git> [bitcoin] fanquake merged pull request #22772: refactor: hasher cleanup (follow-up to 19935) (master...202108_hasher_cleanup) https://github.com/bitcoin/bitcoin/pull/22772
20:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:25 -!- aechu [~major@gateway/tor-sasl/major] has quit [Ping timeout: 244 seconds]
20:27 -!- aechu [~major@gateway/tor-sasl/major] has joined #bitcoin-core-dev
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:22 -!- gleb7 [~gleb@178.150.137.228] has quit [Ping timeout: 252 seconds]
21:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
21:25 < bitcoin-git> [bitcoin] kallewoof opened pull request #22787: refactor: actual immutable pointing (master...202108-const-shared-ptrs) https://github.com/bitcoin/bitcoin/pull/22787
21:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
21:40 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 244 seconds]
21:43 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection]
21:43 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
21:46 < fanquake> wumpus / sipa: please block https://github.com/codedfile
21:47 < kalle> maybe give fanquake block privs?
21:49 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
21:56 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
22:20 < meshcollider> kalle: I think block privs require being a github repo admin, which is the highest permission level. Not opposed to fanquake being added but it is definitely a bigger move so it'd have to be discussed at the meeting I guess (plus the more people with those permissions the greater the "attack surface").
22:20 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 244 seconds]
22:22 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
22:44 -!- vysn [~vysn@user/vysn] has quit [Remote host closed the connection]
22:55 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
23:19 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
23:46 -!- Henrik [~textual@84.212.107.177] has joined #bitcoin-core-dev
23:58 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
--- Log closed Tue Aug 24 00:00:47 2021