--- Log opened Tue Aug 24 00:00:47 2021
00:26 -!- Henrik [~textual@84.212.107.177] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
00:28 -!- Guest18 [~Guest18@dynamic-2ewv96tdcb52h13mbt-pd01.res.v6.highway.a1.net] has joined #bitcoin-core-dev
00:32 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection]
00:33 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
00:33 -!- vnogueira [~vnogueira@user/vnogueira] has quit [Remote host closed the connection]
00:33 -!- prayank [~andr0irc@51.158.144.31] has joined #bitcoin-core-dev
00:33 -!- vnogueira [~vnogueira@user/vnogueira] has joined #bitcoin-core-dev
00:35 < prayank> re: wallet files should not be used across chains
00:36 < prayank> Related issues: https://github.com/bitcoin/bitcoin/issues/12805
00:36 < prayank> https://github.com/bitcoin-core/gui/issues/369
00:36 < prayank> Which PR is fixing this? I am assuming #18554
00:36 <@gribble> https://github.com/bitcoin/bitcoin/issues/18554 | wallet: ensure wallet files are not reused across chains by rodentrabies · Pull Request #18554 · bitcoin/bitcoin · GitHub
00:37 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has joined #bitcoin-core-dev
00:37 < prayank> If yes, would review and test this ASAP. Request other wallet devs to review as well and get this merged.
00:38 < prayank> Reason: This can result in some weird vulnerabilities if not managed properly and things aren't kept separate
00:39 < vasild> Is anybody working on fixing the addrman/asmap order issue reported above? I guess this would fix it: https://bpa.st/7TLQ (a possible quick fix, would not improve the quality of the code like making it impossible to wrong-do in the future).
00:39 < vasild> jonatack: laanwj: jnewbery: MarcoFalke: sipa: ^
00:40 < vasild> If nobody is looking into it, I can take care about it.
00:46 -!- prayank [~andr0irc@51.158.144.31] has quit [Quit: irc thread exit]
00:48 -!- Talkless [~Talkless@88.118.107.234] has joined #bitcoin-core-dev
00:54 -!- Henrik [~textual@84.212.107.177] has joined #bitcoin-core-dev
00:57 -!- earnestly [~earnest@user/earnestly] has joined #bitcoin-core-dev
00:58 -!- lkqwejhhgasdjhgn [~kljkljklk@p200300d46f38960079b57c3ff61f7967.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
01:09 -!- Talkless [~Talkless@88.118.107.234] has quit [Quit: Konversation terminated!]
01:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:10 < bitcoin-git> [gui] MarcoFalke merged pull request #349: replace QDateTime::fromTime_t with QDateTime::fromSecsSinceEpoch (master...qt_drop_from_time_t) https://github.com/bitcoin-core/gui/pull/349
01:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:11 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b20ad0eb16b9...dd455ecfa085
01:11 < bitcoin-git> bitcoin/master 27257b3 fanquake: refactor: replace QDateTime::fromTime_t with QDateTime::fromSecsSinceEpoch
01:11 < bitcoin-git> bitcoin/master 3ae503c fanquake: refactor: replace QDateTime::toTime_t with QDateTime::toSecsSinceEpoch
01:11 < bitcoin-git> bitcoin/master dd455ec MarcoFalke: Merge bitcoin-core/gui#349: replace QDateTime::fromTime_t with QDateTime::...
01:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:12 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
01:16 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 240 seconds]
01:16 -!- vnogueira [~vnogueira@user/vnogueira] has quit [Remote host closed the connection]
01:17 -!- vnogueira [~vnogueira@user/vnogueira] has joined #bitcoin-core-dev
01:21 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
01:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:22 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/dd455ecfa085...eb09c26724e3
01:22 < bitcoin-git> bitcoin/master faf7e92 MarcoFalke: test: Add generate* calls to test framework
01:22 < bitcoin-git> bitcoin/master fab2e23 MarcoFalke: Use generate* from TestFramework
01:22 < bitcoin-git> bitcoin/master eb09c26 fanquake: Merge bitcoin/bitcoin#22741: test: Add generate* calls to test framework
01:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:23 < bitcoin-git> [bitcoin] fanquake merged pull request #22741: test: Add generate* calls to test framework (master...2108-testSync01) https://github.com/bitcoin/bitcoin/pull/22741
01:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:34 < jnewbery> vasild: I don't think that diff would work. Addrman needs to be constructed before connman.
01:35 < jnewbery> I'll open a fix PR this morning
01:36 < vasild> node.addrman = std::make_unique... is not moved
01:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:36 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #22788: scripted-diff: Use generate* from TestFramework (master...2108-testGenDiff) https://github.com/bitcoin/bitcoin/pull/22788
01:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:36 < vasild> i.e. addrman is constructed before connman
01:37 < vasild> but anyway, if you will fix it properly (e.g. make asmap argument to addrman constructor), poke me for review :)
01:38 < jnewbery> ah, ok. Yes, I think that'd do it then, but I think it'd be preferable to collect all of the addrman initialization code together in one place.
01:39 < vasild> I wonder if it would be better to pass `std::vector<bool> asmap` to the addrman ctor and read it before calling the ctor with the static CAddrMan::DecodeAsmap() or to pass fs::path asmap_path to the ctor.
01:40 < vasild> std::optional<fs::path>
01:41 < vasild> I guess also CConnman::SetAsmap() can be removed
01:42 < jnewbery> vasild: I was planning on making `std::vector<bool>* asmap` the argument
01:42 < jnewbery> indeed - remove CConnman::SetAsmap()
01:42 < jnewbery> and potentially make m_asmap private
01:43 < vasild> +1, maybe a getter method would be required
01:45 < vasild> std::vector<bool> asmap = CAddrMan::DecodeAsmap(path); CAddrMan addrman(asmap); // this pattern looks a bit strange
01:46 < vasild> CAddrMan addrman(asmap_path); // and call DecodeAsmap() inside the ctor looks more straight-forward to me
01:47 < jnewbery> vasild: I agree. DecodeAsmap() does not need to be a static member function on CAddrMan at all. In fact, I don't think asmap belongs inside CAddrMan, but it's a bigger job to extract it
01:50 < vasild> DecodeAsmap() can be non-static private method, only called from the ctor. But anyway, I guess it can be improved in different ways :)
02:12 -!- janb [~arjan@185.238.129.113] has quit [Ping timeout: 240 seconds]
02:27 -!- Henrik [~textual@84.212.107.177] has quit [Ping timeout: 250 seconds]
02:36 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 244 seconds]
02:39 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Read error: Connection reset by peer]
02:39 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
02:39 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev
02:46 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 244 seconds]
02:50 -!- pigeons [~pigeons@androzani.sysevolve.com] has quit [Ping timeout: 240 seconds]
02:51 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
03:00 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Remote host closed the connection]
03:09 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
03:15 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 244 seconds]
03:19 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
03:38 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
03:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:42 < bitcoin-git> [bitcoin] theStack opened pull request #22789: external_signer: improve fingerprint matching logic (stop on first match) (master...202108-external_signer-improve_fingerprint_matching) https://github.com/bitcoin/bitcoin/pull/22789
03:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:48 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
03:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:57 < bitcoin-git> [bitcoin] Zero-1729 opened pull request #22790: test: add aarch64-apple-darwin platform entry to get_previous_releases (master...add-aarch64-apple-darwin-get-prev-releases) https://github.com/bitcoin/bitcoin/pull/22790
03:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:24 < jnewbery> jonatack: are you able to test whether https://github.com/jnewbery/bitcoin/tree/2021-08-asmap-addrman-init resolves the addrman/asmap issue?
04:27 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
04:27 -!- NorrinRadd [~username@154.6.20.215] has joined #bitcoin-core-dev
04:28 -!- Talkless [~Talkless@88.118.107.234] has joined #bitcoin-core-dev
04:31 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Client Quit]
04:33 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
04:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:34 < bitcoin-git> [bitcoin] jnewbery opened pull request #22791: [init] Read/decode asmap before constructing addrman (master...2021-08-asmap-addrman-init) https://github.com/bitcoin/bitcoin/pull/22791
04:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:43 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
04:46 -!- Talkless [~Talkless@88.118.107.234] has quit [Read error: Connection reset by peer]
04:47 -!- Talkless [~Talkless@88.118.107.234] has joined #bitcoin-core-dev
04:47 -!- Talkless [~Talkless@88.118.107.234] has quit [Client Quit]
04:50 -!- Guest18 [~Guest18@dynamic-2ewv96tdcb52h13mbt-pd01.res.v6.highway.a1.net] has quit [Ping timeout: 246 seconds]
04:54 -!- Guest18 [~Guest18@dynamic-2ewv9512956j1ss81n-pd01.res.v6.highway.a1.net] has joined #bitcoin-core-dev
04:54 -!- Guest18 [~Guest18@dynamic-2ewv9512956j1ss81n-pd01.res.v6.highway.a1.net] has quit [Client Quit]
05:15 -!- instagibbs [~instagibb@119247204116.ctinets.com] has quit [Ping timeout: 258 seconds]
05:16 -!- instagibbs [~instagibb@119247204116.ctinets.com] has joined #bitcoin-core-dev
05:23 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 240 seconds]
05:37 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
05:55 -!- vhs43[m] [~vhs43matr@2001:470:69fc:105::ba6d] has quit [Quit: You have been idle for 30+ days]
05:59 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Ping timeout: 250 seconds]
06:04 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
06:04 -!- jetpack_ [~jetpack@2605:2700:1:100e:ddb4:196e:c17a:3b92] has quit [Quit: ZNC 1.7.2+deb3 - https://znc.in]
06:06 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
06:07 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev
06:07 -!- jetpack [~jetpack@2605:2700:1:100e:ddb4:196e:c17a:3b92] has joined #bitcoin-core-dev
06:08 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Read error: Connection reset by peer]
06:09 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev
06:24 -!- Netsplit *.net <-> *.split quits: Ananta-shesha, piku, c_arc_, jrayhawk, mekster6, DeanGuss, cfields, sanket1729, Lightsword, schmidty,  (+11 more, use /NETSPLIT to show all of them)
06:25 -!- Netsplit over, joins: luke-jr
06:25 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Read error: Connection reset by peer]
06:26 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev
06:27 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Read error: Connection reset by peer]
06:28 -!- andytosh1 [~apoelstra@s66-183-0-205.bc.hsia.telus.net] has joined #bitcoin-core-dev
06:28 -!- ariard__ [~ariard@167.99.46.220] has joined #bitcoin-core-dev
06:28 -!- piku [~piku@47.202.122.99] has joined #bitcoin-core-dev
06:28 -!- jesseposner [~jesse@c-24-4-88-184.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
06:28 -!- dviola [~diego@user/dviola] has joined #bitcoin-core-dev
06:28 -!- cfields [~cfields@207.172.223.102] has joined #bitcoin-core-dev
06:28 -!- sanket1729 [~sanket172@ec2-100-24-255-95.compute-1.amazonaws.com] has joined #bitcoin-core-dev
06:28 -!- jrayhawk [~jrayhawk@user/jrayhawk] has joined #bitcoin-core-dev
06:28 -!- provoostenator [~quassel@user/provoostenator] has joined #bitcoin-core-dev
06:28 -!- Ananta-shesha [~pjetcetal@2.95.210.196] has joined #bitcoin-core-dev
06:28 -!- BUSY [~BUSY@user/busy] has joined #bitcoin-core-dev
06:28 -!- elichai2 [sid212594@stonehaven.irccloud.com] has joined #bitcoin-core-dev
06:28 -!- schmidty [sid297174@tooting.irccloud.com] has joined #bitcoin-core-dev
06:28 -!- cold [~cold@user/cold] has joined #bitcoin-core-dev
06:28 -!- Lightsword [~Lightswor@user/lightsword] has joined #bitcoin-core-dev
06:28 -!- mdrollette [~mdrollett@user/mdrollette] has joined #bitcoin-core-dev
06:28 -!- warren [~warren@fedora/wombat/warren] has joined #bitcoin-core-dev
06:28 -!- c_arc_ [~c_arc@4.53.92.114] has joined #bitcoin-core-dev
06:28 -!- mekster6 [~mekster@user/mekster] has joined #bitcoin-core-dev
06:28 -!- DeanGuss [~dean@user/deanguss] has joined #bitcoin-core-dev
06:28 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev
06:29 -!- gleb7 [~gleb@178.150.137.228] has joined #bitcoin-core-dev
06:54 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has quit [Quit: Konversation terminated!]
07:04 -!- RDK [~RDK@p200300db67137b89080d34ef7b8dc0ac.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
07:11 -!- RDK [~RDK@p200300db67137b89080d34ef7b8dc0ac.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
07:12 -!- RDK [~RDK@p200300db67137b89080d34ef7b8dc0ac.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
07:27 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
07:27 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
07:28 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
07:32 -!- muhblockchain [~muhblockc@user/muhblockchain] has joined #bitcoin-core-dev
07:50 -!- AaronvanW [~AaronvanW@190.150.30.183] has joined #bitcoin-core-dev
07:51 -!- hsmiths [uid95325@id-95325.brockwell.irccloud.com] has quit []
07:51 -!- hsmiths [uid95325@id-95325.helmsley.irccloud.com] has joined #bitcoin-core-dev
07:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:59 < bitcoin-git> [bitcoin] hebasto closed pull request #17786: refactor: Nuke policy/fees->mempool circular dependencies (master...20191221-mempool-circ-dep) https://github.com/bitcoin/bitcoin/pull/17786
07:59 -!- JackH [~laptop@ppp-0-174.leed-a-2.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev
07:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:04 < bitcoin-git> [bitcoin] hebasto closed pull request #17791: Remove UBSan suppressions for CTxMemPool* (master...20191222-mempool-ub) https://github.com/bitcoin/bitcoin/pull/17791
08:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:10 -!- jamesob [sid180710@id-180710.brockwell.irccloud.com] has quit []
08:10 -!- jamesob [sid180710@id-180710.helmsley.irccloud.com] has joined #bitcoin-core-dev
08:23 -!- rodarmor [sid210835@id-210835.brockwell.irccloud.com] has quit []
08:24 -!- rodarmor [sid210835@id-210835.helmsley.irccloud.com] has joined #bitcoin-core-dev
08:28 < ryanofsky> Can add #22219 to high priority for me since previous prs merged?
08:28 <@gribble> https://github.com/bitcoin/bitcoin/issues/22219 | multiprocess: Start using init makeNode, makeChain, etc methods by ryanofsky · Pull Request #22219 · bitcoin/bitcoin · GitHub
08:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:37 < bitcoin-git> [bitcoin] hebasto closed pull request #19306: refactor: Replace RecursiveMutex with Mutex in CTxMemPool (master...200616-mempool-mx) https://github.com/bitcoin/bitcoin/pull/19306
08:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:38 < bitcoin-git> [bitcoin] hebasto closed pull request #19652: Avoid locking CTxMemPool::cs recursively in Mempool{Info}ToJSON() (master...200803-mmx-2) https://github.com/bitcoin/bitcoin/pull/19652
08:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:40 < bitcoin-git> [bitcoin] hebasto closed pull request #19901: Avoid locking CTxMemPool::cs recursively in CTxMemPool::DynamicMemoryUsage() (master...200906-pool) https://github.com/bitcoin/bitcoin/pull/19901
08:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:41 < bitcoin-git> [bitcoin] hebasto closed pull request #19872: Avoid locking CTxMemPool::cs recursively in some cases (master...200904-mmx4) https://github.com/bitcoin/bitcoin/pull/19872
08:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:45 < jonatack> hebasto: these look like pretty cool PRs. closing due to lack of review, or no longer relevant?
08:47 < hebasto> jonatack: I think they require a fresh look :)
08:48 < jonatack> ok. (can you elaborate on what "a fresh look" means?)
08:48 < hebasto> while rebasing them, I realize that I don't really like their implementation
08:49 < hebasto> I think we should keep all locks within  class
08:52 < jonatack> ah, thanks for clarifying
09:01 -!- lkqwejhhgasdjhgn [~kljkljklk@p200300d46f38960079b57c3ff61f7967.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!]
09:03 -!- RDK [~RDK@p200300db67137b89080d34ef7b8dc0ac.dip0.t-ipconnect.de] has quit [Quit: Leaving]
10:01 -!- xor9[m] [~xor9matri@2001:470:69fc:105::d186] has joined #bitcoin-core-dev
10:01 -!- NorrinRadd [~username@154.6.20.215] has quit [Ping timeout: 252 seconds]
10:03 -!- NorrinRadd [~username@154.6.20.215] has joined #bitcoin-core-dev
10:16 < jnewbery> hebasto: > I think we should keep all locks within  class
10:16 < jnewbery> ^ it's definitly better when you can do it that way
10:17 -!- jespada [~jespada@90.254.245.194] has quit [Ping timeout: 250 seconds]
10:20 -!- jespada [~jespada@90.254.245.194] has joined #bitcoin-core-dev
10:21 -!- hex17or [~hex17or@gateway/tor-sasl/hex17or] has quit [Remote host closed the connection]
10:21 -!- hex17or [~hex17or@gateway/tor-sasl/hex17or] has joined #bitcoin-core-dev
10:28 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
10:45 < jarolrod> ^^ it's certainly a better interface
11:08 -!- pigeons [~pigeons@androzani.sysevolve.com] has joined #bitcoin-core-dev
11:18 -!- lightlike [~lightlike@user/lightlike] has joined #bitcoin-core-dev
11:33 -!- commmon [~common@096-033-221-075.res.spectrum.com] has joined #bitcoin-core-dev
11:36 -!- andytosh1 is now known as andytoshi
11:37 -!- common [~common@user/common] has quit [Ping timeout: 252 seconds]
11:40 -!- common [~common@096-033-221-075.res.spectrum.com] has joined #bitcoin-core-dev
11:42 -!- commmon [~common@096-033-221-075.res.spectrum.com] has quit [Ping timeout: 248 seconds]
11:57 -!- common [~common@096-033-221-075.res.spectrum.com] has quit [Ping timeout: 250 seconds]
13:10 -!- Yihen [~textual@103.138.75.117] has quit [Remote host closed the connection]
13:17 -!- ExEric3 [~exeric3@178.132.3.92] has quit [Ping timeout: 240 seconds]
13:19 < S3RK> sipa: laanwj: re: RPC interface is supposed to be local only. I was under a similar impression, but I'm not sure that's actually the case
13:20 < S3RK> e.g. https://github.com/bitcoin/bitcoin/pull/22775#issuecomment-903843166
13:20 < S3RK> folks are using wallet RPC remotely over hidden Tor service
13:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:22 < bitcoin-git> [bitcoin] achow101 opened pull request #22793: Simplify BaseSignatureChecker virtual functions and GenericTransactionSignatureChecker constructors (master...refactor-sig-checker) https://github.com/bitcoin/bitcoin/pull/22793
13:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:23 < sipa> S3RK: i think that's fine if it's only exposed to trusted clients
13:23 -!- JackH [~laptop@ppp-0-174.leed-a-2.dynamic.dsl.as9105.com] has quit [Ping timeout: 248 seconds]
13:24 < S3RK> would you call it a supported use case? Should we add more method params to deal with the latency?
13:28 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 244 seconds]
13:39 -!- ExEric3 [~exeric3@178.132.3.92] has joined #bitcoin-core-dev
13:42 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
13:49 -!- moneyball_ [sid299869@id-299869.brockwell.irccloud.com] has quit []
13:49 -!- moneyball_ [sid299869@id-299869.helmsley.irccloud.com] has joined #bitcoin-core-dev
13:51 -!- RubenSomsen [sid301948@user/rubensomsen] has quit []
13:51 -!- RubenSomsen [sid301948@user/rubensomsen] has joined #bitcoin-core-dev
14:03 -!- prayank [~andr0irc@51.158.144.32] has joined #bitcoin-core-dev
14:09 < prayank> S3RK: In PR #22775 I don't think latency really is a good enough reason to make changes. However, this would make listtransactions RPC easier to use. I have answered few related questions on Stackexchange and GitHub, some users are not sure how this works and TBH it's a kind of puzzle. Also if a change reduces number of calls it's always good.
14:09 <@gribble> https://github.com/bitcoin/bitcoin/issues/22775 | rpc: Add option to list transactions from oldest to newest in `listtransactions` RPC command by ben-kaufman · Pull Request #22775 · bitcoin/bitcoin · GitHub
14:30 -!- jespada [~jespada@90.254.245.194] has quit [Ping timeout: 252 seconds]
14:33 -!- ajonas [sid385278@id-385278.brockwell.irccloud.com] has quit []
14:33 -!- ajonas [sid385278@id-385278.helmsley.irccloud.com] has joined #bitcoin-core-dev
14:34 -!- jespada [~jespada@90.254.245.194] has joined #bitcoin-core-dev
14:38 < S3RK> prayank: it depens on how we define the purpose/users for the RPC. Based on my understanding, RPC interface is an API for machines and is not intended for the end users. If users are still confused the fix should have GUI-first approach and only modify RPCs if necessary
14:41 < S3RK> to be clear, I'm more interested in understanding our philosophy on designing RPC API and whether my understanding is correct, rather this specific example
14:41 < prayank> RPC can be used by devs or power users in CLI, POST requests, code etc. Consider an example in which you want to list last 10 transactions from wallet, machine will run RPC but you have to write what are the arguments for it.
14:42 < prayank> Maybe Copilot or some other tools have suggestions but eventually humans write code that machines run
14:49 < prayank> https://bitcoin.stackexchange.com/q/106116/
14:50 < S3RK> in my mind CLI and RPC are very much different things. CLI is a user-facing interface and RPC is a machine API. Those two things should have different design philosophies 
14:50 < S3RK> but in bitcoin-core CLI is just a thin proxy. Which begs the question whether it's a serious user-facing interface or not
15:08 -!- hex17or [~hex17or@gateway/tor-sasl/hex17or] has quit [Ping timeout: 244 seconds]
15:09 -!- hex17or [~hex17or@gateway/tor-sasl/hex17or] has joined #bitcoin-core-dev
15:10 < Bullit> listtransactions causes me to open blockchain.info to retrieve via shared mutual .info handshake the adresses of inferior bech58 or bech3X
15:16 -!- lightlike [~lightlike@user/lightlike] has quit [Quit: Leaving]
15:31 -!- belcher [~belcher@user/belcher] has quit [Read error: Connection reset by peer]
15:31 -!- belcher [~belcher@user/belcher] has joined #bitcoin-core-dev
15:32 -!- bomb-on [~bomb-on@194.144.47.113] has joined #bitcoin-core-dev
15:32 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
15:46 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 244 seconds]
15:52 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
15:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:52 < bitcoin-git> [bitcoin] lsilva01 opened pull request #22794: test: Split rpc_invalid_address_message test into two (master...split_invalid_address_message_test) https://github.com/bitcoin/bitcoin/pull/22794
15:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
16:02 -!- Guest54 [~Guest54@12.97.152.122] has joined #bitcoin-core-dev
16:03 -!- Ananta-shesha [~pjetcetal@2.95.210.196] has quit [Remote host closed the connection]
16:04 -!- Guest54 [~Guest54@12.97.152.122] has quit [Client Quit]
16:06 -!- instagibbs [~instagibb@119247204116.ctinets.com] has quit [Quit: Leaving]
16:08 -!- prayank [~andr0irc@51.158.144.32] has quit [Ping timeout: 250 seconds]
16:11 -!- Ananta-shesha [~pjetcetal@2.95.210.196] has joined #bitcoin-core-dev
16:14 -!- hex17or [~hex17or@gateway/tor-sasl/hex17or] has quit [Ping timeout: 244 seconds]
16:15 -!- instagibbs [~instagibb@119247204116.ctinets.com] has joined #bitcoin-core-dev
16:16 -!- hex17or [~hex17or@gateway/tor-sasl/hex17or] has joined #bitcoin-core-dev
16:16 < Bullit> recall listtransactions as a command from japan and return 8.533fractal bitcoin to 3KWmEuAXy8HauiZRhUJLVdn4eFKvoGCtap split Recall Protocol Controller invalid adress
16:17 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
16:26 -!- bomb-on [~bomb-on@194.144.47.113] has quit [Quit: aллилѹіа!]
16:29 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 250 seconds]
16:34 -!- VzxPLnHqr [VzxPLnHqr@gateway/vpn/protonvpn/vzxplnhqr] has joined #bitcoin-core-dev
16:45 -!- davterra [~davterra@143.198.56.186] has quit [Read error: Connection reset by peer]
16:45 -!- davterra [~davterra@143.198.56.186] has joined #bitcoin-core-dev
16:46 -!- hex17or [~hex17or@gateway/tor-sasl/hex17or] has quit [Ping timeout: 244 seconds]
16:48 -!- midnight [~midnight@user/midnight] has joined #bitcoin-core-dev
16:49 < midnight> Hello. Where are the gitian signers typically storing their pgp keys these days? Is there a keyserver you're uploading to..?
16:49 -!- hex17or [~hex17or@gateway/tor-sasl/hex17or] has joined #bitcoin-core-dev
17:04 -!- jesseposner [~jesse@c-24-4-88-184.hsd1.ca.comcast.net] has quit [Ping timeout: 268 seconds]
17:14 < midnight> .. because the sks servers are all dying due to storage spam and fake-key uploading and GDPR demands (surprisingly)
17:15 < fanquake> try https://keys.openpgp.org/
17:17 < midnight> \o ah, there is a keyserver still up is there. a couple of the keys in the gitian list aren't there either. I'll track them down meself.
17:18 < fanquake> there's also hkp://keyserver.ubuntu.com:80
17:18 < midnight> hrmm
17:32 < Bullit> No They never met it is all protocol speculation about the transmitting of hash keys probably related to the amount of interest in a value of 420k
17:58 < sipa> ... what?
18:14 -!- Yihen [~textual@103.138.75.117] has joined #bitcoin-core-dev
18:16 -!- gene [~gene@gateway/tor-sasl/gene] has joined #bitcoin-core-dev
18:51  * midnight shrugs-- beats me, I didn't understand it either, maybe someone got an old dada bot working
18:55 < midnight> 0.21.1 is when the signed windows bins were tossed out..? Good heavens, how far behind *am* I..
18:57 -!- gene [~gene@gateway/tor-sasl/gene] has quit [Quit: gene]
19:18 -!- NorrinRadd [~username@154.6.20.215] has quit [Ping timeout: 250 seconds]
19:20 -!- NorrinRadd [~username@154.6.20.210] has joined #bitcoin-core-dev
19:40 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
19:43 -!- prayank [~andr0irc@51.158.144.32] has joined #bitcoin-core-dev
19:48 -!- prayank [~andr0irc@51.158.144.32] has quit [Ping timeout: 240 seconds]
19:55 < achow101> midnight: nah, the windows signing key got revoked so we just published the unsigned bins. We have a new signing key so the next release will have windows signed bins
20:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:23 < bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/eb09c26724e3...3755dea3c502
20:23 < bitcoin-git> bitcoin/master 8733a8e Saibato: the result of CWallet::IsHDEnabled() was initialized with true.
20:23 < bitcoin-git> bitcoin/master 3755dea Samuel Dobson: Merge bitcoin/bitcoin#22781: wallet: fix the behavior of IsHDEnabled, retu...
20:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:23 < bitcoin-git> [bitcoin] meshcollider merged pull request #22781: wallet: fix the behavior of IsHDEnabled, return false in case of a blank hd wallet. (master...fix_ishdenabled) https://github.com/bitcoin/bitcoin/pull/22781
20:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:05 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
21:06 -!- NorrinRadd [~username@154.6.20.210] has quit [Ping timeout: 252 seconds]
21:08 -!- NorrinRadd [~username@102.67.16.112] has joined #bitcoin-core-dev
21:11 -!- Yihen [~textual@103.138.75.117] has quit [Remote host closed the connection]
21:34 -!- hex17or [~hex17or@gateway/tor-sasl/hex17or] has quit [Remote host closed the connection]
21:39 -!- hex17or [~hex17or@127.0.6.10] has joined #bitcoin-core-dev
21:57 -!- jesseposner [~jesse@c-24-4-88-184.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
21:59 -!- AaronvanW [~AaronvanW@190.150.30.183] has quit [Quit: Leaving...]
22:10 -!- babasancheti [~babasanch@43.249.232.30] has joined #bitcoin-core-dev
22:31 -!- NorrinRadd [~username@102.67.16.112] has quit [Ping timeout: 240 seconds]
22:34 -!- Pasha [~Cory@user/pasha] has quit [Ping timeout: 276 seconds]
22:34 -!- NorrinRadd [~username@102.67.16.112] has joined #bitcoin-core-dev
22:54 -!- NorrinRadd [~username@102.67.16.112] has quit [Ping timeout: 240 seconds]
23:27 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
23:28 -!- babasancheti [~babasanch@43.249.232.30] has quit [Quit: Client closed]
23:31 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has joined #bitcoin-core-dev
23:39 -!- hex17or [~hex17or@127.0.6.10] has quit [Changing host]
23:39 -!- hex17or [~hex17or@gateway/tor-sasl/hex17or] has joined #bitcoin-core-dev
23:51 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
23:53 -!- prayank [~andr0irc@51.15.9.205] has joined #bitcoin-core-dev
--- Log closed Wed Aug 25 00:00:48 2021