--- Log opened Fri Aug 27 00:00:50 2021
00:17 < michaelfolkson> ariard__: I think #22665 would benefit from your input. You've Concept ACKed #22698 but I and presumably others don't know if you'd also be happy with #22665
00:18 <@gribble> https://github.com/bitcoin/bitcoin/issues/22665 | policy/rbf: dont return "incorrect" replaceability status by darosior · Pull Request #22665 · bitcoin/bitcoin · GitHub
00:18 <@gribble> https://github.com/bitcoin/bitcoin/issues/22665 | policy/rbf: dont return "incorrect" replaceability status by darosior · Pull Request #22665 · bitcoin/bitcoin · GitHub
00:18 <@gribble> https://github.com/bitcoin/bitcoin/issues/22698 | Implement RBF inherited signaling and fix getmempoolentry returned bip125-replaceable status by mjdietzx · Pull Request #22698 · bitcoin/bitcoin · GitHub
00:18 -!- earnestly [~earnest@user/earnestly] has joined #bitcoin-core-dev
00:20 < michaelfolkson> ariard__: I agree on BIP vs code being case by case. If BIP logic is stronger we should go with BIP. If code logic is stronger we should go with code. I don't think we should blindly go with code because code automatically overrules BIP
00:26 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection]
00:27 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
00:34 < laanwj> "code overrules documentation" is a necessity for consensus code which is very hard to change, for policy it's less clear cut, though it still takes long to propagate changes
00:34 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Remote host closed the connection]
00:35 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
00:35 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
00:40 < michaelfolkson> laanwj: Agreed on consensus code. I wouldn't describe a BIP as (Core) documentation though. I would describe it as a standard.
00:43 < michaelfolkson> If the code and the Core documentation don't match you would just update the documentation. But presumably BIPs have got buy in from alternative implementations and today Lightning implementations etc
00:45 < michaelfolkson> So you might still update the BIP or create a new BIP if the code logic is superior (or too difficult to change) to the BIP logic. But it isn't just a Core issue
00:46 < michaelfolkson> That's my view anyway :)
00:54 < laanwj> sure, but there are no other mempool policy implementations in wide use, arguably a document that describes that is actually running in the wild has some use, apart from any function as standard
00:57 < laanwj> there's a lot of inertia involved in trying to change the implementation, if something gets merged it will take a long time before that version is widely spread on the network to be behavior other software can rely on, so in the meantime... it might as well be a new BIP
00:58 -!- Ananta-shesha [~pjetcetal@128-71-152-79.broadband.corbina.ru] has joined #bitcoin-core-dev
01:01 < laanwj> e.g. most straightforward would be to create a new diff-BIP that documents core's behavior and state that we implement that
01:03 < laanwj> then consider if we want to really implement BIP125 instead
01:05 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
01:19 -!- JackH [~laptop@ppp-3-99.leed-a-1.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev
01:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:19 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #22817: test: Avoid race after connect_nodes (master...2108-testRaceConnect) https://github.com/bitcoin/bitcoin/pull/22817
01:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:37 -!- JackH [~laptop@ppp-3-99.leed-a-1.dynamic.dsl.as9105.com] has quit [Ping timeout: 248 seconds]
01:46 -!- Henrik [~textual@84.212.107.177] has joined #bitcoin-core-dev
01:49 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 276 seconds]
01:59 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
02:03 -!- emcy [~emcy@user/emcy] has quit [Ping timeout: 250 seconds]
02:03 -!- JackH [~laptop@ppp-3-99.leed-a-1.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev
02:07 -!- klementtan [~textual@218.212.21.21] has quit [Quit: Textual IRC Client: www.textualapp.com]
02:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:07 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #20808: test: Run rpc_generateblock.py even with wallet disabled (master...iss20078) https://github.com/bitcoin/bitcoin/pull/20808
02:07 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:09 -!- Henrik [~textual@84.212.107.177] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
02:12 -!- emcy [~emcy@user/emcy] has joined #bitcoin-core-dev
02:20 -!- jonatack [~jonatack@user/jonatack] has quit [Quit: Client closed]
02:30 -!- JackH [~laptop@ppp-3-99.leed-a-1.dynamic.dsl.as9105.com] has quit [Ping timeout: 252 seconds]
02:31 < michaelfolkson> laanwj: I agree at least a comment/addendum on BIP125 saying that Core doesn't implement it in full is a good idea
02:33 < michaelfolkson> That inertia I guess is an argument for merging #22665 and then considering a rebased #22698
02:33 <@gribble> https://github.com/bitcoin/bitcoin/issues/22665 | policy/rbf: dont return "incorrect" replaceability status by darosior · Pull Request #22665 · bitcoin/bitcoin · GitHub
02:33 <@gribble> https://github.com/bitcoin/bitcoin/issues/22698 | Implement RBF inherited signaling and fix getmempoolentry returned bip125-replaceable status by mjdietzx · Pull Request #22698 · bitcoin/bitcoin · GitHub
02:45 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
02:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:47 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/19364c0ddf22...33707a2a8828
02:47 < bitcoin-git> bitcoin/master fa82f4e MarcoFalke: Remove unused MaybeSetAddrName
02:47 < bitcoin-git> bitcoin/master fa78657 MarcoFalke: Remove unused RecursiveMutex cs_addrName
02:47 < bitcoin-git> bitcoin/master fa9eade MarcoFalke: Remove GetAddrName
02:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:48 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #22782: Remove unused MaybeSetAddrName (master...2108-noMaybeSetAddrName) https://github.com/bitcoin/bitcoin/pull/22782
02:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:58 -!- Henrik [~textual@84.212.107.177] has joined #bitcoin-core-dev
03:03 -!- lkqwejhhgasdjhgn [~kljkljklk@p200300d46f3896005c3ecfb186ae7ec8.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
03:14 -!- Henrik [~textual@84.212.107.177] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
03:34 -!- Yihen [~textual@103.138.75.117] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
03:47 -!- vysn [~vysn@user/vysn] has quit [Quit: WeeChat 3.2]
03:54 -!- Henrik [~textual@84.212.107.177] has joined #bitcoin-core-dev
04:06 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has quit [Quit: Konversation terminated!]
04:11 -!- JackH [~laptop@80.225.173.99] has joined #bitcoin-core-dev
04:13 -!- Henrik [~textual@84.212.107.177] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
04:57 -!- prayank [~andr0irc@51.158.144.31] has joined #bitcoin-core-dev
05:03 -!- goatpig [~goat@h-94-254-2-155.A498.priv.bahnhof.se] has joined #bitcoin-core-dev
05:09 -!- prayank [~andr0irc@51.158.144.31] has quit [Read error: Connection reset by peer]
05:15 -!- Ananta-shesha is now known as ArcticVaultETMar
05:15 -!- ArcticVaultETMar is now known as ArcticVauETMarsH
05:15 -!- ArcticVauETMarsH is now known as ArcticVauMarsHel
05:15 -!- ArcticVauMarsHel is now known as ArcticVauMarsHPJ
05:15 -!- prayank [~andr0irc@51.158.144.31] has joined #bitcoin-core-dev
05:16 -!- ArcticVauMarsHPJ is now known as ArctVaultMarsHMP
05:16 -!- ArctVaultMarsHMP is now known as ArctVaulMarsHMPJ
05:22 -!- vnogueir- [~vnogueira@user/vnogueira] has joined #bitcoin-core-dev
05:23 -!- vnogueira [~vnogueira@user/vnogueira] has quit [Ping timeout: 276 seconds]
05:28 -!- suraj [~suraj@2409:4065:106:45c0:dd55:492:58e0:fb4f] has joined #bitcoin-core-dev
05:36 -!- prayank [~andr0irc@51.158.144.31] has quit [Ping timeout: 250 seconds]
05:44 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
05:50 < ariard__> michaelfolkson: Happy to review #22665, if you review a PR in LDK, next release should be productionish one and I'm late on few reviews there :)
05:50 <@gribble> https://github.com/bitcoin/bitcoin/issues/22665 | policy/rbf: dont return "incorrect" replaceability status by darosior · Pull Request #22665 · bitcoin/bitcoin · GitHub
05:50 -!- Henrik [~textual@84.212.107.177] has joined #bitcoin-core-dev
05:58 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
06:05 -!- Henrik [~textual@84.212.107.177] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
06:33 -!- aechu [~major@gateway/tor-sasl/major] has quit [Ping timeout: 276 seconds]
06:34 -!- aechu [~major@gateway/tor-sasl/major] has joined #bitcoin-core-dev
06:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:40 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #22818: test: Activate all regtest softforks at height 1, unless overridden (master...2108-regtestSoft) https://github.com/bitcoin/bitcoin/pull/22818
06:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:50 -!- vnogueira [~vnogueira@user/vnogueira] has joined #bitcoin-core-dev
06:51 -!- vnogueir- [~vnogueira@user/vnogueira] has quit [Ping timeout: 276 seconds]
06:52 -!- ArctVaulMarsHMPJ [~pjetcetal@128-71-152-79.broadband.corbina.ru] has quit [Quit: EXIT]
06:54 -!- dviola [~diego@user/dviola] has joined #bitcoin-core-dev
07:04 -!- suraj [~suraj@2409:4065:106:45c0:dd55:492:58e0:fb4f] has quit [Quit: Client closed]
07:06 -!- AaronvanW [~AaronvanW@190.86.109.168] has joined #bitcoin-core-dev
07:23 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 276 seconds]
07:24 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
07:52 -!- dviola [~diego@user/dviola] has quit [Ping timeout: 252 seconds]
08:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:00 < bitcoin-git> [bitcoin] hebasto opened pull request #22820: build, qt: Fix typo in QtInputSupport check (master...210827-input) https://github.com/bitcoin/bitcoin/pull/22820
08:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:08 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
08:16 -!- common [~common@096-033-221-075.res.spectrum.com] has quit [Ping timeout: 240 seconds]
08:19 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
08:21 -!- lkqwejhhgasdjhgn [~kljkljklk@p200300d46f3896005c3ecfb186ae7ec8.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!]
08:31 -!- raj_ [~raj_@103.77.139.179] has joined #bitcoin-core-dev
08:33 -!- raj [~raj_@103.77.139.233] has quit [Ping timeout: 248 seconds]
08:36 < michaelfolkson> ariard__: Haha I'll have a scratch around. Didn't know a major LDK release was on the horizon, don't let me distract you :)
09:24 -!- common [~common@096-033-221-075.res.spectrum.com] has joined #bitcoin-core-dev
09:52 -!- prayank [~andr0irc@51.15.0.88] has joined #bitcoin-core-dev
09:53 < yanmaani> What is Bitcoin Core's policy on refactors that are beneficial to downstream projects, but not directly useful for Bitcoin?
09:54 < yanmaani> Specifically, adding an additional SignTranaction(tx, sighash) method in CWallet, which works like the current SignTransaction(tx) method with fetching coins, but doesn't assume SIGHASH_DEFAULT.
09:54 < prayank> #proposedwalletmeetingtopic
09:55 < prayank> Not sure if this hashtag did anything
09:55 < michaelfolkson> You put the topic directly after the hashtag prayank
09:55 < prayank> lol okay
09:57 < prayank> #dontusewalletacrosschains
09:57 -!- b10c [uid500648@id-500648.charlton.irccloud.com] has joined #bitcoin-core-dev
09:58 < michaelfolkson> #proposedwalletmeetingtopic and then your topic :)
09:58 < michaelfolkson> e.g. #proposedwalletmeetingtopic Don't use wallet across chains
09:59 < prayank> #proposedwalletmeetingtopic wallet files should not be reused across chains
09:59 < yanmaani> Are they now?
10:00 < prayank> Yes
10:00 < yanmaani> What, across testnet and mainnet?
10:00 < sipa> what?
10:00 < prayank> Testnet wallet works in mainnet
10:00 < yanmaani> Yeah, but they're not reused, are they?
10:01 < sipa> they're in separate data directories
10:01 < yanmaani> i.e. bitcoin generates a new wallet if I go into testnet; I'd have to manually move my wallet to get it to reuse them
10:01 < prayank> Reused = Can be loaded and used
10:01 < prayank> Details: https://github.com/bitcoin/bitcoin/issues/22792
10:02 < sipa> ok, so they aren't reused, but it's not detected when you accidentally load the wrong one
10:02 < sipa> ?
10:02 < prayank> Yes
10:02 < michaelfolkson> yanmaani: Someone with more experience can answer your question but I'm almost certain they will say it is case by case basis. If it isn't harmful to Core, has benefits to downstream projects and can get sufficient review to warrant it being merged there's no reason why it can't get merged
10:02 < sipa> if it's only beneficial to downstream project, the getting sufficient review part may be hard
10:03 < yanmaani> sipa: It's on the order of 2-10 lines, so it's not a massive chunk of code
10:04 < sipa> best way would be to tr
10:04 < sipa> y
10:04 < michaelfolkson> I don't know what "not directly useful for Bitcoin" means. I'm assuming you mean not directly useful for Bitcoin Core users there
10:04 < yanmaani> michaelfolkson: nice
10:04 < sipa> that'll reach for more people than asking it here now
10:04 < sipa> *far
10:04 < yanmaani> michaelfolkson: yes, it would be dead code
10:04 < yanmaani> sipa: On the ML or github?
10:04 < sipa> yanmaani: open a PR
10:05 < sipa> there is no bitcoin core development ML
10:06 < yanmaani> sipa: thanks
10:07 < sipa> if it's dead code, i would NACK it
10:07 < sipa> unless there is a prospected need for it
10:08 < yanmaani> sipa: there's a need for it in downstream projects, but from the pov of bitcoin, it would be dead code.
10:09 < sipa> yanmaani: bitcoin core's reviewers won't care about that
10:09 < sipa> i suspect
10:09 < sipa> (and i wouldn't)
10:15 -!- jarthur [~jarthur@2603-8080-1540-002d-3d62-46ba-a48f-7c27.res6.spectrum.com] has joined #bitcoin-core-dev
10:16 < yanmaani> sipa: e.g. wouldn't want it?
10:18 < sipa> no
10:29 < prayank> michaelfolkson: Thanks for helping with the hashtag. So do we have any meeting today to discuss wallet issues? Wanted to confirm else this IRC app disconnects in between when I do other things and not looking at my phone
10:30 < michaelfolkson> prayank: I'm not sure what you are asking. As I said meeting at 19:00 UTC, in about 90 minutes
10:31 < prayank> Sorry I thought it's at 17:00. Will join later. Thanks.
10:31 -!- prayank [~andr0irc@51.15.0.88] has quit [Quit: irc thread exit]
10:43 -!- aitorjs [~aitorjs@184.76.76.188.dynamic.jazztel.es] has joined #bitcoin-core-dev
10:56 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
10:58 -!- Chris_Stewart_5 [~Chris_Ste@2600:1700:56ea:430:819:2125:77f7:e5ae] has quit [Ping timeout: 240 seconds]
11:06 < S3RK> #proposedwalletmeetingtopic automatically adding record to adress book to prevent #19856
11:06 <@gribble> https://github.com/bitcoin/bitcoin/issues/19856 | Some transactions are not shown in listtransactions output · Issue #19856 · bitcoin/bitcoin · GitHub
11:07 -!- bomb-on [~bomb-on@194.144.47.113] has joined #bitcoin-core-dev
11:23 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 252 seconds]
11:34 -!- belcher [~belcher@user/belcher] has joined #bitcoin-core-dev
12:00 -!- prayank [~andr0irc@51.158.144.31] has joined #bitcoin-core-dev
12:01 < achow101> #startmeeting
12:01 < core-meetingbot> Meeting started Fri Aug 27 19:01:34 2021 UTC.  The chair is achow101. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
12:01 < core-meetingbot> Available commands: action commands idea info link nick
12:01 < michaelfolkson> hi
12:01 < S3RK> hi
12:01 < achow101> #bitcoin-core-dev Wallet Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos nehan NicolasDorier paveljanik petertodd 
12:01 < achow101> phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild
12:01 < prayank> hi
12:02 < jarolrod> hi
12:02 < achow101> two proposed topics
12:02 < achow101> #topic wallet files should not be reused across chains (prayank)
12:02 < core-meetingbot> topic: wallet files should not be reused across chains (prayank)
12:03 < sipa> prayank: you have the floor
12:03 < prayank> I tried this PR
12:04 < prayank> https://github.com/bitcoin/bitcoin/pull/18554
12:04 < prayank> Which doesn't fix the issues
12:04 < prayank> So I was thinking if we can save this info in db
12:04 < prayank> If a wallet was created for testnet or mainnet or signet
12:05 < prayank> And check this to give error
12:05 < prayank> But this won't work for old wallets
12:05 < michaelfolkson> This is the context https://github.com/bitcoin/bitcoin/issues/16107
12:05 < S3RK> I remember there was a proposal to check best block record and compare genesis blocks
12:05 < sipa> that seems to be what 18554 is doing
12:06 < achow101> comparing bestblock only works if it is in the mainchain. If it's a stale block, and the wallet is loaded on a node that doesn't have it, it won't work
12:06 < prayank> Yes it does something with blocks which doesn't look the right approach or maybe we need to add more things in if statement
12:06 < sipa> prayank: if you tested that PR, and found it isn't doing what it is claimed, you should leave that as a review on the PR
12:06 < prayank> I commented in PR
12:07 < michaelfolkson> sipa: https://github.com/bitcoin/bitcoin/pull/18554#issuecomment-904808840
12:07 < sipa> i saw that
12:07 < sipa> but it doesn't say anything
12:08 < prayank> I will add more details in the comment
12:08 < michaelfolkson> I think prayank was possibly unsure why it wasn't fixing them
12:09 < prayank> Yeah I wasn't even sure if this is the only PR that is working to resolve this issue
12:09 < S3RK> achow101: how does rescan works in the case of stale bestblocked absent on the node?
12:09 < michaelfolkson> It appears this PR should be closed if it is taking a flawed approach
12:09 < achow101> S3RK: I think it rescans from genesis
12:11 < sipa> i see it's looking at the block locator record in the wallet
12:11 < sipa> i don't see why it would ever not work
12:11 < sipa> as the locator always includes the genesis block
12:11 < achow101> oh, it's a locator? I thought it was just the hash
12:12 < sipa> oh
12:12 < sipa> hmm
12:12 < sipa> WalletBatch batch(walletInstance->GetDatabase()); CBlockLocator locator; if (batch.ReadBestBlock(locator))
12:13 < sipa> what it's doing below seems overly complicated
12:13 < sipa> it can just compare the genesis
12:13 < S3RK> but there is no protection now, the code now just determines the point to rescan from
12:13 -!- commmon [~common@096-033-221-075.res.spectrum.com] has joined #bitcoin-core-dev
12:14 < achow101> sipa: is CBlockLocator guaranteed to have the genesis hash?
12:14 < michaelfolkson> sipa: Greg said genesis block isn't sufficient as altcoins share genesis blocks https://github.com/bitcoin/bitcoin/pull/14533#issuecomment-431645072
12:15 < sipa> achow101: yes
12:15 < sipa> michaelfolkson: oh, i see
12:15 -!- laptop [~laptop@ppp-2-125.leed-a-1.dynamic.dsl.as9105.com] has joined #bitcoin-core-dev
12:15 < sipa> though that's unnecessary if the concern is mixing testnet/mainnet
12:15 -!- laptop is now known as Guest67
12:16 < sipa> but fair, it's nicer if it can account for that too
12:16 < sipa> in any case, i don't think there is much to discuss here; comments can go on the PR
12:16 -!- common [~common@096-033-221-075.res.spectrum.com] has quit [Ping timeout: 252 seconds]
12:16 -!- JackH [~laptop@80.225.173.99] has quit [Ping timeout: 248 seconds]
12:17 < achow101> probably need to have a network magic record?
12:18 < achow101> in any case, I agree this can be discussed in the PR
12:18 < achow101> #topic automatically adding record to adress book to prevent #19856 (S3RK)
12:18 < core-meetingbot> topic: automatically adding record to adress book to prevent #19856 (S3RK)
12:18 <@gribble> https://github.com/bitcoin/bitcoin/issues/19856 | Some transactions are not shown in listtransactions output · Issue #19856 · bitcoin/bitcoin · GitHub
12:18 <@gribble> https://github.com/bitcoin/bitcoin/issues/19856 | Some transactions are not shown in listtransactions output · Issue #19856 · bitcoin/bitcoin · GitHub
12:19 < S3RK> descriptor wallets already contain magic afaik
12:19 < S3RK> yes. So there is a problem with miscategorizing self-to-self transactions as change
12:19 < S3RK> this leads to them missing from listtransactions
12:19 < S3RK> it affects cases when restoring wallets with missing metadata
12:19 < S3RK> or having same wallet loaded in parallel in two nodes
12:20 < S3RK> I created a prototype to fix that by automatically adding such addresses to address book
12:20 < S3RK> but I'm not sure that's a way to go
12:20 < achow101> send to self should already be in the address book because the address had to be requested
12:21 < S3RK> yes, but no in the cases I described
12:21 < achow101> the situations this bug occurs in are restored wallets and having another node loaded with the same wallet
12:22 < S3RK> even we discard the case with the same wallet loaded in two places
12:22 < S3RK> the case with restored wallet seems like a bug
12:23 < S3RK> I don't see many downsides to add such addresses automatically to the address book
12:23 < S3RK> or should I say any downsides
12:24 < achow101> IMO it's not a bug. I think if you are restoring a wallet, you can expect that some metadata will be missing, e.g. whether something is or is not change
12:24 < S3RK> whether it's a bug or not is secondary. It's a poor ux and we can reasonably fix that
12:25 < achow101> I don't mind if it isn't very invasive
12:25 < S3RK> I can't think of any downsides, but I may be missing something
12:26 < achow101> the only downside is if we want to change back to using a single key chain rather than a split for receive and change
12:26 < S3RK> the prototype is here https://github.com/S3RK/bitcoin/tree/fix_19856
12:27 < achow101> since afaict, you need the split in order to correctly determine whether an output is send to self or change
12:28 < S3RK> not exaclty, even without descriptors you can get it from keypool records
12:28 < achow101> only for legacy wallets
12:29 < S3RK> agree, one chain makes it much more complicated or even impossible
12:30 < achow101> in any case, if you open a PR, we can discuss further there
12:30 < S3RK> ok. I wasn't sure if it makes sense to invest more time. Will open a PR
12:31 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 276 seconds]
12:31 < achow101> any other topics to discuss?
12:31 < S3RK> I have a question
12:31 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
12:32 < S3RK> do you have any updates on the upgrading wallets to tr descriptors?
12:32 < achow101> No, I thought it might be something we should discuss at coredev
12:32 < S3RK> thumbs up
12:33 < michaelfolkson> +1
12:33 < michaelfolkson> Latest Twitch streams have been on multipath descriptors
12:33 -!- Guest67 [~laptop@ppp-2-125.leed-a-1.dynamic.dsl.as9105.com] has quit [Quit: Leaving]
12:33 < S3RK> there is a gist with topic ideas for coredev
12:34 < achow101> I'll comment on it (don't post that here)
12:34 < achow101> anything else?
12:34 < michaelfolkson> It hasn't clicked with me why multipath descriptors are important but I didn't do sufficient reading
12:34 < michaelfolkson> So let me do that first
12:34 < michaelfolkson> No nothing from me
12:34 < S3RK> one more small thing
12:35 < S3RK> I'm reviewing #22067
12:35 <@gribble> https://github.com/bitcoin/bitcoin/issues/22067 | Test and document a basic M-of-N multisig using descriptor wallets and PSBTs by mjdietzx · Pull Request #22067 · bitcoin/bitcoin · GitHub
12:35 < S3RK> and I wonder why can't we use one wallet for this multisig setup
12:36 < achow101> I think it's to demonstrate the use of combinepsbt
12:36 < achow101> and generally the passing around of PSBTs
12:36 < S3RK> no, I mean each participant have two wallets
12:36 < S3RK> one to signer and one watch-only multisig
12:36 < S3RK> can't we have both descriptors in one wallet?
12:37 < achow101> oh, pure watchonly can't be imported into a wallet with private keys
12:37 < S3RK> yes, but you can replace your xpub with xprv
12:38 -!- vnogueira [~vnogueira@user/vnogueira] has quit [Remote host closed the connection]
12:38 < achow101> sure
12:38 < achow101> that's something you can ask in the pr
12:38 < S3RK> will do. Just checking if I'm missing something obvious
12:39 < S3RK> that's all from me
12:39 -!- vnogueira [~vnogueira@user/vnogueira] has joined #bitcoin-core-dev
12:39 < achow101> anything else?
12:39 < S3RK> thank you for your time :) 
12:40 < michaelfolkson> Yeah thanks achow101
12:40 < achow101> #endmeeting
12:40 < core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
12:40 < core-meetingbot> Meeting ended Fri Aug 27 19:40:03 2021 UTC.  
12:40 < core-meetingbot> Minutes:        https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2021/bitcoin-core-dev.2021-08-27-19.01.moin.txt
12:46 < prayank> Thanks
12:46 < prayank> Everyone
12:46 -!- prayank [~andr0irc@51.158.144.31] has quit [Quit: irc thread exit]
13:01 -!- meshcollider [meshcollid@user/meshcollider] has quit [Ping timeout: 240 seconds]
13:08 -!- neha [~neha@41.213.196.104.bc.googleusercontent.com] has quit [Ping timeout: 240 seconds]
13:09 -!- neha [~neha@41.213.196.104.bc.googleusercontent.com] has joined #bitcoin-core-dev
13:12 -!- meshcollider [meshcollid@jujube.ircnow.org] has joined #bitcoin-core-dev
13:24 -!- belcher_ [~belcher@user/belcher] has joined #bitcoin-core-dev
13:25 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 248 seconds]
13:29 -!- belcher_ is now known as belcher
13:40 -!- dviola [~diego@189.7.68.223] has joined #bitcoin-core-dev
13:52 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:08 -!- raj_ [~raj_@103.77.139.179] has quit [Quit: Leaving]
14:18 -!- Aaronvan_ [~AaronvanW@190.86.109.168] has joined #bitcoin-core-dev
14:20 -!- AaronvanW [~AaronvanW@190.86.109.168] has quit [Ping timeout: 248 seconds]
14:22 -!- Chris_Stewart_5 [~Chris_Ste@2600:1700:56ea:430:7557:f4f8:b473:789c] has joined #bitcoin-core-dev
14:27 -!- Chris_Stewart_5 [~Chris_Ste@2600:1700:56ea:430:7557:f4f8:b473:789c] has quit [Ping timeout: 250 seconds]
14:41 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
14:44 -!- aitorjs [~aitorjs@184.76.76.188.dynamic.jazztel.es] has quit [Ping timeout: 248 seconds]
14:52 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
15:09 -!- roconnor [~roconnor@host-45-58-210-199.dyn.295.ca] has joined #bitcoin-core-dev
15:22 -!- prayank [~andr0irc@51.158.144.32] has joined #bitcoin-core-dev
15:23 < prayank> i2p celebrates its 20th year: https://geti2p.net/en/blog/post/2021/08/26/20-Years-of-I2P
15:23 < prayank> Bitcoin mentioned in the blog post
15:26 -!- Aaronvan_ is now known as AaronvanW
15:49 -!- meshcollider [meshcollid@jujube.ircnow.org] has quit [Changing host]
15:49 -!- meshcollider [meshcollid@user/meshcollider] has joined #bitcoin-core-dev
15:51 -!- Guest16 [~Guest16@c-8a49e655.02-208-73746f71.bbcust.telenor.se] has joined #bitcoin-core-dev
15:53 -!- Guest16 [~Guest16@c-8a49e655.02-208-73746f71.bbcust.telenor.se] has quit [Client Quit]
15:55 -!- piku [~piku@47.202.122.99] has quit [Quit: Leaving]
16:11 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 250 seconds]
16:22 -!- piku [~piku@47.202.122.99] has joined #bitcoin-core-dev
16:25 -!- vnogueira [~vnogueira@user/vnogueira] has quit [Remote host closed the connection]
16:25 -!- vnogueira [~vnogueira@user/vnogueira] has joined #bitcoin-core-dev
16:25 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net]
16:26 -!- luke-jr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
16:30 -!- piku [~piku@47.202.122.99] has quit [Quit: Leaving]
17:02 -!- bomb-on [~bomb-on@194.144.47.113] has quit [Quit: aллилѹіа!]
17:04 -!- prayank [~andr0irc@51.158.144.32] has quit [Quit: irc thread exit]
17:09 -!- AaronvanW [~AaronvanW@190.86.109.168] has quit [Remote host closed the connection]
17:16 -!- belcher_ [~belcher@user/belcher] has joined #bitcoin-core-dev
17:17 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 240 seconds]
17:28 -!- earnestly [~earnest@user/earnestly] has quit [Ping timeout: 240 seconds]
17:40 -!- AaronvanW [~AaronvanW@190.86.109.168] has joined #bitcoin-core-dev
17:40 -!- dviola [~diego@189.7.68.223] has quit [Ping timeout: 248 seconds]
18:10 -!- jarthur [~jarthur@2603-8080-1540-002d-3d62-46ba-a48f-7c27.res6.spectrum.com] has quit [Ping timeout: 250 seconds]
18:13 -!- jarthur [~jarthur@2603-8080-1540-002d-102c-5ed2-dfbe-d754.res6.spectrum.com] has joined #bitcoin-core-dev
18:14 -!- AaronvanW [~AaronvanW@190.86.109.168] has quit [Ping timeout: 240 seconds]
18:20 -!- brson [~brson@75-166-55-155.hlrn.qwest.net] has joined #bitcoin-core-dev
18:24 -!- brson [~brson@75-166-55-155.hlrn.qwest.net] has quit [Client Quit]
18:28 -!- b10c [uid500648@id-500648.charlton.irccloud.com] has quit [Quit: Connection closed for inactivity]
18:41 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
18:44 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
18:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
18:47 < bitcoin-git> [bitcoin] lsilva01 opened pull request #22822: doc: Add multisig tutorial (master...multisig_tutorial_doc) https://github.com/bitcoin/bitcoin/pull/22822
18:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
19:07 -!- hendi [sid489601@id-489601.tooting.irccloud.com] has quit [Ping timeout: 256 seconds]
19:10 -!- hendi [sid489601@id-489601.tooting.irccloud.com] has joined #bitcoin-core-dev
19:20 -!- dergoegge [sid453889@tooting.irccloud.com] has quit [Ping timeout: 248 seconds]
19:21 -!- jkczyz [sid419941@2001:67c:2f08:4::6:6865] has quit [Ping timeout: 240 seconds]
19:21 -!- dergoegge [sid453889@id-453889.tooting.irccloud.com] has joined #bitcoin-core-dev
19:25 -!- jkczyz [sid419941@id-419941.tooting.irccloud.com] has joined #bitcoin-core-dev
19:43 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
20:16 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
20:18 -!- AaronvanW [~AaronvanW@190.86.109.168] has joined #bitcoin-core-dev
20:36 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
20:37 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
20:44 -!- AaronvanW [~AaronvanW@190.86.109.168] has quit [Ping timeout: 252 seconds]
20:45 -!- OLDshoes [~jodie@host-24-138-51-57.public.eastlink.ca] has joined #bitcoin-core-dev
20:56 -!- bitdex_ [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
20:58 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Ping timeout: 276 seconds]
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:34 -!- jarthur [~jarthur@2603-8080-1540-002d-102c-5ed2-dfbe-d754.res6.spectrum.com] has quit [Ping timeout: 240 seconds]
21:40 -!- jarthur [~jarthur@2603-8080-1540-002d-185d-46f0-e096-0d5e.res6.spectrum.com] has joined #bitcoin-core-dev
22:00 -!- Netsplit *.net <-> *.split quits: jonatack
22:39 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
22:42 -!- AaronvanW [~AaronvanW@190.86.109.168] has joined #bitcoin-core-dev
22:51 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
23:14 -!- AaronvanW [~AaronvanW@190.86.109.168] has quit [Ping timeout: 250 seconds]
23:32 -!- belcher_ is now known as belcher
23:43 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
23:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:44 < bitcoin-git> [bitcoin] fanquake merged pull request #22810: [0.21] qt: Pre-0.21.2rc2 translations update (0.21...210826-0.21-tr) https://github.com/bitcoin/bitcoin/pull/22810
23:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:47 -!- saranshsharma [~saranshsh@2401:4900:4464:c090:c4a5:4e99:813b:c84] has joined #bitcoin-core-dev
23:52 -!- saranshsharma [~saranshsh@2401:4900:4464:c090:c4a5:4e99:813b:c84] has quit [Quit: Ping timeout (120 seconds)]
23:53 -!- saranshsharma [~saranshsh@2401:4900:4464:c090:c4a5:4e99:813b:c84] has joined #bitcoin-core-dev
23:54 < saranshsharma> I would like to understand this issue in bit clarity, I am thinking of helping on this issue could anyone here better probably share some insight or details to approach this... https://github.com/bitcoin/bitcoin/issues/22799
23:55 < saranshsharma> ```Auto-formatting and sanity checking the RPCExamples with RPCMan```
23:55 < fanquake> saranshsharma: MarcoFalke is the best person to talk to, and iirc currently has a number of related PRs open.
23:56 < saranshsharma> Number of related PRs how can I view them ?
23:58 < fanquake> https://github.com/bitcoin/bitcoin/pulls/MarcoFalke. Includes 22798 and 19262. There might actually be less open currently than I thought there were.
--- Log closed Sat Aug 28 00:00:51 2021