--- Log opened Thu Sep 02 00:00:56 2021
00:04 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has joined #bitcoin-core-dev
00:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:04 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/77e77e8544c7...6bf706a0560d
00:04 < bitcoin-git> bitcoin/master 97cea1a Antoine Poinsot: policy: unit test Segwit dust thresholds
00:04 < bitcoin-git> bitcoin/master 6bf706a MarcoFalke: Merge bitcoin/bitcoin#22846: policy: unit test Segwit dust thresholds
00:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:05 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #22846: policy: unit test Segwit dust thresholds (master...unit_test_getdustthreshold) https://github.com/bitcoin/bitcoin/pull/22846
00:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:15 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has joined #bitcoin-core-dev
00:24 -!- earnestly [~earnest@user/earnestly] has quit [Quit: WeeChat 3.2]
00:27 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
00:28 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 256 seconds]
00:29 -!- sipsorcery [~sipsorcer@37.228.225.67] has joined #bitcoin-core-dev
00:29 -!- b10c [uid500648@id-500648.charlton.irccloud.com] has joined #bitcoin-core-dev
00:36 -!- aechu [~major@gateway/tor-sasl/major] has quit [Ping timeout: 276 seconds]
00:40 -!- earnestly [~earnest@user/earnestly] has joined #bitcoin-core-dev
00:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:42 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #22860: test: Always clear reject reason in IsStandard tx test (master...2109-testRej) https://github.com/bitcoin/bitcoin/pull/22860
00:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:44 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6bf706a0560d...d6034e41226e
00:44 < bitcoin-git> bitcoin/master ae4ad1a fanquake: msvc: update bitcoin_config.h defines
00:44 < bitcoin-git> bitcoin/master d6034e4 fanquake: Merge bitcoin/bitcoin#22843: msvc: update bitcoin_config.h defines
00:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:44 < bitcoin-git> [bitcoin] fanquake merged pull request #22843: msvc: update bitcoin_config.h defines (master...update_msvc_bitcoin_configg) https://github.com/bitcoin/bitcoin/pull/22843
00:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:54 -!- lkqwejhhgasdjhgn [~kljkljklk@p200300d46f389600fe601e396c9efc18.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
00:58 -!- aechu [~major@gateway/tor-sasl/major] has joined #bitcoin-core-dev
01:00 -!- AaronvanW [~AaronvanW@190.242.161.186] has joined #bitcoin-core-dev
01:02 -!- Alina-malina [~Alina-mal@user/alina-malina] has joined #bitcoin-core-dev
01:04 -!- AaronvanW [~AaronvanW@190.242.161.186] has quit [Ping timeout: 252 seconds]
01:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:11 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d6034e41226e...245462b66ce3
01:11 < bitcoin-git> bitcoin/master ab9c342 fanquake: release: remove gitian
01:11 < bitcoin-git> bitcoin/master 245462b MarcoFalke: Merge bitcoin/bitcoin#22418: release: Remove gitian
01:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:11 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #22418: release: Remove gitian (master...remove_gitian) https://github.com/bitcoin/bitcoin/pull/22418
01:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:27 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #22861: test: Update test README and lint script (master...2109-testDoc) https://github.com/bitcoin/bitcoin/pull/22861
01:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:32 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 276 seconds]
01:38 -!- vnogueira [~vnogueira@user/vnogueira] has joined #bitcoin-core-dev
01:38 -!- vnogueir- [~vnogueira@user/vnogueira] has quit [Remote host closed the connection]
01:44 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has quit [Quit: Konversation terminated!]
02:01 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has joined #bitcoin-core-dev
02:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:27 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/245462b66ce3...b997dd211ecf
02:27 < bitcoin-git> bitcoin/master fa2e9de MarcoFalke: test: Check that non-signaling BIP125 tx can be replaced via parent
02:27 < bitcoin-git> bitcoin/master b997dd2 fanquake: Merge bitcoin/bitcoin#22809: test: Check that non-signaling BIP125 tx can ...
02:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:27 < bitcoin-git> [bitcoin] fanquake merged pull request #22809: test: Check that non-signaling BIP125 tx can be replaced via parent (master...2108-testTxReplace) https://github.com/bitcoin/bitcoin/pull/22809
02:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:33 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
02:43 -!- fch [~myname87@mob-5-90-227-40.net.vodafone.it] has joined #bitcoin-core-dev
02:46 -!- Alina-malina [~Alina-mal@user/alina-malina] has quit [Ping timeout: 252 seconds]
02:47 -!- Alina-malina [~Alina-mal@user/alina-malina] has joined #bitcoin-core-dev
03:04 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has quit [Ping timeout: 252 seconds]
03:04 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
03:06 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
03:16 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 276 seconds]
04:07 -!- yanmaani [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
04:20 -!- jespada [~jespada@90.254.245.194] has quit [Ping timeout: 252 seconds]
04:21 -!- jespada [~jespada@90.254.245.194] has joined #bitcoin-core-dev
04:24 -!- fch [~myname87@mob-5-90-227-40.net.vodafone.it] has quit [Ping timeout: 244 seconds]
04:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:45 < bitcoin-git> [bitcoin] darosior opened pull request #22863: policy: document dust threshold for Taproot outputs (master...dust_threshold_doc) https://github.com/bitcoin/bitcoin/pull/22863
04:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:45 < bitcoin-git> [bitcoin] darosior closed pull request #22779: policy: correct (lower) the dust threshold for Taproot outputs (master...taproot_dust_limit) https://github.com/bitcoin/bitcoin/pull/22779
04:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:14 -!- sipsorcery [~sipsorcer@37.228.225.67] has quit [Ping timeout: 244 seconds]
05:14 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
05:19 -!- Guest463 [~Guest4@103.98.238.25] has joined #bitcoin-core-dev
05:20 -!- Guest463 [~Guest4@103.98.238.25] has quit [Client Quit]
05:31 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has joined #bitcoin-core-dev
05:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:32 < bitcoin-git> [gui] Sjors opened pull request #416: gui: add RPC setting (master...2021/09/rpc_setting) https://github.com/bitcoin-core/gui/pull/416
05:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:48 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
06:11 -!- sugarpuff_ [sid92283@2001:67c:2f08:4::1:687b] has quit []
06:12 -!- sugarpuff_ [sid92283@id-92283.lymington.irccloud.com] has joined #bitcoin-core-dev
06:14 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection]
06:15 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
06:16 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection]
06:20 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
06:30 < jonatack> On the topic of addr monitoring... #22501 has 5 ACKs (and 5 re-ACKs or so after updating it for addr_rate_limited, too) if anyone is in the mood to merge it in...been running it since mid-July
06:30 <@gribble> https://github.com/bitcoin/bitcoin/issues/22501 | netinfo: display addr_{processed, rate_limited, relay_enabled} and relaytxes data by jonatack · Pull Request #22501 · bitcoin/bitcoin · GitHub
06:31 < jonatack> after updating it for *addr_relay_enabled
06:37 -!- vasild [~vd@user/vasild] has quit [Remote host closed the connection]
06:37 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
06:42 -!- vasild [~vd@user/vasild] has quit [Ping timeout: 276 seconds]
06:44 -!- AaronvanW [~AaronvanW@190.242.161.186] has joined #bitcoin-core-dev
06:49 -!- vasild [~vd@user/vasild] has joined #bitcoin-core-dev
06:55 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has quit [Quit: Konversation terminated!]
07:19 -!- goatpig [~goat@h-94-254-2-155.A498.priv.bahnhof.se] has joined #bitcoin-core-dev
07:24 < michaelfolkson> jonatack: Does seem ready to merge. Happy to test it and add another ACK if needed.
07:25 < michaelfolkson> What was the response to sipa's point? "I'm really not convinced these numbers are sufficiently important to turn into a new field, unless the expectation is that many more things will be added to it."
07:25 < michaelfolkson> https://github.com/bitcoin/bitcoin/pull/22501#issuecomment-884660105
07:25 < michaelfolkson> Oh I think you ditched those numbers
07:41 -!- schmidty [sid297174@id-297174.tooting.irccloud.com] has quit []
07:41 -!- schmidty [sid297174@id-297174.lymington.irccloud.com] has joined #bitcoin-core-dev
07:45 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
07:51 -!- hugohn [sid304114@id-304114.tooting.irccloud.com] has quit []
07:51 -!- hugohn [sid304114@id-304114.lymington.irccloud.com] has joined #bitcoin-core-dev
07:55 < laanwj> jonatack: looking at it
07:58 -!- homura [root@user/homura] has left #bitcoin-core-dev []
08:00 < jonatack> michaelfolkson: i read that comment as referring to adding an additional developer-oriented details level, which i agree with, but since i'm close to it from always having a terminal buffer open with it, i'm used to all the detail and wasn't sure if it was becoming hard to grok :)
08:00 -!- vnogueira [~vnogueira@user/vnogueira] has quit [Remote host closed the connection]
08:00 < jonatack> laanwj: thanks!
08:00 -!- vnogueira [~vnogueira@user/vnogueira] has joined #bitcoin-core-dev
08:01 < jonatack> michaelfolkson: *i agree with (sipa's comment)
08:03 < michaelfolkson> jonatack: Cool. Always hard to gauge the granularity of fields that people would use/appreciate :)
08:07 -!- jonatack [~jonatack@user/jonatack] has quit [Quit: Client closed]
08:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:13 < bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/b997dd211ecf...a70768d15964
08:13 < bitcoin-git> bitcoin/master 5eeea8e Jon Atack: Add addr_processed and addr_rate_limited stats to -netinfo
08:13 < bitcoin-git> bitcoin/master 0a9ee3a Jon Atack: Simplify a few conditionals in -netinfo
08:13 < bitcoin-git> bitcoin/master 3834e23 Jon Atack: Display peers in -netinfo that request we not relay transactions
08:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:13 < bitcoin-git> [bitcoin] laanwj merged pull request #22501: netinfo: display addr_{processed, rate_limited, relay_enabled} and relaytxes data (master...netinfo-addr-statistics) https://github.com/bitcoin/bitcoin/pull/22501
08:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:14 -!- vysn [~vysn@user/vysn] has quit [Quit: WeeChat 3.2]
08:15 -!- lkqwejhhgasdjhgn [~kljkljklk@p200300d46f389600fe601e396c9efc18.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!]
08:15 -!- amiti [sid373138@id-373138.tooting.irccloud.com] has quit []
08:16 -!- amiti [sid373138@id-373138.lymington.irccloud.com] has joined #bitcoin-core-dev
08:17 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
08:40 -!- grettke [~grettke@cpe-65-29-228-30.wi.res.rr.com] has joined #bitcoin-core-dev
08:44 -!- jonatack [~jonatack@user/jonatack] has quit [Quit: Client closed]
08:54 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 256 seconds]
08:59 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
09:03 -!- saranshsharma [~saranshsh@112.133.224.115] has joined #bitcoin-core-dev
09:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:06 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a70768d15964...dd097c42df73
09:06 < bitcoin-git> bitcoin/master ea98d9c Sebastian Falbesoner: rpc: fix/add missing RPCExamples for "Util" RPCs
09:06 < bitcoin-git> bitcoin/master dd097c4 MarcoFalke: Merge bitcoin/bitcoin#18448: rpc: fix/add missing RPCExamples for "Util" R...
09:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:06 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #18448: rpc: fix/add missing RPCExamples for "Util" RPCs (master...20200326-rpc-add-fix-rpcexamples-in-misc-category) https://github.com/bitcoin/bitcoin/pull/18448
09:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:23 -!- stick [sid403625@user/prusnak] has quit []
09:23 -!- stick [sid403625@user/prusnak] has joined #bitcoin-core-dev
09:28 -!- jkczyz [sid419941@id-419941.tooting.irccloud.com] has quit []
09:29 -!- jkczyz [sid419941@id-419941.lymington.irccloud.com] has joined #bitcoin-core-dev
09:43 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
09:44 -!- saranshsharma [~saranshsh@112.133.224.115] has quit [Remote host closed the connection]
09:49 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
09:53 -!- dergoegge [sid453889@id-453889.tooting.irccloud.com] has quit []
09:54 -!- dergoegge [sid453889@id-453889.lymington.irccloud.com] has joined #bitcoin-core-dev
09:55 < provoostenator> hebasto: the v22 release notes mention -natpmp,  but they  don'nt mention GUI support yet, which was also added
10:06 < hebasto> provoostenator: thanks, just double checking https://github.com/bitcoin-core/bitcoin-devwiki/wiki/22.0-Release-Notes-draft#gui right now
10:24 -!- jarthur [~jarthur@2603-8080-1540-002d-d4cb-19ad-9d54-b5c3.res6.spectrum.com] has joined #bitcoin-core-dev
10:25 -!- dongcarl [~dongcarl@96.224.58.144] has joined #bitcoin-core-dev
10:50 -!- saranshsharma [~saranshsh@112.133.224.115] has joined #bitcoin-core-dev
10:54 -!- saranshsharma [~saranshsh@112.133.224.115] has quit [Ping timeout: 244 seconds]
10:54 < jonatack> laanwj: mentioning as i may be late for the meeting, #22702 is out of WIP; perhaps add to high-priority
10:54 <@gribble> https://github.com/bitcoin/bitcoin/issues/22702 | Add allocator for node based containers by martinus · Pull Request #22702 · bitcoin/bitcoin · GitHub
10:57 -!- koolazer [~koo@user/koolazer] has joined #bitcoin-core-dev
11:08 -!- saranshsharma [~saranshsh@112.133.224.115] has joined #bitcoin-core-dev
11:12 -!- saranshsharma [~saranshsh@112.133.224.115] has quit [Ping timeout: 252 seconds]
11:13 -!- lightlike [~lightlike@user/lightlike] has joined #bitcoin-core-dev
11:19 -!- gene [~gene@gateway/tor-sasl/gene] has joined #bitcoin-core-dev
11:24 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 252 seconds]
11:45 -!- saranshsharma [~saranshsh@112.133.224.115] has joined #bitcoin-core-dev
11:49 -!- saranshsharma [~saranshsh@112.133.224.115] has quit [Ping timeout: 252 seconds]
11:51 < laanwj> jonatack: added
12:00 < laanwj> #startmeeting
12:00 < core-meetingbot> Meeting started Thu Sep  2 19:00:01 2021 UTC.  The chair is laanwj. Information about MeetBot at https://bitcoin.jonasschnelli.ch/ircmeetings.
12:00 < core-meetingbot> Available commands: action commands idea info link nick
12:00 < gene> hi
12:00 < kvaciral[m]> hi
12:00 < hebasto> hi
12:00 < laanwj> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard BlueMatt cfields Chris_Stewart_5 darosior digi_james dongcarl elichai2 emilengler fanquake fjahr gleb glozow gmaxwell gwillen hebasto instagibbs jamesob jarolrod jb55 jeremyrubin jl2012 jnewbery jonasschnelli jonatack jtimon kallewoof kanzure kvaciral laanwj lightlike luke-jr maaku marcofalke meshcollider michagogo moneyball morcos
12:00 < laanwj> nehan NicolasDorier paveljanik petertodd phantomcircuit promag provoostenator ryanofsky sdaftuar sipa vasild
12:00 < achow101> hi
12:00 < meshcollider> hi
12:00 < michaelfolkson> hi
12:01 < cfields> hi
12:01 < dongcarl> hi
12:01 < luke-jr> hi
12:01 < laanwj> there have been no topics proposed using #proposedmeetingtopic this week
12:01 < laanwj> any last minute ones people would like to discuss?
12:01 < larryruane> hi
12:02 < laanwj> how are we with 22.0? looks like rc3 is holding up quite well
12:02 < laanwj> or have people encountered regressions/bugs?
12:03 < kanzure> hi
12:03 < laanwj> or anything else that will make a rc4 necessary
12:03 < achow101> doesn't seem like it
12:03 < sipa> i haven't seen anything
12:03 < laanwj> fantastic
12:05 < laanwj> so maybe we can tag final this/next week, let's see
12:05 < laanwj> #topic High priority for review
12:05 < core-meetingbot> topic: High priority for review
12:05 < laanwj> https://github.com/bitcoin/bitcoin/projects/8 currently 7 blockers, 2 chasing concept ACK
12:05 < achow101> #17526 for me
12:06 <@gribble> https://github.com/bitcoin/bitcoin/issues/17526 | Use Single Random Draw In addition to knapsack as coin selection fallback by achow101 · Pull Request #17526 · bitcoin/bitcoin · GitHub
12:06 < laanwj> achow101: added
12:07 < laanwj> anything else to add/remove or that is (almost) ready for merge?
12:07 < glozow> could i get #22675 please?
12:07 <@gribble> https://github.com/bitcoin/bitcoin/issues/22675 | RBF move 2/3: extract RBF logic into policy/rbf by glozow · Pull Request #22675 · bitcoin/bitcoin · GitHub
12:07 < michaelfolkson> What's the latest on the build work for Minisketch? #21859
12:07 <@gribble> https://github.com/bitcoin/bitcoin/issues/21859 | Add minisketch subtree and integrate in build/test by sipa · Pull Request #21859 · bitcoin/bitcoin · GitHub
12:08 < laanwj> glozow: added!
12:08 < sipa> once https://github.com/sipa/minisketch/pull/45 is in (and possible other cleanups), i'll update 21859 to follow the approach suggested by cfields and fanquake 
12:09 < michaelfolkson> sipa: Cool
12:11 < laanwj> another urgent request for review (if we're going to tag final soonish) would be the 22.0 draft release notes: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/22.0-Release-Notes-draft
12:12 < sipa> laanwj: +1
12:13 < hebasto> ^^ working on it
12:13 < laanwj> any other PRs? or other topics?
12:13 < laanwj> hebasto: thanks
12:14 < laanwj> that was a short meeting again, thanks everyone for attending
12:15 < laanwj> #endmeeting
12:15 < core-meetingbot> topic: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt / http://gnusha.org/bitcoin-core-dev/proposedwalletmeetingtopics.txt
12:15 < core-meetingbot> Meeting ended Thu Sep  2 19:15:01 2021 UTC.  
12:15 < core-meetingbot> Minutes:        https://bitcoin.jonasschnelli.ch/ircmeetings/logs/bitcoin-core-dev/2021/bitcoin-core-dev.2021-09-02-19.00.moin.txt
12:15 < gene> been thinking about adding support for cbor RPC, should that idea be floated on the mailing list before starting work?
12:16 < hebasto> provoostenator: 22.0 draft release notes about added nat-pmp support matches a191e23b8e7f0e19fc0359825eb7ca0d47966fa9 commit
12:16 < hebasto> not sure how to mention it in the GUI section nicely
12:17 < sipa> gene: i'd suggest opening an issue, where you describe the advantages, what kind of changes would be required, etc...
12:17 < sipa> the ML would be inappropriate I think, as it's not a protocol issue
12:18 < gene> sipa: thanks, will work on a write-up, and open an issue
12:18 < laanwj> yes, it's not a ML issue, the RPC is specific to the bitcoin core implementation
12:19 < gene> laanwj: that makes sense, just wasn't sure since it would have implications for clients interacting with the core implementation
12:20 < laanwj> i personally don't see much chance that JSON will be replaced
12:20 < gene> right, not a replacement, an addition
12:20 -!- saranshsharma [~saranshsh@112.133.224.115] has joined #bitcoin-core-dev
12:20 < gene> basically mirroring current RPC on another port that accepts CBOR instead of JSON
12:21 -!- hendi [sid489601@id-489601.tooting.irccloud.com] has quit []
12:21 -!- hendi [sid489601@id-489601.lymington.irccloud.com] has joined #bitcoin-core-dev
12:21 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
12:21 < gene> mainly thinking of it as an advantage for mobile clients, and anyone developing IoT clients
12:24 < cfields> why not just put a proxy translator in the middle?
12:24 -!- saranshsharma [~saranshsh@112.133.224.115] has quit [Ping timeout: 252 seconds]
12:25 < gene> cfields: thought about doing that, too. writing a small rust program that takes in CBOR, translates to JSON, then passes to current RPC
12:25 < gene> will make sure to include that as an alternative in the issue write-up
12:27 < gene> the proxy has a number of advantages, like not adding more code (and thus attack surface, maintenance cost) to bitcoin core 
12:28 < gene> disadvantages would be users would need to install an additional program along with bitcoin core
12:29 < gene> plus the translation overhead, rather than calling into the RPC backend directly from deserialized CBOR
12:29 < glozow> laanwj: thank you for adding!
12:31 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
12:31 < laanwj> gene: what i think you need to specfically elaborate on is that, in the hypothetical case we'd add another interface in parallel to JSON, why CBOR specifically? why is it suited to software like this. e.g. it seems JSON is very well supported in mobile, almost everything uses some javascript kind of thing nowadays.
12:34 < gene> laanwj: ok, will make sure to cover those topics. briefly, CBOR has an RFC, and is becoming the de-facto protocol for data constrained devices. because of the smaller data footprint, it would save mobile/IoT users money on their data plans
12:34 < laanwj> also if it's meant for communication with *remote* clients, it must be tunneled over something else already, so the extra overhead of a proxy isn't that much i'd expect
12:35 < cfields> I dunno about cbor, but json can be deserialized from a stream in realtime. Assuming cbor has the same property, you could potentially multiplex the decode/encode for minimal latency.
12:35 < gene> right, the overhead saving would mostly be for remote clients
12:35 < laanwj> compressing JSON already helps a lot btw
12:36 < sipa> it appears CBOR actually has native support for 64-bit integers
12:36 < laanwj> before you do a lot of work-i fell into that trap once, coming up with some specific binary format for something, compressed JSON actually did slightly better :-)
12:36 < sipa> while JSON only has a rather abstractly defined "number" type
12:36 -!- Chris_Stewart_5 [~Chris_Ste@2600:1700:56ea:430:b902:ac7a:6af6:b21e] has quit [Ping timeout: 245 seconds]
12:37 -!- Chris_Stewart_5 [~Chris_Ste@2600:1700:56ea:430:bd83:2738:41c8:40f4] has joined #bitcoin-core-dev
12:37 < gene> laanwj: absolutely, that's why I wanted to float the idea before diving in too much deeper
12:37 < cfields> sipa: I've been struggling with this lately. Playing around with rewriting UniValue as a std::variant. The JSON number/string constraints are annoyingly vague.
12:38 < gene> sipa: CBOR also encodes binary data without the need for Base64 encoding, so passing around public keys and other binary data would be much more compact
12:38 < laanwj> sipa: that's a good thing at least, no longer the 'how do we represent monetary amounts' question
12:38 < cfields> s/vague/non-existent/, I guess.
12:39 < laanwj> that said, everything is adapted to how bitcoin core does things now
12:39 < laanwj> it was slightly different in 2012
12:39 < sipa> gene: yes, i assumed that'd be the main objective
12:41 < laanwj> compressing base64 gets pretty close to the original binary size
12:44 < jonatack> laanwj: thanks for adding the node allocator pull to hi-prio. WRT the release notes, the addr rate-limiting and some PRs seem to be missing, will re-check tomorrow morning. In terms of v22.0, there's a (maybe...or maybe not important) edge case I plan to check out tomorrow.
12:45 < gene> laanwj: can do a small implementation of a few RPC calls (trying to get a representative sample), and compare sizes between compressed CBOR and JSON encodings
12:51 < laanwj> gene: okay!
13:05 -!- saranshsharma [~saranshsh@112.133.224.115] has joined #bitcoin-core-dev
13:10 -!- saranshsharma [~saranshsh@112.133.224.115] has quit [Ping timeout: 245 seconds]
13:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:15 < bitcoin-git> [bitcoin] martinus closed pull request #22702: Add allocator for node based containers (master...2019-08-bulkpoolallocator) https://github.com/bitcoin/bitcoin/pull/22702
13:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:15 < bitcoin-git> [bitcoin] martinus reopened pull request #22702: Add allocator for node based containers (master...2019-08-bulkpoolallocator) https://github.com/bitcoin/bitcoin/pull/22702
13:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:50 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
13:56 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
13:59 -!- AaronvanW [~AaronvanW@190.242.161.186] has quit [Remote host closed the connection]
14:00 -!- common [~common@096-033-221-075.res.spectrum.com] has quit [Read error: Connection reset by peer]
14:00 -!- common [~common@096-033-221-075.res.spectrum.com] has joined #bitcoin-core-dev
14:08 -!- AaronvanW [~AaronvanW@190.242.161.186] has joined #bitcoin-core-dev
14:12 -!- AaronvanW [~AaronvanW@190.242.161.186] has quit [Ping timeout: 252 seconds]
14:17 -!- AaronvanW [~AaronvanW@190.242.161.186] has joined #bitcoin-core-dev
14:45 -!- gene [~gene@gateway/tor-sasl/gene] has quit [Quit: gene]
14:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:56 < bitcoin-git> [bitcoin] mjdietzx opened pull request #22867: Extend test coverage of BIP125 and document confusing/inconsistent behavior (master...test_bip125_edge_cases) https://github.com/bitcoin/bitcoin/pull/22867
14:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:04 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
15:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:18 < bitcoin-git> [bitcoin] promag opened pull request #22868: wallet: Call load handlers without cs_wallet locked (master...2021-09-wallet-load-lock) https://github.com/bitcoin/bitcoin/pull/22868
15:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:32 -!- bomb-on [~bomb-on@194.144.47.113] has joined #bitcoin-core-dev
15:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:42 < bitcoin-git> [gui] promag opened pull request #417: Ditch wallet model juggling (master...2021-09-eager-wallet-load-1) https://github.com/bitcoin-core/gui/pull/417
15:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:55 -!- lightlike [~lightlike@user/lightlike] has quit [Quit: Leaving]
15:58 -!- saranshsharma [~saranshsh@112.133.224.115] has joined #bitcoin-core-dev
16:02 -!- saranshsharma [~saranshsh@112.133.224.115] has quit [Ping timeout: 252 seconds]
16:13 < fanquake> laanwj: #22857 - although as I mention in the description, shouldn’t require an rc4
16:13 <@gribble> https://github.com/bitcoin/bitcoin/issues/22857 | [22.x] Backports by fanquake · Pull Request #22857 · bitcoin/bitcoin · GitHub
16:19 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 252 seconds]
16:20 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 240 seconds]
16:22 -!- jarthur [~jarthur@2603-8080-1540-002d-d4cb-19ad-9d54-b5c3.res6.spectrum.com] has quit [Ping timeout: 245 seconds]
16:27 -!- jarthur [~jarthur@2603-8080-1540-002d-fc65-cf54-436c-2f33.res6.spectrum.com] has joined #bitcoin-core-dev
16:28 -!- TallTim [~TallTim@184-83-248-206-dynamic.midco.net] has quit [Ping timeout: 240 seconds]
16:42 -!- jarthur [~jarthur@2603-8080-1540-002d-fc65-cf54-436c-2f33.res6.spectrum.com] has quit [Quit: jarthur]
16:43 -!- b10c [uid500648@id-500648.charlton.irccloud.com] has quit [Quit: Connection closed for inactivity]
16:44 -!- jarthur [~jarthur@2603-8080-1540-002d-fc65-cf54-436c-2f33.res6.spectrum.com] has joined #bitcoin-core-dev
16:53 -!- bomb-on [~bomb-on@194.144.47.113] has quit [Quit: aллилѹіа!]
17:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
17:03 < bitcoin-git> [bitcoin] JeremyRubin opened pull request #22870: [TESTS] Update Transaction Tests to permit setting a flag as always on and disabling the exhaustive failure test (master...update-txvalid-json) https://github.com/bitcoin/bitcoin/pull/22870
17:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
17:08 -!- jarthur [~jarthur@2603-8080-1540-002d-fc65-cf54-436c-2f33.res6.spectrum.com] has quit [Quit: jarthur]
17:09 -!- AaronvanW [~AaronvanW@190.242.161.186] has quit [Remote host closed the connection]
17:16 -!- AaronvanW [~AaronvanW@190.242.161.186] has joined #bitcoin-core-dev
17:19 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 244 seconds]
17:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
17:20 < bitcoin-git> [bitcoin] JeremyRubin opened pull request #22871: Discourage CSV as NOP when locktime disable is set (master...discourage-csv) https://github.com/bitcoin/bitcoin/pull/22871
17:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
17:21 -!- AaronvanW [~AaronvanW@190.242.161.186] has quit [Ping timeout: 244 seconds]
17:26 -!- saranshsharma [~saranshsh@112.133.224.115] has joined #bitcoin-core-dev
17:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
17:29 < bitcoin-git> [bitcoin] jonatack opened pull request #22872: log: improve checkaddrman logging with duration in milliseconds (master...improve-checkaddrman-logging) https://github.com/bitcoin/bitcoin/pull/22872
17:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
17:29 -!- earnestly [~earnest@user/earnestly] has quit [Ping timeout: 244 seconds]
17:31 -!- saranshsharma [~saranshsh@112.133.224.115] has quit [Ping timeout: 256 seconds]
17:31 -!- belcher [~belcher@user/belcher] has joined #bitcoin-core-dev
17:34 -!- AaronvanW [~AaronvanW@190.242.161.186] has joined #bitcoin-core-dev
17:39 -!- AaronvanW [~AaronvanW@190.242.161.186] has quit [Ping timeout: 252 seconds]
17:44 -!- AaronvanW [~AaronvanW@190.242.161.186] has joined #bitcoin-core-dev
18:00 -!- AaronvanW [~AaronvanW@190.242.161.186] has quit [Ping timeout: 252 seconds]
18:12 -!- AaronvanW [~AaronvanW@190.242.161.186] has joined #bitcoin-core-dev
18:37 -!- jarthur [~jarthur@cpe-70-114-198-37.austin.res.rr.com] has joined #bitcoin-core-dev
18:46 -!- AaronvanW [~AaronvanW@190.242.161.186] has quit [Ping timeout: 256 seconds]
19:00 -!- AaronvanW [~AaronvanW@190.242.161.186] has joined #bitcoin-core-dev
19:33 -!- AaronvanW [~AaronvanW@190.242.161.186] has quit [Ping timeout: 240 seconds]
19:48 -!- AaronvanW [~AaronvanW@190.242.161.186] has joined #bitcoin-core-dev
20:00 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has quit [Ping timeout: 240 seconds]
20:21 -!- dermoth_ [~dermoth@user/dermoth] has joined #bitcoin-core-dev
20:21 -!- dermoth [~dermoth@user/dermoth] has quit [Killed (NickServ (GHOST command used by dermoth_))]
20:21 -!- dermoth_ is now known as dermoth
20:21 -!- AaronvanW [~AaronvanW@190.242.161.186] has quit [Ping timeout: 252 seconds]
20:36 -!- AaronvanW [~AaronvanW@190.242.161.186] has joined #bitcoin-core-dev
20:38 -!- BUSY [~BUSY@user/busy] has joined #bitcoin-core-dev
21:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
21:00 < bitcoin-git> [bitcoin] JeremyRubin opened pull request #22875: Fix Racy ParseOpCode function initialization (master...threadsafe-fix) https://github.com/bitcoin/bitcoin/pull/22875
21:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:10 -!- AaronvanW [~AaronvanW@190.242.161.186] has quit [Ping timeout: 240 seconds]
21:24 -!- AaronvanW [~AaronvanW@190.242.161.186] has joined #bitcoin-core-dev
21:25 -!- saranshsharma [~saranshsh@112.133.224.115] has joined #bitcoin-core-dev
21:29 -!- saranshsharma [~saranshsh@112.133.224.115] has quit [Ping timeout: 252 seconds]
21:58 -!- AaronvanW [~AaronvanW@190.242.161.186] has quit [Ping timeout: 252 seconds]
22:12 -!- AaronvanW [~AaronvanW@190.242.161.186] has joined #bitcoin-core-dev
22:21 -!- saranshsharma [~saranshsh@112.133.224.115] has joined #bitcoin-core-dev
22:42 -!- goatpig [~goat@h-94-254-2-155.A498.priv.bahnhof.se] has quit [Quit: Konversation terminated!]
22:45 -!- vnogueira [~vnogueira@user/vnogueira] has quit [Ping timeout: 276 seconds]
22:46 -!- AaronvanW [~AaronvanW@190.242.161.186] has quit [Ping timeout: 252 seconds]
23:00 -!- jespada [~jespada@90.254.245.194] has quit [Ping timeout: 252 seconds]
23:01 -!- AaronvanW [~AaronvanW@190.242.161.186] has joined #bitcoin-core-dev
23:05 -!- jespada [~jespada@90.254.245.194] has joined #bitcoin-core-dev
23:07 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 256 seconds]
23:17 -!- vnogueira [~vnogueira@user/vnogueira] has joined #bitcoin-core-dev
23:21 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
23:30 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
23:34 -!- AaronvanW [~AaronvanW@190.242.161.186] has quit [Ping timeout: 244 seconds]
23:48 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has joined #bitcoin-core-dev
23:49 -!- AaronvanW [~AaronvanW@190.242.161.186] has joined #bitcoin-core-dev
23:57 -!- saranshsharma [~saranshsh@112.133.224.115] has quit [Remote host closed the connection]
--- Log closed Fri Sep 03 00:00:56 2021