--- Log opened Wed Sep 08 00:00:01 2021
00:01 -!- vnogueira [~vnogueira@user/vnogueira] has quit [Remote host closed the connection]
00:01 -!- vnogueira [~vnogueira@user/vnogueira] has joined #bitcoin-core-dev
00:08 -!- saranshsharma [~saranshsh@2401:4900:120c:8155:2c35:7671:4347:733b] has quit [Remote host closed the connection]
00:12 -!- saranshsharma [~saranshsh@112.133.224.115] has joined #bitcoin-core-dev
00:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:18 < bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ecf580e40f60...7d7d5e8efde9
00:18 < bitcoin-git> bitcoin/master facce4c MarcoFalke: test: Remove useless overwrite
00:18 < bitcoin-git> bitcoin/master fab0b55 MarcoFalke: addrman: Fix format string in deserialize error
00:18 < bitcoin-git> bitcoin/master 7d7d5e8 fanquake: Merge bitcoin/bitcoin#22879: addrman: Fix format string in deserialize err...
00:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:18 < bitcoin-git> [bitcoin] fanquake merged pull request #22879: addrman: Fix format string in deserialize error (master...2109-testPeersDat) https://github.com/bitcoin/bitcoin/pull/22879
00:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:22 -!- saranshsharma [~saranshsh@112.133.224.115] has quit [Remote host closed the connection]
00:27 < vasild> Is anybody running a CJDNS node?
00:32 -!- saranshsharma [~saranshsh@112.133.224.115] has joined #bitcoin-core-dev
00:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:35 < bitcoin-git> [bitcoin] fanquake opened pull request #22914: util: remove libevent <= 2.0.18 back-compat code (master...libevent_cleanup) https://github.com/bitcoin/bitcoin/pull/22914
00:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:37 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #22915: Remove confusing CAddrDB (master...2109-noAddrDb) https://github.com/bitcoin/bitcoin/pull/22915
00:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:39 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has quit [Quit: Konversation terminated!]
00:41 -!- lkqwejhhgasdjhgn [~kljkljklk@p200300d46f389600dda8b22aaea27669.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
00:44 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
00:52 -!- saranshsharma [~saranshsh@112.133.224.115] has quit [Remote host closed the connection]
00:58 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has joined #bitcoin-core-dev
01:14 -!- aechu [~major@gateway/tor-sasl/major] has quit [Ping timeout: 276 seconds]
01:14 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 276 seconds]
01:16 -!- aechu [~major@gateway/tor-sasl/major] has joined #bitcoin-core-dev
01:25 -!- earnestly [~earnest@user/earnestly] has joined #bitcoin-core-dev
01:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:29 < bitcoin-git> [bitcoin] fanquake opened pull request #22916: doc: add missing copyright header to getuniquepath.cpp (master...missing_copyright_header) https://github.com/bitcoin/bitcoin/pull/22916
01:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:44 -!- smartin [~Icedove@88.135.18.171] has joined #bitcoin-core-dev
01:49 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
01:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:58 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7d7d5e8efde9...5e3380b9f594
01:58 < bitcoin-git> bitcoin/master 69a439b fanquake: doc: add missing copyright header to getuniquepath.cpp
01:58 < bitcoin-git> bitcoin/master 5e3380b MarcoFalke: Merge bitcoin/bitcoin#22916: doc: add missing copyright header to getuniqu...
01:58 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:59 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #22916: doc: add missing copyright header to getuniquepath.cpp (master...missing_copyright_header) https://github.com/bitcoin/bitcoin/pull/22916
01:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:01 -!- Guest44 [~Guest44@122.97.78.46] has joined #bitcoin-core-dev
02:02 -!- Guest44 [~Guest44@122.97.78.46] has quit [Client Quit]
02:02 -!- kexkey [~kexkey@static-198-54-132-122.cust.tzulo.com] has quit [Ping timeout: 252 seconds]
02:05 -!- kexkey [~kexkey@static-198-54-132-90.cust.tzulo.com] has joined #bitcoin-core-dev
02:25 -!- belcher_ is now known as belcher
02:26 -!- saranshsharma [~saranshsh@112.133.224.115] has joined #bitcoin-core-dev
02:30 -!- saranshsharma [~saranshsh@112.133.224.115] has quit [Ping timeout: 260 seconds]
02:38 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
03:17 -!- saranshsharma [~saranshsh@112.133.224.115] has joined #bitcoin-core-dev
03:19 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has quit [Ping timeout: 252 seconds]
03:21 -!- saranshsharma [~saranshsh@112.133.224.115] has quit [Ping timeout: 265 seconds]
03:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:27 < bitcoin-git> [bitcoin] hebasto opened pull request #22917: build: Copy appropriate MSVC build output to src/qt automatically (master...210908-copy) https://github.com/bitcoin/bitcoin/pull/22917
03:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:27 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
03:32 -!- b10c [uid500648@id-500648.ilkley.irccloud.com] has joined #bitcoin-core-dev
03:37 < hebasto> MarcoFalke: should we in https://ci.appveyor.com/project/DrahtBot/bitcoin/settings check box "Skip branches without `appveyor.yml`" ?
03:40 < MarcoFalke> hebasto: Maybe. Currently I can't login
03:41 < MarcoFalke> I used up my rate limit to lock all historic pull requests to prevent spam
04:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:10 < bitcoin-git> [bitcoin] kiminuo opened pull request #22918: rpc: Add level 3 verbosity to getblock RPC call (#21245 modified) (master...feature/2021-09-verbose-level-3-for-getblock) https://github.com/bitcoin/bitcoin/pull/22918
04:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:17 < bitcoin-git> [bitcoin] fanquake closed pull request #21245: rpc: Add level 3 verbosity to getblock RPC call. (master...verbosity-level-3-getblock) https://github.com/bitcoin/bitcoin/pull/21245
04:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:18 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has joined #bitcoin-core-dev
04:30 -!- ArctVaulMarsHMPJ [~pjetcetal@2.95.102.85] has quit [Quit: EXIT]
04:32 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has quit [Quit: = ""]
04:57 -!- vysn [~vysn@user/vysn] has quit [Quit: WeeChat 3.2]
04:57 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
05:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:05 < bitcoin-git> [bitcoin] RohitRanjangit opened pull request #22919: fees: skip pointless fee parameter calculation during IBD (master...lazy_update) https://github.com/bitcoin/bitcoin/pull/22919
05:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:45 -!- copumpkin [~woohoo@user/copumpkin] has quit [Ping timeout: 252 seconds]
06:09 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 260 seconds]
06:15 -!- prayank [~andr0irc@51.158.144.31] has joined #bitcoin-core-dev
06:18 < prayank> debug=mempool -> debug.log -> replacing tx <original txid>
06:19 < prayank> Does removing this information from logs affect any functionality?
06:20 < sipa> no, it's a log...
06:20 < sipa> logs don't have functionality
06:20 < sipa> apart from logging what's going on
06:20 < laanwj> it affects the functionality of: being able to debug that functionality of the mempool by checking the logs
06:20 < prayank> I mean is someone using them and any projects depend on it?
06:21 < laanwj> i think you should start from the start, why do you want to remove it
06:21 < michaelfolkson> Debuggers rely on debug logs to locate bugs
06:21 < laanwj> exactly
06:21 < laanwj> it's troubleshooting information not more
06:22 < prayank> Privacy. I don't think others need to know about my replacement details. X replaced Y. This is not available on blockchain and a user who starts running node today won't be able to get it for past transactions. It's available for only wallet transactions using gettransaction.
06:23 < michaelfolkson> So don't share your debug log with anyone
06:23 < laanwj> there's a lot of debug functionality that can be enabled that is potentially privacy sensitive
06:23 < prayank> It's not something you control
06:23 < prayank> Debug logs are available for all running nodes
06:23 < laanwj> only if the 'mempool' flag is enabled in this case right
06:24 < laanwj> which you wouldn't enable unless you want to see mempool internals
06:24 < prayank> Okay let me rephrase my question
06:25 < laanwj> just be really careful with giving bitcoin debug logs to people, they're never "safe" from a privacy perspective, if possible only post a relevant excerpt and if you post to public forums, censor information you don't want known
06:25 < sipa> debug=net will list every network message received
06:25 < sipa> e.g.
06:25 < laanwj> there is nothing especially bad about this message in that regard?
06:25 < michaelfolkson> You don
06:25 < prayank> If we change "replacing tx <original txid>" to "replacing tx <>". Does this affect any debugging or any projects?
06:26 < laanwj> yes, it make it pointless
06:26 < michaelfolkson> Yes if someone is trying to debug a problem with RBF
06:26 < laanwj> the specific information is what you need to trace problems, why debug logging exists
06:27 < laanwj> say, if some specific transaction gets mis-handled, it is good to see when/what
06:28 < sipa> there may also be functional tests that rely on debug messages, though i'm not sure that's the case specifically for this one
06:28 < laanwj> yes
06:29 < sipa> in any case: if you don't want mempool details in your logs, don't enable mempool debug logs
06:30 < prayank> It's not about my logs. Others can see replacement done by me in their logs.
06:30 < laanwj> well it's public information
06:30 < sipa> ooh, now i understand
06:30 < sipa> well, yes, it's public information
06:33 < prayank> I wish we could remove it. Maybe I will experiment more with it and see if anything can be changed. I think this is similar to confidential transactions in which amounts are hidden which can affect verification of supply or other debugging.
06:33 < sipa> no
06:34 < sipa> in CT the information is secret
06:34 < laanwj> confidential transactions is completely different, it means peers *don't have* this information, so can't log it if they wanted, playing hide and seek with log messages is not going to make anyone more safe
06:35 < sipa> just because information isn't logged doesn't mean it isn't there; anyone who actually cares about it can still log it
06:35 -!- saranshsharma [~saranshsh@112.133.224.115] has joined #bitcoin-core-dev
06:38 < laanwj> yes; as far as we know, spy nodes do not generally run bitcoin core at all, or if they do, i'd expect them to use a heavily patched version that logs all kinds of extra stuff
06:40 -!- saranshsharma [~saranshsh@112.133.224.115] has quit [Ping timeout: 252 seconds]
06:40 -!- r-ush [~r-ush@52.187.184.81] has joined #bitcoin-core-dev
06:42 < laanwj> besides, it's an unencrypted P2P network, information about transaction propagation can be sniffed passively
06:45 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
06:45 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 260 seconds]
06:46 -!- Guyver2_ is now known as Guyver2
06:46 < laanwj> crippling our own debugging capability in any way for a false sense of privacy seems a bad trade-off
06:48 -!- vnogueira [~vnogueira@user/vnogueira] has quit [Remote host closed the connection]
06:53 -!- goatpig [~goat@blocksettle-gw.cust.31173.se] has quit [Quit: Konversation terminated!]
07:17 < laanwj> should we tag 22.0 final ?
07:18 -!- lucaferr [~lucaferr@c188-151-171-114.bredband.tele2.se] has joined #bitcoin-core-dev
07:19 -!- lucaferr [~lucaferr@c188-151-171-114.bredband.tele2.se] has quit [Client Quit]
07:19 -!- lucaferr [~lucaferr@c188-151-171-114.bredband.tele2.se] has joined #bitcoin-core-dev
07:21 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
07:22 < hebasto> everything looks done for 22.0 final
07:23 < laanwj> yes-just removed #22681 from the milestone, there's #22857 but I don't think it has anything critical that needs an extra rc, could just as well be 22.1 items?
07:23 <@gribble> https://github.com/bitcoin/bitcoin/issues/22681 | Manual page generation on master broken · Issue #22681 · bitcoin/bitcoin · GitHub
07:23 <@gribble> https://github.com/bitcoin/bitcoin/issues/22857 | [22.x] Backports by fanquake · Pull Request #22857 · bitcoin/bitcoin · GitHub
07:26 < lucaferr> I'm trying to find an example TapRoot keypath transaction in the test vectors linked from bip341. Any suggestions on how to find one?
07:27 < laanwj> although fanquake has a point that they could be merged without a rc, it's a doc change and a minor build system one
07:32 < laanwj> first things first, let's merge the release notes back from the wiki
07:35 < sipa> lucaferr: around half of them probably are
07:35 < lucaferr> @sipa: ah, ok.. A bit unsure on how to interpret the comment field
07:36 < lucaferr> I was hoping for one without annex or just as vanilla as possible
07:39 < sipa> lucaferr: easier to look at the generating code: https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_taproot.py
07:40 < lucaferr> will do, thanks
07:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:41 < bitcoin-git> [bitcoin] laanwj opened pull request #22920: doc: Move 22.0 release notes from wiki (22.x...2021-09-release-notes) https://github.com/bitcoin/bitcoin/pull/22920
07:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:04 -!- vnogueira [~vnogueira@user/vnogueira] has joined #bitcoin-core-dev
08:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:05 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to 22.x: https://github.com/bitcoin/bitcoin/compare/86de56776aae...fbf498d26bd2
08:05 < bitcoin-git> bitcoin/22.x d447972 W. J. van der Laan: doc: Move 22.0 release notes from wiki
08:05 < bitcoin-git> bitcoin/22.x fbf498d W. J. van der Laan: Merge bitcoin/bitcoin#22920: doc: Move 22.0 release notes from wiki
08:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:06 < bitcoin-git> [bitcoin] laanwj merged pull request #22920: doc: Move 22.0 release notes from wiki (22.x...2021-09-release-notes) https://github.com/bitcoin/bitcoin/pull/22920
08:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:15 -!- copumpkin [~woohoo@user/copumpkin] has joined #bitcoin-core-dev
08:17 < sipa> lucaferr: both the "sig/bitflip" cases in unit_test_data/script_assets_test.json are key path spends without annex
08:19 < lucaferr> sipa: thank you! that's very helpful
08:19 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has quit [Ping timeout: 265 seconds]
08:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:20 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to 22.x: https://github.com/bitcoin/bitcoin/compare/fbf498d26bd2...03f142278620
08:20 < bitcoin-git> bitcoin/22.x 0640bf5 Pieter Wuille: doc: mention bech32m/BIP350 in doc/descriptors.md
08:20 < bitcoin-git> bitcoin/22.x 303bc8a Carl Dong: guix/prelude: Override VERSION with FORCE_VERSION
08:20 < bitcoin-git> bitcoin/22.x 03f1422 W. J. van der Laan: Merge bitcoin/bitcoin#22857: [22.x] Backports
08:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:20 -!- rockhouse [~rockhouse@user/rockhouse] has quit [Remote host closed the connection]
08:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:20 < bitcoin-git> [bitcoin] laanwj merged pull request #22857: [22.x] Backports  (22.x...more_22_x_backports) https://github.com/bitcoin/bitcoin/pull/22857
08:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:21 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to 22.x: https://github.com/bitcoin/bitcoin/compare/03f142278620...f75615ebdda9
08:21 < bitcoin-git> bitcoin/22.x afbee40 W. J. van der Laan: build: Bump version to 22.0 final
08:21 < bitcoin-git> bitcoin/22.x f75615e W. J. van der Laan: doc: Manual pages update for 22.0 final
08:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:22 < laanwj> phew
08:22 -!- rockhouse [~rockhouse@user/rockhouse] has joined #bitcoin-core-dev
08:25 < sipa> i guess the switch to guix should be listed under build system changes in the release notes?
08:26 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has joined #bitcoin-core-dev
08:26 < sipa> ping dongcarl ?
08:27 < sipa> provoostenator: also, there is a release notes section for new RPCs, but the new external signer RPCs aren't listed under it
08:27 < sipa> in general, please read the release notes to see if things are missing
08:28 < laanwj> it would have been handier to do this when the release notes were still on the wiki
08:28 < laanwj> but yes
08:28 -!- lucaferr [~lucaferr@c188-151-171-114.bredband.tele2.se] has quit [Remote host closed the connection]
08:28 < sipa> laanwj: yes, agree
08:29 < laanwj> now I'm not sure whether to hold off tagging final for now, or for how long
08:29 < sipa> oh, ok
08:29 -!- jonatack [~jonatack@user/jonatack] has quit [Quit: Client closed]
08:31 < sipa> well let me PR a very short reference at least then
08:31 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
08:31 < laanwj> sure
08:32 < sipa> actually, these new RPCs are listed, but under the wallet section
08:32 < laanwj> that seems ok
08:32 < sipa> so i'll just remove the empty section, and mention it
08:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:37 < bitcoin-git> [bitcoin] sipa opened pull request #22921: Some small improvements to release notes (22.x...202109_22xrelease) https://github.com/bitcoin/bitcoin/pull/22921
08:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:38 < ryanofsky> achow101, just saw earlier WalletContext/CWallet question, replied https://github.com/bitcoin/bitcoin/pull/22183#issuecomment-915348120
08:47 -!- jarthur [~jarthur@2603-8080-1540-002d-b453-a897-4f94-54c0.res6.spectrum.com] has quit [Ping timeout: 252 seconds]
08:50 -!- jarthur [~jarthur@2603-8080-1540-002d-99ef-1e4e-a8ff-fad3.res6.spectrum.com] has joined #bitcoin-core-dev
08:53 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has quit [Ping timeout: 265 seconds]
08:57 -!- lkqwejhhgasdjhgn [~kljkljklk@p200300d46f389600dda8b22aaea27669.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!]
09:00 -!- prayank[m] [~prayankni@2001:470:69fc:105::ba63] has quit [Quit: You have been kicked for being idle]
09:00 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has joined #bitcoin-core-dev
09:12 -!- gleb7 [~gleb@178.150.137.228] has quit [Ping timeout: 245 seconds]
09:12 < achow101> ryanofsky: I see. The reason I asked is that #19602 currently makes new CWallets from within a CWallet. I'll try to rework that to not be a member function then.
09:12 <@gribble> https://github.com/bitcoin/bitcoin/issues/19602 | wallet: Migrate legacy wallets to descriptor wallets by achow101 · Pull Request #19602 · bitcoin/bitcoin · GitHub
09:20 -!- lightlike [~lightlike@user/lightlike] has joined #bitcoin-core-dev
09:24 < ryanofsky> I think the part of 19602 that makes new cwallets in a cwallet method looks fine. It's just the part that messes with the vpwallets array should be pulled out to the caller
09:24 < ryanofsky> i.e. CWallet::MigrateToDescriptor could simply return the new CWallets instead of adding them to ::vpwallets
09:25 -!- saranshsharma [~saranshsh@112.133.224.115] has joined #bitcoin-core-dev
09:27 -!- saranshsharma [~saranshsh@112.133.224.115] has quit [Remote host closed the connection]
09:28 -!- saranshsharma [~saranshsh@112.133.224.115] has joined #bitcoin-core-dev
09:39 -!- saranshsharma [~saranshsh@112.133.224.115] has quit [Remote host closed the connection]
09:42 -!- Talkless [~Talkless@mail.dargis.net] has joined #bitcoin-core-dev
09:48 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
09:50 < jonatack> sipa: feel free to ignore, but while you're there, i hesitated to add a release note about the addr rate limiting in "P2P and network changes" (and the additional getpeerinfo fields in "Updated RPCs")
09:52 < laanwj> sipa: something went wrong with your PR
09:54 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 276 seconds]
09:55 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
09:58 < sipa> jonatack: mentioning the new fields seems fine, that's standard practice
09:59 < sipa> laanwj: hmm, will fix soom
09:59 < laanwj> just briefly mentioning them is good, you don't actually need (or should) write documentation in the release notes
10:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:00 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #22922: ci: Fix and enable tests on Windows (master...2109-testWin) https://github.com/bitcoin/bitcoin/pull/22922
10:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:00 < jonatack> sipa: wondered if the omission was intentional :D  at any rate, no one is spamming addresses (per the rate limiting) to me any longer lately
10:01 -!- raj [~raj_@115.187.59.1] has joined #bitcoin-core-dev
10:03 < sipa> jonatack: oh good to hear, i hadn't paid too much attention to it lately
10:04 -!- JohnnyD [~JohnnyD@2605:a601:af6e:b800:111:47c9:4f75:56f5] has joined #bitcoin-core-dev
10:06 -!- JohnnyD [~JohnnyD@2605:a601:af6e:b800:111:47c9:4f75:56f5] has quit [Client Quit]
10:07 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 276 seconds]
10:07 -!- prayank [~andr0irc@51.158.144.31] has quit [Quit: irc thread exit]
10:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:09 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #22923: ci: Switch multiprocess to clang i686 build (master...2109-ciClang686) https://github.com/bitcoin/bitcoin/pull/22923
10:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:12 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has joined #bitcoin-core-dev
10:12 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has quit [Ping timeout: 265 seconds]
10:12 < sipa> laanwj: fixed; seems i just hadn't pulled in the latest upstream/22.x
10:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:12 < bitcoin-git> [bitcoin] mjdietzx opened pull request #22924: refactor: merge ScriptPubKeyToUniv and ScriptToUniv into a single function (master...refactor_ScriptToUniv) https://github.com/bitcoin/bitcoin/pull/22924
10:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:24 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 260 seconds]
10:24 -!- gleb7 [~gleb@178.150.137.228] has joined #bitcoin-core-dev
10:28 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
10:31 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has joined #bitcoin-core-dev
10:34 -!- AaronvanW [~AaronvanW@190.242.161.186] has joined #bitcoin-core-dev
10:37 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has quit [Ping timeout: 252 seconds]
10:38 < dongcarl> sipa: I will take a look at the branch right now, apologies I missed the release notes in the wiki stage
10:38 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has joined #bitcoin-core-dev
10:39 -!- cfields [~cfields@207.172.223.102] has quit [Changing host]
10:39 -!- cfields [~cfields@user/cfields] has joined #bitcoin-core-dev
10:46 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has quit [Ping timeout: 265 seconds]
10:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:46 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #22925: test: Add missing suppression signed-integer-overflow:addrman.cpp (master...2109-testSupFuzz) https://github.com/bitcoin/bitcoin/pull/22925
10:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:47 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has joined #bitcoin-core-dev
11:02 -!- vysn [~vysn@user/vysn] has quit [Quit: WeeChat 3.2]
11:08 -!- Guyver2_ [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
11:11 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 252 seconds]
11:11 -!- Guyver2_ is now known as Guyver2
11:12 -!- saranshsharma [~saranshsh@112.133.224.115] has joined #bitcoin-core-dev
11:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:16 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to 22.x: https://github.com/bitcoin/bitcoin/compare/f75615ebdda9...a0988140b714
11:16 < bitcoin-git> bitcoin/22.x 9f9ffe5 Pieter Wuille: Some small improvements to release notes
11:16 < bitcoin-git> bitcoin/22.x a098814 W. J. van der Laan: Merge bitcoin/bitcoin#22921: Some small improvements to release notes
11:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:16 -!- saranshsharma [~saranshsh@112.133.224.115] has quit [Ping timeout: 265 seconds]
11:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:17 < bitcoin-git> [bitcoin] laanwj merged pull request #22921: Some small improvements to release notes (22.x...202109_22xrelease) https://github.com/bitcoin/bitcoin/pull/22921
11:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:17 < dongcarl> Hmm, is there an IRC channel just for C++ questions?
11:17 < dongcarl> Can't seem to find any on libera
11:17 < sipa> #c++ ?
11:17 < sipa> (i haven't tried)
11:18 < sipa> but stackoverflow probably works
11:18 < dongcarl> oh dope that works
11:19 < sipa> i would advise against using dope to answer C++ questions
11:19 < dongcarl> 😬
11:22 -!- jonatack [~jonatack@user/jonatack] has quit [Quit: Client closed]
11:22 -!- vysn [~vysn@user/vysn] has joined #bitcoin-core-dev
11:23 < laanwj> it might help make undefined behavior more understandable
11:24 < dongcarl> XP
11:25 < shiza> C++ has no owner. Old days freenode would then have ##C++ as well...
11:26 < shiza> But yes everything is in StackOverflow already.
11:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:26 < bitcoin-git> [bitcoin] laanwj pushed tag v22.0: https://github.com/bitcoin/bitcoin/compare/v22.0
11:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:27 < hebasto> \o/
11:27 < achow101> \o/
11:27 < shiza> You can go ask StackOverflow and your question be closed.
11:27 < shiza> Congrats on the new release!
11:29 < laanwj> ^^
11:29 < dongcarl> hip hip hooray
11:59 -!- mxcl [~mxcl@ec2-34-238-66-213.compute-1.amazonaws.com] has quit [Quit: The Lounge - https://thelounge.chat]
11:59 < jamesob> does this mean it's time for another guix build?
11:59 < laanwj> jamesob: yep
12:02 -!- Talkless [~Talkless@mail.dargis.net] has quit [Quit: Konversation terminated!]
12:13 < stick> wohooo 22.0 \o/
12:17 < sipa> you take one up, pass it around, 22 cores of bitcoin on the wall
12:17 < sipa> i guess that doesn't roll off the tongue that well
12:18 < stick> 22 luftballons auf ihrem weg zum horizont :D
12:18 < laanwj> hehe
12:19 < b10c> \o/
12:24 < dodo> nice
12:25 < jb55> \o/ gj team
12:32 < cfields> :)
12:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:43 < bitcoin-git> [bitcoin] hebasto closed pull request #22917: build: Copy appropriate MSVC build output to src/qt automatically (master...210908-copy) https://github.com/bitcoin/bitcoin/pull/22917
12:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:44 -!- gleb7 [~gleb@178.150.137.228] has quit [Ping timeout: 265 seconds]
12:54 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
13:02 -!- Guyver2_ [~Guyver@2001:985:f3f:1:a12e:280:8f07:cc3a] has joined #bitcoin-core-dev
13:03 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has quit [Ping timeout: 265 seconds]
13:03 -!- Guyver2_ is now known as Guyver2
13:14 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has quit [Quit: Konversation terminated!]
13:28 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has joined #bitcoin-core-dev
13:29 -!- saranshsharma [~saranshsh@112.133.224.115] has joined #bitcoin-core-dev
13:34 -!- saranshsharma [~saranshsh@112.133.224.115] has quit [Ping timeout: 265 seconds]
13:39 < dongcarl> Wondering how our lock annotations interact with inheritance. Let's say I have "class A { virtual int foo() EXCLUSIVE_LOCK_REQUIRED(cs_a) = 0; }", and "class B { int foo() override EXCLUSIVE_LOCK_REQUIRED(cs_b) {  return 1 }; }", would calling B::foo lock both cs_a and cs_b?
13:43 -!- raj [~raj_@115.187.59.1] has quit [Quit: Leaving]
13:45 -!- smartin [~Icedove@88.135.18.171] has quit [Ping timeout: 252 seconds]
13:54 < dongcarl> s/lock both/require both/g
14:02 < jonatack> dongcarl: IDK, but you have me reading https://clang.llvm.org/docs/ThreadSafetyAnalysis.html now :)
14:09 < jonatack> https://clang.llvm.org/docs/ThreadSafetyAnalysis.html#lexical-scope
14:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:24 < bitcoin-git> [bitcoin] hebasto opened pull request #22926: doc: Set PYTHONUTF8=1 for functional tests on Windows (master...210908-utf) https://github.com/bitcoin/bitcoin/pull/22926
14:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:42 < emzy> \o/
14:48 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 260 seconds]
14:56 < cfields> dongcarl: I kinda doubt clang is smart enough to figure that out. It's very picky about requiring exact variables and iirc isn't able to follow copies or anything complicated...
14:56 < cfields> that said, it should be easy enough to whip up a quick test-case and see :)
14:57 < dongcarl> cfields: Yeah I did a quick test and you right
14:57 < dongcarl> It's a dumb mechanism, oh well
14:59 < cfields> dongcarl: could maybe use CRTP if static polymorphism is enough :)
14:59 -!- Guyver2 [~Guyver@2001:985:f3f:1:a12e:280:8f07:cc3a] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:59 < cfields> (assuming it could even figure out that much)
15:03 < dongcarl> Huh... Will read up on CRTP
15:14 -!- saranshsharma [~saranshsh@112.133.224.115] has joined #bitcoin-core-dev
15:15 -!- gene [~gene@gateway/tor-sasl/gene] has joined #bitcoin-core-dev
15:19 -!- saranshsharma [~saranshsh@112.133.224.115] has quit [Ping timeout: 265 seconds]
15:19 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has joined #bitcoin-core-dev
15:27 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has quit [Ping timeout: 252 seconds]
15:28 -!- yanmaani1 [~yanmaani@gateway/tor-sasl/yanmaani] has quit [Ping timeout: 276 seconds]
15:40 -!- bitdex [~bitdex@gateway/tor-sasl/bitdex] has joined #bitcoin-core-dev
15:55 -!- sipsorcery [~sipsorcer@2a02:8084:6180:500::12b] has quit [Ping timeout: 252 seconds]
16:05 -!- saranshsharma [~saranshsh@112.133.224.115] has joined #bitcoin-core-dev
16:10 -!- saranshsharma [~saranshsh@112.133.224.115] has quit [Ping timeout: 265 seconds]
16:19 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has joined #bitcoin-core-dev
16:34 -!- lightlike [~lightlike@user/lightlike] has quit [Quit: Leaving]
16:59 -!- jonatack [~jonatack@user/jonatack] has quit [Ping timeout: 256 seconds]
17:04 < meshcollider> \o/
17:06 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has quit [Ping timeout: 260 seconds]
17:10 -!- lukedashjr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
17:11 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 245 seconds]
17:11 -!- lukedashjr is now known as luke-jr
17:13 -!- jonatack [~jonatack@user/jonatack] has joined #bitcoin-core-dev
17:20 -!- earnestly [~earnest@user/earnestly] has quit [Ping timeout: 260 seconds]
17:20 -!- belcher [~belcher@user/belcher] has quit [Ping timeout: 252 seconds]
17:33 -!- belcher [~belcher@user/belcher] has joined #bitcoin-core-dev
17:46 -!- b10c [uid500648@id-500648.ilkley.irccloud.com] has quit [Quit: Connection closed for inactivity]
18:05 -!- saranshsharma [~saranshsh@112.133.224.115] has joined #bitcoin-core-dev
18:10 -!- saranshsharma [~saranshsh@112.133.224.115] has quit [Ping timeout: 265 seconds]
18:18 -!- ___nick___ [~quassel@cpc68286-cdif17-2-0-cust533.5-1.cable.virginm.net] has joined #bitcoin-core-dev
18:29 -!- vysn [~vysn@user/vysn] has quit [Ping timeout: 252 seconds]
18:57 -!- saranshsharma [~saranshsh@112.133.224.115] has joined #bitcoin-core-dev
19:01 -!- saranshsharma [~saranshsh@112.133.224.115] has quit [Ping timeout: 265 seconds]
19:11 -!- Yihen [~textual@103.138.75.117] has joined #bitcoin-core-dev
19:11 -!- gene [~gene@gateway/tor-sasl/gene] has quit [Quit: gene]
19:14 -!- saranshsharma [~saranshsh@112.133.224.115] has joined #bitcoin-core-dev
19:19 -!- saranshsharma [~saranshsh@112.133.224.115] has quit [Ping timeout: 260 seconds]
19:23 -!- lukedashjr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
19:25 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 260 seconds]
19:25 -!- lukedashjr is now known as luke-jr
19:48 -!- saranshsharma [~saranshsh@112.133.224.115] has joined #bitcoin-core-dev
19:52 -!- saranshsharma [~saranshsh@112.133.224.115] has quit [Ping timeout: 265 seconds]
20:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:34 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5e3380b9f594...da67b75c5cd7
20:34 < bitcoin-git> bitcoin/master fa57fa1 MarcoFalke: Enable clang-tidy bugprone-argument-comment and fix violations
20:34 < bitcoin-git> bitcoin/master da67b75 fanquake: Merge bitcoin/bitcoin#22903: Enable clang-tidy bugprone-argument-comment a...
20:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
20:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
20:34 < bitcoin-git> [bitcoin] fanquake merged pull request #22903: Enable clang-tidy bugprone-argument-comment and fix violations (master...2109-tidyNamedArgs) https://github.com/bitcoin/bitcoin/pull/22903
20:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
21:01 -!- cmirror [~cmirror@4.53.92.114] has quit [Remote host closed the connection]
21:01 -!- cmirror [~cmirror@4.53.92.114] has joined #bitcoin-core-dev
21:57 -!- AaronvanW [~AaronvanW@190.242.161.186] has quit [Quit: Leaving...]
22:04 -!- kexkey [~kexkey@static-198-54-132-90.cust.tzulo.com] has quit [Read error: Connection reset by peer]
22:04 -!- kexkey [~kexkey@static-198-54-132-90.cust.tzulo.com] has joined #bitcoin-core-dev
22:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
22:51 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/da67b75c5cd7...8805e0666318
22:51 < bitcoin-git> bitcoin/master fdd7144 fanquake: system: skip trying to set the locale on NetBSD
22:51 < bitcoin-git> bitcoin/master 8805e06 fanquake: Merge bitcoin/bitcoin#22390: system: skip trying to set the locale on NetB...
22:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
22:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
22:51 < bitcoin-git> [bitcoin] fanquake merged pull request #22390: system: skip trying to set the locale on NetBSD (master...netbsd_dont_set_locale) https://github.com/bitcoin/bitcoin/pull/22390
22:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
22:53 -!- saranshsharma [~saranshsh@112.133.224.115] has joined #bitcoin-core-dev
22:54 -!- saranshs_ [~saranshsh@106.207.41.200] has joined #bitcoin-core-dev
22:56 -!- saranshs_ [~saranshsh@106.207.41.200] has quit [Remote host closed the connection]
22:58 -!- saranshsharma [~saranshsh@112.133.224.115] has quit [Ping timeout: 265 seconds]
23:04 -!- saranshsharma [~saranshsh@112.133.224.115] has joined #bitcoin-core-dev
23:04 -!- Guyver2 [Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
23:08 -!- saranshsharma [~saranshsh@112.133.224.115] has quit [Ping timeout: 260 seconds]
23:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:10 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/8805e0666318...896649996bda
23:10 < bitcoin-git> bitcoin/master fa3f5d0 MarcoFalke: Move addrman includes from .h to .cpp
23:10 < bitcoin-git> bitcoin/master fa7f77b MarcoFalke: Fix addrdb includes
23:10 < bitcoin-git> bitcoin/master fade9a1 MarcoFalke: Remove confusing CAddrDB
23:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:11 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #22915: Remove confusing CAddrDB (master...2109-noAddrDb) https://github.com/bitcoin/bitcoin/pull/22915
23:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:14 -!- gnaf [~gnaf@86-91-224-60.opennet.kpn.net] has joined #bitcoin-core-dev
23:18 -!- saranshsharma [~saranshsh@112.133.224.115] has joined #bitcoin-core-dev
23:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:25 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/896649996bda...e4aa9b15b9f8
23:25 < bitcoin-git> bitcoin/master fadecbd MarcoFalke: test: Fix tests on Windows
23:25 < bitcoin-git> bitcoin/master fa0c194 MarcoFalke: cirrus: Enable tests on windows
23:25 < bitcoin-git> bitcoin/master e4aa9b1 MarcoFalke: Merge bitcoin/bitcoin#22922: ci: Fix and enable tests on Windows
23:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:25 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #22922: ci: Fix and enable tests on Windows (master...2109-testWin) https://github.com/bitcoin/bitcoin/pull/22922
23:25 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
23:26 < bitcoin-git> [bitcoin] kiminuo opened pull request #22928: Remove `gArgs` from `wallet.h` and `wallet.cpp` (2) (master...feature/2021-09-wallet-gArgs) https://github.com/bitcoin/bitcoin/pull/22928
23:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
23:27 -!- saranshsharma [~saranshsh@112.133.224.115] has quit [Ping timeout: 252 seconds]
23:35 -!- lukedashjr [~luke-jr@user/luke-jr] has joined #bitcoin-core-dev
23:35 -!- luke-jr [~luke-jr@user/luke-jr] has quit [Ping timeout: 265 seconds]
23:36 -!- lukedashjr is now known as luke-jr
23:45 -!- b10c [uid500648@id-500648.ilkley.irccloud.com] has joined #bitcoin-core-dev
23:56 -!- aechu [~major@gateway/tor-sasl/major] has quit [Remote host closed the connection]
--- Log closed Thu Sep 09 00:00:02 2021